{"action":"created","comment":{"url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/pulls/comments/172775989","pull_request_review_id":101848296,"id":172775989,"diff_hunk":"@@ -127,13 +127,34 @@ RevealWidget.prototype.readState = function() {\n \t\t\tthis.readMatchState(state);\n \t\t\tthis.isOpen = !this.isOpen;\n \t\t\tbreak;\n+\t\tcase \"lt\":\n+\t\t\tthis.readMatchStateltgt(state);\n+\t\t\tbreak;\n+\t\tcase \"gt\":\n+\t\t\tthis.readMatchStateltgt(state);\n+\t\t\tthis.isOpen = !this.isOpen;\n+\t\t\tbreak;\n+\t\tcase \"lteq\":\n+\t\t\tthis.readMatchStatelteq(state);\n+\t\t\tbreak;\n+\t\tcase \"gteq\":\n+\t\t\tthis.readMatchStategteq(state);\n+\t\t\tbreak;\n \t}\n };\n \n RevealWidget.prototype.readMatchState = function(state) {\n \tthis.isOpen = state === this.text;\n };\n-\n+RevealWidget.prototype.readMatchStateltgt = function(state) {\n+\tthis.isOpen = (parseInt(state, 10) < parseInt(this.text, 10))?true:false;","path":"core/modules/widgets/reveal.js","position":null,"original_position":25,"commit_id":"b11c715cf3fee110f9f37f7fb63446861b969e9c","original_commit_id":"0ccdd82e9c3682db464219dd3a0e027e80b2731a","user":{"login":"pmario","id":374655,"avatar_url":"https://avatars2.githubusercontent.com/u/374655?v=4","gravatar_id":"","url":"https://api.github.com/users/pmario","html_url":"https://github.com/pmario","followers_url":"https://api.github.com/users/pmario/followers","following_url":"https://api.github.com/users/pmario/following{/other_user}","gists_url":"https://api.github.com/users/pmario/gists{/gist_id}","starred_url":"https://api.github.com/users/pmario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmario/subscriptions","organizations_url":"https://api.github.com/users/pmario/orgs","repos_url":"https://api.github.com/users/pmario/repos","events_url":"https://api.github.com/users/pmario/events{/privacy}","received_events_url":"https://api.github.com/users/pmario/received_events","type":"User","site_admin":false},"body":"```\r\nparseInt(\"a\", 10) < parseInt(\"b\", 10)\r\n```\r\n\r\nReturns false and is logically wrong for users. ... So if we implement something like this, imo we have to have consistent behaviour. \r\n\r\nmatch \"a\" == \"a\"  works\r\nlt \"a\" < \"b\" doesn't \r\n\r\nIf we restrict the function to numbers, will make the code much simpler, imo we need to implement `eq` too. \r\nsame as `match` but with numbers, ... or ...\r\n\r\nwe need to implement all possible \"alpha numeric\" sorting mechanisms, which is a bit of a nightmare.","created_at":"2018-03-07T09:02:13Z","updated_at":"2018-03-07T09:02:13Z","html_url":"https://github.com/Jermolene/TiddlyWiki5/pull/3157#discussion_r172775989","pull_request_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/pulls/3157","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Jermolene/TiddlyWiki5/pulls/comments/172775989"},"html":{"href":"https://github.com/Jermolene/TiddlyWiki5/pull/3157#discussion_r172775989"},"pull_request":{"href":"https://api.github.com/repos/Jermolene/TiddlyWiki5/pulls/3157"}},"in_reply_to_id":172553085},"pull_request":{"url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/pulls/3157","id":173187114,"html_url":"https://github.com/Jermolene/TiddlyWiki5/pull/3157","diff_url":"https://github.com/Jermolene/TiddlyWiki5/pull/3157.diff","patch_url":"https://github.com/Jermolene/TiddlyWiki5/pull/3157.patch","issue_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/issues/3157","number":3157,"state":"open","locked":false,"title":"Adding comparative operators to reveal widget","user":{"login":"ibnishak","id":15052221,"avatar_url":"https://avatars1.githubusercontent.com/u/15052221?v=4","gravatar_id":"","url":"https://api.github.com/users/ibnishak","html_url":"https://github.com/ibnishak","followers_url":"https://api.github.com/users/ibnishak/followers","following_url":"https://api.github.com/users/ibnishak/following{/other_user}","gists_url":"https://api.github.com/users/ibnishak/gists{/gist_id}","starred_url":"https://api.github.com/users/ibnishak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibnishak/subscriptions","organizations_url":"https://api.github.com/users/ibnishak/orgs","repos_url":"https://api.github.com/users/ibnishak/repos","events_url":"https://api.github.com/users/ibnishak/events{/privacy}","received_events_url":"https://api.github.com/users/ibnishak/received_events","type":"User","site_admin":false},"body":">, <, >=, <=","created_at":"2018-03-06T15:13:07Z","updated_at":"2018-03-07T09:02:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8b6dc0883c0803958c12ad0f4b8d0c8a6fa91bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/pulls/3157/commits","review_comments_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/pulls/3157/comments","review_comment_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/issues/3157/comments","statuses_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/statuses/b11c715cf3fee110f9f37f7fb63446861b969e9c","head":{"label":"ibnishak:patch-1","ref":"patch-1","sha":"b11c715cf3fee110f9f37f7fb63446861b969e9c","user":{"login":"ibnishak","id":15052221,"avatar_url":"https://avatars1.githubusercontent.com/u/15052221?v=4","gravatar_id":"","url":"https://api.github.com/users/ibnishak","html_url":"https://github.com/ibnishak","followers_url":"https://api.github.com/users/ibnishak/followers","following_url":"https://api.github.com/users/ibnishak/following{/other_user}","gists_url":"https://api.github.com/users/ibnishak/gists{/gist_id}","starred_url":"https://api.github.com/users/ibnishak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibnishak/subscriptions","organizations_url":"https://api.github.com/users/ibnishak/orgs","repos_url":"https://api.github.com/users/ibnishak/repos","events_url":"https://api.github.com/users/ibnishak/events{/privacy}","received_events_url":"https://api.github.com/users/ibnishak/received_events","type":"User","site_admin":false},"repo":{"id":123416013,"name":"TiddlyWiki5","full_name":"ibnishak/TiddlyWiki5","owner":{"login":"ibnishak","id":15052221,"avatar_url":"https://avatars1.githubusercontent.com/u/15052221?v=4","gravatar_id":"","url":"https://api.github.com/users/ibnishak","html_url":"https://github.com/ibnishak","followers_url":"https://api.github.com/users/ibnishak/followers","following_url":"https://api.github.com/users/ibnishak/following{/other_user}","gists_url":"https://api.github.com/users/ibnishak/gists{/gist_id}","starred_url":"https://api.github.com/users/ibnishak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibnishak/subscriptions","organizations_url":"https://api.github.com/users/ibnishak/orgs","repos_url":"https://api.github.com/users/ibnishak/repos","events_url":"https://api.github.com/users/ibnishak/events{/privacy}","received_events_url":"https://api.github.com/users/ibnishak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ibnishak/TiddlyWiki5","description":"A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.","fork":true,"url":"https://api.github.com/repos/ibnishak/TiddlyWiki5","forks_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/forks","keys_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/teams","hooks_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/hooks","issue_events_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/issues/events{/number}","events_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/events","assignees_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/assignees{/user}","branches_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/branches{/branch}","tags_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/tags","blobs_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/statuses/{sha}","languages_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/languages","stargazers_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/stargazers","contributors_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/contributors","subscribers_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/subscribers","subscription_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/subscription","commits_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/contents/{+path}","compare_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/merges","archive_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/downloads","issues_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/issues{/number}","pulls_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/pulls{/number}","milestones_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/milestones{/number}","notifications_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/labels{/name}","releases_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/releases{/id}","deployments_url":"https://api.github.com/repos/ibnishak/TiddlyWiki5/deployments","created_at":"2018-03-01T09:55:40Z","updated_at":"2018-03-01T09:55:48Z","pushed_at":"2018-03-07T02:20:25Z","git_url":"git://github.com/ibnishak/TiddlyWiki5.git","ssh_url":"git@github.com:ibnishak/TiddlyWiki5.git","clone_url":"https://github.com/ibnishak/TiddlyWiki5.git","svn_url":"https://github.com/ibnishak/TiddlyWiki5","homepage":"https://tiddlywiki.com/","size":33381,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Jermolene:master","ref":"master","sha":"1a52fdd6266e70b3858875299fb996754b4fedac","user":{"login":"Jermolene","id":174761,"avatar_url":"https://avatars1.githubusercontent.com/u/174761?v=4","gravatar_id":"","url":"https://api.github.com/users/Jermolene","html_url":"https://github.com/Jermolene","followers_url":"https://api.github.com/users/Jermolene/followers","following_url":"https://api.github.com/users/Jermolene/following{/other_user}","gists_url":"https://api.github.com/users/Jermolene/gists{/gist_id}","starred_url":"https://api.github.com/users/Jermolene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jermolene/subscriptions","organizations_url":"https://api.github.com/users/Jermolene/orgs","repos_url":"https://api.github.com/users/Jermolene/repos","events_url":"https://api.github.com/users/Jermolene/events{/privacy}","received_events_url":"https://api.github.com/users/Jermolene/received_events","type":"User","site_admin":false},"repo":{"id":2828239,"name":"TiddlyWiki5","full_name":"Jermolene/TiddlyWiki5","owner":{"login":"Jermolene","id":174761,"avatar_url":"https://avatars1.githubusercontent.com/u/174761?v=4","gravatar_id":"","url":"https://api.github.com/users/Jermolene","html_url":"https://github.com/Jermolene","followers_url":"https://api.github.com/users/Jermolene/followers","following_url":"https://api.github.com/users/Jermolene/following{/other_user}","gists_url":"https://api.github.com/users/Jermolene/gists{/gist_id}","starred_url":"https://api.github.com/users/Jermolene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jermolene/subscriptions","organizations_url":"https://api.github.com/users/Jermolene/orgs","repos_url":"https://api.github.com/users/Jermolene/repos","events_url":"https://api.github.com/users/Jermolene/events{/privacy}","received_events_url":"https://api.github.com/users/Jermolene/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jermolene/TiddlyWiki5","description":"A self-contained JavaScript wiki for the browser, Node.js, AWS Lambda etc.","fork":false,"url":"https://api.github.com/repos/Jermolene/TiddlyWiki5","forks_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/forks","keys_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/teams","hooks_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/hooks","issue_events_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/issues/events{/number}","events_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/events","assignees_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/assignees{/user}","branches_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/branches{/branch}","tags_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/tags","blobs_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/statuses/{sha}","languages_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/languages","stargazers_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/stargazers","contributors_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/contributors","subscribers_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/subscribers","subscription_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/subscription","commits_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/contents/{+path}","compare_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/merges","archive_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/downloads","issues_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/issues{/number}","pulls_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/pulls{/number}","milestones_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/milestones{/number}","notifications_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/labels{/name}","releases_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/releases{/id}","deployments_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/deployments","created_at":"2011-11-22T14:26:07Z","updated_at":"2018-03-07T01:14:02Z","pushed_at":"2018-03-07T00:34:26Z","git_url":"git://github.com/Jermolene/TiddlyWiki5.git","ssh_url":"git@github.com:Jermolene/TiddlyWiki5.git","clone_url":"https://github.com/Jermolene/TiddlyWiki5.git","svn_url":"https://github.com/Jermolene/TiddlyWiki5","homepage":"https://tiddlywiki.com/","size":32854,"stargazers_count":3056,"watchers_count":3056,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":618,"mirror_url":null,"archived":false,"open_issues_count":760,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":618,"open_issues":760,"watchers":3056,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Jermolene/TiddlyWiki5/pulls/3157"},"html":{"href":"https://github.com/Jermolene/TiddlyWiki5/pull/3157"},"issue":{"href":"https://api.github.com/repos/Jermolene/TiddlyWiki5/issues/3157"},"comments":{"href":"https://api.github.com/repos/Jermolene/TiddlyWiki5/issues/3157/comments"},"review_comments":{"href":"https://api.github.com/repos/Jermolene/TiddlyWiki5/pulls/3157/comments"},"review_comment":{"href":"https://api.github.com/repos/Jermolene/TiddlyWiki5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Jermolene/TiddlyWiki5/pulls/3157/commits"},"statuses":{"href":"https://api.github.com/repos/Jermolene/TiddlyWiki5/statuses/b11c715cf3fee110f9f37f7fb63446861b969e9c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pmario"}}