{"action":"closed","number":434,"pull_request":{"url":"https://api.github.com/repos/inex/IXP-Manager/pulls/434","id":200637937,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjM3OTM3","html_url":"https://github.com/inex/IXP-Manager/pull/434","diff_url":"https://github.com/inex/IXP-Manager/pull/434.diff","patch_url":"https://github.com/inex/IXP-Manager/pull/434.patch","issue_url":"https://api.github.com/repos/inex/IXP-Manager/issues/434","number":434,"state":"closed","locked":false,"title":"[BF] - Cannot delete clients - fixes inex/IXP-Manager#433","user":{"login":"yannrobin","id":23074417,"node_id":"MDQ6VXNlcjIzMDc0NDE3","avatar_url":"https://avatars3.githubusercontent.com/u/23074417?v=4","gravatar_id":"","url":"https://api.github.com/users/yannrobin","html_url":"https://github.com/yannrobin","followers_url":"https://api.github.com/users/yannrobin/followers","following_url":"https://api.github.com/users/yannrobin/following{/other_user}","gists_url":"https://api.github.com/users/yannrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/yannrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannrobin/subscriptions","organizations_url":"https://api.github.com/users/yannrobin/orgs","repos_url":"https://api.github.com/users/yannrobin/repos","events_url":"https://api.github.com/users/yannrobin/events{/privacy}","received_events_url":"https://api.github.com/users/yannrobin/received_events","type":"User","site_admin":false},"body":"Cannot delete clients\r\n\r\nThe CSRF token was missing in the delete form.\r\n\r\nIn addition to the above, I have:\r\n\r\n - [x] ensured all relevant template output is escaped to avoid XSS attached with `<?= $t->ee( $data ) ?>` or equivalent.\r\n - [x] ensured appropriate checks against user privilege / resources accessed\r\n - [x] API calls (particular for add/edit/delete/toggle) are not implemented with GET and use CSRF tokens to avoid CSRF attacks\r\n  \r\n","created_at":"2018-07-11T09:25:50Z","updated_at":"2018-07-11T09:49:56Z","closed_at":"2018-07-11T09:49:56Z","merged_at":"2018-07-11T09:49:56Z","merge_commit_sha":"d023e786158de2aad1e70f0da65501442b181f0d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/inex/IXP-Manager/pulls/434/commits","review_comments_url":"https://api.github.com/repos/inex/IXP-Manager/pulls/434/comments","review_comment_url":"https://api.github.com/repos/inex/IXP-Manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inex/IXP-Manager/issues/434/comments","statuses_url":"https://api.github.com/repos/inex/IXP-Manager/statuses/8d3cf549cb610dcc95ec60a084ee4559b2a5c372","head":{"label":"inex:issue-433","ref":"issue-433","sha":"8d3cf549cb610dcc95ec60a084ee4559b2a5c372","user":{"login":"inex","id":804665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwNDY2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/804665?v=4","gravatar_id":"","url":"https://api.github.com/users/inex","html_url":"https://github.com/inex","followers_url":"https://api.github.com/users/inex/followers","following_url":"https://api.github.com/users/inex/following{/other_user}","gists_url":"https://api.github.com/users/inex/gists{/gist_id}","starred_url":"https://api.github.com/users/inex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inex/subscriptions","organizations_url":"https://api.github.com/users/inex/orgs","repos_url":"https://api.github.com/users/inex/repos","events_url":"https://api.github.com/users/inex/events{/privacy}","received_events_url":"https://api.github.com/users/inex/received_events","type":"Organization","site_admin":false},"repo":{"id":1794125,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk0MTI1","name":"IXP-Manager","full_name":"inex/IXP-Manager","owner":{"login":"inex","id":804665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwNDY2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/804665?v=4","gravatar_id":"","url":"https://api.github.com/users/inex","html_url":"https://github.com/inex","followers_url":"https://api.github.com/users/inex/followers","following_url":"https://api.github.com/users/inex/following{/other_user}","gists_url":"https://api.github.com/users/inex/gists{/gist_id}","starred_url":"https://api.github.com/users/inex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inex/subscriptions","organizations_url":"https://api.github.com/users/inex/orgs","repos_url":"https://api.github.com/users/inex/repos","events_url":"https://api.github.com/users/inex/events{/privacy}","received_events_url":"https://api.github.com/users/inex/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inex/IXP-Manager","description":"Full stack web application to manage Internet Exchange Points (IXPs)","fork":false,"url":"https://api.github.com/repos/inex/IXP-Manager","forks_url":"https://api.github.com/repos/inex/IXP-Manager/forks","keys_url":"https://api.github.com/repos/inex/IXP-Manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inex/IXP-Manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inex/IXP-Manager/teams","hooks_url":"https://api.github.com/repos/inex/IXP-Manager/hooks","issue_events_url":"https://api.github.com/repos/inex/IXP-Manager/issues/events{/number}","events_url":"https://api.github.com/repos/inex/IXP-Manager/events","assignees_url":"https://api.github.com/repos/inex/IXP-Manager/assignees{/user}","branches_url":"https://api.github.com/repos/inex/IXP-Manager/branches{/branch}","tags_url":"https://api.github.com/repos/inex/IXP-Manager/tags","blobs_url":"https://api.github.com/repos/inex/IXP-Manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inex/IXP-Manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inex/IXP-Manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/inex/IXP-Manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inex/IXP-Manager/statuses/{sha}","languages_url":"https://api.github.com/repos/inex/IXP-Manager/languages","stargazers_url":"https://api.github.com/repos/inex/IXP-Manager/stargazers","contributors_url":"https://api.github.com/repos/inex/IXP-Manager/contributors","subscribers_url":"https://api.github.com/repos/inex/IXP-Manager/subscribers","subscription_url":"https://api.github.com/repos/inex/IXP-Manager/subscription","commits_url":"https://api.github.com/repos/inex/IXP-Manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/inex/IXP-Manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/inex/IXP-Manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/inex/IXP-Manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/inex/IXP-Manager/contents/{+path}","compare_url":"https://api.github.com/repos/inex/IXP-Manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inex/IXP-Manager/merges","archive_url":"https://api.github.com/repos/inex/IXP-Manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inex/IXP-Manager/downloads","issues_url":"https://api.github.com/repos/inex/IXP-Manager/issues{/number}","pulls_url":"https://api.github.com/repos/inex/IXP-Manager/pulls{/number}","milestones_url":"https://api.github.com/repos/inex/IXP-Manager/milestones{/number}","notifications_url":"https://api.github.com/repos/inex/IXP-Manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inex/IXP-Manager/labels{/name}","releases_url":"https://api.github.com/repos/inex/IXP-Manager/releases{/id}","deployments_url":"https://api.github.com/repos/inex/IXP-Manager/deployments","created_at":"2011-05-24T15:36:58Z","updated_at":"2018-07-10T15:06:37Z","pushed_at":"2018-07-11T09:49:56Z","git_url":"git://github.com/inex/IXP-Manager.git","ssh_url":"git@github.com:inex/IXP-Manager.git","clone_url":"https://github.com/inex/IXP-Manager.git","svn_url":"https://github.com/inex/IXP-Manager","homepage":"http://www.ixpmanager.org/","size":29541,"stargazers_count":147,"watchers_count":147,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":103,"open_issues":42,"watchers":147,"default_branch":"master"}},"base":{"label":"inex:master","ref":"master","sha":"4a46db40eb4642a7bc296daf3d4203e2a376d89c","user":{"login":"inex","id":804665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwNDY2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/804665?v=4","gravatar_id":"","url":"https://api.github.com/users/inex","html_url":"https://github.com/inex","followers_url":"https://api.github.com/users/inex/followers","following_url":"https://api.github.com/users/inex/following{/other_user}","gists_url":"https://api.github.com/users/inex/gists{/gist_id}","starred_url":"https://api.github.com/users/inex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inex/subscriptions","organizations_url":"https://api.github.com/users/inex/orgs","repos_url":"https://api.github.com/users/inex/repos","events_url":"https://api.github.com/users/inex/events{/privacy}","received_events_url":"https://api.github.com/users/inex/received_events","type":"Organization","site_admin":false},"repo":{"id":1794125,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk0MTI1","name":"IXP-Manager","full_name":"inex/IXP-Manager","owner":{"login":"inex","id":804665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwNDY2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/804665?v=4","gravatar_id":"","url":"https://api.github.com/users/inex","html_url":"https://github.com/inex","followers_url":"https://api.github.com/users/inex/followers","following_url":"https://api.github.com/users/inex/following{/other_user}","gists_url":"https://api.github.com/users/inex/gists{/gist_id}","starred_url":"https://api.github.com/users/inex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inex/subscriptions","organizations_url":"https://api.github.com/users/inex/orgs","repos_url":"https://api.github.com/users/inex/repos","events_url":"https://api.github.com/users/inex/events{/privacy}","received_events_url":"https://api.github.com/users/inex/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inex/IXP-Manager","description":"Full stack web application to manage Internet Exchange Points (IXPs)","fork":false,"url":"https://api.github.com/repos/inex/IXP-Manager","forks_url":"https://api.github.com/repos/inex/IXP-Manager/forks","keys_url":"https://api.github.com/repos/inex/IXP-Manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inex/IXP-Manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inex/IXP-Manager/teams","hooks_url":"https://api.github.com/repos/inex/IXP-Manager/hooks","issue_events_url":"https://api.github.com/repos/inex/IXP-Manager/issues/events{/number}","events_url":"https://api.github.com/repos/inex/IXP-Manager/events","assignees_url":"https://api.github.com/repos/inex/IXP-Manager/assignees{/user}","branches_url":"https://api.github.com/repos/inex/IXP-Manager/branches{/branch}","tags_url":"https://api.github.com/repos/inex/IXP-Manager/tags","blobs_url":"https://api.github.com/repos/inex/IXP-Manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inex/IXP-Manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inex/IXP-Manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/inex/IXP-Manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inex/IXP-Manager/statuses/{sha}","languages_url":"https://api.github.com/repos/inex/IXP-Manager/languages","stargazers_url":"https://api.github.com/repos/inex/IXP-Manager/stargazers","contributors_url":"https://api.github.com/repos/inex/IXP-Manager/contributors","subscribers_url":"https://api.github.com/repos/inex/IXP-Manager/subscribers","subscription_url":"https://api.github.com/repos/inex/IXP-Manager/subscription","commits_url":"https://api.github.com/repos/inex/IXP-Manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/inex/IXP-Manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/inex/IXP-Manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/inex/IXP-Manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/inex/IXP-Manager/contents/{+path}","compare_url":"https://api.github.com/repos/inex/IXP-Manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inex/IXP-Manager/merges","archive_url":"https://api.github.com/repos/inex/IXP-Manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inex/IXP-Manager/downloads","issues_url":"https://api.github.com/repos/inex/IXP-Manager/issues{/number}","pulls_url":"https://api.github.com/repos/inex/IXP-Manager/pulls{/number}","milestones_url":"https://api.github.com/repos/inex/IXP-Manager/milestones{/number}","notifications_url":"https://api.github.com/repos/inex/IXP-Manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inex/IXP-Manager/labels{/name}","releases_url":"https://api.github.com/repos/inex/IXP-Manager/releases{/id}","deployments_url":"https://api.github.com/repos/inex/IXP-Manager/deployments","created_at":"2011-05-24T15:36:58Z","updated_at":"2018-07-10T15:06:37Z","pushed_at":"2018-07-11T09:49:56Z","git_url":"git://github.com/inex/IXP-Manager.git","ssh_url":"git@github.com:inex/IXP-Manager.git","clone_url":"https://github.com/inex/IXP-Manager.git","svn_url":"https://github.com/inex/IXP-Manager","homepage":"http://www.ixpmanager.org/","size":29541,"stargazers_count":147,"watchers_count":147,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":103,"open_issues":42,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inex/IXP-Manager/pulls/434"},"html":{"href":"https://github.com/inex/IXP-Manager/pull/434"},"issue":{"href":"https://api.github.com/repos/inex/IXP-Manager/issues/434"},"comments":{"href":"https://api.github.com/repos/inex/IXP-Manager/issues/434/comments"},"review_comments":{"href":"https://api.github.com/repos/inex/IXP-Manager/pulls/434/comments"},"review_comment":{"href":"https://api.github.com/repos/inex/IXP-Manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inex/IXP-Manager/pulls/434/commits"},"statuses":{"href":"https://api.github.com/repos/inex/IXP-Manager/statuses/8d3cf549cb610dcc95ec60a084ee4559b2a5c372"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"barryo","id":804649,"node_id":"MDQ6VXNlcjgwNDY0OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/804649?v=4","gravatar_id":"","url":"https://api.github.com/users/barryo","html_url":"https://github.com/barryo","followers_url":"https://api.github.com/users/barryo/followers","following_url":"https://api.github.com/users/barryo/following{/other_user}","gists_url":"https://api.github.com/users/barryo/gists{/gist_id}","starred_url":"https://api.github.com/users/barryo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barryo/subscriptions","organizations_url":"https://api.github.com/users/barryo/orgs","repos_url":"https://api.github.com/users/barryo/repos","events_url":"https://api.github.com/users/barryo/events{/privacy}","received_events_url":"https://api.github.com/users/barryo/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"barryo"}}