{"action":"created","issue":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/60934","repository_url":"https://api.github.com/repos/brianchandotcom/liferay-portal","labels_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/60934/labels{/name}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/60934/comments","events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/60934/events","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/60934","id":337169908,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDQ5NDEw","number":60934,"title":"CLDSVCS-3573 Change the JspBundleClassloader fallback to super in ord…","user":{"login":"shuyangzhou","id":173369,"node_id":"MDQ6VXNlcjE3MzM2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/173369?v=4","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-30T00:19:11Z","updated_at":"2018-06-30T00:19:19Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/60934","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/60934","diff_url":"https://github.com/brianchandotcom/liferay-portal/pull/60934.diff","patch_url":"https://github.com/brianchandotcom/liferay-portal/pull/60934.patch"},"body":"…er to cover incomplete jsp api usages bnd scanning.\r\n\r\nThis is a HIGH RISK fix.\r\n@jrhoun @jhendley please make the best to run through all the regression tests we have that is related to wab handling.\r\n\r\n@rotty3000 @mhan810 , this is not the best way to fix, or even the right way. However at this phase we really have no other choice. The real problem is inside JspAnalyzerPlugin. LCS used to work, because it was saved a bug that Neil fixed at dd20350ed020d24a74ce8552f3e29304319ec938 . And we can not go back to add the bug back, at that will expose incomplete portlet 3.0 to war wab bundle. It is JspAnalyzerPlugin that failed to scan through all the possible packages it needs at runtime. There is no time for us to update it to scan jsp better, so I am just allowing it delegating to super classloader. If QA can confirm no new regressions on this, let's just settle with it for this release, and revisit it later with a formal solution."},"comment":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/comments/401503486","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/60934#issuecomment-401503486","issue_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/60934","id":401503486,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTUwMzQ4Ng==","user":{"login":"shuyangzhou","id":173369,"node_id":"MDQ6VXNlcjE3MzM2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/173369?v=4","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"created_at":"2018-06-30T00:19:19Z","updated_at":"2018-06-30T00:19:19Z","author_association":"NONE","body":"ci:test"}}
{"actor":{"display_login":"shuyangzhou"}}