{"action":"closed","number":4565,"pull_request":{"url":"https://api.github.com/repos/keystonejs/keystone/pulls/4565","id":167124080,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY3MTI0MDgw","html_url":"https://github.com/keystonejs/keystone/pull/4565","diff_url":"https://github.com/keystonejs/keystone/pull/4565.diff","patch_url":"https://github.com/keystonejs/keystone/pull/4565.patch","issue_url":"https://api.github.com/repos/keystonejs/keystone/issues/4565","number":4565,"state":"closed","locked":false,"title":"Added session max age cookie to match keystone.uid cookie expiry","user":{"login":"millsy","id":983479,"node_id":"MDQ6VXNlcjk4MzQ3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/983479?v=4","gravatar_id":"","url":"https://api.github.com/users/millsy","html_url":"https://github.com/millsy","followers_url":"https://api.github.com/users/millsy/followers","following_url":"https://api.github.com/users/millsy/following{/other_user}","gists_url":"https://api.github.com/users/millsy/gists{/gist_id}","starred_url":"https://api.github.com/users/millsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/millsy/subscriptions","organizations_url":"https://api.github.com/users/millsy/orgs","repos_url":"https://api.github.com/users/millsy/repos","events_url":"https://api.github.com/users/millsy/events{/privacy}","received_events_url":"https://api.github.com/users/millsy/received_events","type":"User","site_admin":false},"body":"## Description of changes\r\nAdd the session max age cookie (defaults to name this.sid) to match the expiry of the keystone.uid cookie. This correctly then expires when the keystone.uid cookie expires forcing the user to need to re-authenticate.\r\n\r\n## Related issues (if any)\r\n\r\nAs described in Issue #4494 \r\n\r\n## Testing\r\n\r\nnpm test run-all doesn't work - fails on **npm test && npm run test-e2e-bg** but this occurred before the change was made, so it's likely my env causing build issues. \r\n\r\n","created_at":"2018-02-05T11:49:50Z","updated_at":"2018-07-07T01:32:53Z","closed_at":"2018-07-07T01:32:53Z","merged_at":null,"merge_commit_sha":"59e2d9dcef5fd67eb1f4d27f606331c69189e1c8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":946258580,"node_id":"MDU6TGFiZWw5NDYyNTg1ODA=","url":"https://api.github.com/repos/keystonejs/keystone/labels/4.0-release-candidate","name":"4.0-release-candidate","color":"d4c5f9","default":false},{"id":114332554,"node_id":"MDU6TGFiZWwxMTQzMzI1NTQ=","url":"https://api.github.com/repos/keystonejs/keystone/labels/needs%20review","name":"needs review","color":"cb137f","default":false},{"id":566359367,"node_id":"MDU6TGFiZWw1NjYzNTkzNjc=","url":"https://api.github.com/repos/keystonejs/keystone/labels/security","name":"security","color":"b60205","default":false}],"milestone":{"url":"https://api.github.com/repos/keystonejs/keystone/milestones/10","html_url":"https://github.com/keystonejs/keystone/milestone/10","labels_url":"https://api.github.com/repos/keystonejs/keystone/milestones/10/labels","id":3477810,"node_id":"MDk6TWlsZXN0b25lMzQ3NzgxMA==","number":10,"title":"v4.0.0-rc.2","description":"","creator":{"login":"stennie","id":15554,"node_id":"MDQ6VXNlcjE1NTU0","avatar_url":"https://avatars1.githubusercontent.com/u/15554?v=4","gravatar_id":"","url":"https://api.github.com/users/stennie","html_url":"https://github.com/stennie","followers_url":"https://api.github.com/users/stennie/followers","following_url":"https://api.github.com/users/stennie/following{/other_user}","gists_url":"https://api.github.com/users/stennie/gists{/gist_id}","starred_url":"https://api.github.com/users/stennie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stennie/subscriptions","organizations_url":"https://api.github.com/users/stennie/orgs","repos_url":"https://api.github.com/users/stennie/repos","events_url":"https://api.github.com/users/stennie/events{/privacy}","received_events_url":"https://api.github.com/users/stennie/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":1,"state":"open","created_at":"2018-07-06T08:57:01Z","updated_at":"2018-07-07T01:32:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/keystonejs/keystone/pulls/4565/commits","review_comments_url":"https://api.github.com/repos/keystonejs/keystone/pulls/4565/comments","review_comment_url":"https://api.github.com/repos/keystonejs/keystone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keystonejs/keystone/issues/4565/comments","statuses_url":"https://api.github.com/repos/keystonejs/keystone/statuses/7f973b8ec45548da536213a522c7aa54dbce67f3","head":{"label":"millsy:master","ref":"master","sha":"7f973b8ec45548da536213a522c7aa54dbce67f3","user":{"login":"millsy","id":983479,"node_id":"MDQ6VXNlcjk4MzQ3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/983479?v=4","gravatar_id":"","url":"https://api.github.com/users/millsy","html_url":"https://github.com/millsy","followers_url":"https://api.github.com/users/millsy/followers","following_url":"https://api.github.com/users/millsy/following{/other_user}","gists_url":"https://api.github.com/users/millsy/gists{/gist_id}","starred_url":"https://api.github.com/users/millsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/millsy/subscriptions","organizations_url":"https://api.github.com/users/millsy/orgs","repos_url":"https://api.github.com/users/millsy/repos","events_url":"https://api.github.com/users/millsy/events{/privacy}","received_events_url":"https://api.github.com/users/millsy/received_events","type":"User","site_admin":false},"repo":{"id":45551456,"node_id":"MDEwOlJlcG9zaXRvcnk0NTU1MTQ1Ng==","name":"keystone","full_name":"millsy/keystone","owner":{"login":"millsy","id":983479,"node_id":"MDQ6VXNlcjk4MzQ3OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/983479?v=4","gravatar_id":"","url":"https://api.github.com/users/millsy","html_url":"https://github.com/millsy","followers_url":"https://api.github.com/users/millsy/followers","following_url":"https://api.github.com/users/millsy/following{/other_user}","gists_url":"https://api.github.com/users/millsy/gists{/gist_id}","starred_url":"https://api.github.com/users/millsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/millsy/subscriptions","organizations_url":"https://api.github.com/users/millsy/orgs","repos_url":"https://api.github.com/users/millsy/repos","events_url":"https://api.github.com/users/millsy/events{/privacy}","received_events_url":"https://api.github.com/users/millsy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/millsy/keystone","description":"node.js cms and web app framework","fork":true,"url":"https://api.github.com/repos/millsy/keystone","forks_url":"https://api.github.com/repos/millsy/keystone/forks","keys_url":"https://api.github.com/repos/millsy/keystone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/millsy/keystone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/millsy/keystone/teams","hooks_url":"https://api.github.com/repos/millsy/keystone/hooks","issue_events_url":"https://api.github.com/repos/millsy/keystone/issues/events{/number}","events_url":"https://api.github.com/repos/millsy/keystone/events","assignees_url":"https://api.github.com/repos/millsy/keystone/assignees{/user}","branches_url":"https://api.github.com/repos/millsy/keystone/branches{/branch}","tags_url":"https://api.github.com/repos/millsy/keystone/tags","blobs_url":"https://api.github.com/repos/millsy/keystone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/millsy/keystone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/millsy/keystone/git/refs{/sha}","trees_url":"https://api.github.com/repos/millsy/keystone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/millsy/keystone/statuses/{sha}","languages_url":"https://api.github.com/repos/millsy/keystone/languages","stargazers_url":"https://api.github.com/repos/millsy/keystone/stargazers","contributors_url":"https://api.github.com/repos/millsy/keystone/contributors","subscribers_url":"https://api.github.com/repos/millsy/keystone/subscribers","subscription_url":"https://api.github.com/repos/millsy/keystone/subscription","commits_url":"https://api.github.com/repos/millsy/keystone/commits{/sha}","git_commits_url":"https://api.github.com/repos/millsy/keystone/git/commits{/sha}","comments_url":"https://api.github.com/repos/millsy/keystone/comments{/number}","issue_comment_url":"https://api.github.com/repos/millsy/keystone/issues/comments{/number}","contents_url":"https://api.github.com/repos/millsy/keystone/contents/{+path}","compare_url":"https://api.github.com/repos/millsy/keystone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/millsy/keystone/merges","archive_url":"https://api.github.com/repos/millsy/keystone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/millsy/keystone/downloads","issues_url":"https://api.github.com/repos/millsy/keystone/issues{/number}","pulls_url":"https://api.github.com/repos/millsy/keystone/pulls{/number}","milestones_url":"https://api.github.com/repos/millsy/keystone/milestones{/number}","notifications_url":"https://api.github.com/repos/millsy/keystone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/millsy/keystone/labels{/name}","releases_url":"https://api.github.com/repos/millsy/keystone/releases{/id}","deployments_url":"https://api.github.com/repos/millsy/keystone/deployments","created_at":"2015-11-04T16:21:55Z","updated_at":"2018-04-25T06:22:33Z","pushed_at":"2018-04-25T06:22:28Z","git_url":"git://github.com/millsy/keystone.git","ssh_url":"git@github.com:millsy/keystone.git","clone_url":"https://github.com/millsy/keystone.git","svn_url":"https://github.com/millsy/keystone","homepage":"http://www.keystonejs.com","size":147534,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"keystonejs:master","ref":"master","sha":"ce14c517cbb748c3d7c2fc0580974e57c8f914dc","user":{"login":"keystonejs","id":6118534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMTg1MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6118534?v=4","gravatar_id":"","url":"https://api.github.com/users/keystonejs","html_url":"https://github.com/keystonejs","followers_url":"https://api.github.com/users/keystonejs/followers","following_url":"https://api.github.com/users/keystonejs/following{/other_user}","gists_url":"https://api.github.com/users/keystonejs/gists{/gist_id}","starred_url":"https://api.github.com/users/keystonejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keystonejs/subscriptions","organizations_url":"https://api.github.com/users/keystonejs/orgs","repos_url":"https://api.github.com/users/keystonejs/repos","events_url":"https://api.github.com/users/keystonejs/events{/privacy}","received_events_url":"https://api.github.com/users/keystonejs/received_events","type":"Organization","site_admin":false},"repo":{"id":11116372,"node_id":"MDEwOlJlcG9zaXRvcnkxMTExNjM3Mg==","name":"keystone","full_name":"keystonejs/keystone","owner":{"login":"keystonejs","id":6118534,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMTg1MzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6118534?v=4","gravatar_id":"","url":"https://api.github.com/users/keystonejs","html_url":"https://github.com/keystonejs","followers_url":"https://api.github.com/users/keystonejs/followers","following_url":"https://api.github.com/users/keystonejs/following{/other_user}","gists_url":"https://api.github.com/users/keystonejs/gists{/gist_id}","starred_url":"https://api.github.com/users/keystonejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keystonejs/subscriptions","organizations_url":"https://api.github.com/users/keystonejs/orgs","repos_url":"https://api.github.com/users/keystonejs/repos","events_url":"https://api.github.com/users/keystonejs/events{/privacy}","received_events_url":"https://api.github.com/users/keystonejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keystonejs/keystone","description":"Node.js CMS and web app framework","fork":false,"url":"https://api.github.com/repos/keystonejs/keystone","forks_url":"https://api.github.com/repos/keystonejs/keystone/forks","keys_url":"https://api.github.com/repos/keystonejs/keystone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keystonejs/keystone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keystonejs/keystone/teams","hooks_url":"https://api.github.com/repos/keystonejs/keystone/hooks","issue_events_url":"https://api.github.com/repos/keystonejs/keystone/issues/events{/number}","events_url":"https://api.github.com/repos/keystonejs/keystone/events","assignees_url":"https://api.github.com/repos/keystonejs/keystone/assignees{/user}","branches_url":"https://api.github.com/repos/keystonejs/keystone/branches{/branch}","tags_url":"https://api.github.com/repos/keystonejs/keystone/tags","blobs_url":"https://api.github.com/repos/keystonejs/keystone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keystonejs/keystone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keystonejs/keystone/git/refs{/sha}","trees_url":"https://api.github.com/repos/keystonejs/keystone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keystonejs/keystone/statuses/{sha}","languages_url":"https://api.github.com/repos/keystonejs/keystone/languages","stargazers_url":"https://api.github.com/repos/keystonejs/keystone/stargazers","contributors_url":"https://api.github.com/repos/keystonejs/keystone/contributors","subscribers_url":"https://api.github.com/repos/keystonejs/keystone/subscribers","subscription_url":"https://api.github.com/repos/keystonejs/keystone/subscription","commits_url":"https://api.github.com/repos/keystonejs/keystone/commits{/sha}","git_commits_url":"https://api.github.com/repos/keystonejs/keystone/git/commits{/sha}","comments_url":"https://api.github.com/repos/keystonejs/keystone/comments{/number}","issue_comment_url":"https://api.github.com/repos/keystonejs/keystone/issues/comments{/number}","contents_url":"https://api.github.com/repos/keystonejs/keystone/contents/{+path}","compare_url":"https://api.github.com/repos/keystonejs/keystone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keystonejs/keystone/merges","archive_url":"https://api.github.com/repos/keystonejs/keystone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keystonejs/keystone/downloads","issues_url":"https://api.github.com/repos/keystonejs/keystone/issues{/number}","pulls_url":"https://api.github.com/repos/keystonejs/keystone/pulls{/number}","milestones_url":"https://api.github.com/repos/keystonejs/keystone/milestones{/number}","notifications_url":"https://api.github.com/repos/keystonejs/keystone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keystonejs/keystone/labels{/name}","releases_url":"https://api.github.com/repos/keystonejs/keystone/releases{/id}","deployments_url":"https://api.github.com/repos/keystonejs/keystone/deployments","created_at":"2013-07-02T05:01:55Z","updated_at":"2018-07-07T01:30:58Z","pushed_at":"2018-07-07T01:30:42Z","git_url":"git://github.com/keystonejs/keystone.git","ssh_url":"git@github.com:keystonejs/keystone.git","clone_url":"https://github.com/keystonejs/keystone.git","svn_url":"https://github.com/keystonejs/keystone","homepage":"http://www.keystonejs.com","size":148799,"stargazers_count":12912,"watchers_count":12912,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2054,"mirror_url":null,"archived":false,"open_issues_count":335,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2054,"open_issues":335,"watchers":12912,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/4565"},"html":{"href":"https://github.com/keystonejs/keystone/pull/4565"},"issue":{"href":"https://api.github.com/repos/keystonejs/keystone/issues/4565"},"comments":{"href":"https://api.github.com/repos/keystonejs/keystone/issues/4565/comments"},"review_comments":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/4565/comments"},"review_comment":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keystonejs/keystone/pulls/4565/commits"},"statuses":{"href":"https://api.github.com/repos/keystonejs/keystone/statuses/7f973b8ec45548da536213a522c7aa54dbce67f3"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":2,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"stennie"}}