{"action":"opened","number":19187,"pull_request":{"url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/19187","id":172131873,"html_url":"https://github.com/woocommerce/woocommerce/pull/19187","diff_url":"https://github.com/woocommerce/woocommerce/pull/19187.diff","patch_url":"https://github.com/woocommerce/woocommerce/pull/19187.patch","issue_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/19187","number":19187,"state":"open","locked":false,"title":"Only show T&C's notice if there is a valid T&Cs page","user":{"login":"WPprodigy","id":8536129,"avatar_url":"https://avatars2.githubusercontent.com/u/8536129?v=4","gravatar_id":"","url":"https://api.github.com/users/WPprodigy","html_url":"https://github.com/WPprodigy","followers_url":"https://api.github.com/users/WPprodigy/followers","following_url":"https://api.github.com/users/WPprodigy/following{/other_user}","gists_url":"https://api.github.com/users/WPprodigy/gists{/gist_id}","starred_url":"https://api.github.com/users/WPprodigy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WPprodigy/subscriptions","organizations_url":"https://api.github.com/users/WPprodigy/orgs","repos_url":"https://api.github.com/users/WPprodigy/repos","events_url":"https://api.github.com/users/WPprodigy/events{/privacy}","received_events_url":"https://api.github.com/users/WPprodigy/received_events","type":"User","site_admin":false},"body":"Bug technically introduced here: https://github.com/woocommerce/woocommerce/pull/18993\r\n\r\nIf you trash a T&C's page and try to checkout, it won't allow you as it will warn you about not accepting the terms and conditions.\r\n\r\nUsing the same check used here: https://github.com/woocommerce/woocommerce/blob/f49491809ff57ceffc46a3785c4d4a256821dd21/includes/class-wc-form-handler.php#L351-L354\r\n\r\nJust checks for this field existing, before also requiring the checkbox to be checked: https://github.com/woocommerce/woocommerce/blob/f49491809ff57ceffc46a3785c4d4a256821dd21/templates/checkout/terms.php#L28","created_at":"2018-03-01T03:03:17Z","updated_at":"2018-03-01T03:03:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":33006752,"url":"https://api.github.com/repos/woocommerce/woocommerce/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"0072BB","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/19187/commits","review_comments_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/19187/comments","review_comment_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/19187/comments","statuses_url":"https://api.github.com/repos/woocommerce/woocommerce/statuses/0568470bb872dcd17c7ceaf15a600918dcdd6f5e","head":{"label":"woocommerce:fix/terms-notice-trashed-page","ref":"fix/terms-notice-trashed-page","sha":"0568470bb872dcd17c7ceaf15a600918dcdd6f5e","user":{"login":"woocommerce","id":473596,"avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":2179920,"name":"woocommerce","full_name":"woocommerce/woocommerce","owner":{"login":"woocommerce","id":473596,"avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/woocommerce/woocommerce","description":"An open source eCommerce plugin for WordPress.","fork":false,"url":"https://api.github.com/repos/woocommerce/woocommerce","forks_url":"https://api.github.com/repos/woocommerce/woocommerce/forks","keys_url":"https://api.github.com/repos/woocommerce/woocommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woocommerce/woocommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woocommerce/woocommerce/teams","hooks_url":"https://api.github.com/repos/woocommerce/woocommerce/hooks","issue_events_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/events{/number}","events_url":"https://api.github.com/repos/woocommerce/woocommerce/events","assignees_url":"https://api.github.com/repos/woocommerce/woocommerce/assignees{/user}","branches_url":"https://api.github.com/repos/woocommerce/woocommerce/branches{/branch}","tags_url":"https://api.github.com/repos/woocommerce/woocommerce/tags","blobs_url":"https://api.github.com/repos/woocommerce/woocommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woocommerce/woocommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woocommerce/woocommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/woocommerce/woocommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woocommerce/woocommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/woocommerce/woocommerce/languages","stargazers_url":"https://api.github.com/repos/woocommerce/woocommerce/stargazers","contributors_url":"https://api.github.com/repos/woocommerce/woocommerce/contributors","subscribers_url":"https://api.github.com/repos/woocommerce/woocommerce/subscribers","subscription_url":"https://api.github.com/repos/woocommerce/woocommerce/subscription","commits_url":"https://api.github.com/repos/woocommerce/woocommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/woocommerce/woocommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/woocommerce/woocommerce/contents/{+path}","compare_url":"https://api.github.com/repos/woocommerce/woocommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woocommerce/woocommerce/merges","archive_url":"https://api.github.com/repos/woocommerce/woocommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woocommerce/woocommerce/downloads","issues_url":"https://api.github.com/repos/woocommerce/woocommerce/issues{/number}","pulls_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/woocommerce/woocommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/woocommerce/woocommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woocommerce/woocommerce/labels{/name}","releases_url":"https://api.github.com/repos/woocommerce/woocommerce/releases{/id}","deployments_url":"https://api.github.com/repos/woocommerce/woocommerce/deployments","created_at":"2011-08-09T15:12:11Z","updated_at":"2018-02-28T22:15:22Z","pushed_at":"2018-03-01T02:59:24Z","git_url":"git://github.com/woocommerce/woocommerce.git","ssh_url":"git@github.com:woocommerce/woocommerce.git","clone_url":"https://github.com/woocommerce/woocommerce.git","svn_url":"https://github.com/woocommerce/woocommerce","homepage":"http://www.woocommerce.com/","size":141269,"stargazers_count":4191,"watchers_count":4191,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3757,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3757,"open_issues":75,"watchers":4191,"default_branch":"master"}},"base":{"label":"woocommerce:master","ref":"master","sha":"8bfb0a96d4344dba2fb5c511952545e842619faa","user":{"login":"woocommerce","id":473596,"avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":2179920,"name":"woocommerce","full_name":"woocommerce/woocommerce","owner":{"login":"woocommerce","id":473596,"avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/woocommerce/woocommerce","description":"An open source eCommerce plugin for WordPress.","fork":false,"url":"https://api.github.com/repos/woocommerce/woocommerce","forks_url":"https://api.github.com/repos/woocommerce/woocommerce/forks","keys_url":"https://api.github.com/repos/woocommerce/woocommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woocommerce/woocommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woocommerce/woocommerce/teams","hooks_url":"https://api.github.com/repos/woocommerce/woocommerce/hooks","issue_events_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/events{/number}","events_url":"https://api.github.com/repos/woocommerce/woocommerce/events","assignees_url":"https://api.github.com/repos/woocommerce/woocommerce/assignees{/user}","branches_url":"https://api.github.com/repos/woocommerce/woocommerce/branches{/branch}","tags_url":"https://api.github.com/repos/woocommerce/woocommerce/tags","blobs_url":"https://api.github.com/repos/woocommerce/woocommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woocommerce/woocommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woocommerce/woocommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/woocommerce/woocommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woocommerce/woocommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/woocommerce/woocommerce/languages","stargazers_url":"https://api.github.com/repos/woocommerce/woocommerce/stargazers","contributors_url":"https://api.github.com/repos/woocommerce/woocommerce/contributors","subscribers_url":"https://api.github.com/repos/woocommerce/woocommerce/subscribers","subscription_url":"https://api.github.com/repos/woocommerce/woocommerce/subscription","commits_url":"https://api.github.com/repos/woocommerce/woocommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/woocommerce/woocommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/woocommerce/woocommerce/contents/{+path}","compare_url":"https://api.github.com/repos/woocommerce/woocommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woocommerce/woocommerce/merges","archive_url":"https://api.github.com/repos/woocommerce/woocommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woocommerce/woocommerce/downloads","issues_url":"https://api.github.com/repos/woocommerce/woocommerce/issues{/number}","pulls_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/woocommerce/woocommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/woocommerce/woocommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woocommerce/woocommerce/labels{/name}","releases_url":"https://api.github.com/repos/woocommerce/woocommerce/releases{/id}","deployments_url":"https://api.github.com/repos/woocommerce/woocommerce/deployments","created_at":"2011-08-09T15:12:11Z","updated_at":"2018-02-28T22:15:22Z","pushed_at":"2018-03-01T02:59:24Z","git_url":"git://github.com/woocommerce/woocommerce.git","ssh_url":"git@github.com:woocommerce/woocommerce.git","clone_url":"https://github.com/woocommerce/woocommerce.git","svn_url":"https://github.com/woocommerce/woocommerce","homepage":"http://www.woocommerce.com/","size":141269,"stargazers_count":4191,"watchers_count":4191,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3757,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3757,"open_issues":75,"watchers":4191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/19187"},"html":{"href":"https://github.com/woocommerce/woocommerce/pull/19187"},"issue":{"href":"https://api.github.com/repos/woocommerce/woocommerce/issues/19187"},"comments":{"href":"https://api.github.com/repos/woocommerce/woocommerce/issues/19187/comments"},"review_comments":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/19187/comments"},"review_comment":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/19187/commits"},"statuses":{"href":"https://api.github.com/repos/woocommerce/woocommerce/statuses/0568470bb872dcd17c7ceaf15a600918dcdd6f5e"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"WPprodigy"}}