{"action":"created","comment":{"url":"https://api.github.com/repos/biosistemika/scinote-web/pulls/comments/209931946","pull_request_review_id":146039367,"id":209931946,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTkzMTk0Ng==","diff_hunk":"@@ -113,12 +113,12 @@ var RepositoryDatatable = (function(global) {\n           $(row).addClass('selected');\n         }\n       },\n-      <% # Next 2 options are provided by server-side default state\n-         # (and get overriden once state load from server kicks in) %>\n-      order: <%= default_table_order_as_js_array %>,\n+      // Next 2 options are provided by server-side default state\n+      //  (and get overriden once state load from server kicks in)\n+      order: JSON.parse($('#datatable_empty_tables_data').attr('data-DEFAULT_TABLE_ORDER_AS_JS_ARRAY')),\n       columns: (function() {\n         var numOfColumns = $(TABLE_ID).data('num-columns');\n-        var columns = <%= default_table_columns %>;\n+        var columns = JSON.parse($('#datatable_empty_tables_data').attr('data-DEFAULT_TABLE_COLUMNS'));","path":"app/assets/javascripts/repositories/repository_datatable.js","position":13,"original_position":13,"commit_id":"d0d80d9418bfba66a10b9e00ef63b0dcd420392e","original_commit_id":"d0d80d9418bfba66a10b9e00ef63b0dcd420392e","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Unexpected var, use let or const instead                                   no-var","created_at":"2018-08-14T12:31:33Z","updated_at":"2018-08-14T12:31:33Z","html_url":"https://github.com/biosistemika/scinote-web/pull/1256#discussion_r209931946","pull_request_url":"https://api.github.com/repos/biosistemika/scinote-web/pulls/1256","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/biosistemika/scinote-web/pulls/comments/209931946"},"html":{"href":"https://github.com/biosistemika/scinote-web/pull/1256#discussion_r209931946"},"pull_request":{"href":"https://api.github.com/repos/biosistemika/scinote-web/pulls/1256"}}},"pull_request":{"url":"https://api.github.com/repos/biosistemika/scinote-web/pulls/1256","id":204449314,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NDQ5MzE0","html_url":"https://github.com/biosistemika/scinote-web/pull/1256","diff_url":"https://github.com/biosistemika/scinote-web/pull/1256.diff","patch_url":"https://github.com/biosistemika/scinote-web/pull/1256.patch","issue_url":"https://api.github.com/repos/biosistemika/scinote-web/issues/1256","number":1256,"state":"open","locked":false,"title":"Refactoring converted .js.erb files to .js [SCI-2620]","user":{"login":"Zanz2","id":10207480,"node_id":"MDQ6VXNlcjEwMjA3NDgw","avatar_url":"https://avatars1.githubusercontent.com/u/10207480?v=4","gravatar_id":"","url":"https://api.github.com/users/Zanz2","html_url":"https://github.com/Zanz2","followers_url":"https://api.github.com/users/Zanz2/followers","following_url":"https://api.github.com/users/Zanz2/following{/other_user}","gists_url":"https://api.github.com/users/Zanz2/gists{/gist_id}","starred_url":"https://api.github.com/users/Zanz2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zanz2/subscriptions","organizations_url":"https://api.github.com/users/Zanz2/orgs","repos_url":"https://api.github.com/users/Zanz2/repos","events_url":"https://api.github.com/users/Zanz2/events{/privacy}","received_events_url":"https://api.github.com/users/Zanz2/received_events","type":"User","site_admin":false},"body":"Audit trails and billing have seperate pull requests on gitlab, constants are in new file in shared folder, so its not too messy flooding other files.\r\n\r\nThe 2 files that I couldnt find a way to convert are my protocols.io files \r\nprotocolsio_import_create.js.erb\r\nprotocolsio_import_save.js.erb\r\n\r\nThey get a response from protocols controller, and are core functionality for uploading protocols.io files, i couldnt convert them because I couldnt find a way to use an alternative than rails j tag to inject data into a tag, and each alternative i tried caused the modal popup to not render.","created_at":"2018-07-27T14:31:44Z","updated_at":"2018-08-14T12:31:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c4344b0b14ae31cc569d4b8159e5e498657c67c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":481893795,"node_id":"MDU6TGFiZWw0ODE4OTM3OTU=","url":"https://api.github.com/repos/biosistemika/scinote-web/labels/master","name":"master","color":"37a0d9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/biosistemika/scinote-web/pulls/1256/commits","review_comments_url":"https://api.github.com/repos/biosistemika/scinote-web/pulls/1256/comments","review_comment_url":"https://api.github.com/repos/biosistemika/scinote-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biosistemika/scinote-web/issues/1256/comments","statuses_url":"https://api.github.com/repos/biosistemika/scinote-web/statuses/d0d80d9418bfba66a10b9e00ef63b0dcd420392e","head":{"label":"Zanz2:zz_js_erb_to_js_sci2620","ref":"zz_js_erb_to_js_sci2620","sha":"d0d80d9418bfba66a10b9e00ef63b0dcd420392e","user":{"login":"Zanz2","id":10207480,"node_id":"MDQ6VXNlcjEwMjA3NDgw","avatar_url":"https://avatars1.githubusercontent.com/u/10207480?v=4","gravatar_id":"","url":"https://api.github.com/users/Zanz2","html_url":"https://github.com/Zanz2","followers_url":"https://api.github.com/users/Zanz2/followers","following_url":"https://api.github.com/users/Zanz2/following{/other_user}","gists_url":"https://api.github.com/users/Zanz2/gists{/gist_id}","starred_url":"https://api.github.com/users/Zanz2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zanz2/subscriptions","organizations_url":"https://api.github.com/users/Zanz2/orgs","repos_url":"https://api.github.com/users/Zanz2/repos","events_url":"https://api.github.com/users/Zanz2/events{/privacy}","received_events_url":"https://api.github.com/users/Zanz2/received_events","type":"User","site_admin":false},"repo":{"id":101616243,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE2MTYyNDM=","name":"scinote-web","full_name":"Zanz2/scinote-web","owner":{"login":"Zanz2","id":10207480,"node_id":"MDQ6VXNlcjEwMjA3NDgw","avatar_url":"https://avatars1.githubusercontent.com/u/10207480?v=4","gravatar_id":"","url":"https://api.github.com/users/Zanz2","html_url":"https://github.com/Zanz2","followers_url":"https://api.github.com/users/Zanz2/followers","following_url":"https://api.github.com/users/Zanz2/following{/other_user}","gists_url":"https://api.github.com/users/Zanz2/gists{/gist_id}","starred_url":"https://api.github.com/users/Zanz2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zanz2/subscriptions","organizations_url":"https://api.github.com/users/Zanz2/orgs","repos_url":"https://api.github.com/users/Zanz2/repos","events_url":"https://api.github.com/users/Zanz2/events{/privacy}","received_events_url":"https://api.github.com/users/Zanz2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zanz2/scinote-web","description":"Open source electronic lab notebook (ELN) that helps you manage your laboratory work and stores all your experimental data in one place.","fork":true,"url":"https://api.github.com/repos/Zanz2/scinote-web","forks_url":"https://api.github.com/repos/Zanz2/scinote-web/forks","keys_url":"https://api.github.com/repos/Zanz2/scinote-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zanz2/scinote-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zanz2/scinote-web/teams","hooks_url":"https://api.github.com/repos/Zanz2/scinote-web/hooks","issue_events_url":"https://api.github.com/repos/Zanz2/scinote-web/issues/events{/number}","events_url":"https://api.github.com/repos/Zanz2/scinote-web/events","assignees_url":"https://api.github.com/repos/Zanz2/scinote-web/assignees{/user}","branches_url":"https://api.github.com/repos/Zanz2/scinote-web/branches{/branch}","tags_url":"https://api.github.com/repos/Zanz2/scinote-web/tags","blobs_url":"https://api.github.com/repos/Zanz2/scinote-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zanz2/scinote-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zanz2/scinote-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zanz2/scinote-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zanz2/scinote-web/statuses/{sha}","languages_url":"https://api.github.com/repos/Zanz2/scinote-web/languages","stargazers_url":"https://api.github.com/repos/Zanz2/scinote-web/stargazers","contributors_url":"https://api.github.com/repos/Zanz2/scinote-web/contributors","subscribers_url":"https://api.github.com/repos/Zanz2/scinote-web/subscribers","subscription_url":"https://api.github.com/repos/Zanz2/scinote-web/subscription","commits_url":"https://api.github.com/repos/Zanz2/scinote-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zanz2/scinote-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zanz2/scinote-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zanz2/scinote-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zanz2/scinote-web/contents/{+path}","compare_url":"https://api.github.com/repos/Zanz2/scinote-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zanz2/scinote-web/merges","archive_url":"https://api.github.com/repos/Zanz2/scinote-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zanz2/scinote-web/downloads","issues_url":"https://api.github.com/repos/Zanz2/scinote-web/issues{/number}","pulls_url":"https://api.github.com/repos/Zanz2/scinote-web/pulls{/number}","milestones_url":"https://api.github.com/repos/Zanz2/scinote-web/milestones{/number}","notifications_url":"https://api.github.com/repos/Zanz2/scinote-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zanz2/scinote-web/labels{/name}","releases_url":"https://api.github.com/repos/Zanz2/scinote-web/releases{/id}","deployments_url":"https://api.github.com/repos/Zanz2/scinote-web/deployments","created_at":"2017-08-28T07:29:55Z","updated_at":"2018-08-14T07:36:32Z","pushed_at":"2018-08-14T12:30:56Z","git_url":"git://github.com/Zanz2/scinote-web.git","ssh_url":"git@github.com:Zanz2/scinote-web.git","clone_url":"https://github.com/Zanz2/scinote-web.git","svn_url":"https://github.com/Zanz2/scinote-web","homepage":"https://www.scinote.net","size":14996,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biosistemika:master","ref":"master","sha":"54caa772d975f2afb1b98d4408b5050ce6b7c998","user":{"login":"biosistemika","id":15630206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjMwMjA2","avatar_url":"https://avatars2.githubusercontent.com/u/15630206?v=4","gravatar_id":"","url":"https://api.github.com/users/biosistemika","html_url":"https://github.com/biosistemika","followers_url":"https://api.github.com/users/biosistemika/followers","following_url":"https://api.github.com/users/biosistemika/following{/other_user}","gists_url":"https://api.github.com/users/biosistemika/gists{/gist_id}","starred_url":"https://api.github.com/users/biosistemika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biosistemika/subscriptions","organizations_url":"https://api.github.com/users/biosistemika/orgs","repos_url":"https://api.github.com/users/biosistemika/repos","events_url":"https://api.github.com/users/biosistemika/events{/privacy}","received_events_url":"https://api.github.com/users/biosistemika/received_events","type":"Organization","site_admin":false},"repo":{"id":51598133,"node_id":"MDEwOlJlcG9zaXRvcnk1MTU5ODEzMw==","name":"scinote-web","full_name":"biosistemika/scinote-web","owner":{"login":"biosistemika","id":15630206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjMwMjA2","avatar_url":"https://avatars2.githubusercontent.com/u/15630206?v=4","gravatar_id":"","url":"https://api.github.com/users/biosistemika","html_url":"https://github.com/biosistemika","followers_url":"https://api.github.com/users/biosistemika/followers","following_url":"https://api.github.com/users/biosistemika/following{/other_user}","gists_url":"https://api.github.com/users/biosistemika/gists{/gist_id}","starred_url":"https://api.github.com/users/biosistemika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biosistemika/subscriptions","organizations_url":"https://api.github.com/users/biosistemika/orgs","repos_url":"https://api.github.com/users/biosistemika/repos","events_url":"https://api.github.com/users/biosistemika/events{/privacy}","received_events_url":"https://api.github.com/users/biosistemika/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biosistemika/scinote-web","description":"Open source electronic lab notebook (ELN) that helps you manage your laboratory work and stores all your experimental data in one place.","fork":false,"url":"https://api.github.com/repos/biosistemika/scinote-web","forks_url":"https://api.github.com/repos/biosistemika/scinote-web/forks","keys_url":"https://api.github.com/repos/biosistemika/scinote-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biosistemika/scinote-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biosistemika/scinote-web/teams","hooks_url":"https://api.github.com/repos/biosistemika/scinote-web/hooks","issue_events_url":"https://api.github.com/repos/biosistemika/scinote-web/issues/events{/number}","events_url":"https://api.github.com/repos/biosistemika/scinote-web/events","assignees_url":"https://api.github.com/repos/biosistemika/scinote-web/assignees{/user}","branches_url":"https://api.github.com/repos/biosistemika/scinote-web/branches{/branch}","tags_url":"https://api.github.com/repos/biosistemika/scinote-web/tags","blobs_url":"https://api.github.com/repos/biosistemika/scinote-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biosistemika/scinote-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biosistemika/scinote-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/biosistemika/scinote-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biosistemika/scinote-web/statuses/{sha}","languages_url":"https://api.github.com/repos/biosistemika/scinote-web/languages","stargazers_url":"https://api.github.com/repos/biosistemika/scinote-web/stargazers","contributors_url":"https://api.github.com/repos/biosistemika/scinote-web/contributors","subscribers_url":"https://api.github.com/repos/biosistemika/scinote-web/subscribers","subscription_url":"https://api.github.com/repos/biosistemika/scinote-web/subscription","commits_url":"https://api.github.com/repos/biosistemika/scinote-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/biosistemika/scinote-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/biosistemika/scinote-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/biosistemika/scinote-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/biosistemika/scinote-web/contents/{+path}","compare_url":"https://api.github.com/repos/biosistemika/scinote-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biosistemika/scinote-web/merges","archive_url":"https://api.github.com/repos/biosistemika/scinote-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biosistemika/scinote-web/downloads","issues_url":"https://api.github.com/repos/biosistemika/scinote-web/issues{/number}","pulls_url":"https://api.github.com/repos/biosistemika/scinote-web/pulls{/number}","milestones_url":"https://api.github.com/repos/biosistemika/scinote-web/milestones{/number}","notifications_url":"https://api.github.com/repos/biosistemika/scinote-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biosistemika/scinote-web/labels{/name}","releases_url":"https://api.github.com/repos/biosistemika/scinote-web/releases{/id}","deployments_url":"https://api.github.com/repos/biosistemika/scinote-web/deployments","created_at":"2016-02-12T15:47:19Z","updated_at":"2018-08-09T09:50:38Z","pushed_at":"2018-08-14T12:30:57Z","git_url":"git://github.com/biosistemika/scinote-web.git","ssh_url":"git@github.com:biosistemika/scinote-web.git","clone_url":"https://github.com/biosistemika/scinote-web.git","svn_url":"https://github.com/biosistemika/scinote-web","homepage":"https://www.scinote.net","size":26440,"stargazers_count":145,"watchers_count":145,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":41,"open_issues":12,"watchers":145,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biosistemika/scinote-web/pulls/1256"},"html":{"href":"https://github.com/biosistemika/scinote-web/pull/1256"},"issue":{"href":"https://api.github.com/repos/biosistemika/scinote-web/issues/1256"},"comments":{"href":"https://api.github.com/repos/biosistemika/scinote-web/issues/1256/comments"},"review_comments":{"href":"https://api.github.com/repos/biosistemika/scinote-web/pulls/1256/comments"},"review_comment":{"href":"https://api.github.com/repos/biosistemika/scinote-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biosistemika/scinote-web/pulls/1256/commits"},"statuses":{"href":"https://api.github.com/repos/biosistemika/scinote-web/statuses/d0d80d9418bfba66a10b9e00ef63b0dcd420392e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"houndci-bot"}}