{"action":"created","issue":{"url":"https://api.github.com/repos/Proxmark/proxmark3/issues/652","repository_url":"https://api.github.com/repos/Proxmark/proxmark3","labels_url":"https://api.github.com/repos/Proxmark/proxmark3/issues/652/labels{/name}","comments_url":"https://api.github.com/repos/Proxmark/proxmark3/issues/652/comments","events_url":"https://api.github.com/repos/Proxmark/proxmark3/issues/652/events","html_url":"https://github.com/Proxmark/proxmark3/pull/652","id":350036363,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3OTgyNzY0","number":652,"title":"ISO15693 device side improvements","user":{"login":"pwpiwi","id":7026004,"node_id":"MDQ6VXNlcjcwMjYwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7026004?v=4","gravatar_id":"","url":"https://api.github.com/users/pwpiwi","html_url":"https://github.com/pwpiwi","followers_url":"https://api.github.com/users/pwpiwi/followers","following_url":"https://api.github.com/users/pwpiwi/following{/other_user}","gists_url":"https://api.github.com/users/pwpiwi/gists{/gist_id}","starred_url":"https://api.github.com/users/pwpiwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwpiwi/subscriptions","organizations_url":"https://api.github.com/users/pwpiwi/orgs","repos_url":"https://api.github.com/users/pwpiwi/repos","events_url":"https://api.github.com/users/pwpiwi/events{/privacy}","received_events_url":"https://api.github.com/users/pwpiwi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-13T13:45:27Z","updated_at":"2018-08-14T11:49:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Proxmark/proxmark3/pulls/652","html_url":"https://github.com/Proxmark/proxmark3/pull/652","diff_url":"https://github.com/Proxmark/proxmark3/pull/652.diff","patch_url":"https://github.com/Proxmark/proxmark3/pull/652.patch"},"body":"* increase accuracy by doubling the sample frequency (hi_read_rx_xcorr.v)\r\n* adjust armsrc/iso15693.c and client/cmdhf15.c accordingly\r\n* use more accurate approximation for sqrt(ci^2 + cq^2)\r\n* improve EOF detection (was often mistaken for Logic0, resulting in \"error, uneven octet! (extra bits!)\")"},"comment":{"url":"https://api.github.com/repos/Proxmark/proxmark3/issues/comments/412845548","html_url":"https://github.com/Proxmark/proxmark3/pull/652#issuecomment-412845548","issue_url":"https://api.github.com/repos/Proxmark/proxmark3/issues/652","id":412845548,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjg0NTU0OA==","user":{"login":"drandreas","id":8958160,"node_id":"MDQ6VXNlcjg5NTgxNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/8958160?v=4","gravatar_id":"","url":"https://api.github.com/users/drandreas","html_url":"https://github.com/drandreas","followers_url":"https://api.github.com/users/drandreas/followers","following_url":"https://api.github.com/users/drandreas/following{/other_user}","gists_url":"https://api.github.com/users/drandreas/gists{/gist_id}","starred_url":"https://api.github.com/users/drandreas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drandreas/subscriptions","organizations_url":"https://api.github.com/users/drandreas/orgs","repos_url":"https://api.github.com/users/drandreas/repos","events_url":"https://api.github.com/users/drandreas/events{/privacy}","received_events_url":"https://api.github.com/users/drandreas/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T11:49:23Z","updated_at":"2018-08-14T11:49:23Z","author_association":"CONTRIBUTOR","body":"You did not miss any code in the official repo. I was considering the 400+ forks that might have implemented protocols based on xcrorr. Yesterday, I was just about to create a PR for Legic Prime, than I noticed conflicts between your changes and mine (Legic Prime has a 212 kHz sub carrier).\r\n\r\nIf you prefer to keep your current xcrorr code I can either bump my Legic code from 5 Q/I pairs to 20 and calculate the average on ARM (that will most definitely work also) or I can add the suggested change to my Legic PR for review and we discuss then which way to go.\r\n\r\nEither way I will wait for this PR to complete, so we do not have versions with broken Legic support."}}
{"actor":{"display_login":"drandreas"}}