{"action":"created","issue":{"url":"https://api.github.com/repos/pmem/redis/issues/19","repository_url":"https://api.github.com/repos/pmem/redis","labels_url":"https://api.github.com/repos/pmem/redis/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/pmem/redis/issues/19/comments","events_url":"https://api.github.com/repos/pmem/redis/issues/19/events","html_url":"https://github.com/pmem/redis/pull/19","id":305885704,"number":19,"title":"Add Makefile variable for memkind","user":{"login":"KFilipek","id":7746856,"avatar_url":"https://avatars2.githubusercontent.com/u/7746856?v=4","gravatar_id":"","url":"https://api.github.com/users/KFilipek","html_url":"https://github.com/KFilipek","followers_url":"https://api.github.com/users/KFilipek/followers","following_url":"https://api.github.com/users/KFilipek/following{/other_user}","gists_url":"https://api.github.com/users/KFilipek/gists{/gist_id}","starred_url":"https://api.github.com/users/KFilipek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KFilipek/subscriptions","organizations_url":"https://api.github.com/users/KFilipek/orgs","repos_url":"https://api.github.com/users/KFilipek/repos","events_url":"https://api.github.com/users/KFilipek/events{/privacy}","received_events_url":"https://api.github.com/users/KFilipek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-16T10:59:38Z","updated_at":"2018-03-16T14:18:32Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/pmem/redis/pulls/19","html_url":"https://github.com/pmem/redis/pull/19","diff_url":"https://github.com/pmem/redis/pull/19.diff","patch_url":"https://github.com/pmem/redis/pull/19.patch"},"body":"I've added JEMALLOC_PATH to point where is Memkind containing jemalloc directory.\r\nVariable can be passed to the main makefile or directly in the src/Makefile.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pmem/redis/19)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/pmem/redis/issues/comments/373727144","html_url":"https://github.com/pmem/redis/pull/19#issuecomment-373727144","issue_url":"https://api.github.com/repos/pmem/redis/issues/19","id":373727144,"user":{"login":"karpiop","id":26297212,"avatar_url":"https://avatars3.githubusercontent.com/u/26297212?v=4","gravatar_id":"","url":"https://api.github.com/users/karpiop","html_url":"https://github.com/karpiop","followers_url":"https://api.github.com/users/karpiop/followers","following_url":"https://api.github.com/users/karpiop/following{/other_user}","gists_url":"https://api.github.com/users/karpiop/gists{/gist_id}","starred_url":"https://api.github.com/users/karpiop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karpiop/subscriptions","organizations_url":"https://api.github.com/users/karpiop/orgs","repos_url":"https://api.github.com/users/karpiop/repos","events_url":"https://api.github.com/users/karpiop/events{/privacy}","received_events_url":"https://api.github.com/users/karpiop/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T14:18:32Z","updated_at":"2018-03-16T14:18:32Z","author_association":"NONE","body":"\n\n\n\nReview status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[Makefile, line 4 at r1](https://reviewable.io:443/reviews/pmem/redis/19#-L7ixnuwB2C1tZsI9-_F:-L7ixnuwB2C1tZsI9-_G:biik88y) ([raw file](https://github.com/pmem/redis/blob/ebedeacea14b0f636492c9e8cd9b098e13a3b4a2/Makefile#L4)):*\n> ```Makefile\n> JEMALLOC_PATH=deps/memkind\n> export JEMALLOC_PATH\n> ```\n\nyou dont't need to export path here since you declare it in src/Makefile\n\n---\n\n*[src/Makefile, line 26 at r1](https://reviewable.io:443/reviews/pmem/redis/19#-L7iqd_-1gUMGI44tezG:-L7iqd_-1gUMGI44tezH:b5pbpdo) ([raw file](https://github.com/pmem/redis/blob/ebedeacea14b0f636492c9e8cd9b098e13a3b4a2/src/Makefile#L26)):*\n> ```Makefile\n> WARN=-Wall -W -Wno-missing-field-initializers\n> OPT=$(OPTIMIZATION)\n> JEMALLOC_PATH=deps/memkind\n> ```\n\nshould be JEMALLOC_PATH=../deps/memkind\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/pmem/redis/19)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"karpiop"}}