{"action":"created","comment":{"url":"https://api.github.com/repos/FezVrasta/react-popper/pulls/comments/202546332","pull_request_review_id":137270317,"id":202546332,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjU0NjMzMg==","diff_hunk":"@@ -59,24 +57,37 @@ const initialArrowStyle = {};\n \n export class InnerPopper extends React.Component<PopperProps, PopperState> {\n   static defaultProps = {\n+    init: true,","path":"src/Popper.js","position":22,"original_position":22,"commit_id":"82dac08a2f2b4b34fe794bc46f3c4398242d294b","original_commit_id":"82dac08a2f2b4b34fe794bc46f3c4398242d294b","user":{"login":"FezVrasta","id":5382443,"node_id":"MDQ6VXNlcjUzODI0NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5382443?v=4","gravatar_id":"","url":"https://api.github.com/users/FezVrasta","html_url":"https://github.com/FezVrasta","followers_url":"https://api.github.com/users/FezVrasta/followers","following_url":"https://api.github.com/users/FezVrasta/following{/other_user}","gists_url":"https://api.github.com/users/FezVrasta/gists{/gist_id}","starred_url":"https://api.github.com/users/FezVrasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FezVrasta/subscriptions","organizations_url":"https://api.github.com/users/FezVrasta/orgs","repos_url":"https://api.github.com/users/FezVrasta/repos","events_url":"https://api.github.com/users/FezVrasta/events{/privacy}","received_events_url":"https://api.github.com/users/FezVrasta/received_events","type":"User","site_admin":false},"body":"Umh okay... Last question (I hope), why do you need to render the dropdown even when you don't want to show it? Couldn't it be:","created_at":"2018-07-15T15:42:10Z","updated_at":"2018-07-15T15:42:10Z","html_url":"https://github.com/FezVrasta/react-popper/pull/197#discussion_r202546332","pull_request_url":"https://api.github.com/repos/FezVrasta/react-popper/pulls/197","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/FezVrasta/react-popper/pulls/comments/202546332"},"html":{"href":"https://github.com/FezVrasta/react-popper/pull/197#discussion_r202546332"},"pull_request":{"href":"https://api.github.com/repos/FezVrasta/react-popper/pulls/197"}},"in_reply_to_id":201183892},"pull_request":{"url":"https://api.github.com/repos/FezVrasta/react-popper/pulls/197","id":199970482,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTcwNDgy","html_url":"https://github.com/FezVrasta/react-popper/pull/197","diff_url":"https://github.com/FezVrasta/react-popper/pull/197.diff","patch_url":"https://github.com/FezVrasta/react-popper/pull/197.patch","issue_url":"https://api.github.com/repos/FezVrasta/react-popper/issues/197","number":197,"state":"open","locked":false,"title":"perf: reduce renders by moving values off of PopperState","user":{"login":"jquense","id":339286,"node_id":"MDQ6VXNlcjMzOTI4Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/339286?v=4","gravatar_id":"","url":"https://api.github.com/users/jquense","html_url":"https://github.com/jquense","followers_url":"https://api.github.com/users/jquense/followers","following_url":"https://api.github.com/users/jquense/following{/other_user}","gists_url":"https://api.github.com/users/jquense/gists{/gist_id}","starred_url":"https://api.github.com/users/jquense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquense/subscriptions","organizations_url":"https://api.github.com/users/jquense/orgs","repos_url":"https://api.github.com/users/jquense/repos","events_url":"https://api.github.com/users/jquense/events{/privacy}","received_events_url":"https://api.github.com/users/jquense/received_events","type":"User","site_admin":false},"body":"This was originally meant to try and make it harder to hit the infinite loop with refs, but ended up with a small perf improvement by reducing the need to rerender when `popper` and `arrow` nodes are set. We don't actually need to update any children until _after_ the node updates have made their way back into popper, at which point the modifier will update state and re-render with the new styles","created_at":"2018-07-09T00:50:42Z","updated_at":"2018-07-15T15:42:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52072319b0cec07b5e25e28d96ec9fc56c025907","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FezVrasta/react-popper/pulls/197/commits","review_comments_url":"https://api.github.com/repos/FezVrasta/react-popper/pulls/197/comments","review_comment_url":"https://api.github.com/repos/FezVrasta/react-popper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FezVrasta/react-popper/issues/197/comments","statuses_url":"https://api.github.com/repos/FezVrasta/react-popper/statuses/82dac08a2f2b4b34fe794bc46f3c4398242d294b","head":{"label":"jquense:reduce-renders","ref":"reduce-renders","sha":"82dac08a2f2b4b34fe794bc46f3c4398242d294b","user":{"login":"jquense","id":339286,"node_id":"MDQ6VXNlcjMzOTI4Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/339286?v=4","gravatar_id":"","url":"https://api.github.com/users/jquense","html_url":"https://github.com/jquense","followers_url":"https://api.github.com/users/jquense/followers","following_url":"https://api.github.com/users/jquense/following{/other_user}","gists_url":"https://api.github.com/users/jquense/gists{/gist_id}","starred_url":"https://api.github.com/users/jquense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquense/subscriptions","organizations_url":"https://api.github.com/users/jquense/orgs","repos_url":"https://api.github.com/users/jquense/repos","events_url":"https://api.github.com/users/jquense/events{/privacy}","received_events_url":"https://api.github.com/users/jquense/received_events","type":"User","site_admin":false},"repo":{"id":140211766,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAyMTE3NjY=","name":"react-popper","full_name":"jquense/react-popper","owner":{"login":"jquense","id":339286,"node_id":"MDQ6VXNlcjMzOTI4Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/339286?v=4","gravatar_id":"","url":"https://api.github.com/users/jquense","html_url":"https://github.com/jquense","followers_url":"https://api.github.com/users/jquense/followers","following_url":"https://api.github.com/users/jquense/following{/other_user}","gists_url":"https://api.github.com/users/jquense/gists{/gist_id}","starred_url":"https://api.github.com/users/jquense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquense/subscriptions","organizations_url":"https://api.github.com/users/jquense/orgs","repos_url":"https://api.github.com/users/jquense/repos","events_url":"https://api.github.com/users/jquense/events{/privacy}","received_events_url":"https://api.github.com/users/jquense/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jquense/react-popper","description":"React wrapper around Popper.js","fork":true,"url":"https://api.github.com/repos/jquense/react-popper","forks_url":"https://api.github.com/repos/jquense/react-popper/forks","keys_url":"https://api.github.com/repos/jquense/react-popper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquense/react-popper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquense/react-popper/teams","hooks_url":"https://api.github.com/repos/jquense/react-popper/hooks","issue_events_url":"https://api.github.com/repos/jquense/react-popper/issues/events{/number}","events_url":"https://api.github.com/repos/jquense/react-popper/events","assignees_url":"https://api.github.com/repos/jquense/react-popper/assignees{/user}","branches_url":"https://api.github.com/repos/jquense/react-popper/branches{/branch}","tags_url":"https://api.github.com/repos/jquense/react-popper/tags","blobs_url":"https://api.github.com/repos/jquense/react-popper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquense/react-popper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquense/react-popper/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquense/react-popper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquense/react-popper/statuses/{sha}","languages_url":"https://api.github.com/repos/jquense/react-popper/languages","stargazers_url":"https://api.github.com/repos/jquense/react-popper/stargazers","contributors_url":"https://api.github.com/repos/jquense/react-popper/contributors","subscribers_url":"https://api.github.com/repos/jquense/react-popper/subscribers","subscription_url":"https://api.github.com/repos/jquense/react-popper/subscription","commits_url":"https://api.github.com/repos/jquense/react-popper/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquense/react-popper/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquense/react-popper/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquense/react-popper/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquense/react-popper/contents/{+path}","compare_url":"https://api.github.com/repos/jquense/react-popper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquense/react-popper/merges","archive_url":"https://api.github.com/repos/jquense/react-popper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquense/react-popper/downloads","issues_url":"https://api.github.com/repos/jquense/react-popper/issues{/number}","pulls_url":"https://api.github.com/repos/jquense/react-popper/pulls{/number}","milestones_url":"https://api.github.com/repos/jquense/react-popper/milestones{/number}","notifications_url":"https://api.github.com/repos/jquense/react-popper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquense/react-popper/labels{/name}","releases_url":"https://api.github.com/repos/jquense/react-popper/releases{/id}","deployments_url":"https://api.github.com/repos/jquense/react-popper/deployments","created_at":"2018-07-09T00:10:55Z","updated_at":"2018-07-09T00:10:57Z","pushed_at":"2018-07-09T14:05:17Z","git_url":"git://github.com/jquense/react-popper.git","ssh_url":"git@github.com:jquense/react-popper.git","clone_url":"https://github.com/jquense/react-popper.git","svn_url":"https://github.com/jquense/react-popper","homepage":"https://fezvrasta.github.io/react-popper/","size":1242,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FezVrasta:master","ref":"master","sha":"f551da8bb9d847d7380a1af71ad7e2a6719d786d","user":{"login":"FezVrasta","id":5382443,"node_id":"MDQ6VXNlcjUzODI0NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5382443?v=4","gravatar_id":"","url":"https://api.github.com/users/FezVrasta","html_url":"https://github.com/FezVrasta","followers_url":"https://api.github.com/users/FezVrasta/followers","following_url":"https://api.github.com/users/FezVrasta/following{/other_user}","gists_url":"https://api.github.com/users/FezVrasta/gists{/gist_id}","starred_url":"https://api.github.com/users/FezVrasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FezVrasta/subscriptions","organizations_url":"https://api.github.com/users/FezVrasta/orgs","repos_url":"https://api.github.com/users/FezVrasta/repos","events_url":"https://api.github.com/users/FezVrasta/events{/privacy}","received_events_url":"https://api.github.com/users/FezVrasta/received_events","type":"User","site_admin":false},"repo":{"id":70210509,"node_id":"MDEwOlJlcG9zaXRvcnk3MDIxMDUwOQ==","name":"react-popper","full_name":"FezVrasta/react-popper","owner":{"login":"FezVrasta","id":5382443,"node_id":"MDQ6VXNlcjUzODI0NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5382443?v=4","gravatar_id":"","url":"https://api.github.com/users/FezVrasta","html_url":"https://github.com/FezVrasta","followers_url":"https://api.github.com/users/FezVrasta/followers","following_url":"https://api.github.com/users/FezVrasta/following{/other_user}","gists_url":"https://api.github.com/users/FezVrasta/gists{/gist_id}","starred_url":"https://api.github.com/users/FezVrasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FezVrasta/subscriptions","organizations_url":"https://api.github.com/users/FezVrasta/orgs","repos_url":"https://api.github.com/users/FezVrasta/repos","events_url":"https://api.github.com/users/FezVrasta/events{/privacy}","received_events_url":"https://api.github.com/users/FezVrasta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FezVrasta/react-popper","description":"React wrapper around Popper.js","fork":false,"url":"https://api.github.com/repos/FezVrasta/react-popper","forks_url":"https://api.github.com/repos/FezVrasta/react-popper/forks","keys_url":"https://api.github.com/repos/FezVrasta/react-popper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FezVrasta/react-popper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FezVrasta/react-popper/teams","hooks_url":"https://api.github.com/repos/FezVrasta/react-popper/hooks","issue_events_url":"https://api.github.com/repos/FezVrasta/react-popper/issues/events{/number}","events_url":"https://api.github.com/repos/FezVrasta/react-popper/events","assignees_url":"https://api.github.com/repos/FezVrasta/react-popper/assignees{/user}","branches_url":"https://api.github.com/repos/FezVrasta/react-popper/branches{/branch}","tags_url":"https://api.github.com/repos/FezVrasta/react-popper/tags","blobs_url":"https://api.github.com/repos/FezVrasta/react-popper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FezVrasta/react-popper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FezVrasta/react-popper/git/refs{/sha}","trees_url":"https://api.github.com/repos/FezVrasta/react-popper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FezVrasta/react-popper/statuses/{sha}","languages_url":"https://api.github.com/repos/FezVrasta/react-popper/languages","stargazers_url":"https://api.github.com/repos/FezVrasta/react-popper/stargazers","contributors_url":"https://api.github.com/repos/FezVrasta/react-popper/contributors","subscribers_url":"https://api.github.com/repos/FezVrasta/react-popper/subscribers","subscription_url":"https://api.github.com/repos/FezVrasta/react-popper/subscription","commits_url":"https://api.github.com/repos/FezVrasta/react-popper/commits{/sha}","git_commits_url":"https://api.github.com/repos/FezVrasta/react-popper/git/commits{/sha}","comments_url":"https://api.github.com/repos/FezVrasta/react-popper/comments{/number}","issue_comment_url":"https://api.github.com/repos/FezVrasta/react-popper/issues/comments{/number}","contents_url":"https://api.github.com/repos/FezVrasta/react-popper/contents/{+path}","compare_url":"https://api.github.com/repos/FezVrasta/react-popper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FezVrasta/react-popper/merges","archive_url":"https://api.github.com/repos/FezVrasta/react-popper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FezVrasta/react-popper/downloads","issues_url":"https://api.github.com/repos/FezVrasta/react-popper/issues{/number}","pulls_url":"https://api.github.com/repos/FezVrasta/react-popper/pulls{/number}","milestones_url":"https://api.github.com/repos/FezVrasta/react-popper/milestones{/number}","notifications_url":"https://api.github.com/repos/FezVrasta/react-popper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FezVrasta/react-popper/labels{/name}","releases_url":"https://api.github.com/repos/FezVrasta/react-popper/releases{/id}","deployments_url":"https://api.github.com/repos/FezVrasta/react-popper/deployments","created_at":"2016-10-07T02:51:11Z","updated_at":"2018-07-13T18:05:09Z","pushed_at":"2018-07-09T02:40:38Z","git_url":"git://github.com/FezVrasta/react-popper.git","ssh_url":"git@github.com:FezVrasta/react-popper.git","clone_url":"https://github.com/FezVrasta/react-popper.git","svn_url":"https://github.com/FezVrasta/react-popper","homepage":"https://fezvrasta.github.io/react-popper/","size":1229,"stargazers_count":733,"watchers_count":733,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":98,"open_issues":7,"watchers":733,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FezVrasta/react-popper/pulls/197"},"html":{"href":"https://github.com/FezVrasta/react-popper/pull/197"},"issue":{"href":"https://api.github.com/repos/FezVrasta/react-popper/issues/197"},"comments":{"href":"https://api.github.com/repos/FezVrasta/react-popper/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/FezVrasta/react-popper/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/FezVrasta/react-popper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FezVrasta/react-popper/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/FezVrasta/react-popper/statuses/82dac08a2f2b4b34fe794bc46f3c4398242d294b"}},"author_association":"NONE"}}
{"actor":{"display_login":"FezVrasta"}}