{"action":"created","issue":{"url":"https://api.github.com/repos/EasyRPG/liblcf/issues/229","repository_url":"https://api.github.com/repos/EasyRPG/liblcf","labels_url":"https://api.github.com/repos/EasyRPG/liblcf/issues/229/labels{/name}","comments_url":"https://api.github.com/repos/EasyRPG/liblcf/issues/229/comments","events_url":"https://api.github.com/repos/EasyRPG/liblcf/issues/229/events","html_url":"https://github.com/EasyRPG/liblcf/issues/229","id":344199710,"node_id":"MDU6SXNzdWUzNDQxOTk3MTA=","number":229,"title":"liblcf should not skip empty arrays","user":{"login":"fdelapena","id":174885,"node_id":"MDQ6VXNlcjE3NDg4NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174885?v=4","gravatar_id":"","url":"https://api.github.com/users/fdelapena","html_url":"https://github.com/fdelapena","followers_url":"https://api.github.com/users/fdelapena/followers","following_url":"https://api.github.com/users/fdelapena/following{/other_user}","gists_url":"https://api.github.com/users/fdelapena/gists{/gist_id}","starred_url":"https://api.github.com/users/fdelapena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdelapena/subscriptions","organizations_url":"https://api.github.com/users/fdelapena/orgs","repos_url":"https://api.github.com/users/fdelapena/repos","events_url":"https://api.github.com/users/fdelapena/events{/privacy}","received_events_url":"https://api.github.com/users/fdelapena/received_events","type":"User","site_admin":false},"labels":[{"id":84676502,"node_id":"MDU6TGFiZWw4NDY3NjUwMg==","url":"https://api.github.com/repos/EasyRPG/liblcf/labels/Chunks","name":"Chunks","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-24T20:53:56Z","updated_at":"2018-07-24T21:14:25Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"This issue makes liblcf remove chunks which should be saved empty.\r\nThis affects starting party and may be related with an old menu commands issue.\r\nChanging this behaviour may require updating stuff in Player."},"comment":{"url":"https://api.github.com/repos/EasyRPG/liblcf/issues/comments/407554398","html_url":"https://github.com/EasyRPG/liblcf/issues/229#issuecomment-407554398","issue_url":"https://api.github.com/repos/EasyRPG/liblcf/issues/229","id":407554398,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzU1NDM5OA==","user":{"login":"20kdc","id":22304167,"node_id":"MDQ6VXNlcjIyMzA0MTY3","avatar_url":"https://avatars2.githubusercontent.com/u/22304167?v=4","gravatar_id":"","url":"https://api.github.com/users/20kdc","html_url":"https://github.com/20kdc","followers_url":"https://api.github.com/users/20kdc/followers","following_url":"https://api.github.com/users/20kdc/following{/other_user}","gists_url":"https://api.github.com/users/20kdc/gists{/gist_id}","starred_url":"https://api.github.com/users/20kdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/20kdc/subscriptions","organizations_url":"https://api.github.com/users/20kdc/orgs","repos_url":"https://api.github.com/users/20kdc/repos","events_url":"https://api.github.com/users/20kdc/events{/privacy}","received_events_url":"https://api.github.com/users/20kdc/received_events","type":"User","site_admin":false},"created_at":"2018-07-24T21:14:25Z","updated_at":"2018-07-24T21:14:25Z","author_association":"NONE","body":"I don't think fixing this will directly impact Player (saving empty arrays can only make things more correct, short of optional arrays that we don't know about), but giving the correct default values, which I think are:\r\n\r\nparty: length 1, contents: [1]\r\nmenu commands: length 1, contents: [0]\r\n\r\ncould cause conflict with the 2k3 detection heuristics. The second might, in any case."}}
{"actor":{"display_login":"20kdc"}}