{"action":"created","comment":{"url":"https://api.github.com/repos/netket/netket/pulls/comments/196078167","pull_request_review_id":129559737,"id":196078167,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjA3ODE2Nw==","diff_hunk":"@@ -77,6 +78,8 @@ class Machine : public AbstractMachine<T> {\n       m_ = Ptype(new RbmSpin<T>(hilbert, pars));\n     } else if (pars[\"Machine\"][\"Name\"] == \"RbmMultival\") {\n       m_ = Ptype(new RbmMultival<T>(hilbert, pars));\n+    } else if (pars[\"Machine\"][\"Name\"] == \"FFNN\") {\n+      m_ = Ptype(new FFNN<T>(hilbert, pars));","path":"NetKet/Machine/machine.hpp","position":13,"original_position":13,"commit_id":"e44731bc85f6b3532235904b4a806e2b82f715f2","original_commit_id":"e44731bc85f6b3532235904b4a806e2b82f715f2","user":{"login":"femtobit","id":4601206,"node_id":"MDQ6VXNlcjQ2MDEyMDY=","avatar_url":"https://avatars1.githubusercontent.com/u/4601206?v=4","gravatar_id":"","url":"https://api.github.com/users/femtobit","html_url":"https://github.com/femtobit","followers_url":"https://api.github.com/users/femtobit/followers","following_url":"https://api.github.com/users/femtobit/following{/other_user}","gists_url":"https://api.github.com/users/femtobit/gists{/gist_id}","starred_url":"https://api.github.com/users/femtobit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/femtobit/subscriptions","organizations_url":"https://api.github.com/users/femtobit/orgs","repos_url":"https://api.github.com/users/femtobit/repos","events_url":"https://api.github.com/users/femtobit/events{/privacy}","received_events_url":"https://api.github.com/users/femtobit/received_events","type":"User","site_admin":false},"body":"Also minor: If \"Machine.Name\" is neither of those values then `m_` will not be set which is an error. This should not happen in practise (as `CheckInput` should be called before passing the input to this function) but I'd add an `assert(CheckInput(pars));` at the start of this function to make sure this never happens (in release mode, the assert will not be compiled so there is no performance problem from checking the input multiple times there).","created_at":"2018-06-18T13:32:58Z","updated_at":"2018-06-18T13:38:58Z","html_url":"https://github.com/netket/netket/pull/36#discussion_r196078167","pull_request_url":"https://api.github.com/repos/netket/netket/pulls/36","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/netket/netket/pulls/comments/196078167"},"html":{"href":"https://github.com/netket/netket/pull/36#discussion_r196078167"},"pull_request":{"href":"https://api.github.com/repos/netket/netket/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/netket/netket/pulls/36","id":195267459,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjY3NDU5","html_url":"https://github.com/netket/netket/pull/36","diff_url":"https://github.com/netket/netket/pull/36.diff","patch_url":"https://github.com/netket/netket/pull/36.patch","issue_url":"https://api.github.com/repos/netket/netket/issues/36","number":36,"state":"open","locked":false,"title":"Feedforward","user":{"login":"kchoo1118","id":39584601,"node_id":"MDQ6VXNlcjM5NTg0NjAx","avatar_url":"https://avatars1.githubusercontent.com/u/39584601?v=4","gravatar_id":"","url":"https://api.github.com/users/kchoo1118","html_url":"https://github.com/kchoo1118","followers_url":"https://api.github.com/users/kchoo1118/followers","following_url":"https://api.github.com/users/kchoo1118/following{/other_user}","gists_url":"https://api.github.com/users/kchoo1118/gists{/gist_id}","starred_url":"https://api.github.com/users/kchoo1118/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kchoo1118/subscriptions","organizations_url":"https://api.github.com/users/kchoo1118/orgs","repos_url":"https://api.github.com/users/kchoo1118/repos","events_url":"https://api.github.com/users/kchoo1118/events{/privacy}","received_events_url":"https://api.github.com/users/kchoo1118/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-15T19:48:16Z","updated_at":"2018-06-18T13:38:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e345b9793c07519c868ac507eac328ca256c4bd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"carrasqu","id":9661833,"node_id":"MDQ6VXNlcjk2NjE4MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/9661833?v=4","gravatar_id":"","url":"https://api.github.com/users/carrasqu","html_url":"https://github.com/carrasqu","followers_url":"https://api.github.com/users/carrasqu/followers","following_url":"https://api.github.com/users/carrasqu/following{/other_user}","gists_url":"https://api.github.com/users/carrasqu/gists{/gist_id}","starred_url":"https://api.github.com/users/carrasqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carrasqu/subscriptions","organizations_url":"https://api.github.com/users/carrasqu/orgs","repos_url":"https://api.github.com/users/carrasqu/repos","events_url":"https://api.github.com/users/carrasqu/events{/privacy}","received_events_url":"https://api.github.com/users/carrasqu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/netket/netket/pulls/36/commits","review_comments_url":"https://api.github.com/repos/netket/netket/pulls/36/comments","review_comment_url":"https://api.github.com/repos/netket/netket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netket/netket/issues/36/comments","statuses_url":"https://api.github.com/repos/netket/netket/statuses/e44731bc85f6b3532235904b4a806e2b82f715f2","head":{"label":"kchoo1118:feedforward","ref":"feedforward","sha":"e44731bc85f6b3532235904b4a806e2b82f715f2","user":{"login":"kchoo1118","id":39584601,"node_id":"MDQ6VXNlcjM5NTg0NjAx","avatar_url":"https://avatars1.githubusercontent.com/u/39584601?v=4","gravatar_id":"","url":"https://api.github.com/users/kchoo1118","html_url":"https://github.com/kchoo1118","followers_url":"https://api.github.com/users/kchoo1118/followers","following_url":"https://api.github.com/users/kchoo1118/following{/other_user}","gists_url":"https://api.github.com/users/kchoo1118/gists{/gist_id}","starred_url":"https://api.github.com/users/kchoo1118/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kchoo1118/subscriptions","organizations_url":"https://api.github.com/users/kchoo1118/orgs","repos_url":"https://api.github.com/users/kchoo1118/repos","events_url":"https://api.github.com/users/kchoo1118/events{/privacy}","received_events_url":"https://api.github.com/users/kchoo1118/received_events","type":"User","site_admin":false},"repo":{"id":135637479,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2Mzc0Nzk=","name":"netket","full_name":"kchoo1118/netket","owner":{"login":"kchoo1118","id":39584601,"node_id":"MDQ6VXNlcjM5NTg0NjAx","avatar_url":"https://avatars1.githubusercontent.com/u/39584601?v=4","gravatar_id":"","url":"https://api.github.com/users/kchoo1118","html_url":"https://github.com/kchoo1118","followers_url":"https://api.github.com/users/kchoo1118/followers","following_url":"https://api.github.com/users/kchoo1118/following{/other_user}","gists_url":"https://api.github.com/users/kchoo1118/gists{/gist_id}","starred_url":"https://api.github.com/users/kchoo1118/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kchoo1118/subscriptions","organizations_url":"https://api.github.com/users/kchoo1118/orgs","repos_url":"https://api.github.com/users/kchoo1118/repos","events_url":"https://api.github.com/users/kchoo1118/events{/privacy}","received_events_url":"https://api.github.com/users/kchoo1118/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kchoo1118/netket","description":"Machine learning algorithms for many-body quantum systems ","fork":true,"url":"https://api.github.com/repos/kchoo1118/netket","forks_url":"https://api.github.com/repos/kchoo1118/netket/forks","keys_url":"https://api.github.com/repos/kchoo1118/netket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kchoo1118/netket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kchoo1118/netket/teams","hooks_url":"https://api.github.com/repos/kchoo1118/netket/hooks","issue_events_url":"https://api.github.com/repos/kchoo1118/netket/issues/events{/number}","events_url":"https://api.github.com/repos/kchoo1118/netket/events","assignees_url":"https://api.github.com/repos/kchoo1118/netket/assignees{/user}","branches_url":"https://api.github.com/repos/kchoo1118/netket/branches{/branch}","tags_url":"https://api.github.com/repos/kchoo1118/netket/tags","blobs_url":"https://api.github.com/repos/kchoo1118/netket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kchoo1118/netket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kchoo1118/netket/git/refs{/sha}","trees_url":"https://api.github.com/repos/kchoo1118/netket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kchoo1118/netket/statuses/{sha}","languages_url":"https://api.github.com/repos/kchoo1118/netket/languages","stargazers_url":"https://api.github.com/repos/kchoo1118/netket/stargazers","contributors_url":"https://api.github.com/repos/kchoo1118/netket/contributors","subscribers_url":"https://api.github.com/repos/kchoo1118/netket/subscribers","subscription_url":"https://api.github.com/repos/kchoo1118/netket/subscription","commits_url":"https://api.github.com/repos/kchoo1118/netket/commits{/sha}","git_commits_url":"https://api.github.com/repos/kchoo1118/netket/git/commits{/sha}","comments_url":"https://api.github.com/repos/kchoo1118/netket/comments{/number}","issue_comment_url":"https://api.github.com/repos/kchoo1118/netket/issues/comments{/number}","contents_url":"https://api.github.com/repos/kchoo1118/netket/contents/{+path}","compare_url":"https://api.github.com/repos/kchoo1118/netket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kchoo1118/netket/merges","archive_url":"https://api.github.com/repos/kchoo1118/netket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kchoo1118/netket/downloads","issues_url":"https://api.github.com/repos/kchoo1118/netket/issues{/number}","pulls_url":"https://api.github.com/repos/kchoo1118/netket/pulls{/number}","milestones_url":"https://api.github.com/repos/kchoo1118/netket/milestones{/number}","notifications_url":"https://api.github.com/repos/kchoo1118/netket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kchoo1118/netket/labels{/name}","releases_url":"https://api.github.com/repos/kchoo1118/netket/releases{/id}","deployments_url":"https://api.github.com/repos/kchoo1118/netket/deployments","created_at":"2018-05-31T21:34:24Z","updated_at":"2018-06-15T19:24:58Z","pushed_at":"2018-06-15T22:06:45Z","git_url":"git://github.com/kchoo1118/netket.git","ssh_url":"git@github.com:kchoo1118/netket.git","clone_url":"https://github.com/kchoo1118/netket.git","svn_url":"https://github.com/kchoo1118/netket","homepage":"https://www.netket.org","size":25609,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netket:feature/feedforward","ref":"feature/feedforward","sha":"66c24d47702bc0610e4fc92d2262475fcb03810a","user":{"login":"netket","id":38641916,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjQxOTE2","avatar_url":"https://avatars2.githubusercontent.com/u/38641916?v=4","gravatar_id":"","url":"https://api.github.com/users/netket","html_url":"https://github.com/netket","followers_url":"https://api.github.com/users/netket/followers","following_url":"https://api.github.com/users/netket/following{/other_user}","gists_url":"https://api.github.com/users/netket/gists{/gist_id}","starred_url":"https://api.github.com/users/netket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netket/subscriptions","organizations_url":"https://api.github.com/users/netket/orgs","repos_url":"https://api.github.com/users/netket/repos","events_url":"https://api.github.com/users/netket/events{/privacy}","received_events_url":"https://api.github.com/users/netket/received_events","type":"Organization","site_admin":false},"repo":{"id":130741783,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA3NDE3ODM=","name":"netket","full_name":"netket/netket","owner":{"login":"netket","id":38641916,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjQxOTE2","avatar_url":"https://avatars2.githubusercontent.com/u/38641916?v=4","gravatar_id":"","url":"https://api.github.com/users/netket","html_url":"https://github.com/netket","followers_url":"https://api.github.com/users/netket/followers","following_url":"https://api.github.com/users/netket/following{/other_user}","gists_url":"https://api.github.com/users/netket/gists{/gist_id}","starred_url":"https://api.github.com/users/netket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netket/subscriptions","organizations_url":"https://api.github.com/users/netket/orgs","repos_url":"https://api.github.com/users/netket/repos","events_url":"https://api.github.com/users/netket/events{/privacy}","received_events_url":"https://api.github.com/users/netket/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netket/netket","description":"Machine learning algorithms for many-body quantum systems ","fork":false,"url":"https://api.github.com/repos/netket/netket","forks_url":"https://api.github.com/repos/netket/netket/forks","keys_url":"https://api.github.com/repos/netket/netket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netket/netket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netket/netket/teams","hooks_url":"https://api.github.com/repos/netket/netket/hooks","issue_events_url":"https://api.github.com/repos/netket/netket/issues/events{/number}","events_url":"https://api.github.com/repos/netket/netket/events","assignees_url":"https://api.github.com/repos/netket/netket/assignees{/user}","branches_url":"https://api.github.com/repos/netket/netket/branches{/branch}","tags_url":"https://api.github.com/repos/netket/netket/tags","blobs_url":"https://api.github.com/repos/netket/netket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netket/netket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netket/netket/git/refs{/sha}","trees_url":"https://api.github.com/repos/netket/netket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netket/netket/statuses/{sha}","languages_url":"https://api.github.com/repos/netket/netket/languages","stargazers_url":"https://api.github.com/repos/netket/netket/stargazers","contributors_url":"https://api.github.com/repos/netket/netket/contributors","subscribers_url":"https://api.github.com/repos/netket/netket/subscribers","subscription_url":"https://api.github.com/repos/netket/netket/subscription","commits_url":"https://api.github.com/repos/netket/netket/commits{/sha}","git_commits_url":"https://api.github.com/repos/netket/netket/git/commits{/sha}","comments_url":"https://api.github.com/repos/netket/netket/comments{/number}","issue_comment_url":"https://api.github.com/repos/netket/netket/issues/comments{/number}","contents_url":"https://api.github.com/repos/netket/netket/contents/{+path}","compare_url":"https://api.github.com/repos/netket/netket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netket/netket/merges","archive_url":"https://api.github.com/repos/netket/netket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netket/netket/downloads","issues_url":"https://api.github.com/repos/netket/netket/issues{/number}","pulls_url":"https://api.github.com/repos/netket/netket/pulls{/number}","milestones_url":"https://api.github.com/repos/netket/netket/milestones{/number}","notifications_url":"https://api.github.com/repos/netket/netket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netket/netket/labels{/name}","releases_url":"https://api.github.com/repos/netket/netket/releases{/id}","deployments_url":"https://api.github.com/repos/netket/netket/deployments","created_at":"2018-04-23T18:48:08Z","updated_at":"2018-06-15T09:01:03Z","pushed_at":"2018-06-15T22:06:46Z","git_url":"git://github.com/netket/netket.git","ssh_url":"git@github.com:netket/netket.git","clone_url":"https://github.com/netket/netket.git","svn_url":"https://github.com/netket/netket","homepage":"https://www.netket.org","size":2009,"stargazers_count":39,"watchers_count":39,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":11,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netket/netket/pulls/36"},"html":{"href":"https://github.com/netket/netket/pull/36"},"issue":{"href":"https://api.github.com/repos/netket/netket/issues/36"},"comments":{"href":"https://api.github.com/repos/netket/netket/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/netket/netket/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/netket/netket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netket/netket/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/netket/netket/statuses/e44731bc85f6b3532235904b4a806e2b82f715f2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"femtobit"}}