{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/37207","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/37207/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/37207/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/37207/events","html_url":"https://github.com/ansible/ansible/pull/37207","id":303573575,"number":37207,"title":"1password plugin","user":{"login":"scottsb","id":6756989,"avatar_url":"https://avatars2.githubusercontent.com/u/6756989?v=4","gravatar_id":"","url":"https://api.github.com/users/scottsb","html_url":"https://github.com/scottsb","followers_url":"https://api.github.com/users/scottsb/followers","following_url":"https://api.github.com/users/scottsb/following{/other_user}","gists_url":"https://api.github.com/users/scottsb/gists{/gist_id}","starred_url":"https://api.github.com/users/scottsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottsb/subscriptions","organizations_url":"https://api.github.com/users/scottsb/orgs","repos_url":"https://api.github.com/users/scottsb/repos","events_url":"https://api.github.com/users/scottsb/events{/privacy}","received_events_url":"https://api.github.com/users/scottsb/received_events","type":"User","site_admin":false},"labels":[{"id":852590921,"url":"https://api.github.com/repos/ansible/ansible/labels/feature","name":"feature","color":"006b75","default":false},{"id":503572087,"url":"https://api.github.com/repos/ansible/ansible/labels/needs_triage","name":"needs_triage","color":"0e8a16","default":false},{"id":636352796,"url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false},{"id":468273802,"url":"https://api.github.com/repos/ansible/ansible/labels/test","name":"test","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-08T17:56:05Z","updated_at":"2018-03-08T18:29:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/37207","html_url":"https://github.com/ansible/ansible/pull/37207","diff_url":"https://github.com/ansible/ansible/pull/37207.diff","patch_url":"https://github.com/ansible/ansible/pull/37207.patch"},"body":"##### SUMMARY\r\nAdd lookup plugin for 1Password using [new CLI tool](https://support.1password.com/command-line/). Based on existing plugin for LastPass.\r\n\r\n##### ISSUE TYPE\r\n - Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\nonepassword\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes below -->\r\n```\r\nansible 2.4.0.0\r\n  config file = None\r\n  configured module search path = [u'/Users/scottbuchanan/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']\r\n  ansible python module location = /Library/Python/2.7/site-packages/ansible\r\n  executable location = /usr/local/bin/ansible\r\n  python version = 2.7.10 (default, Jul 15 2017, 17:16:57) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.31)]\r\n```\r\n\r\n##### ADDITIONAL INFORMATION\r\n- Python is not a language I work in regularly, so please feel free to point out anything that could be more Pythonic or where there is a more Ansible-like way to do things.\r\n- I'm not sure if the the `ANSIBLE_METADATA` or copyright information is what it should be. I could not find guidelines on these; please advice or point me in the right direction. Also, the `version_added` in the plugin documentation will need to be adjusted."},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/371578951","html_url":"https://github.com/ansible/ansible/pull/37207#issuecomment-371578951","issue_url":"https://api.github.com/repos/ansible/ansible/issues/37207","id":371578951,"user":{"login":"ansibot","id":6585283,"avatar_url":"https://avatars0.githubusercontent.com/u/6585283?v=4","gravatar_id":"","url":"https://api.github.com/users/ansibot","html_url":"https://github.com/ansibot","followers_url":"https://api.github.com/users/ansibot/followers","following_url":"https://api.github.com/users/ansibot/following{/other_user}","gists_url":"https://api.github.com/users/ansibot/gists{/gist_id}","starred_url":"https://api.github.com/users/ansibot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansibot/subscriptions","organizations_url":"https://api.github.com/users/ansibot/orgs","repos_url":"https://api.github.com/users/ansibot/repos","events_url":"https://api.github.com/users/ansibot/events{/privacy}","received_events_url":"https://api.github.com/users/ansibot/received_events","type":"User","site_admin":false},"created_at":"2018-03-08T18:29:30Z","updated_at":"2018-03-08T18:29:30Z","author_association":"CONTRIBUTOR","body":"The test `ansible-test sanity --test pylint` [[explain](https://docs.ansible.com/ansible/devel/dev_guide/testing/sanity/pylint.html)] failed with 6 errors:\n```\nlib/ansible/plugins/lookup/onepassword.py:77:17: ansible-format-automatic-specification Format string contains automatic field numbering specification\nlib/ansible/plugins/lookup/onepassword.py:80:21: ansible-format-automatic-specification Format string contains automatic field numbering specification\ntest/units/plugins/lookup/test_onepassword.py:23:0: multiple-imports Multiple imports on one line (json, datetime)\ntest/units/plugins/lookup/test_onepassword.py:153:24: ansible-format-automatic-specification Format string contains automatic field numbering specification\ntest/units/plugins/lookup/test_onepassword.py:167:43: ansible-format-automatic-specification Format string contains automatic field numbering specification\ntest/units/plugins/lookup/test_onepassword.py:175:31: ansible-format-automatic-specification Format string contains automatic field numbering specification\n```\n<!-- job_id: 5aa179370648721600ce7080 -->\n<!-- job_id: 5aa1793ade94891600b7c36c -->\n<!-- job_id: /testresults/ansible-test-sanity-pylint.json -->\nThe test `ansible-test sanity --test no-underscore-variable` [[explain](https://docs.ansible.com/ansible/devel/dev_guide/testing/sanity/no-underscore-variable.html)] failed with 4 errors:\n```\nlib/ansible/plugins/lookup/onepassword.py:81:15: use `dummy` instead of `_` for a variable name\ntest/units/plugins/lookup/test_onepassword.py:214:13: use `dummy` instead of `_` for a variable name\ntest/units/plugins/lookup/test_onepassword.py:229:9: use `dummy` instead of `_` for a variable name\ntest/units/plugins/lookup/test_onepassword.py:250:9: use `dummy` instead of `_` for a variable name\n```\n<!-- job_id: 5aa179370648721600ce7080 -->\n<!-- job_id: 5aa1793ade94891600b7c36b -->\n<!-- job_id: /testresults/ansible-test-sanity-no-underscore-variable.json -->\nThe test `ansible-test sanity --test pep8` [[explain](https://docs.ansible.com/ansible/devel/dev_guide/testing/sanity/pep8.html)] failed with 17 errors:\n```\nlib/ansible/plugins/lookup/onepassword.py:56:1: E302 expected 2 blank lines, found 1\ntest/units/plugins/lookup/test_onepassword.py:23:12: E401 multiple imports on one line\ntest/units/plugins/lookup/test_onepassword.py:60:26: E201 whitespace after '{'\ntest/units/plugins/lookup/test_onepassword.py:60:60: E202 whitespace before '}'\ntest/units/plugins/lookup/test_onepassword.py:61:26: E201 whitespace after '{'\ntest/units/plugins/lookup/test_onepassword.py:61:60: E202 whitespace before '}'\ntest/units/plugins/lookup/test_onepassword.py:62:26: E201 whitespace after '{'\ntest/units/plugins/lookup/test_onepassword.py:62:102: E202 whitespace before '}'\ntest/units/plugins/lookup/test_onepassword.py:63:26: E201 whitespace after '{'\ntest/units/plugins/lookup/test_onepassword.py:63:83: E202 whitespace before '}'\ntest/units/plugins/lookup/test_onepassword.py:82:22: E201 whitespace after '{'\ntest/units/plugins/lookup/test_onepassword.py:82:68: E202 whitespace before '}'\ntest/units/plugins/lookup/test_onepassword.py:88:26: E201 whitespace after '{'\ntest/units/plugins/lookup/test_onepassword.py:88:60: E202 whitespace before '}'\ntest/units/plugins/lookup/test_onepassword.py:96:1: E302 expected 2 blank lines, found 1\ntest/units/plugins/lookup/test_onepassword.py:104:1: E302 expected 2 blank lines, found 1\ntest/units/plugins/lookup/test_onepassword.py:171:32: E221 multiple spaces before operator\n```\n<!-- job_id: 5aa179370648721600ce7080 -->\n<!-- job_id: 5aa1793ade94891600b7c36b -->\n<!-- job_id: /testresults/ansible-test-sanity-pep8.json -->\n\n[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)\n<!--- boilerplate: shippable_test_result --->"}}
{"actor":{"display_login":"ansibot"}}