{"action":"created","comment":{"url":"https://api.github.com/repos/electron/libchromiumcontent/pulls/comments/195675440","pull_request_review_id":129092205,"id":195675440,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTY3NTQ0MA==","diff_hunk":"@@ -0,0 +1,235 @@\n+From 5020630808043615f2f6fbbfba1ea73342bebd69 Mon Sep 17 00:00:00 2001\n+From: Daniel Clifford <danno@chromium.org>\n+Date: Wed, 28 Mar 2018 13:30:16 +0200\n+Subject: [PATCH] Remove legacy C++ implementation of Array#slice","path":"patches/common/v8/backport_50206308.patch","position":4,"original_position":4,"commit_id":"4da8fce00b978a3e0a6340d9b9f287bbb10ca726","original_commit_id":"925240dc0382f737517bcd69431b9c18a5e4dea4","user":{"login":"deepak1556","id":964386,"node_id":"MDQ6VXNlcjk2NDM4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/964386?v=4","gravatar_id":"","url":"https://api.github.com/users/deepak1556","html_url":"https://github.com/deepak1556","followers_url":"https://api.github.com/users/deepak1556/followers","following_url":"https://api.github.com/users/deepak1556/following{/other_user}","gists_url":"https://api.github.com/users/deepak1556/gists{/gist_id}","starred_url":"https://api.github.com/users/deepak1556/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepak1556/subscriptions","organizations_url":"https://api.github.com/users/deepak1556/orgs","repos_url":"https://api.github.com/users/deepak1556/repos","events_url":"https://api.github.com/users/deepak1556/events{/privacy}","received_events_url":"https://api.github.com/users/deepak1556/received_events","type":"User","site_admin":false},"body":"Yup its clear now, thanks!\r\n\r\n> Hence, there were some calls to functions which did not exist after the \"separate species protector\" patch\r\n\r\nWouldn't it be just this `isolate->IsSpeciesLookupChainIntact()` call, which can be converted to use the array specific protector. I didn't find any other conflicting call when applying https://chromium-review.googlesource.com/c/v8/v8/+/1030553. The current solution looks good to me, but if the goal is to keep patches minimal I would prefer making that function call change.","created_at":"2018-06-15T09:12:06Z","updated_at":"2018-06-15T09:12:07Z","html_url":"https://github.com/electron/libchromiumcontent/pull/555#discussion_r195675440","pull_request_url":"https://api.github.com/repos/electron/libchromiumcontent/pulls/555","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/electron/libchromiumcontent/pulls/comments/195675440"},"html":{"href":"https://github.com/electron/libchromiumcontent/pull/555#discussion_r195675440"},"pull_request":{"href":"https://api.github.com/repos/electron/libchromiumcontent/pulls/555"}},"in_reply_to_id":195360950},"pull_request":{"url":"https://api.github.com/repos/electron/libchromiumcontent/pulls/555","id":194742286,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzQyMjg2","html_url":"https://github.com/electron/libchromiumcontent/pull/555","diff_url":"https://github.com/electron/libchromiumcontent/pull/555.diff","patch_url":"https://github.com/electron/libchromiumcontent/pull/555.patch","issue_url":"https://api.github.com/repos/electron/libchromiumcontent/issues/555","number":555,"state":"open","locked":false,"title":"Patches to backport the array splice performance regression caused in ch66.","user":{"login":"nitsakh","id":5625083,"node_id":"MDQ6VXNlcjU2MjUwODM=","avatar_url":"https://avatars1.githubusercontent.com/u/5625083?v=4","gravatar_id":"","url":"https://api.github.com/users/nitsakh","html_url":"https://github.com/nitsakh","followers_url":"https://api.github.com/users/nitsakh/followers","following_url":"https://api.github.com/users/nitsakh/following{/other_user}","gists_url":"https://api.github.com/users/nitsakh/gists{/gist_id}","starred_url":"https://api.github.com/users/nitsakh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitsakh/subscriptions","organizations_url":"https://api.github.com/users/nitsakh/orgs","repos_url":"https://api.github.com/users/nitsakh/repos","events_url":"https://api.github.com/users/nitsakh/events{/privacy}","received_events_url":"https://api.github.com/users/nitsakh/received_events","type":"User","site_admin":false},"body":"This backports two commits to fix the array splice regression caused in ch66.\r\nThe patches represent those commits and fixing some merge conflicts etc.\r\nPlease suggest a sensible number for the patch version for v8.\r\nThis addresses https://github.com/electron/electron/issues/13153.\r\n","created_at":"2018-06-13T23:25:55Z","updated_at":"2018-06-15T09:12:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89a3f83eae56a9b25875251a47f0fefa3085a51a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/electron/libchromiumcontent/pulls/555/commits","review_comments_url":"https://api.github.com/repos/electron/libchromiumcontent/pulls/555/comments","review_comment_url":"https://api.github.com/repos/electron/libchromiumcontent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/libchromiumcontent/issues/555/comments","statuses_url":"https://api.github.com/repos/electron/libchromiumcontent/statuses/4da8fce00b978a3e0a6340d9b9f287bbb10ca726","head":{"label":"electron:fix-array-splice","ref":"fix-array-splice","sha":"4da8fce00b978a3e0a6340d9b9f287bbb10ca726","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":8479951,"node_id":"MDEwOlJlcG9zaXRvcnk4NDc5OTUx","name":"libchromiumcontent","full_name":"electron/libchromiumcontent","owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electron/libchromiumcontent","description":"Shared library build of Chromium’s Content module","fork":false,"url":"https://api.github.com/repos/electron/libchromiumcontent","forks_url":"https://api.github.com/repos/electron/libchromiumcontent/forks","keys_url":"https://api.github.com/repos/electron/libchromiumcontent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/libchromiumcontent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/libchromiumcontent/teams","hooks_url":"https://api.github.com/repos/electron/libchromiumcontent/hooks","issue_events_url":"https://api.github.com/repos/electron/libchromiumcontent/issues/events{/number}","events_url":"https://api.github.com/repos/electron/libchromiumcontent/events","assignees_url":"https://api.github.com/repos/electron/libchromiumcontent/assignees{/user}","branches_url":"https://api.github.com/repos/electron/libchromiumcontent/branches{/branch}","tags_url":"https://api.github.com/repos/electron/libchromiumcontent/tags","blobs_url":"https://api.github.com/repos/electron/libchromiumcontent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/libchromiumcontent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/libchromiumcontent/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/libchromiumcontent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/libchromiumcontent/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/libchromiumcontent/languages","stargazers_url":"https://api.github.com/repos/electron/libchromiumcontent/stargazers","contributors_url":"https://api.github.com/repos/electron/libchromiumcontent/contributors","subscribers_url":"https://api.github.com/repos/electron/libchromiumcontent/subscribers","subscription_url":"https://api.github.com/repos/electron/libchromiumcontent/subscription","commits_url":"https://api.github.com/repos/electron/libchromiumcontent/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/libchromiumcontent/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/libchromiumcontent/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/libchromiumcontent/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/libchromiumcontent/contents/{+path}","compare_url":"https://api.github.com/repos/electron/libchromiumcontent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/libchromiumcontent/merges","archive_url":"https://api.github.com/repos/electron/libchromiumcontent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/libchromiumcontent/downloads","issues_url":"https://api.github.com/repos/electron/libchromiumcontent/issues{/number}","pulls_url":"https://api.github.com/repos/electron/libchromiumcontent/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/libchromiumcontent/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/libchromiumcontent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/libchromiumcontent/labels{/name}","releases_url":"https://api.github.com/repos/electron/libchromiumcontent/releases{/id}","deployments_url":"https://api.github.com/repos/electron/libchromiumcontent/deployments","created_at":"2013-02-28T13:48:40Z","updated_at":"2018-06-14T07:27:04Z","pushed_at":"2018-06-15T08:09:54Z","git_url":"git://github.com/electron/libchromiumcontent.git","ssh_url":"git@github.com:electron/libchromiumcontent.git","clone_url":"https://github.com/electron/libchromiumcontent.git","svn_url":"https://github.com/electron/libchromiumcontent","homepage":"","size":38159,"stargazers_count":431,"watchers_count":431,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":160,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":160,"open_issues":40,"watchers":431,"default_branch":"master"}},"base":{"label":"electron:chromium-upgrade/66","ref":"chromium-upgrade/66","sha":"b9a68acb7e1f93193540cdf94f73ad6ba22c7900","user":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":8479951,"node_id":"MDEwOlJlcG9zaXRvcnk4NDc5OTUx","name":"libchromiumcontent","full_name":"electron/libchromiumcontent","owner":{"login":"electron","id":13409222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDA5MjIy","avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electron/libchromiumcontent","description":"Shared library build of Chromium’s Content module","fork":false,"url":"https://api.github.com/repos/electron/libchromiumcontent","forks_url":"https://api.github.com/repos/electron/libchromiumcontent/forks","keys_url":"https://api.github.com/repos/electron/libchromiumcontent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/libchromiumcontent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/libchromiumcontent/teams","hooks_url":"https://api.github.com/repos/electron/libchromiumcontent/hooks","issue_events_url":"https://api.github.com/repos/electron/libchromiumcontent/issues/events{/number}","events_url":"https://api.github.com/repos/electron/libchromiumcontent/events","assignees_url":"https://api.github.com/repos/electron/libchromiumcontent/assignees{/user}","branches_url":"https://api.github.com/repos/electron/libchromiumcontent/branches{/branch}","tags_url":"https://api.github.com/repos/electron/libchromiumcontent/tags","blobs_url":"https://api.github.com/repos/electron/libchromiumcontent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/libchromiumcontent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/libchromiumcontent/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/libchromiumcontent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/libchromiumcontent/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/libchromiumcontent/languages","stargazers_url":"https://api.github.com/repos/electron/libchromiumcontent/stargazers","contributors_url":"https://api.github.com/repos/electron/libchromiumcontent/contributors","subscribers_url":"https://api.github.com/repos/electron/libchromiumcontent/subscribers","subscription_url":"https://api.github.com/repos/electron/libchromiumcontent/subscription","commits_url":"https://api.github.com/repos/electron/libchromiumcontent/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/libchromiumcontent/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/libchromiumcontent/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/libchromiumcontent/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/libchromiumcontent/contents/{+path}","compare_url":"https://api.github.com/repos/electron/libchromiumcontent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/libchromiumcontent/merges","archive_url":"https://api.github.com/repos/electron/libchromiumcontent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/libchromiumcontent/downloads","issues_url":"https://api.github.com/repos/electron/libchromiumcontent/issues{/number}","pulls_url":"https://api.github.com/repos/electron/libchromiumcontent/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/libchromiumcontent/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/libchromiumcontent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/libchromiumcontent/labels{/name}","releases_url":"https://api.github.com/repos/electron/libchromiumcontent/releases{/id}","deployments_url":"https://api.github.com/repos/electron/libchromiumcontent/deployments","created_at":"2013-02-28T13:48:40Z","updated_at":"2018-06-14T07:27:04Z","pushed_at":"2018-06-15T08:09:54Z","git_url":"git://github.com/electron/libchromiumcontent.git","ssh_url":"git@github.com:electron/libchromiumcontent.git","clone_url":"https://github.com/electron/libchromiumcontent.git","svn_url":"https://github.com/electron/libchromiumcontent","homepage":"","size":38159,"stargazers_count":431,"watchers_count":431,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":160,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":160,"open_issues":40,"watchers":431,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/libchromiumcontent/pulls/555"},"html":{"href":"https://github.com/electron/libchromiumcontent/pull/555"},"issue":{"href":"https://api.github.com/repos/electron/libchromiumcontent/issues/555"},"comments":{"href":"https://api.github.com/repos/electron/libchromiumcontent/issues/555/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/libchromiumcontent/pulls/555/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/libchromiumcontent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/libchromiumcontent/pulls/555/commits"},"statuses":{"href":"https://api.github.com/repos/electron/libchromiumcontent/statuses/4da8fce00b978a3e0a6340d9b9f287bbb10ca726"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"deepak1556"}}