{"action":"created","issue":{"url":"https://api.github.com/repos/phoebe-project/phoebe2/issues/294","repository_url":"https://api.github.com/repos/phoebe-project/phoebe2","labels_url":"https://api.github.com/repos/phoebe-project/phoebe2/issues/294/labels{/name}","comments_url":"https://api.github.com/repos/phoebe-project/phoebe2/issues/294/comments","events_url":"https://api.github.com/repos/phoebe-project/phoebe2/issues/294/events","html_url":"https://github.com/phoebe-project/phoebe2/issues/294","id":344054242,"node_id":"MDU6SXNzdWUzNDQwNTQyNDI=","number":294,"title":"Setting contact_binary=True for at/near critical system might cause SegFault","user":{"login":"giammarc","id":20957571,"node_id":"MDQ6VXNlcjIwOTU3NTcx","avatar_url":"https://avatars0.githubusercontent.com/u/20957571?v=4","gravatar_id":"","url":"https://api.github.com/users/giammarc","html_url":"https://github.com/giammarc","followers_url":"https://api.github.com/users/giammarc/followers","following_url":"https://api.github.com/users/giammarc/following{/other_user}","gists_url":"https://api.github.com/users/giammarc/gists{/gist_id}","starred_url":"https://api.github.com/users/giammarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giammarc/subscriptions","organizations_url":"https://api.github.com/users/giammarc/orgs","repos_url":"https://api.github.com/users/giammarc/repos","events_url":"https://api.github.com/users/giammarc/events{/privacy}","received_events_url":"https://api.github.com/users/giammarc/received_events","type":"User","site_admin":false},"labels":[{"id":429017481,"node_id":"MDU6TGFiZWw0MjkwMTc0ODE=","url":"https://api.github.com/repos/phoebe-project/phoebe2/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-07-24T14:08:36Z","updated_at":"2018-09-18T18:18:18Z","closed_at":null,"author_association":"MEMBER","body":"Setting contact_binary=True for at/near critical system might cause SegFault.  For this system it does.  Attached are 1. A minimal script to reproduce the issue and 2. Notes from running through gdb.  3. Image of mesh when contact_binary=False.\r\n\r\nWith  contact_binary=True at  ./phoebe/lib/triang_marching.h:1669 delta has a value of -nan.  (see attached SegFault_Notes.txt)\r\n\r\nIf the potentials are set to critical values and contact_binary=False the mesh is created without issue.   See attached image.   \r\n\r\n**BUT** if 'irrad_method' != 'none' ( 'irrad_method' ='wilson') results are awful. I'll open another issue for that.\r\n\r\n![bsvul_crit0 25t](https://user-images.githubusercontent.com/20957571/43143582-8c15421c-8f4a-11e8-9253-ca0917f8d8db.png)\r\n[SegFault_Notes.txt](https://github.com/phoebe-project/phoebe2/files/2223953/SegFault_Notes.txt)\r\n[BSVul.py.txt](https://github.com/phoebe-project/phoebe2/files/2223956/BSVul.py.txt)\r\n"},"comment":{"url":"https://api.github.com/repos/phoebe-project/phoebe2/issues/comments/422495802","html_url":"https://github.com/phoebe-project/phoebe2/issues/294#issuecomment-422495802","issue_url":"https://api.github.com/repos/phoebe-project/phoebe2/issues/294","id":422495802,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjQ5NTgwMg==","user":{"login":"kecnry","id":877591,"node_id":"MDQ6VXNlcjg3NzU5MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/877591?v=4","gravatar_id":"","url":"https://api.github.com/users/kecnry","html_url":"https://github.com/kecnry","followers_url":"https://api.github.com/users/kecnry/followers","following_url":"https://api.github.com/users/kecnry/following{/other_user}","gists_url":"https://api.github.com/users/kecnry/gists{/gist_id}","starred_url":"https://api.github.com/users/kecnry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kecnry/subscriptions","organizations_url":"https://api.github.com/users/kecnry/orgs","repos_url":"https://api.github.com/users/kecnry/repos","events_url":"https://api.github.com/users/kecnry/events{/privacy}","received_events_url":"https://api.github.com/users/kecnry/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T18:18:18Z","updated_at":"2018-09-18T18:18:18Z","author_association":"MEMBER","body":"Can either of you (@horvatm or @giammarc) test to see if this check on requiv is sufficient?  I only implemented it for the case of contacts and only near the requiv_min critical value (so not overlow for contacts).  Is that reasonable?"}}
{"actor":{"display_login":"kecnry"}}