{"push_id":3107511698,"size":2,"distinct_size":2,"ref":"refs/heads/delhi","head":"f00c02597ca48f084afa959917a034f4da33a778","before":"f5e17b5b8e2028680f8bfec56d08bcc466f6440c","commits":[{"sha":"d5d3f506059e058a69ebd51a82212057b78ecb12","author":{"name":"Ian Johnson","email":"9bf56e8911b743430bd23560344a680697e62e50@canonical.com"},"message":"snap/many: replace usage of systemd-notify with forking daemons\n\nThis change is necessary because the daemon-notify interface is not implemented properly and is missing the capabilities \"net_admin\" and \"sys_admin\" in AppArmor in order to notify for a different process than the one that `systemd-notify` runs as. \nTo remedy this, we instead make all of the daemons that were using systemd-notify into forking daemons, with an additional forking wrapper which immediately forks a process such that systemd can always immediately think that the process has successfully started up. We also need to ensure that the process that is initially forked stays alive for the remainder of the lifetime of the service because that service will be the \"main\" PID that systemd tracks. So for the go services we need to use exec instead of just running it normally, and for the security-services wrapper we already are doing the right thing in the script by waiting for all the child processes to exit. This point is doubly important because systemd docs say that forking daemons should specify a PIDFile, which unfortunately we can't do in the snap, as snapd doesn't support this, so if the main PID isn't the PID that systemd sees initially, bad things will happen. As currently implemented however it's not a problem.\n\n\nSigned-off-by: Ian Johnson <ian.johnson@canonical.com>","distinct":true,"url":"https://api.github.com/repos/edgexfoundry/edgex-go/commits/d5d3f506059e058a69ebd51a82212057b78ecb12"},{"sha":"f00c02597ca48f084afa959917a034f4da33a778","author":{"name":"Ian Johnson","email":"8d937f34b17341d88305c9284d143b00830af5aa@gmail.com"},"message":"Merge pull request #885 from anonymouse64/bugfix/systemd-notify-pid\n\nsnap/many: replace usage of systemd-notify with forking daemons","distinct":true,"url":"https://api.github.com/repos/edgexfoundry/edgex-go/commits/f00c02597ca48f084afa959917a034f4da33a778"}]}
{"actor":{"display_login":"anonymouse64"}}