{"action":"created","comment":{"url":"https://api.github.com/repos/knative/serving/pulls/comments/206896724","pull_request_review_id":142395453,"id":206896724,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjg5NjcyNA==","diff_hunk":"@@ -346,63 +326,3 @@ func TestReconcile(t *testing.T) {\n \t\t}\n \t})\n }\n-\n-func cfgWithBuildAndStatus(name, namespace string, generation int64, build *buildv1alpha1.BuildSpec, status v1alpha1.ConfigurationStatus) *v1alpha1.Configuration {\n-\treturn &v1alpha1.Configuration{\n-\t\tObjectMeta: metav1.ObjectMeta{\n-\t\t\tName:      name,\n-\t\t\tNamespace: namespace,\n-\t\t},\n-\t\tSpec: v1alpha1.ConfigurationSpec{\n-\t\t\tGeneration: generation,\n-\t\t\tBuild:      build,\n-\t\t\tRevisionTemplate: v1alpha1.RevisionTemplateSpec{\n-\t\t\t\tSpec: revisionSpec,\n-\t\t\t},\n-\t\t},\n-\t\tStatus: status,\n-\t}\n-}\n-\n-func cfgWithStatus(name, namespace string, generation int64, status v1alpha1.ConfigurationStatus) *v1alpha1.Configuration {\n-\treturn cfgWithBuildAndStatus(name, namespace, generation, nil, status)\n-}\n-\n-func cfgWithBuild(name, namespace string, generation int64, build *buildv1alpha1.BuildSpec) *v1alpha1.Configuration {\n-\treturn cfgWithBuildAndStatus(name, namespace, generation, build, v1alpha1.ConfigurationStatus{})\n-}\n-\n-func cfg(name, namespace string, generation int64) *v1alpha1.Configuration {\n-\treturn cfgWithStatus(name, namespace, generation, v1alpha1.ConfigurationStatus{})\n-}\n-\n-func setConcurrencyModel(cfg *v1alpha1.Configuration, ss v1alpha1.RevisionRequestConcurrencyModelType) *v1alpha1.Configuration {\n-\tcfg.Spec.RevisionTemplate.Spec.ConcurrencyModel = ss\n-\treturn cfg\n-}\n-\n-func setRevConcurrencyModel(rev *v1alpha1.Revision, ss v1alpha1.RevisionRequestConcurrencyModelType) *v1alpha1.Revision {\n-\trev.Spec.ConcurrencyModel = ss\n-\treturn rev\n-}\n-\n-func makeRevReady(t *testing.T, rev *v1alpha1.Revision) *v1alpha1.Revision {\n-\trev.Status.InitializeConditions()\n-\trev.Status.MarkContainerHealthy()\n-\trev.Status.MarkResourcesAvailable()\n-\tif !rev.Status.IsReady() {\n-\t\tt.Fatalf(\"Wanted ready revision: %v\", rev)\n-\t}\n-\treturn rev\n-}\n-\n-func makeRevFailed(rev *v1alpha1.Revision) *v1alpha1.Revision {\n-\trev.Status.InitializeConditions()\n-\trev.Status.MarkContainerMissing(\"It's the end of the world as we know it\")\n-\treturn rev\n-}\n-\n-func makeRevStatus(rev *v1alpha1.Revision, status v1alpha1.RevisionStatus) *v1alpha1.Revision {\n-\trev.Status = status\n-\treturn rev\n-}","path":"pkg/controller/configuration/configuration_test.go","position":549,"original_position":549,"commit_id":"3f95d254a31a7a740502de781748c5320c3c26e4","original_commit_id":"3f95d254a31a7a740502de781748c5320c3c26e4","user":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"body":"🎉 ","created_at":"2018-08-01T14:16:33Z","updated_at":"2018-08-01T14:21:04Z","html_url":"https://github.com/knative/serving/pull/1762#discussion_r206896724","pull_request_url":"https://api.github.com/repos/knative/serving/pulls/1762","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/comments/206896724"},"html":{"href":"https://github.com/knative/serving/pull/1762#discussion_r206896724"},"pull_request":{"href":"https://api.github.com/repos/knative/serving/pulls/1762"}}},"pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/1762","id":204932066,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0OTMyMDY2","html_url":"https://github.com/knative/serving/pull/1762","diff_url":"https://github.com/knative/serving/pull/1762.diff","patch_url":"https://github.com/knative/serving/pull/1762.patch","issue_url":"https://api.github.com/repos/knative/serving/issues/1762","number":1762,"state":"open","locked":false,"title":"[PoC] Use builders to make table tests more readable","user":{"login":"dprotaso","id":18562,"node_id":"MDQ6VXNlcjE4NTYy","avatar_url":"https://avatars2.githubusercontent.com/u/18562?v=4","gravatar_id":"","url":"https://api.github.com/users/dprotaso","html_url":"https://github.com/dprotaso","followers_url":"https://api.github.com/users/dprotaso/followers","following_url":"https://api.github.com/users/dprotaso/following{/other_user}","gists_url":"https://api.github.com/users/dprotaso/gists{/gist_id}","starred_url":"https://api.github.com/users/dprotaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dprotaso/subscriptions","organizations_url":"https://api.github.com/users/dprotaso/orgs","repos_url":"https://api.github.com/users/dprotaso/repos","events_url":"https://api.github.com/users/dprotaso/events{/privacy}","received_events_url":"https://api.github.com/users/dprotaso/received_events","type":"User","site_admin":false},"body":"This is just a proof-of-concept to source feedback on whether folks like this pattern, and whether they feel this improves readability. This secondly helps reduce the combinatorial method names. ","created_at":"2018-07-30T21:14:47Z","updated_at":"2018-08-01T14:21:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"852c7d4500cdf8e5307caa53f3f698435c7b671e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"grantr","id":680,"node_id":"MDQ6VXNlcjY4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/680?v=4","gravatar_id":"","url":"https://api.github.com/users/grantr","html_url":"https://github.com/grantr","followers_url":"https://api.github.com/users/grantr/followers","following_url":"https://api.github.com/users/grantr/following{/other_user}","gists_url":"https://api.github.com/users/grantr/gists{/gist_id}","starred_url":"https://api.github.com/users/grantr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grantr/subscriptions","organizations_url":"https://api.github.com/users/grantr/orgs","repos_url":"https://api.github.com/users/grantr/repos","events_url":"https://api.github.com/users/grantr/events{/privacy}","received_events_url":"https://api.github.com/users/grantr/received_events","type":"User","site_admin":false},{"login":"tanzeeb","id":8570,"node_id":"MDQ6VXNlcjg1NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/8570?v=4","gravatar_id":"","url":"https://api.github.com/users/tanzeeb","html_url":"https://github.com/tanzeeb","followers_url":"https://api.github.com/users/tanzeeb/followers","following_url":"https://api.github.com/users/tanzeeb/following{/other_user}","gists_url":"https://api.github.com/users/tanzeeb/gists{/gist_id}","starred_url":"https://api.github.com/users/tanzeeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanzeeb/subscriptions","organizations_url":"https://api.github.com/users/tanzeeb/orgs","repos_url":"https://api.github.com/users/tanzeeb/repos","events_url":"https://api.github.com/users/tanzeeb/events{/privacy}","received_events_url":"https://api.github.com/users/tanzeeb/received_events","type":"User","site_admin":false},{"login":"shashwathi","id":9938926,"node_id":"MDQ6VXNlcjk5Mzg5MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/9938926?v=4","gravatar_id":"","url":"https://api.github.com/users/shashwathi","html_url":"https://github.com/shashwathi","followers_url":"https://api.github.com/users/shashwathi/followers","following_url":"https://api.github.com/users/shashwathi/following{/other_user}","gists_url":"https://api.github.com/users/shashwathi/gists{/gist_id}","starred_url":"https://api.github.com/users/shashwathi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashwathi/subscriptions","organizations_url":"https://api.github.com/users/shashwathi/orgs","repos_url":"https://api.github.com/users/shashwathi/repos","events_url":"https://api.github.com/users/shashwathi/events{/privacy}","received_events_url":"https://api.github.com/users/shashwathi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":862145007,"node_id":"MDU6TGFiZWw4NjIxNDUwMDc=","url":"https://api.github.com/repos/knative/serving/labels/size/XL","name":"size/XL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/serving/pulls/1762/commits","review_comments_url":"https://api.github.com/repos/knative/serving/pulls/1762/comments","review_comment_url":"https://api.github.com/repos/knative/serving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/serving/issues/1762/comments","statuses_url":"https://api.github.com/repos/knative/serving/statuses/3f95d254a31a7a740502de781748c5320c3c26e4","head":{"label":"dprotaso:poc-test-builders","ref":"poc-test-builders","sha":"3f95d254a31a7a740502de781748c5320c3c26e4","user":{"login":"dprotaso","id":18562,"node_id":"MDQ6VXNlcjE4NTYy","avatar_url":"https://avatars2.githubusercontent.com/u/18562?v=4","gravatar_id":"","url":"https://api.github.com/users/dprotaso","html_url":"https://github.com/dprotaso","followers_url":"https://api.github.com/users/dprotaso/followers","following_url":"https://api.github.com/users/dprotaso/following{/other_user}","gists_url":"https://api.github.com/users/dprotaso/gists{/gist_id}","starred_url":"https://api.github.com/users/dprotaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dprotaso/subscriptions","organizations_url":"https://api.github.com/users/dprotaso/orgs","repos_url":"https://api.github.com/users/dprotaso/repos","events_url":"https://api.github.com/users/dprotaso/events{/privacy}","received_events_url":"https://api.github.com/users/dprotaso/received_events","type":"User","site_admin":false},"repo":{"id":142365584,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzNjU1ODQ=","name":"serving","full_name":"dprotaso/serving","owner":{"login":"dprotaso","id":18562,"node_id":"MDQ6VXNlcjE4NTYy","avatar_url":"https://avatars2.githubusercontent.com/u/18562?v=4","gravatar_id":"","url":"https://api.github.com/users/dprotaso","html_url":"https://github.com/dprotaso","followers_url":"https://api.github.com/users/dprotaso/followers","following_url":"https://api.github.com/users/dprotaso/following{/other_user}","gists_url":"https://api.github.com/users/dprotaso/gists{/gist_id}","starred_url":"https://api.github.com/users/dprotaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dprotaso/subscriptions","organizations_url":"https://api.github.com/users/dprotaso/orgs","repos_url":"https://api.github.com/users/dprotaso/repos","events_url":"https://api.github.com/users/dprotaso/events{/privacy}","received_events_url":"https://api.github.com/users/dprotaso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dprotaso/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":true,"url":"https://api.github.com/repos/dprotaso/serving","forks_url":"https://api.github.com/repos/dprotaso/serving/forks","keys_url":"https://api.github.com/repos/dprotaso/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dprotaso/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dprotaso/serving/teams","hooks_url":"https://api.github.com/repos/dprotaso/serving/hooks","issue_events_url":"https://api.github.com/repos/dprotaso/serving/issues/events{/number}","events_url":"https://api.github.com/repos/dprotaso/serving/events","assignees_url":"https://api.github.com/repos/dprotaso/serving/assignees{/user}","branches_url":"https://api.github.com/repos/dprotaso/serving/branches{/branch}","tags_url":"https://api.github.com/repos/dprotaso/serving/tags","blobs_url":"https://api.github.com/repos/dprotaso/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dprotaso/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dprotaso/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/dprotaso/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dprotaso/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/dprotaso/serving/languages","stargazers_url":"https://api.github.com/repos/dprotaso/serving/stargazers","contributors_url":"https://api.github.com/repos/dprotaso/serving/contributors","subscribers_url":"https://api.github.com/repos/dprotaso/serving/subscribers","subscription_url":"https://api.github.com/repos/dprotaso/serving/subscription","commits_url":"https://api.github.com/repos/dprotaso/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/dprotaso/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/dprotaso/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/dprotaso/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/dprotaso/serving/contents/{+path}","compare_url":"https://api.github.com/repos/dprotaso/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dprotaso/serving/merges","archive_url":"https://api.github.com/repos/dprotaso/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dprotaso/serving/downloads","issues_url":"https://api.github.com/repos/dprotaso/serving/issues{/number}","pulls_url":"https://api.github.com/repos/dprotaso/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/dprotaso/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/dprotaso/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dprotaso/serving/labels{/name}","releases_url":"https://api.github.com/repos/dprotaso/serving/releases{/id}","deployments_url":"https://api.github.com/repos/dprotaso/serving/deployments","created_at":"2018-07-25T23:56:22Z","updated_at":"2018-07-25T23:56:24Z","pushed_at":"2018-07-31T02:08:02Z","git_url":"git://github.com/dprotaso/serving.git","ssh_url":"git@github.com:dprotaso/serving.git","clone_url":"https://github.com/dprotaso/serving.git","svn_url":"https://github.com/dprotaso/serving","homepage":"","size":20619,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"c036e919d7febcbf45c8d4b4363fc6fdcbf2029b","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":118828329,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MjgzMjk=","name":"serving","full_name":"knative/serving","owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/knative/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":false,"url":"https://api.github.com/repos/knative/serving","forks_url":"https://api.github.com/repos/knative/serving/forks","keys_url":"https://api.github.com/repos/knative/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/serving/teams","hooks_url":"https://api.github.com/repos/knative/serving/hooks","issue_events_url":"https://api.github.com/repos/knative/serving/issues/events{/number}","events_url":"https://api.github.com/repos/knative/serving/events","assignees_url":"https://api.github.com/repos/knative/serving/assignees{/user}","branches_url":"https://api.github.com/repos/knative/serving/branches{/branch}","tags_url":"https://api.github.com/repos/knative/serving/tags","blobs_url":"https://api.github.com/repos/knative/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/serving/languages","stargazers_url":"https://api.github.com/repos/knative/serving/stargazers","contributors_url":"https://api.github.com/repos/knative/serving/contributors","subscribers_url":"https://api.github.com/repos/knative/serving/subscribers","subscription_url":"https://api.github.com/repos/knative/serving/subscription","commits_url":"https://api.github.com/repos/knative/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/serving/contents/{+path}","compare_url":"https://api.github.com/repos/knative/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/serving/merges","archive_url":"https://api.github.com/repos/knative/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/serving/downloads","issues_url":"https://api.github.com/repos/knative/serving/issues{/number}","pulls_url":"https://api.github.com/repos/knative/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/serving/labels{/name}","releases_url":"https://api.github.com/repos/knative/serving/releases{/id}","deployments_url":"https://api.github.com/repos/knative/serving/deployments","created_at":"2018-01-24T22:07:44Z","updated_at":"2018-08-01T13:30:11Z","pushed_at":"2018-08-01T06:08:33Z","git_url":"git://github.com/knative/serving.git","ssh_url":"git@github.com:knative/serving.git","clone_url":"https://github.com/knative/serving.git","svn_url":"https://github.com/knative/serving","homepage":"","size":20652,"stargazers_count":536,"watchers_count":536,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":310,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":62,"open_issues":310,"watchers":536,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/1762"},"html":{"href":"https://github.com/knative/serving/pull/1762"},"issue":{"href":"https://api.github.com/repos/knative/serving/issues/1762"},"comments":{"href":"https://api.github.com/repos/knative/serving/issues/1762/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/serving/pulls/1762/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/serving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/serving/pulls/1762/commits"},"statuses":{"href":"https://api.github.com/repos/knative/serving/statuses/3f95d254a31a7a740502de781748c5320c3c26e4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mattmoor"}}