{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/213840171","pull_request_review_id":150762067,"id":213840171,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzg0MDE3MQ==","diff_hunk":"@@ -1121,6 +1125,15 @@\n       <SupportedFramework Condition=\"'%(SupportedFramework.Version)' == ''\">\n         <Version>$(_AssemblyVersion)</Version>\n       </SupportedFramework>\n+\n+      <!--\n+        Harvesting supported versions can sometimes lead to unknown versions when harvesting a package\n+        which has placeholders for older frameworks like net45. We should just exclude those from validation\n+        since we cannot easily determine what they are without looking at each specific platform itself.\n+      -->\n+      <ItemGroup>\n+        <SupportedFramework Remove=\"@(SupportedFramework)\" Condition=\"'%(SupportedFramework.Version)' == 'unknown'\" />","path":"src/Microsoft.DotNet.Build.Tasks.Packaging/src/PackageFiles/Packaging.targets","position":178,"original_position":178,"commit_id":"325d90346174a764cdad80e53d8e76c971eb8210","original_commit_id":"325d90346174a764cdad80e53d8e76c971eb8210","user":{"login":"joperezr","id":13854455,"node_id":"MDQ6VXNlcjEzODU0NDU1","avatar_url":"https://avatars3.githubusercontent.com/u/13854455?v=4","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"body":"I didn't look but I assume that you updated your corefx PR to remove this from there since it will live here now.","created_at":"2018-08-29T21:27:40Z","updated_at":"2018-08-29T21:27:40Z","html_url":"https://github.com/dotnet/buildtools/pull/2151#discussion_r213840171","pull_request_url":"https://api.github.com/repos/dotnet/buildtools/pulls/2151","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/213840171"},"html":{"href":"https://github.com/dotnet/buildtools/pull/2151#discussion_r213840171"},"pull_request":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/2151"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/2151","id":211889418,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExODg5NDE4","html_url":"https://github.com/dotnet/buildtools/pull/2151","diff_url":"https://github.com/dotnet/buildtools/pull/2151.diff","patch_url":"https://github.com/dotnet/buildtools/pull/2151.patch","issue_url":"https://api.github.com/repos/dotnet/buildtools/issues/2151","number":2151,"state":"open","locked":false,"title":"Add support for netcoreapp3.0 to packaging targets","user":{"login":"weshaggard","id":9010698,"node_id":"MDQ6VXNlcjkwMTA2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"Add the 3.0 supported tfm/rid combinations.\r\n\r\nAlso add a SupportedFramework filter to exclude unknown versions\r\nfrom the set. The unknown version only comes from package harvesting\r\nwhere we cannot figure out the version number from the package, in\r\nthose cases we don't have a great way to get the expected version so\r\nwe should just filter them out from validation.\r\n\r\ncc @ericstj @joperezr ","created_at":"2018-08-29T21:14:27Z","updated_at":"2018-08-29T21:27:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c55d362471c3deec45705f5857de1b51e55a3f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/buildtools/pulls/2151/commits","review_comments_url":"https://api.github.com/repos/dotnet/buildtools/pulls/2151/comments","review_comment_url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/buildtools/issues/2151/comments","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/325d90346174a764cdad80e53d8e76c971eb8210","head":{"label":"weshaggard:30PackagingSupport","ref":"30PackagingSupport","sha":"325d90346174a764cdad80e53d8e76c971eb8210","user":{"login":"weshaggard","id":9010698,"node_id":"MDQ6VXNlcjkwMTA2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"repo":{"id":27045928,"node_id":"MDEwOlJlcG9zaXRvcnkyNzA0NTkyOA==","name":"buildtools","full_name":"weshaggard/buildtools","owner":{"login":"weshaggard","id":9010698,"node_id":"MDQ6VXNlcjkwMTA2OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9010698?v=4","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weshaggard/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":true,"url":"https://api.github.com/repos/weshaggard/buildtools","forks_url":"https://api.github.com/repos/weshaggard/buildtools/forks","keys_url":"https://api.github.com/repos/weshaggard/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weshaggard/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weshaggard/buildtools/teams","hooks_url":"https://api.github.com/repos/weshaggard/buildtools/hooks","issue_events_url":"https://api.github.com/repos/weshaggard/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/weshaggard/buildtools/events","assignees_url":"https://api.github.com/repos/weshaggard/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/weshaggard/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/weshaggard/buildtools/tags","blobs_url":"https://api.github.com/repos/weshaggard/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weshaggard/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weshaggard/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/weshaggard/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weshaggard/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/weshaggard/buildtools/languages","stargazers_url":"https://api.github.com/repos/weshaggard/buildtools/stargazers","contributors_url":"https://api.github.com/repos/weshaggard/buildtools/contributors","subscribers_url":"https://api.github.com/repos/weshaggard/buildtools/subscribers","subscription_url":"https://api.github.com/repos/weshaggard/buildtools/subscription","commits_url":"https://api.github.com/repos/weshaggard/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/weshaggard/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/weshaggard/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/weshaggard/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/weshaggard/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/weshaggard/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weshaggard/buildtools/merges","archive_url":"https://api.github.com/repos/weshaggard/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weshaggard/buildtools/downloads","issues_url":"https://api.github.com/repos/weshaggard/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/weshaggard/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/weshaggard/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/weshaggard/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weshaggard/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/weshaggard/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/weshaggard/buildtools/deployments","created_at":"2014-11-23T20:13:50Z","updated_at":"2018-08-29T21:08:54Z","pushed_at":"2018-08-29T21:14:05Z","git_url":"git://github.com/weshaggard/buildtools.git","ssh_url":"git@github.com:weshaggard/buildtools.git","clone_url":"https://github.com/weshaggard/buildtools.git","svn_url":"https://github.com/weshaggard/buildtools","homepage":"","size":6418,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"4d4a4386746d09bb82cc9cbf8d48fd49651482b7","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295349,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0OQ==","name":"buildtools","full_name":"dotnet/buildtools","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":false,"url":"https://api.github.com/repos/dotnet/buildtools","forks_url":"https://api.github.com/repos/dotnet/buildtools/forks","keys_url":"https://api.github.com/repos/dotnet/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/buildtools/teams","hooks_url":"https://api.github.com/repos/dotnet/buildtools/hooks","issue_events_url":"https://api.github.com/repos/dotnet/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/buildtools/events","assignees_url":"https://api.github.com/repos/dotnet/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/buildtools/tags","blobs_url":"https://api.github.com/repos/dotnet/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/buildtools/languages","stargazers_url":"https://api.github.com/repos/dotnet/buildtools/stargazers","contributors_url":"https://api.github.com/repos/dotnet/buildtools/contributors","subscribers_url":"https://api.github.com/repos/dotnet/buildtools/subscribers","subscription_url":"https://api.github.com/repos/dotnet/buildtools/subscription","commits_url":"https://api.github.com/repos/dotnet/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/buildtools/merges","archive_url":"https://api.github.com/repos/dotnet/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/buildtools/downloads","issues_url":"https://api.github.com/repos/dotnet/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/buildtools/deployments","created_at":"2014-11-06T23:43:05Z","updated_at":"2018-08-29T20:48:22Z","pushed_at":"2018-08-29T21:14:27Z","git_url":"git://github.com/dotnet/buildtools.git","ssh_url":"git@github.com:dotnet/buildtools.git","clone_url":"https://github.com/dotnet/buildtools.git","svn_url":"https://github.com/dotnet/buildtools","homepage":"","size":6460,"stargazers_count":464,"watchers_count":464,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":263,"mirror_url":null,"archived":false,"open_issues_count":179,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":263,"open_issues":179,"watchers":464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/2151"},"html":{"href":"https://github.com/dotnet/buildtools/pull/2151"},"issue":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/2151"},"comments":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/2151/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/2151/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/2151/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/buildtools/statuses/325d90346174a764cdad80e53d8e76c971eb8210"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"joperezr"}}