{"action":"closed","number":2130,"pull_request":{"url":"https://api.github.com/repos/STScI-JWST/jwst/pulls/2130","id":192837050,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyODM3MDUw","html_url":"https://github.com/STScI-JWST/jwst/pull/2130","diff_url":"https://github.com/STScI-JWST/jwst/pull/2130.diff","patch_url":"https://github.com/STScI-JWST/jwst/pull/2130.patch","issue_url":"https://api.github.com/repos/STScI-JWST/jwst/issues/2130","number":2130,"state":"closed","locked":false,"title":"Do not write asdf extension when saving reference files","user":{"login":"bernie-simon","id":7916041,"node_id":"MDQ6VXNlcjc5MTYwNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/7916041?v=4","gravatar_id":"","url":"https://api.github.com/users/bernie-simon","html_url":"https://github.com/bernie-simon","followers_url":"https://api.github.com/users/bernie-simon/followers","following_url":"https://api.github.com/users/bernie-simon/following{/other_user}","gists_url":"https://api.github.com/users/bernie-simon/gists{/gist_id}","starred_url":"https://api.github.com/users/bernie-simon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernie-simon/subscriptions","organizations_url":"https://api.github.com/users/bernie-simon/orgs","repos_url":"https://api.github.com/users/bernie-simon/repos","events_url":"https://api.github.com/users/bernie-simon/events{/privacy}","received_events_url":"https://api.github.com/users/bernie-simon/received_events","type":"User","site_admin":false},"body":"The asdf format has had compatibility problems between software\r\nversions that has complicated the handling of reference files. So\r\ndatamodels this code change updates datamodels to not write an asdf\r\nextension to reference files. There are three changes:\r\n\r\nDatamodels has a new attribute, _no_asdf_extension. It is set to True\r\nfor reference files and False for other files. When a datamodel is\r\nsaved to a file, the code checks this attribute and calls the fitsio\r\nwriteto method if it is True and asdf write_to method if it is False.\r\n\r\nAll reference file model types are now subclassed from\r\nReferenceFileModel, which sets _no_asdf_extension to True.\r\n\r\nThe validate method in ReferenceFileModel now calls the validate\r\nmethod in the base class of Datamodels so that full validation is done\r\nwhen updating reference files.","created_at":"2018-06-05T21:09:20Z","updated_at":"2018-06-06T12:31:24Z","closed_at":"2018-06-06T12:31:24Z","merged_at":"2018-06-06T12:31:24Z","merge_commit_sha":"840e8c7cd4ff33fd2ac1f2fdd24714d659916dd9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/STScI-JWST/jwst/pulls/2130/commits","review_comments_url":"https://api.github.com/repos/STScI-JWST/jwst/pulls/2130/comments","review_comment_url":"https://api.github.com/repos/STScI-JWST/jwst/pulls/comments{/number}","comments_url":"https://api.github.com/repos/STScI-JWST/jwst/issues/2130/comments","statuses_url":"https://api.github.com/repos/STScI-JWST/jwst/statuses/5cab5ad1ee3077d5ae6518b2822b1e23026076e2","head":{"label":"bernie-simon:no_asdf","ref":"no_asdf","sha":"5cab5ad1ee3077d5ae6518b2822b1e23026076e2","user":{"login":"bernie-simon","id":7916041,"node_id":"MDQ6VXNlcjc5MTYwNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/7916041?v=4","gravatar_id":"","url":"https://api.github.com/users/bernie-simon","html_url":"https://github.com/bernie-simon","followers_url":"https://api.github.com/users/bernie-simon/followers","following_url":"https://api.github.com/users/bernie-simon/following{/other_user}","gists_url":"https://api.github.com/users/bernie-simon/gists{/gist_id}","starred_url":"https://api.github.com/users/bernie-simon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernie-simon/subscriptions","organizations_url":"https://api.github.com/users/bernie-simon/orgs","repos_url":"https://api.github.com/users/bernie-simon/repos","events_url":"https://api.github.com/users/bernie-simon/events{/privacy}","received_events_url":"https://api.github.com/users/bernie-simon/received_events","type":"User","site_admin":false},"repo":{"id":130864760,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA4NjQ3NjA=","name":"jwst","full_name":"bernie-simon/jwst","owner":{"login":"bernie-simon","id":7916041,"node_id":"MDQ6VXNlcjc5MTYwNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/7916041?v=4","gravatar_id":"","url":"https://api.github.com/users/bernie-simon","html_url":"https://github.com/bernie-simon","followers_url":"https://api.github.com/users/bernie-simon/followers","following_url":"https://api.github.com/users/bernie-simon/following{/other_user}","gists_url":"https://api.github.com/users/bernie-simon/gists{/gist_id}","starred_url":"https://api.github.com/users/bernie-simon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernie-simon/subscriptions","organizations_url":"https://api.github.com/users/bernie-simon/orgs","repos_url":"https://api.github.com/users/bernie-simon/repos","events_url":"https://api.github.com/users/bernie-simon/events{/privacy}","received_events_url":"https://api.github.com/users/bernie-simon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bernie-simon/jwst","description":"JWST Calibration Pipeline","fork":true,"url":"https://api.github.com/repos/bernie-simon/jwst","forks_url":"https://api.github.com/repos/bernie-simon/jwst/forks","keys_url":"https://api.github.com/repos/bernie-simon/jwst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bernie-simon/jwst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bernie-simon/jwst/teams","hooks_url":"https://api.github.com/repos/bernie-simon/jwst/hooks","issue_events_url":"https://api.github.com/repos/bernie-simon/jwst/issues/events{/number}","events_url":"https://api.github.com/repos/bernie-simon/jwst/events","assignees_url":"https://api.github.com/repos/bernie-simon/jwst/assignees{/user}","branches_url":"https://api.github.com/repos/bernie-simon/jwst/branches{/branch}","tags_url":"https://api.github.com/repos/bernie-simon/jwst/tags","blobs_url":"https://api.github.com/repos/bernie-simon/jwst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bernie-simon/jwst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bernie-simon/jwst/git/refs{/sha}","trees_url":"https://api.github.com/repos/bernie-simon/jwst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bernie-simon/jwst/statuses/{sha}","languages_url":"https://api.github.com/repos/bernie-simon/jwst/languages","stargazers_url":"https://api.github.com/repos/bernie-simon/jwst/stargazers","contributors_url":"https://api.github.com/repos/bernie-simon/jwst/contributors","subscribers_url":"https://api.github.com/repos/bernie-simon/jwst/subscribers","subscription_url":"https://api.github.com/repos/bernie-simon/jwst/subscription","commits_url":"https://api.github.com/repos/bernie-simon/jwst/commits{/sha}","git_commits_url":"https://api.github.com/repos/bernie-simon/jwst/git/commits{/sha}","comments_url":"https://api.github.com/repos/bernie-simon/jwst/comments{/number}","issue_comment_url":"https://api.github.com/repos/bernie-simon/jwst/issues/comments{/number}","contents_url":"https://api.github.com/repos/bernie-simon/jwst/contents/{+path}","compare_url":"https://api.github.com/repos/bernie-simon/jwst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bernie-simon/jwst/merges","archive_url":"https://api.github.com/repos/bernie-simon/jwst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bernie-simon/jwst/downloads","issues_url":"https://api.github.com/repos/bernie-simon/jwst/issues{/number}","pulls_url":"https://api.github.com/repos/bernie-simon/jwst/pulls{/number}","milestones_url":"https://api.github.com/repos/bernie-simon/jwst/milestones{/number}","notifications_url":"https://api.github.com/repos/bernie-simon/jwst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bernie-simon/jwst/labels{/name}","releases_url":"https://api.github.com/repos/bernie-simon/jwst/releases{/id}","deployments_url":"https://api.github.com/repos/bernie-simon/jwst/deployments","created_at":"2018-04-24T14:12:13Z","updated_at":"2018-06-04T18:59:52Z","pushed_at":"2018-06-05T21:00:00Z","git_url":"git://github.com/bernie-simon/jwst.git","ssh_url":"git@github.com:bernie-simon/jwst.git","clone_url":"https://github.com/bernie-simon/jwst.git","svn_url":"https://github.com/bernie-simon/jwst","homepage":"","size":67847,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"STScI-JWST:master","ref":"master","sha":"8b2051230d40e31b744b1d536f4138b50195f921","user":{"login":"STScI-JWST","id":17731768,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzMxNzY4","avatar_url":"https://avatars0.githubusercontent.com/u/17731768?v=4","gravatar_id":"","url":"https://api.github.com/users/STScI-JWST","html_url":"https://github.com/STScI-JWST","followers_url":"https://api.github.com/users/STScI-JWST/followers","following_url":"https://api.github.com/users/STScI-JWST/following{/other_user}","gists_url":"https://api.github.com/users/STScI-JWST/gists{/gist_id}","starred_url":"https://api.github.com/users/STScI-JWST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STScI-JWST/subscriptions","organizations_url":"https://api.github.com/users/STScI-JWST/orgs","repos_url":"https://api.github.com/users/STScI-JWST/repos","events_url":"https://api.github.com/users/STScI-JWST/events{/privacy}","received_events_url":"https://api.github.com/users/STScI-JWST/received_events","type":"Organization","site_admin":false},"repo":{"id":60551519,"node_id":"MDEwOlJlcG9zaXRvcnk2MDU1MTUxOQ==","name":"jwst","full_name":"STScI-JWST/jwst","owner":{"login":"STScI-JWST","id":17731768,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzMxNzY4","avatar_url":"https://avatars0.githubusercontent.com/u/17731768?v=4","gravatar_id":"","url":"https://api.github.com/users/STScI-JWST","html_url":"https://github.com/STScI-JWST","followers_url":"https://api.github.com/users/STScI-JWST/followers","following_url":"https://api.github.com/users/STScI-JWST/following{/other_user}","gists_url":"https://api.github.com/users/STScI-JWST/gists{/gist_id}","starred_url":"https://api.github.com/users/STScI-JWST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STScI-JWST/subscriptions","organizations_url":"https://api.github.com/users/STScI-JWST/orgs","repos_url":"https://api.github.com/users/STScI-JWST/repos","events_url":"https://api.github.com/users/STScI-JWST/events{/privacy}","received_events_url":"https://api.github.com/users/STScI-JWST/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/STScI-JWST/jwst","description":"JWST Calibration Pipeline","fork":false,"url":"https://api.github.com/repos/STScI-JWST/jwst","forks_url":"https://api.github.com/repos/STScI-JWST/jwst/forks","keys_url":"https://api.github.com/repos/STScI-JWST/jwst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STScI-JWST/jwst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STScI-JWST/jwst/teams","hooks_url":"https://api.github.com/repos/STScI-JWST/jwst/hooks","issue_events_url":"https://api.github.com/repos/STScI-JWST/jwst/issues/events{/number}","events_url":"https://api.github.com/repos/STScI-JWST/jwst/events","assignees_url":"https://api.github.com/repos/STScI-JWST/jwst/assignees{/user}","branches_url":"https://api.github.com/repos/STScI-JWST/jwst/branches{/branch}","tags_url":"https://api.github.com/repos/STScI-JWST/jwst/tags","blobs_url":"https://api.github.com/repos/STScI-JWST/jwst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STScI-JWST/jwst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STScI-JWST/jwst/git/refs{/sha}","trees_url":"https://api.github.com/repos/STScI-JWST/jwst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STScI-JWST/jwst/statuses/{sha}","languages_url":"https://api.github.com/repos/STScI-JWST/jwst/languages","stargazers_url":"https://api.github.com/repos/STScI-JWST/jwst/stargazers","contributors_url":"https://api.github.com/repos/STScI-JWST/jwst/contributors","subscribers_url":"https://api.github.com/repos/STScI-JWST/jwst/subscribers","subscription_url":"https://api.github.com/repos/STScI-JWST/jwst/subscription","commits_url":"https://api.github.com/repos/STScI-JWST/jwst/commits{/sha}","git_commits_url":"https://api.github.com/repos/STScI-JWST/jwst/git/commits{/sha}","comments_url":"https://api.github.com/repos/STScI-JWST/jwst/comments{/number}","issue_comment_url":"https://api.github.com/repos/STScI-JWST/jwst/issues/comments{/number}","contents_url":"https://api.github.com/repos/STScI-JWST/jwst/contents/{+path}","compare_url":"https://api.github.com/repos/STScI-JWST/jwst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STScI-JWST/jwst/merges","archive_url":"https://api.github.com/repos/STScI-JWST/jwst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STScI-JWST/jwst/downloads","issues_url":"https://api.github.com/repos/STScI-JWST/jwst/issues{/number}","pulls_url":"https://api.github.com/repos/STScI-JWST/jwst/pulls{/number}","milestones_url":"https://api.github.com/repos/STScI-JWST/jwst/milestones{/number}","notifications_url":"https://api.github.com/repos/STScI-JWST/jwst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STScI-JWST/jwst/labels{/name}","releases_url":"https://api.github.com/repos/STScI-JWST/jwst/releases{/id}","deployments_url":"https://api.github.com/repos/STScI-JWST/jwst/deployments","created_at":"2016-06-06T18:34:23Z","updated_at":"2018-06-05T12:41:55Z","pushed_at":"2018-06-06T12:31:24Z","git_url":"git://github.com/STScI-JWST/jwst.git","ssh_url":"git@github.com:STScI-JWST/jwst.git","clone_url":"https://github.com/STScI-JWST/jwst.git","svn_url":"https://github.com/STScI-JWST/jwst","homepage":"https://jwst-pipeline.readthedocs.io/en/latest/","size":67669,"stargazers_count":44,"watchers_count":44,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":199,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":40,"open_issues":199,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/STScI-JWST/jwst/pulls/2130"},"html":{"href":"https://github.com/STScI-JWST/jwst/pull/2130"},"issue":{"href":"https://api.github.com/repos/STScI-JWST/jwst/issues/2130"},"comments":{"href":"https://api.github.com/repos/STScI-JWST/jwst/issues/2130/comments"},"review_comments":{"href":"https://api.github.com/repos/STScI-JWST/jwst/pulls/2130/comments"},"review_comment":{"href":"https://api.github.com/repos/STScI-JWST/jwst/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/STScI-JWST/jwst/pulls/2130/commits"},"statuses":{"href":"https://api.github.com/repos/STScI-JWST/jwst/statuses/5cab5ad1ee3077d5ae6518b2822b1e23026076e2"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bernie-simon","id":7916041,"node_id":"MDQ6VXNlcjc5MTYwNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/7916041?v=4","gravatar_id":"","url":"https://api.github.com/users/bernie-simon","html_url":"https://github.com/bernie-simon","followers_url":"https://api.github.com/users/bernie-simon/followers","following_url":"https://api.github.com/users/bernie-simon/following{/other_user}","gists_url":"https://api.github.com/users/bernie-simon/gists{/gist_id}","starred_url":"https://api.github.com/users/bernie-simon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernie-simon/subscriptions","organizations_url":"https://api.github.com/users/bernie-simon/orgs","repos_url":"https://api.github.com/users/bernie-simon/repos","events_url":"https://api.github.com/users/bernie-simon/events{/privacy}","received_events_url":"https://api.github.com/users/bernie-simon/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":85,"deletions":75,"changed_files":33}}
{"actor":{"display_login":"bernie-simon"}}