{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/235776509","pull_request_review_id":177721320,"id":235776509,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTc3NjUwOQ==","diff_hunk":"@@ -205,7 +205,15 @@ bool UsbConnection::PostOutTransfer() {\n }\n \n void UsbConnection::OnOutTransfer(libusb_transfer* transfer) {\n-  LOG4CXX_TRACE(logger_, \"enter with  Libusb_transfer*: \" << transfer);\n+  LOG4CXX_AUTO_TRACE(logger_);\n+  LOG4CXX_DEBUG(logger_,\"enter with Libusb_transfer*: \" << transfer);","path":"src/components/transport_manager/src/usb/libusb/usb_connection.cc","position":null,"original_position":6,"commit_id":"3c539a8a53cfd07be342e9a557446b71d8247c5a","original_commit_id":"8977c019208ef0b106eb7361f53f64d825ad4682","user":{"login":"Ypostolov","id":32772773,"node_id":"MDQ6VXNlcjMyNzcyNzcz","avatar_url":"https://avatars2.githubusercontent.com/u/32772773?v=4","gravatar_id":"","url":"https://api.github.com/users/Ypostolov","html_url":"https://github.com/Ypostolov","followers_url":"https://api.github.com/users/Ypostolov/followers","following_url":"https://api.github.com/users/Ypostolov/following{/other_user}","gists_url":"https://api.github.com/users/Ypostolov/gists{/gist_id}","starred_url":"https://api.github.com/users/Ypostolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ypostolov/subscriptions","organizations_url":"https://api.github.com/users/Ypostolov/orgs","repos_url":"https://api.github.com/users/Ypostolov/repos","events_url":"https://api.github.com/users/Ypostolov/events{/privacy}","received_events_url":"https://api.github.com/users/Ypostolov/received_events","type":"User","site_admin":false},"body":"Fixed in 3c539a8a53cfd07be342e9a557446b71d8247c5a","created_at":"2018-11-22T16:13:53Z","updated_at":"2018-11-22T16:13:53Z","html_url":"https://github.com/smartdevicelink/sdl_core/pull/2505#discussion_r235776509","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/2505","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/235776509"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/2505#discussion_r235776509"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/2505"}},"in_reply_to_id":224907003},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/2505","id":207320400,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzIwNDAw","html_url":"https://github.com/smartdevicelink/sdl_core/pull/2505","diff_url":"https://github.com/smartdevicelink/sdl_core/pull/2505.diff","patch_url":"https://github.com/smartdevicelink/sdl_core/pull/2505.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/2505","number":2505,"state":"open","locked":false,"title":"fix crash in libusb callback handling","user":{"login":"Ypostolov","id":32772773,"node_id":"MDQ6VXNlcjMyNzcyNzcz","avatar_url":"https://avatars2.githubusercontent.com/u/32772773?v=4","gravatar_id":"","url":"https://api.github.com/users/Ypostolov","html_url":"https://github.com/Ypostolov","followers_url":"https://api.github.com/users/Ypostolov/followers","following_url":"https://api.github.com/users/Ypostolov/following{/other_user}","gists_url":"https://api.github.com/users/Ypostolov/gists{/gist_id}","starred_url":"https://api.github.com/users/Ypostolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ypostolov/subscriptions","organizations_url":"https://api.github.com/users/Ypostolov/orgs","repos_url":"https://api.github.com/users/Ypostolov/repos","events_url":"https://api.github.com/users/Ypostolov/events{/privacy}","received_events_url":"https://api.github.com/users/Ypostolov/received_events","type":"User","site_admin":false},"body":"\r\n\r\nFixes #2429\r\n\r\nThis PR is ready for review.\r\n\r\n### Risk\r\nThis PR makes no API changes.\r\n\r\n### Testing Plan\r\nChanges in PR are already covered within existing unit tests.\r\n\r\n### Summary\r\nThe rootcause of the issue is the callback function OnOutTransfer().\r\nThis is occuring when when AbortConnection() is called or\r\nUsbConnection object is destroyed. In case if have OutTransfer\r\ncurrently taking place we cancel this transfer with\r\nlibusb_cancel_transfer(). So in order to fix the issue we capture this status in our callback\r\nfunction, free allocated transfer structure used by libusb and exit not\r\ntouching anything else. It's also taken under consideration\r\n\r\n\r\n\r\n### CLA\r\n- [x] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform)","created_at":"2018-08-09T13:41:25Z","updated_at":"2018-11-22T16:13:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef3949ce2e0cbd91e7180f84b08d3b0bff49957e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"LitvinenkoIra","id":18070449,"node_id":"MDQ6VXNlcjE4MDcwNDQ5","avatar_url":"https://avatars3.githubusercontent.com/u/18070449?v=4","gravatar_id":"","url":"https://api.github.com/users/LitvinenkoIra","html_url":"https://github.com/LitvinenkoIra","followers_url":"https://api.github.com/users/LitvinenkoIra/followers","following_url":"https://api.github.com/users/LitvinenkoIra/following{/other_user}","gists_url":"https://api.github.com/users/LitvinenkoIra/gists{/gist_id}","starred_url":"https://api.github.com/users/LitvinenkoIra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LitvinenkoIra/subscriptions","organizations_url":"https://api.github.com/users/LitvinenkoIra/orgs","repos_url":"https://api.github.com/users/LitvinenkoIra/repos","events_url":"https://api.github.com/users/LitvinenkoIra/events{/privacy}","received_events_url":"https://api.github.com/users/LitvinenkoIra/received_events","type":"User","site_admin":false},{"login":"ValeriiMalkov","id":35764812,"node_id":"MDQ6VXNlcjM1NzY0ODEy","avatar_url":"https://avatars1.githubusercontent.com/u/35764812?v=4","gravatar_id":"","url":"https://api.github.com/users/ValeriiMalkov","html_url":"https://github.com/ValeriiMalkov","followers_url":"https://api.github.com/users/ValeriiMalkov/followers","following_url":"https://api.github.com/users/ValeriiMalkov/following{/other_user}","gists_url":"https://api.github.com/users/ValeriiMalkov/gists{/gist_id}","starred_url":"https://api.github.com/users/ValeriiMalkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ValeriiMalkov/subscriptions","organizations_url":"https://api.github.com/users/ValeriiMalkov/orgs","repos_url":"https://api.github.com/users/ValeriiMalkov/repos","events_url":"https://api.github.com/users/ValeriiMalkov/events{/privacy}","received_events_url":"https://api.github.com/users/ValeriiMalkov/received_events","type":"User","site_admin":false},{"login":"APipko","id":39483182,"node_id":"MDQ6VXNlcjM5NDgzMTgy","avatar_url":"https://avatars1.githubusercontent.com/u/39483182?v=4","gravatar_id":"","url":"https://api.github.com/users/APipko","html_url":"https://github.com/APipko","followers_url":"https://api.github.com/users/APipko/followers","following_url":"https://api.github.com/users/APipko/following{/other_user}","gists_url":"https://api.github.com/users/APipko/gists{/gist_id}","starred_url":"https://api.github.com/users/APipko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/APipko/subscriptions","organizations_url":"https://api.github.com/users/APipko/orgs","repos_url":"https://api.github.com/users/APipko/repos","events_url":"https://api.github.com/users/APipko/events{/privacy}","received_events_url":"https://api.github.com/users/APipko/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/2505/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/2505/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/2505/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/3c539a8a53cfd07be342e9a557446b71d8247c5a","head":{"label":"Ypostolov:fix/Fix_crash_in_libusb_callback_handling","ref":"fix/Fix_crash_in_libusb_callback_handling","sha":"3c539a8a53cfd07be342e9a557446b71d8247c5a","user":{"login":"Ypostolov","id":32772773,"node_id":"MDQ6VXNlcjMyNzcyNzcz","avatar_url":"https://avatars2.githubusercontent.com/u/32772773?v=4","gravatar_id":"","url":"https://api.github.com/users/Ypostolov","html_url":"https://github.com/Ypostolov","followers_url":"https://api.github.com/users/Ypostolov/followers","following_url":"https://api.github.com/users/Ypostolov/following{/other_user}","gists_url":"https://api.github.com/users/Ypostolov/gists{/gist_id}","starred_url":"https://api.github.com/users/Ypostolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ypostolov/subscriptions","organizations_url":"https://api.github.com/users/Ypostolov/orgs","repos_url":"https://api.github.com/users/Ypostolov/repos","events_url":"https://api.github.com/users/Ypostolov/events{/privacy}","received_events_url":"https://api.github.com/users/Ypostolov/received_events","type":"User","site_admin":false},"repo":{"id":114358260,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQzNTgyNjA=","name":"sdl_core","full_name":"Ypostolov/sdl_core","private":false,"owner":{"login":"Ypostolov","id":32772773,"node_id":"MDQ6VXNlcjMyNzcyNzcz","avatar_url":"https://avatars2.githubusercontent.com/u/32772773?v=4","gravatar_id":"","url":"https://api.github.com/users/Ypostolov","html_url":"https://github.com/Ypostolov","followers_url":"https://api.github.com/users/Ypostolov/followers","following_url":"https://api.github.com/users/Ypostolov/following{/other_user}","gists_url":"https://api.github.com/users/Ypostolov/gists{/gist_id}","starred_url":"https://api.github.com/users/Ypostolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ypostolov/subscriptions","organizations_url":"https://api.github.com/users/Ypostolov/orgs","repos_url":"https://api.github.com/users/Ypostolov/repos","events_url":"https://api.github.com/users/Ypostolov/events{/privacy}","received_events_url":"https://api.github.com/users/Ypostolov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Ypostolov/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":true,"url":"https://api.github.com/repos/Ypostolov/sdl_core","forks_url":"https://api.github.com/repos/Ypostolov/sdl_core/forks","keys_url":"https://api.github.com/repos/Ypostolov/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ypostolov/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ypostolov/sdl_core/teams","hooks_url":"https://api.github.com/repos/Ypostolov/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/Ypostolov/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/Ypostolov/sdl_core/events","assignees_url":"https://api.github.com/repos/Ypostolov/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/Ypostolov/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/Ypostolov/sdl_core/tags","blobs_url":"https://api.github.com/repos/Ypostolov/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ypostolov/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ypostolov/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ypostolov/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ypostolov/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/Ypostolov/sdl_core/languages","stargazers_url":"https://api.github.com/repos/Ypostolov/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/Ypostolov/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/Ypostolov/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/Ypostolov/sdl_core/subscription","commits_url":"https://api.github.com/repos/Ypostolov/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ypostolov/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ypostolov/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ypostolov/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ypostolov/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/Ypostolov/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ypostolov/sdl_core/merges","archive_url":"https://api.github.com/repos/Ypostolov/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ypostolov/sdl_core/downloads","issues_url":"https://api.github.com/repos/Ypostolov/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/Ypostolov/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/Ypostolov/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/Ypostolov/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ypostolov/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/Ypostolov/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/Ypostolov/sdl_core/deployments","created_at":"2017-12-15T10:24:19Z","updated_at":"2017-12-15T10:24:30Z","pushed_at":"2018-11-22T16:12:27Z","git_url":"git://github.com/Ypostolov/sdl_core.git","ssh_url":"git@github.com:Ypostolov/sdl_core.git","clone_url":"https://github.com/Ypostolov/sdl_core.git","svn_url":"https://github.com/Ypostolov/sdl_core","homepage":"","size":319069,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"04893693053bd1d1fd49aaf0d9510a57fde9fc8f","user":{"login":"smartdevicelink","id":8671397,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2NzEzOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24724170,"node_id":"MDEwOlJlcG9zaXRvcnkyNDcyNDE3MA==","name":"sdl_core","full_name":"smartdevicelink/sdl_core","private":false,"owner":{"login":"smartdevicelink","id":8671397,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2NzEzOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/smartdevicelink/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_core","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_core/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_core/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_core/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_core/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/deployments","created_at":"2014-10-02T15:16:26Z","updated_at":"2018-11-19T22:46:11Z","pushed_at":"2018-11-22T16:12:29Z","git_url":"git://github.com/smartdevicelink/sdl_core.git","ssh_url":"git@github.com:smartdevicelink/sdl_core.git","clone_url":"https://github.com/smartdevicelink/sdl_core.git","svn_url":"https://github.com/smartdevicelink/sdl_core","homepage":"","size":320527,"stargazers_count":158,"watchers_count":158,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":216,"mirror_url":null,"archived":false,"open_issues_count":410,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":216,"open_issues":410,"watchers":158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/2505"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/2505"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/2505"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/2505/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/2505/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/2505/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/3c539a8a53cfd07be342e9a557446b71d8247c5a"}},"author_association":"NONE"}}
{"actor":{"display_login":"Ypostolov"}}