{"action":"created","comment":{"url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/pulls/comments/232272314","pull_request_review_id":173435195,"id":232272314,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjI3MjMxNA==","diff_hunk":"@@ -6,7 +6,9 @@ def install_ruby_dependencies\n         when /^jruby-/\n           package jruby_package_deps\n         else\n-          package package_deps\n+          package_deps.each do |deps|\n+            package deps\n+          end","path":"libraries/package_deps.rb","position":7,"original_position":7,"commit_id":"864542efc93e621f446b04c586f2a9673cb54457","original_commit_id":"864542efc93e621f446b04c586f2a9673cb54457","user":{"login":"damacus","id":40786,"node_id":"MDQ6VXNlcjQwNzg2","avatar_url":"https://avatars1.githubusercontent.com/u/40786?v=4","gravatar_id":"","url":"https://api.github.com/users/damacus","html_url":"https://github.com/damacus","followers_url":"https://api.github.com/users/damacus/followers","following_url":"https://api.github.com/users/damacus/following{/other_user}","gists_url":"https://api.github.com/users/damacus/gists{/gist_id}","starred_url":"https://api.github.com/users/damacus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damacus/subscriptions","organizations_url":"https://api.github.com/users/damacus/orgs","repos_url":"https://api.github.com/users/damacus/repos","events_url":"https://api.github.com/users/damacus/events{/privacy}","received_events_url":"https://api.github.com/users/damacus/received_events","type":"User","site_admin":false},"body":"I mean, we still support 13.x until next April so this will have to do. ","created_at":"2018-11-09T14:35:19Z","updated_at":"2018-11-09T14:35:20Z","html_url":"https://github.com/sous-chefs/ruby_rbenv/pull/239#discussion_r232272314","pull_request_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/pulls/239","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sous-chefs/ruby_rbenv/pulls/comments/232272314"},"html":{"href":"https://github.com/sous-chefs/ruby_rbenv/pull/239#discussion_r232272314"},"pull_request":{"href":"https://api.github.com/repos/sous-chefs/ruby_rbenv/pulls/239"}},"in_reply_to_id":232261006},"pull_request":{"url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/pulls/239","id":229696412,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5Njk2NDEy","html_url":"https://github.com/sous-chefs/ruby_rbenv/pull/239","diff_url":"https://github.com/sous-chefs/ruby_rbenv/pull/239.diff","patch_url":"https://github.com/sous-chefs/ruby_rbenv/pull/239.patch","issue_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/issues/239","number":239,"state":"open","locked":false,"title":"Improved manage 'mac_os_x' platform family (only for Ruby >= 1.9.3-p0…)","user":{"login":"x21Kenobi","id":18399554,"node_id":"MDQ6VXNlcjE4Mzk5NTU0","avatar_url":"https://avatars1.githubusercontent.com/u/18399554?v=4","gravatar_id":"","url":"https://api.github.com/users/x21Kenobi","html_url":"https://github.com/x21Kenobi","followers_url":"https://api.github.com/users/x21Kenobi/followers","following_url":"https://api.github.com/users/x21Kenobi/following{/other_user}","gists_url":"https://api.github.com/users/x21Kenobi/gists{/gist_id}","starred_url":"https://api.github.com/users/x21Kenobi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x21Kenobi/subscriptions","organizations_url":"https://api.github.com/users/x21Kenobi/orgs","repos_url":"https://api.github.com/users/x21Kenobi/repos","events_url":"https://api.github.com/users/x21Kenobi/events{/privacy}","received_events_url":"https://api.github.com/users/x21Kenobi/received_events","type":"User","site_admin":false},"body":"Improved management for 'mac_os_x' platform family (only for Ruby >= 1.9.3-p0…) \r\n[TypeError: no implicit conversion of nil into String]\r\n[TypeError: name is required]\r\n\r\n### Description\r\n\r\nI'm working on an infrastructure with some **Mac servers** that needs `rbenv` to manage ruby installations. \r\nAt the moment I'm using a custom cookbook but I would like able to use these resources for `mac_os_x` platforms; so I was using your resources and I got the error in object.\r\nThis setup worked for me, those are dependecies for Mac platforms.\r\nWARN: this commit doesn't work for Ruby versions <= 1.9.3-p0\r\nhttps://github.com/rbenv/ruby-build/wiki\r\n\r\n### Issues Resolved\r\n\r\nCould resolve this:\r\nhttps://github.com/sous-chefs/ruby_rbenv/issues/205\r\n\r\n### Contribution Check List\r\n\r\nAt the moment I'm using this solution in test environment.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/sous-chefs/ruby_rbenv/239)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-11-09T13:38:05Z","updated_at":"2018-11-09T14:35:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b25432cf7295a02559a954eaae41cb8e7350d0a6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":718295802,"node_id":"MDU6TGFiZWw3MTgyOTU4MDI=","url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/labels/Type:%20Bug","name":"Type: Bug","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/pulls/239/commits","review_comments_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/pulls/239/comments","review_comment_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/issues/239/comments","statuses_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/statuses/864542efc93e621f446b04c586f2a9673cb54457","head":{"label":"x21Kenobi:master","ref":"master","sha":"864542efc93e621f446b04c586f2a9673cb54457","user":{"login":"x21Kenobi","id":18399554,"node_id":"MDQ6VXNlcjE4Mzk5NTU0","avatar_url":"https://avatars1.githubusercontent.com/u/18399554?v=4","gravatar_id":"","url":"https://api.github.com/users/x21Kenobi","html_url":"https://github.com/x21Kenobi","followers_url":"https://api.github.com/users/x21Kenobi/followers","following_url":"https://api.github.com/users/x21Kenobi/following{/other_user}","gists_url":"https://api.github.com/users/x21Kenobi/gists{/gist_id}","starred_url":"https://api.github.com/users/x21Kenobi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x21Kenobi/subscriptions","organizations_url":"https://api.github.com/users/x21Kenobi/orgs","repos_url":"https://api.github.com/users/x21Kenobi/repos","events_url":"https://api.github.com/users/x21Kenobi/events{/privacy}","received_events_url":"https://api.github.com/users/x21Kenobi/received_events","type":"User","site_admin":false},"repo":{"id":156731517,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY3MzE1MTc=","name":"ruby_rbenv","full_name":"x21Kenobi/ruby_rbenv","private":false,"owner":{"login":"x21Kenobi","id":18399554,"node_id":"MDQ6VXNlcjE4Mzk5NTU0","avatar_url":"https://avatars1.githubusercontent.com/u/18399554?v=4","gravatar_id":"","url":"https://api.github.com/users/x21Kenobi","html_url":"https://github.com/x21Kenobi","followers_url":"https://api.github.com/users/x21Kenobi/followers","following_url":"https://api.github.com/users/x21Kenobi/following{/other_user}","gists_url":"https://api.github.com/users/x21Kenobi/gists{/gist_id}","starred_url":"https://api.github.com/users/x21Kenobi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x21Kenobi/subscriptions","organizations_url":"https://api.github.com/users/x21Kenobi/orgs","repos_url":"https://api.github.com/users/x21Kenobi/repos","events_url":"https://api.github.com/users/x21Kenobi/events{/privacy}","received_events_url":"https://api.github.com/users/x21Kenobi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/x21Kenobi/ruby_rbenv","description":"Development repository for the ruby_rbenv cookbook","fork":true,"url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv","forks_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/forks","keys_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/teams","hooks_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/hooks","issue_events_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/issues/events{/number}","events_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/events","assignees_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/assignees{/user}","branches_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/branches{/branch}","tags_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/tags","blobs_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/git/refs{/sha}","trees_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/statuses/{sha}","languages_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/languages","stargazers_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/stargazers","contributors_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/contributors","subscribers_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/subscribers","subscription_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/subscription","commits_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/commits{/sha}","git_commits_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/git/commits{/sha}","comments_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/comments{/number}","issue_comment_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/issues/comments{/number}","contents_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/contents/{+path}","compare_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/merges","archive_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/downloads","issues_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/issues{/number}","pulls_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/pulls{/number}","milestones_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/milestones{/number}","notifications_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/labels{/name}","releases_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/releases{/id}","deployments_url":"https://api.github.com/repos/x21Kenobi/ruby_rbenv/deployments","created_at":"2018-11-08T15:53:28Z","updated_at":"2018-11-09T13:56:41Z","pushed_at":"2018-11-09T13:56:40Z","git_url":"git://github.com/x21Kenobi/ruby_rbenv.git","ssh_url":"git@github.com:x21Kenobi/ruby_rbenv.git","clone_url":"https://github.com/x21Kenobi/ruby_rbenv.git","svn_url":"https://github.com/x21Kenobi/ruby_rbenv","homepage":"https://supermarket.chef.io/cookbooks/ruby_rbenv","size":409,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sous-chefs:master","ref":"master","sha":"5160c95e0148d797443275fca788b774336351e7","user":{"login":"sous-chefs","id":12356028,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzU2MDI4","avatar_url":"https://avatars3.githubusercontent.com/u/12356028?v=4","gravatar_id":"","url":"https://api.github.com/users/sous-chefs","html_url":"https://github.com/sous-chefs","followers_url":"https://api.github.com/users/sous-chefs/followers","following_url":"https://api.github.com/users/sous-chefs/following{/other_user}","gists_url":"https://api.github.com/users/sous-chefs/gists{/gist_id}","starred_url":"https://api.github.com/users/sous-chefs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sous-chefs/subscriptions","organizations_url":"https://api.github.com/users/sous-chefs/orgs","repos_url":"https://api.github.com/users/sous-chefs/repos","events_url":"https://api.github.com/users/sous-chefs/events{/privacy}","received_events_url":"https://api.github.com/users/sous-chefs/received_events","type":"Organization","site_admin":false},"repo":{"id":3029040,"node_id":"MDEwOlJlcG9zaXRvcnkzMDI5MDQw","name":"ruby_rbenv","full_name":"sous-chefs/ruby_rbenv","private":false,"owner":{"login":"sous-chefs","id":12356028,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzU2MDI4","avatar_url":"https://avatars3.githubusercontent.com/u/12356028?v=4","gravatar_id":"","url":"https://api.github.com/users/sous-chefs","html_url":"https://github.com/sous-chefs","followers_url":"https://api.github.com/users/sous-chefs/followers","following_url":"https://api.github.com/users/sous-chefs/following{/other_user}","gists_url":"https://api.github.com/users/sous-chefs/gists{/gist_id}","starred_url":"https://api.github.com/users/sous-chefs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sous-chefs/subscriptions","organizations_url":"https://api.github.com/users/sous-chefs/orgs","repos_url":"https://api.github.com/users/sous-chefs/repos","events_url":"https://api.github.com/users/sous-chefs/events{/privacy}","received_events_url":"https://api.github.com/users/sous-chefs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sous-chefs/ruby_rbenv","description":"Development repository for the ruby_rbenv cookbook","fork":false,"url":"https://api.github.com/repos/sous-chefs/ruby_rbenv","forks_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/forks","keys_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/teams","hooks_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/hooks","issue_events_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/issues/events{/number}","events_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/events","assignees_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/assignees{/user}","branches_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/branches{/branch}","tags_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/tags","blobs_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/git/refs{/sha}","trees_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/statuses/{sha}","languages_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/languages","stargazers_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/stargazers","contributors_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/contributors","subscribers_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/subscribers","subscription_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/subscription","commits_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/commits{/sha}","git_commits_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/git/commits{/sha}","comments_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/comments{/number}","issue_comment_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/issues/comments{/number}","contents_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/contents/{+path}","compare_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/merges","archive_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/downloads","issues_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/issues{/number}","pulls_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/pulls{/number}","milestones_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/milestones{/number}","notifications_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/labels{/name}","releases_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/releases{/id}","deployments_url":"https://api.github.com/repos/sous-chefs/ruby_rbenv/deployments","created_at":"2011-12-21T19:13:56Z","updated_at":"2018-10-21T15:57:49Z","pushed_at":"2018-11-09T13:56:46Z","git_url":"git://github.com/sous-chefs/ruby_rbenv.git","ssh_url":"git@github.com:sous-chefs/ruby_rbenv.git","clone_url":"https://github.com/sous-chefs/ruby_rbenv.git","svn_url":"https://github.com/sous-chefs/ruby_rbenv","homepage":"https://supermarket.chef.io/cookbooks/ruby_rbenv","size":604,"stargazers_count":330,"watchers_count":330,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":250,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":250,"open_issues":4,"watchers":330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sous-chefs/ruby_rbenv/pulls/239"},"html":{"href":"https://github.com/sous-chefs/ruby_rbenv/pull/239"},"issue":{"href":"https://api.github.com/repos/sous-chefs/ruby_rbenv/issues/239"},"comments":{"href":"https://api.github.com/repos/sous-chefs/ruby_rbenv/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/sous-chefs/ruby_rbenv/pulls/239/comments"},"review_comment":{"href":"https://api.github.com/repos/sous-chefs/ruby_rbenv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sous-chefs/ruby_rbenv/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/sous-chefs/ruby_rbenv/statuses/864542efc93e621f446b04c586f2a9673cb54457"}},"author_association":"NONE"}}
{"actor":{"display_login":"damacus"}}