{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/37275","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/37275/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/37275/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/37275/events","html_url":"https://github.com/ansible/ansible/pull/37275","id":304158383,"number":37275,"title":"Letsencrypt: add account management module","user":{"login":"felixfontein","id":5781356,"avatar_url":"https://avatars0.githubusercontent.com/u/5781356?v=4","gravatar_id":"","url":"https://api.github.com/users/felixfontein","html_url":"https://github.com/felixfontein","followers_url":"https://api.github.com/users/felixfontein/followers","following_url":"https://api.github.com/users/felixfontein/following{/other_user}","gists_url":"https://api.github.com/users/felixfontein/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfontein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfontein/subscriptions","organizations_url":"https://api.github.com/users/felixfontein/orgs","repos_url":"https://api.github.com/users/felixfontein/repos","events_url":"https://api.github.com/users/felixfontein/events{/privacy}","received_events_url":"https://api.github.com/users/felixfontein/received_events","type":"User","site_admin":false},"labels":[{"id":513652538,"url":"https://api.github.com/repos/ansible/ansible/labels/core_review","name":"core_review","color":"ededed","default":false},{"id":496359346,"url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":473225334,"url":"https://api.github.com/repos/ansible/ansible/labels/new_module","name":"new_module","color":"ededed","default":false},{"id":153577825,"url":"https://api.github.com/repos/ansible/ansible/labels/new_plugin","name":"new_plugin","color":"bfe5bf","default":false},{"id":636327968,"url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false},{"id":636352796,"url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false},{"id":468273802,"url":"https://api.github.com/repos/ansible/ansible/labels/test","name":"test","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-03-11T13:28:19Z","updated_at":"2018-04-07T13:26:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/37275","html_url":"https://github.com/ansible/ansible/pull/37275","diff_url":"https://github.com/ansible/ansible/pull/37275.diff","patch_url":"https://github.com/ansible/ansible/pull/37275.patch"},"body":"##### SUMMARY\r\nAdds a new module which allows to manage Let's Encrypt accounts (using the ACME v2 protocol). Fixes #36346.\r\n\r\n##### ISSUE TYPE\r\nNew Module Pull Request\r\n\r\n##### COMPONENT NAME\r\nletsencrypt_account\r\n\r\n##### ANSIBLE VERSION\r\n2.6\r\n\r\n##### ADDITIONAL INFORMATION\r\nThere are some integration tests. I'm using an EC account key so that this will be fast. This test depends on the Let's Encrypt ACME v2 staging endpoint. If Ansible tests should not depend on external services, I will remove the tests for now.\r\n"},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/379469158","html_url":"https://github.com/ansible/ansible/pull/37275#issuecomment-379469158","issue_url":"https://api.github.com/repos/ansible/ansible/issues/37275","id":379469158,"user":{"login":"felixfontein","id":5781356,"avatar_url":"https://avatars0.githubusercontent.com/u/5781356?v=4","gravatar_id":"","url":"https://api.github.com/users/felixfontein","html_url":"https://github.com/felixfontein","followers_url":"https://api.github.com/users/felixfontein/followers","following_url":"https://api.github.com/users/felixfontein/following{/other_user}","gists_url":"https://api.github.com/users/felixfontein/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfontein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfontein/subscriptions","organizations_url":"https://api.github.com/users/felixfontein/orgs","repos_url":"https://api.github.com/users/felixfontein/repos","events_url":"https://api.github.com/users/felixfontein/events{/privacy}","received_events_url":"https://api.github.com/users/felixfontein/received_events","type":"User","site_admin":false},"created_at":"2018-04-07T13:26:30Z","updated_at":"2018-04-07T13:26:30Z","author_association":"CONTRIBUTOR","body":"@abadger @aioue @Akasurde @bverschueren @cgar @gundalow @kgottholm @mattclay @mgruener @resmo\r\n\r\nDear all,\r\nI want to add two more Let's Encrypt modules to Ansible (one for account management #36346, implemented in this PR, and one for revoking certificates #36345). Since some of the code from the `letsencrypt` module can be re-used for these tasks, I wanted to move parts of it to a Python module in the `module_utils` folder. This is done in this PR; you can see the [new Python module `module_utils/letsencrypt.py` here](https://github.com/felixfontein/ansible/blob/72c32fa84ff80b6a5bbba12e4f9fabe86194360e/lib/ansible/module_utils/letsencrypt.py).\r\nNow all Python modules in `module_utils` must have a BSD license; the original module is licensed under GPLv3. Since you all authored commits which modified code or comments which will be moved into `module_utils` by this commit, you all need to confirm that you are OK with this license change. All code not moved to `module_utils` is not affected by this. In this PR, some of the documentation is moved to [`utils/module_docs_fragments/letsencrypt.py`](https://github.com/felixfontein/ansible/blob/72c32fa84ff80b6a5bbba12e4f9fabe86194360e/lib/ansible/utils/module_docs_fragments/letsencrypt.py); this will stay GPL licensed.\r\nMore precisely, I want to change the lines:\r\n``` .py\r\n# (c) 2016 Michael Gruener <michael.gruener@chaosmoon.net>\r\n# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)\r\n```\r\nof `module_utils/letsencrypt.py` into\r\n``` .py\r\n# This code is part of Ansible, but is an independent component.\r\n# This particular file snippet, and this file snippet only, is BSD licensed.\r\n# Modules you write using this snippet, which is embedded dynamically by Ansible\r\n# still belong to the author of the module, and may assign their own license\r\n# to the complete work.\r\n#\r\n# Copyright (c), Michael Gruener <michael.gruener@chaosmoon.net>, 2016\r\n#\r\n# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)\r\n```\r\n(Taken from [`module_utils/urls.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/urls.py).)\r\nPlease confirm by writing a comment in this PR whether you are OK with this change or not. Thank you very much in advance!\r\n"}}
{"actor":{"display_login":"felixfontein"}}