{"action":"created","comment":{"url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/pulls/comments/189448445","pull_request_review_id":121633198,"id":189448445,"diff_hunk":"@@ -77,7 +78,7 @@ int main(int argc, void **argv) {\n \n     g_do_nxboot = loader_ctx->chainload_entrypoint == 0;\n     if (g_do_nxboot) {\n-        nxboot_main();\n+        nxboot_main((uint8_t*)g_framebuffer);","path":"fusee/fusee-secondary/src/main.c","position":13,"original_position":13,"commit_id":"860b852e4e109f1f2ed80ffae8303ed012492dac","original_commit_id":"860b852e4e109f1f2ed80ffae8303ed012492dac","user":{"login":"Sorixelle","id":38685302,"avatar_url":"https://avatars3.githubusercontent.com/u/38685302?v=4","gravatar_id":"","url":"https://api.github.com/users/Sorixelle","html_url":"https://github.com/Sorixelle","followers_url":"https://api.github.com/users/Sorixelle/followers","following_url":"https://api.github.com/users/Sorixelle/following{/other_user}","gists_url":"https://api.github.com/users/Sorixelle/gists{/gist_id}","starred_url":"https://api.github.com/users/Sorixelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sorixelle/subscriptions","organizations_url":"https://api.github.com/users/Sorixelle/orgs","repos_url":"https://api.github.com/users/Sorixelle/repos","events_url":"https://api.github.com/users/Sorixelle/events{/privacy}","received_events_url":"https://api.github.com/users/Sorixelle/received_events","type":"User","site_admin":false},"body":"When I made this PR, `g_framebuffer` was defined there. However, it was moved between then and now, and I did an update to that fork which broke this (probably a bad idea). Tux has mentioned he'll merge and make any necessary changes, however, and the team is aware of this issue.","created_at":"2018-05-20T01:03:56Z","updated_at":"2018-05-20T01:03:56Z","html_url":"https://github.com/Atmosphere-NX/Atmosphere/pull/95#discussion_r189448445","pull_request_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/pulls/95","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/pulls/comments/189448445"},"html":{"href":"https://github.com/Atmosphere-NX/Atmosphere/pull/95#discussion_r189448445"},"pull_request":{"href":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/pulls/95"}},"in_reply_to_id":189445423},"pull_request":{"url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/pulls/95","id":187122251,"html_url":"https://github.com/Atmosphere-NX/Atmosphere/pull/95","diff_url":"https://github.com/Atmosphere-NX/Atmosphere/pull/95.diff","patch_url":"https://github.com/Atmosphere-NX/Atmosphere/pull/95.patch","issue_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/issues/95","number":95,"state":"open","locked":false,"title":"Implement splash screen loading for fusee stage2","user":{"login":"Sorixelle","id":38685302,"avatar_url":"https://avatars3.githubusercontent.com/u/38685302?v=4","gravatar_id":"","url":"https://api.github.com/users/Sorixelle","html_url":"https://github.com/Sorixelle","followers_url":"https://api.github.com/users/Sorixelle/followers","following_url":"https://api.github.com/users/Sorixelle/following{/other_user}","gists_url":"https://api.github.com/users/Sorixelle/gists{/gist_id}","starred_url":"https://api.github.com/users/Sorixelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sorixelle/subscriptions","organizations_url":"https://api.github.com/users/Sorixelle/orgs","repos_url":"https://api.github.com/users/Sorixelle/repos","events_url":"https://api.github.com/users/Sorixelle/events{/privacy}","received_events_url":"https://api.github.com/users/Sorixelle/received_events","type":"User","site_admin":false},"body":"Currently, it only supports BMP splashes. If the splash couldn't be loaded for whatever reason, it will fall back to the default splash, statically linked into the stage2 binary.\r\n\r\nAs the default splash is quite large, this also increases the size of stage2 by quite a bit (~250KB -> >3MB). High speed SD reading might want to be looked into soon, as stage2 takes about 2-3 minutes in my experience to load now.\r\n\r\nExample image:\r\n![Splash Example](https://cdn.discordapp.com/attachments/415701147169587200/443740264134344704/image6.jpeg)","created_at":"2018-05-10T07:36:06Z","updated_at":"2018-05-20T01:03:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9c49113ce7e841c2d5317acb38208c1b11a2740","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/pulls/95/commits","review_comments_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/pulls/95/comments","review_comment_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/issues/95/comments","statuses_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/statuses/860b852e4e109f1f2ed80ffae8303ed012492dac","head":{"label":"Sorixelle:master","ref":"master","sha":"860b852e4e109f1f2ed80ffae8303ed012492dac","user":{"login":"Sorixelle","id":38685302,"avatar_url":"https://avatars3.githubusercontent.com/u/38685302?v=4","gravatar_id":"","url":"https://api.github.com/users/Sorixelle","html_url":"https://github.com/Sorixelle","followers_url":"https://api.github.com/users/Sorixelle/followers","following_url":"https://api.github.com/users/Sorixelle/following{/other_user}","gists_url":"https://api.github.com/users/Sorixelle/gists{/gist_id}","starred_url":"https://api.github.com/users/Sorixelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sorixelle/subscriptions","organizations_url":"https://api.github.com/users/Sorixelle/orgs","repos_url":"https://api.github.com/users/Sorixelle/repos","events_url":"https://api.github.com/users/Sorixelle/events{/privacy}","received_events_url":"https://api.github.com/users/Sorixelle/received_events","type":"User","site_admin":false},"repo":{"id":132670653,"name":"Atmosphere","full_name":"Sorixelle/Atmosphere","owner":{"login":"Sorixelle","id":38685302,"avatar_url":"https://avatars3.githubusercontent.com/u/38685302?v=4","gravatar_id":"","url":"https://api.github.com/users/Sorixelle","html_url":"https://github.com/Sorixelle","followers_url":"https://api.github.com/users/Sorixelle/followers","following_url":"https://api.github.com/users/Sorixelle/following{/other_user}","gists_url":"https://api.github.com/users/Sorixelle/gists{/gist_id}","starred_url":"https://api.github.com/users/Sorixelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sorixelle/subscriptions","organizations_url":"https://api.github.com/users/Sorixelle/orgs","repos_url":"https://api.github.com/users/Sorixelle/repos","events_url":"https://api.github.com/users/Sorixelle/events{/privacy}","received_events_url":"https://api.github.com/users/Sorixelle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sorixelle/Atmosphere","description":"Atmosphère is a work-in-progress customized firmware for the Nintendo Switch.","fork":true,"url":"https://api.github.com/repos/Sorixelle/Atmosphere","forks_url":"https://api.github.com/repos/Sorixelle/Atmosphere/forks","keys_url":"https://api.github.com/repos/Sorixelle/Atmosphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sorixelle/Atmosphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sorixelle/Atmosphere/teams","hooks_url":"https://api.github.com/repos/Sorixelle/Atmosphere/hooks","issue_events_url":"https://api.github.com/repos/Sorixelle/Atmosphere/issues/events{/number}","events_url":"https://api.github.com/repos/Sorixelle/Atmosphere/events","assignees_url":"https://api.github.com/repos/Sorixelle/Atmosphere/assignees{/user}","branches_url":"https://api.github.com/repos/Sorixelle/Atmosphere/branches{/branch}","tags_url":"https://api.github.com/repos/Sorixelle/Atmosphere/tags","blobs_url":"https://api.github.com/repos/Sorixelle/Atmosphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sorixelle/Atmosphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sorixelle/Atmosphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sorixelle/Atmosphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sorixelle/Atmosphere/statuses/{sha}","languages_url":"https://api.github.com/repos/Sorixelle/Atmosphere/languages","stargazers_url":"https://api.github.com/repos/Sorixelle/Atmosphere/stargazers","contributors_url":"https://api.github.com/repos/Sorixelle/Atmosphere/contributors","subscribers_url":"https://api.github.com/repos/Sorixelle/Atmosphere/subscribers","subscription_url":"https://api.github.com/repos/Sorixelle/Atmosphere/subscription","commits_url":"https://api.github.com/repos/Sorixelle/Atmosphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sorixelle/Atmosphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sorixelle/Atmosphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sorixelle/Atmosphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sorixelle/Atmosphere/contents/{+path}","compare_url":"https://api.github.com/repos/Sorixelle/Atmosphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sorixelle/Atmosphere/merges","archive_url":"https://api.github.com/repos/Sorixelle/Atmosphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sorixelle/Atmosphere/downloads","issues_url":"https://api.github.com/repos/Sorixelle/Atmosphere/issues{/number}","pulls_url":"https://api.github.com/repos/Sorixelle/Atmosphere/pulls{/number}","milestones_url":"https://api.github.com/repos/Sorixelle/Atmosphere/milestones{/number}","notifications_url":"https://api.github.com/repos/Sorixelle/Atmosphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sorixelle/Atmosphere/labels{/name}","releases_url":"https://api.github.com/repos/Sorixelle/Atmosphere/releases{/id}","deployments_url":"https://api.github.com/repos/Sorixelle/Atmosphere/deployments","created_at":"2018-05-08T22:11:03Z","updated_at":"2018-05-20T00:23:39Z","pushed_at":"2018-05-20T00:22:55Z","git_url":"git://github.com/Sorixelle/Atmosphere.git","ssh_url":"git@github.com:Sorixelle/Atmosphere.git","clone_url":"https://github.com/Sorixelle/Atmosphere.git","svn_url":"https://github.com/Sorixelle/Atmosphere","homepage":"","size":3549,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Atmosphere-NX:master","ref":"master","sha":"b4eeddd7e1575d472aa76d785b40d726d1ab3b3f","user":{"login":"Atmosphere-NX","id":37918415,"avatar_url":"https://avatars1.githubusercontent.com/u/37918415?v=4","gravatar_id":"","url":"https://api.github.com/users/Atmosphere-NX","html_url":"https://github.com/Atmosphere-NX","followers_url":"https://api.github.com/users/Atmosphere-NX/followers","following_url":"https://api.github.com/users/Atmosphere-NX/following{/other_user}","gists_url":"https://api.github.com/users/Atmosphere-NX/gists{/gist_id}","starred_url":"https://api.github.com/users/Atmosphere-NX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atmosphere-NX/subscriptions","organizations_url":"https://api.github.com/users/Atmosphere-NX/orgs","repos_url":"https://api.github.com/users/Atmosphere-NX/repos","events_url":"https://api.github.com/users/Atmosphere-NX/events{/privacy}","received_events_url":"https://api.github.com/users/Atmosphere-NX/received_events","type":"Organization","site_admin":false},"repo":{"id":117948953,"name":"Atmosphere","full_name":"Atmosphere-NX/Atmosphere","owner":{"login":"Atmosphere-NX","id":37918415,"avatar_url":"https://avatars1.githubusercontent.com/u/37918415?v=4","gravatar_id":"","url":"https://api.github.com/users/Atmosphere-NX","html_url":"https://github.com/Atmosphere-NX","followers_url":"https://api.github.com/users/Atmosphere-NX/followers","following_url":"https://api.github.com/users/Atmosphere-NX/following{/other_user}","gists_url":"https://api.github.com/users/Atmosphere-NX/gists{/gist_id}","starred_url":"https://api.github.com/users/Atmosphere-NX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atmosphere-NX/subscriptions","organizations_url":"https://api.github.com/users/Atmosphere-NX/orgs","repos_url":"https://api.github.com/users/Atmosphere-NX/repos","events_url":"https://api.github.com/users/Atmosphere-NX/events{/privacy}","received_events_url":"https://api.github.com/users/Atmosphere-NX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Atmosphere-NX/Atmosphere","description":"Atmosphère is a work-in-progress customized firmware for the Nintendo Switch.","fork":false,"url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere","forks_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/forks","keys_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/teams","hooks_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/hooks","issue_events_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/issues/events{/number}","events_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/events","assignees_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/assignees{/user}","branches_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/branches{/branch}","tags_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/tags","blobs_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/statuses/{sha}","languages_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/languages","stargazers_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/stargazers","contributors_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/contributors","subscribers_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/subscribers","subscription_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/subscription","commits_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/contents/{+path}","compare_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/merges","archive_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/downloads","issues_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/issues{/number}","pulls_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/pulls{/number}","milestones_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/milestones{/number}","notifications_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/labels{/name}","releases_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/releases{/id}","deployments_url":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/deployments","created_at":"2018-01-18T07:36:33Z","updated_at":"2018-05-19T23:40:36Z","pushed_at":"2018-05-19T23:40:34Z","git_url":"git://github.com/Atmosphere-NX/Atmosphere.git","ssh_url":"git@github.com:Atmosphere-NX/Atmosphere.git","clone_url":"https://github.com/Atmosphere-NX/Atmosphere.git","svn_url":"https://github.com/Atmosphere-NX/Atmosphere","homepage":"","size":3644,"stargazers_count":857,"watchers_count":857,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":94,"open_issues":25,"watchers":857,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/pulls/95"},"html":{"href":"https://github.com/Atmosphere-NX/Atmosphere/pull/95"},"issue":{"href":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/issues/95"},"comments":{"href":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/Atmosphere-NX/Atmosphere/statuses/860b852e4e109f1f2ed80ffae8303ed012492dac"}},"author_association":"NONE"}}
{"actor":{"display_login":"Sorixelle"}}