{"action":"created","comment":{"url":"https://api.github.com/repos/elucideye/acf/pulls/comments/178096910","pull_request_review_id":108099011,"id":178096910,"diff_hunk":"@@ -10,7 +10,7 @@ add_executable(${test_app} ${acf_ut_srcs})\n set_property(TARGET ${test_app} PROPERTY FOLDER \"app/tests\")\n target_link_libraries(${test_app} PUBLIC acf GTest::gtest ${OpenCV_LIBS})\n \n-if ((${ACF_DO_GPU_TESTING}) AND ACF_BUILD_OGLES_GPGPU)\n+if (ACF_BUILD_OGLES_GPGPU and aglet_FOUND)","path":"src/lib/acf/ut/CMakeLists.txt","position":5,"original_position":5,"commit_id":"7b42c07480ed9b73b4b6667ccc2358c510ea7c93","original_commit_id":"7b42c07480ed9b73b4b6667ccc2358c510ea7c93","user":{"login":"ruslo","id":4346993,"avatar_url":"https://avatars2.githubusercontent.com/u/4346993?v=4","gravatar_id":"","url":"https://api.github.com/users/ruslo","html_url":"https://github.com/ruslo","followers_url":"https://api.github.com/users/ruslo/followers","following_url":"https://api.github.com/users/ruslo/following{/other_user}","gists_url":"https://api.github.com/users/ruslo/gists{/gist_id}","starred_url":"https://api.github.com/users/ruslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruslo/subscriptions","organizations_url":"https://api.github.com/users/ruslo/orgs","repos_url":"https://api.github.com/users/ruslo/repos","events_url":"https://api.github.com/users/ruslo/events{/privacy}","received_events_url":"https://api.github.com/users/ruslo/received_events","type":"User","site_admin":false},"body":"May be `AND TARGET aglet::aglet`?","created_at":"2018-03-29T15:38:42Z","updated_at":"2018-03-29T15:40:16Z","html_url":"https://github.com/elucideye/acf/pull/39#discussion_r178096910","pull_request_url":"https://api.github.com/repos/elucideye/acf/pulls/39","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elucideye/acf/pulls/comments/178096910"},"html":{"href":"https://github.com/elucideye/acf/pull/39#discussion_r178096910"},"pull_request":{"href":"https://api.github.com/repos/elucideye/acf/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/elucideye/acf/pulls/39","id":178364007,"html_url":"https://github.com/elucideye/acf/pull/39","diff_url":"https://github.com/elucideye/acf/pull/39.diff","patch_url":"https://github.com/elucideye/acf/pull/39.patch","issue_url":"https://api.github.com/repos/elucideye/acf/issues/39","number":39,"state":"open","locked":false,"title":"cmake updates","user":{"login":"headupinclouds","id":554720,"avatar_url":"https://avatars3.githubusercontent.com/u/554720?v=4","gravatar_id":"","url":"https://api.github.com/users/headupinclouds","html_url":"https://github.com/headupinclouds","followers_url":"https://api.github.com/users/headupinclouds/followers","following_url":"https://api.github.com/users/headupinclouds/following{/other_user}","gists_url":"https://api.github.com/users/headupinclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/headupinclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/headupinclouds/subscriptions","organizations_url":"https://api.github.com/users/headupinclouds/orgs","repos_url":"https://api.github.com/users/headupinclouds/repos","events_url":"https://api.github.com/users/headupinclouds/events{/privacy}","received_events_url":"https://api.github.com/users/headupinclouds/received_events","type":"User","site_admin":false},"body":"* update local vs dependency cmake build logic (we rely on HUNTER_ENABLED to indicate a package build, so the test will fail for in-repo builds after the first build — this isn’t really a problem until the local config options are different — so we set ACF_IS_REPO_BUILD in the cache to remember that we are an in-repo build)\r\n* fix grammar in cmake error\r\n* add an option to ignore the CI friendly drishti-upload configuration (in favor of local (most likely more recent versions of opencv, etc)\r\n* update local cmake logic related to gpu use : assume we won’t have a gpu on CI platforms unless it is android where the HW emulator is available and assume gpu is available elsewhere (reasonable heuristic)\r\n* use ACF_HAS_GPU for conditiona gpu builds (if that stuff is enabled)\r\n* enable ACF_USE_DRISHTI_UPLOAD in travis/appveyor configs\r\n* update logic for building aglet (for portable context usage): if we are building tests or examples and ACF_HAS_GPU AND ACF_BUILD_OGLES_GPGPU then we pull in the aglet package for later context creation in the console apps/tests\r\n* update logic related to GPU tests in src/lib/acf/ut/CMakeLists.txt: `if (ACF_BUILD_OGLES_GPGPU and aglet_FOUND)`\r\n* move some of ObjectDetector.h definition to ObjectDetector.cpp (explicit compilation)\r\n* remove a few comments in cpp files, etc","created_at":"2018-03-29T15:30:50Z","updated_at":"2018-03-29T15:40:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd40d9d4a3f69fae935618c2fde999af356f15a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elucideye/acf/pulls/39/commits","review_comments_url":"https://api.github.com/repos/elucideye/acf/pulls/39/comments","review_comment_url":"https://api.github.com/repos/elucideye/acf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elucideye/acf/issues/39/comments","statuses_url":"https://api.github.com/repos/elucideye/acf/statuses/7b42c07480ed9b73b4b6667ccc2358c510ea7c93","head":{"label":"elucideye:pr.cmake.updates","ref":"pr.cmake.updates","sha":"7b42c07480ed9b73b4b6667ccc2358c510ea7c93","user":{"login":"elucideye","id":20400838,"avatar_url":"https://avatars1.githubusercontent.com/u/20400838?v=4","gravatar_id":"","url":"https://api.github.com/users/elucideye","html_url":"https://github.com/elucideye","followers_url":"https://api.github.com/users/elucideye/followers","following_url":"https://api.github.com/users/elucideye/following{/other_user}","gists_url":"https://api.github.com/users/elucideye/gists{/gist_id}","starred_url":"https://api.github.com/users/elucideye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elucideye/subscriptions","organizations_url":"https://api.github.com/users/elucideye/orgs","repos_url":"https://api.github.com/users/elucideye/repos","events_url":"https://api.github.com/users/elucideye/events{/privacy}","received_events_url":"https://api.github.com/users/elucideye/received_events","type":"Organization","site_admin":false},"repo":{"id":104651900,"name":"acf","full_name":"elucideye/acf","owner":{"login":"elucideye","id":20400838,"avatar_url":"https://avatars1.githubusercontent.com/u/20400838?v=4","gravatar_id":"","url":"https://api.github.com/users/elucideye","html_url":"https://github.com/elucideye","followers_url":"https://api.github.com/users/elucideye/followers","following_url":"https://api.github.com/users/elucideye/following{/other_user}","gists_url":"https://api.github.com/users/elucideye/gists{/gist_id}","starred_url":"https://api.github.com/users/elucideye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elucideye/subscriptions","organizations_url":"https://api.github.com/users/elucideye/orgs","repos_url":"https://api.github.com/users/elucideye/repos","events_url":"https://api.github.com/users/elucideye/events{/privacy}","received_events_url":"https://api.github.com/users/elucideye/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elucideye/acf","description":"Aggregated Channel Feature object detection in C++ and OpenGL ES 2.0","fork":false,"url":"https://api.github.com/repos/elucideye/acf","forks_url":"https://api.github.com/repos/elucideye/acf/forks","keys_url":"https://api.github.com/repos/elucideye/acf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elucideye/acf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elucideye/acf/teams","hooks_url":"https://api.github.com/repos/elucideye/acf/hooks","issue_events_url":"https://api.github.com/repos/elucideye/acf/issues/events{/number}","events_url":"https://api.github.com/repos/elucideye/acf/events","assignees_url":"https://api.github.com/repos/elucideye/acf/assignees{/user}","branches_url":"https://api.github.com/repos/elucideye/acf/branches{/branch}","tags_url":"https://api.github.com/repos/elucideye/acf/tags","blobs_url":"https://api.github.com/repos/elucideye/acf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elucideye/acf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elucideye/acf/git/refs{/sha}","trees_url":"https://api.github.com/repos/elucideye/acf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elucideye/acf/statuses/{sha}","languages_url":"https://api.github.com/repos/elucideye/acf/languages","stargazers_url":"https://api.github.com/repos/elucideye/acf/stargazers","contributors_url":"https://api.github.com/repos/elucideye/acf/contributors","subscribers_url":"https://api.github.com/repos/elucideye/acf/subscribers","subscription_url":"https://api.github.com/repos/elucideye/acf/subscription","commits_url":"https://api.github.com/repos/elucideye/acf/commits{/sha}","git_commits_url":"https://api.github.com/repos/elucideye/acf/git/commits{/sha}","comments_url":"https://api.github.com/repos/elucideye/acf/comments{/number}","issue_comment_url":"https://api.github.com/repos/elucideye/acf/issues/comments{/number}","contents_url":"https://api.github.com/repos/elucideye/acf/contents/{+path}","compare_url":"https://api.github.com/repos/elucideye/acf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elucideye/acf/merges","archive_url":"https://api.github.com/repos/elucideye/acf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elucideye/acf/downloads","issues_url":"https://api.github.com/repos/elucideye/acf/issues{/number}","pulls_url":"https://api.github.com/repos/elucideye/acf/pulls{/number}","milestones_url":"https://api.github.com/repos/elucideye/acf/milestones{/number}","notifications_url":"https://api.github.com/repos/elucideye/acf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elucideye/acf/labels{/name}","releases_url":"https://api.github.com/repos/elucideye/acf/releases{/id}","deployments_url":"https://api.github.com/repos/elucideye/acf/deployments","created_at":"2017-09-24T14:50:19Z","updated_at":"2018-02-26T14:07:53Z","pushed_at":"2018-03-29T15:30:51Z","git_url":"git://github.com/elucideye/acf.git","ssh_url":"git@github.com:elucideye/acf.git","clone_url":"https://github.com/elucideye/acf.git","svn_url":"https://github.com/elucideye/acf","homepage":"","size":185,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":10,"open_issues":11,"watchers":10,"default_branch":"master"}},"base":{"label":"elucideye:master","ref":"master","sha":"17b8da4c72290a55ecfcca7899dbdd1da061ce80","user":{"login":"elucideye","id":20400838,"avatar_url":"https://avatars1.githubusercontent.com/u/20400838?v=4","gravatar_id":"","url":"https://api.github.com/users/elucideye","html_url":"https://github.com/elucideye","followers_url":"https://api.github.com/users/elucideye/followers","following_url":"https://api.github.com/users/elucideye/following{/other_user}","gists_url":"https://api.github.com/users/elucideye/gists{/gist_id}","starred_url":"https://api.github.com/users/elucideye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elucideye/subscriptions","organizations_url":"https://api.github.com/users/elucideye/orgs","repos_url":"https://api.github.com/users/elucideye/repos","events_url":"https://api.github.com/users/elucideye/events{/privacy}","received_events_url":"https://api.github.com/users/elucideye/received_events","type":"Organization","site_admin":false},"repo":{"id":104651900,"name":"acf","full_name":"elucideye/acf","owner":{"login":"elucideye","id":20400838,"avatar_url":"https://avatars1.githubusercontent.com/u/20400838?v=4","gravatar_id":"","url":"https://api.github.com/users/elucideye","html_url":"https://github.com/elucideye","followers_url":"https://api.github.com/users/elucideye/followers","following_url":"https://api.github.com/users/elucideye/following{/other_user}","gists_url":"https://api.github.com/users/elucideye/gists{/gist_id}","starred_url":"https://api.github.com/users/elucideye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elucideye/subscriptions","organizations_url":"https://api.github.com/users/elucideye/orgs","repos_url":"https://api.github.com/users/elucideye/repos","events_url":"https://api.github.com/users/elucideye/events{/privacy}","received_events_url":"https://api.github.com/users/elucideye/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elucideye/acf","description":"Aggregated Channel Feature object detection in C++ and OpenGL ES 2.0","fork":false,"url":"https://api.github.com/repos/elucideye/acf","forks_url":"https://api.github.com/repos/elucideye/acf/forks","keys_url":"https://api.github.com/repos/elucideye/acf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elucideye/acf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elucideye/acf/teams","hooks_url":"https://api.github.com/repos/elucideye/acf/hooks","issue_events_url":"https://api.github.com/repos/elucideye/acf/issues/events{/number}","events_url":"https://api.github.com/repos/elucideye/acf/events","assignees_url":"https://api.github.com/repos/elucideye/acf/assignees{/user}","branches_url":"https://api.github.com/repos/elucideye/acf/branches{/branch}","tags_url":"https://api.github.com/repos/elucideye/acf/tags","blobs_url":"https://api.github.com/repos/elucideye/acf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elucideye/acf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elucideye/acf/git/refs{/sha}","trees_url":"https://api.github.com/repos/elucideye/acf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elucideye/acf/statuses/{sha}","languages_url":"https://api.github.com/repos/elucideye/acf/languages","stargazers_url":"https://api.github.com/repos/elucideye/acf/stargazers","contributors_url":"https://api.github.com/repos/elucideye/acf/contributors","subscribers_url":"https://api.github.com/repos/elucideye/acf/subscribers","subscription_url":"https://api.github.com/repos/elucideye/acf/subscription","commits_url":"https://api.github.com/repos/elucideye/acf/commits{/sha}","git_commits_url":"https://api.github.com/repos/elucideye/acf/git/commits{/sha}","comments_url":"https://api.github.com/repos/elucideye/acf/comments{/number}","issue_comment_url":"https://api.github.com/repos/elucideye/acf/issues/comments{/number}","contents_url":"https://api.github.com/repos/elucideye/acf/contents/{+path}","compare_url":"https://api.github.com/repos/elucideye/acf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elucideye/acf/merges","archive_url":"https://api.github.com/repos/elucideye/acf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elucideye/acf/downloads","issues_url":"https://api.github.com/repos/elucideye/acf/issues{/number}","pulls_url":"https://api.github.com/repos/elucideye/acf/pulls{/number}","milestones_url":"https://api.github.com/repos/elucideye/acf/milestones{/number}","notifications_url":"https://api.github.com/repos/elucideye/acf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elucideye/acf/labels{/name}","releases_url":"https://api.github.com/repos/elucideye/acf/releases{/id}","deployments_url":"https://api.github.com/repos/elucideye/acf/deployments","created_at":"2017-09-24T14:50:19Z","updated_at":"2018-02-26T14:07:53Z","pushed_at":"2018-03-29T15:30:51Z","git_url":"git://github.com/elucideye/acf.git","ssh_url":"git@github.com:elucideye/acf.git","clone_url":"https://github.com/elucideye/acf.git","svn_url":"https://github.com/elucideye/acf","homepage":"","size":185,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":10,"open_issues":11,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elucideye/acf/pulls/39"},"html":{"href":"https://github.com/elucideye/acf/pull/39"},"issue":{"href":"https://api.github.com/repos/elucideye/acf/issues/39"},"comments":{"href":"https://api.github.com/repos/elucideye/acf/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/elucideye/acf/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/elucideye/acf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elucideye/acf/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/elucideye/acf/statuses/7b42c07480ed9b73b4b6667ccc2358c510ea7c93"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ruslo"}}