{"action":"created","comment":{"url":"https://api.github.com/repos/golemfactory/concent/pulls/comments/207458700","pull_request_review_id":143074692,"id":207458700,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzQ1ODcwMA==","diff_hunk":"@@ -77,45 +77,48 @@ def test_that_middleman_is_created_with_default_params(self):  # pylint: disable\n class TestMiddleManServer:\n     patcher = None\n     crash_logger_mock = None\n+    internal_port = None\n+    external_port = None\n+    middleman = None\n \n     @pytest.fixture(autouse=True)\n-    def middleman_setup(self, unused_tcp_port_factory, event_loop):\n+    def _middleman_setup(self, unused_tcp_port_factory, event_loop):\n         self.patcher = mock.patch(\"middleman.middleman_server.crash_logger\")\n         self.crash_logger_mock = self.patcher.start()\n         self.internal_port, self.external_port = unused_tcp_port_factory(), unused_tcp_port_factory()\n         self.middleman = MiddleMan(internal_port=self.internal_port, external_port=self.external_port, loop=event_loop)\n         yield self.internal_port, self.external_port\n         self.patcher.stop()\n \n-    def test_that_if_keyboard_interrupt_is_raised_application_will_exit_without_errors(self, middleman_setup):\n+    def test_that_if_keyboard_interrupt_is_raised_application_will_exit_without_errors(self, _middleman_setup):","path":"concent_api/middleman/tests/test_middleman.py","position":19,"original_position":19,"commit_id":"a5680e981d4c6612f7fe171ef1a3f6e1dd4a45df","original_commit_id":"a5680e981d4c6612f7fe171ef1a3f6e1dd4a45df","user":{"login":"dybi","id":36961162,"node_id":"MDQ6VXNlcjM2OTYxMTYy","avatar_url":"https://avatars0.githubusercontent.com/u/36961162?v=4","gravatar_id":"","url":"https://api.github.com/users/dybi","html_url":"https://github.com/dybi","followers_url":"https://api.github.com/users/dybi/followers","following_url":"https://api.github.com/users/dybi/following{/other_user}","gists_url":"https://api.github.com/users/dybi/gists{/gist_id}","starred_url":"https://api.github.com/users/dybi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dybi/subscriptions","organizations_url":"https://api.github.com/users/dybi/orgs","repos_url":"https://api.github.com/users/dybi/repos","events_url":"https://api.github.com/users/dybi/events{/privacy}","received_events_url":"https://api.github.com/users/dybi/received_events","type":"User","site_admin":false},"body":"remove `_middleman_setup` from here and the rest of test methods","created_at":"2018-08-03T07:10:35Z","updated_at":"2018-08-03T07:14:20Z","html_url":"https://github.com/golemfactory/concent/pull/699#discussion_r207458700","pull_request_url":"https://api.github.com/repos/golemfactory/concent/pulls/699","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/comments/207458700"},"html":{"href":"https://github.com/golemfactory/concent/pull/699#discussion_r207458700"},"pull_request":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/699"}}},"pull_request":{"url":"https://api.github.com/repos/golemfactory/concent/pulls/699","id":205740370,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NzQwMzcw","html_url":"https://github.com/golemfactory/concent/pull/699","diff_url":"https://github.com/golemfactory/concent/pull/699.diff","patch_url":"https://github.com/golemfactory/concent/pull/699.patch","issue_url":"https://api.github.com/repos/golemfactory/concent/issues/699","number":699,"state":"open","locked":false,"title":"Fix pylint warnings in middleman tests","user":{"login":"Jakub89","id":20682491,"node_id":"MDQ6VXNlcjIwNjgyNDkx","avatar_url":"https://avatars2.githubusercontent.com/u/20682491?v=4","gravatar_id":"","url":"https://api.github.com/users/Jakub89","html_url":"https://github.com/Jakub89","followers_url":"https://api.github.com/users/Jakub89/followers","following_url":"https://api.github.com/users/Jakub89/following{/other_user}","gists_url":"https://api.github.com/users/Jakub89/gists{/gist_id}","starred_url":"https://api.github.com/users/Jakub89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jakub89/subscriptions","organizations_url":"https://api.github.com/users/Jakub89/orgs","repos_url":"https://api.github.com/users/Jakub89/repos","events_url":"https://api.github.com/users/Jakub89/events{/privacy}","received_events_url":"https://api.github.com/users/Jakub89/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-02T13:46:28Z","updated_at":"2018-08-03T07:14:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd03b80e5e0b52c0d3950fec7ef58b6582bc2f63","assignee":{"login":"Jakub89","id":20682491,"node_id":"MDQ6VXNlcjIwNjgyNDkx","avatar_url":"https://avatars2.githubusercontent.com/u/20682491?v=4","gravatar_id":"","url":"https://api.github.com/users/Jakub89","html_url":"https://github.com/Jakub89","followers_url":"https://api.github.com/users/Jakub89/followers","following_url":"https://api.github.com/users/Jakub89/following{/other_user}","gists_url":"https://api.github.com/users/Jakub89/gists{/gist_id}","starred_url":"https://api.github.com/users/Jakub89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jakub89/subscriptions","organizations_url":"https://api.github.com/users/Jakub89/orgs","repos_url":"https://api.github.com/users/Jakub89/repos","events_url":"https://api.github.com/users/Jakub89/events{/privacy}","received_events_url":"https://api.github.com/users/Jakub89/received_events","type":"User","site_admin":false},"assignees":[{"login":"Jakub89","id":20682491,"node_id":"MDQ6VXNlcjIwNjgyNDkx","avatar_url":"https://avatars2.githubusercontent.com/u/20682491?v=4","gravatar_id":"","url":"https://api.github.com/users/Jakub89","html_url":"https://github.com/Jakub89","followers_url":"https://api.github.com/users/Jakub89/followers","following_url":"https://api.github.com/users/Jakub89/following{/other_user}","gists_url":"https://api.github.com/users/Jakub89/gists{/gist_id}","starred_url":"https://api.github.com/users/Jakub89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jakub89/subscriptions","organizations_url":"https://api.github.com/users/Jakub89/orgs","repos_url":"https://api.github.com/users/Jakub89/repos","events_url":"https://api.github.com/users/Jakub89/events{/privacy}","received_events_url":"https://api.github.com/users/Jakub89/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"cameel","id":137030,"node_id":"MDQ6VXNlcjEzNzAzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/137030?v=4","gravatar_id":"","url":"https://api.github.com/users/cameel","html_url":"https://github.com/cameel","followers_url":"https://api.github.com/users/cameel/followers","following_url":"https://api.github.com/users/cameel/following{/other_user}","gists_url":"https://api.github.com/users/cameel/gists{/gist_id}","starred_url":"https://api.github.com/users/cameel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cameel/subscriptions","organizations_url":"https://api.github.com/users/cameel/orgs","repos_url":"https://api.github.com/users/cameel/repos","events_url":"https://api.github.com/users/cameel/events{/privacy}","received_events_url":"https://api.github.com/users/cameel/received_events","type":"User","site_admin":false},{"login":"kbeker","id":26469852,"node_id":"MDQ6VXNlcjI2NDY5ODUy","avatar_url":"https://avatars3.githubusercontent.com/u/26469852?v=4","gravatar_id":"","url":"https://api.github.com/users/kbeker","html_url":"https://github.com/kbeker","followers_url":"https://api.github.com/users/kbeker/followers","following_url":"https://api.github.com/users/kbeker/following{/other_user}","gists_url":"https://api.github.com/users/kbeker/gists{/gist_id}","starred_url":"https://api.github.com/users/kbeker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbeker/subscriptions","organizations_url":"https://api.github.com/users/kbeker/orgs","repos_url":"https://api.github.com/users/kbeker/repos","events_url":"https://api.github.com/users/kbeker/events{/privacy}","received_events_url":"https://api.github.com/users/kbeker/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/golemfactory/concent/pulls/699/commits","review_comments_url":"https://api.github.com/repos/golemfactory/concent/pulls/699/comments","review_comment_url":"https://api.github.com/repos/golemfactory/concent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/golemfactory/concent/issues/699/comments","statuses_url":"https://api.github.com/repos/golemfactory/concent/statuses/a5680e981d4c6612f7fe171ef1a3f6e1dd4a45df","head":{"label":"golemfactory:bugfix-pylint-warnings","ref":"bugfix-pylint-warnings","sha":"a5680e981d4c6612f7fe171ef1a3f6e1dd4a45df","user":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":108836885,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg4MzY4ODU=","name":"concent","full_name":"golemfactory/concent","owner":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/golemfactory/concent","description":"Repository for Concent Service sources","fork":false,"url":"https://api.github.com/repos/golemfactory/concent","forks_url":"https://api.github.com/repos/golemfactory/concent/forks","keys_url":"https://api.github.com/repos/golemfactory/concent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golemfactory/concent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golemfactory/concent/teams","hooks_url":"https://api.github.com/repos/golemfactory/concent/hooks","issue_events_url":"https://api.github.com/repos/golemfactory/concent/issues/events{/number}","events_url":"https://api.github.com/repos/golemfactory/concent/events","assignees_url":"https://api.github.com/repos/golemfactory/concent/assignees{/user}","branches_url":"https://api.github.com/repos/golemfactory/concent/branches{/branch}","tags_url":"https://api.github.com/repos/golemfactory/concent/tags","blobs_url":"https://api.github.com/repos/golemfactory/concent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golemfactory/concent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golemfactory/concent/git/refs{/sha}","trees_url":"https://api.github.com/repos/golemfactory/concent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golemfactory/concent/statuses/{sha}","languages_url":"https://api.github.com/repos/golemfactory/concent/languages","stargazers_url":"https://api.github.com/repos/golemfactory/concent/stargazers","contributors_url":"https://api.github.com/repos/golemfactory/concent/contributors","subscribers_url":"https://api.github.com/repos/golemfactory/concent/subscribers","subscription_url":"https://api.github.com/repos/golemfactory/concent/subscription","commits_url":"https://api.github.com/repos/golemfactory/concent/commits{/sha}","git_commits_url":"https://api.github.com/repos/golemfactory/concent/git/commits{/sha}","comments_url":"https://api.github.com/repos/golemfactory/concent/comments{/number}","issue_comment_url":"https://api.github.com/repos/golemfactory/concent/issues/comments{/number}","contents_url":"https://api.github.com/repos/golemfactory/concent/contents/{+path}","compare_url":"https://api.github.com/repos/golemfactory/concent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golemfactory/concent/merges","archive_url":"https://api.github.com/repos/golemfactory/concent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golemfactory/concent/downloads","issues_url":"https://api.github.com/repos/golemfactory/concent/issues{/number}","pulls_url":"https://api.github.com/repos/golemfactory/concent/pulls{/number}","milestones_url":"https://api.github.com/repos/golemfactory/concent/milestones{/number}","notifications_url":"https://api.github.com/repos/golemfactory/concent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golemfactory/concent/labels{/name}","releases_url":"https://api.github.com/repos/golemfactory/concent/releases{/id}","deployments_url":"https://api.github.com/repos/golemfactory/concent/deployments","created_at":"2017-10-30T10:41:44Z","updated_at":"2018-08-02T22:09:48Z","pushed_at":"2018-08-03T00:09:26Z","git_url":"git://github.com/golemfactory/concent.git","ssh_url":"git@github.com:golemfactory/concent.git","clone_url":"https://github.com/golemfactory/concent.git","svn_url":"https://github.com/golemfactory/concent","homepage":null,"size":2541,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":88,"license":null,"forks":2,"open_issues":88,"watchers":4,"default_branch":"master"}},"base":{"label":"golemfactory:master","ref":"master","sha":"c069376caa3b79716d63f5ceae83c9d3a35a611e","user":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":108836885,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg4MzY4ODU=","name":"concent","full_name":"golemfactory/concent","owner":{"login":"golemfactory","id":23193179,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTkzMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/golemfactory/concent","description":"Repository for Concent Service sources","fork":false,"url":"https://api.github.com/repos/golemfactory/concent","forks_url":"https://api.github.com/repos/golemfactory/concent/forks","keys_url":"https://api.github.com/repos/golemfactory/concent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golemfactory/concent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golemfactory/concent/teams","hooks_url":"https://api.github.com/repos/golemfactory/concent/hooks","issue_events_url":"https://api.github.com/repos/golemfactory/concent/issues/events{/number}","events_url":"https://api.github.com/repos/golemfactory/concent/events","assignees_url":"https://api.github.com/repos/golemfactory/concent/assignees{/user}","branches_url":"https://api.github.com/repos/golemfactory/concent/branches{/branch}","tags_url":"https://api.github.com/repos/golemfactory/concent/tags","blobs_url":"https://api.github.com/repos/golemfactory/concent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golemfactory/concent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golemfactory/concent/git/refs{/sha}","trees_url":"https://api.github.com/repos/golemfactory/concent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golemfactory/concent/statuses/{sha}","languages_url":"https://api.github.com/repos/golemfactory/concent/languages","stargazers_url":"https://api.github.com/repos/golemfactory/concent/stargazers","contributors_url":"https://api.github.com/repos/golemfactory/concent/contributors","subscribers_url":"https://api.github.com/repos/golemfactory/concent/subscribers","subscription_url":"https://api.github.com/repos/golemfactory/concent/subscription","commits_url":"https://api.github.com/repos/golemfactory/concent/commits{/sha}","git_commits_url":"https://api.github.com/repos/golemfactory/concent/git/commits{/sha}","comments_url":"https://api.github.com/repos/golemfactory/concent/comments{/number}","issue_comment_url":"https://api.github.com/repos/golemfactory/concent/issues/comments{/number}","contents_url":"https://api.github.com/repos/golemfactory/concent/contents/{+path}","compare_url":"https://api.github.com/repos/golemfactory/concent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golemfactory/concent/merges","archive_url":"https://api.github.com/repos/golemfactory/concent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golemfactory/concent/downloads","issues_url":"https://api.github.com/repos/golemfactory/concent/issues{/number}","pulls_url":"https://api.github.com/repos/golemfactory/concent/pulls{/number}","milestones_url":"https://api.github.com/repos/golemfactory/concent/milestones{/number}","notifications_url":"https://api.github.com/repos/golemfactory/concent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golemfactory/concent/labels{/name}","releases_url":"https://api.github.com/repos/golemfactory/concent/releases{/id}","deployments_url":"https://api.github.com/repos/golemfactory/concent/deployments","created_at":"2017-10-30T10:41:44Z","updated_at":"2018-08-02T22:09:48Z","pushed_at":"2018-08-03T00:09:26Z","git_url":"git://github.com/golemfactory/concent.git","ssh_url":"git@github.com:golemfactory/concent.git","clone_url":"https://github.com/golemfactory/concent.git","svn_url":"https://github.com/golemfactory/concent","homepage":null,"size":2541,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":88,"license":null,"forks":2,"open_issues":88,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/699"},"html":{"href":"https://github.com/golemfactory/concent/pull/699"},"issue":{"href":"https://api.github.com/repos/golemfactory/concent/issues/699"},"comments":{"href":"https://api.github.com/repos/golemfactory/concent/issues/699/comments"},"review_comments":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/699/comments"},"review_comment":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/golemfactory/concent/pulls/699/commits"},"statuses":{"href":"https://api.github.com/repos/golemfactory/concent/statuses/a5680e981d4c6612f7fe171ef1a3f6e1dd4a45df"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dybi"}}