{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments/241947139","pull_request_review_id":185352324,"id":241947139,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTk0NzEzOQ==","diff_hunk":"@@ -25,9 +26,12 @@\n     ('beta', lambda v: semver.bump_prerelease(v, 'beta')),\n ])\n \n-# The checks requirement file used by the agent\n-AGENT_REQ_FILE = 'requirements-agent-release.txt'\n-\n+# The requirements file listing integrations to be included in the Agent package\n+AGENT_RELEASE_REQ_FILE = 'requirements-agent-release.txt'\n+# The requirements file listing dependencies needed by the embedded Python environment\n+AGENT_REQUIREMENTS = os.path.join(","path":"datadog_checks_dev/datadog_checks/dev/tooling/constants.py","position":null,"original_position":18,"commit_id":"f9cb3062e7de338d4c71b1757e603e1de840325c","original_commit_id":"daf50a3af7fa87b10ae5471452b2276830f20cc9","user":{"login":"masci","id":7241,"node_id":"MDQ6VXNlcjcyNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7241?v=4","gravatar_id":"","url":"https://api.github.com/users/masci","html_url":"https://github.com/masci","followers_url":"https://api.github.com/users/masci/followers","following_url":"https://api.github.com/users/masci/following{/other_user}","gists_url":"https://api.github.com/users/masci/gists{/gist_id}","starred_url":"https://api.github.com/users/masci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masci/subscriptions","organizations_url":"https://api.github.com/users/masci/orgs","repos_url":"https://api.github.com/users/masci/repos","events_url":"https://api.github.com/users/masci/events{/privacy}","received_events_url":"https://api.github.com/users/masci/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2018-12-15T11:51:34Z","updated_at":"2018-12-15T11:51:34Z","html_url":"https://github.com/DataDog/integrations-core/pull/2746#discussion_r241947139","pull_request_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/2746","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments/241947139"},"html":{"href":"https://github.com/DataDog/integrations-core/pull/2746#discussion_r241947139"},"pull_request":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/2746"}},"in_reply_to_id":241508868},"pull_request":{"url":"https://api.github.com/repos/DataDog/integrations-core/pulls/2746","id":238463873,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NDYzODcz","html_url":"https://github.com/DataDog/integrations-core/pull/2746","diff_url":"https://github.com/DataDog/integrations-core/pull/2746.diff","patch_url":"https://github.com/DataDog/integrations-core/pull/2746.patch","issue_url":"https://api.github.com/repos/DataDog/integrations-core/issues/2746","number":2746,"state":"open","locked":false,"title":"Validate checks dependencies against the embedded environment","user":{"login":"masci","id":7241,"node_id":"MDQ6VXNlcjcyNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7241?v=4","gravatar_id":"","url":"https://api.github.com/users/masci","html_url":"https://github.com/masci","followers_url":"https://api.github.com/users/masci/followers","following_url":"https://api.github.com/users/masci/following{/other_user}","gists_url":"https://api.github.com/users/masci/gists{/gist_id}","starred_url":"https://api.github.com/users/masci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masci/subscriptions","organizations_url":"https://api.github.com/users/masci/orgs","repos_url":"https://api.github.com/users/masci/repos","events_url":"https://api.github.com/users/masci/events{/privacy}","received_events_url":"https://api.github.com/users/masci/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nAdds an extra step to `ddev validate dep`: now the tool will ensure a certain dependency in a local `requirements.txt` file for an integration has a match in the requirements file that defines the Python env embedded in the Agent.\r\n\r\n### Motivation\r\n\r\nConsistency\r\n\r\n### Review checklist\r\n\r\n- [ ] PR has a [meaningful title](https://github.com/DataDog/integrations-core/blob/master/CONTRIBUTING.md#pull-request-title) or PR has the `no-changelog` label attached\r\n- [ ] Feature or bugfix has tests\r\n- [ ] Git history is clean\r\n- [ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the [documentation repo](https://github.com/DataDog/documentation/issues/new)\r\n- [ ] If PR adds a configuration option, it has been added to the configuration file.\r\n\r\n### Additional Notes\r\n\r\nAlso added a bit of refactoring:\r\n\r\n* `Package` is now a full fledged class with utility methods\r\n* added a `PackageCatalog` class to wrap a bunch of complex nested dicts \r\n","created_at":"2018-12-13T17:02:33Z","updated_at":"2018-12-15T11:51:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1218979a82d9676d37adbf2c762da100aa83dcb4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":937215339,"node_id":"MDU6TGFiZWw5MzcyMTUzMzk=","url":"https://api.github.com/repos/DataDog/integrations-core/labels/changelog/Added","name":"changelog/Added","color":"f2983e","default":false},{"id":992015121,"node_id":"MDU6TGFiZWw5OTIwMTUxMjE=","url":"https://api.github.com/repos/DataDog/integrations-core/labels/integration/datadog_checks_dev","name":"integration/datadog_checks_dev","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/2746/commits","review_comments_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/2746/comments","review_comment_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/issues/2746/comments","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/f9cb3062e7de338d4c71b1757e603e1de840325c","head":{"label":"DataDog:massi/check-req","ref":"massi/check-req","sha":"f9cb3062e7de338d4c71b1757e603e1de840325c","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":47203045,"node_id":"MDEwOlJlcG9zaXRvcnk0NzIwMzA0NQ==","name":"integrations-core","full_name":"DataDog/integrations-core","private":false,"owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataDog/integrations-core","description":"Core integrations of the Datadog Agent","fork":false,"url":"https://api.github.com/repos/DataDog/integrations-core","forks_url":"https://api.github.com/repos/DataDog/integrations-core/forks","keys_url":"https://api.github.com/repos/DataDog/integrations-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/integrations-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/integrations-core/teams","hooks_url":"https://api.github.com/repos/DataDog/integrations-core/hooks","issue_events_url":"https://api.github.com/repos/DataDog/integrations-core/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/integrations-core/events","assignees_url":"https://api.github.com/repos/DataDog/integrations-core/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/integrations-core/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/integrations-core/tags","blobs_url":"https://api.github.com/repos/DataDog/integrations-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/integrations-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/integrations-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/integrations-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/integrations-core/languages","stargazers_url":"https://api.github.com/repos/DataDog/integrations-core/stargazers","contributors_url":"https://api.github.com/repos/DataDog/integrations-core/contributors","subscribers_url":"https://api.github.com/repos/DataDog/integrations-core/subscribers","subscription_url":"https://api.github.com/repos/DataDog/integrations-core/subscription","commits_url":"https://api.github.com/repos/DataDog/integrations-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/integrations-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/integrations-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/integrations-core/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/integrations-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/integrations-core/merges","archive_url":"https://api.github.com/repos/DataDog/integrations-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/integrations-core/downloads","issues_url":"https://api.github.com/repos/DataDog/integrations-core/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/integrations-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/integrations-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/integrations-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/integrations-core/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/integrations-core/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/integrations-core/deployments","created_at":"2015-12-01T16:41:45Z","updated_at":"2018-12-14T21:46:49Z","pushed_at":"2018-12-15T11:51:00Z","git_url":"git://github.com/DataDog/integrations-core.git","ssh_url":"git@github.com:DataDog/integrations-core.git","clone_url":"https://github.com/DataDog/integrations-core.git","svn_url":"https://github.com/DataDog/integrations-core","homepage":"","size":31791,"stargazers_count":187,"watchers_count":187,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":361,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":361,"open_issues":64,"watchers":187,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"c733230681eda3159b0b61b7f77d52392f20cbeb","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":47203045,"node_id":"MDEwOlJlcG9zaXRvcnk0NzIwMzA0NQ==","name":"integrations-core","full_name":"DataDog/integrations-core","private":false,"owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DataDog/integrations-core","description":"Core integrations of the Datadog Agent","fork":false,"url":"https://api.github.com/repos/DataDog/integrations-core","forks_url":"https://api.github.com/repos/DataDog/integrations-core/forks","keys_url":"https://api.github.com/repos/DataDog/integrations-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/integrations-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/integrations-core/teams","hooks_url":"https://api.github.com/repos/DataDog/integrations-core/hooks","issue_events_url":"https://api.github.com/repos/DataDog/integrations-core/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/integrations-core/events","assignees_url":"https://api.github.com/repos/DataDog/integrations-core/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/integrations-core/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/integrations-core/tags","blobs_url":"https://api.github.com/repos/DataDog/integrations-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/integrations-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/integrations-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/integrations-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/integrations-core/languages","stargazers_url":"https://api.github.com/repos/DataDog/integrations-core/stargazers","contributors_url":"https://api.github.com/repos/DataDog/integrations-core/contributors","subscribers_url":"https://api.github.com/repos/DataDog/integrations-core/subscribers","subscription_url":"https://api.github.com/repos/DataDog/integrations-core/subscription","commits_url":"https://api.github.com/repos/DataDog/integrations-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/integrations-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/integrations-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/integrations-core/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/integrations-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/integrations-core/merges","archive_url":"https://api.github.com/repos/DataDog/integrations-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/integrations-core/downloads","issues_url":"https://api.github.com/repos/DataDog/integrations-core/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/integrations-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/integrations-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/integrations-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/integrations-core/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/integrations-core/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/integrations-core/deployments","created_at":"2015-12-01T16:41:45Z","updated_at":"2018-12-14T21:46:49Z","pushed_at":"2018-12-15T11:51:00Z","git_url":"git://github.com/DataDog/integrations-core.git","ssh_url":"git@github.com:DataDog/integrations-core.git","clone_url":"https://github.com/DataDog/integrations-core.git","svn_url":"https://github.com/DataDog/integrations-core","homepage":"","size":31791,"stargazers_count":187,"watchers_count":187,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":361,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":361,"open_issues":64,"watchers":187,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/2746"},"html":{"href":"https://github.com/DataDog/integrations-core/pull/2746"},"issue":{"href":"https://api.github.com/repos/DataDog/integrations-core/issues/2746"},"comments":{"href":"https://api.github.com/repos/DataDog/integrations-core/issues/2746/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/2746/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/2746/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/integrations-core/statuses/f9cb3062e7de338d4c71b1757e603e1de840325c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"masci"}}