{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/226574248","pull_request_review_id":166429738,"id":226574248,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjU3NDI0OA==","diff_hunk":"@@ -0,0 +1,102 @@\n+#include \"extensions/filters/network/dubbo_proxy/hessian_serializer_impl.h\"\n+\n+#include \"envoy/common/exception.h\"\n+\n+#include \"common/common/assert.h\"\n+#include \"common/common/macros.h\"\n+\n+#include \"extensions/filters/network/dubbo_proxy/hessian_utils.h\"\n+#include \"extensions/filters/network/dubbo_proxy/serialization.h\"\n+#include \"extensions/filters/network/dubbo_proxy/serialization_impl.h\"\n+\n+namespace Envoy {\n+namespace Extensions {\n+namespace NetworkFilters {\n+namespace DubboProxy {\n+\n+enum class RpcResponseType : unsigned char {\n+  ResponseWithException = 0,\n+  ResponseWithValue = 1,\n+  ResponseWithNullValue = 2,\n+  ResponseWithExceptionWithAttachments = 3,\n+  ResponseValueWithAttachments = 4,\n+  ResponseNullValueWithAttachments = 5,\n+\n+  // ATTENTION: MAKE SURE THIS REMAINS EQUAL TO THE LAST RpcResponseType TYPE\n+  LastResponseType = ResponseNullValueWithAttachments,","path":"source/extensions/filters/network/dubbo_proxy/hessian_serializer_impl.cc","position":26,"original_position":26,"commit_id":"2bef6e6455661693666d4fd893cdea7e0f52f076","original_commit_id":"2bef6e6455661693666d4fd893cdea7e0f52f076","user":{"login":"lizan","id":1016047,"node_id":"MDQ6VXNlcjEwMTYwNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1016047?v=4","gravatar_id":"","url":"https://api.github.com/users/lizan","html_url":"https://github.com/lizan","followers_url":"https://api.github.com/users/lizan/followers","following_url":"https://api.github.com/users/lizan/following{/other_user}","gists_url":"https://api.github.com/users/lizan/gists{/gist_id}","starred_url":"https://api.github.com/users/lizan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizan/subscriptions","organizations_url":"https://api.github.com/users/lizan/orgs","repos_url":"https://api.github.com/users/lizan/repos","events_url":"https://api.github.com/users/lizan/events{/privacy}","received_events_url":"https://api.github.com/users/lizan/received_events","type":"User","site_admin":false},"body":"where is this used?","created_at":"2018-10-19T08:46:28Z","updated_at":"2018-10-19T08:59:30Z","html_url":"https://github.com/envoyproxy/envoy/pull/4785#discussion_r226574248","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4785","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/226574248"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4785#discussion_r226574248"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4785"}}},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4785","id":224210908,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MjEwOTA4","html_url":"https://github.com/envoyproxy/envoy/pull/4785","diff_url":"https://github.com/envoyproxy/envoy/pull/4785.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/4785.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4785","number":4785,"state":"open","locked":false,"title":"dubbo_proxy: Add hessian rpc deserialize","user":{"login":"zyfjeff","id":8816403,"node_id":"MDQ6VXNlcjg4MTY0MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/8816403?v=4","gravatar_id":"","url":"https://api.github.com/users/zyfjeff","html_url":"https://github.com/zyfjeff","followers_url":"https://api.github.com/users/zyfjeff/followers","following_url":"https://api.github.com/users/zyfjeff/following{/other_user}","gists_url":"https://api.github.com/users/zyfjeff/gists{/gist_id}","starred_url":"https://api.github.com/users/zyfjeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyfjeff/subscriptions","organizations_url":"https://api.github.com/users/zyfjeff/orgs","repos_url":"https://api.github.com/users/zyfjeff/repos","events_url":"https://api.github.com/users/zyfjeff/events{/privacy}","received_events_url":"https://api.github.com/users/zyfjeff/received_events","type":"User","site_admin":false},"body":"Signed-off-by: tianqian.zyf <tianqian.zyf@alibaba-inc.com>\r\n\r\n*Description*: Add hessian rpc deserialize\r\n*Risk Level*: low\r\n*Testing*: unittests\r\n*Docs Changes*: N/A\r\n*Release Notes*: N/A \r\n[Optional Fixes #Issue]  #3998  #4200 \r\n","created_at":"2018-10-19T08:40:44Z","updated_at":"2018-10-19T08:59:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9d52fa6035a38e293a871ee36246f6c0d1a9713","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4785/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4785/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4785/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/2bef6e6455661693666d4fd893cdea7e0f52f076","head":{"label":"zyfjeff:hessian_deserialization","ref":"hessian_deserialization","sha":"2bef6e6455661693666d4fd893cdea7e0f52f076","user":{"login":"zyfjeff","id":8816403,"node_id":"MDQ6VXNlcjg4MTY0MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/8816403?v=4","gravatar_id":"","url":"https://api.github.com/users/zyfjeff","html_url":"https://github.com/zyfjeff","followers_url":"https://api.github.com/users/zyfjeff/followers","following_url":"https://api.github.com/users/zyfjeff/following{/other_user}","gists_url":"https://api.github.com/users/zyfjeff/gists{/gist_id}","starred_url":"https://api.github.com/users/zyfjeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyfjeff/subscriptions","organizations_url":"https://api.github.com/users/zyfjeff/orgs","repos_url":"https://api.github.com/users/zyfjeff/repos","events_url":"https://api.github.com/users/zyfjeff/events{/privacy}","received_events_url":"https://api.github.com/users/zyfjeff/received_events","type":"User","site_admin":false},"repo":{"id":115982663,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU5ODI2NjM=","name":"envoy","full_name":"zyfjeff/envoy","private":false,"owner":{"login":"zyfjeff","id":8816403,"node_id":"MDQ6VXNlcjg4MTY0MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/8816403?v=4","gravatar_id":"","url":"https://api.github.com/users/zyfjeff","html_url":"https://github.com/zyfjeff","followers_url":"https://api.github.com/users/zyfjeff/followers","following_url":"https://api.github.com/users/zyfjeff/following{/other_user}","gists_url":"https://api.github.com/users/zyfjeff/gists{/gist_id}","starred_url":"https://api.github.com/users/zyfjeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyfjeff/subscriptions","organizations_url":"https://api.github.com/users/zyfjeff/orgs","repos_url":"https://api.github.com/users/zyfjeff/repos","events_url":"https://api.github.com/users/zyfjeff/events{/privacy}","received_events_url":"https://api.github.com/users/zyfjeff/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zyfjeff/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/zyfjeff/envoy","forks_url":"https://api.github.com/repos/zyfjeff/envoy/forks","keys_url":"https://api.github.com/repos/zyfjeff/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zyfjeff/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zyfjeff/envoy/teams","hooks_url":"https://api.github.com/repos/zyfjeff/envoy/hooks","issue_events_url":"https://api.github.com/repos/zyfjeff/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/zyfjeff/envoy/events","assignees_url":"https://api.github.com/repos/zyfjeff/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/zyfjeff/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/zyfjeff/envoy/tags","blobs_url":"https://api.github.com/repos/zyfjeff/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zyfjeff/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zyfjeff/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/zyfjeff/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zyfjeff/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/zyfjeff/envoy/languages","stargazers_url":"https://api.github.com/repos/zyfjeff/envoy/stargazers","contributors_url":"https://api.github.com/repos/zyfjeff/envoy/contributors","subscribers_url":"https://api.github.com/repos/zyfjeff/envoy/subscribers","subscription_url":"https://api.github.com/repos/zyfjeff/envoy/subscription","commits_url":"https://api.github.com/repos/zyfjeff/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/zyfjeff/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/zyfjeff/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/zyfjeff/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/zyfjeff/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/zyfjeff/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zyfjeff/envoy/merges","archive_url":"https://api.github.com/repos/zyfjeff/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zyfjeff/envoy/downloads","issues_url":"https://api.github.com/repos/zyfjeff/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/zyfjeff/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/zyfjeff/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/zyfjeff/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zyfjeff/envoy/labels{/name}","releases_url":"https://api.github.com/repos/zyfjeff/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/zyfjeff/envoy/deployments","created_at":"2018-01-02T06:30:37Z","updated_at":"2018-08-20T16:51:52Z","pushed_at":"2018-10-19T08:38:32Z","git_url":"git://github.com/zyfjeff/envoy.git","ssh_url":"git@github.com:zyfjeff/envoy.git","clone_url":"https://github.com/zyfjeff/envoy.git","svn_url":"https://github.com/zyfjeff/envoy","homepage":"https://envoyproxy.github.io/","size":63709,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"0ccc70ae77909baadcb07dd0c9ca2ef583dde3b5","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","private":false,"owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-10-19T08:21:08Z","pushed_at":"2018-10-19T08:48:13Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":22147,"stargazers_count":6849,"watchers_count":6849,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":940,"mirror_url":null,"archived":false,"open_issues_count":381,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":940,"open_issues":381,"watchers":6849,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4785"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4785"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4785"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4785/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4785/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4785/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/2bef6e6455661693666d4fd893cdea7e0f52f076"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lizan"}}