{"action":"created","comment":{"url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/pulls/comments/231465657","pull_request_review_id":172440403,"id":231465657,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTQ2NTY1Nw==","diff_hunk":"@@ -8,20 +8,13 @@ already cloned the ev3dev-lang-python repo you can use the `--recursive` option\n when you git clone.  Example:\n \n ```\n-$ git clone --recursive https://github.com/rhempel/ev3dev-lang-python.git\n+$ git clone --recursive https://github.com/ev3dev/ev3dev-lang-python.git\n ```\n \n # Running Tests\n To run the tests do:\n ```\n-$ ./api_tests.py\n-```\n-\n-# Misc\n-Commands used to copy the /sys/class node:","path":"tests/README.md","position":15,"original_position":15,"commit_id":"5da26b77a7bae405fdea5b7a4b56072c6da61e62","original_commit_id":"a702382b8918c57a8df4f0b5af097f222b419154","user":{"login":"dwalton76","id":468309,"node_id":"MDQ6VXNlcjQ2ODMwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/468309?v=4","gravatar_id":"","url":"https://api.github.com/users/dwalton76","html_url":"https://github.com/dwalton76","followers_url":"https://api.github.com/users/dwalton76/followers","following_url":"https://api.github.com/users/dwalton76/following{/other_user}","gists_url":"https://api.github.com/users/dwalton76/gists{/gist_id}","starred_url":"https://api.github.com/users/dwalton76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwalton76/subscriptions","organizations_url":"https://api.github.com/users/dwalton76/orgs","repos_url":"https://api.github.com/users/dwalton76/repos","events_url":"https://api.github.com/users/dwalton76/events{/privacy}","received_events_url":"https://api.github.com/users/dwalton76/received_events","type":"User","site_admin":false},"body":"yep it is already in the fake-sys README","created_at":"2018-11-07T11:12:21Z","updated_at":"2018-11-07T11:12:22Z","html_url":"https://github.com/ev3dev/ev3dev-lang-python/pull/556#discussion_r231465657","pull_request_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/pulls/556","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/pulls/comments/231465657"},"html":{"href":"https://github.com/ev3dev/ev3dev-lang-python/pull/556#discussion_r231465657"},"pull_request":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/pulls/556"}},"in_reply_to_id":230610116},"pull_request":{"url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/pulls/556","id":227924275,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTI0Mjc1","html_url":"https://github.com/ev3dev/ev3dev-lang-python/pull/556","diff_url":"https://github.com/ev3dev/ev3dev-lang-python/pull/556.diff","patch_url":"https://github.com/ev3dev/ev3dev-lang-python/pull/556.patch","issue_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/issues/556","number":556,"state":"open","locked":false,"title":"suppress unittest ResourceWarning messages","user":{"login":"dwalton76","id":468309,"node_id":"MDQ6VXNlcjQ2ODMwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/468309?v=4","gravatar_id":"","url":"https://api.github.com/users/dwalton76","html_url":"https://github.com/dwalton76","followers_url":"https://api.github.com/users/dwalton76/followers","following_url":"https://api.github.com/users/dwalton76/following{/other_user}","gists_url":"https://api.github.com/users/dwalton76/gists{/gist_id}","starred_url":"https://api.github.com/users/dwalton76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwalton76/subscriptions","organizations_url":"https://api.github.com/users/dwalton76/orgs","repos_url":"https://api.github.com/users/dwalton76/repos","events_url":"https://api.github.com/users/dwalton76/events{/privacy}","received_events_url":"https://api.github.com/users/dwalton76/received_events","type":"User","site_admin":false},"body":"For issue #433 \r\n\r\nThis does not fix the issue of the filehandles being left open it just suppresses the warnings generated by unittest.  We've had 433 open for almost a year and haven't come up with a good solution and leaving the filehandles open isn't really causing any issues (none that I know of at least).  From googling these unittest ResourceWarning messages we would not be the first repo to just ignore these via a warnings filter.\r\n\r\nThe ``setUp()`` method just makes it so you can tell what output is coming from what test (this is optional)\r\n\r\nnew output\r\n```\r\nImport warning: Failed to import \"evdev\". Button will be unusable!\r\n\r\n\r\ntest_device\r\n===========\r\n\t0\toutA\t./tests/fake-sys/arena/tacho-motor/motor0\r\n\t0\tin1\t./tests/fake-sys/arena/lego-sensor/sensor0\r\n.\r\n\r\ntest_infrared_sensor\r\n====================\r\n\t0\tin1\t./tests/fake-sys/arena/lego-sensor/sensor0\r\n.\r\n\r\ntest_joystick_units\r\n===================\r\n\t0\toutA\t./tests/fake-sys/arena/tacho-motor/motor0\r\n\t1\toutB\t./tests/fake-sys/arena/tacho-motor/motor1\r\n.\r\n\r\ntest_medium_motor\r\n=================\r\n\t0\toutA\t./tests/fake-sys/arena/tacho-motor/motor0\r\n.\r\n\r\ntest_medium_motor_write\r\n=======================\r\n\t0\toutA\t./tests/fake-sys/arena/tacho-motor/motor0\r\n.\r\n\r\ntest_motor_on_for_degrees\r\n=========================\r\n\t0\toutA\t./tests/fake-sys/arena/tacho-motor/motor0\r\n.\r\n\r\ntest_motor_on_for_rotations\r\n===========================\r\n\t0\toutA\t./tests/fake-sys/arena/tacho-motor/motor0\r\n.\r\n\r\ntest_move_tank_relative_distance\r\n================================\r\n\t0\toutA\t./tests/fake-sys/arena/tacho-motor/motor0\r\n\t1\toutB\t./tests/fake-sys/arena/tacho-motor/motor1\r\n.\r\n\r\ntest_steering_large_value\r\n=========================\r\n\t0\toutA\t./tests/fake-sys/arena/tacho-motor/motor0\r\n\t1\toutB\t./tests/fake-sys/arena/tacho-motor/motor1\r\n.\r\n\r\ntest_steering_units\r\n===================\r\n\t0\toutA\t./tests/fake-sys/arena/tacho-motor/motor0\r\n\t1\toutB\t./tests/fake-sys/arena/tacho-motor/motor1\r\n.\r\n\r\ntest_tank_units\r\n===============\r\n\t0\toutA\t./tests/fake-sys/arena/tacho-motor/motor0\r\n\t1\toutB\t./tests/fake-sys/arena/tacho-motor/motor1\r\n.\r\n\r\ntest_units\r\n==========\r\n\t0\toutA\t./tests/fake-sys/arena/tacho-motor/motor0\r\n\t1\toutB\t./tests/fake-sys/arena/tacho-motor/motor1\r\n.\r\n----------------------------------------------------------------------\r\nRan 12 tests in 0.082s\r\n\r\nOK\r\n```","created_at":"2018-11-02T12:38:43Z","updated_at":"2018-11-07T11:12:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fa1877e5a01fa31f77d4f61c3045857111fa5ca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/pulls/556/commits","review_comments_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/pulls/556/comments","review_comment_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/issues/556/comments","statuses_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/statuses/5da26b77a7bae405fdea5b7a4b56072c6da61e62","head":{"label":"dwalton76:ResourceWarning","ref":"ResourceWarning","sha":"5da26b77a7bae405fdea5b7a4b56072c6da61e62","user":{"login":"dwalton76","id":468309,"node_id":"MDQ6VXNlcjQ2ODMwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/468309?v=4","gravatar_id":"","url":"https://api.github.com/users/dwalton76","html_url":"https://github.com/dwalton76","followers_url":"https://api.github.com/users/dwalton76/followers","following_url":"https://api.github.com/users/dwalton76/following{/other_user}","gists_url":"https://api.github.com/users/dwalton76/gists{/gist_id}","starred_url":"https://api.github.com/users/dwalton76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwalton76/subscriptions","organizations_url":"https://api.github.com/users/dwalton76/orgs","repos_url":"https://api.github.com/users/dwalton76/repos","events_url":"https://api.github.com/users/dwalton76/events{/privacy}","received_events_url":"https://api.github.com/users/dwalton76/received_events","type":"User","site_admin":false},"repo":{"id":154533399,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1MzMzOTk=","name":"ev3dev-lang-python","full_name":"dwalton76/ev3dev-lang-python","private":false,"owner":{"login":"dwalton76","id":468309,"node_id":"MDQ6VXNlcjQ2ODMwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/468309?v=4","gravatar_id":"","url":"https://api.github.com/users/dwalton76","html_url":"https://github.com/dwalton76","followers_url":"https://api.github.com/users/dwalton76/followers","following_url":"https://api.github.com/users/dwalton76/following{/other_user}","gists_url":"https://api.github.com/users/dwalton76/gists{/gist_id}","starred_url":"https://api.github.com/users/dwalton76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwalton76/subscriptions","organizations_url":"https://api.github.com/users/dwalton76/orgs","repos_url":"https://api.github.com/users/dwalton76/repos","events_url":"https://api.github.com/users/dwalton76/events{/privacy}","received_events_url":"https://api.github.com/users/dwalton76/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dwalton76/ev3dev-lang-python","description":"Pure python bindings for ev3dev","fork":true,"url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python","forks_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/forks","keys_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/teams","hooks_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/hooks","issue_events_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/issues/events{/number}","events_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/events","assignees_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/assignees{/user}","branches_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/branches{/branch}","tags_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/tags","blobs_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/statuses/{sha}","languages_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/languages","stargazers_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/stargazers","contributors_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/contributors","subscribers_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/subscribers","subscription_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/subscription","commits_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/contents/{+path}","compare_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/merges","archive_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/downloads","issues_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/issues{/number}","pulls_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/pulls{/number}","milestones_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/milestones{/number}","notifications_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/labels{/name}","releases_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/releases{/id}","deployments_url":"https://api.github.com/repos/dwalton76/ev3dev-lang-python/deployments","created_at":"2018-10-24T16:28:32Z","updated_at":"2018-10-28T02:51:31Z","pushed_at":"2018-11-07T11:11:10Z","git_url":"git://github.com/dwalton76/ev3dev-lang-python.git","ssh_url":"git@github.com:dwalton76/ev3dev-lang-python.git","clone_url":"https://github.com/dwalton76/ev3dev-lang-python.git","svn_url":"https://github.com/dwalton76/ev3dev-lang-python","homepage":null,"size":9772,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"ev3dev-stretch"}},"base":{"label":"ev3dev:ev3dev-stretch","ref":"ev3dev-stretch","sha":"245d8ae74f3c24ddcf852fb068a363b294c3d2e4","user":{"login":"ev3dev","id":6878323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NzgzMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6878323?v=4","gravatar_id":"","url":"https://api.github.com/users/ev3dev","html_url":"https://github.com/ev3dev","followers_url":"https://api.github.com/users/ev3dev/followers","following_url":"https://api.github.com/users/ev3dev/following{/other_user}","gists_url":"https://api.github.com/users/ev3dev/gists{/gist_id}","starred_url":"https://api.github.com/users/ev3dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev3dev/subscriptions","organizations_url":"https://api.github.com/users/ev3dev/orgs","repos_url":"https://api.github.com/users/ev3dev/repos","events_url":"https://api.github.com/users/ev3dev/events{/privacy}","received_events_url":"https://api.github.com/users/ev3dev/received_events","type":"Organization","site_admin":false},"repo":{"id":43603757,"node_id":"MDEwOlJlcG9zaXRvcnk0MzYwMzc1Nw==","name":"ev3dev-lang-python","full_name":"ev3dev/ev3dev-lang-python","private":false,"owner":{"login":"ev3dev","id":6878323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NzgzMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6878323?v=4","gravatar_id":"","url":"https://api.github.com/users/ev3dev","html_url":"https://github.com/ev3dev","followers_url":"https://api.github.com/users/ev3dev/followers","following_url":"https://api.github.com/users/ev3dev/following{/other_user}","gists_url":"https://api.github.com/users/ev3dev/gists{/gist_id}","starred_url":"https://api.github.com/users/ev3dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev3dev/subscriptions","organizations_url":"https://api.github.com/users/ev3dev/orgs","repos_url":"https://api.github.com/users/ev3dev/repos","events_url":"https://api.github.com/users/ev3dev/events{/privacy}","received_events_url":"https://api.github.com/users/ev3dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ev3dev/ev3dev-lang-python","description":"Pure python bindings for ev3dev","fork":false,"url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python","forks_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/forks","keys_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/teams","hooks_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/hooks","issue_events_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/issues/events{/number}","events_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/events","assignees_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/assignees{/user}","branches_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/branches{/branch}","tags_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/tags","blobs_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/statuses/{sha}","languages_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/languages","stargazers_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/stargazers","contributors_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/contributors","subscribers_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/subscribers","subscription_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/subscription","commits_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/contents/{+path}","compare_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/merges","archive_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/downloads","issues_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/issues{/number}","pulls_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/pulls{/number}","milestones_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/milestones{/number}","notifications_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/labels{/name}","releases_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/releases{/id}","deployments_url":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/deployments","created_at":"2015-10-03T15:32:20Z","updated_at":"2018-11-07T11:07:00Z","pushed_at":"2018-11-07T11:11:12Z","git_url":"git://github.com/ev3dev/ev3dev-lang-python.git","ssh_url":"git@github.com:ev3dev/ev3dev-lang-python.git","clone_url":"https://github.com/ev3dev/ev3dev-lang-python.git","svn_url":"https://github.com/ev3dev/ev3dev-lang-python","homepage":null,"size":9733,"stargazers_count":207,"watchers_count":207,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":77,"open_issues":52,"watchers":207,"default_branch":"ev3dev-stretch"}},"_links":{"self":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/pulls/556"},"html":{"href":"https://github.com/ev3dev/ev3dev-lang-python/pull/556"},"issue":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/issues/556"},"comments":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/issues/556/comments"},"review_comments":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/pulls/556/comments"},"review_comment":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/pulls/556/commits"},"statuses":{"href":"https://api.github.com/repos/ev3dev/ev3dev-lang-python/statuses/5da26b77a7bae405fdea5b7a4b56072c6da61e62"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dwalton76"}}