{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/docs/issues/4752","repository_url":"https://api.github.com/repos/dotnet/docs","labels_url":"https://api.github.com/repos/dotnet/docs/issues/4752/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/docs/issues/4752/comments","events_url":"https://api.github.com/repos/dotnet/docs/issues/4752/events","html_url":"https://github.com/dotnet/docs/pull/4752","id":307931981,"number":4752,"title":"Remove private setters to make class immutable","user":{"login":"Alexbits","id":3949302,"avatar_url":"https://avatars2.githubusercontent.com/u/3949302?v=4","gravatar_id":"","url":"https://api.github.com/users/Alexbits","html_url":"https://github.com/Alexbits","followers_url":"https://api.github.com/users/Alexbits/followers","following_url":"https://api.github.com/users/Alexbits/following{/other_user}","gists_url":"https://api.github.com/users/Alexbits/gists{/gist_id}","starred_url":"https://api.github.com/users/Alexbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alexbits/subscriptions","organizations_url":"https://api.github.com/users/Alexbits/orgs","repos_url":"https://api.github.com/users/Alexbits/repos","events_url":"https://api.github.com/users/Alexbits/events{/privacy}","received_events_url":"https://api.github.com/users/Alexbits/received_events","type":"User","site_admin":false},"labels":[{"id":697062683,"url":"https://api.github.com/repos/dotnet/docs/labels/:sparkles:%201st-time%20docs%20contributor!","name":":sparkles: 1st-time docs contributor!","color":"fef2c0","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/dotnet/docs/milestones/37","html_url":"https://github.com/dotnet/docs/milestone/37","labels_url":"https://api.github.com/repos/dotnet/docs/milestones/37/labels","id":3163528,"number":37,"title":"Sprint 133 (3/17/18 - 4/06/18) ","description":"Key goals:\r\n\r\n1. Progress on .NET Core 2.1 content \r\n2. First cards for VB 15.7 and C# 7.3 \r\n3. Continued improvements on get started content\r\n","creator":{"login":"BillWagner","id":493969,"avatar_url":"https://avatars2.githubusercontent.com/u/493969?v=4","gravatar_id":"","url":"https://api.github.com/users/BillWagner","html_url":"https://github.com/BillWagner","followers_url":"https://api.github.com/users/BillWagner/followers","following_url":"https://api.github.com/users/BillWagner/following{/other_user}","gists_url":"https://api.github.com/users/BillWagner/gists{/gist_id}","starred_url":"https://api.github.com/users/BillWagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillWagner/subscriptions","organizations_url":"https://api.github.com/users/BillWagner/orgs","repos_url":"https://api.github.com/users/BillWagner/repos","events_url":"https://api.github.com/users/BillWagner/events{/privacy}","received_events_url":"https://api.github.com/users/BillWagner/received_events","type":"User","site_admin":false},"open_issues":33,"closed_issues":25,"state":"open","created_at":"2018-03-05T21:46:46Z","updated_at":"2018-03-23T13:51:12Z","due_on":"2018-04-06T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-03-23T07:53:03Z","updated_at":"2018-03-23T13:52:29Z","closed_at":"2018-03-23T13:50:45Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dotnet/docs/pulls/4752","html_url":"https://github.com/dotnet/docs/pull/4752","diff_url":"https://github.com/dotnet/docs/pull/4752.diff","patch_url":"https://github.com/dotnet/docs/pull/4752.patch"},"body":"Remove private setters to make Enumeration immutable. Otherwise, it's possible to change the property values. \r\n\r\n ```csharp\r\n public override string ToString()\r\n        {\r\n            Name = \"Whatever\";\r\n            return Name;\r\n        }\r\n```\r\n\r\n## Summary\r\n\r\nRemove private setters for public properties\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/docs/issues/comments/375671476","html_url":"https://github.com/dotnet/docs/pull/4752#issuecomment-375671476","issue_url":"https://api.github.com/repos/dotnet/docs/issues/4752","id":375671476,"user":{"login":"BillWagner","id":493969,"avatar_url":"https://avatars2.githubusercontent.com/u/493969?v=4","gravatar_id":"","url":"https://api.github.com/users/BillWagner","html_url":"https://github.com/BillWagner","followers_url":"https://api.github.com/users/BillWagner/followers","following_url":"https://api.github.com/users/BillWagner/following{/other_user}","gists_url":"https://api.github.com/users/BillWagner/gists{/gist_id}","starred_url":"https://api.github.com/users/BillWagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillWagner/subscriptions","organizations_url":"https://api.github.com/users/BillWagner/orgs","repos_url":"https://api.github.com/users/BillWagner/repos","events_url":"https://api.github.com/users/BillWagner/events{/privacy}","received_events_url":"https://api.github.com/users/BillWagner/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T13:52:29Z","updated_at":"2018-03-23T13:52:29Z","author_association":"MEMBER","body":"@CESARDELATORRE FYI on this PR. He had suggested using a newer C# feature to more clearly describe the immutability of the enumeration type. This should get propagated back to the reference implementation(s) for eShopOnContainers."}}
{"actor":{"display_login":"BillWagner"}}