{"action":"created","comment":{"url":"https://api.github.com/repos/exercism/problem-specifications/pulls/comments/230603084","pull_request_review_id":171377049,"id":230603084,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDYwMzA4NA==","diff_hunk":"@@ -41,6 +41,14 @@ left-to-right, _ignoring the typical order of operations._\n \n 15  (i.e. not 9)\n \n+## Iteration 4 — Errors\n+\n+The parser should reject:\n+\n+* Unsupported operations (\"What is 52 cubed?\")\n+* Non-math questions (\"Who is the President of the United States\")","path":"exercises/wordy/description.md","position":9,"original_position":9,"commit_id":"4d458d8351bcfc80a2bdaa2b5962414333fba0b6","original_commit_id":"4d458d8351bcfc80a2bdaa2b5962414333fba0b6","user":{"login":"petertseng","id":346181,"node_id":"MDQ6VXNlcjM0NjE4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/346181?v=4","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"body":"Even if this PR is rejected, I'd suggest adding these lines in any case!","created_at":"2018-11-04T20:09:03Z","updated_at":"2018-11-04T20:10:46Z","html_url":"https://github.com/exercism/problem-specifications/pull/1383#discussion_r230603084","pull_request_url":"https://api.github.com/repos/exercism/problem-specifications/pulls/1383","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/exercism/problem-specifications/pulls/comments/230603084"},"html":{"href":"https://github.com/exercism/problem-specifications/pull/1383#discussion_r230603084"},"pull_request":{"href":"https://api.github.com/repos/exercism/problem-specifications/pulls/1383"}}},"pull_request":{"url":"https://api.github.com/repos/exercism/problem-specifications/pulls/1383","id":228199311,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTk5MzEx","html_url":"https://github.com/exercism/problem-specifications/pull/1383","diff_url":"https://github.com/exercism/problem-specifications/pull/1383.diff","patch_url":"https://github.com/exercism/problem-specifications/pull/1383.patch","issue_url":"https://api.github.com/repos/exercism/problem-specifications/issues/1383","number":1383,"state":"open","locked":false,"title":"wordy: test that various syntax errors are in fact syntax errors","user":{"login":"petertseng","id":346181,"node_id":"MDQ6VXNlcjM0NjE4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/346181?v=4","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"body":"By explicitly testing these we are making sure that the implementation\r\nfails in an appropriate way, rather than failing in an inappropriate way\r\nor erroneously giving an answer.\r\n\r\nFor example, in languages using an optional for their answer, ensuring\r\nthat [`None` is returned instead of panicking/aborting][1].\r\n\r\n[1]: https://github.com/exercism/rust/pull/704#discussion_r230593072\r\n\r\nThis is beneficial because the problem is partially about building a\r\nparser (even if very rudimentary), and it's common for parsers to have\r\nto deal with errors like this. We may otherwise see some unfortunately\r\nfragile parsers.\r\n\r\nIntentional merge conflict for the same reason as #1382","created_at":"2018-11-04T20:08:03Z","updated_at":"2018-11-04T20:10:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exercism/problem-specifications/pulls/1383/commits","review_comments_url":"https://api.github.com/repos/exercism/problem-specifications/pulls/1383/comments","review_comment_url":"https://api.github.com/repos/exercism/problem-specifications/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exercism/problem-specifications/issues/1383/comments","statuses_url":"https://api.github.com/repos/exercism/problem-specifications/statuses/4d458d8351bcfc80a2bdaa2b5962414333fba0b6","head":{"label":"petertseng:wordy-order","ref":"wordy-order","sha":"4d458d8351bcfc80a2bdaa2b5962414333fba0b6","user":{"login":"petertseng","id":346181,"node_id":"MDQ6VXNlcjM0NjE4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/346181?v=4","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"repo":{"id":50249694,"node_id":"MDEwOlJlcG9zaXRvcnk1MDI0OTY5NA==","name":"exercism-problem-specifications","full_name":"petertseng/exercism-problem-specifications","private":false,"owner":{"login":"petertseng","id":346181,"node_id":"MDQ6VXNlcjM0NjE4MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/346181?v=4","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"html_url":"https://github.com/petertseng/exercism-problem-specifications","description":"Shared metadata for exercism exercises.","fork":true,"url":"https://api.github.com/repos/petertseng/exercism-problem-specifications","forks_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/forks","keys_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/teams","hooks_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/hooks","issue_events_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/issues/events{/number}","events_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/events","assignees_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/assignees{/user}","branches_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/branches{/branch}","tags_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/tags","blobs_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/git/refs{/sha}","trees_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/statuses/{sha}","languages_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/languages","stargazers_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/stargazers","contributors_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/contributors","subscribers_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/subscribers","subscription_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/subscription","commits_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/commits{/sha}","git_commits_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/git/commits{/sha}","comments_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/comments{/number}","issue_comment_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/issues/comments{/number}","contents_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/contents/{+path}","compare_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/merges","archive_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/downloads","issues_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/issues{/number}","pulls_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/pulls{/number}","milestones_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/milestones{/number}","notifications_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/labels{/name}","releases_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/releases{/id}","deployments_url":"https://api.github.com/repos/petertseng/exercism-problem-specifications/deployments","created_at":"2016-01-23T17:34:18Z","updated_at":"2018-11-04T09:11:13Z","pushed_at":"2018-11-04T20:07:30Z","git_url":"git://github.com/petertseng/exercism-problem-specifications.git","ssh_url":"git@github.com:petertseng/exercism-problem-specifications.git","clone_url":"https://github.com/petertseng/exercism-problem-specifications.git","svn_url":"https://github.com/petertseng/exercism-problem-specifications","homepage":null,"size":1807,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"verify"}},"base":{"label":"exercism:master","ref":"master","sha":"ad64a3cde27c2e58e889bf5c0c849e606fdab6a3","user":{"login":"exercism","id":5624255,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MjQyNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5624255?v=4","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"repo":{"id":17259886,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI1OTg4Ng==","name":"problem-specifications","full_name":"exercism/problem-specifications","private":false,"owner":{"login":"exercism","id":5624255,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MjQyNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5624255?v=4","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/exercism/problem-specifications","description":"Shared metadata for exercism exercises.","fork":false,"url":"https://api.github.com/repos/exercism/problem-specifications","forks_url":"https://api.github.com/repos/exercism/problem-specifications/forks","keys_url":"https://api.github.com/repos/exercism/problem-specifications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exercism/problem-specifications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exercism/problem-specifications/teams","hooks_url":"https://api.github.com/repos/exercism/problem-specifications/hooks","issue_events_url":"https://api.github.com/repos/exercism/problem-specifications/issues/events{/number}","events_url":"https://api.github.com/repos/exercism/problem-specifications/events","assignees_url":"https://api.github.com/repos/exercism/problem-specifications/assignees{/user}","branches_url":"https://api.github.com/repos/exercism/problem-specifications/branches{/branch}","tags_url":"https://api.github.com/repos/exercism/problem-specifications/tags","blobs_url":"https://api.github.com/repos/exercism/problem-specifications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exercism/problem-specifications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exercism/problem-specifications/git/refs{/sha}","trees_url":"https://api.github.com/repos/exercism/problem-specifications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exercism/problem-specifications/statuses/{sha}","languages_url":"https://api.github.com/repos/exercism/problem-specifications/languages","stargazers_url":"https://api.github.com/repos/exercism/problem-specifications/stargazers","contributors_url":"https://api.github.com/repos/exercism/problem-specifications/contributors","subscribers_url":"https://api.github.com/repos/exercism/problem-specifications/subscribers","subscription_url":"https://api.github.com/repos/exercism/problem-specifications/subscription","commits_url":"https://api.github.com/repos/exercism/problem-specifications/commits{/sha}","git_commits_url":"https://api.github.com/repos/exercism/problem-specifications/git/commits{/sha}","comments_url":"https://api.github.com/repos/exercism/problem-specifications/comments{/number}","issue_comment_url":"https://api.github.com/repos/exercism/problem-specifications/issues/comments{/number}","contents_url":"https://api.github.com/repos/exercism/problem-specifications/contents/{+path}","compare_url":"https://api.github.com/repos/exercism/problem-specifications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exercism/problem-specifications/merges","archive_url":"https://api.github.com/repos/exercism/problem-specifications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exercism/problem-specifications/downloads","issues_url":"https://api.github.com/repos/exercism/problem-specifications/issues{/number}","pulls_url":"https://api.github.com/repos/exercism/problem-specifications/pulls{/number}","milestones_url":"https://api.github.com/repos/exercism/problem-specifications/milestones{/number}","notifications_url":"https://api.github.com/repos/exercism/problem-specifications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exercism/problem-specifications/labels{/name}","releases_url":"https://api.github.com/repos/exercism/problem-specifications/releases{/id}","deployments_url":"https://api.github.com/repos/exercism/problem-specifications/deployments","created_at":"2014-02-27T18:40:48Z","updated_at":"2018-11-01T20:10:56Z","pushed_at":"2018-11-04T20:08:04Z","git_url":"git://github.com/exercism/problem-specifications.git","ssh_url":"git@github.com:exercism/problem-specifications.git","clone_url":"https://github.com/exercism/problem-specifications.git","svn_url":"https://github.com/exercism/problem-specifications","homepage":null,"size":1677,"stargazers_count":148,"watchers_count":148,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":363,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":363,"open_issues":85,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exercism/problem-specifications/pulls/1383"},"html":{"href":"https://github.com/exercism/problem-specifications/pull/1383"},"issue":{"href":"https://api.github.com/repos/exercism/problem-specifications/issues/1383"},"comments":{"href":"https://api.github.com/repos/exercism/problem-specifications/issues/1383/comments"},"review_comments":{"href":"https://api.github.com/repos/exercism/problem-specifications/pulls/1383/comments"},"review_comment":{"href":"https://api.github.com/repos/exercism/problem-specifications/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exercism/problem-specifications/pulls/1383/commits"},"statuses":{"href":"https://api.github.com/repos/exercism/problem-specifications/statuses/4d458d8351bcfc80a2bdaa2b5962414333fba0b6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"petertseng"}}