{"action":"created","comment":{"url":"https://api.github.com/repos/boto/botocore/pulls/comments/212746850","pull_request_review_id":149437146,"id":212746850,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjc0Njg1MA==","diff_hunk":"@@ -53,6 +52,83 @@\n     ConnectTimeoutError,\n )\n S3_ACCELERATE_WHITELIST = ['dualstack']\n+# In switching events from using service name / endpoint prefix to service\n+# id, we have to preserve compatibility. This maps the instances where either\n+# is different than the transformed service id.\n+EVENT_ALIASES = {","path":"botocore/utils.py","position":15,"original_position":15,"commit_id":"a779e65d6c669bb93991ae1511e9f75e9842f97e","original_commit_id":"66d04f1f78ec30b661ba5b8c4e31002cfa016638","user":{"login":"kyleknap","id":4605355,"node_id":"MDQ6VXNlcjQ2MDUzNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/4605355?v=4","gravatar_id":"","url":"https://api.github.com/users/kyleknap","html_url":"https://github.com/kyleknap","followers_url":"https://api.github.com/users/kyleknap/followers","following_url":"https://api.github.com/users/kyleknap/following{/other_user}","gists_url":"https://api.github.com/users/kyleknap/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleknap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleknap/subscriptions","organizations_url":"https://api.github.com/users/kyleknap/orgs","repos_url":"https://api.github.com/users/kyleknap/repos","events_url":"https://api.github.com/users/kyleknap/events{/privacy}","received_events_url":"https://api.github.com/users/kyleknap/received_events","type":"User","site_admin":false},"body":"What's your thoughts on adding some functional tests for these aliases? I was thinking it would be similar to what we did for `sagemaker` but be more programmatic. Specifically, we would have two tests where one emits events for service names that do not match the service id and the other emits events for endpoint prefixes that do not match the service id. Then in each yielded case we would register a handler to an event that uses the appropriate alias and make sure it gets fired. The list for the cases to run would also be statically generated. I think this can give us a lot of confidence in these aliasings. ","created_at":"2018-08-24T20:29:17Z","updated_at":"2018-08-24T20:29:43Z","html_url":"https://github.com/boto/botocore/pull/1524#discussion_r212746850","pull_request_url":"https://api.github.com/repos/boto/botocore/pulls/1524","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/boto/botocore/pulls/comments/212746850"},"html":{"href":"https://github.com/boto/botocore/pull/1524#discussion_r212746850"},"pull_request":{"href":"https://api.github.com/repos/boto/botocore/pulls/1524"}}},"pull_request":{"url":"https://api.github.com/repos/boto/botocore/pulls/1524","id":210284366,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMjg0MzY2","html_url":"https://github.com/boto/botocore/pull/1524","diff_url":"https://github.com/boto/botocore/pull/1524.diff","patch_url":"https://github.com/boto/botocore/pull/1524.patch","issue_url":"https://api.github.com/repos/boto/botocore/issues/1524","number":1524,"state":"open","locked":false,"title":"Migrate to service ids for event names","user":{"login":"JordonPhillips","id":2643092,"node_id":"MDQ6VXNlcjI2NDMwOTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2643092?v=4","gravatar_id":"","url":"https://api.github.com/users/JordonPhillips","html_url":"https://github.com/JordonPhillips","followers_url":"https://api.github.com/users/JordonPhillips/followers","following_url":"https://api.github.com/users/JordonPhillips/following{/other_user}","gists_url":"https://api.github.com/users/JordonPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/JordonPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordonPhillips/subscriptions","organizations_url":"https://api.github.com/users/JordonPhillips/orgs","repos_url":"https://api.github.com/users/JordonPhillips/repos","events_url":"https://api.github.com/users/JordonPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/JordonPhillips/received_events","type":"User","site_admin":false},"body":"This moves events from using some combination of service name and\r\nenpoint prefix to always using the new service id. This maintains\r\ncompatiblity with the previous state, but nonetheless updates all\r\ninternal usage.\r\n\r\nIt also migrates the aliasing strategy to using a wrapper class so custom\r\nemitters are also aliased.","created_at":"2018-08-22T22:39:20Z","updated_at":"2018-08-24T20:29:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fe262b5bd2c84db338dab3a09385435c22337ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/boto/botocore/pulls/1524/commits","review_comments_url":"https://api.github.com/repos/boto/botocore/pulls/1524/comments","review_comment_url":"https://api.github.com/repos/boto/botocore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boto/botocore/issues/1524/comments","statuses_url":"https://api.github.com/repos/boto/botocore/statuses/a779e65d6c669bb93991ae1511e9f75e9842f97e","head":{"label":"JordonPhillips:service-id-events","ref":"service-id-events","sha":"a779e65d6c669bb93991ae1511e9f75e9842f97e","user":{"login":"JordonPhillips","id":2643092,"node_id":"MDQ6VXNlcjI2NDMwOTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2643092?v=4","gravatar_id":"","url":"https://api.github.com/users/JordonPhillips","html_url":"https://github.com/JordonPhillips","followers_url":"https://api.github.com/users/JordonPhillips/followers","following_url":"https://api.github.com/users/JordonPhillips/following{/other_user}","gists_url":"https://api.github.com/users/JordonPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/JordonPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordonPhillips/subscriptions","organizations_url":"https://api.github.com/users/JordonPhillips/orgs","repos_url":"https://api.github.com/users/JordonPhillips/repos","events_url":"https://api.github.com/users/JordonPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/JordonPhillips/received_events","type":"User","site_admin":false},"repo":{"id":41875883,"node_id":"MDEwOlJlcG9zaXRvcnk0MTg3NTg4Mw==","name":"botocore","full_name":"JordonPhillips/botocore","owner":{"login":"JordonPhillips","id":2643092,"node_id":"MDQ6VXNlcjI2NDMwOTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2643092?v=4","gravatar_id":"","url":"https://api.github.com/users/JordonPhillips","html_url":"https://github.com/JordonPhillips","followers_url":"https://api.github.com/users/JordonPhillips/followers","following_url":"https://api.github.com/users/JordonPhillips/following{/other_user}","gists_url":"https://api.github.com/users/JordonPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/JordonPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordonPhillips/subscriptions","organizations_url":"https://api.github.com/users/JordonPhillips/orgs","repos_url":"https://api.github.com/users/JordonPhillips/repos","events_url":"https://api.github.com/users/JordonPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/JordonPhillips/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JordonPhillips/botocore","description":"The low-level, core functionality of boto 3.","fork":true,"url":"https://api.github.com/repos/JordonPhillips/botocore","forks_url":"https://api.github.com/repos/JordonPhillips/botocore/forks","keys_url":"https://api.github.com/repos/JordonPhillips/botocore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JordonPhillips/botocore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JordonPhillips/botocore/teams","hooks_url":"https://api.github.com/repos/JordonPhillips/botocore/hooks","issue_events_url":"https://api.github.com/repos/JordonPhillips/botocore/issues/events{/number}","events_url":"https://api.github.com/repos/JordonPhillips/botocore/events","assignees_url":"https://api.github.com/repos/JordonPhillips/botocore/assignees{/user}","branches_url":"https://api.github.com/repos/JordonPhillips/botocore/branches{/branch}","tags_url":"https://api.github.com/repos/JordonPhillips/botocore/tags","blobs_url":"https://api.github.com/repos/JordonPhillips/botocore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JordonPhillips/botocore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JordonPhillips/botocore/git/refs{/sha}","trees_url":"https://api.github.com/repos/JordonPhillips/botocore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JordonPhillips/botocore/statuses/{sha}","languages_url":"https://api.github.com/repos/JordonPhillips/botocore/languages","stargazers_url":"https://api.github.com/repos/JordonPhillips/botocore/stargazers","contributors_url":"https://api.github.com/repos/JordonPhillips/botocore/contributors","subscribers_url":"https://api.github.com/repos/JordonPhillips/botocore/subscribers","subscription_url":"https://api.github.com/repos/JordonPhillips/botocore/subscription","commits_url":"https://api.github.com/repos/JordonPhillips/botocore/commits{/sha}","git_commits_url":"https://api.github.com/repos/JordonPhillips/botocore/git/commits{/sha}","comments_url":"https://api.github.com/repos/JordonPhillips/botocore/comments{/number}","issue_comment_url":"https://api.github.com/repos/JordonPhillips/botocore/issues/comments{/number}","contents_url":"https://api.github.com/repos/JordonPhillips/botocore/contents/{+path}","compare_url":"https://api.github.com/repos/JordonPhillips/botocore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JordonPhillips/botocore/merges","archive_url":"https://api.github.com/repos/JordonPhillips/botocore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JordonPhillips/botocore/downloads","issues_url":"https://api.github.com/repos/JordonPhillips/botocore/issues{/number}","pulls_url":"https://api.github.com/repos/JordonPhillips/botocore/pulls{/number}","milestones_url":"https://api.github.com/repos/JordonPhillips/botocore/milestones{/number}","notifications_url":"https://api.github.com/repos/JordonPhillips/botocore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JordonPhillips/botocore/labels{/name}","releases_url":"https://api.github.com/repos/JordonPhillips/botocore/releases{/id}","deployments_url":"https://api.github.com/repos/JordonPhillips/botocore/deployments","created_at":"2015-09-03T18:13:17Z","updated_at":"2018-08-24T17:11:45Z","pushed_at":"2018-08-24T17:22:42Z","git_url":"git://github.com/JordonPhillips/botocore.git","ssh_url":"git@github.com:JordonPhillips/botocore.git","clone_url":"https://github.com/JordonPhillips/botocore.git","svn_url":"https://github.com/JordonPhillips/botocore","homepage":null,"size":44319,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"boto:develop","ref":"develop","sha":"25fec7e95af8420eaae7a43b9071eb85bfcf89c2","user":{"login":"boto","id":327752,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzc1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/327752?v=4","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"repo":{"id":6670942,"node_id":"MDEwOlJlcG9zaXRvcnk2NjcwOTQy","name":"botocore","full_name":"boto/botocore","owner":{"login":"boto","id":327752,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzc1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/327752?v=4","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boto/botocore","description":"The low-level, core functionality of boto 3.","fork":false,"url":"https://api.github.com/repos/boto/botocore","forks_url":"https://api.github.com/repos/boto/botocore/forks","keys_url":"https://api.github.com/repos/boto/botocore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boto/botocore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boto/botocore/teams","hooks_url":"https://api.github.com/repos/boto/botocore/hooks","issue_events_url":"https://api.github.com/repos/boto/botocore/issues/events{/number}","events_url":"https://api.github.com/repos/boto/botocore/events","assignees_url":"https://api.github.com/repos/boto/botocore/assignees{/user}","branches_url":"https://api.github.com/repos/boto/botocore/branches{/branch}","tags_url":"https://api.github.com/repos/boto/botocore/tags","blobs_url":"https://api.github.com/repos/boto/botocore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boto/botocore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boto/botocore/git/refs{/sha}","trees_url":"https://api.github.com/repos/boto/botocore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boto/botocore/statuses/{sha}","languages_url":"https://api.github.com/repos/boto/botocore/languages","stargazers_url":"https://api.github.com/repos/boto/botocore/stargazers","contributors_url":"https://api.github.com/repos/boto/botocore/contributors","subscribers_url":"https://api.github.com/repos/boto/botocore/subscribers","subscription_url":"https://api.github.com/repos/boto/botocore/subscription","commits_url":"https://api.github.com/repos/boto/botocore/commits{/sha}","git_commits_url":"https://api.github.com/repos/boto/botocore/git/commits{/sha}","comments_url":"https://api.github.com/repos/boto/botocore/comments{/number}","issue_comment_url":"https://api.github.com/repos/boto/botocore/issues/comments{/number}","contents_url":"https://api.github.com/repos/boto/botocore/contents/{+path}","compare_url":"https://api.github.com/repos/boto/botocore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boto/botocore/merges","archive_url":"https://api.github.com/repos/boto/botocore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boto/botocore/downloads","issues_url":"https://api.github.com/repos/boto/botocore/issues{/number}","pulls_url":"https://api.github.com/repos/boto/botocore/pulls{/number}","milestones_url":"https://api.github.com/repos/boto/botocore/milestones{/number}","notifications_url":"https://api.github.com/repos/boto/botocore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boto/botocore/labels{/name}","releases_url":"https://api.github.com/repos/boto/botocore/releases{/id}","deployments_url":"https://api.github.com/repos/boto/botocore/deployments","created_at":"2012-11-13T13:25:36Z","updated_at":"2018-08-24T18:53:28Z","pushed_at":"2018-08-24T18:00:15Z","git_url":"git://github.com/boto/botocore.git","ssh_url":"git@github.com:boto/botocore.git","clone_url":"https://github.com/boto/botocore.git","svn_url":"https://github.com/boto/botocore","homepage":null,"size":44138,"stargazers_count":498,"watchers_count":498,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":442,"mirror_url":null,"archived":false,"open_issues_count":153,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":442,"open_issues":153,"watchers":498,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/boto/botocore/pulls/1524"},"html":{"href":"https://github.com/boto/botocore/pull/1524"},"issue":{"href":"https://api.github.com/repos/boto/botocore/issues/1524"},"comments":{"href":"https://api.github.com/repos/boto/botocore/issues/1524/comments"},"review_comments":{"href":"https://api.github.com/repos/boto/botocore/pulls/1524/comments"},"review_comment":{"href":"https://api.github.com/repos/boto/botocore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boto/botocore/pulls/1524/commits"},"statuses":{"href":"https://api.github.com/repos/boto/botocore/statuses/a779e65d6c669bb93991ae1511e9f75e9842f97e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kyleknap"}}