{"action":"created","issue":{"url":"https://api.github.com/repos/E3SM-Project/HOMMEXX/issues/370","repository_url":"https://api.github.com/repos/E3SM-Project/HOMMEXX","labels_url":"https://api.github.com/repos/E3SM-Project/HOMMEXX/issues/370/labels{/name}","comments_url":"https://api.github.com/repos/E3SM-Project/HOMMEXX/issues/370/comments","events_url":"https://api.github.com/repos/E3SM-Project/HOMMEXX/issues/370/events","html_url":"https://github.com/E3SM-Project/HOMMEXX/pull/370","id":358796267,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDQ1NDIy","number":370,"title":"Changed tests names and their configuration","user":{"login":"bartgol","id":3226046,"node_id":"MDQ6VXNlcjMyMjYwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/3226046?v=4","gravatar_id":"","url":"https://api.github.com/users/bartgol","html_url":"https://github.com/bartgol","followers_url":"https://api.github.com/users/bartgol/followers","following_url":"https://api.github.com/users/bartgol/following{/other_user}","gists_url":"https://api.github.com/users/bartgol/gists{/gist_id}","starred_url":"https://api.github.com/users/bartgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartgol/subscriptions","organizations_url":"https://api.github.com/users/bartgol/orgs","repos_url":"https://api.github.com/users/bartgol/repos","events_url":"https://api.github.com/users/bartgol/events{/privacy}","received_events_url":"https://api.github.com/users/bartgol/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-10T21:11:09Z","updated_at":"2018-09-10T21:27:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/E3SM-Project/HOMMEXX/pulls/370","html_url":"https://github.com/E3SM-Project/HOMMEXX/pull/370","diff_url":"https://github.com/E3SM-Project/HOMMEXX/pull/370.diff","patch_url":"https://github.com/E3SM-Project/HOMMEXX/pull/370.patch"},"body":"This PR does a couple of changes to the tests in hommexx.\r\n\r\n1) the executable and tests root name is no longer prtcA or prtcB (impossible to pronounce, btw), but preqx-nlev26 and preqx-nlev72 (more verbose). These name roots are also applied to the tests.\r\n2) the cmake logic used to configure tests namelists is extended to more options. So far we only used it to configure ne and ndays; now we use it also for rsplit, qsize, moisture and the name of vcoord files. This allows to have much fewer files in test/reg_test/namelists, increasing maintainability and lowering bugs (only 1 file to change for multiple tests).\r\n3) Distinction between original fortran an kokkos versions (of executables, tests, and the likes) is now via a '-kokkos' appended to kokkos version. The fortran version has no hint (e.g., no '-f' appended to fortran tests names).\r\n\r\nNote: we could push this evn further, and have a single namelist file, with plenty of cmake variables in it, so that we could use it also for tensorhv, nudiv, q6 and lim9 tests. However, those are more 'niche' options, not as often played around with as the others, so for those tests I put a specific namelist file."},"comment":{"url":"https://api.github.com/repos/E3SM-Project/HOMMEXX/issues/comments/420067060","html_url":"https://github.com/E3SM-Project/HOMMEXX/pull/370#issuecomment-420067060","issue_url":"https://api.github.com/repos/E3SM-Project/HOMMEXX/issues/370","id":420067060,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDA2NzA2MA==","user":{"login":"ambrad","id":3401413,"node_id":"MDQ6VXNlcjM0MDE0MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/3401413?v=4","gravatar_id":"","url":"https://api.github.com/users/ambrad","html_url":"https://github.com/ambrad","followers_url":"https://api.github.com/users/ambrad/followers","following_url":"https://api.github.com/users/ambrad/following{/other_user}","gists_url":"https://api.github.com/users/ambrad/gists{/gist_id}","starred_url":"https://api.github.com/users/ambrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ambrad/subscriptions","organizations_url":"https://api.github.com/users/ambrad/orgs","repos_url":"https://api.github.com/users/ambrad/repos","events_url":"https://api.github.com/users/ambrad/events{/privacy}","received_events_url":"https://api.github.com/users/ambrad/received_events","type":"User","site_admin":false},"created_at":"2018-09-10T21:27:20Z","updated_at":"2018-09-10T21:27:20Z","author_association":"CONTRIBUTOR","body":"This is great. I'm doing a full run with baselines, etc.; I'll report back later this afternoon if all goes well."}}
{"actor":{"display_login":"ambrad"}}