{"action":"created","issue":{"url":"https://api.github.com/repos/chrmarti/vscode-regex/issues/27","repository_url":"https://api.github.com/repos/chrmarti/vscode-regex","labels_url":"https://api.github.com/repos/chrmarti/vscode-regex/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/chrmarti/vscode-regex/issues/27/comments","events_url":"https://api.github.com/repos/chrmarti/vscode-regex/issues/27/events","html_url":"https://github.com/chrmarti/vscode-regex/issues/27","id":315788720,"number":27,"title":"False positive match for URL route definitions","user":{"login":"bennidi","id":1842420,"avatar_url":"https://avatars2.githubusercontent.com/u/1842420?v=4","gravatar_id":"","url":"https://api.github.com/users/bennidi","html_url":"https://github.com/bennidi","followers_url":"https://api.github.com/users/bennidi/followers","following_url":"https://api.github.com/users/bennidi/following{/other_user}","gists_url":"https://api.github.com/users/bennidi/gists{/gist_id}","starred_url":"https://api.github.com/users/bennidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bennidi/subscriptions","organizations_url":"https://api.github.com/users/bennidi/orgs","repos_url":"https://api.github.com/users/bennidi/repos","events_url":"https://api.github.com/users/bennidi/events{/privacy}","received_events_url":"https://api.github.com/users/bennidi/received_events","type":"User","site_admin":false},"labels":[{"id":399374395,"url":"https://api.github.com/repos/chrmarti/vscode-regex/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":{"login":"chrmarti","id":9205389,"avatar_url":"https://avatars2.githubusercontent.com/u/9205389?v=4","gravatar_id":"","url":"https://api.github.com/users/chrmarti","html_url":"https://github.com/chrmarti","followers_url":"https://api.github.com/users/chrmarti/followers","following_url":"https://api.github.com/users/chrmarti/following{/other_user}","gists_url":"https://api.github.com/users/chrmarti/gists{/gist_id}","starred_url":"https://api.github.com/users/chrmarti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrmarti/subscriptions","organizations_url":"https://api.github.com/users/chrmarti/orgs","repos_url":"https://api.github.com/users/chrmarti/repos","events_url":"https://api.github.com/users/chrmarti/events{/privacy}","received_events_url":"https://api.github.com/users/chrmarti/received_events","type":"User","site_admin":false},"assignees":[{"login":"chrmarti","id":9205389,"avatar_url":"https://avatars2.githubusercontent.com/u/9205389?v=4","gravatar_id":"","url":"https://api.github.com/users/chrmarti","html_url":"https://github.com/chrmarti","followers_url":"https://api.github.com/users/chrmarti/followers","following_url":"https://api.github.com/users/chrmarti/following{/other_user}","gists_url":"https://api.github.com/users/chrmarti/gists{/gist_id}","starred_url":"https://api.github.com/users/chrmarti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrmarti/subscriptions","organizations_url":"https://api.github.com/users/chrmarti/orgs","repos_url":"https://api.github.com/users/chrmarti/repos","events_url":"https://api.github.com/users/chrmarti/events{/privacy}","received_events_url":"https://api.github.com/users/chrmarti/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-04-19T09:05:13Z","updated_at":"2018-04-20T10:24:53Z","closed_at":null,"author_association":"NONE","body":"Hey, I really enjoy this small extension a lot. Thanks for giving it out to the community.\r\nI am currently developing a lot of node.js / koa services. And the codebase also contains quite some swagger documentation.\r\n\r\nI have matches in various places where I don't like them and all the extra lenses make me see less than more :)\r\nExample:\r\n\r\n```js\r\n    describe('(a) POST /vehicles/{vehicleId}/reservations', () => {\r\n```\r\n\r\nI don't know what other users think but I believe that test regex should never be applied to strings that have some regex like meta-character in them."},"comment":{"url":"https://api.github.com/repos/chrmarti/vscode-regex/issues/comments/383054524","html_url":"https://github.com/chrmarti/vscode-regex/issues/27#issuecomment-383054524","issue_url":"https://api.github.com/repos/chrmarti/vscode-regex/issues/27","id":383054524,"user":{"login":"bennidi","id":1842420,"avatar_url":"https://avatars2.githubusercontent.com/u/1842420?v=4","gravatar_id":"","url":"https://api.github.com/users/bennidi","html_url":"https://github.com/bennidi","followers_url":"https://api.github.com/users/bennidi/followers","following_url":"https://api.github.com/users/bennidi/following{/other_user}","gists_url":"https://api.github.com/users/bennidi/gists{/gist_id}","starred_url":"https://api.github.com/users/bennidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bennidi/subscriptions","organizations_url":"https://api.github.com/users/bennidi/orgs","repos_url":"https://api.github.com/users/bennidi/repos","events_url":"https://api.github.com/users/bennidi/events{/privacy}","received_events_url":"https://api.github.com/users/bennidi/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T10:24:53Z","updated_at":"2018-04-20T10:24:53Z","author_association":"NONE","body":"I have no clue how vscode extensions are developed -  I mean what the\nsurrounding framework provides as context and hooks etc. But in an IDE,\nshouldn't there be an AST of some sort? Anyways, the regex should be able\nto see that it is contained in a string (^' or ^\" and $' , $\") - but I am\nalso no regexpert.\n\nWhat do you think? What would be a good way to go? Maybe I can create a\nPR...\n\n2018-04-20 11:43 GMT+02:00 Christof Marti <notifications@github.com>:\n\n> I agree. The difficulty here is that the extension currently doesn't know\n> which part of the code it is looking at. So it doesn't know if it is in a\n> string, comment or regular code.\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/chrmarti/vscode-regex/issues/27#issuecomment-383044477>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ABwc9Cp84MuLuTN7Vlg1jGLHEwNg4PcOks5tqa27gaJpZM4TbaZo>\n> .\n>\n"}}
{"actor":{"display_login":"bennidi"}}