{"action":"created","issue":{"url":"https://api.github.com/repos/reloxx13/SonWEB/issues/92","repository_url":"https://api.github.com/repos/reloxx13/SonWEB","labels_url":"https://api.github.com/repos/reloxx13/SonWEB/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/reloxx13/SonWEB/issues/92/comments","events_url":"https://api.github.com/repos/reloxx13/SonWEB/issues/92/events","html_url":"https://github.com/reloxx13/SonWEB/issues/92","id":320547853,"number":92,"title":"Merge Sonweb and SonWeb docker ","user":{"login":"RaymondMouthaan","id":25717738,"avatar_url":"https://avatars3.githubusercontent.com/u/25717738?v=4","gravatar_id":"","url":"https://api.github.com/users/RaymondMouthaan","html_url":"https://github.com/RaymondMouthaan","followers_url":"https://api.github.com/users/RaymondMouthaan/followers","following_url":"https://api.github.com/users/RaymondMouthaan/following{/other_user}","gists_url":"https://api.github.com/users/RaymondMouthaan/gists{/gist_id}","starred_url":"https://api.github.com/users/RaymondMouthaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaymondMouthaan/subscriptions","organizations_url":"https://api.github.com/users/RaymondMouthaan/orgs","repos_url":"https://api.github.com/users/RaymondMouthaan/repos","events_url":"https://api.github.com/users/RaymondMouthaan/events{/privacy}","received_events_url":"https://api.github.com/users/RaymondMouthaan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-05T23:01:06Z","updated_at":"2018-05-16T09:51:23Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"@reloxx13 what do you think of merging my docker stuff into your Sonoff github project, so we have all code in one place? \r\n\r\nMaybe before renaming of the project or after.. #81 ?\r\n\r\nI also was thinking from a docker point of view to extend the number of supported architectures. \r\n\r\nLet me know your thoughts about it... 🤔"},"comment":{"url":"https://api.github.com/repos/reloxx13/SonWEB/issues/comments/389462242","html_url":"https://github.com/reloxx13/SonWEB/issues/92#issuecomment-389462242","issue_url":"https://api.github.com/repos/reloxx13/SonWEB/issues/92","id":389462242,"user":{"login":"RaymondMouthaan","id":25717738,"avatar_url":"https://avatars3.githubusercontent.com/u/25717738?v=4","gravatar_id":"","url":"https://api.github.com/users/RaymondMouthaan","html_url":"https://github.com/RaymondMouthaan","followers_url":"https://api.github.com/users/RaymondMouthaan/followers","following_url":"https://api.github.com/users/RaymondMouthaan/following{/other_user}","gists_url":"https://api.github.com/users/RaymondMouthaan/gists{/gist_id}","starred_url":"https://api.github.com/users/RaymondMouthaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaymondMouthaan/subscriptions","organizations_url":"https://api.github.com/users/RaymondMouthaan/orgs","repos_url":"https://api.github.com/users/RaymondMouthaan/repos","events_url":"https://api.github.com/users/RaymondMouthaan/events{/privacy}","received_events_url":"https://api.github.com/users/RaymondMouthaan/received_events","type":"User","site_admin":false},"created_at":"2018-05-16T09:51:23Z","updated_at":"2018-05-16T09:51:23Z","author_association":"CONTRIBUTOR","body":"Ola @reloxx13,\r\n\r\nWhen we merge, all files and dirs from [SonWeb-Docker](https://github.com/RaymondMouthaan/sonweb-docker) will be placed in [SonWeb](https://github.com/reloxx13/SonWEB). And indeed when a git clone and/or auto-update will be executed then also the docker related files will be downloaded. This wouldn't be a problem since these files do not interfere with the application it self.\r\n\r\nAs we decide to merge both, this would mean that we need a Travis account and the SonWeb GitHub project is synced to it - Travis builds the docker image and pushes it to Docker Hub. When one commits changes to GitHub, then Travis gets triggered and builds the SonWeb docker images pushes it to Docker Hub (automatically). I can take the docker part for my responsibility as you can continue your work for SonWeb application. Best would be if you can give me access to GitHub SonWeb, so we both maintain SonWeb. If giving access is a problem then using the PR mechanism could be a solution. I do the changes via PR (no access is required) and you can merge those changes.\r\n\r\nAnother thing i like to suggest is to work with \"releases\" .. let me explain :-) .. GitHub has the ability to create releases and tag them (see [example](https://github.com/RaymondMouthaan/docker-image-logitech-media-server/releases)). My idea (and seen at many GitHub projects) is to create a release using Travis. So with the Travis build job, we git clone the project, we pack all SonWeb related files and dirs (only required files, excluding the docker related files) into a tar.gz file and push this as a release with a version into GitHub. This release tar.gz file can be used by the auto-update function in SonWeb application. Curl or wget the tar.gz and extract and update SonWeb.\r\nSince the source files of SonWeb are available on the Travis build server, we can build our Docker images directly right after. We also can include some tests before releasing a newer version. \r\n\r\nIf you are interested to do as above, I am happy to participate the SonWeb project :-) .. let me know your thoughts ... \r\n\r\n@ascillato, for me SonWeb and SonWeb docker are related and candidates to merge to have all SonWeb related stuff at one place. This is easier to maintain and more user friendly. \r\nHowever I don't see the reason to merge Sonoff-Tasmota_Modified and Sonoff-Tasmota_KNX into it. These projects are not related to SonWeb and I would not recommend to put those into the same project.\r\nI am not a HomeAssistant user, so I am not sure what you mean by ADD-ONS in relation to Docker?  "}}
{"actor":{"display_login":"RaymondMouthaan"}}