{"action":"created","comment":{"url":"https://api.github.com/repos/vrapio/rmf-codegen/pulls/comments/207568849","pull_request_review_id":143210075,"id":207568849,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzU2ODg0OQ==","diff_hunk":"@@ -0,0 +1,87 @@\n+package io.vrap.rmf.codegen.common.generator.core;\n+\n+import io.vrap.rmf.codegen.common.processor.extension.ExtensionMapper;\n+import io.vrap.rmf.raml.model.resources.Resource;\n+import io.vrap.rmf.raml.model.types.ObjectType;\n+import io.vrap.rmf.raml.model.types.StringType;\n+import io.vrap.rmf.raml.model.types.util.TypesSwitch;\n+import org.eclipse.emf.ecore.EObject;\n+import org.eclipse.emf.ecore.util.ComposedSwitch;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+import org.stringtemplate.v4.STGroupFile;\n+\n+import java.util.HashMap;\n+import java.util.List;\n+import java.util.Map;\n+\n+\n+public class JavaSTFileSwitch extends ComposedSwitch<STGroupFile> {\n+\n+    private static final Logger LOGGER = LoggerFactory.getLogger(JavaSTFileSwitch.class);\n+\n+    private Map<String, STGroupFile> cache = new HashMap<>();","path":"common-codegen/src/main/java/io/vrap/rmf/codegen/common/generator/core/JavaSTFileSwitch.java","position":23,"original_position":23,"commit_id":"adde29baecb678c9d1fd4eec4639a6b73bc18c53","original_commit_id":"adde29baecb678c9d1fd4eec4639a6b73bc18c53","user":{"login":"katmatt","id":231232,"node_id":"MDQ6VXNlcjIzMTIzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/231232?v=4","gravatar_id":"","url":"https://api.github.com/users/katmatt","html_url":"https://github.com/katmatt","followers_url":"https://api.github.com/users/katmatt/followers","following_url":"https://api.github.com/users/katmatt/following{/other_user}","gists_url":"https://api.github.com/users/katmatt/gists{/gist_id}","starred_url":"https://api.github.com/users/katmatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katmatt/subscriptions","organizations_url":"https://api.github.com/users/katmatt/orgs","repos_url":"https://api.github.com/users/katmatt/repos","events_url":"https://api.github.com/users/katmatt/events{/privacy}","received_events_url":"https://api.github.com/users/katmatt/received_events","type":"User","site_admin":false},"body":"I'm not 100% sure, but I thought that stringtemplate already provides a cache. But let's keep your code as it is and we can still see if we can improve this further in the future.","created_at":"2018-08-03T14:47:09Z","updated_at":"2018-08-03T14:53:34Z","html_url":"https://github.com/vrapio/rmf-codegen/pull/18#discussion_r207568849","pull_request_url":"https://api.github.com/repos/vrapio/rmf-codegen/pulls/18","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vrapio/rmf-codegen/pulls/comments/207568849"},"html":{"href":"https://github.com/vrapio/rmf-codegen/pull/18#discussion_r207568849"},"pull_request":{"href":"https://api.github.com/repos/vrapio/rmf-codegen/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/vrapio/rmf-codegen/pulls/18","id":206000142,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDAwMTQy","html_url":"https://github.com/vrapio/rmf-codegen/pull/18","diff_url":"https://github.com/vrapio/rmf-codegen/pull/18.diff","patch_url":"https://github.com/vrapio/rmf-codegen/pull/18.patch","issue_url":"https://api.github.com/repos/vrapio/rmf-codegen/issues/18","number":18,"state":"open","locked":false,"title":"Generating client","user":{"login":"acbeni","id":4366702,"node_id":"MDQ6VXNlcjQzNjY3MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/4366702?v=4","gravatar_id":"","url":"https://api.github.com/users/acbeni","html_url":"https://github.com/acbeni","followers_url":"https://api.github.com/users/acbeni/followers","following_url":"https://api.github.com/users/acbeni/following{/other_user}","gists_url":"https://api.github.com/users/acbeni/gists{/gist_id}","starred_url":"https://api.github.com/users/acbeni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acbeni/subscriptions","organizations_url":"https://api.github.com/users/acbeni/orgs","repos_url":"https://api.github.com/users/acbeni/repos","events_url":"https://api.github.com/users/acbeni/events{/privacy}","received_events_url":"https://api.github.com/users/acbeni/received_events","type":"User","site_admin":false},"body":"Yet another huge PR, sorry @katmatt for that 😢 \r\n\r\nBefore merging the pr please make sure it doesn't break anything since it contains clean ups for old code generators.\r\n\r\nTo make the new generator work you have to setup the test runner to gradle test runner in intellij otherwise it doesn't recognise the extensions.","created_at":"2018-08-03T11:17:14Z","updated_at":"2018-08-03T14:53:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19a81d30075087cfdd11520bee0d110aa2d9bc6c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vrapio/rmf-codegen/pulls/18/commits","review_comments_url":"https://api.github.com/repos/vrapio/rmf-codegen/pulls/18/comments","review_comment_url":"https://api.github.com/repos/vrapio/rmf-codegen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vrapio/rmf-codegen/issues/18/comments","statuses_url":"https://api.github.com/repos/vrapio/rmf-codegen/statuses/adde29baecb678c9d1fd4eec4639a6b73bc18c53","head":{"label":"vrapio:generating-client","ref":"generating-client","sha":"adde29baecb678c9d1fd4eec4639a6b73bc18c53","user":{"login":"vrapio","id":26872105,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODcyMTA1","avatar_url":"https://avatars0.githubusercontent.com/u/26872105?v=4","gravatar_id":"","url":"https://api.github.com/users/vrapio","html_url":"https://github.com/vrapio","followers_url":"https://api.github.com/users/vrapio/followers","following_url":"https://api.github.com/users/vrapio/following{/other_user}","gists_url":"https://api.github.com/users/vrapio/gists{/gist_id}","starred_url":"https://api.github.com/users/vrapio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrapio/subscriptions","organizations_url":"https://api.github.com/users/vrapio/orgs","repos_url":"https://api.github.com/users/vrapio/repos","events_url":"https://api.github.com/users/vrapio/events{/privacy}","received_events_url":"https://api.github.com/users/vrapio/received_events","type":"Organization","site_admin":false},"repo":{"id":136635215,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MzUyMTU=","name":"rmf-codegen","full_name":"vrapio/rmf-codegen","owner":{"login":"vrapio","id":26872105,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODcyMTA1","avatar_url":"https://avatars0.githubusercontent.com/u/26872105?v=4","gravatar_id":"","url":"https://api.github.com/users/vrapio","html_url":"https://github.com/vrapio","followers_url":"https://api.github.com/users/vrapio/followers","following_url":"https://api.github.com/users/vrapio/following{/other_user}","gists_url":"https://api.github.com/users/vrapio/gists{/gist_id}","starred_url":"https://api.github.com/users/vrapio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrapio/subscriptions","organizations_url":"https://api.github.com/users/vrapio/orgs","repos_url":"https://api.github.com/users/vrapio/repos","events_url":"https://api.github.com/users/vrapio/events{/privacy}","received_events_url":"https://api.github.com/users/vrapio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vrapio/rmf-codegen","description":"Provides RAML code generators based on RMF.","fork":false,"url":"https://api.github.com/repos/vrapio/rmf-codegen","forks_url":"https://api.github.com/repos/vrapio/rmf-codegen/forks","keys_url":"https://api.github.com/repos/vrapio/rmf-codegen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrapio/rmf-codegen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrapio/rmf-codegen/teams","hooks_url":"https://api.github.com/repos/vrapio/rmf-codegen/hooks","issue_events_url":"https://api.github.com/repos/vrapio/rmf-codegen/issues/events{/number}","events_url":"https://api.github.com/repos/vrapio/rmf-codegen/events","assignees_url":"https://api.github.com/repos/vrapio/rmf-codegen/assignees{/user}","branches_url":"https://api.github.com/repos/vrapio/rmf-codegen/branches{/branch}","tags_url":"https://api.github.com/repos/vrapio/rmf-codegen/tags","blobs_url":"https://api.github.com/repos/vrapio/rmf-codegen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrapio/rmf-codegen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrapio/rmf-codegen/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrapio/rmf-codegen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrapio/rmf-codegen/statuses/{sha}","languages_url":"https://api.github.com/repos/vrapio/rmf-codegen/languages","stargazers_url":"https://api.github.com/repos/vrapio/rmf-codegen/stargazers","contributors_url":"https://api.github.com/repos/vrapio/rmf-codegen/contributors","subscribers_url":"https://api.github.com/repos/vrapio/rmf-codegen/subscribers","subscription_url":"https://api.github.com/repos/vrapio/rmf-codegen/subscription","commits_url":"https://api.github.com/repos/vrapio/rmf-codegen/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrapio/rmf-codegen/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrapio/rmf-codegen/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrapio/rmf-codegen/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrapio/rmf-codegen/contents/{+path}","compare_url":"https://api.github.com/repos/vrapio/rmf-codegen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrapio/rmf-codegen/merges","archive_url":"https://api.github.com/repos/vrapio/rmf-codegen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrapio/rmf-codegen/downloads","issues_url":"https://api.github.com/repos/vrapio/rmf-codegen/issues{/number}","pulls_url":"https://api.github.com/repos/vrapio/rmf-codegen/pulls{/number}","milestones_url":"https://api.github.com/repos/vrapio/rmf-codegen/milestones{/number}","notifications_url":"https://api.github.com/repos/vrapio/rmf-codegen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrapio/rmf-codegen/labels{/name}","releases_url":"https://api.github.com/repos/vrapio/rmf-codegen/releases{/id}","deployments_url":"https://api.github.com/repos/vrapio/rmf-codegen/deployments","created_at":"2018-06-08T15:17:50Z","updated_at":"2018-07-30T21:45:33Z","pushed_at":"2018-08-03T14:38:18Z","git_url":"git://github.com/vrapio/rmf-codegen.git","ssh_url":"git@github.com:vrapio/rmf-codegen.git","clone_url":"https://github.com/vrapio/rmf-codegen.git","svn_url":"https://github.com/vrapio/rmf-codegen","homepage":"","size":213,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"vrapio:master","ref":"master","sha":"c670dc1d2ed50efd5648757110fa25c368fb7132","user":{"login":"vrapio","id":26872105,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODcyMTA1","avatar_url":"https://avatars0.githubusercontent.com/u/26872105?v=4","gravatar_id":"","url":"https://api.github.com/users/vrapio","html_url":"https://github.com/vrapio","followers_url":"https://api.github.com/users/vrapio/followers","following_url":"https://api.github.com/users/vrapio/following{/other_user}","gists_url":"https://api.github.com/users/vrapio/gists{/gist_id}","starred_url":"https://api.github.com/users/vrapio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrapio/subscriptions","organizations_url":"https://api.github.com/users/vrapio/orgs","repos_url":"https://api.github.com/users/vrapio/repos","events_url":"https://api.github.com/users/vrapio/events{/privacy}","received_events_url":"https://api.github.com/users/vrapio/received_events","type":"Organization","site_admin":false},"repo":{"id":136635215,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MzUyMTU=","name":"rmf-codegen","full_name":"vrapio/rmf-codegen","owner":{"login":"vrapio","id":26872105,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODcyMTA1","avatar_url":"https://avatars0.githubusercontent.com/u/26872105?v=4","gravatar_id":"","url":"https://api.github.com/users/vrapio","html_url":"https://github.com/vrapio","followers_url":"https://api.github.com/users/vrapio/followers","following_url":"https://api.github.com/users/vrapio/following{/other_user}","gists_url":"https://api.github.com/users/vrapio/gists{/gist_id}","starred_url":"https://api.github.com/users/vrapio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrapio/subscriptions","organizations_url":"https://api.github.com/users/vrapio/orgs","repos_url":"https://api.github.com/users/vrapio/repos","events_url":"https://api.github.com/users/vrapio/events{/privacy}","received_events_url":"https://api.github.com/users/vrapio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vrapio/rmf-codegen","description":"Provides RAML code generators based on RMF.","fork":false,"url":"https://api.github.com/repos/vrapio/rmf-codegen","forks_url":"https://api.github.com/repos/vrapio/rmf-codegen/forks","keys_url":"https://api.github.com/repos/vrapio/rmf-codegen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vrapio/rmf-codegen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vrapio/rmf-codegen/teams","hooks_url":"https://api.github.com/repos/vrapio/rmf-codegen/hooks","issue_events_url":"https://api.github.com/repos/vrapio/rmf-codegen/issues/events{/number}","events_url":"https://api.github.com/repos/vrapio/rmf-codegen/events","assignees_url":"https://api.github.com/repos/vrapio/rmf-codegen/assignees{/user}","branches_url":"https://api.github.com/repos/vrapio/rmf-codegen/branches{/branch}","tags_url":"https://api.github.com/repos/vrapio/rmf-codegen/tags","blobs_url":"https://api.github.com/repos/vrapio/rmf-codegen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vrapio/rmf-codegen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vrapio/rmf-codegen/git/refs{/sha}","trees_url":"https://api.github.com/repos/vrapio/rmf-codegen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vrapio/rmf-codegen/statuses/{sha}","languages_url":"https://api.github.com/repos/vrapio/rmf-codegen/languages","stargazers_url":"https://api.github.com/repos/vrapio/rmf-codegen/stargazers","contributors_url":"https://api.github.com/repos/vrapio/rmf-codegen/contributors","subscribers_url":"https://api.github.com/repos/vrapio/rmf-codegen/subscribers","subscription_url":"https://api.github.com/repos/vrapio/rmf-codegen/subscription","commits_url":"https://api.github.com/repos/vrapio/rmf-codegen/commits{/sha}","git_commits_url":"https://api.github.com/repos/vrapio/rmf-codegen/git/commits{/sha}","comments_url":"https://api.github.com/repos/vrapio/rmf-codegen/comments{/number}","issue_comment_url":"https://api.github.com/repos/vrapio/rmf-codegen/issues/comments{/number}","contents_url":"https://api.github.com/repos/vrapio/rmf-codegen/contents/{+path}","compare_url":"https://api.github.com/repos/vrapio/rmf-codegen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vrapio/rmf-codegen/merges","archive_url":"https://api.github.com/repos/vrapio/rmf-codegen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vrapio/rmf-codegen/downloads","issues_url":"https://api.github.com/repos/vrapio/rmf-codegen/issues{/number}","pulls_url":"https://api.github.com/repos/vrapio/rmf-codegen/pulls{/number}","milestones_url":"https://api.github.com/repos/vrapio/rmf-codegen/milestones{/number}","notifications_url":"https://api.github.com/repos/vrapio/rmf-codegen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vrapio/rmf-codegen/labels{/name}","releases_url":"https://api.github.com/repos/vrapio/rmf-codegen/releases{/id}","deployments_url":"https://api.github.com/repos/vrapio/rmf-codegen/deployments","created_at":"2018-06-08T15:17:50Z","updated_at":"2018-07-30T21:45:33Z","pushed_at":"2018-08-03T14:38:18Z","git_url":"git://github.com/vrapio/rmf-codegen.git","ssh_url":"git@github.com:vrapio/rmf-codegen.git","clone_url":"https://github.com/vrapio/rmf-codegen.git","svn_url":"https://github.com/vrapio/rmf-codegen","homepage":"","size":213,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vrapio/rmf-codegen/pulls/18"},"html":{"href":"https://github.com/vrapio/rmf-codegen/pull/18"},"issue":{"href":"https://api.github.com/repos/vrapio/rmf-codegen/issues/18"},"comments":{"href":"https://api.github.com/repos/vrapio/rmf-codegen/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/vrapio/rmf-codegen/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/vrapio/rmf-codegen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vrapio/rmf-codegen/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/vrapio/rmf-codegen/statuses/adde29baecb678c9d1fd4eec4639a6b73bc18c53"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"katmatt"}}