{"action":"opened","number":8,"pull_request":{"url":"https://api.github.com/repos/stratumn/go-chainscript/pulls/8","id":205980696,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1OTgwNjk2","html_url":"https://github.com/stratumn/go-chainscript/pull/8","diff_url":"https://github.com/stratumn/go-chainscript/pull/8.diff","patch_url":"https://github.com/stratumn/go-chainscript/pull/8.patch","issue_url":"https://api.github.com/repos/stratumn/go-chainscript/issues/8","number":8,"state":"open","locked":false,"title":"link: signature","user":{"login":"t-bast","id":31281497,"node_id":"MDQ6VXNlcjMxMjgxNDk3","avatar_url":"https://avatars0.githubusercontent.com/u/31281497?v=4","gravatar_id":"","url":"https://api.github.com/users/t-bast","html_url":"https://github.com/t-bast","followers_url":"https://api.github.com/users/t-bast/followers","following_url":"https://api.github.com/users/t-bast/following{/other_user}","gists_url":"https://api.github.com/users/t-bast/gists{/gist_id}","starred_url":"https://api.github.com/users/t-bast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t-bast/subscriptions","organizations_url":"https://api.github.com/users/t-bast/orgs","repos_url":"https://api.github.com/users/t-bast/repos","events_url":"https://api.github.com/users/t-bast/events{/privacy}","received_events_url":"https://api.github.com/users/t-bast/received_events","type":"User","site_admin":false},"body":"Adding link signatures. Now go-chainscript should be at feature parity with what we have in go-indigocore so we can work on js-chainscript and then integrate into go-indigocore and js-indigocore (once go-crypto and js-crypto have a stable release though).\r\n\r\nNote that we lose the ability to sign only parts of the link.data or parts of the link.meta.data since it's only uninterpreted bytes and this library wants to be agnostic of its encoding (we can't eat our cake and have it too). \r\nSince only a few specific applications might really need to sign parts of the state, those applications should create their own signature that signs the link.data parts before it's encoded (because the application is the only place where the structure of the link.data is known). That means such an app needs to have its own ClientID for signature and link validation.\r\n\r\nOverall I think that managing different ClientID will be a bit of work (and headache sometimes) but it's the only way I see to provide backwards compatibility easily and allow flexibility to other applications that would need specific logic.","created_at":"2018-08-03T09:51:40Z","updated_at":"2018-08-03T09:51:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratumn/go-chainscript/pulls/8/commits","review_comments_url":"https://api.github.com/repos/stratumn/go-chainscript/pulls/8/comments","review_comment_url":"https://api.github.com/repos/stratumn/go-chainscript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratumn/go-chainscript/issues/8/comments","statuses_url":"https://api.github.com/repos/stratumn/go-chainscript/statuses/5377bca01544bdf6e7694db7b7bb9b17dbc876a3","head":{"label":"stratumn:bt/link/signature","ref":"bt/link/signature","sha":"5377bca01544bdf6e7694db7b7bb9b17dbc876a3","user":{"login":"stratumn","id":15095987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDk1OTg3","avatar_url":"https://avatars0.githubusercontent.com/u/15095987?v=4","gravatar_id":"","url":"https://api.github.com/users/stratumn","html_url":"https://github.com/stratumn","followers_url":"https://api.github.com/users/stratumn/followers","following_url":"https://api.github.com/users/stratumn/following{/other_user}","gists_url":"https://api.github.com/users/stratumn/gists{/gist_id}","starred_url":"https://api.github.com/users/stratumn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratumn/subscriptions","organizations_url":"https://api.github.com/users/stratumn/orgs","repos_url":"https://api.github.com/users/stratumn/repos","events_url":"https://api.github.com/users/stratumn/events{/privacy}","received_events_url":"https://api.github.com/users/stratumn/received_events","type":"Organization","site_admin":false},"repo":{"id":142893616,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI4OTM2MTY=","name":"go-chainscript","full_name":"stratumn/go-chainscript","owner":{"login":"stratumn","id":15095987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDk1OTg3","avatar_url":"https://avatars0.githubusercontent.com/u/15095987?v=4","gravatar_id":"","url":"https://api.github.com/users/stratumn","html_url":"https://github.com/stratumn","followers_url":"https://api.github.com/users/stratumn/followers","following_url":"https://api.github.com/users/stratumn/following{/other_user}","gists_url":"https://api.github.com/users/stratumn/gists{/gist_id}","starred_url":"https://api.github.com/users/stratumn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratumn/subscriptions","organizations_url":"https://api.github.com/users/stratumn/orgs","repos_url":"https://api.github.com/users/stratumn/repos","events_url":"https://api.github.com/users/stratumn/events{/privacy}","received_events_url":"https://api.github.com/users/stratumn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratumn/go-chainscript","description":"Official Go implementation of https://github.com/stratumn/chainscript. ","fork":false,"url":"https://api.github.com/repos/stratumn/go-chainscript","forks_url":"https://api.github.com/repos/stratumn/go-chainscript/forks","keys_url":"https://api.github.com/repos/stratumn/go-chainscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratumn/go-chainscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratumn/go-chainscript/teams","hooks_url":"https://api.github.com/repos/stratumn/go-chainscript/hooks","issue_events_url":"https://api.github.com/repos/stratumn/go-chainscript/issues/events{/number}","events_url":"https://api.github.com/repos/stratumn/go-chainscript/events","assignees_url":"https://api.github.com/repos/stratumn/go-chainscript/assignees{/user}","branches_url":"https://api.github.com/repos/stratumn/go-chainscript/branches{/branch}","tags_url":"https://api.github.com/repos/stratumn/go-chainscript/tags","blobs_url":"https://api.github.com/repos/stratumn/go-chainscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratumn/go-chainscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratumn/go-chainscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratumn/go-chainscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratumn/go-chainscript/statuses/{sha}","languages_url":"https://api.github.com/repos/stratumn/go-chainscript/languages","stargazers_url":"https://api.github.com/repos/stratumn/go-chainscript/stargazers","contributors_url":"https://api.github.com/repos/stratumn/go-chainscript/contributors","subscribers_url":"https://api.github.com/repos/stratumn/go-chainscript/subscribers","subscription_url":"https://api.github.com/repos/stratumn/go-chainscript/subscription","commits_url":"https://api.github.com/repos/stratumn/go-chainscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratumn/go-chainscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratumn/go-chainscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratumn/go-chainscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratumn/go-chainscript/contents/{+path}","compare_url":"https://api.github.com/repos/stratumn/go-chainscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratumn/go-chainscript/merges","archive_url":"https://api.github.com/repos/stratumn/go-chainscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratumn/go-chainscript/downloads","issues_url":"https://api.github.com/repos/stratumn/go-chainscript/issues{/number}","pulls_url":"https://api.github.com/repos/stratumn/go-chainscript/pulls{/number}","milestones_url":"https://api.github.com/repos/stratumn/go-chainscript/milestones{/number}","notifications_url":"https://api.github.com/repos/stratumn/go-chainscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratumn/go-chainscript/labels{/name}","releases_url":"https://api.github.com/repos/stratumn/go-chainscript/releases{/id}","deployments_url":"https://api.github.com/repos/stratumn/go-chainscript/deployments","created_at":"2018-07-30T15:22:07Z","updated_at":"2018-08-02T12:21:16Z","pushed_at":"2018-08-03T09:44:09Z","git_url":"git://github.com/stratumn/go-chainscript.git","ssh_url":"git@github.com:stratumn/go-chainscript.git","clone_url":"https://github.com/stratumn/go-chainscript.git","svn_url":"https://github.com/stratumn/go-chainscript","homepage":"","size":87,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"stratumn:master","ref":"master","sha":"61cc5418b04685cf8d56fde7d69ce787e32e745e","user":{"login":"stratumn","id":15095987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDk1OTg3","avatar_url":"https://avatars0.githubusercontent.com/u/15095987?v=4","gravatar_id":"","url":"https://api.github.com/users/stratumn","html_url":"https://github.com/stratumn","followers_url":"https://api.github.com/users/stratumn/followers","following_url":"https://api.github.com/users/stratumn/following{/other_user}","gists_url":"https://api.github.com/users/stratumn/gists{/gist_id}","starred_url":"https://api.github.com/users/stratumn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratumn/subscriptions","organizations_url":"https://api.github.com/users/stratumn/orgs","repos_url":"https://api.github.com/users/stratumn/repos","events_url":"https://api.github.com/users/stratumn/events{/privacy}","received_events_url":"https://api.github.com/users/stratumn/received_events","type":"Organization","site_admin":false},"repo":{"id":142893616,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI4OTM2MTY=","name":"go-chainscript","full_name":"stratumn/go-chainscript","owner":{"login":"stratumn","id":15095987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDk1OTg3","avatar_url":"https://avatars0.githubusercontent.com/u/15095987?v=4","gravatar_id":"","url":"https://api.github.com/users/stratumn","html_url":"https://github.com/stratumn","followers_url":"https://api.github.com/users/stratumn/followers","following_url":"https://api.github.com/users/stratumn/following{/other_user}","gists_url":"https://api.github.com/users/stratumn/gists{/gist_id}","starred_url":"https://api.github.com/users/stratumn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratumn/subscriptions","organizations_url":"https://api.github.com/users/stratumn/orgs","repos_url":"https://api.github.com/users/stratumn/repos","events_url":"https://api.github.com/users/stratumn/events{/privacy}","received_events_url":"https://api.github.com/users/stratumn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratumn/go-chainscript","description":"Official Go implementation of https://github.com/stratumn/chainscript. ","fork":false,"url":"https://api.github.com/repos/stratumn/go-chainscript","forks_url":"https://api.github.com/repos/stratumn/go-chainscript/forks","keys_url":"https://api.github.com/repos/stratumn/go-chainscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratumn/go-chainscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratumn/go-chainscript/teams","hooks_url":"https://api.github.com/repos/stratumn/go-chainscript/hooks","issue_events_url":"https://api.github.com/repos/stratumn/go-chainscript/issues/events{/number}","events_url":"https://api.github.com/repos/stratumn/go-chainscript/events","assignees_url":"https://api.github.com/repos/stratumn/go-chainscript/assignees{/user}","branches_url":"https://api.github.com/repos/stratumn/go-chainscript/branches{/branch}","tags_url":"https://api.github.com/repos/stratumn/go-chainscript/tags","blobs_url":"https://api.github.com/repos/stratumn/go-chainscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratumn/go-chainscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratumn/go-chainscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratumn/go-chainscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratumn/go-chainscript/statuses/{sha}","languages_url":"https://api.github.com/repos/stratumn/go-chainscript/languages","stargazers_url":"https://api.github.com/repos/stratumn/go-chainscript/stargazers","contributors_url":"https://api.github.com/repos/stratumn/go-chainscript/contributors","subscribers_url":"https://api.github.com/repos/stratumn/go-chainscript/subscribers","subscription_url":"https://api.github.com/repos/stratumn/go-chainscript/subscription","commits_url":"https://api.github.com/repos/stratumn/go-chainscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratumn/go-chainscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratumn/go-chainscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratumn/go-chainscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratumn/go-chainscript/contents/{+path}","compare_url":"https://api.github.com/repos/stratumn/go-chainscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratumn/go-chainscript/merges","archive_url":"https://api.github.com/repos/stratumn/go-chainscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratumn/go-chainscript/downloads","issues_url":"https://api.github.com/repos/stratumn/go-chainscript/issues{/number}","pulls_url":"https://api.github.com/repos/stratumn/go-chainscript/pulls{/number}","milestones_url":"https://api.github.com/repos/stratumn/go-chainscript/milestones{/number}","notifications_url":"https://api.github.com/repos/stratumn/go-chainscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratumn/go-chainscript/labels{/name}","releases_url":"https://api.github.com/repos/stratumn/go-chainscript/releases{/id}","deployments_url":"https://api.github.com/repos/stratumn/go-chainscript/deployments","created_at":"2018-07-30T15:22:07Z","updated_at":"2018-08-02T12:21:16Z","pushed_at":"2018-08-03T09:44:09Z","git_url":"git://github.com/stratumn/go-chainscript.git","ssh_url":"git@github.com:stratumn/go-chainscript.git","clone_url":"https://github.com/stratumn/go-chainscript.git","svn_url":"https://github.com/stratumn/go-chainscript","homepage":"","size":87,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratumn/go-chainscript/pulls/8"},"html":{"href":"https://github.com/stratumn/go-chainscript/pull/8"},"issue":{"href":"https://api.github.com/repos/stratumn/go-chainscript/issues/8"},"comments":{"href":"https://api.github.com/repos/stratumn/go-chainscript/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/stratumn/go-chainscript/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/stratumn/go-chainscript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratumn/go-chainscript/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/stratumn/go-chainscript/statuses/5377bca01544bdf6e7694db7b7bb9b17dbc876a3"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":696,"deletions":18,"changed_files":11}}
{"actor":{"display_login":"t-bast"}}