{"action":"closed","number":1786,"pull_request":{"url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1786","id":206663265,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NjYzMjY1","html_url":"https://github.com/wso2/carbon-identity-framework/pull/1786","diff_url":"https://github.com/wso2/carbon-identity-framework/pull/1786.diff","patch_url":"https://github.com/wso2/carbon-identity-framework/pull/1786.patch","issue_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/1786","number":1786,"state":"closed","locked":false,"title":"Store identity management confirmation codes directly into the database to improve the performance","user":{"login":"denuwanthi","id":1377917,"node_id":"MDQ6VXNlcjEzNzc5MTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1377917?v=4","gravatar_id":"","url":"https://api.github.com/users/denuwanthi","html_url":"https://github.com/denuwanthi","followers_url":"https://api.github.com/users/denuwanthi/followers","following_url":"https://api.github.com/users/denuwanthi/following{/other_user}","gists_url":"https://api.github.com/users/denuwanthi/gists{/gist_id}","starred_url":"https://api.github.com/users/denuwanthi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denuwanthi/subscriptions","organizations_url":"https://api.github.com/users/denuwanthi/orgs","repos_url":"https://api.github.com/users/denuwanthi/repos","events_url":"https://api.github.com/users/denuwanthi/events{/privacy}","received_events_url":"https://api.github.com/users/denuwanthi/received_events","type":"User","site_admin":false},"body":"### Proposed changes in this pull request\r\n\r\nResolves https://github.com/wso2/product-is/issues/3533\r\n\r\n### When should this PR be merged\r\n\r\n[Please describe any preconditions that need to be addressed before we\r\ncan merge this pull request.]\r\n\r\n\r\n### Follow up actions\r\n\r\n[List any possible follow-up actions here; for instance, testing data\r\nmigrations, software that we need to install on staging and production\r\nenvironments.]\r\n\r\n-\r\n\r\n\r\n### Checklist (for reviewing)\r\n\r\n#### General\r\n\r\n- [ ] **Is this PR explained thoroughly?** All code changes must be accounted for in the PR description.\r\n- [ ] **Is the PR labeled correctly?**\r\n\r\n#### Functionality\r\n\r\n- [ ] **Are all requirements met?** Compare implemented functionality with the requirements specification.\r\n- [ ] **Does the UI work as expected?** There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.\r\n\r\n#### Code\r\n\r\n- [ ] **Do you fully understand the introduced changes to the code?** If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.\r\n- [ ] **Does the PR introduce any inefficient database requests?** Use the debug server to check for duplicate requests.\r\n- [ ] **Are all necessary strings marked for translation?** All strings that are exposed to users via the UI must be [marked for translation](https://docs.djangoproject.com/en/1.10/topics/i18n/translation/).\r\n\r\n#### Tests\r\n\r\n- [ ] **Are there sufficient test cases?** Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.\r\n- [ ] **If this is a bug fix, are tests for the issue in place?**  There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.\r\n- [ ] **If this is a new feature or a significant change to an existing feature?** has the manual testing spreadsheet been updated with instructions for manual testing?\r\n\r\n#### Security\r\n\r\n- [ ] **Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.**\r\n- [ ] **Are all UI and API inputs run through forms or serializers?**\r\n- [ ] **Are all external inputs validated and sanitized appropriately?**\r\n- [ ] **Does all branching logic have a default case?**\r\n- [ ] **Does this solution handle outliers and edge cases gracefully?**\r\n- [ ] **Are all external communications secured and restricted to SSL?**\r\n\r\n#### Documentation\r\n\r\n- [ ] **Are changes to the UI documented in the platform docs?** If this PR introduces new platform site functionality or changes existing ones, the changes should be documented.\r\n- [ ] **Are changes to the API documented in the API docs?** If this PR introduces new API functionality or changes existing ones, the changes must be documented.\r\n- [ ] **Are reusable components documented?** If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.\r\n","created_at":"2018-08-07T11:16:06Z","updated_at":"2018-08-22T12:48:52Z","closed_at":"2018-08-22T12:48:52Z","merged_at":"2018-08-22T12:48:52Z","merge_commit_sha":"b11d11c20682ade9f9843e46fb6eea545119bb53","assignee":null,"assignees":[],"requested_reviewers":[{"login":"IsuraD","id":8455535,"node_id":"MDQ6VXNlcjg0NTU1MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/8455535?v=4","gravatar_id":"","url":"https://api.github.com/users/IsuraD","html_url":"https://github.com/IsuraD","followers_url":"https://api.github.com/users/IsuraD/followers","following_url":"https://api.github.com/users/IsuraD/following{/other_user}","gists_url":"https://api.github.com/users/IsuraD/gists{/gist_id}","starred_url":"https://api.github.com/users/IsuraD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IsuraD/subscriptions","organizations_url":"https://api.github.com/users/IsuraD/orgs","repos_url":"https://api.github.com/users/IsuraD/repos","events_url":"https://api.github.com/users/IsuraD/events{/privacy}","received_events_url":"https://api.github.com/users/IsuraD/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1786/commits","review_comments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1786/comments","review_comment_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/1786/comments","statuses_url":"https://api.github.com/repos/wso2/carbon-identity-framework/statuses/399b1ddbffc8147c7da4b03b852fa85fbf690b5d","head":{"label":"denuwanthi:denuwanthi-identity-mgt","ref":"denuwanthi-identity-mgt","sha":"399b1ddbffc8147c7da4b03b852fa85fbf690b5d","user":{"login":"denuwanthi","id":1377917,"node_id":"MDQ6VXNlcjEzNzc5MTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1377917?v=4","gravatar_id":"","url":"https://api.github.com/users/denuwanthi","html_url":"https://github.com/denuwanthi","followers_url":"https://api.github.com/users/denuwanthi/followers","following_url":"https://api.github.com/users/denuwanthi/following{/other_user}","gists_url":"https://api.github.com/users/denuwanthi/gists{/gist_id}","starred_url":"https://api.github.com/users/denuwanthi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denuwanthi/subscriptions","organizations_url":"https://api.github.com/users/denuwanthi/orgs","repos_url":"https://api.github.com/users/denuwanthi/repos","events_url":"https://api.github.com/users/denuwanthi/events{/privacy}","received_events_url":"https://api.github.com/users/denuwanthi/received_events","type":"User","site_admin":false},"repo":{"id":100379853,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAzNzk4NTM=","name":"carbon-identity-framework-1","full_name":"denuwanthi/carbon-identity-framework-1","owner":{"login":"denuwanthi","id":1377917,"node_id":"MDQ6VXNlcjEzNzc5MTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1377917?v=4","gravatar_id":"","url":"https://api.github.com/users/denuwanthi","html_url":"https://github.com/denuwanthi","followers_url":"https://api.github.com/users/denuwanthi/followers","following_url":"https://api.github.com/users/denuwanthi/following{/other_user}","gists_url":"https://api.github.com/users/denuwanthi/gists{/gist_id}","starred_url":"https://api.github.com/users/denuwanthi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denuwanthi/subscriptions","organizations_url":"https://api.github.com/users/denuwanthi/orgs","repos_url":"https://api.github.com/users/denuwanthi/repos","events_url":"https://api.github.com/users/denuwanthi/events{/privacy}","received_events_url":"https://api.github.com/users/denuwanthi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/denuwanthi/carbon-identity-framework-1","description":null,"fork":true,"url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1","forks_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/forks","keys_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/teams","hooks_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/hooks","issue_events_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/issues/events{/number}","events_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/events","assignees_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/assignees{/user}","branches_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/branches{/branch}","tags_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/tags","blobs_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/statuses/{sha}","languages_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/languages","stargazers_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/stargazers","contributors_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/contributors","subscribers_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/subscribers","subscription_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/subscription","commits_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/contents/{+path}","compare_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/merges","archive_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/downloads","issues_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/issues{/number}","pulls_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/pulls{/number}","milestones_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/milestones{/number}","notifications_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/labels{/name}","releases_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/releases{/id}","deployments_url":"https://api.github.com/repos/denuwanthi/carbon-identity-framework-1/deployments","created_at":"2017-08-15T13:25:25Z","updated_at":"2017-08-15T13:25:33Z","pushed_at":"2018-08-15T08:34:29Z","git_url":"git://github.com/denuwanthi/carbon-identity-framework-1.git","ssh_url":"git@github.com:denuwanthi/carbon-identity-framework-1.git","clone_url":"https://github.com/denuwanthi/carbon-identity-framework-1.git","svn_url":"https://github.com/denuwanthi/carbon-identity-framework-1","homepage":null,"size":119010,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"dda080ad9962d9f05c42e5fcd506125efd8198ea","user":{"login":"wso2","id":533043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzA0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":52329722,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMyOTcyMg==","name":"carbon-identity-framework","full_name":"wso2/carbon-identity-framework","owner":{"login":"wso2","id":533043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzA0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/carbon-identity-framework","description":null,"fork":false,"url":"https://api.github.com/repos/wso2/carbon-identity-framework","forks_url":"https://api.github.com/repos/wso2/carbon-identity-framework/forks","keys_url":"https://api.github.com/repos/wso2/carbon-identity-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/carbon-identity-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/carbon-identity-framework/teams","hooks_url":"https://api.github.com/repos/wso2/carbon-identity-framework/hooks","issue_events_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/carbon-identity-framework/events","assignees_url":"https://api.github.com/repos/wso2/carbon-identity-framework/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/carbon-identity-framework/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/carbon-identity-framework/tags","blobs_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/carbon-identity-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/carbon-identity-framework/languages","stargazers_url":"https://api.github.com/repos/wso2/carbon-identity-framework/stargazers","contributors_url":"https://api.github.com/repos/wso2/carbon-identity-framework/contributors","subscribers_url":"https://api.github.com/repos/wso2/carbon-identity-framework/subscribers","subscription_url":"https://api.github.com/repos/wso2/carbon-identity-framework/subscription","commits_url":"https://api.github.com/repos/wso2/carbon-identity-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/carbon-identity-framework/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/carbon-identity-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/carbon-identity-framework/merges","archive_url":"https://api.github.com/repos/wso2/carbon-identity-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/carbon-identity-framework/downloads","issues_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/carbon-identity-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/carbon-identity-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/carbon-identity-framework/labels{/name}","releases_url":"https://api.github.com/repos/wso2/carbon-identity-framework/releases{/id}","deployments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/deployments","created_at":"2016-02-23T04:20:26Z","updated_at":"2018-08-22T12:38:36Z","pushed_at":"2018-08-22T12:48:52Z","git_url":"git://github.com/wso2/carbon-identity-framework.git","ssh_url":"git@github.com:wso2/carbon-identity-framework.git","clone_url":"https://github.com/wso2/carbon-identity-framework.git","svn_url":"https://github.com/wso2/carbon-identity-framework","homepage":null,"size":120363,"stargazers_count":16,"watchers_count":16,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":201,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":201,"open_issues":38,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1786"},"html":{"href":"https://github.com/wso2/carbon-identity-framework/pull/1786"},"issue":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/1786"},"comments":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/1786/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1786/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1786/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/statuses/399b1ddbffc8147c7da4b03b852fa85fbf690b5d"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"thanujalk","id":1498339,"node_id":"MDQ6VXNlcjE0OTgzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1498339?v=4","gravatar_id":"","url":"https://api.github.com/users/thanujalk","html_url":"https://github.com/thanujalk","followers_url":"https://api.github.com/users/thanujalk/followers","following_url":"https://api.github.com/users/thanujalk/following{/other_user}","gists_url":"https://api.github.com/users/thanujalk/gists{/gist_id}","starred_url":"https://api.github.com/users/thanujalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thanujalk/subscriptions","organizations_url":"https://api.github.com/users/thanujalk/orgs","repos_url":"https://api.github.com/users/thanujalk/repos","events_url":"https://api.github.com/users/thanujalk/events{/privacy}","received_events_url":"https://api.github.com/users/thanujalk/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"maintainer_can_modify":false,"commits":2,"additions":80,"deletions":54,"changed_files":1}}
{"actor":{"display_login":"thanujalk"}}