{"action":"created","issue":{"url":"https://api.github.com/repos/contao/contao/issues/206","repository_url":"https://api.github.com/repos/contao/contao","labels_url":"https://api.github.com/repos/contao/contao/issues/206/labels{/name}","comments_url":"https://api.github.com/repos/contao/contao/issues/206/comments","events_url":"https://api.github.com/repos/contao/contao/issues/206/events","html_url":"https://github.com/contao/contao/pull/206","id":385408572,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0Mzg2MjY4","number":206,"title":"Fix for #169","user":{"login":"m-vo","id":5305677,"node_id":"MDQ6VXNlcjUzMDU2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/5305677?v=4","gravatar_id":"","url":"https://api.github.com/users/m-vo","html_url":"https://github.com/m-vo","followers_url":"https://api.github.com/users/m-vo/followers","following_url":"https://api.github.com/users/m-vo/following{/other_user}","gists_url":"https://api.github.com/users/m-vo/gists{/gist_id}","starred_url":"https://api.github.com/users/m-vo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-vo/subscriptions","organizations_url":"https://api.github.com/users/m-vo/orgs","repos_url":"https://api.github.com/users/m-vo/repos","events_url":"https://api.github.com/users/m-vo/events{/privacy}","received_events_url":"https://api.github.com/users/m-vo/received_events","type":"User","site_admin":false},"labels":[{"id":1028270354,"node_id":"MDU6TGFiZWwxMDI4MjcwMzU0","url":"https://api.github.com/repos/contao/contao/labels/defect","name":"defect","color":"bd2c00","default":false}],"state":"open","locked":false,"assignee":{"login":"m-vo","id":5305677,"node_id":"MDQ6VXNlcjUzMDU2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/5305677?v=4","gravatar_id":"","url":"https://api.github.com/users/m-vo","html_url":"https://github.com/m-vo","followers_url":"https://api.github.com/users/m-vo/followers","following_url":"https://api.github.com/users/m-vo/following{/other_user}","gists_url":"https://api.github.com/users/m-vo/gists{/gist_id}","starred_url":"https://api.github.com/users/m-vo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-vo/subscriptions","organizations_url":"https://api.github.com/users/m-vo/orgs","repos_url":"https://api.github.com/users/m-vo/repos","events_url":"https://api.github.com/users/m-vo/events{/privacy}","received_events_url":"https://api.github.com/users/m-vo/received_events","type":"User","site_admin":false},"assignees":[{"login":"m-vo","id":5305677,"node_id":"MDQ6VXNlcjUzMDU2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/5305677?v=4","gravatar_id":"","url":"https://api.github.com/users/m-vo","html_url":"https://github.com/m-vo","followers_url":"https://api.github.com/users/m-vo/followers","following_url":"https://api.github.com/users/m-vo/following{/other_user}","gists_url":"https://api.github.com/users/m-vo/gists{/gist_id}","starred_url":"https://api.github.com/users/m-vo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-vo/subscriptions","organizations_url":"https://api.github.com/users/m-vo/orgs","repos_url":"https://api.github.com/users/m-vo/repos","events_url":"https://api.github.com/users/m-vo/events{/privacy}","received_events_url":"https://api.github.com/users/m-vo/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/contao/contao/milestones/2","html_url":"https://github.com/contao/contao/milestone/2","labels_url":"https://api.github.com/repos/contao/contao/milestones/2/labels","id":3583777,"node_id":"MDk6TWlsZXN0b25lMzU4Mzc3Nw==","number":2,"title":"4.7.0","description":"","creator":{"login":"leofeyer","id":1192057,"node_id":"MDQ6VXNlcjExOTIwNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1192057?v=4","gravatar_id":"","url":"https://api.github.com/users/leofeyer","html_url":"https://github.com/leofeyer","followers_url":"https://api.github.com/users/leofeyer/followers","following_url":"https://api.github.com/users/leofeyer/following{/other_user}","gists_url":"https://api.github.com/users/leofeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/leofeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leofeyer/subscriptions","organizations_url":"https://api.github.com/users/leofeyer/orgs","repos_url":"https://api.github.com/users/leofeyer/repos","events_url":"https://api.github.com/users/leofeyer/events{/privacy}","received_events_url":"https://api.github.com/users/leofeyer/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":25,"state":"open","created_at":"2018-08-20T14:28:40Z","updated_at":"2018-11-29T10:29:28Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-11-28T18:50:14Z","updated_at":"2018-11-29T10:45:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/contao/contao/pulls/206","html_url":"https://github.com/contao/contao/pull/206","diff_url":"https://github.com/contao/contao/pull/206.diff","patch_url":"https://github.com/contao/contao/pull/206.patch"},"body":"Followup to #169 \r\n\r\nNow commands in `checkEngineAndCollation()` are also tracked.\r\n\r\nQuick note: These lines...\r\nhttps://github.com/contao/contao/blob/0670398703691e33dafb18842ec67460a50e4a1e/installation-bundle/src/Database/Installer.php#L273-L275\r\n... probably make sure there are no duplicates shown in the GUI. However, we need the first entry for the correct order. I am therefore adding all hashes no matter what and later calling `array_unique` on the order array to ensure only the first entries are kept."},"comment":{"url":"https://api.github.com/repos/contao/contao/issues/comments/442788797","html_url":"https://github.com/contao/contao/pull/206#issuecomment-442788797","issue_url":"https://api.github.com/repos/contao/contao/issues/206","id":442788797,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Mjc4ODc5Nw==","user":{"login":"leofeyer","id":1192057,"node_id":"MDQ6VXNlcjExOTIwNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1192057?v=4","gravatar_id":"","url":"https://api.github.com/users/leofeyer","html_url":"https://github.com/leofeyer","followers_url":"https://api.github.com/users/leofeyer/followers","following_url":"https://api.github.com/users/leofeyer/following{/other_user}","gists_url":"https://api.github.com/users/leofeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/leofeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leofeyer/subscriptions","organizations_url":"https://api.github.com/users/leofeyer/orgs","repos_url":"https://api.github.com/users/leofeyer/repos","events_url":"https://api.github.com/users/leofeyer/events{/privacy}","received_events_url":"https://api.github.com/users/leofeyer/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T10:45:16Z","updated_at":"2018-11-29T10:45:16Z","author_association":"MEMBER","body":"The problem is that the original order tries to add the index before the collation of the table has changed. And if we try to prepend the `checkEngineAndCollation()` hashes so they are executed first, the install tool will try to change the collation before the indexes have been removed.\r\n\r\n<img width=\"1012\" alt=\"\" src=\"https://user-images.githubusercontent.com/1192057/49216792-31d94280-f3cc-11e8-8978-4baf0c67a8e3.png\">\r\n\r\nSo I guess we have to revert the changes all together."}}
{"actor":{"display_login":"leofeyer"}}