{"action":"closed","number":6122,"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/6122","id":178475260,"html_url":"https://github.com/pytorch/pytorch/pull/6122","diff_url":"https://github.com/pytorch/pytorch/pull/6122.diff","patch_url":"https://github.com/pytorch/pytorch/pull/6122.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/6122","number":6122,"state":"closed","locked":false,"title":"Add REL_WITH_DEB_INFO build mode","user":{"login":"goldsborough","id":6429851,"avatar_url":"https://avatars3.githubusercontent.com/u/6429851?v=4","gravatar_id":"","url":"https://api.github.com/users/goldsborough","html_url":"https://github.com/goldsborough","followers_url":"https://api.github.com/users/goldsborough/followers","following_url":"https://api.github.com/users/goldsborough/following{/other_user}","gists_url":"https://api.github.com/users/goldsborough/gists{/gist_id}","starred_url":"https://api.github.com/users/goldsborough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldsborough/subscriptions","organizations_url":"https://api.github.com/users/goldsborough/orgs","repos_url":"https://api.github.com/users/goldsborough/repos","events_url":"https://api.github.com/users/goldsborough/events{/privacy}","received_events_url":"https://api.github.com/users/goldsborough/received_events","type":"User","site_admin":false},"body":"Small PR to allow use of `RelWithDebInfo` mode in CMake as per request from @ebetica, to make debugging in optimized binaries easier (i.e. don't have to suffer major decrease in performance when using `DEBUG` mode, but can still debug properly, not like in `RELEASE` mode).\r\n\r\nFrom what I can see using `RelWithDebInfo` means `-O2 -g -DNDEBUG` while `Release` means `-O3`.\r\n\r\nnormal (release):\r\n```\r\n$ python setup.py build develop\r\n$ grep -e' -fexceptions ' aten/build/build.ninja\r\nFLAGS = -DUSE_AVX2 -msse3 -DUSE_SSE3 --std=c++11 -Wall -Wno-unknown-pragmas -Wno-vla -fexceptions  -fopenmp -O3\r\n```\r\n\r\nThis PR allows use of the `REL_WITH_DEB_INFO` environment variable:\r\n\r\n```\r\n$ REL_WITH_DEB_INFO=1 python setup.py build develop\r\n$ grep -e' -fexceptions ' aten/build/build.ninja\r\nFLAGS = -DUSE_AVX2   -DUSE_SSE3 --std=c++11 -Wall -Wno-unknown-pragmas -Wno-vla -fexceptions  -O2 -g -DNDEBUG\r\n```\r\n\r\n@ezyang @ebetica ","created_at":"2018-03-30T01:08:20Z","updated_at":"2018-03-30T19:18:49Z","closed_at":"2018-03-30T19:18:49Z","merged_at":"2018-03-30T19:18:48Z","merge_commit_sha":"3d3b62e2d6407e54f6993e7c56ea856a326f98b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/6122/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/6122/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/6122/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/7a2d03b7e9ab356be21202b614940da983182699","head":{"label":"goldsborough:rel-with-deb-info","ref":"rel-with-deb-info","sha":"7a2d03b7e9ab356be21202b614940da983182699","user":{"login":"goldsborough","id":6429851,"avatar_url":"https://avatars3.githubusercontent.com/u/6429851?v=4","gravatar_id":"","url":"https://api.github.com/users/goldsborough","html_url":"https://github.com/goldsborough","followers_url":"https://api.github.com/users/goldsborough/followers","following_url":"https://api.github.com/users/goldsborough/following{/other_user}","gists_url":"https://api.github.com/users/goldsborough/gists{/gist_id}","starred_url":"https://api.github.com/users/goldsborough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldsborough/subscriptions","organizations_url":"https://api.github.com/users/goldsborough/orgs","repos_url":"https://api.github.com/users/goldsborough/repos","events_url":"https://api.github.com/users/goldsborough/events{/privacy}","received_events_url":"https://api.github.com/users/goldsborough/received_events","type":"User","site_admin":false},"repo":{"id":115096378,"name":"pytorch","full_name":"goldsborough/pytorch","owner":{"login":"goldsborough","id":6429851,"avatar_url":"https://avatars3.githubusercontent.com/u/6429851?v=4","gravatar_id":"","url":"https://api.github.com/users/goldsborough","html_url":"https://github.com/goldsborough","followers_url":"https://api.github.com/users/goldsborough/followers","following_url":"https://api.github.com/users/goldsborough/following{/other_user}","gists_url":"https://api.github.com/users/goldsborough/gists{/gist_id}","starred_url":"https://api.github.com/users/goldsborough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldsborough/subscriptions","organizations_url":"https://api.github.com/users/goldsborough/orgs","repos_url":"https://api.github.com/users/goldsborough/repos","events_url":"https://api.github.com/users/goldsborough/events{/privacy}","received_events_url":"https://api.github.com/users/goldsborough/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goldsborough/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/goldsborough/pytorch","forks_url":"https://api.github.com/repos/goldsborough/pytorch/forks","keys_url":"https://api.github.com/repos/goldsborough/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goldsborough/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goldsborough/pytorch/teams","hooks_url":"https://api.github.com/repos/goldsborough/pytorch/hooks","issue_events_url":"https://api.github.com/repos/goldsborough/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/goldsborough/pytorch/events","assignees_url":"https://api.github.com/repos/goldsborough/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/goldsborough/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/goldsborough/pytorch/tags","blobs_url":"https://api.github.com/repos/goldsborough/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goldsborough/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goldsborough/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/goldsborough/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goldsborough/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/goldsborough/pytorch/languages","stargazers_url":"https://api.github.com/repos/goldsborough/pytorch/stargazers","contributors_url":"https://api.github.com/repos/goldsborough/pytorch/contributors","subscribers_url":"https://api.github.com/repos/goldsborough/pytorch/subscribers","subscription_url":"https://api.github.com/repos/goldsborough/pytorch/subscription","commits_url":"https://api.github.com/repos/goldsborough/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/goldsborough/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/goldsborough/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/goldsborough/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/goldsborough/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/goldsborough/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goldsborough/pytorch/merges","archive_url":"https://api.github.com/repos/goldsborough/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goldsborough/pytorch/downloads","issues_url":"https://api.github.com/repos/goldsborough/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/goldsborough/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/goldsborough/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/goldsborough/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goldsborough/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/goldsborough/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/goldsborough/pytorch/deployments","created_at":"2017-12-22T08:49:57Z","updated_at":"2018-03-29T23:23:23Z","pushed_at":"2018-03-30T01:10:39Z","git_url":"git://github.com/goldsborough/pytorch.git","ssh_url":"git@github.com:goldsborough/pytorch.git","clone_url":"https://github.com/goldsborough/pytorch.git","svn_url":"https://github.com/goldsborough/pytorch","homepage":"http://pytorch.org","size":25983,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"f8270c0225e19403038aec2d8af2697a2b5326ec","user":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"name":"pytorch","full_name":"pytorch/pytorch","owner":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-03-30T19:03:47Z","pushed_at":"2018-03-30T19:18:49Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":48498,"stargazers_count":13377,"watchers_count":13377,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2880,"mirror_url":null,"archived":false,"open_issues_count":860,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2880,"open_issues":860,"watchers":13377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/6122"},"html":{"href":"https://github.com/pytorch/pytorch/pull/6122"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/6122"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/6122/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/6122/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/6122/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/7a2d03b7e9ab356be21202b614940da983182699"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ezyang","id":13564,"avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":15,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"ezyang"}}