{"action":"created","issue":{"url":"https://api.github.com/repos/samvera/hyrax/issues/2917","repository_url":"https://api.github.com/repos/samvera/hyrax","labels_url":"https://api.github.com/repos/samvera/hyrax/issues/2917/labels{/name}","comments_url":"https://api.github.com/repos/samvera/hyrax/issues/2917/comments","events_url":"https://api.github.com/repos/samvera/hyrax/issues/2917/events","html_url":"https://github.com/samvera/hyrax/issues/2917","id":313873548,"number":2917,"title":"Pagination for Modal popup in the facets. Facets -> more","user":{"login":"straleyb","id":6424683,"avatar_url":"https://avatars1.githubusercontent.com/u/6424683?v=4","gravatar_id":"","url":"https://api.github.com/users/straleyb","html_url":"https://github.com/straleyb","followers_url":"https://api.github.com/users/straleyb/followers","following_url":"https://api.github.com/users/straleyb/following{/other_user}","gists_url":"https://api.github.com/users/straleyb/gists{/gist_id}","starred_url":"https://api.github.com/users/straleyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/straleyb/subscriptions","organizations_url":"https://api.github.com/users/straleyb/orgs","repos_url":"https://api.github.com/users/straleyb/repos","events_url":"https://api.github.com/users/straleyb/events{/privacy}","received_events_url":"https://api.github.com/users/straleyb/received_events","type":"User","site_admin":false},"labels":[{"id":491302916,"url":"https://api.github.com/repos/samvera/hyrax/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":505053957,"url":"https://api.github.com/repos/samvera/hyrax/labels/feedback%20needed","name":"feedback needed","color":"8DC2BC","default":false},{"id":491302922,"url":"https://api.github.com/repos/samvera/hyrax/labels/question","name":"question","color":"cc317c","default":true},{"id":505053950,"url":"https://api.github.com/repos/samvera/hyrax/labels/user%20interface","name":"user interface","color":"02e10c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/samvera/hyrax/milestones/1","html_url":"https://github.com/samvera/hyrax/milestone/1","labels_url":"https://api.github.com/repos/samvera/hyrax/milestones/1/labels","id":2210731,"number":1,"title":"Backlog","description":"","creator":{"login":"mjgiarlo","id":131982,"avatar_url":"https://avatars0.githubusercontent.com/u/131982?v=4","gravatar_id":"","url":"https://api.github.com/users/mjgiarlo","html_url":"https://github.com/mjgiarlo","followers_url":"https://api.github.com/users/mjgiarlo/followers","following_url":"https://api.github.com/users/mjgiarlo/following{/other_user}","gists_url":"https://api.github.com/users/mjgiarlo/gists{/gist_id}","starred_url":"https://api.github.com/users/mjgiarlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjgiarlo/subscriptions","organizations_url":"https://api.github.com/users/mjgiarlo/orgs","repos_url":"https://api.github.com/users/mjgiarlo/repos","events_url":"https://api.github.com/users/mjgiarlo/events{/privacy}","received_events_url":"https://api.github.com/users/mjgiarlo/received_events","type":"User","site_admin":false},"open_issues":276,"closed_issues":104,"state":"open","created_at":"2016-12-21T19:45:35Z","updated_at":"2018-04-13T00:09:07Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-04-12T20:20:45Z","updated_at":"2018-04-13T06:51:03Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"This is simply a proposition for a piece of functionality that seemed to be incomplete in hyrax. Currently on the modal popup for the facets \"more\", it shows the previous and next links, but thats it. After these facet lists get to be too long (10,000 creators for example), going through these pages can be a pain in the behind going through one at a time. Ive created a PR here https://github.com/osulp/Scholars-Archive/pull/1326 which aims to solve this problem. This is a first step and a proposed fix for this issue. It can be enhanced or expanded to skip 10 pages, 50 pages, 100 pages. Or whatever is deemed necessary for shuffling through 10's of thousands of records on this page. \r\n\r\nThe kicker was maintaining the `data-ajax-modal=\"preserve\"` data attribute in the list elements (which is from my understanding, difficult to retain using Kaminari's (https://github.com/kaminari/kaminari) paginate base code. So custom code was written to handle the logic of rendering x number of pages before and after the current page, checking the first and last page, disabling buttons when needed, etc. \r\n\r\nId like feedback on this feature and what it may take to get this into a form acceptable for hyrax. \r\n\r\n@mjgiarlo @jcoyne Feel free to tag anyone else who would be good with talking about this issue. \r\n\r\n![paginate](https://user-images.githubusercontent.com/6424683/38701976-34083404-3e54-11e8-940c-84d270bbc55a.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/samvera/hyrax/issues/comments/381041273","html_url":"https://github.com/samvera/hyrax/issues/2917#issuecomment-381041273","issue_url":"https://api.github.com/repos/samvera/hyrax/issues/2917","id":381041273,"user":{"login":"mjgiarlo","id":131982,"avatar_url":"https://avatars0.githubusercontent.com/u/131982?v=4","gravatar_id":"","url":"https://api.github.com/users/mjgiarlo","html_url":"https://github.com/mjgiarlo","followers_url":"https://api.github.com/users/mjgiarlo/followers","following_url":"https://api.github.com/users/mjgiarlo/following{/other_user}","gists_url":"https://api.github.com/users/mjgiarlo/gists{/gist_id}","starred_url":"https://api.github.com/users/mjgiarlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjgiarlo/subscriptions","organizations_url":"https://api.github.com/users/mjgiarlo/orgs","repos_url":"https://api.github.com/users/mjgiarlo/repos","events_url":"https://api.github.com/users/mjgiarlo/events{/privacy}","received_events_url":"https://api.github.com/users/mjgiarlo/received_events","type":"User","site_admin":false},"created_at":"2018-04-13T06:51:03Z","updated_at":"2018-04-13T06:51:03Z","author_association":"OWNER","body":"Tagging in @samvera/hyrax-code-reviewers "}}
{"actor":{"display_login":"mjgiarlo"}}