{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/flow/issues/3685","repository_url":"https://api.github.com/repos/vaadin/flow","labels_url":"https://api.github.com/repos/vaadin/flow/issues/3685/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/flow/issues/3685/comments","events_url":"https://api.github.com/repos/vaadin/flow/issues/3685/events","html_url":"https://github.com/vaadin/flow/pull/3685","id":304013340,"number":3685,"title":"Add support for ValueChangeMode.ON_CHANGE","user":{"login":"marcushellberg","id":883698,"avatar_url":"https://avatars3.githubusercontent.com/u/883698?v=4","gravatar_id":"","url":"https://api.github.com/users/marcushellberg","html_url":"https://github.com/marcushellberg","followers_url":"https://api.github.com/users/marcushellberg/followers","following_url":"https://api.github.com/users/marcushellberg/following{/other_user}","gists_url":"https://api.github.com/users/marcushellberg/gists{/gist_id}","starred_url":"https://api.github.com/users/marcushellberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcushellberg/subscriptions","organizations_url":"https://api.github.com/users/marcushellberg/orgs","repos_url":"https://api.github.com/users/marcushellberg/repos","events_url":"https://api.github.com/users/marcushellberg/events{/privacy}","received_events_url":"https://api.github.com/users/marcushellberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-09T23:33:09Z","updated_at":"2018-03-10T11:09:22Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/vaadin/flow/pulls/3685","html_url":"https://github.com/vaadin/flow/pull/3685","diff_url":"https://github.com/vaadin/flow/pull/3685.diff","patch_url":"https://github.com/vaadin/flow/pull/3685.patch"},"body":"Fix https://github.com/vaadin/vaadin-text-field-flow/issues/55\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/flow/3685)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/flow/issues/comments/372021882","html_url":"https://github.com/vaadin/flow/pull/3685#issuecomment-372021882","issue_url":"https://api.github.com/repos/vaadin/flow/issues/3685","id":372021882,"user":{"login":"pleku","id":1478381,"avatar_url":"https://avatars1.githubusercontent.com/u/1478381?v=4","gravatar_id":"","url":"https://api.github.com/users/pleku","html_url":"https://github.com/pleku","followers_url":"https://api.github.com/users/pleku/followers","following_url":"https://api.github.com/users/pleku/following{/other_user}","gists_url":"https://api.github.com/users/pleku/gists{/gist_id}","starred_url":"https://api.github.com/users/pleku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleku/subscriptions","organizations_url":"https://api.github.com/users/pleku/orgs","repos_url":"https://api.github.com/users/pleku/repos","events_url":"https://api.github.com/users/pleku/events{/privacy}","received_events_url":"https://api.github.com/users/pleku/received_events","type":"User","site_admin":false},"created_at":"2018-03-10T11:09:22Z","updated_at":"2018-03-10T11:09:22Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReviewed 2 of 2 files at r1.\nReview status: all files reviewed at latest revision, all discussions resolved.\n\n---\n\n*[flow-data/src/main/java/com/vaadin/flow/data/value/HasValueChangeMode.java, line 55 at r1](https://beta.reviewable.io/reviews/vaadin/flow/3685#-L7EaHcGArRQvRWP7ocm:-L7EaHcGArRQvRWP7ocn:bluxf6r) ([raw file](https://github.com/vaadin/flow/blob/6698e12ded2758e5ec89e8724bd10cb9c566f49e/flow-data/src/main/java/com/vaadin/flow/data/value/HasValueChangeMode.java#L55)):*\n> ```Java\n>      *            new value change mode, not {@code null}\n>      */\n>     default void setValueChangeMode(ValueChangeMode valueChangeMode) {\n> ```\n\nIt seems to me we should add a unit test to verify this methods logic, so that nobody accidentally breaks things. But we can do that (not blocking) \n\n---\n\n*[flow-data/src/main/java/com/vaadin/flow/data/value/HasValueChangeMode.java, line 61 at r1](https://beta.reviewable.io/reviews/vaadin/flow/3685#-L7E_LSDAz_LZesnRW1w:-L7E_LSDAz_LZesnRW1x:bow1q0b) ([raw file](https://github.com/vaadin/flow/blob/6698e12ded2758e5ec89e8724bd10cb9c566f49e/flow-data/src/main/java/com/vaadin/flow/data/value/HasValueChangeMode.java#L61)):*\n>  element.removeSynchronizedPropertyEvent(\"blur\");\n\nThis line should be extracted to outside the switch-case and should use `getClientPropertyChangeEventName()`. Now after adding a third option, this would be broken.\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/vaadin/flow/3685)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"pleku"}}