{"action":"opened","number":48730,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/48730","id":231252369,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjUyMzY5","html_url":"https://github.com/ansible/ansible/pull/48730","diff_url":"https://github.com/ansible/ansible/pull/48730.diff","patch_url":"https://github.com/ansible/ansible/pull/48730.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/48730","number":48730,"state":"open","locked":false,"title":"Fixed support for LLD type user macros and added missing validate_cer…","user":{"login":"D3DeFi","id":9269600,"node_id":"MDQ6VXNlcjkyNjk2MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/9269600?v=4","gravatar_id":"","url":"https://api.github.com/users/D3DeFi","html_url":"https://github.com/D3DeFi","followers_url":"https://api.github.com/users/D3DeFi/followers","following_url":"https://api.github.com/users/D3DeFi/following{/other_user}","gists_url":"https://api.github.com/users/D3DeFi/gists{/gist_id}","starred_url":"https://api.github.com/users/D3DeFi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D3DeFi/subscriptions","organizations_url":"https://api.github.com/users/D3DeFi/orgs","repos_url":"https://api.github.com/users/D3DeFi/repos","events_url":"https://api.github.com/users/D3DeFi/events{/privacy}","received_events_url":"https://api.github.com/users/D3DeFi/received_events","type":"User","site_admin":false},"body":"…ts attribute\r\n\r\n##### SUMMARY\r\nFixes #46953 #47611\r\n\r\n* due to module converting whole `macro_name` to upper space characters, LLD type macros ended up being created wrong (e.g. `LOW_SPACE_LIMIT:/home` was converted to `LOW_SPACE_LIMIT:/HOME`). Credits to @HampusLundqvist for proposed changes\r\n\r\n* module didn't properly implement `validate_certs` option, attribute was never passed to ZabbixAPI object, thus not allowing SSL connections to be made with untrusted certificates. Credits to @tifennlegoff\r\n\r\n* some minor grammar fixes\r\n\r\n##### ISSUE TYPE\r\n- Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\nzabbix_hostmacro.py\r\n\r\n##### ADDITIONAL INFORMATION\r\nUser macros in zabbix are using same syntax as [trigger expressions](https://www.zabbix.com/documentation/3.0/manual/config/triggers/expression), thus it is fairly safe to assume that there will be just one colon present in the expression when using `.split()`.\r\n\r\nTested against all LTS releases of zabbix-server (2.2, 3.0, 4.0).","created_at":"2018-11-15T16:16:54Z","updated_at":"2018-11-15T16:16:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/48730/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/48730/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/48730/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/7af8c0e07e9da01ad0a05631c6094e62532fb21e","head":{"label":"D3DeFi:zbx_macros_lld_fix","ref":"zbx_macros_lld_fix","sha":"7af8c0e07e9da01ad0a05631c6094e62532fb21e","user":{"login":"D3DeFi","id":9269600,"node_id":"MDQ6VXNlcjkyNjk2MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/9269600?v=4","gravatar_id":"","url":"https://api.github.com/users/D3DeFi","html_url":"https://github.com/D3DeFi","followers_url":"https://api.github.com/users/D3DeFi/followers","following_url":"https://api.github.com/users/D3DeFi/following{/other_user}","gists_url":"https://api.github.com/users/D3DeFi/gists{/gist_id}","starred_url":"https://api.github.com/users/D3DeFi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D3DeFi/subscriptions","organizations_url":"https://api.github.com/users/D3DeFi/orgs","repos_url":"https://api.github.com/users/D3DeFi/repos","events_url":"https://api.github.com/users/D3DeFi/events{/privacy}","received_events_url":"https://api.github.com/users/D3DeFi/received_events","type":"User","site_admin":false},"repo":{"id":84920171,"node_id":"MDEwOlJlcG9zaXRvcnk4NDkyMDE3MQ==","name":"ansible","full_name":"D3DeFi/ansible","private":false,"owner":{"login":"D3DeFi","id":9269600,"node_id":"MDQ6VXNlcjkyNjk2MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/9269600?v=4","gravatar_id":"","url":"https://api.github.com/users/D3DeFi","html_url":"https://github.com/D3DeFi","followers_url":"https://api.github.com/users/D3DeFi/followers","following_url":"https://api.github.com/users/D3DeFi/following{/other_user}","gists_url":"https://api.github.com/users/D3DeFi/gists{/gist_id}","starred_url":"https://api.github.com/users/D3DeFi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D3DeFi/subscriptions","organizations_url":"https://api.github.com/users/D3DeFi/orgs","repos_url":"https://api.github.com/users/D3DeFi/repos","events_url":"https://api.github.com/users/D3DeFi/events{/privacy}","received_events_url":"https://api.github.com/users/D3DeFi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/D3DeFi/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/D3DeFi/ansible","forks_url":"https://api.github.com/repos/D3DeFi/ansible/forks","keys_url":"https://api.github.com/repos/D3DeFi/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D3DeFi/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D3DeFi/ansible/teams","hooks_url":"https://api.github.com/repos/D3DeFi/ansible/hooks","issue_events_url":"https://api.github.com/repos/D3DeFi/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/D3DeFi/ansible/events","assignees_url":"https://api.github.com/repos/D3DeFi/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/D3DeFi/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/D3DeFi/ansible/tags","blobs_url":"https://api.github.com/repos/D3DeFi/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D3DeFi/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D3DeFi/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/D3DeFi/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D3DeFi/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/D3DeFi/ansible/languages","stargazers_url":"https://api.github.com/repos/D3DeFi/ansible/stargazers","contributors_url":"https://api.github.com/repos/D3DeFi/ansible/contributors","subscribers_url":"https://api.github.com/repos/D3DeFi/ansible/subscribers","subscription_url":"https://api.github.com/repos/D3DeFi/ansible/subscription","commits_url":"https://api.github.com/repos/D3DeFi/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/D3DeFi/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/D3DeFi/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/D3DeFi/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/D3DeFi/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/D3DeFi/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D3DeFi/ansible/merges","archive_url":"https://api.github.com/repos/D3DeFi/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D3DeFi/ansible/downloads","issues_url":"https://api.github.com/repos/D3DeFi/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/D3DeFi/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/D3DeFi/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/D3DeFi/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D3DeFi/ansible/labels{/name}","releases_url":"https://api.github.com/repos/D3DeFi/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/D3DeFi/ansible/deployments","created_at":"2017-03-14T07:43:57Z","updated_at":"2018-11-15T15:57:55Z","pushed_at":"2018-11-15T16:00:45Z","git_url":"git://github.com/D3DeFi/ansible.git","ssh_url":"git@github.com:D3DeFi/ansible.git","clone_url":"https://github.com/D3DeFi/ansible.git","svn_url":"https://github.com/D3DeFi/ansible","homepage":"http://ansible.com/","size":139900,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"f0c290c930744b20e6d926dcf5dba1fcca57e404","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","private":false,"owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-11-15T15:55:42Z","pushed_at":"2018-11-15T16:11:20Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":144978,"stargazers_count":33762,"watchers_count":33762,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13473,"mirror_url":null,"archived":false,"open_issues_count":5612,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":13473,"open_issues":5612,"watchers":33762,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/48730"},"html":{"href":"https://github.com/ansible/ansible/pull/48730"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/48730"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/48730/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/48730/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/48730/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/7af8c0e07e9da01ad0a05631c6094e62532fb21e"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":12,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"D3DeFi"}}