{"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-server/pulls/comments/199461243","pull_request_review_id":133582493,"id":199461243,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTQ2MTI0Mw==","diff_hunk":"@@ -0,0 +1,101 @@\n+name:          spar\n+version:       '0.1'\n+synopsis:      'User Service for SSO provisioning and authentication.'\n+author:        Wire Swiss GmbH\n+maintainer:    Wire Swiss GmbH <backend@wire.com>\n+copyright:     (c) 2018 Wire Swiss GmbH\n+license:       AGPL-3\n+license-file:  LICENSE\n+category:      System\n+description:   'See README.md'\n+\n+ghc-options: -j -O2 -Wall -Wno-redundant-constraints -fwarn-tabs -Werror\n+\n+dependencies:\n+  - aeson\n+  - aeson-pretty\n+  - aeson-qq\n+  - base\n+  - bilge\n+  - binary\n+  - brig-types\n+  - bytestring\n+  - bytestring-conversion\n+  - cassandra-util\n+  - containers\n+  - cookie\n+  - errors\n+  - exceptions  # (for MonadClient, which in turn needs MonadCatch)\n+  - ghc-prim\n+  - http-client\n+  - http-types\n+  - metrics-core\n+  - microlens\n+  - microlens-th\n+  - mtl\n+  - optparse-applicative\n+  - raw-strings-qq\n+  - saml2-web-sso\n+  - scientific\n+  - servant\n+  - servant-multipart\n+  - servant-server\n+  - servant-swagger\n+  - string-conversions\n+  - swagger2\n+  - text\n+  - time\n+  - tinylog\n+  - transformers\n+  - types-common\n+  - uri-bytestring\n+  - uuid\n+  - wai-utilities\n+  - warp\n+  - x509\n+  - yaml\n+\n+library:\n+  source-dirs:\n+    - src\n+\n+tests:\n+  spec:\n+    main: Spec.hs\n+    source-dirs:\n+      - test\n+    ghc-options: -threaded -rtsopts -with-rtsopts=-N\n+    dependencies:\n+      - hspec\n+      - hspec-discover\n+      - QuickCheck\n+      - spar\n+      - uri-bytestring\n+\n+executables:\n+  spar:\n+    main: Main.hs\n+    source-dirs: exec\n+    ghc-options: -threaded -rtsopts -with-rtsopts=-N","path":"services/spar/package.yaml","position":79,"original_position":79,"commit_id":"1efe77745d3ef61b606530a4adba706e85e74db0","original_commit_id":"f9de4cd3d68b83b10fe40f0158f8b291812cd1b0","user":{"login":"fisx","id":10210727,"node_id":"MDQ6VXNlcjEwMjEwNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/10210727?v=4","gravatar_id":"","url":"https://api.github.com/users/fisx","html_url":"https://github.com/fisx","followers_url":"https://api.github.com/users/fisx/followers","following_url":"https://api.github.com/users/fisx/following{/other_user}","gists_url":"https://api.github.com/users/fisx/gists{/gist_id}","starred_url":"https://api.github.com/users/fisx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fisx/subscriptions","organizations_url":"https://api.github.com/users/fisx/orgs","repos_url":"https://api.github.com/users/fisx/repos","events_url":"https://api.github.com/users/fisx/events{/privacy}","received_events_url":"https://api.github.com/users/fisx/received_events","type":"User","site_admin":false},"body":"Not sure how exactly this works, but these will either be ignored or cause trouble in the library case, and I don't know how to say `use these for all executables and tests` in `hpack`.  I would prefer to leave it as is?  Simple and straight-forward, no?","created_at":"2018-07-02T11:04:59Z","updated_at":"2018-07-02T11:05:00Z","html_url":"https://github.com/wireapp/wire-server/pull/390#discussion_r199461243","pull_request_url":"https://api.github.com/repos/wireapp/wire-server/pulls/390","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/comments/199461243"},"html":{"href":"https://github.com/wireapp/wire-server/pull/390#discussion_r199461243"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/390"}},"in_reply_to_id":199440253},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-server/pulls/390","id":198285427,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Mjg1NDI3","html_url":"https://github.com/wireapp/wire-server/pull/390","diff_url":"https://github.com/wireapp/wire-server/pull/390.diff","patch_url":"https://github.com/wireapp/wire-server/pull/390.patch","issue_url":"https://api.github.com/repos/wireapp/wire-server/issues/390","number":390,"state":"open","locked":false,"title":"Initial version of the spar service.","user":{"login":"fisx","id":10210727,"node_id":"MDQ6VXNlcjEwMjEwNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/10210727?v=4","gravatar_id":"","url":"https://api.github.com/users/fisx","html_url":"https://github.com/fisx","followers_url":"https://api.github.com/users/fisx/followers","following_url":"https://api.github.com/users/fisx/following{/other_user}","gists_url":"https://api.github.com/users/fisx/gists{/gist_id}","starred_url":"https://api.github.com/users/fisx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fisx/subscriptions","organizations_url":"https://api.github.com/users/fisx/orgs","repos_url":"https://api.github.com/users/fisx/repos","events_url":"https://api.github.com/users/fisx/events{/privacy}","received_events_url":"https://api.github.com/users/fisx/received_events","type":"User","site_admin":false},"body":"comments and questions for the reviewers:\r\n\r\n- don't look at the individual commits!  :-)\r\n- did i forget any integration tests?\r\n- how important are the open tasks you can find with `git grep -Hn TODO`?\r\n- assuming the integration tests pass, is it reasonably safe to put this to production?  what else should i consider to make it so?","created_at":"2018-06-29T11:05:20Z","updated_at":"2018-07-02T11:05:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecbbfe936613630d244c73479062c5dbb65d02c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-server/pulls/390/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-server/pulls/390/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-server/issues/390/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-server/statuses/1efe77745d3ef61b606530a4adba706e85e74db0","head":{"label":"wireapp:feature/sso-service-spar","ref":"feature/sso-service-spar","sha":"1efe77745d3ef61b606530a4adba706e85e74db0","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":81935044,"node_id":"MDEwOlJlcG9zaXRvcnk4MTkzNTA0NA==","name":"wire-server","full_name":"wireapp/wire-server","owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-server","description":"🇪🇺 Wire back-end services","fork":false,"url":"https://api.github.com/repos/wireapp/wire-server","forks_url":"https://api.github.com/repos/wireapp/wire-server/forks","keys_url":"https://api.github.com/repos/wireapp/wire-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-server/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-server/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-server/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-server/events","assignees_url":"https://api.github.com/repos/wireapp/wire-server/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-server/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-server/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-server/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-server/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-server/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-server/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-server/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-server/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-server/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-server/merges","archive_url":"https://api.github.com/repos/wireapp/wire-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-server/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-server/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-server/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-server/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-server/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-server/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-server/deployments","created_at":"2017-02-14T10:42:59Z","updated_at":"2018-07-02T09:18:21Z","pushed_at":"2018-07-02T10:56:54Z","git_url":"git://github.com/wireapp/wire-server.git","ssh_url":"git@github.com:wireapp/wire-server.git","clone_url":"https://github.com/wireapp/wire-server.git","svn_url":"https://github.com/wireapp/wire-server","homepage":"https://wire.com","size":2919,"stargazers_count":1615,"watchers_count":1615,"language":"Haskell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":194,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":194,"open_issues":21,"watchers":1615,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"f7ce4a828cc4e7e7a78f474044f2b89484c6c60a","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":81935044,"node_id":"MDEwOlJlcG9zaXRvcnk4MTkzNTA0NA==","name":"wire-server","full_name":"wireapp/wire-server","owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-server","description":"🇪🇺 Wire back-end services","fork":false,"url":"https://api.github.com/repos/wireapp/wire-server","forks_url":"https://api.github.com/repos/wireapp/wire-server/forks","keys_url":"https://api.github.com/repos/wireapp/wire-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-server/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-server/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-server/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-server/events","assignees_url":"https://api.github.com/repos/wireapp/wire-server/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-server/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-server/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-server/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-server/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-server/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-server/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-server/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-server/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-server/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-server/merges","archive_url":"https://api.github.com/repos/wireapp/wire-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-server/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-server/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-server/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-server/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-server/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-server/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-server/deployments","created_at":"2017-02-14T10:42:59Z","updated_at":"2018-07-02T09:18:21Z","pushed_at":"2018-07-02T10:56:54Z","git_url":"git://github.com/wireapp/wire-server.git","ssh_url":"git@github.com:wireapp/wire-server.git","clone_url":"https://github.com/wireapp/wire-server.git","svn_url":"https://github.com/wireapp/wire-server","homepage":"https://wire.com","size":2919,"stargazers_count":1615,"watchers_count":1615,"language":"Haskell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":194,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":194,"open_issues":21,"watchers":1615,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/390"},"html":{"href":"https://github.com/wireapp/wire-server/pull/390"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-server/issues/390"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-server/issues/390/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/390/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/390/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-server/statuses/1efe77745d3ef61b606530a4adba706e85e74db0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fisx"}}