{"action":"created","comment":{"url":"https://api.github.com/repos/solana-labs/solana/pulls/comments/235587436","pull_request_review_id":177487479,"id":235587436,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTU4NzQzNg==","diff_hunk":"@@ -79,7 +81,14 @@ pub fn repair(\n         max_entry_height + 2\n     };\n \n-    let idxs = find_missing_data_indexes(slot, db_ledger, consumed, max_repair_entry_height - 1);\n+    let mut idxs = find_missing_data_indexes(\n+        slot,\n+        db_ledger,\n+        consumed,\n+        max_repair_entry_height - 1,\n+        MAX_REPAIR_LENGTH,\n+    );\n+    idxs.truncate(MAX_REPAIR_LENGTH);","path":"src/db_window.rs","position":21,"original_position":21,"commit_id":"7411e0bef2f01dae1e1bd164bf472d68bffcacb0","original_commit_id":"7411e0bef2f01dae1e1bd164bf472d68bffcacb0","user":{"login":"rob-solana","id":40183961,"node_id":"MDQ6VXNlcjQwMTgzOTYx","avatar_url":"https://avatars0.githubusercontent.com/u/40183961?v=4","gravatar_id":"","url":"https://api.github.com/users/rob-solana","html_url":"https://github.com/rob-solana","followers_url":"https://api.github.com/users/rob-solana/followers","following_url":"https://api.github.com/users/rob-solana/following{/other_user}","gists_url":"https://api.github.com/users/rob-solana/gists{/gist_id}","starred_url":"https://api.github.com/users/rob-solana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rob-solana/subscriptions","organizations_url":"https://api.github.com/users/rob-solana/orgs","repos_url":"https://api.github.com/users/rob-solana/repos","events_url":"https://api.github.com/users/rob-solana/events{/privacy}","received_events_url":"https://api.github.com/users/rob-solana/received_events","type":"User","site_admin":false},"body":"why are you truncating if find_missing is limiting its output?","created_at":"2018-11-22T02:38:24Z","updated_at":"2018-11-22T02:38:25Z","html_url":"https://github.com/solana-labs/solana/pull/1886#discussion_r235587436","pull_request_url":"https://api.github.com/repos/solana-labs/solana/pulls/1886","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/comments/235587436"},"html":{"href":"https://github.com/solana-labs/solana/pull/1886#discussion_r235587436"},"pull_request":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/1886"}}},"pull_request":{"url":"https://api.github.com/repos/solana-labs/solana/pulls/1886","id":232840158,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODQwMTU4","html_url":"https://github.com/solana-labs/solana/pull/1886","diff_url":"https://github.com/solana-labs/solana/pull/1886.diff","patch_url":"https://github.com/solana-labs/solana/pull/1886.patch","issue_url":"https://api.github.com/repos/solana-labs/solana/issues/1886","number":1886,"state":"open","locked":false,"title":"Add maximum repair length to db_window","user":{"login":"carllin","id":3374799,"node_id":"MDQ6VXNlcjMzNzQ3OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3374799?v=4","gravatar_id":"","url":"https://api.github.com/users/carllin","html_url":"https://github.com/carllin","followers_url":"https://api.github.com/users/carllin/followers","following_url":"https://api.github.com/users/carllin/following{/other_user}","gists_url":"https://api.github.com/users/carllin/gists{/gist_id}","starred_url":"https://api.github.com/users/carllin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carllin/subscriptions","organizations_url":"https://api.github.com/users/carllin/orgs","repos_url":"https://api.github.com/users/carllin/repos","events_url":"https://api.github.com/users/carllin/events{/privacy}","received_events_url":"https://api.github.com/users/carllin/received_events","type":"User","site_admin":false},"body":"#### Problem\r\nThe number of repairs could now be potentially unbounded, which causes massive congestion on the network.\r\n\r\n#### Summary of Changes\r\nLimit the number of repairs a node can fire off at once\r\n\r\nFixes #\r\n","created_at":"2018-11-22T02:03:22Z","updated_at":"2018-11-22T02:38:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"313a524413cf9f3a651c0822efd4bf4e19c9d634","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/solana-labs/solana/pulls/1886/commits","review_comments_url":"https://api.github.com/repos/solana-labs/solana/pulls/1886/comments","review_comment_url":"https://api.github.com/repos/solana-labs/solana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solana-labs/solana/issues/1886/comments","statuses_url":"https://api.github.com/repos/solana-labs/solana/statuses/7411e0bef2f01dae1e1bd164bf472d68bffcacb0","head":{"label":"carllin:AddMaximumRepairLength","ref":"AddMaximumRepairLength","sha":"7411e0bef2f01dae1e1bd164bf472d68bffcacb0","user":{"login":"carllin","id":3374799,"node_id":"MDQ6VXNlcjMzNzQ3OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3374799?v=4","gravatar_id":"","url":"https://api.github.com/users/carllin","html_url":"https://github.com/carllin","followers_url":"https://api.github.com/users/carllin/followers","following_url":"https://api.github.com/users/carllin/following{/other_user}","gists_url":"https://api.github.com/users/carllin/gists{/gist_id}","starred_url":"https://api.github.com/users/carllin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carllin/subscriptions","organizations_url":"https://api.github.com/users/carllin/orgs","repos_url":"https://api.github.com/users/carllin/repos","events_url":"https://api.github.com/users/carllin/events{/privacy}","received_events_url":"https://api.github.com/users/carllin/received_events","type":"User","site_admin":false},"repo":{"id":136771278,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY3NzEyNzg=","name":"solana","full_name":"carllin/solana","private":false,"owner":{"login":"carllin","id":3374799,"node_id":"MDQ6VXNlcjMzNzQ3OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/3374799?v=4","gravatar_id":"","url":"https://api.github.com/users/carllin","html_url":"https://github.com/carllin","followers_url":"https://api.github.com/users/carllin/followers","following_url":"https://api.github.com/users/carllin/following{/other_user}","gists_url":"https://api.github.com/users/carllin/gists{/gist_id}","starred_url":"https://api.github.com/users/carllin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carllin/subscriptions","organizations_url":"https://api.github.com/users/carllin/orgs","repos_url":"https://api.github.com/users/carllin/repos","events_url":"https://api.github.com/users/carllin/events{/privacy}","received_events_url":"https://api.github.com/users/carllin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/carllin/solana","description":"Blockchain, Rebuilt for Scale","fork":true,"url":"https://api.github.com/repos/carllin/solana","forks_url":"https://api.github.com/repos/carllin/solana/forks","keys_url":"https://api.github.com/repos/carllin/solana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carllin/solana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carllin/solana/teams","hooks_url":"https://api.github.com/repos/carllin/solana/hooks","issue_events_url":"https://api.github.com/repos/carllin/solana/issues/events{/number}","events_url":"https://api.github.com/repos/carllin/solana/events","assignees_url":"https://api.github.com/repos/carllin/solana/assignees{/user}","branches_url":"https://api.github.com/repos/carllin/solana/branches{/branch}","tags_url":"https://api.github.com/repos/carllin/solana/tags","blobs_url":"https://api.github.com/repos/carllin/solana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carllin/solana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carllin/solana/git/refs{/sha}","trees_url":"https://api.github.com/repos/carllin/solana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carllin/solana/statuses/{sha}","languages_url":"https://api.github.com/repos/carllin/solana/languages","stargazers_url":"https://api.github.com/repos/carllin/solana/stargazers","contributors_url":"https://api.github.com/repos/carllin/solana/contributors","subscribers_url":"https://api.github.com/repos/carllin/solana/subscribers","subscription_url":"https://api.github.com/repos/carllin/solana/subscription","commits_url":"https://api.github.com/repos/carllin/solana/commits{/sha}","git_commits_url":"https://api.github.com/repos/carllin/solana/git/commits{/sha}","comments_url":"https://api.github.com/repos/carllin/solana/comments{/number}","issue_comment_url":"https://api.github.com/repos/carllin/solana/issues/comments{/number}","contents_url":"https://api.github.com/repos/carllin/solana/contents/{+path}","compare_url":"https://api.github.com/repos/carllin/solana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carllin/solana/merges","archive_url":"https://api.github.com/repos/carllin/solana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carllin/solana/downloads","issues_url":"https://api.github.com/repos/carllin/solana/issues{/number}","pulls_url":"https://api.github.com/repos/carllin/solana/pulls{/number}","milestones_url":"https://api.github.com/repos/carllin/solana/milestones{/number}","notifications_url":"https://api.github.com/repos/carllin/solana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carllin/solana/labels{/name}","releases_url":"https://api.github.com/repos/carllin/solana/releases{/id}","deployments_url":"https://api.github.com/repos/carllin/solana/deployments","created_at":"2018-06-10T01:50:19Z","updated_at":"2018-09-19T21:33:30Z","pushed_at":"2018-11-22T02:02:51Z","git_url":"git://github.com/carllin/solana.git","ssh_url":"git@github.com:carllin/solana.git","clone_url":"https://github.com/carllin/solana.git","svn_url":"https://github.com/carllin/solana","homepage":"https://solana.com","size":13612,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"solana-labs:master","ref":"master","sha":"e6f91269ec3c97d7b529715deae6d85466f16100","user":{"login":"solana-labs","id":35608259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA4MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/35608259?v=4","gravatar_id":"","url":"https://api.github.com/users/solana-labs","html_url":"https://github.com/solana-labs","followers_url":"https://api.github.com/users/solana-labs/followers","following_url":"https://api.github.com/users/solana-labs/following{/other_user}","gists_url":"https://api.github.com/users/solana-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/solana-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solana-labs/subscriptions","organizations_url":"https://api.github.com/users/solana-labs/orgs","repos_url":"https://api.github.com/users/solana-labs/repos","events_url":"https://api.github.com/users/solana-labs/events{/privacy}","received_events_url":"https://api.github.com/users/solana-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":121470383,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0NzAzODM=","name":"solana","full_name":"solana-labs/solana","private":false,"owner":{"login":"solana-labs","id":35608259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA4MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/35608259?v=4","gravatar_id":"","url":"https://api.github.com/users/solana-labs","html_url":"https://github.com/solana-labs","followers_url":"https://api.github.com/users/solana-labs/followers","following_url":"https://api.github.com/users/solana-labs/following{/other_user}","gists_url":"https://api.github.com/users/solana-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/solana-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solana-labs/subscriptions","organizations_url":"https://api.github.com/users/solana-labs/orgs","repos_url":"https://api.github.com/users/solana-labs/repos","events_url":"https://api.github.com/users/solana-labs/events{/privacy}","received_events_url":"https://api.github.com/users/solana-labs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/solana-labs/solana","description":"Blockchain, Rebuilt for Scale","fork":false,"url":"https://api.github.com/repos/solana-labs/solana","forks_url":"https://api.github.com/repos/solana-labs/solana/forks","keys_url":"https://api.github.com/repos/solana-labs/solana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solana-labs/solana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solana-labs/solana/teams","hooks_url":"https://api.github.com/repos/solana-labs/solana/hooks","issue_events_url":"https://api.github.com/repos/solana-labs/solana/issues/events{/number}","events_url":"https://api.github.com/repos/solana-labs/solana/events","assignees_url":"https://api.github.com/repos/solana-labs/solana/assignees{/user}","branches_url":"https://api.github.com/repos/solana-labs/solana/branches{/branch}","tags_url":"https://api.github.com/repos/solana-labs/solana/tags","blobs_url":"https://api.github.com/repos/solana-labs/solana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solana-labs/solana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solana-labs/solana/git/refs{/sha}","trees_url":"https://api.github.com/repos/solana-labs/solana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solana-labs/solana/statuses/{sha}","languages_url":"https://api.github.com/repos/solana-labs/solana/languages","stargazers_url":"https://api.github.com/repos/solana-labs/solana/stargazers","contributors_url":"https://api.github.com/repos/solana-labs/solana/contributors","subscribers_url":"https://api.github.com/repos/solana-labs/solana/subscribers","subscription_url":"https://api.github.com/repos/solana-labs/solana/subscription","commits_url":"https://api.github.com/repos/solana-labs/solana/commits{/sha}","git_commits_url":"https://api.github.com/repos/solana-labs/solana/git/commits{/sha}","comments_url":"https://api.github.com/repos/solana-labs/solana/comments{/number}","issue_comment_url":"https://api.github.com/repos/solana-labs/solana/issues/comments{/number}","contents_url":"https://api.github.com/repos/solana-labs/solana/contents/{+path}","compare_url":"https://api.github.com/repos/solana-labs/solana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solana-labs/solana/merges","archive_url":"https://api.github.com/repos/solana-labs/solana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solana-labs/solana/downloads","issues_url":"https://api.github.com/repos/solana-labs/solana/issues{/number}","pulls_url":"https://api.github.com/repos/solana-labs/solana/pulls{/number}","milestones_url":"https://api.github.com/repos/solana-labs/solana/milestones{/number}","notifications_url":"https://api.github.com/repos/solana-labs/solana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solana-labs/solana/labels{/name}","releases_url":"https://api.github.com/repos/solana-labs/solana/releases{/id}","deployments_url":"https://api.github.com/repos/solana-labs/solana/deployments","created_at":"2018-02-14T04:26:27Z","updated_at":"2018-11-22T00:45:58Z","pushed_at":"2018-11-22T02:03:23Z","git_url":"git://github.com/solana-labs/solana.git","ssh_url":"git@github.com:solana-labs/solana.git","clone_url":"https://github.com/solana-labs/solana.git","svn_url":"https://github.com/solana-labs/solana","homepage":"https://solana.com","size":13718,"stargazers_count":379,"watchers_count":379,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":161,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":65,"open_issues":161,"watchers":379,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/1886"},"html":{"href":"https://github.com/solana-labs/solana/pull/1886"},"issue":{"href":"https://api.github.com/repos/solana-labs/solana/issues/1886"},"comments":{"href":"https://api.github.com/repos/solana-labs/solana/issues/1886/comments"},"review_comments":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/1886/comments"},"review_comment":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/1886/commits"},"statuses":{"href":"https://api.github.com/repos/solana-labs/solana/statuses/7411e0bef2f01dae1e1bd164bf472d68bffcacb0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rob-solana"}}