{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-combo-box-flow/issues/84","repository_url":"https://api.github.com/repos/vaadin/vaadin-combo-box-flow","labels_url":"https://api.github.com/repos/vaadin/vaadin-combo-box-flow/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-combo-box-flow/issues/84/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-combo-box-flow/issues/84/events","html_url":"https://github.com/vaadin/vaadin-combo-box-flow/pull/84","id":328958893,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMzM0NTUx","number":84,"title":"Keep the value before disabling the component","user":{"login":"ZheSun88","id":31067185,"node_id":"MDQ6VXNlcjMxMDY3MTg1","avatar_url":"https://avatars2.githubusercontent.com/u/31067185?v=4","gravatar_id":"","url":"https://api.github.com/users/ZheSun88","html_url":"https://github.com/ZheSun88","followers_url":"https://api.github.com/users/ZheSun88/followers","following_url":"https://api.github.com/users/ZheSun88/following{/other_user}","gists_url":"https://api.github.com/users/ZheSun88/gists{/gist_id}","starred_url":"https://api.github.com/users/ZheSun88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZheSun88/subscriptions","organizations_url":"https://api.github.com/users/ZheSun88/orgs","repos_url":"https://api.github.com/users/ZheSun88/repos","events_url":"https://api.github.com/users/ZheSun88/events{/privacy}","received_events_url":"https://api.github.com/users/ZheSun88/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-04T08:37:28Z","updated_at":"2018-06-04T09:02:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-combo-box-flow/pulls/84","html_url":"https://github.com/vaadin/vaadin-combo-box-flow/pull/84","diff_url":"https://github.com/vaadin/vaadin-combo-box-flow/pull/84.diff","patch_url":"https://github.com/vaadin/vaadin-combo-box-flow/pull/84.patch"},"body":"Add test case;\r\nFixes#83.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-combo-box-flow/84)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-combo-box-flow/issues/comments/394284791","html_url":"https://github.com/vaadin/vaadin-combo-box-flow/pull/84#issuecomment-394284791","issue_url":"https://api.github.com/repos/vaadin/vaadin-combo-box-flow/issues/84","id":394284791,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDI4NDc5MQ==","user":{"login":"ZheSun88","id":31067185,"node_id":"MDQ6VXNlcjMxMDY3MTg1","avatar_url":"https://avatars2.githubusercontent.com/u/31067185?v=4","gravatar_id":"","url":"https://api.github.com/users/ZheSun88","html_url":"https://github.com/ZheSun88","followers_url":"https://api.github.com/users/ZheSun88/followers","following_url":"https://api.github.com/users/ZheSun88/following{/other_user}","gists_url":"https://api.github.com/users/ZheSun88/gists{/gist_id}","starred_url":"https://api.github.com/users/ZheSun88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZheSun88/subscriptions","organizations_url":"https://api.github.com/users/ZheSun88/orgs","repos_url":"https://api.github.com/users/ZheSun88/repos","events_url":"https://api.github.com/users/ZheSun88/events{/privacy}","received_events_url":"https://api.github.com/users/ZheSun88/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T09:02:46Z","updated_at":"2018-06-04T09:02:46Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[src/main/java/com/vaadin/flow/component/combobox/ComboBox.java, line 496 at r1](https://reviewable.io/reviews/vaadin/vaadin-combo-box-flow/84#-LE8y0Yb3XTyOGa1uBAo:-LE91-ir6bO6JDFxeGJz:b-896fix) ([raw file](https://github.com/vaadin/vaadin-combo-box-flow/blob/241dbf8772680e5856ac632060778e7d35f3f7de/src/main/java/com/vaadin/flow/component/combobox/ComboBox.java#L496)):*\n<details><summary><i>Previously, denis-anisimov (Denis) wrote…</i></summary><blockquote>\n\n> ```\n>         return (getValue(getElement()\n>                 .getPropertyRaw(SELECTED_ITEM_PROPERTY_NAME))) == null\n> ```\n\nYou are using the same value twice. Here to check against `null` and below as a value.\nIt would be OK if it wasn't so long.\nSo please extract it as a variable and use the variable instead in the expression.\n</blockquote></details>\n\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/vaadin/vaadin-combo-box-flow/84)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"ZheSun88"}}