{"action":"created","comment":{"url":"https://api.github.com/repos/bakerstu/openmrn/pulls/comments/195902143","pull_request_review_id":129362439,"id":195902143,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTkwMjE0Mw==","diff_hunk":"@@ -408,6 +408,8 @@ StateFlowBase::Action DispatchFlowBase<NUM_PRIO>::iterate()\n {\n     ID id = get_message_id();\n     {\n+        // @todo(balazs.racz) make the registered handlers structure for the\n+        // dispatcher lock-free. This mutex here is very expensive.","path":"src/executor/Dispatcher.hxx","position":5,"original_position":5,"commit_id":"0c8f2e99d7c2308f650a573947ab3922627be6fb","original_commit_id":"0c8f2e99d7c2308f650a573947ab3922627be6fb","user":{"login":"balazsracz","id":3719690,"node_id":"MDQ6VXNlcjM3MTk2OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/3719690?v=4","gravatar_id":"","url":"https://api.github.com/users/balazsracz","html_url":"https://github.com/balazsracz","followers_url":"https://api.github.com/users/balazsracz/followers","following_url":"https://api.github.com/users/balazsracz/following{/other_user}","gists_url":"https://api.github.com/users/balazsracz/gists{/gist_id}","starred_url":"https://api.github.com/users/balazsracz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balazsracz/subscriptions","organizations_url":"https://api.github.com/users/balazsracz/orgs","repos_url":"https://api.github.com/users/balazsracz/repos","events_url":"https://api.github.com/users/balazsracz/events{/privacy}","received_events_url":"https://api.github.com/users/balazsracz/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-06-16T12:33:08Z","updated_at":"2018-06-16T12:33:08Z","html_url":"https://github.com/bakerstu/openmrn/pull/145#discussion_r195902143","pull_request_url":"https://api.github.com/repos/bakerstu/openmrn/pulls/145","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/bakerstu/openmrn/pulls/comments/195902143"},"html":{"href":"https://github.com/bakerstu/openmrn/pull/145#discussion_r195902143"},"pull_request":{"href":"https://api.github.com/repos/bakerstu/openmrn/pulls/145"}},"in_reply_to_id":194945492},"pull_request":{"url":"https://api.github.com/repos/bakerstu/openmrn/pulls/145","id":194362288,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MzYyMjg4","html_url":"https://github.com/bakerstu/openmrn/pull/145","diff_url":"https://github.com/bakerstu/openmrn/pull/145.diff","patch_url":"https://github.com/bakerstu/openmrn/pull/145.patch","issue_url":"https://api.github.com/repos/bakerstu/openmrn/issues/145","number":145,"state":"open","locked":false,"title":"Core performance optimizations","user":{"login":"balazsracz","id":3719690,"node_id":"MDQ6VXNlcjM3MTk2OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/3719690?v=4","gravatar_id":"","url":"https://api.github.com/users/balazsracz","html_url":"https://github.com/balazsracz","followers_url":"https://api.github.com/users/balazsracz/followers","following_url":"https://api.github.com/users/balazsracz/following{/other_user}","gists_url":"https://api.github.com/users/balazsracz/gists{/gist_id}","starred_url":"https://api.github.com/users/balazsracz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balazsracz/subscriptions","organizations_url":"https://api.github.com/users/balazsracz/orgs","repos_url":"https://api.github.com/users/balazsracz/repos","events_url":"https://api.github.com/users/balazsracz/events{/privacy}","received_events_url":"https://api.github.com/users/balazsracz/received_events","type":"User","site_admin":false},"body":"Optimizes the openmrn core executor and timer services to use less CPU for packet processing.\r\nThe optimizations are mostly around inner loops of the executor and the dispatcher flow.\r\n- Amortizes the cost of timers the same way we do with select() calls.\r\n- removes duplicate and unnecessary mutexes and locks, for example when we acquired nested mutexes for no good reason\r\n- removes one lock-unlock sequence from the dispatcher's most common code path.\r\n- makes the queue implementations be inlineable by the compiler\r\n\r\nThe timer poll resampling caused a lot of unittest failures because wait_for_main_executo() suddenly did not ensure that expired timers have run. This PR changes the underlying infrastructure ExecutorGuard to actually wait for the already expired timers by sleeping -1 time on the timer queue instead of getting added to the lowest priority executor queue.\r\n","created_at":"2018-06-12T18:03:17Z","updated_at":"2018-06-16T12:33:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d38061ebec53ae920579c39e294b79965f938007","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bakerstu/openmrn/pulls/145/commits","review_comments_url":"https://api.github.com/repos/bakerstu/openmrn/pulls/145/comments","review_comment_url":"https://api.github.com/repos/bakerstu/openmrn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bakerstu/openmrn/issues/145/comments","statuses_url":"https://api.github.com/repos/bakerstu/openmrn/statuses/0c8f2e99d7c2308f650a573947ab3922627be6fb","head":{"label":"bakerstu:bracz-core-performance-optimizations","ref":"bracz-core-performance-optimizations","sha":"0c8f2e99d7c2308f650a573947ab3922627be6fb","user":{"login":"bakerstu","id":2278798,"node_id":"MDQ6VXNlcjIyNzg3OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2278798?v=4","gravatar_id":"","url":"https://api.github.com/users/bakerstu","html_url":"https://github.com/bakerstu","followers_url":"https://api.github.com/users/bakerstu/followers","following_url":"https://api.github.com/users/bakerstu/following{/other_user}","gists_url":"https://api.github.com/users/bakerstu/gists{/gist_id}","starred_url":"https://api.github.com/users/bakerstu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakerstu/subscriptions","organizations_url":"https://api.github.com/users/bakerstu/orgs","repos_url":"https://api.github.com/users/bakerstu/repos","events_url":"https://api.github.com/users/bakerstu/events{/privacy}","received_events_url":"https://api.github.com/users/bakerstu/received_events","type":"User","site_admin":false},"repo":{"id":6500256,"node_id":"MDEwOlJlcG9zaXRvcnk2NTAwMjU2","name":"openmrn","full_name":"bakerstu/openmrn","owner":{"login":"bakerstu","id":2278798,"node_id":"MDQ6VXNlcjIyNzg3OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2278798?v=4","gravatar_id":"","url":"https://api.github.com/users/bakerstu","html_url":"https://github.com/bakerstu","followers_url":"https://api.github.com/users/bakerstu/followers","following_url":"https://api.github.com/users/bakerstu/following{/other_user}","gists_url":"https://api.github.com/users/bakerstu/gists{/gist_id}","starred_url":"https://api.github.com/users/bakerstu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakerstu/subscriptions","organizations_url":"https://api.github.com/users/bakerstu/orgs","repos_url":"https://api.github.com/users/bakerstu/repos","events_url":"https://api.github.com/users/bakerstu/events{/privacy}","received_events_url":"https://api.github.com/users/bakerstu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bakerstu/openmrn","description":"OpenMRN (Open Model Railroad Network)","fork":false,"url":"https://api.github.com/repos/bakerstu/openmrn","forks_url":"https://api.github.com/repos/bakerstu/openmrn/forks","keys_url":"https://api.github.com/repos/bakerstu/openmrn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bakerstu/openmrn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bakerstu/openmrn/teams","hooks_url":"https://api.github.com/repos/bakerstu/openmrn/hooks","issue_events_url":"https://api.github.com/repos/bakerstu/openmrn/issues/events{/number}","events_url":"https://api.github.com/repos/bakerstu/openmrn/events","assignees_url":"https://api.github.com/repos/bakerstu/openmrn/assignees{/user}","branches_url":"https://api.github.com/repos/bakerstu/openmrn/branches{/branch}","tags_url":"https://api.github.com/repos/bakerstu/openmrn/tags","blobs_url":"https://api.github.com/repos/bakerstu/openmrn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bakerstu/openmrn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bakerstu/openmrn/git/refs{/sha}","trees_url":"https://api.github.com/repos/bakerstu/openmrn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bakerstu/openmrn/statuses/{sha}","languages_url":"https://api.github.com/repos/bakerstu/openmrn/languages","stargazers_url":"https://api.github.com/repos/bakerstu/openmrn/stargazers","contributors_url":"https://api.github.com/repos/bakerstu/openmrn/contributors","subscribers_url":"https://api.github.com/repos/bakerstu/openmrn/subscribers","subscription_url":"https://api.github.com/repos/bakerstu/openmrn/subscription","commits_url":"https://api.github.com/repos/bakerstu/openmrn/commits{/sha}","git_commits_url":"https://api.github.com/repos/bakerstu/openmrn/git/commits{/sha}","comments_url":"https://api.github.com/repos/bakerstu/openmrn/comments{/number}","issue_comment_url":"https://api.github.com/repos/bakerstu/openmrn/issues/comments{/number}","contents_url":"https://api.github.com/repos/bakerstu/openmrn/contents/{+path}","compare_url":"https://api.github.com/repos/bakerstu/openmrn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bakerstu/openmrn/merges","archive_url":"https://api.github.com/repos/bakerstu/openmrn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bakerstu/openmrn/downloads","issues_url":"https://api.github.com/repos/bakerstu/openmrn/issues{/number}","pulls_url":"https://api.github.com/repos/bakerstu/openmrn/pulls{/number}","milestones_url":"https://api.github.com/repos/bakerstu/openmrn/milestones{/number}","notifications_url":"https://api.github.com/repos/bakerstu/openmrn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bakerstu/openmrn/labels{/name}","releases_url":"https://api.github.com/repos/bakerstu/openmrn/releases{/id}","deployments_url":"https://api.github.com/repos/bakerstu/openmrn/deployments","created_at":"2012-11-02T02:20:12Z","updated_at":"2018-06-16T11:28:35Z","pushed_at":"2018-06-16T12:30:27Z","git_url":"git://github.com/bakerstu/openmrn.git","ssh_url":"git@github.com:bakerstu/openmrn.git","clone_url":"https://github.com/bakerstu/openmrn.git","svn_url":"https://github.com/bakerstu/openmrn","homepage":null,"size":13336,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":11,"open_issues":38,"watchers":7,"default_branch":"master"}},"base":{"label":"bakerstu:master","ref":"master","sha":"670f4a94140e268815de9e22f960c9ec56359c71","user":{"login":"bakerstu","id":2278798,"node_id":"MDQ6VXNlcjIyNzg3OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2278798?v=4","gravatar_id":"","url":"https://api.github.com/users/bakerstu","html_url":"https://github.com/bakerstu","followers_url":"https://api.github.com/users/bakerstu/followers","following_url":"https://api.github.com/users/bakerstu/following{/other_user}","gists_url":"https://api.github.com/users/bakerstu/gists{/gist_id}","starred_url":"https://api.github.com/users/bakerstu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakerstu/subscriptions","organizations_url":"https://api.github.com/users/bakerstu/orgs","repos_url":"https://api.github.com/users/bakerstu/repos","events_url":"https://api.github.com/users/bakerstu/events{/privacy}","received_events_url":"https://api.github.com/users/bakerstu/received_events","type":"User","site_admin":false},"repo":{"id":6500256,"node_id":"MDEwOlJlcG9zaXRvcnk2NTAwMjU2","name":"openmrn","full_name":"bakerstu/openmrn","owner":{"login":"bakerstu","id":2278798,"node_id":"MDQ6VXNlcjIyNzg3OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2278798?v=4","gravatar_id":"","url":"https://api.github.com/users/bakerstu","html_url":"https://github.com/bakerstu","followers_url":"https://api.github.com/users/bakerstu/followers","following_url":"https://api.github.com/users/bakerstu/following{/other_user}","gists_url":"https://api.github.com/users/bakerstu/gists{/gist_id}","starred_url":"https://api.github.com/users/bakerstu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakerstu/subscriptions","organizations_url":"https://api.github.com/users/bakerstu/orgs","repos_url":"https://api.github.com/users/bakerstu/repos","events_url":"https://api.github.com/users/bakerstu/events{/privacy}","received_events_url":"https://api.github.com/users/bakerstu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bakerstu/openmrn","description":"OpenMRN (Open Model Railroad Network)","fork":false,"url":"https://api.github.com/repos/bakerstu/openmrn","forks_url":"https://api.github.com/repos/bakerstu/openmrn/forks","keys_url":"https://api.github.com/repos/bakerstu/openmrn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bakerstu/openmrn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bakerstu/openmrn/teams","hooks_url":"https://api.github.com/repos/bakerstu/openmrn/hooks","issue_events_url":"https://api.github.com/repos/bakerstu/openmrn/issues/events{/number}","events_url":"https://api.github.com/repos/bakerstu/openmrn/events","assignees_url":"https://api.github.com/repos/bakerstu/openmrn/assignees{/user}","branches_url":"https://api.github.com/repos/bakerstu/openmrn/branches{/branch}","tags_url":"https://api.github.com/repos/bakerstu/openmrn/tags","blobs_url":"https://api.github.com/repos/bakerstu/openmrn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bakerstu/openmrn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bakerstu/openmrn/git/refs{/sha}","trees_url":"https://api.github.com/repos/bakerstu/openmrn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bakerstu/openmrn/statuses/{sha}","languages_url":"https://api.github.com/repos/bakerstu/openmrn/languages","stargazers_url":"https://api.github.com/repos/bakerstu/openmrn/stargazers","contributors_url":"https://api.github.com/repos/bakerstu/openmrn/contributors","subscribers_url":"https://api.github.com/repos/bakerstu/openmrn/subscribers","subscription_url":"https://api.github.com/repos/bakerstu/openmrn/subscription","commits_url":"https://api.github.com/repos/bakerstu/openmrn/commits{/sha}","git_commits_url":"https://api.github.com/repos/bakerstu/openmrn/git/commits{/sha}","comments_url":"https://api.github.com/repos/bakerstu/openmrn/comments{/number}","issue_comment_url":"https://api.github.com/repos/bakerstu/openmrn/issues/comments{/number}","contents_url":"https://api.github.com/repos/bakerstu/openmrn/contents/{+path}","compare_url":"https://api.github.com/repos/bakerstu/openmrn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bakerstu/openmrn/merges","archive_url":"https://api.github.com/repos/bakerstu/openmrn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bakerstu/openmrn/downloads","issues_url":"https://api.github.com/repos/bakerstu/openmrn/issues{/number}","pulls_url":"https://api.github.com/repos/bakerstu/openmrn/pulls{/number}","milestones_url":"https://api.github.com/repos/bakerstu/openmrn/milestones{/number}","notifications_url":"https://api.github.com/repos/bakerstu/openmrn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bakerstu/openmrn/labels{/name}","releases_url":"https://api.github.com/repos/bakerstu/openmrn/releases{/id}","deployments_url":"https://api.github.com/repos/bakerstu/openmrn/deployments","created_at":"2012-11-02T02:20:12Z","updated_at":"2018-06-16T11:28:35Z","pushed_at":"2018-06-16T12:30:27Z","git_url":"git://github.com/bakerstu/openmrn.git","ssh_url":"git@github.com:bakerstu/openmrn.git","clone_url":"https://github.com/bakerstu/openmrn.git","svn_url":"https://github.com/bakerstu/openmrn","homepage":null,"size":13336,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":11,"open_issues":38,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bakerstu/openmrn/pulls/145"},"html":{"href":"https://github.com/bakerstu/openmrn/pull/145"},"issue":{"href":"https://api.github.com/repos/bakerstu/openmrn/issues/145"},"comments":{"href":"https://api.github.com/repos/bakerstu/openmrn/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/bakerstu/openmrn/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/bakerstu/openmrn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bakerstu/openmrn/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/bakerstu/openmrn/statuses/0c8f2e99d7c2308f650a573947ab3922627be6fb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"balazsracz"}}