{"action":"created","comment":{"url":"https://api.github.com/repos/exhi/hoist-react/pulls/comments/220571887","pull_request_review_id":159008220,"id":220571887,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDU3MTg4Nw==","diff_hunk":"@@ -192,13 +200,19 @@ export class Column {\n \n         const {renderer, elementRenderer} = this;\n         if (renderer) {\n-            ret.cellRenderer = (params) => {\n-                const metaData = {colId: params.column.colId};\n-                return renderer(params.value, params.data, metaData);\n+            ret.cellRenderer = (agParams) => {\n+                return renderer(agParams.value, {record: agParams.data, column: this, agParams});\n             };\n         } else if (elementRenderer) {\n+            // eslint-disable-next-line consistent-this\n+            const column = this;\n             ret.cellRendererFramework = class extends Component {\n-                render() {return elementRenderer(this.props)}\n+                render() {\n+                    const agParams = this.props,\n+                        {value, data: record} = agParams;\n+\n+                    return elementRenderer({value, record, agParams, column});\n+                }\n                 refresh() {return false}","path":"columns/Column.js","position":62,"original_position":62,"commit_id":"5146b15e46724a458e07967df726b7a4015a1536","original_commit_id":"5146b15e46724a458e07967df726b7a4015a1536","user":{"login":"lbwexler","id":2307561,"node_id":"MDQ6VXNlcjIzMDc1NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/2307561?v=4","gravatar_id":"","url":"https://api.github.com/users/lbwexler","html_url":"https://github.com/lbwexler","followers_url":"https://api.github.com/users/lbwexler/followers","following_url":"https://api.github.com/users/lbwexler/following{/other_user}","gists_url":"https://api.github.com/users/lbwexler/gists{/gist_id}","starred_url":"https://api.github.com/users/lbwexler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbwexler/subscriptions","organizations_url":"https://api.github.com/users/lbwexler/orgs","repos_url":"https://api.github.com/users/lbwexler/repos","events_url":"https://api.github.com/users/lbwexler/events{/privacy}","received_events_url":"https://api.github.com/users/lbwexler/received_events","type":"User","site_admin":false},"body":"OK -- totally fine with going that way.  I also think its totally fine that you can't provide a raw elemFactory to the renderer -- as you saw from my other comment want to move away from any possible conflation of the two concepts....","created_at":"2018-09-26T13:53:57Z","updated_at":"2018-09-26T13:53:58Z","html_url":"https://github.com/exhi/hoist-react/pull/608#discussion_r220571887","pull_request_url":"https://api.github.com/repos/exhi/hoist-react/pulls/608","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/comments/220571887"},"html":{"href":"https://github.com/exhi/hoist-react/pull/608#discussion_r220571887"},"pull_request":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/608"}},"in_reply_to_id":220500872},"pull_request":{"url":"https://api.github.com/repos/exhi/hoist-react/pulls/608","id":215075136,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDc1MTM2","html_url":"https://github.com/exhi/hoist-react/pull/608","diff_url":"https://github.com/exhi/hoist-react/pull/608.diff","patch_url":"https://github.com/exhi/hoist-react/pull/608.patch","issue_url":"https://api.github.com/repos/exhi/hoist-react/issues/608","number":608,"state":"open","locked":false,"title":"Grid actions column","user":{"login":"haynesjm42","id":9619538,"node_id":"MDQ6VXNlcjk2MTk1Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/9619538?v=4","gravatar_id":"","url":"https://api.github.com/users/haynesjm42","html_url":"https://github.com/haynesjm42","followers_url":"https://api.github.com/users/haynesjm42/followers","following_url":"https://api.github.com/users/haynesjm42/following{/other_user}","gists_url":"https://api.github.com/users/haynesjm42/gists{/gist_id}","starred_url":"https://api.github.com/users/haynesjm42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haynesjm42/subscriptions","organizations_url":"https://api.github.com/users/haynesjm42/orgs","repos_url":"https://api.github.com/users/haynesjm42/repos","events_url":"https://api.github.com/users/haynesjm42/events{/privacy}","received_events_url":"https://api.github.com/users/haynesjm42/received_events","type":"User","site_admin":false},"body":"Initial pass at support actions grid columns. #549 \r\n\r\nExtended the Column API to accept `rendererParams` to be passed through to the `renderer` or `elementRenderer` (the mechanism for passing the action definitions through to the ActionBar component)\r\n\r\nActionBar component which accepts a collection of action definitions, and simply renders them in a row as minimal buttons. Action definition properties can be a value or a function which returns a value (where it makes sense).\r\n\r\nAlso made some changes for #575 as part of this\r\n\r\n@lbwexler did a quick review with @amcclain of this approach, wanted your feedback on whether this seems like a sounds approach or if something more object-oriented and explicit (ActionColumn, pass actions to the GridModel, etc.) would be preferable.\r\n\r\nSee https://github.com/exhi/toolbox/commit/035f035a044385770d2e1b9467fbe7c3b7bc94d3 for an action column example.","created_at":"2018-09-12T19:48:14Z","updated_at":"2018-09-26T13:53:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"591dbf539a5335b5672bf7bd5a5b16478b43e4c3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"amcclain","id":225806,"node_id":"MDQ6VXNlcjIyNTgwNg==","avatar_url":"https://avatars3.githubusercontent.com/u/225806?v=4","gravatar_id":"","url":"https://api.github.com/users/amcclain","html_url":"https://github.com/amcclain","followers_url":"https://api.github.com/users/amcclain/followers","following_url":"https://api.github.com/users/amcclain/following{/other_user}","gists_url":"https://api.github.com/users/amcclain/gists{/gist_id}","starred_url":"https://api.github.com/users/amcclain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amcclain/subscriptions","organizations_url":"https://api.github.com/users/amcclain/orgs","repos_url":"https://api.github.com/users/amcclain/repos","events_url":"https://api.github.com/users/amcclain/events{/privacy}","received_events_url":"https://api.github.com/users/amcclain/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":970308892,"node_id":"MDU6TGFiZWw5NzAzMDg4OTI=","url":"https://api.github.com/repos/exhi/hoist-react/labels/wip","name":"wip","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/exhi/hoist-react/pulls/608/commits","review_comments_url":"https://api.github.com/repos/exhi/hoist-react/pulls/608/comments","review_comment_url":"https://api.github.com/repos/exhi/hoist-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exhi/hoist-react/issues/608/comments","statuses_url":"https://api.github.com/repos/exhi/hoist-react/statuses/5146b15e46724a458e07967df726b7a4015a1536","head":{"label":"exhi:actionCol","ref":"actionCol","sha":"5146b15e46724a458e07967df726b7a4015a1536","user":{"login":"exhi","id":850311,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MDMxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/850311?v=4","gravatar_id":"","url":"https://api.github.com/users/exhi","html_url":"https://github.com/exhi","followers_url":"https://api.github.com/users/exhi/followers","following_url":"https://api.github.com/users/exhi/following{/other_user}","gists_url":"https://api.github.com/users/exhi/gists{/gist_id}","starred_url":"https://api.github.com/users/exhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exhi/subscriptions","organizations_url":"https://api.github.com/users/exhi/orgs","repos_url":"https://api.github.com/users/exhi/repos","events_url":"https://api.github.com/users/exhi/events{/privacy}","received_events_url":"https://api.github.com/users/exhi/received_events","type":"Organization","site_admin":false},"repo":{"id":117733567,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3MzM1Njc=","name":"hoist-react","full_name":"exhi/hoist-react","private":false,"owner":{"login":"exhi","id":850311,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MDMxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/850311?v=4","gravatar_id":"","url":"https://api.github.com/users/exhi","html_url":"https://github.com/exhi","followers_url":"https://api.github.com/users/exhi/followers","following_url":"https://api.github.com/users/exhi/following{/other_user}","gists_url":"https://api.github.com/users/exhi/gists{/gist_id}","starred_url":"https://api.github.com/users/exhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exhi/subscriptions","organizations_url":"https://api.github.com/users/exhi/orgs","repos_url":"https://api.github.com/users/exhi/repos","events_url":"https://api.github.com/users/exhi/events{/privacy}","received_events_url":"https://api.github.com/users/exhi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/exhi/hoist-react","description":"🏗️ ⚛️ Hoist toolkit for building React applications.","fork":false,"url":"https://api.github.com/repos/exhi/hoist-react","forks_url":"https://api.github.com/repos/exhi/hoist-react/forks","keys_url":"https://api.github.com/repos/exhi/hoist-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exhi/hoist-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exhi/hoist-react/teams","hooks_url":"https://api.github.com/repos/exhi/hoist-react/hooks","issue_events_url":"https://api.github.com/repos/exhi/hoist-react/issues/events{/number}","events_url":"https://api.github.com/repos/exhi/hoist-react/events","assignees_url":"https://api.github.com/repos/exhi/hoist-react/assignees{/user}","branches_url":"https://api.github.com/repos/exhi/hoist-react/branches{/branch}","tags_url":"https://api.github.com/repos/exhi/hoist-react/tags","blobs_url":"https://api.github.com/repos/exhi/hoist-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exhi/hoist-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exhi/hoist-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/exhi/hoist-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exhi/hoist-react/statuses/{sha}","languages_url":"https://api.github.com/repos/exhi/hoist-react/languages","stargazers_url":"https://api.github.com/repos/exhi/hoist-react/stargazers","contributors_url":"https://api.github.com/repos/exhi/hoist-react/contributors","subscribers_url":"https://api.github.com/repos/exhi/hoist-react/subscribers","subscription_url":"https://api.github.com/repos/exhi/hoist-react/subscription","commits_url":"https://api.github.com/repos/exhi/hoist-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/exhi/hoist-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/exhi/hoist-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/exhi/hoist-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/exhi/hoist-react/contents/{+path}","compare_url":"https://api.github.com/repos/exhi/hoist-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exhi/hoist-react/merges","archive_url":"https://api.github.com/repos/exhi/hoist-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exhi/hoist-react/downloads","issues_url":"https://api.github.com/repos/exhi/hoist-react/issues{/number}","pulls_url":"https://api.github.com/repos/exhi/hoist-react/pulls{/number}","milestones_url":"https://api.github.com/repos/exhi/hoist-react/milestones{/number}","notifications_url":"https://api.github.com/repos/exhi/hoist-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exhi/hoist-react/labels{/name}","releases_url":"https://api.github.com/repos/exhi/hoist-react/releases{/id}","deployments_url":"https://api.github.com/repos/exhi/hoist-react/deployments","created_at":"2018-01-16T19:50:49Z","updated_at":"2018-09-26T02:59:15Z","pushed_at":"2018-09-26T02:59:20Z","git_url":"git://github.com/exhi/hoist-react.git","ssh_url":"git@github.com:exhi/hoist-react.git","clone_url":"https://github.com/exhi/hoist-react.git","svn_url":"https://github.com/exhi/hoist-react","homepage":"https://xh.io","size":2161,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":43,"watchers":3,"default_branch":"develop"}},"base":{"label":"exhi:develop","ref":"develop","sha":"7107675eac5a5660ff9e035fc36a29087650b0ed","user":{"login":"exhi","id":850311,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MDMxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/850311?v=4","gravatar_id":"","url":"https://api.github.com/users/exhi","html_url":"https://github.com/exhi","followers_url":"https://api.github.com/users/exhi/followers","following_url":"https://api.github.com/users/exhi/following{/other_user}","gists_url":"https://api.github.com/users/exhi/gists{/gist_id}","starred_url":"https://api.github.com/users/exhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exhi/subscriptions","organizations_url":"https://api.github.com/users/exhi/orgs","repos_url":"https://api.github.com/users/exhi/repos","events_url":"https://api.github.com/users/exhi/events{/privacy}","received_events_url":"https://api.github.com/users/exhi/received_events","type":"Organization","site_admin":false},"repo":{"id":117733567,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3MzM1Njc=","name":"hoist-react","full_name":"exhi/hoist-react","private":false,"owner":{"login":"exhi","id":850311,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MDMxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/850311?v=4","gravatar_id":"","url":"https://api.github.com/users/exhi","html_url":"https://github.com/exhi","followers_url":"https://api.github.com/users/exhi/followers","following_url":"https://api.github.com/users/exhi/following{/other_user}","gists_url":"https://api.github.com/users/exhi/gists{/gist_id}","starred_url":"https://api.github.com/users/exhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exhi/subscriptions","organizations_url":"https://api.github.com/users/exhi/orgs","repos_url":"https://api.github.com/users/exhi/repos","events_url":"https://api.github.com/users/exhi/events{/privacy}","received_events_url":"https://api.github.com/users/exhi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/exhi/hoist-react","description":"🏗️ ⚛️ Hoist toolkit for building React applications.","fork":false,"url":"https://api.github.com/repos/exhi/hoist-react","forks_url":"https://api.github.com/repos/exhi/hoist-react/forks","keys_url":"https://api.github.com/repos/exhi/hoist-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exhi/hoist-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exhi/hoist-react/teams","hooks_url":"https://api.github.com/repos/exhi/hoist-react/hooks","issue_events_url":"https://api.github.com/repos/exhi/hoist-react/issues/events{/number}","events_url":"https://api.github.com/repos/exhi/hoist-react/events","assignees_url":"https://api.github.com/repos/exhi/hoist-react/assignees{/user}","branches_url":"https://api.github.com/repos/exhi/hoist-react/branches{/branch}","tags_url":"https://api.github.com/repos/exhi/hoist-react/tags","blobs_url":"https://api.github.com/repos/exhi/hoist-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exhi/hoist-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exhi/hoist-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/exhi/hoist-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exhi/hoist-react/statuses/{sha}","languages_url":"https://api.github.com/repos/exhi/hoist-react/languages","stargazers_url":"https://api.github.com/repos/exhi/hoist-react/stargazers","contributors_url":"https://api.github.com/repos/exhi/hoist-react/contributors","subscribers_url":"https://api.github.com/repos/exhi/hoist-react/subscribers","subscription_url":"https://api.github.com/repos/exhi/hoist-react/subscription","commits_url":"https://api.github.com/repos/exhi/hoist-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/exhi/hoist-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/exhi/hoist-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/exhi/hoist-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/exhi/hoist-react/contents/{+path}","compare_url":"https://api.github.com/repos/exhi/hoist-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exhi/hoist-react/merges","archive_url":"https://api.github.com/repos/exhi/hoist-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exhi/hoist-react/downloads","issues_url":"https://api.github.com/repos/exhi/hoist-react/issues{/number}","pulls_url":"https://api.github.com/repos/exhi/hoist-react/pulls{/number}","milestones_url":"https://api.github.com/repos/exhi/hoist-react/milestones{/number}","notifications_url":"https://api.github.com/repos/exhi/hoist-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exhi/hoist-react/labels{/name}","releases_url":"https://api.github.com/repos/exhi/hoist-react/releases{/id}","deployments_url":"https://api.github.com/repos/exhi/hoist-react/deployments","created_at":"2018-01-16T19:50:49Z","updated_at":"2018-09-26T02:59:15Z","pushed_at":"2018-09-26T02:59:20Z","git_url":"git://github.com/exhi/hoist-react.git","ssh_url":"git@github.com:exhi/hoist-react.git","clone_url":"https://github.com/exhi/hoist-react.git","svn_url":"https://github.com/exhi/hoist-react","homepage":"https://xh.io","size":2161,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":43,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/608"},"html":{"href":"https://github.com/exhi/hoist-react/pull/608"},"issue":{"href":"https://api.github.com/repos/exhi/hoist-react/issues/608"},"comments":{"href":"https://api.github.com/repos/exhi/hoist-react/issues/608/comments"},"review_comments":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/608/comments"},"review_comment":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exhi/hoist-react/pulls/608/commits"},"statuses":{"href":"https://api.github.com/repos/exhi/hoist-react/statuses/5146b15e46724a458e07967df726b7a4015a1536"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lbwexler"}}