{"push_id":2872682813,"size":5,"distinct_size":5,"ref":"refs/heads/rollup","head":"8cdc6e614e848bac5a116241cc51477db5323c52","before":"9af125d248659d16246279b03a521b8c53a183d6","commits":[{"sha":"f7fa67cea13efdacfc82389f6f592bb4bda86a2e","author":{"name":"Jordan Rhee","email":"47dce742baa0f83253d225fafd19a7ceeefffbc4@microsoft.com"},"message":"Add target thumbv7a-pc-windows-msvc","distinct":true,"url":"https://api.github.com/repos/kennytm/rust/commits/f7fa67cea13efdacfc82389f6f592bb4bda86a2e"},{"sha":"b081a49a0701e6d95bc868a526138bc7a3cf6d46","author":{"name":"Jordan Rhee","email":"47dce742baa0f83253d225fafd19a7ceeefffbc4@microsoft.com"},"message":"Removed hardcoded paths and unnecessary LLVM features","distinct":true,"url":"https://api.github.com/repos/kennytm/rust/commits/b081a49a0701e6d95bc868a526138bc7a3cf6d46"},{"sha":"54a16aea6a3b6a765ebf1821d339456c87f6e82c","author":{"name":"Jordan Rhee","email":"47dce742baa0f83253d225fafd19a7ceeefffbc4@microsoft.com"},"message":"Fix tidy errors","distinct":true,"url":"https://api.github.com/repos/kennytm/rust/commits/54a16aea6a3b6a765ebf1821d339456c87f6e82c"},{"sha":"fd41c390534e15c223200031c93a10173046ebfa","author":{"name":"Jordan Rhee","email":"47dce742baa0f83253d225fafd19a7ceeefffbc4@microsoft.com"},"message":"Expand comments in thumbv7a-pc-windows-msvc target spec","distinct":true,"url":"https://api.github.com/repos/kennytm/rust/commits/fd41c390534e15c223200031c93a10173046ebfa"},{"sha":"8cdc6e614e848bac5a116241cc51477db5323c52","author":{"name":"kennytm","email":"d10ee62456d8e2be8715605d23b69b7662d1915a@gmail.com"},"message":"Rollup merge of #53621 - jordanrh1:windows-arm, r=alexcrichton\n\nAdd target thumbv7a-pc-windows-msvc\n\nThis is an early draft of support for Windows/ARM. To test it,\n\n1. Install Visual Studio 2017 and Windows SDK version 17134.\n1. Obtain alexcrichton/xz2-rs#35, rust-lang-nursery/compiler-builtins#256, and the fix for [LLVM Bug 38620](https://bugs.llvm.org/show_bug.cgi?id=38620).\n2. Open a command prompt and run\n```\nset CC_thumbv7a-pc-windows-msvc=C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Enterprise\\VC\\Tools\\MSVC\\14.11.25503\\bin\\HostX64\\arm\\CL.exe\nset CFLAGS_thumbv7a-pc-windows-msvc=/D_ARM_WINAPI_PARTITION_DESKTOP_SDK_AVAILABLE=1 /nologo\nc:\\python27\\python.exe x.py build --host x86_64-pc-windows-msvc --build x86_64-pc-windows-msvc --target thumbv7a-pc-windows-msvc\n```\n\nIt will build the stage 2 compiler, but fail building stage 2 test. To build an executable targeting windows/arm,\n1. Copy `build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe` to `build\\x86_64-pc-windows-msvc\\stage2\\bin`\n2. Open a command prompt and run\n```\n\"C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Enterprise\\VC\\Auxiliary\\Build\\vcvars64.bat\"\nset PATH=build\\x86_64-pc-windows-msvc\\stage2\\bin;%PATH%\ncargo new hello\ncd hello\ncargo build --target thumbv7a-pc-windows-msvc –release\n```\n\nCopy target\\thumbv7a-pc-windows-msvc\\release\\hello.exe to your platform and run.\n\nThere are a number of open issues that I'm hoping to get help with:\n\n - Error when compiling the `test` crate: `error: cannot link together two panic runtimes: panic_abort and panic_unwind`\n - Warnings when building the compiler_builtins crate: `warning: cl : Command line warning D9002 : ignoring unknown option '-fvisibility=hidden'`. It looks like the build system is passing GCC-style flags to MSVC.\n - How to specify the LIBPATH entries for ARM. Right now they are hardcoded as absolute paths in the target spec.\n\nThis pull request depends on\n - alexcrichton/xz2-rs#35 - update vcxproj to Visual Studio 2017\n - rust-lang-nursery/compiler-builtins#256 - fix compile errors when building for windows/arm\n - [Bug 38620 - ARM: Incorrect COFF relocation type for thumb bl instruction](https://bugs.llvm.org/show_bug.cgi?id=38620)\n\nThis PR updates #52659","distinct":true,"url":"https://api.github.com/repos/kennytm/rust/commits/8cdc6e614e848bac5a116241cc51477db5323c52"}]}
{"actor":{"display_login":"kennytm"}}