{"action":"created","issue":{"url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/329","repository_url":"https://api.github.com/repos/onfido/onfido-sdk-ui","labels_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/329/labels{/name}","comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/329/comments","events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/329/events","html_url":"https://github.com/onfido/onfido-sdk-ui/pull/329","id":317636981,"number":329,"title":"Header and Footer refactoring","user":{"login":"stefaniacardenas","id":7127427,"avatar_url":"https://avatars1.githubusercontent.com/u/7127427?v=4","gravatar_id":"","url":"https://api.github.com/users/stefaniacardenas","html_url":"https://github.com/stefaniacardenas","followers_url":"https://api.github.com/users/stefaniacardenas/followers","following_url":"https://api.github.com/users/stefaniacardenas/following{/other_user}","gists_url":"https://api.github.com/users/stefaniacardenas/gists{/gist_id}","starred_url":"https://api.github.com/users/stefaniacardenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefaniacardenas/subscriptions","organizations_url":"https://api.github.com/users/stefaniacardenas/orgs","repos_url":"https://api.github.com/users/stefaniacardenas/repos","events_url":"https://api.github.com/users/stefaniacardenas/events{/privacy}","received_events_url":"https://api.github.com/users/stefaniacardenas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-04-25T13:49:59Z","updated_at":"2018-04-30T17:37:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/329","html_url":"https://github.com/onfido/onfido-sdk-ui/pull/329","diff_url":"https://github.com/onfido/onfido-sdk-ui/pull/329.diff","patch_url":"https://github.com/onfido/onfido-sdk-ui/pull/329.patch"},"body":"# Problem\r\n\r\nAt the moment the JS SDK displays the \"powered by Onfido\" logo at the bottom of each screen, as it was a footer. The logo is not enclosed in a footer div and is currently just a background image within the main container `.onfido-sdk-ui-Modal-inner`, this means that the logo is not a DOM element in itself and therefore it doesn't occupy any space, resulting in other elements often overriding or covering it.\r\n\r\nThis is an issue when implementing new screens as we have to be extra careful not to cover the \"powered by Onfido\" logo and it creates inconsistency in the UI of different screens. \r\nThis is also an issue when the content needs to be spread evenly between the header and the footer or when we need to use flexbox.\r\n\r\n# Solution\r\n\r\nThe \"powered by Onfido\" logo  should be enclosed in a footer that is placed at the bottom of each screens. It should work on the following scenarios:\r\n\r\n* Standard Mode, where the content is contained between the header and the footer, ie on Desktop where the main container is smaller than the viewport\r\n* Scrollable Mode, where content needs to be scrollable, ie document select screen on small screens\r\n* Full Screen mode, where footer and back button will be displayed as an overlay\r\n\r\nThe Full Screen mode will be implemented as part of the Live Capture feature. For now, this mode can be tested as a dummy screen by adding `?liveCapture=true` to the url.\r\n\r\n## Checklist\r\n_put `n/a` if item is not relevant to PR changes_\r\n\r\n- [n/a] Have the CHANGELOG, README, MIGRATION, RELEASE_GUIDELINES docs been updated?\r\n- [n/a] Have new automated tests been implemented?\r\n- [n/a] Have new manual tests been written down?\r\n- [x] Have tests passed locally?\r\n- [n/a] Have any new strings been translated?\r\n"},"comment":{"url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/comments/385472539","html_url":"https://github.com/onfido/onfido-sdk-ui/pull/329#issuecomment-385472539","issue_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/329","id":385472539,"user":{"login":"rfreitas","id":651348,"avatar_url":"https://avatars3.githubusercontent.com/u/651348?v=4","gravatar_id":"","url":"https://api.github.com/users/rfreitas","html_url":"https://github.com/rfreitas","followers_url":"https://api.github.com/users/rfreitas/followers","following_url":"https://api.github.com/users/rfreitas/following{/other_user}","gists_url":"https://api.github.com/users/rfreitas/gists{/gist_id}","starred_url":"https://api.github.com/users/rfreitas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfreitas/subscriptions","organizations_url":"https://api.github.com/users/rfreitas/orgs","repos_url":"https://api.github.com/users/rfreitas/repos","events_url":"https://api.github.com/users/rfreitas/events{/privacy}","received_events_url":"https://api.github.com/users/rfreitas/received_events","type":"User","site_admin":false},"created_at":"2018-04-30T17:37:56Z","updated_at":"2018-04-30T17:37:56Z","author_association":"CONTRIBUTOR","body":"Travis automatic deployment: https://staging-329-pr-onfido-sdk-ui-onfido.surge.sh"}}
{"actor":{"display_login":"rfreitas"}}