{"action":"created","comment":{"url":"https://api.github.com/repos/google/play-instant-unity-plugin/pulls/comments/190721300","pull_request_review_id":123158822,"id":190721300,"diff_hunk":"@@ -0,0 +1,82 @@\n+// Copyright 2018 Google LLC\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     https://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+#if UNITY_2018_1_OR_NEWER\n+using System;\n+using System.IO;\n+using System.Xml.Linq;\n+using UnityEditor;\n+using UnityEditor.Android;\n+using UnityEngine;\n+\n+namespace GooglePlayInstant.Editor.AndroidManifest\n+{\n+    /// <summary>\n+    /// An IAndroidManifestUpdater for Unity 2018+ that obtains the AndroidManifest.xml after it is fully merged\n+    /// but before the build occurs and updates it according to whether this is a Play Instant build.\n+    /// </summary>\n+    public class PostGenerateGradleProjectAndroidManifestUpdater : IAndroidManifestUpdater,\n+        IPostGenerateGradleAndroidProject\n+    {\n+        public int callbackOrder\n+        {\n+            get { return 100; }\n+        }\n+\n+        public void OnPostGenerateGradleAndroidProject(string path)\n+        {\n+            if (!PlayInstantBuildConfiguration.IsPlayInstantScriptingSymbolDefined())\n+            {\n+                return;\n+            }\n+\n+            var x = new AndroidTargetDeviceARMv7();","path":"GooglePlayInstant/Editor/AndroidManifest/PostGenerateGradleProjectAndroidManifestUpdater.cs","position":null,"original_position":44,"commit_id":"017c5ca38d0e239b582e72018e858c9480c15848","original_commit_id":"915f4e89e7e071be208fab21b66146e4c1c8a446","user":{"login":"thanwah","id":38674020,"avatar_url":"https://avatars2.githubusercontent.com/u/38674020?v=4","gravatar_id":"","url":"https://api.github.com/users/thanwah","html_url":"https://github.com/thanwah","followers_url":"https://api.github.com/users/thanwah/followers","following_url":"https://api.github.com/users/thanwah/following{/other_user}","gists_url":"https://api.github.com/users/thanwah/gists{/gist_id}","starred_url":"https://api.github.com/users/thanwah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thanwah/subscriptions","organizations_url":"https://api.github.com/users/thanwah/orgs","repos_url":"https://api.github.com/users/thanwah/repos","events_url":"https://api.github.com/users/thanwah/events{/privacy}","received_events_url":"https://api.github.com/users/thanwah/received_events","type":"User","site_admin":false},"body":"Oops! Great catch! Fixed.","created_at":"2018-05-24T20:31:16Z","updated_at":"2018-05-24T20:53:22Z","html_url":"https://github.com/google/play-instant-unity-plugin/pull/3#discussion_r190721300","pull_request_url":"https://api.github.com/repos/google/play-instant-unity-plugin/pulls/3","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/play-instant-unity-plugin/pulls/comments/190721300"},"html":{"href":"https://github.com/google/play-instant-unity-plugin/pull/3#discussion_r190721300"},"pull_request":{"href":"https://api.github.com/repos/google/play-instant-unity-plugin/pulls/3"}},"in_reply_to_id":190655236},"pull_request":{"url":"https://api.github.com/repos/google/play-instant-unity-plugin/pulls/3","id":189832848,"html_url":"https://github.com/google/play-instant-unity-plugin/pull/3","diff_url":"https://github.com/google/play-instant-unity-plugin/pull/3.diff","patch_url":"https://github.com/google/play-instant-unity-plugin/pull/3.patch","issue_url":"https://api.github.com/repos/google/play-instant-unity-plugin/issues/3","number":3,"state":"open","locked":false,"title":"Add a \"Build and Run\" feature","user":{"login":"thanwah","id":38674020,"avatar_url":"https://avatars2.githubusercontent.com/u/38674020?v=4","gravatar_id":"","url":"https://api.github.com/users/thanwah","html_url":"https://github.com/thanwah","followers_url":"https://api.github.com/users/thanwah/followers","following_url":"https://api.github.com/users/thanwah/following{/other_user}","gists_url":"https://api.github.com/users/thanwah/gists{/gist_id}","starred_url":"https://api.github.com/users/thanwah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thanwah/subscriptions","organizations_url":"https://api.github.com/users/thanwah/orgs","repos_url":"https://api.github.com/users/thanwah/repos","events_url":"https://api.github.com/users/thanwah/events{/privacy}","received_events_url":"https://api.github.com/users/thanwah/received_events","type":"User","site_admin":false},"body":"The \"Build\" step calls Unity's BuildPlayer to create an APK in a temp\r\ndirectory. The \"Run\" step pushes that APK to an ADB connected\r\ndevice and runs it as an instant app.\r\n\r\nWith Unity 2017.x an AndroidManifest.xml is created/updated in\r\nAssets/Plugins/Android/. With Unity 2018.1+ the manifest is updated\r\ndynamically during the gradle build.","created_at":"2018-05-23T01:19:44Z","updated_at":"2018-05-24T20:53:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82d189380990ef8f07aed51c6af6bd3604071ef4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"manivaradarajan","id":39422644,"avatar_url":"https://avatars0.githubusercontent.com/u/39422644?v=4","gravatar_id":"","url":"https://api.github.com/users/manivaradarajan","html_url":"https://github.com/manivaradarajan","followers_url":"https://api.github.com/users/manivaradarajan/followers","following_url":"https://api.github.com/users/manivaradarajan/following{/other_user}","gists_url":"https://api.github.com/users/manivaradarajan/gists{/gist_id}","starred_url":"https://api.github.com/users/manivaradarajan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manivaradarajan/subscriptions","organizations_url":"https://api.github.com/users/manivaradarajan/orgs","repos_url":"https://api.github.com/users/manivaradarajan/repos","events_url":"https://api.github.com/users/manivaradarajan/events{/privacy}","received_events_url":"https://api.github.com/users/manivaradarajan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/play-instant-unity-plugin/pulls/3/commits","review_comments_url":"https://api.github.com/repos/google/play-instant-unity-plugin/pulls/3/comments","review_comment_url":"https://api.github.com/repos/google/play-instant-unity-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/play-instant-unity-plugin/issues/3/comments","statuses_url":"https://api.github.com/repos/google/play-instant-unity-plugin/statuses/017c5ca38d0e239b582e72018e858c9480c15848","head":{"label":"google:buildrun","ref":"buildrun","sha":"017c5ca38d0e239b582e72018e858c9480c15848","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":133990583,"name":"play-instant-unity-plugin","full_name":"google/play-instant-unity-plugin","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/play-instant-unity-plugin","description":"The Google Play Instant Plugin for Unity Beta : Simplifies conversion of a Unity-based Android app into an instant app that can be deployed through Google Play Instant.","fork":false,"url":"https://api.github.com/repos/google/play-instant-unity-plugin","forks_url":"https://api.github.com/repos/google/play-instant-unity-plugin/forks","keys_url":"https://api.github.com/repos/google/play-instant-unity-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/play-instant-unity-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/play-instant-unity-plugin/teams","hooks_url":"https://api.github.com/repos/google/play-instant-unity-plugin/hooks","issue_events_url":"https://api.github.com/repos/google/play-instant-unity-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/google/play-instant-unity-plugin/events","assignees_url":"https://api.github.com/repos/google/play-instant-unity-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/google/play-instant-unity-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/google/play-instant-unity-plugin/tags","blobs_url":"https://api.github.com/repos/google/play-instant-unity-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/play-instant-unity-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/play-instant-unity-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/play-instant-unity-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/play-instant-unity-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/google/play-instant-unity-plugin/languages","stargazers_url":"https://api.github.com/repos/google/play-instant-unity-plugin/stargazers","contributors_url":"https://api.github.com/repos/google/play-instant-unity-plugin/contributors","subscribers_url":"https://api.github.com/repos/google/play-instant-unity-plugin/subscribers","subscription_url":"https://api.github.com/repos/google/play-instant-unity-plugin/subscription","commits_url":"https://api.github.com/repos/google/play-instant-unity-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/play-instant-unity-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/play-instant-unity-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/play-instant-unity-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/play-instant-unity-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/google/play-instant-unity-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/play-instant-unity-plugin/merges","archive_url":"https://api.github.com/repos/google/play-instant-unity-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/play-instant-unity-plugin/downloads","issues_url":"https://api.github.com/repos/google/play-instant-unity-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/google/play-instant-unity-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/google/play-instant-unity-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/google/play-instant-unity-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/play-instant-unity-plugin/labels{/name}","releases_url":"https://api.github.com/repos/google/play-instant-unity-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/google/play-instant-unity-plugin/deployments","created_at":"2018-05-18T18:28:57Z","updated_at":"2018-05-23T01:20:51Z","pushed_at":"2018-05-24T20:51:41Z","git_url":"git://github.com/google/play-instant-unity-plugin.git","ssh_url":"git@github.com:google/play-instant-unity-plugin.git","clone_url":"https://github.com/google/play-instant-unity-plugin.git","svn_url":"https://github.com/google/play-instant-unity-plugin","homepage":"","size":62,"stargazers_count":9,"watchers_count":9,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":2,"watchers":9,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"c6ec0b1e0879979b42bc6b20720c15daac2f14d9","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":133990583,"name":"play-instant-unity-plugin","full_name":"google/play-instant-unity-plugin","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/play-instant-unity-plugin","description":"The Google Play Instant Plugin for Unity Beta : Simplifies conversion of a Unity-based Android app into an instant app that can be deployed through Google Play Instant.","fork":false,"url":"https://api.github.com/repos/google/play-instant-unity-plugin","forks_url":"https://api.github.com/repos/google/play-instant-unity-plugin/forks","keys_url":"https://api.github.com/repos/google/play-instant-unity-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/play-instant-unity-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/play-instant-unity-plugin/teams","hooks_url":"https://api.github.com/repos/google/play-instant-unity-plugin/hooks","issue_events_url":"https://api.github.com/repos/google/play-instant-unity-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/google/play-instant-unity-plugin/events","assignees_url":"https://api.github.com/repos/google/play-instant-unity-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/google/play-instant-unity-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/google/play-instant-unity-plugin/tags","blobs_url":"https://api.github.com/repos/google/play-instant-unity-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/play-instant-unity-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/play-instant-unity-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/play-instant-unity-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/play-instant-unity-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/google/play-instant-unity-plugin/languages","stargazers_url":"https://api.github.com/repos/google/play-instant-unity-plugin/stargazers","contributors_url":"https://api.github.com/repos/google/play-instant-unity-plugin/contributors","subscribers_url":"https://api.github.com/repos/google/play-instant-unity-plugin/subscribers","subscription_url":"https://api.github.com/repos/google/play-instant-unity-plugin/subscription","commits_url":"https://api.github.com/repos/google/play-instant-unity-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/play-instant-unity-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/play-instant-unity-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/play-instant-unity-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/play-instant-unity-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/google/play-instant-unity-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/play-instant-unity-plugin/merges","archive_url":"https://api.github.com/repos/google/play-instant-unity-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/play-instant-unity-plugin/downloads","issues_url":"https://api.github.com/repos/google/play-instant-unity-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/google/play-instant-unity-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/google/play-instant-unity-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/google/play-instant-unity-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/play-instant-unity-plugin/labels{/name}","releases_url":"https://api.github.com/repos/google/play-instant-unity-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/google/play-instant-unity-plugin/deployments","created_at":"2018-05-18T18:28:57Z","updated_at":"2018-05-23T01:20:51Z","pushed_at":"2018-05-24T20:51:41Z","git_url":"git://github.com/google/play-instant-unity-plugin.git","ssh_url":"git@github.com:google/play-instant-unity-plugin.git","clone_url":"https://github.com/google/play-instant-unity-plugin.git","svn_url":"https://github.com/google/play-instant-unity-plugin","homepage":"","size":62,"stargazers_count":9,"watchers_count":9,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":2,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/play-instant-unity-plugin/pulls/3"},"html":{"href":"https://github.com/google/play-instant-unity-plugin/pull/3"},"issue":{"href":"https://api.github.com/repos/google/play-instant-unity-plugin/issues/3"},"comments":{"href":"https://api.github.com/repos/google/play-instant-unity-plugin/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/google/play-instant-unity-plugin/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/google/play-instant-unity-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/play-instant-unity-plugin/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/google/play-instant-unity-plugin/statuses/017c5ca38d0e239b582e72018e858c9480c15848"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"thanwah"}}