{"action":"created","issue":{"url":"https://api.github.com/repos/includable/react-native-map-link/issues/30","repository_url":"https://api.github.com/repos/includable/react-native-map-link","labels_url":"https://api.github.com/repos/includable/react-native-map-link/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/includable/react-native-map-link/issues/30/comments","events_url":"https://api.github.com/repos/includable/react-native-map-link/issues/30/events","html_url":"https://github.com/includable/react-native-map-link/pull/30","id":330924721,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzk5Njk2","number":30,"title":"Adding apps white list prop to Popup Component","user":{"login":"gbahamondezc","id":22915623,"node_id":"MDQ6VXNlcjIyOTE1NjIz","avatar_url":"https://avatars2.githubusercontent.com/u/22915623?v=4","gravatar_id":"","url":"https://api.github.com/users/gbahamondezc","html_url":"https://github.com/gbahamondezc","followers_url":"https://api.github.com/users/gbahamondezc/followers","following_url":"https://api.github.com/users/gbahamondezc/following{/other_user}","gists_url":"https://api.github.com/users/gbahamondezc/gists{/gist_id}","starred_url":"https://api.github.com/users/gbahamondezc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbahamondezc/subscriptions","organizations_url":"https://api.github.com/users/gbahamondezc/orgs","repos_url":"https://api.github.com/users/gbahamondezc/repos","events_url":"https://api.github.com/users/gbahamondezc/events{/privacy}","received_events_url":"https://api.github.com/users/gbahamondezc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-06-09T22:50:07Z","updated_at":"2018-06-11T18:30:54Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/includable/react-native-map-link/pulls/30","html_url":"https://github.com/includable/react-native-map-link/pull/30","diff_url":"https://github.com/includable/react-native-map-link/pull/30.diff","patch_url":"https://github.com/includable/react-native-map-link/pull/30.patch"},"body":"- Adding apps whitelist filtering in Popup Component\r\n- Updating README with appsWhiteList property\r\n- Adding intellij and vscode config folders to gitignore\r\n\r\n#29 "},"comment":{"url":"https://api.github.com/repos/includable/react-native-map-link/issues/comments/396341143","html_url":"https://github.com/includable/react-native-map-link/pull/30#issuecomment-396341143","issue_url":"https://api.github.com/repos/includable/react-native-map-link/issues/30","id":396341143,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjM0MTE0Mw==","user":{"login":"gbahamondezc","id":22915623,"node_id":"MDQ6VXNlcjIyOTE1NjIz","avatar_url":"https://avatars2.githubusercontent.com/u/22915623?v=4","gravatar_id":"","url":"https://api.github.com/users/gbahamondezc","html_url":"https://github.com/gbahamondezc","followers_url":"https://api.github.com/users/gbahamondezc/followers","following_url":"https://api.github.com/users/gbahamondezc/following{/other_user}","gists_url":"https://api.github.com/users/gbahamondezc/gists{/gist_id}","starred_url":"https://api.github.com/users/gbahamondezc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbahamondezc/subscriptions","organizations_url":"https://api.github.com/users/gbahamondezc/orgs","repos_url":"https://api.github.com/users/gbahamondezc/repos","events_url":"https://api.github.com/users/gbahamondezc/events{/privacy}","received_events_url":"https://api.github.com/users/gbahamondezc/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T18:30:54Z","updated_at":"2018-06-11T18:30:54Z","author_association":"NONE","body":"@johanleroch i agree in that a enum-like constant with the valid app names can be useful. \r\n\r\nBut anyway it not solves the problem in this particular case, since the implementer still can just ignore the ENUM and use strings.\r\n\r\n@tschoffelen just to understand, what's are the downsides for you of using enum-like stuff in JS?\r\n\r\nIndependent of the decision about  use or not enum-like stuff,  based in your opinions, i think  that a validation of the elements in the  `appsWhiteList` property throwing a exception if some element is not a valid app,  is necessary in both implementations.\r\n\r\n@tschoffelen @johanleroch what do you think?"}}
{"actor":{"display_login":"gbahamondezc"}}