{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/22556","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/22556/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/22556/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/22556/events","html_url":"https://github.com/nodejs/node/pull/22556","id":354472868,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjI3MTMz","number":22556,"title":"errors: add useOriginalName to internal/errors","user":{"login":"joyeecheung","id":4299420,"node_id":"MDQ6VXNlcjQyOTk0MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4299420?v=4","gravatar_id":"","url":"https://api.github.com/users/joyeecheung","html_url":"https://github.com/joyeecheung","followers_url":"https://api.github.com/users/joyeecheung/followers","following_url":"https://api.github.com/users/joyeecheung/following{/other_user}","gists_url":"https://api.github.com/users/joyeecheung/gists{/gist_id}","starred_url":"https://api.github.com/users/joyeecheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyeecheung/subscriptions","organizations_url":"https://api.github.com/users/joyeecheung/orgs","repos_url":"https://api.github.com/users/joyeecheung/repos","events_url":"https://api.github.com/users/joyeecheung/events{/privacy}","received_events_url":"https://api.github.com/users/joyeecheung/received_events","type":"User","site_admin":false},"labels":[{"id":458724661,"node_id":"MDU6TGFiZWw0NTg3MjQ2NjE=","url":"https://api.github.com/repos/nodejs/node/labels/errors","name":"errors","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-08-27T20:49:15Z","updated_at":"2018-08-28T17:06:35Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/22556","html_url":"https://github.com/nodejs/node/pull/22556","diff_url":"https://github.com/nodejs/node/pull/22556.diff","patch_url":"https://github.com/nodejs/node/pull/22556.patch"},"body":"This allows us to tell the type of the errors without using\r\ninstanceof, which is necessary in WPT harness.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/416665223","html_url":"https://github.com/nodejs/node/pull/22556#issuecomment-416665223","issue_url":"https://api.github.com/repos/nodejs/node/issues/22556","id":416665223,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjY2NTIyMw==","user":{"login":"jdalton","id":4303,"node_id":"MDQ6VXNlcjQzMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/4303?v=4","gravatar_id":"","url":"https://api.github.com/users/jdalton","html_url":"https://github.com/jdalton","followers_url":"https://api.github.com/users/jdalton/followers","following_url":"https://api.github.com/users/jdalton/following{/other_user}","gists_url":"https://api.github.com/users/jdalton/gists{/gist_id}","starred_url":"https://api.github.com/users/jdalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdalton/subscriptions","organizations_url":"https://api.github.com/users/jdalton/orgs","repos_url":"https://api.github.com/users/jdalton/repos","events_url":"https://api.github.com/users/jdalton/events{/privacy}","received_events_url":"https://api.github.com/users/jdalton/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T17:06:35Z","updated_at":"2018-08-28T17:06:35Z","author_association":"MEMBER","body":"This is a test harness concern and not worth moving into exposed APIs. I've given you a path forward that doesn't involving touching Node error APIs. Depending on where the fault is you can file a bug on WPT or work with Node to correct its errors. If it requires a major bump for Node then so be it. The WPT tests can be held until then."}}
{"actor":{"display_login":"jdalton"}}