{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/238983046","pull_request_review_id":181654042,"id":238983046,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODk4MzA0Ng==","diff_hunk":"@@ -97,23 +98,29 @@\n \n SWITCH_SCHEMA = vol.Schema({vol.Optional(CONF_ZONE_RUN_TIME): cv.positive_int})\n \n-CONFIG_SCHEMA = vol.Schema(\n-    {\n-        DOMAIN:\n-        vol.Schema({\n-            vol.Required(CONF_IP_ADDRESS): cv.string,\n-            vol.Required(CONF_PASSWORD): cv.string,\n-            vol.Optional(CONF_PORT, default=DEFAULT_PORT): cv.port,\n-            vol.Optional(CONF_SSL, default=DEFAULT_SSL): cv.boolean,\n-            vol.Optional(CONF_SCAN_INTERVAL, default=DEFAULT_SCAN_INTERVAL):\n-                cv.time_period,\n-            vol.Optional(CONF_BINARY_SENSORS, default={}):\n-                BINARY_SENSOR_SCHEMA,\n-            vol.Optional(CONF_SENSORS, default={}): SENSOR_SCHEMA,\n-            vol.Optional(CONF_SWITCHES, default={}): SWITCH_SCHEMA,\n-        })\n-    },\n-    extra=vol.ALLOW_EXTRA)\n+\n+CONTROLLER_SCHEMA = vol.Schema({\n+    DOMAIN: vol.Schema({","path":"homeassistant/components/rainmachine/__init__.py","position":48,"original_position":48,"commit_id":"e1df665657dadcdeca10856b584c2cfe9247b3de","original_commit_id":"e1df665657dadcdeca10856b584c2cfe9247b3de","user":{"login":"MartinHjelmare","id":3181692,"node_id":"MDQ6VXNlcjMxODE2OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/3181692?v=4","gravatar_id":"","url":"https://api.github.com/users/MartinHjelmare","html_url":"https://github.com/MartinHjelmare","followers_url":"https://api.github.com/users/MartinHjelmare/followers","following_url":"https://api.github.com/users/MartinHjelmare/following{/other_user}","gists_url":"https://api.github.com/users/MartinHjelmare/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinHjelmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinHjelmare/subscriptions","organizations_url":"https://api.github.com/users/MartinHjelmare/orgs","repos_url":"https://api.github.com/users/MartinHjelmare/repos","events_url":"https://api.github.com/users/MartinHjelmare/events{/privacy}","received_events_url":"https://api.github.com/users/MartinHjelmare/received_events","type":"User","site_admin":false},"body":"Remove this nesting and domain key. That's not correct. This might be what has been bugging us.","created_at":"2018-12-05T09:17:27Z","updated_at":"2018-12-05T09:17:35Z","html_url":"https://github.com/home-assistant/home-assistant/pull/18989#discussion_r238983046","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/18989","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/238983046"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/18989#discussion_r238983046"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/18989"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/18989","id":235628919,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NjI4OTE5","html_url":"https://github.com/home-assistant/home-assistant/pull/18989","diff_url":"https://github.com/home-assistant/home-assistant/pull/18989.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/18989.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/18989","number":18989,"state":"open","locked":false,"title":"Add support for multiple RainMachine controllers","user":{"login":"bachya","id":47216,"node_id":"MDQ6VXNlcjQ3MjE2","avatar_url":"https://avatars3.githubusercontent.com/u/47216?v=4","gravatar_id":"","url":"https://api.github.com/users/bachya","html_url":"https://github.com/bachya","followers_url":"https://api.github.com/users/bachya/followers","following_url":"https://api.github.com/users/bachya/following{/other_user}","gists_url":"https://api.github.com/users/bachya/gists{/gist_id}","starred_url":"https://api.github.com/users/bachya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachya/subscriptions","organizations_url":"https://api.github.com/users/bachya/orgs","repos_url":"https://api.github.com/users/bachya/repos","events_url":"https://api.github.com/users/bachya/events{/privacy}","received_events_url":"https://api.github.com/users/bachya/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\nEven though multiple RainMachine controllers can be added via config UI, the same use case can't be accommodated via `configuration.yaml`. This PR rectifies that.\r\n\r\n**BREAKING CHANGE:** the `configuration.yaml` format changes to the below.\r\n\r\n**Related issue (if applicable):** N/A\r\n\r\n**Pull request in [home-assistant.io](https://github.com/home-assistant/home-assistant.io) with documentation (if applicable):** https://github.com/home-assistant/home-assistant.io/pull/7721\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\nrainmachine:\r\n  controllers:\r\n    - ip_address: !secret rainmachine_ip_address\r\n      password: !secret rainmachine_password\r\n```\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n  - [x] There is no commented out code in this PR.\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [x] Documentation added/updated in [home-assistant.io](https://github.com/home-assistant/home-assistant.io)\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2018-12-03T23:31:49Z","updated_at":"2018-12-05T09:17:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4a698b7b3e3c12ef1a692e285ef4f51795227d3","assignee":{"login":"bachya","id":47216,"node_id":"MDQ6VXNlcjQ3MjE2","avatar_url":"https://avatars3.githubusercontent.com/u/47216?v=4","gravatar_id":"","url":"https://api.github.com/users/bachya","html_url":"https://github.com/bachya","followers_url":"https://api.github.com/users/bachya/followers","following_url":"https://api.github.com/users/bachya/following{/other_user}","gists_url":"https://api.github.com/users/bachya/gists{/gist_id}","starred_url":"https://api.github.com/users/bachya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachya/subscriptions","organizations_url":"https://api.github.com/users/bachya/orgs","repos_url":"https://api.github.com/users/bachya/repos","events_url":"https://api.github.com/users/bachya/events{/privacy}","received_events_url":"https://api.github.com/users/bachya/received_events","type":"User","site_admin":false},"assignees":[{"login":"bachya","id":47216,"node_id":"MDQ6VXNlcjQ3MjE2","avatar_url":"https://avatars3.githubusercontent.com/u/47216?v=4","gravatar_id":"","url":"https://api.github.com/users/bachya","html_url":"https://github.com/bachya","followers_url":"https://api.github.com/users/bachya/followers","following_url":"https://api.github.com/users/bachya/following{/other_user}","gists_url":"https://api.github.com/users/bachya/gists{/gist_id}","starred_url":"https://api.github.com/users/bachya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachya/subscriptions","organizations_url":"https://api.github.com/users/bachya/orgs","repos_url":"https://api.github.com/users/bachya/repos","events_url":"https://api.github.com/users/bachya/events{/privacy}","received_events_url":"https://api.github.com/users/bachya/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":457646398,"node_id":"MDU6TGFiZWw0NTc2NDYzOTg=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/breaking%20change","name":"breaking change","color":"d93f0b","default":false},{"id":527871105,"node_id":"MDU6TGFiZWw1Mjc4NzExMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":914301406,"node_id":"MDU6TGFiZWw5MTQzMDE0MDY=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20rainmachine","name":"component: rainmachine","color":"ededed","default":false},{"id":955422305,"node_id":"MDU6TGFiZWw5NTU0MjIzMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/18989/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/18989/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/18989/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/e1df665657dadcdeca10856b584c2cfe9247b3de","head":{"label":"bachya:multiple-rainmachine","ref":"multiple-rainmachine","sha":"e1df665657dadcdeca10856b584c2cfe9247b3de","user":{"login":"bachya","id":47216,"node_id":"MDQ6VXNlcjQ3MjE2","avatar_url":"https://avatars3.githubusercontent.com/u/47216?v=4","gravatar_id":"","url":"https://api.github.com/users/bachya","html_url":"https://github.com/bachya","followers_url":"https://api.github.com/users/bachya/followers","following_url":"https://api.github.com/users/bachya/following{/other_user}","gists_url":"https://api.github.com/users/bachya/gists{/gist_id}","starred_url":"https://api.github.com/users/bachya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachya/subscriptions","organizations_url":"https://api.github.com/users/bachya/orgs","repos_url":"https://api.github.com/users/bachya/repos","events_url":"https://api.github.com/users/bachya/events{/privacy}","received_events_url":"https://api.github.com/users/bachya/received_events","type":"User","site_admin":false},"repo":{"id":99717341,"node_id":"MDEwOlJlcG9zaXRvcnk5OTcxNzM0MQ==","name":"home-assistant","full_name":"bachya/home-assistant","private":false,"owner":{"login":"bachya","id":47216,"node_id":"MDQ6VXNlcjQ3MjE2","avatar_url":"https://avatars3.githubusercontent.com/u/47216?v=4","gravatar_id":"","url":"https://api.github.com/users/bachya","html_url":"https://github.com/bachya","followers_url":"https://api.github.com/users/bachya/followers","following_url":"https://api.github.com/users/bachya/following{/other_user}","gists_url":"https://api.github.com/users/bachya/gists{/gist_id}","starred_url":"https://api.github.com/users/bachya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachya/subscriptions","organizations_url":"https://api.github.com/users/bachya/orgs","repos_url":"https://api.github.com/users/bachya/repos","events_url":"https://api.github.com/users/bachya/events{/privacy}","received_events_url":"https://api.github.com/users/bachya/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bachya/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/bachya/home-assistant","forks_url":"https://api.github.com/repos/bachya/home-assistant/forks","keys_url":"https://api.github.com/repos/bachya/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bachya/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bachya/home-assistant/teams","hooks_url":"https://api.github.com/repos/bachya/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/bachya/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/bachya/home-assistant/events","assignees_url":"https://api.github.com/repos/bachya/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/bachya/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/bachya/home-assistant/tags","blobs_url":"https://api.github.com/repos/bachya/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bachya/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bachya/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/bachya/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bachya/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/bachya/home-assistant/languages","stargazers_url":"https://api.github.com/repos/bachya/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/bachya/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/bachya/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/bachya/home-assistant/subscription","commits_url":"https://api.github.com/repos/bachya/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/bachya/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/bachya/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/bachya/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/bachya/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/bachya/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bachya/home-assistant/merges","archive_url":"https://api.github.com/repos/bachya/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bachya/home-assistant/downloads","issues_url":"https://api.github.com/repos/bachya/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/bachya/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/bachya/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/bachya/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bachya/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/bachya/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/bachya/home-assistant/deployments","created_at":"2017-08-08T17:09:51Z","updated_at":"2018-12-03T22:13:06Z","pushed_at":"2018-12-04T18:50:24Z","git_url":"git://github.com/bachya/home-assistant.git","ssh_url":"git@github.com:bachya/home-assistant.git","clone_url":"https://github.com/bachya/home-assistant.git","svn_url":"https://github.com/bachya/home-assistant","homepage":"https://home-assistant.io","size":94776,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":1,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"b5e7e45f6cc8f968007f194f1bef8cbbb9cc6c1a","user":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4ODk5Mw==","name":"home-assistant","full_name":"home-assistant/home-assistant","private":false,"owner":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open source home automation that puts local control and privacy first","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-12-05T08:30:49Z","pushed_at":"2018-12-05T08:35:27Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://www.home-assistant.io","size":94860,"stargazers_count":19005,"watchers_count":19005,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5582,"mirror_url":null,"archived":false,"open_issues_count":1022,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5582,"open_issues":1022,"watchers":19005,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/18989"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/18989"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/18989"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/18989/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/18989/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/18989/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/e1df665657dadcdeca10856b584c2cfe9247b3de"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MartinHjelmare"}}