{"action":"created","comment":{"url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments/180149765","pull_request_review_id":110520521,"id":180149765,"diff_hunk":"@@ -138,6 +138,9 @@ export default class MediaController extends Eventable {\n                 // Start firing visualQuality once playback has started\n                 mediaModel.off(MEDIA_VISUAL_QUALITY, null, this);\n                 mediaModel.change(MEDIA_VISUAL_QUALITY, (changedMediaModel, eventData) => {\n+                    if (!eventData) {\n+                        return;","path":"src/js/program/media-controller.js","position":5,"original_position":5,"commit_id":"378222dc5ddaa58db677761ef946722d34b78edf","original_commit_id":"378222dc5ddaa58db677761ef946722d34b78edf","user":{"login":"robwalch","id":333258,"avatar_url":"https://avatars1.githubusercontent.com/u/333258?v=4","gravatar_id":"","url":"https://api.github.com/users/robwalch","html_url":"https://github.com/robwalch","followers_url":"https://api.github.com/users/robwalch/followers","following_url":"https://api.github.com/users/robwalch/following{/other_user}","gists_url":"https://api.github.com/users/robwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/robwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robwalch/subscriptions","organizations_url":"https://api.github.com/users/robwalch/orgs","repos_url":"https://api.github.com/users/robwalch/repos","events_url":"https://api.github.com/users/robwalch/events{/privacy}","received_events_url":"https://api.github.com/users/robwalch/received_events","type":"User","site_admin":false},"body":"Providers should not dispatch visualQuality events without data. The guard should be in the provider before \"visualQuality\" is set on mediaModel.","created_at":"2018-04-09T16:15:46Z","updated_at":"2018-04-09T16:16:14Z","html_url":"https://github.com/jwplayer/jwplayer/pull/2832#discussion_r180149765","pull_request_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2832","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments/180149765"},"html":{"href":"https://github.com/jwplayer/jwplayer/pull/2832#discussion_r180149765"},"pull_request":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2832"}}},"pull_request":{"url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2832","id":180357078,"html_url":"https://github.com/jwplayer/jwplayer/pull/2832","diff_url":"https://github.com/jwplayer/jwplayer/pull/2832.diff","patch_url":"https://github.com/jwplayer/jwplayer/pull/2832.patch","issue_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/2832","number":2832,"state":"open","locked":false,"title":"Add guard check for visualQuality Event","user":{"login":"DanFerrer","id":6787010,"avatar_url":"https://avatars1.githubusercontent.com/u/6787010?v=4","gravatar_id":"","url":"https://api.github.com/users/DanFerrer","html_url":"https://github.com/DanFerrer","followers_url":"https://api.github.com/users/DanFerrer/followers","following_url":"https://api.github.com/users/DanFerrer/following{/other_user}","gists_url":"https://api.github.com/users/DanFerrer/gists{/gist_id}","starred_url":"https://api.github.com/users/DanFerrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanFerrer/subscriptions","organizations_url":"https://api.github.com/users/DanFerrer/orgs","repos_url":"https://api.github.com/users/DanFerrer/repos","events_url":"https://api.github.com/users/DanFerrer/events{/privacy}","received_events_url":"https://api.github.com/users/DanFerrer/received_events","type":"User","site_admin":false},"body":"### This PR will...\r\n\r\nOnly trigger visualQuality event in media-controller if the eventData argument isn't a falsy value.\r\n\r\n### Why is this Pull Request needed?\r\n\r\nAn empty visualQuality event is triggered in HLS when preload is set to \"none\" on play attempt. The eventData argument that would be passed in when it's triggered returns null. We dont know the actual visualQuality until the adaptation event fires\r\n\r\n### Are there any points in the code the reviewer needs to double check?\r\n\r\n### Are there any Pull Requests open in other repos which need to be merged with this?\r\n\r\n#### Addresses Issue(s):\r\n\r\nJW8-1404\r\n\r\n","created_at":"2018-04-09T16:10:22Z","updated_at":"2018-04-09T16:16:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abde5200043956443a70ad7b60ac001bd6a3a99b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"johnBartos","id":5042276,"avatar_url":"https://avatars1.githubusercontent.com/u/5042276?v=4","gravatar_id":"","url":"https://api.github.com/users/johnBartos","html_url":"https://github.com/johnBartos","followers_url":"https://api.github.com/users/johnBartos/followers","following_url":"https://api.github.com/users/johnBartos/following{/other_user}","gists_url":"https://api.github.com/users/johnBartos/gists{/gist_id}","starred_url":"https://api.github.com/users/johnBartos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnBartos/subscriptions","organizations_url":"https://api.github.com/users/johnBartos/orgs","repos_url":"https://api.github.com/users/johnBartos/repos","events_url":"https://api.github.com/users/johnBartos/events{/privacy}","received_events_url":"https://api.github.com/users/johnBartos/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":89434456,"url":"https://api.github.com/repos/jwplayer/jwplayer/labels/bug","name":"bug","color":"f7c6c7","default":true},{"id":226546376,"url":"https://api.github.com/repos/jwplayer/jwplayer/labels/needs-review","name":"needs-review","color":"ededed","default":false}],"milestone":{"url":"https://api.github.com/repos/jwplayer/jwplayer/milestones/88","html_url":"https://github.com/jwplayer/jwplayer/milestone/88","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones/88/labels","id":3205022,"number":88,"title":"v8.3.0","description":null,"creator":{"login":"robwalch","id":333258,"avatar_url":"https://avatars1.githubusercontent.com/u/333258?v=4","gravatar_id":"","url":"https://api.github.com/users/robwalch","html_url":"https://github.com/robwalch","followers_url":"https://api.github.com/users/robwalch/followers","following_url":"https://api.github.com/users/robwalch/following{/other_user}","gists_url":"https://api.github.com/users/robwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/robwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robwalch/subscriptions","organizations_url":"https://api.github.com/users/robwalch/orgs","repos_url":"https://api.github.com/users/robwalch/repos","events_url":"https://api.github.com/users/robwalch/events{/privacy}","received_events_url":"https://api.github.com/users/robwalch/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":10,"state":"open","created_at":"2018-03-20T23:32:27Z","updated_at":"2018-04-09T16:10:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2832/commits","review_comments_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2832/comments","review_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/2832/comments","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/378222dc5ddaa58db677761ef946722d34b78edf","head":{"label":"jwplayer:bugfix/invalid-visual-quality-hls","ref":"bugfix/invalid-visual-quality-hls","sha":"378222dc5ddaa58db677761ef946722d34b78edf","user":{"login":"jwplayer","id":5090060,"avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"repo":{"id":18307175,"name":"jwplayer","full_name":"jwplayer/jwplayer","owner":{"login":"jwplayer","id":5090060,"avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jwplayer/jwplayer","description":"JW Player is the world's most popular embeddable media player.","fork":false,"url":"https://api.github.com/repos/jwplayer/jwplayer","forks_url":"https://api.github.com/repos/jwplayer/jwplayer/forks","keys_url":"https://api.github.com/repos/jwplayer/jwplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwplayer/jwplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwplayer/jwplayer/teams","hooks_url":"https://api.github.com/repos/jwplayer/jwplayer/hooks","issue_events_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/events{/number}","events_url":"https://api.github.com/repos/jwplayer/jwplayer/events","assignees_url":"https://api.github.com/repos/jwplayer/jwplayer/assignees{/user}","branches_url":"https://api.github.com/repos/jwplayer/jwplayer/branches{/branch}","tags_url":"https://api.github.com/repos/jwplayer/jwplayer/tags","blobs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwplayer/jwplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwplayer/jwplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/jwplayer/jwplayer/languages","stargazers_url":"https://api.github.com/repos/jwplayer/jwplayer/stargazers","contributors_url":"https://api.github.com/repos/jwplayer/jwplayer/contributors","subscribers_url":"https://api.github.com/repos/jwplayer/jwplayer/subscribers","subscription_url":"https://api.github.com/repos/jwplayer/jwplayer/subscription","commits_url":"https://api.github.com/repos/jwplayer/jwplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwplayer/jwplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwplayer/jwplayer/contents/{+path}","compare_url":"https://api.github.com/repos/jwplayer/jwplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwplayer/jwplayer/merges","archive_url":"https://api.github.com/repos/jwplayer/jwplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwplayer/jwplayer/downloads","issues_url":"https://api.github.com/repos/jwplayer/jwplayer/issues{/number}","pulls_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/jwplayer/jwplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/labels{/name}","releases_url":"https://api.github.com/repos/jwplayer/jwplayer/releases{/id}","deployments_url":"https://api.github.com/repos/jwplayer/jwplayer/deployments","created_at":"2014-03-31T20:34:20Z","updated_at":"2018-04-09T15:42:41Z","pushed_at":"2018-04-09T16:10:23Z","git_url":"git://github.com/jwplayer/jwplayer.git","ssh_url":"git@github.com:jwplayer/jwplayer.git","clone_url":"https://github.com/jwplayer/jwplayer.git","svn_url":"https://github.com/jwplayer/jwplayer","homepage":"https://developer.jwplayer.com/","size":85780,"stargazers_count":1593,"watchers_count":1593,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":707,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":707,"open_issues":77,"watchers":1593,"default_branch":"master"}},"base":{"label":"jwplayer:master","ref":"master","sha":"be3ae807f1ca29f3b820abc7a63debcb4202aa2e","user":{"login":"jwplayer","id":5090060,"avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"repo":{"id":18307175,"name":"jwplayer","full_name":"jwplayer/jwplayer","owner":{"login":"jwplayer","id":5090060,"avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jwplayer/jwplayer","description":"JW Player is the world's most popular embeddable media player.","fork":false,"url":"https://api.github.com/repos/jwplayer/jwplayer","forks_url":"https://api.github.com/repos/jwplayer/jwplayer/forks","keys_url":"https://api.github.com/repos/jwplayer/jwplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwplayer/jwplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwplayer/jwplayer/teams","hooks_url":"https://api.github.com/repos/jwplayer/jwplayer/hooks","issue_events_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/events{/number}","events_url":"https://api.github.com/repos/jwplayer/jwplayer/events","assignees_url":"https://api.github.com/repos/jwplayer/jwplayer/assignees{/user}","branches_url":"https://api.github.com/repos/jwplayer/jwplayer/branches{/branch}","tags_url":"https://api.github.com/repos/jwplayer/jwplayer/tags","blobs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwplayer/jwplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwplayer/jwplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/jwplayer/jwplayer/languages","stargazers_url":"https://api.github.com/repos/jwplayer/jwplayer/stargazers","contributors_url":"https://api.github.com/repos/jwplayer/jwplayer/contributors","subscribers_url":"https://api.github.com/repos/jwplayer/jwplayer/subscribers","subscription_url":"https://api.github.com/repos/jwplayer/jwplayer/subscription","commits_url":"https://api.github.com/repos/jwplayer/jwplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwplayer/jwplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwplayer/jwplayer/contents/{+path}","compare_url":"https://api.github.com/repos/jwplayer/jwplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwplayer/jwplayer/merges","archive_url":"https://api.github.com/repos/jwplayer/jwplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwplayer/jwplayer/downloads","issues_url":"https://api.github.com/repos/jwplayer/jwplayer/issues{/number}","pulls_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/jwplayer/jwplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/labels{/name}","releases_url":"https://api.github.com/repos/jwplayer/jwplayer/releases{/id}","deployments_url":"https://api.github.com/repos/jwplayer/jwplayer/deployments","created_at":"2014-03-31T20:34:20Z","updated_at":"2018-04-09T15:42:41Z","pushed_at":"2018-04-09T16:10:23Z","git_url":"git://github.com/jwplayer/jwplayer.git","ssh_url":"git@github.com:jwplayer/jwplayer.git","clone_url":"https://github.com/jwplayer/jwplayer.git","svn_url":"https://github.com/jwplayer/jwplayer","homepage":"https://developer.jwplayer.com/","size":85780,"stargazers_count":1593,"watchers_count":1593,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":707,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":707,"open_issues":77,"watchers":1593,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2832"},"html":{"href":"https://github.com/jwplayer/jwplayer/pull/2832"},"issue":{"href":"https://api.github.com/repos/jwplayer/jwplayer/issues/2832"},"comments":{"href":"https://api.github.com/repos/jwplayer/jwplayer/issues/2832/comments"},"review_comments":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2832/comments"},"review_comment":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2832/commits"},"statuses":{"href":"https://api.github.com/repos/jwplayer/jwplayer/statuses/378222dc5ddaa58db677761ef946722d34b78edf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robwalch"}}