{"action":"created","comment":{"url":"https://api.github.com/repos/chef/chef/pulls/comments/244626759","pull_request_review_id":188545434,"id":244626759,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDYyNjc1OQ==","diff_hunk":"@@ -756,50 +705,12 @@ def converge_and_save(run_context)\n         begin\n           save_updated_node\n         rescue Exception => e\n-          raise e if Chef::Config[:audit_mode] == :disabled\n-          converge_exception = e\n+          raise e","path":"lib/chef/client.rb","position":150,"original_position":150,"commit_id":"126b2a5f2c4535ac1c170e817faa8de80ab72a0d","original_commit_id":"126b2a5f2c4535ac1c170e817faa8de80ab72a0d","user":{"login":"lamont-granquist","id":454857,"node_id":"MDQ6VXNlcjQ1NDg1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/454857?v=4","gravatar_id":"","url":"https://api.github.com/users/lamont-granquist","html_url":"https://github.com/lamont-granquist","followers_url":"https://api.github.com/users/lamont-granquist/followers","following_url":"https://api.github.com/users/lamont-granquist/following{/other_user}","gists_url":"https://api.github.com/users/lamont-granquist/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont-granquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont-granquist/subscriptions","organizations_url":"https://api.github.com/users/lamont-granquist/orgs","repos_url":"https://api.github.com/users/lamont-granquist/repos","events_url":"https://api.github.com/users/lamont-granquist/events{/privacy}","received_events_url":"https://api.github.com/users/lamont-granquist/received_events","type":"User","site_admin":false},"body":"```\r\ndef converge_and_save(run_context)\r\n  converge_exception = converge(run_context)\r\n  unless converge_exception\r\n    save_updated_node\r\n  end\r\n  converge_exception\r\nend\r\n```\r\n\r\ni don't particularly like the way that the node save looks like it clobbers the shit out of the converge exception, but i think that is backwards compatible with what we've always done.","created_at":"2019-01-01T01:52:59Z","updated_at":"2019-01-01T01:52:59Z","html_url":"https://github.com/chef/chef/pull/7728#discussion_r244626759","pull_request_url":"https://api.github.com/repos/chef/chef/pulls/7728","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/chef/chef/pulls/comments/244626759"},"html":{"href":"https://github.com/chef/chef/pull/7728#discussion_r244626759"},"pull_request":{"href":"https://api.github.com/repos/chef/chef/pulls/7728"}},"in_reply_to_id":244623453},"pull_request":{"url":"https://api.github.com/repos/chef/chef/pulls/7728","id":220861722,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODYxNzIy","html_url":"https://github.com/chef/chef/pull/7728","diff_url":"https://github.com/chef/chef/pull/7728.diff","patch_url":"https://github.com/chef/chef/pull/7728.patch","issue_url":"https://api.github.com/repos/chef/chef/issues/7728","number":7728,"state":"open","locked":false,"title":"Remove audit mode from chef-client","user":{"login":"tas50","id":1015200,"node_id":"MDQ6VXNlcjEwMTUyMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1015200?v=4","gravatar_id":"","url":"https://api.github.com/users/tas50","html_url":"https://github.com/tas50","followers_url":"https://api.github.com/users/tas50/followers","following_url":"https://api.github.com/users/tas50/following{/other_user}","gists_url":"https://api.github.com/users/tas50/gists{/gist_id}","starred_url":"https://api.github.com/users/tas50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tas50/subscriptions","organizations_url":"https://api.github.com/users/tas50/orgs","repos_url":"https://api.github.com/users/tas50/repos","events_url":"https://api.github.com/users/tas50/events{/privacy}","received_events_url":"https://api.github.com/users/tas50/received_events","type":"User","site_admin":false},"body":"This just gives us a line count to the change and perhaps a starting\r\npoint for when we do this in Chef 15\r\n\r\nSigned-off-by: Tim Smith <tsmith@chef.io>","created_at":"2018-10-06T03:22:21Z","updated_at":"2019-01-01T01:52:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"480fcde15a3b62d5955c4eec6be06290370e986d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chef/chef/pulls/7728/commits","review_comments_url":"https://api.github.com/repos/chef/chef/pulls/7728/comments","review_comment_url":"https://api.github.com/repos/chef/chef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef/issues/7728/comments","statuses_url":"https://api.github.com/repos/chef/chef/statuses/126b2a5f2c4535ac1c170e817faa8de80ab72a0d","head":{"label":"chef:audit","ref":"audit","sha":"126b2a5f2c4535ac1c170e817faa8de80ab72a0d","user":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":108278,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgyNzg=","name":"chef","full_name":"chef/chef","private":false,"owner":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chef/chef","description":"A systems integration framework, built to bring the benefits of configuration management to your entire infrastructure.","fork":false,"url":"https://api.github.com/repos/chef/chef","forks_url":"https://api.github.com/repos/chef/chef/forks","keys_url":"https://api.github.com/repos/chef/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef/teams","hooks_url":"https://api.github.com/repos/chef/chef/hooks","issue_events_url":"https://api.github.com/repos/chef/chef/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef/events","assignees_url":"https://api.github.com/repos/chef/chef/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef/tags","blobs_url":"https://api.github.com/repos/chef/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef/languages","stargazers_url":"https://api.github.com/repos/chef/chef/stargazers","contributors_url":"https://api.github.com/repos/chef/chef/contributors","subscribers_url":"https://api.github.com/repos/chef/chef/subscribers","subscription_url":"https://api.github.com/repos/chef/chef/subscription","commits_url":"https://api.github.com/repos/chef/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef/merges","archive_url":"https://api.github.com/repos/chef/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef/downloads","issues_url":"https://api.github.com/repos/chef/chef/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef/releases{/id}","deployments_url":"https://api.github.com/repos/chef/chef/deployments","created_at":"2009-01-15T20:40:48Z","updated_at":"2018-12-31T21:36:22Z","pushed_at":"2019-01-01T00:51:44Z","git_url":"git://github.com/chef/chef.git","ssh_url":"git@github.com:chef/chef.git","clone_url":"https://github.com/chef/chef.git","svn_url":"https://github.com/chef/chef","homepage":"http://www.chef.io/chef/","size":108861,"stargazers_count":5619,"watchers_count":5619,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2276,"mirror_url":null,"archived":false,"open_issues_count":559,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2276,"open_issues":559,"watchers":5619,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"201ced07b525141caf6c6f04c9837a9934d9746f","user":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":108278,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgyNzg=","name":"chef","full_name":"chef/chef","private":false,"owner":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chef/chef","description":"A systems integration framework, built to bring the benefits of configuration management to your entire infrastructure.","fork":false,"url":"https://api.github.com/repos/chef/chef","forks_url":"https://api.github.com/repos/chef/chef/forks","keys_url":"https://api.github.com/repos/chef/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef/teams","hooks_url":"https://api.github.com/repos/chef/chef/hooks","issue_events_url":"https://api.github.com/repos/chef/chef/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef/events","assignees_url":"https://api.github.com/repos/chef/chef/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef/tags","blobs_url":"https://api.github.com/repos/chef/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef/languages","stargazers_url":"https://api.github.com/repos/chef/chef/stargazers","contributors_url":"https://api.github.com/repos/chef/chef/contributors","subscribers_url":"https://api.github.com/repos/chef/chef/subscribers","subscription_url":"https://api.github.com/repos/chef/chef/subscription","commits_url":"https://api.github.com/repos/chef/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef/merges","archive_url":"https://api.github.com/repos/chef/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef/downloads","issues_url":"https://api.github.com/repos/chef/chef/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef/releases{/id}","deployments_url":"https://api.github.com/repos/chef/chef/deployments","created_at":"2009-01-15T20:40:48Z","updated_at":"2018-12-31T21:36:22Z","pushed_at":"2019-01-01T00:51:44Z","git_url":"git://github.com/chef/chef.git","ssh_url":"git@github.com:chef/chef.git","clone_url":"https://github.com/chef/chef.git","svn_url":"https://github.com/chef/chef","homepage":"http://www.chef.io/chef/","size":108861,"stargazers_count":5619,"watchers_count":5619,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2276,"mirror_url":null,"archived":false,"open_issues_count":559,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2276,"open_issues":559,"watchers":5619,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef/pulls/7728"},"html":{"href":"https://github.com/chef/chef/pull/7728"},"issue":{"href":"https://api.github.com/repos/chef/chef/issues/7728"},"comments":{"href":"https://api.github.com/repos/chef/chef/issues/7728/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef/pulls/7728/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef/pulls/7728/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef/statuses/126b2a5f2c4535ac1c170e817faa8de80ab72a0d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lamont-granquist"}}