{"action":"created","comment":{"url":"https://api.github.com/repos/kirasystems/compojure-throttle/pulls/comments/217473373","pull_request_review_id":155193850,"id":217473373,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzQ3MzM3Mw==","diff_hunk":"@@ -61,18 +70,19 @@\n   (:remote-addr req))\n \n (defn throttle\n-\"Throttle incoming connections from a given source. By default this is based on IP.\n-\n-Optionally takes a second argument which is a function used to lookup the 'token'\n-that determines whether or not the request is unique. For example a function that\n-returns a user token to limit by user id rather than ip. This function should accept\n-the request as its single argument\"\n-([finder handler]\n+  \"Throttle incoming connections from a given source. By default this is based on IP.\n+  \n+  Optionally takes a second argument which is a function used to lookup the 'token'\n+  that determines whether or not the request is unique. For example a function that\n+  returns a user token to limit by user id rather than ip. This function should accept\n+  the request as its single argument\"","path":"src/compojure_throttle/core.clj","position":83,"original_position":79,"commit_id":"d44f9018d25e139cc12925f4b783f8591a962074","original_commit_id":"46ec98d83732c861e6b5225101aa8dec6b3769f5","user":{"login":"MatthewDarling","id":1369423,"node_id":"MDQ6VXNlcjEzNjk0MjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1369423?v=4","gravatar_id":"","url":"https://api.github.com/users/MatthewDarling","html_url":"https://github.com/MatthewDarling","followers_url":"https://api.github.com/users/MatthewDarling/followers","following_url":"https://api.github.com/users/MatthewDarling/following{/other_user}","gists_url":"https://api.github.com/users/MatthewDarling/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewDarling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewDarling/subscriptions","organizations_url":"https://api.github.com/users/MatthewDarling/orgs","repos_url":"https://api.github.com/users/MatthewDarling/repos","events_url":"https://api.github.com/users/MatthewDarling/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewDarling/received_events","type":"User","site_admin":false},"body":"Ah, so it's just for our servers talking to each other. Not having special permissions for random other servers does simplify things.\r\n\r\nHow do we guarantee we're always in the same subnet? Part of being in a single VPC in AWS, I guess?","created_at":"2018-09-13T17:39:43Z","updated_at":"2018-09-13T17:39:43Z","html_url":"https://github.com/kirasystems/compojure-throttle/pull/1#discussion_r217473373","pull_request_url":"https://api.github.com/repos/kirasystems/compojure-throttle/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kirasystems/compojure-throttle/pulls/comments/217473373"},"html":{"href":"https://github.com/kirasystems/compojure-throttle/pull/1#discussion_r217473373"},"pull_request":{"href":"https://api.github.com/repos/kirasystems/compojure-throttle/pulls/1"}},"in_reply_to_id":217184573},"pull_request":{"url":"https://api.github.com/repos/kirasystems/compojure-throttle/pulls/1","id":215077482,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDc3NDgy","html_url":"https://github.com/kirasystems/compojure-throttle/pull/1","diff_url":"https://github.com/kirasystems/compojure-throttle/pull/1.diff","patch_url":"https://github.com/kirasystems/compojure-throttle/pull/1.patch","issue_url":"https://api.github.com/repos/kirasystems/compojure-throttle/issues/1","number":1,"state":"open","locked":false,"title":"[DEV-874] selective throttling","user":{"login":"Elknar","id":4155077,"node_id":"MDQ6VXNlcjQxNTUwNzc=","avatar_url":"https://avatars0.githubusercontent.com/u/4155077?v=4","gravatar_id":"","url":"https://api.github.com/users/Elknar","html_url":"https://github.com/Elknar","followers_url":"https://api.github.com/users/Elknar/followers","following_url":"https://api.github.com/users/Elknar/following{/other_user}","gists_url":"https://api.github.com/users/Elknar/gists{/gist_id}","starred_url":"https://api.github.com/users/Elknar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elknar/subscriptions","organizations_url":"https://api.github.com/users/Elknar/orgs","repos_url":"https://api.github.com/users/Elknar/repos","events_url":"https://api.github.com/users/Elknar/events{/privacy}","received_events_url":"https://api.github.com/users/Elknar/received_events","type":"User","site_admin":false},"body":"Disabling the throttler now requires a valid subnet (`:service-compojure-throttle-lax-ips`) to be specified in addition to setting the `:service-compojure-throttle-enabled` flag to false.\r\n\r\nOtherwise, the default behavior to disable the throttling will only disable it for `127.0.0.1`\r\n\r\n(also removed the snapshot from the version #)\r\n","created_at":"2018-09-12T19:57:02Z","updated_at":"2018-09-13T17:39:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcca4a94b24f5deb27ef6613bc04f02a371d4bb0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1054821754,"node_id":"MDU6TGFiZWwxMDU0ODIxNzU0","url":"https://api.github.com/repos/kirasystems/compojure-throttle/labels/Security","name":"Security","color":"f7ce54","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kirasystems/compojure-throttle/pulls/1/commits","review_comments_url":"https://api.github.com/repos/kirasystems/compojure-throttle/pulls/1/comments","review_comment_url":"https://api.github.com/repos/kirasystems/compojure-throttle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kirasystems/compojure-throttle/issues/1/comments","statuses_url":"https://api.github.com/repos/kirasystems/compojure-throttle/statuses/d44f9018d25e139cc12925f4b783f8591a962074","head":{"label":"kirasystems:dev-874-selective-throttle","ref":"dev-874-selective-throttle","sha":"d44f9018d25e139cc12925f4b783f8591a962074","user":{"login":"kirasystems","id":852771,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1Mjc3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/852771?v=4","gravatar_id":"","url":"https://api.github.com/users/kirasystems","html_url":"https://github.com/kirasystems","followers_url":"https://api.github.com/users/kirasystems/followers","following_url":"https://api.github.com/users/kirasystems/following{/other_user}","gists_url":"https://api.github.com/users/kirasystems/gists{/gist_id}","starred_url":"https://api.github.com/users/kirasystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirasystems/subscriptions","organizations_url":"https://api.github.com/users/kirasystems/orgs","repos_url":"https://api.github.com/users/kirasystems/repos","events_url":"https://api.github.com/users/kirasystems/events{/privacy}","received_events_url":"https://api.github.com/users/kirasystems/received_events","type":"Organization","site_admin":false},"repo":{"id":147870685,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc4NzA2ODU=","name":"compojure-throttle","full_name":"kirasystems/compojure-throttle","owner":{"login":"kirasystems","id":852771,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1Mjc3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/852771?v=4","gravatar_id":"","url":"https://api.github.com/users/kirasystems","html_url":"https://github.com/kirasystems","followers_url":"https://api.github.com/users/kirasystems/followers","following_url":"https://api.github.com/users/kirasystems/following{/other_user}","gists_url":"https://api.github.com/users/kirasystems/gists{/gist_id}","starred_url":"https://api.github.com/users/kirasystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirasystems/subscriptions","organizations_url":"https://api.github.com/users/kirasystems/orgs","repos_url":"https://api.github.com/users/kirasystems/repos","events_url":"https://api.github.com/users/kirasystems/events{/privacy}","received_events_url":"https://api.github.com/users/kirasystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kirasystems/compojure-throttle","description":"A compojure middleware library that can throttle IPs or users","fork":true,"url":"https://api.github.com/repos/kirasystems/compojure-throttle","forks_url":"https://api.github.com/repos/kirasystems/compojure-throttle/forks","keys_url":"https://api.github.com/repos/kirasystems/compojure-throttle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kirasystems/compojure-throttle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kirasystems/compojure-throttle/teams","hooks_url":"https://api.github.com/repos/kirasystems/compojure-throttle/hooks","issue_events_url":"https://api.github.com/repos/kirasystems/compojure-throttle/issues/events{/number}","events_url":"https://api.github.com/repos/kirasystems/compojure-throttle/events","assignees_url":"https://api.github.com/repos/kirasystems/compojure-throttle/assignees{/user}","branches_url":"https://api.github.com/repos/kirasystems/compojure-throttle/branches{/branch}","tags_url":"https://api.github.com/repos/kirasystems/compojure-throttle/tags","blobs_url":"https://api.github.com/repos/kirasystems/compojure-throttle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kirasystems/compojure-throttle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kirasystems/compojure-throttle/git/refs{/sha}","trees_url":"https://api.github.com/repos/kirasystems/compojure-throttle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kirasystems/compojure-throttle/statuses/{sha}","languages_url":"https://api.github.com/repos/kirasystems/compojure-throttle/languages","stargazers_url":"https://api.github.com/repos/kirasystems/compojure-throttle/stargazers","contributors_url":"https://api.github.com/repos/kirasystems/compojure-throttle/contributors","subscribers_url":"https://api.github.com/repos/kirasystems/compojure-throttle/subscribers","subscription_url":"https://api.github.com/repos/kirasystems/compojure-throttle/subscription","commits_url":"https://api.github.com/repos/kirasystems/compojure-throttle/commits{/sha}","git_commits_url":"https://api.github.com/repos/kirasystems/compojure-throttle/git/commits{/sha}","comments_url":"https://api.github.com/repos/kirasystems/compojure-throttle/comments{/number}","issue_comment_url":"https://api.github.com/repos/kirasystems/compojure-throttle/issues/comments{/number}","contents_url":"https://api.github.com/repos/kirasystems/compojure-throttle/contents/{+path}","compare_url":"https://api.github.com/repos/kirasystems/compojure-throttle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kirasystems/compojure-throttle/merges","archive_url":"https://api.github.com/repos/kirasystems/compojure-throttle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kirasystems/compojure-throttle/downloads","issues_url":"https://api.github.com/repos/kirasystems/compojure-throttle/issues{/number}","pulls_url":"https://api.github.com/repos/kirasystems/compojure-throttle/pulls{/number}","milestones_url":"https://api.github.com/repos/kirasystems/compojure-throttle/milestones{/number}","notifications_url":"https://api.github.com/repos/kirasystems/compojure-throttle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kirasystems/compojure-throttle/labels{/name}","releases_url":"https://api.github.com/repos/kirasystems/compojure-throttle/releases{/id}","deployments_url":"https://api.github.com/repos/kirasystems/compojure-throttle/deployments","created_at":"2018-09-07T20:17:26Z","updated_at":"2018-09-07T20:17:29Z","pushed_at":"2018-09-13T17:36:41Z","git_url":"git://github.com/kirasystems/compojure-throttle.git","ssh_url":"git@github.com:kirasystems/compojure-throttle.git","clone_url":"https://github.com/kirasystems/compojure-throttle.git","svn_url":"https://github.com/kirasystems/compojure-throttle","homepage":null,"size":24,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kirasystems:master","ref":"master","sha":"38ecca33af2cbf78a32c83e5eb064afabe6abd3e","user":{"login":"kirasystems","id":852771,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1Mjc3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/852771?v=4","gravatar_id":"","url":"https://api.github.com/users/kirasystems","html_url":"https://github.com/kirasystems","followers_url":"https://api.github.com/users/kirasystems/followers","following_url":"https://api.github.com/users/kirasystems/following{/other_user}","gists_url":"https://api.github.com/users/kirasystems/gists{/gist_id}","starred_url":"https://api.github.com/users/kirasystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirasystems/subscriptions","organizations_url":"https://api.github.com/users/kirasystems/orgs","repos_url":"https://api.github.com/users/kirasystems/repos","events_url":"https://api.github.com/users/kirasystems/events{/privacy}","received_events_url":"https://api.github.com/users/kirasystems/received_events","type":"Organization","site_admin":false},"repo":{"id":147870685,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc4NzA2ODU=","name":"compojure-throttle","full_name":"kirasystems/compojure-throttle","owner":{"login":"kirasystems","id":852771,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1Mjc3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/852771?v=4","gravatar_id":"","url":"https://api.github.com/users/kirasystems","html_url":"https://github.com/kirasystems","followers_url":"https://api.github.com/users/kirasystems/followers","following_url":"https://api.github.com/users/kirasystems/following{/other_user}","gists_url":"https://api.github.com/users/kirasystems/gists{/gist_id}","starred_url":"https://api.github.com/users/kirasystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirasystems/subscriptions","organizations_url":"https://api.github.com/users/kirasystems/orgs","repos_url":"https://api.github.com/users/kirasystems/repos","events_url":"https://api.github.com/users/kirasystems/events{/privacy}","received_events_url":"https://api.github.com/users/kirasystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kirasystems/compojure-throttle","description":"A compojure middleware library that can throttle IPs or users","fork":true,"url":"https://api.github.com/repos/kirasystems/compojure-throttle","forks_url":"https://api.github.com/repos/kirasystems/compojure-throttle/forks","keys_url":"https://api.github.com/repos/kirasystems/compojure-throttle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kirasystems/compojure-throttle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kirasystems/compojure-throttle/teams","hooks_url":"https://api.github.com/repos/kirasystems/compojure-throttle/hooks","issue_events_url":"https://api.github.com/repos/kirasystems/compojure-throttle/issues/events{/number}","events_url":"https://api.github.com/repos/kirasystems/compojure-throttle/events","assignees_url":"https://api.github.com/repos/kirasystems/compojure-throttle/assignees{/user}","branches_url":"https://api.github.com/repos/kirasystems/compojure-throttle/branches{/branch}","tags_url":"https://api.github.com/repos/kirasystems/compojure-throttle/tags","blobs_url":"https://api.github.com/repos/kirasystems/compojure-throttle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kirasystems/compojure-throttle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kirasystems/compojure-throttle/git/refs{/sha}","trees_url":"https://api.github.com/repos/kirasystems/compojure-throttle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kirasystems/compojure-throttle/statuses/{sha}","languages_url":"https://api.github.com/repos/kirasystems/compojure-throttle/languages","stargazers_url":"https://api.github.com/repos/kirasystems/compojure-throttle/stargazers","contributors_url":"https://api.github.com/repos/kirasystems/compojure-throttle/contributors","subscribers_url":"https://api.github.com/repos/kirasystems/compojure-throttle/subscribers","subscription_url":"https://api.github.com/repos/kirasystems/compojure-throttle/subscription","commits_url":"https://api.github.com/repos/kirasystems/compojure-throttle/commits{/sha}","git_commits_url":"https://api.github.com/repos/kirasystems/compojure-throttle/git/commits{/sha}","comments_url":"https://api.github.com/repos/kirasystems/compojure-throttle/comments{/number}","issue_comment_url":"https://api.github.com/repos/kirasystems/compojure-throttle/issues/comments{/number}","contents_url":"https://api.github.com/repos/kirasystems/compojure-throttle/contents/{+path}","compare_url":"https://api.github.com/repos/kirasystems/compojure-throttle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kirasystems/compojure-throttle/merges","archive_url":"https://api.github.com/repos/kirasystems/compojure-throttle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kirasystems/compojure-throttle/downloads","issues_url":"https://api.github.com/repos/kirasystems/compojure-throttle/issues{/number}","pulls_url":"https://api.github.com/repos/kirasystems/compojure-throttle/pulls{/number}","milestones_url":"https://api.github.com/repos/kirasystems/compojure-throttle/milestones{/number}","notifications_url":"https://api.github.com/repos/kirasystems/compojure-throttle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kirasystems/compojure-throttle/labels{/name}","releases_url":"https://api.github.com/repos/kirasystems/compojure-throttle/releases{/id}","deployments_url":"https://api.github.com/repos/kirasystems/compojure-throttle/deployments","created_at":"2018-09-07T20:17:26Z","updated_at":"2018-09-07T20:17:29Z","pushed_at":"2018-09-13T17:36:41Z","git_url":"git://github.com/kirasystems/compojure-throttle.git","ssh_url":"git@github.com:kirasystems/compojure-throttle.git","clone_url":"https://github.com/kirasystems/compojure-throttle.git","svn_url":"https://github.com/kirasystems/compojure-throttle","homepage":null,"size":24,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kirasystems/compojure-throttle/pulls/1"},"html":{"href":"https://github.com/kirasystems/compojure-throttle/pull/1"},"issue":{"href":"https://api.github.com/repos/kirasystems/compojure-throttle/issues/1"},"comments":{"href":"https://api.github.com/repos/kirasystems/compojure-throttle/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/kirasystems/compojure-throttle/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/kirasystems/compojure-throttle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kirasystems/compojure-throttle/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/kirasystems/compojure-throttle/statuses/d44f9018d25e139cc12925f4b783f8591a962074"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"MatthewDarling"}}