{"action":"created","comment":{"url":"https://api.github.com/repos/hooroo/BudgetApp/pulls/comments/170789628","pull_request_review_id":99524263,"id":170789628,"diff_hunk":"@@ -0,0 +1,15 @@\n+require \"rails_helper\"\n+\n+feature \"admin deletes themselves\" do\n+  scenario \"and is logged out\" do\n+    user = create(:user, admin: true)\n+    log_in_as user\n+\n+    visit admin_users_path\n+    click_on I18n.t(\"admin.users.delete.submit\")\n+","path":"spec/features/admin/admin_deletes_themselves.rb","position":10,"original_position":10,"commit_id":"7db5aaddb484787b737679df174e2ac2f12caa40","original_commit_id":"7db5aaddb484787b737679df174e2ac2f12caa40","user":{"login":"elle","id":57038,"avatar_url":"https://avatars3.githubusercontent.com/u/57038?v=4","gravatar_id":"","url":"https://api.github.com/users/elle","html_url":"https://github.com/elle","followers_url":"https://api.github.com/users/elle/followers","following_url":"https://api.github.com/users/elle/following{/other_user}","gists_url":"https://api.github.com/users/elle/gists{/gist_id}","starred_url":"https://api.github.com/users/elle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elle/subscriptions","organizations_url":"https://api.github.com/users/elle/orgs","repos_url":"https://api.github.com/users/elle/repos","events_url":"https://api.github.com/users/elle/events{/privacy}","received_events_url":"https://api.github.com/users/elle/received_events","type":"User","site_admin":false},"body":"I would add one or two assertions here for `current_page` and the flash message.\r\n\r\nFor example: \r\n```\r\nexpect(current_path).to eq new_session_path\r\n```","created_at":"2018-02-27T01:16:44Z","updated_at":"2018-02-27T01:27:58Z","html_url":"https://github.com/hooroo/BudgetApp/pull/28#discussion_r170789628","pull_request_url":"https://api.github.com/repos/hooroo/BudgetApp/pulls/28","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hooroo/BudgetApp/pulls/comments/170789628"},"html":{"href":"https://github.com/hooroo/BudgetApp/pull/28#discussion_r170789628"},"pull_request":{"href":"https://api.github.com/repos/hooroo/BudgetApp/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/hooroo/BudgetApp/pulls/28","id":171198609,"html_url":"https://github.com/hooroo/BudgetApp/pull/28","diff_url":"https://github.com/hooroo/BudgetApp/pull/28.diff","patch_url":"https://github.com/hooroo/BudgetApp/pull/28.patch","issue_url":"https://api.github.com/repos/hooroo/BudgetApp/issues/28","number":28,"state":"open","locked":false,"title":"Ad admin namespace","user":{"login":"apalski","id":21995514,"avatar_url":"https://avatars0.githubusercontent.com/u/21995514?v=4","gravatar_id":"","url":"https://api.github.com/users/apalski","html_url":"https://github.com/apalski","followers_url":"https://api.github.com/users/apalski/followers","following_url":"https://api.github.com/users/apalski/following{/other_user}","gists_url":"https://api.github.com/users/apalski/gists{/gist_id}","starred_url":"https://api.github.com/users/apalski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apalski/subscriptions","organizations_url":"https://api.github.com/users/apalski/orgs","repos_url":"https://api.github.com/users/apalski/repos","events_url":"https://api.github.com/users/apalski/events{/privacy}","received_events_url":"https://api.github.com/users/apalski/received_events","type":"User","site_admin":false},"body":"PR to add admin namespace to project:\r\n- Alter user routes to have routes for admin.user and routes for user as single resource\r\n- Add admin.user controller and base controller\r\n- Move require_admin from application controller to base controller\r\n- Remove index and destroy actions from users controller\r\n- Refactor users controller sessions controller and their views and specs for single resource change\r\n- Add views for admin.users actions\r\n- Add I18n info to en.yml\r\n- Add feature and controller specs for admin.users\r\n- Add require \"database_cleaner\" to database_cleaner.rb\r\nLooking for feedback on all aspects of this PR.\r\nThank you for taking a look!\r\nhttps://trello.com/c/FaUppvfG\r\nhttps://trello.com/c/quGiX7HB\r\nhttps://trello.com/c/lVvnHLg2\r\nhttps://trello.com/c/beSx0rtg\r\n\r\n\r\n\r\n","created_at":"2018-02-24T21:30:53Z","updated_at":"2018-02-27T01:27:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab9a0a3b15be5df2a447332efb17c17da3def7c7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hooroo/BudgetApp/pulls/28/commits","review_comments_url":"https://api.github.com/repos/hooroo/BudgetApp/pulls/28/comments","review_comment_url":"https://api.github.com/repos/hooroo/BudgetApp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hooroo/BudgetApp/issues/28/comments","statuses_url":"https://api.github.com/repos/hooroo/BudgetApp/statuses/7db5aaddb484787b737679df174e2ac2f12caa40","head":{"label":"hooroo:ad-admin-namespace","ref":"ad-admin-namespace","sha":"7db5aaddb484787b737679df174e2ac2f12caa40","user":{"login":"hooroo","id":785479,"avatar_url":"https://avatars0.githubusercontent.com/u/785479?v=4","gravatar_id":"","url":"https://api.github.com/users/hooroo","html_url":"https://github.com/hooroo","followers_url":"https://api.github.com/users/hooroo/followers","following_url":"https://api.github.com/users/hooroo/following{/other_user}","gists_url":"https://api.github.com/users/hooroo/gists{/gist_id}","starred_url":"https://api.github.com/users/hooroo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hooroo/subscriptions","organizations_url":"https://api.github.com/users/hooroo/orgs","repos_url":"https://api.github.com/users/hooroo/repos","events_url":"https://api.github.com/users/hooroo/events{/privacy}","received_events_url":"https://api.github.com/users/hooroo/received_events","type":"Organization","site_admin":false},"repo":{"id":111200727,"name":"BudgetApp","full_name":"hooroo/BudgetApp","owner":{"login":"hooroo","id":785479,"avatar_url":"https://avatars0.githubusercontent.com/u/785479?v=4","gravatar_id":"","url":"https://api.github.com/users/hooroo","html_url":"https://github.com/hooroo","followers_url":"https://api.github.com/users/hooroo/followers","following_url":"https://api.github.com/users/hooroo/following{/other_user}","gists_url":"https://api.github.com/users/hooroo/gists{/gist_id}","starred_url":"https://api.github.com/users/hooroo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hooroo/subscriptions","organizations_url":"https://api.github.com/users/hooroo/orgs","repos_url":"https://api.github.com/users/hooroo/repos","events_url":"https://api.github.com/users/hooroo/events{/privacy}","received_events_url":"https://api.github.com/users/hooroo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hooroo/BudgetApp","description":"Rails JQuery React app to allow user to create and manage their budget","fork":false,"url":"https://api.github.com/repos/hooroo/BudgetApp","forks_url":"https://api.github.com/repos/hooroo/BudgetApp/forks","keys_url":"https://api.github.com/repos/hooroo/BudgetApp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hooroo/BudgetApp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hooroo/BudgetApp/teams","hooks_url":"https://api.github.com/repos/hooroo/BudgetApp/hooks","issue_events_url":"https://api.github.com/repos/hooroo/BudgetApp/issues/events{/number}","events_url":"https://api.github.com/repos/hooroo/BudgetApp/events","assignees_url":"https://api.github.com/repos/hooroo/BudgetApp/assignees{/user}","branches_url":"https://api.github.com/repos/hooroo/BudgetApp/branches{/branch}","tags_url":"https://api.github.com/repos/hooroo/BudgetApp/tags","blobs_url":"https://api.github.com/repos/hooroo/BudgetApp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hooroo/BudgetApp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hooroo/BudgetApp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hooroo/BudgetApp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hooroo/BudgetApp/statuses/{sha}","languages_url":"https://api.github.com/repos/hooroo/BudgetApp/languages","stargazers_url":"https://api.github.com/repos/hooroo/BudgetApp/stargazers","contributors_url":"https://api.github.com/repos/hooroo/BudgetApp/contributors","subscribers_url":"https://api.github.com/repos/hooroo/BudgetApp/subscribers","subscription_url":"https://api.github.com/repos/hooroo/BudgetApp/subscription","commits_url":"https://api.github.com/repos/hooroo/BudgetApp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hooroo/BudgetApp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hooroo/BudgetApp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hooroo/BudgetApp/issues/comments{/number}","contents_url":"https://api.github.com/repos/hooroo/BudgetApp/contents/{+path}","compare_url":"https://api.github.com/repos/hooroo/BudgetApp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hooroo/BudgetApp/merges","archive_url":"https://api.github.com/repos/hooroo/BudgetApp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hooroo/BudgetApp/downloads","issues_url":"https://api.github.com/repos/hooroo/BudgetApp/issues{/number}","pulls_url":"https://api.github.com/repos/hooroo/BudgetApp/pulls{/number}","milestones_url":"https://api.github.com/repos/hooroo/BudgetApp/milestones{/number}","notifications_url":"https://api.github.com/repos/hooroo/BudgetApp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hooroo/BudgetApp/labels{/name}","releases_url":"https://api.github.com/repos/hooroo/BudgetApp/releases{/id}","deployments_url":"https://api.github.com/repos/hooroo/BudgetApp/deployments","created_at":"2017-11-18T11:39:32Z","updated_at":"2017-11-18T11:50:21Z","pushed_at":"2018-02-26T20:25:34Z","git_url":"git://github.com/hooroo/BudgetApp.git","ssh_url":"git@github.com:hooroo/BudgetApp.git","clone_url":"https://github.com/hooroo/BudgetApp.git","svn_url":"https://github.com/hooroo/BudgetApp","homepage":"","size":479,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"hooroo:master","ref":"master","sha":"ec18df2463e548ff678d6f86815f5085c69fcf31","user":{"login":"hooroo","id":785479,"avatar_url":"https://avatars0.githubusercontent.com/u/785479?v=4","gravatar_id":"","url":"https://api.github.com/users/hooroo","html_url":"https://github.com/hooroo","followers_url":"https://api.github.com/users/hooroo/followers","following_url":"https://api.github.com/users/hooroo/following{/other_user}","gists_url":"https://api.github.com/users/hooroo/gists{/gist_id}","starred_url":"https://api.github.com/users/hooroo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hooroo/subscriptions","organizations_url":"https://api.github.com/users/hooroo/orgs","repos_url":"https://api.github.com/users/hooroo/repos","events_url":"https://api.github.com/users/hooroo/events{/privacy}","received_events_url":"https://api.github.com/users/hooroo/received_events","type":"Organization","site_admin":false},"repo":{"id":111200727,"name":"BudgetApp","full_name":"hooroo/BudgetApp","owner":{"login":"hooroo","id":785479,"avatar_url":"https://avatars0.githubusercontent.com/u/785479?v=4","gravatar_id":"","url":"https://api.github.com/users/hooroo","html_url":"https://github.com/hooroo","followers_url":"https://api.github.com/users/hooroo/followers","following_url":"https://api.github.com/users/hooroo/following{/other_user}","gists_url":"https://api.github.com/users/hooroo/gists{/gist_id}","starred_url":"https://api.github.com/users/hooroo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hooroo/subscriptions","organizations_url":"https://api.github.com/users/hooroo/orgs","repos_url":"https://api.github.com/users/hooroo/repos","events_url":"https://api.github.com/users/hooroo/events{/privacy}","received_events_url":"https://api.github.com/users/hooroo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hooroo/BudgetApp","description":"Rails JQuery React app to allow user to create and manage their budget","fork":false,"url":"https://api.github.com/repos/hooroo/BudgetApp","forks_url":"https://api.github.com/repos/hooroo/BudgetApp/forks","keys_url":"https://api.github.com/repos/hooroo/BudgetApp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hooroo/BudgetApp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hooroo/BudgetApp/teams","hooks_url":"https://api.github.com/repos/hooroo/BudgetApp/hooks","issue_events_url":"https://api.github.com/repos/hooroo/BudgetApp/issues/events{/number}","events_url":"https://api.github.com/repos/hooroo/BudgetApp/events","assignees_url":"https://api.github.com/repos/hooroo/BudgetApp/assignees{/user}","branches_url":"https://api.github.com/repos/hooroo/BudgetApp/branches{/branch}","tags_url":"https://api.github.com/repos/hooroo/BudgetApp/tags","blobs_url":"https://api.github.com/repos/hooroo/BudgetApp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hooroo/BudgetApp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hooroo/BudgetApp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hooroo/BudgetApp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hooroo/BudgetApp/statuses/{sha}","languages_url":"https://api.github.com/repos/hooroo/BudgetApp/languages","stargazers_url":"https://api.github.com/repos/hooroo/BudgetApp/stargazers","contributors_url":"https://api.github.com/repos/hooroo/BudgetApp/contributors","subscribers_url":"https://api.github.com/repos/hooroo/BudgetApp/subscribers","subscription_url":"https://api.github.com/repos/hooroo/BudgetApp/subscription","commits_url":"https://api.github.com/repos/hooroo/BudgetApp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hooroo/BudgetApp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hooroo/BudgetApp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hooroo/BudgetApp/issues/comments{/number}","contents_url":"https://api.github.com/repos/hooroo/BudgetApp/contents/{+path}","compare_url":"https://api.github.com/repos/hooroo/BudgetApp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hooroo/BudgetApp/merges","archive_url":"https://api.github.com/repos/hooroo/BudgetApp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hooroo/BudgetApp/downloads","issues_url":"https://api.github.com/repos/hooroo/BudgetApp/issues{/number}","pulls_url":"https://api.github.com/repos/hooroo/BudgetApp/pulls{/number}","milestones_url":"https://api.github.com/repos/hooroo/BudgetApp/milestones{/number}","notifications_url":"https://api.github.com/repos/hooroo/BudgetApp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hooroo/BudgetApp/labels{/name}","releases_url":"https://api.github.com/repos/hooroo/BudgetApp/releases{/id}","deployments_url":"https://api.github.com/repos/hooroo/BudgetApp/deployments","created_at":"2017-11-18T11:39:32Z","updated_at":"2017-11-18T11:50:21Z","pushed_at":"2018-02-26T20:25:34Z","git_url":"git://github.com/hooroo/BudgetApp.git","ssh_url":"git@github.com:hooroo/BudgetApp.git","clone_url":"https://github.com/hooroo/BudgetApp.git","svn_url":"https://github.com/hooroo/BudgetApp","homepage":"","size":479,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hooroo/BudgetApp/pulls/28"},"html":{"href":"https://github.com/hooroo/BudgetApp/pull/28"},"issue":{"href":"https://api.github.com/repos/hooroo/BudgetApp/issues/28"},"comments":{"href":"https://api.github.com/repos/hooroo/BudgetApp/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/hooroo/BudgetApp/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/hooroo/BudgetApp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hooroo/BudgetApp/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/hooroo/BudgetApp/statuses/7db5aaddb484787b737679df174e2ac2f12caa40"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"elle"}}