{"action":"created","comment":{"url":"https://api.github.com/repos/devtools-html/perf.html/pulls/comments/202434961","pull_request_review_id":137141546,"id":202434961,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjQzNDk2MQ==","diff_hunk":"@@ -18,8 +18,8 @@ import mockRaf from '../fixtures/mocks/request-animation-frame';\n \n const MARKERS = [\n   ['Marker A', 0, { startTime: 0, endTime: 10 }],\n-  ['Marker B', 0, { startTime: 0, endTime: 10 }],\n-  ['Marker C', 5, { startTime: 5, endTime: 15 }],\n+  ['Marker A', 0, { startTime: 0, endTime: 10 }],\n+  ['Marker A', 11, { startTime: 11, endTime: 15 }],","path":"src/test/components/MarkerChart.test.js","position":16,"original_position":16,"commit_id":"4b407abcefca5ab4462deed7eb78b12b9fd17e6a","original_commit_id":"4b407abcefca5ab4462deed7eb78b12b9fd17e6a","user":{"login":"julienw","id":454175,"node_id":"MDQ6VXNlcjQ1NDE3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/454175?v=4","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"body":"This change to actually test how markers with the same name are arranged.","created_at":"2018-07-13T18:22:59Z","updated_at":"2018-07-13T18:22:59Z","html_url":"https://github.com/devtools-html/perf.html/pull/1134#discussion_r202434961","pull_request_url":"https://api.github.com/repos/devtools-html/perf.html/pulls/1134","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/devtools-html/perf.html/pulls/comments/202434961"},"html":{"href":"https://github.com/devtools-html/perf.html/pull/1134#discussion_r202434961"},"pull_request":{"href":"https://api.github.com/repos/devtools-html/perf.html/pulls/1134"}}},"pull_request":{"url":"https://api.github.com/repos/devtools-html/perf.html/pulls/1134","id":201341124,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzQxMTI0","html_url":"https://github.com/devtools-html/perf.html/pull/1134","diff_url":"https://github.com/devtools-html/perf.html/pull/1134.diff","patch_url":"https://github.com/devtools-html/perf.html/pull/1134.patch","issue_url":"https://api.github.com/repos/devtools-html/perf.html/issues/1134","number":1134,"state":"open","locked":false,"title":"Draw the hovered marker out of the loop","user":{"login":"julienw","id":454175,"node_id":"MDQ6VXNlcjQ1NDE3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/454175?v=4","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"body":"Previously we were drawing the hovered marker inside the loop. This was\r\npretty bad as we were drawing it again and again for each and every\r\nmarker on the same line, even outside of the range.\r\n\r\nThe STR is similar to #865 \r\n1. go to http://localhost:4242/public/1c77f550d099ab67995681cf835ae589dd88e714/marker-chart/?hiddenThreads=0-1-2-3&range=8.0979_10.7529~8.7533_8.8137&react_perf&thread=4&threadOrder=0-2-3-4-1&v=3\r\n2. hover the markers to display the tooltips\r\n\r\n=> see how this is much faster now !","created_at":"2018-07-13T16:31:48Z","updated_at":"2018-07-13T18:22:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49140b1d0ac78552ca18960793856b159e92b3f1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gregtatum","id":1588648,"node_id":"MDQ6VXNlcjE1ODg2NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1588648?v=4","gravatar_id":"","url":"https://api.github.com/users/gregtatum","html_url":"https://github.com/gregtatum","followers_url":"https://api.github.com/users/gregtatum/followers","following_url":"https://api.github.com/users/gregtatum/following{/other_user}","gists_url":"https://api.github.com/users/gregtatum/gists{/gist_id}","starred_url":"https://api.github.com/users/gregtatum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregtatum/subscriptions","organizations_url":"https://api.github.com/users/gregtatum/orgs","repos_url":"https://api.github.com/users/gregtatum/repos","events_url":"https://api.github.com/users/gregtatum/events{/privacy}","received_events_url":"https://api.github.com/users/gregtatum/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/devtools-html/perf.html/pulls/1134/commits","review_comments_url":"https://api.github.com/repos/devtools-html/perf.html/pulls/1134/comments","review_comment_url":"https://api.github.com/repos/devtools-html/perf.html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/devtools-html/perf.html/issues/1134/comments","statuses_url":"https://api.github.com/repos/devtools-html/perf.html/statuses/4b407abcefca5ab4462deed7eb78b12b9fd17e6a","head":{"label":"julienw:fix-drawing-of-hovered-element","ref":"fix-drawing-of-hovered-element","sha":"4b407abcefca5ab4462deed7eb78b12b9fd17e6a","user":{"login":"julienw","id":454175,"node_id":"MDQ6VXNlcjQ1NDE3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/454175?v=4","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"repo":{"id":85606366,"node_id":"MDEwOlJlcG9zaXRvcnk4NTYwNjM2Ng==","name":"perf.html","full_name":"julienw/perf.html","owner":{"login":"julienw","id":454175,"node_id":"MDQ6VXNlcjQ1NDE3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/454175?v=4","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julienw/perf.html","description":"Firefox Performance tools for the web, by the web 🛥","fork":true,"url":"https://api.github.com/repos/julienw/perf.html","forks_url":"https://api.github.com/repos/julienw/perf.html/forks","keys_url":"https://api.github.com/repos/julienw/perf.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julienw/perf.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julienw/perf.html/teams","hooks_url":"https://api.github.com/repos/julienw/perf.html/hooks","issue_events_url":"https://api.github.com/repos/julienw/perf.html/issues/events{/number}","events_url":"https://api.github.com/repos/julienw/perf.html/events","assignees_url":"https://api.github.com/repos/julienw/perf.html/assignees{/user}","branches_url":"https://api.github.com/repos/julienw/perf.html/branches{/branch}","tags_url":"https://api.github.com/repos/julienw/perf.html/tags","blobs_url":"https://api.github.com/repos/julienw/perf.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julienw/perf.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julienw/perf.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/julienw/perf.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julienw/perf.html/statuses/{sha}","languages_url":"https://api.github.com/repos/julienw/perf.html/languages","stargazers_url":"https://api.github.com/repos/julienw/perf.html/stargazers","contributors_url":"https://api.github.com/repos/julienw/perf.html/contributors","subscribers_url":"https://api.github.com/repos/julienw/perf.html/subscribers","subscription_url":"https://api.github.com/repos/julienw/perf.html/subscription","commits_url":"https://api.github.com/repos/julienw/perf.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/julienw/perf.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/julienw/perf.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/julienw/perf.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/julienw/perf.html/contents/{+path}","compare_url":"https://api.github.com/repos/julienw/perf.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julienw/perf.html/merges","archive_url":"https://api.github.com/repos/julienw/perf.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julienw/perf.html/downloads","issues_url":"https://api.github.com/repos/julienw/perf.html/issues{/number}","pulls_url":"https://api.github.com/repos/julienw/perf.html/pulls{/number}","milestones_url":"https://api.github.com/repos/julienw/perf.html/milestones{/number}","notifications_url":"https://api.github.com/repos/julienw/perf.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julienw/perf.html/labels{/name}","releases_url":"https://api.github.com/repos/julienw/perf.html/releases{/id}","deployments_url":"https://api.github.com/repos/julienw/perf.html/deployments","created_at":"2017-03-20T17:30:11Z","updated_at":"2018-04-19T15:14:54Z","pushed_at":"2018-07-13T18:20:54Z","git_url":"git://github.com/julienw/perf.html.git","ssh_url":"git@github.com:julienw/perf.html.git","clone_url":"https://github.com/julienw/perf.html.git","svn_url":"https://github.com/julienw/perf.html","homepage":"https://perf-html.io/","size":11890,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"devtools-html:master","ref":"master","sha":"9cc8943f1cd4160f0e3ecf1026e4f1a09e987705","user":{"login":"devtools-html","id":19979421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTc5NDIx","avatar_url":"https://avatars2.githubusercontent.com/u/19979421?v=4","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"repo":{"id":3607308,"node_id":"MDEwOlJlcG9zaXRvcnkzNjA3MzA4","name":"perf.html","full_name":"devtools-html/perf.html","owner":{"login":"devtools-html","id":19979421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTc5NDIx","avatar_url":"https://avatars2.githubusercontent.com/u/19979421?v=4","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/devtools-html/perf.html","description":"Firefox Performance tools for the web, by the web 🛥","fork":false,"url":"https://api.github.com/repos/devtools-html/perf.html","forks_url":"https://api.github.com/repos/devtools-html/perf.html/forks","keys_url":"https://api.github.com/repos/devtools-html/perf.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devtools-html/perf.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devtools-html/perf.html/teams","hooks_url":"https://api.github.com/repos/devtools-html/perf.html/hooks","issue_events_url":"https://api.github.com/repos/devtools-html/perf.html/issues/events{/number}","events_url":"https://api.github.com/repos/devtools-html/perf.html/events","assignees_url":"https://api.github.com/repos/devtools-html/perf.html/assignees{/user}","branches_url":"https://api.github.com/repos/devtools-html/perf.html/branches{/branch}","tags_url":"https://api.github.com/repos/devtools-html/perf.html/tags","blobs_url":"https://api.github.com/repos/devtools-html/perf.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devtools-html/perf.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devtools-html/perf.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/devtools-html/perf.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devtools-html/perf.html/statuses/{sha}","languages_url":"https://api.github.com/repos/devtools-html/perf.html/languages","stargazers_url":"https://api.github.com/repos/devtools-html/perf.html/stargazers","contributors_url":"https://api.github.com/repos/devtools-html/perf.html/contributors","subscribers_url":"https://api.github.com/repos/devtools-html/perf.html/subscribers","subscription_url":"https://api.github.com/repos/devtools-html/perf.html/subscription","commits_url":"https://api.github.com/repos/devtools-html/perf.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/devtools-html/perf.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/devtools-html/perf.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/devtools-html/perf.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/devtools-html/perf.html/contents/{+path}","compare_url":"https://api.github.com/repos/devtools-html/perf.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devtools-html/perf.html/merges","archive_url":"https://api.github.com/repos/devtools-html/perf.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devtools-html/perf.html/downloads","issues_url":"https://api.github.com/repos/devtools-html/perf.html/issues{/number}","pulls_url":"https://api.github.com/repos/devtools-html/perf.html/pulls{/number}","milestones_url":"https://api.github.com/repos/devtools-html/perf.html/milestones{/number}","notifications_url":"https://api.github.com/repos/devtools-html/perf.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devtools-html/perf.html/labels{/name}","releases_url":"https://api.github.com/repos/devtools-html/perf.html/releases{/id}","deployments_url":"https://api.github.com/repos/devtools-html/perf.html/deployments","created_at":"2012-03-02T23:55:22Z","updated_at":"2018-07-13T16:19:29Z","pushed_at":"2018-07-13T18:20:56Z","git_url":"git://github.com/devtools-html/perf.html.git","ssh_url":"git@github.com:devtools-html/perf.html.git","clone_url":"https://github.com/devtools-html/perf.html.git","svn_url":"https://github.com/devtools-html/perf.html","homepage":"https://perf-html.io/","size":11530,"stargazers_count":175,"watchers_count":175,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":293,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":60,"open_issues":293,"watchers":175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/devtools-html/perf.html/pulls/1134"},"html":{"href":"https://github.com/devtools-html/perf.html/pull/1134"},"issue":{"href":"https://api.github.com/repos/devtools-html/perf.html/issues/1134"},"comments":{"href":"https://api.github.com/repos/devtools-html/perf.html/issues/1134/comments"},"review_comments":{"href":"https://api.github.com/repos/devtools-html/perf.html/pulls/1134/comments"},"review_comment":{"href":"https://api.github.com/repos/devtools-html/perf.html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/devtools-html/perf.html/pulls/1134/commits"},"statuses":{"href":"https://api.github.com/repos/devtools-html/perf.html/statuses/4b407abcefca5ab4462deed7eb78b12b9fd17e6a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"julienw"}}