{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/charts/issues/4038","repository_url":"https://api.github.com/repos/kubernetes/charts","labels_url":"https://api.github.com/repos/kubernetes/charts/issues/4038/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/4038/comments","events_url":"https://api.github.com/repos/kubernetes/charts/issues/4038/events","html_url":"https://github.com/kubernetes/charts/pull/4038","id":303151079,"number":4038,"title":"[stable/redis-ha] Upgrade chart to use stateful sets and pdbs","user":{"login":"bzumhagen","id":1493382,"avatar_url":"https://avatars1.githubusercontent.com/u/1493382?v=4","gravatar_id":"","url":"https://api.github.com/users/bzumhagen","html_url":"https://github.com/bzumhagen","followers_url":"https://api.github.com/users/bzumhagen/followers","following_url":"https://api.github.com/users/bzumhagen/following{/other_user}","gists_url":"https://api.github.com/users/bzumhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/bzumhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzumhagen/subscriptions","organizations_url":"https://api.github.com/users/bzumhagen/orgs","repos_url":"https://api.github.com/users/bzumhagen/repos","events_url":"https://api.github.com/users/bzumhagen/events{/privacy}","received_events_url":"https://api.github.com/users/bzumhagen/received_events","type":"User","site_admin":false},"labels":[{"id":484586588,"url":"https://api.github.com/repos/kubernetes/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":582594847,"url":"https://api.github.com/repos/kubernetes/charts/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":676596499,"url":"https://api.github.com/repos/kubernetes/charts/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"seanknox","id":1231630,"avatar_url":"https://avatars1.githubusercontent.com/u/1231630?v=4","gravatar_id":"","url":"https://api.github.com/users/seanknox","html_url":"https://github.com/seanknox","followers_url":"https://api.github.com/users/seanknox/followers","following_url":"https://api.github.com/users/seanknox/following{/other_user}","gists_url":"https://api.github.com/users/seanknox/gists{/gist_id}","starred_url":"https://api.github.com/users/seanknox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanknox/subscriptions","organizations_url":"https://api.github.com/users/seanknox/orgs","repos_url":"https://api.github.com/users/seanknox/repos","events_url":"https://api.github.com/users/seanknox/events{/privacy}","received_events_url":"https://api.github.com/users/seanknox/received_events","type":"User","site_admin":false},"assignees":[{"login":"unguiculus","id":925412,"avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false},{"login":"seanknox","id":1231630,"avatar_url":"https://avatars1.githubusercontent.com/u/1231630?v=4","gravatar_id":"","url":"https://api.github.com/users/seanknox","html_url":"https://github.com/seanknox","followers_url":"https://api.github.com/users/seanknox/followers","following_url":"https://api.github.com/users/seanknox/following{/other_user}","gists_url":"https://api.github.com/users/seanknox/gists{/gist_id}","starred_url":"https://api.github.com/users/seanknox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanknox/subscriptions","organizations_url":"https://api.github.com/users/seanknox/orgs","repos_url":"https://api.github.com/users/seanknox/repos","events_url":"https://api.github.com/users/seanknox/events{/privacy}","received_events_url":"https://api.github.com/users/seanknox/received_events","type":"User","site_admin":false}],"milestone":null,"comments":16,"created_at":"2018-03-07T15:48:05Z","updated_at":"2018-04-28T16:06:56Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/4038","html_url":"https://github.com/kubernetes/charts/pull/4038","diff_url":"https://github.com/kubernetes/charts/pull/4038.diff","patch_url":"https://github.com/kubernetes/charts/pull/4038.patch"},"body":"In order to fix issues brought up in https://github.com/kubernetes/charts/issues/3237.\r\nIt's a major version change because you cannot upgrade from deployment to stateful set without destroying the old deployment.\r\n\r\nStateful set fixes the issue of master selection thrashing, while adding the pds prevents cluster maintenance disruptions.\r\n\r\nAlso added redis-cli healthcheck to ensure redis service has at least started before moving on to creating more nodes.\r\n\r\nChange-Id: Id6d296d8e49db925061e961a8e10988720dde3f2\r\n\r\n*****************************************************************************************\r\n\r\nThank you for contributing to kubernetes/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the \r\nhistory. This will make it easier to identify new changes. The PR will be squashed \r\nanyways when it is merged. Thanks.\r\n\r\n*****************************************************************************************\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/charts/issues/comments/385186808","html_url":"https://github.com/kubernetes/charts/pull/4038#issuecomment-385186808","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/4038","id":385186808,"user":{"login":"bzumhagen","id":1493382,"avatar_url":"https://avatars1.githubusercontent.com/u/1493382?v=4","gravatar_id":"","url":"https://api.github.com/users/bzumhagen","html_url":"https://github.com/bzumhagen","followers_url":"https://api.github.com/users/bzumhagen/followers","following_url":"https://api.github.com/users/bzumhagen/following{/other_user}","gists_url":"https://api.github.com/users/bzumhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/bzumhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzumhagen/subscriptions","organizations_url":"https://api.github.com/users/bzumhagen/orgs","repos_url":"https://api.github.com/users/bzumhagen/repos","events_url":"https://api.github.com/users/bzumhagen/events{/privacy}","received_events_url":"https://api.github.com/users/bzumhagen/received_events","type":"User","site_admin":false},"created_at":"2018-04-28T16:06:56Z","updated_at":"2018-04-28T16:06:56Z","author_association":"NONE","body":"Hey guys, sorry for the delay. We discovered some issues with the chart and were trying to iron them out in our cluster.\r\n\r\nI've rebased and added our latest findings, so hopefully this means a very stable chart which can survive cluster maintenance."}}
{"actor":{"display_login":"bzumhagen"}}