{"action":"created","comment":{"url":"https://api.github.com/repos/zulip/zulip/pulls/comments/228690762","pull_request_review_id":169031416,"id":228690762,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODY5MDc2Mg==","diff_hunk":"@@ -301,6 +301,14 @@ exports.get_announcement_only = function (stream_name) {\n     return sub.is_announcement_only;\n };\n \n+exports.get_first_message_id = function (stream_name) {\n+    var sub = exports.get_sub(stream_name);\n+    if (sub === undefined) {\n+        return false;","path":"static/js/stream_data.js","position":9,"original_position":7,"commit_id":"5b3663cc96b94ca6a4ba80234eaa244189aee219","original_commit_id":"48f94032c42dbdc82725aa5b8f68872e3e7a9df8","user":{"login":"timabbott","id":2746074,"node_id":"MDQ6VXNlcjI3NDYwNzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2746074?v=4","gravatar_id":"","url":"https://api.github.com/users/timabbott","html_url":"https://github.com/timabbott","followers_url":"https://api.github.com/users/timabbott/followers","following_url":"https://api.github.com/users/timabbott/following{/other_user}","gists_url":"https://api.github.com/users/timabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/timabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timabbott/subscriptions","organizations_url":"https://api.github.com/users/timabbott/orgs","repos_url":"https://api.github.com/users/timabbott/repos","events_url":"https://api.github.com/users/timabbott/events{/privacy}","received_events_url":"https://api.github.com/users/timabbott/received_events","type":"User","site_admin":false},"body":"Under what circumstance do you think it'd be possible?\r\n\r\nThere might need to be a few more checks here on `all_msg_list` being up-to-date that are a little subtle, but the point of this feature is to be able to avoid showing \"more topics\" when we know that all topics in the stream's history are already displayed.  \r\n\r\nAnd since `all_msg_list` has a local copy of the history of all streams in a range of message IDs from `all_msg_list.first_message_id` through current, this value should let us do this check.","created_at":"2018-10-26T23:45:05Z","updated_at":"2018-10-26T23:45:05Z","html_url":"https://github.com/zulip/zulip/pull/10452#discussion_r228690762","pull_request_url":"https://api.github.com/repos/zulip/zulip/pulls/10452","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip/pulls/comments/228690762"},"html":{"href":"https://github.com/zulip/zulip/pull/10452#discussion_r228690762"},"pull_request":{"href":"https://api.github.com/repos/zulip/zulip/pulls/10452"}},"in_reply_to_id":214494383},"pull_request":{"url":"https://api.github.com/repos/zulip/zulip/pulls/10452","id":212347747,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMzQ3NzQ3","html_url":"https://github.com/zulip/zulip/pull/10452","diff_url":"https://github.com/zulip/zulip/pull/10452.diff","patch_url":"https://github.com/zulip/zulip/pull/10452.patch","issue_url":"https://api.github.com/repos/zulip/zulip/issues/10452","number":10452,"state":"open","locked":false,"title":"[WIP] Streams: Add first_message_id field.","user":{"login":"zy964c","id":15901908,"node_id":"MDQ6VXNlcjE1OTAxOTA4","avatar_url":"https://avatars3.githubusercontent.com/u/15901908?v=4","gravatar_id":"","url":"https://api.github.com/users/zy964c","html_url":"https://github.com/zy964c","followers_url":"https://api.github.com/users/zy964c/followers","following_url":"https://api.github.com/users/zy964c/following{/other_user}","gists_url":"https://api.github.com/users/zy964c/gists{/gist_id}","starred_url":"https://api.github.com/users/zy964c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zy964c/subscriptions","organizations_url":"https://api.github.com/users/zy964c/orgs","repos_url":"https://api.github.com/users/zy964c/repos","events_url":"https://api.github.com/users/zy964c/events{/privacy}","received_events_url":"https://api.github.com/users/zy964c/received_events","type":"User","site_admin":false},"body":"Adds `first_message_id` field to Stream model and backfills the data.\r\nAlso ensures that if the lowest message id on the stream is equal to `first_message_id` browser won't show `more topics` on the left sidebar.\r\n\r\nFixes #10265","created_at":"2018-08-31T10:57:59Z","updated_at":"2018-10-26T23:45:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f64afddf5ac2e2c68b6b0891aff9f414a897349a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":804197644,"node_id":"MDU6TGFiZWw4MDQxOTc2NDQ=","url":"https://api.github.com/repos/zulip/zulip/labels/size:%20L","name":"size: L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zulip/zulip/pulls/10452/commits","review_comments_url":"https://api.github.com/repos/zulip/zulip/pulls/10452/comments","review_comment_url":"https://api.github.com/repos/zulip/zulip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/10452/comments","statuses_url":"https://api.github.com/repos/zulip/zulip/statuses/5b3663cc96b94ca6a4ba80234eaa244189aee219","head":{"label":"zy964c:issue-10265-more-topics","ref":"issue-10265-more-topics","sha":"5b3663cc96b94ca6a4ba80234eaa244189aee219","user":{"login":"zy964c","id":15901908,"node_id":"MDQ6VXNlcjE1OTAxOTA4","avatar_url":"https://avatars3.githubusercontent.com/u/15901908?v=4","gravatar_id":"","url":"https://api.github.com/users/zy964c","html_url":"https://github.com/zy964c","followers_url":"https://api.github.com/users/zy964c/followers","following_url":"https://api.github.com/users/zy964c/following{/other_user}","gists_url":"https://api.github.com/users/zy964c/gists{/gist_id}","starred_url":"https://api.github.com/users/zy964c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zy964c/subscriptions","organizations_url":"https://api.github.com/users/zy964c/orgs","repos_url":"https://api.github.com/users/zy964c/repos","events_url":"https://api.github.com/users/zy964c/events{/privacy}","received_events_url":"https://api.github.com/users/zy964c/received_events","type":"User","site_admin":false},"repo":{"id":108753997,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg3NTM5OTc=","name":"zulip","full_name":"zy964c/zulip","private":false,"owner":{"login":"zy964c","id":15901908,"node_id":"MDQ6VXNlcjE1OTAxOTA4","avatar_url":"https://avatars3.githubusercontent.com/u/15901908?v=4","gravatar_id":"","url":"https://api.github.com/users/zy964c","html_url":"https://github.com/zy964c","followers_url":"https://api.github.com/users/zy964c/followers","following_url":"https://api.github.com/users/zy964c/following{/other_user}","gists_url":"https://api.github.com/users/zy964c/gists{/gist_id}","starred_url":"https://api.github.com/users/zy964c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zy964c/subscriptions","organizations_url":"https://api.github.com/users/zy964c/orgs","repos_url":"https://api.github.com/users/zy964c/repos","events_url":"https://api.github.com/users/zy964c/events{/privacy}","received_events_url":"https://api.github.com/users/zy964c/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zy964c/zulip","description":"Zulip server - powerful open source group chat","fork":true,"url":"https://api.github.com/repos/zy964c/zulip","forks_url":"https://api.github.com/repos/zy964c/zulip/forks","keys_url":"https://api.github.com/repos/zy964c/zulip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zy964c/zulip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zy964c/zulip/teams","hooks_url":"https://api.github.com/repos/zy964c/zulip/hooks","issue_events_url":"https://api.github.com/repos/zy964c/zulip/issues/events{/number}","events_url":"https://api.github.com/repos/zy964c/zulip/events","assignees_url":"https://api.github.com/repos/zy964c/zulip/assignees{/user}","branches_url":"https://api.github.com/repos/zy964c/zulip/branches{/branch}","tags_url":"https://api.github.com/repos/zy964c/zulip/tags","blobs_url":"https://api.github.com/repos/zy964c/zulip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zy964c/zulip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zy964c/zulip/git/refs{/sha}","trees_url":"https://api.github.com/repos/zy964c/zulip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zy964c/zulip/statuses/{sha}","languages_url":"https://api.github.com/repos/zy964c/zulip/languages","stargazers_url":"https://api.github.com/repos/zy964c/zulip/stargazers","contributors_url":"https://api.github.com/repos/zy964c/zulip/contributors","subscribers_url":"https://api.github.com/repos/zy964c/zulip/subscribers","subscription_url":"https://api.github.com/repos/zy964c/zulip/subscription","commits_url":"https://api.github.com/repos/zy964c/zulip/commits{/sha}","git_commits_url":"https://api.github.com/repos/zy964c/zulip/git/commits{/sha}","comments_url":"https://api.github.com/repos/zy964c/zulip/comments{/number}","issue_comment_url":"https://api.github.com/repos/zy964c/zulip/issues/comments{/number}","contents_url":"https://api.github.com/repos/zy964c/zulip/contents/{+path}","compare_url":"https://api.github.com/repos/zy964c/zulip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zy964c/zulip/merges","archive_url":"https://api.github.com/repos/zy964c/zulip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zy964c/zulip/downloads","issues_url":"https://api.github.com/repos/zy964c/zulip/issues{/number}","pulls_url":"https://api.github.com/repos/zy964c/zulip/pulls{/number}","milestones_url":"https://api.github.com/repos/zy964c/zulip/milestones{/number}","notifications_url":"https://api.github.com/repos/zy964c/zulip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zy964c/zulip/labels{/name}","releases_url":"https://api.github.com/repos/zy964c/zulip/releases{/id}","deployments_url":"https://api.github.com/repos/zy964c/zulip/deployments","created_at":"2017-10-29T17:09:36Z","updated_at":"2017-10-29T17:09:43Z","pushed_at":"2018-09-24T10:33:58Z","git_url":"git://github.com/zy964c/zulip.git","ssh_url":"git@github.com:zy964c/zulip.git","clone_url":"https://github.com/zy964c/zulip.git","svn_url":"https://github.com/zy964c/zulip","homepage":"","size":216467,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"issue-5489-realm-name-setting"}},"base":{"label":"zulip:master","ref":"master","sha":"d69d71c59f4ddbcf878dea4f3963fb51892cc193","user":{"login":"zulip","id":4921959,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MjE5NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"repo":{"id":43160685,"node_id":"MDEwOlJlcG9zaXRvcnk0MzE2MDY4NQ==","name":"zulip","full_name":"zulip/zulip","private":false,"owner":{"login":"zulip","id":4921959,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MjE5NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zulip/zulip","description":"Zulip server - powerful open source team chat","fork":false,"url":"https://api.github.com/repos/zulip/zulip","forks_url":"https://api.github.com/repos/zulip/zulip/forks","keys_url":"https://api.github.com/repos/zulip/zulip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zulip/zulip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zulip/zulip/teams","hooks_url":"https://api.github.com/repos/zulip/zulip/hooks","issue_events_url":"https://api.github.com/repos/zulip/zulip/issues/events{/number}","events_url":"https://api.github.com/repos/zulip/zulip/events","assignees_url":"https://api.github.com/repos/zulip/zulip/assignees{/user}","branches_url":"https://api.github.com/repos/zulip/zulip/branches{/branch}","tags_url":"https://api.github.com/repos/zulip/zulip/tags","blobs_url":"https://api.github.com/repos/zulip/zulip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zulip/zulip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zulip/zulip/git/refs{/sha}","trees_url":"https://api.github.com/repos/zulip/zulip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zulip/zulip/statuses/{sha}","languages_url":"https://api.github.com/repos/zulip/zulip/languages","stargazers_url":"https://api.github.com/repos/zulip/zulip/stargazers","contributors_url":"https://api.github.com/repos/zulip/zulip/contributors","subscribers_url":"https://api.github.com/repos/zulip/zulip/subscribers","subscription_url":"https://api.github.com/repos/zulip/zulip/subscription","commits_url":"https://api.github.com/repos/zulip/zulip/commits{/sha}","git_commits_url":"https://api.github.com/repos/zulip/zulip/git/commits{/sha}","comments_url":"https://api.github.com/repos/zulip/zulip/comments{/number}","issue_comment_url":"https://api.github.com/repos/zulip/zulip/issues/comments{/number}","contents_url":"https://api.github.com/repos/zulip/zulip/contents/{+path}","compare_url":"https://api.github.com/repos/zulip/zulip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zulip/zulip/merges","archive_url":"https://api.github.com/repos/zulip/zulip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zulip/zulip/downloads","issues_url":"https://api.github.com/repos/zulip/zulip/issues{/number}","pulls_url":"https://api.github.com/repos/zulip/zulip/pulls{/number}","milestones_url":"https://api.github.com/repos/zulip/zulip/milestones{/number}","notifications_url":"https://api.github.com/repos/zulip/zulip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zulip/zulip/labels{/name}","releases_url":"https://api.github.com/repos/zulip/zulip/releases{/id}","deployments_url":"https://api.github.com/repos/zulip/zulip/deployments","created_at":"2015-09-25T16:37:25Z","updated_at":"2018-10-26T23:04:06Z","pushed_at":"2018-10-26T23:02:57Z","git_url":"git://github.com/zulip/zulip.git","ssh_url":"git@github.com:zulip/zulip.git","clone_url":"https://github.com/zulip/zulip.git","svn_url":"https://github.com/zulip/zulip","homepage":"https://zulip.org/","size":218371,"stargazers_count":8257,"watchers_count":8257,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2496,"mirror_url":null,"archived":false,"open_issues_count":1163,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2496,"open_issues":1163,"watchers":8257,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip/pulls/10452"},"html":{"href":"https://github.com/zulip/zulip/pull/10452"},"issue":{"href":"https://api.github.com/repos/zulip/zulip/issues/10452"},"comments":{"href":"https://api.github.com/repos/zulip/zulip/issues/10452/comments"},"review_comments":{"href":"https://api.github.com/repos/zulip/zulip/pulls/10452/comments"},"review_comment":{"href":"https://api.github.com/repos/zulip/zulip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zulip/zulip/pulls/10452/commits"},"statuses":{"href":"https://api.github.com/repos/zulip/zulip/statuses/5b3663cc96b94ca6a4ba80234eaa244189aee219"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"timabbott"}}