{"action":"created","comment":{"url":"https://api.github.com/repos/scalacenter/bloop/pulls/comments/177031369","pull_request_review_id":106832721,"id":177031369,"diff_hunk":"@@ -16,6 +25,42 @@ object ExecutionContext {\n     java.util.concurrent.Executors.newFixedThreadPool(4)\n   }\n \n-  implicit val scheduler: Scheduler = Scheduler(executor)\n-  implicit val ioScheduler: Scheduler = Scheduler.io(\"bloop-io\")\n+  implicit lazy val scheduler: Scheduler = Scheduler(executor)\n+\n+  val ioReporter = UncaughtExceptionReporter.LogExceptionsToStandardErr\n+  lazy val ioExecutor: ThreadPoolExecutor = {\n+    val threadFactory = monixThreadFactoryBuilder(\"bloop-io\", ioReporter, daemonic = true)\n+    new ThreadPoolExecutor(\n+      0,\n+      Int.MaxValue,\n+      60,\n+      TimeUnit.SECONDS,\n+      new SynchronousQueue[Runnable](false),\n+      threadFactory\n+    )\n+  }\n+\n+  implicit lazy val ioScheduler: Scheduler =\n+    ExecutorScheduler(ioExecutor, ioReporter, ExecutionModel.Default)\n+\n+  // Inlined from `monix.execution.schedulers.ThreadFactoryBuilder`","path":"frontend/src/main/scala/bloop/engine/ExecutionContext.scala","position":43,"original_position":43,"commit_id":"3b07914214c27039658685c68355de169f083d3c","original_commit_id":"3b07914214c27039658685c68355de169f083d3c","user":{"login":"jvican","id":2462974,"avatar_url":"https://avatars0.githubusercontent.com/u/2462974?v=4","gravatar_id":"","url":"https://api.github.com/users/jvican","html_url":"https://github.com/jvican","followers_url":"https://api.github.com/users/jvican/followers","following_url":"https://api.github.com/users/jvican/following{/other_user}","gists_url":"https://api.github.com/users/jvican/gists{/gist_id}","starred_url":"https://api.github.com/users/jvican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvican/subscriptions","organizations_url":"https://api.github.com/users/jvican/orgs","repos_url":"https://api.github.com/users/jvican/repos","events_url":"https://api.github.com/users/jvican/events{/privacy}","received_events_url":"https://api.github.com/users/jvican/received_events","type":"User","site_admin":false},"body":"Because the executor needs to be exposed so that https://github.com/scalacenter/bloop/pull/389/files/3b07914214c27039658685c68355de169f083d3c#diff-f9ab286c6a27ce9fefdf1f0373d83486R67 works.","created_at":"2018-03-26T09:38:36Z","updated_at":"2018-03-26T09:38:36Z","html_url":"https://github.com/scalacenter/bloop/pull/389#discussion_r177031369","pull_request_url":"https://api.github.com/repos/scalacenter/bloop/pulls/389","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/comments/177031369"},"html":{"href":"https://github.com/scalacenter/bloop/pull/389#discussion_r177031369"},"pull_request":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/389"}},"in_reply_to_id":176993012},"pull_request":{"url":"https://api.github.com/repos/scalacenter/bloop/pulls/389","id":177115274,"html_url":"https://github.com/scalacenter/bloop/pull/389","diff_url":"https://github.com/scalacenter/bloop/pull/389.diff","patch_url":"https://github.com/scalacenter/bloop/pull/389.patch","issue_url":"https://api.github.com/repos/scalacenter/bloop/issues/389","number":389,"state":"open","locked":false,"title":"Ensure that file watching task exits","user":{"login":"jvican","id":2462974,"avatar_url":"https://avatars0.githubusercontent.com/u/2462974?v=4","gravatar_id":"","url":"https://api.github.com/users/jvican","html_url":"https://github.com/jvican","followers_url":"https://api.github.com/users/jvican/followers","following_url":"https://api.github.com/users/jvican/following{/other_user}","gists_url":"https://api.github.com/users/jvican/gists{/gist_id}","starred_url":"https://api.github.com/users/jvican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvican/subscriptions","organizations_url":"https://api.github.com/users/jvican/orgs","repos_url":"https://api.github.com/users/jvican/repos","events_url":"https://api.github.com/users/jvican/events{/privacy}","received_events_url":"https://api.github.com/users/jvican/received_events","type":"User","site_admin":false},"body":"Previously, `cancel` would not complete the task. This refactoring makes\nsure that the task is cancelled and that the completion returns the last\nstate processed by the consumer.\n\nSuch improvement makes sure that there's no hanging task listening to file\nwatching events.\n\nFixes #379.","created_at":"2018-03-23T16:06:05Z","updated_at":"2018-03-26T09:38:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcb44fb766a14064ce47f11c6780a22b27e36bbd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":747209079,"url":"https://api.github.com/repos/scalacenter/bloop/labels/bug","name":"bug","color":"ee0701","default":true},{"id":804409643,"url":"https://api.github.com/repos/scalacenter/bloop/labels/task%20/%20compile","name":"task / compile","color":"92e502","default":false},{"id":834993199,"url":"https://api.github.com/repos/scalacenter/bloop/labels/task%20/%20watch","name":"task / watch","color":"e5792b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/scalacenter/bloop/pulls/389/commits","review_comments_url":"https://api.github.com/repos/scalacenter/bloop/pulls/389/comments","review_comment_url":"https://api.github.com/repos/scalacenter/bloop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalacenter/bloop/issues/389/comments","statuses_url":"https://api.github.com/repos/scalacenter/bloop/statuses/3b07914214c27039658685c68355de169f083d3c","head":{"label":"scalacenter:ticket/379-final","ref":"ticket/379-final","sha":"3b07914214c27039658685c68355de169f083d3c","user":{"login":"scalacenter","id":16118980,"avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"repo":{"id":110334159,"name":"bloop","full_name":"scalacenter/bloop","owner":{"login":"scalacenter","id":16118980,"avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalacenter/bloop","description":"A hot bloop for your productivity","fork":false,"url":"https://api.github.com/repos/scalacenter/bloop","forks_url":"https://api.github.com/repos/scalacenter/bloop/forks","keys_url":"https://api.github.com/repos/scalacenter/bloop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalacenter/bloop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalacenter/bloop/teams","hooks_url":"https://api.github.com/repos/scalacenter/bloop/hooks","issue_events_url":"https://api.github.com/repos/scalacenter/bloop/issues/events{/number}","events_url":"https://api.github.com/repos/scalacenter/bloop/events","assignees_url":"https://api.github.com/repos/scalacenter/bloop/assignees{/user}","branches_url":"https://api.github.com/repos/scalacenter/bloop/branches{/branch}","tags_url":"https://api.github.com/repos/scalacenter/bloop/tags","blobs_url":"https://api.github.com/repos/scalacenter/bloop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalacenter/bloop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalacenter/bloop/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalacenter/bloop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalacenter/bloop/statuses/{sha}","languages_url":"https://api.github.com/repos/scalacenter/bloop/languages","stargazers_url":"https://api.github.com/repos/scalacenter/bloop/stargazers","contributors_url":"https://api.github.com/repos/scalacenter/bloop/contributors","subscribers_url":"https://api.github.com/repos/scalacenter/bloop/subscribers","subscription_url":"https://api.github.com/repos/scalacenter/bloop/subscription","commits_url":"https://api.github.com/repos/scalacenter/bloop/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalacenter/bloop/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalacenter/bloop/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalacenter/bloop/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalacenter/bloop/contents/{+path}","compare_url":"https://api.github.com/repos/scalacenter/bloop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalacenter/bloop/merges","archive_url":"https://api.github.com/repos/scalacenter/bloop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalacenter/bloop/downloads","issues_url":"https://api.github.com/repos/scalacenter/bloop/issues{/number}","pulls_url":"https://api.github.com/repos/scalacenter/bloop/pulls{/number}","milestones_url":"https://api.github.com/repos/scalacenter/bloop/milestones{/number}","notifications_url":"https://api.github.com/repos/scalacenter/bloop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalacenter/bloop/labels{/name}","releases_url":"https://api.github.com/repos/scalacenter/bloop/releases{/id}","deployments_url":"https://api.github.com/repos/scalacenter/bloop/deployments","created_at":"2017-11-11T09:39:34Z","updated_at":"2018-03-25T13:10:11Z","pushed_at":"2018-03-26T09:16:12Z","git_url":"git://github.com/scalacenter/bloop.git","ssh_url":"git@github.com:scalacenter/bloop.git","clone_url":"https://github.com/scalacenter/bloop.git","svn_url":"https://github.com/scalacenter/bloop","homepage":"https://scalacenter.github.io/bloop/","size":2986,"stargazers_count":157,"watchers_count":157,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12,"open_issues":56,"watchers":157,"default_branch":"master"}},"base":{"label":"scalacenter:master","ref":"master","sha":"ee1c3695d8b8169519ce51579309f1b3afaeafc4","user":{"login":"scalacenter","id":16118980,"avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"repo":{"id":110334159,"name":"bloop","full_name":"scalacenter/bloop","owner":{"login":"scalacenter","id":16118980,"avatar_url":"https://avatars2.githubusercontent.com/u/16118980?v=4","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalacenter/bloop","description":"A hot bloop for your productivity","fork":false,"url":"https://api.github.com/repos/scalacenter/bloop","forks_url":"https://api.github.com/repos/scalacenter/bloop/forks","keys_url":"https://api.github.com/repos/scalacenter/bloop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalacenter/bloop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalacenter/bloop/teams","hooks_url":"https://api.github.com/repos/scalacenter/bloop/hooks","issue_events_url":"https://api.github.com/repos/scalacenter/bloop/issues/events{/number}","events_url":"https://api.github.com/repos/scalacenter/bloop/events","assignees_url":"https://api.github.com/repos/scalacenter/bloop/assignees{/user}","branches_url":"https://api.github.com/repos/scalacenter/bloop/branches{/branch}","tags_url":"https://api.github.com/repos/scalacenter/bloop/tags","blobs_url":"https://api.github.com/repos/scalacenter/bloop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalacenter/bloop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalacenter/bloop/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalacenter/bloop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalacenter/bloop/statuses/{sha}","languages_url":"https://api.github.com/repos/scalacenter/bloop/languages","stargazers_url":"https://api.github.com/repos/scalacenter/bloop/stargazers","contributors_url":"https://api.github.com/repos/scalacenter/bloop/contributors","subscribers_url":"https://api.github.com/repos/scalacenter/bloop/subscribers","subscription_url":"https://api.github.com/repos/scalacenter/bloop/subscription","commits_url":"https://api.github.com/repos/scalacenter/bloop/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalacenter/bloop/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalacenter/bloop/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalacenter/bloop/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalacenter/bloop/contents/{+path}","compare_url":"https://api.github.com/repos/scalacenter/bloop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalacenter/bloop/merges","archive_url":"https://api.github.com/repos/scalacenter/bloop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalacenter/bloop/downloads","issues_url":"https://api.github.com/repos/scalacenter/bloop/issues{/number}","pulls_url":"https://api.github.com/repos/scalacenter/bloop/pulls{/number}","milestones_url":"https://api.github.com/repos/scalacenter/bloop/milestones{/number}","notifications_url":"https://api.github.com/repos/scalacenter/bloop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalacenter/bloop/labels{/name}","releases_url":"https://api.github.com/repos/scalacenter/bloop/releases{/id}","deployments_url":"https://api.github.com/repos/scalacenter/bloop/deployments","created_at":"2017-11-11T09:39:34Z","updated_at":"2018-03-25T13:10:11Z","pushed_at":"2018-03-26T09:16:12Z","git_url":"git://github.com/scalacenter/bloop.git","ssh_url":"git@github.com:scalacenter/bloop.git","clone_url":"https://github.com/scalacenter/bloop.git","svn_url":"https://github.com/scalacenter/bloop","homepage":"https://scalacenter.github.io/bloop/","size":2986,"stargazers_count":157,"watchers_count":157,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12,"open_issues":56,"watchers":157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/389"},"html":{"href":"https://github.com/scalacenter/bloop/pull/389"},"issue":{"href":"https://api.github.com/repos/scalacenter/bloop/issues/389"},"comments":{"href":"https://api.github.com/repos/scalacenter/bloop/issues/389/comments"},"review_comments":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/389/comments"},"review_comment":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalacenter/bloop/pulls/389/commits"},"statuses":{"href":"https://api.github.com/repos/scalacenter/bloop/statuses/3b07914214c27039658685c68355de169f083d3c"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jvican"}}