{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/170535498","pull_request_review_id":99232982,"id":170535498,"diff_hunk":"@@ -619,44 +626,106 @@ def test_retire_parent_service_now(self, request, appliance):\n \n \n class TestServiceDialogsRESTAPI(object):\n-    def test_query_service_dialog_attributes(self, appliance, dialog, soft_assert):\n+    def check_returned_dialog(self, appliance):\n+        # full dialog is returned only in >= 5.9\n+        if appliance.version < '5.9':\n+            return\n+        returned = appliance.rest_api.response.json()\n+        if 'results' in returned:\n+            results = returned['results']\n+        else:\n+            results = [returned]\n+        for result in results:\n+            dialog_tabs, = result['dialog_tabs']","path":"cfme/tests/services/test_rest_services.py","position":36,"original_position":36,"commit_id":"0ce59846d81eb3870a2ec9c40d88415cb161cb9b","original_commit_id":"0ce59846d81eb3870a2ec9c40d88415cb161cb9b","user":{"login":"izapolsk","id":21039333,"avatar_url":"https://avatars2.githubusercontent.com/u/21039333?v=4","gravatar_id":"","url":"https://api.github.com/users/izapolsk","html_url":"https://github.com/izapolsk","followers_url":"https://api.github.com/users/izapolsk/followers","following_url":"https://api.github.com/users/izapolsk/following{/other_user}","gists_url":"https://api.github.com/users/izapolsk/gists{/gist_id}","starred_url":"https://api.github.com/users/izapolsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izapolsk/subscriptions","organizations_url":"https://api.github.com/users/izapolsk/orgs","repos_url":"https://api.github.com/users/izapolsk/repos","events_url":"https://api.github.com/users/izapolsk/events{/privacy}","received_events_url":"https://api.github.com/users/izapolsk/received_events","type":"User","site_admin":false},"body":"Q: please explain me what's going on here. I'm a bit confused about this syntax","created_at":"2018-02-26T09:36:44Z","updated_at":"2018-02-26T09:52:04Z","html_url":"https://github.com/ManageIQ/integration_tests/pull/6728#discussion_r170535498","pull_request_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/6728","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/170535498"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/6728#discussion_r170535498"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/6728"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/6728","id":170775477,"html_url":"https://github.com/ManageIQ/integration_tests/pull/6728","diff_url":"https://github.com/ManageIQ/integration_tests/pull/6728.diff","patch_url":"https://github.com/ManageIQ/integration_tests/pull/6728.patch","issue_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/6728","number":6728,"state":"open","locked":false,"title":"[1LP][RFR] New tests and enhancements to service dialogs API testing","user":{"login":"mkoura","id":2352619,"avatar_url":"https://avatars1.githubusercontent.com/u/2352619?v=4","gravatar_id":"","url":"https://api.github.com/users/mkoura","html_url":"https://github.com/mkoura","followers_url":"https://api.github.com/users/mkoura/followers","following_url":"https://api.github.com/users/mkoura/following{/other_user}","gists_url":"https://api.github.com/users/mkoura/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoura/subscriptions","organizations_url":"https://api.github.com/users/mkoura/orgs","repos_url":"https://api.github.com/users/mkoura/repos","events_url":"https://api.github.com/users/mkoura/events{/privacy}","received_events_url":"https://api.github.com/users/mkoura/received_events","type":"User","site_admin":false},"body":"* removed unused ``dialog_ui`` function\r\n* better checking of data returned by create and edit actions\r\n* new test ``test_edit_service_dialogs``\r\n\r\n{{pytest: -v --long-running -k TestServiceDialogsRESTAPI cfme/tests/services/test_rest_services.py}}","created_at":"2018-02-22T15:05:43Z","updated_at":"2018-02-26T09:52:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28542903c80a29c440e812214145525221e1b72a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":118710104,"url":"https://api.github.com/repos/ManageIQ/integration_tests/labels/lint-ok","name":"lint-ok","color":"ffffff","default":false},{"id":469132575,"url":"https://api.github.com/repos/ManageIQ/integration_tests/labels/new-test-or-feature","name":"new-test-or-feature","color":"ffff55","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/6728/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/6728/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/6728/comments","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/0ce59846d81eb3870a2ec9c40d88415cb161cb9b","head":{"label":"mkoura:service_dialogs_enhancements","ref":"service_dialogs_enhancements","sha":"0ce59846d81eb3870a2ec9c40d88415cb161cb9b","user":{"login":"mkoura","id":2352619,"avatar_url":"https://avatars1.githubusercontent.com/u/2352619?v=4","gravatar_id":"","url":"https://api.github.com/users/mkoura","html_url":"https://github.com/mkoura","followers_url":"https://api.github.com/users/mkoura/followers","following_url":"https://api.github.com/users/mkoura/following{/other_user}","gists_url":"https://api.github.com/users/mkoura/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoura/subscriptions","organizations_url":"https://api.github.com/users/mkoura/orgs","repos_url":"https://api.github.com/users/mkoura/repos","events_url":"https://api.github.com/users/mkoura/events{/privacy}","received_events_url":"https://api.github.com/users/mkoura/received_events","type":"User","site_admin":false},"repo":{"id":58528439,"name":"cfme_tests","full_name":"mkoura/cfme_tests","owner":{"login":"mkoura","id":2352619,"avatar_url":"https://avatars1.githubusercontent.com/u/2352619?v=4","gravatar_id":"","url":"https://api.github.com/users/mkoura","html_url":"https://github.com/mkoura","followers_url":"https://api.github.com/users/mkoura/followers","following_url":"https://api.github.com/users/mkoura/following{/other_user}","gists_url":"https://api.github.com/users/mkoura/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoura/subscriptions","organizations_url":"https://api.github.com/users/mkoura/orgs","repos_url":"https://api.github.com/users/mkoura/repos","events_url":"https://api.github.com/users/mkoura/events{/privacy}","received_events_url":"https://api.github.com/users/mkoura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkoura/cfme_tests","description":"CloudForms Management Engine - Functional tests","fork":true,"url":"https://api.github.com/repos/mkoura/cfme_tests","forks_url":"https://api.github.com/repos/mkoura/cfme_tests/forks","keys_url":"https://api.github.com/repos/mkoura/cfme_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkoura/cfme_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkoura/cfme_tests/teams","hooks_url":"https://api.github.com/repos/mkoura/cfme_tests/hooks","issue_events_url":"https://api.github.com/repos/mkoura/cfme_tests/issues/events{/number}","events_url":"https://api.github.com/repos/mkoura/cfme_tests/events","assignees_url":"https://api.github.com/repos/mkoura/cfme_tests/assignees{/user}","branches_url":"https://api.github.com/repos/mkoura/cfme_tests/branches{/branch}","tags_url":"https://api.github.com/repos/mkoura/cfme_tests/tags","blobs_url":"https://api.github.com/repos/mkoura/cfme_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkoura/cfme_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkoura/cfme_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkoura/cfme_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkoura/cfme_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/mkoura/cfme_tests/languages","stargazers_url":"https://api.github.com/repos/mkoura/cfme_tests/stargazers","contributors_url":"https://api.github.com/repos/mkoura/cfme_tests/contributors","subscribers_url":"https://api.github.com/repos/mkoura/cfme_tests/subscribers","subscription_url":"https://api.github.com/repos/mkoura/cfme_tests/subscription","commits_url":"https://api.github.com/repos/mkoura/cfme_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkoura/cfme_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkoura/cfme_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkoura/cfme_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkoura/cfme_tests/contents/{+path}","compare_url":"https://api.github.com/repos/mkoura/cfme_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkoura/cfme_tests/merges","archive_url":"https://api.github.com/repos/mkoura/cfme_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkoura/cfme_tests/downloads","issues_url":"https://api.github.com/repos/mkoura/cfme_tests/issues{/number}","pulls_url":"https://api.github.com/repos/mkoura/cfme_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/mkoura/cfme_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/mkoura/cfme_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkoura/cfme_tests/labels{/name}","releases_url":"https://api.github.com/repos/mkoura/cfme_tests/releases{/id}","deployments_url":"https://api.github.com/repos/mkoura/cfme_tests/deployments","created_at":"2016-05-11T08:44:27Z","updated_at":"2016-05-11T08:44:29Z","pushed_at":"2018-02-23T10:42:02Z","git_url":"git://github.com/mkoura/cfme_tests.git","ssh_url":"git@github.com:mkoura/cfme_tests.git","clone_url":"https://github.com/mkoura/cfme_tests.git","svn_url":"https://github.com/mkoura/cfme_tests","homepage":"","size":23443,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"f9b31e789d65ebbfea79d634e67d5a0e33daf028","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":8061086,"name":"integration_tests","full_name":"ManageIQ/integration_tests","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/integration_tests","description":"ManageIQ integration tests","fork":false,"url":"https://api.github.com/repos/ManageIQ/integration_tests","forks_url":"https://api.github.com/repos/ManageIQ/integration_tests/forks","keys_url":"https://api.github.com/repos/ManageIQ/integration_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/integration_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/integration_tests/teams","hooks_url":"https://api.github.com/repos/ManageIQ/integration_tests/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/integration_tests/events","assignees_url":"https://api.github.com/repos/ManageIQ/integration_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/integration_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/tags","blobs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/integration_tests/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/integration_tests/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/integration_tests/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscription","commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/integration_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/integration_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/integration_tests/merges","archive_url":"https://api.github.com/repos/ManageIQ/integration_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/integration_tests/downloads","issues_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/integration_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/integration_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/integration_tests/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/integration_tests/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/integration_tests/deployments","created_at":"2013-02-06T21:59:17Z","updated_at":"2018-01-30T15:07:50Z","pushed_at":"2018-02-26T09:37:23Z","git_url":"git://github.com/ManageIQ/integration_tests.git","ssh_url":"git@github.com:ManageIQ/integration_tests.git","clone_url":"https://github.com/ManageIQ/integration_tests.git","svn_url":"https://github.com/ManageIQ/integration_tests","homepage":"","size":23739,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"open_issues_count":173,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":118,"open_issues":173,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/6728"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/6728"},"issue":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/6728"},"comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/6728/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/6728/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/6728/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/0ce59846d81eb3870a2ec9c40d88415cb161cb9b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"izapolsk"}}