{"action":"opened","number":753,"pull_request":{"url":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/753","id":236937258,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTM3MjU4","html_url":"https://github.com/Azure/sonic-mgmt/pull/753","diff_url":"https://github.com/Azure/sonic-mgmt/pull/753.diff","patch_url":"https://github.com/Azure/sonic-mgmt/pull/753.patch","issue_url":"https://api.github.com/repos/Azure/sonic-mgmt/issues/753","number":753,"state":"open","locked":false,"title":"[acl]: Revisit ACL test","user":{"login":"stcheng","id":2702699,"node_id":"MDQ6VXNlcjI3MDI2OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2702699?v=4","gravatar_id":"","url":"https://api.github.com/users/stcheng","html_url":"https://github.com/stcheng","followers_url":"https://api.github.com/users/stcheng/followers","following_url":"https://api.github.com/users/stcheng/following{/other_user}","gists_url":"https://api.github.com/users/stcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/stcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stcheng/subscriptions","organizations_url":"https://api.github.com/users/stcheng/orgs","repos_url":"https://api.github.com/users/stcheng/repos","events_url":"https://api.github.com/users/stcheng/events{/privacy}","received_events_url":"https://api.github.com/users/stcheng/received_events","type":"User","site_admin":false},"body":"1. The current ACL loader will insert a default DROP rule that\r\n   whatever doesn't match any rules will fall into this slot and\r\n   get dropped. Thus the current DROP rules inserted during the\r\n   test cannot be used to inspect if a rule is successfully\r\n   inserted or not. Thus I modified the rule file to make it test\r\n   if a packet is forwarded and received.\r\n\r\n2. A test #0 is added to make sure that if a packet doesn't fall into\r\n   any slots it will be dropped by default.\r\n\r\n3. Remove the current EtherType match rule since whatever ethertypes\r\n   that are not IP or IPv6 would be dropped. A TODO task is to add\r\n   rules that matches IPv4/IPv6 separately and determine if the field\r\n   works or not.\r\n\r\nSigned-off-by: Shuotian Cheng <stcheng_89@hotmail.com>","created_at":"2018-12-07T17:16:47Z","updated_at":"2018-12-07T17:16:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/753/commits","review_comments_url":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/753/comments","review_comment_url":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/sonic-mgmt/issues/753/comments","statuses_url":"https://api.github.com/repos/Azure/sonic-mgmt/statuses/950cd5f151820facaae6829889cbdd5562119dcd","head":{"label":"stcheng:acltb-ervisit","ref":"acltb-ervisit","sha":"950cd5f151820facaae6829889cbdd5562119dcd","user":{"login":"stcheng","id":2702699,"node_id":"MDQ6VXNlcjI3MDI2OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2702699?v=4","gravatar_id":"","url":"https://api.github.com/users/stcheng","html_url":"https://github.com/stcheng","followers_url":"https://api.github.com/users/stcheng/followers","following_url":"https://api.github.com/users/stcheng/following{/other_user}","gists_url":"https://api.github.com/users/stcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/stcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stcheng/subscriptions","organizations_url":"https://api.github.com/users/stcheng/orgs","repos_url":"https://api.github.com/users/stcheng/repos","events_url":"https://api.github.com/users/stcheng/events{/privacy}","received_events_url":"https://api.github.com/users/stcheng/received_events","type":"User","site_admin":false},"repo":{"id":71282749,"node_id":"MDEwOlJlcG9zaXRvcnk3MTI4Mjc0OQ==","name":"sonic-mgmt","full_name":"stcheng/sonic-mgmt","private":false,"owner":{"login":"stcheng","id":2702699,"node_id":"MDQ6VXNlcjI3MDI2OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2702699?v=4","gravatar_id":"","url":"https://api.github.com/users/stcheng","html_url":"https://github.com/stcheng","followers_url":"https://api.github.com/users/stcheng/followers","following_url":"https://api.github.com/users/stcheng/following{/other_user}","gists_url":"https://api.github.com/users/stcheng/gists{/gist_id}","starred_url":"https://api.github.com/users/stcheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stcheng/subscriptions","organizations_url":"https://api.github.com/users/stcheng/orgs","repos_url":"https://api.github.com/users/stcheng/repos","events_url":"https://api.github.com/users/stcheng/events{/privacy}","received_events_url":"https://api.github.com/users/stcheng/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stcheng/sonic-mgmt","description":"Configuration management examples for SONiC","fork":true,"url":"https://api.github.com/repos/stcheng/sonic-mgmt","forks_url":"https://api.github.com/repos/stcheng/sonic-mgmt/forks","keys_url":"https://api.github.com/repos/stcheng/sonic-mgmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stcheng/sonic-mgmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stcheng/sonic-mgmt/teams","hooks_url":"https://api.github.com/repos/stcheng/sonic-mgmt/hooks","issue_events_url":"https://api.github.com/repos/stcheng/sonic-mgmt/issues/events{/number}","events_url":"https://api.github.com/repos/stcheng/sonic-mgmt/events","assignees_url":"https://api.github.com/repos/stcheng/sonic-mgmt/assignees{/user}","branches_url":"https://api.github.com/repos/stcheng/sonic-mgmt/branches{/branch}","tags_url":"https://api.github.com/repos/stcheng/sonic-mgmt/tags","blobs_url":"https://api.github.com/repos/stcheng/sonic-mgmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stcheng/sonic-mgmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stcheng/sonic-mgmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/stcheng/sonic-mgmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stcheng/sonic-mgmt/statuses/{sha}","languages_url":"https://api.github.com/repos/stcheng/sonic-mgmt/languages","stargazers_url":"https://api.github.com/repos/stcheng/sonic-mgmt/stargazers","contributors_url":"https://api.github.com/repos/stcheng/sonic-mgmt/contributors","subscribers_url":"https://api.github.com/repos/stcheng/sonic-mgmt/subscribers","subscription_url":"https://api.github.com/repos/stcheng/sonic-mgmt/subscription","commits_url":"https://api.github.com/repos/stcheng/sonic-mgmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/stcheng/sonic-mgmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/stcheng/sonic-mgmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/stcheng/sonic-mgmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/stcheng/sonic-mgmt/contents/{+path}","compare_url":"https://api.github.com/repos/stcheng/sonic-mgmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stcheng/sonic-mgmt/merges","archive_url":"https://api.github.com/repos/stcheng/sonic-mgmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stcheng/sonic-mgmt/downloads","issues_url":"https://api.github.com/repos/stcheng/sonic-mgmt/issues{/number}","pulls_url":"https://api.github.com/repos/stcheng/sonic-mgmt/pulls{/number}","milestones_url":"https://api.github.com/repos/stcheng/sonic-mgmt/milestones{/number}","notifications_url":"https://api.github.com/repos/stcheng/sonic-mgmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stcheng/sonic-mgmt/labels{/name}","releases_url":"https://api.github.com/repos/stcheng/sonic-mgmt/releases{/id}","deployments_url":"https://api.github.com/repos/stcheng/sonic-mgmt/deployments","created_at":"2016-10-18T19:14:24Z","updated_at":"2016-10-18T19:14:26Z","pushed_at":"2018-12-07T17:16:22Z","git_url":"git://github.com/stcheng/sonic-mgmt.git","ssh_url":"git@github.com:stcheng/sonic-mgmt.git","clone_url":"https://github.com/stcheng/sonic-mgmt.git","svn_url":"https://github.com/stcheng/sonic-mgmt","homepage":null,"size":1468,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"a52af35ec4b881061799fc6529e0873691b8f25f","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":52558133,"node_id":"MDEwOlJlcG9zaXRvcnk1MjU1ODEzMw==","name":"sonic-mgmt","full_name":"Azure/sonic-mgmt","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/sonic-mgmt","description":"Configuration management examples for SONiC","fork":false,"url":"https://api.github.com/repos/Azure/sonic-mgmt","forks_url":"https://api.github.com/repos/Azure/sonic-mgmt/forks","keys_url":"https://api.github.com/repos/Azure/sonic-mgmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/sonic-mgmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/sonic-mgmt/teams","hooks_url":"https://api.github.com/repos/Azure/sonic-mgmt/hooks","issue_events_url":"https://api.github.com/repos/Azure/sonic-mgmt/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/sonic-mgmt/events","assignees_url":"https://api.github.com/repos/Azure/sonic-mgmt/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/sonic-mgmt/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/sonic-mgmt/tags","blobs_url":"https://api.github.com/repos/Azure/sonic-mgmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/sonic-mgmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/sonic-mgmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/sonic-mgmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/sonic-mgmt/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/sonic-mgmt/languages","stargazers_url":"https://api.github.com/repos/Azure/sonic-mgmt/stargazers","contributors_url":"https://api.github.com/repos/Azure/sonic-mgmt/contributors","subscribers_url":"https://api.github.com/repos/Azure/sonic-mgmt/subscribers","subscription_url":"https://api.github.com/repos/Azure/sonic-mgmt/subscription","commits_url":"https://api.github.com/repos/Azure/sonic-mgmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/sonic-mgmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/sonic-mgmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/sonic-mgmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/sonic-mgmt/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/sonic-mgmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/sonic-mgmt/merges","archive_url":"https://api.github.com/repos/Azure/sonic-mgmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/sonic-mgmt/downloads","issues_url":"https://api.github.com/repos/Azure/sonic-mgmt/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/sonic-mgmt/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/sonic-mgmt/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/sonic-mgmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/sonic-mgmt/labels{/name}","releases_url":"https://api.github.com/repos/Azure/sonic-mgmt/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/sonic-mgmt/deployments","created_at":"2016-02-25T21:28:59Z","updated_at":"2018-12-07T09:48:10Z","pushed_at":"2018-12-07T09:48:04Z","git_url":"git://github.com/Azure/sonic-mgmt.git","ssh_url":"git@github.com:Azure/sonic-mgmt.git","clone_url":"https://github.com/Azure/sonic-mgmt.git","svn_url":"https://github.com/Azure/sonic-mgmt","homepage":null,"size":1466,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":88,"open_issues":100,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/753"},"html":{"href":"https://github.com/Azure/sonic-mgmt/pull/753"},"issue":{"href":"https://api.github.com/repos/Azure/sonic-mgmt/issues/753"},"comments":{"href":"https://api.github.com/repos/Azure/sonic-mgmt/issues/753/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/753/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/sonic-mgmt/pulls/753/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/sonic-mgmt/statuses/950cd5f151820facaae6829889cbdd5562119dcd"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":134,"deletions":156,"changed_files":4}}
{"actor":{"display_login":"stcheng"}}