{"action":"created","comment":{"url":"https://api.github.com/repos/eslint/eslint/pulls/comments/184833062","pull_request_review_id":116114243,"id":184833062,"diff_hunk":"@@ -38,6 +38,45 @@ function getTopConcatBinaryExpression(node) {\n     return currentNode;\n }\n \n+/**\n+ * Determines whether a given node is a octal escape sequence\n+ * @param {ASTNode} node A node to check\n+ * @returns {boolean} `true` if the node is an octal escape sequence\n+ */\n+function isOctalEscapeSequence(node) {\n+\n+    // No need to check TemplateLiterals – would throw error with octal escape\n+    const isStringLiteral = node.type === \"Literal\" && typeof node.value === \"string\";\n+\n+    if (!isStringLiteral) {\n+        return false;\n+    }\n+\n+    const match = node.raw.match(/^([^\\\\]|\\\\[^0-7])*\\\\([0-3][0-7]{1,2}|[4-7][0-7]|[0-7])/);","path":"lib/rules/prefer-template.js","position":18,"original_position":18,"commit_id":"17dc1a50bdf3174d1b4ebf671e1d96cdc7bea28d","original_commit_id":"17dc1a50bdf3174d1b4ebf671e1d96cdc7bea28d","user":{"login":"not-an-aardvark","id":11638619,"avatar_url":"https://avatars2.githubusercontent.com/u/11638619?v=4","gravatar_id":"","url":"https://api.github.com/users/not-an-aardvark","html_url":"https://github.com/not-an-aardvark","followers_url":"https://api.github.com/users/not-an-aardvark/followers","following_url":"https://api.github.com/users/not-an-aardvark/following{/other_user}","gists_url":"https://api.github.com/users/not-an-aardvark/gists{/gist_id}","starred_url":"https://api.github.com/users/not-an-aardvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/not-an-aardvark/subscriptions","organizations_url":"https://api.github.com/users/not-an-aardvark/orgs","repos_url":"https://api.github.com/users/not-an-aardvark/repos","events_url":"https://api.github.com/users/not-an-aardvark/events{/privacy}","received_events_url":"https://api.github.com/users/not-an-aardvark/received_events","type":"User","site_admin":false},"body":"I think the second part of this regular expression could be simplified from this:\r\n\r\n```\r\n([0-3][0-7]{1,2}|[4-7][0-7]|[0-7])\r\n```\r\n\r\nto this:\r\n\r\n```\r\n([0-7]{1,3})\r\n```\r\n\r\n...since it seems like the `[0-7]` character class will always match something even if the other cases don't.","created_at":"2018-04-28T00:45:35Z","updated_at":"2018-04-28T00:52:05Z","html_url":"https://github.com/eslint/eslint/pull/10240#discussion_r184833062","pull_request_url":"https://api.github.com/repos/eslint/eslint/pulls/10240","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments/184833062"},"html":{"href":"https://github.com/eslint/eslint/pull/10240#discussion_r184833062"},"pull_request":{"href":"https://api.github.com/repos/eslint/eslint/pulls/10240"}}},"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/10240","id":182578460,"html_url":"https://github.com/eslint/eslint/pull/10240","diff_url":"https://github.com/eslint/eslint/pull/10240.diff","patch_url":"https://github.com/eslint/eslint/pull/10240.patch","issue_url":"https://api.github.com/repos/eslint/eslint/issues/10240","number":10240,"state":"open","locked":false,"title":" Fix: do not autofix octal escape sequence (fixes #10031)","user":{"login":"malcolmsgroves","id":26167038,"avatar_url":"https://avatars2.githubusercontent.com/u/26167038?v=4","gravatar_id":"","url":"https://api.github.com/users/malcolmsgroves","html_url":"https://github.com/malcolmsgroves","followers_url":"https://api.github.com/users/malcolmsgroves/followers","following_url":"https://api.github.com/users/malcolmsgroves/following{/other_user}","gists_url":"https://api.github.com/users/malcolmsgroves/gists{/gist_id}","starred_url":"https://api.github.com/users/malcolmsgroves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malcolmsgroves/subscriptions","organizations_url":"https://api.github.com/users/malcolmsgroves/orgs","repos_url":"https://api.github.com/users/malcolmsgroves/repos","events_url":"https://api.github.com/users/malcolmsgroves/events{/privacy}","received_events_url":"https://api.github.com/users/malcolmsgroves/received_events","type":"User","site_admin":false},"body":"<!--\r\n    ESLint adheres to the [JS Foundation Code of Conduct](https://js.foundation/community/code-of-conduct).\r\n-->\r\n\r\n**What is the purpose of this pull request? (put an \"X\" next to item)**\r\n\r\n[ ] Documentation update\r\n[X] Bug fix ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/bug-report.md))\r\n[ ] New rule ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/rule-proposal.md))\r\n[ ] Changes an existing rule ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/rule-change-proposal.md))\r\n[ ] Add autofixing to a rule\r\n[ ] Add a CLI option\r\n[ ] Add something to the core\r\n[ ] Other, please explain:\r\n\r\n<!--\r\n    If the item you've checked above has a template, please paste the template questions below and answer them. (If this pull request is addressing an issue, you can just paste a link to the issue here instead.)\r\n-->\r\nhttps://github.com/eslint/eslint/issues/10031\r\n<!--\r\n    Please ensure your pull request is ready:\r\n\r\n    - Read the pull request guide (https://eslint.org/docs/developer-guide/contributing/pull-requests)\r\n    - Include tests for this change\r\n    - Update documentation for this change (if appropriate)\r\n-->\r\n\r\n<!--\r\n    The following is required for all pull requests:\r\n-->\r\n\r\n**What changes did you make? (Give an overview)**\r\nAdded a check for octal escape sequences in binary expressions. The```prefer-template``` rule does not attempt to fix binary expressions that contain octal escape sequences, and returns a ```null``` fixer object if this is the case.\r\n\r\nAlso added a test that ensures that binary expressions with octal escape sequences are not auto fixed.\r\n\r\n**Is there anything you'd like reviewers to focus on?**\r\n\r\n","created_at":"2018-04-18T19:24:12Z","updated_at":"2018-04-28T00:52:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97365a02c9e7151eefa4455ec0b488a47a086995","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":131106229,"url":"https://api.github.com/repos/eslint/eslint/labels/accepted","name":"accepted","color":"0052cc","default":false},{"id":45711350,"url":"https://api.github.com/repos/eslint/eslint/labels/bug","name":"bug","color":"fc2929","default":true},{"id":45798639,"url":"https://api.github.com/repos/eslint/eslint/labels/rule","name":"rule","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eslint/eslint/pulls/10240/commits","review_comments_url":"https://api.github.com/repos/eslint/eslint/pulls/10240/comments","review_comment_url":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/10240/comments","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/17dc1a50bdf3174d1b4ebf671e1d96cdc7bea28d","head":{"label":"malcolmsgroves:issue10031","ref":"issue10031","sha":"17dc1a50bdf3174d1b4ebf671e1d96cdc7bea28d","user":{"login":"malcolmsgroves","id":26167038,"avatar_url":"https://avatars2.githubusercontent.com/u/26167038?v=4","gravatar_id":"","url":"https://api.github.com/users/malcolmsgroves","html_url":"https://github.com/malcolmsgroves","followers_url":"https://api.github.com/users/malcolmsgroves/followers","following_url":"https://api.github.com/users/malcolmsgroves/following{/other_user}","gists_url":"https://api.github.com/users/malcolmsgroves/gists{/gist_id}","starred_url":"https://api.github.com/users/malcolmsgroves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malcolmsgroves/subscriptions","organizations_url":"https://api.github.com/users/malcolmsgroves/orgs","repos_url":"https://api.github.com/users/malcolmsgroves/repos","events_url":"https://api.github.com/users/malcolmsgroves/events{/privacy}","received_events_url":"https://api.github.com/users/malcolmsgroves/received_events","type":"User","site_admin":false},"repo":{"id":128997179,"name":"eslint","full_name":"malcolmsgroves/eslint","owner":{"login":"malcolmsgroves","id":26167038,"avatar_url":"https://avatars2.githubusercontent.com/u/26167038?v=4","gravatar_id":"","url":"https://api.github.com/users/malcolmsgroves","html_url":"https://github.com/malcolmsgroves","followers_url":"https://api.github.com/users/malcolmsgroves/followers","following_url":"https://api.github.com/users/malcolmsgroves/following{/other_user}","gists_url":"https://api.github.com/users/malcolmsgroves/gists{/gist_id}","starred_url":"https://api.github.com/users/malcolmsgroves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malcolmsgroves/subscriptions","organizations_url":"https://api.github.com/users/malcolmsgroves/orgs","repos_url":"https://api.github.com/users/malcolmsgroves/repos","events_url":"https://api.github.com/users/malcolmsgroves/events{/privacy}","received_events_url":"https://api.github.com/users/malcolmsgroves/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/malcolmsgroves/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript","fork":true,"url":"https://api.github.com/repos/malcolmsgroves/eslint","forks_url":"https://api.github.com/repos/malcolmsgroves/eslint/forks","keys_url":"https://api.github.com/repos/malcolmsgroves/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/malcolmsgroves/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/malcolmsgroves/eslint/teams","hooks_url":"https://api.github.com/repos/malcolmsgroves/eslint/hooks","issue_events_url":"https://api.github.com/repos/malcolmsgroves/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/malcolmsgroves/eslint/events","assignees_url":"https://api.github.com/repos/malcolmsgroves/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/malcolmsgroves/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/malcolmsgroves/eslint/tags","blobs_url":"https://api.github.com/repos/malcolmsgroves/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/malcolmsgroves/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/malcolmsgroves/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/malcolmsgroves/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/malcolmsgroves/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/malcolmsgroves/eslint/languages","stargazers_url":"https://api.github.com/repos/malcolmsgroves/eslint/stargazers","contributors_url":"https://api.github.com/repos/malcolmsgroves/eslint/contributors","subscribers_url":"https://api.github.com/repos/malcolmsgroves/eslint/subscribers","subscription_url":"https://api.github.com/repos/malcolmsgroves/eslint/subscription","commits_url":"https://api.github.com/repos/malcolmsgroves/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/malcolmsgroves/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/malcolmsgroves/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/malcolmsgroves/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/malcolmsgroves/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/malcolmsgroves/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/malcolmsgroves/eslint/merges","archive_url":"https://api.github.com/repos/malcolmsgroves/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/malcolmsgroves/eslint/downloads","issues_url":"https://api.github.com/repos/malcolmsgroves/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/malcolmsgroves/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/malcolmsgroves/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/malcolmsgroves/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/malcolmsgroves/eslint/labels{/name}","releases_url":"https://api.github.com/repos/malcolmsgroves/eslint/releases{/id}","deployments_url":"https://api.github.com/repos/malcolmsgroves/eslint/deployments","created_at":"2018-04-10T21:30:14Z","updated_at":"2018-04-17T23:11:05Z","pushed_at":"2018-04-18T19:33:25Z","git_url":"git://github.com/malcolmsgroves/eslint.git","ssh_url":"git@github.com:malcolmsgroves/eslint.git","clone_url":"https://github.com/malcolmsgroves/eslint.git","svn_url":"https://github.com/malcolmsgroves/eslint","homepage":"https://eslint.org","size":17876,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eslint:master","ref":"master","sha":"a2953ec0c975f6ac8f44fbe6944a6f3116f445cc","user":{"login":"eslint","id":6019716,"avatar_url":"https://avatars3.githubusercontent.com/u/6019716?v=4","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"repo":{"id":11061773,"name":"eslint","full_name":"eslint/eslint","owner":{"login":"eslint","id":6019716,"avatar_url":"https://avatars3.githubusercontent.com/u/6019716?v=4","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eslint/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript","fork":false,"url":"https://api.github.com/repos/eslint/eslint","forks_url":"https://api.github.com/repos/eslint/eslint/forks","keys_url":"https://api.github.com/repos/eslint/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eslint/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eslint/eslint/teams","hooks_url":"https://api.github.com/repos/eslint/eslint/hooks","issue_events_url":"https://api.github.com/repos/eslint/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/eslint/eslint/events","assignees_url":"https://api.github.com/repos/eslint/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/eslint/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/eslint/eslint/tags","blobs_url":"https://api.github.com/repos/eslint/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eslint/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eslint/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/eslint/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/eslint/eslint/languages","stargazers_url":"https://api.github.com/repos/eslint/eslint/stargazers","contributors_url":"https://api.github.com/repos/eslint/eslint/contributors","subscribers_url":"https://api.github.com/repos/eslint/eslint/subscribers","subscription_url":"https://api.github.com/repos/eslint/eslint/subscription","commits_url":"https://api.github.com/repos/eslint/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/eslint/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/eslint/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/eslint/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/eslint/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/eslint/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eslint/eslint/merges","archive_url":"https://api.github.com/repos/eslint/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eslint/eslint/downloads","issues_url":"https://api.github.com/repos/eslint/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/eslint/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/eslint/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/eslint/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eslint/eslint/labels{/name}","releases_url":"https://api.github.com/repos/eslint/eslint/releases{/id}","deployments_url":"https://api.github.com/repos/eslint/eslint/deployments","created_at":"2013-06-29T23:59:48Z","updated_at":"2018-04-27T23:53:03Z","pushed_at":"2018-04-27T21:34:31Z","git_url":"git://github.com/eslint/eslint.git","ssh_url":"git@github.com:eslint/eslint.git","clone_url":"https://github.com/eslint/eslint.git","svn_url":"https://github.com/eslint/eslint","homepage":"https://eslint.org","size":17888,"stargazers_count":11221,"watchers_count":11221,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1936,"mirror_url":null,"archived":false,"open_issues_count":306,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1936,"open_issues":306,"watchers":11221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/10240"},"html":{"href":"https://github.com/eslint/eslint/pull/10240"},"issue":{"href":"https://api.github.com/repos/eslint/eslint/issues/10240"},"comments":{"href":"https://api.github.com/repos/eslint/eslint/issues/10240/comments"},"review_comments":{"href":"https://api.github.com/repos/eslint/eslint/pulls/10240/comments"},"review_comment":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eslint/eslint/pulls/10240/commits"},"statuses":{"href":"https://api.github.com/repos/eslint/eslint/statuses/17dc1a50bdf3174d1b4ebf671e1d96cdc7bea28d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"not-an-aardvark"}}