{"action":"created","comment":{"url":"https://api.github.com/repos/invenia/FTPClient.jl/pulls/comments/212424104","pull_request_review_id":149055513,"id":212424104,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjQyNDEwNA==","diff_hunk":"@@ -62,19 +61,29 @@ end\n \n function RequestOptions(\n     url::AbstractString;\n-    ssl::Bool=false,\n     verify_peer::Bool=true,\n     active_mode::Bool=false,\n+    ssl::Union{Nothing, Bool}=nothing,\n )\n+    if ssl !== nothing\n+         Base.depwarn(\n+            \"RequestOptions(url; ssl=false, verify_peer=true, active_mode=false) is \" *\n+            \"deprecated, use \\\"ftpes://\\\" or \\\"ftps://\\\" in the url to indicate \" *\n+            \"explicit or implicit ssl respectively\",\n+            :RequestOptions\n+        )\n+        url = ssl ? replace(url, \"ftp://\" => \"ftpes://\") : url\n+    end\n+\n     uri = URI(url)\n \n-    if !(uri.scheme in (\"ftps\", \"ftp\"))\n+    if !(uri.scheme in (\"ftps\", \"ftp\", \"ftpes\"))\n         throw(ArgumentError(\"Unhandled FTP scheme: $(uri.scheme)\"))\n     end\n \n     RequestOptions(\n         uri,\n-        uri.scheme == \"ftps\" ? true : ssl,\n+        uri.scheme in (\"ftps\", \"ftpes\") ? true : false,","path":"src/FTPC.jl","position":43,"original_position":43,"commit_id":"0182a549d9a4a9ef5af494710a0cedea71a4269f","original_commit_id":"0182a549d9a4a9ef5af494710a0cedea71a4269f","user":{"login":"omus","id":1675958,"node_id":"MDQ6VXNlcjE2NzU5NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1675958?v=4","gravatar_id":"","url":"https://api.github.com/users/omus","html_url":"https://github.com/omus","followers_url":"https://api.github.com/users/omus/followers","following_url":"https://api.github.com/users/omus/following{/other_user}","gists_url":"https://api.github.com/users/omus/gists{/gist_id}","starred_url":"https://api.github.com/users/omus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omus/subscriptions","organizations_url":"https://api.github.com/users/omus/orgs","repos_url":"https://api.github.com/users/omus/repos","events_url":"https://api.github.com/users/omus/events{/privacy}","received_events_url":"https://api.github.com/users/omus/received_events","type":"User","site_admin":false},"body":"Don't need the ternary","created_at":"2018-08-23T19:07:49Z","updated_at":"2018-08-23T19:20:50Z","html_url":"https://github.com/invenia/FTPClient.jl/pull/67#discussion_r212424104","pull_request_url":"https://api.github.com/repos/invenia/FTPClient.jl/pulls/67","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/invenia/FTPClient.jl/pulls/comments/212424104"},"html":{"href":"https://github.com/invenia/FTPClient.jl/pull/67#discussion_r212424104"},"pull_request":{"href":"https://api.github.com/repos/invenia/FTPClient.jl/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/invenia/FTPClient.jl/pulls/67","id":210264343,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMjY0MzQz","html_url":"https://github.com/invenia/FTPClient.jl/pull/67","diff_url":"https://github.com/invenia/FTPClient.jl/pull/67.diff","patch_url":"https://github.com/invenia/FTPClient.jl/pull/67.patch","issue_url":"https://api.github.com/repos/invenia/FTPClient.jl/issues/67","number":67,"state":"open","locked":false,"title":"Add support for \"ftpes://\" protocol parsing","user":{"login":"nicoleepp","id":11255768,"node_id":"MDQ6VXNlcjExMjU1NzY4","avatar_url":"https://avatars3.githubusercontent.com/u/11255768?v=4","gravatar_id":"","url":"https://api.github.com/users/nicoleepp","html_url":"https://github.com/nicoleepp","followers_url":"https://api.github.com/users/nicoleepp/followers","following_url":"https://api.github.com/users/nicoleepp/following{/other_user}","gists_url":"https://api.github.com/users/nicoleepp/gists{/gist_id}","starred_url":"https://api.github.com/users/nicoleepp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicoleepp/subscriptions","organizations_url":"https://api.github.com/users/nicoleepp/orgs","repos_url":"https://api.github.com/users/nicoleepp/repos","events_url":"https://api.github.com/users/nicoleepp/events{/privacy}","received_events_url":"https://api.github.com/users/nicoleepp/received_events","type":"User","site_admin":false},"body":"Closes #64","created_at":"2018-08-22T21:05:06Z","updated_at":"2018-08-23T19:20:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bc3d03f6b77fff4e8e85b5135b2a43b01422e8d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/invenia/FTPClient.jl/pulls/67/commits","review_comments_url":"https://api.github.com/repos/invenia/FTPClient.jl/pulls/67/comments","review_comment_url":"https://api.github.com/repos/invenia/FTPClient.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/invenia/FTPClient.jl/issues/67/comments","statuses_url":"https://api.github.com/repos/invenia/FTPClient.jl/statuses/0182a549d9a4a9ef5af494710a0cedea71a4269f","head":{"label":"invenia:ne/parse-protocol","ref":"ne/parse-protocol","sha":"0182a549d9a4a9ef5af494710a0cedea71a4269f","user":{"login":"invenia","id":5262440,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNjI0NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5262440?v=4","gravatar_id":"","url":"https://api.github.com/users/invenia","html_url":"https://github.com/invenia","followers_url":"https://api.github.com/users/invenia/followers","following_url":"https://api.github.com/users/invenia/following{/other_user}","gists_url":"https://api.github.com/users/invenia/gists{/gist_id}","starred_url":"https://api.github.com/users/invenia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invenia/subscriptions","organizations_url":"https://api.github.com/users/invenia/orgs","repos_url":"https://api.github.com/users/invenia/repos","events_url":"https://api.github.com/users/invenia/events{/privacy}","received_events_url":"https://api.github.com/users/invenia/received_events","type":"Organization","site_admin":false},"repo":{"id":38510098,"node_id":"MDEwOlJlcG9zaXRvcnkzODUxMDA5OA==","name":"FTPClient.jl","full_name":"invenia/FTPClient.jl","owner":{"login":"invenia","id":5262440,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNjI0NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5262440?v=4","gravatar_id":"","url":"https://api.github.com/users/invenia","html_url":"https://github.com/invenia","followers_url":"https://api.github.com/users/invenia/followers","following_url":"https://api.github.com/users/invenia/following{/other_user}","gists_url":"https://api.github.com/users/invenia/gists{/gist_id}","starred_url":"https://api.github.com/users/invenia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invenia/subscriptions","organizations_url":"https://api.github.com/users/invenia/orgs","repos_url":"https://api.github.com/users/invenia/repos","events_url":"https://api.github.com/users/invenia/events{/privacy}","received_events_url":"https://api.github.com/users/invenia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/invenia/FTPClient.jl","description":"Julia FTP client using LibCURL.jl","fork":false,"url":"https://api.github.com/repos/invenia/FTPClient.jl","forks_url":"https://api.github.com/repos/invenia/FTPClient.jl/forks","keys_url":"https://api.github.com/repos/invenia/FTPClient.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/invenia/FTPClient.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/invenia/FTPClient.jl/teams","hooks_url":"https://api.github.com/repos/invenia/FTPClient.jl/hooks","issue_events_url":"https://api.github.com/repos/invenia/FTPClient.jl/issues/events{/number}","events_url":"https://api.github.com/repos/invenia/FTPClient.jl/events","assignees_url":"https://api.github.com/repos/invenia/FTPClient.jl/assignees{/user}","branches_url":"https://api.github.com/repos/invenia/FTPClient.jl/branches{/branch}","tags_url":"https://api.github.com/repos/invenia/FTPClient.jl/tags","blobs_url":"https://api.github.com/repos/invenia/FTPClient.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/invenia/FTPClient.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/invenia/FTPClient.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/invenia/FTPClient.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/invenia/FTPClient.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/invenia/FTPClient.jl/languages","stargazers_url":"https://api.github.com/repos/invenia/FTPClient.jl/stargazers","contributors_url":"https://api.github.com/repos/invenia/FTPClient.jl/contributors","subscribers_url":"https://api.github.com/repos/invenia/FTPClient.jl/subscribers","subscription_url":"https://api.github.com/repos/invenia/FTPClient.jl/subscription","commits_url":"https://api.github.com/repos/invenia/FTPClient.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/invenia/FTPClient.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/invenia/FTPClient.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/invenia/FTPClient.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/invenia/FTPClient.jl/contents/{+path}","compare_url":"https://api.github.com/repos/invenia/FTPClient.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/invenia/FTPClient.jl/merges","archive_url":"https://api.github.com/repos/invenia/FTPClient.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/invenia/FTPClient.jl/downloads","issues_url":"https://api.github.com/repos/invenia/FTPClient.jl/issues{/number}","pulls_url":"https://api.github.com/repos/invenia/FTPClient.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/invenia/FTPClient.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/invenia/FTPClient.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/invenia/FTPClient.jl/labels{/name}","releases_url":"https://api.github.com/repos/invenia/FTPClient.jl/releases{/id}","deployments_url":"https://api.github.com/repos/invenia/FTPClient.jl/deployments","created_at":"2015-07-03T20:50:52Z","updated_at":"2018-08-03T01:15:32Z","pushed_at":"2018-08-23T17:47:51Z","git_url":"git://github.com/invenia/FTPClient.jl.git","ssh_url":"git@github.com:invenia/FTPClient.jl.git","clone_url":"https://github.com/invenia/FTPClient.jl.git","svn_url":"https://github.com/invenia/FTPClient.jl","homepage":"","size":5953,"stargazers_count":6,"watchers_count":6,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":3,"open_issues":11,"watchers":6,"default_branch":"master"}},"base":{"label":"invenia:master","ref":"master","sha":"856de70f5d1776d8dbf6c51ac5a6da07244002b4","user":{"login":"invenia","id":5262440,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNjI0NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5262440?v=4","gravatar_id":"","url":"https://api.github.com/users/invenia","html_url":"https://github.com/invenia","followers_url":"https://api.github.com/users/invenia/followers","following_url":"https://api.github.com/users/invenia/following{/other_user}","gists_url":"https://api.github.com/users/invenia/gists{/gist_id}","starred_url":"https://api.github.com/users/invenia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invenia/subscriptions","organizations_url":"https://api.github.com/users/invenia/orgs","repos_url":"https://api.github.com/users/invenia/repos","events_url":"https://api.github.com/users/invenia/events{/privacy}","received_events_url":"https://api.github.com/users/invenia/received_events","type":"Organization","site_admin":false},"repo":{"id":38510098,"node_id":"MDEwOlJlcG9zaXRvcnkzODUxMDA5OA==","name":"FTPClient.jl","full_name":"invenia/FTPClient.jl","owner":{"login":"invenia","id":5262440,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNjI0NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5262440?v=4","gravatar_id":"","url":"https://api.github.com/users/invenia","html_url":"https://github.com/invenia","followers_url":"https://api.github.com/users/invenia/followers","following_url":"https://api.github.com/users/invenia/following{/other_user}","gists_url":"https://api.github.com/users/invenia/gists{/gist_id}","starred_url":"https://api.github.com/users/invenia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invenia/subscriptions","organizations_url":"https://api.github.com/users/invenia/orgs","repos_url":"https://api.github.com/users/invenia/repos","events_url":"https://api.github.com/users/invenia/events{/privacy}","received_events_url":"https://api.github.com/users/invenia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/invenia/FTPClient.jl","description":"Julia FTP client using LibCURL.jl","fork":false,"url":"https://api.github.com/repos/invenia/FTPClient.jl","forks_url":"https://api.github.com/repos/invenia/FTPClient.jl/forks","keys_url":"https://api.github.com/repos/invenia/FTPClient.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/invenia/FTPClient.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/invenia/FTPClient.jl/teams","hooks_url":"https://api.github.com/repos/invenia/FTPClient.jl/hooks","issue_events_url":"https://api.github.com/repos/invenia/FTPClient.jl/issues/events{/number}","events_url":"https://api.github.com/repos/invenia/FTPClient.jl/events","assignees_url":"https://api.github.com/repos/invenia/FTPClient.jl/assignees{/user}","branches_url":"https://api.github.com/repos/invenia/FTPClient.jl/branches{/branch}","tags_url":"https://api.github.com/repos/invenia/FTPClient.jl/tags","blobs_url":"https://api.github.com/repos/invenia/FTPClient.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/invenia/FTPClient.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/invenia/FTPClient.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/invenia/FTPClient.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/invenia/FTPClient.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/invenia/FTPClient.jl/languages","stargazers_url":"https://api.github.com/repos/invenia/FTPClient.jl/stargazers","contributors_url":"https://api.github.com/repos/invenia/FTPClient.jl/contributors","subscribers_url":"https://api.github.com/repos/invenia/FTPClient.jl/subscribers","subscription_url":"https://api.github.com/repos/invenia/FTPClient.jl/subscription","commits_url":"https://api.github.com/repos/invenia/FTPClient.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/invenia/FTPClient.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/invenia/FTPClient.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/invenia/FTPClient.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/invenia/FTPClient.jl/contents/{+path}","compare_url":"https://api.github.com/repos/invenia/FTPClient.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/invenia/FTPClient.jl/merges","archive_url":"https://api.github.com/repos/invenia/FTPClient.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/invenia/FTPClient.jl/downloads","issues_url":"https://api.github.com/repos/invenia/FTPClient.jl/issues{/number}","pulls_url":"https://api.github.com/repos/invenia/FTPClient.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/invenia/FTPClient.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/invenia/FTPClient.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/invenia/FTPClient.jl/labels{/name}","releases_url":"https://api.github.com/repos/invenia/FTPClient.jl/releases{/id}","deployments_url":"https://api.github.com/repos/invenia/FTPClient.jl/deployments","created_at":"2015-07-03T20:50:52Z","updated_at":"2018-08-03T01:15:32Z","pushed_at":"2018-08-23T17:47:51Z","git_url":"git://github.com/invenia/FTPClient.jl.git","ssh_url":"git@github.com:invenia/FTPClient.jl.git","clone_url":"https://github.com/invenia/FTPClient.jl.git","svn_url":"https://github.com/invenia/FTPClient.jl","homepage":"","size":5953,"stargazers_count":6,"watchers_count":6,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":3,"open_issues":11,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/invenia/FTPClient.jl/pulls/67"},"html":{"href":"https://github.com/invenia/FTPClient.jl/pull/67"},"issue":{"href":"https://api.github.com/repos/invenia/FTPClient.jl/issues/67"},"comments":{"href":"https://api.github.com/repos/invenia/FTPClient.jl/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/invenia/FTPClient.jl/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/invenia/FTPClient.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/invenia/FTPClient.jl/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/invenia/FTPClient.jl/statuses/0182a549d9a4a9ef5af494710a0cedea71a4269f"}},"author_association":"NONE"}}
{"actor":{"display_login":"omus"}}