{"action":"created","comment":{"url":"https://api.github.com/repos/genestack/JS-SDK/pulls/comments/214007006","pull_request_review_id":150964329,"id":214007006,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDAwNzAwNg==","diff_hunk":"@@ -0,0 +1,29 @@\n+/*\n+ * Copyright (c) 2011-2018 Genestack Limited\n+ * All Rights Reserved\n+ * This source code is distributed under the MIT license:\n+ * https://github.com/genestack/JS-SDK/tree/master/LICENSE\n+ */\n+\n+import SystemMessage from './system-message';\n+\n+type HandleErrorMessageType = 'G$:handle-error';\n+export const HANDLE_ERROR_MESSAGE_TYPE: HandleErrorMessageType = 'G$:handle-error';\n+\n+interface GenestackServerError {\n+    name: string;\n+    message: string;\n+    stack: string;\n+    serverStackTrace: string;\n+    responseText: string;\n+    calledApplicationId: string;\n+    method: string;\n+    parameters: Array<any>;\n+    notificationError: string;","path":"packages/interfaces/src/handle-error-message.ts","position":22,"original_position":22,"commit_id":"ed8ec827d5b3643772cf98933c8b55152b0e2922","original_commit_id":"ed8ec827d5b3643772cf98933c8b55152b0e2922","user":{"login":"RB-Lab","id":5694678,"node_id":"MDQ6VXNlcjU2OTQ2Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/5694678?v=4","gravatar_id":"","url":"https://api.github.com/users/RB-Lab","html_url":"https://github.com/RB-Lab","followers_url":"https://api.github.com/users/RB-Lab/followers","following_url":"https://api.github.com/users/RB-Lab/following{/other_user}","gists_url":"https://api.github.com/users/RB-Lab/gists{/gist_id}","starred_url":"https://api.github.com/users/RB-Lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RB-Lab/subscriptions","organizations_url":"https://api.github.com/users/RB-Lab/orgs","repos_url":"https://api.github.com/users/RB-Lab/repos","events_url":"https://api.github.com/users/RB-Lab/events{/privacy}","received_events_url":"https://api.github.com/users/RB-Lab/received_events","type":"User","site_admin":false},"body":"Good catch! 👍 ","created_at":"2018-08-30T12:16:39Z","updated_at":"2018-08-30T12:16:39Z","html_url":"https://github.com/genestack/JS-SDK/pull/3#discussion_r214007006","pull_request_url":"https://api.github.com/repos/genestack/JS-SDK/pulls/3","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/genestack/JS-SDK/pulls/comments/214007006"},"html":{"href":"https://github.com/genestack/JS-SDK/pull/3#discussion_r214007006"},"pull_request":{"href":"https://api.github.com/repos/genestack/JS-SDK/pulls/3"}},"in_reply_to_id":213995867},"pull_request":{"url":"https://api.github.com/repos/genestack/JS-SDK/pulls/3","id":212019615,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMDE5NjE1","html_url":"https://github.com/genestack/JS-SDK/pull/3","diff_url":"https://github.com/genestack/JS-SDK/pull/3.diff","patch_url":"https://github.com/genestack/JS-SDK/pull/3.patch","issue_url":"https://api.github.com/repos/genestack/JS-SDK/issues/3","number":3,"state":"open","locked":false,"title":"mehtod-invocation: add error handling handler (GS-11691)","user":{"login":"RB-Lab","id":5694678,"node_id":"MDQ6VXNlcjU2OTQ2Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/5694678?v=4","gravatar_id":"","url":"https://api.github.com/users/RB-Lab","html_url":"https://github.com/RB-Lab","followers_url":"https://api.github.com/users/RB-Lab/followers","following_url":"https://api.github.com/users/RB-Lab/following{/other_user}","gists_url":"https://api.github.com/users/RB-Lab/gists{/gist_id}","starred_url":"https://api.github.com/users/RB-Lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RB-Lab/subscriptions","organizations_url":"https://api.github.com/users/RB-Lab/orgs","repos_url":"https://api.github.com/users/RB-Lab/repos","events_url":"https://api.github.com/users/RB-Lab/events{/privacy}","received_events_url":"https://api.github.com/users/RB-Lab/received_events","type":"User","site_admin":false},"body":"Original defect: https://genestack.atlassian.net/browse/GS-11691\r\n\r\nFirst of all, I just forgot about error handling, and the second – strict checks in TS are disabled by default (as it turned out).","created_at":"2018-08-30T09:50:05Z","updated_at":"2018-08-30T12:16:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b048b50c0959f0fd1cdef6fb9ad7323426f3301","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/genestack/JS-SDK/pulls/3/commits","review_comments_url":"https://api.github.com/repos/genestack/JS-SDK/pulls/3/comments","review_comment_url":"https://api.github.com/repos/genestack/JS-SDK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/genestack/JS-SDK/issues/3/comments","statuses_url":"https://api.github.com/repos/genestack/JS-SDK/statuses/ed8ec827d5b3643772cf98933c8b55152b0e2922","head":{"label":"genestack:rb/fix-error-handling-GS-11691","ref":"rb/fix-error-handling-GS-11691","sha":"ed8ec827d5b3643772cf98933c8b55152b0e2922","user":{"login":"genestack","id":1460470,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjA0NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1460470?v=4","gravatar_id":"","url":"https://api.github.com/users/genestack","html_url":"https://github.com/genestack","followers_url":"https://api.github.com/users/genestack/followers","following_url":"https://api.github.com/users/genestack/following{/other_user}","gists_url":"https://api.github.com/users/genestack/gists{/gist_id}","starred_url":"https://api.github.com/users/genestack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genestack/subscriptions","organizations_url":"https://api.github.com/users/genestack/orgs","repos_url":"https://api.github.com/users/genestack/repos","events_url":"https://api.github.com/users/genestack/events{/privacy}","received_events_url":"https://api.github.com/users/genestack/received_events","type":"Organization","site_admin":false},"repo":{"id":145590215,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU1OTAyMTU=","name":"JS-SDK","full_name":"genestack/JS-SDK","owner":{"login":"genestack","id":1460470,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjA0NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1460470?v=4","gravatar_id":"","url":"https://api.github.com/users/genestack","html_url":"https://github.com/genestack","followers_url":"https://api.github.com/users/genestack/followers","following_url":"https://api.github.com/users/genestack/following{/other_user}","gists_url":"https://api.github.com/users/genestack/gists{/gist_id}","starred_url":"https://api.github.com/users/genestack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genestack/subscriptions","organizations_url":"https://api.github.com/users/genestack/orgs","repos_url":"https://api.github.com/users/genestack/repos","events_url":"https://api.github.com/users/genestack/events{/privacy}","received_events_url":"https://api.github.com/users/genestack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/genestack/JS-SDK","description":"This monorepository contains components of Genestack JavaScript software development kit","fork":false,"url":"https://api.github.com/repos/genestack/JS-SDK","forks_url":"https://api.github.com/repos/genestack/JS-SDK/forks","keys_url":"https://api.github.com/repos/genestack/JS-SDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genestack/JS-SDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genestack/JS-SDK/teams","hooks_url":"https://api.github.com/repos/genestack/JS-SDK/hooks","issue_events_url":"https://api.github.com/repos/genestack/JS-SDK/issues/events{/number}","events_url":"https://api.github.com/repos/genestack/JS-SDK/events","assignees_url":"https://api.github.com/repos/genestack/JS-SDK/assignees{/user}","branches_url":"https://api.github.com/repos/genestack/JS-SDK/branches{/branch}","tags_url":"https://api.github.com/repos/genestack/JS-SDK/tags","blobs_url":"https://api.github.com/repos/genestack/JS-SDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genestack/JS-SDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genestack/JS-SDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/genestack/JS-SDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genestack/JS-SDK/statuses/{sha}","languages_url":"https://api.github.com/repos/genestack/JS-SDK/languages","stargazers_url":"https://api.github.com/repos/genestack/JS-SDK/stargazers","contributors_url":"https://api.github.com/repos/genestack/JS-SDK/contributors","subscribers_url":"https://api.github.com/repos/genestack/JS-SDK/subscribers","subscription_url":"https://api.github.com/repos/genestack/JS-SDK/subscription","commits_url":"https://api.github.com/repos/genestack/JS-SDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/genestack/JS-SDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/genestack/JS-SDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/genestack/JS-SDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/genestack/JS-SDK/contents/{+path}","compare_url":"https://api.github.com/repos/genestack/JS-SDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genestack/JS-SDK/merges","archive_url":"https://api.github.com/repos/genestack/JS-SDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genestack/JS-SDK/downloads","issues_url":"https://api.github.com/repos/genestack/JS-SDK/issues{/number}","pulls_url":"https://api.github.com/repos/genestack/JS-SDK/pulls{/number}","milestones_url":"https://api.github.com/repos/genestack/JS-SDK/milestones{/number}","notifications_url":"https://api.github.com/repos/genestack/JS-SDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genestack/JS-SDK/labels{/name}","releases_url":"https://api.github.com/repos/genestack/JS-SDK/releases{/id}","deployments_url":"https://api.github.com/repos/genestack/JS-SDK/deployments","created_at":"2018-08-21T16:24:01Z","updated_at":"2018-08-29T09:44:57Z","pushed_at":"2018-08-30T09:50:05Z","git_url":"git://github.com/genestack/JS-SDK.git","ssh_url":"git@github.com:genestack/JS-SDK.git","clone_url":"https://github.com/genestack/JS-SDK.git","svn_url":"https://github.com/genestack/JS-SDK","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"genestack:master","ref":"master","sha":"c499319ec93e2856faefde766929c9cb2cc0c448","user":{"login":"genestack","id":1460470,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjA0NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1460470?v=4","gravatar_id":"","url":"https://api.github.com/users/genestack","html_url":"https://github.com/genestack","followers_url":"https://api.github.com/users/genestack/followers","following_url":"https://api.github.com/users/genestack/following{/other_user}","gists_url":"https://api.github.com/users/genestack/gists{/gist_id}","starred_url":"https://api.github.com/users/genestack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genestack/subscriptions","organizations_url":"https://api.github.com/users/genestack/orgs","repos_url":"https://api.github.com/users/genestack/repos","events_url":"https://api.github.com/users/genestack/events{/privacy}","received_events_url":"https://api.github.com/users/genestack/received_events","type":"Organization","site_admin":false},"repo":{"id":145590215,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU1OTAyMTU=","name":"JS-SDK","full_name":"genestack/JS-SDK","owner":{"login":"genestack","id":1460470,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjA0NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1460470?v=4","gravatar_id":"","url":"https://api.github.com/users/genestack","html_url":"https://github.com/genestack","followers_url":"https://api.github.com/users/genestack/followers","following_url":"https://api.github.com/users/genestack/following{/other_user}","gists_url":"https://api.github.com/users/genestack/gists{/gist_id}","starred_url":"https://api.github.com/users/genestack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genestack/subscriptions","organizations_url":"https://api.github.com/users/genestack/orgs","repos_url":"https://api.github.com/users/genestack/repos","events_url":"https://api.github.com/users/genestack/events{/privacy}","received_events_url":"https://api.github.com/users/genestack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/genestack/JS-SDK","description":"This monorepository contains components of Genestack JavaScript software development kit","fork":false,"url":"https://api.github.com/repos/genestack/JS-SDK","forks_url":"https://api.github.com/repos/genestack/JS-SDK/forks","keys_url":"https://api.github.com/repos/genestack/JS-SDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genestack/JS-SDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genestack/JS-SDK/teams","hooks_url":"https://api.github.com/repos/genestack/JS-SDK/hooks","issue_events_url":"https://api.github.com/repos/genestack/JS-SDK/issues/events{/number}","events_url":"https://api.github.com/repos/genestack/JS-SDK/events","assignees_url":"https://api.github.com/repos/genestack/JS-SDK/assignees{/user}","branches_url":"https://api.github.com/repos/genestack/JS-SDK/branches{/branch}","tags_url":"https://api.github.com/repos/genestack/JS-SDK/tags","blobs_url":"https://api.github.com/repos/genestack/JS-SDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genestack/JS-SDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genestack/JS-SDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/genestack/JS-SDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genestack/JS-SDK/statuses/{sha}","languages_url":"https://api.github.com/repos/genestack/JS-SDK/languages","stargazers_url":"https://api.github.com/repos/genestack/JS-SDK/stargazers","contributors_url":"https://api.github.com/repos/genestack/JS-SDK/contributors","subscribers_url":"https://api.github.com/repos/genestack/JS-SDK/subscribers","subscription_url":"https://api.github.com/repos/genestack/JS-SDK/subscription","commits_url":"https://api.github.com/repos/genestack/JS-SDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/genestack/JS-SDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/genestack/JS-SDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/genestack/JS-SDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/genestack/JS-SDK/contents/{+path}","compare_url":"https://api.github.com/repos/genestack/JS-SDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genestack/JS-SDK/merges","archive_url":"https://api.github.com/repos/genestack/JS-SDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genestack/JS-SDK/downloads","issues_url":"https://api.github.com/repos/genestack/JS-SDK/issues{/number}","pulls_url":"https://api.github.com/repos/genestack/JS-SDK/pulls{/number}","milestones_url":"https://api.github.com/repos/genestack/JS-SDK/milestones{/number}","notifications_url":"https://api.github.com/repos/genestack/JS-SDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genestack/JS-SDK/labels{/name}","releases_url":"https://api.github.com/repos/genestack/JS-SDK/releases{/id}","deployments_url":"https://api.github.com/repos/genestack/JS-SDK/deployments","created_at":"2018-08-21T16:24:01Z","updated_at":"2018-08-29T09:44:57Z","pushed_at":"2018-08-30T09:50:05Z","git_url":"git://github.com/genestack/JS-SDK.git","ssh_url":"git@github.com:genestack/JS-SDK.git","clone_url":"https://github.com/genestack/JS-SDK.git","svn_url":"https://github.com/genestack/JS-SDK","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/genestack/JS-SDK/pulls/3"},"html":{"href":"https://github.com/genestack/JS-SDK/pull/3"},"issue":{"href":"https://api.github.com/repos/genestack/JS-SDK/issues/3"},"comments":{"href":"https://api.github.com/repos/genestack/JS-SDK/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/genestack/JS-SDK/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/genestack/JS-SDK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/genestack/JS-SDK/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/genestack/JS-SDK/statuses/ed8ec827d5b3643772cf98933c8b55152b0e2922"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"RB-Lab"}}