{"action":"created","comment":{"url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments/232389914","pull_request_review_id":173586234,"id":232389914,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjM4OTkxNA==","diff_hunk":"@@ -0,0 +1,84 @@\n+/* Copyright 2018\n+ *\n+ * This program is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU General Public License as published by\n+ * the Free Software Foundation, either version 2 of the License, or\n+ * (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ * GNU General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU General Public License\n+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.\n+ */\n+#pragma once\n+\n+#include \"quantum.h\"\n+#define ___ KC_NO\n+\n+#ifndef FLIP_HALF\n+#define LAYOUT_split( \\\n+\tL00, L01, L02, L03, L04, R00, R01, R02, R03, R04, \\\n+\tL10, L11, L12, L13, L14, R10, R11, R12, R13, R14, \\\n+\tL20, L21, L22, L23, L24, R20, R21, R22, R23, R24, \\\n+\tL30, L31, L32, L33, L34, R30, R31, R32, R33, R34, \\\n+\tL40, L41, L42, L43, L44, R40, R41, R42, R43, R44  \\\n+) { \\\n+\t{ L00, L01, L02, L03, L04 }, \\\n+\t{ L10, L11, L12, L13, L14 }, \\\n+\t{ L20, L21, L22, L23, L24 }, \\\n+\t{ L30, L31, L32, L33, L34 }, \\\n+\t{ L40, L41, L42, L43, L44 }, \\\n+\t{ R04, R03, R02, R01, R00 }, \\\n+\t{ R14, R13, R12, R11, R10 }, \\\n+\t{ R24, R23, R22, R21, R20 }, \\\n+\t{ R34, R33, R32, R31, R30 }, \\\n+\t{ R44, R43, R42, R41, R40 }  \\\n+}\n+#else\n+#define LAYOUT_split( \\\n+\tL00, L01, L02, L03, L04, R00, R01, R02, R03, R04, \\\n+\tL10, L11, L12, L13, L14, R10, R11, R12, R13, R14, \\\n+\tL20, L21, L22, L23, L24, R20, R21, R22, R23, R24, \\\n+\tL30, L31, L32, L33, L34, R30, R31, R32, R33, R34, \\\n+\tL40, L41, L42, L43, L44, R40, R41, R42, R43, R44  \\\n+) { \\\n+\t{ L00, L01, L02, L03, L04 }, \\\n+\t{ L10, L11, L12, L13, L14 }, \\\n+\t{ L20, L21, L22, L23, L24 }, \\\n+\t{ L30, L31, L32, L33, L34 }, \\\n+\t{ L40, L41, L42, L43, L44 }, \\\n+\t{ R00, R01, R02, R03, R04 }, \\\n+\t{ R10, R11, R12, R13, R14 }, \\\n+\t{ R20, R21, R22, R23, R24 }, \\\n+\t{ R30, R31, R32, R33, R34 }, \\\n+\t{ R40, R41, R42, R43, R44 }  \\\n+}\n+#endif\n+\n+#define LAYOUT_macro( \\\n+\tL00, L01, L02, L03, L04, \\\n+\tL10, L11, L12, L13, L14, \\\n+\tL20, L21, L22, L23, L24, \\\n+\tL30, L31, L32, L33, L34, \\\n+\tL40, L41, L42, L43, L44  \\\n+) { \\\n+\t{ L00, L01, L02, L03, L04 }, \\\n+\t{ L10, L11, L12, L13, L14 }, \\\n+\t{ L20, L21, L22, L23, L24 }, \\\n+\t{ L30, L31, L32, L33, L34 }, \\\n+\t{ L40, L41, L42, L43, L44 }, \\\n+\t{ ___, ___, ___, ___, ___ }, \\\n+  { ___, ___, ___, ___, ___ }, \\\n+  { ___, ___, ___, ___, ___ }, \\\n+  { ___, ___, ___, ___, ___ }, \\\n+  { ___, ___, ___, ___, ___ }  \\\n+}\n+\n+#define LAYOUT LAYOUT_macro","path":"keyboards/40percentclub/25/25.h","position":80,"original_position":80,"commit_id":"1dbadff070bba6617d4211e0ca43d49712b47a72","original_commit_id":"1dbadff070bba6617d4211e0ca43d49712b47a72","user":{"login":"zvecr","id":16520359,"node_id":"MDQ6VXNlcjE2NTIwMzU5","avatar_url":"https://avatars1.githubusercontent.com/u/16520359?v=4","gravatar_id":"","url":"https://api.github.com/users/zvecr","html_url":"https://github.com/zvecr","followers_url":"https://api.github.com/users/zvecr/followers","following_url":"https://api.github.com/users/zvecr/following{/other_user}","gists_url":"https://api.github.com/users/zvecr/gists{/gist_id}","starred_url":"https://api.github.com/users/zvecr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zvecr/subscriptions","organizations_url":"https://api.github.com/users/zvecr/orgs","repos_url":"https://api.github.com/users/zvecr/repos","events_url":"https://api.github.com/users/zvecr/events{/privacy}","received_events_url":"https://api.github.com/users/zvecr/received_events","type":"User","site_admin":false},"body":"Given a quick grep across the code base, `grep -h -r \"#define LAYOUT\" keyboards/ | sort | uniq -c | sort -k 1 -n` gives 192 instances of `#define layout` and at least 20 instances of aliases. It was an attempt to make the keymaps more consistent with other boards and potentially provide a clearer intention within the keymap files.\r\n\r\nWith the other suggested changes, my preference would be to go with something like:\r\n`#define LAYOUT_macro LAYOUT_ortho_5x5\r\n#define LAYOUT_split LAYOUT_ortho_5x10\r\n#define LAYOUT LAYOUT_ortho_5x5`\r\n","created_at":"2018-11-09T20:52:18Z","updated_at":"2018-11-09T20:52:18Z","html_url":"https://github.com/qmk/qmk_firmware/pull/4394#discussion_r232389914","pull_request_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4394","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments/232389914"},"html":{"href":"https://github.com/qmk/qmk_firmware/pull/4394#discussion_r232389914"},"pull_request":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4394"}},"in_reply_to_id":232129420},"pull_request":{"url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4394","id":229571221,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTcxMjIx","html_url":"https://github.com/qmk/qmk_firmware/pull/4394","diff_url":"https://github.com/qmk/qmk_firmware/pull/4394.diff","patch_url":"https://github.com/qmk/qmk_firmware/pull/4394.patch","issue_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4394","number":4394,"state":"open","locked":false,"title":"Initial 25 port","user":{"login":"zvecr","id":16520359,"node_id":"MDQ6VXNlcjE2NTIwMzU5","avatar_url":"https://avatars1.githubusercontent.com/u/16520359?v=4","gravatar_id":"","url":"https://api.github.com/users/zvecr","html_url":"https://github.com/zvecr","followers_url":"https://api.github.com/users/zvecr/followers","following_url":"https://api.github.com/users/zvecr/following{/other_user}","gists_url":"https://api.github.com/users/zvecr/gists{/gist_id}","starred_url":"https://api.github.com/users/zvecr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zvecr/subscriptions","organizations_url":"https://api.github.com/users/zvecr/orgs","repos_url":"https://api.github.com/users/zvecr/repos","events_url":"https://api.github.com/users/zvecr/events{/privacy}","received_events_url":"https://api.github.com/users/zvecr/received_events","type":"User","site_admin":false},"body":"Port of original TMK firmware (https://github.com/di0ib/tmk_keyboard/tree/master/keyboard/25) following what has been previously done for other 40percent.club boards.\r\n\r\nFor now, this is the last of the boards i currently have pcbs for.","created_at":"2018-11-09T02:38:02Z","updated_at":"2018-11-09T20:52:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9504fd4ff2706d07842949012c67ad6f72963ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":720614009,"node_id":"MDU6TGFiZWw3MjA2MTQwMDk=","url":"https://api.github.com/repos/qmk/qmk_firmware/labels/keyboard","name":"keyboard","color":"647fc1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4394/commits","review_comments_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4394/comments","review_comment_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4394/comments","statuses_url":"https://api.github.com/repos/qmk/qmk_firmware/statuses/1dbadff070bba6617d4211e0ca43d49712b47a72","head":{"label":"zvecr:feature/port-25","ref":"feature/port-25","sha":"1dbadff070bba6617d4211e0ca43d49712b47a72","user":{"login":"zvecr","id":16520359,"node_id":"MDQ6VXNlcjE2NTIwMzU5","avatar_url":"https://avatars1.githubusercontent.com/u/16520359?v=4","gravatar_id":"","url":"https://api.github.com/users/zvecr","html_url":"https://github.com/zvecr","followers_url":"https://api.github.com/users/zvecr/followers","following_url":"https://api.github.com/users/zvecr/following{/other_user}","gists_url":"https://api.github.com/users/zvecr/gists{/gist_id}","starred_url":"https://api.github.com/users/zvecr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zvecr/subscriptions","organizations_url":"https://api.github.com/users/zvecr/orgs","repos_url":"https://api.github.com/users/zvecr/repos","events_url":"https://api.github.com/users/zvecr/events{/privacy}","received_events_url":"https://api.github.com/users/zvecr/received_events","type":"User","site_admin":false},"repo":{"id":156141624,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYxNDE2MjQ=","name":"qmk_firmware","full_name":"zvecr/qmk_firmware","private":false,"owner":{"login":"zvecr","id":16520359,"node_id":"MDQ6VXNlcjE2NTIwMzU5","avatar_url":"https://avatars1.githubusercontent.com/u/16520359?v=4","gravatar_id":"","url":"https://api.github.com/users/zvecr","html_url":"https://github.com/zvecr","followers_url":"https://api.github.com/users/zvecr/followers","following_url":"https://api.github.com/users/zvecr/following{/other_user}","gists_url":"https://api.github.com/users/zvecr/gists{/gist_id}","starred_url":"https://api.github.com/users/zvecr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zvecr/subscriptions","organizations_url":"https://api.github.com/users/zvecr/orgs","repos_url":"https://api.github.com/users/zvecr/repos","events_url":"https://api.github.com/users/zvecr/events{/privacy}","received_events_url":"https://api.github.com/users/zvecr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zvecr/qmk_firmware","description":"keyboard controller firmware for Atmel AVR and ARM USB families","fork":true,"url":"https://api.github.com/repos/zvecr/qmk_firmware","forks_url":"https://api.github.com/repos/zvecr/qmk_firmware/forks","keys_url":"https://api.github.com/repos/zvecr/qmk_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zvecr/qmk_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zvecr/qmk_firmware/teams","hooks_url":"https://api.github.com/repos/zvecr/qmk_firmware/hooks","issue_events_url":"https://api.github.com/repos/zvecr/qmk_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/zvecr/qmk_firmware/events","assignees_url":"https://api.github.com/repos/zvecr/qmk_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/zvecr/qmk_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/zvecr/qmk_firmware/tags","blobs_url":"https://api.github.com/repos/zvecr/qmk_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zvecr/qmk_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zvecr/qmk_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/zvecr/qmk_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zvecr/qmk_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/zvecr/qmk_firmware/languages","stargazers_url":"https://api.github.com/repos/zvecr/qmk_firmware/stargazers","contributors_url":"https://api.github.com/repos/zvecr/qmk_firmware/contributors","subscribers_url":"https://api.github.com/repos/zvecr/qmk_firmware/subscribers","subscription_url":"https://api.github.com/repos/zvecr/qmk_firmware/subscription","commits_url":"https://api.github.com/repos/zvecr/qmk_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/zvecr/qmk_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/zvecr/qmk_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/zvecr/qmk_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/zvecr/qmk_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/zvecr/qmk_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zvecr/qmk_firmware/merges","archive_url":"https://api.github.com/repos/zvecr/qmk_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zvecr/qmk_firmware/downloads","issues_url":"https://api.github.com/repos/zvecr/qmk_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/zvecr/qmk_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/zvecr/qmk_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/zvecr/qmk_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zvecr/qmk_firmware/labels{/name}","releases_url":"https://api.github.com/repos/zvecr/qmk_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/zvecr/qmk_firmware/deployments","created_at":"2018-11-05T01:05:33Z","updated_at":"2018-11-09T01:04:46Z","pushed_at":"2018-11-09T02:37:15Z","git_url":"git://github.com/zvecr/qmk_firmware.git","ssh_url":"git@github.com:zvecr/qmk_firmware.git","clone_url":"https://github.com/zvecr/qmk_firmware.git","svn_url":"https://github.com/zvecr/qmk_firmware","homepage":"http://qmk.fm","size":105896,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qmk:master","ref":"master","sha":"fa2183a64a1f8619f0b0ce9b8087732eaaa154bf","user":{"login":"qmk","id":25358678,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU4Njc4","avatar_url":"https://avatars3.githubusercontent.com/u/25358678?v=4","gravatar_id":"","url":"https://api.github.com/users/qmk","html_url":"https://github.com/qmk","followers_url":"https://api.github.com/users/qmk/followers","following_url":"https://api.github.com/users/qmk/following{/other_user}","gists_url":"https://api.github.com/users/qmk/gists{/gist_id}","starred_url":"https://api.github.com/users/qmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmk/subscriptions","organizations_url":"https://api.github.com/users/qmk/orgs","repos_url":"https://api.github.com/users/qmk/repos","events_url":"https://api.github.com/users/qmk/events{/privacy}","received_events_url":"https://api.github.com/users/qmk/received_events","type":"Organization","site_admin":false},"repo":{"id":27737393,"node_id":"MDEwOlJlcG9zaXRvcnkyNzczNzM5Mw==","name":"qmk_firmware","full_name":"qmk/qmk_firmware","private":false,"owner":{"login":"qmk","id":25358678,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU4Njc4","avatar_url":"https://avatars3.githubusercontent.com/u/25358678?v=4","gravatar_id":"","url":"https://api.github.com/users/qmk","html_url":"https://github.com/qmk","followers_url":"https://api.github.com/users/qmk/followers","following_url":"https://api.github.com/users/qmk/following{/other_user}","gists_url":"https://api.github.com/users/qmk/gists{/gist_id}","starred_url":"https://api.github.com/users/qmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmk/subscriptions","organizations_url":"https://api.github.com/users/qmk/orgs","repos_url":"https://api.github.com/users/qmk/repos","events_url":"https://api.github.com/users/qmk/events{/privacy}","received_events_url":"https://api.github.com/users/qmk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qmk/qmk_firmware","description":"keyboard controller firmware for Atmel AVR and ARM USB families","fork":false,"url":"https://api.github.com/repos/qmk/qmk_firmware","forks_url":"https://api.github.com/repos/qmk/qmk_firmware/forks","keys_url":"https://api.github.com/repos/qmk/qmk_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qmk/qmk_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qmk/qmk_firmware/teams","hooks_url":"https://api.github.com/repos/qmk/qmk_firmware/hooks","issue_events_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/qmk/qmk_firmware/events","assignees_url":"https://api.github.com/repos/qmk/qmk_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/qmk/qmk_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/qmk/qmk_firmware/tags","blobs_url":"https://api.github.com/repos/qmk/qmk_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qmk/qmk_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qmk/qmk_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/qmk/qmk_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qmk/qmk_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/qmk/qmk_firmware/languages","stargazers_url":"https://api.github.com/repos/qmk/qmk_firmware/stargazers","contributors_url":"https://api.github.com/repos/qmk/qmk_firmware/contributors","subscribers_url":"https://api.github.com/repos/qmk/qmk_firmware/subscribers","subscription_url":"https://api.github.com/repos/qmk/qmk_firmware/subscription","commits_url":"https://api.github.com/repos/qmk/qmk_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/qmk/qmk_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/qmk/qmk_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/qmk/qmk_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/qmk/qmk_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qmk/qmk_firmware/merges","archive_url":"https://api.github.com/repos/qmk/qmk_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qmk/qmk_firmware/downloads","issues_url":"https://api.github.com/repos/qmk/qmk_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/qmk/qmk_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/qmk/qmk_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qmk/qmk_firmware/labels{/name}","releases_url":"https://api.github.com/repos/qmk/qmk_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/qmk/qmk_firmware/deployments","created_at":"2014-12-08T22:02:05Z","updated_at":"2018-11-09T20:38:35Z","pushed_at":"2018-11-09T20:48:16Z","git_url":"git://github.com/qmk/qmk_firmware.git","ssh_url":"git@github.com:qmk/qmk_firmware.git","clone_url":"https://github.com/qmk/qmk_firmware.git","svn_url":"https://github.com/qmk/qmk_firmware","homepage":"http://qmk.fm","size":120611,"stargazers_count":3210,"watchers_count":3210,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":6009,"mirror_url":null,"archived":false,"open_issues_count":314,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6009,"open_issues":314,"watchers":3210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4394"},"html":{"href":"https://github.com/qmk/qmk_firmware/pull/4394"},"issue":{"href":"https://api.github.com/repos/qmk/qmk_firmware/issues/4394"},"comments":{"href":"https://api.github.com/repos/qmk/qmk_firmware/issues/4394/comments"},"review_comments":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4394/comments"},"review_comment":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4394/commits"},"statuses":{"href":"https://api.github.com/repos/qmk/qmk_firmware/statuses/1dbadff070bba6617d4211e0ca43d49712b47a72"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zvecr"}}