{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/180582169","pull_request_review_id":111027890,"id":180582169,"diff_hunk":"@@ -175,8 +212,8 @@ export class Cid {\n     const scope = getCidStruct.scope;\n     /** @const {!Location} */\n     const url = parseUrl(this.ampdoc.win.location.href);\n+    const apiKey = this.isScopeOptedIn_(scope);","path":"src/service/cid-impl.js","position":68,"original_position":68,"commit_id":"9be9045171f536970ecc0f35bb7be0ec22f213dc","original_commit_id":"9be9045171f536970ecc0f35bb7be0ec22f213dc","user":{"login":"choumx","id":20525523,"avatar_url":"https://avatars1.githubusercontent.com/u/20525523?v=4","gravatar_id":"","url":"https://api.github.com/users/choumx","html_url":"https://github.com/choumx","followers_url":"https://api.github.com/users/choumx/followers","following_url":"https://api.github.com/users/choumx/following{/other_user}","gists_url":"https://api.github.com/users/choumx/gists{/gist_id}","starred_url":"https://api.github.com/users/choumx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choumx/subscriptions","organizations_url":"https://api.github.com/users/choumx/orgs","repos_url":"https://api.github.com/users/choumx/repos","events_url":"https://api.github.com/users/choumx/events{/privacy}","received_events_url":"https://api.github.com/users/choumx/received_events","type":"User","site_admin":false},"body":"Let's only call this if necessary to avoid wasted work.","created_at":"2018-04-10T22:08:21Z","updated_at":"2018-04-10T22:39:02Z","html_url":"https://github.com/ampproject/amphtml/pull/14450#discussion_r180582169","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14450","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/180582169"},"html":{"href":"https://github.com/ampproject/amphtml/pull/14450#discussion_r180582169"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14450"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/14450","id":179805464,"html_url":"https://github.com/ampproject/amphtml/pull/14450","diff_url":"https://github.com/ampproject/amphtml/pull/14450.diff","patch_url":"https://github.com/ampproject/amphtml/pull/14450.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/14450","number":14450,"state":"open","locked":false,"title":"Add support for cache:getClientId","user":{"login":"RJSumi","id":6004860,"avatar_url":"https://avatars0.githubusercontent.com/u/6004860?v=4","gravatar_id":"","url":"https://api.github.com/users/RJSumi","html_url":"https://github.com/RJSumi","followers_url":"https://api.github.com/users/RJSumi/followers","following_url":"https://api.github.com/users/RJSumi/following{/other_user}","gists_url":"https://api.github.com/users/RJSumi/gists{/gist_id}","starred_url":"https://api.github.com/users/RJSumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJSumi/subscriptions","organizations_url":"https://api.github.com/users/RJSumi/orgs","repos_url":"https://api.github.com/users/RJSumi/repos","events_url":"https://api.github.com/users/RJSumi/events{/privacy}","received_events_url":"https://api.github.com/users/RJSumi/received_events","type":"User","site_admin":false},"body":"* Implements support for cache:getClientId via a new class, CacheCidApi.\r\n\r\nThe current status of the pull has a temporary implementation of isCctEmbedded.  This PR is intended to follow https://github.com/ampproject/amphtml/pull/14224, which implements it better.\r\n\r\nPlease advise on how to better share the retry and opted-in scopes code between the CacheCidApi and the ViewerCidApi/GoogleCidApi.\r\n\r\nWorking on unit tests at the moment.\r\n\r\nFixes #13118 ","created_at":"2018-04-05T21:46:08Z","updated_at":"2018-04-10T22:39:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3dcb3afa4dd2f2dfa5aa79ff5c7d7ca39a7118e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars0.githubusercontent.com/u/5419904?v=4","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":596633554,"url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14450/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14450/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/14450/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/9be9045171f536970ecc0f35bb7be0ec22f213dc","head":{"label":"RJSumi:cache-cid-api","ref":"cache-cid-api","sha":"9be9045171f536970ecc0f35bb7be0ec22f213dc","user":{"login":"RJSumi","id":6004860,"avatar_url":"https://avatars0.githubusercontent.com/u/6004860?v=4","gravatar_id":"","url":"https://api.github.com/users/RJSumi","html_url":"https://github.com/RJSumi","followers_url":"https://api.github.com/users/RJSumi/followers","following_url":"https://api.github.com/users/RJSumi/following{/other_user}","gists_url":"https://api.github.com/users/RJSumi/gists{/gist_id}","starred_url":"https://api.github.com/users/RJSumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJSumi/subscriptions","organizations_url":"https://api.github.com/users/RJSumi/orgs","repos_url":"https://api.github.com/users/RJSumi/repos","events_url":"https://api.github.com/users/RJSumi/events{/privacy}","received_events_url":"https://api.github.com/users/RJSumi/received_events","type":"User","site_admin":false},"repo":{"id":107464317,"name":"amphtml","full_name":"RJSumi/amphtml","owner":{"login":"RJSumi","id":6004860,"avatar_url":"https://avatars0.githubusercontent.com/u/6004860?v=4","gravatar_id":"","url":"https://api.github.com/users/RJSumi","html_url":"https://github.com/RJSumi","followers_url":"https://api.github.com/users/RJSumi/followers","following_url":"https://api.github.com/users/RJSumi/following{/other_user}","gists_url":"https://api.github.com/users/RJSumi/gists{/gist_id}","starred_url":"https://api.github.com/users/RJSumi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJSumi/subscriptions","organizations_url":"https://api.github.com/users/RJSumi/orgs","repos_url":"https://api.github.com/users/RJSumi/repos","events_url":"https://api.github.com/users/RJSumi/events{/privacy}","received_events_url":"https://api.github.com/users/RJSumi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RJSumi/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/RJSumi/amphtml","forks_url":"https://api.github.com/repos/RJSumi/amphtml/forks","keys_url":"https://api.github.com/repos/RJSumi/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RJSumi/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RJSumi/amphtml/teams","hooks_url":"https://api.github.com/repos/RJSumi/amphtml/hooks","issue_events_url":"https://api.github.com/repos/RJSumi/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/RJSumi/amphtml/events","assignees_url":"https://api.github.com/repos/RJSumi/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/RJSumi/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/RJSumi/amphtml/tags","blobs_url":"https://api.github.com/repos/RJSumi/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RJSumi/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RJSumi/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/RJSumi/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RJSumi/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/RJSumi/amphtml/languages","stargazers_url":"https://api.github.com/repos/RJSumi/amphtml/stargazers","contributors_url":"https://api.github.com/repos/RJSumi/amphtml/contributors","subscribers_url":"https://api.github.com/repos/RJSumi/amphtml/subscribers","subscription_url":"https://api.github.com/repos/RJSumi/amphtml/subscription","commits_url":"https://api.github.com/repos/RJSumi/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/RJSumi/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/RJSumi/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/RJSumi/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/RJSumi/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/RJSumi/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RJSumi/amphtml/merges","archive_url":"https://api.github.com/repos/RJSumi/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RJSumi/amphtml/downloads","issues_url":"https://api.github.com/repos/RJSumi/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/RJSumi/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/RJSumi/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/RJSumi/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RJSumi/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/RJSumi/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/RJSumi/amphtml/deployments","created_at":"2017-10-18T21:19:48Z","updated_at":"2018-04-10T21:41:14Z","pushed_at":"2018-04-10T21:53:25Z","git_url":"git://github.com/RJSumi/amphtml.git","ssh_url":"git@github.com:RJSumi/amphtml.git","clone_url":"https://github.com/RJSumi/amphtml.git","svn_url":"https://github.com/RJSumi/amphtml","homepage":"https://www.ampproject.org","size":416035,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"35cf3d5a91a5a443d52725c5565431e2c44ce6b3","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-04-10T21:15:46Z","pushed_at":"2018-04-10T22:35:38Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":417259,"stargazers_count":11428,"watchers_count":11428,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2323,"mirror_url":null,"archived":false,"open_issues_count":1271,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2323,"open_issues":1271,"watchers":11428,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14450"},"html":{"href":"https://github.com/ampproject/amphtml/pull/14450"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/14450"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/14450/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14450/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14450/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/9be9045171f536970ecc0f35bb7be0ec22f213dc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"choumx"}}