{"action":"created","comment":{"url":"https://api.github.com/repos/singer-io/tap-facebook/pulls/comments/171351990","pull_request_review_id":100189313,"id":171351990,"diff_hunk":"@@ -196,10 +208,12 @@ def do_request():\n             include_deleted = CONFIG.get('include_deleted', 'false')\n             if include_deleted.lower() == 'true':\n                 params.update({'filtering': get_delivery_info_filter('ad')})\n-            return self.account.get_ads(fields=self.fields(), params=params) # pylint: disable=no-member\n+            if self.current_bookmark:\n+                params['filtering'].append({'field': 'ad.' + UPDATED_TIME_KEY, 'operator': 'GREATER_THAN', 'value': self.current_bookmark.int_timestamp})","path":"tap_facebook/__init__.py","position":null,"original_position":40,"commit_id":"425a0b0a11d1ce2759358a3bdcb35356c68f3ac5","original_commit_id":"c6b228a100d088eb0057954e9468498a363b3b16","user":{"login":"KAllan357","id":221009,"avatar_url":"https://avatars3.githubusercontent.com/u/221009?v=4","gravatar_id":"","url":"https://api.github.com/users/KAllan357","html_url":"https://github.com/KAllan357","followers_url":"https://api.github.com/users/KAllan357/followers","following_url":"https://api.github.com/users/KAllan357/following{/other_user}","gists_url":"https://api.github.com/users/KAllan357/gists{/gist_id}","starred_url":"https://api.github.com/users/KAllan357/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KAllan357/subscriptions","organizations_url":"https://api.github.com/users/KAllan357/orgs","repos_url":"https://api.github.com/users/KAllan357/repos","events_url":"https://api.github.com/users/KAllan357/events{/privacy}","received_events_url":"https://api.github.com/users/KAllan357/received_events","type":"User","site_admin":false},"body":"Good catch","created_at":"2018-02-28T19:07:22Z","updated_at":"2018-02-28T19:08:10Z","html_url":"https://github.com/singer-io/tap-facebook/pull/37#discussion_r171351990","pull_request_url":"https://api.github.com/repos/singer-io/tap-facebook/pulls/37","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/singer-io/tap-facebook/pulls/comments/171351990"},"html":{"href":"https://github.com/singer-io/tap-facebook/pull/37#discussion_r171351990"},"pull_request":{"href":"https://api.github.com/repos/singer-io/tap-facebook/pulls/37"}},"in_reply_to_id":171083333},"pull_request":{"url":"https://api.github.com/repos/singer-io/tap-facebook/pulls/37","id":171785767,"html_url":"https://github.com/singer-io/tap-facebook/pull/37","diff_url":"https://github.com/singer-io/tap-facebook/pull/37.diff","patch_url":"https://github.com/singer-io/tap-facebook/pull/37.patch","issue_url":"https://api.github.com/repos/singer-io/tap-facebook/issues/37","number":37,"state":"open","locked":false,"title":"Attempting to fix 500's during filtering filtering","user":{"login":"KAllan357","id":221009,"avatar_url":"https://avatars3.githubusercontent.com/u/221009?v=4","gravatar_id":"","url":"https://api.github.com/users/KAllan357","html_url":"https://github.com/KAllan357","followers_url":"https://api.github.com/users/KAllan357/followers","following_url":"https://api.github.com/users/KAllan357/following{/other_user}","gists_url":"https://api.github.com/users/KAllan357/gists{/gist_id}","starred_url":"https://api.github.com/users/KAllan357/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KAllan357/subscriptions","organizations_url":"https://api.github.com/users/KAllan357/orgs","repos_url":"https://api.github.com/users/KAllan357/repos","events_url":"https://api.github.com/users/KAllan357/events{/privacy}","received_events_url":"https://api.github.com/users/KAllan357/received_events","type":"User","site_admin":false},"body":"We suspect there are one of 2 issues:\r\n\r\n* The URL and query params were too long / complicated and would cause Facebook to issue a 500 error.\r\n* The next-page request would be too long or complicated and would cause the same behavior.\r\n\r\nThis PR addresses both concerns:\r\n\r\n* Retrieve ads/adsets/campaigns using only automatic fields and then retrieve the full object later\r\n* Add a filtering parameter to limit the number of results returned when we have a bookmark","created_at":"2018-02-27T21:12:57Z","updated_at":"2018-02-28T19:08:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9908ce24dbd50cb8fcb72fa90d4fe697f6fdbcc5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/singer-io/tap-facebook/pulls/37/commits","review_comments_url":"https://api.github.com/repos/singer-io/tap-facebook/pulls/37/comments","review_comment_url":"https://api.github.com/repos/singer-io/tap-facebook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/singer-io/tap-facebook/issues/37/comments","statuses_url":"https://api.github.com/repos/singer-io/tap-facebook/statuses/425a0b0a11d1ce2759358a3bdcb35356c68f3ac5","head":{"label":"singer-io:fix_filtering","ref":"fix_filtering","sha":"425a0b0a11d1ce2759358a3bdcb35356c68f3ac5","user":{"login":"singer-io","id":25538203,"avatar_url":"https://avatars0.githubusercontent.com/u/25538203?v=4","gravatar_id":"","url":"https://api.github.com/users/singer-io","html_url":"https://github.com/singer-io","followers_url":"https://api.github.com/users/singer-io/followers","following_url":"https://api.github.com/users/singer-io/following{/other_user}","gists_url":"https://api.github.com/users/singer-io/gists{/gist_id}","starred_url":"https://api.github.com/users/singer-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singer-io/subscriptions","organizations_url":"https://api.github.com/users/singer-io/orgs","repos_url":"https://api.github.com/users/singer-io/repos","events_url":"https://api.github.com/users/singer-io/events{/privacy}","received_events_url":"https://api.github.com/users/singer-io/received_events","type":"Organization","site_admin":false},"repo":{"id":85717536,"name":"tap-facebook","full_name":"singer-io/tap-facebook","owner":{"login":"singer-io","id":25538203,"avatar_url":"https://avatars0.githubusercontent.com/u/25538203?v=4","gravatar_id":"","url":"https://api.github.com/users/singer-io","html_url":"https://github.com/singer-io","followers_url":"https://api.github.com/users/singer-io/followers","following_url":"https://api.github.com/users/singer-io/following{/other_user}","gists_url":"https://api.github.com/users/singer-io/gists{/gist_id}","starred_url":"https://api.github.com/users/singer-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singer-io/subscriptions","organizations_url":"https://api.github.com/users/singer-io/orgs","repos_url":"https://api.github.com/users/singer-io/repos","events_url":"https://api.github.com/users/singer-io/events{/privacy}","received_events_url":"https://api.github.com/users/singer-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/singer-io/tap-facebook","description":"Singer.io tap for Facebook Marketing API","fork":false,"url":"https://api.github.com/repos/singer-io/tap-facebook","forks_url":"https://api.github.com/repos/singer-io/tap-facebook/forks","keys_url":"https://api.github.com/repos/singer-io/tap-facebook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/singer-io/tap-facebook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/singer-io/tap-facebook/teams","hooks_url":"https://api.github.com/repos/singer-io/tap-facebook/hooks","issue_events_url":"https://api.github.com/repos/singer-io/tap-facebook/issues/events{/number}","events_url":"https://api.github.com/repos/singer-io/tap-facebook/events","assignees_url":"https://api.github.com/repos/singer-io/tap-facebook/assignees{/user}","branches_url":"https://api.github.com/repos/singer-io/tap-facebook/branches{/branch}","tags_url":"https://api.github.com/repos/singer-io/tap-facebook/tags","blobs_url":"https://api.github.com/repos/singer-io/tap-facebook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/singer-io/tap-facebook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/singer-io/tap-facebook/git/refs{/sha}","trees_url":"https://api.github.com/repos/singer-io/tap-facebook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/singer-io/tap-facebook/statuses/{sha}","languages_url":"https://api.github.com/repos/singer-io/tap-facebook/languages","stargazers_url":"https://api.github.com/repos/singer-io/tap-facebook/stargazers","contributors_url":"https://api.github.com/repos/singer-io/tap-facebook/contributors","subscribers_url":"https://api.github.com/repos/singer-io/tap-facebook/subscribers","subscription_url":"https://api.github.com/repos/singer-io/tap-facebook/subscription","commits_url":"https://api.github.com/repos/singer-io/tap-facebook/commits{/sha}","git_commits_url":"https://api.github.com/repos/singer-io/tap-facebook/git/commits{/sha}","comments_url":"https://api.github.com/repos/singer-io/tap-facebook/comments{/number}","issue_comment_url":"https://api.github.com/repos/singer-io/tap-facebook/issues/comments{/number}","contents_url":"https://api.github.com/repos/singer-io/tap-facebook/contents/{+path}","compare_url":"https://api.github.com/repos/singer-io/tap-facebook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/singer-io/tap-facebook/merges","archive_url":"https://api.github.com/repos/singer-io/tap-facebook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/singer-io/tap-facebook/downloads","issues_url":"https://api.github.com/repos/singer-io/tap-facebook/issues{/number}","pulls_url":"https://api.github.com/repos/singer-io/tap-facebook/pulls{/number}","milestones_url":"https://api.github.com/repos/singer-io/tap-facebook/milestones{/number}","notifications_url":"https://api.github.com/repos/singer-io/tap-facebook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/singer-io/tap-facebook/labels{/name}","releases_url":"https://api.github.com/repos/singer-io/tap-facebook/releases{/id}","deployments_url":"https://api.github.com/repos/singer-io/tap-facebook/deployments","created_at":"2017-03-21T15:16:38Z","updated_at":"2018-02-08T18:21:17Z","pushed_at":"2018-02-28T19:08:10Z","git_url":"git://github.com/singer-io/tap-facebook.git","ssh_url":"git@github.com:singer-io/tap-facebook.git","clone_url":"https://github.com/singer-io/tap-facebook.git","svn_url":"https://github.com/singer-io/tap-facebook","homepage":null,"size":155,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":4,"open_issues":5,"watchers":14,"default_branch":"master"}},"base":{"label":"singer-io:master","ref":"master","sha":"f10fe37e80a8af63675b8858a4a89637285a3d11","user":{"login":"singer-io","id":25538203,"avatar_url":"https://avatars0.githubusercontent.com/u/25538203?v=4","gravatar_id":"","url":"https://api.github.com/users/singer-io","html_url":"https://github.com/singer-io","followers_url":"https://api.github.com/users/singer-io/followers","following_url":"https://api.github.com/users/singer-io/following{/other_user}","gists_url":"https://api.github.com/users/singer-io/gists{/gist_id}","starred_url":"https://api.github.com/users/singer-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singer-io/subscriptions","organizations_url":"https://api.github.com/users/singer-io/orgs","repos_url":"https://api.github.com/users/singer-io/repos","events_url":"https://api.github.com/users/singer-io/events{/privacy}","received_events_url":"https://api.github.com/users/singer-io/received_events","type":"Organization","site_admin":false},"repo":{"id":85717536,"name":"tap-facebook","full_name":"singer-io/tap-facebook","owner":{"login":"singer-io","id":25538203,"avatar_url":"https://avatars0.githubusercontent.com/u/25538203?v=4","gravatar_id":"","url":"https://api.github.com/users/singer-io","html_url":"https://github.com/singer-io","followers_url":"https://api.github.com/users/singer-io/followers","following_url":"https://api.github.com/users/singer-io/following{/other_user}","gists_url":"https://api.github.com/users/singer-io/gists{/gist_id}","starred_url":"https://api.github.com/users/singer-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singer-io/subscriptions","organizations_url":"https://api.github.com/users/singer-io/orgs","repos_url":"https://api.github.com/users/singer-io/repos","events_url":"https://api.github.com/users/singer-io/events{/privacy}","received_events_url":"https://api.github.com/users/singer-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/singer-io/tap-facebook","description":"Singer.io tap for Facebook Marketing API","fork":false,"url":"https://api.github.com/repos/singer-io/tap-facebook","forks_url":"https://api.github.com/repos/singer-io/tap-facebook/forks","keys_url":"https://api.github.com/repos/singer-io/tap-facebook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/singer-io/tap-facebook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/singer-io/tap-facebook/teams","hooks_url":"https://api.github.com/repos/singer-io/tap-facebook/hooks","issue_events_url":"https://api.github.com/repos/singer-io/tap-facebook/issues/events{/number}","events_url":"https://api.github.com/repos/singer-io/tap-facebook/events","assignees_url":"https://api.github.com/repos/singer-io/tap-facebook/assignees{/user}","branches_url":"https://api.github.com/repos/singer-io/tap-facebook/branches{/branch}","tags_url":"https://api.github.com/repos/singer-io/tap-facebook/tags","blobs_url":"https://api.github.com/repos/singer-io/tap-facebook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/singer-io/tap-facebook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/singer-io/tap-facebook/git/refs{/sha}","trees_url":"https://api.github.com/repos/singer-io/tap-facebook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/singer-io/tap-facebook/statuses/{sha}","languages_url":"https://api.github.com/repos/singer-io/tap-facebook/languages","stargazers_url":"https://api.github.com/repos/singer-io/tap-facebook/stargazers","contributors_url":"https://api.github.com/repos/singer-io/tap-facebook/contributors","subscribers_url":"https://api.github.com/repos/singer-io/tap-facebook/subscribers","subscription_url":"https://api.github.com/repos/singer-io/tap-facebook/subscription","commits_url":"https://api.github.com/repos/singer-io/tap-facebook/commits{/sha}","git_commits_url":"https://api.github.com/repos/singer-io/tap-facebook/git/commits{/sha}","comments_url":"https://api.github.com/repos/singer-io/tap-facebook/comments{/number}","issue_comment_url":"https://api.github.com/repos/singer-io/tap-facebook/issues/comments{/number}","contents_url":"https://api.github.com/repos/singer-io/tap-facebook/contents/{+path}","compare_url":"https://api.github.com/repos/singer-io/tap-facebook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/singer-io/tap-facebook/merges","archive_url":"https://api.github.com/repos/singer-io/tap-facebook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/singer-io/tap-facebook/downloads","issues_url":"https://api.github.com/repos/singer-io/tap-facebook/issues{/number}","pulls_url":"https://api.github.com/repos/singer-io/tap-facebook/pulls{/number}","milestones_url":"https://api.github.com/repos/singer-io/tap-facebook/milestones{/number}","notifications_url":"https://api.github.com/repos/singer-io/tap-facebook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/singer-io/tap-facebook/labels{/name}","releases_url":"https://api.github.com/repos/singer-io/tap-facebook/releases{/id}","deployments_url":"https://api.github.com/repos/singer-io/tap-facebook/deployments","created_at":"2017-03-21T15:16:38Z","updated_at":"2018-02-08T18:21:17Z","pushed_at":"2018-02-28T19:08:10Z","git_url":"git://github.com/singer-io/tap-facebook.git","ssh_url":"git@github.com:singer-io/tap-facebook.git","clone_url":"https://github.com/singer-io/tap-facebook.git","svn_url":"https://github.com/singer-io/tap-facebook","homepage":null,"size":155,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":4,"open_issues":5,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/singer-io/tap-facebook/pulls/37"},"html":{"href":"https://github.com/singer-io/tap-facebook/pull/37"},"issue":{"href":"https://api.github.com/repos/singer-io/tap-facebook/issues/37"},"comments":{"href":"https://api.github.com/repos/singer-io/tap-facebook/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/singer-io/tap-facebook/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/singer-io/tap-facebook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/singer-io/tap-facebook/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/singer-io/tap-facebook/statuses/425a0b0a11d1ce2759358a3bdcb35356c68f3ac5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KAllan357"}}