{"action":"created","issue":{"url":"https://api.github.com/repos/jitsi/ice4j/issues/164","repository_url":"https://api.github.com/repos/jitsi/ice4j","labels_url":"https://api.github.com/repos/jitsi/ice4j/issues/164/labels{/name}","comments_url":"https://api.github.com/repos/jitsi/ice4j/issues/164/comments","events_url":"https://api.github.com/repos/jitsi/ice4j/issues/164/events","html_url":"https://github.com/jitsi/ice4j/pull/164","id":391697546,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MTMzMTE2","number":164,"title":"Invoke `releasePacket` on dropped items in `PacketQueue`.","user":{"login":"mstyura","id":385639,"node_id":"MDQ6VXNlcjM4NTYzOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/385639?v=4","gravatar_id":"","url":"https://api.github.com/users/mstyura","html_url":"https://github.com/mstyura","followers_url":"https://api.github.com/users/mstyura/followers","following_url":"https://api.github.com/users/mstyura/following{/other_user}","gists_url":"https://api.github.com/users/mstyura/gists{/gist_id}","starred_url":"https://api.github.com/users/mstyura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstyura/subscriptions","organizations_url":"https://api.github.com/users/mstyura/orgs","repos_url":"https://api.github.com/users/mstyura/repos","events_url":"https://api.github.com/users/mstyura/events{/privacy}","received_events_url":"https://api.github.com/users/mstyura/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-17T12:49:12Z","updated_at":"2018-12-17T14:51:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jitsi/ice4j/pulls/164","html_url":"https://github.com/jitsi/ice4j/pull/164","diff_url":"https://github.com/jitsi/ice4j/pull/164.diff","patch_url":"https://github.com/jitsi/ice4j/pull/164.patch"},"body":"There was missing call to `releasePacket` when packet was dropped from queue due to queue overflow.\r\n\r\nTo facilitate usage of object pool in conjunction with `PacketQueue` the missing call to `releasePacket` were added.\r\n\r\nA scope of `synchronized` block inside `doAdd` were reduced to just notify threads waiting on `queue` object.  The underlying queue is thread-safe and does not need a protection with `syncronized` block. It is also allowed to avoid calling `releasePacket` within `synchronized` block.\r\n\r\nA `Object.notifyAll` was replaced with `Object.notify`, because only there no reason to wake more that 1 thread when single item is added into queue.\r\n\r\nAdded a unit test to check that `releasePacket` is invoked from dropped items."},"comment":{"url":"https://api.github.com/repos/jitsi/ice4j/issues/comments/447871989","html_url":"https://github.com/jitsi/ice4j/pull/164#issuecomment-447871989","issue_url":"https://api.github.com/repos/jitsi/ice4j/issues/164","id":447871989,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzg3MTk4OQ==","user":{"login":"mstyura","id":385639,"node_id":"MDQ6VXNlcjM4NTYzOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/385639?v=4","gravatar_id":"","url":"https://api.github.com/users/mstyura","html_url":"https://github.com/mstyura","followers_url":"https://api.github.com/users/mstyura/followers","following_url":"https://api.github.com/users/mstyura/following{/other_user}","gists_url":"https://api.github.com/users/mstyura/gists{/gist_id}","starred_url":"https://api.github.com/users/mstyura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstyura/subscriptions","organizations_url":"https://api.github.com/users/mstyura/orgs","repos_url":"https://api.github.com/users/mstyura/repos","events_url":"https://api.github.com/users/mstyura/events{/privacy}","received_events_url":"https://api.github.com/users/mstyura/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T14:51:44Z","updated_at":"2018-12-17T14:51:44Z","author_association":"CONTRIBUTOR","body":"Jenkins test this please"}}
{"actor":{"display_login":"mstyura"}}