{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/openj9/issues/2450","repository_url":"https://api.github.com/repos/eclipse/openj9","labels_url":"https://api.github.com/repos/eclipse/openj9/issues/2450/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/2450/comments","events_url":"https://api.github.com/repos/eclipse/openj9/issues/2450/events","html_url":"https://github.com/eclipse/openj9/pull/2450","id":343670072,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMjQ3Nzg5","number":2450,"title":"Locking Changes","user":{"login":"babsingh","id":8634038,"node_id":"MDQ6VXNlcjg2MzQwMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/8634038?v=4","gravatar_id":"","url":"https://api.github.com/users/babsingh","html_url":"https://github.com/babsingh","followers_url":"https://api.github.com/users/babsingh/followers","following_url":"https://api.github.com/users/babsingh/following{/other_user}","gists_url":"https://api.github.com/users/babsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/babsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babsingh/subscriptions","organizations_url":"https://api.github.com/users/babsingh/orgs","repos_url":"https://api.github.com/users/babsingh/repos","events_url":"https://api.github.com/users/babsingh/events{/privacy}","received_events_url":"https://api.github.com/users/babsingh/received_events","type":"User","site_admin":false},"labels":[{"id":697962110,"node_id":"MDU6TGFiZWw2OTc5NjIxMTA=","url":"https://api.github.com/repos/eclipse/openj9/labels/comp:vm","name":"comp:vm","color":"1d76db","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-07-23T14:59:18Z","updated_at":"2018-07-25T03:03:14Z","closed_at":"2018-07-25T02:09:38Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/2450","html_url":"https://github.com/eclipse/openj9/pull/2450","diff_url":"https://github.com/eclipse/openj9/pull/2450.diff","patch_url":"https://github.com/eclipse/openj9/pull/2450.patch"},"body":"1) **Revert \"Improve locking\"**\r\n\r\n\tThis commit reverts the first commit in #553.\r\n\r\n\tThe purpose of the original change was to reduce compare and swap\r\n\toperations in the spinlock loop; thus, reducing spinning overhead. The\r\n\tpremise was to improve throughput by reducing spinning overhead. In the\r\n\tinitial benchmarking, no throughput improvements were noticed because of\r\n\tthis change. Recently, this change has resulted in regressing\r\n\tthroughput. ~30% throughput drop is observed in one of the OpenLiberty\r\n\tbenchmarks. Thus, it has been decided to revert the original change.\r\n\r\nSigned-off-by: Babneet Singh <sbabneet@ca.ibm.com>"},"comment":{"url":"https://api.github.com/repos/eclipse/openj9/issues/comments/407618480","html_url":"https://github.com/eclipse/openj9/pull/2450#issuecomment-407618480","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/2450","id":407618480,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzYxODQ4MA==","user":{"login":"DanHeidinga","id":8503711,"node_id":"MDQ6VXNlcjg1MDM3MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8503711?v=4","gravatar_id":"","url":"https://api.github.com/users/DanHeidinga","html_url":"https://github.com/DanHeidinga","followers_url":"https://api.github.com/users/DanHeidinga/followers","following_url":"https://api.github.com/users/DanHeidinga/following{/other_user}","gists_url":"https://api.github.com/users/DanHeidinga/gists{/gist_id}","starred_url":"https://api.github.com/users/DanHeidinga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanHeidinga/subscriptions","organizations_url":"https://api.github.com/users/DanHeidinga/orgs","repos_url":"https://api.github.com/users/DanHeidinga/repos","events_url":"https://api.github.com/users/DanHeidinga/events{/privacy}","received_events_url":"https://api.github.com/users/DanHeidinga/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T03:03:14Z","updated_at":"2018-07-25T03:03:14Z","author_association":"CONTRIBUTOR","body":"> Recently, this change has resulted in regressing\r\nthroughput. ~30% throughput drop \r\n\r\n@babsingh Have you investigated how this change is responsible for the ~30% throughput drop?  \r\nIs the regression related to particular machine configurations (ie: # of cores)?   #553 defined `maxSpinThreads` differently based on the number of cores and I'm wondering if this is might be addressed by adjusting the maxSpinThreads heuristic."}}
{"actor":{"display_login":"DanHeidinga"}}