{"action":"created","comment":{"url":"https://api.github.com/repos/insolar/insolar/pulls/comments/225121653","pull_request_review_id":164650467,"id":225121653,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTEyMTY1Mw==","diff_hunk":"@@ -58,10 +59,21 @@ type RPC struct {\n \tGI *GoInsider\n }\n \n+func recoverRPC(err *error) {\n+\tif r := recover(); r != nil {\n+\t\tif err != nil && *err == nil {\n+\t\t\t*err = errors.New(fmt.Sprint(r))","path":"logicrunner/goplugin/ginsider/ginsider.go","position":15,"original_position":15,"commit_id":"86820b6bbe9826b36b228cbdb5a88fa73f1b50d7","original_commit_id":"86820b6bbe9826b36b228cbdb5a88fa73f1b50d7","user":{"login":"ivanshibitov","id":3951515,"node_id":"MDQ6VXNlcjM5NTE1MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3951515?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanshibitov","html_url":"https://github.com/ivanshibitov","followers_url":"https://api.github.com/users/ivanshibitov/followers","following_url":"https://api.github.com/users/ivanshibitov/following{/other_user}","gists_url":"https://api.github.com/users/ivanshibitov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanshibitov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanshibitov/subscriptions","organizations_url":"https://api.github.com/users/ivanshibitov/orgs","repos_url":"https://api.github.com/users/ivanshibitov/repos","events_url":"https://api.github.com/users/ivanshibitov/events{/privacy}","received_events_url":"https://api.github.com/users/ivanshibitov/received_events","type":"User","site_admin":false},"body":"May be is it better to join text of panic and text of error?\r\nBecause it looks like we loose text of panic if error exists, but print only text of panic","created_at":"2018-10-15T10:56:36Z","updated_at":"2018-10-15T10:56:48Z","html_url":"https://github.com/insolar/insolar/pull/394#discussion_r225121653","pull_request_url":"https://api.github.com/repos/insolar/insolar/pulls/394","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/insolar/insolar/pulls/comments/225121653"},"html":{"href":"https://github.com/insolar/insolar/pull/394#discussion_r225121653"},"pull_request":{"href":"https://api.github.com/repos/insolar/insolar/pulls/394"}}},"pull_request":{"url":"https://api.github.com/repos/insolar/insolar/pulls/394","id":222861057,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyODYxMDU3","html_url":"https://github.com/insolar/insolar/pull/394","diff_url":"https://github.com/insolar/insolar/pull/394.diff","patch_url":"https://github.com/insolar/insolar/pull/394.patch","issue_url":"https://api.github.com/repos/insolar/insolar/issues/394","number":394,"state":"open","locked":false,"title":"INS-623: recover on panics in insgorund","user":{"login":"ruz","id":42598,"node_id":"MDQ6VXNlcjQyNTk4","avatar_url":"https://avatars1.githubusercontent.com/u/42598?v=4","gravatar_id":"","url":"https://api.github.com/users/ruz","html_url":"https://github.com/ruz","followers_url":"https://api.github.com/users/ruz/followers","following_url":"https://api.github.com/users/ruz/following{/other_user}","gists_url":"https://api.github.com/users/ruz/gists{/gist_id}","starred_url":"https://api.github.com/users/ruz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruz/subscriptions","organizations_url":"https://api.github.com/users/ruz/orgs","repos_url":"https://api.github.com/users/ruz/repos","events_url":"https://api.github.com/users/ruz/events{/privacy}","received_events_url":"https://api.github.com/users/ruz/received_events","type":"User","site_admin":false},"body":"don't crash whole daemon when a panic happens in a contract, return an\r\nRPC error","created_at":"2018-10-15T10:47:24Z","updated_at":"2018-10-15T10:56:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d25a5887ca819b1fb0ad390e9c437594f9a258b4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Vany","id":47273,"node_id":"MDQ6VXNlcjQ3Mjcz","avatar_url":"https://avatars2.githubusercontent.com/u/47273?v=4","gravatar_id":"","url":"https://api.github.com/users/Vany","html_url":"https://github.com/Vany","followers_url":"https://api.github.com/users/Vany/followers","following_url":"https://api.github.com/users/Vany/following{/other_user}","gists_url":"https://api.github.com/users/Vany/gists{/gist_id}","starred_url":"https://api.github.com/users/Vany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vany/subscriptions","organizations_url":"https://api.github.com/users/Vany/orgs","repos_url":"https://api.github.com/users/Vany/repos","events_url":"https://api.github.com/users/Vany/events{/privacy}","received_events_url":"https://api.github.com/users/Vany/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/insolar/insolar/pulls/394/commits","review_comments_url":"https://api.github.com/repos/insolar/insolar/pulls/394/comments","review_comment_url":"https://api.github.com/repos/insolar/insolar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/insolar/insolar/issues/394/comments","statuses_url":"https://api.github.com/repos/insolar/insolar/statuses/86820b6bbe9826b36b228cbdb5a88fa73f1b50d7","head":{"label":"insolar:INS-623-dont-crash-whole-insgorund-on-panic","ref":"INS-623-dont-crash-whole-insgorund-on-panic","sha":"86820b6bbe9826b36b228cbdb5a88fa73f1b50d7","user":{"login":"insolar","id":31775388,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc1Mzg4","avatar_url":"https://avatars1.githubusercontent.com/u/31775388?v=4","gravatar_id":"","url":"https://api.github.com/users/insolar","html_url":"https://github.com/insolar","followers_url":"https://api.github.com/users/insolar/followers","following_url":"https://api.github.com/users/insolar/following{/other_user}","gists_url":"https://api.github.com/users/insolar/gists{/gist_id}","starred_url":"https://api.github.com/users/insolar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insolar/subscriptions","organizations_url":"https://api.github.com/users/insolar/orgs","repos_url":"https://api.github.com/users/insolar/repos","events_url":"https://api.github.com/users/insolar/events{/privacy}","received_events_url":"https://api.github.com/users/insolar/received_events","type":"Organization","site_admin":false},"repo":{"id":139829328,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4MjkzMjg=","name":"insolar","full_name":"insolar/insolar","private":false,"owner":{"login":"insolar","id":31775388,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc1Mzg4","avatar_url":"https://avatars1.githubusercontent.com/u/31775388?v=4","gravatar_id":"","url":"https://api.github.com/users/insolar","html_url":"https://github.com/insolar","followers_url":"https://api.github.com/users/insolar/followers","following_url":"https://api.github.com/users/insolar/following{/other_user}","gists_url":"https://api.github.com/users/insolar/gists{/gist_id}","starred_url":"https://api.github.com/users/insolar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insolar/subscriptions","organizations_url":"https://api.github.com/users/insolar/orgs","repos_url":"https://api.github.com/users/insolar/repos","events_url":"https://api.github.com/users/insolar/events{/privacy}","received_events_url":"https://api.github.com/users/insolar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/insolar/insolar","description":"Enterprise blockchain platform","fork":false,"url":"https://api.github.com/repos/insolar/insolar","forks_url":"https://api.github.com/repos/insolar/insolar/forks","keys_url":"https://api.github.com/repos/insolar/insolar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/insolar/insolar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/insolar/insolar/teams","hooks_url":"https://api.github.com/repos/insolar/insolar/hooks","issue_events_url":"https://api.github.com/repos/insolar/insolar/issues/events{/number}","events_url":"https://api.github.com/repos/insolar/insolar/events","assignees_url":"https://api.github.com/repos/insolar/insolar/assignees{/user}","branches_url":"https://api.github.com/repos/insolar/insolar/branches{/branch}","tags_url":"https://api.github.com/repos/insolar/insolar/tags","blobs_url":"https://api.github.com/repos/insolar/insolar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/insolar/insolar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/insolar/insolar/git/refs{/sha}","trees_url":"https://api.github.com/repos/insolar/insolar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/insolar/insolar/statuses/{sha}","languages_url":"https://api.github.com/repos/insolar/insolar/languages","stargazers_url":"https://api.github.com/repos/insolar/insolar/stargazers","contributors_url":"https://api.github.com/repos/insolar/insolar/contributors","subscribers_url":"https://api.github.com/repos/insolar/insolar/subscribers","subscription_url":"https://api.github.com/repos/insolar/insolar/subscription","commits_url":"https://api.github.com/repos/insolar/insolar/commits{/sha}","git_commits_url":"https://api.github.com/repos/insolar/insolar/git/commits{/sha}","comments_url":"https://api.github.com/repos/insolar/insolar/comments{/number}","issue_comment_url":"https://api.github.com/repos/insolar/insolar/issues/comments{/number}","contents_url":"https://api.github.com/repos/insolar/insolar/contents/{+path}","compare_url":"https://api.github.com/repos/insolar/insolar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/insolar/insolar/merges","archive_url":"https://api.github.com/repos/insolar/insolar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/insolar/insolar/downloads","issues_url":"https://api.github.com/repos/insolar/insolar/issues{/number}","pulls_url":"https://api.github.com/repos/insolar/insolar/pulls{/number}","milestones_url":"https://api.github.com/repos/insolar/insolar/milestones{/number}","notifications_url":"https://api.github.com/repos/insolar/insolar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/insolar/insolar/labels{/name}","releases_url":"https://api.github.com/repos/insolar/insolar/releases{/id}","deployments_url":"https://api.github.com/repos/insolar/insolar/deployments","created_at":"2018-07-05T09:49:28Z","updated_at":"2018-10-15T10:11:34Z","pushed_at":"2018-10-15T10:49:22Z","git_url":"git://github.com/insolar/insolar.git","ssh_url":"git@github.com:insolar/insolar.git","clone_url":"https://github.com/insolar/insolar.git","svn_url":"https://github.com/insolar/insolar","homepage":"","size":14941,"stargazers_count":41,"watchers_count":41,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":6,"watchers":41,"default_branch":"master"}},"base":{"label":"insolar:master","ref":"master","sha":"f84339acb28304ff0cd6aeae21f1b3ba4a54d883","user":{"login":"insolar","id":31775388,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc1Mzg4","avatar_url":"https://avatars1.githubusercontent.com/u/31775388?v=4","gravatar_id":"","url":"https://api.github.com/users/insolar","html_url":"https://github.com/insolar","followers_url":"https://api.github.com/users/insolar/followers","following_url":"https://api.github.com/users/insolar/following{/other_user}","gists_url":"https://api.github.com/users/insolar/gists{/gist_id}","starred_url":"https://api.github.com/users/insolar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insolar/subscriptions","organizations_url":"https://api.github.com/users/insolar/orgs","repos_url":"https://api.github.com/users/insolar/repos","events_url":"https://api.github.com/users/insolar/events{/privacy}","received_events_url":"https://api.github.com/users/insolar/received_events","type":"Organization","site_admin":false},"repo":{"id":139829328,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4MjkzMjg=","name":"insolar","full_name":"insolar/insolar","private":false,"owner":{"login":"insolar","id":31775388,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc1Mzg4","avatar_url":"https://avatars1.githubusercontent.com/u/31775388?v=4","gravatar_id":"","url":"https://api.github.com/users/insolar","html_url":"https://github.com/insolar","followers_url":"https://api.github.com/users/insolar/followers","following_url":"https://api.github.com/users/insolar/following{/other_user}","gists_url":"https://api.github.com/users/insolar/gists{/gist_id}","starred_url":"https://api.github.com/users/insolar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insolar/subscriptions","organizations_url":"https://api.github.com/users/insolar/orgs","repos_url":"https://api.github.com/users/insolar/repos","events_url":"https://api.github.com/users/insolar/events{/privacy}","received_events_url":"https://api.github.com/users/insolar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/insolar/insolar","description":"Enterprise blockchain platform","fork":false,"url":"https://api.github.com/repos/insolar/insolar","forks_url":"https://api.github.com/repos/insolar/insolar/forks","keys_url":"https://api.github.com/repos/insolar/insolar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/insolar/insolar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/insolar/insolar/teams","hooks_url":"https://api.github.com/repos/insolar/insolar/hooks","issue_events_url":"https://api.github.com/repos/insolar/insolar/issues/events{/number}","events_url":"https://api.github.com/repos/insolar/insolar/events","assignees_url":"https://api.github.com/repos/insolar/insolar/assignees{/user}","branches_url":"https://api.github.com/repos/insolar/insolar/branches{/branch}","tags_url":"https://api.github.com/repos/insolar/insolar/tags","blobs_url":"https://api.github.com/repos/insolar/insolar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/insolar/insolar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/insolar/insolar/git/refs{/sha}","trees_url":"https://api.github.com/repos/insolar/insolar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/insolar/insolar/statuses/{sha}","languages_url":"https://api.github.com/repos/insolar/insolar/languages","stargazers_url":"https://api.github.com/repos/insolar/insolar/stargazers","contributors_url":"https://api.github.com/repos/insolar/insolar/contributors","subscribers_url":"https://api.github.com/repos/insolar/insolar/subscribers","subscription_url":"https://api.github.com/repos/insolar/insolar/subscription","commits_url":"https://api.github.com/repos/insolar/insolar/commits{/sha}","git_commits_url":"https://api.github.com/repos/insolar/insolar/git/commits{/sha}","comments_url":"https://api.github.com/repos/insolar/insolar/comments{/number}","issue_comment_url":"https://api.github.com/repos/insolar/insolar/issues/comments{/number}","contents_url":"https://api.github.com/repos/insolar/insolar/contents/{+path}","compare_url":"https://api.github.com/repos/insolar/insolar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/insolar/insolar/merges","archive_url":"https://api.github.com/repos/insolar/insolar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/insolar/insolar/downloads","issues_url":"https://api.github.com/repos/insolar/insolar/issues{/number}","pulls_url":"https://api.github.com/repos/insolar/insolar/pulls{/number}","milestones_url":"https://api.github.com/repos/insolar/insolar/milestones{/number}","notifications_url":"https://api.github.com/repos/insolar/insolar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/insolar/insolar/labels{/name}","releases_url":"https://api.github.com/repos/insolar/insolar/releases{/id}","deployments_url":"https://api.github.com/repos/insolar/insolar/deployments","created_at":"2018-07-05T09:49:28Z","updated_at":"2018-10-15T10:11:34Z","pushed_at":"2018-10-15T10:49:22Z","git_url":"git://github.com/insolar/insolar.git","ssh_url":"git@github.com:insolar/insolar.git","clone_url":"https://github.com/insolar/insolar.git","svn_url":"https://github.com/insolar/insolar","homepage":"","size":14941,"stargazers_count":41,"watchers_count":41,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":6,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/insolar/insolar/pulls/394"},"html":{"href":"https://github.com/insolar/insolar/pull/394"},"issue":{"href":"https://api.github.com/repos/insolar/insolar/issues/394"},"comments":{"href":"https://api.github.com/repos/insolar/insolar/issues/394/comments"},"review_comments":{"href":"https://api.github.com/repos/insolar/insolar/pulls/394/comments"},"review_comment":{"href":"https://api.github.com/repos/insolar/insolar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/insolar/insolar/pulls/394/commits"},"statuses":{"href":"https://api.github.com/repos/insolar/insolar/statuses/86820b6bbe9826b36b228cbdb5a88fa73f1b50d7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ivanshibitov"}}