{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/168191598","pull_request_review_id":96517429,"id":168191598,"diff_hunk":"@@ -743,6 +743,15 @@ ObjectSharedPtr Factory::loadFromYamlString(const std::string& yaml) {\n     return parseYamlNode(YAML::Load(yaml));\n   } catch (YAML::ParserException& e) {\n     throw EnvoyException(e.what());\n+  } catch (YAML::BadConversion& e) {\n+    throw EnvoyException(e.what());\n+  } catch (std::exception& e) {\n+    // There is a potentially wide space of exceptions thrown by the YAML parser,\n+    // and enumerating them all may be difficult. Envoy doesn't work well with\n+    // unhandled exceptions, so we capture them and record the exception name in\n+    // the Envoy Exception text.\n+    std::exception_ptr p = std::current_exception();","path":"source/common/json/json_loader.cc","position":11,"original_position":11,"commit_id":"5cf08f683b8f34a5df93f9bc2449c3e8b9e05335","original_commit_id":"5cf08f683b8f34a5df93f9bc2449c3e8b9e05335","user":{"login":"jmarantz","id":1942589,"avatar_url":"https://avatars3.githubusercontent.com/u/1942589?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarantz","html_url":"https://github.com/jmarantz","followers_url":"https://api.github.com/users/jmarantz/followers","following_url":"https://api.github.com/users/jmarantz/following{/other_user}","gists_url":"https://api.github.com/users/jmarantz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarantz/subscriptions","organizations_url":"https://api.github.com/users/jmarantz/orgs","repos_url":"https://api.github.com/users/jmarantz/repos","events_url":"https://api.github.com/users/jmarantz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarantz/received_events","type":"User","site_admin":false},"body":"actually I didn't need that line at all.","created_at":"2018-02-14T14:34:48Z","updated_at":"2018-02-14T14:34:48Z","html_url":"https://github.com/envoyproxy/envoy/pull/2599#discussion_r168191598","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2599","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/168191598"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/2599#discussion_r168191598"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2599"}},"in_reply_to_id":168172768},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2599","id":168979130,"html_url":"https://github.com/envoyproxy/envoy/pull/2599","diff_url":"https://github.com/envoyproxy/envoy/pull/2599.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/2599.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2599","number":2599,"state":"open","locked":false,"title":"config: catch all exceptions from YAML parser","user":{"login":"jmarantz","id":1942589,"avatar_url":"https://avatars3.githubusercontent.com/u/1942589?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarantz","html_url":"https://github.com/jmarantz","followers_url":"https://api.github.com/users/jmarantz/followers","following_url":"https://api.github.com/users/jmarantz/following{/other_user}","gists_url":"https://api.github.com/users/jmarantz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarantz/subscriptions","organizations_url":"https://api.github.com/users/jmarantz/orgs","repos_url":"https://api.github.com/users/jmarantz/repos","events_url":"https://api.github.com/users/jmarantz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarantz/received_events","type":"User","site_admin":false},"body":"*Description*:\r\nYAML can throw a fairly wide variety of exceptions.  Unhandled exceptions are not handled well by the Envoy codebase in general, e.g. ThreadLocalStoreImpl will assert-fail if it's destructed right after it's constructed, which can happen with an exception.\r\n\r\n*Risk Level*: Low\r\n\r\n*Testing*:\r\n//test/...\r\nNew unit test to cover type-conversion exception.\r\n","created_at":"2018-02-13T22:55:11Z","updated_at":"2018-02-14T14:34:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45c98c2d9f1749b473abab502be6363fc02f75af","assignee":{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false},"assignees":[{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2599/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2599/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2599/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/5cf08f683b8f34a5df93f9bc2449c3e8b9e05335","head":{"label":"jmarantz:json-catch-all","ref":"json-catch-all","sha":"5cf08f683b8f34a5df93f9bc2449c3e8b9e05335","user":{"login":"jmarantz","id":1942589,"avatar_url":"https://avatars3.githubusercontent.com/u/1942589?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarantz","html_url":"https://github.com/jmarantz","followers_url":"https://api.github.com/users/jmarantz/followers","following_url":"https://api.github.com/users/jmarantz/following{/other_user}","gists_url":"https://api.github.com/users/jmarantz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarantz/subscriptions","organizations_url":"https://api.github.com/users/jmarantz/orgs","repos_url":"https://api.github.com/users/jmarantz/repos","events_url":"https://api.github.com/users/jmarantz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarantz/received_events","type":"User","site_admin":false},"repo":{"id":109787330,"name":"envoy","full_name":"jmarantz/envoy","owner":{"login":"jmarantz","id":1942589,"avatar_url":"https://avatars3.githubusercontent.com/u/1942589?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarantz","html_url":"https://github.com/jmarantz","followers_url":"https://api.github.com/users/jmarantz/followers","following_url":"https://api.github.com/users/jmarantz/following{/other_user}","gists_url":"https://api.github.com/users/jmarantz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarantz/subscriptions","organizations_url":"https://api.github.com/users/jmarantz/orgs","repos_url":"https://api.github.com/users/jmarantz/repos","events_url":"https://api.github.com/users/jmarantz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarantz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmarantz/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/jmarantz/envoy","forks_url":"https://api.github.com/repos/jmarantz/envoy/forks","keys_url":"https://api.github.com/repos/jmarantz/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmarantz/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmarantz/envoy/teams","hooks_url":"https://api.github.com/repos/jmarantz/envoy/hooks","issue_events_url":"https://api.github.com/repos/jmarantz/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/jmarantz/envoy/events","assignees_url":"https://api.github.com/repos/jmarantz/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/jmarantz/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/jmarantz/envoy/tags","blobs_url":"https://api.github.com/repos/jmarantz/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmarantz/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmarantz/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmarantz/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmarantz/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/jmarantz/envoy/languages","stargazers_url":"https://api.github.com/repos/jmarantz/envoy/stargazers","contributors_url":"https://api.github.com/repos/jmarantz/envoy/contributors","subscribers_url":"https://api.github.com/repos/jmarantz/envoy/subscribers","subscription_url":"https://api.github.com/repos/jmarantz/envoy/subscription","commits_url":"https://api.github.com/repos/jmarantz/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmarantz/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmarantz/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmarantz/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmarantz/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/jmarantz/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmarantz/envoy/merges","archive_url":"https://api.github.com/repos/jmarantz/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmarantz/envoy/downloads","issues_url":"https://api.github.com/repos/jmarantz/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/jmarantz/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/jmarantz/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/jmarantz/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmarantz/envoy/labels{/name}","releases_url":"https://api.github.com/repos/jmarantz/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/jmarantz/envoy/deployments","created_at":"2017-11-07T04:36:02Z","updated_at":"2017-11-07T04:36:07Z","pushed_at":"2018-02-14T05:20:04Z","git_url":"git://github.com/jmarantz/envoy.git","ssh_url":"git@github.com:jmarantz/envoy.git","clone_url":"https://github.com/jmarantz/envoy.git","svn_url":"https://github.com/jmarantz/envoy","homepage":"https://envoyproxy.github.io/","size":53599,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"deffec6a177bdb00586d1d7682aca5dbb395e68a","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-02-14T13:59:55Z","pushed_at":"2018-02-14T00:36:51Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://envoyproxy.github.io/","size":11952,"stargazers_count":3870,"watchers_count":3870,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":470,"mirror_url":null,"archived":false,"open_issues_count":227,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":470,"open_issues":227,"watchers":3870,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2599"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/2599"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/2599"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/2599/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2599/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2599/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/5cf08f683b8f34a5df93f9bc2449c3e8b9e05335"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmarantz"}}