{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleChrome/workbox/issues/329","repository_url":"https://api.github.com/repos/GoogleChrome/workbox","labels_url":"https://api.github.com/repos/GoogleChrome/workbox/issues/329/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/workbox/issues/329/comments","events_url":"https://api.github.com/repos/GoogleChrome/workbox/issues/329/events","html_url":"https://github.com/GoogleChrome/workbox/issues/329","id":214246381,"number":329,"title":"sw-cli globIgnores field doesn't seem to work","user":{"login":"samthor","id":119184,"avatar_url":"https://avatars0.githubusercontent.com/u/119184?v=4","gravatar_id":"","url":"https://api.github.com/users/samthor","html_url":"https://github.com/samthor","followers_url":"https://api.github.com/users/samthor/followers","following_url":"https://api.github.com/users/samthor/following{/other_user}","gists_url":"https://api.github.com/users/samthor/gists{/gist_id}","starred_url":"https://api.github.com/users/samthor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samthor/subscriptions","organizations_url":"https://api.github.com/users/samthor/orgs","repos_url":"https://api.github.com/users/samthor/repos","events_url":"https://api.github.com/users/samthor/events{/privacy}","received_events_url":"https://api.github.com/users/samthor/received_events","type":"User","site_admin":false},"labels":[{"id":571606198,"url":"https://api.github.com/repos/GoogleChrome/workbox/labels/P1","name":"P1","color":"0052cc","default":false},{"id":352475038,"url":"https://api.github.com/repos/GoogleChrome/workbox/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"closed","locked":false,"assignee":{"login":"gauntface","id":139760,"avatar_url":"https://avatars0.githubusercontent.com/u/139760?v=4","gravatar_id":"","url":"https://api.github.com/users/gauntface","html_url":"https://github.com/gauntface","followers_url":"https://api.github.com/users/gauntface/followers","following_url":"https://api.github.com/users/gauntface/following{/other_user}","gists_url":"https://api.github.com/users/gauntface/gists{/gist_id}","starred_url":"https://api.github.com/users/gauntface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauntface/subscriptions","organizations_url":"https://api.github.com/users/gauntface/orgs","repos_url":"https://api.github.com/users/gauntface/repos","events_url":"https://api.github.com/users/gauntface/events{/privacy}","received_events_url":"https://api.github.com/users/gauntface/received_events","type":"User","site_admin":false},"assignees":[{"login":"gauntface","id":139760,"avatar_url":"https://avatars0.githubusercontent.com/u/139760?v=4","gravatar_id":"","url":"https://api.github.com/users/gauntface","html_url":"https://github.com/gauntface","followers_url":"https://api.github.com/users/gauntface/followers","following_url":"https://api.github.com/users/gauntface/following{/other_user}","gists_url":"https://api.github.com/users/gauntface/gists{/gist_id}","starred_url":"https://api.github.com/users/gauntface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauntface/subscriptions","organizations_url":"https://api.github.com/users/gauntface/orgs","repos_url":"https://api.github.com/users/gauntface/repos","events_url":"https://api.github.com/users/gauntface/events{/privacy}","received_events_url":"https://api.github.com/users/gauntface/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/GoogleChrome/workbox/milestones/4","html_url":"https://github.com/GoogleChrome/workbox/milestone/4","labels_url":"https://api.github.com/repos/GoogleChrome/workbox/milestones/4/labels","id":2442183,"number":4,"title":"Workbox (Release)","description":"We're aiming for an official stable release under a new brand.","creator":{"login":"tjsavage","id":348551,"avatar_url":"https://avatars1.githubusercontent.com/u/348551?v=4","gravatar_id":"","url":"https://api.github.com/users/tjsavage","html_url":"https://github.com/tjsavage","followers_url":"https://api.github.com/users/tjsavage/followers","following_url":"https://api.github.com/users/tjsavage/following{/other_user}","gists_url":"https://api.github.com/users/tjsavage/gists{/gist_id}","starred_url":"https://api.github.com/users/tjsavage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjsavage/subscriptions","organizations_url":"https://api.github.com/users/tjsavage/orgs","repos_url":"https://api.github.com/users/tjsavage/repos","events_url":"https://api.github.com/users/tjsavage/events{/privacy}","received_events_url":"https://api.github.com/users/tjsavage/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":42,"state":"closed","created_at":"2017-04-06T23:48:55Z","updated_at":"2017-11-30T23:53:50Z","due_on":"2017-05-05T07:00:00Z","closed_at":"2017-08-10T16:48:36Z"},"comments":3,"created_at":"2017-03-15T00:20:09Z","updated_at":"2018-03-08T16:42:40Z","closed_at":"2017-06-07T20:16:41Z","author_association":"MEMBER","body":"**Library Affected**:\r\nsw-cli\r\n\r\n**Browser & Platform**:\r\nNode v7.7.2\r\n\r\n**Issue or Feature Request Description**:\r\nIf I modify the generated config file (`sw-cli-config.json`) to update the `globIgnores` field by adding \"node_modules/*\" (or \"/node_modules/*\"), and rerun `sw-cli`, the generated `sw.js` file still has node_modules files in it.\r\n\r\n*When reporting bugs, please include relevant JavaScript Console logs and links to public URLs at which the issue could be reproduced.*\r\n\r\n```json\r\n{\"rootDirectory\":\"./\",\"globPatterns\":[\"**/*.{sample,md,js,svg,html,css}\"],\"dest\":\"sw.js\",\"globIgnores\":[\"sw.js\",\"node_modules/*\",\"/node_modules/*\",\"node_modules\"]}\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/GoogleChrome/workbox/issues/comments/371545674","html_url":"https://github.com/GoogleChrome/workbox/issues/329#issuecomment-371545674","issue_url":"https://api.github.com/repos/GoogleChrome/workbox/issues/329","id":371545674,"user":{"login":"arthurmuchir","id":6191766,"avatar_url":"https://avatars0.githubusercontent.com/u/6191766?v=4","gravatar_id":"","url":"https://api.github.com/users/arthurmuchir","html_url":"https://github.com/arthurmuchir","followers_url":"https://api.github.com/users/arthurmuchir/followers","following_url":"https://api.github.com/users/arthurmuchir/following{/other_user}","gists_url":"https://api.github.com/users/arthurmuchir/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurmuchir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurmuchir/subscriptions","organizations_url":"https://api.github.com/users/arthurmuchir/orgs","repos_url":"https://api.github.com/users/arthurmuchir/repos","events_url":"https://api.github.com/users/arthurmuchir/events{/privacy}","received_events_url":"https://api.github.com/users/arthurmuchir/received_events","type":"User","site_admin":false},"created_at":"2018-03-08T16:42:40Z","updated_at":"2018-03-08T16:42:40Z","author_association":"NONE","body":"Is this fixed ? Still got problems with `globIgnores: ['**/*.{json,map}']`, still getting `.json` files in my `precache-manifest.js`"}}
{"actor":{"display_login":"arthurmuchir"}}