{"action":"created","comment":{"url":"https://api.github.com/repos/conan-io/conan/pulls/comments/211915118","pull_request_review_id":148433521,"id":211915118,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTkxNTExOA==","diff_hunk":"@@ -0,0 +1,267 @@\n+from os.path import normpath, join, relpath\n+\n+from conans.errors import NotFoundException, ConanException\n+from conans.model.ref import PackageReference, ConanFileReference\n+from conans.paths import SimplePaths, EXPORT_FOLDER, PACKAGES_FOLDER\n+from conans.server.revision_list import RevisionList\n+\n+REVISIONS_FILE = \"revisions.txt\"\n+\n+\n+class ServerStore(SimplePaths):\n+\n+    def __init__(self, revisions_enabled, storage_adapter):\n+        super(ServerStore, self).__init__(storage_adapter.base_storage_folder())\n+        self._revisions_enabled = revisions_enabled","path":"conans/server/store/server_store.py","position":15,"original_position":15,"commit_id":"33b9144e0905591c6141233cdca4a831a667ebd1","original_commit_id":"33b9144e0905591c6141233cdca4a831a667ebd1","user":{"login":"memsharded","id":15367152,"node_id":"MDQ6VXNlcjE1MzY3MTUy","avatar_url":"https://avatars2.githubusercontent.com/u/15367152?v=4","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false},"body":"Maybe a hierarchy of ServerStore with and without revisions would be a bit more maintainable. But I am ok as-is.","created_at":"2018-08-22T11:09:23Z","updated_at":"2018-08-22T11:14:55Z","html_url":"https://github.com/conan-io/conan/pull/3379#discussion_r211915118","pull_request_url":"https://api.github.com/repos/conan-io/conan/pulls/3379","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan/pulls/comments/211915118"},"html":{"href":"https://github.com/conan-io/conan/pull/3379#discussion_r211915118"},"pull_request":{"href":"https://api.github.com/repos/conan-io/conan/pulls/3379"}}},"pull_request":{"url":"https://api.github.com/repos/conan-io/conan/pulls/3379","id":209580041,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NTgwMDQx","html_url":"https://github.com/conan-io/conan/pull/3379","diff_url":"https://github.com/conan-io/conan/pull/3379.diff","patch_url":"https://github.com/conan-io/conan/pull/3379.patch","issue_url":"https://api.github.com/repos/conan-io/conan/issues/3379","number":3379,"state":"open","locked":false,"title":"Revisions: Only server","user":{"login":"lasote","id":3807515,"node_id":"MDQ6VXNlcjM4MDc1MTU=","avatar_url":"https://avatars1.githubusercontent.com/u/3807515?v=4","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"body":"- Extracted from #3055\r\n- Only `ref` model of the client side.\r\n- Server refactor + revisions support server side (apiv2)\r\n- Server in testing NOT using revisions.","created_at":"2018-08-20T16:43:39Z","updated_at":"2018-08-22T11:14:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b35cbaccafc845214bfe8f74816fc2ded69aa9b","assignee":{"login":"memsharded","id":15367152,"node_id":"MDQ6VXNlcjE1MzY3MTUy","avatar_url":"https://avatars2.githubusercontent.com/u/15367152?v=4","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false},"assignees":[{"login":"memsharded","id":15367152,"node_id":"MDQ6VXNlcjE1MzY3MTUy","avatar_url":"https://avatars2.githubusercontent.com/u/15367152?v=4","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":821746717,"node_id":"MDU6TGFiZWw4MjE3NDY3MTc=","url":"https://api.github.com/repos/conan-io/conan/labels/in%20review","name":"in review","color":"0000e6","default":false}],"milestone":{"url":"https://api.github.com/repos/conan-io/conan/milestones/61","html_url":"https://github.com/conan-io/conan/milestone/61","labels_url":"https://api.github.com/repos/conan-io/conan/milestones/61/labels","id":3469823,"node_id":"MDk6TWlsZXN0b25lMzQ2OTgyMw==","number":61,"title":"1.7","description":null,"creator":{"login":"lasote","id":3807515,"node_id":"MDQ6VXNlcjM4MDc1MTU=","avatar_url":"https://avatars1.githubusercontent.com/u/3807515?v=4","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":51,"state":"open","created_at":"2018-07-03T10:43:21Z","updated_at":"2018-08-22T10:29:04Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/conan-io/conan/pulls/3379/commits","review_comments_url":"https://api.github.com/repos/conan-io/conan/pulls/3379/comments","review_comment_url":"https://api.github.com/repos/conan-io/conan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conan-io/conan/issues/3379/comments","statuses_url":"https://api.github.com/repos/conan-io/conan/statuses/33b9144e0905591c6141233cdca4a831a667ebd1","head":{"label":"lasote:feature/revisions_server","ref":"feature/revisions_server","sha":"33b9144e0905591c6141233cdca4a831a667ebd1","user":{"login":"lasote","id":3807515,"node_id":"MDQ6VXNlcjM4MDc1MTU=","avatar_url":"https://avatars1.githubusercontent.com/u/3807515?v=4","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"repo":{"id":47204017,"node_id":"MDEwOlJlcG9zaXRvcnk0NzIwNDAxNw==","name":"conan","full_name":"lasote/conan","owner":{"login":"lasote","id":3807515,"node_id":"MDQ6VXNlcjM4MDc1MTU=","avatar_url":"https://avatars1.githubusercontent.com/u/3807515?v=4","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lasote/conan","description":"Conan.io - The open-source C/C++ package manager","fork":true,"url":"https://api.github.com/repos/lasote/conan","forks_url":"https://api.github.com/repos/lasote/conan/forks","keys_url":"https://api.github.com/repos/lasote/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lasote/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lasote/conan/teams","hooks_url":"https://api.github.com/repos/lasote/conan/hooks","issue_events_url":"https://api.github.com/repos/lasote/conan/issues/events{/number}","events_url":"https://api.github.com/repos/lasote/conan/events","assignees_url":"https://api.github.com/repos/lasote/conan/assignees{/user}","branches_url":"https://api.github.com/repos/lasote/conan/branches{/branch}","tags_url":"https://api.github.com/repos/lasote/conan/tags","blobs_url":"https://api.github.com/repos/lasote/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lasote/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lasote/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/lasote/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lasote/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/lasote/conan/languages","stargazers_url":"https://api.github.com/repos/lasote/conan/stargazers","contributors_url":"https://api.github.com/repos/lasote/conan/contributors","subscribers_url":"https://api.github.com/repos/lasote/conan/subscribers","subscription_url":"https://api.github.com/repos/lasote/conan/subscription","commits_url":"https://api.github.com/repos/lasote/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/lasote/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/lasote/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/lasote/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/lasote/conan/contents/{+path}","compare_url":"https://api.github.com/repos/lasote/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lasote/conan/merges","archive_url":"https://api.github.com/repos/lasote/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lasote/conan/downloads","issues_url":"https://api.github.com/repos/lasote/conan/issues{/number}","pulls_url":"https://api.github.com/repos/lasote/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/lasote/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/lasote/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lasote/conan/labels{/name}","releases_url":"https://api.github.com/repos/lasote/conan/releases{/id}","deployments_url":"https://api.github.com/repos/lasote/conan/deployments","created_at":"2015-12-01T16:56:42Z","updated_at":"2017-07-19T13:30:17Z","pushed_at":"2018-08-22T10:17:13Z","git_url":"git://github.com/lasote/conan.git","ssh_url":"git@github.com:lasote/conan.git","clone_url":"https://github.com/lasote/conan.git","svn_url":"https://github.com/lasote/conan","homepage":"https://conan.io","size":6528,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":2,"default_branch":"develop"}},"base":{"label":"conan-io:develop","ref":"develop","sha":"3a695a1450b368f08117bb42ffda2c5fc0e60595","user":{"login":"conan-io","id":15212165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjEyMTY1","avatar_url":"https://avatars3.githubusercontent.com/u/15212165?v=4","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"repo":{"id":47190624,"node_id":"MDEwOlJlcG9zaXRvcnk0NzE5MDYyNA==","name":"conan","full_name":"conan-io/conan","owner":{"login":"conan-io","id":15212165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjEyMTY1","avatar_url":"https://avatars3.githubusercontent.com/u/15212165?v=4","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conan-io/conan","description":"Conan.io - The open-source C/C++ package manager","fork":false,"url":"https://api.github.com/repos/conan-io/conan","forks_url":"https://api.github.com/repos/conan-io/conan/forks","keys_url":"https://api.github.com/repos/conan-io/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conan-io/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conan-io/conan/teams","hooks_url":"https://api.github.com/repos/conan-io/conan/hooks","issue_events_url":"https://api.github.com/repos/conan-io/conan/issues/events{/number}","events_url":"https://api.github.com/repos/conan-io/conan/events","assignees_url":"https://api.github.com/repos/conan-io/conan/assignees{/user}","branches_url":"https://api.github.com/repos/conan-io/conan/branches{/branch}","tags_url":"https://api.github.com/repos/conan-io/conan/tags","blobs_url":"https://api.github.com/repos/conan-io/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conan-io/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conan-io/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/conan-io/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conan-io/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/conan-io/conan/languages","stargazers_url":"https://api.github.com/repos/conan-io/conan/stargazers","contributors_url":"https://api.github.com/repos/conan-io/conan/contributors","subscribers_url":"https://api.github.com/repos/conan-io/conan/subscribers","subscription_url":"https://api.github.com/repos/conan-io/conan/subscription","commits_url":"https://api.github.com/repos/conan-io/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/conan-io/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/conan-io/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/conan-io/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/conan-io/conan/contents/{+path}","compare_url":"https://api.github.com/repos/conan-io/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conan-io/conan/merges","archive_url":"https://api.github.com/repos/conan-io/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conan-io/conan/downloads","issues_url":"https://api.github.com/repos/conan-io/conan/issues{/number}","pulls_url":"https://api.github.com/repos/conan-io/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/conan-io/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/conan-io/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conan-io/conan/labels{/name}","releases_url":"https://api.github.com/repos/conan-io/conan/releases{/id}","deployments_url":"https://api.github.com/repos/conan-io/conan/deployments","created_at":"2015-12-01T13:17:02Z","updated_at":"2018-08-22T10:29:10Z","pushed_at":"2018-08-22T10:29:04Z","git_url":"git://github.com/conan-io/conan.git","ssh_url":"git@github.com:conan-io/conan.git","clone_url":"https://github.com/conan-io/conan.git","svn_url":"https://github.com/conan-io/conan","homepage":"https://conan.io","size":5268,"stargazers_count":2084,"watchers_count":2084,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":268,"mirror_url":null,"archived":false,"open_issues_count":443,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":268,"open_issues":443,"watchers":2084,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan/pulls/3379"},"html":{"href":"https://github.com/conan-io/conan/pull/3379"},"issue":{"href":"https://api.github.com/repos/conan-io/conan/issues/3379"},"comments":{"href":"https://api.github.com/repos/conan-io/conan/issues/3379/comments"},"review_comments":{"href":"https://api.github.com/repos/conan-io/conan/pulls/3379/comments"},"review_comment":{"href":"https://api.github.com/repos/conan-io/conan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conan-io/conan/pulls/3379/commits"},"statuses":{"href":"https://api.github.com/repos/conan-io/conan/statuses/33b9144e0905591c6141233cdca4a831a667ebd1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"memsharded"}}