{"action":"opened","issue":{"url":"https://api.github.com/repos/GitHawkApp/GitHawk/issues/2070","repository_url":"https://api.github.com/repos/GitHawkApp/GitHawk","labels_url":"https://api.github.com/repos/GitHawkApp/GitHawk/issues/2070/labels{/name}","comments_url":"https://api.github.com/repos/GitHawkApp/GitHawk/issues/2070/comments","events_url":"https://api.github.com/repos/GitHawkApp/GitHawk/issues/2070/events","html_url":"https://github.com/GitHawkApp/GitHawk/issues/2070","id":349334060,"node_id":"MDU6SXNzdWUzNDkzMzQwNjA=","number":2070,"title":"FeedRefresh only not calling beginRefreshing (only endRefreshing)","user":{"login":"Huddie","id":10662471,"node_id":"MDQ6VXNlcjEwNjYyNDcx","avatar_url":"https://avatars0.githubusercontent.com/u/10662471?v=4","gravatar_id":"","url":"https://api.github.com/users/Huddie","html_url":"https://github.com/Huddie","followers_url":"https://api.github.com/users/Huddie/followers","following_url":"https://api.github.com/users/Huddie/following{/other_user}","gists_url":"https://api.github.com/users/Huddie/gists{/gist_id}","starred_url":"https://api.github.com/users/Huddie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Huddie/subscriptions","organizations_url":"https://api.github.com/users/Huddie/orgs","repos_url":"https://api.github.com/users/Huddie/repos","events_url":"https://api.github.com/users/Huddie/events{/privacy}","received_events_url":"https://api.github.com/users/Huddie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-10T00:15:58Z","updated_at":"2018-08-10T00:15:58Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Is there any chance that beginRefreshing (In `FeedRefresh.swift`) is seldomly called?\r\n\r\nMy research:\r\nChecked the call hierarchy. It led me to 2 places\r\n\r\n1. `Feed.refreshHead`\r\n2. `RepositoryCodeBlobViewController`\r\n\r\nI didn't focus on the 2nd one but in the first one I checked the call hierarchy again (For refreshHead)\r\n\r\n1. `NotificationsViewController.didForeground(handler:)`\r\n\r\nI took a guess on this one that it had to do with the app moving from inactive/background -> active/foreground. \r\n\r\nSo i'm going to assume `FeedRefresh. beginRefreshing` isn't called regularly (When user pulls down on list)\r\n\r\nNot sure if this is on purpose. Pretty sure everything is getting updated and pull to refresh will \"work\" fine with just endRefreshing called but \r\n\r\n1. It doesn't allow for custom pull to refresh animations to occur on begin\r\n2. It's a bit weird that begin refreshing isn't called IMO\r\n\r\n"}}
{"actor":{"display_login":"Huddie"}}