{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/polymer/pulls/comments/231267454","pull_request_review_id":172201656,"id":231267454,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTI2NzQ1NA==","diff_hunk":"@@ -166,28 +248,57 @@\n         /**\n          * @return {void}\n          */\n+        // Called on element prototype\n         _registered() {\n-          super._registered();\n           /* NOTE: `beforeRegister` is called here for bc, but the behavior\n            is different than in 1.x. In 1.0, the method was called *after*\n            mixing prototypes together but *before* processing of meta-objects.\n            However, dynamic effects can still be set here and can be done either\n            in `beforeRegister` or `registered`. It is no longer possible to set\n            `is` in `beforeRegister` as you could in 1.x.\n           */\n+          const proto = this;\n+          if (proto.hasOwnProperty('__behaviors')) {","path":"lib/legacy/class.html","position":229,"original_position":229,"commit_id":"5bd4afd6cd6e80905c7dec03f551e05750e3ce93","original_commit_id":"5bd4afd6cd6e80905c7dec03f551e05750e3ce93","user":{"login":"sorvell","id":78891,"node_id":"MDQ6VXNlcjc4ODkx","avatar_url":"https://avatars1.githubusercontent.com/u/78891?v=4","gravatar_id":"","url":"https://api.github.com/users/sorvell","html_url":"https://github.com/sorvell","followers_url":"https://api.github.com/users/sorvell/followers","following_url":"https://api.github.com/users/sorvell/following{/other_user}","gists_url":"https://api.github.com/users/sorvell/gists{/gist_id}","starred_url":"https://api.github.com/users/sorvell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorvell/subscriptions","organizations_url":"https://api.github.com/users/sorvell/orgs","repos_url":"https://api.github.com/users/sorvell/repos","events_url":"https://api.github.com/users/sorvell/events{/privacy}","received_events_url":"https://api.github.com/users/sorvell/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-11-06T19:48:55Z","updated_at":"2018-11-06T19:48:55Z","html_url":"https://github.com/Polymer/polymer/pull/5418#discussion_r231267454","pull_request_url":"https://api.github.com/repos/Polymer/polymer/pulls/5418","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/comments/231267454"},"html":{"href":"https://github.com/Polymer/polymer/pull/5418#discussion_r231267454"},"pull_request":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/5418"}},"in_reply_to_id":230989807},"pull_request":{"url":"https://api.github.com/repos/Polymer/polymer/pulls/5418","id":227424110,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDI0MTEw","html_url":"https://github.com/Polymer/polymer/pull/5418","diff_url":"https://github.com/Polymer/polymer/pull/5418.diff","patch_url":"https://github.com/Polymer/polymer/pull/5418.patch","issue_url":"https://api.github.com/repos/Polymer/polymer/issues/5418","number":5418,"state":"open","locked":false,"title":"2.x - Performance optimizations geared towards legacy `Polymer({...})` use","user":{"login":"sorvell","id":78891,"node_id":"MDQ6VXNlcjc4ODkx","avatar_url":"https://avatars1.githubusercontent.com/u/78891?v=4","gravatar_id":"","url":"https://api.github.com/users/sorvell","html_url":"https://github.com/sorvell","followers_url":"https://api.github.com/users/sorvell/followers","following_url":"https://api.github.com/users/sorvell/following{/other_user}","gists_url":"https://api.github.com/users/sorvell/gists{/gist_id}","starred_url":"https://api.github.com/users/sorvell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorvell/subscriptions","organizations_url":"https://api.github.com/users/sorvell/orgs","repos_url":"https://api.github.com/users/sorvell/repos","events_url":"https://api.github.com/users/sorvell/events{/privacy}","received_events_url":"https://api.github.com/users/sorvell/received_events","type":"User","site_admin":false},"body":"* Behaviors:\r\n  * Now mixed in lazily rather than at class time. This change means behaviors are no longer in the element's prototype chain.\r\n  * A memoized list of behavior lifecycle methods is constructed at finalization time and then used at runtime.\r\n* Adds `Polymer.legacyOptimizations` flag which avoids copying element templates (needed for subclassing) and turns on `stripWhitespace` for all templates.\r\n* TemplateStamp: A TreeWalker is now used to crawl through template nodes. This should be slightly faster when the ShadyDOM polyfill is used.\r\n* `Polymer.telemetry`: now properly records registered elements, even if they have not been created","created_at":"2018-10-31T20:03:30Z","updated_at":"2018-11-06T19:48:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b76cf3f6bbb6ce798ba025b623c2b5e0ebae6bd8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"azakus","id":46725,"node_id":"MDQ6VXNlcjQ2NzI1","avatar_url":"https://avatars0.githubusercontent.com/u/46725?v=4","gravatar_id":"","url":"https://api.github.com/users/azakus","html_url":"https://github.com/azakus","followers_url":"https://api.github.com/users/azakus/followers","following_url":"https://api.github.com/users/azakus/following{/other_user}","gists_url":"https://api.github.com/users/azakus/gists{/gist_id}","starred_url":"https://api.github.com/users/azakus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azakus/subscriptions","organizations_url":"https://api.github.com/users/azakus/orgs","repos_url":"https://api.github.com/users/azakus/repos","events_url":"https://api.github.com/users/azakus/events{/privacy}","received_events_url":"https://api.github.com/users/azakus/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":88354526,"node_id":"MDU6TGFiZWw4ODM1NDUyNg==","url":"https://api.github.com/repos/Polymer/polymer/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/polymer/pulls/5418/commits","review_comments_url":"https://api.github.com/repos/Polymer/polymer/pulls/5418/comments","review_comment_url":"https://api.github.com/repos/Polymer/polymer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/polymer/issues/5418/comments","statuses_url":"https://api.github.com/repos/Polymer/polymer/statuses/5bd4afd6cd6e80905c7dec03f551e05750e3ce93","head":{"label":"Polymer:perf-opt","ref":"perf-opt","sha":"5bd4afd6cd6e80905c7dec03f551e05750e3ce93","user":{"login":"Polymer","id":2159051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNTkwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2159051?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":5532320,"node_id":"MDEwOlJlcG9zaXRvcnk1NTMyMzIw","name":"polymer","full_name":"Polymer/polymer","private":false,"owner":{"login":"Polymer","id":2159051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNTkwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2159051?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Polymer/polymer","description":"Build modern apps using web components","fork":false,"url":"https://api.github.com/repos/Polymer/polymer","forks_url":"https://api.github.com/repos/Polymer/polymer/forks","keys_url":"https://api.github.com/repos/Polymer/polymer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer/events","assignees_url":"https://api.github.com/repos/Polymer/polymer/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer/merges","archive_url":"https://api.github.com/repos/Polymer/polymer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/polymer/deployments","created_at":"2012-08-23T20:56:30Z","updated_at":"2018-11-06T18:33:48Z","pushed_at":"2018-11-06T00:34:43Z","git_url":"git://github.com/Polymer/polymer.git","ssh_url":"git@github.com:Polymer/polymer.git","clone_url":"https://github.com/Polymer/polymer.git","svn_url":"https://github.com/Polymer/polymer","homepage":"https://www.polymer-project.org/","size":27551,"stargazers_count":20356,"watchers_count":20356,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1985,"mirror_url":null,"archived":false,"open_issues_count":244,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1985,"open_issues":244,"watchers":20356,"default_branch":"master"}},"base":{"label":"Polymer:2.x","ref":"2.x","sha":"8882c3db248634403453e2969d1e9e02f5333b48","user":{"login":"Polymer","id":2159051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNTkwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2159051?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":5532320,"node_id":"MDEwOlJlcG9zaXRvcnk1NTMyMzIw","name":"polymer","full_name":"Polymer/polymer","private":false,"owner":{"login":"Polymer","id":2159051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNTkwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2159051?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Polymer/polymer","description":"Build modern apps using web components","fork":false,"url":"https://api.github.com/repos/Polymer/polymer","forks_url":"https://api.github.com/repos/Polymer/polymer/forks","keys_url":"https://api.github.com/repos/Polymer/polymer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer/events","assignees_url":"https://api.github.com/repos/Polymer/polymer/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer/merges","archive_url":"https://api.github.com/repos/Polymer/polymer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/polymer/deployments","created_at":"2012-08-23T20:56:30Z","updated_at":"2018-11-06T18:33:48Z","pushed_at":"2018-11-06T00:34:43Z","git_url":"git://github.com/Polymer/polymer.git","ssh_url":"git@github.com:Polymer/polymer.git","clone_url":"https://github.com/Polymer/polymer.git","svn_url":"https://github.com/Polymer/polymer","homepage":"https://www.polymer-project.org/","size":27551,"stargazers_count":20356,"watchers_count":20356,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1985,"mirror_url":null,"archived":false,"open_issues_count":244,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1985,"open_issues":244,"watchers":20356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/5418"},"html":{"href":"https://github.com/Polymer/polymer/pull/5418"},"issue":{"href":"https://api.github.com/repos/Polymer/polymer/issues/5418"},"comments":{"href":"https://api.github.com/repos/Polymer/polymer/issues/5418/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/5418/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/5418/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/polymer/statuses/5bd4afd6cd6e80905c7dec03f551e05750e3ce93"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sorvell"}}