{"action":"created","comment":{"url":"https://api.github.com/repos/delphix/appliance-build/pulls/comments/201170873","pull_request_review_id":135620194,"id":201170873,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTE3MDg3Mw==","diff_hunk":"@@ -323,3 +323,37 @@\n   with_items:\n     - { key: 'kernel.core_pattern', value: '/var/crash/core.%e.%p.%t' }\n     - { key: 'vm.overcommit_memory', value: '1' }\n+\n+#\n+# Add the apt repos that have the debug versions of packages, so that we\n+# can download a debug kernel to use with crash.\n+#\n+- apt:\n+    name: 'ubuntu-dbgsym-keyring'\n+- apt_repository:\n+    repo: \"{{ item }}\"\n+  with_items:\n+    - deb http://ddebs.ubuntu.com bionic main restricted universe multiverse\n+    - deb http://ddebs.ubuntu.com bionic-updates main restricted universe multiverse\n+    - deb http://ddebs.ubuntu.com bionic-proposed main restricted universe multiverse\n+\n+#\n+# Assume that the newest kernel is the one we are going to boot, and\n+# fetch the symbols for that one.\n+#\n+- shell: ls /boot/vmlinuz-* | sed 's|/boot/vmlinuz-||' | sort -V | tail -n1","path":"live-build/misc/ansible-roles/appliance-build.minimal-common/tasks/main.yml","position":22,"original_position":22,"commit_id":"28f362e7fa38605e618fa635fb1e4c5f6cd425f8","original_commit_id":"28f362e7fa38605e618fa635fb1e4c5f6cd425f8","user":{"login":"jgallag88","id":4139386,"node_id":"MDQ6VXNlcjQxMzkzODY=","avatar_url":"https://avatars1.githubusercontent.com/u/4139386?v=4","gravatar_id":"","url":"https://api.github.com/users/jgallag88","html_url":"https://github.com/jgallag88","followers_url":"https://api.github.com/users/jgallag88/followers","following_url":"https://api.github.com/users/jgallag88/following{/other_user}","gists_url":"https://api.github.com/users/jgallag88/gists{/gist_id}","starred_url":"https://api.github.com/users/jgallag88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgallag88/subscriptions","organizations_url":"https://api.github.com/users/jgallag88/orgs","repos_url":"https://api.github.com/users/jgallag88/repos","events_url":"https://api.github.com/users/jgallag88/events{/privacy}","received_events_url":"https://api.github.com/users/jgallag88/received_events","type":"User","site_admin":false},"body":"My thinking was that we would need a zfs kernel module for each kernel that we actually want to use, and since we only install one zfs module as part of the appliance build, we are only going to have one usable kernel, so we only need the debug symbols for that kernel.\r\n\r\nHowever, instead of just choosing the newest kernel, it's probably better to either\r\n - Fail if the assumption that there is only one kernel installed doesn't hold, or\r\n - Just install symbols for every version like you mention, and let the other parts of the build worry about which and how many kernels to install.\r\n\r\nI don't I really have a preference for one over the other.","created_at":"2018-07-09T22:46:02Z","updated_at":"2018-07-09T22:46:02Z","html_url":"https://github.com/delphix/appliance-build/pull/65#discussion_r201170873","pull_request_url":"https://api.github.com/repos/delphix/appliance-build/pulls/65","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/delphix/appliance-build/pulls/comments/201170873"},"html":{"href":"https://github.com/delphix/appliance-build/pull/65#discussion_r201170873"},"pull_request":{"href":"https://api.github.com/repos/delphix/appliance-build/pulls/65"}},"in_reply_to_id":200787781},"pull_request":{"url":"https://api.github.com/repos/delphix/appliance-build/pulls/65","id":199861566,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODYxNTY2","html_url":"https://github.com/delphix/appliance-build/pull/65","diff_url":"https://github.com/delphix/appliance-build/pull/65.diff","patch_url":"https://github.com/delphix/appliance-build/pull/65.patch","issue_url":"https://api.github.com/repos/delphix/appliance-build/issues/65","number":65,"state":"open","locked":false,"title":"LX-960 Enable kernel crash dump support","user":{"login":"jgallag88","id":4139386,"node_id":"MDQ6VXNlcjQxMzkzODY=","avatar_url":"https://avatars1.githubusercontent.com/u/4139386?v=4","gravatar_id":"","url":"https://api.github.com/users/jgallag88","html_url":"https://github.com/jgallag88","followers_url":"https://api.github.com/users/jgallag88/followers","following_url":"https://api.github.com/users/jgallag88/following{/other_user}","gists_url":"https://api.github.com/users/jgallag88/gists{/gist_id}","starred_url":"https://api.github.com/users/jgallag88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgallag88/subscriptions","organizations_url":"https://api.github.com/users/jgallag88/orgs","repos_url":"https://api.github.com/users/jgallag88/repos","events_url":"https://api.github.com/users/jgallag88/events{/privacy}","received_events_url":"https://api.github.com/users/jgallag88/received_events","type":"User","site_admin":false},"body":"This adds and configures `kdump` so that we can get crash dumps, and adds `crash` so that we can examine them.\r\n\r\nNote that this adds some time to the build, because downloading debug kernel from the Ubuntu repository for debug packages is quite slow (it takes ~15min to download <600MB). Once we start mirroring all of the upstream Ubuntu packages, this should no longer be an issue.\r\n\r\nThis change requires expanding the size of the disk on the bootstrap vm, which is blocked until the fix for DOAM-786 is deployed. However, I've tested building a single variant, and used qemu to verify that crash dumps are gathered successfully. I'll run `git-ab-pre-push` after the bootstrap golden image is updated.","created_at":"2018-07-06T22:41:53Z","updated_at":"2018-07-09T22:46:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa848529f7514aa2a419c159e7b8052aaad3b76f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/delphix/appliance-build/pulls/65/commits","review_comments_url":"https://api.github.com/repos/delphix/appliance-build/pulls/65/comments","review_comment_url":"https://api.github.com/repos/delphix/appliance-build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/delphix/appliance-build/issues/65/comments","statuses_url":"https://api.github.com/repos/delphix/appliance-build/statuses/28f362e7fa38605e618fa635fb1e4c5f6cd425f8","head":{"label":"jgallag88:crashdumps","ref":"crashdumps","sha":"28f362e7fa38605e618fa635fb1e4c5f6cd425f8","user":{"login":"jgallag88","id":4139386,"node_id":"MDQ6VXNlcjQxMzkzODY=","avatar_url":"https://avatars1.githubusercontent.com/u/4139386?v=4","gravatar_id":"","url":"https://api.github.com/users/jgallag88","html_url":"https://github.com/jgallag88","followers_url":"https://api.github.com/users/jgallag88/followers","following_url":"https://api.github.com/users/jgallag88/following{/other_user}","gists_url":"https://api.github.com/users/jgallag88/gists{/gist_id}","starred_url":"https://api.github.com/users/jgallag88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgallag88/subscriptions","organizations_url":"https://api.github.com/users/jgallag88/orgs","repos_url":"https://api.github.com/users/jgallag88/repos","events_url":"https://api.github.com/users/jgallag88/events{/privacy}","received_events_url":"https://api.github.com/users/jgallag88/received_events","type":"User","site_admin":false},"repo":{"id":131911772,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE5MTE3NzI=","name":"appliance-build","full_name":"jgallag88/appliance-build","owner":{"login":"jgallag88","id":4139386,"node_id":"MDQ6VXNlcjQxMzkzODY=","avatar_url":"https://avatars1.githubusercontent.com/u/4139386?v=4","gravatar_id":"","url":"https://api.github.com/users/jgallag88","html_url":"https://github.com/jgallag88","followers_url":"https://api.github.com/users/jgallag88/followers","following_url":"https://api.github.com/users/jgallag88/following{/other_user}","gists_url":"https://api.github.com/users/jgallag88/gists{/gist_id}","starred_url":"https://api.github.com/users/jgallag88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgallag88/subscriptions","organizations_url":"https://api.github.com/users/jgallag88/orgs","repos_url":"https://api.github.com/users/jgallag88/repos","events_url":"https://api.github.com/users/jgallag88/events{/privacy}","received_events_url":"https://api.github.com/users/jgallag88/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgallag88/appliance-build","description":"This repository contains the code used to build the Ubuntu-based Delphix Appliance, leveraging open-source tools such as Debian's live-build, Docker, Ansible, OpenZFS, and others.","fork":true,"url":"https://api.github.com/repos/jgallag88/appliance-build","forks_url":"https://api.github.com/repos/jgallag88/appliance-build/forks","keys_url":"https://api.github.com/repos/jgallag88/appliance-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgallag88/appliance-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgallag88/appliance-build/teams","hooks_url":"https://api.github.com/repos/jgallag88/appliance-build/hooks","issue_events_url":"https://api.github.com/repos/jgallag88/appliance-build/issues/events{/number}","events_url":"https://api.github.com/repos/jgallag88/appliance-build/events","assignees_url":"https://api.github.com/repos/jgallag88/appliance-build/assignees{/user}","branches_url":"https://api.github.com/repos/jgallag88/appliance-build/branches{/branch}","tags_url":"https://api.github.com/repos/jgallag88/appliance-build/tags","blobs_url":"https://api.github.com/repos/jgallag88/appliance-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgallag88/appliance-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgallag88/appliance-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgallag88/appliance-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgallag88/appliance-build/statuses/{sha}","languages_url":"https://api.github.com/repos/jgallag88/appliance-build/languages","stargazers_url":"https://api.github.com/repos/jgallag88/appliance-build/stargazers","contributors_url":"https://api.github.com/repos/jgallag88/appliance-build/contributors","subscribers_url":"https://api.github.com/repos/jgallag88/appliance-build/subscribers","subscription_url":"https://api.github.com/repos/jgallag88/appliance-build/subscription","commits_url":"https://api.github.com/repos/jgallag88/appliance-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgallag88/appliance-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgallag88/appliance-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgallag88/appliance-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgallag88/appliance-build/contents/{+path}","compare_url":"https://api.github.com/repos/jgallag88/appliance-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgallag88/appliance-build/merges","archive_url":"https://api.github.com/repos/jgallag88/appliance-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgallag88/appliance-build/downloads","issues_url":"https://api.github.com/repos/jgallag88/appliance-build/issues{/number}","pulls_url":"https://api.github.com/repos/jgallag88/appliance-build/pulls{/number}","milestones_url":"https://api.github.com/repos/jgallag88/appliance-build/milestones{/number}","notifications_url":"https://api.github.com/repos/jgallag88/appliance-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgallag88/appliance-build/labels{/name}","releases_url":"https://api.github.com/repos/jgallag88/appliance-build/releases{/id}","deployments_url":"https://api.github.com/repos/jgallag88/appliance-build/deployments","created_at":"2018-05-02T22:19:38Z","updated_at":"2018-06-07T20:59:43Z","pushed_at":"2018-07-06T22:39:14Z","git_url":"git://github.com/jgallag88/appliance-build.git","ssh_url":"git@github.com:jgallag88/appliance-build.git","clone_url":"https://github.com/jgallag88/appliance-build.git","svn_url":"https://github.com/jgallag88/appliance-build","homepage":"","size":161,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"delphix:master","ref":"master","sha":"aaeff9d58bd5f53dfd576c79025eb6f428294f52","user":{"login":"delphix","id":682240,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4MjI0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/682240?v=4","gravatar_id":"","url":"https://api.github.com/users/delphix","html_url":"https://github.com/delphix","followers_url":"https://api.github.com/users/delphix/followers","following_url":"https://api.github.com/users/delphix/following{/other_user}","gists_url":"https://api.github.com/users/delphix/gists{/gist_id}","starred_url":"https://api.github.com/users/delphix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delphix/subscriptions","organizations_url":"https://api.github.com/users/delphix/orgs","repos_url":"https://api.github.com/users/delphix/repos","events_url":"https://api.github.com/users/delphix/events{/privacy}","received_events_url":"https://api.github.com/users/delphix/received_events","type":"Organization","site_admin":false},"repo":{"id":131873230,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE4NzMyMzA=","name":"appliance-build","full_name":"delphix/appliance-build","owner":{"login":"delphix","id":682240,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4MjI0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/682240?v=4","gravatar_id":"","url":"https://api.github.com/users/delphix","html_url":"https://github.com/delphix","followers_url":"https://api.github.com/users/delphix/followers","following_url":"https://api.github.com/users/delphix/following{/other_user}","gists_url":"https://api.github.com/users/delphix/gists{/gist_id}","starred_url":"https://api.github.com/users/delphix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delphix/subscriptions","organizations_url":"https://api.github.com/users/delphix/orgs","repos_url":"https://api.github.com/users/delphix/repos","events_url":"https://api.github.com/users/delphix/events{/privacy}","received_events_url":"https://api.github.com/users/delphix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/delphix/appliance-build","description":"This repository contains the code used to build the Ubuntu-based Delphix Appliance, leveraging open-source tools such as Debian's live-build, Docker, Ansible, OpenZFS, and others.","fork":false,"url":"https://api.github.com/repos/delphix/appliance-build","forks_url":"https://api.github.com/repos/delphix/appliance-build/forks","keys_url":"https://api.github.com/repos/delphix/appliance-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/delphix/appliance-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/delphix/appliance-build/teams","hooks_url":"https://api.github.com/repos/delphix/appliance-build/hooks","issue_events_url":"https://api.github.com/repos/delphix/appliance-build/issues/events{/number}","events_url":"https://api.github.com/repos/delphix/appliance-build/events","assignees_url":"https://api.github.com/repos/delphix/appliance-build/assignees{/user}","branches_url":"https://api.github.com/repos/delphix/appliance-build/branches{/branch}","tags_url":"https://api.github.com/repos/delphix/appliance-build/tags","blobs_url":"https://api.github.com/repos/delphix/appliance-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/delphix/appliance-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/delphix/appliance-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/delphix/appliance-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/delphix/appliance-build/statuses/{sha}","languages_url":"https://api.github.com/repos/delphix/appliance-build/languages","stargazers_url":"https://api.github.com/repos/delphix/appliance-build/stargazers","contributors_url":"https://api.github.com/repos/delphix/appliance-build/contributors","subscribers_url":"https://api.github.com/repos/delphix/appliance-build/subscribers","subscription_url":"https://api.github.com/repos/delphix/appliance-build/subscription","commits_url":"https://api.github.com/repos/delphix/appliance-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/delphix/appliance-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/delphix/appliance-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/delphix/appliance-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/delphix/appliance-build/contents/{+path}","compare_url":"https://api.github.com/repos/delphix/appliance-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/delphix/appliance-build/merges","archive_url":"https://api.github.com/repos/delphix/appliance-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/delphix/appliance-build/downloads","issues_url":"https://api.github.com/repos/delphix/appliance-build/issues{/number}","pulls_url":"https://api.github.com/repos/delphix/appliance-build/pulls{/number}","milestones_url":"https://api.github.com/repos/delphix/appliance-build/milestones{/number}","notifications_url":"https://api.github.com/repos/delphix/appliance-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/delphix/appliance-build/labels{/name}","releases_url":"https://api.github.com/repos/delphix/appliance-build/releases{/id}","deployments_url":"https://api.github.com/repos/delphix/appliance-build/deployments","created_at":"2018-05-02T15:49:13Z","updated_at":"2018-07-06T16:49:13Z","pushed_at":"2018-07-09T22:21:46Z","git_url":"git://github.com/delphix/appliance-build.git","ssh_url":"git@github.com:delphix/appliance-build.git","clone_url":"https://github.com/delphix/appliance-build.git","svn_url":"https://github.com/delphix/appliance-build","homepage":"","size":157,"stargazers_count":6,"watchers_count":6,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/delphix/appliance-build/pulls/65"},"html":{"href":"https://github.com/delphix/appliance-build/pull/65"},"issue":{"href":"https://api.github.com/repos/delphix/appliance-build/issues/65"},"comments":{"href":"https://api.github.com/repos/delphix/appliance-build/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/delphix/appliance-build/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/delphix/appliance-build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/delphix/appliance-build/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/delphix/appliance-build/statuses/28f362e7fa38605e618fa635fb1e4c5f6cd425f8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jgallag88"}}