{"action":"created","issue":{"url":"https://api.github.com/repos/pendo-io/appwrap/issues/12","repository_url":"https://api.github.com/repos/pendo-io/appwrap","labels_url":"https://api.github.com/repos/pendo-io/appwrap/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/pendo-io/appwrap/issues/12/comments","events_url":"https://api.github.com/repos/pendo-io/appwrap/issues/12/events","html_url":"https://github.com/pendo-io/appwrap/pull/12","id":357867090,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzc4ODk5","number":12,"title":"APP-10820 Added DataLogger Interface to appwrap","user":{"login":"JamWils","id":1825111,"node_id":"MDQ6VXNlcjE4MjUxMTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1825111?v=4","gravatar_id":"","url":"https://api.github.com/users/JamWils","html_url":"https://github.com/JamWils","followers_url":"https://api.github.com/users/JamWils/followers","following_url":"https://api.github.com/users/JamWils/following{/other_user}","gists_url":"https://api.github.com/users/JamWils/gists{/gist_id}","starred_url":"https://api.github.com/users/JamWils/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamWils/subscriptions","organizations_url":"https://api.github.com/users/JamWils/orgs","repos_url":"https://api.github.com/users/JamWils/repos","events_url":"https://api.github.com/users/JamWils/events{/privacy}","received_events_url":"https://api.github.com/users/JamWils/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"sgp","id":50475,"node_id":"MDQ6VXNlcjUwNDc1","avatar_url":"https://avatars2.githubusercontent.com/u/50475?v=4","gravatar_id":"","url":"https://api.github.com/users/sgp","html_url":"https://github.com/sgp","followers_url":"https://api.github.com/users/sgp/followers","following_url":"https://api.github.com/users/sgp/following{/other_user}","gists_url":"https://api.github.com/users/sgp/gists{/gist_id}","starred_url":"https://api.github.com/users/sgp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgp/subscriptions","organizations_url":"https://api.github.com/users/sgp/orgs","repos_url":"https://api.github.com/users/sgp/repos","events_url":"https://api.github.com/users/sgp/events{/privacy}","received_events_url":"https://api.github.com/users/sgp/received_events","type":"User","site_admin":false},"assignees":[{"login":"sgp","id":50475,"node_id":"MDQ6VXNlcjUwNDc1","avatar_url":"https://avatars2.githubusercontent.com/u/50475?v=4","gravatar_id":"","url":"https://api.github.com/users/sgp","html_url":"https://github.com/sgp","followers_url":"https://api.github.com/users/sgp/followers","following_url":"https://api.github.com/users/sgp/following{/other_user}","gists_url":"https://api.github.com/users/sgp/gists{/gist_id}","starred_url":"https://api.github.com/users/sgp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgp/subscriptions","organizations_url":"https://api.github.com/users/sgp/orgs","repos_url":"https://api.github.com/users/sgp/repos","events_url":"https://api.github.com/users/sgp/events{/privacy}","received_events_url":"https://api.github.com/users/sgp/received_events","type":"User","site_admin":false},{"login":"daboyuka","id":3924734,"node_id":"MDQ6VXNlcjM5MjQ3MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3924734?v=4","gravatar_id":"","url":"https://api.github.com/users/daboyuka","html_url":"https://github.com/daboyuka","followers_url":"https://api.github.com/users/daboyuka/followers","following_url":"https://api.github.com/users/daboyuka/following{/other_user}","gists_url":"https://api.github.com/users/daboyuka/gists{/gist_id}","starred_url":"https://api.github.com/users/daboyuka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daboyuka/subscriptions","organizations_url":"https://api.github.com/users/daboyuka/orgs","repos_url":"https://api.github.com/users/daboyuka/repos","events_url":"https://api.github.com/users/daboyuka/events{/privacy}","received_events_url":"https://api.github.com/users/daboyuka/received_events","type":"User","site_admin":false},{"login":"ewtroan","id":5664819,"node_id":"MDQ6VXNlcjU2NjQ4MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5664819?v=4","gravatar_id":"","url":"https://api.github.com/users/ewtroan","html_url":"https://github.com/ewtroan","followers_url":"https://api.github.com/users/ewtroan/followers","following_url":"https://api.github.com/users/ewtroan/following{/other_user}","gists_url":"https://api.github.com/users/ewtroan/gists{/gist_id}","starred_url":"https://api.github.com/users/ewtroan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewtroan/subscriptions","organizations_url":"https://api.github.com/users/ewtroan/orgs","repos_url":"https://api.github.com/users/ewtroan/repos","events_url":"https://api.github.com/users/ewtroan/events{/privacy}","received_events_url":"https://api.github.com/users/ewtroan/received_events","type":"User","site_admin":false},{"login":"jshore1296","id":20143850,"node_id":"MDQ6VXNlcjIwMTQzODUw","avatar_url":"https://avatars2.githubusercontent.com/u/20143850?v=4","gravatar_id":"","url":"https://api.github.com/users/jshore1296","html_url":"https://github.com/jshore1296","followers_url":"https://api.github.com/users/jshore1296/followers","following_url":"https://api.github.com/users/jshore1296/following{/other_user}","gists_url":"https://api.github.com/users/jshore1296/gists{/gist_id}","starred_url":"https://api.github.com/users/jshore1296/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jshore1296/subscriptions","organizations_url":"https://api.github.com/users/jshore1296/orgs","repos_url":"https://api.github.com/users/jshore1296/repos","events_url":"https://api.github.com/users/jshore1296/events{/privacy}","received_events_url":"https://api.github.com/users/jshore1296/received_events","type":"User","site_admin":false},{"login":"mkj-pendo","id":22749559,"node_id":"MDQ6VXNlcjIyNzQ5NTU5","avatar_url":"https://avatars1.githubusercontent.com/u/22749559?v=4","gravatar_id":"","url":"https://api.github.com/users/mkj-pendo","html_url":"https://github.com/mkj-pendo","followers_url":"https://api.github.com/users/mkj-pendo/followers","following_url":"https://api.github.com/users/mkj-pendo/following{/other_user}","gists_url":"https://api.github.com/users/mkj-pendo/gists{/gist_id}","starred_url":"https://api.github.com/users/mkj-pendo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkj-pendo/subscriptions","organizations_url":"https://api.github.com/users/mkj-pendo/orgs","repos_url":"https://api.github.com/users/mkj-pendo/repos","events_url":"https://api.github.com/users/mkj-pendo/events{/privacy}","received_events_url":"https://api.github.com/users/mkj-pendo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":18,"created_at":"2018-09-06T23:36:38Z","updated_at":"2018-12-19T17:54:12Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/pendo-io/appwrap/pulls/12","html_url":"https://github.com/pendo-io/appwrap/pull/12","diff_url":"https://github.com/pendo-io/appwrap/pull/12.diff","patch_url":"https://github.com/pendo-io/appwrap/pull/12.patch"},"body":"I'm expecting that there might be some back and forth on this.  I wanted to get the PRs up so we can keep moving forward.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pendo-io/appwrap/12)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/pendo-io/appwrap/issues/comments/448686620","html_url":"https://github.com/pendo-io/appwrap/pull/12#issuecomment-448686620","issue_url":"https://api.github.com/repos/pendo-io/appwrap/issues/12","id":448686620,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODY4NjYyMA==","user":{"login":"JamWils","id":1825111,"node_id":"MDQ6VXNlcjE4MjUxMTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1825111?v=4","gravatar_id":"","url":"https://api.github.com/users/JamWils","html_url":"https://github.com/JamWils","followers_url":"https://api.github.com/users/JamWils/followers","following_url":"https://api.github.com/users/JamWils/following{/other_user}","gists_url":"https://api.github.com/users/JamWils/gists{/gist_id}","starred_url":"https://api.github.com/users/JamWils/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamWils/subscriptions","organizations_url":"https://api.github.com/users/JamWils/orgs","repos_url":"https://api.github.com/users/JamWils/repos","events_url":"https://api.github.com/users/JamWils/events{/privacy}","received_events_url":"https://api.github.com/users/JamWils/received_events","type":"User","site_admin":false},"created_at":"2018-12-19T17:54:12Z","updated_at":"2018-12-19T17:54:12Z","author_association":"NONE","body":"\n\n\n\n___\n*[loggingservice.go, line 127 at r5](https://reviewable.io/reviews/pendo-io/appwrap/12#-LU6N555A24jePHLb-Sz:-LU6aUQy1fgQsPdfUhxV:bilktn1) ([raw file](https://github.com/pendo-io/appwrap/blob/d2e6b2b3c60640ed14223bfce8ad11d932cc9bf4/loggingservice.go#L127)):*\n<details><summary><i>Previously, jshore1296 wrote…</i></summary><blockquote>\n\nCould this be a private method?  I like having NewAppengineLoggingService() call it for me, and can't think of a reason someone outside of appwrap would need to worry about it.\n\nAlso, I just mistakenly double-called it!\n</blockquote></details>\n\nYes, that's a good point.  Most of this code was build in googlesvcs before moving it to app wrap, and this function was one of the core reasons for doing that.  It should be private.  Thanks!\n\n\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"JamWils"}}