{"action":"opened","number":4,"pull_request":{"url":"https://api.github.com/repos/ArkEcosystem/ledger/pulls/4","id":217481899,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDgxODk5","html_url":"https://github.com/ArkEcosystem/ledger/pull/4","diff_url":"https://github.com/ArkEcosystem/ledger/pull/4.diff","patch_url":"https://github.com/ArkEcosystem/ledger/pull/4.patch","issue_url":"https://api.github.com/repos/ArkEcosystem/ledger/issues/4","number":4,"state":"open","locked":false,"title":"feat: message signing","user":{"login":"supaiku0","id":1311798,"node_id":"MDQ6VXNlcjEzMTE3OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1311798?v=4","gravatar_id":"","url":"https://api.github.com/users/supaiku0","html_url":"https://github.com/supaiku0","followers_url":"https://api.github.com/users/supaiku0/followers","following_url":"https://api.github.com/users/supaiku0/following{/other_user}","gists_url":"https://api.github.com/users/supaiku0/gists{/gist_id}","starred_url":"https://api.github.com/users/supaiku0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supaiku0/subscriptions","organizations_url":"https://api.github.com/users/supaiku0/orgs","repos_url":"https://api.github.com/users/supaiku0/repos","events_url":"https://api.github.com/users/supaiku0/events{/privacy}","received_events_url":"https://api.github.com/users/supaiku0/received_events","type":"User","site_admin":false},"body":"Allows to sign messages with the instruction code `0x08`.\r\n\r\nExample with message `Lorem ipsum`:\r\n```\r\nHID => e008804020058000002c800000018000000000000000000000004c6f72656d20697073756d\r\nHID <= 30440220525d9b1998d3446d49a619f25f9a3c7cb8ff4e47957d2cd57b1eeee53a7875c902201366e8f146e0aa65d611c871a968eea79a74472dda90f5f8aba379ff4f2b75ef9000\r\n```\r\nIf it's a longer message which can't be fully displayed, the text will do a \"roundtrip\" like when signing a tx.\r\n\r\nThis https://github.com/ArkEcosystem/desktop-wallet/blob/master/LedgerArk.js#L108 should theoretically work now, but I haven't been able to test it since some older dependency refuses to compile on my machine. ","created_at":"2018-09-22T22:34:26Z","updated_at":"2018-09-22T22:34:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArkEcosystem/ledger/pulls/4/commits","review_comments_url":"https://api.github.com/repos/ArkEcosystem/ledger/pulls/4/comments","review_comment_url":"https://api.github.com/repos/ArkEcosystem/ledger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArkEcosystem/ledger/issues/4/comments","statuses_url":"https://api.github.com/repos/ArkEcosystem/ledger/statuses/f621abc893eb033332b4852c7349781e3f69c462","head":{"label":"supaiku0:message-signing","ref":"message-signing","sha":"f621abc893eb033332b4852c7349781e3f69c462","user":{"login":"supaiku0","id":1311798,"node_id":"MDQ6VXNlcjEzMTE3OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1311798?v=4","gravatar_id":"","url":"https://api.github.com/users/supaiku0","html_url":"https://github.com/supaiku0","followers_url":"https://api.github.com/users/supaiku0/followers","following_url":"https://api.github.com/users/supaiku0/following{/other_user}","gists_url":"https://api.github.com/users/supaiku0/gists{/gist_id}","starred_url":"https://api.github.com/users/supaiku0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supaiku0/subscriptions","organizations_url":"https://api.github.com/users/supaiku0/orgs","repos_url":"https://api.github.com/users/supaiku0/repos","events_url":"https://api.github.com/users/supaiku0/events{/privacy}","received_events_url":"https://api.github.com/users/supaiku0/received_events","type":"User","site_admin":false},"repo":{"id":149634469,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2MzQ0Njk=","name":"ledger","full_name":"supaiku0/ledger","private":false,"owner":{"login":"supaiku0","id":1311798,"node_id":"MDQ6VXNlcjEzMTE3OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1311798?v=4","gravatar_id":"","url":"https://api.github.com/users/supaiku0","html_url":"https://github.com/supaiku0","followers_url":"https://api.github.com/users/supaiku0/followers","following_url":"https://api.github.com/users/supaiku0/following{/other_user}","gists_url":"https://api.github.com/users/supaiku0/gists{/gist_id}","starred_url":"https://api.github.com/users/supaiku0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supaiku0/subscriptions","organizations_url":"https://api.github.com/users/supaiku0/orgs","repos_url":"https://api.github.com/users/supaiku0/repos","events_url":"https://api.github.com/users/supaiku0/events{/privacy}","received_events_url":"https://api.github.com/users/supaiku0/received_events","type":"User","site_admin":false},"html_url":"https://github.com/supaiku0/ledger","description":"Ledger App for Nano S and Nano Blue","fork":true,"url":"https://api.github.com/repos/supaiku0/ledger","forks_url":"https://api.github.com/repos/supaiku0/ledger/forks","keys_url":"https://api.github.com/repos/supaiku0/ledger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/supaiku0/ledger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/supaiku0/ledger/teams","hooks_url":"https://api.github.com/repos/supaiku0/ledger/hooks","issue_events_url":"https://api.github.com/repos/supaiku0/ledger/issues/events{/number}","events_url":"https://api.github.com/repos/supaiku0/ledger/events","assignees_url":"https://api.github.com/repos/supaiku0/ledger/assignees{/user}","branches_url":"https://api.github.com/repos/supaiku0/ledger/branches{/branch}","tags_url":"https://api.github.com/repos/supaiku0/ledger/tags","blobs_url":"https://api.github.com/repos/supaiku0/ledger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/supaiku0/ledger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/supaiku0/ledger/git/refs{/sha}","trees_url":"https://api.github.com/repos/supaiku0/ledger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/supaiku0/ledger/statuses/{sha}","languages_url":"https://api.github.com/repos/supaiku0/ledger/languages","stargazers_url":"https://api.github.com/repos/supaiku0/ledger/stargazers","contributors_url":"https://api.github.com/repos/supaiku0/ledger/contributors","subscribers_url":"https://api.github.com/repos/supaiku0/ledger/subscribers","subscription_url":"https://api.github.com/repos/supaiku0/ledger/subscription","commits_url":"https://api.github.com/repos/supaiku0/ledger/commits{/sha}","git_commits_url":"https://api.github.com/repos/supaiku0/ledger/git/commits{/sha}","comments_url":"https://api.github.com/repos/supaiku0/ledger/comments{/number}","issue_comment_url":"https://api.github.com/repos/supaiku0/ledger/issues/comments{/number}","contents_url":"https://api.github.com/repos/supaiku0/ledger/contents/{+path}","compare_url":"https://api.github.com/repos/supaiku0/ledger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/supaiku0/ledger/merges","archive_url":"https://api.github.com/repos/supaiku0/ledger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/supaiku0/ledger/downloads","issues_url":"https://api.github.com/repos/supaiku0/ledger/issues{/number}","pulls_url":"https://api.github.com/repos/supaiku0/ledger/pulls{/number}","milestones_url":"https://api.github.com/repos/supaiku0/ledger/milestones{/number}","notifications_url":"https://api.github.com/repos/supaiku0/ledger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/supaiku0/ledger/labels{/name}","releases_url":"https://api.github.com/repos/supaiku0/ledger/releases{/id}","deployments_url":"https://api.github.com/repos/supaiku0/ledger/deployments","created_at":"2018-09-20T15:54:46Z","updated_at":"2018-09-20T15:54:48Z","pushed_at":"2018-09-22T21:50:53Z","git_url":"git://github.com/supaiku0/ledger.git","ssh_url":"git@github.com:supaiku0/ledger.git","clone_url":"https://github.com/supaiku0/ledger.git","svn_url":"https://github.com/supaiku0/ledger","homepage":null,"size":53,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ArkEcosystem:master","ref":"master","sha":"4a986f25d0f6817683351647553efedb13b2b6c6","user":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":95088404,"node_id":"MDEwOlJlcG9zaXRvcnk5NTA4ODQwNA==","name":"ledger","full_name":"ArkEcosystem/ledger","private":false,"owner":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ArkEcosystem/ledger","description":"Ledger App for Nano S and Nano Blue","fork":false,"url":"https://api.github.com/repos/ArkEcosystem/ledger","forks_url":"https://api.github.com/repos/ArkEcosystem/ledger/forks","keys_url":"https://api.github.com/repos/ArkEcosystem/ledger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArkEcosystem/ledger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArkEcosystem/ledger/teams","hooks_url":"https://api.github.com/repos/ArkEcosystem/ledger/hooks","issue_events_url":"https://api.github.com/repos/ArkEcosystem/ledger/issues/events{/number}","events_url":"https://api.github.com/repos/ArkEcosystem/ledger/events","assignees_url":"https://api.github.com/repos/ArkEcosystem/ledger/assignees{/user}","branches_url":"https://api.github.com/repos/ArkEcosystem/ledger/branches{/branch}","tags_url":"https://api.github.com/repos/ArkEcosystem/ledger/tags","blobs_url":"https://api.github.com/repos/ArkEcosystem/ledger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArkEcosystem/ledger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArkEcosystem/ledger/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArkEcosystem/ledger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArkEcosystem/ledger/statuses/{sha}","languages_url":"https://api.github.com/repos/ArkEcosystem/ledger/languages","stargazers_url":"https://api.github.com/repos/ArkEcosystem/ledger/stargazers","contributors_url":"https://api.github.com/repos/ArkEcosystem/ledger/contributors","subscribers_url":"https://api.github.com/repos/ArkEcosystem/ledger/subscribers","subscription_url":"https://api.github.com/repos/ArkEcosystem/ledger/subscription","commits_url":"https://api.github.com/repos/ArkEcosystem/ledger/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArkEcosystem/ledger/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArkEcosystem/ledger/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArkEcosystem/ledger/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArkEcosystem/ledger/contents/{+path}","compare_url":"https://api.github.com/repos/ArkEcosystem/ledger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArkEcosystem/ledger/merges","archive_url":"https://api.github.com/repos/ArkEcosystem/ledger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArkEcosystem/ledger/downloads","issues_url":"https://api.github.com/repos/ArkEcosystem/ledger/issues{/number}","pulls_url":"https://api.github.com/repos/ArkEcosystem/ledger/pulls{/number}","milestones_url":"https://api.github.com/repos/ArkEcosystem/ledger/milestones{/number}","notifications_url":"https://api.github.com/repos/ArkEcosystem/ledger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArkEcosystem/ledger/labels{/name}","releases_url":"https://api.github.com/repos/ArkEcosystem/ledger/releases{/id}","deployments_url":"https://api.github.com/repos/ArkEcosystem/ledger/deployments","created_at":"2017-06-22T07:41:22Z","updated_at":"2018-09-22T08:49:16Z","pushed_at":"2018-09-22T08:49:11Z","git_url":"git://github.com/ArkEcosystem/ledger.git","ssh_url":"git@github.com:ArkEcosystem/ledger.git","clone_url":"https://github.com/ArkEcosystem/ledger.git","svn_url":"https://github.com/ArkEcosystem/ledger","homepage":null,"size":54,"stargazers_count":11,"watchers_count":11,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":14,"open_issues":2,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArkEcosystem/ledger/pulls/4"},"html":{"href":"https://github.com/ArkEcosystem/ledger/pull/4"},"issue":{"href":"https://api.github.com/repos/ArkEcosystem/ledger/issues/4"},"comments":{"href":"https://api.github.com/repos/ArkEcosystem/ledger/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/ArkEcosystem/ledger/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/ArkEcosystem/ledger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArkEcosystem/ledger/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/ArkEcosystem/ledger/statuses/f621abc893eb033332b4852c7349781e3f69c462"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":294,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"supaiku0"}}