{"action":"closed","number":285,"pull_request":{"url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/285","id":208572295,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NTcyMjk1","html_url":"https://github.com/awslabs/cfn-python-lint/pull/285","diff_url":"https://github.com/awslabs/cfn-python-lint/pull/285.diff","patch_url":"https://github.com/awslabs/cfn-python-lint/pull/285.patch","issue_url":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/285","number":285,"state":"closed","locked":false,"title":"Add linting of CNAMEs","user":{"login":"fatbasstard","id":35613489,"node_id":"MDQ6VXNlcjM1NjEzNDg5","avatar_url":"https://avatars2.githubusercontent.com/u/35613489?v=4","gravatar_id":"","url":"https://api.github.com/users/fatbasstard","html_url":"https://github.com/fatbasstard","followers_url":"https://api.github.com/users/fatbasstard/followers","following_url":"https://api.github.com/users/fatbasstard/following{/other_user}","gists_url":"https://api.github.com/users/fatbasstard/gists{/gist_id}","starred_url":"https://api.github.com/users/fatbasstard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatbasstard/subscriptions","organizations_url":"https://api.github.com/users/fatbasstard/orgs","repos_url":"https://api.github.com/users/fatbasstard/repos","events_url":"https://api.github.com/users/fatbasstard/events{/privacy}","received_events_url":"https://api.github.com/users/fatbasstard/received_events","type":"User","site_admin":false},"body":"*Issue https://github.com/awslabs/cfn-python-lint/issues/94*\r\n\r\nAdded basic linting of CNAME records:\r\n\r\n* Only 1 value allowed (https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/resource-record-sets-values-basic.html#rrsets-values-basic-value)\r\n* Simple domain name value check for the value. \r\n\r\nAlong the way:\r\n\r\n* [Since Aliases can be used for everything except NS and SOA records](https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/resource-record-sets-values-alias.html#rrsets-values-alias-type), moved the `AliasTarget` check to the central RecordSet check\r\n* All RecordSets are now checked on being a dict (a.k.a. instrinsic function logic), this complexity is not checked (yet)\r\n* Removed all the full Path information from the error messages for clarity  \r\n\r\nBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.\r\n","created_at":"2018-08-15T14:05:57Z","updated_at":"2018-08-15T14:38:32Z","closed_at":"2018-08-15T14:38:32Z","merged_at":"2018-08-15T14:38:32Z","merge_commit_sha":"e62d5fc67b8f46b45f1466d03c35bd8cae686963","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/285/commits","review_comments_url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/285/comments","review_comment_url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/285/comments","statuses_url":"https://api.github.com/repos/awslabs/cfn-python-lint/statuses/94541e888dd6b4e5debc2e908261271e4479302a","head":{"label":"fatbasstard:route53-records","ref":"route53-records","sha":"94541e888dd6b4e5debc2e908261271e4479302a","user":{"login":"fatbasstard","id":35613489,"node_id":"MDQ6VXNlcjM1NjEzNDg5","avatar_url":"https://avatars2.githubusercontent.com/u/35613489?v=4","gravatar_id":"","url":"https://api.github.com/users/fatbasstard","html_url":"https://github.com/fatbasstard","followers_url":"https://api.github.com/users/fatbasstard/followers","following_url":"https://api.github.com/users/fatbasstard/following{/other_user}","gists_url":"https://api.github.com/users/fatbasstard/gists{/gist_id}","starred_url":"https://api.github.com/users/fatbasstard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatbasstard/subscriptions","organizations_url":"https://api.github.com/users/fatbasstard/orgs","repos_url":"https://api.github.com/users/fatbasstard/repos","events_url":"https://api.github.com/users/fatbasstard/events{/privacy}","received_events_url":"https://api.github.com/users/fatbasstard/received_events","type":"User","site_admin":false},"repo":{"id":131030648,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEwMzA2NDg=","name":"cfn-python-lint","full_name":"fatbasstard/cfn-python-lint","owner":{"login":"fatbasstard","id":35613489,"node_id":"MDQ6VXNlcjM1NjEzNDg5","avatar_url":"https://avatars2.githubusercontent.com/u/35613489?v=4","gravatar_id":"","url":"https://api.github.com/users/fatbasstard","html_url":"https://github.com/fatbasstard","followers_url":"https://api.github.com/users/fatbasstard/followers","following_url":"https://api.github.com/users/fatbasstard/following{/other_user}","gists_url":"https://api.github.com/users/fatbasstard/gists{/gist_id}","starred_url":"https://api.github.com/users/fatbasstard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatbasstard/subscriptions","organizations_url":"https://api.github.com/users/fatbasstard/orgs","repos_url":"https://api.github.com/users/fatbasstard/repos","events_url":"https://api.github.com/users/fatbasstard/events{/privacy}","received_events_url":"https://api.github.com/users/fatbasstard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fatbasstard/cfn-python-lint","description":"CloudFormation Linter","fork":true,"url":"https://api.github.com/repos/fatbasstard/cfn-python-lint","forks_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/forks","keys_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/teams","hooks_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/hooks","issue_events_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/issues/events{/number}","events_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/events","assignees_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/assignees{/user}","branches_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/branches{/branch}","tags_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/tags","blobs_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/git/refs{/sha}","trees_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/statuses/{sha}","languages_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/languages","stargazers_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/stargazers","contributors_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/contributors","subscribers_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/subscribers","subscription_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/subscription","commits_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/commits{/sha}","git_commits_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/git/commits{/sha}","comments_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/comments{/number}","issue_comment_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/issues/comments{/number}","contents_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/contents/{+path}","compare_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/merges","archive_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/downloads","issues_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/issues{/number}","pulls_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/pulls{/number}","milestones_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/milestones{/number}","notifications_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/labels{/name}","releases_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/releases{/id}","deployments_url":"https://api.github.com/repos/fatbasstard/cfn-python-lint/deployments","created_at":"2018-04-25T15:56:49Z","updated_at":"2018-08-10T06:45:13Z","pushed_at":"2018-08-15T14:18:28Z","git_url":"git://github.com/fatbasstard/cfn-python-lint.git","ssh_url":"git@github.com:fatbasstard/cfn-python-lint.git","clone_url":"https://github.com/fatbasstard/cfn-python-lint.git","svn_url":"https://github.com/fatbasstard/cfn-python-lint","homepage":null,"size":1252,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"9a8468ae9ed1f34a3850be981ec0484fbf42dbeb","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":129005655,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkwMDU2NTU=","name":"cfn-python-lint","full_name":"awslabs/cfn-python-lint","owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/cfn-python-lint","description":"CloudFormation Linter","fork":false,"url":"https://api.github.com/repos/awslabs/cfn-python-lint","forks_url":"https://api.github.com/repos/awslabs/cfn-python-lint/forks","keys_url":"https://api.github.com/repos/awslabs/cfn-python-lint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/cfn-python-lint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/cfn-python-lint/teams","hooks_url":"https://api.github.com/repos/awslabs/cfn-python-lint/hooks","issue_events_url":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/cfn-python-lint/events","assignees_url":"https://api.github.com/repos/awslabs/cfn-python-lint/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/cfn-python-lint/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/cfn-python-lint/tags","blobs_url":"https://api.github.com/repos/awslabs/cfn-python-lint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/cfn-python-lint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/cfn-python-lint/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/cfn-python-lint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/cfn-python-lint/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/cfn-python-lint/languages","stargazers_url":"https://api.github.com/repos/awslabs/cfn-python-lint/stargazers","contributors_url":"https://api.github.com/repos/awslabs/cfn-python-lint/contributors","subscribers_url":"https://api.github.com/repos/awslabs/cfn-python-lint/subscribers","subscription_url":"https://api.github.com/repos/awslabs/cfn-python-lint/subscription","commits_url":"https://api.github.com/repos/awslabs/cfn-python-lint/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/cfn-python-lint/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/cfn-python-lint/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/cfn-python-lint/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/cfn-python-lint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/cfn-python-lint/merges","archive_url":"https://api.github.com/repos/awslabs/cfn-python-lint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/cfn-python-lint/downloads","issues_url":"https://api.github.com/repos/awslabs/cfn-python-lint/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/cfn-python-lint/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/cfn-python-lint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/cfn-python-lint/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/cfn-python-lint/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/cfn-python-lint/deployments","created_at":"2018-04-10T23:16:16Z","updated_at":"2018-08-14T14:09:30Z","pushed_at":"2018-08-15T14:38:32Z","git_url":"git://github.com/awslabs/cfn-python-lint.git","ssh_url":"git@github.com:awslabs/cfn-python-lint.git","clone_url":"https://github.com/awslabs/cfn-python-lint.git","svn_url":"https://github.com/awslabs/cfn-python-lint","homepage":null,"size":1198,"stargazers_count":183,"watchers_count":183,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":42,"open_issues":28,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/285"},"html":{"href":"https://github.com/awslabs/cfn-python-lint/pull/285"},"issue":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/285"},"comments":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/issues/285/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/285/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/pulls/285/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/cfn-python-lint/statuses/94541e888dd6b4e5debc2e908261271e4479302a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cmmeyer","id":5632125,"node_id":"MDQ6VXNlcjU2MzIxMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/5632125?v=4","gravatar_id":"","url":"https://api.github.com/users/cmmeyer","html_url":"https://github.com/cmmeyer","followers_url":"https://api.github.com/users/cmmeyer/followers","following_url":"https://api.github.com/users/cmmeyer/following{/other_user}","gists_url":"https://api.github.com/users/cmmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/cmmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmmeyer/subscriptions","organizations_url":"https://api.github.com/users/cmmeyer/orgs","repos_url":"https://api.github.com/users/cmmeyer/repos","events_url":"https://api.github.com/users/cmmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/cmmeyer/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":117,"deletions":61,"changed_files":4}}
{"actor":{"display_login":"cmmeyer"}}