{"action":"created","comment":{"url":"https://api.github.com/repos/go-hep/hep/pulls/comments/206111687","pull_request_review_id":141506880,"id":206111687,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjExMTY4Nw==","diff_hunk":"@@ -61,6 +61,20 @@ func (tsi *tstreamerInfo) Elements() []StreamerElement {\n \treturn tsi.elems\n }\n \n+func (tsi *tstreamerInfo) MarshalROOT(w *WBuffer) (int, error) {\n+\tif w.err != nil {\n+\t\treturn 0, w.err\n+\t}\n+\tpos := w.Pos()\n+\tw.WriteVersion(tsi.rvers)\n+\ttsi.named.MarshalROOT(w)\n+\tw.WriteU32(tsi.chksum)\n+\tw.WriteI32(tsi.clsver)\n+\tw.WriteObjectAny(tsi.objarr)","path":"rootio/streamers.go","position":13,"original_position":13,"commit_id":"21803fd4b855088fdffbe58f52e1d993299e124a","original_commit_id":"21803fd4b855088fdffbe58f52e1d993299e124a","user":{"login":"sbinet","id":1070920,"node_id":"MDQ6VXNlcjEwNzA5MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1070920?v=4","gravatar_id":"","url":"https://api.github.com/users/sbinet","html_url":"https://github.com/sbinet","followers_url":"https://api.github.com/users/sbinet/followers","following_url":"https://api.github.com/users/sbinet/following{/other_user}","gists_url":"https://api.github.com/users/sbinet/gists{/gist_id}","starred_url":"https://api.github.com/users/sbinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbinet/subscriptions","organizations_url":"https://api.github.com/users/sbinet/orgs","repos_url":"https://api.github.com/users/sbinet/repos","events_url":"https://api.github.com/users/sbinet/events{/privacy}","received_events_url":"https://api.github.com/users/sbinet/received_events","type":"User","site_admin":false},"body":"it's a bit more complicated than that.\r\n`tsi.objarr.arr` is `nil`-ed in `UnmarshalROOT` as it's duplicate informations with the `tsi.elems` slice (which is itself a more convenient way to expose informations to users.)\r\n\r\nif we don't re-create + populate the `tsi.objarr.arr` field with meaningful informations, the `read-write-read` round trip test will just fail.","created_at":"2018-07-30T12:19:46Z","updated_at":"2018-07-30T12:19:51Z","html_url":"https://github.com/go-hep/hep/pull/322#discussion_r206111687","pull_request_url":"https://api.github.com/repos/go-hep/hep/pulls/322","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/go-hep/hep/pulls/comments/206111687"},"html":{"href":"https://github.com/go-hep/hep/pull/322#discussion_r206111687"},"pull_request":{"href":"https://api.github.com/repos/go-hep/hep/pulls/322"}}},"pull_request":{"url":"https://api.github.com/repos/go-hep/hep/pulls/322","id":204772861,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NzcyODYx","html_url":"https://github.com/go-hep/hep/pull/322","diff_url":"https://github.com/go-hep/hep/pull/322.diff","patch_url":"https://github.com/go-hep/hep/pull/322.patch","issue_url":"https://api.github.com/repos/go-hep/hep/issues/322","number":322,"state":"open","locked":false,"title":"rootio: ROOTMarshaler for the streamers ","user":{"login":"maloft","id":38098030,"node_id":"MDQ6VXNlcjM4MDk4MDMw","avatar_url":"https://avatars1.githubusercontent.com/u/38098030?v=4","gravatar_id":"","url":"https://api.github.com/users/maloft","html_url":"https://github.com/maloft","followers_url":"https://api.github.com/users/maloft/followers","following_url":"https://api.github.com/users/maloft/following{/other_user}","gists_url":"https://api.github.com/users/maloft/gists{/gist_id}","starred_url":"https://api.github.com/users/maloft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maloft/subscriptions","organizations_url":"https://api.github.com/users/maloft/orgs","repos_url":"https://api.github.com/users/maloft/repos","events_url":"https://api.github.com/users/maloft/events{/privacy}","received_events_url":"https://api.github.com/users/maloft/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-30T11:22:48Z","updated_at":"2018-07-30T12:19:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aed638fd6e902c3925ee2195714ed53d4936b1f2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/go-hep/hep/pulls/322/commits","review_comments_url":"https://api.github.com/repos/go-hep/hep/pulls/322/comments","review_comment_url":"https://api.github.com/repos/go-hep/hep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-hep/hep/issues/322/comments","statuses_url":"https://api.github.com/repos/go-hep/hep/statuses/21803fd4b855088fdffbe58f52e1d993299e124a","head":{"label":"maloft:master","ref":"master","sha":"21803fd4b855088fdffbe58f52e1d993299e124a","user":{"login":"maloft","id":38098030,"node_id":"MDQ6VXNlcjM4MDk4MDMw","avatar_url":"https://avatars1.githubusercontent.com/u/38098030?v=4","gravatar_id":"","url":"https://api.github.com/users/maloft","html_url":"https://github.com/maloft","followers_url":"https://api.github.com/users/maloft/followers","following_url":"https://api.github.com/users/maloft/following{/other_user}","gists_url":"https://api.github.com/users/maloft/gists{/gist_id}","starred_url":"https://api.github.com/users/maloft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maloft/subscriptions","organizations_url":"https://api.github.com/users/maloft/orgs","repos_url":"https://api.github.com/users/maloft/repos","events_url":"https://api.github.com/users/maloft/events{/privacy}","received_events_url":"https://api.github.com/users/maloft/received_events","type":"User","site_admin":false},"repo":{"id":129216814,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkyMTY4MTQ=","name":"hep","full_name":"maloft/hep","owner":{"login":"maloft","id":38098030,"node_id":"MDQ6VXNlcjM4MDk4MDMw","avatar_url":"https://avatars1.githubusercontent.com/u/38098030?v=4","gravatar_id":"","url":"https://api.github.com/users/maloft","html_url":"https://github.com/maloft","followers_url":"https://api.github.com/users/maloft/followers","following_url":"https://api.github.com/users/maloft/following{/other_user}","gists_url":"https://api.github.com/users/maloft/gists{/gist_id}","starred_url":"https://api.github.com/users/maloft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maloft/subscriptions","organizations_url":"https://api.github.com/users/maloft/orgs","repos_url":"https://api.github.com/users/maloft/repos","events_url":"https://api.github.com/users/maloft/events{/privacy}","received_events_url":"https://api.github.com/users/maloft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maloft/hep","description":"hep is the mono repository holding all of go-hep.org/x/hep packages and tools","fork":true,"url":"https://api.github.com/repos/maloft/hep","forks_url":"https://api.github.com/repos/maloft/hep/forks","keys_url":"https://api.github.com/repos/maloft/hep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maloft/hep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maloft/hep/teams","hooks_url":"https://api.github.com/repos/maloft/hep/hooks","issue_events_url":"https://api.github.com/repos/maloft/hep/issues/events{/number}","events_url":"https://api.github.com/repos/maloft/hep/events","assignees_url":"https://api.github.com/repos/maloft/hep/assignees{/user}","branches_url":"https://api.github.com/repos/maloft/hep/branches{/branch}","tags_url":"https://api.github.com/repos/maloft/hep/tags","blobs_url":"https://api.github.com/repos/maloft/hep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maloft/hep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maloft/hep/git/refs{/sha}","trees_url":"https://api.github.com/repos/maloft/hep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maloft/hep/statuses/{sha}","languages_url":"https://api.github.com/repos/maloft/hep/languages","stargazers_url":"https://api.github.com/repos/maloft/hep/stargazers","contributors_url":"https://api.github.com/repos/maloft/hep/contributors","subscribers_url":"https://api.github.com/repos/maloft/hep/subscribers","subscription_url":"https://api.github.com/repos/maloft/hep/subscription","commits_url":"https://api.github.com/repos/maloft/hep/commits{/sha}","git_commits_url":"https://api.github.com/repos/maloft/hep/git/commits{/sha}","comments_url":"https://api.github.com/repos/maloft/hep/comments{/number}","issue_comment_url":"https://api.github.com/repos/maloft/hep/issues/comments{/number}","contents_url":"https://api.github.com/repos/maloft/hep/contents/{+path}","compare_url":"https://api.github.com/repos/maloft/hep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maloft/hep/merges","archive_url":"https://api.github.com/repos/maloft/hep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maloft/hep/downloads","issues_url":"https://api.github.com/repos/maloft/hep/issues{/number}","pulls_url":"https://api.github.com/repos/maloft/hep/pulls{/number}","milestones_url":"https://api.github.com/repos/maloft/hep/milestones{/number}","notifications_url":"https://api.github.com/repos/maloft/hep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maloft/hep/labels{/name}","releases_url":"https://api.github.com/repos/maloft/hep/releases{/id}","deployments_url":"https://api.github.com/repos/maloft/hep/deployments","created_at":"2018-04-12T08:14:42Z","updated_at":"2018-07-30T11:18:58Z","pushed_at":"2018-07-30T11:18:56Z","git_url":"git://github.com/maloft/hep.git","ssh_url":"git@github.com:maloft/hep.git","clone_url":"https://github.com/maloft/hep.git","svn_url":"https://github.com/maloft/hep","homepage":"https://go-hep.org","size":9722,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"go-hep:master","ref":"master","sha":"ddac9d54c2a801d7e8830c18acab18b6e46f4d69","user":{"login":"go-hep","id":2822440,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MjI0NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/2822440?v=4","gravatar_id":"","url":"https://api.github.com/users/go-hep","html_url":"https://github.com/go-hep","followers_url":"https://api.github.com/users/go-hep/followers","following_url":"https://api.github.com/users/go-hep/following{/other_user}","gists_url":"https://api.github.com/users/go-hep/gists{/gist_id}","starred_url":"https://api.github.com/users/go-hep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-hep/subscriptions","organizations_url":"https://api.github.com/users/go-hep/orgs","repos_url":"https://api.github.com/users/go-hep/repos","events_url":"https://api.github.com/users/go-hep/events{/privacy}","received_events_url":"https://api.github.com/users/go-hep/received_events","type":"Organization","site_admin":false},"repo":{"id":81190550,"node_id":"MDEwOlJlcG9zaXRvcnk4MTE5MDU1MA==","name":"hep","full_name":"go-hep/hep","owner":{"login":"go-hep","id":2822440,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MjI0NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/2822440?v=4","gravatar_id":"","url":"https://api.github.com/users/go-hep","html_url":"https://github.com/go-hep","followers_url":"https://api.github.com/users/go-hep/followers","following_url":"https://api.github.com/users/go-hep/following{/other_user}","gists_url":"https://api.github.com/users/go-hep/gists{/gist_id}","starred_url":"https://api.github.com/users/go-hep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-hep/subscriptions","organizations_url":"https://api.github.com/users/go-hep/orgs","repos_url":"https://api.github.com/users/go-hep/repos","events_url":"https://api.github.com/users/go-hep/events{/privacy}","received_events_url":"https://api.github.com/users/go-hep/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-hep/hep","description":"hep is the mono repository holding all of go-hep.org/x/hep packages and tools","fork":false,"url":"https://api.github.com/repos/go-hep/hep","forks_url":"https://api.github.com/repos/go-hep/hep/forks","keys_url":"https://api.github.com/repos/go-hep/hep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-hep/hep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-hep/hep/teams","hooks_url":"https://api.github.com/repos/go-hep/hep/hooks","issue_events_url":"https://api.github.com/repos/go-hep/hep/issues/events{/number}","events_url":"https://api.github.com/repos/go-hep/hep/events","assignees_url":"https://api.github.com/repos/go-hep/hep/assignees{/user}","branches_url":"https://api.github.com/repos/go-hep/hep/branches{/branch}","tags_url":"https://api.github.com/repos/go-hep/hep/tags","blobs_url":"https://api.github.com/repos/go-hep/hep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-hep/hep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-hep/hep/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-hep/hep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-hep/hep/statuses/{sha}","languages_url":"https://api.github.com/repos/go-hep/hep/languages","stargazers_url":"https://api.github.com/repos/go-hep/hep/stargazers","contributors_url":"https://api.github.com/repos/go-hep/hep/contributors","subscribers_url":"https://api.github.com/repos/go-hep/hep/subscribers","subscription_url":"https://api.github.com/repos/go-hep/hep/subscription","commits_url":"https://api.github.com/repos/go-hep/hep/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-hep/hep/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-hep/hep/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-hep/hep/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-hep/hep/contents/{+path}","compare_url":"https://api.github.com/repos/go-hep/hep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-hep/hep/merges","archive_url":"https://api.github.com/repos/go-hep/hep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-hep/hep/downloads","issues_url":"https://api.github.com/repos/go-hep/hep/issues{/number}","pulls_url":"https://api.github.com/repos/go-hep/hep/pulls{/number}","milestones_url":"https://api.github.com/repos/go-hep/hep/milestones{/number}","notifications_url":"https://api.github.com/repos/go-hep/hep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-hep/hep/labels{/name}","releases_url":"https://api.github.com/repos/go-hep/hep/releases{/id}","deployments_url":"https://api.github.com/repos/go-hep/hep/deployments","created_at":"2017-02-07T09:28:30Z","updated_at":"2018-07-30T10:51:52Z","pushed_at":"2018-07-30T11:22:49Z","git_url":"git://github.com/go-hep/hep.git","ssh_url":"git@github.com:go-hep/hep.git","clone_url":"https://github.com/go-hep/hep.git","svn_url":"https://github.com/go-hep/hep","homepage":"https://go-hep.org","size":6305,"stargazers_count":52,"watchers_count":52,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":10,"open_issues":77,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-hep/hep/pulls/322"},"html":{"href":"https://github.com/go-hep/hep/pull/322"},"issue":{"href":"https://api.github.com/repos/go-hep/hep/issues/322"},"comments":{"href":"https://api.github.com/repos/go-hep/hep/issues/322/comments"},"review_comments":{"href":"https://api.github.com/repos/go-hep/hep/pulls/322/comments"},"review_comment":{"href":"https://api.github.com/repos/go-hep/hep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-hep/hep/pulls/322/commits"},"statuses":{"href":"https://api.github.com/repos/go-hep/hep/statuses/21803fd4b855088fdffbe58f52e1d993299e124a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sbinet"}}