{"action":"created","comment":{"url":"https://api.github.com/repos/WeakAuras/WeakAuras2/pulls/comments/223122838","pull_request_review_id":162182446,"id":223122838,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzEyMjgzOA==","diff_hunk":"@@ -4072,6 +4072,84 @@ function WeakAuras.PickDisplayMultiple(id)\n   frame:PickDisplayMultiple(id);\n end\n \n+function WeakAuras.PickDisplayMultipleShift(target)\n+  if (frame.pickedDisplay) then\n+    -- get first aura selected\n+    local first;\n+    if (WeakAuras.IsPickedMultiple()) then\n+      first = tempGroup.controlledChildren[1];\n+    else\n+      first = frame.pickedDisplay;\n+    end\n+    if (first and first ~= target) then\n+      -- check that id is in same group as first\n+      local firstData = WeakAuras.GetData(first);\n+      -- in a group\n+      if (firstData.parent) then\n+        local sameGroup = false;\n+        local group = WeakAuras.GetData(firstData.parent);\n+        for index, child in pairs(group.controlledChildren) do","path":"WeakAurasOptions/WeakAurasOptions.lua","position":20,"original_position":20,"commit_id":"ecc7e00de7efd9b211af36d19e1ca80d8c4a8c92","original_commit_id":"ecc7e00de7efd9b211af36d19e1ca80d8c4a8c92","user":{"login":"mrbuds","id":189656,"node_id":"MDQ6VXNlcjE4OTY1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/189656?v=4","gravatar_id":"","url":"https://api.github.com/users/mrbuds","html_url":"https://github.com/mrbuds","followers_url":"https://api.github.com/users/mrbuds/followers","following_url":"https://api.github.com/users/mrbuds/following{/other_user}","gists_url":"https://api.github.com/users/mrbuds/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbuds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbuds/subscriptions","organizations_url":"https://api.github.com/users/mrbuds/orgs","repos_url":"https://api.github.com/users/mrbuds/repos","events_url":"https://api.github.com/users/mrbuds/events{/privacy}","received_events_url":"https://api.github.com/users/mrbuds/received_events","type":"User","site_admin":false},"body":"I could do \r\n      local firstData = WeakAuras.GetData(first);\r\n      local targetData = WeakAuras.GetData(target);\r\nand then compare firstData.parent == targetData.parent (which is more readable and concise)\r\nBut after checking both items are in the same group, i still need to iterate over the group children, so another GetData() on the parent\r\n\r\nThe way i did it save a GetData() call, i have not checked the complexity of this call, do you think their is not enough performance gain doing what i did for what we loose in readability ?","created_at":"2018-10-05T19:54:48Z","updated_at":"2018-10-05T19:54:48Z","html_url":"https://github.com/WeakAuras/WeakAuras2/pull/812#discussion_r223122838","pull_request_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/pulls/812","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/WeakAuras/WeakAuras2/pulls/comments/223122838"},"html":{"href":"https://github.com/WeakAuras/WeakAuras2/pull/812#discussion_r223122838"},"pull_request":{"href":"https://api.github.com/repos/WeakAuras/WeakAuras2/pulls/812"}},"in_reply_to_id":223087363},"pull_request":{"url":"https://api.github.com/repos/WeakAuras/WeakAuras2/pulls/812","id":220227602,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMjI3NjAy","html_url":"https://github.com/WeakAuras/WeakAuras2/pull/812","diff_url":"https://github.com/WeakAuras/WeakAuras2/pull/812.diff","patch_url":"https://github.com/WeakAuras/WeakAuras2/pull/812.patch","issue_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/issues/812","number":812,"state":"open","locked":false,"title":"multi-selection of auras with shift modifier","user":{"login":"mrbuds","id":189656,"node_id":"MDQ6VXNlcjE4OTY1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/189656?v=4","gravatar_id":"","url":"https://api.github.com/users/mrbuds","html_url":"https://github.com/mrbuds","followers_url":"https://api.github.com/users/mrbuds/followers","following_url":"https://api.github.com/users/mrbuds/following{/other_user}","gists_url":"https://api.github.com/users/mrbuds/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbuds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbuds/subscriptions","organizations_url":"https://api.github.com/users/mrbuds/orgs","repos_url":"https://api.github.com/users/mrbuds/repos","events_url":"https://api.github.com/users/mrbuds/events{/privacy}","received_events_url":"https://api.github.com/users/mrbuds/received_events","type":"User","site_admin":false},"body":"It works only if the first aura selected and the second are both in the same group or are top level.\r\n\r\nimplement #810 ","created_at":"2018-10-04T01:50:41Z","updated_at":"2018-10-05T19:54:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e64dcc332f4a1e10a45f6859574076e343e57a19","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1001627770,"node_id":"MDU6TGFiZWwxMDAxNjI3Nzcw","url":"https://api.github.com/repos/WeakAuras/WeakAuras2/labels/%F0%9F%8E%A8%20Enhancement","name":"🎨 Enhancement","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/pulls/812/commits","review_comments_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/pulls/812/comments","review_comment_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/issues/812/comments","statuses_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/statuses/ecc7e00de7efd9b211af36d19e1ca80d8c4a8c92","head":{"label":"mrbuds:smallfix","ref":"smallfix","sha":"ecc7e00de7efd9b211af36d19e1ca80d8c4a8c92","user":{"login":"mrbuds","id":189656,"node_id":"MDQ6VXNlcjE4OTY1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/189656?v=4","gravatar_id":"","url":"https://api.github.com/users/mrbuds","html_url":"https://github.com/mrbuds","followers_url":"https://api.github.com/users/mrbuds/followers","following_url":"https://api.github.com/users/mrbuds/following{/other_user}","gists_url":"https://api.github.com/users/mrbuds/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbuds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbuds/subscriptions","organizations_url":"https://api.github.com/users/mrbuds/orgs","repos_url":"https://api.github.com/users/mrbuds/repos","events_url":"https://api.github.com/users/mrbuds/events{/privacy}","received_events_url":"https://api.github.com/users/mrbuds/received_events","type":"User","site_admin":false},"repo":{"id":141358023,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzNTgwMjM=","name":"WeakAuras2","full_name":"mrbuds/WeakAuras2","private":false,"owner":{"login":"mrbuds","id":189656,"node_id":"MDQ6VXNlcjE4OTY1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/189656?v=4","gravatar_id":"","url":"https://api.github.com/users/mrbuds","html_url":"https://github.com/mrbuds","followers_url":"https://api.github.com/users/mrbuds/followers","following_url":"https://api.github.com/users/mrbuds/following{/other_user}","gists_url":"https://api.github.com/users/mrbuds/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbuds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbuds/subscriptions","organizations_url":"https://api.github.com/users/mrbuds/orgs","repos_url":"https://api.github.com/users/mrbuds/repos","events_url":"https://api.github.com/users/mrbuds/events{/privacy}","received_events_url":"https://api.github.com/users/mrbuds/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mrbuds/WeakAuras2","description":"World of Warcraft addon that provides a powerful and flexible framework to display highly customizable graphics on your screen.","fork":true,"url":"https://api.github.com/repos/mrbuds/WeakAuras2","forks_url":"https://api.github.com/repos/mrbuds/WeakAuras2/forks","keys_url":"https://api.github.com/repos/mrbuds/WeakAuras2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrbuds/WeakAuras2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrbuds/WeakAuras2/teams","hooks_url":"https://api.github.com/repos/mrbuds/WeakAuras2/hooks","issue_events_url":"https://api.github.com/repos/mrbuds/WeakAuras2/issues/events{/number}","events_url":"https://api.github.com/repos/mrbuds/WeakAuras2/events","assignees_url":"https://api.github.com/repos/mrbuds/WeakAuras2/assignees{/user}","branches_url":"https://api.github.com/repos/mrbuds/WeakAuras2/branches{/branch}","tags_url":"https://api.github.com/repos/mrbuds/WeakAuras2/tags","blobs_url":"https://api.github.com/repos/mrbuds/WeakAuras2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrbuds/WeakAuras2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrbuds/WeakAuras2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrbuds/WeakAuras2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrbuds/WeakAuras2/statuses/{sha}","languages_url":"https://api.github.com/repos/mrbuds/WeakAuras2/languages","stargazers_url":"https://api.github.com/repos/mrbuds/WeakAuras2/stargazers","contributors_url":"https://api.github.com/repos/mrbuds/WeakAuras2/contributors","subscribers_url":"https://api.github.com/repos/mrbuds/WeakAuras2/subscribers","subscription_url":"https://api.github.com/repos/mrbuds/WeakAuras2/subscription","commits_url":"https://api.github.com/repos/mrbuds/WeakAuras2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrbuds/WeakAuras2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrbuds/WeakAuras2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrbuds/WeakAuras2/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrbuds/WeakAuras2/contents/{+path}","compare_url":"https://api.github.com/repos/mrbuds/WeakAuras2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrbuds/WeakAuras2/merges","archive_url":"https://api.github.com/repos/mrbuds/WeakAuras2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrbuds/WeakAuras2/downloads","issues_url":"https://api.github.com/repos/mrbuds/WeakAuras2/issues{/number}","pulls_url":"https://api.github.com/repos/mrbuds/WeakAuras2/pulls{/number}","milestones_url":"https://api.github.com/repos/mrbuds/WeakAuras2/milestones{/number}","notifications_url":"https://api.github.com/repos/mrbuds/WeakAuras2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrbuds/WeakAuras2/labels{/name}","releases_url":"https://api.github.com/repos/mrbuds/WeakAuras2/releases{/id}","deployments_url":"https://api.github.com/repos/mrbuds/WeakAuras2/deployments","created_at":"2018-07-17T23:54:26Z","updated_at":"2018-10-02T11:44:09Z","pushed_at":"2018-10-05T17:09:36Z","git_url":"git://github.com/mrbuds/WeakAuras2.git","ssh_url":"git@github.com:mrbuds/WeakAuras2.git","clone_url":"https://github.com/mrbuds/WeakAuras2.git","svn_url":"https://github.com/mrbuds/WeakAuras2","homepage":"https://weakauras.wtf","size":17276,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WeakAuras:master","ref":"master","sha":"8556e7209c2496e5682448615ea783567600bdda","user":{"login":"WeakAuras","id":9121773,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMjE3NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/9121773?v=4","gravatar_id":"","url":"https://api.github.com/users/WeakAuras","html_url":"https://github.com/WeakAuras","followers_url":"https://api.github.com/users/WeakAuras/followers","following_url":"https://api.github.com/users/WeakAuras/following{/other_user}","gists_url":"https://api.github.com/users/WeakAuras/gists{/gist_id}","starred_url":"https://api.github.com/users/WeakAuras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeakAuras/subscriptions","organizations_url":"https://api.github.com/users/WeakAuras/orgs","repos_url":"https://api.github.com/users/WeakAuras/repos","events_url":"https://api.github.com/users/WeakAuras/events{/privacy}","received_events_url":"https://api.github.com/users/WeakAuras/received_events","type":"Organization","site_admin":false},"repo":{"id":25056248,"node_id":"MDEwOlJlcG9zaXRvcnkyNTA1NjI0OA==","name":"WeakAuras2","full_name":"WeakAuras/WeakAuras2","private":false,"owner":{"login":"WeakAuras","id":9121773,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxMjE3NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/9121773?v=4","gravatar_id":"","url":"https://api.github.com/users/WeakAuras","html_url":"https://github.com/WeakAuras","followers_url":"https://api.github.com/users/WeakAuras/followers","following_url":"https://api.github.com/users/WeakAuras/following{/other_user}","gists_url":"https://api.github.com/users/WeakAuras/gists{/gist_id}","starred_url":"https://api.github.com/users/WeakAuras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WeakAuras/subscriptions","organizations_url":"https://api.github.com/users/WeakAuras/orgs","repos_url":"https://api.github.com/users/WeakAuras/repos","events_url":"https://api.github.com/users/WeakAuras/events{/privacy}","received_events_url":"https://api.github.com/users/WeakAuras/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WeakAuras/WeakAuras2","description":"World of Warcraft addon that provides a powerful and flexible framework to display highly customizable graphics on your screen.","fork":false,"url":"https://api.github.com/repos/WeakAuras/WeakAuras2","forks_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/forks","keys_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/teams","hooks_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/hooks","issue_events_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/issues/events{/number}","events_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/events","assignees_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/assignees{/user}","branches_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/branches{/branch}","tags_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/tags","blobs_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/git/refs{/sha}","trees_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/statuses/{sha}","languages_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/languages","stargazers_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/stargazers","contributors_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/contributors","subscribers_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/subscribers","subscription_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/subscription","commits_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/commits{/sha}","git_commits_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/git/commits{/sha}","comments_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/comments{/number}","issue_comment_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/issues/comments{/number}","contents_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/contents/{+path}","compare_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/merges","archive_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/downloads","issues_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/issues{/number}","pulls_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/pulls{/number}","milestones_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/milestones{/number}","notifications_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/labels{/name}","releases_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/releases{/id}","deployments_url":"https://api.github.com/repos/WeakAuras/WeakAuras2/deployments","created_at":"2014-10-10T22:57:50Z","updated_at":"2018-10-05T17:57:05Z","pushed_at":"2018-10-05T17:54:51Z","git_url":"git://github.com/WeakAuras/WeakAuras2.git","ssh_url":"git@github.com:WeakAuras/WeakAuras2.git","clone_url":"https://github.com/WeakAuras/WeakAuras2.git","svn_url":"https://github.com/WeakAuras/WeakAuras2","homepage":"https://weakauras.wtf","size":17273,"stargazers_count":214,"watchers_count":214,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":73,"open_issues":33,"watchers":214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WeakAuras/WeakAuras2/pulls/812"},"html":{"href":"https://github.com/WeakAuras/WeakAuras2/pull/812"},"issue":{"href":"https://api.github.com/repos/WeakAuras/WeakAuras2/issues/812"},"comments":{"href":"https://api.github.com/repos/WeakAuras/WeakAuras2/issues/812/comments"},"review_comments":{"href":"https://api.github.com/repos/WeakAuras/WeakAuras2/pulls/812/comments"},"review_comment":{"href":"https://api.github.com/repos/WeakAuras/WeakAuras2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WeakAuras/WeakAuras2/pulls/812/commits"},"statuses":{"href":"https://api.github.com/repos/WeakAuras/WeakAuras2/statuses/ecc7e00de7efd9b211af36d19e1ca80d8c4a8c92"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mrbuds"}}