{"action":"created","issue":{"url":"https://api.github.com/repos/dotMorten/Microsoft.SqlServer.Types/issues/18","repository_url":"https://api.github.com/repos/dotMorten/Microsoft.SqlServer.Types","labels_url":"https://api.github.com/repos/dotMorten/Microsoft.SqlServer.Types/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/dotMorten/Microsoft.SqlServer.Types/issues/18/comments","events_url":"https://api.github.com/repos/dotMorten/Microsoft.SqlServer.Types/issues/18/events","html_url":"https://github.com/dotMorten/Microsoft.SqlServer.Types/pull/18","id":377622457,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NTIyMzQ0","number":18,"title":"Added  STPointFromText, STLength, STStartPoint, STEndPoint, STEnvelope, STIsValid","user":{"login":"xfischer","id":2776898,"node_id":"MDQ6VXNlcjI3NzY4OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2776898?v=4","gravatar_id":"","url":"https://api.github.com/users/xfischer","html_url":"https://github.com/xfischer","followers_url":"https://api.github.com/users/xfischer/followers","following_url":"https://api.github.com/users/xfischer/following{/other_user}","gists_url":"https://api.github.com/users/xfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/xfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfischer/subscriptions","organizations_url":"https://api.github.com/users/xfischer/orgs","repos_url":"https://api.github.com/users/xfischer/repos","events_url":"https://api.github.com/users/xfischer/events{/privacy}","received_events_url":"https://api.github.com/users/xfischer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-05T23:09:27Z","updated_at":"2018-11-07T09:57:05Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/dotMorten/Microsoft.SqlServer.Types/pulls/18","html_url":"https://github.com/dotMorten/Microsoft.SqlServer.Types/pull/18","diff_url":"https://github.com/dotMorten/Microsoft.SqlServer.Types/pull/18.diff","patch_url":"https://github.com/dotMorten/Microsoft.SqlServer.Types/pull/18.patch"},"body":"Hi Morten.\r\nFirst, thanks for initiating this port.\r\nI'm porting a personal project and needed to add missing OGC functions.\r\nSorry for the partial implementation of STLength for V2 geometries.\r\nAlso, as I was not sure about how to use internal ShapeData, I relied on instance methods, so my implementation is not optimal, but it's also a good starting point."},"comment":{"url":"https://api.github.com/repos/dotMorten/Microsoft.SqlServer.Types/issues/comments/436568950","html_url":"https://github.com/dotMorten/Microsoft.SqlServer.Types/pull/18#issuecomment-436568950","issue_url":"https://api.github.com/repos/dotMorten/Microsoft.SqlServer.Types/issues/18","id":436568950,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjU2ODk1MA==","user":{"login":"xfischer","id":2776898,"node_id":"MDQ6VXNlcjI3NzY4OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2776898?v=4","gravatar_id":"","url":"https://api.github.com/users/xfischer","html_url":"https://github.com/xfischer","followers_url":"https://api.github.com/users/xfischer/followers","following_url":"https://api.github.com/users/xfischer/following{/other_user}","gists_url":"https://api.github.com/users/xfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/xfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfischer/subscriptions","organizations_url":"https://api.github.com/users/xfischer/orgs","repos_url":"https://api.github.com/users/xfischer/repos","events_url":"https://api.github.com/users/xfischer/events{/privacy}","received_events_url":"https://api.github.com/users/xfischer/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T09:57:05Z","updated_at":"2018-11-07T09:57:05Z","author_association":"NONE","body":"I was planning to use Sql Types within my project without an actual database, but more for handling spatial data in my own project.\r\nThey have some drawbacks but (that's where we meet) I'm confident about how to do things fast and efficiently with those types.\r\nSo let's make it simple : do you plan to add calculations such as unions, intersections in your library, or is this just aimed to embed the well known types and let SQL Server do the complicated stuff ?\r\nThere will be a moment (IMHO) where I'll need to do calculations on the client side because it will be the cleaner way (recombining geometries, extracting rings, reprojecting, validating, buffering).\r\nI'll try to help you the best as I can because I'd love to go on .Net Core with SqlTypes and not migrate my codebase to other lib. So I'll resubmit what I did in a more cleaner way.\r\nCheers !"}}
{"actor":{"display_login":"xfischer"}}