{"action":"created","comment":{"url":"https://api.github.com/repos/python/cpython/pulls/comments/228753810","pull_request_review_id":169097816,"id":228753810,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODc1MzgxMA==","diff_hunk":"@@ -779,32 +779,25 @@ The module defines the following classes, functions and decorators:\n \n    .. versionadded:: 3.5.2\n \n-.. class:: io\n+.. class:: IO\n+           TextIO\n+           BinaryIO\n \n-   Wrapper namespace for I/O stream types.\n-\n-   This defines the generic type ``IO[AnyStr]`` and subclasses ``TextIO``\n-   and ``BinaryIO``, deriving from ``IO[str]`` and ``IO[bytes]``,\n-   respectively. These represent the types of I/O streams such as returned by\n+   Generic type ``IO[AnyStr]`` and subclasses ``TextIO(IO[str])``\n+   and ``BinaryIO(IO[bytes])``","path":"Doc/library/typing.rst","position":15,"original_position":15,"commit_id":"617954304cdefcada05d88b41d8351a84295e605","original_commit_id":"617954304cdefcada05d88b41d8351a84295e605","user":{"login":"srittau","id":52799,"node_id":"MDQ6VXNlcjUyNzk5","avatar_url":"https://avatars3.githubusercontent.com/u/52799?v=4","gravatar_id":"","url":"https://api.github.com/users/srittau","html_url":"https://github.com/srittau","followers_url":"https://api.github.com/users/srittau/followers","following_url":"https://api.github.com/users/srittau/following{/other_user}","gists_url":"https://api.github.com/users/srittau/gists{/gist_id}","starred_url":"https://api.github.com/users/srittau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srittau/subscriptions","organizations_url":"https://api.github.com/users/srittau/orgs","repos_url":"https://api.github.com/users/srittau/repos","events_url":"https://api.github.com/users/srittau/events{/privacy}","received_events_url":"https://api.github.com/users/srittau/received_events","type":"User","site_admin":false},"body":"The problem is that \"This defined\" is now wrong, but when removing the verb you have to reformulate. I first ended up with:\r\n\r\n> The generic type `IO[AnyStr]` and subclasses `TextIO` and `BinaryIO`, deriving from `IO[str]` and `IO[bytes]`, respectively, represent the types of I/O streams such as returned by `open`.\r\n\r\n But I found this hard to understand.","created_at":"2018-10-28T15:47:44Z","updated_at":"2018-10-28T15:47:45Z","html_url":"https://github.com/python/cpython/pull/10173#discussion_r228753810","pull_request_url":"https://api.github.com/repos/python/cpython/pulls/10173","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/comments/228753810"},"html":{"href":"https://github.com/python/cpython/pull/10173#discussion_r228753810"},"pull_request":{"href":"https://api.github.com/repos/python/cpython/pulls/10173"}},"in_reply_to_id":228753667},"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/10173","id":226361962,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzYxOTYy","html_url":"https://github.com/python/cpython/pull/10173","diff_url":"https://github.com/python/cpython/pull/10173.diff","patch_url":"https://github.com/python/cpython/pull/10173.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/10173","number":10173,"state":"open","locked":false,"title":"bpo-35089: Don't mention typing.io and typing.re","user":{"login":"srittau","id":52799,"node_id":"MDQ6VXNlcjUyNzk5","avatar_url":"https://avatars3.githubusercontent.com/u/52799?v=4","gravatar_id":"","url":"https://api.github.com/users/srittau","html_url":"https://github.com/srittau","followers_url":"https://api.github.com/users/srittau/followers","following_url":"https://api.github.com/users/srittau/following{/other_user}","gists_url":"https://api.github.com/users/srittau/gists{/gist_id}","starred_url":"https://api.github.com/users/srittau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srittau/subscriptions","organizations_url":"https://api.github.com/users/srittau/orgs","repos_url":"https://api.github.com/users/srittau/repos","events_url":"https://api.github.com/users/srittau/events{/privacy}","received_events_url":"https://api.github.com/users/srittau/received_events","type":"User","site_admin":false},"body":"\n\n<!-- issue-number: [bpo-35089](https://bugs.python.org/issue35089) -->\nhttps://bugs.python.org/issue35089\n<!-- /issue-number -->\n","created_at":"2018-10-28T12:04:34Z","updated_at":"2018-10-28T15:47:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"811b5063301d9e43c7bd615fbb38c6bff574afb6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":536945472,"node_id":"MDU6TGFiZWw1MzY5NDU0NzI=","url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666980059,"node_id":"MDU6TGFiZWw2NjY5ODAwNTk=","url":"https://api.github.com/repos/python/cpython/labels/awaiting%20merge","name":"awaiting merge","color":"fbca04","default":false},{"id":538516109,"node_id":"MDU6TGFiZWw1Mzg1MTYxMDk=","url":"https://api.github.com/repos/python/cpython/labels/type-documentation","name":"type-documentation","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/10173/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/10173/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/10173/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/617954304cdefcada05d88b41d8351a84295e605","head":{"label":"srittau:typing-doc","ref":"typing-doc","sha":"617954304cdefcada05d88b41d8351a84295e605","user":{"login":"srittau","id":52799,"node_id":"MDQ6VXNlcjUyNzk5","avatar_url":"https://avatars3.githubusercontent.com/u/52799?v=4","gravatar_id":"","url":"https://api.github.com/users/srittau","html_url":"https://github.com/srittau","followers_url":"https://api.github.com/users/srittau/followers","following_url":"https://api.github.com/users/srittau/following{/other_user}","gists_url":"https://api.github.com/users/srittau/gists{/gist_id}","starred_url":"https://api.github.com/users/srittau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srittau/subscriptions","organizations_url":"https://api.github.com/users/srittau/orgs","repos_url":"https://api.github.com/users/srittau/repos","events_url":"https://api.github.com/users/srittau/events{/privacy}","received_events_url":"https://api.github.com/users/srittau/received_events","type":"User","site_admin":false},"repo":{"id":114091472,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQwOTE0NzI=","name":"cpython","full_name":"srittau/cpython","private":false,"owner":{"login":"srittau","id":52799,"node_id":"MDQ6VXNlcjUyNzk5","avatar_url":"https://avatars3.githubusercontent.com/u/52799?v=4","gravatar_id":"","url":"https://api.github.com/users/srittau","html_url":"https://github.com/srittau","followers_url":"https://api.github.com/users/srittau/followers","following_url":"https://api.github.com/users/srittau/following{/other_user}","gists_url":"https://api.github.com/users/srittau/gists{/gist_id}","starred_url":"https://api.github.com/users/srittau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srittau/subscriptions","organizations_url":"https://api.github.com/users/srittau/orgs","repos_url":"https://api.github.com/users/srittau/repos","events_url":"https://api.github.com/users/srittau/events{/privacy}","received_events_url":"https://api.github.com/users/srittau/received_events","type":"User","site_admin":false},"html_url":"https://github.com/srittau/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/srittau/cpython","forks_url":"https://api.github.com/repos/srittau/cpython/forks","keys_url":"https://api.github.com/repos/srittau/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srittau/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srittau/cpython/teams","hooks_url":"https://api.github.com/repos/srittau/cpython/hooks","issue_events_url":"https://api.github.com/repos/srittau/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/srittau/cpython/events","assignees_url":"https://api.github.com/repos/srittau/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/srittau/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/srittau/cpython/tags","blobs_url":"https://api.github.com/repos/srittau/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srittau/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srittau/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/srittau/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srittau/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/srittau/cpython/languages","stargazers_url":"https://api.github.com/repos/srittau/cpython/stargazers","contributors_url":"https://api.github.com/repos/srittau/cpython/contributors","subscribers_url":"https://api.github.com/repos/srittau/cpython/subscribers","subscription_url":"https://api.github.com/repos/srittau/cpython/subscription","commits_url":"https://api.github.com/repos/srittau/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/srittau/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/srittau/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/srittau/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/srittau/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/srittau/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srittau/cpython/merges","archive_url":"https://api.github.com/repos/srittau/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srittau/cpython/downloads","issues_url":"https://api.github.com/repos/srittau/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/srittau/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/srittau/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/srittau/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srittau/cpython/labels{/name}","releases_url":"https://api.github.com/repos/srittau/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/srittau/cpython/deployments","created_at":"2017-12-13T07:59:16Z","updated_at":"2018-10-28T11:32:48Z","pushed_at":"2018-10-28T12:03:12Z","git_url":"git://github.com/srittau/cpython.git","ssh_url":"git@github.com:srittau/cpython.git","clone_url":"https://github.com/srittau/cpython.git","svn_url":"https://github.com/srittau/cpython","homepage":"https://www.python.org/","size":244128,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"6015cc50bc38b9e920ce4986ee10658eaa14f561","user":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"node_id":"MDEwOlJlcG9zaXRvcnk4MTU5ODk2MQ==","name":"cpython","full_name":"python/cpython","private":false,"owner":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2018-10-28T15:05:32Z","pushed_at":"2018-10-28T15:33:07Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":253725,"stargazers_count":20523,"watchers_count":20523,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7425,"mirror_url":null,"archived":false,"open_issues_count":931,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7425,"open_issues":931,"watchers":20523,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/10173"},"html":{"href":"https://github.com/python/cpython/pull/10173"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/10173"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/10173/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/10173/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/10173/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/617954304cdefcada05d88b41d8351a84295e605"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"srittau"}}