{"action":"created","issue":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9116","repository_url":"https://api.github.com/repos/PrestaShop/PrestaShop","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9116/labels{/name}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9116/comments","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9116/events","html_url":"https://github.com/PrestaShop/PrestaShop/pull/9116","id":325770636,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwMDI1NDcw","number":9116,"title":"Migrate localization page","user":{"login":"sarjon","id":15143151,"node_id":"MDQ6VXNlcjE1MTQzMTUx","avatar_url":"https://avatars3.githubusercontent.com/u/15143151?v=4","gravatar_id":"","url":"https://api.github.com/users/sarjon","html_url":"https://github.com/sarjon","followers_url":"https://api.github.com/users/sarjon/followers","following_url":"https://api.github.com/users/sarjon/following{/other_user}","gists_url":"https://api.github.com/users/sarjon/gists{/gist_id}","starred_url":"https://api.github.com/users/sarjon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarjon/subscriptions","organizations_url":"https://api.github.com/users/sarjon/orgs","repos_url":"https://api.github.com/users/sarjon/repos","events_url":"https://api.github.com/users/sarjon/events{/privacy}","received_events_url":"https://api.github.com/users/sarjon/received_events","type":"User","site_admin":false},"labels":[{"id":904910825,"node_id":"MDU6TGFiZWw5MDQ5MTA4MjU=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/develop","name":"develop","color":"3ce091","default":false},{"id":630442847,"node_id":"MDU6TGFiZWw2MzA0NDI4NDc=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/feature","name":"feature","color":"b9d854","default":false},{"id":186105912,"node_id":"MDU6TGFiZWwxODYxMDU5MTI=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/waiting%20for%20author%20feedback","name":"waiting for author feedback","color":"fbca04","default":false},{"id":268030897,"node_id":"MDU6TGFiZWwyNjgwMzA4OTc=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/wip","name":"wip","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-23T15:55:45Z","updated_at":"2018-06-06T09:10:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9116","html_url":"https://github.com/PrestaShop/PrestaShop/pull/9116","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/9116.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/9116.patch"},"body":"| Questions     | Answers\r\n| ------------- | -------------------------------------------------------\r\n| Branch?       | develop\r\n| Description?  | Migrates \"Improve > International > Localization\" page to Symfony\r\n| Type?         | new feature\r\n| Category?     | CO\r\n| BC breaks?    | yes (overrides)\r\n| Deprecations? | no\r\n| Fixed ticket? | n/a\r\n| How to test?  | Access \"Improve > International > Localization\" and it should work the same as legacy page.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/prestashop/prestashop/9116)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments/395000731","html_url":"https://github.com/PrestaShop/PrestaShop/pull/9116#issuecomment-395000731","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9116","id":395000731,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTAwMDczMQ==","user":{"login":"PierreRambaud","id":1462701,"node_id":"MDQ6VXNlcjE0NjI3MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1462701?v=4","gravatar_id":"","url":"https://api.github.com/users/PierreRambaud","html_url":"https://github.com/PierreRambaud","followers_url":"https://api.github.com/users/PierreRambaud/followers","following_url":"https://api.github.com/users/PierreRambaud/following{/other_user}","gists_url":"https://api.github.com/users/PierreRambaud/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreRambaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreRambaud/subscriptions","organizations_url":"https://api.github.com/users/PierreRambaud/orgs","repos_url":"https://api.github.com/users/PierreRambaud/repos","events_url":"https://api.github.com/users/PierreRambaud/events{/privacy}","received_events_url":"https://api.github.com/users/PierreRambaud/received_events","type":"User","site_admin":false},"created_at":"2018-06-06T09:10:43Z","updated_at":"2018-06-06T09:10:43Z","author_association":"CONTRIBUTOR","body":"> > it's the same method as above, maybe refactoring by create a method setActive($status);, is it normal to settings this value to 1 or 0 and not to true or false?\r\n> \r\n >Sadly, I think it's a \"tiny int\" stored in database: I don't like it neither :/\r\n\r\nIn fact, MySQL boolean field is a tinyint(1) (YEAH FUCK LOGIC), so we can use true and false that should be automatically converted to tinyint :)\r\n```sql\r\nCREATE TABLE `test_prestashop`.`test_boolean` ( `test` BOOLEAN NOT NULL ) ENGINE = InnoDB;\r\n\r\nINSERT INTO `test_boolean` (`test`) VALUES ('1');\r\nINSERT INTO `test_boolean` (`test`) VALUES (1);\r\nINSERT INTO `test_boolean` (`test`) VALUES (TRUE);\r\n```\r\n\r\nThe dump:\r\n```sql\r\nCREATE TABLE `test_boolean` (\r\n  `test` tinyint(1) NOT NULL\r\n) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;\r\n```\r\n\r\nThis is one reason why I hate MySQL :trollface: "}}
{"actor":{"display_login":"PierreRambaud"}}