{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/3563","repository_url":"https://api.github.com/repos/apache/incubator-airflow","labels_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3563/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3563/comments","events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3563/events","html_url":"https://github.com/apache/incubator-airflow/pull/3563","id":337142394,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDI4NDI0","number":3563,"title":"[AIRFLOW-2698] Simplify Kerberos code","user":{"login":"gglanzani","id":630284,"node_id":"MDQ6VXNlcjYzMDI4NA==","avatar_url":"https://avatars1.githubusercontent.com/u/630284?v=4","gravatar_id":"","url":"https://api.github.com/users/gglanzani","html_url":"https://github.com/gglanzani","followers_url":"https://api.github.com/users/gglanzani/followers","following_url":"https://api.github.com/users/gglanzani/following{/other_user}","gists_url":"https://api.github.com/users/gglanzani/gists{/gist_id}","starred_url":"https://api.github.com/users/gglanzani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gglanzani/subscriptions","organizations_url":"https://api.github.com/users/gglanzani/orgs","repos_url":"https://api.github.com/users/gglanzani/repos","events_url":"https://api.github.com/users/gglanzani/events{/privacy}","received_events_url":"https://api.github.com/users/gglanzani/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-06-29T21:27:08Z","updated_at":"2018-10-23T11:07:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3563","html_url":"https://github.com/apache/incubator-airflow/pull/3563","diff_url":"https://github.com/apache/incubator-airflow/pull/3563.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/3563.patch"},"body":"Dear Airflow maintainers, please accept my pull request\r\n\r\nMake sure you have checked _all_ steps below.\r\n\r\n### JIRA\r\n- [x] My PR addresses the following [Airflow JIRA](https://issues.apache.org/jira/projects/AIRFLOW/issues/AIRFLOW-2698) issues and references them in the PR title.\r\n\r\n### Description\r\n- [x] Here are some details about my PR, including screenshots of any UI changes:\r\n\r\nSome functions were not used. On top of that, the\r\n`principal_from_username` function was getting the wrong config value\r\n(\"security\" instead of \"kerberos\").\r\n\r\nSince the results were only used by `kerberos.checkPassword`, and the\r\nfunction can cope with needing a realm in the `username` when `realm` is\r\nprovided, we removed the `principal_from_username` function altogether.\r\n\r\n### Tests\r\n- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:\r\n\r\nNo functionality has been added\r\n\r\n### Commits\r\n- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n    1. Subject is separated from body by a blank line\r\n    2. Subject is limited to 50 characters\r\n    3. Subject does not end with a period\r\n    4. Subject uses the imperative mood (\"add\", not \"adding\")\r\n    5. Body wraps at 72 characters\r\n    6. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n\r\n### Documentation\r\n- [x] In case of new functionality, my PR adds documentation that describes how to use it.\r\nNo new functionality\r\n\r\n### Code Quality\r\n- [x] Passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments/432202708","html_url":"https://github.com/apache/incubator-airflow/pull/3563#issuecomment-432202708","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3563","id":432202708,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjIwMjcwOA==","user":{"login":"gglanzani","id":630284,"node_id":"MDQ6VXNlcjYzMDI4NA==","avatar_url":"https://avatars1.githubusercontent.com/u/630284?v=4","gravatar_id":"","url":"https://api.github.com/users/gglanzani","html_url":"https://github.com/gglanzani","followers_url":"https://api.github.com/users/gglanzani/followers","following_url":"https://api.github.com/users/gglanzani/following{/other_user}","gists_url":"https://api.github.com/users/gglanzani/gists{/gist_id}","starred_url":"https://api.github.com/users/gglanzani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gglanzani/subscriptions","organizations_url":"https://api.github.com/users/gglanzani/orgs","repos_url":"https://api.github.com/users/gglanzani/repos","events_url":"https://api.github.com/users/gglanzani/events{/privacy}","received_events_url":"https://api.github.com/users/gglanzani/received_events","type":"User","site_admin":false},"created_at":"2018-10-23T11:07:39Z","updated_at":"2018-10-23T11:07:39Z","author_association":"CONTRIBUTOR","body":"@Ron819 I'm waiting for an ok here"}}
{"actor":{"display_login":"gglanzani"}}