{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/24494","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/24494/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24494/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/24494/events","html_url":"https://github.com/nodejs/node/pull/24494","id":382309849,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDQ3MjQy","number":24494,"title":"n-api: handle reference delete before finalize","user":{"login":"mhdawson","id":9373002,"node_id":"MDQ6VXNlcjkzNzMwMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/9373002?v=4","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":574036893,"node_id":"MDU6TGFiZWw1NzQwMzY4OTM=","url":"https://api.github.com/repos/nodejs/node/labels/n-api","name":"n-api","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-11-19T17:03:48Z","updated_at":"2018-11-22T21:56:26Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24494","html_url":"https://github.com/nodejs/node/pull/24494","diff_url":"https://github.com/nodejs/node/pull/24494.diff","patch_url":"https://github.com/nodejs/node/pull/24494.patch"},"body":"Crashes were reported during finalization due to\r\nthe memory for a reference being deleted and the\r\nfinalizer running after the deletion.\r\n\r\nThis change ensures the deletion of the memory for\r\nthe reference only occurs after the finalizer has run.\r\n\r\nFixes: https://github.com/nodejs/node-addon-api/issues/393\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [X] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [X] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/441125672","html_url":"https://github.com/nodejs/node/pull/24494#issuecomment-441125672","issue_url":"https://api.github.com/repos/nodejs/node/issues/24494","id":441125672,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTEyNTY3Mg==","user":{"login":"mhdawson","id":9373002,"node_id":"MDQ6VXNlcjkzNzMwMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/9373002?v=4","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"created_at":"2018-11-22T21:56:26Z","updated_at":"2018-11-22T21:56:26Z","author_association":"MEMBER","body":"and thanks to @toddwong for the basis of the test.  I'm surprised it was straightforward to have a test that recreates relatively easily."}}
{"actor":{"display_login":"mhdawson"}}