{"action":"created","issue":{"url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/309","repository_url":"https://api.github.com/repos/sillsdev/web-languageforge","labels_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/309/labels{/name}","comments_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/309/comments","events_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/309/events","html_url":"https://github.com/sillsdev/web-languageforge/pull/309","id":335862620,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDU0NTA1","number":309,"title":"Navigating to list should not retain empty entry","user":{"login":"Umasengoden","id":39293609,"node_id":"MDQ6VXNlcjM5MjkzNjA5","avatar_url":"https://avatars3.githubusercontent.com/u/39293609?v=4","gravatar_id":"","url":"https://api.github.com/users/Umasengoden","html_url":"https://github.com/Umasengoden","followers_url":"https://api.github.com/users/Umasengoden/followers","following_url":"https://api.github.com/users/Umasengoden/following{/other_user}","gists_url":"https://api.github.com/users/Umasengoden/gists{/gist_id}","starred_url":"https://api.github.com/users/Umasengoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Umasengoden/subscriptions","organizations_url":"https://api.github.com/users/Umasengoden/orgs","repos_url":"https://api.github.com/users/Umasengoden/repos","events_url":"https://api.github.com/users/Umasengoden/events{/privacy}","received_events_url":"https://api.github.com/users/Umasengoden/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-26T15:01:04Z","updated_at":"2018-06-27T23:40:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sillsdev/web-languageforge/pulls/309","html_url":"https://github.com/sillsdev/web-languageforge/pull/309","diff_url":"https://github.com/sillsdev/web-languageforge/pull/309.diff","patch_url":"https://github.com/sillsdev/web-languageforge/pull/309.patch"},"body":"When new entry is not filled any content, while navigating to the list, the new entry has been removed from the list.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/sillsdev/web-languageforge/309)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/comments/400864207","html_url":"https://github.com/sillsdev/web-languageforge/pull/309#issuecomment-400864207","issue_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/309","id":400864207,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDg2NDIwNw==","user":{"login":"irahopkinson","id":5582153,"node_id":"MDQ6VXNlcjU1ODIxNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5582153?v=4","gravatar_id":"","url":"https://api.github.com/users/irahopkinson","html_url":"https://github.com/irahopkinson","followers_url":"https://api.github.com/users/irahopkinson/followers","following_url":"https://api.github.com/users/irahopkinson/following{/other_user}","gists_url":"https://api.github.com/users/irahopkinson/gists{/gist_id}","starred_url":"https://api.github.com/users/irahopkinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irahopkinson/subscriptions","organizations_url":"https://api.github.com/users/irahopkinson/orgs","repos_url":"https://api.github.com/users/irahopkinson/repos","events_url":"https://api.github.com/users/irahopkinson/events{/privacy}","received_events_url":"https://api.github.com/users/irahopkinson/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T23:40:23Z","updated_at":"2018-06-27T23:40:23Z","author_association":"COLLABORATOR","body":"BTW are you able to run the E2E tests on your PC? Are they passing? Are you able to respond using the **Reviewable** link in Github (rather than using Github directly)?\n\n---\n\nReviewed 1 of 1 files at r2.\nReview status: all files reviewed, 2 unresolved discussions (waiting on @Nateowami and @Umasengoden)\n\n---\n\n*[src/angular-app/languageforge/lexicon/editor/editor.component.ts, line 219 at r1](https://reviewable.io/reviews/sillsdev/web-languageforge/309#-LFyPJl90GhdShP5Vc9C:-LG2_blQ-wW6SYo7vEMW:bsjr47c) ([raw file](https://github.com/sillsdev/web-languageforge/blob/c41bd992642aae73b952e6fd1fd4b4c66df9c34a/src/angular-app/languageforge/lexicon/editor/editor.component.ts#L219)):*\n<details><summary><i>Previously, irahopkinson (Ira Hopkinson) wrote…</i></summary><blockquote>\n\nOh I see, you want to find an empty entry right? In that case the boolean `hasNewEntry` is poorly named; how about `hasNewEmptyEntry`. You should also check it is new and not just empty. Does this code really check that it is empty?\n</blockquote></details>\n\nThis code is getting better, well done. However, this will still remove a new entry even if it isn't empty. You need to also check if its empty.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/sillsdev/web-languageforge/309#-:-LG2a4U6-XTKAUALEvfo:b1xojn3)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"irahopkinson"}}