{"action":"created","comment":{"url":"https://api.github.com/repos/Ultimaker/Cura/pulls/comments/231866181","pull_request_review_id":172929550,"id":231866181,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTg2NjE4MQ==","diff_hunk":"@@ -375,10 +375,13 @@ def setActiveMachine(self, stack_id: str) -> None:\n             # Mark global stack as invalid\n             ConfigurationErrorMessage.getInstance().addFaultyContainers(global_stack.getId())\n             return  # We're done here\n-        ExtruderManager.getInstance().setActiveExtruderIndex(0)  # Switch to first extruder\n+\n         self._global_container_stack = global_stack\n+\n+        ExtruderManager.getInstance().globalContainerStackChanged()","path":"cura/Settings/MachineManager.py","position":8,"original_position":8,"commit_id":"6417932e56d20160823b69594c45c5830744cede","original_commit_id":"6417932e56d20160823b69594c45c5830744cede","user":{"login":"nallath","id":3922611,"node_id":"MDQ6VXNlcjM5MjI2MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3922611?v=4","gravatar_id":"","url":"https://api.github.com/users/nallath","html_url":"https://github.com/nallath","followers_url":"https://api.github.com/users/nallath/followers","following_url":"https://api.github.com/users/nallath/following{/other_user}","gists_url":"https://api.github.com/users/nallath/gists{/gist_id}","starred_url":"https://api.github.com/users/nallath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nallath/subscriptions","organizations_url":"https://api.github.com/users/nallath/orgs","repos_url":"https://api.github.com/users/nallath/repos","events_url":"https://api.github.com/users/nallath/events{/privacy}","received_events_url":"https://api.github.com/users/nallath/received_events","type":"User","site_admin":false},"body":"Instead of doing this (and changing the _addCurrentMachineExtruders), i think its better to do the following:\r\naddMachineExtruders(machine_id) <- This function gets the machine as provided by the ID and ensures that it's extruders have been initialised. That way it doesn't have to get a different kind of global stack. ","created_at":"2018-11-08T12:19:30Z","updated_at":"2018-11-08T12:19:30Z","html_url":"https://github.com/Ultimaker/Cura/pull/4756#discussion_r231866181","pull_request_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/4756","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/comments/231866181"},"html":{"href":"https://github.com/Ultimaker/Cura/pull/4756#discussion_r231866181"},"pull_request":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/4756"}}},"pull_request":{"url":"https://api.github.com/repos/Ultimaker/Cura/pulls/4756","id":229335533,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MzM1NTMz","html_url":"https://github.com/Ultimaker/Cura/pull/4756","diff_url":"https://github.com/Ultimaker/Cura/pull/4756.diff","patch_url":"https://github.com/Ultimaker/Cura/pull/4756.patch","issue_url":"https://api.github.com/repos/Ultimaker/Cura/issues/4756","number":4756,"state":"open","locked":false,"title":"While initial loading Machine Manager was triggered global stack chan…","user":{"login":"alekseisasin","id":29890821,"node_id":"MDQ6VXNlcjI5ODkwODIx","avatar_url":"https://avatars1.githubusercontent.com/u/29890821?v=4","gravatar_id":"","url":"https://api.github.com/users/alekseisasin","html_url":"https://github.com/alekseisasin","followers_url":"https://api.github.com/users/alekseisasin/followers","following_url":"https://api.github.com/users/alekseisasin/following{/other_user}","gists_url":"https://api.github.com/users/alekseisasin/gists{/gist_id}","starred_url":"https://api.github.com/users/alekseisasin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alekseisasin/subscriptions","organizations_url":"https://api.github.com/users/alekseisasin/orgs","repos_url":"https://api.github.com/users/alekseisasin/repos","events_url":"https://api.github.com/users/alekseisasin/events{/privacy}","received_events_url":"https://api.github.com/users/alekseisasin/received_events","type":"User","site_admin":false},"body":"…ged, but extruder stacks were not ready.\r\n\r\nCURA-5893","created_at":"2018-11-08T11:38:25Z","updated_at":"2018-11-08T12:19:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c7a67ca2a3428a47b07d5e2fc2e63eaa9e4c94e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"LipuFei","id":2630468,"node_id":"MDQ6VXNlcjI2MzA0Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/2630468?v=4","gravatar_id":"","url":"https://api.github.com/users/LipuFei","html_url":"https://github.com/LipuFei","followers_url":"https://api.github.com/users/LipuFei/followers","following_url":"https://api.github.com/users/LipuFei/following{/other_user}","gists_url":"https://api.github.com/users/LipuFei/gists{/gist_id}","starred_url":"https://api.github.com/users/LipuFei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LipuFei/subscriptions","organizations_url":"https://api.github.com/users/LipuFei/orgs","repos_url":"https://api.github.com/users/LipuFei/repos","events_url":"https://api.github.com/users/LipuFei/events{/privacy}","received_events_url":"https://api.github.com/users/LipuFei/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/4756/commits","review_comments_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/4756/comments","review_comment_url":"https://api.github.com/repos/Ultimaker/Cura/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ultimaker/Cura/issues/4756/comments","statuses_url":"https://api.github.com/repos/Ultimaker/Cura/statuses/6417932e56d20160823b69594c45c5830744cede","head":{"label":"Ultimaker:CURA-5893_exception_not_valid_adhesion_type","ref":"CURA-5893_exception_not_valid_adhesion_type","sha":"6417932e56d20160823b69594c45c5830744cede","user":{"login":"Ultimaker","id":499557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/499557?v=4","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"repo":{"id":20884782,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg4NDc4Mg==","name":"Cura","full_name":"Ultimaker/Cura","private":false,"owner":{"login":"Ultimaker","id":499557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/499557?v=4","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Ultimaker/Cura","description":"3D printer / slicing GUI built on top of the Uranium framework","fork":false,"url":"https://api.github.com/repos/Ultimaker/Cura","forks_url":"https://api.github.com/repos/Ultimaker/Cura/forks","keys_url":"https://api.github.com/repos/Ultimaker/Cura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ultimaker/Cura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ultimaker/Cura/teams","hooks_url":"https://api.github.com/repos/Ultimaker/Cura/hooks","issue_events_url":"https://api.github.com/repos/Ultimaker/Cura/issues/events{/number}","events_url":"https://api.github.com/repos/Ultimaker/Cura/events","assignees_url":"https://api.github.com/repos/Ultimaker/Cura/assignees{/user}","branches_url":"https://api.github.com/repos/Ultimaker/Cura/branches{/branch}","tags_url":"https://api.github.com/repos/Ultimaker/Cura/tags","blobs_url":"https://api.github.com/repos/Ultimaker/Cura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ultimaker/Cura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ultimaker/Cura/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ultimaker/Cura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ultimaker/Cura/statuses/{sha}","languages_url":"https://api.github.com/repos/Ultimaker/Cura/languages","stargazers_url":"https://api.github.com/repos/Ultimaker/Cura/stargazers","contributors_url":"https://api.github.com/repos/Ultimaker/Cura/contributors","subscribers_url":"https://api.github.com/repos/Ultimaker/Cura/subscribers","subscription_url":"https://api.github.com/repos/Ultimaker/Cura/subscription","commits_url":"https://api.github.com/repos/Ultimaker/Cura/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ultimaker/Cura/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ultimaker/Cura/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ultimaker/Cura/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ultimaker/Cura/contents/{+path}","compare_url":"https://api.github.com/repos/Ultimaker/Cura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ultimaker/Cura/merges","archive_url":"https://api.github.com/repos/Ultimaker/Cura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ultimaker/Cura/downloads","issues_url":"https://api.github.com/repos/Ultimaker/Cura/issues{/number}","pulls_url":"https://api.github.com/repos/Ultimaker/Cura/pulls{/number}","milestones_url":"https://api.github.com/repos/Ultimaker/Cura/milestones{/number}","notifications_url":"https://api.github.com/repos/Ultimaker/Cura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ultimaker/Cura/labels{/name}","releases_url":"https://api.github.com/repos/Ultimaker/Cura/releases{/id}","deployments_url":"https://api.github.com/repos/Ultimaker/Cura/deployments","created_at":"2014-06-16T12:55:31Z","updated_at":"2018-11-08T12:03:49Z","pushed_at":"2018-11-08T12:03:43Z","git_url":"git://github.com/Ultimaker/Cura.git","ssh_url":"git@github.com:Ultimaker/Cura.git","clone_url":"https://github.com/Ultimaker/Cura.git","svn_url":"https://github.com/Ultimaker/Cura","homepage":"","size":161213,"stargazers_count":1072,"watchers_count":1072,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":551,"mirror_url":null,"archived":false,"open_issues_count":534,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":551,"open_issues":534,"watchers":1072,"default_branch":"master"}},"base":{"label":"Ultimaker:3.6","ref":"3.6","sha":"69c9ffaf618385d29ef51671283d84b010ebb531","user":{"login":"Ultimaker","id":499557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/499557?v=4","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"repo":{"id":20884782,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg4NDc4Mg==","name":"Cura","full_name":"Ultimaker/Cura","private":false,"owner":{"login":"Ultimaker","id":499557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/499557?v=4","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Ultimaker/Cura","description":"3D printer / slicing GUI built on top of the Uranium framework","fork":false,"url":"https://api.github.com/repos/Ultimaker/Cura","forks_url":"https://api.github.com/repos/Ultimaker/Cura/forks","keys_url":"https://api.github.com/repos/Ultimaker/Cura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ultimaker/Cura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ultimaker/Cura/teams","hooks_url":"https://api.github.com/repos/Ultimaker/Cura/hooks","issue_events_url":"https://api.github.com/repos/Ultimaker/Cura/issues/events{/number}","events_url":"https://api.github.com/repos/Ultimaker/Cura/events","assignees_url":"https://api.github.com/repos/Ultimaker/Cura/assignees{/user}","branches_url":"https://api.github.com/repos/Ultimaker/Cura/branches{/branch}","tags_url":"https://api.github.com/repos/Ultimaker/Cura/tags","blobs_url":"https://api.github.com/repos/Ultimaker/Cura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ultimaker/Cura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ultimaker/Cura/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ultimaker/Cura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ultimaker/Cura/statuses/{sha}","languages_url":"https://api.github.com/repos/Ultimaker/Cura/languages","stargazers_url":"https://api.github.com/repos/Ultimaker/Cura/stargazers","contributors_url":"https://api.github.com/repos/Ultimaker/Cura/contributors","subscribers_url":"https://api.github.com/repos/Ultimaker/Cura/subscribers","subscription_url":"https://api.github.com/repos/Ultimaker/Cura/subscription","commits_url":"https://api.github.com/repos/Ultimaker/Cura/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ultimaker/Cura/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ultimaker/Cura/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ultimaker/Cura/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ultimaker/Cura/contents/{+path}","compare_url":"https://api.github.com/repos/Ultimaker/Cura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ultimaker/Cura/merges","archive_url":"https://api.github.com/repos/Ultimaker/Cura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ultimaker/Cura/downloads","issues_url":"https://api.github.com/repos/Ultimaker/Cura/issues{/number}","pulls_url":"https://api.github.com/repos/Ultimaker/Cura/pulls{/number}","milestones_url":"https://api.github.com/repos/Ultimaker/Cura/milestones{/number}","notifications_url":"https://api.github.com/repos/Ultimaker/Cura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ultimaker/Cura/labels{/name}","releases_url":"https://api.github.com/repos/Ultimaker/Cura/releases{/id}","deployments_url":"https://api.github.com/repos/Ultimaker/Cura/deployments","created_at":"2014-06-16T12:55:31Z","updated_at":"2018-11-08T12:03:49Z","pushed_at":"2018-11-08T12:03:43Z","git_url":"git://github.com/Ultimaker/Cura.git","ssh_url":"git@github.com:Ultimaker/Cura.git","clone_url":"https://github.com/Ultimaker/Cura.git","svn_url":"https://github.com/Ultimaker/Cura","homepage":"","size":161213,"stargazers_count":1072,"watchers_count":1072,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":551,"mirror_url":null,"archived":false,"open_issues_count":534,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":551,"open_issues":534,"watchers":1072,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/4756"},"html":{"href":"https://github.com/Ultimaker/Cura/pull/4756"},"issue":{"href":"https://api.github.com/repos/Ultimaker/Cura/issues/4756"},"comments":{"href":"https://api.github.com/repos/Ultimaker/Cura/issues/4756/comments"},"review_comments":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/4756/comments"},"review_comment":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ultimaker/Cura/pulls/4756/commits"},"statuses":{"href":"https://api.github.com/repos/Ultimaker/Cura/statuses/6417932e56d20160823b69594c45c5830744cede"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nallath"}}