{"action":"created","comment":{"url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/pulls/comments/231688313","pull_request_review_id":172713860,"id":231688313,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTY4ODMxMw==","diff_hunk":"@@ -1,9 +1,13 @@\n package com.kin.ecosystem.recovery.backup.presenter;\n \n+import android.os.Bundle;\n import com.kin.ecosystem.recovery.backup.view.BackupNextStepListener;\n import com.kin.ecosystem.recovery.backup.view.BackupView;\n import com.kin.ecosystem.recovery.base.BasePresenter;\n \n public interface BackupPresenter extends BasePresenter<BackupView>, BackupNextStepListener {\n \n+\tvoid onSaveInstanceState(Bundle outState);","path":"recovery/src/main/java/com/kin/ecosystem/recovery/backup/presenter/BackupPresenter.java","position":10,"original_position":10,"commit_id":"c85ca1295b277f39117f9d6c3dcf150b907fa3a2","original_commit_id":"c85ca1295b277f39117f9d6c3dcf150b907fa3a2","user":{"login":"YohayBar","id":3635216,"node_id":"MDQ6VXNlcjM2MzUyMTY=","avatar_url":"https://avatars0.githubusercontent.com/u/3635216?v=4","gravatar_id":"","url":"https://api.github.com/users/YohayBar","html_url":"https://github.com/YohayBar","followers_url":"https://api.github.com/users/YohayBar/followers","following_url":"https://api.github.com/users/YohayBar/following{/other_user}","gists_url":"https://api.github.com/users/YohayBar/gists{/gist_id}","starred_url":"https://api.github.com/users/YohayBar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YohayBar/subscriptions","organizations_url":"https://api.github.com/users/YohayBar/orgs","repos_url":"https://api.github.com/users/YohayBar/repos","events_url":"https://api.github.com/users/YohayBar/events{/privacy}","received_events_url":"https://api.github.com/users/YohayBar/received_events","type":"User","site_admin":false},"body":"will that affect unit test of BackupPresenter do to  Bundle ","created_at":"2018-11-07T21:44:24Z","updated_at":"2018-11-07T21:44:24Z","html_url":"https://github.com/kinecosystem/kin-ecosystem-android-sdk/pull/185#discussion_r231688313","pull_request_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/pulls/185","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/pulls/comments/231688313"},"html":{"href":"https://github.com/kinecosystem/kin-ecosystem-android-sdk/pull/185#discussion_r231688313"},"pull_request":{"href":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/pulls/185","id":229015776,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MDE1Nzc2","html_url":"https://github.com/kinecosystem/kin-ecosystem-android-sdk/pull/185","diff_url":"https://github.com/kinecosystem/kin-ecosystem-android-sdk/pull/185.diff","patch_url":"https://github.com/kinecosystem/kin-ecosystem-android-sdk/pull/185.patch","issue_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/issues/185","number":185,"state":"open","locked":false,"title":"Solved crash after activity is killed for backup flow","user":{"login":"OrenZak","id":8303735,"node_id":"MDQ6VXNlcjgzMDM3MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/8303735?v=4","gravatar_id":"","url":"https://api.github.com/users/OrenZak","html_url":"https://github.com/OrenZak","followers_url":"https://api.github.com/users/OrenZak/followers","following_url":"https://api.github.com/users/OrenZak/following{/other_user}","gists_url":"https://api.github.com/users/OrenZak/gists{/gist_id}","starred_url":"https://api.github.com/users/OrenZak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrenZak/subscriptions","organizations_url":"https://api.github.com/users/OrenZak/orgs","repos_url":"https://api.github.com/users/OrenZak/repos","events_url":"https://api.github.com/users/OrenZak/events{/privacy}","received_events_url":"https://api.github.com/users/OrenZak/received_events","type":"User","site_admin":false},"body":"#### Main purpose:\r\nThe crash appeared while having the developer option of `don't keep activities`.\r\nThis fix is only for backup flow, restore flow will do next.\r\n#### Technical description:\r\nAdd save instance state mechanism for the fragments and main activity `BackupActivity`\r\n\r\n","created_at":"2018-11-07T12:45:20Z","updated_at":"2018-11-07T21:44:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e12ced15fbb720967fa579688303e337a7c0c36","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yosriz","id":1626032,"node_id":"MDQ6VXNlcjE2MjYwMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1626032?v=4","gravatar_id":"","url":"https://api.github.com/users/yosriz","html_url":"https://github.com/yosriz","followers_url":"https://api.github.com/users/yosriz/followers","following_url":"https://api.github.com/users/yosriz/following{/other_user}","gists_url":"https://api.github.com/users/yosriz/gists{/gist_id}","starred_url":"https://api.github.com/users/yosriz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosriz/subscriptions","organizations_url":"https://api.github.com/users/yosriz/orgs","repos_url":"https://api.github.com/users/yosriz/repos","events_url":"https://api.github.com/users/yosriz/events{/privacy}","received_events_url":"https://api.github.com/users/yosriz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/pulls/185/commits","review_comments_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/pulls/185/comments","review_comment_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/issues/185/comments","statuses_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/statuses/c85ca1295b277f39117f9d6c3dcf150b907fa3a2","head":{"label":"kinecosystem:ECO-737/developer_options_kill_activities_as_soon_as_pos_crash","ref":"ECO-737/developer_options_kill_activities_as_soon_as_pos_crash","sha":"c85ca1295b277f39117f9d6c3dcf150b907fa3a2","user":{"login":"kinecosystem","id":28860603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODYwNjAz","avatar_url":"https://avatars2.githubusercontent.com/u/28860603?v=4","gravatar_id":"","url":"https://api.github.com/users/kinecosystem","html_url":"https://github.com/kinecosystem","followers_url":"https://api.github.com/users/kinecosystem/followers","following_url":"https://api.github.com/users/kinecosystem/following{/other_user}","gists_url":"https://api.github.com/users/kinecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/kinecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinecosystem/subscriptions","organizations_url":"https://api.github.com/users/kinecosystem/orgs","repos_url":"https://api.github.com/users/kinecosystem/repos","events_url":"https://api.github.com/users/kinecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/kinecosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":120272671,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAyNzI2NzE=","name":"kin-ecosystem-android-sdk","full_name":"kinecosystem/kin-ecosystem-android-sdk","private":false,"owner":{"login":"kinecosystem","id":28860603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODYwNjAz","avatar_url":"https://avatars2.githubusercontent.com/u/28860603?v=4","gravatar_id":"","url":"https://api.github.com/users/kinecosystem","html_url":"https://github.com/kinecosystem","followers_url":"https://api.github.com/users/kinecosystem/followers","following_url":"https://api.github.com/users/kinecosystem/following{/other_user}","gists_url":"https://api.github.com/users/kinecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/kinecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinecosystem/subscriptions","organizations_url":"https://api.github.com/users/kinecosystem/orgs","repos_url":"https://api.github.com/users/kinecosystem/repos","events_url":"https://api.github.com/users/kinecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/kinecosystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kinecosystem/kin-ecosystem-android-sdk","description":"Add Kin ecosystem sdk to enable earn and spend opportunities in your app.","fork":false,"url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk","forks_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/forks","keys_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/teams","hooks_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/events","assignees_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/tags","blobs_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/languages","stargazers_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/subscription","commits_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/merges","archive_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/downloads","issues_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/deployments","created_at":"2018-02-05T07:56:03Z","updated_at":"2018-11-07T13:11:49Z","pushed_at":"2018-11-07T13:11:50Z","git_url":"git://github.com/kinecosystem/kin-ecosystem-android-sdk.git","ssh_url":"git@github.com:kinecosystem/kin-ecosystem-android-sdk.git","clone_url":"https://github.com/kinecosystem/kin-ecosystem-android-sdk.git","svn_url":"https://github.com/kinecosystem/kin-ecosystem-android-sdk","homepage":"","size":2908,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":1,"watchers":22,"default_branch":"dev"}},"base":{"label":"kinecosystem:dev","ref":"dev","sha":"29a16f5d3eec669477f274d91eacc23986170da8","user":{"login":"kinecosystem","id":28860603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODYwNjAz","avatar_url":"https://avatars2.githubusercontent.com/u/28860603?v=4","gravatar_id":"","url":"https://api.github.com/users/kinecosystem","html_url":"https://github.com/kinecosystem","followers_url":"https://api.github.com/users/kinecosystem/followers","following_url":"https://api.github.com/users/kinecosystem/following{/other_user}","gists_url":"https://api.github.com/users/kinecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/kinecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinecosystem/subscriptions","organizations_url":"https://api.github.com/users/kinecosystem/orgs","repos_url":"https://api.github.com/users/kinecosystem/repos","events_url":"https://api.github.com/users/kinecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/kinecosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":120272671,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAyNzI2NzE=","name":"kin-ecosystem-android-sdk","full_name":"kinecosystem/kin-ecosystem-android-sdk","private":false,"owner":{"login":"kinecosystem","id":28860603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODYwNjAz","avatar_url":"https://avatars2.githubusercontent.com/u/28860603?v=4","gravatar_id":"","url":"https://api.github.com/users/kinecosystem","html_url":"https://github.com/kinecosystem","followers_url":"https://api.github.com/users/kinecosystem/followers","following_url":"https://api.github.com/users/kinecosystem/following{/other_user}","gists_url":"https://api.github.com/users/kinecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/kinecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinecosystem/subscriptions","organizations_url":"https://api.github.com/users/kinecosystem/orgs","repos_url":"https://api.github.com/users/kinecosystem/repos","events_url":"https://api.github.com/users/kinecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/kinecosystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kinecosystem/kin-ecosystem-android-sdk","description":"Add Kin ecosystem sdk to enable earn and spend opportunities in your app.","fork":false,"url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk","forks_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/forks","keys_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/teams","hooks_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/events","assignees_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/tags","blobs_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/languages","stargazers_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/subscription","commits_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/merges","archive_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/downloads","issues_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/deployments","created_at":"2018-02-05T07:56:03Z","updated_at":"2018-11-07T13:11:49Z","pushed_at":"2018-11-07T13:11:50Z","git_url":"git://github.com/kinecosystem/kin-ecosystem-android-sdk.git","ssh_url":"git@github.com:kinecosystem/kin-ecosystem-android-sdk.git","clone_url":"https://github.com/kinecosystem/kin-ecosystem-android-sdk.git","svn_url":"https://github.com/kinecosystem/kin-ecosystem-android-sdk","homepage":"","size":2908,"stargazers_count":22,"watchers_count":22,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":1,"watchers":22,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/pulls/185"},"html":{"href":"https://github.com/kinecosystem/kin-ecosystem-android-sdk/pull/185"},"issue":{"href":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/issues/185"},"comments":{"href":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/kinecosystem/kin-ecosystem-android-sdk/statuses/c85ca1295b277f39117f9d6c3dcf150b907fa3a2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"YohayBar"}}