{"action":"created","comment":{"url":"https://api.github.com/repos/pulp/pulp/pulls/comments/174906410","pull_request_review_id":104350362,"id":174906410,"diff_hunk":"@@ -115,10 +115,17 @@ class WorkerSerializer(ModelSerializer):\n     )\n \n     online = serializers.BooleanField(\n-        help_text='Whether the worker is online or not. Defaults to True.',\n+        help_text=_('Whether the worker is online'),\n+        read_only=True\n+    )\n+\n+    gracefully_stopped = serializers.BooleanField(\n+        help_text=_('If this worker is currently offline, this represents whether the worker \\\n+            was shut down properly, as opposed to e.g. crashed'),\n         read_only=True\n     )\n \n     class Meta:\n         model = models.Worker\n-        fields = ModelSerializer.Meta.fields + ('name', 'last_heartbeat', 'online')\n+        fields = ModelSerializer.Meta.fields + ('name', 'last_heartbeat',","path":"pulpcore/pulpcore/app/serializers/task.py","position":18,"original_position":18,"commit_id":"acf13c15303c56e6add24eb39c571b0454013af7","original_commit_id":"acf13c15303c56e6add24eb39c571b0454013af7","user":{"login":"dralley","id":2751996,"avatar_url":"https://avatars1.githubusercontent.com/u/2751996?v=4","gravatar_id":"","url":"https://api.github.com/users/dralley","html_url":"https://github.com/dralley","followers_url":"https://api.github.com/users/dralley/followers","following_url":"https://api.github.com/users/dralley/following{/other_user}","gists_url":"https://api.github.com/users/dralley/gists{/gist_id}","starred_url":"https://api.github.com/users/dralley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dralley/subscriptions","organizations_url":"https://api.github.com/users/dralley/orgs","repos_url":"https://api.github.com/users/dralley/repos","events_url":"https://api.github.com/users/dralley/events{/privacy}","received_events_url":"https://api.github.com/users/dralley/received_events","type":"User","site_admin":false},"body":"Here's the docs page: http://www.django-rest-framework.org/api-guide/serializers/#specifying-which-fields-to-include\r\n\r\nIt looks like it's ensuring that all of the fields specified to include on the base ModelSerializer are included on the final Model, but I'm not sure if there is a better way to accomplish this.  Maybe worth looking into.","created_at":"2018-03-15T19:34:25Z","updated_at":"2018-03-15T19:34:25Z","html_url":"https://github.com/pulp/pulp/pull/3369#discussion_r174906410","pull_request_url":"https://api.github.com/repos/pulp/pulp/pulls/3369","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments/174906410"},"html":{"href":"https://github.com/pulp/pulp/pull/3369#discussion_r174906410"},"pull_request":{"href":"https://api.github.com/repos/pulp/pulp/pulls/3369"}},"in_reply_to_id":174901967},"pull_request":{"url":"https://api.github.com/repos/pulp/pulp/pulls/3369","id":174497471,"html_url":"https://github.com/pulp/pulp/pull/3369","diff_url":"https://github.com/pulp/pulp/pull/3369.diff","patch_url":"https://github.com/pulp/pulp/pull/3369.patch","issue_url":"https://api.github.com/repos/pulp/pulp/issues/3369","number":3369,"state":"open","locked":false,"title":"Simplify worker 'online' state tracking","user":{"login":"dralley","id":2751996,"avatar_url":"https://avatars1.githubusercontent.com/u/2751996?v=4","gravatar_id":"","url":"https://api.github.com/users/dralley","html_url":"https://github.com/dralley","followers_url":"https://api.github.com/users/dralley/followers","following_url":"https://api.github.com/users/dralley/following{/other_user}","gists_url":"https://api.github.com/users/dralley/gists{/gist_id}","starred_url":"https://api.github.com/users/dralley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dralley/subscriptions","organizations_url":"https://api.github.com/users/dralley/orgs","repos_url":"https://api.github.com/users/dralley/repos","events_url":"https://api.github.com/users/dralley/events{/privacy}","received_events_url":"https://api.github.com/users/dralley/received_events","type":"User","site_admin":false},"body":"closes #3121\r\nhttps://pulp.plan.io/issues/3121","created_at":"2018-03-12T21:17:48Z","updated_at":"2018-03-15T19:34:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98c0ac613c167f363243135edf9c6e8dc418f201","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":415921585,"url":"https://api.github.com/repos/pulp/pulp/labels/3.0","name":"3.0","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pulp/pulp/pulls/3369/commits","review_comments_url":"https://api.github.com/repos/pulp/pulp/pulls/3369/comments","review_comment_url":"https://api.github.com/repos/pulp/pulp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pulp/pulp/issues/3369/comments","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/acf13c15303c56e6add24eb39c571b0454013af7","head":{"label":"dralley:3121-worker-online","ref":"3121-worker-online","sha":"acf13c15303c56e6add24eb39c571b0454013af7","user":{"login":"dralley","id":2751996,"avatar_url":"https://avatars1.githubusercontent.com/u/2751996?v=4","gravatar_id":"","url":"https://api.github.com/users/dralley","html_url":"https://github.com/dralley","followers_url":"https://api.github.com/users/dralley/followers","following_url":"https://api.github.com/users/dralley/following{/other_user}","gists_url":"https://api.github.com/users/dralley/gists{/gist_id}","starred_url":"https://api.github.com/users/dralley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dralley/subscriptions","organizations_url":"https://api.github.com/users/dralley/orgs","repos_url":"https://api.github.com/users/dralley/repos","events_url":"https://api.github.com/users/dralley/events{/privacy}","received_events_url":"https://api.github.com/users/dralley/received_events","type":"User","site_admin":false},"repo":{"id":103665728,"name":"pulp","full_name":"dralley/pulp","owner":{"login":"dralley","id":2751996,"avatar_url":"https://avatars1.githubusercontent.com/u/2751996?v=4","gravatar_id":"","url":"https://api.github.com/users/dralley","html_url":"https://github.com/dralley","followers_url":"https://api.github.com/users/dralley/followers","following_url":"https://api.github.com/users/dralley/following{/other_user}","gists_url":"https://api.github.com/users/dralley/gists{/gist_id}","starred_url":"https://api.github.com/users/dralley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dralley/subscriptions","organizations_url":"https://api.github.com/users/dralley/orgs","repos_url":"https://api.github.com/users/dralley/repos","events_url":"https://api.github.com/users/dralley/events{/privacy}","received_events_url":"https://api.github.com/users/dralley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dralley/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":true,"url":"https://api.github.com/repos/dralley/pulp","forks_url":"https://api.github.com/repos/dralley/pulp/forks","keys_url":"https://api.github.com/repos/dralley/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dralley/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dralley/pulp/teams","hooks_url":"https://api.github.com/repos/dralley/pulp/hooks","issue_events_url":"https://api.github.com/repos/dralley/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/dralley/pulp/events","assignees_url":"https://api.github.com/repos/dralley/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/dralley/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/dralley/pulp/tags","blobs_url":"https://api.github.com/repos/dralley/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dralley/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dralley/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/dralley/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dralley/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/dralley/pulp/languages","stargazers_url":"https://api.github.com/repos/dralley/pulp/stargazers","contributors_url":"https://api.github.com/repos/dralley/pulp/contributors","subscribers_url":"https://api.github.com/repos/dralley/pulp/subscribers","subscription_url":"https://api.github.com/repos/dralley/pulp/subscription","commits_url":"https://api.github.com/repos/dralley/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/dralley/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/dralley/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/dralley/pulp/issues/comments{/number}","contents_url":"https://api.github.com/repos/dralley/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/dralley/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dralley/pulp/merges","archive_url":"https://api.github.com/repos/dralley/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dralley/pulp/downloads","issues_url":"https://api.github.com/repos/dralley/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/dralley/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/dralley/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/dralley/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dralley/pulp/labels{/name}","releases_url":"https://api.github.com/repos/dralley/pulp/releases{/id}","deployments_url":"https://api.github.com/repos/dralley/pulp/deployments","created_at":"2017-09-15T14:22:26Z","updated_at":"2017-09-15T14:22:33Z","pushed_at":"2018-03-14T20:24:25Z","git_url":"git://github.com/dralley/pulp.git","ssh_url":"git@github.com:dralley/pulp.git","clone_url":"https://github.com/dralley/pulp.git","svn_url":"https://github.com/dralley/pulp","homepage":"","size":96686,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pulp:3.0-dev","ref":"3.0-dev","sha":"52f4862e16444d6fd46a28f842a6dccd4ad3a9c2","user":{"login":"pulp","id":2103606,"avatar_url":"https://avatars1.githubusercontent.com/u/2103606?v=4","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":5314652,"name":"pulp","full_name":"pulp/pulp","owner":{"login":"pulp","id":2103606,"avatar_url":"https://avatars1.githubusercontent.com/u/2103606?v=4","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulp/pulp","description":"Repository for Pulp platform code, including the server and base admin and consumer clients","fork":false,"url":"https://api.github.com/repos/pulp/pulp","forks_url":"https://api.github.com/repos/pulp/pulp/forks","keys_url":"https://api.github.com/repos/pulp/pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/pulp/teams","hooks_url":"https://api.github.com/repos/pulp/pulp/hooks","issue_events_url":"https://api.github.com/repos/pulp/pulp/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/pulp/events","assignees_url":"https://api.github.com/repos/pulp/pulp/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/pulp/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/pulp/tags","blobs_url":"https://api.github.com/repos/pulp/pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/pulp/languages","stargazers_url":"https://api.github.com/repos/pulp/pulp/stargazers","contributors_url":"https://api.github.com/repos/pulp/pulp/contributors","subscribers_url":"https://api.github.com/repos/pulp/pulp/subscribers","subscription_url":"https://api.github.com/repos/pulp/pulp/subscription","commits_url":"https://api.github.com/repos/pulp/pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/pulp/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulp/pulp/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/pulp/merges","archive_url":"https://api.github.com/repos/pulp/pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/pulp/downloads","issues_url":"https://api.github.com/repos/pulp/pulp/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/pulp/labels{/name}","releases_url":"https://api.github.com/repos/pulp/pulp/releases{/id}","deployments_url":"https://api.github.com/repos/pulp/pulp/deployments","created_at":"2012-08-06T13:49:20Z","updated_at":"2018-03-14T10:20:47Z","pushed_at":"2018-03-15T18:12:45Z","git_url":"git://github.com/pulp/pulp.git","ssh_url":"git@github.com:pulp/pulp.git","clone_url":"https://github.com/pulp/pulp.git","svn_url":"https://github.com/pulp/pulp","homepage":"","size":96717,"stargazers_count":356,"watchers_count":356,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":140,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":140,"open_issues":15,"watchers":356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp/pulls/3369"},"html":{"href":"https://github.com/pulp/pulp/pull/3369"},"issue":{"href":"https://api.github.com/repos/pulp/pulp/issues/3369"},"comments":{"href":"https://api.github.com/repos/pulp/pulp/issues/3369/comments"},"review_comments":{"href":"https://api.github.com/repos/pulp/pulp/pulls/3369/comments"},"review_comment":{"href":"https://api.github.com/repos/pulp/pulp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pulp/pulp/pulls/3369/commits"},"statuses":{"href":"https://api.github.com/repos/pulp/pulp/statuses/acf13c15303c56e6add24eb39c571b0454013af7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dralley"}}