{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/242427953","pull_request_review_id":185932470,"id":242427953,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjQyNzk1Mw==","diff_hunk":"@@ -15,21 +15,21 @@\n using Microsoft.ML.Runtime.Internal.Utilities;\n using Microsoft.ML.Runtime.Model;\n \n-[assembly: LoadableClass(typeof(FieldAwareFactorizationMachinePredictor), null, typeof(SignatureLoadModel), \"Field Aware Factorization Machine\", FieldAwareFactorizationMachinePredictor.LoaderSignature)]\n+[assembly: LoadableClass(typeof(FieldAwareFactorizationMachineModelParameters), null, typeof(SignatureLoadModel), \"Field Aware Factorization Machine\", FieldAwareFactorizationMachineModelParameters.LoaderSignature)]\n \n [assembly: LoadableClass(typeof(FieldAwareFactorizationMachinePredictionTransformer), typeof(FieldAwareFactorizationMachinePredictionTransformer), null, typeof(SignatureLoadModel),\n     \"\", FieldAwareFactorizationMachinePredictionTransformer.LoaderSignature)]\n \n namespace Microsoft.ML.Runtime.FactorizationMachine\n {\n-    public sealed class FieldAwareFactorizationMachinePredictor : PredictorBase<float>, ISchemaBindableMapper, ICanSaveModel\n+    public sealed class FieldAwareFactorizationMachineModelParameters : ModelParametersBase<float>, ISchemaBindableMapper\n     {\n-        public const string LoaderSignature = \"FieldAwareFactMacPredict\";\n+        internal const string LoaderSignature = \"FieldAwareFactMacPredict\";\n         public override PredictionKind PredictionKind => PredictionKind.BinaryClassification;\n         private bool _norm;\n-        internal int FieldCount { get; }\n-        internal int FeatureCount { get; }\n-        internal int LatentDim { get; }\n+        public int FieldCount { get; }","path":"src/Microsoft.ML.StandardLearners/FactorizationMachine/FieldAwareFactorizationMachineModelParameters.cs","position":22,"original_position":22,"commit_id":"d3ea4df4676e4075e42089f34c3963cf89756460","original_commit_id":"d3ea4df4676e4075e42089f34c3963cf89756460","user":{"login":"sfilipi","id":19392467,"node_id":"MDQ6VXNlcjE5MzkyNDY3","avatar_url":"https://avatars1.githubusercontent.com/u/19392467?v=4","gravatar_id":"","url":"https://api.github.com/users/sfilipi","html_url":"https://github.com/sfilipi","followers_url":"https://api.github.com/users/sfilipi/followers","following_url":"https://api.github.com/users/sfilipi/following{/other_user}","gists_url":"https://api.github.com/users/sfilipi/gists{/gist_id}","starred_url":"https://api.github.com/users/sfilipi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfilipi/subscriptions","organizations_url":"https://api.github.com/users/sfilipi/orgs","repos_url":"https://api.github.com/users/sfilipi/repos","events_url":"https://api.github.com/users/sfilipi/events{/privacy}","received_events_url":"https://api.github.com/users/sfilipi/received_events","type":"User","site_admin":false},"body":">public [](start = 8, length = 6)\r\n\r\nxml","created_at":"2018-12-18T07:20:32Z","updated_at":"2018-12-18T07:20:32Z","html_url":"https://github.com/dotnet/machinelearning/pull/1901#discussion_r242427953","pull_request_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1901","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/242427953"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/1901#discussion_r242427953"},"pull_request":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1901"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1901","id":239359056,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MzU5MDU2","html_url":"https://github.com/dotnet/machinelearning/pull/1901","diff_url":"https://github.com/dotnet/machinelearning/pull/1901.diff","patch_url":"https://github.com/dotnet/machinelearning/pull/1901.patch","issue_url":"https://api.github.com/repos/dotnet/machinelearning/issues/1901","number":1901,"state":"open","locked":false,"title":"Public API for remaining learners","user":{"login":"najeeb-kazmi","id":14131235,"node_id":"MDQ6VXNlcjE0MTMxMjM1","avatar_url":"https://avatars3.githubusercontent.com/u/14131235?v=4","gravatar_id":"","url":"https://api.github.com/users/najeeb-kazmi","html_url":"https://github.com/najeeb-kazmi","followers_url":"https://api.github.com/users/najeeb-kazmi/followers","following_url":"https://api.github.com/users/najeeb-kazmi/following{/other_user}","gists_url":"https://api.github.com/users/najeeb-kazmi/gists{/gist_id}","starred_url":"https://api.github.com/users/najeeb-kazmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/najeeb-kazmi/subscriptions","organizations_url":"https://api.github.com/users/najeeb-kazmi/orgs","repos_url":"https://api.github.com/users/najeeb-kazmi/repos","events_url":"https://api.github.com/users/najeeb-kazmi/events{/privacy}","received_events_url":"https://api.github.com/users/najeeb-kazmi/received_events","type":"User","site_admin":false},"body":"Fixes #1703 \r\n\r\nPredictors covered in this PR:\r\n- `EnsemblePredictorBase`\r\n- `EnsembleDistributionPredictor`\r\n- `EnsemblePredictor`\r\n- `EnsembleMultiClassPredictor`\r\n- `GamPredictorBase`\r\n- `BinaryClassificationGamPredictor`\r\n- `RegressionGamPredictor`\r\n- `PcaPredictor`\r\n- `FieldAwareFactorizationmachinePredictor`\r\n- MultiClassLogisticRegressionPredictor`\r\n- `MultiClassNaiveBayesPredictor`\r\n- `OvaPredictor`\r\n- `PkpdPredictor`\r\n- `RandomPredictor`\r\n- `PriorPredictor`\r\n","created_at":"2018-12-18T04:08:10Z","updated_at":"2018-12-18T07:20:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a583d07ea022edee901e8ece2847b4e28608608e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wschin","id":3524474,"node_id":"MDQ6VXNlcjM1MjQ0NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3524474?v=4","gravatar_id":"","url":"https://api.github.com/users/wschin","html_url":"https://github.com/wschin","followers_url":"https://api.github.com/users/wschin/followers","following_url":"https://api.github.com/users/wschin/following{/other_user}","gists_url":"https://api.github.com/users/wschin/gists{/gist_id}","starred_url":"https://api.github.com/users/wschin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wschin/subscriptions","organizations_url":"https://api.github.com/users/wschin/orgs","repos_url":"https://api.github.com/users/wschin/repos","events_url":"https://api.github.com/users/wschin/events{/privacy}","received_events_url":"https://api.github.com/users/wschin/received_events","type":"User","site_admin":false},{"login":"TomFinley","id":8295757,"node_id":"MDQ6VXNlcjgyOTU3NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/8295757?v=4","gravatar_id":"","url":"https://api.github.com/users/TomFinley","html_url":"https://github.com/TomFinley","followers_url":"https://api.github.com/users/TomFinley/followers","following_url":"https://api.github.com/users/TomFinley/following{/other_user}","gists_url":"https://api.github.com/users/TomFinley/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFinley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFinley/subscriptions","organizations_url":"https://api.github.com/users/TomFinley/orgs","repos_url":"https://api.github.com/users/TomFinley/repos","events_url":"https://api.github.com/users/TomFinley/events{/privacy}","received_events_url":"https://api.github.com/users/TomFinley/received_events","type":"User","site_admin":false},{"login":"Zruty0","id":41337831,"node_id":"MDQ6VXNlcjQxMzM3ODMx","avatar_url":"https://avatars1.githubusercontent.com/u/41337831?v=4","gravatar_id":"","url":"https://api.github.com/users/Zruty0","html_url":"https://github.com/Zruty0","followers_url":"https://api.github.com/users/Zruty0/followers","following_url":"https://api.github.com/users/Zruty0/following{/other_user}","gists_url":"https://api.github.com/users/Zruty0/gists{/gist_id}","starred_url":"https://api.github.com/users/Zruty0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zruty0/subscriptions","organizations_url":"https://api.github.com/users/Zruty0/orgs","repos_url":"https://api.github.com/users/Zruty0/repos","events_url":"https://api.github.com/users/Zruty0/events{/privacy}","received_events_url":"https://api.github.com/users/Zruty0/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1901/commits","review_comments_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1901/comments","review_comment_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/1901/comments","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/d3ea4df4676e4075e42089f34c3963cf89756460","head":{"label":"najeeb-kazmi:1703","ref":"1703","sha":"d3ea4df4676e4075e42089f34c3963cf89756460","user":{"login":"najeeb-kazmi","id":14131235,"node_id":"MDQ6VXNlcjE0MTMxMjM1","avatar_url":"https://avatars3.githubusercontent.com/u/14131235?v=4","gravatar_id":"","url":"https://api.github.com/users/najeeb-kazmi","html_url":"https://github.com/najeeb-kazmi","followers_url":"https://api.github.com/users/najeeb-kazmi/followers","following_url":"https://api.github.com/users/najeeb-kazmi/following{/other_user}","gists_url":"https://api.github.com/users/najeeb-kazmi/gists{/gist_id}","starred_url":"https://api.github.com/users/najeeb-kazmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/najeeb-kazmi/subscriptions","organizations_url":"https://api.github.com/users/najeeb-kazmi/orgs","repos_url":"https://api.github.com/users/najeeb-kazmi/repos","events_url":"https://api.github.com/users/najeeb-kazmi/events{/privacy}","received_events_url":"https://api.github.com/users/najeeb-kazmi/received_events","type":"User","site_admin":false},"repo":{"id":149672647,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2NzI2NDc=","name":"machinelearning","full_name":"najeeb-kazmi/machinelearning","private":false,"owner":{"login":"najeeb-kazmi","id":14131235,"node_id":"MDQ6VXNlcjE0MTMxMjM1","avatar_url":"https://avatars3.githubusercontent.com/u/14131235?v=4","gravatar_id":"","url":"https://api.github.com/users/najeeb-kazmi","html_url":"https://github.com/najeeb-kazmi","followers_url":"https://api.github.com/users/najeeb-kazmi/followers","following_url":"https://api.github.com/users/najeeb-kazmi/following{/other_user}","gists_url":"https://api.github.com/users/najeeb-kazmi/gists{/gist_id}","starred_url":"https://api.github.com/users/najeeb-kazmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/najeeb-kazmi/subscriptions","organizations_url":"https://api.github.com/users/najeeb-kazmi/orgs","repos_url":"https://api.github.com/users/najeeb-kazmi/repos","events_url":"https://api.github.com/users/najeeb-kazmi/events{/privacy}","received_events_url":"https://api.github.com/users/najeeb-kazmi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/najeeb-kazmi/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":true,"url":"https://api.github.com/repos/najeeb-kazmi/machinelearning","forks_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/forks","keys_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/teams","hooks_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/events","assignees_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/tags","blobs_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/languages","stargazers_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/subscription","commits_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/merges","archive_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/downloads","issues_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/najeeb-kazmi/machinelearning/deployments","created_at":"2018-09-20T21:27:47Z","updated_at":"2018-12-13T22:41:26Z","pushed_at":"2018-12-18T04:22:11Z","git_url":"git://github.com/najeeb-kazmi/machinelearning.git","ssh_url":"git@github.com:najeeb-kazmi/machinelearning.git","clone_url":"https://github.com/najeeb-kazmi/machinelearning.git","svn_url":"https://github.com/najeeb-kazmi/machinelearning","homepage":"https://dot.net/ml","size":32160,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"76d26d08b484871852f90b8961bc33015749e9c0","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":132021166,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMjExNjY=","name":"machinelearning","full_name":"dotnet/machinelearning","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":false,"url":"https://api.github.com/repos/dotnet/machinelearning","forks_url":"https://api.github.com/repos/dotnet/machinelearning/forks","keys_url":"https://api.github.com/repos/dotnet/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/machinelearning/teams","hooks_url":"https://api.github.com/repos/dotnet/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/machinelearning/events","assignees_url":"https://api.github.com/repos/dotnet/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/machinelearning/tags","blobs_url":"https://api.github.com/repos/dotnet/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/machinelearning/languages","stargazers_url":"https://api.github.com/repos/dotnet/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/dotnet/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/dotnet/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/dotnet/machinelearning/subscription","commits_url":"https://api.github.com/repos/dotnet/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/machinelearning/merges","archive_url":"https://api.github.com/repos/dotnet/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/machinelearning/downloads","issues_url":"https://api.github.com/repos/dotnet/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/machinelearning/deployments","created_at":"2018-05-03T16:20:42Z","updated_at":"2018-12-18T07:17:27Z","pushed_at":"2018-12-18T07:04:28Z","git_url":"git://github.com/dotnet/machinelearning.git","ssh_url":"git@github.com:dotnet/machinelearning.git","clone_url":"https://github.com/dotnet/machinelearning.git","svn_url":"https://github.com/dotnet/machinelearning","homepage":"https://dot.net/ml","size":31940,"stargazers_count":4373,"watchers_count":4373,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":841,"mirror_url":null,"archived":false,"open_issues_count":387,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":841,"open_issues":387,"watchers":4373,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1901"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/1901"},"issue":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/1901"},"comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/1901/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1901/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1901/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/machinelearning/statuses/d3ea4df4676e4075e42089f34c3963cf89756460"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sfilipi"}}