{"push_id":2351989200,"size":15,"distinct_size":15,"ref":"refs/heads/addpdfkit","head":"4502557cf0d6c0cf05377896c4983e46773342b1","before":"88d1d1718f39c2021e9872c4a9649cd5ed33df97","commits":[{"sha":"1bde95a3f33d77d396c23f66c701dd0a20d03778","author":{"name":"lozflan","email":"199ee4511d5267c01cd8fdc4ceefd419a98b7ca3@hlac.com.au"},"message":"fixed nav bar hiding on thumb scrubber tap by adding custom tap recogniser ontop of thumb scrubber. don't know why it works.\nnow refactoring scaleFactor reset to 1 before changing a display attribute using new setDisplayAttributeWithFullPageScaleFactor which captures scaleFactor, runs closure, and resets scale factor.\nissue - pdf view disappearing when applying this to the displayMode segmented control","distinct":true,"url":"https://api.github.com/repos/lozflan/Identi/commits/1bde95a3f33d77d396c23f66c701dd0a20d03778"},{"sha":"7017621833a0b5e6c5073499a5c1a8ac898db054","author":{"name":"lozflan","email":"199ee4511d5267c01cd8fdc4ceefd419a98b7ca3@hlac.com.au"},"message":"done. implemented setDisplayAttributeWithFullPageScaleFactor function and tested it works well with pageDisplay segmented control.\nnext testing with pageNavigatorSegmentedControll","distinct":true,"url":"https://api.github.com/repos/lozflan/Identi/commits/7017621833a0b5e6c5073499a5c1a8ac898db054"},{"sha":"cd02ce25fda4a6a1efbf7b1a418b7afe6ab31654","author":{"name":"lozflan","email":"199ee4511d5267c01cd8fdc4ceefd419a98b7ca3@hlac.com.au"},"message":"previous problem with pagination all fixed with setDisplayAttributeWithFullPageScaleFactor\nnow working on adding left border to thumb scrubber.","distinct":true,"url":"https://api.github.com/repos/lozflan/Identi/commits/cd02ce25fda4a6a1efbf7b1a418b7afe6ab31654"},{"sha":"359f84b9f1696bb4a4308fc78c3a289806302aef","author":{"name":"lozflan","email":"199ee4511d5267c01cd8fdc4ceefd419a98b7ca3@hlac.com.au"},"message":"done thumbnail scrubber left border.\nnext try to fix constraints error in console","distinct":true,"url":"https://api.github.com/repos/lozflan/Identi/commits/359f84b9f1696bb4a4308fc78c3a289806302aef"},{"sha":"7b4cc5cc1d8b6750531da691305889cca01f89c2","author":{"name":"lozflan","email":"199ee4511d5267c01cd8fdc4ceefd419a98b7ca3@hlac.com.au"},"message":"fixed thumb scrubber layout constraint conflict by changing top and bottom to priority 999. seems there was some conflict with thumb scrubber and top of pdfCollectionView","distinct":true,"url":"https://api.github.com/repos/lozflan/Identi/commits/7b4cc5cc1d8b6750531da691305889cca01f89c2"},{"sha":"a339c40658897f3a17d3965cc4b52aba74b3844d","author":{"name":"lozflan","email":"199ee4511d5267c01cd8fdc4ceefd419a98b7ca3@hlac.com.au"},"message":"all working well. next do review to work out next things to work on","distinct":true,"url":"https://api.github.com/repos/lozflan/Identi/commits/a339c40658897f3a17d3965cc4b52aba74b3844d"},{"sha":"605cee23a7eb000fb330aab4e5539d8209699926","author":{"name":"lozflan","email":"199ee4511d5267c01cd8fdc4ceefd419a98b7ca3@hlac.com.au"},"message":"done. change displayMode segmented control to change to scaleFactorForSizeToFit if going to 2up and pageScale larger than scaleFactorForSizeToFit ... can't think of time when user would want 2up page scale to be larger than this","distinct":true,"url":"https://api.github.com/repos/lozflan/Identi/commits/605cee23a7eb000fb330aab4e5539d8209699926"},{"sha":"01d2201ff2732a9595ed00d64990ea961a5bdd5e","author":{"name":"lozflan","email":"199ee4511d5267c01cd8fdc4ceefd419a98b7ca3@hlac.com.au"},"message":"in progress. adding page history navigator ie page history segmented control. working using enabling segments but issue with small page size again causing thumb scrubber to not go to page selected","distinct":true,"url":"https://api.github.com/repos/lozflan/Identi/commits/01d2201ff2732a9595ed00d64990ea961a5bdd5e"},{"sha":"e402cd31f2d9da9abfce9753afc1d29fc84d85a4","author":{"name":"lozflan","email":"199ee4511d5267c01cd8fdc4ceefd419a98b7ca3@hlac.com.au"},"message":"in progress. pageChangedObserver getting called twice when scaleFactor < ~.75 ... strange but may give opportunity to reset the scaleFactor to previous on the second run","distinct":true,"url":"https://api.github.com/repos/lozflan/Identi/commits/e402cd31f2d9da9abfce9753afc1d29fc84d85a4"},{"sha":"e7b4dd2ff4311022bf1de7f0fb3b149e26ebd188","author":{"name":"lozflan","email":"199ee4511d5267c01cd8fdc4ceefd419a98b7ca3@hlac.com.au"},"message":"in progress. still working in change page observer to see if i can set scaleFactor to allow correct nav on thumbnail tap","distinct":true,"url":"https://api.github.com/repos/lozflan/Identi/commits/e7b4dd2ff4311022bf1de7f0fb3b149e26ebd188"},{"sha":"76de8c7f20336a87d89fdf980c245e81ae915c41","author":{"name":"lozflan","email":"199ee4511d5267c01cd8fdc4ceefd419a98b7ca3@hlac.com.au"},"message":"done. thumbnailView navigation scaleFactor issue. Thought i couldn't use setDisplayAttributeWithFullPageScaleFactor but turns out i can bc all i need is a ref to the current page and then to navigate to that page when the scaleFactor is set to 1.0\nnext.\n- text this works properly\n- maybe look at multi select in thumb view\n- maybe check other pdf sample apps for next desired functionality","distinct":true,"url":"https://api.github.com/repos/lozflan/Identi/commits/76de8c7f20336a87d89fdf980c245e81ae915c41"},{"sha":"a994333a14485a597c29025aafc16683788be863","author":{"name":"lozflan","email":"199ee4511d5267c01cd8fdc4ceefd419a98b7ca3@hlac.com.au"},"message":"in progress. have fixed nav problem with <0.75 scale in thumbnailView but now have that code being called if just scrolling thru pdf doc and that is stopping smooth scrolling.\nneed to see how to call this only if page changed from thumnailView press rather than from scroll.\nmaybe can put code in thumbnail view recogniser instead or find out if page is scrolling and prevent code running if so","distinct":true,"url":"https://api.github.com/repos/lozflan/Identi/commits/a994333a14485a597c29025aafc16683788be863"},{"sha":"476fc757c8b59cbbb5eeb5d9a227950a9a142e40","author":{"name":"lozflan","email":"199ee4511d5267c01cd8fdc4ceefd419a98b7ca3@hlac.com.au"},"message":"Page change observer calling scale fixer even on scroll problem (interrupting scroll).\n- tried setting VC and PDFView as scrollView delegate - not working\n- tried adding swipe recogniser to pdfView. working but will have to add .up, .down, and pan recognisers also so bit of an extensive hack.\n- try going over pdfview methods and thumbnailView options again.","distinct":true,"url":"https://api.github.com/repos/lozflan/Identi/commits/476fc757c8b59cbbb5eeb5d9a227950a9a142e40"},{"sha":"a2e5f6f047fbd81a53145601ab399c06440fb949","author":{"name":"lozflan","email":"199ee4511d5267c01cd8fdc4ceefd419a98b7ca3@hlac.com.au"},"message":"in progress. still working through intercepting touch on pdfView. for flexibility probably good to have custom view in between main view and subviews. test this by copying a new version of the VC in storyboard.\nalso can subclass pdfview itself so try that either as well or as an alternative","distinct":true,"url":"https://api.github.com/repos/lozflan/Identi/commits/a2e5f6f047fbd81a53145601ab399c06440fb949"},{"sha":"4502557cf0d6c0cf05377896c4983e46773342b1","author":{"name":"lozflan","email":"199ee4511d5267c01cd8fdc4ceefd419a98b7ca3@hlac.com.au"},"message":"restructure of pdf view controller to have custom view in between VC main view and pdf related subviews and subclass pdfview\ndone - new SB pdfVC working with superview inserted. have not yet subclassed the new superview but nav bar hides and all look ok.\nnext -\n- further check all good and maybe subclass the new view to see if i can intercept hit testing.\n- subclass pdf view to see what this allows","distinct":true,"url":"https://api.github.com/repos/lozflan/Identi/commits/4502557cf0d6c0cf05377896c4983e46773342b1"}]}
{"actor":{"display_login":"lozflan"}}