{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/235546231","pull_request_review_id":177438244,"id":235546231,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTU0NjIzMQ==","diff_hunk":"@@ -65,7 +65,7 @@ private[deploy] object DependencyUtils extends Logging {\n       .map {\n         resolveGlobPaths(_, hadoopConf)\n           .split(\",\")\n-          .filterNot(_.contains(userJar.split(\"/\").last))\n+          .filterNot(_.contains(userJar.split(System.getProperty(\"file.separator\")).last))","path":"core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala","position":5,"original_position":5,"commit_id":"09cb210ce2092338f954467926b6cacd09d60eec","original_commit_id":"09cb210ce2092338f954467926b6cacd09d60eec","user":{"login":"srowen","id":822522,"node_id":"MDQ6VXNlcjgyMjUyMg==","avatar_url":"https://avatars0.githubusercontent.com/u/822522?v=4","gravatar_id":"","url":"https://api.github.com/users/srowen","html_url":"https://github.com/srowen","followers_url":"https://api.github.com/users/srowen/followers","following_url":"https://api.github.com/users/srowen/following{/other_user}","gists_url":"https://api.github.com/users/srowen/gists{/gist_id}","starred_url":"https://api.github.com/users/srowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srowen/subscriptions","organizations_url":"https://api.github.com/users/srowen/orgs","repos_url":"https://api.github.com/users/srowen/repos","events_url":"https://api.github.com/users/srowen/events{/privacy}","received_events_url":"https://api.github.com/users/srowen/received_events","type":"User","site_admin":false},"body":"`File.separator` is better","created_at":"2018-11-21T21:40:03Z","updated_at":"2018-11-21T21:40:31Z","html_url":"https://github.com/apache/spark/pull/23102#discussion_r235546231","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/23102","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/235546231"},"html":{"href":"https://github.com/apache/spark/pull/23102#discussion_r235546231"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/23102"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/23102","id":232605534,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjA1NTM0","html_url":"https://github.com/apache/spark/pull/23102","diff_url":"https://github.com/apache/spark/pull/23102.diff","patch_url":"https://github.com/apache/spark/pull/23102.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/23102","number":23102,"state":"open","locked":false,"title":"[SPARK-26137][CORE] Use Java system property \"file.separator\" inste…","user":{"login":"markpavey","id":17084885,"node_id":"MDQ6VXNlcjE3MDg0ODg1","avatar_url":"https://avatars0.githubusercontent.com/u/17084885?v=4","gravatar_id":"","url":"https://api.github.com/users/markpavey","html_url":"https://github.com/markpavey","followers_url":"https://api.github.com/users/markpavey/followers","following_url":"https://api.github.com/users/markpavey/following{/other_user}","gists_url":"https://api.github.com/users/markpavey/gists{/gist_id}","starred_url":"https://api.github.com/users/markpavey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markpavey/subscriptions","organizations_url":"https://api.github.com/users/markpavey/orgs","repos_url":"https://api.github.com/users/markpavey/repos","events_url":"https://api.github.com/users/markpavey/events{/privacy}","received_events_url":"https://api.github.com/users/markpavey/received_events","type":"User","site_admin":false},"body":"… of hard coded \"/\" in DependencyUtils\r\n\r\n## What changes were proposed in this pull request?\r\n\r\nUse Java system property \"file.separator\" instead of hard coded \"/\" in DependencyUtils.\r\n\r\n## How was this patch tested?\r\n\r\nManual test\r\n","created_at":"2018-11-21T10:12:04Z","updated_at":"2018-11-21T21:40:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9e8a4f53e78ee69346bf3daa8c1b534734e9afa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/23102/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/23102/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/23102/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/09cb210ce2092338f954467926b6cacd09d60eec","head":{"label":"thefilter:JIRA_SPARK-26137_DependencyUtilsFileSeparatorFix","ref":"JIRA_SPARK-26137_DependencyUtilsFileSeparatorFix","sha":"09cb210ce2092338f954467926b6cacd09d60eec","user":{"login":"thefilter","id":5197904,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxOTc5MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5197904?v=4","gravatar_id":"","url":"https://api.github.com/users/thefilter","html_url":"https://github.com/thefilter","followers_url":"https://api.github.com/users/thefilter/followers","following_url":"https://api.github.com/users/thefilter/following{/other_user}","gists_url":"https://api.github.com/users/thefilter/gists{/gist_id}","starred_url":"https://api.github.com/users/thefilter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefilter/subscriptions","organizations_url":"https://api.github.com/users/thefilter/orgs","repos_url":"https://api.github.com/users/thefilter/repos","events_url":"https://api.github.com/users/thefilter/events{/privacy}","received_events_url":"https://api.github.com/users/thefilter/received_events","type":"Organization","site_admin":false},"repo":{"id":158418726,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg0MTg3MjY=","name":"spark","full_name":"thefilter/spark","private":false,"owner":{"login":"thefilter","id":5197904,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxOTc5MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5197904?v=4","gravatar_id":"","url":"https://api.github.com/users/thefilter","html_url":"https://github.com/thefilter","followers_url":"https://api.github.com/users/thefilter/followers","following_url":"https://api.github.com/users/thefilter/following{/other_user}","gists_url":"https://api.github.com/users/thefilter/gists{/gist_id}","starred_url":"https://api.github.com/users/thefilter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefilter/subscriptions","organizations_url":"https://api.github.com/users/thefilter/orgs","repos_url":"https://api.github.com/users/thefilter/repos","events_url":"https://api.github.com/users/thefilter/events{/privacy}","received_events_url":"https://api.github.com/users/thefilter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thefilter/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/thefilter/spark","forks_url":"https://api.github.com/repos/thefilter/spark/forks","keys_url":"https://api.github.com/repos/thefilter/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thefilter/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thefilter/spark/teams","hooks_url":"https://api.github.com/repos/thefilter/spark/hooks","issue_events_url":"https://api.github.com/repos/thefilter/spark/issues/events{/number}","events_url":"https://api.github.com/repos/thefilter/spark/events","assignees_url":"https://api.github.com/repos/thefilter/spark/assignees{/user}","branches_url":"https://api.github.com/repos/thefilter/spark/branches{/branch}","tags_url":"https://api.github.com/repos/thefilter/spark/tags","blobs_url":"https://api.github.com/repos/thefilter/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thefilter/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thefilter/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/thefilter/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thefilter/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/thefilter/spark/languages","stargazers_url":"https://api.github.com/repos/thefilter/spark/stargazers","contributors_url":"https://api.github.com/repos/thefilter/spark/contributors","subscribers_url":"https://api.github.com/repos/thefilter/spark/subscribers","subscription_url":"https://api.github.com/repos/thefilter/spark/subscription","commits_url":"https://api.github.com/repos/thefilter/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/thefilter/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/thefilter/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/thefilter/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/thefilter/spark/contents/{+path}","compare_url":"https://api.github.com/repos/thefilter/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thefilter/spark/merges","archive_url":"https://api.github.com/repos/thefilter/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thefilter/spark/downloads","issues_url":"https://api.github.com/repos/thefilter/spark/issues{/number}","pulls_url":"https://api.github.com/repos/thefilter/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/thefilter/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/thefilter/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thefilter/spark/labels{/name}","releases_url":"https://api.github.com/repos/thefilter/spark/releases{/id}","deployments_url":"https://api.github.com/repos/thefilter/spark/deployments","created_at":"2018-11-20T16:22:22Z","updated_at":"2018-11-20T16:22:51Z","pushed_at":"2018-11-21T10:10:31Z","git_url":"git://github.com/thefilter/spark.git","ssh_url":"git@github.com:thefilter/spark.git","clone_url":"https://github.com/thefilter/spark.git","svn_url":"https://github.com/thefilter/spark","homepage":null,"size":287108,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a480a6256318b43b963fb7414ccb789e4b950c8b","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-11-21T21:31:09Z","pushed_at":"2018-11-21T20:30:59Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":287206,"stargazers_count":19563,"watchers_count":19563,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17473,"mirror_url":null,"archived":false,"open_issues_count":509,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17473,"open_issues":509,"watchers":19563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/23102"},"html":{"href":"https://github.com/apache/spark/pull/23102"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/23102"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/23102/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/23102/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/23102/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/09cb210ce2092338f954467926b6cacd09d60eec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"srowen"}}