{"action":"created","comment":{"url":"https://api.github.com/repos/discourse/discourse/pulls/comments/203171090","pull_request_review_id":138009570,"id":203171090,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzE3MTA5MA==","diff_hunk":"@@ -40,6 +40,18 @@ export default Ember.Controller.extend(CanCheckEmails, {\n       .join(\", \");\n   },\n \n+  @computed(\"model.associated_accounts\")\n+  associatedAccountsLoaded(associatedAccounts) {\n+    return associatedAccounts !== undefined;","path":"app/assets/javascripts/admin/controllers/admin-user-index.js.es6","position":6,"original_position":6,"commit_id":"53813b54a2f589f1805578e408285dae285cec78","original_commit_id":"53813b54a2f589f1805578e408285dae285cec78","user":{"login":"jjaffeux","id":339945,"node_id":"MDQ6VXNlcjMzOTk0NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/339945?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaffeux","html_url":"https://github.com/jjaffeux","followers_url":"https://api.github.com/users/jjaffeux/followers","following_url":"https://api.github.com/users/jjaffeux/following{/other_user}","gists_url":"https://api.github.com/users/jjaffeux/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaffeux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaffeux/subscriptions","organizations_url":"https://api.github.com/users/jjaffeux/orgs","repos_url":"https://api.github.com/users/jjaffeux/repos","events_url":"https://api.github.com/users/jjaffeux/events{/privacy}","received_events_url":"https://api.github.com/users/jjaffeux/received_events","type":"User","site_admin":false},"body":"check other comment on using typeof here instead","created_at":"2018-07-17T20:42:20Z","updated_at":"2018-07-17T20:42:21Z","html_url":"https://github.com/discourse/discourse/pull/6099#discussion_r203171090","pull_request_url":"https://api.github.com/repos/discourse/discourse/pulls/6099","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/discourse/discourse/pulls/comments/203171090"},"html":{"href":"https://github.com/discourse/discourse/pull/6099#discussion_r203171090"},"pull_request":{"href":"https://api.github.com/repos/discourse/discourse/pulls/6099"}}},"pull_request":{"url":"https://api.github.com/repos/discourse/discourse/pulls/6099","id":201988646,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxOTg4NjQ2","html_url":"https://github.com/discourse/discourse/pull/6099","diff_url":"https://github.com/discourse/discourse/pull/6099.diff","patch_url":"https://github.com/discourse/discourse/pull/6099.patch","issue_url":"https://api.github.com/repos/discourse/discourse/issues/6099","number":6099,"state":"open","locked":false,"title":"FEATURE: Social auth improvements","user":{"login":"davidtaylorhq","id":6270921,"node_id":"MDQ6VXNlcjYyNzA5MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/6270921?v=4","gravatar_id":"","url":"https://api.github.com/users/davidtaylorhq","html_url":"https://github.com/davidtaylorhq","followers_url":"https://api.github.com/users/davidtaylorhq/followers","following_url":"https://api.github.com/users/davidtaylorhq/following{/other_user}","gists_url":"https://api.github.com/users/davidtaylorhq/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtaylorhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtaylorhq/subscriptions","organizations_url":"https://api.github.com/users/davidtaylorhq/orgs","repos_url":"https://api.github.com/users/davidtaylorhq/repos","events_url":"https://api.github.com/users/davidtaylorhq/events{/privacy}","received_events_url":"https://api.github.com/users/davidtaylorhq/received_events","type":"User","site_admin":false},"body":"This is the start of work to add revoke and reconnect for social logins.\r\n\r\n## Visible/functional changes:\r\n- Additional section under `/my/preferences/account` which lists all connected accounts. \r\n- For providers with support, it is possible to revoke and reconnect accounts. \r\n- Currently this only actually works for Facebook, but more providers will be added soon.\r\n\r\n## Screenshots:\r\n![screen shot 2018-07-17 at 16 23 48](https://user-images.githubusercontent.com/6270921/42828173-0a6e40b6-89e0-11e8-8dda-c41ae3483cc2.png)\r\n\r\n![screen shot 2018-07-17 at 16 24 05](https://user-images.githubusercontent.com/6270921/42828178-0c52a8cc-89e0-11e8-9022-9703baa5939d.png)\r\n\r\n\r\n## Under-the-hood changes:\r\n- Moved client-side social login code from the login controller to `login_method.js.es6`, so that it can be used for reconnecting accounts\r\n- `user.associated_accounts` is now an array of objects, rather than a single string\r\n- New endpoint for revoking an auth provider\r\n- Plugin authenticators are now stored in the `PluginRegistry`, to match up with other similar plugin-contributed functionality\r\n- Plugin and core authentication providers are now ‘equal citizens` on the server side - no more copy/pasting for facebook/twitter/instagram etc.\r\n- Each authenticator can now implement:\r\n    - `enabled?`\r\n    - `description_for_user`\r\n    - `can_revoke?`\r\n    - `can_connect_existing_user?`\r\n    - `revoke`\r\n- Revoke and reconnect ability added to facebook_authenticator\r\n\r\nThe plugin API remains identical. For now, plugins that have not defined `enabled?` will log a warning, but will still function fine.","created_at":"2018-07-17T15:51:52Z","updated_at":"2018-07-17T20:42:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84de6c26f7a29367c3d12785c6022889ebde1815","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/discourse/discourse/pulls/6099/commits","review_comments_url":"https://api.github.com/repos/discourse/discourse/pulls/6099/comments","review_comment_url":"https://api.github.com/repos/discourse/discourse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/discourse/discourse/issues/6099/comments","statuses_url":"https://api.github.com/repos/discourse/discourse/statuses/53813b54a2f589f1805578e408285dae285cec78","head":{"label":"discourse:social-auth-improvements","ref":"social-auth-improvements","sha":"53813b54a2f589f1805578e408285dae285cec78","user":{"login":"discourse","id":3220138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjAxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3220138?v=4","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"repo":{"id":7569578,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY5NTc4","name":"discourse","full_name":"discourse/discourse","owner":{"login":"discourse","id":3220138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjAxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3220138?v=4","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/discourse/discourse","description":"A platform for community discussion. Free, open, simple.","fork":false,"url":"https://api.github.com/repos/discourse/discourse","forks_url":"https://api.github.com/repos/discourse/discourse/forks","keys_url":"https://api.github.com/repos/discourse/discourse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/discourse/discourse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/discourse/discourse/teams","hooks_url":"https://api.github.com/repos/discourse/discourse/hooks","issue_events_url":"https://api.github.com/repos/discourse/discourse/issues/events{/number}","events_url":"https://api.github.com/repos/discourse/discourse/events","assignees_url":"https://api.github.com/repos/discourse/discourse/assignees{/user}","branches_url":"https://api.github.com/repos/discourse/discourse/branches{/branch}","tags_url":"https://api.github.com/repos/discourse/discourse/tags","blobs_url":"https://api.github.com/repos/discourse/discourse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/discourse/discourse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/discourse/discourse/git/refs{/sha}","trees_url":"https://api.github.com/repos/discourse/discourse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/discourse/discourse/statuses/{sha}","languages_url":"https://api.github.com/repos/discourse/discourse/languages","stargazers_url":"https://api.github.com/repos/discourse/discourse/stargazers","contributors_url":"https://api.github.com/repos/discourse/discourse/contributors","subscribers_url":"https://api.github.com/repos/discourse/discourse/subscribers","subscription_url":"https://api.github.com/repos/discourse/discourse/subscription","commits_url":"https://api.github.com/repos/discourse/discourse/commits{/sha}","git_commits_url":"https://api.github.com/repos/discourse/discourse/git/commits{/sha}","comments_url":"https://api.github.com/repos/discourse/discourse/comments{/number}","issue_comment_url":"https://api.github.com/repos/discourse/discourse/issues/comments{/number}","contents_url":"https://api.github.com/repos/discourse/discourse/contents/{+path}","compare_url":"https://api.github.com/repos/discourse/discourse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/discourse/discourse/merges","archive_url":"https://api.github.com/repos/discourse/discourse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/discourse/discourse/downloads","issues_url":"https://api.github.com/repos/discourse/discourse/issues{/number}","pulls_url":"https://api.github.com/repos/discourse/discourse/pulls{/number}","milestones_url":"https://api.github.com/repos/discourse/discourse/milestones{/number}","notifications_url":"https://api.github.com/repos/discourse/discourse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/discourse/discourse/labels{/name}","releases_url":"https://api.github.com/repos/discourse/discourse/releases{/id}","deployments_url":"https://api.github.com/repos/discourse/discourse/deployments","created_at":"2013-01-12T00:25:55Z","updated_at":"2018-07-17T19:05:23Z","pushed_at":"2018-07-17T20:05:12Z","git_url":"git://github.com/discourse/discourse.git","ssh_url":"git@github.com:discourse/discourse.git","clone_url":"https://github.com/discourse/discourse.git","svn_url":"https://github.com/discourse/discourse","homepage":"https://www.discourse.org","size":225154,"stargazers_count":25545,"watchers_count":25545,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6129,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6129,"open_issues":12,"watchers":25545,"default_branch":"master"}},"base":{"label":"discourse:master","ref":"master","sha":"202b839208d4127b73d2206dc1a96efe408b7bd8","user":{"login":"discourse","id":3220138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjAxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3220138?v=4","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"repo":{"id":7569578,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY5NTc4","name":"discourse","full_name":"discourse/discourse","owner":{"login":"discourse","id":3220138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjAxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3220138?v=4","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/discourse/discourse","description":"A platform for community discussion. Free, open, simple.","fork":false,"url":"https://api.github.com/repos/discourse/discourse","forks_url":"https://api.github.com/repos/discourse/discourse/forks","keys_url":"https://api.github.com/repos/discourse/discourse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/discourse/discourse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/discourse/discourse/teams","hooks_url":"https://api.github.com/repos/discourse/discourse/hooks","issue_events_url":"https://api.github.com/repos/discourse/discourse/issues/events{/number}","events_url":"https://api.github.com/repos/discourse/discourse/events","assignees_url":"https://api.github.com/repos/discourse/discourse/assignees{/user}","branches_url":"https://api.github.com/repos/discourse/discourse/branches{/branch}","tags_url":"https://api.github.com/repos/discourse/discourse/tags","blobs_url":"https://api.github.com/repos/discourse/discourse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/discourse/discourse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/discourse/discourse/git/refs{/sha}","trees_url":"https://api.github.com/repos/discourse/discourse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/discourse/discourse/statuses/{sha}","languages_url":"https://api.github.com/repos/discourse/discourse/languages","stargazers_url":"https://api.github.com/repos/discourse/discourse/stargazers","contributors_url":"https://api.github.com/repos/discourse/discourse/contributors","subscribers_url":"https://api.github.com/repos/discourse/discourse/subscribers","subscription_url":"https://api.github.com/repos/discourse/discourse/subscription","commits_url":"https://api.github.com/repos/discourse/discourse/commits{/sha}","git_commits_url":"https://api.github.com/repos/discourse/discourse/git/commits{/sha}","comments_url":"https://api.github.com/repos/discourse/discourse/comments{/number}","issue_comment_url":"https://api.github.com/repos/discourse/discourse/issues/comments{/number}","contents_url":"https://api.github.com/repos/discourse/discourse/contents/{+path}","compare_url":"https://api.github.com/repos/discourse/discourse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/discourse/discourse/merges","archive_url":"https://api.github.com/repos/discourse/discourse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/discourse/discourse/downloads","issues_url":"https://api.github.com/repos/discourse/discourse/issues{/number}","pulls_url":"https://api.github.com/repos/discourse/discourse/pulls{/number}","milestones_url":"https://api.github.com/repos/discourse/discourse/milestones{/number}","notifications_url":"https://api.github.com/repos/discourse/discourse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/discourse/discourse/labels{/name}","releases_url":"https://api.github.com/repos/discourse/discourse/releases{/id}","deployments_url":"https://api.github.com/repos/discourse/discourse/deployments","created_at":"2013-01-12T00:25:55Z","updated_at":"2018-07-17T19:05:23Z","pushed_at":"2018-07-17T20:05:12Z","git_url":"git://github.com/discourse/discourse.git","ssh_url":"git@github.com:discourse/discourse.git","clone_url":"https://github.com/discourse/discourse.git","svn_url":"https://github.com/discourse/discourse","homepage":"https://www.discourse.org","size":225154,"stargazers_count":25545,"watchers_count":25545,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6129,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6129,"open_issues":12,"watchers":25545,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/discourse/discourse/pulls/6099"},"html":{"href":"https://github.com/discourse/discourse/pull/6099"},"issue":{"href":"https://api.github.com/repos/discourse/discourse/issues/6099"},"comments":{"href":"https://api.github.com/repos/discourse/discourse/issues/6099/comments"},"review_comments":{"href":"https://api.github.com/repos/discourse/discourse/pulls/6099/comments"},"review_comment":{"href":"https://api.github.com/repos/discourse/discourse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/discourse/discourse/pulls/6099/commits"},"statuses":{"href":"https://api.github.com/repos/discourse/discourse/statuses/53813b54a2f589f1805578e408285dae285cec78"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jjaffeux"}}