{"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/170599524","pull_request_review_id":99301874,"id":170599524,"diff_hunk":"@@ -292,7 +338,7 @@ def read_weight(self):\n \n     def set_zero(self):\n         with self.scalelock:\n-            if self.device:\n+            if self.device and self.protocol.commandSupport:","path":"addons/hw_scale/controllers/main.py","position":190,"original_position":190,"commit_id":"d6b496028ef578252acd2fd728aaa5819222e3ff","original_commit_id":"d6b496028ef578252acd2fd728aaa5819222e3ff","user":{"login":"pimodoo","id":20767708,"avatar_url":"https://avatars2.githubusercontent.com/u/20767708?v=4","gravatar_id":"","url":"https://api.github.com/users/pimodoo","html_url":"https://github.com/pimodoo","followers_url":"https://api.github.com/users/pimodoo/followers","following_url":"https://api.github.com/users/pimodoo/following{/other_user}","gists_url":"https://api.github.com/users/pimodoo/gists{/gist_id}","starred_url":"https://api.github.com/users/pimodoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pimodoo/subscriptions","organizations_url":"https://api.github.com/users/pimodoo/orgs","repos_url":"https://api.github.com/users/pimodoo/repos","events_url":"https://api.github.com/users/pimodoo/events{/privacy}","received_events_url":"https://api.github.com/users/pimodoo/received_events","type":"User","site_admin":false},"body":"if self.device and self.protocol.zeroCommand ","created_at":"2018-02-26T14:02:08Z","updated_at":"2018-02-26T14:05:06Z","html_url":"https://github.com/odoo/odoo/pull/23317#discussion_r170599524","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/23317","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/170599524"},"html":{"href":"https://github.com/odoo/odoo/pull/23317#discussion_r170599524"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/23317"}}},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/23317","id":171328675,"html_url":"https://github.com/odoo/odoo/pull/23317","diff_url":"https://github.com/odoo/odoo/pull/23317.diff","patch_url":"https://github.com/odoo/odoo/pull/23317.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/23317","number":23317,"state":"open","locked":false,"title":"Master hw scale driver pat","user":{"login":"pat-odoo","id":24875578,"avatar_url":"https://avatars2.githubusercontent.com/u/24875578?v=4","gravatar_id":"","url":"https://api.github.com/users/pat-odoo","html_url":"https://github.com/pat-odoo","followers_url":"https://api.github.com/users/pat-odoo/followers","following_url":"https://api.github.com/users/pat-odoo/following{/other_user}","gists_url":"https://api.github.com/users/pat-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/pat-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pat-odoo/subscriptions","organizations_url":"https://api.github.com/users/pat-odoo/orgs","repos_url":"https://api.github.com/users/pat-odoo/repos","events_url":"https://api.github.com/users/pat-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/pat-odoo/received_events","type":"User","site_admin":false},"body":"Task : https://www.odoo.com/web#id=58750&view_type=form&model=project.task&action=327&menu_id=4720\r\n\r\nPad : https://pad.odoo.com/p/r.757b843ffe7eb51b27c343234c979d05\r\n\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n","created_at":"2018-02-26T10:03:16Z","updated_at":"2018-02-26T14:05:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e466f461acef0ba5347a114886918e97f688ccd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/23317/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/23317/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/23317/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/d6b496028ef578252acd2fd728aaa5819222e3ff","head":{"label":"odoo-dev:master-hw_scale-driver-pat","ref":"master-hw_scale-driver-pat","sha":"d6b496028ef578252acd2fd728aaa5819222e3ff","user":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars0.githubusercontent.com/u/7466976?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"name":"odoo","full_name":"odoo-dev/odoo","owner":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars0.githubusercontent.com/u/7466976?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo-dev/odoo/deployments","created_at":"2014-05-16T11:16:19Z","updated_at":"2018-02-09T02:21:02Z","pushed_at":"2018-02-26T14:04:13Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"git@github.com:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":2014197,"stargazers_count":74,"watchers_count":74,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":38,"open_issues":0,"watchers":74,"default_branch":"master"}},"base":{"label":"odoo:master","ref":"master","sha":"a0d7763e099a35c0ad374a2d05dc5598404a6535","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo. Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2018-02-26T13:28:10Z","pushed_at":"2018-02-26T14:04:17Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1971517,"stargazers_count":8860,"watchers_count":8860,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7679,"mirror_url":null,"archived":false,"open_issues_count":2562,"license":null,"forks":7679,"open_issues":2562,"watchers":8860,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/23317"},"html":{"href":"https://github.com/odoo/odoo/pull/23317"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/23317"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/23317/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/23317/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/23317/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/d6b496028ef578252acd2fd728aaa5819222e3ff"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pimodoo"}}