{"action":"created","comment":{"url":"https://api.github.com/repos/usgs/thredds/pulls/comments/211666382","pull_request_review_id":148136861,"id":211666382,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTY2NjM4Mg==","diff_hunk":"@@ -0,0 +1,47 @@\n+package ucar.nc2.ft2.coverage.simpgeometry;\r\n+\r\n+import org.junit.Assert;\r\n+import org.junit.Test;\r\n+\r\n+import ucar.ma2.Array;\r\n+import ucar.nc2.dataset.NetcdfDataset;\r\n+import ucar.nc2.ft2.coverage.simpgeometry.*;\r\n+import ucar.unidata.util.test.TestDir;\r\n+\r\n+import java.util.Random;\r\n+import java.io.IOException;\r\n+import java.util.List;\r\n+\r\n+/**\r\n+ * Point construction tests at the dataset level.\r\n+ * \r\n+ * @author wchen@usgs.gov\r\n+ *\r\n+ */\r\n+public class TestReadPoint {\r\n+\r\n+\tprivate SimpleGeometryReader newReader()\r\n+\t{\r\n+\t\tString filepath = TestDir.cdmLocalTestDataDir + \"dataset/SimpleGeos/avg_temp_3gage_5timesteps.nc\";\r\n+\t\tNetcdfDataset dataset = null;\r\n+\t\t\r\n+\t\ttry {\r\n+\t\t\r\n+\t\t\tdataset = NetcdfDataset.openDataset(filepath);\r","path":"cdm/src/test/java/ucar/nc2/ft2/coverage/simpgeometry/TestReadPoint.java","position":30,"original_position":30,"commit_id":"b5fc64aea1e1fa34fcbb1675d46d89d0df2ac944","original_commit_id":"b5fc64aea1e1fa34fcbb1675d46d89d0df2ac944","user":{"login":"wchen329","id":26677485,"node_id":"MDQ6VXNlcjI2Njc3NDg1","avatar_url":"https://avatars1.githubusercontent.com/u/26677485?v=4","gravatar_id":"","url":"https://api.github.com/users/wchen329","html_url":"https://github.com/wchen329","followers_url":"https://api.github.com/users/wchen329/followers","following_url":"https://api.github.com/users/wchen329/following{/other_user}","gists_url":"https://api.github.com/users/wchen329/gists{/gist_id}","starred_url":"https://api.github.com/users/wchen329/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchen329/subscriptions","organizations_url":"https://api.github.com/users/wchen329/orgs","repos_url":"https://api.github.com/users/wchen329/repos","events_url":"https://api.github.com/users/wchen329/events{/privacy}","received_events_url":"https://api.github.com/users/wchen329/received_events","type":"User","site_admin":false},"body":"Oh yeah this test is not finished, still need working Point data and Line data. Will get both the Line and Point tests finished once those are fixed.","created_at":"2018-08-21T16:09:58Z","updated_at":"2018-08-21T16:09:58Z","html_url":"https://github.com/usgs/thredds/pull/10#discussion_r211666382","pull_request_url":"https://api.github.com/repos/usgs/thredds/pulls/10","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/usgs/thredds/pulls/comments/211666382"},"html":{"href":"https://github.com/usgs/thredds/pull/10#discussion_r211666382"},"pull_request":{"href":"https://api.github.com/repos/usgs/thredds/pulls/10"}},"in_reply_to_id":211411232},"pull_request":{"url":"https://api.github.com/repos/usgs/thredds/pulls/10","id":208069362,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDY5MzYy","html_url":"https://github.com/usgs/thredds/pull/10","diff_url":"https://github.com/usgs/thredds/pull/10.diff","patch_url":"https://github.com/usgs/thredds/pull/10.patch","issue_url":"https://api.github.com/repos/usgs/thredds/issues/10","number":10,"state":"open","locked":false,"title":"Added Simple Geometry Containers (MAP-59/60)","user":{"login":"wchen329","id":26677485,"node_id":"MDQ6VXNlcjI2Njc3NDg1","avatar_url":"https://avatars1.githubusercontent.com/u/26677485?v=4","gravatar_id":"","url":"https://api.github.com/users/wchen329","html_url":"https://github.com/wchen329","followers_url":"https://api.github.com/users/wchen329/followers","following_url":"https://api.github.com/users/wchen329/following{/other_user}","gists_url":"https://api.github.com/users/wchen329/gists{/gist_id}","starred_url":"https://api.github.com/users/wchen329/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchen329/subscriptions","organizations_url":"https://api.github.com/users/wchen329/orgs","repos_url":"https://api.github.com/users/wchen329/repos","events_url":"https://api.github.com/users/wchen329/events{/privacy}","received_events_url":"https://api.github.com/users/wchen329/received_events","type":"User","site_admin":false},"body":"Added some containers for simple geometry and tests for them. Also added a factory for Simple Geometry.","created_at":"2018-08-13T18:51:06Z","updated_at":"2018-08-21T16:09:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0816528e3a994ec4b3aa37cb19e3c5d02f217165","assignee":{"login":"skaymen","id":24640429,"node_id":"MDQ6VXNlcjI0NjQwNDI5","avatar_url":"https://avatars3.githubusercontent.com/u/24640429?v=4","gravatar_id":"","url":"https://api.github.com/users/skaymen","html_url":"https://github.com/skaymen","followers_url":"https://api.github.com/users/skaymen/followers","following_url":"https://api.github.com/users/skaymen/following{/other_user}","gists_url":"https://api.github.com/users/skaymen/gists{/gist_id}","starred_url":"https://api.github.com/users/skaymen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skaymen/subscriptions","organizations_url":"https://api.github.com/users/skaymen/orgs","repos_url":"https://api.github.com/users/skaymen/repos","events_url":"https://api.github.com/users/skaymen/events{/privacy}","received_events_url":"https://api.github.com/users/skaymen/received_events","type":"User","site_admin":false},"assignees":[{"login":"skaymen","id":24640429,"node_id":"MDQ6VXNlcjI0NjQwNDI5","avatar_url":"https://avatars3.githubusercontent.com/u/24640429?v=4","gravatar_id":"","url":"https://api.github.com/users/skaymen","html_url":"https://github.com/skaymen","followers_url":"https://api.github.com/users/skaymen/followers","following_url":"https://api.github.com/users/skaymen/following{/other_user}","gists_url":"https://api.github.com/users/skaymen/gists{/gist_id}","starred_url":"https://api.github.com/users/skaymen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skaymen/subscriptions","organizations_url":"https://api.github.com/users/skaymen/orgs","repos_url":"https://api.github.com/users/skaymen/repos","events_url":"https://api.github.com/users/skaymen/events{/privacy}","received_events_url":"https://api.github.com/users/skaymen/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/usgs/thredds/pulls/10/commits","review_comments_url":"https://api.github.com/repos/usgs/thredds/pulls/10/comments","review_comment_url":"https://api.github.com/repos/usgs/thredds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/usgs/thredds/issues/10/comments","statuses_url":"https://api.github.com/repos/usgs/thredds/statuses/b5fc64aea1e1fa34fcbb1675d46d89d0df2ac944","head":{"label":"wchen329:MAP-5960","ref":"MAP-5960","sha":"b5fc64aea1e1fa34fcbb1675d46d89d0df2ac944","user":{"login":"wchen329","id":26677485,"node_id":"MDQ6VXNlcjI2Njc3NDg1","avatar_url":"https://avatars1.githubusercontent.com/u/26677485?v=4","gravatar_id":"","url":"https://api.github.com/users/wchen329","html_url":"https://github.com/wchen329","followers_url":"https://api.github.com/users/wchen329/followers","following_url":"https://api.github.com/users/wchen329/following{/other_user}","gists_url":"https://api.github.com/users/wchen329/gists{/gist_id}","starred_url":"https://api.github.com/users/wchen329/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchen329/subscriptions","organizations_url":"https://api.github.com/users/wchen329/orgs","repos_url":"https://api.github.com/users/wchen329/repos","events_url":"https://api.github.com/users/wchen329/events{/privacy}","received_events_url":"https://api.github.com/users/wchen329/received_events","type":"User","site_admin":false},"repo":{"id":142620841,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI2MjA4NDE=","name":"thredds","full_name":"wchen329/thredds","owner":{"login":"wchen329","id":26677485,"node_id":"MDQ6VXNlcjI2Njc3NDg1","avatar_url":"https://avatars1.githubusercontent.com/u/26677485?v=4","gravatar_id":"","url":"https://api.github.com/users/wchen329","html_url":"https://github.com/wchen329","followers_url":"https://api.github.com/users/wchen329/followers","following_url":"https://api.github.com/users/wchen329/following{/other_user}","gists_url":"https://api.github.com/users/wchen329/gists{/gist_id}","starred_url":"https://api.github.com/users/wchen329/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchen329/subscriptions","organizations_url":"https://api.github.com/users/wchen329/orgs","repos_url":"https://api.github.com/users/wchen329/repos","events_url":"https://api.github.com/users/wchen329/events{/privacy}","received_events_url":"https://api.github.com/users/wchen329/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wchen329/thredds","description":"Thredds and netCDF-Java (CDM)","fork":true,"url":"https://api.github.com/repos/wchen329/thredds","forks_url":"https://api.github.com/repos/wchen329/thredds/forks","keys_url":"https://api.github.com/repos/wchen329/thredds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wchen329/thredds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wchen329/thredds/teams","hooks_url":"https://api.github.com/repos/wchen329/thredds/hooks","issue_events_url":"https://api.github.com/repos/wchen329/thredds/issues/events{/number}","events_url":"https://api.github.com/repos/wchen329/thredds/events","assignees_url":"https://api.github.com/repos/wchen329/thredds/assignees{/user}","branches_url":"https://api.github.com/repos/wchen329/thredds/branches{/branch}","tags_url":"https://api.github.com/repos/wchen329/thredds/tags","blobs_url":"https://api.github.com/repos/wchen329/thredds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wchen329/thredds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wchen329/thredds/git/refs{/sha}","trees_url":"https://api.github.com/repos/wchen329/thredds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wchen329/thredds/statuses/{sha}","languages_url":"https://api.github.com/repos/wchen329/thredds/languages","stargazers_url":"https://api.github.com/repos/wchen329/thredds/stargazers","contributors_url":"https://api.github.com/repos/wchen329/thredds/contributors","subscribers_url":"https://api.github.com/repos/wchen329/thredds/subscribers","subscription_url":"https://api.github.com/repos/wchen329/thredds/subscription","commits_url":"https://api.github.com/repos/wchen329/thredds/commits{/sha}","git_commits_url":"https://api.github.com/repos/wchen329/thredds/git/commits{/sha}","comments_url":"https://api.github.com/repos/wchen329/thredds/comments{/number}","issue_comment_url":"https://api.github.com/repos/wchen329/thredds/issues/comments{/number}","contents_url":"https://api.github.com/repos/wchen329/thredds/contents/{+path}","compare_url":"https://api.github.com/repos/wchen329/thredds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wchen329/thredds/merges","archive_url":"https://api.github.com/repos/wchen329/thredds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wchen329/thredds/downloads","issues_url":"https://api.github.com/repos/wchen329/thredds/issues{/number}","pulls_url":"https://api.github.com/repos/wchen329/thredds/pulls{/number}","milestones_url":"https://api.github.com/repos/wchen329/thredds/milestones{/number}","notifications_url":"https://api.github.com/repos/wchen329/thredds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wchen329/thredds/labels{/name}","releases_url":"https://api.github.com/repos/wchen329/thredds/releases{/id}","deployments_url":"https://api.github.com/repos/wchen329/thredds/deployments","created_at":"2018-07-27T20:28:18Z","updated_at":"2018-08-20T20:33:25Z","pushed_at":"2018-08-20T20:33:03Z","git_url":"git://github.com/wchen329/thredds.git","ssh_url":"git@github.com:wchen329/thredds.git","clone_url":"https://github.com/wchen329/thredds.git","svn_url":"https://github.com/wchen329/thredds","homepage":"http://www.unidata.ucar.edu/software/netcdf-java/documentation.htm","size":903647,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.0.0-usgs"}},"base":{"label":"usgs:5.0.0-usgs","ref":"5.0.0-usgs","sha":"56152af60c464e6d06297cac899e7e1eff0a40a6","user":{"login":"usgs","id":1091434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTE0MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1091434?v=4","gravatar_id":"","url":"https://api.github.com/users/usgs","html_url":"https://github.com/usgs","followers_url":"https://api.github.com/users/usgs/followers","following_url":"https://api.github.com/users/usgs/following{/other_user}","gists_url":"https://api.github.com/users/usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usgs/subscriptions","organizations_url":"https://api.github.com/users/usgs/orgs","repos_url":"https://api.github.com/users/usgs/repos","events_url":"https://api.github.com/users/usgs/events{/privacy}","received_events_url":"https://api.github.com/users/usgs/received_events","type":"Organization","site_admin":false},"repo":{"id":142071752,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwNzE3NTI=","name":"thredds","full_name":"usgs/thredds","owner":{"login":"usgs","id":1091434,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTE0MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1091434?v=4","gravatar_id":"","url":"https://api.github.com/users/usgs","html_url":"https://github.com/usgs","followers_url":"https://api.github.com/users/usgs/followers","following_url":"https://api.github.com/users/usgs/following{/other_user}","gists_url":"https://api.github.com/users/usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usgs/subscriptions","organizations_url":"https://api.github.com/users/usgs/orgs","repos_url":"https://api.github.com/users/usgs/repos","events_url":"https://api.github.com/users/usgs/events{/privacy}","received_events_url":"https://api.github.com/users/usgs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/usgs/thredds","description":"Thredds and netCDF-Java (CDM)","fork":true,"url":"https://api.github.com/repos/usgs/thredds","forks_url":"https://api.github.com/repos/usgs/thredds/forks","keys_url":"https://api.github.com/repos/usgs/thredds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usgs/thredds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usgs/thredds/teams","hooks_url":"https://api.github.com/repos/usgs/thredds/hooks","issue_events_url":"https://api.github.com/repos/usgs/thredds/issues/events{/number}","events_url":"https://api.github.com/repos/usgs/thredds/events","assignees_url":"https://api.github.com/repos/usgs/thredds/assignees{/user}","branches_url":"https://api.github.com/repos/usgs/thredds/branches{/branch}","tags_url":"https://api.github.com/repos/usgs/thredds/tags","blobs_url":"https://api.github.com/repos/usgs/thredds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usgs/thredds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usgs/thredds/git/refs{/sha}","trees_url":"https://api.github.com/repos/usgs/thredds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usgs/thredds/statuses/{sha}","languages_url":"https://api.github.com/repos/usgs/thredds/languages","stargazers_url":"https://api.github.com/repos/usgs/thredds/stargazers","contributors_url":"https://api.github.com/repos/usgs/thredds/contributors","subscribers_url":"https://api.github.com/repos/usgs/thredds/subscribers","subscription_url":"https://api.github.com/repos/usgs/thredds/subscription","commits_url":"https://api.github.com/repos/usgs/thredds/commits{/sha}","git_commits_url":"https://api.github.com/repos/usgs/thredds/git/commits{/sha}","comments_url":"https://api.github.com/repos/usgs/thredds/comments{/number}","issue_comment_url":"https://api.github.com/repos/usgs/thredds/issues/comments{/number}","contents_url":"https://api.github.com/repos/usgs/thredds/contents/{+path}","compare_url":"https://api.github.com/repos/usgs/thredds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usgs/thredds/merges","archive_url":"https://api.github.com/repos/usgs/thredds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usgs/thredds/downloads","issues_url":"https://api.github.com/repos/usgs/thredds/issues{/number}","pulls_url":"https://api.github.com/repos/usgs/thredds/pulls{/number}","milestones_url":"https://api.github.com/repos/usgs/thredds/milestones{/number}","notifications_url":"https://api.github.com/repos/usgs/thredds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usgs/thredds/labels{/name}","releases_url":"https://api.github.com/repos/usgs/thredds/releases{/id}","deployments_url":"https://api.github.com/repos/usgs/thredds/deployments","created_at":"2018-07-23T21:32:58Z","updated_at":"2018-08-20T22:33:51Z","pushed_at":"2018-08-20T22:33:49Z","git_url":"git://github.com/usgs/thredds.git","ssh_url":"git@github.com:usgs/thredds.git","clone_url":"https://github.com/usgs/thredds.git","svn_url":"https://github.com/usgs/thredds","homepage":"http://www.unidata.ucar.edu/software/netcdf-java/documentation.htm","size":903486,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":1,"watchers":0,"default_branch":"5.0.0-usgs"}},"_links":{"self":{"href":"https://api.github.com/repos/usgs/thredds/pulls/10"},"html":{"href":"https://github.com/usgs/thredds/pull/10"},"issue":{"href":"https://api.github.com/repos/usgs/thredds/issues/10"},"comments":{"href":"https://api.github.com/repos/usgs/thredds/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/usgs/thredds/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/usgs/thredds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/usgs/thredds/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/usgs/thredds/statuses/b5fc64aea1e1fa34fcbb1675d46d89d0df2ac944"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wchen329"}}