{"action":"created","comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/comments/208953953","pull_request_review_id":144871214,"id":208953953,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODk1Mzk1Mw==","diff_hunk":"@@ -590,8 +603,24 @@ public JaegerTracer build() {\n             .withMetrics(metrics)\n             .build();\n       }\n+      return createTracer(serviceName, reporter, sampler, registry, clock, metrics, tags,\n+          zipkinSharedRpcSpan, scopeManager, baggageRestrictionManager, expandExceptionLogs, objectFactory);\n+    }\n+\n+    protected JaegerTracer createTracer(String serviceName,","path":"jaeger-core/src/main/java/io/jaegertracing/internal/JaegerTracer.java","position":127,"original_position":127,"commit_id":"12dbd518b8ba963ac917841eb0067bd69fd13c2c","original_commit_id":"12dbd518b8ba963ac917841eb0067bd69fd13c2c","user":{"login":"isaachier","id":2578297,"node_id":"MDQ6VXNlcjI1NzgyOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2578297?v=4","gravatar_id":"","url":"https://api.github.com/users/isaachier","html_url":"https://github.com/isaachier","followers_url":"https://api.github.com/users/isaachier/followers","following_url":"https://api.github.com/users/isaachier/following{/other_user}","gists_url":"https://api.github.com/users/isaachier/gists{/gist_id}","starred_url":"https://api.github.com/users/isaachier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaachier/subscriptions","organizations_url":"https://api.github.com/users/isaachier/orgs","repos_url":"https://api.github.com/users/isaachier/repos","events_url":"https://api.github.com/users/isaachier/events{/privacy}","received_events_url":"https://api.github.com/users/isaachier/received_events","type":"User","site_admin":false},"body":"Lol same explanation as above.","created_at":"2018-08-09T14:36:26Z","updated_at":"2018-08-09T14:36:26Z","html_url":"https://github.com/jaegertracing/jaeger-client-java/pull/509#discussion_r208953953","pull_request_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/509","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/comments/208953953"},"html":{"href":"https://github.com/jaegertracing/jaeger-client-java/pull/509#discussion_r208953953"},"pull_request":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/509"}},"in_reply_to_id":208768919},"pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/509","id":206455052,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDU1MDUy","html_url":"https://github.com/jaegertracing/jaeger-client-java/pull/509","diff_url":"https://github.com/jaegertracing/jaeger-client-java/pull/509.diff","patch_url":"https://github.com/jaegertracing/jaeger-client-java/pull/509.patch","issue_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/509","number":509,"state":"open","locked":false,"title":"Add protected methods to common classes so subclasses may extend them","user":{"login":"isaachier","id":2578297,"node_id":"MDQ6VXNlcjI1NzgyOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2578297?v=4","gravatar_id":"","url":"https://api.github.com/users/isaachier","html_url":"https://github.com/isaachier","followers_url":"https://api.github.com/users/isaachier/followers","following_url":"https://api.github.com/users/isaachier/following{/other_user}","gists_url":"https://api.github.com/users/isaachier/gists{/gist_id}","starred_url":"https://api.github.com/users/isaachier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaachier/subscriptions","organizations_url":"https://api.github.com/users/isaachier/orgs","repos_url":"https://api.github.com/users/isaachier/repos","events_url":"https://api.github.com/users/isaachier/events{/privacy}","received_events_url":"https://api.github.com/users/isaachier/received_events","type":"User","site_admin":false},"body":"<!--\r\nWe appreciate your contribution to the Jaeger project! 👋🎉\r\n\r\nBefore creating a pull request, please make sure:\r\n- Your PR is solving one problem\r\n- You have read the guide for contributing\r\n  - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md\r\n- You signed all your commits (otherwise we won't be able to merge the PR)\r\n  - See https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md#sign-your-work\r\n- You added unit tests for the new functionality\r\n- You mention in the PR description which issue it is addressing, e.g. \"Resolves #123\"\r\n-->\r\n\r\n- Addresses configuration override for #508.\r\n\r\n- Make private static methods in Configuration have protected static\r\nvisibility instead.","created_at":"2018-08-06T16:38:55Z","updated_at":"2018-08-09T14:36:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d3364cbd8cec565ff221e0b714b9c8e8aa4d940","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/509/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/509/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/509/comments","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/statuses/12dbd518b8ba963ac917841eb0067bd69fd13c2c","head":{"label":"isaachier:override-config","ref":"override-config","sha":"12dbd518b8ba963ac917841eb0067bd69fd13c2c","user":{"login":"isaachier","id":2578297,"node_id":"MDQ6VXNlcjI1NzgyOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2578297?v=4","gravatar_id":"","url":"https://api.github.com/users/isaachier","html_url":"https://github.com/isaachier","followers_url":"https://api.github.com/users/isaachier/followers","following_url":"https://api.github.com/users/isaachier/following{/other_user}","gists_url":"https://api.github.com/users/isaachier/gists{/gist_id}","starred_url":"https://api.github.com/users/isaachier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaachier/subscriptions","organizations_url":"https://api.github.com/users/isaachier/orgs","repos_url":"https://api.github.com/users/isaachier/repos","events_url":"https://api.github.com/users/isaachier/events{/privacy}","received_events_url":"https://api.github.com/users/isaachier/received_events","type":"User","site_admin":false},"repo":{"id":101230938,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyMzA5Mzg=","name":"jaeger-client-java","full_name":"isaachier/jaeger-client-java","owner":{"login":"isaachier","id":2578297,"node_id":"MDQ6VXNlcjI1NzgyOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2578297?v=4","gravatar_id":"","url":"https://api.github.com/users/isaachier","html_url":"https://github.com/isaachier","followers_url":"https://api.github.com/users/isaachier/followers","following_url":"https://api.github.com/users/isaachier/following{/other_user}","gists_url":"https://api.github.com/users/isaachier/gists{/gist_id}","starred_url":"https://api.github.com/users/isaachier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaachier/subscriptions","organizations_url":"https://api.github.com/users/isaachier/orgs","repos_url":"https://api.github.com/users/isaachier/repos","events_url":"https://api.github.com/users/isaachier/events{/privacy}","received_events_url":"https://api.github.com/users/isaachier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isaachier/jaeger-client-java","description":"Jaeger Bindings for Java OpenTracing API","fork":true,"url":"https://api.github.com/repos/isaachier/jaeger-client-java","forks_url":"https://api.github.com/repos/isaachier/jaeger-client-java/forks","keys_url":"https://api.github.com/repos/isaachier/jaeger-client-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isaachier/jaeger-client-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isaachier/jaeger-client-java/teams","hooks_url":"https://api.github.com/repos/isaachier/jaeger-client-java/hooks","issue_events_url":"https://api.github.com/repos/isaachier/jaeger-client-java/issues/events{/number}","events_url":"https://api.github.com/repos/isaachier/jaeger-client-java/events","assignees_url":"https://api.github.com/repos/isaachier/jaeger-client-java/assignees{/user}","branches_url":"https://api.github.com/repos/isaachier/jaeger-client-java/branches{/branch}","tags_url":"https://api.github.com/repos/isaachier/jaeger-client-java/tags","blobs_url":"https://api.github.com/repos/isaachier/jaeger-client-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isaachier/jaeger-client-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isaachier/jaeger-client-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/isaachier/jaeger-client-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isaachier/jaeger-client-java/statuses/{sha}","languages_url":"https://api.github.com/repos/isaachier/jaeger-client-java/languages","stargazers_url":"https://api.github.com/repos/isaachier/jaeger-client-java/stargazers","contributors_url":"https://api.github.com/repos/isaachier/jaeger-client-java/contributors","subscribers_url":"https://api.github.com/repos/isaachier/jaeger-client-java/subscribers","subscription_url":"https://api.github.com/repos/isaachier/jaeger-client-java/subscription","commits_url":"https://api.github.com/repos/isaachier/jaeger-client-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/isaachier/jaeger-client-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/isaachier/jaeger-client-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/isaachier/jaeger-client-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/isaachier/jaeger-client-java/contents/{+path}","compare_url":"https://api.github.com/repos/isaachier/jaeger-client-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isaachier/jaeger-client-java/merges","archive_url":"https://api.github.com/repos/isaachier/jaeger-client-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isaachier/jaeger-client-java/downloads","issues_url":"https://api.github.com/repos/isaachier/jaeger-client-java/issues{/number}","pulls_url":"https://api.github.com/repos/isaachier/jaeger-client-java/pulls{/number}","milestones_url":"https://api.github.com/repos/isaachier/jaeger-client-java/milestones{/number}","notifications_url":"https://api.github.com/repos/isaachier/jaeger-client-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isaachier/jaeger-client-java/labels{/name}","releases_url":"https://api.github.com/repos/isaachier/jaeger-client-java/releases{/id}","deployments_url":"https://api.github.com/repos/isaachier/jaeger-client-java/deployments","created_at":"2017-08-23T22:42:44Z","updated_at":"2018-08-08T12:56:20Z","pushed_at":"2018-08-08T19:40:09Z","git_url":"git://github.com/isaachier/jaeger-client-java.git","ssh_url":"git@github.com:isaachier/jaeger-client-java.git","clone_url":"https://github.com/isaachier/jaeger-client-java.git","svn_url":"https://github.com/isaachier/jaeger-client-java","homepage":"http://uber.github.io/jaeger/","size":1887,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"a8c8225fccc223feda6bd909f2b37ad3d0cad9d9","user":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":56551000,"node_id":"MDEwOlJlcG9zaXRvcnk1NjU1MTAwMA==","name":"jaeger-client-java","full_name":"jaegertracing/jaeger-client-java","owner":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jaegertracing/jaeger-client-java","description":"Jaeger Bindings for Java OpenTracing API","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger-client-java","forks_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-java/deployments","created_at":"2016-04-19T00:10:02Z","updated_at":"2018-08-07T12:41:30Z","pushed_at":"2018-08-08T19:40:11Z","git_url":"git://github.com/jaegertracing/jaeger-client-java.git","ssh_url":"git@github.com:jaegertracing/jaeger-client-java.git","clone_url":"https://github.com/jaegertracing/jaeger-client-java.git","svn_url":"https://github.com/jaegertracing/jaeger-client-java","homepage":"https://jaegertracing.io/","size":1711,"stargazers_count":183,"watchers_count":183,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":85,"open_issues":50,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/509"},"html":{"href":"https://github.com/jaegertracing/jaeger-client-java/pull/509"},"issue":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/509"},"comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/issues/509/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/509/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/pulls/509/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-java/statuses/12dbd518b8ba963ac917841eb0067bd69fd13c2c"}},"author_association":"NONE"}}
{"actor":{"display_login":"isaachier"}}