{"action":"created","comment":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/191244694","pull_request_review_id":123779764,"id":191244694,"diff_hunk":"@@ -388,6 +388,20 @@ namespace\n     }\n #endif // TORRENT_ABI_VERSION\n \n+    void alert_notify(object cb)\n+    {\n+        if (cb)","path":"bindings/python/src/session.cpp","position":6,"original_position":6,"commit_id":"cf6c46261d04eb09da57e59aabb558ea55e27ace","original_commit_id":"cf6c46261d04eb09da57e59aabb558ea55e27ace","user":{"login":"aresch","id":185632,"avatar_url":"https://avatars1.githubusercontent.com/u/185632?v=4","gravatar_id":"","url":"https://api.github.com/users/aresch","html_url":"https://github.com/aresch","followers_url":"https://api.github.com/users/aresch/followers","following_url":"https://api.github.com/users/aresch/following{/other_user}","gists_url":"https://api.github.com/users/aresch/gists{/gist_id}","starred_url":"https://api.github.com/users/aresch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aresch/subscriptions","organizations_url":"https://api.github.com/users/aresch/orgs","repos_url":"https://api.github.com/users/aresch/repos","events_url":"https://api.github.com/users/aresch/events{/privacy}","received_events_url":"https://api.github.com/users/aresch/received_events","type":"User","site_admin":false},"body":"Oh whoops. We grab the gil anyways if cb is not None. I'll just move the lock to the top of the function just to be safe.","created_at":"2018-05-28T16:45:07Z","updated_at":"2018-05-28T16:45:07Z","html_url":"https://github.com/arvidn/libtorrent/pull/3066#discussion_r191244694","pull_request_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/3066","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/191244694"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/3066#discussion_r191244694"},"pull_request":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/3066"}},"in_reply_to_id":191215199},"pull_request":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/3066","id":190763905,"html_url":"https://github.com/arvidn/libtorrent/pull/3066","diff_url":"https://github.com/arvidn/libtorrent/pull/3066.diff","patch_url":"https://github.com/arvidn/libtorrent/pull/3066.patch","issue_url":"https://api.github.com/repos/arvidn/libtorrent/issues/3066","number":3066,"state":"open","locked":false,"title":"Add set_alert_notify to python bindings","user":{"login":"aresch","id":185632,"avatar_url":"https://avatars1.githubusercontent.com/u/185632?v=4","gravatar_id":"","url":"https://api.github.com/users/aresch","html_url":"https://github.com/aresch","followers_url":"https://api.github.com/users/aresch/followers","following_url":"https://api.github.com/users/aresch/following{/other_user}","gists_url":"https://api.github.com/users/aresch/gists{/gist_id}","starred_url":"https://api.github.com/users/aresch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aresch/subscriptions","organizations_url":"https://api.github.com/users/aresch/orgs","repos_url":"https://api.github.com/users/aresch/repos","events_url":"https://api.github.com/users/aresch/events{/privacy}","received_events_url":"https://api.github.com/users/aresch/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-26T23:51:27Z","updated_at":"2018-05-28T16:45:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9b18816eb9754359a3e707c128571ea551fbfb4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/3066/commits","review_comments_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/3066/comments","review_comment_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/issues/3066/comments","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/cf6c46261d04eb09da57e59aabb558ea55e27ace","head":{"label":"aresch:notify_alert","ref":"notify_alert","sha":"cf6c46261d04eb09da57e59aabb558ea55e27ace","user":{"login":"aresch","id":185632,"avatar_url":"https://avatars1.githubusercontent.com/u/185632?v=4","gravatar_id":"","url":"https://api.github.com/users/aresch","html_url":"https://github.com/aresch","followers_url":"https://api.github.com/users/aresch/followers","following_url":"https://api.github.com/users/aresch/following{/other_user}","gists_url":"https://api.github.com/users/aresch/gists{/gist_id}","starred_url":"https://api.github.com/users/aresch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aresch/subscriptions","organizations_url":"https://api.github.com/users/aresch/orgs","repos_url":"https://api.github.com/users/aresch/repos","events_url":"https://api.github.com/users/aresch/events{/privacy}","received_events_url":"https://api.github.com/users/aresch/received_events","type":"User","site_admin":false},"repo":{"id":49480905,"name":"libtorrent","full_name":"aresch/libtorrent","owner":{"login":"aresch","id":185632,"avatar_url":"https://avatars1.githubusercontent.com/u/185632?v=4","gravatar_id":"","url":"https://api.github.com/users/aresch","html_url":"https://github.com/aresch","followers_url":"https://api.github.com/users/aresch/followers","following_url":"https://api.github.com/users/aresch/following{/other_user}","gists_url":"https://api.github.com/users/aresch/gists{/gist_id}","starred_url":"https://api.github.com/users/aresch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aresch/subscriptions","organizations_url":"https://api.github.com/users/aresch/orgs","repos_url":"https://api.github.com/users/aresch/repos","events_url":"https://api.github.com/users/aresch/events{/privacy}","received_events_url":"https://api.github.com/users/aresch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aresch/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":true,"url":"https://api.github.com/repos/aresch/libtorrent","forks_url":"https://api.github.com/repos/aresch/libtorrent/forks","keys_url":"https://api.github.com/repos/aresch/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aresch/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aresch/libtorrent/teams","hooks_url":"https://api.github.com/repos/aresch/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/aresch/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/aresch/libtorrent/events","assignees_url":"https://api.github.com/repos/aresch/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/aresch/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/aresch/libtorrent/tags","blobs_url":"https://api.github.com/repos/aresch/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aresch/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aresch/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/aresch/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aresch/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/aresch/libtorrent/languages","stargazers_url":"https://api.github.com/repos/aresch/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/aresch/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/aresch/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/aresch/libtorrent/subscription","commits_url":"https://api.github.com/repos/aresch/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/aresch/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/aresch/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/aresch/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/aresch/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/aresch/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aresch/libtorrent/merges","archive_url":"https://api.github.com/repos/aresch/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aresch/libtorrent/downloads","issues_url":"https://api.github.com/repos/aresch/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/aresch/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/aresch/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/aresch/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aresch/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/aresch/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/aresch/libtorrent/deployments","created_at":"2016-01-12T06:49:54Z","updated_at":"2016-01-12T06:49:57Z","pushed_at":"2018-05-27T20:46:43Z","git_url":"git://github.com/aresch/libtorrent.git","ssh_url":"git@github.com:aresch/libtorrent.git","clone_url":"https://github.com/aresch/libtorrent.git","svn_url":"https://github.com/aresch/libtorrent","homepage":"http://libtorrent.org","size":63099,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arvidn:master","ref":"master","sha":"d6cecee8c09704cc8a24158b4640bf84f690a242","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"repo":{"id":36781769,"name":"libtorrent","full_name":"arvidn/libtorrent","owner":{"login":"arvidn","id":661450,"avatar_url":"https://avatars0.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arvidn/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":false,"url":"https://api.github.com/repos/arvidn/libtorrent","forks_url":"https://api.github.com/repos/arvidn/libtorrent/forks","keys_url":"https://api.github.com/repos/arvidn/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvidn/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvidn/libtorrent/teams","hooks_url":"https://api.github.com/repos/arvidn/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/arvidn/libtorrent/events","assignees_url":"https://api.github.com/repos/arvidn/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/arvidn/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/arvidn/libtorrent/tags","blobs_url":"https://api.github.com/repos/arvidn/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvidn/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvidn/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvidn/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/arvidn/libtorrent/languages","stargazers_url":"https://api.github.com/repos/arvidn/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/arvidn/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/arvidn/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/arvidn/libtorrent/subscription","commits_url":"https://api.github.com/repos/arvidn/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvidn/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvidn/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/arvidn/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvidn/libtorrent/merges","archive_url":"https://api.github.com/repos/arvidn/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvidn/libtorrent/downloads","issues_url":"https://api.github.com/repos/arvidn/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/arvidn/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/arvidn/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/arvidn/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvidn/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/arvidn/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/arvidn/libtorrent/deployments","created_at":"2015-06-03T05:22:03Z","updated_at":"2018-05-27T21:01:26Z","pushed_at":"2018-05-28T15:02:36Z","git_url":"git://github.com/arvidn/libtorrent.git","ssh_url":"git@github.com:arvidn/libtorrent.git","clone_url":"https://github.com/arvidn/libtorrent.git","svn_url":"https://github.com/arvidn/libtorrent","homepage":"http://libtorrent.org","size":76054,"stargazers_count":1312,"watchers_count":1312,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":387,"mirror_url":null,"archived":false,"open_issues_count":216,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":387,"open_issues":216,"watchers":1312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/3066"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/3066"},"issue":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/3066"},"comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/3066/comments"},"review_comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/3066/comments"},"review_comment":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/3066/commits"},"statuses":{"href":"https://api.github.com/repos/arvidn/libtorrent/statuses/cf6c46261d04eb09da57e59aabb558ea55e27ace"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aresch"}}