{"action":"created","issue":{"url":"https://api.github.com/repos/alibaba/pouch/issues/1735","repository_url":"https://api.github.com/repos/alibaba/pouch","labels_url":"https://api.github.com/repos/alibaba/pouch/issues/1735/labels{/name}","comments_url":"https://api.github.com/repos/alibaba/pouch/issues/1735/comments","events_url":"https://api.github.com/repos/alibaba/pouch/issues/1735/events","html_url":"https://github.com/alibaba/pouch/pull/1735","id":340878488,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMTg1NDM3","number":1735,"title":"bugfix: record logpath to container mata","user":{"login":"YaoZengzeng","id":8636562,"node_id":"MDQ6VXNlcjg2MzY1NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/8636562?v=4","gravatar_id":"","url":"https://api.github.com/users/YaoZengzeng","html_url":"https://github.com/YaoZengzeng","followers_url":"https://api.github.com/users/YaoZengzeng/followers","following_url":"https://api.github.com/users/YaoZengzeng/following{/other_user}","gists_url":"https://api.github.com/users/YaoZengzeng/gists{/gist_id}","starred_url":"https://api.github.com/users/YaoZengzeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YaoZengzeng/subscriptions","organizations_url":"https://api.github.com/users/YaoZengzeng/orgs","repos_url":"https://api.github.com/users/YaoZengzeng/repos","events_url":"https://api.github.com/users/YaoZengzeng/events{/privacy}","received_events_url":"https://api.github.com/users/YaoZengzeng/received_events","type":"User","site_admin":false},"labels":[{"id":722340727,"node_id":"MDU6TGFiZWw3MjIzNDA3Mjc=","url":"https://api.github.com/repos/alibaba/pouch/labels/areas/log","name":"areas/log","color":"1d76db","default":false},{"id":722344260,"node_id":"MDU6TGFiZWw3MjIzNDQyNjA=","url":"https://api.github.com/repos/alibaba/pouch/labels/conflict/needs-rebase","name":"conflict/needs-rebase","color":"cccccc","default":false},{"id":684575943,"node_id":"MDU6TGFiZWw2ODQ1NzU5NDM=","url":"https://api.github.com/repos/alibaba/pouch/labels/kind/bug","name":"kind/bug","color":"f77e56","default":false},{"id":722355122,"node_id":"MDU6TGFiZWw3MjIzNTUxMjI=","url":"https://api.github.com/repos/alibaba/pouch/labels/size/L","name":"size/L","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-13T04:33:47Z","updated_at":"2018-07-30T06:20:39Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/1735","html_url":"https://github.com/alibaba/pouch/pull/1735","diff_url":"https://github.com/alibaba/pouch/pull/1735.diff","patch_url":"https://github.com/alibaba/pouch/pull/1735.patch"},"body":"Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>\r\n\r\n<!-- \r\nPlease make sure you have read and understood the contributing guidelines;\r\nhttps://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md -->\r\n\r\n### Ⅰ. Describe what this PR did\r\n\r\nWe should get the `LogPath` information when we get the status of the container.\r\n\r\nBut now CRI Manager handle the log stuff of the CRI container by itself.\r\n\r\nSo we should store the `LogPath` as meta data when we create container, then we could get the log information when we return the status of container.\r\n\r\nIt is what this PR do.\r\n\r\nHowever I think we should let the container manager handle the log stuff for all containers including the CRI container or non-CRI container. Then we could get all the container-related information from container manager other then maintaining an extra container meta data store in CRI manager.\r\n\r\n@fuweid If you are free, please let the log driver in container manager to support the CRI format log file 😄 \r\n\r\n### Ⅱ. Does this pull request fix one issue?\r\n<!--If that, add \"fixes #xxxx\" below in the next line, for example, fixes #15. Otherwise, add \"NONE\" -->\r\n\r\n\r\n### Ⅲ. Describe how you did it\r\n\r\n\r\n### Ⅳ. Describe how to verify it\r\n\r\n\r\n### Ⅴ. Special notes for reviews\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/alibaba/pouch/issues/comments/408758824","html_url":"https://github.com/alibaba/pouch/pull/1735#issuecomment-408758824","issue_url":"https://api.github.com/repos/alibaba/pouch/issues/1735","id":408758824,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODc1ODgyNA==","user":{"login":"pouchrobot","id":33292901,"node_id":"MDQ6VXNlcjMzMjkyOTAx","avatar_url":"https://avatars1.githubusercontent.com/u/33292901?v=4","gravatar_id":"","url":"https://api.github.com/users/pouchrobot","html_url":"https://github.com/pouchrobot","followers_url":"https://api.github.com/users/pouchrobot/followers","following_url":"https://api.github.com/users/pouchrobot/following{/other_user}","gists_url":"https://api.github.com/users/pouchrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/pouchrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pouchrobot/subscriptions","organizations_url":"https://api.github.com/users/pouchrobot/orgs","repos_url":"https://api.github.com/users/pouchrobot/repos","events_url":"https://api.github.com/users/pouchrobot/events{/privacy}","received_events_url":"https://api.github.com/users/pouchrobot/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T06:20:39Z","updated_at":"2018-07-30T06:20:39Z","author_association":"COLLABORATOR","body":"ping @YaoZengzeng \nConflict happens after merging a previous commit.\nPlease rebase the branch against master and push it back again. Thanks a lot.\n"}}
{"actor":{"display_login":"pouchrobot"}}