{"action":"created","comment":{"url":"https://api.github.com/repos/google/kythe/pulls/comments/192172388","pull_request_review_id":124896870,"id":192172388,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjE3MjM4OA==","diff_hunk":"@@ -56,28 +56,22 @@ bool LoadVName(const rapidjson::Value &value, proto::VName *vname_out) {\n   return true;\n }\n \n-/// \\brief Attempts to load buffer as a header-style metadata file.\n-/// \\param buffer data to try and parse.\n-/// \\return the decoded metadata on success or null on failure.\n-std::unique_ptr<llvm::MemoryBuffer> LoadHeaderMetadata(\n-    const llvm::MemoryBuffer *buffer) {\n-  if (buffer->getBufferSize() < 2) {\n-    return nullptr;\n-  }\n+std::unique_ptr<llvm::MemoryBuffer> LoadCommentMetadata(\n+    llvm::StringRef buf_string, size_t comment_slash_pos,","path":"kythe/cxx/common/kythe_metadata_file.cc","position":13,"original_position":13,"commit_id":"f681ad4ec69eb946aed25c9c3eb381cbae1638e6","original_commit_id":"f681ad4ec69eb946aed25c9c3eb381cbae1638e6","user":{"login":"zrlk","id":8932755,"node_id":"MDQ6VXNlcjg5MzI3NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/8932755?v=4","gravatar_id":"","url":"https://api.github.com/users/zrlk","html_url":"https://github.com/zrlk","followers_url":"https://api.github.com/users/zrlk/followers","following_url":"https://api.github.com/users/zrlk/following{/other_user}","gists_url":"https://api.github.com/users/zrlk/gists{/gist_id}","starred_url":"https://api.github.com/users/zrlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zrlk/subscriptions","organizations_url":"https://api.github.com/users/zrlk/orgs","repos_url":"https://api.github.com/users/zrlk/repos","events_url":"https://api.github.com/users/zrlk/events{/privacy}","received_events_url":"https://api.github.com/users/zrlk/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-05-31T17:13:35Z","updated_at":"2018-05-31T17:13:35Z","html_url":"https://github.com/google/kythe/pull/70#discussion_r192172388","pull_request_url":"https://api.github.com/repos/google/kythe/pulls/70","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/kythe/pulls/comments/192172388"},"html":{"href":"https://github.com/google/kythe/pull/70#discussion_r192172388"},"pull_request":{"href":"https://api.github.com/repos/google/kythe/pulls/70"}},"in_reply_to_id":191976702},"pull_request":{"url":"https://api.github.com/repos/google/kythe/pulls/70","id":191610466,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjEwNDY2","html_url":"https://github.com/google/kythe/pull/70","diff_url":"https://github.com/google/kythe/pull/70.diff","patch_url":"https://github.com/google/kythe/pull/70.patch","issue_url":"https://api.github.com/repos/google/kythe/issues/70","number":70,"state":"open","locked":false,"title":"Support imputes and inline metadata.","user":{"login":"zrlk","id":8932755,"node_id":"MDQ6VXNlcjg5MzI3NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/8932755?v=4","gravatar_id":"","url":"https://api.github.com/users/zrlk","html_url":"https://github.com/zrlk","followers_url":"https://api.github.com/users/zrlk/followers","following_url":"https://api.github.com/users/zrlk/following{/other_user}","gists_url":"https://api.github.com/users/zrlk/gists{/gist_id}","starred_url":"https://api.github.com/users/zrlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zrlk/subscriptions","organizations_url":"https://api.github.com/users/zrlk/orgs","repos_url":"https://api.github.com/users/zrlk/repos","events_url":"https://api.github.com/users/zrlk/events{/privacy}","received_events_url":"https://api.github.com/users/zrlk/received_events","type":"User","site_admin":false},"body":"This PR adds a new metadata rule, anchor_anchor,\r\nwhich makes the `imputes` edge useful. It also allows\r\nfor metadata to be included in the same file that it\r\ndescribes using a new pragma. (A test is included that\r\ndocuments a second way of doing this using __FILE__ that\r\nwould be difficult to do in practice, owing to having to\r\nget the offsets right).","created_at":"2018-05-30T23:51:39Z","updated_at":"2018-05-31T17:13:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a5b065bd2ab79a036512f2eb037caef698ae66a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/kythe/pulls/70/commits","review_comments_url":"https://api.github.com/repos/google/kythe/pulls/70/comments","review_comment_url":"https://api.github.com/repos/google/kythe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/kythe/issues/70/comments","statuses_url":"https://api.github.com/repos/google/kythe/statuses/f681ad4ec69eb946aed25c9c3eb381cbae1638e6","head":{"label":"google:metadata","ref":"metadata","sha":"f681ad4ec69eb946aed25c9c3eb381cbae1638e6","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":29174627,"node_id":"MDEwOlJlcG9zaXRvcnkyOTE3NDYyNw==","name":"kythe","full_name":"google/kythe","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/kythe","description":"Kythe is a pluggable, (mostly) language-agnostic ecosystem for building tools that work with code.","fork":false,"url":"https://api.github.com/repos/google/kythe","forks_url":"https://api.github.com/repos/google/kythe/forks","keys_url":"https://api.github.com/repos/google/kythe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/kythe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/kythe/teams","hooks_url":"https://api.github.com/repos/google/kythe/hooks","issue_events_url":"https://api.github.com/repos/google/kythe/issues/events{/number}","events_url":"https://api.github.com/repos/google/kythe/events","assignees_url":"https://api.github.com/repos/google/kythe/assignees{/user}","branches_url":"https://api.github.com/repos/google/kythe/branches{/branch}","tags_url":"https://api.github.com/repos/google/kythe/tags","blobs_url":"https://api.github.com/repos/google/kythe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/kythe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/kythe/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/kythe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/kythe/statuses/{sha}","languages_url":"https://api.github.com/repos/google/kythe/languages","stargazers_url":"https://api.github.com/repos/google/kythe/stargazers","contributors_url":"https://api.github.com/repos/google/kythe/contributors","subscribers_url":"https://api.github.com/repos/google/kythe/subscribers","subscription_url":"https://api.github.com/repos/google/kythe/subscription","commits_url":"https://api.github.com/repos/google/kythe/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/kythe/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/kythe/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/kythe/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/kythe/contents/{+path}","compare_url":"https://api.github.com/repos/google/kythe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/kythe/merges","archive_url":"https://api.github.com/repos/google/kythe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/kythe/downloads","issues_url":"https://api.github.com/repos/google/kythe/issues{/number}","pulls_url":"https://api.github.com/repos/google/kythe/pulls{/number}","milestones_url":"https://api.github.com/repos/google/kythe/milestones{/number}","notifications_url":"https://api.github.com/repos/google/kythe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/kythe/labels{/name}","releases_url":"https://api.github.com/repos/google/kythe/releases{/id}","deployments_url":"https://api.github.com/repos/google/kythe/deployments","created_at":"2015-01-13T05:39:06Z","updated_at":"2018-05-31T17:02:00Z","pushed_at":"2018-05-31T17:02:47Z","git_url":"git://github.com/google/kythe.git","ssh_url":"git@github.com:google/kythe.git","clone_url":"https://github.com/google/kythe.git","svn_url":"https://github.com/google/kythe","homepage":"https://kythe.io","size":156310,"stargazers_count":984,"watchers_count":984,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":119,"open_issues":8,"watchers":984,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"c79a90543fbd0868a3610aa8d817408ade96a2a5","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":29174627,"node_id":"MDEwOlJlcG9zaXRvcnkyOTE3NDYyNw==","name":"kythe","full_name":"google/kythe","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/kythe","description":"Kythe is a pluggable, (mostly) language-agnostic ecosystem for building tools that work with code.","fork":false,"url":"https://api.github.com/repos/google/kythe","forks_url":"https://api.github.com/repos/google/kythe/forks","keys_url":"https://api.github.com/repos/google/kythe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/kythe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/kythe/teams","hooks_url":"https://api.github.com/repos/google/kythe/hooks","issue_events_url":"https://api.github.com/repos/google/kythe/issues/events{/number}","events_url":"https://api.github.com/repos/google/kythe/events","assignees_url":"https://api.github.com/repos/google/kythe/assignees{/user}","branches_url":"https://api.github.com/repos/google/kythe/branches{/branch}","tags_url":"https://api.github.com/repos/google/kythe/tags","blobs_url":"https://api.github.com/repos/google/kythe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/kythe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/kythe/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/kythe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/kythe/statuses/{sha}","languages_url":"https://api.github.com/repos/google/kythe/languages","stargazers_url":"https://api.github.com/repos/google/kythe/stargazers","contributors_url":"https://api.github.com/repos/google/kythe/contributors","subscribers_url":"https://api.github.com/repos/google/kythe/subscribers","subscription_url":"https://api.github.com/repos/google/kythe/subscription","commits_url":"https://api.github.com/repos/google/kythe/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/kythe/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/kythe/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/kythe/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/kythe/contents/{+path}","compare_url":"https://api.github.com/repos/google/kythe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/kythe/merges","archive_url":"https://api.github.com/repos/google/kythe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/kythe/downloads","issues_url":"https://api.github.com/repos/google/kythe/issues{/number}","pulls_url":"https://api.github.com/repos/google/kythe/pulls{/number}","milestones_url":"https://api.github.com/repos/google/kythe/milestones{/number}","notifications_url":"https://api.github.com/repos/google/kythe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/kythe/labels{/name}","releases_url":"https://api.github.com/repos/google/kythe/releases{/id}","deployments_url":"https://api.github.com/repos/google/kythe/deployments","created_at":"2015-01-13T05:39:06Z","updated_at":"2018-05-31T17:02:00Z","pushed_at":"2018-05-31T17:02:47Z","git_url":"git://github.com/google/kythe.git","ssh_url":"git@github.com:google/kythe.git","clone_url":"https://github.com/google/kythe.git","svn_url":"https://github.com/google/kythe","homepage":"https://kythe.io","size":156310,"stargazers_count":984,"watchers_count":984,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":119,"open_issues":8,"watchers":984,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/kythe/pulls/70"},"html":{"href":"https://github.com/google/kythe/pull/70"},"issue":{"href":"https://api.github.com/repos/google/kythe/issues/70"},"comments":{"href":"https://api.github.com/repos/google/kythe/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/google/kythe/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/google/kythe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/kythe/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/google/kythe/statuses/f681ad4ec69eb946aed25c9c3eb381cbae1638e6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zrlk"}}