{"action":"created","issue":{"url":"https://api.github.com/repos/xetys/hetzner-kube/issues/40","repository_url":"https://api.github.com/repos/xetys/hetzner-kube","labels_url":"https://api.github.com/repos/xetys/hetzner-kube/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/xetys/hetzner-kube/issues/40/comments","events_url":"https://api.github.com/repos/xetys/hetzner-kube/issues/40/events","html_url":"https://github.com/xetys/hetzner-kube/pull/40","id":301866897,"number":40,"title":"Fix PR-37 external hcloud manager","user":{"login":"mcadam","id":3319629,"avatar_url":"https://avatars1.githubusercontent.com/u/3319629?v=4","gravatar_id":"","url":"https://api.github.com/users/mcadam","html_url":"https://github.com/mcadam","followers_url":"https://api.github.com/users/mcadam/followers","following_url":"https://api.github.com/users/mcadam/following{/other_user}","gists_url":"https://api.github.com/users/mcadam/gists{/gist_id}","starred_url":"https://api.github.com/users/mcadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcadam/subscriptions","organizations_url":"https://api.github.com/users/mcadam/orgs","repos_url":"https://api.github.com/users/mcadam/repos","events_url":"https://api.github.com/users/mcadam/events{/privacy}","received_events_url":"https://api.github.com/users/mcadam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-02T18:48:38Z","updated_at":"2018-03-03T13:08:32Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/xetys/hetzner-kube/pulls/40","html_url":"https://github.com/xetys/hetzner-kube/pull/40","diff_url":"https://github.com/xetys/hetzner-kube/pull/40.diff","patch_url":"https://github.com/xetys/hetzner-kube/pull/40.patch"},"body":"Quick fix to just remove the extra flag `--cloud-provider=external` on provisioning external node.\r\nNot fully tested right now as the build is broken, see #38 "},"comment":{"url":"https://api.github.com/repos/xetys/hetzner-kube/issues/comments/370146348","html_url":"https://github.com/xetys/hetzner-kube/pull/40#issuecomment-370146348","issue_url":"https://api.github.com/repos/xetys/hetzner-kube/issues/40","id":370146348,"user":{"login":"mcadam","id":3319629,"avatar_url":"https://avatars1.githubusercontent.com/u/3319629?v=4","gravatar_id":"","url":"https://api.github.com/users/mcadam","html_url":"https://github.com/mcadam","followers_url":"https://api.github.com/users/mcadam/followers","following_url":"https://api.github.com/users/mcadam/following{/other_user}","gists_url":"https://api.github.com/users/mcadam/gists{/gist_id}","starred_url":"https://api.github.com/users/mcadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcadam/subscriptions","organizations_url":"https://api.github.com/users/mcadam/orgs","repos_url":"https://api.github.com/users/mcadam/repos","events_url":"https://api.github.com/users/mcadam/events{/privacy}","received_events_url":"https://api.github.com/users/mcadam/received_events","type":"User","site_admin":false},"created_at":"2018-03-03T13:08:32Z","updated_at":"2018-03-03T13:08:32Z","author_association":"NONE","body":"Ok now we have the behaviour that we want as we don't add the kubelet option to specify external cloud, I also added the option to pass a SSH port on the external node add command. \r\nAlso on the remove command we were not capturing the passphrase so it was not able to delete the node from kubectl directly."}}
{"actor":{"display_login":"mcadam"}}