{"action":"opened","number":175,"pull_request":{"url":"https://api.github.com/repos/euvl/vue-js-modal/pulls/175","id":169437399,"html_url":"https://github.com/euvl/vue-js-modal/pull/175","diff_url":"https://github.com/euvl/vue-js-modal/pull/175.diff","patch_url":"https://github.com/euvl/vue-js-modal/pull/175.patch","issue_url":"https://api.github.com/repos/euvl/vue-js-modal/issues/175","number":175,"state":"open","locked":false,"title":"Dynamic modals","user":{"login":"NoelDeMartin","id":1517677,"avatar_url":"https://avatars3.githubusercontent.com/u/1517677?v=4","gravatar_id":"","url":"https://api.github.com/users/NoelDeMartin","html_url":"https://github.com/NoelDeMartin","followers_url":"https://api.github.com/users/NoelDeMartin/followers","following_url":"https://api.github.com/users/NoelDeMartin/following{/other_user}","gists_url":"https://api.github.com/users/NoelDeMartin/gists{/gist_id}","starred_url":"https://api.github.com/users/NoelDeMartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NoelDeMartin/subscriptions","organizations_url":"https://api.github.com/users/NoelDeMartin/orgs","repos_url":"https://api.github.com/users/NoelDeMartin/repos","events_url":"https://api.github.com/users/NoelDeMartin/events{/privacy}","received_events_url":"https://api.github.com/users/NoelDeMartin/received_events","type":"User","site_admin":false},"body":"As discussed in #173, this is an approach to create dynamic modals at runtime. It is complimentary to everything on the package and backward compatible. This can be useful in different situations, 2 in particular come to mind:\r\n\r\n- Decluttering templates and leaving modal logic to controllers.\r\n- Using lazy-loading of modals for SPAs.\r\n\r\nI am not overly familiar with this package, so I tried to add everything necessary (documentation, linting, typings, etc) but I'm sure there is something missing. Please take this as a proposal rather than a full implementation.","created_at":"2018-02-15T17:34:47Z","updated_at":"2018-02-15T17:34:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/euvl/vue-js-modal/pulls/175/commits","review_comments_url":"https://api.github.com/repos/euvl/vue-js-modal/pulls/175/comments","review_comment_url":"https://api.github.com/repos/euvl/vue-js-modal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/euvl/vue-js-modal/issues/175/comments","statuses_url":"https://api.github.com/repos/euvl/vue-js-modal/statuses/c36dfb3c3961edbe9c2d6d8b05b0d6915d086e5c","head":{"label":"NoelDeMartin:dynamic-modals","ref":"dynamic-modals","sha":"c36dfb3c3961edbe9c2d6d8b05b0d6915d086e5c","user":{"login":"NoelDeMartin","id":1517677,"avatar_url":"https://avatars3.githubusercontent.com/u/1517677?v=4","gravatar_id":"","url":"https://api.github.com/users/NoelDeMartin","html_url":"https://github.com/NoelDeMartin","followers_url":"https://api.github.com/users/NoelDeMartin/followers","following_url":"https://api.github.com/users/NoelDeMartin/following{/other_user}","gists_url":"https://api.github.com/users/NoelDeMartin/gists{/gist_id}","starred_url":"https://api.github.com/users/NoelDeMartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NoelDeMartin/subscriptions","organizations_url":"https://api.github.com/users/NoelDeMartin/orgs","repos_url":"https://api.github.com/users/NoelDeMartin/repos","events_url":"https://api.github.com/users/NoelDeMartin/events{/privacy}","received_events_url":"https://api.github.com/users/NoelDeMartin/received_events","type":"User","site_admin":false},"repo":{"id":121650136,"name":"vue-js-modal","full_name":"NoelDeMartin/vue-js-modal","owner":{"login":"NoelDeMartin","id":1517677,"avatar_url":"https://avatars3.githubusercontent.com/u/1517677?v=4","gravatar_id":"","url":"https://api.github.com/users/NoelDeMartin","html_url":"https://github.com/NoelDeMartin","followers_url":"https://api.github.com/users/NoelDeMartin/followers","following_url":"https://api.github.com/users/NoelDeMartin/following{/other_user}","gists_url":"https://api.github.com/users/NoelDeMartin/gists{/gist_id}","starred_url":"https://api.github.com/users/NoelDeMartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NoelDeMartin/subscriptions","organizations_url":"https://api.github.com/users/NoelDeMartin/orgs","repos_url":"https://api.github.com/users/NoelDeMartin/repos","events_url":"https://api.github.com/users/NoelDeMartin/events{/privacy}","received_events_url":"https://api.github.com/users/NoelDeMartin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NoelDeMartin/vue-js-modal","description":":pizza: Simple to use, highly customizable, mobile friendly Vue.js 2.0+ modal.","fork":true,"url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal","forks_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/forks","keys_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/teams","hooks_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/hooks","issue_events_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/issues/events{/number}","events_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/events","assignees_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/assignees{/user}","branches_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/branches{/branch}","tags_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/tags","blobs_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/git/refs{/sha}","trees_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/statuses/{sha}","languages_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/languages","stargazers_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/stargazers","contributors_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/contributors","subscribers_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/subscribers","subscription_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/subscription","commits_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/commits{/sha}","git_commits_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/git/commits{/sha}","comments_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/comments{/number}","issue_comment_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/issues/comments{/number}","contents_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/contents/{+path}","compare_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/merges","archive_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/downloads","issues_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/issues{/number}","pulls_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/pulls{/number}","milestones_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/milestones{/number}","notifications_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/labels{/name}","releases_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/releases{/id}","deployments_url":"https://api.github.com/repos/NoelDeMartin/vue-js-modal/deployments","created_at":"2018-02-15T16:07:55Z","updated_at":"2018-02-15T16:07:58Z","pushed_at":"2018-02-15T17:30:09Z","git_url":"git://github.com/NoelDeMartin/vue-js-modal.git","ssh_url":"git@github.com:NoelDeMartin/vue-js-modal.git","clone_url":"https://github.com/NoelDeMartin/vue-js-modal.git","svn_url":"https://github.com/NoelDeMartin/vue-js-modal","homepage":"http://vue-js-modal.yev.io","size":1882,"stargazers_count":0,"watchers_count":0,"language":"Vue","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"euvl:master","ref":"master","sha":"5b2db5b38a804966c4de005a347fbb874e657ee6","user":{"login":"euvl","id":1577802,"avatar_url":"https://avatars0.githubusercontent.com/u/1577802?v=4","gravatar_id":"","url":"https://api.github.com/users/euvl","html_url":"https://github.com/euvl","followers_url":"https://api.github.com/users/euvl/followers","following_url":"https://api.github.com/users/euvl/following{/other_user}","gists_url":"https://api.github.com/users/euvl/gists{/gist_id}","starred_url":"https://api.github.com/users/euvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euvl/subscriptions","organizations_url":"https://api.github.com/users/euvl/orgs","repos_url":"https://api.github.com/users/euvl/repos","events_url":"https://api.github.com/users/euvl/events{/privacy}","received_events_url":"https://api.github.com/users/euvl/received_events","type":"User","site_admin":false},"repo":{"id":73701576,"name":"vue-js-modal","full_name":"euvl/vue-js-modal","owner":{"login":"euvl","id":1577802,"avatar_url":"https://avatars0.githubusercontent.com/u/1577802?v=4","gravatar_id":"","url":"https://api.github.com/users/euvl","html_url":"https://github.com/euvl","followers_url":"https://api.github.com/users/euvl/followers","following_url":"https://api.github.com/users/euvl/following{/other_user}","gists_url":"https://api.github.com/users/euvl/gists{/gist_id}","starred_url":"https://api.github.com/users/euvl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euvl/subscriptions","organizations_url":"https://api.github.com/users/euvl/orgs","repos_url":"https://api.github.com/users/euvl/repos","events_url":"https://api.github.com/users/euvl/events{/privacy}","received_events_url":"https://api.github.com/users/euvl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/euvl/vue-js-modal","description":":pizza: Simple to use, highly customizable, mobile friendly Vue.js 2.0+ modal.","fork":false,"url":"https://api.github.com/repos/euvl/vue-js-modal","forks_url":"https://api.github.com/repos/euvl/vue-js-modal/forks","keys_url":"https://api.github.com/repos/euvl/vue-js-modal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/euvl/vue-js-modal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/euvl/vue-js-modal/teams","hooks_url":"https://api.github.com/repos/euvl/vue-js-modal/hooks","issue_events_url":"https://api.github.com/repos/euvl/vue-js-modal/issues/events{/number}","events_url":"https://api.github.com/repos/euvl/vue-js-modal/events","assignees_url":"https://api.github.com/repos/euvl/vue-js-modal/assignees{/user}","branches_url":"https://api.github.com/repos/euvl/vue-js-modal/branches{/branch}","tags_url":"https://api.github.com/repos/euvl/vue-js-modal/tags","blobs_url":"https://api.github.com/repos/euvl/vue-js-modal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/euvl/vue-js-modal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/euvl/vue-js-modal/git/refs{/sha}","trees_url":"https://api.github.com/repos/euvl/vue-js-modal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/euvl/vue-js-modal/statuses/{sha}","languages_url":"https://api.github.com/repos/euvl/vue-js-modal/languages","stargazers_url":"https://api.github.com/repos/euvl/vue-js-modal/stargazers","contributors_url":"https://api.github.com/repos/euvl/vue-js-modal/contributors","subscribers_url":"https://api.github.com/repos/euvl/vue-js-modal/subscribers","subscription_url":"https://api.github.com/repos/euvl/vue-js-modal/subscription","commits_url":"https://api.github.com/repos/euvl/vue-js-modal/commits{/sha}","git_commits_url":"https://api.github.com/repos/euvl/vue-js-modal/git/commits{/sha}","comments_url":"https://api.github.com/repos/euvl/vue-js-modal/comments{/number}","issue_comment_url":"https://api.github.com/repos/euvl/vue-js-modal/issues/comments{/number}","contents_url":"https://api.github.com/repos/euvl/vue-js-modal/contents/{+path}","compare_url":"https://api.github.com/repos/euvl/vue-js-modal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/euvl/vue-js-modal/merges","archive_url":"https://api.github.com/repos/euvl/vue-js-modal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/euvl/vue-js-modal/downloads","issues_url":"https://api.github.com/repos/euvl/vue-js-modal/issues{/number}","pulls_url":"https://api.github.com/repos/euvl/vue-js-modal/pulls{/number}","milestones_url":"https://api.github.com/repos/euvl/vue-js-modal/milestones{/number}","notifications_url":"https://api.github.com/repos/euvl/vue-js-modal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/euvl/vue-js-modal/labels{/name}","releases_url":"https://api.github.com/repos/euvl/vue-js-modal/releases{/id}","deployments_url":"https://api.github.com/repos/euvl/vue-js-modal/deployments","created_at":"2016-11-14T12:15:54Z","updated_at":"2018-02-15T14:59:34Z","pushed_at":"2018-02-15T14:12:11Z","git_url":"git://github.com/euvl/vue-js-modal.git","ssh_url":"git@github.com:euvl/vue-js-modal.git","clone_url":"https://github.com/euvl/vue-js-modal.git","svn_url":"https://github.com/euvl/vue-js-modal","homepage":"http://vue-js-modal.yev.io","size":1882,"stargazers_count":866,"watchers_count":866,"language":"Vue","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":117,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":117,"open_issues":9,"watchers":866,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/euvl/vue-js-modal/pulls/175"},"html":{"href":"https://github.com/euvl/vue-js-modal/pull/175"},"issue":{"href":"https://api.github.com/repos/euvl/vue-js-modal/issues/175"},"comments":{"href":"https://api.github.com/repos/euvl/vue-js-modal/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/euvl/vue-js-modal/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/euvl/vue-js-modal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/euvl/vue-js-modal/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/euvl/vue-js-modal/statuses/c36dfb3c3961edbe9c2d6d8b05b0d6915d086e5c"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":236,"deletions":60,"changed_files":11}}
{"actor":{"display_login":"NoelDeMartin"}}