{"action":"created","comment":{"url":"https://api.github.com/repos/kata-containers/runtime/pulls/comments/181892951","pull_request_review_id":112597631,"id":181892951,"diff_hunk":"@@ -110,6 +111,8 @@ const (\n \tmaxDevIDSize            = 31\n )\n \n+const bridgePCIStartAddr = 5","path":"virtcontainers/qemu_arch_base.go","position":12,"original_position":12,"commit_id":"a64f2eb2bf720faa8e1c3f014cca52ed33e1f17c","original_commit_id":"a64f2eb2bf720faa8e1c3f014cca52ed33e1f17c","user":{"login":"sboeuf","id":22890413,"avatar_url":"https://avatars3.githubusercontent.com/u/22890413?v=4","gravatar_id":"","url":"https://api.github.com/users/sboeuf","html_url":"https://github.com/sboeuf","followers_url":"https://api.github.com/users/sboeuf/followers","following_url":"https://api.github.com/users/sboeuf/following{/other_user}","gists_url":"https://api.github.com/users/sboeuf/gists{/gist_id}","starred_url":"https://api.github.com/users/sboeuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sboeuf/subscriptions","organizations_url":"https://api.github.com/users/sboeuf/orgs","repos_url":"https://api.github.com/users/sboeuf/repos","events_url":"https://api.github.com/users/sboeuf/events{/privacy}","received_events_url":"https://api.github.com/users/sboeuf/received_events","type":"User","site_admin":false},"body":"I totally get it, I was wondering if other cold plugged devices (do we have some ?), could be cold plugged before the bridge. If that's the case, then you cannot guarantee that nothing else will appear at address 5.\r\nFollowing this explanation, if you're sure that the bridge is gonna be the first thing being added to the main bridge, then I think it is better to take the first PCI address that we know available (and explain that previous addresses 0 and 1 are indeed used internally by Qemu, but this is a known thing).","created_at":"2018-04-16T21:34:38Z","updated_at":"2018-04-16T21:34:38Z","html_url":"https://github.com/kata-containers/runtime/pull/211#discussion_r181892951","pull_request_url":"https://api.github.com/repos/kata-containers/runtime/pulls/211","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/comments/181892951"},"html":{"href":"https://github.com/kata-containers/runtime/pull/211#discussion_r181892951"},"pull_request":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/211"}},"in_reply_to_id":181767250},"pull_request":{"url":"https://api.github.com/repos/kata-containers/runtime/pulls/211","id":181614308,"html_url":"https://github.com/kata-containers/runtime/pull/211","diff_url":"https://github.com/kata-containers/runtime/pull/211.diff","patch_url":"https://github.com/kata-containers/runtime/pull/211.patch","issue_url":"https://api.github.com/repos/kata-containers/runtime/issues/211","number":211,"state":"open","locked":false,"title":"Assign address to a pci bridge while appending it","user":{"login":"amshinde","id":7132811,"avatar_url":"https://avatars0.githubusercontent.com/u/7132811?v=4","gravatar_id":"","url":"https://api.github.com/users/amshinde","html_url":"https://github.com/amshinde","followers_url":"https://api.github.com/users/amshinde/followers","following_url":"https://api.github.com/users/amshinde/following{/other_user}","gists_url":"https://api.github.com/users/amshinde/gists{/gist_id}","starred_url":"https://api.github.com/users/amshinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amshinde/subscriptions","organizations_url":"https://api.github.com/users/amshinde/orgs","repos_url":"https://api.github.com/users/amshinde/repos","events_url":"https://api.github.com/users/amshinde/events{/privacy}","received_events_url":"https://api.github.com/users/amshinde/received_events","type":"User","site_admin":false},"body":"This will allow to determine the PCI address of the device attached to the bridge within the guest.","created_at":"2018-04-13T23:12:31Z","updated_at":"2018-04-16T21:34:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88a52d71fe84d16c90438a7a0555f685054ee756","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":837054292,"url":"https://api.github.com/repos/kata-containers/runtime/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kata-containers/runtime/pulls/211/commits","review_comments_url":"https://api.github.com/repos/kata-containers/runtime/pulls/211/comments","review_comment_url":"https://api.github.com/repos/kata-containers/runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kata-containers/runtime/issues/211/comments","statuses_url":"https://api.github.com/repos/kata-containers/runtime/statuses/a64f2eb2bf720faa8e1c3f014cca52ed33e1f17c","head":{"label":"amshinde:assign-bridge-addr","ref":"assign-bridge-addr","sha":"a64f2eb2bf720faa8e1c3f014cca52ed33e1f17c","user":{"login":"amshinde","id":7132811,"avatar_url":"https://avatars0.githubusercontent.com/u/7132811?v=4","gravatar_id":"","url":"https://api.github.com/users/amshinde","html_url":"https://github.com/amshinde","followers_url":"https://api.github.com/users/amshinde/followers","following_url":"https://api.github.com/users/amshinde/following{/other_user}","gists_url":"https://api.github.com/users/amshinde/gists{/gist_id}","starred_url":"https://api.github.com/users/amshinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amshinde/subscriptions","organizations_url":"https://api.github.com/users/amshinde/orgs","repos_url":"https://api.github.com/users/amshinde/repos","events_url":"https://api.github.com/users/amshinde/events{/privacy}","received_events_url":"https://api.github.com/users/amshinde/received_events","type":"User","site_admin":false},"repo":{"id":125129475,"name":"kata-runtime","full_name":"amshinde/kata-runtime","owner":{"login":"amshinde","id":7132811,"avatar_url":"https://avatars0.githubusercontent.com/u/7132811?v=4","gravatar_id":"","url":"https://api.github.com/users/amshinde","html_url":"https://github.com/amshinde","followers_url":"https://api.github.com/users/amshinde/followers","following_url":"https://api.github.com/users/amshinde/following{/other_user}","gists_url":"https://api.github.com/users/amshinde/gists{/gist_id}","starred_url":"https://api.github.com/users/amshinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amshinde/subscriptions","organizations_url":"https://api.github.com/users/amshinde/orgs","repos_url":"https://api.github.com/users/amshinde/repos","events_url":"https://api.github.com/users/amshinde/events{/privacy}","received_events_url":"https://api.github.com/users/amshinde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amshinde/kata-runtime","description":"Kata Containers runtimes","fork":true,"url":"https://api.github.com/repos/amshinde/kata-runtime","forks_url":"https://api.github.com/repos/amshinde/kata-runtime/forks","keys_url":"https://api.github.com/repos/amshinde/kata-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amshinde/kata-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amshinde/kata-runtime/teams","hooks_url":"https://api.github.com/repos/amshinde/kata-runtime/hooks","issue_events_url":"https://api.github.com/repos/amshinde/kata-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/amshinde/kata-runtime/events","assignees_url":"https://api.github.com/repos/amshinde/kata-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/amshinde/kata-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/amshinde/kata-runtime/tags","blobs_url":"https://api.github.com/repos/amshinde/kata-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amshinde/kata-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amshinde/kata-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/amshinde/kata-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amshinde/kata-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/amshinde/kata-runtime/languages","stargazers_url":"https://api.github.com/repos/amshinde/kata-runtime/stargazers","contributors_url":"https://api.github.com/repos/amshinde/kata-runtime/contributors","subscribers_url":"https://api.github.com/repos/amshinde/kata-runtime/subscribers","subscription_url":"https://api.github.com/repos/amshinde/kata-runtime/subscription","commits_url":"https://api.github.com/repos/amshinde/kata-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/amshinde/kata-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/amshinde/kata-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/amshinde/kata-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/amshinde/kata-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/amshinde/kata-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amshinde/kata-runtime/merges","archive_url":"https://api.github.com/repos/amshinde/kata-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amshinde/kata-runtime/downloads","issues_url":"https://api.github.com/repos/amshinde/kata-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/amshinde/kata-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/amshinde/kata-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/amshinde/kata-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amshinde/kata-runtime/labels{/name}","releases_url":"https://api.github.com/repos/amshinde/kata-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/amshinde/kata-runtime/deployments","created_at":"2018-03-13T23:53:09Z","updated_at":"2018-03-14T00:33:32Z","pushed_at":"2018-04-16T20:48:41Z","git_url":"git://github.com/amshinde/kata-runtime.git","ssh_url":"git@github.com:amshinde/kata-runtime.git","clone_url":"https://github.com/amshinde/kata-runtime.git","svn_url":"https://github.com/amshinde/kata-runtime","homepage":"","size":3772,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kata-containers:master","ref":"master","sha":"ad5669f781e68ce0ed4f2b28e378ed4f6e8fb2e3","user":{"login":"kata-containers","id":33289952,"avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"repo":{"id":110539997,"name":"runtime","full_name":"kata-containers/runtime","owner":{"login":"kata-containers","id":33289952,"avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kata-containers/runtime","description":"Kata Containers runtimes","fork":false,"url":"https://api.github.com/repos/kata-containers/runtime","forks_url":"https://api.github.com/repos/kata-containers/runtime/forks","keys_url":"https://api.github.com/repos/kata-containers/runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kata-containers/runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kata-containers/runtime/teams","hooks_url":"https://api.github.com/repos/kata-containers/runtime/hooks","issue_events_url":"https://api.github.com/repos/kata-containers/runtime/issues/events{/number}","events_url":"https://api.github.com/repos/kata-containers/runtime/events","assignees_url":"https://api.github.com/repos/kata-containers/runtime/assignees{/user}","branches_url":"https://api.github.com/repos/kata-containers/runtime/branches{/branch}","tags_url":"https://api.github.com/repos/kata-containers/runtime/tags","blobs_url":"https://api.github.com/repos/kata-containers/runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kata-containers/runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kata-containers/runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/kata-containers/runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kata-containers/runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/kata-containers/runtime/languages","stargazers_url":"https://api.github.com/repos/kata-containers/runtime/stargazers","contributors_url":"https://api.github.com/repos/kata-containers/runtime/contributors","subscribers_url":"https://api.github.com/repos/kata-containers/runtime/subscribers","subscription_url":"https://api.github.com/repos/kata-containers/runtime/subscription","commits_url":"https://api.github.com/repos/kata-containers/runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/kata-containers/runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/kata-containers/runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/kata-containers/runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/kata-containers/runtime/contents/{+path}","compare_url":"https://api.github.com/repos/kata-containers/runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kata-containers/runtime/merges","archive_url":"https://api.github.com/repos/kata-containers/runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kata-containers/runtime/downloads","issues_url":"https://api.github.com/repos/kata-containers/runtime/issues{/number}","pulls_url":"https://api.github.com/repos/kata-containers/runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/kata-containers/runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/kata-containers/runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kata-containers/runtime/labels{/name}","releases_url":"https://api.github.com/repos/kata-containers/runtime/releases{/id}","deployments_url":"https://api.github.com/repos/kata-containers/runtime/deployments","created_at":"2017-11-13T11:29:03Z","updated_at":"2018-04-16T14:24:45Z","pushed_at":"2018-04-16T21:34:10Z","git_url":"git://github.com/kata-containers/runtime.git","ssh_url":"git@github.com:kata-containers/runtime.git","clone_url":"https://github.com/kata-containers/runtime.git","svn_url":"https://github.com/kata-containers/runtime","homepage":"","size":3766,"stargazers_count":130,"watchers_count":130,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":37,"open_issues":83,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/211"},"html":{"href":"https://github.com/kata-containers/runtime/pull/211"},"issue":{"href":"https://api.github.com/repos/kata-containers/runtime/issues/211"},"comments":{"href":"https://api.github.com/repos/kata-containers/runtime/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/kata-containers/runtime/statuses/a64f2eb2bf720faa8e1c3f014cca52ed33e1f17c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sboeuf"}}