{"action":"created","issue":{"url":"https://api.github.com/repos/Educama/Showcase/issues/166","repository_url":"https://api.github.com/repos/Educama/Showcase","labels_url":"https://api.github.com/repos/Educama/Showcase/issues/166/labels{/name}","comments_url":"https://api.github.com/repos/Educama/Showcase/issues/166/comments","events_url":"https://api.github.com/repos/Educama/Showcase/issues/166/events","html_url":"https://github.com/Educama/Showcase/pull/166","id":322779749,"number":166,"title":"ECM-291: Added integration test for CustomerController, refactored so…","user":{"login":"StvWltr","id":19705554,"avatar_url":"https://avatars3.githubusercontent.com/u/19705554?v=4","gravatar_id":"","url":"https://api.github.com/users/StvWltr","html_url":"https://github.com/StvWltr","followers_url":"https://api.github.com/users/StvWltr/followers","following_url":"https://api.github.com/users/StvWltr/following{/other_user}","gists_url":"https://api.github.com/users/StvWltr/gists{/gist_id}","starred_url":"https://api.github.com/users/StvWltr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StvWltr/subscriptions","organizations_url":"https://api.github.com/users/StvWltr/orgs","repos_url":"https://api.github.com/users/StvWltr/repos","events_url":"https://api.github.com/users/StvWltr/events{/privacy}","received_events_url":"https://api.github.com/users/StvWltr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-14T11:38:37Z","updated_at":"2018-05-16T05:54:53Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Educama/Showcase/pulls/166","html_url":"https://github.com/Educama/Showcase/pull/166","diff_url":"https://github.com/Educama/Showcase/pull/166.diff","patch_url":"https://github.com/Educama/Showcase/pull/166.patch"},"body":"- added spring integration test for CustomerController\r\n- refactored CustomerBoundaryService\r\n- Changed access to fields of Address (best-practice)\r\n- Replaced some field injection with constructor injection (best-practice)"},"comment":{"url":"https://api.github.com/repos/Educama/Showcase/issues/comments/389403257","html_url":"https://github.com/Educama/Showcase/pull/166#issuecomment-389403257","issue_url":"https://api.github.com/repos/Educama/Showcase/issues/166","id":389403257,"user":{"login":"StvWltr","id":19705554,"avatar_url":"https://avatars3.githubusercontent.com/u/19705554?v=4","gravatar_id":"","url":"https://api.github.com/users/StvWltr","html_url":"https://github.com/StvWltr","followers_url":"https://api.github.com/users/StvWltr/followers","following_url":"https://api.github.com/users/StvWltr/following{/other_user}","gists_url":"https://api.github.com/users/StvWltr/gists{/gist_id}","starred_url":"https://api.github.com/users/StvWltr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StvWltr/subscriptions","organizations_url":"https://api.github.com/users/StvWltr/orgs","repos_url":"https://api.github.com/users/StvWltr/repos","events_url":"https://api.github.com/users/StvWltr/events{/privacy}","received_events_url":"https://api.github.com/users/StvWltr/received_events","type":"User","site_admin":false},"created_at":"2018-05-16T05:54:53Z","updated_at":"2018-05-16T05:54:53Z","author_association":"NONE","body":"Hi Lars,\r\n\r\nthank you for your clarification. I was not aware of the fact, that constructor injection is not to be used in this project (However there are several classes in the code using it). I found this nowhere to be documented. I also thought, a goal of this project was to apply best practices, which is constructor injection in my opinion. That's why i changed this part. Shall i remove constructor injection from this pull request?"}}
{"actor":{"display_login":"StvWltr"}}