{"action":"created","comment":{"url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/comments/190658513","pull_request_review_id":123083000,"id":190658513,"diff_hunk":"@@ -383,13 +430,16 @@ def checkAndShareObjectWithPeers(data):\n     if not isProofOfWorkSufficient(data):\n         logger.info('Proof of work is insufficient.')\n         return 0\n-    \n+\n     endOfLifeTime, = unpack('>Q', data[8:16])\n-    if endOfLifeTime - int(time.time()) > 28 * 24 * 60 * 60 + 10800: # The TTL may not be larger than 28 days + 3 hours of wiggle room\n+    # The TTL may not be larger than 28 days + 3 hours of wiggle room\n+    if endOfLifeTime - int(time.time()) > 28 * 24 * 60 * 60 + 10800:\n         logger.info('This object\\'s End of Life time is too far in the future. Ignoring it. Time is %s', endOfLifeTime)\n         return 0\n-    if endOfLifeTime - int(time.time()) < - 3600: # The EOL time was more than an hour ago. That's too much.\n-        logger.info('This object\\'s End of Life time was more than an hour ago. Ignoring the object. Time is %s', endOfLifeTime)\n+    if endOfLifeTime - int(time.time()) < - 3600:  # The EOL time was more than an hour ago. That's too much.","path":"src/protocol.py","position":484,"original_position":475,"commit_id":"e1c2e8ec46912c106e60a14b3d8330da8ef60df8","original_commit_id":"ab1dd319e3b74a539aad7d29cfff37bfe128e19b","user":{"login":"g1itch","id":4012700,"avatar_url":"https://avatars1.githubusercontent.com/u/4012700?v=4","gravatar_id":"","url":"https://api.github.com/users/g1itch","html_url":"https://github.com/g1itch","followers_url":"https://api.github.com/users/g1itch/followers","following_url":"https://api.github.com/users/g1itch/following{/other_user}","gists_url":"https://api.github.com/users/g1itch/gists{/gist_id}","starred_url":"https://api.github.com/users/g1itch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g1itch/subscriptions","organizations_url":"https://api.github.com/users/g1itch/orgs","repos_url":"https://api.github.com/users/g1itch/repos","events_url":"https://api.github.com/users/g1itch/events{/privacy}","received_events_url":"https://api.github.com/users/g1itch/received_events","type":"User","site_admin":false},"body":"My remark was exactly about style: I think the space is redundant here. No doubt that works correctly in any python interpreter.","created_at":"2018-05-24T16:54:15Z","updated_at":"2018-05-24T16:54:15Z","html_url":"https://github.com/Bitmessage/PyBitmessage/pull/1261#discussion_r190658513","pull_request_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/1261","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/comments/190658513"},"html":{"href":"https://github.com/Bitmessage/PyBitmessage/pull/1261#discussion_r190658513"},"pull_request":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/1261"}},"in_reply_to_id":190549119},"pull_request":{"url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/1261","id":190233286,"html_url":"https://github.com/Bitmessage/PyBitmessage/pull/1261","diff_url":"https://github.com/Bitmessage/PyBitmessage/pull/1261.diff","patch_url":"https://github.com/Bitmessage/PyBitmessage/pull/1261.patch","issue_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/1261","number":1261,"state":"open","locked":false,"title":"Fixed: Code style and lint fixes","user":{"login":"coffeedogs","id":38851325,"avatar_url":"https://avatars2.githubusercontent.com/u/38851325?v=4","gravatar_id":"","url":"https://api.github.com/users/coffeedogs","html_url":"https://github.com/coffeedogs","followers_url":"https://api.github.com/users/coffeedogs/followers","following_url":"https://api.github.com/users/coffeedogs/following{/other_user}","gists_url":"https://api.github.com/users/coffeedogs/gists{/gist_id}","starred_url":"https://api.github.com/users/coffeedogs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coffeedogs/subscriptions","organizations_url":"https://api.github.com/users/coffeedogs/orgs","repos_url":"https://api.github.com/users/coffeedogs/repos","events_url":"https://api.github.com/users/coffeedogs/events{/privacy}","received_events_url":"https://api.github.com/users/coffeedogs/received_events","type":"User","site_admin":false},"body":"Address code style and lint violations in the next two most violating files.\r\n\r\nOf interest for testing would be the change to imports. The app runs for me but my testing procedure is not thorough yet.","created_at":"2018-05-24T09:59:25Z","updated_at":"2018-05-24T16:54:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"907debcb2701204669563c4a136b32a538b1625c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"PeterSurda","id":3815204,"avatar_url":"https://avatars0.githubusercontent.com/u/3815204?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterSurda","html_url":"https://github.com/PeterSurda","followers_url":"https://api.github.com/users/PeterSurda/followers","following_url":"https://api.github.com/users/PeterSurda/following{/other_user}","gists_url":"https://api.github.com/users/PeterSurda/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterSurda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterSurda/subscriptions","organizations_url":"https://api.github.com/users/PeterSurda/orgs","repos_url":"https://api.github.com/users/PeterSurda/repos","events_url":"https://api.github.com/users/PeterSurda/events{/privacy}","received_events_url":"https://api.github.com/users/PeterSurda/received_events","type":"User","site_admin":false},{"login":"omkar1117","id":4657893,"avatar_url":"https://avatars3.githubusercontent.com/u/4657893?v=4","gravatar_id":"","url":"https://api.github.com/users/omkar1117","html_url":"https://github.com/omkar1117","followers_url":"https://api.github.com/users/omkar1117/followers","following_url":"https://api.github.com/users/omkar1117/following{/other_user}","gists_url":"https://api.github.com/users/omkar1117/gists{/gist_id}","starred_url":"https://api.github.com/users/omkar1117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omkar1117/subscriptions","organizations_url":"https://api.github.com/users/omkar1117/orgs","repos_url":"https://api.github.com/users/omkar1117/repos","events_url":"https://api.github.com/users/omkar1117/events{/privacy}","received_events_url":"https://api.github.com/users/omkar1117/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/1261/commits","review_comments_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/1261/comments","review_comment_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/1261/comments","statuses_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/statuses/e1c2e8ec46912c106e60a14b3d8330da8ef60df8","head":{"label":"coffeedogs:codeQ-2105","ref":"codeQ-2105","sha":"e1c2e8ec46912c106e60a14b3d8330da8ef60df8","user":{"login":"coffeedogs","id":38851325,"avatar_url":"https://avatars2.githubusercontent.com/u/38851325?v=4","gravatar_id":"","url":"https://api.github.com/users/coffeedogs","html_url":"https://github.com/coffeedogs","followers_url":"https://api.github.com/users/coffeedogs/followers","following_url":"https://api.github.com/users/coffeedogs/following{/other_user}","gists_url":"https://api.github.com/users/coffeedogs/gists{/gist_id}","starred_url":"https://api.github.com/users/coffeedogs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coffeedogs/subscriptions","organizations_url":"https://api.github.com/users/coffeedogs/orgs","repos_url":"https://api.github.com/users/coffeedogs/repos","events_url":"https://api.github.com/users/coffeedogs/events{/privacy}","received_events_url":"https://api.github.com/users/coffeedogs/received_events","type":"User","site_admin":false},"repo":{"id":131573331,"name":"PyBitmessage","full_name":"coffeedogs/PyBitmessage","owner":{"login":"coffeedogs","id":38851325,"avatar_url":"https://avatars2.githubusercontent.com/u/38851325?v=4","gravatar_id":"","url":"https://api.github.com/users/coffeedogs","html_url":"https://github.com/coffeedogs","followers_url":"https://api.github.com/users/coffeedogs/followers","following_url":"https://api.github.com/users/coffeedogs/following{/other_user}","gists_url":"https://api.github.com/users/coffeedogs/gists{/gist_id}","starred_url":"https://api.github.com/users/coffeedogs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coffeedogs/subscriptions","organizations_url":"https://api.github.com/users/coffeedogs/orgs","repos_url":"https://api.github.com/users/coffeedogs/repos","events_url":"https://api.github.com/users/coffeedogs/events{/privacy}","received_events_url":"https://api.github.com/users/coffeedogs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coffeedogs/PyBitmessage","description":"Reference client for Bitmessage: a P2P encrypted decentralised communication protocol:","fork":true,"url":"https://api.github.com/repos/coffeedogs/PyBitmessage","forks_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/forks","keys_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/teams","hooks_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/hooks","issue_events_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/issues/events{/number}","events_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/events","assignees_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/assignees{/user}","branches_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/branches{/branch}","tags_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/tags","blobs_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/git/refs{/sha}","trees_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/statuses/{sha}","languages_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/languages","stargazers_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/stargazers","contributors_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/contributors","subscribers_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/subscribers","subscription_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/subscription","commits_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/commits{/sha}","git_commits_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/git/commits{/sha}","comments_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/comments{/number}","issue_comment_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/issues/comments{/number}","contents_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/contents/{+path}","compare_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/merges","archive_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/downloads","issues_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/issues{/number}","pulls_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/pulls{/number}","milestones_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/milestones{/number}","notifications_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/labels{/name}","releases_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/releases{/id}","deployments_url":"https://api.github.com/repos/coffeedogs/PyBitmessage/deployments","created_at":"2018-04-30T08:41:37Z","updated_at":"2018-04-30T08:41:40Z","pushed_at":"2018-05-24T16:00:06Z","git_url":"git://github.com/coffeedogs/PyBitmessage.git","ssh_url":"git@github.com:coffeedogs/PyBitmessage.git","clone_url":"https://github.com/coffeedogs/PyBitmessage.git","svn_url":"https://github.com/coffeedogs/PyBitmessage","homepage":"https://bitmessage.org/wiki/Main_Page","size":9566,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Bitmessage:v0.6","ref":"v0.6","sha":"74ddda8775156d6b4271284b6902058513c5d3d5","user":{"login":"Bitmessage","id":2625379,"avatar_url":"https://avatars3.githubusercontent.com/u/2625379?v=4","gravatar_id":"","url":"https://api.github.com/users/Bitmessage","html_url":"https://github.com/Bitmessage","followers_url":"https://api.github.com/users/Bitmessage/followers","following_url":"https://api.github.com/users/Bitmessage/following{/other_user}","gists_url":"https://api.github.com/users/Bitmessage/gists{/gist_id}","starred_url":"https://api.github.com/users/Bitmessage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bitmessage/subscriptions","organizations_url":"https://api.github.com/users/Bitmessage/orgs","repos_url":"https://api.github.com/users/Bitmessage/repos","events_url":"https://api.github.com/users/Bitmessage/events{/privacy}","received_events_url":"https://api.github.com/users/Bitmessage/received_events","type":"Organization","site_admin":false},"repo":{"id":6648028,"name":"PyBitmessage","full_name":"Bitmessage/PyBitmessage","owner":{"login":"Bitmessage","id":2625379,"avatar_url":"https://avatars3.githubusercontent.com/u/2625379?v=4","gravatar_id":"","url":"https://api.github.com/users/Bitmessage","html_url":"https://github.com/Bitmessage","followers_url":"https://api.github.com/users/Bitmessage/followers","following_url":"https://api.github.com/users/Bitmessage/following{/other_user}","gists_url":"https://api.github.com/users/Bitmessage/gists{/gist_id}","starred_url":"https://api.github.com/users/Bitmessage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bitmessage/subscriptions","organizations_url":"https://api.github.com/users/Bitmessage/orgs","repos_url":"https://api.github.com/users/Bitmessage/repos","events_url":"https://api.github.com/users/Bitmessage/events{/privacy}","received_events_url":"https://api.github.com/users/Bitmessage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Bitmessage/PyBitmessage","description":"Reference client for Bitmessage: a P2P encrypted decentralised communication protocol:","fork":false,"url":"https://api.github.com/repos/Bitmessage/PyBitmessage","forks_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/forks","keys_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/teams","hooks_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/hooks","issue_events_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/events{/number}","events_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/events","assignees_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/assignees{/user}","branches_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/branches{/branch}","tags_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/tags","blobs_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/statuses/{sha}","languages_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/languages","stargazers_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/stargazers","contributors_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/contributors","subscribers_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/subscribers","subscription_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/subscription","commits_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/contents/{+path}","compare_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/merges","archive_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/downloads","issues_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues{/number}","pulls_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls{/number}","milestones_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/milestones{/number}","notifications_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/labels{/name}","releases_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/releases{/id}","deployments_url":"https://api.github.com/repos/Bitmessage/PyBitmessage/deployments","created_at":"2012-11-12T03:36:43Z","updated_at":"2018-05-24T07:54:20Z","pushed_at":"2018-05-24T16:00:09Z","git_url":"git://github.com/Bitmessage/PyBitmessage.git","ssh_url":"git@github.com:Bitmessage/PyBitmessage.git","clone_url":"https://github.com/Bitmessage/PyBitmessage.git","svn_url":"https://github.com/Bitmessage/PyBitmessage","homepage":"https://bitmessage.org/wiki/Main_Page","size":9506,"stargazers_count":2260,"watchers_count":2260,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":504,"mirror_url":null,"archived":false,"open_issues_count":150,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":504,"open_issues":150,"watchers":2260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/1261"},"html":{"href":"https://github.com/Bitmessage/PyBitmessage/pull/1261"},"issue":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/1261"},"comments":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/issues/1261/comments"},"review_comments":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/1261/comments"},"review_comment":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/pulls/1261/commits"},"statuses":{"href":"https://api.github.com/repos/Bitmessage/PyBitmessage/statuses/e1c2e8ec46912c106e60a14b3d8330da8ef60df8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"g1itch"}}