{"action":"created","comment":{"url":"https://api.github.com/repos/ray-project/ray/pulls/comments/239677871","pull_request_review_id":182528812,"id":239677871,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTY3Nzg3MQ==","diff_hunk":"@@ -58,17 +63,35 @@ def flush(self):\n class UnifiedLogger(Logger):\n     \"\"\"Unified result logger for TensorBoard, rllab/viskit, plain json.\n \n-    This class also periodically syncs output to the given upload uri.\"\"\"\n+    This class also periodically syncs output to the given upload uri.\n+\n+    Arguments:\n+        config: Configuration passed to all logger creators.\n+        logdir: Directory for all logger creators to log to.\n+        upload_uri (str): Optional URI where the logdir is sync'ed to.\n+        custom_loggers (list): List of custom logger creators.\n+        sync_cmd_tmpl (str): Optional template for syncer to run. Needs to\n+            include replacement fields \"{local_dir}\" and \"{remote_dir}\".\n+            See ray/python/ray/tune/log_sync.py","path":"python/ray/tune/logger.py","position":26,"original_position":26,"commit_id":"1a10482ff611aaff3329cd68dfe9106dc35da058","original_commit_id":"95fd1d00a29fe49bca1aab80a8434bb0ef001a75","user":{"login":"richardliaw","id":4529381,"node_id":"MDQ6VXNlcjQ1MjkzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4529381?v=4","gravatar_id":"","url":"https://api.github.com/users/richardliaw","html_url":"https://github.com/richardliaw","followers_url":"https://api.github.com/users/richardliaw/followers","following_url":"https://api.github.com/users/richardliaw/following{/other_user}","gists_url":"https://api.github.com/users/richardliaw/gists{/gist_id}","starred_url":"https://api.github.com/users/richardliaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardliaw/subscriptions","organizations_url":"https://api.github.com/users/richardliaw/orgs","repos_url":"https://api.github.com/users/richardliaw/repos","events_url":"https://api.github.com/users/richardliaw/events{/privacy}","received_events_url":"https://api.github.com/users/richardliaw/received_events","type":"User","site_admin":false},"body":"Hey @hartikainen, can you leave some feedback in #3034? The sentiment there is similar, but it would be great to get some consolidated feedback before implementing.","created_at":"2018-12-07T02:13:36Z","updated_at":"2018-12-07T02:13:36Z","html_url":"https://github.com/ray-project/ray/pull/3465#discussion_r239677871","pull_request_url":"https://api.github.com/repos/ray-project/ray/pulls/3465","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments/239677871"},"html":{"href":"https://github.com/ray-project/ray/pull/3465#discussion_r239677871"},"pull_request":{"href":"https://api.github.com/repos/ray-project/ray/pulls/3465"}},"in_reply_to_id":239331826},"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/3465","id":235938447,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1OTM4NDQ3","html_url":"https://github.com/ray-project/ray/pull/3465","diff_url":"https://github.com/ray-project/ray/pull/3465.diff","patch_url":"https://github.com/ray-project/ray/pull/3465.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/3465","number":3465,"state":"open","locked":false,"title":"[wip][tune] Custom Logging","user":{"login":"richardliaw","id":4529381,"node_id":"MDQ6VXNlcjQ1MjkzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4529381?v=4","gravatar_id":"","url":"https://api.github.com/users/richardliaw","html_url":"https://github.com/richardliaw","followers_url":"https://api.github.com/users/richardliaw/followers","following_url":"https://api.github.com/users/richardliaw/following{/other_user}","gists_url":"https://api.github.com/users/richardliaw/gists{/gist_id}","starred_url":"https://api.github.com/users/richardliaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardliaw/subscriptions","organizations_url":"https://api.github.com/users/richardliaw/orgs","repos_url":"https://api.github.com/users/richardliaw/repos","events_url":"https://api.github.com/users/richardliaw/events{/privacy}","received_events_url":"https://api.github.com/users/richardliaw/received_events","type":"User","site_admin":false},"body":"\r\n<!-- Please give a short brief about these changes. -->\r\n\r\nTODO: \r\n\r\n - [ ] Add tests for custom sync\r\n - [ ] Add test for custom logger\r\n\r\n<!-- Are there any issues opened that will be resolved by merging this change? -->\r\nThis should address #3034, #2985, and #3390.","created_at":"2018-12-04T19:52:47Z","updated_at":"2018-12-07T02:13:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5a51d6b72aa592abcf43e8fe3fd739274ef7e59","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/3465/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/3465/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/3465/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/1a10482ff611aaff3329cd68dfe9106dc35da058","head":{"label":"richardliaw:custom_logging","ref":"custom_logging","sha":"1a10482ff611aaff3329cd68dfe9106dc35da058","user":{"login":"richardliaw","id":4529381,"node_id":"MDQ6VXNlcjQ1MjkzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4529381?v=4","gravatar_id":"","url":"https://api.github.com/users/richardliaw","html_url":"https://github.com/richardliaw","followers_url":"https://api.github.com/users/richardliaw/followers","following_url":"https://api.github.com/users/richardliaw/following{/other_user}","gists_url":"https://api.github.com/users/richardliaw/gists{/gist_id}","starred_url":"https://api.github.com/users/richardliaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardliaw/subscriptions","organizations_url":"https://api.github.com/users/richardliaw/orgs","repos_url":"https://api.github.com/users/richardliaw/repos","events_url":"https://api.github.com/users/richardliaw/events{/privacy}","received_events_url":"https://api.github.com/users/richardliaw/received_events","type":"User","site_admin":false},"repo":{"id":79407420,"node_id":"MDEwOlJlcG9zaXRvcnk3OTQwNzQyMA==","name":"ray","full_name":"richardliaw/ray","private":false,"owner":{"login":"richardliaw","id":4529381,"node_id":"MDQ6VXNlcjQ1MjkzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4529381?v=4","gravatar_id":"","url":"https://api.github.com/users/richardliaw","html_url":"https://github.com/richardliaw","followers_url":"https://api.github.com/users/richardliaw/followers","following_url":"https://api.github.com/users/richardliaw/following{/other_user}","gists_url":"https://api.github.com/users/richardliaw/gists{/gist_id}","starred_url":"https://api.github.com/users/richardliaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardliaw/subscriptions","organizations_url":"https://api.github.com/users/richardliaw/orgs","repos_url":"https://api.github.com/users/richardliaw/repos","events_url":"https://api.github.com/users/richardliaw/events{/privacy}","received_events_url":"https://api.github.com/users/richardliaw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/richardliaw/ray","description":"An experimental distributed execution engine","fork":true,"url":"https://api.github.com/repos/richardliaw/ray","forks_url":"https://api.github.com/repos/richardliaw/ray/forks","keys_url":"https://api.github.com/repos/richardliaw/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richardliaw/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richardliaw/ray/teams","hooks_url":"https://api.github.com/repos/richardliaw/ray/hooks","issue_events_url":"https://api.github.com/repos/richardliaw/ray/issues/events{/number}","events_url":"https://api.github.com/repos/richardliaw/ray/events","assignees_url":"https://api.github.com/repos/richardliaw/ray/assignees{/user}","branches_url":"https://api.github.com/repos/richardliaw/ray/branches{/branch}","tags_url":"https://api.github.com/repos/richardliaw/ray/tags","blobs_url":"https://api.github.com/repos/richardliaw/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richardliaw/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richardliaw/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/richardliaw/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richardliaw/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/richardliaw/ray/languages","stargazers_url":"https://api.github.com/repos/richardliaw/ray/stargazers","contributors_url":"https://api.github.com/repos/richardliaw/ray/contributors","subscribers_url":"https://api.github.com/repos/richardliaw/ray/subscribers","subscription_url":"https://api.github.com/repos/richardliaw/ray/subscription","commits_url":"https://api.github.com/repos/richardliaw/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/richardliaw/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/richardliaw/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/richardliaw/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/richardliaw/ray/contents/{+path}","compare_url":"https://api.github.com/repos/richardliaw/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richardliaw/ray/merges","archive_url":"https://api.github.com/repos/richardliaw/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richardliaw/ray/downloads","issues_url":"https://api.github.com/repos/richardliaw/ray/issues{/number}","pulls_url":"https://api.github.com/repos/richardliaw/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/richardliaw/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/richardliaw/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richardliaw/ray/labels{/name}","releases_url":"https://api.github.com/repos/richardliaw/ray/releases{/id}","deployments_url":"https://api.github.com/repos/richardliaw/ray/deployments","created_at":"2017-01-19T02:34:33Z","updated_at":"2018-12-04T22:51:10Z","pushed_at":"2018-12-07T00:54:23Z","git_url":"git://github.com/richardliaw/ray.git","ssh_url":"git@github.com:richardliaw/ray.git","clone_url":"https://github.com/richardliaw/ray.git","svn_url":"https://github.com/richardliaw/ray","homepage":"","size":25869,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"ce355d13d4b50481ba1a86b63555fef204e25f9f","user":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"node_id":"MDEwOlJlcG9zaXRvcnk3MTkzMjM0OQ==","name":"ray","full_name":"ray-project/ray","private":false,"owner":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ray-project/ray","description":"A system for parallel and distributed Python that unifies the ML ecosystem.","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2018-12-07T02:01:20Z","pushed_at":"2018-12-07T02:01:12Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"git@github.com:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"https://ray.readthedocs.io/en/latest/","size":17055,"stargazers_count":4941,"watchers_count":4941,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":668,"mirror_url":null,"archived":false,"open_issues_count":483,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":668,"open_issues":483,"watchers":4941,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/3465"},"html":{"href":"https://github.com/ray-project/ray/pull/3465"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/3465"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/3465/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/3465/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/3465/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/1a10482ff611aaff3329cd68dfe9106dc35da058"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"richardliaw"}}