{"action":"created","comment":{"url":"https://api.github.com/repos/pkp/pkp-lib/pulls/comments/176306504","pull_request_review_id":105984807,"id":176306504,"diff_hunk":"@@ -35,9 +48,47 @@ function getTemplateVarsFromRowColumn($row, $column) {\n \t\t\tcase 'date':\n \t\t\t\treturn array('label' => is_a($element, 'EventLogEntry') ? $element->getDateLogged() : $element->getDateSent());\n \t\t\tcase 'event':\n-\t\t\t\treturn array('label' => is_a($element, 'EventLogEntry') ? $element->getTranslatedMessage() : $element->getPrefixedSubject());\n+\t\t\t\treturn array('label' => is_a($element, 'EventLogEntry') ? $element->getTranslatedMessage(null, $this->_isCurrentUserAssignedAuthor) : $element->getPrefixedSubject());\n \t\t\tcase 'user':\n-\t\t\t\treturn array('label' => is_a($element, 'EventLogEntry') ? $element->getUserFullName() : $element->getSenderFullName());\n+\t\t\t\tif (is_a($element, 'EventLogEntry')) {\n+\t\t\t\t\t$userName = $element->getUserFullName();\n+\t\t\t\t\t$reviewAssignmentDao = DAORegistry::getDAO('ReviewAssignmentDAO');\n+\n+\t\t\t\t\t// Maybe anonymize reviewer log entries\n+\t\t\t\t\t$reviewerLogTypes = array(\n+\t\t\t\t\t\tSUBMISSION_LOG_REVIEW_ACCEPT,\n+\t\t\t\t\t\tSUBMISSION_LOG_REVIEW_DECLINE,\n+\t\t\t\t\t\tSUBMISSION_LOG_REVIEW_UNCONSIDERED,\n+\t\t\t\t\t\tSUBMISSION_LOG_REVIEW_FILE,\n+\t\t\t\t\t\tSUBMISSION_LOG_REVIEW_CANCEL,\n+\t\t\t\t\t\tSUBMISSION_LOG_REVIEW_REVISION,\n+\t\t\t\t\t\tSUBMISSION_LOG_REVIEW_RECOMMENDATION,\n+\t\t\t\t\t);\n+\t\t\t\t\t$params = $element->getParams();\n+\t\t\t\t\tif (in_array($element->getEventType(), $reviewerLogTypes) && isset($params['reviewAssignmentId'])) {","path":"controllers/grid/eventLog/EventLogGridCellProvider.inc.php","position":43,"original_position":43,"commit_id":"4ed012aa0b3ca51cc0857f0e4f24cc686538f2ed","original_commit_id":"4ed012aa0b3ca51cc0857f0e4f24cc686538f2ed","user":{"login":"asmecher","id":200411,"avatar_url":"https://avatars0.githubusercontent.com/u/200411?v=4","gravatar_id":"","url":"https://api.github.com/users/asmecher","html_url":"https://github.com/asmecher","followers_url":"https://api.github.com/users/asmecher/followers","following_url":"https://api.github.com/users/asmecher/following{/other_user}","gists_url":"https://api.github.com/users/asmecher/gists{/gist_id}","starred_url":"https://api.github.com/users/asmecher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmecher/subscriptions","organizations_url":"https://api.github.com/users/asmecher/orgs","repos_url":"https://api.github.com/users/asmecher/repos","events_url":"https://api.github.com/users/asmecher/events{/privacy}","received_events_url":"https://api.github.com/users/asmecher/received_events","type":"User","site_admin":false},"body":"What about existing log entries that don't have `reviewAssignmentId` available to them?","created_at":"2018-03-22T04:36:20Z","updated_at":"2018-03-22T04:36:20Z","html_url":"https://github.com/pkp/pkp-lib/pull/3499#discussion_r176306504","pull_request_url":"https://api.github.com/repos/pkp/pkp-lib/pulls/3499","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/pkp/pkp-lib/pulls/comments/176306504"},"html":{"href":"https://github.com/pkp/pkp-lib/pull/3499#discussion_r176306504"},"pull_request":{"href":"https://api.github.com/repos/pkp/pkp-lib/pulls/3499"}}},"pull_request":{"url":"https://api.github.com/repos/pkp/pkp-lib/pulls/3499","id":176219053,"html_url":"https://github.com/pkp/pkp-lib/pull/3499","diff_url":"https://github.com/pkp/pkp-lib/pull/3499.diff","patch_url":"https://github.com/pkp/pkp-lib/pull/3499.patch","issue_url":"https://api.github.com/repos/pkp/pkp-lib/issues/3499","number":3499,"state":"open","locked":false,"title":"pkp/pkp-lib#3130 Improve access control for dual-assignments","user":{"login":"NateWr","id":2306629,"avatar_url":"https://avatars2.githubusercontent.com/u/2306629?v=4","gravatar_id":"","url":"https://api.github.com/users/NateWr","html_url":"https://github.com/NateWr","followers_url":"https://api.github.com/users/NateWr/followers","following_url":"https://api.github.com/users/NateWr/following{/other_user}","gists_url":"https://api.github.com/users/NateWr/gists{/gist_id}","starred_url":"https://api.github.com/users/NateWr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NateWr/subscriptions","organizations_url":"https://api.github.com/users/NateWr/orgs","repos_url":"https://api.github.com/users/NateWr/repos","events_url":"https://api.github.com/users/NateWr/events{/privacy}","received_events_url":"https://api.github.com/users/NateWr/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-20T14:59:22Z","updated_at":"2018-03-22T04:36:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb55d7509e3665193d0d44661aae0c5d8ff5e54f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pkp/pkp-lib/pulls/3499/commits","review_comments_url":"https://api.github.com/repos/pkp/pkp-lib/pulls/3499/comments","review_comment_url":"https://api.github.com/repos/pkp/pkp-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pkp/pkp-lib/issues/3499/comments","statuses_url":"https://api.github.com/repos/pkp/pkp-lib/statuses/4ed012aa0b3ca51cc0857f0e4f24cc686538f2ed","head":{"label":"NateWr:i3130_access_2","ref":"i3130_access_2","sha":"4ed012aa0b3ca51cc0857f0e4f24cc686538f2ed","user":{"login":"NateWr","id":2306629,"avatar_url":"https://avatars2.githubusercontent.com/u/2306629?v=4","gravatar_id":"","url":"https://api.github.com/users/NateWr","html_url":"https://github.com/NateWr","followers_url":"https://api.github.com/users/NateWr/followers","following_url":"https://api.github.com/users/NateWr/following{/other_user}","gists_url":"https://api.github.com/users/NateWr/gists{/gist_id}","starred_url":"https://api.github.com/users/NateWr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NateWr/subscriptions","organizations_url":"https://api.github.com/users/NateWr/orgs","repos_url":"https://api.github.com/users/NateWr/repos","events_url":"https://api.github.com/users/NateWr/events{/privacy}","received_events_url":"https://api.github.com/users/NateWr/received_events","type":"User","site_admin":false},"repo":{"id":78215108,"name":"pkp-lib","full_name":"NateWr/pkp-lib","owner":{"login":"NateWr","id":2306629,"avatar_url":"https://avatars2.githubusercontent.com/u/2306629?v=4","gravatar_id":"","url":"https://api.github.com/users/NateWr","html_url":"https://github.com/NateWr","followers_url":"https://api.github.com/users/NateWr/followers","following_url":"https://api.github.com/users/NateWr/following{/other_user}","gists_url":"https://api.github.com/users/NateWr/gists{/gist_id}","starred_url":"https://api.github.com/users/NateWr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NateWr/subscriptions","organizations_url":"https://api.github.com/users/NateWr/orgs","repos_url":"https://api.github.com/users/NateWr/repos","events_url":"https://api.github.com/users/NateWr/events{/privacy}","received_events_url":"https://api.github.com/users/NateWr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NateWr/pkp-lib","description":"PKP Web Application Library","fork":true,"url":"https://api.github.com/repos/NateWr/pkp-lib","forks_url":"https://api.github.com/repos/NateWr/pkp-lib/forks","keys_url":"https://api.github.com/repos/NateWr/pkp-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NateWr/pkp-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NateWr/pkp-lib/teams","hooks_url":"https://api.github.com/repos/NateWr/pkp-lib/hooks","issue_events_url":"https://api.github.com/repos/NateWr/pkp-lib/issues/events{/number}","events_url":"https://api.github.com/repos/NateWr/pkp-lib/events","assignees_url":"https://api.github.com/repos/NateWr/pkp-lib/assignees{/user}","branches_url":"https://api.github.com/repos/NateWr/pkp-lib/branches{/branch}","tags_url":"https://api.github.com/repos/NateWr/pkp-lib/tags","blobs_url":"https://api.github.com/repos/NateWr/pkp-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NateWr/pkp-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NateWr/pkp-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/NateWr/pkp-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NateWr/pkp-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/NateWr/pkp-lib/languages","stargazers_url":"https://api.github.com/repos/NateWr/pkp-lib/stargazers","contributors_url":"https://api.github.com/repos/NateWr/pkp-lib/contributors","subscribers_url":"https://api.github.com/repos/NateWr/pkp-lib/subscribers","subscription_url":"https://api.github.com/repos/NateWr/pkp-lib/subscription","commits_url":"https://api.github.com/repos/NateWr/pkp-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/NateWr/pkp-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/NateWr/pkp-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/NateWr/pkp-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/NateWr/pkp-lib/contents/{+path}","compare_url":"https://api.github.com/repos/NateWr/pkp-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NateWr/pkp-lib/merges","archive_url":"https://api.github.com/repos/NateWr/pkp-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NateWr/pkp-lib/downloads","issues_url":"https://api.github.com/repos/NateWr/pkp-lib/issues{/number}","pulls_url":"https://api.github.com/repos/NateWr/pkp-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/NateWr/pkp-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/NateWr/pkp-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NateWr/pkp-lib/labels{/name}","releases_url":"https://api.github.com/repos/NateWr/pkp-lib/releases{/id}","deployments_url":"https://api.github.com/repos/NateWr/pkp-lib/deployments","created_at":"2017-01-06T15:10:16Z","updated_at":"2018-03-20T16:03:58Z","pushed_at":"2018-03-21T10:31:13Z","git_url":"git://github.com/NateWr/pkp-lib.git","ssh_url":"git@github.com:NateWr/pkp-lib.git","clone_url":"https://github.com/NateWr/pkp-lib.git","svn_url":"https://github.com/NateWr/pkp-lib","homepage":"http://pkp.sfu.ca","size":64639,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pkp:master","ref":"master","sha":"c3c0f12c509cde392334e1ec8ca555dace5b013b","user":{"login":"pkp","id":130896,"avatar_url":"https://avatars3.githubusercontent.com/u/130896?v=4","gravatar_id":"","url":"https://api.github.com/users/pkp","html_url":"https://github.com/pkp","followers_url":"https://api.github.com/users/pkp/followers","following_url":"https://api.github.com/users/pkp/following{/other_user}","gists_url":"https://api.github.com/users/pkp/gists{/gist_id}","starred_url":"https://api.github.com/users/pkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkp/subscriptions","organizations_url":"https://api.github.com/users/pkp/orgs","repos_url":"https://api.github.com/users/pkp/repos","events_url":"https://api.github.com/users/pkp/events{/privacy}","received_events_url":"https://api.github.com/users/pkp/received_events","type":"Organization","site_admin":false},"repo":{"id":316712,"name":"pkp-lib","full_name":"pkp/pkp-lib","owner":{"login":"pkp","id":130896,"avatar_url":"https://avatars3.githubusercontent.com/u/130896?v=4","gravatar_id":"","url":"https://api.github.com/users/pkp","html_url":"https://github.com/pkp","followers_url":"https://api.github.com/users/pkp/followers","following_url":"https://api.github.com/users/pkp/following{/other_user}","gists_url":"https://api.github.com/users/pkp/gists{/gist_id}","starred_url":"https://api.github.com/users/pkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkp/subscriptions","organizations_url":"https://api.github.com/users/pkp/orgs","repos_url":"https://api.github.com/users/pkp/repos","events_url":"https://api.github.com/users/pkp/events{/privacy}","received_events_url":"https://api.github.com/users/pkp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pkp/pkp-lib","description":"PKP Web Application Library","fork":false,"url":"https://api.github.com/repos/pkp/pkp-lib","forks_url":"https://api.github.com/repos/pkp/pkp-lib/forks","keys_url":"https://api.github.com/repos/pkp/pkp-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkp/pkp-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkp/pkp-lib/teams","hooks_url":"https://api.github.com/repos/pkp/pkp-lib/hooks","issue_events_url":"https://api.github.com/repos/pkp/pkp-lib/issues/events{/number}","events_url":"https://api.github.com/repos/pkp/pkp-lib/events","assignees_url":"https://api.github.com/repos/pkp/pkp-lib/assignees{/user}","branches_url":"https://api.github.com/repos/pkp/pkp-lib/branches{/branch}","tags_url":"https://api.github.com/repos/pkp/pkp-lib/tags","blobs_url":"https://api.github.com/repos/pkp/pkp-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkp/pkp-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkp/pkp-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkp/pkp-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkp/pkp-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/pkp/pkp-lib/languages","stargazers_url":"https://api.github.com/repos/pkp/pkp-lib/stargazers","contributors_url":"https://api.github.com/repos/pkp/pkp-lib/contributors","subscribers_url":"https://api.github.com/repos/pkp/pkp-lib/subscribers","subscription_url":"https://api.github.com/repos/pkp/pkp-lib/subscription","commits_url":"https://api.github.com/repos/pkp/pkp-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkp/pkp-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkp/pkp-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkp/pkp-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkp/pkp-lib/contents/{+path}","compare_url":"https://api.github.com/repos/pkp/pkp-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkp/pkp-lib/merges","archive_url":"https://api.github.com/repos/pkp/pkp-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkp/pkp-lib/downloads","issues_url":"https://api.github.com/repos/pkp/pkp-lib/issues{/number}","pulls_url":"https://api.github.com/repos/pkp/pkp-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/pkp/pkp-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/pkp/pkp-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkp/pkp-lib/labels{/name}","releases_url":"https://api.github.com/repos/pkp/pkp-lib/releases{/id}","deployments_url":"https://api.github.com/repos/pkp/pkp-lib/deployments","created_at":"2009-09-24T19:30:31Z","updated_at":"2018-03-20T22:06:50Z","pushed_at":"2018-03-21T19:21:00Z","git_url":"git://github.com/pkp/pkp-lib.git","ssh_url":"git@github.com:pkp/pkp-lib.git","clone_url":"https://github.com/pkp/pkp-lib.git","svn_url":"https://github.com/pkp/pkp-lib","homepage":"http://pkp.sfu.ca","size":66260,"stargazers_count":113,"watchers_count":113,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":267,"mirror_url":null,"archived":false,"open_issues_count":482,"license":null,"forks":267,"open_issues":482,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pkp/pkp-lib/pulls/3499"},"html":{"href":"https://github.com/pkp/pkp-lib/pull/3499"},"issue":{"href":"https://api.github.com/repos/pkp/pkp-lib/issues/3499"},"comments":{"href":"https://api.github.com/repos/pkp/pkp-lib/issues/3499/comments"},"review_comments":{"href":"https://api.github.com/repos/pkp/pkp-lib/pulls/3499/comments"},"review_comment":{"href":"https://api.github.com/repos/pkp/pkp-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pkp/pkp-lib/pulls/3499/commits"},"statuses":{"href":"https://api.github.com/repos/pkp/pkp-lib/statuses/4ed012aa0b3ca51cc0857f0e4f24cc686538f2ed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"asmecher"}}