{"action":"created","comment":{"url":"https://api.github.com/repos/elfi-dev/elfi/pulls/comments/209549433","pull_request_review_id":145580893,"id":209549433,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTU0OTQzMw==","diff_hunk":"@@ -203,6 +205,59 @@ def sample_means_array(self):\n         \"\"\"\n         return np.array(list(self.sample_means.values()))\n \n+    def save(self, fname=None, kind='csv'):\n+        \"\"\"Save samples in csv, json or pickle file formats.\n+\n+        Parameters\n+        ----------\n+        fname : str, required\n+            File name to be saved\n+        kind : str, optional\n+            File format to be saved. Default format is csv","path":"elfi/methods/results.py","position":21,"original_position":21,"commit_id":"9d673e9b33a704496903db97cd19a8786b4ad49a","original_commit_id":"9d673e9b33a704496903db97cd19a8786b4ad49a","user":{"login":"vuolleko","id":1233418,"node_id":"MDQ6VXNlcjEyMzM0MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1233418?v=4","gravatar_id":"","url":"https://api.github.com/users/vuolleko","html_url":"https://github.com/vuolleko","followers_url":"https://api.github.com/users/vuolleko/followers","following_url":"https://api.github.com/users/vuolleko/following{/other_user}","gists_url":"https://api.github.com/users/vuolleko/gists{/gist_id}","starred_url":"https://api.github.com/users/vuolleko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuolleko/subscriptions","organizations_url":"https://api.github.com/users/vuolleko/orgs","repos_url":"https://api.github.com/users/vuolleko/repos","events_url":"https://api.github.com/users/vuolleko/events{/privacy}","received_events_url":"https://api.github.com/users/vuolleko/received_events","type":"User","site_admin":false},"body":"Good to list exact supported strings here.\r\n\r\nConsider inferring kind from fname?","created_at":"2018-08-13T09:47:45Z","updated_at":"2018-08-13T09:49:34Z","html_url":"https://github.com/elfi-dev/elfi/pull/282#discussion_r209549433","pull_request_url":"https://api.github.com/repos/elfi-dev/elfi/pulls/282","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elfi-dev/elfi/pulls/comments/209549433"},"html":{"href":"https://github.com/elfi-dev/elfi/pull/282#discussion_r209549433"},"pull_request":{"href":"https://api.github.com/repos/elfi-dev/elfi/pulls/282"}}},"pull_request":{"url":"https://api.github.com/repos/elfi-dev/elfi/pulls/282","id":203764527,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNzY0NTI3","html_url":"https://github.com/elfi-dev/elfi/pull/282","diff_url":"https://github.com/elfi-dev/elfi/pull/282.diff","patch_url":"https://github.com/elfi-dev/elfi/pull/282.patch","issue_url":"https://api.github.com/repos/elfi-dev/elfi/issues/282","number":282,"state":"open","locked":false,"title":"Save samples for inference methods","user":{"login":"b5y","id":1110987,"node_id":"MDQ6VXNlcjExMTA5ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1110987?v=4","gravatar_id":"","url":"https://api.github.com/users/b5y","html_url":"https://github.com/b5y","followers_url":"https://api.github.com/users/b5y/followers","following_url":"https://api.github.com/users/b5y/following{/other_user}","gists_url":"https://api.github.com/users/b5y/gists{/gist_id}","starred_url":"https://api.github.com/users/b5y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b5y/subscriptions","organizations_url":"https://api.github.com/users/b5y/orgs","repos_url":"https://api.github.com/users/b5y/repos","events_url":"https://api.github.com/users/b5y/events{/privacy}","received_events_url":"https://api.github.com/users/b5y/received_events","type":"User","site_admin":false},"body":"#### Summary:\r\nAdding ability to save samples for inference methods (csv and json supported)\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/elfi-dev/elfi/282)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-07-25T08:49:46Z","updated_at":"2018-08-13T09:49:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"127efe1bdceb52e6e6b415ec0d4eedb1a9a7249c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elfi-dev/elfi/pulls/282/commits","review_comments_url":"https://api.github.com/repos/elfi-dev/elfi/pulls/282/comments","review_comment_url":"https://api.github.com/repos/elfi-dev/elfi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elfi-dev/elfi/issues/282/comments","statuses_url":"https://api.github.com/repos/elfi-dev/elfi/statuses/9d673e9b33a704496903db97cd19a8786b4ad49a","head":{"label":"elfi-dev:save_samples","ref":"save_samples","sha":"9d673e9b33a704496903db97cd19a8786b4ad49a","user":{"login":"elfi-dev","id":24249379,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MjQ5Mzc5","avatar_url":"https://avatars3.githubusercontent.com/u/24249379?v=4","gravatar_id":"","url":"https://api.github.com/users/elfi-dev","html_url":"https://github.com/elfi-dev","followers_url":"https://api.github.com/users/elfi-dev/followers","following_url":"https://api.github.com/users/elfi-dev/following{/other_user}","gists_url":"https://api.github.com/users/elfi-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/elfi-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfi-dev/subscriptions","organizations_url":"https://api.github.com/users/elfi-dev/orgs","repos_url":"https://api.github.com/users/elfi-dev/repos","events_url":"https://api.github.com/users/elfi-dev/events{/privacy}","received_events_url":"https://api.github.com/users/elfi-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":69855441,"node_id":"MDEwOlJlcG9zaXRvcnk2OTg1NTQ0MQ==","name":"elfi","full_name":"elfi-dev/elfi","owner":{"login":"elfi-dev","id":24249379,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MjQ5Mzc5","avatar_url":"https://avatars3.githubusercontent.com/u/24249379?v=4","gravatar_id":"","url":"https://api.github.com/users/elfi-dev","html_url":"https://github.com/elfi-dev","followers_url":"https://api.github.com/users/elfi-dev/followers","following_url":"https://api.github.com/users/elfi-dev/following{/other_user}","gists_url":"https://api.github.com/users/elfi-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/elfi-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfi-dev/subscriptions","organizations_url":"https://api.github.com/users/elfi-dev/orgs","repos_url":"https://api.github.com/users/elfi-dev/repos","events_url":"https://api.github.com/users/elfi-dev/events{/privacy}","received_events_url":"https://api.github.com/users/elfi-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elfi-dev/elfi","description":"ELFI - Engine for Likelihood-Free Inference","fork":false,"url":"https://api.github.com/repos/elfi-dev/elfi","forks_url":"https://api.github.com/repos/elfi-dev/elfi/forks","keys_url":"https://api.github.com/repos/elfi-dev/elfi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elfi-dev/elfi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elfi-dev/elfi/teams","hooks_url":"https://api.github.com/repos/elfi-dev/elfi/hooks","issue_events_url":"https://api.github.com/repos/elfi-dev/elfi/issues/events{/number}","events_url":"https://api.github.com/repos/elfi-dev/elfi/events","assignees_url":"https://api.github.com/repos/elfi-dev/elfi/assignees{/user}","branches_url":"https://api.github.com/repos/elfi-dev/elfi/branches{/branch}","tags_url":"https://api.github.com/repos/elfi-dev/elfi/tags","blobs_url":"https://api.github.com/repos/elfi-dev/elfi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elfi-dev/elfi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elfi-dev/elfi/git/refs{/sha}","trees_url":"https://api.github.com/repos/elfi-dev/elfi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elfi-dev/elfi/statuses/{sha}","languages_url":"https://api.github.com/repos/elfi-dev/elfi/languages","stargazers_url":"https://api.github.com/repos/elfi-dev/elfi/stargazers","contributors_url":"https://api.github.com/repos/elfi-dev/elfi/contributors","subscribers_url":"https://api.github.com/repos/elfi-dev/elfi/subscribers","subscription_url":"https://api.github.com/repos/elfi-dev/elfi/subscription","commits_url":"https://api.github.com/repos/elfi-dev/elfi/commits{/sha}","git_commits_url":"https://api.github.com/repos/elfi-dev/elfi/git/commits{/sha}","comments_url":"https://api.github.com/repos/elfi-dev/elfi/comments{/number}","issue_comment_url":"https://api.github.com/repos/elfi-dev/elfi/issues/comments{/number}","contents_url":"https://api.github.com/repos/elfi-dev/elfi/contents/{+path}","compare_url":"https://api.github.com/repos/elfi-dev/elfi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elfi-dev/elfi/merges","archive_url":"https://api.github.com/repos/elfi-dev/elfi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elfi-dev/elfi/downloads","issues_url":"https://api.github.com/repos/elfi-dev/elfi/issues{/number}","pulls_url":"https://api.github.com/repos/elfi-dev/elfi/pulls{/number}","milestones_url":"https://api.github.com/repos/elfi-dev/elfi/milestones{/number}","notifications_url":"https://api.github.com/repos/elfi-dev/elfi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elfi-dev/elfi/labels{/name}","releases_url":"https://api.github.com/repos/elfi-dev/elfi/releases{/id}","deployments_url":"https://api.github.com/repos/elfi-dev/elfi/deployments","created_at":"2016-10-03T09:03:38Z","updated_at":"2018-08-09T09:35:11Z","pushed_at":"2018-08-10T20:43:05Z","git_url":"git://github.com/elfi-dev/elfi.git","ssh_url":"git@github.com:elfi-dev/elfi.git","clone_url":"https://github.com/elfi-dev/elfi.git","svn_url":"https://github.com/elfi-dev/elfi","homepage":"http://elfi.readthedocs.io","size":1280,"stargazers_count":127,"watchers_count":127,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":31,"open_issues":11,"watchers":127,"default_branch":"dev"}},"base":{"label":"elfi-dev:dev","ref":"dev","sha":"d7fe2d23d889469eef5765a0d2ba02027a18e22c","user":{"login":"elfi-dev","id":24249379,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MjQ5Mzc5","avatar_url":"https://avatars3.githubusercontent.com/u/24249379?v=4","gravatar_id":"","url":"https://api.github.com/users/elfi-dev","html_url":"https://github.com/elfi-dev","followers_url":"https://api.github.com/users/elfi-dev/followers","following_url":"https://api.github.com/users/elfi-dev/following{/other_user}","gists_url":"https://api.github.com/users/elfi-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/elfi-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfi-dev/subscriptions","organizations_url":"https://api.github.com/users/elfi-dev/orgs","repos_url":"https://api.github.com/users/elfi-dev/repos","events_url":"https://api.github.com/users/elfi-dev/events{/privacy}","received_events_url":"https://api.github.com/users/elfi-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":69855441,"node_id":"MDEwOlJlcG9zaXRvcnk2OTg1NTQ0MQ==","name":"elfi","full_name":"elfi-dev/elfi","owner":{"login":"elfi-dev","id":24249379,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MjQ5Mzc5","avatar_url":"https://avatars3.githubusercontent.com/u/24249379?v=4","gravatar_id":"","url":"https://api.github.com/users/elfi-dev","html_url":"https://github.com/elfi-dev","followers_url":"https://api.github.com/users/elfi-dev/followers","following_url":"https://api.github.com/users/elfi-dev/following{/other_user}","gists_url":"https://api.github.com/users/elfi-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/elfi-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfi-dev/subscriptions","organizations_url":"https://api.github.com/users/elfi-dev/orgs","repos_url":"https://api.github.com/users/elfi-dev/repos","events_url":"https://api.github.com/users/elfi-dev/events{/privacy}","received_events_url":"https://api.github.com/users/elfi-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elfi-dev/elfi","description":"ELFI - Engine for Likelihood-Free Inference","fork":false,"url":"https://api.github.com/repos/elfi-dev/elfi","forks_url":"https://api.github.com/repos/elfi-dev/elfi/forks","keys_url":"https://api.github.com/repos/elfi-dev/elfi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elfi-dev/elfi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elfi-dev/elfi/teams","hooks_url":"https://api.github.com/repos/elfi-dev/elfi/hooks","issue_events_url":"https://api.github.com/repos/elfi-dev/elfi/issues/events{/number}","events_url":"https://api.github.com/repos/elfi-dev/elfi/events","assignees_url":"https://api.github.com/repos/elfi-dev/elfi/assignees{/user}","branches_url":"https://api.github.com/repos/elfi-dev/elfi/branches{/branch}","tags_url":"https://api.github.com/repos/elfi-dev/elfi/tags","blobs_url":"https://api.github.com/repos/elfi-dev/elfi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elfi-dev/elfi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elfi-dev/elfi/git/refs{/sha}","trees_url":"https://api.github.com/repos/elfi-dev/elfi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elfi-dev/elfi/statuses/{sha}","languages_url":"https://api.github.com/repos/elfi-dev/elfi/languages","stargazers_url":"https://api.github.com/repos/elfi-dev/elfi/stargazers","contributors_url":"https://api.github.com/repos/elfi-dev/elfi/contributors","subscribers_url":"https://api.github.com/repos/elfi-dev/elfi/subscribers","subscription_url":"https://api.github.com/repos/elfi-dev/elfi/subscription","commits_url":"https://api.github.com/repos/elfi-dev/elfi/commits{/sha}","git_commits_url":"https://api.github.com/repos/elfi-dev/elfi/git/commits{/sha}","comments_url":"https://api.github.com/repos/elfi-dev/elfi/comments{/number}","issue_comment_url":"https://api.github.com/repos/elfi-dev/elfi/issues/comments{/number}","contents_url":"https://api.github.com/repos/elfi-dev/elfi/contents/{+path}","compare_url":"https://api.github.com/repos/elfi-dev/elfi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elfi-dev/elfi/merges","archive_url":"https://api.github.com/repos/elfi-dev/elfi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elfi-dev/elfi/downloads","issues_url":"https://api.github.com/repos/elfi-dev/elfi/issues{/number}","pulls_url":"https://api.github.com/repos/elfi-dev/elfi/pulls{/number}","milestones_url":"https://api.github.com/repos/elfi-dev/elfi/milestones{/number}","notifications_url":"https://api.github.com/repos/elfi-dev/elfi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elfi-dev/elfi/labels{/name}","releases_url":"https://api.github.com/repos/elfi-dev/elfi/releases{/id}","deployments_url":"https://api.github.com/repos/elfi-dev/elfi/deployments","created_at":"2016-10-03T09:03:38Z","updated_at":"2018-08-09T09:35:11Z","pushed_at":"2018-08-10T20:43:05Z","git_url":"git://github.com/elfi-dev/elfi.git","ssh_url":"git@github.com:elfi-dev/elfi.git","clone_url":"https://github.com/elfi-dev/elfi.git","svn_url":"https://github.com/elfi-dev/elfi","homepage":"http://elfi.readthedocs.io","size":1280,"stargazers_count":127,"watchers_count":127,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":31,"open_issues":11,"watchers":127,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/elfi-dev/elfi/pulls/282"},"html":{"href":"https://github.com/elfi-dev/elfi/pull/282"},"issue":{"href":"https://api.github.com/repos/elfi-dev/elfi/issues/282"},"comments":{"href":"https://api.github.com/repos/elfi-dev/elfi/issues/282/comments"},"review_comments":{"href":"https://api.github.com/repos/elfi-dev/elfi/pulls/282/comments"},"review_comment":{"href":"https://api.github.com/repos/elfi-dev/elfi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elfi-dev/elfi/pulls/282/commits"},"statuses":{"href":"https://api.github.com/repos/elfi-dev/elfi/statuses/9d673e9b33a704496903db97cd19a8786b4ad49a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vuolleko"}}