{"action":"created","comment":{"url":"https://api.github.com/repos/willowtreeapps/ukor/pulls/comments/218467929","pull_request_review_id":156412948,"id":218467929,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODQ2NzkyOQ==","diff_hunk":"@@ -0,0 +1,27 @@\n+const log = require('./log')\n+const wistLogger = require('./wist-logger')\n+const CLIEngine = require('@willowtreeapps/wist').CLIEngine\n+\n+function run(sourceFiles, ignoreErrors) {","path":"lib/utils/linter.js","position":5,"original_position":5,"commit_id":"42669e74524c363615acc06028c01aecd0e30e21","original_commit_id":"42669e74524c363615acc06028c01aecd0e30e21","user":{"login":"nishtahir","id":2018617,"node_id":"MDQ6VXNlcjIwMTg2MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2018617?v=4","gravatar_id":"","url":"https://api.github.com/users/nishtahir","html_url":"https://github.com/nishtahir","followers_url":"https://api.github.com/users/nishtahir/followers","following_url":"https://api.github.com/users/nishtahir/following{/other_user}","gists_url":"https://api.github.com/users/nishtahir/gists{/gist_id}","starred_url":"https://api.github.com/users/nishtahir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nishtahir/subscriptions","organizations_url":"https://api.github.com/users/nishtahir/orgs","repos_url":"https://api.github.com/users/nishtahir/repos","events_url":"https://api.github.com/users/nishtahir/events{/privacy}","received_events_url":"https://api.github.com/users/nishtahir/received_events","type":"User","site_admin":false},"body":"This is a neat first step. I think the way forward from here would be to come up with a way to parallelize the linting process.","created_at":"2018-09-18T14:57:29Z","updated_at":"2018-09-18T14:57:29Z","html_url":"https://github.com/willowtreeapps/ukor/pull/48#discussion_r218467929","pull_request_url":"https://api.github.com/repos/willowtreeapps/ukor/pulls/48","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/willowtreeapps/ukor/pulls/comments/218467929"},"html":{"href":"https://github.com/willowtreeapps/ukor/pull/48#discussion_r218467929"},"pull_request":{"href":"https://api.github.com/repos/willowtreeapps/ukor/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/willowtreeapps/ukor/pulls/48","id":216277642,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2Mjc3NjQy","html_url":"https://github.com/willowtreeapps/ukor/pull/48","diff_url":"https://github.com/willowtreeapps/ukor/pull/48.diff","patch_url":"https://github.com/willowtreeapps/ukor/pull/48.patch","issue_url":"https://api.github.com/repos/willowtreeapps/ukor/issues/48","number":48,"state":"open","locked":false,"title":"Separate linting from build/install process","user":{"login":"cazacutudor","id":16267898,"node_id":"MDQ6VXNlcjE2MjY3ODk4","avatar_url":"https://avatars0.githubusercontent.com/u/16267898?v=4","gravatar_id":"","url":"https://api.github.com/users/cazacutudor","html_url":"https://github.com/cazacutudor","followers_url":"https://api.github.com/users/cazacutudor/followers","following_url":"https://api.github.com/users/cazacutudor/following{/other_user}","gists_url":"https://api.github.com/users/cazacutudor/gists{/gist_id}","starred_url":"https://api.github.com/users/cazacutudor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cazacutudor/subscriptions","organizations_url":"https://api.github.com/users/cazacutudor/orgs","repos_url":"https://api.github.com/users/cazacutudor/repos","events_url":"https://api.github.com/users/cazacutudor/events{/privacy}","received_events_url":"https://api.github.com/users/cazacutudor/received_events","type":"User","site_admin":false},"body":"This pull-request will separate linting from build/install process.\r\n\r\nReason - for medium and big roku projects the linting process is very very slow because of the big number of files. So to install or create a build will take too long time. (example: ~30 mins on a project that have 266 brs files)\r\n\r\nAfter this changes you will still be enable to use linting tool (wist) with command:\r\n`ukor lint <flavor>`\r\n\r\nExample:\r\n![image](https://user-images.githubusercontent.com/16267898/45685143-14c4ff80-bb51-11e8-95ce-4946036bcd95.png)\r\n\r\n`~30 mins on a project that have 266 brs files` - was obtained on this configuration:\r\n![image](https://user-images.githubusercontent.com/16267898/45685926-9e75cc80-bb53-11e8-8d5f-a3e9d209dcd2.png)\r\n","created_at":"2018-09-18T11:43:02Z","updated_at":"2018-09-18T14:57:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92b169f5e54ce88ef240cb40f5353eea8ef80a6d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vannuysm","id":760100,"node_id":"MDQ6VXNlcjc2MDEwMA==","avatar_url":"https://avatars0.githubusercontent.com/u/760100?v=4","gravatar_id":"","url":"https://api.github.com/users/vannuysm","html_url":"https://github.com/vannuysm","followers_url":"https://api.github.com/users/vannuysm/followers","following_url":"https://api.github.com/users/vannuysm/following{/other_user}","gists_url":"https://api.github.com/users/vannuysm/gists{/gist_id}","starred_url":"https://api.github.com/users/vannuysm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vannuysm/subscriptions","organizations_url":"https://api.github.com/users/vannuysm/orgs","repos_url":"https://api.github.com/users/vannuysm/repos","events_url":"https://api.github.com/users/vannuysm/events{/privacy}","received_events_url":"https://api.github.com/users/vannuysm/received_events","type":"User","site_admin":false},{"login":"slheavner","id":5651483,"node_id":"MDQ6VXNlcjU2NTE0ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/5651483?v=4","gravatar_id":"","url":"https://api.github.com/users/slheavner","html_url":"https://github.com/slheavner","followers_url":"https://api.github.com/users/slheavner/followers","following_url":"https://api.github.com/users/slheavner/following{/other_user}","gists_url":"https://api.github.com/users/slheavner/gists{/gist_id}","starred_url":"https://api.github.com/users/slheavner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slheavner/subscriptions","organizations_url":"https://api.github.com/users/slheavner/orgs","repos_url":"https://api.github.com/users/slheavner/repos","events_url":"https://api.github.com/users/slheavner/events{/privacy}","received_events_url":"https://api.github.com/users/slheavner/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/willowtreeapps/ukor/pulls/48/commits","review_comments_url":"https://api.github.com/repos/willowtreeapps/ukor/pulls/48/comments","review_comment_url":"https://api.github.com/repos/willowtreeapps/ukor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/willowtreeapps/ukor/issues/48/comments","statuses_url":"https://api.github.com/repos/willowtreeapps/ukor/statuses/42669e74524c363615acc06028c01aecd0e30e21","head":{"label":"cazacutudor:separate-linting","ref":"separate-linting","sha":"42669e74524c363615acc06028c01aecd0e30e21","user":{"login":"cazacutudor","id":16267898,"node_id":"MDQ6VXNlcjE2MjY3ODk4","avatar_url":"https://avatars0.githubusercontent.com/u/16267898?v=4","gravatar_id":"","url":"https://api.github.com/users/cazacutudor","html_url":"https://github.com/cazacutudor","followers_url":"https://api.github.com/users/cazacutudor/followers","following_url":"https://api.github.com/users/cazacutudor/following{/other_user}","gists_url":"https://api.github.com/users/cazacutudor/gists{/gist_id}","starred_url":"https://api.github.com/users/cazacutudor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cazacutudor/subscriptions","organizations_url":"https://api.github.com/users/cazacutudor/orgs","repos_url":"https://api.github.com/users/cazacutudor/repos","events_url":"https://api.github.com/users/cazacutudor/events{/privacy}","received_events_url":"https://api.github.com/users/cazacutudor/received_events","type":"User","site_admin":false},"repo":{"id":148633351,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg2MzMzNTE=","name":"ukor","full_name":"cazacutudor/ukor","private":false,"owner":{"login":"cazacutudor","id":16267898,"node_id":"MDQ6VXNlcjE2MjY3ODk4","avatar_url":"https://avatars0.githubusercontent.com/u/16267898?v=4","gravatar_id":"","url":"https://api.github.com/users/cazacutudor","html_url":"https://github.com/cazacutudor","followers_url":"https://api.github.com/users/cazacutudor/followers","following_url":"https://api.github.com/users/cazacutudor/following{/other_user}","gists_url":"https://api.github.com/users/cazacutudor/gists{/gist_id}","starred_url":"https://api.github.com/users/cazacutudor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cazacutudor/subscriptions","organizations_url":"https://api.github.com/users/cazacutudor/orgs","repos_url":"https://api.github.com/users/cazacutudor/repos","events_url":"https://api.github.com/users/cazacutudor/events{/privacy}","received_events_url":"https://api.github.com/users/cazacutudor/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cazacutudor/ukor","description":"A Roku build tool with support for build flavors","fork":true,"url":"https://api.github.com/repos/cazacutudor/ukor","forks_url":"https://api.github.com/repos/cazacutudor/ukor/forks","keys_url":"https://api.github.com/repos/cazacutudor/ukor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cazacutudor/ukor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cazacutudor/ukor/teams","hooks_url":"https://api.github.com/repos/cazacutudor/ukor/hooks","issue_events_url":"https://api.github.com/repos/cazacutudor/ukor/issues/events{/number}","events_url":"https://api.github.com/repos/cazacutudor/ukor/events","assignees_url":"https://api.github.com/repos/cazacutudor/ukor/assignees{/user}","branches_url":"https://api.github.com/repos/cazacutudor/ukor/branches{/branch}","tags_url":"https://api.github.com/repos/cazacutudor/ukor/tags","blobs_url":"https://api.github.com/repos/cazacutudor/ukor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cazacutudor/ukor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cazacutudor/ukor/git/refs{/sha}","trees_url":"https://api.github.com/repos/cazacutudor/ukor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cazacutudor/ukor/statuses/{sha}","languages_url":"https://api.github.com/repos/cazacutudor/ukor/languages","stargazers_url":"https://api.github.com/repos/cazacutudor/ukor/stargazers","contributors_url":"https://api.github.com/repos/cazacutudor/ukor/contributors","subscribers_url":"https://api.github.com/repos/cazacutudor/ukor/subscribers","subscription_url":"https://api.github.com/repos/cazacutudor/ukor/subscription","commits_url":"https://api.github.com/repos/cazacutudor/ukor/commits{/sha}","git_commits_url":"https://api.github.com/repos/cazacutudor/ukor/git/commits{/sha}","comments_url":"https://api.github.com/repos/cazacutudor/ukor/comments{/number}","issue_comment_url":"https://api.github.com/repos/cazacutudor/ukor/issues/comments{/number}","contents_url":"https://api.github.com/repos/cazacutudor/ukor/contents/{+path}","compare_url":"https://api.github.com/repos/cazacutudor/ukor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cazacutudor/ukor/merges","archive_url":"https://api.github.com/repos/cazacutudor/ukor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cazacutudor/ukor/downloads","issues_url":"https://api.github.com/repos/cazacutudor/ukor/issues{/number}","pulls_url":"https://api.github.com/repos/cazacutudor/ukor/pulls{/number}","milestones_url":"https://api.github.com/repos/cazacutudor/ukor/milestones{/number}","notifications_url":"https://api.github.com/repos/cazacutudor/ukor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cazacutudor/ukor/labels{/name}","releases_url":"https://api.github.com/repos/cazacutudor/ukor/releases{/id}","deployments_url":"https://api.github.com/repos/cazacutudor/ukor/deployments","created_at":"2018-09-13T12:19:59Z","updated_at":"2018-09-18T11:49:43Z","pushed_at":"2018-09-18T11:49:42Z","git_url":"git://github.com/cazacutudor/ukor.git","ssh_url":"git@github.com:cazacutudor/ukor.git","clone_url":"https://github.com/cazacutudor/ukor.git","svn_url":"https://github.com/cazacutudor/ukor","homepage":"","size":340,"stargazers_count":0,"watchers_count":0,"language":"Brightscript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"willowtreeapps:master","ref":"master","sha":"924ad0a5a176c7b2c96c317e5aa0205b1f8eb9a9","user":{"login":"willowtreeapps","id":557680,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NzY4MA==","avatar_url":"https://avatars2.githubusercontent.com/u/557680?v=4","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"repo":{"id":92086226,"node_id":"MDEwOlJlcG9zaXRvcnk5MjA4NjIyNg==","name":"ukor","full_name":"willowtreeapps/ukor","private":false,"owner":{"login":"willowtreeapps","id":557680,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1NzY4MA==","avatar_url":"https://avatars2.githubusercontent.com/u/557680?v=4","gravatar_id":"","url":"https://api.github.com/users/willowtreeapps","html_url":"https://github.com/willowtreeapps","followers_url":"https://api.github.com/users/willowtreeapps/followers","following_url":"https://api.github.com/users/willowtreeapps/following{/other_user}","gists_url":"https://api.github.com/users/willowtreeapps/gists{/gist_id}","starred_url":"https://api.github.com/users/willowtreeapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willowtreeapps/subscriptions","organizations_url":"https://api.github.com/users/willowtreeapps/orgs","repos_url":"https://api.github.com/users/willowtreeapps/repos","events_url":"https://api.github.com/users/willowtreeapps/events{/privacy}","received_events_url":"https://api.github.com/users/willowtreeapps/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/willowtreeapps/ukor","description":"A Roku build tool with support for build flavors","fork":false,"url":"https://api.github.com/repos/willowtreeapps/ukor","forks_url":"https://api.github.com/repos/willowtreeapps/ukor/forks","keys_url":"https://api.github.com/repos/willowtreeapps/ukor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willowtreeapps/ukor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willowtreeapps/ukor/teams","hooks_url":"https://api.github.com/repos/willowtreeapps/ukor/hooks","issue_events_url":"https://api.github.com/repos/willowtreeapps/ukor/issues/events{/number}","events_url":"https://api.github.com/repos/willowtreeapps/ukor/events","assignees_url":"https://api.github.com/repos/willowtreeapps/ukor/assignees{/user}","branches_url":"https://api.github.com/repos/willowtreeapps/ukor/branches{/branch}","tags_url":"https://api.github.com/repos/willowtreeapps/ukor/tags","blobs_url":"https://api.github.com/repos/willowtreeapps/ukor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willowtreeapps/ukor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willowtreeapps/ukor/git/refs{/sha}","trees_url":"https://api.github.com/repos/willowtreeapps/ukor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willowtreeapps/ukor/statuses/{sha}","languages_url":"https://api.github.com/repos/willowtreeapps/ukor/languages","stargazers_url":"https://api.github.com/repos/willowtreeapps/ukor/stargazers","contributors_url":"https://api.github.com/repos/willowtreeapps/ukor/contributors","subscribers_url":"https://api.github.com/repos/willowtreeapps/ukor/subscribers","subscription_url":"https://api.github.com/repos/willowtreeapps/ukor/subscription","commits_url":"https://api.github.com/repos/willowtreeapps/ukor/commits{/sha}","git_commits_url":"https://api.github.com/repos/willowtreeapps/ukor/git/commits{/sha}","comments_url":"https://api.github.com/repos/willowtreeapps/ukor/comments{/number}","issue_comment_url":"https://api.github.com/repos/willowtreeapps/ukor/issues/comments{/number}","contents_url":"https://api.github.com/repos/willowtreeapps/ukor/contents/{+path}","compare_url":"https://api.github.com/repos/willowtreeapps/ukor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willowtreeapps/ukor/merges","archive_url":"https://api.github.com/repos/willowtreeapps/ukor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willowtreeapps/ukor/downloads","issues_url":"https://api.github.com/repos/willowtreeapps/ukor/issues{/number}","pulls_url":"https://api.github.com/repos/willowtreeapps/ukor/pulls{/number}","milestones_url":"https://api.github.com/repos/willowtreeapps/ukor/milestones{/number}","notifications_url":"https://api.github.com/repos/willowtreeapps/ukor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willowtreeapps/ukor/labels{/name}","releases_url":"https://api.github.com/repos/willowtreeapps/ukor/releases{/id}","deployments_url":"https://api.github.com/repos/willowtreeapps/ukor/deployments","created_at":"2017-05-22T18:26:54Z","updated_at":"2018-08-29T01:03:52Z","pushed_at":"2018-09-18T11:43:02Z","git_url":"git://github.com/willowtreeapps/ukor.git","ssh_url":"git@github.com:willowtreeapps/ukor.git","clone_url":"https://github.com/willowtreeapps/ukor.git","svn_url":"https://github.com/willowtreeapps/ukor","homepage":"","size":327,"stargazers_count":17,"watchers_count":17,"language":"Brightscript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":9,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/willowtreeapps/ukor/pulls/48"},"html":{"href":"https://github.com/willowtreeapps/ukor/pull/48"},"issue":{"href":"https://api.github.com/repos/willowtreeapps/ukor/issues/48"},"comments":{"href":"https://api.github.com/repos/willowtreeapps/ukor/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/willowtreeapps/ukor/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/willowtreeapps/ukor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/willowtreeapps/ukor/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/willowtreeapps/ukor/statuses/42669e74524c363615acc06028c01aecd0e30e21"}},"author_association":"NONE"}}
{"actor":{"display_login":"nishtahir"}}