{"action":"closed","number":56,"pull_request":{"url":"https://api.github.com/repos/THETA476/THETA/pulls/56","id":185607019,"html_url":"https://github.com/THETA476/THETA/pull/56","diff_url":"https://github.com/THETA476/THETA/pull/56.diff","patch_url":"https://github.com/THETA476/THETA/pull/56.patch","issue_url":"https://api.github.com/repos/THETA476/THETA/issues/56","number":56,"state":"closed","locked":false,"title":"added simple tests for boundary_conditions","user":{"login":"nuclearkatie","id":8053456,"avatar_url":"https://avatars2.githubusercontent.com/u/8053456?v=4","gravatar_id":"","url":"https://api.github.com/users/nuclearkatie","html_url":"https://github.com/nuclearkatie","followers_url":"https://api.github.com/users/nuclearkatie/followers","following_url":"https://api.github.com/users/nuclearkatie/following{/other_user}","gists_url":"https://api.github.com/users/nuclearkatie/gists{/gist_id}","starred_url":"https://api.github.com/users/nuclearkatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuclearkatie/subscriptions","organizations_url":"https://api.github.com/users/nuclearkatie/orgs","repos_url":"https://api.github.com/users/nuclearkatie/repos","events_url":"https://api.github.com/users/nuclearkatie/events{/privacy}","received_events_url":"https://api.github.com/users/nuclearkatie/received_events","type":"User","site_admin":false},"body":"I tried to make this a part of #53, but my pull request to @rarmstrong3's branch was too slow, @Zach-Fiscus already merged it\r\n\r\nHere was the justification I had about adding these tests:\r\n\r\nadded two very simple tests. They are trivial at this point (checking the output type and basically redoing the whole function), but the idea is that if boundary_conditions ever becomes more complex, these tests would still be relevant and confirm that the function is doing what we want it to do","created_at":"2018-05-03T02:54:17Z","updated_at":"2018-05-03T03:51:26Z","closed_at":"2018-05-03T03:51:26Z","merged_at":"2018-05-03T03:51:26Z","merge_commit_sha":"208a5587c3da71699db4ec1afda51434ae26d531","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/THETA476/THETA/pulls/56/commits","review_comments_url":"https://api.github.com/repos/THETA476/THETA/pulls/56/comments","review_comment_url":"https://api.github.com/repos/THETA476/THETA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/THETA476/THETA/issues/56/comments","statuses_url":"https://api.github.com/repos/THETA476/THETA/statuses/11055573d69b9fa7f2fcdbeb9e00939fb77736aa","head":{"label":"nuclearkatie:temperature_boundary","ref":"temperature_boundary","sha":"11055573d69b9fa7f2fcdbeb9e00939fb77736aa","user":{"login":"nuclearkatie","id":8053456,"avatar_url":"https://avatars2.githubusercontent.com/u/8053456?v=4","gravatar_id":"","url":"https://api.github.com/users/nuclearkatie","html_url":"https://github.com/nuclearkatie","followers_url":"https://api.github.com/users/nuclearkatie/followers","following_url":"https://api.github.com/users/nuclearkatie/following{/other_user}","gists_url":"https://api.github.com/users/nuclearkatie/gists{/gist_id}","starred_url":"https://api.github.com/users/nuclearkatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuclearkatie/subscriptions","organizations_url":"https://api.github.com/users/nuclearkatie/orgs","repos_url":"https://api.github.com/users/nuclearkatie/repos","events_url":"https://api.github.com/users/nuclearkatie/events{/privacy}","received_events_url":"https://api.github.com/users/nuclearkatie/received_events","type":"User","site_admin":false},"repo":{"id":124443120,"name":"THETA","full_name":"nuclearkatie/THETA","owner":{"login":"nuclearkatie","id":8053456,"avatar_url":"https://avatars2.githubusercontent.com/u/8053456?v=4","gravatar_id":"","url":"https://api.github.com/users/nuclearkatie","html_url":"https://github.com/nuclearkatie","followers_url":"https://api.github.com/users/nuclearkatie/followers","following_url":"https://api.github.com/users/nuclearkatie/following{/other_user}","gists_url":"https://api.github.com/users/nuclearkatie/gists{/gist_id}","starred_url":"https://api.github.com/users/nuclearkatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuclearkatie/subscriptions","organizations_url":"https://api.github.com/users/nuclearkatie/orgs","repos_url":"https://api.github.com/users/nuclearkatie/repos","events_url":"https://api.github.com/users/nuclearkatie/events{/privacy}","received_events_url":"https://api.github.com/users/nuclearkatie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nuclearkatie/THETA","description":"Develop a heat transfer kernel ","fork":true,"url":"https://api.github.com/repos/nuclearkatie/THETA","forks_url":"https://api.github.com/repos/nuclearkatie/THETA/forks","keys_url":"https://api.github.com/repos/nuclearkatie/THETA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuclearkatie/THETA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuclearkatie/THETA/teams","hooks_url":"https://api.github.com/repos/nuclearkatie/THETA/hooks","issue_events_url":"https://api.github.com/repos/nuclearkatie/THETA/issues/events{/number}","events_url":"https://api.github.com/repos/nuclearkatie/THETA/events","assignees_url":"https://api.github.com/repos/nuclearkatie/THETA/assignees{/user}","branches_url":"https://api.github.com/repos/nuclearkatie/THETA/branches{/branch}","tags_url":"https://api.github.com/repos/nuclearkatie/THETA/tags","blobs_url":"https://api.github.com/repos/nuclearkatie/THETA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuclearkatie/THETA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuclearkatie/THETA/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuclearkatie/THETA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuclearkatie/THETA/statuses/{sha}","languages_url":"https://api.github.com/repos/nuclearkatie/THETA/languages","stargazers_url":"https://api.github.com/repos/nuclearkatie/THETA/stargazers","contributors_url":"https://api.github.com/repos/nuclearkatie/THETA/contributors","subscribers_url":"https://api.github.com/repos/nuclearkatie/THETA/subscribers","subscription_url":"https://api.github.com/repos/nuclearkatie/THETA/subscription","commits_url":"https://api.github.com/repos/nuclearkatie/THETA/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuclearkatie/THETA/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuclearkatie/THETA/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuclearkatie/THETA/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuclearkatie/THETA/contents/{+path}","compare_url":"https://api.github.com/repos/nuclearkatie/THETA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuclearkatie/THETA/merges","archive_url":"https://api.github.com/repos/nuclearkatie/THETA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuclearkatie/THETA/downloads","issues_url":"https://api.github.com/repos/nuclearkatie/THETA/issues{/number}","pulls_url":"https://api.github.com/repos/nuclearkatie/THETA/pulls{/number}","milestones_url":"https://api.github.com/repos/nuclearkatie/THETA/milestones{/number}","notifications_url":"https://api.github.com/repos/nuclearkatie/THETA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuclearkatie/THETA/labels{/name}","releases_url":"https://api.github.com/repos/nuclearkatie/THETA/releases{/id}","deployments_url":"https://api.github.com/repos/nuclearkatie/THETA/deployments","created_at":"2018-03-08T20:15:21Z","updated_at":"2018-05-03T00:51:16Z","pushed_at":"2018-05-03T02:33:57Z","git_url":"git://github.com/nuclearkatie/THETA.git","ssh_url":"git@github.com:nuclearkatie/THETA.git","clone_url":"https://github.com/nuclearkatie/THETA.git","svn_url":"https://github.com/nuclearkatie/THETA","homepage":null,"size":65,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"THETA476:master","ref":"master","sha":"80dc5606326b23bf71f1b179d5fb5851192d9484","user":{"login":"THETA476","id":36900420,"avatar_url":"https://avatars1.githubusercontent.com/u/36900420?v=4","gravatar_id":"","url":"https://api.github.com/users/THETA476","html_url":"https://github.com/THETA476","followers_url":"https://api.github.com/users/THETA476/followers","following_url":"https://api.github.com/users/THETA476/following{/other_user}","gists_url":"https://api.github.com/users/THETA476/gists{/gist_id}","starred_url":"https://api.github.com/users/THETA476/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/THETA476/subscriptions","organizations_url":"https://api.github.com/users/THETA476/orgs","repos_url":"https://api.github.com/users/THETA476/repos","events_url":"https://api.github.com/users/THETA476/events{/privacy}","received_events_url":"https://api.github.com/users/THETA476/received_events","type":"Organization","site_admin":false},"repo":{"id":123183362,"name":"THETA","full_name":"THETA476/THETA","owner":{"login":"THETA476","id":36900420,"avatar_url":"https://avatars1.githubusercontent.com/u/36900420?v=4","gravatar_id":"","url":"https://api.github.com/users/THETA476","html_url":"https://github.com/THETA476","followers_url":"https://api.github.com/users/THETA476/followers","following_url":"https://api.github.com/users/THETA476/following{/other_user}","gists_url":"https://api.github.com/users/THETA476/gists{/gist_id}","starred_url":"https://api.github.com/users/THETA476/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/THETA476/subscriptions","organizations_url":"https://api.github.com/users/THETA476/orgs","repos_url":"https://api.github.com/users/THETA476/repos","events_url":"https://api.github.com/users/THETA476/events{/privacy}","received_events_url":"https://api.github.com/users/THETA476/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/THETA476/THETA","description":"heat transfer kernel ","fork":false,"url":"https://api.github.com/repos/THETA476/THETA","forks_url":"https://api.github.com/repos/THETA476/THETA/forks","keys_url":"https://api.github.com/repos/THETA476/THETA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/THETA476/THETA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/THETA476/THETA/teams","hooks_url":"https://api.github.com/repos/THETA476/THETA/hooks","issue_events_url":"https://api.github.com/repos/THETA476/THETA/issues/events{/number}","events_url":"https://api.github.com/repos/THETA476/THETA/events","assignees_url":"https://api.github.com/repos/THETA476/THETA/assignees{/user}","branches_url":"https://api.github.com/repos/THETA476/THETA/branches{/branch}","tags_url":"https://api.github.com/repos/THETA476/THETA/tags","blobs_url":"https://api.github.com/repos/THETA476/THETA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/THETA476/THETA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/THETA476/THETA/git/refs{/sha}","trees_url":"https://api.github.com/repos/THETA476/THETA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/THETA476/THETA/statuses/{sha}","languages_url":"https://api.github.com/repos/THETA476/THETA/languages","stargazers_url":"https://api.github.com/repos/THETA476/THETA/stargazers","contributors_url":"https://api.github.com/repos/THETA476/THETA/contributors","subscribers_url":"https://api.github.com/repos/THETA476/THETA/subscribers","subscription_url":"https://api.github.com/repos/THETA476/THETA/subscription","commits_url":"https://api.github.com/repos/THETA476/THETA/commits{/sha}","git_commits_url":"https://api.github.com/repos/THETA476/THETA/git/commits{/sha}","comments_url":"https://api.github.com/repos/THETA476/THETA/comments{/number}","issue_comment_url":"https://api.github.com/repos/THETA476/THETA/issues/comments{/number}","contents_url":"https://api.github.com/repos/THETA476/THETA/contents/{+path}","compare_url":"https://api.github.com/repos/THETA476/THETA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/THETA476/THETA/merges","archive_url":"https://api.github.com/repos/THETA476/THETA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/THETA476/THETA/downloads","issues_url":"https://api.github.com/repos/THETA476/THETA/issues{/number}","pulls_url":"https://api.github.com/repos/THETA476/THETA/pulls{/number}","milestones_url":"https://api.github.com/repos/THETA476/THETA/milestones{/number}","notifications_url":"https://api.github.com/repos/THETA476/THETA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/THETA476/THETA/labels{/name}","releases_url":"https://api.github.com/repos/THETA476/THETA/releases{/id}","deployments_url":"https://api.github.com/repos/THETA476/THETA/deployments","created_at":"2018-02-27T20:20:04Z","updated_at":"2018-05-03T03:22:15Z","pushed_at":"2018-05-03T03:51:26Z","git_url":"git://github.com/THETA476/THETA.git","ssh_url":"git@github.com:THETA476/THETA.git","clone_url":"https://github.com/THETA476/THETA.git","svn_url":"https://github.com/THETA476/THETA","homepage":"","size":71,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/THETA476/THETA/pulls/56"},"html":{"href":"https://github.com/THETA476/THETA/pull/56"},"issue":{"href":"https://api.github.com/repos/THETA476/THETA/issues/56"},"comments":{"href":"https://api.github.com/repos/THETA476/THETA/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/THETA476/THETA/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/THETA476/THETA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/THETA476/THETA/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/THETA476/THETA/statuses/11055573d69b9fa7f2fcdbeb9e00939fb77736aa"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Zach-Fiscus","id":35815274,"avatar_url":"https://avatars0.githubusercontent.com/u/35815274?v=4","gravatar_id":"","url":"https://api.github.com/users/Zach-Fiscus","html_url":"https://github.com/Zach-Fiscus","followers_url":"https://api.github.com/users/Zach-Fiscus/followers","following_url":"https://api.github.com/users/Zach-Fiscus/following{/other_user}","gists_url":"https://api.github.com/users/Zach-Fiscus/gists{/gist_id}","starred_url":"https://api.github.com/users/Zach-Fiscus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zach-Fiscus/subscriptions","organizations_url":"https://api.github.com/users/Zach-Fiscus/orgs","repos_url":"https://api.github.com/users/Zach-Fiscus/repos","events_url":"https://api.github.com/users/Zach-Fiscus/events{/privacy}","received_events_url":"https://api.github.com/users/Zach-Fiscus/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":20,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"Zach-Fiscus"}}