{"action":"opened","number":39,"pull_request":{"url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/pulls/39","id":219891369,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODkxMzY5","html_url":"https://github.com/cmseaton42/node-ethernet-ip/pull/39","diff_url":"https://github.com/cmseaton42/node-ethernet-ip/pull/39.diff","patch_url":"https://github.com/cmseaton42/node-ethernet-ip/pull/39.patch","issue_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/issues/39","number":39,"state":"open","locked":false,"title":"Tag unstagewrite bugfix","user":{"login":"jhenson29","id":39809659,"node_id":"MDQ6VXNlcjM5ODA5NjU5","avatar_url":"https://avatars2.githubusercontent.com/u/39809659?v=4","gravatar_id":"","url":"https://api.github.com/users/jhenson29","html_url":"https://github.com/jhenson29","followers_url":"https://api.github.com/users/jhenson29/followers","following_url":"https://api.github.com/users/jhenson29/following{/other_user}","gists_url":"https://api.github.com/users/jhenson29/gists{/gist_id}","starred_url":"https://api.github.com/users/jhenson29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhenson29/subscriptions","organizations_url":"https://api.github.com/users/jhenson29/orgs","repos_url":"https://api.github.com/users/jhenson29/repos","events_url":"https://api.github.com/users/jhenson29/events{/privacy}","received_events_url":"https://api.github.com/users/jhenson29/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\nchanged `unstageWriteRequest` to set `tag.controllerValue` to `tag.value` instead of the other way around.\r\n\r\n### Description, Motivation, and Context\r\n<!--- Describe your changes in detail -->\r\n<!--- Why is this change required? What problem does it solve? -->\r\n`tag.value` returns to previous value after a plc write because it is set to `tag.controllerValue` in unstageWriteRequest, but tag.controllerValue had never been updated.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nTested writing tag to plc.\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n- [ ] This is a work in progress, and I want some feedback (If yes, please mark it in the title -> e.g. `[WIP] Some awesome PR title`)\r\n\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\n#36 ","created_at":"2018-10-03T01:30:49Z","updated_at":"2018-10-03T01:30:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/pulls/39/commits","review_comments_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/pulls/39/comments","review_comment_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/issues/39/comments","statuses_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/statuses/614f2f47733f09bea315066496b414ec0114be74","head":{"label":"jhenson29:tag-unstagewrite-bugfix","ref":"tag-unstagewrite-bugfix","sha":"614f2f47733f09bea315066496b414ec0114be74","user":{"login":"jhenson29","id":39809659,"node_id":"MDQ6VXNlcjM5ODA5NjU5","avatar_url":"https://avatars2.githubusercontent.com/u/39809659?v=4","gravatar_id":"","url":"https://api.github.com/users/jhenson29","html_url":"https://github.com/jhenson29","followers_url":"https://api.github.com/users/jhenson29/followers","following_url":"https://api.github.com/users/jhenson29/following{/other_user}","gists_url":"https://api.github.com/users/jhenson29/gists{/gist_id}","starred_url":"https://api.github.com/users/jhenson29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhenson29/subscriptions","organizations_url":"https://api.github.com/users/jhenson29/orgs","repos_url":"https://api.github.com/users/jhenson29/repos","events_url":"https://api.github.com/users/jhenson29/events{/privacy}","received_events_url":"https://api.github.com/users/jhenson29/received_events","type":"User","site_admin":false},"repo":{"id":135738306,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3MzgzMDY=","name":"node-ethernet-ip","full_name":"jhenson29/node-ethernet-ip","private":false,"owner":{"login":"jhenson29","id":39809659,"node_id":"MDQ6VXNlcjM5ODA5NjU5","avatar_url":"https://avatars2.githubusercontent.com/u/39809659?v=4","gravatar_id":"","url":"https://api.github.com/users/jhenson29","html_url":"https://github.com/jhenson29","followers_url":"https://api.github.com/users/jhenson29/followers","following_url":"https://api.github.com/users/jhenson29/following{/other_user}","gists_url":"https://api.github.com/users/jhenson29/gists{/gist_id}","starred_url":"https://api.github.com/users/jhenson29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhenson29/subscriptions","organizations_url":"https://api.github.com/users/jhenson29/orgs","repos_url":"https://api.github.com/users/jhenson29/repos","events_url":"https://api.github.com/users/jhenson29/events{/privacy}","received_events_url":"https://api.github.com/users/jhenson29/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jhenson29/node-ethernet-ip","description":"A Lightweight Ethernet/IP API written to interface with Rockwell ControlLogix/CompactLogix Controllers.","fork":true,"url":"https://api.github.com/repos/jhenson29/node-ethernet-ip","forks_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/forks","keys_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/teams","hooks_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/hooks","issue_events_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/issues/events{/number}","events_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/events","assignees_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/assignees{/user}","branches_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/branches{/branch}","tags_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/tags","blobs_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/statuses/{sha}","languages_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/languages","stargazers_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/stargazers","contributors_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/contributors","subscribers_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/subscribers","subscription_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/subscription","commits_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/contents/{+path}","compare_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/merges","archive_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/downloads","issues_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/issues{/number}","pulls_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/pulls{/number}","milestones_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/milestones{/number}","notifications_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/labels{/name}","releases_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/releases{/id}","deployments_url":"https://api.github.com/repos/jhenson29/node-ethernet-ip/deployments","created_at":"2018-06-01T16:06:17Z","updated_at":"2018-10-03T01:22:30Z","pushed_at":"2018-10-03T01:24:43Z","git_url":"git://github.com/jhenson29/node-ethernet-ip.git","ssh_url":"git@github.com:jhenson29/node-ethernet-ip.git","clone_url":"https://github.com/jhenson29/node-ethernet-ip.git","svn_url":"https://github.com/jhenson29/node-ethernet-ip","homepage":"","size":20676,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cmseaton42:master","ref":"master","sha":"ea1d428a594a8fe60b13a7f511aff2c440d7ad0a","user":{"login":"cmseaton42","id":18745936,"node_id":"MDQ6VXNlcjE4NzQ1OTM2","avatar_url":"https://avatars2.githubusercontent.com/u/18745936?v=4","gravatar_id":"","url":"https://api.github.com/users/cmseaton42","html_url":"https://github.com/cmseaton42","followers_url":"https://api.github.com/users/cmseaton42/followers","following_url":"https://api.github.com/users/cmseaton42/following{/other_user}","gists_url":"https://api.github.com/users/cmseaton42/gists{/gist_id}","starred_url":"https://api.github.com/users/cmseaton42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmseaton42/subscriptions","organizations_url":"https://api.github.com/users/cmseaton42/orgs","repos_url":"https://api.github.com/users/cmseaton42/repos","events_url":"https://api.github.com/users/cmseaton42/events{/privacy}","received_events_url":"https://api.github.com/users/cmseaton42/received_events","type":"User","site_admin":false},"repo":{"id":117992019,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc5OTIwMTk=","name":"node-ethernet-ip","full_name":"cmseaton42/node-ethernet-ip","private":false,"owner":{"login":"cmseaton42","id":18745936,"node_id":"MDQ6VXNlcjE4NzQ1OTM2","avatar_url":"https://avatars2.githubusercontent.com/u/18745936?v=4","gravatar_id":"","url":"https://api.github.com/users/cmseaton42","html_url":"https://github.com/cmseaton42","followers_url":"https://api.github.com/users/cmseaton42/followers","following_url":"https://api.github.com/users/cmseaton42/following{/other_user}","gists_url":"https://api.github.com/users/cmseaton42/gists{/gist_id}","starred_url":"https://api.github.com/users/cmseaton42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmseaton42/subscriptions","organizations_url":"https://api.github.com/users/cmseaton42/orgs","repos_url":"https://api.github.com/users/cmseaton42/repos","events_url":"https://api.github.com/users/cmseaton42/events{/privacy}","received_events_url":"https://api.github.com/users/cmseaton42/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cmseaton42/node-ethernet-ip","description":"A Lightweight Ethernet/IP API written to interface with Rockwell ControlLogix/CompactLogix Controllers.","fork":false,"url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip","forks_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/forks","keys_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/teams","hooks_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/hooks","issue_events_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/issues/events{/number}","events_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/events","assignees_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/assignees{/user}","branches_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/branches{/branch}","tags_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/tags","blobs_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/statuses/{sha}","languages_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/languages","stargazers_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/stargazers","contributors_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/contributors","subscribers_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/subscribers","subscription_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/subscription","commits_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/contents/{+path}","compare_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/merges","archive_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/downloads","issues_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/issues{/number}","pulls_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/pulls{/number}","milestones_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/milestones{/number}","notifications_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/labels{/name}","releases_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/releases{/id}","deployments_url":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/deployments","created_at":"2018-01-18T14:16:55Z","updated_at":"2018-09-30T19:56:35Z","pushed_at":"2018-09-30T19:56:48Z","git_url":"git://github.com/cmseaton42/node-ethernet-ip.git","ssh_url":"git@github.com:cmseaton42/node-ethernet-ip.git","clone_url":"https://github.com/cmseaton42/node-ethernet-ip.git","svn_url":"https://github.com/cmseaton42/node-ethernet-ip","homepage":"","size":19727,"stargazers_count":52,"watchers_count":52,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19,"open_issues":11,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/pulls/39"},"html":{"href":"https://github.com/cmseaton42/node-ethernet-ip/pull/39"},"issue":{"href":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/issues/39"},"comments":{"href":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/cmseaton42/node-ethernet-ip/statuses/614f2f47733f09bea315066496b414ec0114be74"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":3,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"jhenson29"}}