{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/233655088","pull_request_review_id":175122098,"id":233655088,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzY1NTA4OA==","diff_hunk":"@@ -66,6 +98,22 @@ abstract class ProgressIndicator extends StatefulWidget {\n     super.debugFillProperties(properties);\n     properties.add(PercentProperty('value', value, showName: false, ifNull: '<indeterminate>'));\n   }\n+\n+  Widget _buildSemanticsWrapper({\n+    @required BuildContext context,\n+    @required Widget child,\n+  }) {\n+    String expandedSemanticsValue = semanticsValue;\n+    if (value != null) {\n+      expandedSemanticsValue ??= '${(value * 100).round()}%';\n+    }\n+    return Semantics(\n+      container: true,","path":"packages/flutter/lib/src/material/progress_indicator.dart","position":65,"original_position":65,"commit_id":"b6f11370ba5330fe7121a3b21cb4526598c8ce50","original_commit_id":"b6f11370ba5330fe7121a3b21cb4526598c8ce50","user":{"login":"dnfield","id":8620741,"node_id":"MDQ6VXNlcjg2MjA3NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/8620741?v=4","gravatar_id":"","url":"https://api.github.com/users/dnfield","html_url":"https://github.com/dnfield","followers_url":"https://api.github.com/users/dnfield/followers","following_url":"https://api.github.com/users/dnfield/following{/other_user}","gists_url":"https://api.github.com/users/dnfield/gists{/gist_id}","starred_url":"https://api.github.com/users/dnfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnfield/subscriptions","organizations_url":"https://api.github.com/users/dnfield/orgs","repos_url":"https://api.github.com/users/dnfield/repos","events_url":"https://api.github.com/users/dnfield/events{/privacy}","received_events_url":"https://api.github.com/users/dnfield/received_events","type":"User","site_admin":false},"body":"How would that handle if this indicator was the child of something that also set label and/or value?","created_at":"2018-11-14T23:02:47Z","updated_at":"2018-11-14T23:02:48Z","html_url":"https://github.com/flutter/flutter/pull/24275#discussion_r233655088","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/24275","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/233655088"},"html":{"href":"https://github.com/flutter/flutter/pull/24275#discussion_r233655088"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/24275"}},"in_reply_to_id":233654336},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/24275","id":230360392,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMzYwMzky","html_url":"https://github.com/flutter/flutter/pull/24275","diff_url":"https://github.com/flutter/flutter/pull/24275.diff","patch_url":"https://github.com/flutter/flutter/pull/24275.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/24275","number":24275,"state":"open","locked":false,"title":"Make progress indicators accessible","user":{"login":"dnfield","id":8620741,"node_id":"MDQ6VXNlcjg2MjA3NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/8620741?v=4","gravatar_id":"","url":"https://api.github.com/users/dnfield","html_url":"https://github.com/dnfield","followers_url":"https://api.github.com/users/dnfield/followers","following_url":"https://api.github.com/users/dnfield/following{/other_user}","gists_url":"https://api.github.com/users/dnfield/gists{/gist_id}","starred_url":"https://api.github.com/users/dnfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnfield/subscriptions","organizations_url":"https://api.github.com/users/dnfield/orgs","repos_url":"https://api.github.com/users/dnfield/repos","events_url":"https://api.github.com/users/dnfield/events{/privacy}","received_events_url":"https://api.github.com/users/dnfield/received_events","type":"User","site_admin":false},"body":"Fixes #14465 \r\n\r\nAndroid does not make progress indicators announce anything by default - we're immitating that here by making it opt in (but still making it easier by providing a default implementation that can be easily used).\r\n\r\nRefreshIndicator is made enabled by default because this should normally be a one at a time widget, and is indicating some kind of modal-like activity.\r\n\r\nI'd appreciate feedback from people using these in accessible apps for sure!\r\n\r\nNote that this does not address making the \"swipe to refresh\" action accessible.","created_at":"2018-11-13T06:20:04Z","updated_at":"2018-11-14T23:02:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be1b0b1edf86037ba1411d031f73e8c9d97a6506","assignee":null,"assignees":[],"requested_reviewers":[{"login":"willlarche","id":1271525,"node_id":"MDQ6VXNlcjEyNzE1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1271525?v=4","gravatar_id":"","url":"https://api.github.com/users/willlarche","html_url":"https://github.com/willlarche","followers_url":"https://api.github.com/users/willlarche/followers","following_url":"https://api.github.com/users/willlarche/following{/other_user}","gists_url":"https://api.github.com/users/willlarche/gists{/gist_id}","starred_url":"https://api.github.com/users/willlarche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willlarche/subscriptions","organizations_url":"https://api.github.com/users/willlarche/orgs","repos_url":"https://api.github.com/users/willlarche/repos","events_url":"https://api.github.com/users/willlarche/events{/privacy}","received_events_url":"https://api.github.com/users/willlarche/received_events","type":"User","site_admin":false},{"login":"DaveShuckerow","id":14947366,"node_id":"MDQ6VXNlcjE0OTQ3MzY2","avatar_url":"https://avatars2.githubusercontent.com/u/14947366?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveShuckerow","html_url":"https://github.com/DaveShuckerow","followers_url":"https://api.github.com/users/DaveShuckerow/followers","following_url":"https://api.github.com/users/DaveShuckerow/following{/other_user}","gists_url":"https://api.github.com/users/DaveShuckerow/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveShuckerow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveShuckerow/subscriptions","organizations_url":"https://api.github.com/users/DaveShuckerow/orgs","repos_url":"https://api.github.com/users/DaveShuckerow/repos","events_url":"https://api.github.com/users/DaveShuckerow/events{/privacy}","received_events_url":"https://api.github.com/users/DaveShuckerow/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/24275/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/24275/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/24275/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/b6f11370ba5330fe7121a3b21cb4526598c8ce50","head":{"label":"dnfield:progress_a11y","ref":"progress_a11y","sha":"b6f11370ba5330fe7121a3b21cb4526598c8ce50","user":{"login":"dnfield","id":8620741,"node_id":"MDQ6VXNlcjg2MjA3NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/8620741?v=4","gravatar_id":"","url":"https://api.github.com/users/dnfield","html_url":"https://github.com/dnfield","followers_url":"https://api.github.com/users/dnfield/followers","following_url":"https://api.github.com/users/dnfield/following{/other_user}","gists_url":"https://api.github.com/users/dnfield/gists{/gist_id}","starred_url":"https://api.github.com/users/dnfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnfield/subscriptions","organizations_url":"https://api.github.com/users/dnfield/orgs","repos_url":"https://api.github.com/users/dnfield/repos","events_url":"https://api.github.com/users/dnfield/events{/privacy}","received_events_url":"https://api.github.com/users/dnfield/received_events","type":"User","site_admin":false},"repo":{"id":131232406,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEyMzI0MDY=","name":"flutter","full_name":"dnfield/flutter","private":false,"owner":{"login":"dnfield","id":8620741,"node_id":"MDQ6VXNlcjg2MjA3NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/8620741?v=4","gravatar_id":"","url":"https://api.github.com/users/dnfield","html_url":"https://github.com/dnfield","followers_url":"https://api.github.com/users/dnfield/followers","following_url":"https://api.github.com/users/dnfield/following{/other_user}","gists_url":"https://api.github.com/users/dnfield/gists{/gist_id}","starred_url":"https://api.github.com/users/dnfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnfield/subscriptions","organizations_url":"https://api.github.com/users/dnfield/orgs","repos_url":"https://api.github.com/users/dnfield/repos","events_url":"https://api.github.com/users/dnfield/events{/privacy}","received_events_url":"https://api.github.com/users/dnfield/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dnfield/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":true,"url":"https://api.github.com/repos/dnfield/flutter","forks_url":"https://api.github.com/repos/dnfield/flutter/forks","keys_url":"https://api.github.com/repos/dnfield/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnfield/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnfield/flutter/teams","hooks_url":"https://api.github.com/repos/dnfield/flutter/hooks","issue_events_url":"https://api.github.com/repos/dnfield/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/dnfield/flutter/events","assignees_url":"https://api.github.com/repos/dnfield/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/dnfield/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/dnfield/flutter/tags","blobs_url":"https://api.github.com/repos/dnfield/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnfield/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnfield/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnfield/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnfield/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/dnfield/flutter/languages","stargazers_url":"https://api.github.com/repos/dnfield/flutter/stargazers","contributors_url":"https://api.github.com/repos/dnfield/flutter/contributors","subscribers_url":"https://api.github.com/repos/dnfield/flutter/subscribers","subscription_url":"https://api.github.com/repos/dnfield/flutter/subscription","commits_url":"https://api.github.com/repos/dnfield/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnfield/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnfield/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnfield/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnfield/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/dnfield/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnfield/flutter/merges","archive_url":"https://api.github.com/repos/dnfield/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnfield/flutter/downloads","issues_url":"https://api.github.com/repos/dnfield/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/dnfield/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/dnfield/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/dnfield/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnfield/flutter/labels{/name}","releases_url":"https://api.github.com/repos/dnfield/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/dnfield/flutter/deployments","created_at":"2018-04-27T02:03:08Z","updated_at":"2018-11-09T05:13:48Z","pushed_at":"2018-11-14T22:39:54Z","git_url":"git://github.com/dnfield/flutter.git","ssh_url":"git@github.com:dnfield/flutter.git","clone_url":"https://github.com/dnfield/flutter.git","svn_url":"https://github.com/dnfield/flutter","homepage":"https://flutter.io","size":49196,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"aa65fa2fa120d99cb867a388aa143fc552130f7f","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-11-14T23:00:58Z","pushed_at":"2018-11-14T23:00:41Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":49075,"stargazers_count":41196,"watchers_count":41196,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4127,"mirror_url":null,"archived":false,"open_issues_count":4354,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4127,"open_issues":4354,"watchers":41196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/24275"},"html":{"href":"https://github.com/flutter/flutter/pull/24275"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/24275"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/24275/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/24275/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/24275/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/b6f11370ba5330fe7121a3b21cb4526598c8ce50"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dnfield"}}