{"action":"created","issue":{"url":"https://api.github.com/repos/mafintosh/hypercore/issues/158","repository_url":"https://api.github.com/repos/mafintosh/hypercore","labels_url":"https://api.github.com/repos/mafintosh/hypercore/issues/158/labels{/name}","comments_url":"https://api.github.com/repos/mafintosh/hypercore/issues/158/comments","events_url":"https://api.github.com/repos/mafintosh/hypercore/issues/158/events","html_url":"https://github.com/mafintosh/hypercore/issues/158","id":326830647,"number":158,"title":"What about refactoring ?","user":{"login":"yuriy-yarosh","id":6811933,"avatar_url":"https://avatars0.githubusercontent.com/u/6811933?v=4","gravatar_id":"","url":"https://api.github.com/users/yuriy-yarosh","html_url":"https://github.com/yuriy-yarosh","followers_url":"https://api.github.com/users/yuriy-yarosh/followers","following_url":"https://api.github.com/users/yuriy-yarosh/following{/other_user}","gists_url":"https://api.github.com/users/yuriy-yarosh/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriy-yarosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriy-yarosh/subscriptions","organizations_url":"https://api.github.com/users/yuriy-yarosh/orgs","repos_url":"https://api.github.com/users/yuriy-yarosh/repos","events_url":"https://api.github.com/users/yuriy-yarosh/events{/privacy}","received_events_url":"https://api.github.com/users/yuriy-yarosh/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-27T16:36:03Z","updated_at":"2018-05-27T18:47:58Z","closed_at":"2018-05-27T17:39:11Z","author_association":"NONE","body":"I've been writting some typings for hypercore in openrealrecord/[#8](https://github.com/xloem/openrealrecord/issues/8), so had reviewed some portion of the hypercore / hyperdb / hyperdiscovery codebase. Well, it's not great... From the QA perspective there are some flaws, and overall API is inconsistent.\r\n\r\n• @mafintosh what do you think about improving code coverage, adding some mutational testing support, newer ES6+ features (promises, async/await, etc) and some TypeScript via Babel7 ?\r\n\r\n• Also I'd like to propose some cancelable streams with FRP on top of [most.js](https://github.com/cujojs/most) to reduce the amount of boilerplate code and increase maintability ?\r\n\r\n• What do you think about using google's [protobuf impl](https://www.npmjs.com/package/google-protobuf) instead of [protocol-buffers](https://www.npmjs.com/package/protocol-buffers) ?\r\n\r\nAnd... from the performance perspective, JavaScript stuff haven't been designed to deliver the best possible performance, but it's possible to deliver good development experience and smooth the rough edges via profiling / flamegraphs and some further Rust/C/C++/ASM FFI, it's especially handy nowadays with Node10.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mafintosh/hypercore/issues/comments/392354129","html_url":"https://github.com/mafintosh/hypercore/issues/158#issuecomment-392354129","issue_url":"https://api.github.com/repos/mafintosh/hypercore/issues/158","id":392354129,"user":{"login":"yuriy-yarosh","id":6811933,"avatar_url":"https://avatars0.githubusercontent.com/u/6811933?v=4","gravatar_id":"","url":"https://api.github.com/users/yuriy-yarosh","html_url":"https://github.com/yuriy-yarosh","followers_url":"https://api.github.com/users/yuriy-yarosh/followers","following_url":"https://api.github.com/users/yuriy-yarosh/following{/other_user}","gists_url":"https://api.github.com/users/yuriy-yarosh/gists{/gist_id}","starred_url":"https://api.github.com/users/yuriy-yarosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuriy-yarosh/subscriptions","organizations_url":"https://api.github.com/users/yuriy-yarosh/orgs","repos_url":"https://api.github.com/users/yuriy-yarosh/repos","events_url":"https://api.github.com/users/yuriy-yarosh/events{/privacy}","received_events_url":"https://api.github.com/users/yuriy-yarosh/received_events","type":"User","site_admin":false},"created_at":"2018-05-27T18:47:58Z","updated_at":"2018-05-27T18:47:58Z","author_association":"NONE","body":"@pfrazee nice one, don't be a jerk, and I hope you've got something to reply [over here](https://github.com/mafintosh/hypercore/issues/155#issuecomment-392353087)."}}
{"actor":{"display_login":"yuriy-yarosh"}}