{"action":"created","issue":{"url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/422","repository_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick","labels_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/422/labels{/name}","comments_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/422/comments","events_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/422/events","html_url":"https://github.com/DistrictDataLabs/yellowbrick/pull/422","id":323266027,"number":422,"title":"[WIP] Make poof() return self.ax","user":{"login":"jtpio","id":591645,"avatar_url":"https://avatars2.githubusercontent.com/u/591645?v=4","gravatar_id":"","url":"https://api.github.com/users/jtpio","html_url":"https://github.com/jtpio","followers_url":"https://api.github.com/users/jtpio/followers","following_url":"https://api.github.com/users/jtpio/following{/other_user}","gists_url":"https://api.github.com/users/jtpio/gists{/gist_id}","starred_url":"https://api.github.com/users/jtpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtpio/subscriptions","organizations_url":"https://api.github.com/users/jtpio/orgs","repos_url":"https://api.github.com/users/jtpio/repos","events_url":"https://api.github.com/users/jtpio/events{/privacy}","received_events_url":"https://api.github.com/users/jtpio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-15T15:20:17Z","updated_at":"2018-05-16T16:11:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/pulls/422","html_url":"https://github.com/DistrictDataLabs/yellowbrick/pull/422","diff_url":"https://github.com/DistrictDataLabs/yellowbrick/pull/422.diff","patch_url":"https://github.com/DistrictDataLabs/yellowbrick/pull/422.patch"},"body":"Initial work to make the `poof()` method return `self.ax`.\r\n\r\nFixes #375 \r\n\r\n@DistrictDataLabs/team-oz-maintainers\r\n"},"comment":{"url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/comments/389576569","html_url":"https://github.com/DistrictDataLabs/yellowbrick/pull/422#issuecomment-389576569","issue_url":"https://api.github.com/repos/DistrictDataLabs/yellowbrick/issues/422","id":389576569,"user":{"login":"NealHumphrey","id":5642566,"avatar_url":"https://avatars1.githubusercontent.com/u/5642566?v=4","gravatar_id":"","url":"https://api.github.com/users/NealHumphrey","html_url":"https://github.com/NealHumphrey","followers_url":"https://api.github.com/users/NealHumphrey/followers","following_url":"https://api.github.com/users/NealHumphrey/following{/other_user}","gists_url":"https://api.github.com/users/NealHumphrey/gists{/gist_id}","starred_url":"https://api.github.com/users/NealHumphrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NealHumphrey/subscriptions","organizations_url":"https://api.github.com/users/NealHumphrey/orgs","repos_url":"https://api.github.com/users/NealHumphrey/repos","events_url":"https://api.github.com/users/NealHumphrey/events{/privacy}","received_events_url":"https://api.github.com/users/NealHumphrey/received_events","type":"User","site_admin":false},"created_at":"2018-05-16T16:11:29Z","updated_at":"2018-05-16T16:11:29Z","author_association":"CONTRIBUTOR","body":"@jtpio looks simple and straightforward. Were you able to search the codebase to see if any visualizers override the `poof()` method though? I can approve if you confirm there was at least a quick check for this. \r\n\r\nI checked on the failed appveyor integration and this was the reason, so should be safe to ignore: `Build execution time has reached the maximum allowed time for your plan (60 minutes).`. Python 3 test completed, Python 2 did not. \r\n\r\nThis is very likely overkill for this issue, but for enforcing API uniformity for situations like this it would be ideal to include a test case that tests all subclasses of Visualizer, so if anyone overrides it'll catch it in the tests. @bbengfort or @ndanielsen I think we talked about this in the past but don't remember if we found a solution or just decided to keep watching out for things manually? If there's a working example of other unit tests that do API enforcement like this we could imitate, otherwise we can leave alone. "}}
{"actor":{"display_login":"NealHumphrey"}}