{"action":"created","issue":{"url":"https://api.github.com/repos/frappe/erpnext/issues/12806","repository_url":"https://api.github.com/repos/frappe/erpnext","labels_url":"https://api.github.com/repos/frappe/erpnext/issues/12806/labels{/name}","comments_url":"https://api.github.com/repos/frappe/erpnext/issues/12806/comments","events_url":"https://api.github.com/repos/frappe/erpnext/issues/12806/events","html_url":"https://github.com/frappe/erpnext/pull/12806","id":295114429,"number":12806,"title":"Automatically Delivery date","user":{"login":"mghoneem10","id":11355558,"avatar_url":"https://avatars2.githubusercontent.com/u/11355558?v=4","gravatar_id":"","url":"https://api.github.com/users/mghoneem10","html_url":"https://github.com/mghoneem10","followers_url":"https://api.github.com/users/mghoneem10/followers","following_url":"https://api.github.com/users/mghoneem10/following{/other_user}","gists_url":"https://api.github.com/users/mghoneem10/gists{/gist_id}","starred_url":"https://api.github.com/users/mghoneem10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mghoneem10/subscriptions","organizations_url":"https://api.github.com/users/mghoneem10/orgs","repos_url":"https://api.github.com/users/mghoneem10/repos","events_url":"https://api.github.com/users/mghoneem10/events{/privacy}","received_events_url":"https://api.github.com/users/mghoneem10/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-07T12:10:24Z","updated_at":"2018-02-07T13:35:26Z","closed_at":"2018-02-07T13:35:26Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/frappe/erpnext/pulls/12806","html_url":"https://github.com/frappe/erpnext/pull/12806","diff_url":"https://github.com/frappe/erpnext/pull/12806.diff","patch_url":"https://github.com/frappe/erpnext/pull/12806.patch"},"body":"I`m planning to make delivery dates automatically for sales orders so the delivery date field will be read only for the user\r\n\r\nwhat i did\r\n\r\n1- i`v created a new int custom field in both item & Sales order item doctypes named ( delivery_days).\r\n2- then fetched it successfully be the following custom script\r\n\r\ncur_frm.add_fetch(“item_code”,“delivery_days”,“delivery_days”);\r\n\r\n3- Then created the following custom script\r\n\r\ncur_frm.add_fetch(\"item_code\",\"delivery_days\",\"delivery_days\");\r\nfrappe.ui.form.on(\"Sales Order Item\", \"delivery_days\", function(frm, cdt, cdn){\r\n         frm.set_value(\"delivery_date\", frappe.datetime.add_days(frappe.datetime.nowdate(), locals[cdt][cdn].delivery_days));\r\n})\r\n\r\nits working well for item delivery date \r\n\r\nbut sales order delivery date takes the last item delivery date in items table \r\n\r\nit should takes the fairest delivery date of the entire items table delivery date not the last row delivery date \r\n\r\nwhat should i do and how can we merge it ??"},"comment":{"url":"https://api.github.com/repos/frappe/erpnext/issues/comments/363770276","html_url":"https://github.com/frappe/erpnext/pull/12806#issuecomment-363770276","issue_url":"https://api.github.com/repos/frappe/erpnext/issues/12806","id":363770276,"user":{"login":"nabinhait","id":836784,"avatar_url":"https://avatars2.githubusercontent.com/u/836784?v=4","gravatar_id":"","url":"https://api.github.com/users/nabinhait","html_url":"https://github.com/nabinhait","followers_url":"https://api.github.com/users/nabinhait/followers","following_url":"https://api.github.com/users/nabinhait/following{/other_user}","gists_url":"https://api.github.com/users/nabinhait/gists{/gist_id}","starred_url":"https://api.github.com/users/nabinhait/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nabinhait/subscriptions","organizations_url":"https://api.github.com/users/nabinhait/orgs","repos_url":"https://api.github.com/users/nabinhait/repos","events_url":"https://api.github.com/users/nabinhait/events{/privacy}","received_events_url":"https://api.github.com/users/nabinhait/received_events","type":"User","site_admin":false},"created_at":"2018-02-07T13:35:26Z","updated_at":"2018-02-07T13:35:26Z","author_association":"OWNER","body":"You did not create the pull request in a correct way. After changing the files in local, commit and push your changes to your fork. Then from your fork, create the pull request. Closing it."}}
{"actor":{"display_login":"nabinhait"}}