{"action":"closed","number":958,"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/958","id":187856085,"html_url":"https://github.com/smartdevicelink/sdl_ios/pull/958","diff_url":"https://github.com/smartdevicelink/sdl_ios/pull/958.diff","patch_url":"https://github.com/smartdevicelink/sdl_ios/pull/958.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/958","number":958,"state":"closed","locked":false,"title":"Fixed image soft buttons getting sent early","user":{"login":"NicoleYarroch","id":19915981,"avatar_url":"https://avatars1.githubusercontent.com/u/19915981?v=4","gravatar_id":"","url":"https://api.github.com/users/NicoleYarroch","html_url":"https://github.com/NicoleYarroch","followers_url":"https://api.github.com/users/NicoleYarroch/followers","following_url":"https://api.github.com/users/NicoleYarroch/following{/other_user}","gists_url":"https://api.github.com/users/NicoleYarroch/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoleYarroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoleYarroch/subscriptions","organizations_url":"https://api.github.com/users/NicoleYarroch/orgs","repos_url":"https://api.github.com/users/NicoleYarroch/repos","events_url":"https://api.github.com/users/NicoleYarroch/events{/privacy}","received_events_url":"https://api.github.com/users/NicoleYarroch/received_events","type":"User","site_admin":false},"body":"Fixes #955\r\n\r\nThis PR is **ready** for review.\r\n\r\n### Risk\r\nThis PR makes **no** API changes.\r\n\r\n### Testing Plan\r\nAdded additional test cases to the *SDLSoftButtonManagerSpec*.\r\n\r\n### Summary\r\n* Previously, the image soft buttons were getting sent even if the artworks where not yet uploaded to the remote because `softButtonCapabilities.imageSupported` always returned `false`. This is due to  the `imageSupported` datatype being a `NSNumber`.\r\n\r\n### Changelog\r\n##### Bug Fix\r\n* Image soft buttons are no longer sent by the *SDLSoftButtonManager* before the image is uploaded to the remote.\r\n\r\n### CLA\r\n- [x] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform)","created_at":"2018-05-14T14:59:10Z","updated_at":"2018-05-14T20:45:36Z","closed_at":"2018-05-14T20:45:36Z","merged_at":"2018-05-14T20:45:35Z","merge_commit_sha":"3c8b96baa241060b3ff4315412ecd7b3a6e1b7a7","assignee":{"login":"NicoleYarroch","id":19915981,"avatar_url":"https://avatars1.githubusercontent.com/u/19915981?v=4","gravatar_id":"","url":"https://api.github.com/users/NicoleYarroch","html_url":"https://github.com/NicoleYarroch","followers_url":"https://api.github.com/users/NicoleYarroch/followers","following_url":"https://api.github.com/users/NicoleYarroch/following{/other_user}","gists_url":"https://api.github.com/users/NicoleYarroch/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoleYarroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoleYarroch/subscriptions","organizations_url":"https://api.github.com/users/NicoleYarroch/orgs","repos_url":"https://api.github.com/users/NicoleYarroch/repos","events_url":"https://api.github.com/users/NicoleYarroch/events{/privacy}","received_events_url":"https://api.github.com/users/NicoleYarroch/received_events","type":"User","site_admin":false},"assignees":[{"login":"NicoleYarroch","id":19915981,"avatar_url":"https://avatars1.githubusercontent.com/u/19915981?v=4","gravatar_id":"","url":"https://api.github.com/users/NicoleYarroch","html_url":"https://github.com/NicoleYarroch","followers_url":"https://api.github.com/users/NicoleYarroch/followers","following_url":"https://api.github.com/users/NicoleYarroch/following{/other_user}","gists_url":"https://api.github.com/users/NicoleYarroch/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoleYarroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoleYarroch/subscriptions","organizations_url":"https://api.github.com/users/NicoleYarroch/orgs","repos_url":"https://api.github.com/users/NicoleYarroch/repos","events_url":"https://api.github.com/users/NicoleYarroch/events{/privacy}","received_events_url":"https://api.github.com/users/NicoleYarroch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":135859168,"url":"https://api.github.com/repos/smartdevicelink/sdl_ios/labels/bug","name":"bug","color":"F44336","default":true}],"milestone":{"url":"https://api.github.com/repos/smartdevicelink/sdl_ios/milestones/19","html_url":"https://github.com/smartdevicelink/sdl_ios/milestone/19","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/milestones/19/labels","id":3223282,"number":19,"title":"6.0.0","description":"","creator":{"login":"NicoleYarroch","id":19915981,"avatar_url":"https://avatars1.githubusercontent.com/u/19915981?v=4","gravatar_id":"","url":"https://api.github.com/users/NicoleYarroch","html_url":"https://github.com/NicoleYarroch","followers_url":"https://api.github.com/users/NicoleYarroch/followers","following_url":"https://api.github.com/users/NicoleYarroch/following{/other_user}","gists_url":"https://api.github.com/users/NicoleYarroch/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoleYarroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoleYarroch/subscriptions","organizations_url":"https://api.github.com/users/NicoleYarroch/orgs","repos_url":"https://api.github.com/users/NicoleYarroch/repos","events_url":"https://api.github.com/users/NicoleYarroch/events{/privacy}","received_events_url":"https://api.github.com/users/NicoleYarroch/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":27,"state":"open","created_at":"2018-03-27T20:47:18Z","updated_at":"2018-05-14T20:45:36Z","due_on":"2018-05-28T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/958/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/958/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/958/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/statuses/00ce9de351e2e8c41cf2ddc80f64c258e5fb0d13","head":{"label":"smartdevicelink:bugfix/issue_955_image_buttons_sent_early","ref":"bugfix/issue_955_image_buttons_sent_early","sha":"00ce9de351e2e8c41cf2ddc80f64c258e5fb0d13","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24940582,"name":"sdl_ios","full_name":"smartdevicelink/sdl_ios","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_ios","description":"Get your app connected to the 🚙, make your users feel like a 🌟","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_ios","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/deployments","created_at":"2014-10-08T12:57:22Z","updated_at":"2018-04-02T09:43:43Z","pushed_at":"2018-05-14T20:45:35Z","git_url":"git://github.com/smartdevicelink/sdl_ios.git","ssh_url":"git@github.com:smartdevicelink/sdl_ios.git","clone_url":"https://github.com/smartdevicelink/sdl_ios.git","svn_url":"https://github.com/smartdevicelink/sdl_ios","homepage":"www.smartdevicelink.com","size":29382,"stargazers_count":105,"watchers_count":105,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":70,"open_issues":77,"watchers":105,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"9fceb95a2f9c192ba7ea2648b5bc207c1e32b263","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24940582,"name":"sdl_ios","full_name":"smartdevicelink/sdl_ios","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_ios","description":"Get your app connected to the 🚙, make your users feel like a 🌟","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_ios","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/deployments","created_at":"2014-10-08T12:57:22Z","updated_at":"2018-04-02T09:43:43Z","pushed_at":"2018-05-14T20:45:35Z","git_url":"git://github.com/smartdevicelink/sdl_ios.git","ssh_url":"git@github.com:smartdevicelink/sdl_ios.git","clone_url":"https://github.com/smartdevicelink/sdl_ios.git","svn_url":"https://github.com/smartdevicelink/sdl_ios","homepage":"www.smartdevicelink.com","size":29382,"stargazers_count":105,"watchers_count":105,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":70,"open_issues":77,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/958"},"html":{"href":"https://github.com/smartdevicelink/sdl_ios/pull/958"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/958"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/958/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/958/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/958/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/statuses/00ce9de351e2e8c41cf2ddc80f64c258e5fb0d13"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"joeljfischer","id":1767063,"avatar_url":"https://avatars0.githubusercontent.com/u/1767063?v=4","gravatar_id":"","url":"https://api.github.com/users/joeljfischer","html_url":"https://github.com/joeljfischer","followers_url":"https://api.github.com/users/joeljfischer/followers","following_url":"https://api.github.com/users/joeljfischer/following{/other_user}","gists_url":"https://api.github.com/users/joeljfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/joeljfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeljfischer/subscriptions","organizations_url":"https://api.github.com/users/joeljfischer/orgs","repos_url":"https://api.github.com/users/joeljfischer/repos","events_url":"https://api.github.com/users/joeljfischer/events{/privacy}","received_events_url":"https://api.github.com/users/joeljfischer/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"maintainer_can_modify":false,"commits":3,"additions":74,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"joeljfischer"}}