{"action":"created","issue":{"url":"https://api.github.com/repos/TeamMaestro/angular-native-seed/issues/79","repository_url":"https://api.github.com/repos/TeamMaestro/angular-native-seed","labels_url":"https://api.github.com/repos/TeamMaestro/angular-native-seed/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/TeamMaestro/angular-native-seed/issues/79/comments","events_url":"https://api.github.com/repos/TeamMaestro/angular-native-seed/issues/79/events","html_url":"https://github.com/TeamMaestro/angular-native-seed/issues/79","id":294376848,"number":79,"title":"Congrats and Angular 5","user":{"login":"dcasbonne","id":18432595,"avatar_url":"https://avatars3.githubusercontent.com/u/18432595?v=4","gravatar_id":"","url":"https://api.github.com/users/dcasbonne","html_url":"https://github.com/dcasbonne","followers_url":"https://api.github.com/users/dcasbonne/followers","following_url":"https://api.github.com/users/dcasbonne/following{/other_user}","gists_url":"https://api.github.com/users/dcasbonne/gists{/gist_id}","starred_url":"https://api.github.com/users/dcasbonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcasbonne/subscriptions","organizations_url":"https://api.github.com/users/dcasbonne/orgs","repos_url":"https://api.github.com/users/dcasbonne/repos","events_url":"https://api.github.com/users/dcasbonne/events{/privacy}","received_events_url":"https://api.github.com/users/dcasbonne/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":30,"created_at":"2018-02-05T12:31:31Z","updated_at":"2018-03-13T13:16:09Z","closed_at":null,"author_association":"NONE","body":"Hi,\r\n\r\nI spend 2 days trying to have shared code between mobile and web and then I find your seed. In one hour, everything was working fine !!! Thank you very much !!!\r\n\r\nDo you plan to upgrade the project to Angular 5 and NativeScript 3.4 ?\r\n\r\nI'm trying to do that but I'm too new to Angular and TNS for the moment...\r\n\r\nEDIT : I've upgraded all dependencies to their latest versions but I've 2 main problems :\r\n- navigation fails on mobile while working on Web\r\n- translation doesn't work anymore (home.title is written for example)\r\n\r\nThanks for your help !\r\n\r\nEDIT 2: \r\n- for translation, the error was on HttpClient due to NG5. I just used the new HttpClient / HttpClientModule for the Web and NativeScriptHttpClientModule / HttpClient in TNS and it works (updating also the imports and translateLoader function)\r\n\r\nEDIT 3 :\r\n- for navigation, we just have to add \"./\" before \"app\" in the lazy loaded routes. So, in \"home.routes.ts\", replace the route for \"about\" with \r\n```\r\nloadChildren: './app/+about/about.module#AboutModule'\r\n```\r\nThe only problem is that it only works for mobile, not for the web... \r\nFinally I have created a \"home.route.tns.ts\" with that type of links and there isn't any changes to \"home.routes.ts\".\r\n\r\nEverything is working now with all latest versions :)"},"comment":{"url":"https://api.github.com/repos/TeamMaestro/angular-native-seed/issues/comments/372661224","html_url":"https://github.com/TeamMaestro/angular-native-seed/issues/79#issuecomment-372661224","issue_url":"https://api.github.com/repos/TeamMaestro/angular-native-seed/issues/79","id":372661224,"user":{"login":"govi2010","id":8776031,"avatar_url":"https://avatars3.githubusercontent.com/u/8776031?v=4","gravatar_id":"","url":"https://api.github.com/users/govi2010","html_url":"https://github.com/govi2010","followers_url":"https://api.github.com/users/govi2010/followers","following_url":"https://api.github.com/users/govi2010/following{/other_user}","gists_url":"https://api.github.com/users/govi2010/gists{/gist_id}","starred_url":"https://api.github.com/users/govi2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govi2010/subscriptions","organizations_url":"https://api.github.com/users/govi2010/orgs","repos_url":"https://api.github.com/users/govi2010/repos","events_url":"https://api.github.com/users/govi2010/events{/privacy}","received_events_url":"https://api.github.com/users/govi2010/received_events","type":"User","site_admin":false},"created_at":"2018-03-13T13:16:09Z","updated_at":"2018-03-13T13:16:09Z","author_association":"NONE","body":"Nothing is useless, Everyone will try to survive. {N} will also try to survive. "}}
{"actor":{"display_login":"govi2010"}}