{"action":"closed","number":1239,"pull_request":{"url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/1239","id":227162464,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MTYyNDY0","html_url":"https://github.com/mozilla-mobile/android-components/pull/1239","diff_url":"https://github.com/mozilla-mobile/android-components/pull/1239.diff","patch_url":"https://github.com/mozilla-mobile/android-components/pull/1239.patch","issue_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/1239","number":1239,"state":"closed","locked":false,"title":"Request a key-bearing scope in FxA sample app.","user":{"login":"rfk","id":34695,"node_id":"MDQ6VXNlcjM0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/34695?v=4","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/mozilla-mobile/android-components/issues/1225\r\n\r\nIf you attempt to fetch keys via the FxA OAuth flow, but you don't request any scopes that actually *have* keys, then FxA bails out because something has probably gone very wrong in your app.  This updates the FxA sample app to request a key-bearing scope when the \"wants keys\" option is checked.","created_at":"2018-10-31T05:18:39Z","updated_at":"2018-10-31T14:45:04Z","closed_at":"2018-10-31T14:45:03Z","merged_at":"2018-10-31T14:45:03Z","merge_commit_sha":"0387986c0c34e2243b51e14af8906f72d65fe610","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1111143398,"node_id":"MDU6TGFiZWwxMTExMTQzMzk4","url":"https://api.github.com/repos/mozilla-mobile/android-components/labels/%F0%9F%95%B5%EF%B8%8F%E2%80%8D%E2%99%80%EF%B8%8F%20needs%20review","name":"🕵️‍♀️ needs review","color":"ffe0b2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/1239/commits","review_comments_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/1239/comments","review_comment_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/1239/comments","statuses_url":"https://api.github.com/repos/mozilla-mobile/android-components/statuses/ef8e12388ff09305e9f1d85522aff07760003007","head":{"label":"rfk:fxa-request-key-bearing-scope","ref":"fxa-request-key-bearing-scope","sha":"ef8e12388ff09305e9f1d85522aff07760003007","user":{"login":"rfk","id":34695,"node_id":"MDQ6VXNlcjM0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/34695?v=4","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"repo":{"id":155502462,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU1MDI0NjI=","name":"android-components","full_name":"rfk/android-components","private":false,"owner":{"login":"rfk","id":34695,"node_id":"MDQ6VXNlcjM0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/34695?v=4","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rfk/android-components","description":"A collection of Android libraries to build browsers or browser-like applications.","fork":true,"url":"https://api.github.com/repos/rfk/android-components","forks_url":"https://api.github.com/repos/rfk/android-components/forks","keys_url":"https://api.github.com/repos/rfk/android-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rfk/android-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rfk/android-components/teams","hooks_url":"https://api.github.com/repos/rfk/android-components/hooks","issue_events_url":"https://api.github.com/repos/rfk/android-components/issues/events{/number}","events_url":"https://api.github.com/repos/rfk/android-components/events","assignees_url":"https://api.github.com/repos/rfk/android-components/assignees{/user}","branches_url":"https://api.github.com/repos/rfk/android-components/branches{/branch}","tags_url":"https://api.github.com/repos/rfk/android-components/tags","blobs_url":"https://api.github.com/repos/rfk/android-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rfk/android-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rfk/android-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/rfk/android-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rfk/android-components/statuses/{sha}","languages_url":"https://api.github.com/repos/rfk/android-components/languages","stargazers_url":"https://api.github.com/repos/rfk/android-components/stargazers","contributors_url":"https://api.github.com/repos/rfk/android-components/contributors","subscribers_url":"https://api.github.com/repos/rfk/android-components/subscribers","subscription_url":"https://api.github.com/repos/rfk/android-components/subscription","commits_url":"https://api.github.com/repos/rfk/android-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/rfk/android-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/rfk/android-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/rfk/android-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/rfk/android-components/contents/{+path}","compare_url":"https://api.github.com/repos/rfk/android-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rfk/android-components/merges","archive_url":"https://api.github.com/repos/rfk/android-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rfk/android-components/downloads","issues_url":"https://api.github.com/repos/rfk/android-components/issues{/number}","pulls_url":"https://api.github.com/repos/rfk/android-components/pulls{/number}","milestones_url":"https://api.github.com/repos/rfk/android-components/milestones{/number}","notifications_url":"https://api.github.com/repos/rfk/android-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rfk/android-components/labels{/name}","releases_url":"https://api.github.com/repos/rfk/android-components/releases{/id}","deployments_url":"https://api.github.com/repos/rfk/android-components/deployments","created_at":"2018-10-31T05:14:55Z","updated_at":"2018-10-31T05:15:04Z","pushed_at":"2018-10-31T14:44:52Z","git_url":"git://github.com/rfk/android-components.git","ssh_url":"git@github.com:rfk/android-components.git","clone_url":"https://github.com/rfk/android-components.git","svn_url":"https://github.com/rfk/android-components","homepage":"https://mozilla-mobile.github.io/android-components/","size":37788,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-mobile:master","ref":"master","sha":"471b3de87ee765b1ffd2d67a617608fc45bb6d32","user":{"login":"mozilla-mobile","id":22351667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzUxNjY3","avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":126199585,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYxOTk1ODU=","name":"android-components","full_name":"mozilla-mobile/android-components","private":false,"owner":{"login":"mozilla-mobile","id":22351667,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzUxNjY3","avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mozilla-mobile/android-components","description":"A collection of Android libraries to build browsers or browser-like applications.","fork":false,"url":"https://api.github.com/repos/mozilla-mobile/android-components","forks_url":"https://api.github.com/repos/mozilla-mobile/android-components/forks","keys_url":"https://api.github.com/repos/mozilla-mobile/android-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-mobile/android-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-mobile/android-components/teams","hooks_url":"https://api.github.com/repos/mozilla-mobile/android-components/hooks","issue_events_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-mobile/android-components/events","assignees_url":"https://api.github.com/repos/mozilla-mobile/android-components/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-mobile/android-components/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-mobile/android-components/tags","blobs_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-mobile/android-components/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-mobile/android-components/languages","stargazers_url":"https://api.github.com/repos/mozilla-mobile/android-components/stargazers","contributors_url":"https://api.github.com/repos/mozilla-mobile/android-components/contributors","subscribers_url":"https://api.github.com/repos/mozilla-mobile/android-components/subscribers","subscription_url":"https://api.github.com/repos/mozilla-mobile/android-components/subscription","commits_url":"https://api.github.com/repos/mozilla-mobile/android-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-mobile/android-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-mobile/android-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-mobile/android-components/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-mobile/android-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-mobile/android-components/merges","archive_url":"https://api.github.com/repos/mozilla-mobile/android-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-mobile/android-components/downloads","issues_url":"https://api.github.com/repos/mozilla-mobile/android-components/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-mobile/android-components/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-mobile/android-components/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-mobile/android-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-mobile/android-components/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-mobile/android-components/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-mobile/android-components/deployments","created_at":"2018-03-21T15:24:03Z","updated_at":"2018-10-31T13:51:28Z","pushed_at":"2018-10-31T14:45:03Z","git_url":"git://github.com/mozilla-mobile/android-components.git","ssh_url":"git@github.com:mozilla-mobile/android-components.git","clone_url":"https://github.com/mozilla-mobile/android-components.git","svn_url":"https://github.com/mozilla-mobile/android-components","homepage":"https://mozilla-mobile.github.io/android-components/","size":37790,"stargazers_count":447,"watchers_count":447,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":91,"mirror_url":null,"archived":false,"open_issues_count":225,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":91,"open_issues":225,"watchers":447,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/1239"},"html":{"href":"https://github.com/mozilla-mobile/android-components/pull/1239"},"issue":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/issues/1239"},"comments":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/issues/1239/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/1239/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/pulls/1239/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-mobile/android-components/statuses/ef8e12388ff09305e9f1d85522aff07760003007"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"csadilek","id":472523,"node_id":"MDQ6VXNlcjQ3MjUyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/472523?v=4","gravatar_id":"","url":"https://api.github.com/users/csadilek","html_url":"https://github.com/csadilek","followers_url":"https://api.github.com/users/csadilek/followers","following_url":"https://api.github.com/users/csadilek/following{/other_user}","gists_url":"https://api.github.com/users/csadilek/gists{/gist_id}","starred_url":"https://api.github.com/users/csadilek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csadilek/subscriptions","organizations_url":"https://api.github.com/users/csadilek/orgs","repos_url":"https://api.github.com/users/csadilek/repos","events_url":"https://api.github.com/users/csadilek/events{/privacy}","received_events_url":"https://api.github.com/users/csadilek/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":4,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"csadilek"}}