{"action":"created","issue":{"url":"https://api.github.com/repos/google/mobly/issues/460","repository_url":"https://api.github.com/repos/google/mobly","labels_url":"https://api.github.com/repos/google/mobly/issues/460/labels{/name}","comments_url":"https://api.github.com/repos/google/mobly/issues/460/comments","events_url":"https://api.github.com/repos/google/mobly/issues/460/events","html_url":"https://github.com/google/mobly/pull/460","id":330849780,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzU2NjI2","number":460,"title":"Fix unicode encoding issues with records module.","user":{"login":"winterfroststrom","id":2516135,"node_id":"MDQ6VXNlcjI1MTYxMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/2516135?v=4","gravatar_id":"","url":"https://api.github.com/users/winterfroststrom","html_url":"https://github.com/winterfroststrom","followers_url":"https://api.github.com/users/winterfroststrom/followers","following_url":"https://api.github.com/users/winterfroststrom/following{/other_user}","gists_url":"https://api.github.com/users/winterfroststrom/gists{/gist_id}","starred_url":"https://api.github.com/users/winterfroststrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winterfroststrom/subscriptions","organizations_url":"https://api.github.com/users/winterfroststrom/orgs","repos_url":"https://api.github.com/users/winterfroststrom/repos","events_url":"https://api.github.com/users/winterfroststrom/events{/privacy}","received_events_url":"https://api.github.com/users/winterfroststrom/received_events","type":"User","site_admin":false},"labels":[{"id":477039421,"node_id":"MDU6TGFiZWw0NzcwMzk0MjE=","url":"https://api.github.com/repos/google/mobly/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":{"login":"winterfroststrom","id":2516135,"node_id":"MDQ6VXNlcjI1MTYxMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/2516135?v=4","gravatar_id":"","url":"https://api.github.com/users/winterfroststrom","html_url":"https://github.com/winterfroststrom","followers_url":"https://api.github.com/users/winterfroststrom/followers","following_url":"https://api.github.com/users/winterfroststrom/following{/other_user}","gists_url":"https://api.github.com/users/winterfroststrom/gists{/gist_id}","starred_url":"https://api.github.com/users/winterfroststrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winterfroststrom/subscriptions","organizations_url":"https://api.github.com/users/winterfroststrom/orgs","repos_url":"https://api.github.com/users/winterfroststrom/repos","events_url":"https://api.github.com/users/winterfroststrom/events{/privacy}","received_events_url":"https://api.github.com/users/winterfroststrom/received_events","type":"User","site_admin":false},"assignees":[{"login":"winterfroststrom","id":2516135,"node_id":"MDQ6VXNlcjI1MTYxMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/2516135?v=4","gravatar_id":"","url":"https://api.github.com/users/winterfroststrom","html_url":"https://github.com/winterfroststrom","followers_url":"https://api.github.com/users/winterfroststrom/followers","following_url":"https://api.github.com/users/winterfroststrom/following{/other_user}","gists_url":"https://api.github.com/users/winterfroststrom/gists{/gist_id}","starred_url":"https://api.github.com/users/winterfroststrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winterfroststrom/subscriptions","organizations_url":"https://api.github.com/users/winterfroststrom/orgs","repos_url":"https://api.github.com/users/winterfroststrom/repos","events_url":"https://api.github.com/users/winterfroststrom/events{/privacy}","received_events_url":"https://api.github.com/users/winterfroststrom/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-06-09T03:44:07Z","updated_at":"2018-06-11T20:34:40Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/google/mobly/pulls/460","html_url":"https://github.com/google/mobly/pull/460","diff_url":"https://github.com/google/mobly/pull/460.diff","patch_url":"https://github.com/google/mobly/pull/460.patch"},"body":"Part of #459\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/google/mobly/460)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/google/mobly/issues/comments/396377871","html_url":"https://github.com/google/mobly/pull/460#issuecomment-396377871","issue_url":"https://api.github.com/repos/google/mobly/issues/460","id":396377871,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjM3Nzg3MQ==","user":{"login":"xpconanfan","id":2242277,"node_id":"MDQ6VXNlcjIyNDIyNzc=","avatar_url":"https://avatars3.githubusercontent.com/u/2242277?v=4","gravatar_id":"","url":"https://api.github.com/users/xpconanfan","html_url":"https://github.com/xpconanfan","followers_url":"https://api.github.com/users/xpconanfan/followers","following_url":"https://api.github.com/users/xpconanfan/following{/other_user}","gists_url":"https://api.github.com/users/xpconanfan/gists{/gist_id}","starred_url":"https://api.github.com/users/xpconanfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpconanfan/subscriptions","organizations_url":"https://api.github.com/users/xpconanfan/orgs","repos_url":"https://api.github.com/users/xpconanfan/repos","events_url":"https://api.github.com/users/xpconanfan/events{/privacy}","received_events_url":"https://api.github.com/users/xpconanfan/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T20:34:40Z","updated_at":"2018-06-11T20:34:40Z","author_association":"COLLABORATOR","body":"\n\n\n\nReview status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @xpconanfan)\n\n---\n\n*[mobly/records.py, line 122 at r1](https://reviewable.io/reviews/google/mobly/460#-LEkVJwA-Kvdl5T1usIn:-LEkYSYV-8lhFw1ZnexV:b-sngt1k) ([raw file](https://github.com/google/mobly/blob/682a2ffccbd86ff445e4e7d1c08cf32a7626b5c0/mobly/records.py#L122)):*\n<details><summary><i>Previously, winterfroststrom wrote…</i></summary><blockquote>\n\nChanged\n</blockquote></details>\n\n\"setting the encoding on yaml.safe_dump\"\nbut we never did that?\n\nSo it is a bit odd to mention this option here...\n\nAlso should we move this comment block to before the `with open`?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/google/mobly/460)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"xpconanfan"}}