{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/188959290","pull_request_review_id":121042769,"id":188959290,"diff_hunk":"@@ -837,6 +839,7 @@ case class ArrayMin(child: Expression) extends UnaryExpression with ImplicitCast\n \n   override def inputTypes: Seq[AbstractDataType] = Seq(ArrayType)\n \n+  @transient","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala","position":24,"original_position":24,"commit_id":"e96962e831a35f61e113e27c38e573a9b4d3ddc2","original_commit_id":"e96962e831a35f61e113e27c38e573a9b4d3ddc2","user":{"login":"mn-mikke","id":3674621,"avatar_url":"https://avatars3.githubusercontent.com/u/3674621?v=4","gravatar_id":"","url":"https://api.github.com/users/mn-mikke","html_url":"https://github.com/mn-mikke","followers_url":"https://api.github.com/users/mn-mikke/followers","following_url":"https://api.github.com/users/mn-mikke/following{/other_user}","gists_url":"https://api.github.com/users/mn-mikke/gists{/gist_id}","starred_url":"https://api.github.com/users/mn-mikke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mn-mikke/subscriptions","organizations_url":"https://api.github.com/users/mn-mikke/orgs","repos_url":"https://api.github.com/users/mn-mikke/repos","events_url":"https://api.github.com/users/mn-mikke/events{/privacy}","received_events_url":"https://api.github.com/users/mn-mikke/received_events","type":"User","site_admin":false},"body":"Yeah, here it isn't necessary.","created_at":"2018-05-17T13:36:57Z","updated_at":"2018-05-17T13:36:57Z","html_url":"https://github.com/apache/spark/pull/21352#discussion_r188959290","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/21352","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/188959290"},"html":{"href":"https://github.com/apache/spark/pull/21352#discussion_r188959290"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/21352"}},"in_reply_to_id":188952300},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/21352","id":188712558,"html_url":"https://github.com/apache/spark/pull/21352","diff_url":"https://github.com/apache/spark/pull/21352.diff","patch_url":"https://github.com/apache/spark/pull/21352.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/21352","number":21352,"state":"open","locked":false,"title":"[SPARK-24305][SQL][FOLLOWUP] Avoid serialization of private fields in collection expressions.","user":{"login":"mn-mikke","id":3674621,"avatar_url":"https://avatars3.githubusercontent.com/u/3674621?v=4","gravatar_id":"","url":"https://api.github.com/users/mn-mikke","html_url":"https://github.com/mn-mikke","followers_url":"https://api.github.com/users/mn-mikke/followers","following_url":"https://api.github.com/users/mn-mikke/following{/other_user}","gists_url":"https://api.github.com/users/mn-mikke/gists{/gist_id}","starred_url":"https://api.github.com/users/mn-mikke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mn-mikke/subscriptions","organizations_url":"https://api.github.com/users/mn-mikke/orgs","repos_url":"https://api.github.com/users/mn-mikke/repos","events_url":"https://api.github.com/users/mn-mikke/events{/privacy}","received_events_url":"https://api.github.com/users/mn-mikke/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nThe PR tries to avoid serialization of private fields of already added collection functions and follows up on comments in [SPARK-23922](https://github.com/apache/spark/pull/21028) and [SPARK-23935](https://github.com/apache/spark/pull/21236)\r\n\r\n## How was this patch tested?\r\n\r\nRun tests from:\r\n- CollectionExpressionSuite.scala\r\n- DataFrameFunctionsSuite.scala\r\n\r\n","created_at":"2018-05-17T11:56:53Z","updated_at":"2018-05-17T13:36:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22bd26806343a07acc96d0f1cff95d027b2eb5a1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/21352/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/21352/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/21352/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/e96962e831a35f61e113e27c38e573a9b4d3ddc2","head":{"label":"mn-mikke:SPARK-24305","ref":"SPARK-24305","sha":"e96962e831a35f61e113e27c38e573a9b4d3ddc2","user":{"login":"mn-mikke","id":3674621,"avatar_url":"https://avatars3.githubusercontent.com/u/3674621?v=4","gravatar_id":"","url":"https://api.github.com/users/mn-mikke","html_url":"https://github.com/mn-mikke","followers_url":"https://api.github.com/users/mn-mikke/followers","following_url":"https://api.github.com/users/mn-mikke/following{/other_user}","gists_url":"https://api.github.com/users/mn-mikke/gists{/gist_id}","starred_url":"https://api.github.com/users/mn-mikke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mn-mikke/subscriptions","organizations_url":"https://api.github.com/users/mn-mikke/orgs","repos_url":"https://api.github.com/users/mn-mikke/repos","events_url":"https://api.github.com/users/mn-mikke/events{/privacy}","received_events_url":"https://api.github.com/users/mn-mikke/received_events","type":"User","site_admin":false},"repo":{"id":116154315,"name":"spark","full_name":"mn-mikke/spark","owner":{"login":"mn-mikke","id":3674621,"avatar_url":"https://avatars3.githubusercontent.com/u/3674621?v=4","gravatar_id":"","url":"https://api.github.com/users/mn-mikke","html_url":"https://github.com/mn-mikke","followers_url":"https://api.github.com/users/mn-mikke/followers","following_url":"https://api.github.com/users/mn-mikke/following{/other_user}","gists_url":"https://api.github.com/users/mn-mikke/gists{/gist_id}","starred_url":"https://api.github.com/users/mn-mikke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mn-mikke/subscriptions","organizations_url":"https://api.github.com/users/mn-mikke/orgs","repos_url":"https://api.github.com/users/mn-mikke/repos","events_url":"https://api.github.com/users/mn-mikke/events{/privacy}","received_events_url":"https://api.github.com/users/mn-mikke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mn-mikke/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/mn-mikke/spark","forks_url":"https://api.github.com/repos/mn-mikke/spark/forks","keys_url":"https://api.github.com/repos/mn-mikke/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mn-mikke/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mn-mikke/spark/teams","hooks_url":"https://api.github.com/repos/mn-mikke/spark/hooks","issue_events_url":"https://api.github.com/repos/mn-mikke/spark/issues/events{/number}","events_url":"https://api.github.com/repos/mn-mikke/spark/events","assignees_url":"https://api.github.com/repos/mn-mikke/spark/assignees{/user}","branches_url":"https://api.github.com/repos/mn-mikke/spark/branches{/branch}","tags_url":"https://api.github.com/repos/mn-mikke/spark/tags","blobs_url":"https://api.github.com/repos/mn-mikke/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mn-mikke/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mn-mikke/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/mn-mikke/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mn-mikke/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/mn-mikke/spark/languages","stargazers_url":"https://api.github.com/repos/mn-mikke/spark/stargazers","contributors_url":"https://api.github.com/repos/mn-mikke/spark/contributors","subscribers_url":"https://api.github.com/repos/mn-mikke/spark/subscribers","subscription_url":"https://api.github.com/repos/mn-mikke/spark/subscription","commits_url":"https://api.github.com/repos/mn-mikke/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/mn-mikke/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/mn-mikke/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/mn-mikke/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/mn-mikke/spark/contents/{+path}","compare_url":"https://api.github.com/repos/mn-mikke/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mn-mikke/spark/merges","archive_url":"https://api.github.com/repos/mn-mikke/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mn-mikke/spark/downloads","issues_url":"https://api.github.com/repos/mn-mikke/spark/issues{/number}","pulls_url":"https://api.github.com/repos/mn-mikke/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/mn-mikke/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/mn-mikke/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mn-mikke/spark/labels{/name}","releases_url":"https://api.github.com/repos/mn-mikke/spark/releases{/id}","deployments_url":"https://api.github.com/repos/mn-mikke/spark/deployments","created_at":"2018-01-03T15:48:07Z","updated_at":"2018-04-21T15:37:46Z","pushed_at":"2018-05-17T12:58:20Z","git_url":"git://github.com/mn-mikke/spark.git","ssh_url":"git@github.com:mn-mikke/spark.git","clone_url":"https://github.com/mn-mikke/spark.git","svn_url":"https://github.com/mn-mikke/spark","homepage":null,"size":269137,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"6c35865d949a8b46f654cd53c7e5f3288def18d0","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-05-17T12:49:05Z","pushed_at":"2018-05-17T13:34:17Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":270363,"stargazers_count":17312,"watchers_count":17312,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15840,"mirror_url":null,"archived":false,"open_issues_count":535,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15840,"open_issues":535,"watchers":17312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/21352"},"html":{"href":"https://github.com/apache/spark/pull/21352"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/21352"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/21352/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/21352/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/21352/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/e96962e831a35f61e113e27c38e573a9b4d3ddc2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mn-mikke"}}