{"action":"created","issue":{"url":"https://api.github.com/repos/google/kythe/issues/2580","repository_url":"https://api.github.com/repos/google/kythe","labels_url":"https://api.github.com/repos/google/kythe/issues/2580/labels{/name}","comments_url":"https://api.github.com/repos/google/kythe/issues/2580/comments","events_url":"https://api.github.com/repos/google/kythe/issues/2580/events","html_url":"https://github.com/google/kythe/issues/2580","id":335654562,"node_id":"MDU6SXNzdWUzMzU2NTQ1NjI=","number":2580,"title":"Updates to support recent Bazel releases. [phab:D2122]","user":{"login":"kythe","id":10677145,"node_id":"MDQ6VXNlcjEwNjc3MTQ1","avatar_url":"https://avatars2.githubusercontent.com/u/10677145?v=4","gravatar_id":"","url":"https://api.github.com/users/kythe","html_url":"https://github.com/kythe","followers_url":"https://api.github.com/users/kythe/followers","following_url":"https://api.github.com/users/kythe/following{/other_user}","gists_url":"https://api.github.com/users/kythe/gists{/gist_id}","starred_url":"https://api.github.com/users/kythe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kythe/subscriptions","organizations_url":"https://api.github.com/users/kythe/orgs","repos_url":"https://api.github.com/users/kythe/repos","events_url":"https://api.github.com/users/kythe/events{/privacy}","received_events_url":"https://api.github.com/users/kythe/received_events","type":"User","site_admin":false},"labels":[{"id":932824657,"node_id":"MDU6TGFiZWw5MzI4MjQ2NTc=","url":"https://api.github.com/repos/google/kythe/labels/phabricator%20diff","name":"phabricator diff","color":"efd57f","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-26T04:26:47Z","updated_at":"2018-06-28T08:29:22Z","closed_at":"2018-06-26T04:26:49Z","author_association":"COLLABORATOR","body":"_Created by **fromberger** at 2018-01-17 20:52:37_: \n\nThis change primarily addresses #2405, which unblock the use of Bazel versions\nmore recent than 0.7.0. Unfortunately this required several interlocking\nchanges that cannot be easily separated. In brief, the changes are:\n\n- Replace our custom protobuf and Go rules with upstream rules.\n  We now use \"native\" aspect-driven proto_library and the Go rules from\n  https://github.com/bazelbuild/rules_go.\n\n- Update the version of the protobuf toolchain to 3.5.1.1.\n  Add C++ and Java proto toolchains.\n  Add bindings for gson and guava required by those external repos.\n  Fixes to make the protobuf repo work with zlib.\n  (see https://github.com/google/protobuf/issues/2365)\n\n- Update the Go toolchain (allowing Go 1.9, finally).\n\n- Update all our proto_library rules. This will require us to update the tool\n  that generates our proto libraries for \"go get\", but I have not included that\n  in this change.\n\n  With this change, per-language generation is handled by separate aspects.\n  Add language-specific rules for C++, Go, and Java.\n\n- Disable the Go unit test macros. These will have to be entirely rewritten, as\n  the internal plumbing of the upstream rules is new. I'll address that in a\n  future change, soon.\n\nThese changes now require Bazel ≥ 0.8.0.\n\nThe upstream Go rules broke many of our tests that were based on the sh_test\nrule.  To address this, add a shell_tool_test macro that simplifies the\nplumbing needed to pass tool paths in to the shell tests, without having to\nentirely rewrite them.  All our sh_test rules that depended on Go binaries are\nnow updated."},"comment":{"url":"https://api.github.com/repos/google/kythe/issues/comments/400955671","html_url":"https://github.com/google/kythe/issues/2580#issuecomment-400955671","issue_url":"https://api.github.com/repos/google/kythe/issues/2580","id":400955671,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDk1NTY3MQ==","user":{"login":"kythe","id":10677145,"node_id":"MDQ6VXNlcjEwNjc3MTQ1","avatar_url":"https://avatars2.githubusercontent.com/u/10677145?v=4","gravatar_id":"","url":"https://api.github.com/users/kythe","html_url":"https://github.com/kythe","followers_url":"https://api.github.com/users/kythe/followers","following_url":"https://api.github.com/users/kythe/following{/other_user}","gists_url":"https://api.github.com/users/kythe/gists{/gist_id}","starred_url":"https://api.github.com/users/kythe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kythe/subscriptions","organizations_url":"https://api.github.com/users/kythe/orgs","repos_url":"https://api.github.com/users/kythe/repos","events_url":"https://api.github.com/users/kythe/events{/privacy}","received_events_url":"https://api.github.com/users/kythe/received_events","type":"User","site_admin":false},"created_at":"2018-06-28T08:29:22Z","updated_at":"2018-06-28T08:29:22Z","author_association":"COLLABORATOR","body":"_**schroederc** commented inline (context lost during migration) at 2018-01-17 21:28:57_:\n\nI believe the above `build` config implies this `test` one."}}
{"actor":{"display_login":"kythe"}}