{"action":"created","issue":{"url":"https://api.github.com/repos/apache/metron/issues/1226","repository_url":"https://api.github.com/repos/apache/metron","labels_url":"https://api.github.com/repos/apache/metron/issues/1226/labels{/name}","comments_url":"https://api.github.com/repos/apache/metron/issues/1226/comments","events_url":"https://api.github.com/repos/apache/metron/issues/1226/events","html_url":"https://github.com/apache/metron/pull/1226","id":367170687,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNjcwMzE3","number":1226,"title":"METRON-1803: Integrate Cypress with Travis","user":{"login":"tiborm","id":2437400,"node_id":"MDQ6VXNlcjI0Mzc0MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2437400?v=4","gravatar_id":"","url":"https://api.github.com/users/tiborm","html_url":"https://github.com/tiborm","followers_url":"https://api.github.com/users/tiborm/followers","following_url":"https://api.github.com/users/tiborm/following{/other_user}","gists_url":"https://api.github.com/users/tiborm/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborm/subscriptions","organizations_url":"https://api.github.com/users/tiborm/orgs","repos_url":"https://api.github.com/users/tiborm/repos","events_url":"https://api.github.com/users/tiborm/events{/privacy}","received_events_url":"https://api.github.com/users/tiborm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-05T11:29:16Z","updated_at":"2018-10-17T08:17:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/metron/pulls/1226","html_url":"https://github.com/apache/metron/pull/1226","diff_url":"https://github.com/apache/metron/pull/1226.diff","patch_url":"https://github.com/apache/metron/pull/1226.patch"},"body":"## Contributor Comments\r\n\r\n[DISCUSS] thread on the dev mailing list: \r\nhttps://lists.apache.org/thread.html/b6a0272c7809c05e8b7aff20171720e8ec76f8a0e9481169c37a4a4a@%3Cdev.metron.apache.org%3E\r\n\r\nJIRA Ticket: https://issues.apache.org/jira/browse/METRON-1803\r\n\r\nThis PR adds Cypress.io to our project. It makes us able to run E2E tests, UI integration tests. Also higher level UI tests with mocked services. \r\nAs part of this PR I added tests to cover the following functionalities of PCAP UI panel:\r\n\r\n- checking running jobs on navigating to PCAP tab\r\n- submitting PCAP job request\r\n- requesting job status\r\n- process status in percentage\r\n- getting PCAP JSON\r\n- rendering PCAP table\r\n- showing PCAP details\r\n- navigating across pages\r\n- downloading PDML\r\n- cancelli PCAP query job\r\n- showing filter validation messages\r\n- showing date validation messages\r\n\r\nPlease consider while reviewing that these tests are not meant to cover all the details of the functionalities above. The aim here is to extend the test coverage build up by a large number of Unit Tests with higher level UI tests.\r\n\r\n### New folders\r\n\r\n#### Integration folder\r\nThat contains the actual Cypress tests. The folder name comes from the Cypress naming convention, however, no real integration tests implemented here yet (at least no other than the integration of UI components to a whole application). We could change the name of the folder anytime we like to, but only one folder applicable.\r\n\r\n#### Fixture folder\r\nThe tests are running on mocked data. This makes us able to integrate them with Travis without the need to having PCAP related services available from our CI.\r\nEach file in the Fixture folder represents a response to a particular request. This makes it fairly easy to create and maintain.\r\n\r\n### How to run tests on your local machine\r\nTo run Cypress tests locally please do the following:\r\n1. pull this branch to your workspace\r\n2. move to metron-interface/metron-alerts folder\r\n3. run: npm ci\r\n4. run: scripts/start-server-for-e2e.sh\r\n5. run: node_modules/cypress/bin/cypress run\r\n    or run: node_modules/cypress/bin/cypress open\r\n    if you like to use the dashboard.\r\n\r\n### Travis integration\r\nAs part of this PR I modified the package.json in metron-alert to make Cypress running in Travis. If you like to see the integration working please check to logs of build step #3.\r\nFailing Cypress tests brakes the build.\r\n\r\nExample of build broken by failing Cypress test: \r\nhttps://travis-ci.com/tiborm/metron/builds/86869264\r\n\r\n\r\n## Pull Request Checklist\r\n\r\nThank you for submitting a contribution to Apache Metron.  \r\nPlease refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  \r\nPlease refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  \r\n\r\n\r\nIn order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).\r\n- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n\r\n### For code changes:\r\n- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?\r\n- [x] Have you included steps or a guide to how the change may be verified and tested manually?\r\n- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:\r\n  ```\r\n  mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh \r\n  ```\r\n\r\n- [x] Have you written or updated unit tests and or integration tests to verify your changes?\r\n- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?\r\n\r\n### For documentation related changes:\r\n- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:\r\n\r\n  ```\r\n  cd site-book\r\n  mvn site\r\n  ```\r\n\r\n#### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.\r\nIt is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/metron/issues/comments/430534140","html_url":"https://github.com/apache/metron/pull/1226#issuecomment-430534140","issue_url":"https://api.github.com/repos/apache/metron/issues/1226","id":430534140,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDUzNDE0MA==","user":{"login":"tiborm","id":2437400,"node_id":"MDQ6VXNlcjI0Mzc0MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2437400?v=4","gravatar_id":"","url":"https://api.github.com/users/tiborm","html_url":"https://github.com/tiborm","followers_url":"https://api.github.com/users/tiborm/followers","following_url":"https://api.github.com/users/tiborm/following{/other_user}","gists_url":"https://api.github.com/users/tiborm/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborm/subscriptions","organizations_url":"https://api.github.com/users/tiborm/orgs","repos_url":"https://api.github.com/users/tiborm/repos","events_url":"https://api.github.com/users/tiborm/events{/privacy}","received_events_url":"https://api.github.com/users/tiborm/received_events","type":"User","site_admin":false},"created_at":"2018-10-17T08:17:19Z","updated_at":"2018-10-17T08:17:19Z","author_association":"CONTRIBUTOR","body":"@mmiklavc Yes, that's the main file. Cypress.conf.json contains 4 line of configs and package.json 3 lines of changes required by the integration. Anything else is test response data."}}
{"actor":{"display_login":"tiborm"}}