{"action":"created","issue":{"url":"https://api.github.com/repos/golang/go/issues/23918","repository_url":"https://api.github.com/repos/golang/go","labels_url":"https://api.github.com/repos/golang/go/issues/23918/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/23918/comments","events_url":"https://api.github.com/repos/golang/go/issues/23918/events","html_url":"https://github.com/golang/go/issues/23918","id":298182751,"number":23918,"title":"os: TestMkdirAll failing Plan 9","user":{"login":"0intro","id":6043744,"avatar_url":"https://avatars3.githubusercontent.com/u/6043744?v=4","gravatar_id":"","url":"https://api.github.com/users/0intro","html_url":"https://github.com/0intro","followers_url":"https://api.github.com/users/0intro/followers","following_url":"https://api.github.com/users/0intro/following{/other_user}","gists_url":"https://api.github.com/users/0intro/gists{/gist_id}","starred_url":"https://api.github.com/users/0intro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0intro/subscriptions","organizations_url":"https://api.github.com/users/0intro/orgs","repos_url":"https://api.github.com/users/0intro/repos","events_url":"https://api.github.com/users/0intro/events{/privacy}","received_events_url":"https://api.github.com/users/0intro/received_events","type":"User","site_admin":false},"labels":[{"id":199753808,"url":"https://api.github.com/repos/golang/go/labels/OS-Plan9","name":"OS-Plan9","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"0intro","id":6043744,"avatar_url":"https://avatars3.githubusercontent.com/u/6043744?v=4","gravatar_id":"","url":"https://api.github.com/users/0intro","html_url":"https://github.com/0intro","followers_url":"https://api.github.com/users/0intro/followers","following_url":"https://api.github.com/users/0intro/following{/other_user}","gists_url":"https://api.github.com/users/0intro/gists{/gist_id}","starred_url":"https://api.github.com/users/0intro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0intro/subscriptions","organizations_url":"https://api.github.com/users/0intro/orgs","repos_url":"https://api.github.com/users/0intro/repos","events_url":"https://api.github.com/users/0intro/events{/privacy}","received_events_url":"https://api.github.com/users/0intro/received_events","type":"User","site_admin":false},"assignees":[{"login":"0intro","id":6043744,"avatar_url":"https://avatars3.githubusercontent.com/u/6043744?v=4","gravatar_id":"","url":"https://api.github.com/users/0intro","html_url":"https://github.com/0intro","followers_url":"https://api.github.com/users/0intro/followers","following_url":"https://api.github.com/users/0intro/following{/other_user}","gists_url":"https://api.github.com/users/0intro/gists{/gist_id}","starred_url":"https://api.github.com/users/0intro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0intro/subscriptions","organizations_url":"https://api.github.com/users/0intro/orgs","repos_url":"https://api.github.com/users/0intro/repos","events_url":"https://api.github.com/users/0intro/events{/privacy}","received_events_url":"https://api.github.com/users/0intro/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/golang/go/milestones/62","html_url":"https://github.com/golang/go/milestone/62","labels_url":"https://api.github.com/repos/golang/go/milestones/62/labels","id":2827591,"number":62,"title":"Go1.11","description":"","creator":{"login":"rsc","id":104030,"avatar_url":"https://avatars1.githubusercontent.com/u/104030?v=4","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"open_issues":769,"closed_issues":115,"state":"open","created_at":"2017-10-10T13:39:17Z","updated_at":"2018-02-19T07:31:46Z","due_on":"2018-07-31T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-02-19T07:31:46Z","updated_at":"2018-02-19T09:35:27Z","closed_at":null,"author_association":"MEMBER","body":"Since CL [86295](https://golang.org/cl/86295), TestMkdirAll is failing on Plan 9.\r\n\r\n```\r\n--- FAIL: TestMkdirAll (0.01s)\r\n\tpath_test.go:67: MkdirAll \"/tmp/_TestMkdirAll_/dir/./dir2/file/subdir\" returned wrong error path: \"/tmp/_TestMkdirAll_/dir/dir2/file/subdir\" not \"/tmp/_TestMkdirAll_/dir/dir2/file\"\r\nFAIL\r\nFAIL\tos\t1.734s\r\n```\r\n\r\nSee https://build.golang.org/log/b073356bfd34ac9b38f472e8ba905e166cd383c6"},"comment":{"url":"https://api.github.com/repos/golang/go/issues/comments/366634278","html_url":"https://github.com/golang/go/issues/23918#issuecomment-366634278","issue_url":"https://api.github.com/repos/golang/go/issues/23918","id":366634278,"user":{"login":"0intro","id":6043744,"avatar_url":"https://avatars3.githubusercontent.com/u/6043744?v=4","gravatar_id":"","url":"https://api.github.com/users/0intro","html_url":"https://github.com/0intro","followers_url":"https://api.github.com/users/0intro/followers","following_url":"https://api.github.com/users/0intro/following{/other_user}","gists_url":"https://api.github.com/users/0intro/gists{/gist_id}","starred_url":"https://api.github.com/users/0intro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0intro/subscriptions","organizations_url":"https://api.github.com/users/0intro/orgs","repos_url":"https://api.github.com/users/0intro/repos","events_url":"https://api.github.com/users/0intro/events{/privacy}","received_events_url":"https://api.github.com/users/0intro/received_events","type":"User","site_admin":false},"created_at":"2018-02-19T09:35:27Z","updated_at":"2018-02-19T09:35:27Z","author_association":"MEMBER","body":"Before the change:\r\n\r\n```\r\n% go test -v -run  '^TestMkdirAll$'\r\n=== RUN   TestMkdirAll\r\n/tmp is a directory\r\nMkdir /tmp/_TestMkdirAll_\r\nMkdir /tmp/_TestMkdirAll_/dir\r\nMkdir /tmp/_TestMkdirAll_/dir/.\r\nMkdir /tmp/_TestMkdirAll_/dir/./dir2\r\n/tmp/_TestMkdirAll_/dir/./dir2 is a directory\r\n/tmp/_TestMkdirAll_/dir/./dir2/file is a file\r\n/tmp/_TestMkdirAll_/dir/./dir2/file is a file\r\n--- PASS: TestMkdirAll (0.01s)\r\nPASS\r\nok  \tos\t0.052s\r\n```\r\n\r\nAfter the change:\r\n\r\n```\r\n% go test -v -run  '^TestMkdirAll$'\r\n=== RUN   TestMkdirAll\r\n/tmp/ is a directory\r\nMkdir /tmp/_TestMkdirAll_/\r\nMkdir /tmp/_TestMkdirAll_/dir/\r\nMkdir /tmp/_TestMkdirAll_/dir/./\r\nMkdir /tmp/_TestMkdirAll_/dir/./dir2\r\n/tmp/_TestMkdirAll_/dir/./dir2 is a directory\r\n/tmp/_TestMkdirAll_/dir/./dir2/file is a file\r\n/tmp/_TestMkdirAll_/dir/./dir2/ is a directory\r\nMkdir /tmp/_TestMkdirAll_/dir/./dir2/file/\r\nMkdir /tmp/_TestMkdirAll_/dir/./dir2/file/subdir\r\n--- FAIL: TestMkdirAll (0.02s)\r\n\tpath_test.go:67: MkdirAll \"/tmp/_TestMkdirAll_/dir/./dir2/file/subdir\" returned wrong error path: \"/tmp/_TestMkdirAll_/dir/dir2/file/subdir\" not \"/tmp/_TestMkdirAll_/dir/dir2/file\"\r\nFAIL\r\nexit status: 'os.test 374140: 1'\r\nFAIL\tos\t0.057s\r\n```\r\n\r\nThis issues emphases a specific behavior on Plan 9. It can be reproduced this way:\r\n\r\n```\r\n% mkdir -p /tmp/_TestMkdirAll_/dir/./dir2\r\n% > /tmp/_TestMkdirAll_/dir/./dir2/file\r\n% mkdir /tmp/_TestMkdirAll_/dir/./dir2/file/\r\n% mkdir /tmp/_TestMkdirAll_/dir/./dir2/file\r\nmkdir: /tmp/_TestMkdirAll_/dir/./dir2/file already exists\r\n```\r\n\r\nMkdir(\"file\") will return an error, while Mkdir(\"file/\") won't."}}
{"actor":{"display_login":"0intro"}}