{"action":"created","comment":{"url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/pulls/comments/176478555","pull_request_review_id":106188807,"id":176478555,"diff_hunk":"@@ -542,9 +542,7 @@ public class RingNode : StorageChannels\n \n         override protected void recycleStorageEngine ( StorageEngine storage )\n         {\n-            auto ring = cast(Ring)storage;\n-            assert(ring);\n-            this.outer.storage_pool.recycle(ring);\n+            this.outer.storage_pool.recycle(downcastAssert!(Ring)(storage));","path":"src/dmqnode/storage/Ring.d","position":31,"original_position":7,"commit_id":"340aa791643bca5aa50e3867c164a6bc3bbeabdb","original_commit_id":"4fc52680f2645744878e52cbf02bc67875022ac5","user":{"login":"david-eckardt-sociomantic","id":2952846,"avatar_url":"https://avatars3.githubusercontent.com/u/2952846?v=4","gravatar_id":"","url":"https://api.github.com/users/david-eckardt-sociomantic","html_url":"https://github.com/david-eckardt-sociomantic","followers_url":"https://api.github.com/users/david-eckardt-sociomantic/followers","following_url":"https://api.github.com/users/david-eckardt-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/david-eckardt-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/david-eckardt-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-eckardt-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/david-eckardt-sociomantic/orgs","repos_url":"https://api.github.com/users/david-eckardt-sociomantic/repos","events_url":"https://api.github.com/users/david-eckardt-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/david-eckardt-sociomantic/received_events","type":"User","site_admin":false},"body":"Yes.","created_at":"2018-03-22T16:06:38Z","updated_at":"2018-03-22T16:06:38Z","html_url":"https://github.com/sociomantic-tsunami/dmqnode/pull/43#discussion_r176478555","pull_request_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/pulls/43","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/pulls/comments/176478555"},"html":{"href":"https://github.com/sociomantic-tsunami/dmqnode/pull/43#discussion_r176478555"},"pull_request":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/pulls/43"}},"in_reply_to_id":176426007},"pull_request":{"url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/pulls/43","id":176561460,"html_url":"https://github.com/sociomantic-tsunami/dmqnode/pull/43","diff_url":"https://github.com/sociomantic-tsunami/dmqnode/pull/43.diff","patch_url":"https://github.com/sociomantic-tsunami/dmqnode/pull/43.patch","issue_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/issues/43","number":43,"state":"open","locked":false,"title":"Convert assert to verify/enforce","user":{"login":"david-eckardt-sociomantic","id":2952846,"avatar_url":"https://avatars3.githubusercontent.com/u/2952846?v=4","gravatar_id":"","url":"https://api.github.com/users/david-eckardt-sociomantic","html_url":"https://github.com/david-eckardt-sociomantic","followers_url":"https://api.github.com/users/david-eckardt-sociomantic/followers","following_url":"https://api.github.com/users/david-eckardt-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/david-eckardt-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/david-eckardt-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-eckardt-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/david-eckardt-sociomantic/orgs","repos_url":"https://api.github.com/users/david-eckardt-sociomantic/repos","events_url":"https://api.github.com/users/david-eckardt-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/david-eckardt-sociomantic/received_events","type":"User","site_admin":false},"body":"There is still a lot of internal `assert`s which are for debugging only so the D2 behaviour -- debug builds terminate and production builds omit them -- is suitable for these.","created_at":"2018-03-21T17:55:15Z","updated_at":"2018-03-22T16:06:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9a42fa1ac6a071c2865e9a295bfdd3cdd0efefc","assignee":{"login":"david-eckardt-sociomantic","id":2952846,"avatar_url":"https://avatars3.githubusercontent.com/u/2952846?v=4","gravatar_id":"","url":"https://api.github.com/users/david-eckardt-sociomantic","html_url":"https://github.com/david-eckardt-sociomantic","followers_url":"https://api.github.com/users/david-eckardt-sociomantic/followers","following_url":"https://api.github.com/users/david-eckardt-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/david-eckardt-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/david-eckardt-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-eckardt-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/david-eckardt-sociomantic/orgs","repos_url":"https://api.github.com/users/david-eckardt-sociomantic/repos","events_url":"https://api.github.com/users/david-eckardt-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/david-eckardt-sociomantic/received_events","type":"User","site_admin":false},"assignees":[{"login":"david-eckardt-sociomantic","id":2952846,"avatar_url":"https://avatars3.githubusercontent.com/u/2952846?v=4","gravatar_id":"","url":"https://api.github.com/users/david-eckardt-sociomantic","html_url":"https://github.com/david-eckardt-sociomantic","followers_url":"https://api.github.com/users/david-eckardt-sociomantic/followers","following_url":"https://api.github.com/users/david-eckardt-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/david-eckardt-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/david-eckardt-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-eckardt-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/david-eckardt-sociomantic/orgs","repos_url":"https://api.github.com/users/david-eckardt-sociomantic/repos","events_url":"https://api.github.com/users/david-eckardt-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/david-eckardt-sociomantic/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/pulls/43/commits","review_comments_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/pulls/43/comments","review_comment_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/issues/43/comments","statuses_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/statuses/340aa791643bca5aa50e3867c164a6bc3bbeabdb","head":{"label":"david-eckardt-sociomantic:verify","ref":"verify","sha":"340aa791643bca5aa50e3867c164a6bc3bbeabdb","user":{"login":"david-eckardt-sociomantic","id":2952846,"avatar_url":"https://avatars3.githubusercontent.com/u/2952846?v=4","gravatar_id":"","url":"https://api.github.com/users/david-eckardt-sociomantic","html_url":"https://github.com/david-eckardt-sociomantic","followers_url":"https://api.github.com/users/david-eckardt-sociomantic/followers","following_url":"https://api.github.com/users/david-eckardt-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/david-eckardt-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/david-eckardt-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-eckardt-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/david-eckardt-sociomantic/orgs","repos_url":"https://api.github.com/users/david-eckardt-sociomantic/repos","events_url":"https://api.github.com/users/david-eckardt-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/david-eckardt-sociomantic/received_events","type":"User","site_admin":false},"repo":{"id":102012486,"name":"dmqnode-1","full_name":"david-eckardt-sociomantic/dmqnode-1","owner":{"login":"david-eckardt-sociomantic","id":2952846,"avatar_url":"https://avatars3.githubusercontent.com/u/2952846?v=4","gravatar_id":"","url":"https://api.github.com/users/david-eckardt-sociomantic","html_url":"https://github.com/david-eckardt-sociomantic","followers_url":"https://api.github.com/users/david-eckardt-sociomantic/followers","following_url":"https://api.github.com/users/david-eckardt-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/david-eckardt-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/david-eckardt-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-eckardt-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/david-eckardt-sociomantic/orgs","repos_url":"https://api.github.com/users/david-eckardt-sociomantic/repos","events_url":"https://api.github.com/users/david-eckardt-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/david-eckardt-sociomantic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/david-eckardt-sociomantic/dmqnode-1","description":"Distributed message queue node","fork":true,"url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1","forks_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/forks","keys_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/teams","hooks_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/hooks","issue_events_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/issues/events{/number}","events_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/events","assignees_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/assignees{/user}","branches_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/branches{/branch}","tags_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/tags","blobs_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/statuses/{sha}","languages_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/languages","stargazers_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/stargazers","contributors_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/contributors","subscribers_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/subscribers","subscription_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/subscription","commits_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/contents/{+path}","compare_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/merges","archive_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/downloads","issues_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/issues{/number}","pulls_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/pulls{/number}","milestones_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/milestones{/number}","notifications_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/labels{/name}","releases_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/releases{/id}","deployments_url":"https://api.github.com/repos/david-eckardt-sociomantic/dmqnode-1/deployments","created_at":"2017-08-31T14:57:23Z","updated_at":"2018-03-20T16:46:43Z","pushed_at":"2018-03-22T11:48:04Z","git_url":"git://github.com/david-eckardt-sociomantic/dmqnode-1.git","ssh_url":"git@github.com:david-eckardt-sociomantic/dmqnode-1.git","clone_url":"https://github.com/david-eckardt-sociomantic/dmqnode-1.git","svn_url":"https://github.com/david-eckardt-sociomantic/dmqnode-1","homepage":null,"size":158,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sociomantic-tsunami:master","ref":"master","sha":"932328f8cd849ee1a6cef6fe6afea9ed8fb3b196","user":{"login":"sociomantic-tsunami","id":16766217,"avatar_url":"https://avatars0.githubusercontent.com/u/16766217?v=4","gravatar_id":"","url":"https://api.github.com/users/sociomantic-tsunami","html_url":"https://github.com/sociomantic-tsunami","followers_url":"https://api.github.com/users/sociomantic-tsunami/followers","following_url":"https://api.github.com/users/sociomantic-tsunami/following{/other_user}","gists_url":"https://api.github.com/users/sociomantic-tsunami/gists{/gist_id}","starred_url":"https://api.github.com/users/sociomantic-tsunami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sociomantic-tsunami/subscriptions","organizations_url":"https://api.github.com/users/sociomantic-tsunami/orgs","repos_url":"https://api.github.com/users/sociomantic-tsunami/repos","events_url":"https://api.github.com/users/sociomantic-tsunami/events{/privacy}","received_events_url":"https://api.github.com/users/sociomantic-tsunami/received_events","type":"Organization","site_admin":false},"repo":{"id":99139359,"name":"dmqnode","full_name":"sociomantic-tsunami/dmqnode","owner":{"login":"sociomantic-tsunami","id":16766217,"avatar_url":"https://avatars0.githubusercontent.com/u/16766217?v=4","gravatar_id":"","url":"https://api.github.com/users/sociomantic-tsunami","html_url":"https://github.com/sociomantic-tsunami","followers_url":"https://api.github.com/users/sociomantic-tsunami/followers","following_url":"https://api.github.com/users/sociomantic-tsunami/following{/other_user}","gists_url":"https://api.github.com/users/sociomantic-tsunami/gists{/gist_id}","starred_url":"https://api.github.com/users/sociomantic-tsunami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sociomantic-tsunami/subscriptions","organizations_url":"https://api.github.com/users/sociomantic-tsunami/orgs","repos_url":"https://api.github.com/users/sociomantic-tsunami/repos","events_url":"https://api.github.com/users/sociomantic-tsunami/events{/privacy}","received_events_url":"https://api.github.com/users/sociomantic-tsunami/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sociomantic-tsunami/dmqnode","description":"Distributed message queue node","fork":false,"url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode","forks_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/forks","keys_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/teams","hooks_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/hooks","issue_events_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/issues/events{/number}","events_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/events","assignees_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/assignees{/user}","branches_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/branches{/branch}","tags_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/tags","blobs_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/git/refs{/sha}","trees_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/statuses/{sha}","languages_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/languages","stargazers_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/stargazers","contributors_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/contributors","subscribers_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/subscribers","subscription_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/subscription","commits_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/commits{/sha}","git_commits_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/git/commits{/sha}","comments_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/comments{/number}","issue_comment_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/issues/comments{/number}","contents_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/contents/{+path}","compare_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/merges","archive_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/downloads","issues_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/issues{/number}","pulls_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/pulls{/number}","milestones_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/milestones{/number}","notifications_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/labels{/name}","releases_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/releases{/id}","deployments_url":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/deployments","created_at":"2017-08-02T16:37:09Z","updated_at":"2018-03-20T16:55:41Z","pushed_at":"2018-03-22T11:48:05Z","git_url":"git://github.com/sociomantic-tsunami/dmqnode.git","ssh_url":"git@github.com:sociomantic-tsunami/dmqnode.git","clone_url":"https://github.com/sociomantic-tsunami/dmqnode.git","svn_url":"https://github.com/sociomantic-tsunami/dmqnode","homepage":null,"size":155,"stargazers_count":1,"watchers_count":1,"language":"D","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":7,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/pulls/43"},"html":{"href":"https://github.com/sociomantic-tsunami/dmqnode/pull/43"},"issue":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/issues/43"},"comments":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmqnode/statuses/340aa791643bca5aa50e3867c164a6bc3bbeabdb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"david-eckardt-sociomantic"}}