{"action":"created","issue":{"url":"https://api.github.com/repos/ionic-team/ionic/issues/15979","repository_url":"https://api.github.com/repos/ionic-team/ionic","labels_url":"https://api.github.com/repos/ionic-team/ionic/issues/15979/labels{/name}","comments_url":"https://api.github.com/repos/ionic-team/ionic/issues/15979/comments","events_url":"https://api.github.com/repos/ionic-team/ionic/issues/15979/events","html_url":"https://github.com/ionic-team/ionic/issues/15979","id":370854194,"node_id":"MDU6SXNzdWUzNzA4NTQxOTQ=","number":15979,"title":"ES6 Builds Broken by #6a5aec8","user":{"login":"godenji","id":238557,"node_id":"MDQ6VXNlcjIzODU1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/238557?v=4","gravatar_id":"","url":"https://api.github.com/users/godenji","html_url":"https://github.com/godenji","followers_url":"https://api.github.com/users/godenji/followers","following_url":"https://api.github.com/users/godenji/following{/other_user}","gists_url":"https://api.github.com/users/godenji/gists{/gist_id}","starred_url":"https://api.github.com/users/godenji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godenji/subscriptions","organizations_url":"https://api.github.com/users/godenji/orgs","repos_url":"https://api.github.com/users/godenji/repos","events_url":"https://api.github.com/users/godenji/events{/privacy}","received_events_url":"https://api.github.com/users/godenji/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"manucorporat","id":127379,"node_id":"MDQ6VXNlcjEyNzM3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/127379?v=4","gravatar_id":"","url":"https://api.github.com/users/manucorporat","html_url":"https://github.com/manucorporat","followers_url":"https://api.github.com/users/manucorporat/followers","following_url":"https://api.github.com/users/manucorporat/following{/other_user}","gists_url":"https://api.github.com/users/manucorporat/gists{/gist_id}","starred_url":"https://api.github.com/users/manucorporat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manucorporat/subscriptions","organizations_url":"https://api.github.com/users/manucorporat/orgs","repos_url":"https://api.github.com/users/manucorporat/repos","events_url":"https://api.github.com/users/manucorporat/events{/privacy}","received_events_url":"https://api.github.com/users/manucorporat/received_events","type":"User","site_admin":false},"assignees":[{"login":"manucorporat","id":127379,"node_id":"MDQ6VXNlcjEyNzM3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/127379?v=4","gravatar_id":"","url":"https://api.github.com/users/manucorporat","html_url":"https://github.com/manucorporat","followers_url":"https://api.github.com/users/manucorporat/followers","following_url":"https://api.github.com/users/manucorporat/following{/other_user}","gists_url":"https://api.github.com/users/manucorporat/gists{/gist_id}","starred_url":"https://api.github.com/users/manucorporat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manucorporat/subscriptions","organizations_url":"https://api.github.com/users/manucorporat/orgs","repos_url":"https://api.github.com/users/manucorporat/repos","events_url":"https://api.github.com/users/manucorporat/events{/privacy}","received_events_url":"https://api.github.com/users/manucorporat/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-10-17T00:46:17Z","updated_at":"2018-11-01T14:28:36Z","closed_at":null,"author_association":"NONE","body":"<!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n# Bug Report\r\n\r\n**Ionic Info**\r\n```\r\nIonic:\r\n\r\n   ionic (Ionic CLI)             : 4.2.1\r\n   Ionic Framework               : @ionic/angular 4.0.0-beta.13\r\n   @angular-devkit/build-angular : 0.7.5\r\n   @angular-devkit/schematics    : 0.7.5\r\n   @angular/cli                  : 6.2.5\r\n   @ionic/angular-toolkit        : 1.0.0\r\n\r\nCordova:\r\n\r\n   cordova (Cordova CLI) : 8.1.2 (cordova-lib@8.1.1)\r\n   Cordova Platforms     : android 7.1.1\r\n   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.2, cordova-plugin-ionic-webview 2.0.3, (and 8 other plugins)\r\n\r\nSystem:\r\n\r\n   NodeJS : v10.10.0 (/usr/bin/node)\r\n   npm    : 6.4.1\r\n   OS     : Linux 4.16\r\n```\r\n\r\n**Describe the Bug**\r\nCommit #6a5aec8 breaks ES6 targeted builds.\r\n\r\n**Steps to Reproduce**\r\nSteps to reproduce the behavior:\r\n1. Upgrade to v4 beta 13\r\n2. Set `tsconfig.json` compile target to `es6`\r\n3. run `ionic serve`\r\n\r\n**Expected Behavior**\r\nES6 targeted builds are produced successfuly.\r\n\r\n**Additional Context**\r\n```\r\nTypeError: \"class constructors must be invoked with |new|\"\r\n\tBackButtonEmitter http://localhost:8100/vendor.js:129680:35\r\n\tPlatform http://localhost:8100/vendor.js:129695:27\r\n\t_createClass http://localhost:8100/vendor.js:63003:20\r\n\t_createProviderInstance http://localhost:8100/vendor.js:62970:26\r\n\tresolveNgModuleDep http://localhost:8100/vendor.js:62915:21\r\n\tget http://localhost:8100/vendor.js:64022:16\r\n\tinject http://localhost:8100/vendor.js:54331:16\r\n\tinjectArgs http://localhost:8100/vendor.js:54371:23\r\n\tconvertInjectableProviderToFactory http://localhost:8100/vendor.js:54440:34\r\n\t_callFactory http://localhost:8100/vendor.js:63030:20\r\n\t_createProviderInstance http://localhost:8100/vendor.js:62973:26\r\n\tresolveNgModuleDep http://localhost:8100/vendor.js:62932:17\r\n\t_callFactory http://localhost:8100/vendor.js:63036:106\r\n\t_createProviderInstance http://localhost:8100/vendor.js:62973:26\r\n\tinitNgModule http://localhost:8100/vendor.js:62876:32\r\n\tNgModuleRef_ http://localhost:8100/vendor.js:64005:9\r\n\tcreateNgModuleRef http://localhost:8100/vendor.js:63988:12\r\n\tdebugCreateNgModuleRef http://localhost:8100/vendor.js:66419:12\r\n\tcreate http://localhost:8100/vendor.js:67513:16\r\n\tbootstrapModuleFactory http://localhost:8100/vendor.js:57837:49\r\n\tinvoke http://localhost:8100/polyfills.js:2710:17\r\n\tonInvoke http://localhost:8100/vendor.js:57262:24\r\n\tinvoke http://localhost:8100/polyfills.js:2709:17\r\n\trun http://localhost:8100/polyfills.js:2460:24\r\n\trun http://localhost:8100/vendor.js:57149:54\r\n\tbootstrapModuleFactory http://localhost:8100/vendor.js:57833:16\r\n\tbootstrapModule http://localhost:8100/vendor.js:57884:38\r\n\tinvoke http://localhost:8100/polyfills.js:2710:17\r\n\trun http://localhost:8100/polyfills.js:2460:24\r\n\tscheduleResolveOrReject http://localhost:8100/polyfills.js:3194:29\r\n\tinvokeTask http://localhost:8100/polyfills.js:2743:17\r\n\trunTask http://localhost:8100/polyfills.js:2510:28\r\n\tdrainMicroTaskQueue http://localhost:8100/polyfills.js:2917:25\r\n```\r\nGenerated JS looks like:\r\n```\r\nvar BackButtonEmitter = /** @class */ (function (_super) {\r\n    __extends(BackButtonEmitter, _super);\r\n    function BackButtonEmitter() {\r\n        return _super !== null && _super.apply(this, arguments) || this;\r\n    }\r\n    BackButtonEmitter.prototype.subscribeWithPriority = function (priority, callback) {\r\n        return this.subscribe(function (ev) {\r\n            ev.register(priority, callback);\r\n        });\r\n    };\r\n    return BackButtonEmitter;\r\n}(_angular_core__WEBPACK_IMPORTED_MODULE_0__[\"EventEmitter\"]));\r\n```\r\nand build blows up with \"class constructors must be invoked with |new|\" on this call: _super.apply(this, arguments)."},"comment":{"url":"https://api.github.com/repos/ionic-team/ionic/issues/comments/435057793","html_url":"https://github.com/ionic-team/ionic/issues/15979#issuecomment-435057793","issue_url":"https://api.github.com/repos/ionic-team/ionic/issues/15979","id":435057793,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTA1Nzc5Mw==","user":{"login":"godenji","id":238557,"node_id":"MDQ6VXNlcjIzODU1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/238557?v=4","gravatar_id":"","url":"https://api.github.com/users/godenji","html_url":"https://github.com/godenji","followers_url":"https://api.github.com/users/godenji/followers","following_url":"https://api.github.com/users/godenji/following{/other_user}","gists_url":"https://api.github.com/users/godenji/gists{/gist_id}","starred_url":"https://api.github.com/users/godenji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godenji/subscriptions","organizations_url":"https://api.github.com/users/godenji/orgs","repos_url":"https://api.github.com/users/godenji/repos","events_url":"https://api.github.com/users/godenji/events{/privacy}","received_events_url":"https://api.github.com/users/godenji/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T14:28:36Z","updated_at":"2018-11-01T14:28:36Z","author_association":"NONE","body":"> Still the same problem with @ionic/angular@4.0.0-beta.15-0\r\n\r\nThat's because the author of the commit that introduced the regression is clearly working on other, presumably more important, issues :)\r\n\r\nA quick and dirty hack that \"fixes\" the issue (i.e. reverts to old behavior) is to change line 32 of `node_modules/@ionic/angular/dist/providers/platform.js` from\r\n`this.backButton = new BackButtonEmitter();` to `this.backButton = new EventEmitter();`"}}
{"actor":{"display_login":"godenji"}}