{"action":"created","issue":{"url":"https://api.github.com/repos/deercreeklabs/lancaster/issues/3","repository_url":"https://api.github.com/repos/deercreeklabs/lancaster","labels_url":"https://api.github.com/repos/deercreeklabs/lancaster/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/deercreeklabs/lancaster/issues/3/comments","events_url":"https://api.github.com/repos/deercreeklabs/lancaster/issues/3/events","html_url":"https://github.com/deercreeklabs/lancaster/pull/3","id":377203028,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MjA4MzA4","number":3,"title":"(wait, request for comments) Clojure(Script) spec addition","user":{"login":"piotr-yuxuan","id":3686502,"node_id":"MDQ6VXNlcjM2ODY1MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/3686502?v=4","gravatar_id":"","url":"https://api.github.com/users/piotr-yuxuan","html_url":"https://github.com/piotr-yuxuan","followers_url":"https://api.github.com/users/piotr-yuxuan/followers","following_url":"https://api.github.com/users/piotr-yuxuan/following{/other_user}","gists_url":"https://api.github.com/users/piotr-yuxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/piotr-yuxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotr-yuxuan/subscriptions","organizations_url":"https://api.github.com/users/piotr-yuxuan/orgs","repos_url":"https://api.github.com/users/piotr-yuxuan/repos","events_url":"https://api.github.com/users/piotr-yuxuan/events{/privacy}","received_events_url":"https://api.github.com/users/piotr-yuxuan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-04T22:37:58Z","updated_at":"2018-11-05T23:38:07Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/deercreeklabs/lancaster/pulls/3","html_url":"https://github.com/deercreeklabs/lancaster/pull/3","diff_url":"https://github.com/deercreeklabs/lancaster/pull/3.diff","patch_url":"https://github.com/deercreeklabs/lancaster/pull/3.patch"},"body":"I'm thinking about adding Clojure(Script) support in `lancaster` as well as you've got Prismatic schemas with `deercreeklabs.lancaster.utils/edn-schema->plumatic-schema`. This first commit (with no tests) is a bare wireframe for the implementation I'm thinking about.\r\n\r\nI'd be more than delighted to get some feedback about that, be it positive or negative. What do you think of the suggested implementation? Anything better / any possible refactoring? Can it work and be useful?"},"comment":{"url":"https://api.github.com/repos/deercreeklabs/lancaster/issues/comments/436076808","html_url":"https://github.com/deercreeklabs/lancaster/pull/3#issuecomment-436076808","issue_url":"https://api.github.com/repos/deercreeklabs/lancaster/issues/3","id":436076808,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjA3NjgwOA==","user":{"login":"chadharrington","id":421618,"node_id":"MDQ6VXNlcjQyMTYxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/421618?v=4","gravatar_id":"","url":"https://api.github.com/users/chadharrington","html_url":"https://github.com/chadharrington","followers_url":"https://api.github.com/users/chadharrington/followers","following_url":"https://api.github.com/users/chadharrington/following{/other_user}","gists_url":"https://api.github.com/users/chadharrington/gists{/gist_id}","starred_url":"https://api.github.com/users/chadharrington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadharrington/subscriptions","organizations_url":"https://api.github.com/users/chadharrington/orgs","repos_url":"https://api.github.com/users/chadharrington/repos","events_url":"https://api.github.com/users/chadharrington/events{/privacy}","received_events_url":"https://api.github.com/users/chadharrington/received_events","type":"User","site_admin":false},"created_at":"2018-11-05T23:38:07Z","updated_at":"2018-11-05T23:38:07Z","author_association":"CONTRIBUTOR","body":"Spec support is definitely something I want to add. Your approach looks great and matches the rest of the project well. One minor naming preference: Let's make the top-level function name simply \"spec\". That matches the rest of the fn names. Usage would be:\r\n```clojure\r\n(require '[deercreeklabs.lancaster :as l])\r\n(def sch (l/map-schema l/int-schema))\r\n(l/spec sch)\r\n```\r\nI have held off because I have some complaints about spec's current form. It sounds like [some changes are coming to spec](https://twitter.com/stuarthalloway/status/1056881838927568896) that will likely resolve those complaints. Let's wait until we see what spec alpha 2 brings, then implement this."}}
{"actor":{"display_login":"chadharrington"}}