{"action":"created","comment":{"url":"https://api.github.com/repos/esl/MongooseIM/pulls/comments/184952158","pull_request_review_id":116245426,"id":184952158,"diff_hunk":"@@ -6,7 +6,7 @@\n     {log_root, \"{{mongooseim_log_dir}}\"},\n     {crash_log, \"crash.log\"},\n     {handlers, [\n-        {lager_console_backend, [info, {lager_default_formatter,[{eol, \"\\r\\n\"}]}]},\n+        {lager_console_backend, [{level, info}]},","path":"rel/files/app.config","position":5,"original_position":5,"commit_id":"9ef566181cc61675f905aedd0370e108767b0eda","original_commit_id":"9ef566181cc61675f905aedd0370e108767b0eda","user":{"login":"arcusfelis","id":639796,"avatar_url":"https://avatars0.githubusercontent.com/u/639796?v=4","gravatar_id":"","url":"https://api.github.com/users/arcusfelis","html_url":"https://github.com/arcusfelis","followers_url":"https://api.github.com/users/arcusfelis/followers","following_url":"https://api.github.com/users/arcusfelis/following{/other_user}","gists_url":"https://api.github.com/users/arcusfelis/gists{/gist_id}","starred_url":"https://api.github.com/users/arcusfelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcusfelis/subscriptions","organizations_url":"https://api.github.com/users/arcusfelis/orgs","repos_url":"https://api.github.com/users/arcusfelis/repos","events_url":"https://api.github.com/users/arcusfelis/events{/privacy}","received_events_url":"https://api.github.com/users/arcusfelis/received_events","type":"User","site_admin":false},"body":"will put in a separate PR.","created_at":"2018-04-30T10:19:14Z","updated_at":"2018-04-30T10:19:14Z","html_url":"https://github.com/esl/MongooseIM/pull/1816#discussion_r184952158","pull_request_url":"https://api.github.com/repos/esl/MongooseIM/pulls/1816","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/comments/184952158"},"html":{"href":"https://github.com/esl/MongooseIM/pull/1816#discussion_r184952158"},"pull_request":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/1816"}},"in_reply_to_id":184660217},"pull_request":{"url":"https://api.github.com/repos/esl/MongooseIM/pulls/1816","id":182772049,"html_url":"https://github.com/esl/MongooseIM/pull/1816","diff_url":"https://github.com/esl/MongooseIM/pull/1816.diff","patch_url":"https://github.com/esl/MongooseIM/pull/1816.patch","issue_url":"https://api.github.com/repos/esl/MongooseIM/issues/1816","number":1816,"state":"open","locked":false,"title":"Fix ODBC API support for MongooseIM","user":{"login":"arcusfelis","id":639796,"avatar_url":"https://avatars0.githubusercontent.com/u/639796?v=4","gravatar_id":"","url":"https://api.github.com/users/arcusfelis","html_url":"https://github.com/arcusfelis","followers_url":"https://api.github.com/users/arcusfelis/followers","following_url":"https://api.github.com/users/arcusfelis/following{/other_user}","gists_url":"https://api.github.com/users/arcusfelis/gists{/gist_id}","starred_url":"https://api.github.com/users/arcusfelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcusfelis/subscriptions","organizations_url":"https://api.github.com/users/arcusfelis/orgs","repos_url":"https://api.github.com/users/arcusfelis/repos","events_url":"https://api.github.com/users/arcusfelis/events{/privacy}","received_events_url":"https://api.github.com/users/arcusfelis/received_events","type":"User","site_admin":false},"body":"Proposed changes include:\r\n\r\nEnable mssql travis build\r\n\r\nUse arcusfelis/eodbc version of odbc application\r\n\r\neodbc returns types of fields\r\n\r\neodbc correctly handles long binaries/texts in pgsql\r\n\r\neodbc prints data when wrong data is written into port\r\n\r\nUse eodbc in mongoose_rdbms_SUITE\r\n\r\nUse return_types in eodbc to handle utf16\r\n\r\nUse utf8mb4 encoding in mysql\r\n\r\nMake start_services optional\r\n\r\nAllow to enable preset on just some nodes\r\n\r\nUpdate travis-setup-db.sh with license reference\r\n\r\nUse shared odbc.ini for both mssql and pgsql\r\n\r\nFix mongoose_rdbms_type:get() function\r\n\r\nAdd search_body into priv/mssql2012.sql schema\r\n\r\nUse varbinary for message field in MSSQL\r\n\r\nUse nvarchar in mssql schema\r\n\r\nReduce length of some fields in mssql schema\r\n\r\nCorrecly escape varchar in mssql\r\n\r\nAdd is_integer(ArcID) check into mod_mam_odbc_async_pool_writer\r\n\r\nAdd is_integer(UserID) check to mod_mam_odbc_prefs:get_behaviour/5\r\n\r\nChange a primary key for mam_muc_message from id to (room_id,id)\r\n\r\nHandle duplicate error from MSSQL in mod_mam_odbc_user\r\n\r\nLog an error with good description when sql_execute fails\r\n\r\nAdd unicode_messages_can_be_extracted test\r\n\r\nUse several like statements when searching for multiple words\r\n\r\nAdd muclight tables\r\n\r\nAdd test_types table to postgres and mysql schemas\r\n\r\nAdd a ssl tip comment into /tools/travis-setup-db.sh\r\n\r\nAdd rdbms_SUITE in big_tests\r\n\r\nRefactor string escaping API\r\n\r\nAdd escape_boolean\r\n\r\nAdd a comment into privacy_SUITE about kicking (non mssql)\r\n\r\nIntroduce ejabberd_c2s:process_incoming_stanza_with_conflict_check\r\n\r\nWait in mam_SUITE:long_text_search_request\r\n\r\nFix unexpected presences in last_SUITE\r\n\r\nFix a race condition in rest_client_SUITE\r\n\r\nCorrectly decode ID in mod_privacy_odbc:get_privacy_list\r\n\r\nRemove application:start from rdbms_odbc:connect/2\r\n","created_at":"2018-04-19T13:13:54Z","updated_at":"2018-04-30T10:19:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe1d2c006e762b85e2297f614c2f51b0c7dcede2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":275953800,"url":"https://api.github.com/repos/esl/MongooseIM/labels/waiting-for-review","name":"waiting-for-review","color":"edd96d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/esl/MongooseIM/pulls/1816/commits","review_comments_url":"https://api.github.com/repos/esl/MongooseIM/pulls/1816/comments","review_comment_url":"https://api.github.com/repos/esl/MongooseIM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/esl/MongooseIM/issues/1816/comments","statuses_url":"https://api.github.com/repos/esl/MongooseIM/statuses/9ef566181cc61675f905aedd0370e108767b0eda","head":{"label":"esl:mssql-travis","ref":"mssql-travis","sha":"9ef566181cc61675f905aedd0370e108767b0eda","user":{"login":"esl","id":283412,"avatar_url":"https://avatars3.githubusercontent.com/u/283412?v=4","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"repo":{"id":2354240,"name":"MongooseIM","full_name":"esl/MongooseIM","owner":{"login":"esl","id":283412,"avatar_url":"https://avatars3.githubusercontent.com/u/283412?v=4","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/esl/MongooseIM","description":"MongooseIM is a mobile messaging platform with focus on performance and scalability","fork":false,"url":"https://api.github.com/repos/esl/MongooseIM","forks_url":"https://api.github.com/repos/esl/MongooseIM/forks","keys_url":"https://api.github.com/repos/esl/MongooseIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esl/MongooseIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esl/MongooseIM/teams","hooks_url":"https://api.github.com/repos/esl/MongooseIM/hooks","issue_events_url":"https://api.github.com/repos/esl/MongooseIM/issues/events{/number}","events_url":"https://api.github.com/repos/esl/MongooseIM/events","assignees_url":"https://api.github.com/repos/esl/MongooseIM/assignees{/user}","branches_url":"https://api.github.com/repos/esl/MongooseIM/branches{/branch}","tags_url":"https://api.github.com/repos/esl/MongooseIM/tags","blobs_url":"https://api.github.com/repos/esl/MongooseIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esl/MongooseIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esl/MongooseIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/esl/MongooseIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esl/MongooseIM/statuses/{sha}","languages_url":"https://api.github.com/repos/esl/MongooseIM/languages","stargazers_url":"https://api.github.com/repos/esl/MongooseIM/stargazers","contributors_url":"https://api.github.com/repos/esl/MongooseIM/contributors","subscribers_url":"https://api.github.com/repos/esl/MongooseIM/subscribers","subscription_url":"https://api.github.com/repos/esl/MongooseIM/subscription","commits_url":"https://api.github.com/repos/esl/MongooseIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/esl/MongooseIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/esl/MongooseIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/esl/MongooseIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/esl/MongooseIM/contents/{+path}","compare_url":"https://api.github.com/repos/esl/MongooseIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esl/MongooseIM/merges","archive_url":"https://api.github.com/repos/esl/MongooseIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esl/MongooseIM/downloads","issues_url":"https://api.github.com/repos/esl/MongooseIM/issues{/number}","pulls_url":"https://api.github.com/repos/esl/MongooseIM/pulls{/number}","milestones_url":"https://api.github.com/repos/esl/MongooseIM/milestones{/number}","notifications_url":"https://api.github.com/repos/esl/MongooseIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esl/MongooseIM/labels{/name}","releases_url":"https://api.github.com/repos/esl/MongooseIM/releases{/id}","deployments_url":"https://api.github.com/repos/esl/MongooseIM/deployments","created_at":"2011-09-09T08:19:18Z","updated_at":"2018-04-30T07:39:24Z","pushed_at":"2018-04-27T17:20:22Z","git_url":"git://github.com/esl/MongooseIM.git","ssh_url":"git@github.com:esl/MongooseIM.git","clone_url":"https://github.com/esl/MongooseIM.git","svn_url":"https://github.com/esl/MongooseIM","homepage":"","size":30264,"stargazers_count":913,"watchers_count":913,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":308,"mirror_url":null,"archived":false,"open_issues_count":151,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":308,"open_issues":151,"watchers":913,"default_branch":"master"}},"base":{"label":"esl:master","ref":"master","sha":"4a2dae61647481b7f55077798cb37a20d9eae1cb","user":{"login":"esl","id":283412,"avatar_url":"https://avatars3.githubusercontent.com/u/283412?v=4","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"repo":{"id":2354240,"name":"MongooseIM","full_name":"esl/MongooseIM","owner":{"login":"esl","id":283412,"avatar_url":"https://avatars3.githubusercontent.com/u/283412?v=4","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/esl/MongooseIM","description":"MongooseIM is a mobile messaging platform with focus on performance and scalability","fork":false,"url":"https://api.github.com/repos/esl/MongooseIM","forks_url":"https://api.github.com/repos/esl/MongooseIM/forks","keys_url":"https://api.github.com/repos/esl/MongooseIM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esl/MongooseIM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esl/MongooseIM/teams","hooks_url":"https://api.github.com/repos/esl/MongooseIM/hooks","issue_events_url":"https://api.github.com/repos/esl/MongooseIM/issues/events{/number}","events_url":"https://api.github.com/repos/esl/MongooseIM/events","assignees_url":"https://api.github.com/repos/esl/MongooseIM/assignees{/user}","branches_url":"https://api.github.com/repos/esl/MongooseIM/branches{/branch}","tags_url":"https://api.github.com/repos/esl/MongooseIM/tags","blobs_url":"https://api.github.com/repos/esl/MongooseIM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esl/MongooseIM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esl/MongooseIM/git/refs{/sha}","trees_url":"https://api.github.com/repos/esl/MongooseIM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esl/MongooseIM/statuses/{sha}","languages_url":"https://api.github.com/repos/esl/MongooseIM/languages","stargazers_url":"https://api.github.com/repos/esl/MongooseIM/stargazers","contributors_url":"https://api.github.com/repos/esl/MongooseIM/contributors","subscribers_url":"https://api.github.com/repos/esl/MongooseIM/subscribers","subscription_url":"https://api.github.com/repos/esl/MongooseIM/subscription","commits_url":"https://api.github.com/repos/esl/MongooseIM/commits{/sha}","git_commits_url":"https://api.github.com/repos/esl/MongooseIM/git/commits{/sha}","comments_url":"https://api.github.com/repos/esl/MongooseIM/comments{/number}","issue_comment_url":"https://api.github.com/repos/esl/MongooseIM/issues/comments{/number}","contents_url":"https://api.github.com/repos/esl/MongooseIM/contents/{+path}","compare_url":"https://api.github.com/repos/esl/MongooseIM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esl/MongooseIM/merges","archive_url":"https://api.github.com/repos/esl/MongooseIM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esl/MongooseIM/downloads","issues_url":"https://api.github.com/repos/esl/MongooseIM/issues{/number}","pulls_url":"https://api.github.com/repos/esl/MongooseIM/pulls{/number}","milestones_url":"https://api.github.com/repos/esl/MongooseIM/milestones{/number}","notifications_url":"https://api.github.com/repos/esl/MongooseIM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esl/MongooseIM/labels{/name}","releases_url":"https://api.github.com/repos/esl/MongooseIM/releases{/id}","deployments_url":"https://api.github.com/repos/esl/MongooseIM/deployments","created_at":"2011-09-09T08:19:18Z","updated_at":"2018-04-30T07:39:24Z","pushed_at":"2018-04-27T17:20:22Z","git_url":"git://github.com/esl/MongooseIM.git","ssh_url":"git@github.com:esl/MongooseIM.git","clone_url":"https://github.com/esl/MongooseIM.git","svn_url":"https://github.com/esl/MongooseIM","homepage":"","size":30264,"stargazers_count":913,"watchers_count":913,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":308,"mirror_url":null,"archived":false,"open_issues_count":151,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":308,"open_issues":151,"watchers":913,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/1816"},"html":{"href":"https://github.com/esl/MongooseIM/pull/1816"},"issue":{"href":"https://api.github.com/repos/esl/MongooseIM/issues/1816"},"comments":{"href":"https://api.github.com/repos/esl/MongooseIM/issues/1816/comments"},"review_comments":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/1816/comments"},"review_comment":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/esl/MongooseIM/pulls/1816/commits"},"statuses":{"href":"https://api.github.com/repos/esl/MongooseIM/statuses/9ef566181cc61675f905aedd0370e108767b0eda"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"arcusfelis"}}