{"action":"opened","number":36,"pull_request":{"url":"https://api.github.com/repos/homes-england/asset-register-api/pulls/36","id":228326577,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MzI2NTc3","html_url":"https://github.com/homes-england/asset-register-api/pull/36","diff_url":"https://github.com/homes-england/asset-register-api/pull/36.diff","patch_url":"https://github.com/homes-england/asset-register-api/pull/36.patch","issue_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/36","number":36,"state":"open","locked":false,"title":"Separate gateway interfaces; reduce namespace name duplication","user":{"login":"craigjbass","id":1889973,"node_id":"MDQ6VXNlcjE4ODk5NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1889973?v=4","gravatar_id":"","url":"https://api.github.com/users/craigjbass","html_url":"https://github.com/craigjbass","followers_url":"https://api.github.com/users/craigjbass/followers","following_url":"https://api.github.com/users/craigjbass/following{/other_user}","gists_url":"https://api.github.com/users/craigjbass/gists{/gist_id}","starred_url":"https://api.github.com/users/craigjbass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigjbass/subscriptions","organizations_url":"https://api.github.com/users/craigjbass/orgs","repos_url":"https://api.github.com/users/craigjbass/repos","events_url":"https://api.github.com/users/craigjbass/events{/privacy}","received_events_url":"https://api.github.com/users/craigjbass/received_events","type":"User","site_admin":false},"body":"Apply a few more Clean Architecture principles to the structure of this application\n\n- Apply interface segregation principle to gateway interface. Remove reverse coupling between all use case classes.\n- Clean up the application class (create dependency exporter) - make it easier to register dependencies\n- Clean up naming of private fields + use readonly keyword, { get; } feels like overkill.\n- Condense all acceptance tests into one suite (lots of duplication)\n- Create a \"port\" namespace to separate out \"UseCase\" interfaces from \"Gateway\" interfaces (ports for adapters)\n- Extract a generic interface to represent use cases (will make it easier to implement abstract proxies)","created_at":"2018-11-05T11:52:19Z","updated_at":"2018-11-05T11:52:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls/36/commits","review_comments_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls/36/comments","review_comment_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/36/comments","statuses_url":"https://api.github.com/repos/homes-england/asset-register-api/statuses/69d32c8bd586418dda83ac6ab09d2fe801245511","head":{"label":"homes-england:more-refactoring","ref":"more-refactoring","sha":"69d32c8bd586418dda83ac6ab09d2fe801245511","user":{"login":"homes-england","id":38912533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTEyNTMz","avatar_url":"https://avatars0.githubusercontent.com/u/38912533?v=4","gravatar_id":"","url":"https://api.github.com/users/homes-england","html_url":"https://github.com/homes-england","followers_url":"https://api.github.com/users/homes-england/followers","following_url":"https://api.github.com/users/homes-england/following{/other_user}","gists_url":"https://api.github.com/users/homes-england/gists{/gist_id}","starred_url":"https://api.github.com/users/homes-england/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homes-england/subscriptions","organizations_url":"https://api.github.com/users/homes-england/orgs","repos_url":"https://api.github.com/users/homes-england/repos","events_url":"https://api.github.com/users/homes-england/events{/privacy}","received_events_url":"https://api.github.com/users/homes-england/received_events","type":"Organization","site_admin":false},"repo":{"id":153280886,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMyODA4ODY=","name":"asset-register-api","full_name":"homes-england/asset-register-api","private":false,"owner":{"login":"homes-england","id":38912533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTEyNTMz","avatar_url":"https://avatars0.githubusercontent.com/u/38912533?v=4","gravatar_id":"","url":"https://api.github.com/users/homes-england","html_url":"https://github.com/homes-england","followers_url":"https://api.github.com/users/homes-england/followers","following_url":"https://api.github.com/users/homes-england/following{/other_user}","gists_url":"https://api.github.com/users/homes-england/gists{/gist_id}","starred_url":"https://api.github.com/users/homes-england/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homes-england/subscriptions","organizations_url":"https://api.github.com/users/homes-england/orgs","repos_url":"https://api.github.com/users/homes-england/repos","events_url":"https://api.github.com/users/homes-england/events{/privacy}","received_events_url":"https://api.github.com/users/homes-england/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/homes-england/asset-register-api","description":"Homes England Asset Register API","fork":false,"url":"https://api.github.com/repos/homes-england/asset-register-api","forks_url":"https://api.github.com/repos/homes-england/asset-register-api/forks","keys_url":"https://api.github.com/repos/homes-england/asset-register-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/homes-england/asset-register-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/homes-england/asset-register-api/teams","hooks_url":"https://api.github.com/repos/homes-england/asset-register-api/hooks","issue_events_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/events{/number}","events_url":"https://api.github.com/repos/homes-england/asset-register-api/events","assignees_url":"https://api.github.com/repos/homes-england/asset-register-api/assignees{/user}","branches_url":"https://api.github.com/repos/homes-england/asset-register-api/branches{/branch}","tags_url":"https://api.github.com/repos/homes-england/asset-register-api/tags","blobs_url":"https://api.github.com/repos/homes-england/asset-register-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/homes-england/asset-register-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/homes-england/asset-register-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/homes-england/asset-register-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/homes-england/asset-register-api/statuses/{sha}","languages_url":"https://api.github.com/repos/homes-england/asset-register-api/languages","stargazers_url":"https://api.github.com/repos/homes-england/asset-register-api/stargazers","contributors_url":"https://api.github.com/repos/homes-england/asset-register-api/contributors","subscribers_url":"https://api.github.com/repos/homes-england/asset-register-api/subscribers","subscription_url":"https://api.github.com/repos/homes-england/asset-register-api/subscription","commits_url":"https://api.github.com/repos/homes-england/asset-register-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/homes-england/asset-register-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/homes-england/asset-register-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/homes-england/asset-register-api/contents/{+path}","compare_url":"https://api.github.com/repos/homes-england/asset-register-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/homes-england/asset-register-api/merges","archive_url":"https://api.github.com/repos/homes-england/asset-register-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/homes-england/asset-register-api/downloads","issues_url":"https://api.github.com/repos/homes-england/asset-register-api/issues{/number}","pulls_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls{/number}","milestones_url":"https://api.github.com/repos/homes-england/asset-register-api/milestones{/number}","notifications_url":"https://api.github.com/repos/homes-england/asset-register-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/homes-england/asset-register-api/labels{/name}","releases_url":"https://api.github.com/repos/homes-england/asset-register-api/releases{/id}","deployments_url":"https://api.github.com/repos/homes-england/asset-register-api/deployments","created_at":"2018-10-16T12:22:31Z","updated_at":"2018-10-31T16:46:56Z","pushed_at":"2018-11-05T11:49:51Z","git_url":"git://github.com/homes-england/asset-register-api.git","ssh_url":"git@github.com:homes-england/asset-register-api.git","clone_url":"https://github.com/homes-england/asset-register-api.git","svn_url":"https://github.com/homes-england/asset-register-api","homepage":"","size":160,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"homes-england:master","ref":"master","sha":"b949712fe81ae300d23cbd28e10035890bd4db4c","user":{"login":"homes-england","id":38912533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTEyNTMz","avatar_url":"https://avatars0.githubusercontent.com/u/38912533?v=4","gravatar_id":"","url":"https://api.github.com/users/homes-england","html_url":"https://github.com/homes-england","followers_url":"https://api.github.com/users/homes-england/followers","following_url":"https://api.github.com/users/homes-england/following{/other_user}","gists_url":"https://api.github.com/users/homes-england/gists{/gist_id}","starred_url":"https://api.github.com/users/homes-england/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homes-england/subscriptions","organizations_url":"https://api.github.com/users/homes-england/orgs","repos_url":"https://api.github.com/users/homes-england/repos","events_url":"https://api.github.com/users/homes-england/events{/privacy}","received_events_url":"https://api.github.com/users/homes-england/received_events","type":"Organization","site_admin":false},"repo":{"id":153280886,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMyODA4ODY=","name":"asset-register-api","full_name":"homes-england/asset-register-api","private":false,"owner":{"login":"homes-england","id":38912533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTEyNTMz","avatar_url":"https://avatars0.githubusercontent.com/u/38912533?v=4","gravatar_id":"","url":"https://api.github.com/users/homes-england","html_url":"https://github.com/homes-england","followers_url":"https://api.github.com/users/homes-england/followers","following_url":"https://api.github.com/users/homes-england/following{/other_user}","gists_url":"https://api.github.com/users/homes-england/gists{/gist_id}","starred_url":"https://api.github.com/users/homes-england/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homes-england/subscriptions","organizations_url":"https://api.github.com/users/homes-england/orgs","repos_url":"https://api.github.com/users/homes-england/repos","events_url":"https://api.github.com/users/homes-england/events{/privacy}","received_events_url":"https://api.github.com/users/homes-england/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/homes-england/asset-register-api","description":"Homes England Asset Register API","fork":false,"url":"https://api.github.com/repos/homes-england/asset-register-api","forks_url":"https://api.github.com/repos/homes-england/asset-register-api/forks","keys_url":"https://api.github.com/repos/homes-england/asset-register-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/homes-england/asset-register-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/homes-england/asset-register-api/teams","hooks_url":"https://api.github.com/repos/homes-england/asset-register-api/hooks","issue_events_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/events{/number}","events_url":"https://api.github.com/repos/homes-england/asset-register-api/events","assignees_url":"https://api.github.com/repos/homes-england/asset-register-api/assignees{/user}","branches_url":"https://api.github.com/repos/homes-england/asset-register-api/branches{/branch}","tags_url":"https://api.github.com/repos/homes-england/asset-register-api/tags","blobs_url":"https://api.github.com/repos/homes-england/asset-register-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/homes-england/asset-register-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/homes-england/asset-register-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/homes-england/asset-register-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/homes-england/asset-register-api/statuses/{sha}","languages_url":"https://api.github.com/repos/homes-england/asset-register-api/languages","stargazers_url":"https://api.github.com/repos/homes-england/asset-register-api/stargazers","contributors_url":"https://api.github.com/repos/homes-england/asset-register-api/contributors","subscribers_url":"https://api.github.com/repos/homes-england/asset-register-api/subscribers","subscription_url":"https://api.github.com/repos/homes-england/asset-register-api/subscription","commits_url":"https://api.github.com/repos/homes-england/asset-register-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/homes-england/asset-register-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/homes-england/asset-register-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/homes-england/asset-register-api/contents/{+path}","compare_url":"https://api.github.com/repos/homes-england/asset-register-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/homes-england/asset-register-api/merges","archive_url":"https://api.github.com/repos/homes-england/asset-register-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/homes-england/asset-register-api/downloads","issues_url":"https://api.github.com/repos/homes-england/asset-register-api/issues{/number}","pulls_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls{/number}","milestones_url":"https://api.github.com/repos/homes-england/asset-register-api/milestones{/number}","notifications_url":"https://api.github.com/repos/homes-england/asset-register-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/homes-england/asset-register-api/labels{/name}","releases_url":"https://api.github.com/repos/homes-england/asset-register-api/releases{/id}","deployments_url":"https://api.github.com/repos/homes-england/asset-register-api/deployments","created_at":"2018-10-16T12:22:31Z","updated_at":"2018-10-31T16:46:56Z","pushed_at":"2018-11-05T11:49:51Z","git_url":"git://github.com/homes-england/asset-register-api.git","ssh_url":"git@github.com:homes-england/asset-register-api.git","clone_url":"https://github.com/homes-england/asset-register-api.git","svn_url":"https://github.com/homes-england/asset-register-api","homepage":"","size":160,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/homes-england/asset-register-api/pulls/36"},"html":{"href":"https://github.com/homes-england/asset-register-api/pull/36"},"issue":{"href":"https://api.github.com/repos/homes-england/asset-register-api/issues/36"},"comments":{"href":"https://api.github.com/repos/homes-england/asset-register-api/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/homes-england/asset-register-api/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/homes-england/asset-register-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/homes-england/asset-register-api/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/homes-england/asset-register-api/statuses/69d32c8bd586418dda83ac6ab09d2fe801245511"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":379,"deletions":346,"changed_files":40}}
{"actor":{"display_login":"craigjbass"}}