{"action":"closed","number":14,"pull_request":{"url":"https://api.github.com/repos/mxtommy/SigkSens/pulls/14","id":168414938,"html_url":"https://github.com/mxtommy/SigkSens/pull/14","diff_url":"https://github.com/mxtommy/SigkSens/pull/14.diff","patch_url":"https://github.com/mxtommy/SigkSens/pull/14.patch","issue_url":"https://api.github.com/repos/mxtommy/SigkSens/issues/14","number":14,"state":"closed","locked":false,"title":"Refactor sensor storage","user":{"login":"mairas","id":407010,"avatar_url":"https://avatars1.githubusercontent.com/u/407010?v=4","gravatar_id":"","url":"https://api.github.com/users/mairas","html_url":"https://github.com/mairas","followers_url":"https://api.github.com/users/mairas/followers","following_url":"https://api.github.com/users/mairas/following{/other_user}","gists_url":"https://api.github.com/users/mairas/gists{/gist_id}","starred_url":"https://api.github.com/users/mairas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mairas/subscriptions","organizations_url":"https://api.github.com/users/mairas/orgs","repos_url":"https://api.github.com/users/mairas/repos","events_url":"https://api.github.com/users/mairas/events{/privacy}","received_events_url":"https://api.github.com/users/mairas/received_events","type":"User","site_admin":false},"body":"OK, this is a rather big one, sorry about that.\r\n\r\nI've refactored the hell out of `sensorList`. Sensors are now grouped according to the sensor type, and within the sensor type storage the sensors are internally stored in an STL `std::map` container. This should make the common-case sensor iteration quite a bit faster, although in practice it might be a slight overkill. I don't think there's much harm in using that, anyway. :-)\r\n\r\nThere's a new `ArduinoSTL` dependency, while `LinkedList` is no longer needed.\r\n","created_at":"2018-02-10T18:45:42Z","updated_at":"2018-02-10T20:18:16Z","closed_at":"2018-02-10T20:18:16Z","merged_at":"2018-02-10T20:18:16Z","merge_commit_sha":"4142e952abc5c84b0275f77057190fdf6252fd5e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mxtommy/SigkSens/pulls/14/commits","review_comments_url":"https://api.github.com/repos/mxtommy/SigkSens/pulls/14/comments","review_comment_url":"https://api.github.com/repos/mxtommy/SigkSens/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mxtommy/SigkSens/issues/14/comments","statuses_url":"https://api.github.com/repos/mxtommy/SigkSens/statuses/1de9db74bd4f3aad27b6e5782c7ffd8539638e59","head":{"label":"mairas:refactor_sensor_storage","ref":"refactor_sensor_storage","sha":"1de9db74bd4f3aad27b6e5782c7ffd8539638e59","user":{"login":"mairas","id":407010,"avatar_url":"https://avatars1.githubusercontent.com/u/407010?v=4","gravatar_id":"","url":"https://api.github.com/users/mairas","html_url":"https://github.com/mairas","followers_url":"https://api.github.com/users/mairas/followers","following_url":"https://api.github.com/users/mairas/following{/other_user}","gists_url":"https://api.github.com/users/mairas/gists{/gist_id}","starred_url":"https://api.github.com/users/mairas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mairas/subscriptions","organizations_url":"https://api.github.com/users/mairas/orgs","repos_url":"https://api.github.com/users/mairas/repos","events_url":"https://api.github.com/users/mairas/events{/privacy}","received_events_url":"https://api.github.com/users/mairas/received_events","type":"User","site_admin":false},"repo":{"id":118372867,"name":"SigkSens","full_name":"mairas/SigkSens","owner":{"login":"mairas","id":407010,"avatar_url":"https://avatars1.githubusercontent.com/u/407010?v=4","gravatar_id":"","url":"https://api.github.com/users/mairas","html_url":"https://github.com/mairas","followers_url":"https://api.github.com/users/mairas/followers","following_url":"https://api.github.com/users/mairas/following{/other_user}","gists_url":"https://api.github.com/users/mairas/gists{/gist_id}","starred_url":"https://api.github.com/users/mairas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mairas/subscriptions","organizations_url":"https://api.github.com/users/mairas/orgs","repos_url":"https://api.github.com/users/mairas/repos","events_url":"https://api.github.com/users/mairas/events{/privacy}","received_events_url":"https://api.github.com/users/mairas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mairas/SigkSens","description":null,"fork":true,"url":"https://api.github.com/repos/mairas/SigkSens","forks_url":"https://api.github.com/repos/mairas/SigkSens/forks","keys_url":"https://api.github.com/repos/mairas/SigkSens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mairas/SigkSens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mairas/SigkSens/teams","hooks_url":"https://api.github.com/repos/mairas/SigkSens/hooks","issue_events_url":"https://api.github.com/repos/mairas/SigkSens/issues/events{/number}","events_url":"https://api.github.com/repos/mairas/SigkSens/events","assignees_url":"https://api.github.com/repos/mairas/SigkSens/assignees{/user}","branches_url":"https://api.github.com/repos/mairas/SigkSens/branches{/branch}","tags_url":"https://api.github.com/repos/mairas/SigkSens/tags","blobs_url":"https://api.github.com/repos/mairas/SigkSens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mairas/SigkSens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mairas/SigkSens/git/refs{/sha}","trees_url":"https://api.github.com/repos/mairas/SigkSens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mairas/SigkSens/statuses/{sha}","languages_url":"https://api.github.com/repos/mairas/SigkSens/languages","stargazers_url":"https://api.github.com/repos/mairas/SigkSens/stargazers","contributors_url":"https://api.github.com/repos/mairas/SigkSens/contributors","subscribers_url":"https://api.github.com/repos/mairas/SigkSens/subscribers","subscription_url":"https://api.github.com/repos/mairas/SigkSens/subscription","commits_url":"https://api.github.com/repos/mairas/SigkSens/commits{/sha}","git_commits_url":"https://api.github.com/repos/mairas/SigkSens/git/commits{/sha}","comments_url":"https://api.github.com/repos/mairas/SigkSens/comments{/number}","issue_comment_url":"https://api.github.com/repos/mairas/SigkSens/issues/comments{/number}","contents_url":"https://api.github.com/repos/mairas/SigkSens/contents/{+path}","compare_url":"https://api.github.com/repos/mairas/SigkSens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mairas/SigkSens/merges","archive_url":"https://api.github.com/repos/mairas/SigkSens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mairas/SigkSens/downloads","issues_url":"https://api.github.com/repos/mairas/SigkSens/issues{/number}","pulls_url":"https://api.github.com/repos/mairas/SigkSens/pulls{/number}","milestones_url":"https://api.github.com/repos/mairas/SigkSens/milestones{/number}","notifications_url":"https://api.github.com/repos/mairas/SigkSens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mairas/SigkSens/labels{/name}","releases_url":"https://api.github.com/repos/mairas/SigkSens/releases{/id}","deployments_url":"https://api.github.com/repos/mairas/SigkSens/deployments","created_at":"2018-01-21T20:52:04Z","updated_at":"2018-01-21T20:52:06Z","pushed_at":"2018-02-10T20:04:45Z","git_url":"git://github.com/mairas/SigkSens.git","ssh_url":"git@github.com:mairas/SigkSens.git","clone_url":"https://github.com/mairas/SigkSens.git","svn_url":"https://github.com/mairas/SigkSens","homepage":null,"size":19394,"stargazers_count":0,"watchers_count":0,"language":"Arduino","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mxtommy:master","ref":"master","sha":"2e84406c68ca8ccf722e52db8b6f65658d7d6cfd","user":{"login":"mxtommy","id":737774,"avatar_url":"https://avatars0.githubusercontent.com/u/737774?v=4","gravatar_id":"","url":"https://api.github.com/users/mxtommy","html_url":"https://github.com/mxtommy","followers_url":"https://api.github.com/users/mxtommy/followers","following_url":"https://api.github.com/users/mxtommy/following{/other_user}","gists_url":"https://api.github.com/users/mxtommy/gists{/gist_id}","starred_url":"https://api.github.com/users/mxtommy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxtommy/subscriptions","organizations_url":"https://api.github.com/users/mxtommy/orgs","repos_url":"https://api.github.com/users/mxtommy/repos","events_url":"https://api.github.com/users/mxtommy/events{/privacy}","received_events_url":"https://api.github.com/users/mxtommy/received_events","type":"User","site_admin":false},"repo":{"id":107254778,"name":"SigkSens","full_name":"mxtommy/SigkSens","owner":{"login":"mxtommy","id":737774,"avatar_url":"https://avatars0.githubusercontent.com/u/737774?v=4","gravatar_id":"","url":"https://api.github.com/users/mxtommy","html_url":"https://github.com/mxtommy","followers_url":"https://api.github.com/users/mxtommy/followers","following_url":"https://api.github.com/users/mxtommy/following{/other_user}","gists_url":"https://api.github.com/users/mxtommy/gists{/gist_id}","starred_url":"https://api.github.com/users/mxtommy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxtommy/subscriptions","organizations_url":"https://api.github.com/users/mxtommy/orgs","repos_url":"https://api.github.com/users/mxtommy/repos","events_url":"https://api.github.com/users/mxtommy/events{/privacy}","received_events_url":"https://api.github.com/users/mxtommy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mxtommy/SigkSens","description":null,"fork":false,"url":"https://api.github.com/repos/mxtommy/SigkSens","forks_url":"https://api.github.com/repos/mxtommy/SigkSens/forks","keys_url":"https://api.github.com/repos/mxtommy/SigkSens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mxtommy/SigkSens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mxtommy/SigkSens/teams","hooks_url":"https://api.github.com/repos/mxtommy/SigkSens/hooks","issue_events_url":"https://api.github.com/repos/mxtommy/SigkSens/issues/events{/number}","events_url":"https://api.github.com/repos/mxtommy/SigkSens/events","assignees_url":"https://api.github.com/repos/mxtommy/SigkSens/assignees{/user}","branches_url":"https://api.github.com/repos/mxtommy/SigkSens/branches{/branch}","tags_url":"https://api.github.com/repos/mxtommy/SigkSens/tags","blobs_url":"https://api.github.com/repos/mxtommy/SigkSens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mxtommy/SigkSens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mxtommy/SigkSens/git/refs{/sha}","trees_url":"https://api.github.com/repos/mxtommy/SigkSens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mxtommy/SigkSens/statuses/{sha}","languages_url":"https://api.github.com/repos/mxtommy/SigkSens/languages","stargazers_url":"https://api.github.com/repos/mxtommy/SigkSens/stargazers","contributors_url":"https://api.github.com/repos/mxtommy/SigkSens/contributors","subscribers_url":"https://api.github.com/repos/mxtommy/SigkSens/subscribers","subscription_url":"https://api.github.com/repos/mxtommy/SigkSens/subscription","commits_url":"https://api.github.com/repos/mxtommy/SigkSens/commits{/sha}","git_commits_url":"https://api.github.com/repos/mxtommy/SigkSens/git/commits{/sha}","comments_url":"https://api.github.com/repos/mxtommy/SigkSens/comments{/number}","issue_comment_url":"https://api.github.com/repos/mxtommy/SigkSens/issues/comments{/number}","contents_url":"https://api.github.com/repos/mxtommy/SigkSens/contents/{+path}","compare_url":"https://api.github.com/repos/mxtommy/SigkSens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mxtommy/SigkSens/merges","archive_url":"https://api.github.com/repos/mxtommy/SigkSens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mxtommy/SigkSens/downloads","issues_url":"https://api.github.com/repos/mxtommy/SigkSens/issues{/number}","pulls_url":"https://api.github.com/repos/mxtommy/SigkSens/pulls{/number}","milestones_url":"https://api.github.com/repos/mxtommy/SigkSens/milestones{/number}","notifications_url":"https://api.github.com/repos/mxtommy/SigkSens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mxtommy/SigkSens/labels{/name}","releases_url":"https://api.github.com/repos/mxtommy/SigkSens/releases{/id}","deployments_url":"https://api.github.com/repos/mxtommy/SigkSens/deployments","created_at":"2017-10-17T10:42:32Z","updated_at":"2018-01-27T04:35:02Z","pushed_at":"2018-02-10T20:18:16Z","git_url":"git://github.com/mxtommy/SigkSens.git","ssh_url":"git@github.com:mxtommy/SigkSens.git","clone_url":"https://github.com/mxtommy/SigkSens.git","svn_url":"https://github.com/mxtommy/SigkSens","homepage":null,"size":19008,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mxtommy/SigkSens/pulls/14"},"html":{"href":"https://github.com/mxtommy/SigkSens/pull/14"},"issue":{"href":"https://api.github.com/repos/mxtommy/SigkSens/issues/14"},"comments":{"href":"https://api.github.com/repos/mxtommy/SigkSens/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/mxtommy/SigkSens/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/mxtommy/SigkSens/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mxtommy/SigkSens/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/mxtommy/SigkSens/statuses/1de9db74bd4f3aad27b6e5782c7ffd8539638e59"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mxtommy","id":737774,"avatar_url":"https://avatars0.githubusercontent.com/u/737774?v=4","gravatar_id":"","url":"https://api.github.com/users/mxtommy","html_url":"https://github.com/mxtommy","followers_url":"https://api.github.com/users/mxtommy/followers","following_url":"https://api.github.com/users/mxtommy/following{/other_user}","gists_url":"https://api.github.com/users/mxtommy/gists{/gist_id}","starred_url":"https://api.github.com/users/mxtommy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxtommy/subscriptions","organizations_url":"https://api.github.com/users/mxtommy/orgs","repos_url":"https://api.github.com/users/mxtommy/repos","events_url":"https://api.github.com/users/mxtommy/events{/privacy}","received_events_url":"https://api.github.com/users/mxtommy/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":15,"additions":65524,"deletions":1090,"changed_files":390}}
{"actor":{"display_login":"mxtommy"}}