{"action":"closed","number":235,"pull_request":{"url":"https://api.github.com/repos/LedgerHQ/ledgerjs/pulls/235","id":226131772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTMxNzcy","html_url":"https://github.com/LedgerHQ/ledgerjs/pull/235","diff_url":"https://github.com/LedgerHQ/ledgerjs/pull/235.diff","patch_url":"https://github.com/LedgerHQ/ledgerjs/pull/235.patch","issue_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/issues/235","number":235,"state":"closed","locked":false,"title":"allow non-wrap responses from hw-transport-u2f","user":{"login":"flocks","id":944835,"node_id":"MDQ6VXNlcjk0NDgzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/944835?v=4","gravatar_id":"","url":"https://api.github.com/users/flocks","html_url":"https://github.com/flocks","followers_url":"https://api.github.com/users/flocks/followers","following_url":"https://api.github.com/users/flocks/following{/other_user}","gists_url":"https://api.github.com/users/flocks/gists{/gist_id}","starred_url":"https://api.github.com/users/flocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flocks/subscriptions","organizations_url":"https://api.github.com/users/flocks/orgs","repos_url":"https://api.github.com/users/flocks/repos","events_url":"https://api.github.com/users/flocks/events{/privacy}","received_events_url":"https://api.github.com/users/flocks/received_events","type":"User","site_admin":false},"body":"### Context\r\n\r\nI ran into a situation where the firmware, by mistake,  didn't add the 5 bytes before the actual response. This is the case for the apdu `f1d0000000` which returns the current scrambleKey. You can set a scrambleKey to null ( `\\00` ) and ask for the current scrambleKey with `f1d0000000`. It basically allow us to know which app is currently open.","created_at":"2018-10-26T15:07:54Z","updated_at":"2018-10-26T15:48:11Z","closed_at":"2018-10-26T15:48:11Z","merged_at":"2018-10-26T15:48:11Z","merge_commit_sha":"bb748be8b2acbddeb27b534b7ba5bb76a2aea74f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/pulls/235/commits","review_comments_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/pulls/235/comments","review_comment_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/issues/235/comments","statuses_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/statuses/81821cc1a25bf6469b79c5df2d2014896d355821","head":{"label":"flocks:allow_unwrap_response","ref":"allow_unwrap_response","sha":"81821cc1a25bf6469b79c5df2d2014896d355821","user":{"login":"flocks","id":944835,"node_id":"MDQ6VXNlcjk0NDgzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/944835?v=4","gravatar_id":"","url":"https://api.github.com/users/flocks","html_url":"https://github.com/flocks","followers_url":"https://api.github.com/users/flocks/followers","following_url":"https://api.github.com/users/flocks/following{/other_user}","gists_url":"https://api.github.com/users/flocks/gists{/gist_id}","starred_url":"https://api.github.com/users/flocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flocks/subscriptions","organizations_url":"https://api.github.com/users/flocks/orgs","repos_url":"https://api.github.com/users/flocks/repos","events_url":"https://api.github.com/users/flocks/events{/privacy}","received_events_url":"https://api.github.com/users/flocks/received_events","type":"User","site_admin":false},"repo":{"id":154824781,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4MjQ3ODE=","name":"ledgerjs","full_name":"flocks/ledgerjs","private":false,"owner":{"login":"flocks","id":944835,"node_id":"MDQ6VXNlcjk0NDgzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/944835?v=4","gravatar_id":"","url":"https://api.github.com/users/flocks","html_url":"https://github.com/flocks","followers_url":"https://api.github.com/users/flocks/followers","following_url":"https://api.github.com/users/flocks/following{/other_user}","gists_url":"https://api.github.com/users/flocks/gists{/gist_id}","starred_url":"https://api.github.com/users/flocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flocks/subscriptions","organizations_url":"https://api.github.com/users/flocks/orgs","repos_url":"https://api.github.com/users/flocks/repos","events_url":"https://api.github.com/users/flocks/events{/privacy}","received_events_url":"https://api.github.com/users/flocks/received_events","type":"User","site_admin":false},"html_url":"https://github.com/flocks/ledgerjs","description":"Ledger Nano / Nano S / Blue JavaScript APIs for Node.js and browsers","fork":true,"url":"https://api.github.com/repos/flocks/ledgerjs","forks_url":"https://api.github.com/repos/flocks/ledgerjs/forks","keys_url":"https://api.github.com/repos/flocks/ledgerjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flocks/ledgerjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flocks/ledgerjs/teams","hooks_url":"https://api.github.com/repos/flocks/ledgerjs/hooks","issue_events_url":"https://api.github.com/repos/flocks/ledgerjs/issues/events{/number}","events_url":"https://api.github.com/repos/flocks/ledgerjs/events","assignees_url":"https://api.github.com/repos/flocks/ledgerjs/assignees{/user}","branches_url":"https://api.github.com/repos/flocks/ledgerjs/branches{/branch}","tags_url":"https://api.github.com/repos/flocks/ledgerjs/tags","blobs_url":"https://api.github.com/repos/flocks/ledgerjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flocks/ledgerjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flocks/ledgerjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/flocks/ledgerjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flocks/ledgerjs/statuses/{sha}","languages_url":"https://api.github.com/repos/flocks/ledgerjs/languages","stargazers_url":"https://api.github.com/repos/flocks/ledgerjs/stargazers","contributors_url":"https://api.github.com/repos/flocks/ledgerjs/contributors","subscribers_url":"https://api.github.com/repos/flocks/ledgerjs/subscribers","subscription_url":"https://api.github.com/repos/flocks/ledgerjs/subscription","commits_url":"https://api.github.com/repos/flocks/ledgerjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/flocks/ledgerjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/flocks/ledgerjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/flocks/ledgerjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/flocks/ledgerjs/contents/{+path}","compare_url":"https://api.github.com/repos/flocks/ledgerjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flocks/ledgerjs/merges","archive_url":"https://api.github.com/repos/flocks/ledgerjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flocks/ledgerjs/downloads","issues_url":"https://api.github.com/repos/flocks/ledgerjs/issues{/number}","pulls_url":"https://api.github.com/repos/flocks/ledgerjs/pulls{/number}","milestones_url":"https://api.github.com/repos/flocks/ledgerjs/milestones{/number}","notifications_url":"https://api.github.com/repos/flocks/ledgerjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flocks/ledgerjs/labels{/name}","releases_url":"https://api.github.com/repos/flocks/ledgerjs/releases{/id}","deployments_url":"https://api.github.com/repos/flocks/ledgerjs/deployments","created_at":"2018-10-26T11:34:46Z","updated_at":"2018-10-26T11:34:48Z","pushed_at":"2018-10-26T15:29:23Z","git_url":"git://github.com/flocks/ledgerjs.git","ssh_url":"git@github.com:flocks/ledgerjs.git","clone_url":"https://github.com/flocks/ledgerjs.git","svn_url":"https://github.com/flocks/ledgerjs","homepage":"http://ledgerhq.github.io/ledgerjs/","size":3709,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LedgerHQ:master","ref":"master","sha":"6bc91048e485dade1acf58db7fa6d3f24969711a","user":{"login":"LedgerHQ","id":9784193,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3ODQxOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9784193?v=4","gravatar_id":"","url":"https://api.github.com/users/LedgerHQ","html_url":"https://github.com/LedgerHQ","followers_url":"https://api.github.com/users/LedgerHQ/followers","following_url":"https://api.github.com/users/LedgerHQ/following{/other_user}","gists_url":"https://api.github.com/users/LedgerHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LedgerHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LedgerHQ/subscriptions","organizations_url":"https://api.github.com/users/LedgerHQ/orgs","repos_url":"https://api.github.com/users/LedgerHQ/repos","events_url":"https://api.github.com/users/LedgerHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LedgerHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":33945868,"node_id":"MDEwOlJlcG9zaXRvcnkzMzk0NTg2OA==","name":"ledgerjs","full_name":"LedgerHQ/ledgerjs","private":false,"owner":{"login":"LedgerHQ","id":9784193,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3ODQxOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9784193?v=4","gravatar_id":"","url":"https://api.github.com/users/LedgerHQ","html_url":"https://github.com/LedgerHQ","followers_url":"https://api.github.com/users/LedgerHQ/followers","following_url":"https://api.github.com/users/LedgerHQ/following{/other_user}","gists_url":"https://api.github.com/users/LedgerHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LedgerHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LedgerHQ/subscriptions","organizations_url":"https://api.github.com/users/LedgerHQ/orgs","repos_url":"https://api.github.com/users/LedgerHQ/repos","events_url":"https://api.github.com/users/LedgerHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LedgerHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LedgerHQ/ledgerjs","description":"Ledger Nano / Nano S / Blue JavaScript APIs for Node.js and browsers","fork":false,"url":"https://api.github.com/repos/LedgerHQ/ledgerjs","forks_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/forks","keys_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/teams","hooks_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/hooks","issue_events_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/issues/events{/number}","events_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/events","assignees_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/assignees{/user}","branches_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/branches{/branch}","tags_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/tags","blobs_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/statuses/{sha}","languages_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/languages","stargazers_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/stargazers","contributors_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/contributors","subscribers_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/subscribers","subscription_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/subscription","commits_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/contents/{+path}","compare_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/merges","archive_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/downloads","issues_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/issues{/number}","pulls_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/pulls{/number}","milestones_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/milestones{/number}","notifications_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/labels{/name}","releases_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/releases{/id}","deployments_url":"https://api.github.com/repos/LedgerHQ/ledgerjs/deployments","created_at":"2015-04-14T17:16:09Z","updated_at":"2018-10-26T11:11:43Z","pushed_at":"2018-10-26T15:48:11Z","git_url":"git://github.com/LedgerHQ/ledgerjs.git","ssh_url":"git@github.com:LedgerHQ/ledgerjs.git","clone_url":"https://github.com/LedgerHQ/ledgerjs.git","svn_url":"https://github.com/LedgerHQ/ledgerjs","homepage":"http://ledgerhq.github.io/ledgerjs/","size":3710,"stargazers_count":215,"watchers_count":215,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":109,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":109,"open_issues":34,"watchers":215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LedgerHQ/ledgerjs/pulls/235"},"html":{"href":"https://github.com/LedgerHQ/ledgerjs/pull/235"},"issue":{"href":"https://api.github.com/repos/LedgerHQ/ledgerjs/issues/235"},"comments":{"href":"https://api.github.com/repos/LedgerHQ/ledgerjs/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/LedgerHQ/ledgerjs/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/LedgerHQ/ledgerjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LedgerHQ/ledgerjs/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/LedgerHQ/ledgerjs/statuses/81821cc1a25bf6469b79c5df2d2014896d355821"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gre","id":211411,"node_id":"MDQ6VXNlcjIxMTQxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/211411?v=4","gravatar_id":"","url":"https://api.github.com/users/gre","html_url":"https://github.com/gre","followers_url":"https://api.github.com/users/gre/followers","following_url":"https://api.github.com/users/gre/following{/other_user}","gists_url":"https://api.github.com/users/gre/gists{/gist_id}","starred_url":"https://api.github.com/users/gre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gre/subscriptions","organizations_url":"https://api.github.com/users/gre/orgs","repos_url":"https://api.github.com/users/gre/repos","events_url":"https://api.github.com/users/gre/events{/privacy}","received_events_url":"https://api.github.com/users/gre/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":16,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"gre"}}