{"action":"created","comment":{"url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/pulls/comments/182916456","pull_request_review_id":113815159,"id":182916456,"diff_hunk":"@@ -19,7 +19,7 @@ spec:\n       containers:\n       - name: web-console-smoke-test\n         image: benjaminapetersen/web-console-smoke-test:latest\n-        imagePullPolicy: IfNotPresent\n+        imagePullPolicy: Always","path":"kube/deployments/smoke-test.yaml","position":null,"original_position":5,"commit_id":"1186372208b92d51cace673b660bcecfc692bd49","original_commit_id":"03c27ffa835aa442322ec5cee24d1d1c1aca5e3c","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"I'd rather limit options for things don't really need to be configurable. You can also edit the deployment if you really need to. You could leave `imagePullPolicy` off entirely if you want it to pull `:latest` always, but not other tags.","created_at":"2018-04-19T23:57:16Z","updated_at":"2018-04-19T23:57:16Z","html_url":"https://github.com/benjaminapetersen/origin-web-console-smoke-test/pull/29#discussion_r182916456","pull_request_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/pulls/29","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/pulls/comments/182916456"},"html":{"href":"https://github.com/benjaminapetersen/origin-web-console-smoke-test/pull/29#discussion_r182916456"},"pull_request":{"href":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/pulls/29"}},"in_reply_to_id":182826131},"pull_request":{"url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/pulls/29","id":181026788,"html_url":"https://github.com/benjaminapetersen/origin-web-console-smoke-test/pull/29","diff_url":"https://github.com/benjaminapetersen/origin-web-console-smoke-test/pull/29.diff","patch_url":"https://github.com/benjaminapetersen/origin-web-console-smoke-test/pull/29.patch","issue_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/issues/29","number":29,"state":"open","locked":false,"title":"HTTPS the /metrics endpoint ","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars0.githubusercontent.com/u/280512?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"body":"Fixes #18\r\nFixes #22 \r\nFixes #35 \r\n\r\nSo the flow:\r\n\r\n````bash \r\n# generate a certificate \r\n# can use this script or diy, whatever you prefer:\r\n# the script will remove the passphrase to make it a little easier to use:\r\n./make_cert.sh \r\n# create a secret using the generated certs files:\r\noc create secret tls tls-certs --cert=tls/cert.pem --key=tls/key.pem -o yaml\r\n# create the deployment after the secret, otherwise it will fail as \r\n# it expects the secret to be mounted as a volume:\r\noc create -f kube/deployments/smoke-test.yaml\r\n```\r\n\r\nVerify by checking your `deployment` in the console.  You should be able to drill down to the `pod` and see things in the logs.  Can also use `oc` if you prefer :) \r\n\r\nIf the `secret` doesn't mount the pod won't start.  I've noticed it hangs indefinitely, and seems to have trouble deleting the pod, deployment, project.  Not sure if there is a bug here.\r\n\r\n- [ ] TODO: update the `README.md` when this is stable.","created_at":"2018-04-11T21:00:19Z","updated_at":"2018-04-19T23:57:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"612a36c8ce01cfa14ec14f1f683f061b1925176e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/pulls/29/commits","review_comments_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/pulls/29/comments","review_comment_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/pulls/comments{/number}","comments_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/issues/29/comments","statuses_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/statuses/1186372208b92d51cace673b660bcecfc692bd49","head":{"label":"benjaminapetersen:issue/22/https","ref":"issue/22/https","sha":"1186372208b92d51cace673b660bcecfc692bd49","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars0.githubusercontent.com/u/280512?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"repo":{"id":122525170,"name":"origin-web-console-smoke-test","full_name":"benjaminapetersen/origin-web-console-smoke-test","owner":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars0.githubusercontent.com/u/280512?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaminapetersen/origin-web-console-smoke-test","description":"Smoke tests running in a pod against the origin-web-console web UI","fork":false,"url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test","forks_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/forks","keys_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/teams","hooks_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/hooks","issue_events_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/issues/events{/number}","events_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/events","assignees_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/assignees{/user}","branches_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/branches{/branch}","tags_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/tags","blobs_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/languages","stargazers_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/stargazers","contributors_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/contributors","subscribers_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/subscribers","subscription_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/subscription","commits_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/contents/{+path}","compare_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/merges","archive_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/downloads","issues_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/issues{/number}","pulls_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/labels{/name}","releases_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/releases{/id}","deployments_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/deployments","created_at":"2018-02-22T19:31:23Z","updated_at":"2018-04-11T15:23:36Z","pushed_at":"2018-04-19T20:26:36Z","git_url":"git://github.com/benjaminapetersen/origin-web-console-smoke-test.git","ssh_url":"git@github.com:benjaminapetersen/origin-web-console-smoke-test.git","clone_url":"https://github.com/benjaminapetersen/origin-web-console-smoke-test.git","svn_url":"https://github.com/benjaminapetersen/origin-web-console-smoke-test","homepage":null,"size":33618,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":16,"watchers":0,"default_branch":"master"}},"base":{"label":"benjaminapetersen:master","ref":"master","sha":"d3f51806cee836a140fe845e150d22e71ca20997","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars0.githubusercontent.com/u/280512?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"repo":{"id":122525170,"name":"origin-web-console-smoke-test","full_name":"benjaminapetersen/origin-web-console-smoke-test","owner":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars0.githubusercontent.com/u/280512?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaminapetersen/origin-web-console-smoke-test","description":"Smoke tests running in a pod against the origin-web-console web UI","fork":false,"url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test","forks_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/forks","keys_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/teams","hooks_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/hooks","issue_events_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/issues/events{/number}","events_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/events","assignees_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/assignees{/user}","branches_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/branches{/branch}","tags_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/tags","blobs_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/languages","stargazers_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/stargazers","contributors_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/contributors","subscribers_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/subscribers","subscription_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/subscription","commits_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/contents/{+path}","compare_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/merges","archive_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/downloads","issues_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/issues{/number}","pulls_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/labels{/name}","releases_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/releases{/id}","deployments_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/deployments","created_at":"2018-02-22T19:31:23Z","updated_at":"2018-04-11T15:23:36Z","pushed_at":"2018-04-19T20:26:36Z","git_url":"git://github.com/benjaminapetersen/origin-web-console-smoke-test.git","ssh_url":"git@github.com:benjaminapetersen/origin-web-console-smoke-test.git","clone_url":"https://github.com/benjaminapetersen/origin-web-console-smoke-test.git","svn_url":"https://github.com/benjaminapetersen/origin-web-console-smoke-test","homepage":null,"size":33618,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/pulls/29"},"html":{"href":"https://github.com/benjaminapetersen/origin-web-console-smoke-test/pull/29"},"issue":{"href":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/issues/29"},"comments":{"href":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/benjaminapetersen/origin-web-console-smoke-test/statuses/1186372208b92d51cace673b660bcecfc692bd49"}},"author_association":"OWNER"}}
{"actor":{"display_login":"spadgett"}}