{"action":"opened","number":460,"pull_request":{"url":"https://api.github.com/repos/nimiq-network/core/pulls/460","id":240882432,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwODgyNDMy","html_url":"https://github.com/nimiq-network/core/pull/460","diff_url":"https://github.com/nimiq-network/core/pull/460.diff","patch_url":"https://github.com/nimiq-network/core/pull/460.patch","issue_url":"https://api.github.com/repos/nimiq-network/core/issues/460","number":460,"state":"open","locked":false,"title":"[WIP] Support ws pool protocol","user":{"login":"terorie","id":21371810,"node_id":"MDQ6VXNlcjIxMzcxODEw","avatar_url":"https://avatars1.githubusercontent.com/u/21371810?v=4","gravatar_id":"","url":"https://api.github.com/users/terorie","html_url":"https://github.com/terorie","followers_url":"https://api.github.com/users/terorie/followers","following_url":"https://api.github.com/users/terorie/following{/other_user}","gists_url":"https://api.github.com/users/terorie/gists{/gist_id}","starred_url":"https://api.github.com/users/terorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terorie/subscriptions","organizations_url":"https://api.github.com/users/terorie/orgs","repos_url":"https://api.github.com/users/terorie/repos","events_url":"https://api.github.com/users/terorie/events{/privacy}","received_events_url":"https://api.github.com/users/terorie/received_events","type":"User","site_admin":false},"body":"## Pull request checklist\r\n\r\n- [ ] All tests pass. Demo project builds and runs.\r\n- [x] I have resolved any merge conflicts.\r\n\r\n#### This fixes issue #459.\r\n\r\nI think it's useful to have the ability to connect to a mining pool server over unencrypted WebSockets. In private mining networks (e.g. not routable over the public Internet), TLS encryption isn't needed or impossible.\r\n\r\n## What's in this pull request?\r\n\r\nAdded `poolMining.protocol` parameter in NodeJS client config.\r\n`BasePoolMiner::connect` method signature changed to `connect(protocol, host, port)`.\r\n\r\nProblems to fix:\r\n- [ ] Breaks dependent packages\r\n- [ ] No way to set protocol from `JsonRpcServer` or command line flags\r\n- [ ] Use `Protocol` class instead?\r\n- [ ] Should include warning when using unencrypted `ws` over public Internet.","created_at":"2018-12-25T15:44:02Z","updated_at":"2018-12-25T15:44:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nimiq-network/core/pulls/460/commits","review_comments_url":"https://api.github.com/repos/nimiq-network/core/pulls/460/comments","review_comment_url":"https://api.github.com/repos/nimiq-network/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nimiq-network/core/issues/460/comments","statuses_url":"https://api.github.com/repos/nimiq-network/core/statuses/aaf95eb2abca2d6d965412f5a37f1877a1d0d56a","head":{"label":"terorie:custom-pool-protocol","ref":"custom-pool-protocol","sha":"aaf95eb2abca2d6d965412f5a37f1877a1d0d56a","user":{"login":"terorie","id":21371810,"node_id":"MDQ6VXNlcjIxMzcxODEw","avatar_url":"https://avatars1.githubusercontent.com/u/21371810?v=4","gravatar_id":"","url":"https://api.github.com/users/terorie","html_url":"https://github.com/terorie","followers_url":"https://api.github.com/users/terorie/followers","following_url":"https://api.github.com/users/terorie/following{/other_user}","gists_url":"https://api.github.com/users/terorie/gists{/gist_id}","starred_url":"https://api.github.com/users/terorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terorie/subscriptions","organizations_url":"https://api.github.com/users/terorie/orgs","repos_url":"https://api.github.com/users/terorie/repos","events_url":"https://api.github.com/users/terorie/events{/privacy}","received_events_url":"https://api.github.com/users/terorie/received_events","type":"User","site_admin":false},"repo":{"id":132665722,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI2NjU3MjI=","name":"nimiq-core","full_name":"terorie/nimiq-core","private":false,"owner":{"login":"terorie","id":21371810,"node_id":"MDQ6VXNlcjIxMzcxODEw","avatar_url":"https://avatars1.githubusercontent.com/u/21371810?v=4","gravatar_id":"","url":"https://api.github.com/users/terorie","html_url":"https://github.com/terorie","followers_url":"https://api.github.com/users/terorie/followers","following_url":"https://api.github.com/users/terorie/following{/other_user}","gists_url":"https://api.github.com/users/terorie/gists{/gist_id}","starred_url":"https://api.github.com/users/terorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terorie/subscriptions","organizations_url":"https://api.github.com/users/terorie/orgs","repos_url":"https://api.github.com/users/terorie/repos","events_url":"https://api.github.com/users/terorie/events{/privacy}","received_events_url":"https://api.github.com/users/terorie/received_events","type":"User","site_admin":false},"html_url":"https://github.com/terorie/nimiq-core","description":"Nimiq: the browser-based blockchain","fork":true,"url":"https://api.github.com/repos/terorie/nimiq-core","forks_url":"https://api.github.com/repos/terorie/nimiq-core/forks","keys_url":"https://api.github.com/repos/terorie/nimiq-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terorie/nimiq-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terorie/nimiq-core/teams","hooks_url":"https://api.github.com/repos/terorie/nimiq-core/hooks","issue_events_url":"https://api.github.com/repos/terorie/nimiq-core/issues/events{/number}","events_url":"https://api.github.com/repos/terorie/nimiq-core/events","assignees_url":"https://api.github.com/repos/terorie/nimiq-core/assignees{/user}","branches_url":"https://api.github.com/repos/terorie/nimiq-core/branches{/branch}","tags_url":"https://api.github.com/repos/terorie/nimiq-core/tags","blobs_url":"https://api.github.com/repos/terorie/nimiq-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terorie/nimiq-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terorie/nimiq-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/terorie/nimiq-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terorie/nimiq-core/statuses/{sha}","languages_url":"https://api.github.com/repos/terorie/nimiq-core/languages","stargazers_url":"https://api.github.com/repos/terorie/nimiq-core/stargazers","contributors_url":"https://api.github.com/repos/terorie/nimiq-core/contributors","subscribers_url":"https://api.github.com/repos/terorie/nimiq-core/subscribers","subscription_url":"https://api.github.com/repos/terorie/nimiq-core/subscription","commits_url":"https://api.github.com/repos/terorie/nimiq-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/terorie/nimiq-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/terorie/nimiq-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/terorie/nimiq-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/terorie/nimiq-core/contents/{+path}","compare_url":"https://api.github.com/repos/terorie/nimiq-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terorie/nimiq-core/merges","archive_url":"https://api.github.com/repos/terorie/nimiq-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terorie/nimiq-core/downloads","issues_url":"https://api.github.com/repos/terorie/nimiq-core/issues{/number}","pulls_url":"https://api.github.com/repos/terorie/nimiq-core/pulls{/number}","milestones_url":"https://api.github.com/repos/terorie/nimiq-core/milestones{/number}","notifications_url":"https://api.github.com/repos/terorie/nimiq-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terorie/nimiq-core/labels{/name}","releases_url":"https://api.github.com/repos/terorie/nimiq-core/releases{/id}","deployments_url":"https://api.github.com/repos/terorie/nimiq-core/deployments","created_at":"2018-05-08T21:11:30Z","updated_at":"2018-09-15T10:17:59Z","pushed_at":"2018-12-25T15:36:58Z","git_url":"git://github.com/terorie/nimiq-core.git","ssh_url":"git@github.com:terorie/nimiq-core.git","clone_url":"https://github.com/terorie/nimiq-core.git","svn_url":"https://github.com/terorie/nimiq-core","homepage":"https://nimiq.com","size":11733,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"cpudetect"}},"base":{"label":"nimiq-network:master","ref":"master","sha":"a21f4298ba437fa454ada33994072143a9d8d913","user":{"login":"nimiq-network","id":28575512,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTc1NTEy","avatar_url":"https://avatars1.githubusercontent.com/u/28575512?v=4","gravatar_id":"","url":"https://api.github.com/users/nimiq-network","html_url":"https://github.com/nimiq-network","followers_url":"https://api.github.com/users/nimiq-network/followers","following_url":"https://api.github.com/users/nimiq-network/following{/other_user}","gists_url":"https://api.github.com/users/nimiq-network/gists{/gist_id}","starred_url":"https://api.github.com/users/nimiq-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimiq-network/subscriptions","organizations_url":"https://api.github.com/users/nimiq-network/orgs","repos_url":"https://api.github.com/users/nimiq-network/repos","events_url":"https://api.github.com/users/nimiq-network/events{/privacy}","received_events_url":"https://api.github.com/users/nimiq-network/received_events","type":"Organization","site_admin":false},"repo":{"id":90784559,"node_id":"MDEwOlJlcG9zaXRvcnk5MDc4NDU1OQ==","name":"core","full_name":"nimiq-network/core","private":false,"owner":{"login":"nimiq-network","id":28575512,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTc1NTEy","avatar_url":"https://avatars1.githubusercontent.com/u/28575512?v=4","gravatar_id":"","url":"https://api.github.com/users/nimiq-network","html_url":"https://github.com/nimiq-network","followers_url":"https://api.github.com/users/nimiq-network/followers","following_url":"https://api.github.com/users/nimiq-network/following{/other_user}","gists_url":"https://api.github.com/users/nimiq-network/gists{/gist_id}","starred_url":"https://api.github.com/users/nimiq-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimiq-network/subscriptions","organizations_url":"https://api.github.com/users/nimiq-network/orgs","repos_url":"https://api.github.com/users/nimiq-network/repos","events_url":"https://api.github.com/users/nimiq-network/events{/privacy}","received_events_url":"https://api.github.com/users/nimiq-network/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nimiq-network/core","description":"Nimiq: the browser-based blockchain","fork":false,"url":"https://api.github.com/repos/nimiq-network/core","forks_url":"https://api.github.com/repos/nimiq-network/core/forks","keys_url":"https://api.github.com/repos/nimiq-network/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nimiq-network/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nimiq-network/core/teams","hooks_url":"https://api.github.com/repos/nimiq-network/core/hooks","issue_events_url":"https://api.github.com/repos/nimiq-network/core/issues/events{/number}","events_url":"https://api.github.com/repos/nimiq-network/core/events","assignees_url":"https://api.github.com/repos/nimiq-network/core/assignees{/user}","branches_url":"https://api.github.com/repos/nimiq-network/core/branches{/branch}","tags_url":"https://api.github.com/repos/nimiq-network/core/tags","blobs_url":"https://api.github.com/repos/nimiq-network/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nimiq-network/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nimiq-network/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/nimiq-network/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nimiq-network/core/statuses/{sha}","languages_url":"https://api.github.com/repos/nimiq-network/core/languages","stargazers_url":"https://api.github.com/repos/nimiq-network/core/stargazers","contributors_url":"https://api.github.com/repos/nimiq-network/core/contributors","subscribers_url":"https://api.github.com/repos/nimiq-network/core/subscribers","subscription_url":"https://api.github.com/repos/nimiq-network/core/subscription","commits_url":"https://api.github.com/repos/nimiq-network/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/nimiq-network/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/nimiq-network/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/nimiq-network/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/nimiq-network/core/contents/{+path}","compare_url":"https://api.github.com/repos/nimiq-network/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nimiq-network/core/merges","archive_url":"https://api.github.com/repos/nimiq-network/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nimiq-network/core/downloads","issues_url":"https://api.github.com/repos/nimiq-network/core/issues{/number}","pulls_url":"https://api.github.com/repos/nimiq-network/core/pulls{/number}","milestones_url":"https://api.github.com/repos/nimiq-network/core/milestones{/number}","notifications_url":"https://api.github.com/repos/nimiq-network/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nimiq-network/core/labels{/name}","releases_url":"https://api.github.com/repos/nimiq-network/core/releases{/id}","deployments_url":"https://api.github.com/repos/nimiq-network/core/deployments","created_at":"2017-05-09T19:33:54Z","updated_at":"2018-12-23T14:40:38Z","pushed_at":"2018-12-23T14:40:34Z","git_url":"git://github.com/nimiq-network/core.git","ssh_url":"git@github.com:nimiq-network/core.git","clone_url":"https://github.com/nimiq-network/core.git","svn_url":"https://github.com/nimiq-network/core","homepage":"https://nimiq.com","size":11822,"stargazers_count":895,"watchers_count":895,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":191,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":191,"open_issues":22,"watchers":895,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nimiq-network/core/pulls/460"},"html":{"href":"https://github.com/nimiq-network/core/pull/460"},"issue":{"href":"https://api.github.com/repos/nimiq-network/core/issues/460"},"comments":{"href":"https://api.github.com/repos/nimiq-network/core/issues/460/comments"},"review_comments":{"href":"https://api.github.com/repos/nimiq-network/core/pulls/460/comments"},"review_comment":{"href":"https://api.github.com/repos/nimiq-network/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nimiq-network/core/pulls/460/commits"},"statuses":{"href":"https://api.github.com/repos/nimiq-network/core/statuses/aaf95eb2abca2d6d965412f5a37f1877a1d0d56a"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":44,"deletions":16,"changed_files":5}}
{"actor":{"display_login":"terorie"}}