{"action":"closed","number":4713,"pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2/pulls/4713","id":198911045,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4OTExMDQ1","html_url":"https://github.com/libgit2/libgit2/pull/4713","diff_url":"https://github.com/libgit2/libgit2/pull/4713.diff","patch_url":"https://github.com/libgit2/libgit2/pull/4713.patch","issue_url":"https://api.github.com/repos/libgit2/libgit2/issues/4713","number":4713,"state":"closed","locked":false,"title":"Support symlinks on Windows when core.symlinks=true","user":{"login":"ethomson","id":1130014,"node_id":"MDQ6VXNlcjExMzAwMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1130014?v=4","gravatar_id":"","url":"https://api.github.com/users/ethomson","html_url":"https://github.com/ethomson","followers_url":"https://api.github.com/users/ethomson/followers","following_url":"https://api.github.com/users/ethomson/following{/other_user}","gists_url":"https://api.github.com/users/ethomson/gists{/gist_id}","starred_url":"https://api.github.com/users/ethomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethomson/subscriptions","organizations_url":"https://api.github.com/users/ethomson/orgs","repos_url":"https://api.github.com/users/ethomson/repos","events_url":"https://api.github.com/users/ethomson/events{/privacy}","received_events_url":"https://api.github.com/users/ethomson/received_events","type":"User","site_admin":false},"body":"Windows 10 enables non-Administrator users to create symbolic links when Developer Mode is enabled.  Git for Windows supports this scenario when `core.symlinks=true`.\r\n\r\nSimilarly, we should support creation of proper symbolic links on Windows when `core.symlinks=true`.  This is as simple as implementing `p_symlink` properly, as checkout already behaves properly, examining `core.symlinks` and creating a fake symlink when `core.symlinks=false` (and creating a true symbolic link otherwise).\r\n\r\nThis is not ready for merge:  at present, Git for Windows requires a configuration setting `core.symlinks` in a global configuration area to enable automatic detection of symbolic links during repository initialization.\r\n\r\nThis probably makes sense: if a repository is created by Administrator - who has symbolic link creation privileges - you may still want to set `core.symlinks=false` on Windows since there is no suggestion that non-Administrator users will be able to use symbolic links.\r\n\r\nHowever, there is some thought of changing this in Git for Windows (https://github.com/git-for-windows/git/pull/1744).  So let's wait for that to be decided - if they change their behavior, then this will be ready for merge.  If not, we will need to modify this PR to adopt their existing behavior.","created_at":"2018-07-03T10:00:08Z","updated_at":"2018-11-15T09:17:52Z","closed_at":"2018-11-15T09:17:51Z","merged_at":"2018-11-15T09:17:51Z","merge_commit_sha":"7321cff05df927c8d00755ef21289ec00d125c9c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libgit2/libgit2/pulls/4713/commits","review_comments_url":"https://api.github.com/repos/libgit2/libgit2/pulls/4713/comments","review_comment_url":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libgit2/libgit2/issues/4713/comments","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/da500cc607f1f30cea822087f3aaeb6b6727ff74","head":{"label":"libgit2:ethomson/win_symlinks","ref":"ethomson/win_symlinks","sha":"da500cc607f1f30cea822087f3aaeb6b6727ff74","user":{"login":"libgit2","id":394745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDc0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/394745?v=4","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"repo":{"id":901662,"node_id":"MDEwOlJlcG9zaXRvcnk5MDE2NjI=","name":"libgit2","full_name":"libgit2/libgit2","private":false,"owner":{"login":"libgit2","id":394745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDc0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/394745?v=4","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/libgit2/libgit2","description":"A cross-platform, linkable library implementation of Git that you can use in your application.","fork":false,"url":"https://api.github.com/repos/libgit2/libgit2","forks_url":"https://api.github.com/repos/libgit2/libgit2/forks","keys_url":"https://api.github.com/repos/libgit2/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgit2/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgit2/libgit2/teams","hooks_url":"https://api.github.com/repos/libgit2/libgit2/hooks","issue_events_url":"https://api.github.com/repos/libgit2/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/libgit2/libgit2/events","assignees_url":"https://api.github.com/repos/libgit2/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/libgit2/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/libgit2/libgit2/tags","blobs_url":"https://api.github.com/repos/libgit2/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgit2/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgit2/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgit2/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/libgit2/libgit2/languages","stargazers_url":"https://api.github.com/repos/libgit2/libgit2/stargazers","contributors_url":"https://api.github.com/repos/libgit2/libgit2/contributors","subscribers_url":"https://api.github.com/repos/libgit2/libgit2/subscribers","subscription_url":"https://api.github.com/repos/libgit2/libgit2/subscription","commits_url":"https://api.github.com/repos/libgit2/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgit2/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgit2/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgit2/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgit2/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/libgit2/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgit2/libgit2/merges","archive_url":"https://api.github.com/repos/libgit2/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgit2/libgit2/downloads","issues_url":"https://api.github.com/repos/libgit2/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/libgit2/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/libgit2/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/libgit2/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgit2/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/libgit2/libgit2/releases{/id}","deployments_url":"https://api.github.com/repos/libgit2/libgit2/deployments","created_at":"2010-09-10T16:17:48Z","updated_at":"2018-11-15T08:52:15Z","pushed_at":"2018-11-15T09:17:51Z","git_url":"git://github.com/libgit2/libgit2.git","ssh_url":"git@github.com:libgit2/libgit2.git","clone_url":"https://github.com/libgit2/libgit2.git","svn_url":"https://github.com/libgit2/libgit2","homepage":"https://libgit2.org/","size":41102,"stargazers_count":6696,"watchers_count":6696,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1698,"mirror_url":null,"archived":false,"open_issues_count":251,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1698,"open_issues":251,"watchers":6696,"default_branch":"master"}},"base":{"label":"libgit2:master","ref":"master","sha":"0fccf0179dadadc63006902c5acb4fb34873dadd","user":{"login":"libgit2","id":394745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDc0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/394745?v=4","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"repo":{"id":901662,"node_id":"MDEwOlJlcG9zaXRvcnk5MDE2NjI=","name":"libgit2","full_name":"libgit2/libgit2","private":false,"owner":{"login":"libgit2","id":394745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDc0NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/394745?v=4","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/libgit2/libgit2","description":"A cross-platform, linkable library implementation of Git that you can use in your application.","fork":false,"url":"https://api.github.com/repos/libgit2/libgit2","forks_url":"https://api.github.com/repos/libgit2/libgit2/forks","keys_url":"https://api.github.com/repos/libgit2/libgit2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgit2/libgit2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgit2/libgit2/teams","hooks_url":"https://api.github.com/repos/libgit2/libgit2/hooks","issue_events_url":"https://api.github.com/repos/libgit2/libgit2/issues/events{/number}","events_url":"https://api.github.com/repos/libgit2/libgit2/events","assignees_url":"https://api.github.com/repos/libgit2/libgit2/assignees{/user}","branches_url":"https://api.github.com/repos/libgit2/libgit2/branches{/branch}","tags_url":"https://api.github.com/repos/libgit2/libgit2/tags","blobs_url":"https://api.github.com/repos/libgit2/libgit2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgit2/libgit2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgit2/libgit2/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgit2/libgit2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgit2/libgit2/statuses/{sha}","languages_url":"https://api.github.com/repos/libgit2/libgit2/languages","stargazers_url":"https://api.github.com/repos/libgit2/libgit2/stargazers","contributors_url":"https://api.github.com/repos/libgit2/libgit2/contributors","subscribers_url":"https://api.github.com/repos/libgit2/libgit2/subscribers","subscription_url":"https://api.github.com/repos/libgit2/libgit2/subscription","commits_url":"https://api.github.com/repos/libgit2/libgit2/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgit2/libgit2/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgit2/libgit2/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgit2/libgit2/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgit2/libgit2/contents/{+path}","compare_url":"https://api.github.com/repos/libgit2/libgit2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgit2/libgit2/merges","archive_url":"https://api.github.com/repos/libgit2/libgit2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgit2/libgit2/downloads","issues_url":"https://api.github.com/repos/libgit2/libgit2/issues{/number}","pulls_url":"https://api.github.com/repos/libgit2/libgit2/pulls{/number}","milestones_url":"https://api.github.com/repos/libgit2/libgit2/milestones{/number}","notifications_url":"https://api.github.com/repos/libgit2/libgit2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgit2/libgit2/labels{/name}","releases_url":"https://api.github.com/repos/libgit2/libgit2/releases{/id}","deployments_url":"https://api.github.com/repos/libgit2/libgit2/deployments","created_at":"2010-09-10T16:17:48Z","updated_at":"2018-11-15T08:52:15Z","pushed_at":"2018-11-15T09:17:51Z","git_url":"git://github.com/libgit2/libgit2.git","ssh_url":"git@github.com:libgit2/libgit2.git","clone_url":"https://github.com/libgit2/libgit2.git","svn_url":"https://github.com/libgit2/libgit2","homepage":"https://libgit2.org/","size":41102,"stargazers_count":6696,"watchers_count":6696,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1698,"mirror_url":null,"archived":false,"open_issues_count":251,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1698,"open_issues":251,"watchers":6696,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/4713"},"html":{"href":"https://github.com/libgit2/libgit2/pull/4713"},"issue":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/4713"},"comments":{"href":"https://api.github.com/repos/libgit2/libgit2/issues/4713/comments"},"review_comments":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/4713/comments"},"review_comment":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libgit2/libgit2/pulls/4713/commits"},"statuses":{"href":"https://api.github.com/repos/libgit2/libgit2/statuses/da500cc607f1f30cea822087f3aaeb6b6727ff74"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ethomson","id":1130014,"node_id":"MDQ6VXNlcjExMzAwMTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1130014?v=4","gravatar_id":"","url":"https://api.github.com/users/ethomson","html_url":"https://github.com/ethomson","followers_url":"https://api.github.com/users/ethomson/followers","following_url":"https://api.github.com/users/ethomson/following{/other_user}","gists_url":"https://api.github.com/users/ethomson/gists{/gist_id}","starred_url":"https://api.github.com/users/ethomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethomson/subscriptions","organizations_url":"https://api.github.com/users/ethomson/orgs","repos_url":"https://api.github.com/users/ethomson/repos","events_url":"https://api.github.com/users/ethomson/events{/privacy}","received_events_url":"https://api.github.com/users/ethomson/received_events","type":"User","site_admin":false},"comments":3,"review_comments":11,"maintainer_can_modify":false,"commits":12,"additions":331,"deletions":198,"changed_files":9}}
{"actor":{"display_login":"ethomson"}}