{"action":"created","issue":{"url":"https://api.github.com/repos/UCL/STIR/issues/211","repository_url":"https://api.github.com/repos/UCL/STIR","labels_url":"https://api.github.com/repos/UCL/STIR/issues/211/labels{/name}","comments_url":"https://api.github.com/repos/UCL/STIR/issues/211/comments","events_url":"https://api.github.com/repos/UCL/STIR/issues/211/events","html_url":"https://github.com/UCL/STIR/issues/211","id":337764234,"node_id":"MDU6SXNzdWUzMzc3NjQyMzQ=","number":211,"title":"STIR registries files are not installed (STIR_REGISTRIES points to original sources)","user":{"login":"KrisThielemans","id":6362141,"node_id":"MDQ6VXNlcjYzNjIxNDE=","avatar_url":"https://avatars2.githubusercontent.com/u/6362141?v=4","gravatar_id":"","url":"https://api.github.com/users/KrisThielemans","html_url":"https://github.com/KrisThielemans","followers_url":"https://api.github.com/users/KrisThielemans/followers","following_url":"https://api.github.com/users/KrisThielemans/following{/other_user}","gists_url":"https://api.github.com/users/KrisThielemans/gists{/gist_id}","starred_url":"https://api.github.com/users/KrisThielemans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrisThielemans/subscriptions","organizations_url":"https://api.github.com/users/KrisThielemans/orgs","repos_url":"https://api.github.com/users/KrisThielemans/repos","events_url":"https://api.github.com/users/KrisThielemans/events{/privacy}","received_events_url":"https://api.github.com/users/KrisThielemans/received_events","type":"User","site_admin":false},"labels":[{"id":266111815,"node_id":"MDU6TGFiZWwyNjYxMTE4MTU=","url":"https://api.github.com/repos/UCL/STIR/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/UCL/STIR/milestones/1","html_url":"https://github.com/UCL/STIR/milestone/1","labels_url":"https://api.github.com/repos/UCL/STIR/milestones/1/labels","id":2655408,"node_id":"MDk6TWlsZXN0b25lMjY1NTQwOA==","number":1,"title":"v4.0","description":"","creator":{"login":"KrisThielemans","id":6362141,"node_id":"MDQ6VXNlcjYzNjIxNDE=","avatar_url":"https://avatars2.githubusercontent.com/u/6362141?v=4","gravatar_id":"","url":"https://api.github.com/users/KrisThielemans","html_url":"https://github.com/KrisThielemans","followers_url":"https://api.github.com/users/KrisThielemans/followers","following_url":"https://api.github.com/users/KrisThielemans/following{/other_user}","gists_url":"https://api.github.com/users/KrisThielemans/gists{/gist_id}","starred_url":"https://api.github.com/users/KrisThielemans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrisThielemans/subscriptions","organizations_url":"https://api.github.com/users/KrisThielemans/orgs","repos_url":"https://api.github.com/users/KrisThielemans/repos","events_url":"https://api.github.com/users/KrisThielemans/events{/privacy}","received_events_url":"https://api.github.com/users/KrisThielemans/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":23,"state":"open","created_at":"2017-07-21T22:28:30Z","updated_at":"2018-07-03T06:41:21Z","due_on":"2018-03-12T07:00:00Z","closed_at":null},"comments":7,"created_at":"2018-07-03T06:41:21Z","updated_at":"2018-07-06T07:55:15Z","closed_at":null,"author_association":"COLLABORATOR","body":"`STIR_REGISTRIES` is a CMake variable that lists all .cxx files that add items to registries, e.g. for IO, see the _Registries of classes_  section in the STIR developers guide.\r\n\r\nAt present, we do not install these files. However, anyone who uses an installed version of STIR will need them for IO, filtering etc to work. Therefore, at present, an **installed version of STIR will only work on the original developer's machine** (if she doesn't delete the source files).\r\n\r\nInstalling source files is \"not done\" however. Where would we put them?\r\n\r\nIf we'd install them, we'll have to adjust the variable in [STIRConfig.cmake.in](https://github.com/UCL/STIR/blob/4e0a2e89f2dfda87106cb13d14081b70d50dc0d4/src/cmake/STIRConfig.cmake.in#L39)\r\n"},"comment":{"url":"https://api.github.com/repos/UCL/STIR/issues/comments/402957182","html_url":"https://github.com/UCL/STIR/issues/211#issuecomment-402957182","issue_url":"https://api.github.com/repos/UCL/STIR/issues/211","id":402957182,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjk1NzE4Mg==","user":{"login":"KrisThielemans","id":6362141,"node_id":"MDQ6VXNlcjYzNjIxNDE=","avatar_url":"https://avatars2.githubusercontent.com/u/6362141?v=4","gravatar_id":"","url":"https://api.github.com/users/KrisThielemans","html_url":"https://github.com/KrisThielemans","followers_url":"https://api.github.com/users/KrisThielemans/followers","following_url":"https://api.github.com/users/KrisThielemans/following{/other_user}","gists_url":"https://api.github.com/users/KrisThielemans/gists{/gist_id}","starred_url":"https://api.github.com/users/KrisThielemans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrisThielemans/subscriptions","organizations_url":"https://api.github.com/users/KrisThielemans/orgs","repos_url":"https://api.github.com/users/KrisThielemans/repos","events_url":"https://api.github.com/users/KrisThielemans/events{/privacy}","received_events_url":"https://api.github.com/users/KrisThielemans/received_events","type":"User","site_admin":false},"created_at":"2018-07-06T07:55:15Z","updated_at":"2018-07-06T07:55:15Z","author_association":"COLLABORATOR","body":"only the registration sources. let's not install anything else. I agree that `${CMAKE_INSTALL_PREFIX}/share/stir` is a good place. I guess it makes most sense to just preserver directory structure.\r\n\r\nAs people using the `${STIR_LOCAL}/extra_dirs.cmake` might have registries themselves (I do), it might be best to add the `INSTALL` targets in a loop over all files in `STIR_REGISTRIES`.\r\n\r\nthe somewhat tricky bit is to adapt the `STIR_REGISTRIES` in the `STIRConfig.cmake.in`. Might need some generator expressions.\r\n\r\nnot a trivial exercise...\r\n\r\nIt isn't really on the list of things for the hackathon, but we can certainly use it to solve some of those \"small\" issues with a few people."}}
{"actor":{"display_login":"KrisThielemans"}}