{"action":"created","issue":{"url":"https://api.github.com/repos/openwrt/telephony/issues/396","repository_url":"https://api.github.com/repos/openwrt/telephony","labels_url":"https://api.github.com/repos/openwrt/telephony/issues/396/labels{/name}","comments_url":"https://api.github.com/repos/openwrt/telephony/issues/396/comments","events_url":"https://api.github.com/repos/openwrt/telephony/issues/396/events","html_url":"https://github.com/openwrt/telephony/pull/396","id":391183911,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4Nzc4Njk0","number":396,"title":"asterisk updates","user":{"login":"dhewg","id":605548,"node_id":"MDQ6VXNlcjYwNTU0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/605548?v=4","gravatar_id":"","url":"https://api.github.com/users/dhewg","html_url":"https://github.com/dhewg","followers_url":"https://api.github.com/users/dhewg/followers","following_url":"https://api.github.com/users/dhewg/following{/other_user}","gists_url":"https://api.github.com/users/dhewg/gists{/gist_id}","starred_url":"https://api.github.com/users/dhewg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhewg/subscriptions","organizations_url":"https://api.github.com/users/dhewg/orgs","repos_url":"https://api.github.com/users/dhewg/repos","events_url":"https://api.github.com/users/dhewg/events{/privacy}","received_events_url":"https://api.github.com/users/dhewg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-14T16:41:21Z","updated_at":"2018-12-16T09:57:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openwrt/telephony/pulls/396","html_url":"https://github.com/openwrt/telephony/pull/396","diff_url":"https://github.com/openwrt/telephony/pull/396.diff","patch_url":"https://github.com/openwrt/telephony/pull/396.patch"},"body":"Maintainer: @jslachta\r\nCompile tested: sunxi, master\r\nRun tested: sunxi, master\r\n\r\nDescription:\r\nThis updates both asterisk versions to the current release. These versions now support pjproject 2.8, so update that too.\r\n\r\nasterisk-13.x was only compile time tested, while asterisk-15.x was updated on my sunxi cubieboard2 setup.\r\n\r\nThanks!\r\nAndre"},"comment":{"url":"https://api.github.com/repos/openwrt/telephony/issues/comments/447630176","html_url":"https://github.com/openwrt/telephony/pull/396#issuecomment-447630176","issue_url":"https://api.github.com/repos/openwrt/telephony/issues/396","id":447630176,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzYzMDE3Ng==","user":{"login":"micmac1","id":10446172,"node_id":"MDQ6VXNlcjEwNDQ2MTcy","avatar_url":"https://avatars2.githubusercontent.com/u/10446172?v=4","gravatar_id":"","url":"https://api.github.com/users/micmac1","html_url":"https://github.com/micmac1","followers_url":"https://api.github.com/users/micmac1/followers","following_url":"https://api.github.com/users/micmac1/following{/other_user}","gists_url":"https://api.github.com/users/micmac1/gists{/gist_id}","starred_url":"https://api.github.com/users/micmac1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micmac1/subscriptions","organizations_url":"https://api.github.com/users/micmac1/orgs","repos_url":"https://api.github.com/users/micmac1/repos","events_url":"https://api.github.com/users/micmac1/events{/privacy}","received_events_url":"https://api.github.com/users/micmac1/received_events","type":"User","site_admin":false},"created_at":"2018-12-16T09:57:49Z","updated_at":"2018-12-16T09:57:49Z","author_association":"COLLABORATOR","body":"Hello Andre,\r\n\r\nThank you for the pull request!\r\n\r\nSmall nitpick: upstream added a new module to asterisk 15. Could you add this to your pull request? Details below.\r\n\r\nOtherwise looks good to me.\r\n\r\nKind regards,\r\nSeb\r\n\r\n```\r\ndiff --git a/net/asterisk-15.x/Makefile b/net/asterisk-15.x/Makefile\r\nindex b2b5bc0..d00550d 100644\r\n--- a/net/asterisk-15.x/Makefile\r\n+++ b/net/asterisk-15.x/Makefile\r\n@@ -273,6 +273,7 @@ MODULES_AVAILABLE:= \\\r\n        res-pjproject \\\r\n        res-pktccops \\\r\n        res-realtime \\\r\n+       res_remb_modifier \\\r\n        res-resolver-unbound \\\r\n        res-rtp-asterisk \\\r\n        res-rtp-multicast \\\r\n@@ -974,6 +975,7 @@ $(eval $(call BuildAsterisk15Module,res-pjsip-phoneprov,PJSIP Phone Provisioning\r\n $(eval $(call BuildAsterisk15Module,res-pjproject,Bridge PJPROJECT to Asterisk logging,,+libpj +libpjlib-util +libpjmedia +libpjmedia +libpjnath +libpjsip-simple +libpjsip-ua +libpjsip +libpjsua +libpjsua2 +libsrtp2,pjproject.conf,res_pjproject,,))\r\n $(eval $(call BuildAsterisk15Module,res-pktccops,PktcCOPS manager for MGCP,PacketCable MGCP variation / NCS,,res_pktccops.conf,res_pktccops,,))\r\n $(eval $(call BuildAsterisk15Module,res-realtime,RealTime CLI,RealTime CLI,,,res_realtime,,))\r\n+$(eval $(call BuildAsterisk15Module,res_remb_modifier,REMB modifier,REMB modifier,,,res_remb_modifier,,))\r\n $(eval $(call BuildAsterisk15Module,res-resolver-unbound,Unbound DNS resolver,Unbound DNS resolver,+libunbound,resolver_unbound.conf,res_resolver_unbound,,))\r\n $(eval $(call BuildAsterisk15Module,res-rtp-asterisk,RTP stack,Supports RTP and RTCP with Symmetric RTP support for NAT traversal,+libpjsip +libpjmedia +libpjnath +libpjsip-simple +libpjsip-ua +libpjsua +libpjsua2,rtp.conf,res_rtp_asterisk,,))\r\n $(eval $(call BuildAsterisk15Module,res-rtp-multicast,RTP multicast engine,Multicast RTP Engine,,,res_rtp_multicast,,))\r\n```"}}
{"actor":{"display_login":"micmac1"}}