{"action":"created","issue":{"url":"https://api.github.com/repos/opensourcepos/opensourcepos/issues/1875","repository_url":"https://api.github.com/repos/opensourcepos/opensourcepos","labels_url":"https://api.github.com/repos/opensourcepos/opensourcepos/issues/1875/labels{/name}","comments_url":"https://api.github.com/repos/opensourcepos/opensourcepos/issues/1875/comments","events_url":"https://api.github.com/repos/opensourcepos/opensourcepos/issues/1875/events","html_url":"https://github.com/opensourcepos/opensourcepos/issues/1875","id":301849300,"number":1875,"title":"It is unethical and potentially illegal to disable someone's install.","user":{"login":"jimktrains","id":40850,"avatar_url":"https://avatars2.githubusercontent.com/u/40850?v=4","gravatar_id":"","url":"https://api.github.com/users/jimktrains","html_url":"https://github.com/jimktrains","followers_url":"https://api.github.com/users/jimktrains/followers","following_url":"https://api.github.com/users/jimktrains/following{/other_user}","gists_url":"https://api.github.com/users/jimktrains/gists{/gist_id}","starred_url":"https://api.github.com/users/jimktrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimktrains/subscriptions","organizations_url":"https://api.github.com/users/jimktrains/orgs","repos_url":"https://api.github.com/users/jimktrains/repos","events_url":"https://api.github.com/users/jimktrains/events{/privacy}","received_events_url":"https://api.github.com/users/jimktrains/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-03-02T17:46:08Z","updated_at":"2018-03-03T15:14:18Z","closed_at":"2018-03-02T19:33:24Z","author_association":"NONE","body":"https://github.com/opensourcepos/opensourcepos/blob/32074771acad1fa66af34e629f8668a83e9fdc98/application/controllers/Login.php#L114\r\n\r\nAdditionally, this check is faulty.  I added some additional information to the footer (the current register and shop) and trigger this along with an issue with blockUI. I am entirely compliant with the license as I have not touched the text originally present."},"comment":{"url":"https://api.github.com/repos/opensourcepos/opensourcepos/issues/comments/370154595","html_url":"https://github.com/opensourcepos/opensourcepos/issues/1875#issuecomment-370154595","issue_url":"https://api.github.com/repos/opensourcepos/opensourcepos/issues/1875","id":370154595,"user":{"login":"jimktrains","id":40850,"avatar_url":"https://avatars2.githubusercontent.com/u/40850?v=4","gravatar_id":"","url":"https://api.github.com/users/jimktrains","html_url":"https://github.com/jimktrains","followers_url":"https://api.github.com/users/jimktrains/followers","following_url":"https://api.github.com/users/jimktrains/following{/other_user}","gists_url":"https://api.github.com/users/jimktrains/gists{/gist_id}","starred_url":"https://api.github.com/users/jimktrains/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimktrains/subscriptions","organizations_url":"https://api.github.com/users/jimktrains/orgs","repos_url":"https://api.github.com/users/jimktrains/repos","events_url":"https://api.github.com/users/jimktrains/events{/privacy}","received_events_url":"https://api.github.com/users/jimktrains/received_events","type":"User","site_admin":false},"created_at":"2018-03-03T15:14:18Z","updated_at":"2018-03-03T15:14:18Z","author_association":"NONE","body":"@daN4cat I was refering to when @mckaygerhard said \"yeah the license said MIT.. well lest analize, ospos make you cheap some money.. and you claim that its ilegal..\" not specifically anything in your message. (It's also not an MIT license. It's based on the MIT license, but that's neither here nor there right now as I'm not objecting to the change.)\r\n\r\n@marcellusmontilla A stock part of the software disabled the rest of the software because I made a change that is compliant with the license.  The license says \r\n\r\n> The footer signature \"You are using Open Source Point Of Sale\" with version, hash and link to the original distribution of the code MUST BE RETAINED, MUST BE VISIBLE IN EVERY PAGE and CANNOT BE MODIFIED.\r\n\r\nI retained this information with no modifications to the div that contains it, just an addition to the <div id=\"footer\">. Not, I didn't even edit the div that directly contains the message in question, just the one tagged as the footer.\r\n\r\n@mckaygerhard every single one of your solutions is a non-obvious solution to a problem that shouldn't exist. i.e.\r\n\r\n1) I don't want them in the header, so why would I think to put them there. (No technical basis is present to point to this as a good/better option.)\r\n2) I wanted the message of what software is being used to show first, so why would I think to put it above said message. (No technical basis is present to point to this as a good/better option.)\r\n\r\n3) I didn't add any CSS, so I'm not sure what's conflicting.\r\n\r\n4) I have no idea what you mean, but yes, an empty overlay and no console message or visible message is extremely frustrating.\r\n\r\nMoreover, these are all options _after_ I find out that the code disables itself when anything is added to the footer (after the OSPOS message?).  Sure, I have options, but I also have the option of removing all of these silly checks, which I did so that they don't randomly bite us in the butt.  Luckily I went to test my stuff a little more before showing it to our brass (problems only manifest after logging in and not while I had an active session.) Otherwise our brass would have seen software that \"self destructs\" when you change it and would have unanimously thumbs down me doing any more work with it.\r\n\r\nThis is not the message you want to send. If someone wants to remove the attribution line they will and can. Perhaps add a comment above the div reminding the user that the terms of the license prohibit modifying the following div. An honest person will abide. A dishonest person won't. A dishonest person will also just disable your checks when it fails.  I happen to be an honest person bit by an edge-case in your opensource-anti-piracy code and had to disable said checks anyway.\r\n\r\n> also i agree with @daN4cat to stop the ones that really want a free meal without neither using their brain. (most windozers users are like)\r\n\r\nTo be honest, that's a risk you take with open source software. Being actively user-hostile (even when they're compliant with the license!) is not a good approach. Even if you had a better license, like the GPL, you still can't stop anyone with even a quarter brain from doing what they wish with the software.\r\n\r\nIt's also very insulting and annoying to read \"windoze\" and makes you come across as childish."}}
{"actor":{"display_login":"jimktrains"}}