{"action":"created","comment":{"url":"https://api.github.com/repos/strimzi/strimzi/pulls/comments/170240775","pull_request_review_id":98898918,"id":170240775,"diff_hunk":"@@ -230,16 +290,49 @@ public void create(String namespace, String name, Handler<AsyncResult<Void>> han\n         }\n     };\n \n+    private final CompositeOperation<TopicController> deleteTopicController = new CompositeOperation<TopicController>() {\n+\n+        @Override\n+        public Future<?> composite(String namespace, ClusterOperation<TopicController> clusterOp) {\n+            TopicController topicController = clusterOp.cluster();\n+            Future<Void> fut = deploymentOperations.delete(namespace, topicController.getName());\n+            return fut;\n+        }\n+\n+        @Override\n+        public ClusterOperation<TopicController> getCluster(String namespace, String name) {\n+            Deployment dep = deploymentOperations.get(namespace, TopicController.topicControllerName(name));\n+            return new ClusterOperation<>(TopicController.fromDeployment(namespace, name, dep), null);\n+        }\n+    };\n+\n     @Override\n     protected void delete(String namespace, String name, Handler<AsyncResult<Void>> handler) {\n-        execute(CLUSTER_TYPE_KAFKA, OP_DELETE, namespace, name, deleteKafka, ar -> {\n-            if (ar.failed()) {\n-                handler.handle(ar);\n-            } else {\n-                execute(CLUSTER_TYPE_ZOOKEEPER, OP_DELETE, namespace, name, deleteZk, handler);\n-            }\n-        });\n \n+        Consumer<Void> execute = v -> {","path":"cluster-controller/src/main/java/io/strimzi/controller/cluster/operations/cluster/KafkaClusterOperations.java","position":193,"original_position":193,"commit_id":"05ade2edd6164f379012f4aeb656d0635cc7c7e8","original_commit_id":"f7498876f3ada94fc6f6d1c11dffde3dbaa54773","user":{"login":"tombentley","id":879487,"avatar_url":"https://avatars3.githubusercontent.com/u/879487?v=4","gravatar_id":"","url":"https://api.github.com/users/tombentley","html_url":"https://github.com/tombentley","followers_url":"https://api.github.com/users/tombentley/followers","following_url":"https://api.github.com/users/tombentley/following{/other_user}","gists_url":"https://api.github.com/users/tombentley/gists{/gist_id}","starred_url":"https://api.github.com/users/tombentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombentley/subscriptions","organizations_url":"https://api.github.com/users/tombentley/orgs","repos_url":"https://api.github.com/users/tombentley/repos","events_url":"https://api.github.com/users/tombentley/events{/privacy}","received_events_url":"https://api.github.com/users/tombentley/received_events","type":"User","site_admin":false},"body":"Well, a private method is just clearer, it seems to me. \r\n\r\nAlso, using lamdbas unnecessarily ends up wasting metaspace, which doesn't matter for an individual use, but if you do it lots it will add up.","created_at":"2018-02-23T12:35:46Z","updated_at":"2018-02-23T12:35:46Z","html_url":"https://github.com/strimzi/strimzi/pull/237#discussion_r170240775","pull_request_url":"https://api.github.com/repos/strimzi/strimzi/pulls/237","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/comments/170240775"},"html":{"href":"https://github.com/strimzi/strimzi/pull/237#discussion_r170240775"},"pull_request":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/237"}},"in_reply_to_id":170230181},"pull_request":{"url":"https://api.github.com/repos/strimzi/strimzi/pulls/237","id":170498784,"html_url":"https://github.com/strimzi/strimzi/pull/237","diff_url":"https://github.com/strimzi/strimzi/pull/237.diff","patch_url":"https://github.com/strimzi/strimzi/pull/237.patch","issue_url":"https://api.github.com/repos/strimzi/strimzi/issues/237","number":237,"state":"open","locked":false,"title":"Topic controller deployed by cluster controller","user":{"login":"ppatierno","id":5842311,"avatar_url":"https://avatars0.githubusercontent.com/u/5842311?v=4","gravatar_id":"","url":"https://api.github.com/users/ppatierno","html_url":"https://github.com/ppatierno","followers_url":"https://api.github.com/users/ppatierno/followers","following_url":"https://api.github.com/users/ppatierno/following{/other_user}","gists_url":"https://api.github.com/users/ppatierno/gists{/gist_id}","starred_url":"https://api.github.com/users/ppatierno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppatierno/subscriptions","organizations_url":"https://api.github.com/users/ppatierno/orgs","repos_url":"https://api.github.com/users/ppatierno/repos","events_url":"https://api.github.com/users/ppatierno/events{/privacy}","received_events_url":"https://api.github.com/users/ppatierno/received_events","type":"User","site_admin":false},"body":"### Type of change\r\n\r\n_Select the type of your PR_\r\n\r\n- Enhancement / new feature\r\n\r\n### Description\r\n\r\nIt's about deploying the topic controller from the cluster controller (see #119).\r\nCreate and deletion operations are implemented up to now.\r\n\r\n### Checklist\r\n\r\n_Please go through this checklist and make sure all applicable tasks have been done_\r\n\r\n- [x] Write tests\r\n- [x] Make sure all tests pass\r\n- [x] Check coding style\r\n- [ ] Update documentation\r\n- [ ] Check RBAC rights for Kubernetes / OpenShift roles\r\n- [ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally\r\n- [ ] Reference relevant issue(s) and close them after merging\r\n\r\n","created_at":"2018-02-21T15:15:16Z","updated_at":"2018-02-23T12:35:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fd7f78d8ec3647450e2359f9132b4c1ad6d61ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/strimzi/strimzi/pulls/237/commits","review_comments_url":"https://api.github.com/repos/strimzi/strimzi/pulls/237/comments","review_comment_url":"https://api.github.com/repos/strimzi/strimzi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strimzi/strimzi/issues/237/comments","statuses_url":"https://api.github.com/repos/strimzi/strimzi/statuses/05ade2edd6164f379012f4aeb656d0635cc7c7e8","head":{"label":"strimzi:topic-controller-dep","ref":"topic-controller-dep","sha":"05ade2edd6164f379012f4aeb656d0635cc7c7e8","user":{"login":"strimzi","id":34767428,"avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":58194180,"name":"strimzi","full_name":"strimzi/strimzi","owner":{"login":"strimzi","id":34767428,"avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strimzi/strimzi","description":"Kafka as a Service running on Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi","forks_url":"https://api.github.com/repos/strimzi/strimzi/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi/deployments","created_at":"2016-05-06T08:52:33Z","updated_at":"2018-02-21T15:16:39Z","pushed_at":"2018-02-23T12:10:52Z","git_url":"git://github.com/strimzi/strimzi.git","ssh_url":"git@github.com:strimzi/strimzi.git","clone_url":"https://github.com/strimzi/strimzi.git","svn_url":"https://github.com/strimzi/strimzi","homepage":"","size":1634,"stargazers_count":119,"watchers_count":119,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":28,"open_issues":44,"watchers":119,"default_branch":"master"}},"base":{"label":"strimzi:master","ref":"master","sha":"fa81309a81f5050410b5eeb4f504f73d61d4d764","user":{"login":"strimzi","id":34767428,"avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":58194180,"name":"strimzi","full_name":"strimzi/strimzi","owner":{"login":"strimzi","id":34767428,"avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strimzi/strimzi","description":"Kafka as a Service running on Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi","forks_url":"https://api.github.com/repos/strimzi/strimzi/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi/deployments","created_at":"2016-05-06T08:52:33Z","updated_at":"2018-02-21T15:16:39Z","pushed_at":"2018-02-23T12:10:52Z","git_url":"git://github.com/strimzi/strimzi.git","ssh_url":"git@github.com:strimzi/strimzi.git","clone_url":"https://github.com/strimzi/strimzi.git","svn_url":"https://github.com/strimzi/strimzi","homepage":"","size":1634,"stargazers_count":119,"watchers_count":119,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":28,"open_issues":44,"watchers":119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/237"},"html":{"href":"https://github.com/strimzi/strimzi/pull/237"},"issue":{"href":"https://api.github.com/repos/strimzi/strimzi/issues/237"},"comments":{"href":"https://api.github.com/repos/strimzi/strimzi/issues/237/comments"},"review_comments":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/237/comments"},"review_comment":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strimzi/strimzi/pulls/237/commits"},"statuses":{"href":"https://api.github.com/repos/strimzi/strimzi/statuses/05ade2edd6164f379012f4aeb656d0635cc7c7e8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tombentley"}}