{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/188092116","pull_request_review_id":120001831,"id":188092116,"diff_hunk":"@@ -1,24 +1,24 @@\n /**\n  * Copyright 2016 The AMP HTML Authors. All Rights Reserved.\n  *\n- * Licensed under the Apache License, Version 2.0 (the \"License\");\n- * you may not use this file except in compliance with the License.\n- * You may obtain a copy of the License at\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not\n+ * use this file except in compliance with the License. You may obtain a copy of\n+ * the License at\n  *\n  *      http://www.apache.org/licenses/LICENSE-2.0\n  *\n  * Unless required by applicable law or agreed to in writing, software\n- * distributed under the License is distributed on an \"AS-IS\" BASIS,\n- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n- * See the License for the specific language governing permissions and\n- * limitations under the License.\n+ * distributed under the License is distributed on an \"AS-IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations under\n+ * the License.","path":"src/polyfills/domtokenlist-toggle.js","position":21,"original_position":21,"commit_id":"dd25d19560a3547b4cf06f46b35033a63efba0e9","original_commit_id":"dd25d19560a3547b4cf06f46b35033a63efba0e9","user":{"login":"choumx","id":20525523,"avatar_url":"https://avatars1.githubusercontent.com/u/20525523?v=4","gravatar_id":"","url":"https://api.github.com/users/choumx","html_url":"https://github.com/choumx","followers_url":"https://api.github.com/users/choumx/followers","following_url":"https://api.github.com/users/choumx/following{/other_user}","gists_url":"https://api.github.com/users/choumx/gists{/gist_id}","starred_url":"https://api.github.com/users/choumx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choumx/subscriptions","organizations_url":"https://api.github.com/users/choumx/orgs","repos_url":"https://api.github.com/users/choumx/repos","events_url":"https://api.github.com/users/choumx/events{/privacy}","received_events_url":"https://api.github.com/users/choumx/received_events","type":"User","site_admin":false},"body":"Should we be reformatting license text?","created_at":"2018-05-14T20:44:45Z","updated_at":"2018-05-14T20:45:56Z","html_url":"https://github.com/ampproject/amphtml/pull/15247#discussion_r188092116","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/15247","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/188092116"},"html":{"href":"https://github.com/ampproject/amphtml/pull/15247#discussion_r188092116"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/15247"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/15247","id":187601255,"html_url":"https://github.com/ampproject/amphtml/pull/15247","diff_url":"https://github.com/ampproject/amphtml/pull/15247.diff","patch_url":"https://github.com/ampproject/amphtml/pull/15247.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/15247","number":15247,"state":"open","locked":false,"title":"🚮Restrict comments to 80 columns (exempt JSDoc annotations)","user":{"login":"rsimha","id":26553114,"avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false},"body":"This PR does the following:\r\n- Replaces `\"ignoreComments\": true` in `.eslintrc` with `\"ignoreTrailingComments\": true`\r\n- Fixes all instances of long text comments using https://github.com/stkb/Rewrap\r\n- Adds exemptions for long single-line JSDoc type annotations via `ignorePattern`\r\n- Fixes a few incorrect type annotations ([here](https://travis-ci.org/ampproject/amphtml/jobs/378165206#L2090-L2099) and [here](https://travis-ci.org/ampproject/amphtml/jobs/378170756#L2090-L2159)) that were not being caught by `gulp check-types` because they were [split across lines](https://github.com/ampproject/amphtml/pull/14439/files#r188090503)\r\n\r\nI've kicked off a separate effort to find and fix all JSDoc errors in our code: #15255\r\n\r\nFixes #15127 \r\nTo be followed by #15256\r\n","created_at":"2018-05-12T02:57:40Z","updated_at":"2018-05-14T20:45:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8299705b3d10cfe50a814e0b1717698fa4e3380b","assignee":{"login":"rsimha","id":26553114,"avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false},"assignees":[{"login":"rsimha","id":26553114,"avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"peterjosling","id":930324,"avatar_url":"https://avatars2.githubusercontent.com/u/930324?v=4","gravatar_id":"","url":"https://api.github.com/users/peterjosling","html_url":"https://github.com/peterjosling","followers_url":"https://api.github.com/users/peterjosling/followers","following_url":"https://api.github.com/users/peterjosling/following{/other_user}","gists_url":"https://api.github.com/users/peterjosling/gists{/gist_id}","starred_url":"https://api.github.com/users/peterjosling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterjosling/subscriptions","organizations_url":"https://api.github.com/users/peterjosling/orgs","repos_url":"https://api.github.com/users/peterjosling/repos","events_url":"https://api.github.com/users/peterjosling/events{/privacy}","received_events_url":"https://api.github.com/users/peterjosling/received_events","type":"User","site_admin":false},{"login":"aghassemi","id":2099009,"avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":295091514,"url":"https://api.github.com/repos/ampproject/amphtml/labels/Cleanup","name":"Cleanup","color":"006b75","default":false},{"id":596633554,"url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/15247/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/15247/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/15247/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/dd25d19560a3547b4cf06f46b35033a63efba0e9","head":{"label":"rsimha:2018-05-11-LintComments","ref":"2018-05-11-LintComments","sha":"dd25d19560a3547b4cf06f46b35033a63efba0e9","user":{"login":"rsimha","id":26553114,"avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false},"repo":{"id":85631456,"name":"amphtml","full_name":"rsimha/amphtml","owner":{"login":"rsimha","id":26553114,"avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsimha/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/rsimha/amphtml","forks_url":"https://api.github.com/repos/rsimha/amphtml/forks","keys_url":"https://api.github.com/repos/rsimha/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsimha/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsimha/amphtml/teams","hooks_url":"https://api.github.com/repos/rsimha/amphtml/hooks","issue_events_url":"https://api.github.com/repos/rsimha/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/rsimha/amphtml/events","assignees_url":"https://api.github.com/repos/rsimha/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/rsimha/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/rsimha/amphtml/tags","blobs_url":"https://api.github.com/repos/rsimha/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsimha/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsimha/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsimha/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsimha/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/rsimha/amphtml/languages","stargazers_url":"https://api.github.com/repos/rsimha/amphtml/stargazers","contributors_url":"https://api.github.com/repos/rsimha/amphtml/contributors","subscribers_url":"https://api.github.com/repos/rsimha/amphtml/subscribers","subscription_url":"https://api.github.com/repos/rsimha/amphtml/subscription","commits_url":"https://api.github.com/repos/rsimha/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsimha/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsimha/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsimha/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsimha/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/rsimha/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsimha/amphtml/merges","archive_url":"https://api.github.com/repos/rsimha/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsimha/amphtml/downloads","issues_url":"https://api.github.com/repos/rsimha/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/rsimha/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/rsimha/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/rsimha/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsimha/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/rsimha/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/rsimha/amphtml/deployments","created_at":"2017-03-20T21:59:46Z","updated_at":"2018-05-14T18:45:12Z","pushed_at":"2018-05-14T19:39:23Z","git_url":"git://github.com/rsimha/amphtml.git","ssh_url":"git@github.com:rsimha/amphtml.git","clone_url":"https://github.com/rsimha/amphtml.git","svn_url":"https://github.com/rsimha/amphtml","homepage":"https://www.ampproject.org","size":442542,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"04c5b80b5017d6e3fb01ea71adbad0c01c7cd1c2","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-05-14T18:58:46Z","pushed_at":"2018-05-14T20:39:43Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":443488,"stargazers_count":11560,"watchers_count":11560,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2381,"mirror_url":null,"archived":false,"open_issues_count":1352,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2381,"open_issues":1352,"watchers":11560,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/15247"},"html":{"href":"https://github.com/ampproject/amphtml/pull/15247"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/15247"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/15247/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/15247/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/15247/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/dd25d19560a3547b4cf06f46b35033a63efba0e9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"choumx"}}