{"action":"closed","number":5960,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-superset/pulls/5960","id":217490910,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDkwOTEw","html_url":"https://github.com/apache/incubator-superset/pull/5960","diff_url":"https://github.com/apache/incubator-superset/pull/5960.diff","patch_url":"https://github.com/apache/incubator-superset/pull/5960.patch","issue_url":"https://api.github.com/repos/apache/incubator-superset/issues/5960","number":5960,"state":"closed","locked":false,"title":"[feat] Feature flag system via config","user":{"login":"xtinec","id":1521435,"node_id":"MDQ6VXNlcjE1MjE0MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1521435?v=4","gravatar_id":"","url":"https://api.github.com/users/xtinec","html_url":"https://github.com/xtinec","followers_url":"https://api.github.com/users/xtinec/followers","following_url":"https://api.github.com/users/xtinec/following{/other_user}","gists_url":"https://api.github.com/users/xtinec/gists{/gist_id}","starred_url":"https://api.github.com/users/xtinec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtinec/subscriptions","organizations_url":"https://api.github.com/users/xtinec/orgs","repos_url":"https://api.github.com/users/xtinec/repos","events_url":"https://api.github.com/users/xtinec/events{/privacy}","received_events_url":"https://api.github.com/users/xtinec/received_events","type":"User","site_admin":false},"body":"Adding a feature flag system that is driven by superset_config.py. This change includes:\r\n- Server side changes to specify a dedicated FEATURE_FLAG dictionary for listing feature flags. E.g.\r\n```\r\nFEATURE_FLAGS = { 'SCOPED_FILTER': true }\r\n```\r\n- Pass the new feature flags to client via bootstrap-data\r\n- Client side changes to inject feature flags into the redux state tree for dashboard, explore view and SqlLab\r\n- Client side refactor/clean up so the feature flags can be properly tested. Also avoid modifying incoming bootstrap data when creating initial state for the redux state tree\r\n- Re-enable tests that were previously disabled for ExploreViewContainer\r\n\r\n@mistercrunch @kristw @williaster ","created_at":"2018-09-23T03:41:32Z","updated_at":"2018-10-01T18:47:07Z","closed_at":"2018-10-01T18:47:07Z","merged_at":"2018-10-01T18:47:07Z","merge_commit_sha":"604524b671b4d68b7cc4be5d3116c0a49cff4d4d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-superset/pulls/5960/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-superset/pulls/5960/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-superset/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-superset/issues/5960/comments","statuses_url":"https://api.github.com/repos/apache/incubator-superset/statuses/b5b812cf63308178b67b223a0a74c16746bff250","head":{"label":"lyft:feature-flags","ref":"feature-flags","sha":"b5b812cf63308178b67b223a0a74c16746bff250","user":{"login":"lyft","id":4269340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjkzNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4269340?v=4","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":108907301,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg5MDczMDE=","name":"incubator-superset","full_name":"lyft/incubator-superset","private":false,"owner":{"login":"lyft","id":4269340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjkzNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4269340?v=4","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lyft/incubator-superset","description":"Apache Superset (incubating) is a modern, enterprise-ready business intelligence web application","fork":true,"url":"https://api.github.com/repos/lyft/incubator-superset","forks_url":"https://api.github.com/repos/lyft/incubator-superset/forks","keys_url":"https://api.github.com/repos/lyft/incubator-superset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/incubator-superset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/incubator-superset/teams","hooks_url":"https://api.github.com/repos/lyft/incubator-superset/hooks","issue_events_url":"https://api.github.com/repos/lyft/incubator-superset/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/incubator-superset/events","assignees_url":"https://api.github.com/repos/lyft/incubator-superset/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/incubator-superset/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/incubator-superset/tags","blobs_url":"https://api.github.com/repos/lyft/incubator-superset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/incubator-superset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/incubator-superset/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/incubator-superset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/incubator-superset/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/incubator-superset/languages","stargazers_url":"https://api.github.com/repos/lyft/incubator-superset/stargazers","contributors_url":"https://api.github.com/repos/lyft/incubator-superset/contributors","subscribers_url":"https://api.github.com/repos/lyft/incubator-superset/subscribers","subscription_url":"https://api.github.com/repos/lyft/incubator-superset/subscription","commits_url":"https://api.github.com/repos/lyft/incubator-superset/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/incubator-superset/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/incubator-superset/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/incubator-superset/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/incubator-superset/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/incubator-superset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/incubator-superset/merges","archive_url":"https://api.github.com/repos/lyft/incubator-superset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/incubator-superset/downloads","issues_url":"https://api.github.com/repos/lyft/incubator-superset/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/incubator-superset/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/incubator-superset/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/incubator-superset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/incubator-superset/labels{/name}","releases_url":"https://api.github.com/repos/lyft/incubator-superset/releases{/id}","deployments_url":"https://api.github.com/repos/lyft/incubator-superset/deployments","created_at":"2017-10-30T20:53:33Z","updated_at":"2018-08-31T06:47:09Z","pushed_at":"2018-09-28T02:58:25Z","git_url":"git://github.com/lyft/incubator-superset.git","ssh_url":"git@github.com:lyft/incubator-superset.git","clone_url":"https://github.com/lyft/incubator-superset.git","svn_url":"https://github.com/lyft/incubator-superset","homepage":"","size":94903,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":3,"watchers":3,"default_branch":"lyft-master"}},"base":{"label":"apache:master","ref":"master","sha":"569f221d9b22ce012422f9affc554dc2a5cafc0d","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":39464018,"node_id":"MDEwOlJlcG9zaXRvcnkzOTQ2NDAxOA==","name":"incubator-superset","full_name":"apache/incubator-superset","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-superset","description":"Apache Superset (incubating) is a modern, enterprise-ready business intelligence web application","fork":false,"url":"https://api.github.com/repos/apache/incubator-superset","forks_url":"https://api.github.com/repos/apache/incubator-superset/forks","keys_url":"https://api.github.com/repos/apache/incubator-superset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-superset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-superset/teams","hooks_url":"https://api.github.com/repos/apache/incubator-superset/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-superset/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-superset/events","assignees_url":"https://api.github.com/repos/apache/incubator-superset/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-superset/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-superset/tags","blobs_url":"https://api.github.com/repos/apache/incubator-superset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-superset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-superset/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-superset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-superset/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-superset/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-superset/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-superset/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-superset/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-superset/subscription","commits_url":"https://api.github.com/repos/apache/incubator-superset/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-superset/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-superset/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-superset/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-superset/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-superset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-superset/merges","archive_url":"https://api.github.com/repos/apache/incubator-superset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-superset/downloads","issues_url":"https://api.github.com/repos/apache/incubator-superset/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-superset/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-superset/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-superset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-superset/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-superset/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-superset/deployments","created_at":"2015-07-21T18:55:34Z","updated_at":"2018-10-01T18:16:30Z","pushed_at":"2018-10-01T18:47:07Z","git_url":"git://github.com/apache/incubator-superset.git","ssh_url":"git@github.com:apache/incubator-superset.git","clone_url":"https://github.com/apache/incubator-superset.git","svn_url":"https://github.com/apache/incubator-superset","homepage":"","size":93099,"stargazers_count":20886,"watchers_count":20886,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3727,"mirror_url":null,"archived":false,"open_issues_count":988,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3727,"open_issues":988,"watchers":20886,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/5960"},"html":{"href":"https://github.com/apache/incubator-superset/pull/5960"},"issue":{"href":"https://api.github.com/repos/apache/incubator-superset/issues/5960"},"comments":{"href":"https://api.github.com/repos/apache/incubator-superset/issues/5960/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/5960/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/5960/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-superset/statuses/b5b812cf63308178b67b223a0a74c16746bff250"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"betodealmeida","id":1534870,"node_id":"MDQ6VXNlcjE1MzQ4NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1534870?v=4","gravatar_id":"","url":"https://api.github.com/users/betodealmeida","html_url":"https://github.com/betodealmeida","followers_url":"https://api.github.com/users/betodealmeida/followers","following_url":"https://api.github.com/users/betodealmeida/following{/other_user}","gists_url":"https://api.github.com/users/betodealmeida/gists{/gist_id}","starred_url":"https://api.github.com/users/betodealmeida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betodealmeida/subscriptions","organizations_url":"https://api.github.com/users/betodealmeida/orgs","repos_url":"https://api.github.com/users/betodealmeida/repos","events_url":"https://api.github.com/users/betodealmeida/events{/privacy}","received_events_url":"https://api.github.com/users/betodealmeida/received_events","type":"User","site_admin":false},"comments":2,"review_comments":13,"maintainer_can_modify":false,"commits":3,"additions":246,"deletions":113,"changed_files":17}}
{"actor":{"display_login":"betodealmeida"}}