{"action":"created","comment":{"url":"https://api.github.com/repos/opensourcepos/opensourcepos/pulls/comments/172055131","pull_request_review_id":101011395,"id":172055131,"diff_hunk":"@@ -65,10 +65,8 @@\n | a PHP script and you can easily do that on your own.\n |\n */\n-if (isset($_ENV['FORCE_HTTPS']))\n-    $_SERVER['HTTPS'] = 'on';\n \n-$config['base_url'] = (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') ? 'https' : 'http';\n+$config['base_url'] = (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') || isset($_ENV['FORCE_HTTPS'])) ? 'https' : 'http';","path":"application/config/config.php","position":null,"original_position":8,"commit_id":"d4d17d640cb3b8940341c18fd8ed44c08141bfc7","original_commit_id":"d4d17d640cb3b8940341c18fd8ed44c08141bfc7","user":{"login":"daN4cat","id":636048,"avatar_url":"https://avatars1.githubusercontent.com/u/636048?v=4","gravatar_id":"","url":"https://api.github.com/users/daN4cat","html_url":"https://github.com/daN4cat","followers_url":"https://api.github.com/users/daN4cat/followers","following_url":"https://api.github.com/users/daN4cat/following{/other_user}","gists_url":"https://api.github.com/users/daN4cat/gists{/gist_id}","starred_url":"https://api.github.com/users/daN4cat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daN4cat/subscriptions","organizations_url":"https://api.github.com/users/daN4cat/orgs","repos_url":"https://api.github.com/users/daN4cat/repos","events_url":"https://api.github.com/users/daN4cat/events{/privacy}","received_events_url":"https://api.github.com/users/daN4cat/received_events","type":"User","site_admin":false},"body":"you need to test your changes before submitting a PR.","created_at":"2018-03-04T16:40:00Z","updated_at":"2018-03-04T16:40:00Z","html_url":"https://github.com/opensourcepos/opensourcepos/pull/1874#discussion_r172055131","pull_request_url":"https://api.github.com/repos/opensourcepos/opensourcepos/pulls/1874","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/opensourcepos/opensourcepos/pulls/comments/172055131"},"html":{"href":"https://github.com/opensourcepos/opensourcepos/pull/1874#discussion_r172055131"},"pull_request":{"href":"https://api.github.com/repos/opensourcepos/opensourcepos/pulls/1874"}},"in_reply_to_id":172055097},"pull_request":{"url":"https://api.github.com/repos/opensourcepos/opensourcepos/pulls/1874","id":172493414,"html_url":"https://github.com/opensourcepos/opensourcepos/pull/1874","diff_url":"https://github.com/opensourcepos/opensourcepos/pull/1874.diff","patch_url":"https://github.com/opensourcepos/opensourcepos/pull/1874.patch","issue_url":"https://api.github.com/repos/opensourcepos/opensourcepos/issues/1874","number":1874,"state":"open","locked":false,"title":"Enable https for proxy offloading","user":{"login":"ElGranLoky","id":2712200,"avatar_url":"https://avatars0.githubusercontent.com/u/2712200?v=4","gravatar_id":"","url":"https://api.github.com/users/ElGranLoky","html_url":"https://github.com/ElGranLoky","followers_url":"https://api.github.com/users/ElGranLoky/followers","following_url":"https://api.github.com/users/ElGranLoky/following{/other_user}","gists_url":"https://api.github.com/users/ElGranLoky/gists{/gist_id}","starred_url":"https://api.github.com/users/ElGranLoky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElGranLoky/subscriptions","organizations_url":"https://api.github.com/users/ElGranLoky/orgs","repos_url":"https://api.github.com/users/ElGranLoky/repos","events_url":"https://api.github.com/users/ElGranLoky/events{/privacy}","received_events_url":"https://api.github.com/users/ElGranLoky/received_events","type":"User","site_admin":false},"body":"If we install ospos in docker behind a proxy that performs ssloffloading, we can enable the url generated to be https instead of http, by activating the environment variable FORCE_HTTPS = 1.","created_at":"2018-03-02T12:39:03Z","updated_at":"2018-03-04T16:40:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10e15cec434eee948e60d1e0bc85fe71364bbf34","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opensourcepos/opensourcepos/pulls/1874/commits","review_comments_url":"https://api.github.com/repos/opensourcepos/opensourcepos/pulls/1874/comments","review_comment_url":"https://api.github.com/repos/opensourcepos/opensourcepos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opensourcepos/opensourcepos/issues/1874/comments","statuses_url":"https://api.github.com/repos/opensourcepos/opensourcepos/statuses/d4d17d640cb3b8940341c18fd8ed44c08141bfc7","head":{"label":"ElGranLoky:master","ref":"master","sha":"d4d17d640cb3b8940341c18fd8ed44c08141bfc7","user":{"login":"ElGranLoky","id":2712200,"avatar_url":"https://avatars0.githubusercontent.com/u/2712200?v=4","gravatar_id":"","url":"https://api.github.com/users/ElGranLoky","html_url":"https://github.com/ElGranLoky","followers_url":"https://api.github.com/users/ElGranLoky/followers","following_url":"https://api.github.com/users/ElGranLoky/following{/other_user}","gists_url":"https://api.github.com/users/ElGranLoky/gists{/gist_id}","starred_url":"https://api.github.com/users/ElGranLoky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElGranLoky/subscriptions","organizations_url":"https://api.github.com/users/ElGranLoky/orgs","repos_url":"https://api.github.com/users/ElGranLoky/repos","events_url":"https://api.github.com/users/ElGranLoky/events{/privacy}","received_events_url":"https://api.github.com/users/ElGranLoky/received_events","type":"User","site_admin":false},"repo":{"id":123576501,"name":"opensourcepos","full_name":"ElGranLoky/opensourcepos","owner":{"login":"ElGranLoky","id":2712200,"avatar_url":"https://avatars0.githubusercontent.com/u/2712200?v=4","gravatar_id":"","url":"https://api.github.com/users/ElGranLoky","html_url":"https://github.com/ElGranLoky","followers_url":"https://api.github.com/users/ElGranLoky/followers","following_url":"https://api.github.com/users/ElGranLoky/following{/other_user}","gists_url":"https://api.github.com/users/ElGranLoky/gists{/gist_id}","starred_url":"https://api.github.com/users/ElGranLoky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElGranLoky/subscriptions","organizations_url":"https://api.github.com/users/ElGranLoky/orgs","repos_url":"https://api.github.com/users/ElGranLoky/repos","events_url":"https://api.github.com/users/ElGranLoky/events{/privacy}","received_events_url":"https://api.github.com/users/ElGranLoky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ElGranLoky/opensourcepos","description":"Open Source Point of Sale is a web based point of sale application written in PHP using CodeIgniter framework. It uses MySQL as the data back end and has a Bootstrap 3 based user interface.","fork":true,"url":"https://api.github.com/repos/ElGranLoky/opensourcepos","forks_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/forks","keys_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/teams","hooks_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/hooks","issue_events_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/issues/events{/number}","events_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/events","assignees_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/assignees{/user}","branches_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/branches{/branch}","tags_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/tags","blobs_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/statuses/{sha}","languages_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/languages","stargazers_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/stargazers","contributors_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/contributors","subscribers_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/subscribers","subscription_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/subscription","commits_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/contents/{+path}","compare_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/merges","archive_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/downloads","issues_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/issues{/number}","pulls_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/pulls{/number}","milestones_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/milestones{/number}","notifications_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/labels{/name}","releases_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/releases{/id}","deployments_url":"https://api.github.com/repos/ElGranLoky/opensourcepos/deployments","created_at":"2018-03-02T12:28:08Z","updated_at":"2018-03-02T12:28:11Z","pushed_at":"2018-03-04T16:32:22Z","git_url":"git://github.com/ElGranLoky/opensourcepos.git","ssh_url":"git@github.com:ElGranLoky/opensourcepos.git","clone_url":"https://github.com/ElGranLoky/opensourcepos.git","svn_url":"https://github.com/ElGranLoky/opensourcepos","homepage":"http://www.opensourcepos.org","size":44231,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opensourcepos:master","ref":"master","sha":"33cc7e3f9c804c394b4d23be1b9a315a66fea5e7","user":{"login":"opensourcepos","id":31845758,"avatar_url":"https://avatars0.githubusercontent.com/u/31845758?v=4","gravatar_id":"","url":"https://api.github.com/users/opensourcepos","html_url":"https://github.com/opensourcepos","followers_url":"https://api.github.com/users/opensourcepos/followers","following_url":"https://api.github.com/users/opensourcepos/following{/other_user}","gists_url":"https://api.github.com/users/opensourcepos/gists{/gist_id}","starred_url":"https://api.github.com/users/opensourcepos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensourcepos/subscriptions","organizations_url":"https://api.github.com/users/opensourcepos/orgs","repos_url":"https://api.github.com/users/opensourcepos/repos","events_url":"https://api.github.com/users/opensourcepos/events{/privacy}","received_events_url":"https://api.github.com/users/opensourcepos/received_events","type":"Organization","site_admin":false},"repo":{"id":14724954,"name":"opensourcepos","full_name":"opensourcepos/opensourcepos","owner":{"login":"opensourcepos","id":31845758,"avatar_url":"https://avatars0.githubusercontent.com/u/31845758?v=4","gravatar_id":"","url":"https://api.github.com/users/opensourcepos","html_url":"https://github.com/opensourcepos","followers_url":"https://api.github.com/users/opensourcepos/followers","following_url":"https://api.github.com/users/opensourcepos/following{/other_user}","gists_url":"https://api.github.com/users/opensourcepos/gists{/gist_id}","starred_url":"https://api.github.com/users/opensourcepos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensourcepos/subscriptions","organizations_url":"https://api.github.com/users/opensourcepos/orgs","repos_url":"https://api.github.com/users/opensourcepos/repos","events_url":"https://api.github.com/users/opensourcepos/events{/privacy}","received_events_url":"https://api.github.com/users/opensourcepos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opensourcepos/opensourcepos","description":"Open Source Point of Sale is a web based point of sale application written in PHP using CodeIgniter framework. It uses MySQL as the data back end and has a Bootstrap 3 based user interface.","fork":false,"url":"https://api.github.com/repos/opensourcepos/opensourcepos","forks_url":"https://api.github.com/repos/opensourcepos/opensourcepos/forks","keys_url":"https://api.github.com/repos/opensourcepos/opensourcepos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensourcepos/opensourcepos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensourcepos/opensourcepos/teams","hooks_url":"https://api.github.com/repos/opensourcepos/opensourcepos/hooks","issue_events_url":"https://api.github.com/repos/opensourcepos/opensourcepos/issues/events{/number}","events_url":"https://api.github.com/repos/opensourcepos/opensourcepos/events","assignees_url":"https://api.github.com/repos/opensourcepos/opensourcepos/assignees{/user}","branches_url":"https://api.github.com/repos/opensourcepos/opensourcepos/branches{/branch}","tags_url":"https://api.github.com/repos/opensourcepos/opensourcepos/tags","blobs_url":"https://api.github.com/repos/opensourcepos/opensourcepos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensourcepos/opensourcepos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensourcepos/opensourcepos/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensourcepos/opensourcepos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensourcepos/opensourcepos/statuses/{sha}","languages_url":"https://api.github.com/repos/opensourcepos/opensourcepos/languages","stargazers_url":"https://api.github.com/repos/opensourcepos/opensourcepos/stargazers","contributors_url":"https://api.github.com/repos/opensourcepos/opensourcepos/contributors","subscribers_url":"https://api.github.com/repos/opensourcepos/opensourcepos/subscribers","subscription_url":"https://api.github.com/repos/opensourcepos/opensourcepos/subscription","commits_url":"https://api.github.com/repos/opensourcepos/opensourcepos/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensourcepos/opensourcepos/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensourcepos/opensourcepos/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensourcepos/opensourcepos/issues/comments{/number}","contents_url":"https://api.github.com/repos/opensourcepos/opensourcepos/contents/{+path}","compare_url":"https://api.github.com/repos/opensourcepos/opensourcepos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensourcepos/opensourcepos/merges","archive_url":"https://api.github.com/repos/opensourcepos/opensourcepos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensourcepos/opensourcepos/downloads","issues_url":"https://api.github.com/repos/opensourcepos/opensourcepos/issues{/number}","pulls_url":"https://api.github.com/repos/opensourcepos/opensourcepos/pulls{/number}","milestones_url":"https://api.github.com/repos/opensourcepos/opensourcepos/milestones{/number}","notifications_url":"https://api.github.com/repos/opensourcepos/opensourcepos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensourcepos/opensourcepos/labels{/name}","releases_url":"https://api.github.com/repos/opensourcepos/opensourcepos/releases{/id}","deployments_url":"https://api.github.com/repos/opensourcepos/opensourcepos/deployments","created_at":"2013-11-26T18:09:05Z","updated_at":"2018-03-03T13:35:43Z","pushed_at":"2018-03-04T16:35:50Z","git_url":"git://github.com/opensourcepos/opensourcepos.git","ssh_url":"git@github.com:opensourcepos/opensourcepos.git","clone_url":"https://github.com/opensourcepos/opensourcepos.git","svn_url":"https://github.com/opensourcepos/opensourcepos","homepage":"http://www.opensourcepos.org","size":44238,"stargazers_count":900,"watchers_count":900,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":743,"mirror_url":null,"archived":false,"open_issues_count":181,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":743,"open_issues":181,"watchers":900,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opensourcepos/opensourcepos/pulls/1874"},"html":{"href":"https://github.com/opensourcepos/opensourcepos/pull/1874"},"issue":{"href":"https://api.github.com/repos/opensourcepos/opensourcepos/issues/1874"},"comments":{"href":"https://api.github.com/repos/opensourcepos/opensourcepos/issues/1874/comments"},"review_comments":{"href":"https://api.github.com/repos/opensourcepos/opensourcepos/pulls/1874/comments"},"review_comment":{"href":"https://api.github.com/repos/opensourcepos/opensourcepos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opensourcepos/opensourcepos/pulls/1874/commits"},"statuses":{"href":"https://api.github.com/repos/opensourcepos/opensourcepos/statuses/d4d17d640cb3b8940341c18fd8ed44c08141bfc7"}},"author_association":"NONE"}}
{"actor":{"display_login":"daN4cat"}}