{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/47556","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/47556/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/47556/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/47556/events","html_url":"https://github.com/NixOS/nixpkgs/pull/47556","id":365227471,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjA2NjQ2","number":47556,"title":"buildRustPackage now installs binaries to bin and libraries to lib","user":{"login":"et4te","id":138829,"node_id":"MDQ6VXNlcjEzODgyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/138829?v=4","gravatar_id":"","url":"https://api.github.com/users/et4te","html_url":"https://github.com/et4te","followers_url":"https://api.github.com/users/et4te/followers","following_url":"https://api.github.com/users/et4te/following{/other_user}","gists_url":"https://api.github.com/users/et4te/gists{/gist_id}","starred_url":"https://api.github.com/users/et4te/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/et4te/subscriptions","organizations_url":"https://api.github.com/users/et4te/orgs","repos_url":"https://api.github.com/users/et4te/repos","events_url":"https://api.github.com/users/et4te/events{/privacy}","received_events_url":"https://api.github.com/users/et4te/received_events","type":"User","site_admin":false},"labels":[{"id":731735640,"node_id":"MDU6TGFiZWw3MzE3MzU2NDA=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%20101-500","name":"10.rebuild-darwin: 101-500","color":"d93f0b","default":false},{"id":731734523,"node_id":"MDU6TGFiZWw3MzE3MzQ1MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%20501+","name":"10.rebuild-linux: 501+","color":"b60205","default":false},{"id":333381548,"node_id":"MDU6TGFiZWwzMzMzODE1NDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20rust","name":"6.topic: rust","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-09-30T14:07:17Z","updated_at":"2018-10-02T07:04:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/47556","html_url":"https://github.com/NixOS/nixpkgs/pull/47556","diff_url":"https://github.com/NixOS/nixpkgs/pull/47556.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/47556.patch"},"body":"###### Motivation for this change\r\n\r\nbuildRustPackage was not installing static libs and was installing .so to bin.  \r\n\r\nFixes this issue: https://github.com/NixOS/nixpkgs/issues/46985\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/426170367","html_url":"https://github.com/NixOS/nixpkgs/pull/47556#issuecomment-426170367","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/47556","id":426170367,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjE3MDM2Nw==","user":{"login":"et4te","id":138829,"node_id":"MDQ6VXNlcjEzODgyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/138829?v=4","gravatar_id":"","url":"https://api.github.com/users/et4te","html_url":"https://github.com/et4te","followers_url":"https://api.github.com/users/et4te/followers","following_url":"https://api.github.com/users/et4te/following{/other_user}","gists_url":"https://api.github.com/users/et4te/gists{/gist_id}","starred_url":"https://api.github.com/users/et4te/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/et4te/subscriptions","organizations_url":"https://api.github.com/users/et4te/orgs","repos_url":"https://api.github.com/users/et4te/repos","events_url":"https://api.github.com/users/et4te/events{/privacy}","received_events_url":"https://api.github.com/users/et4te/received_events","type":"User","site_admin":false},"created_at":"2018-10-02T07:04:16Z","updated_at":"2018-10-02T07:04:16Z","author_association":"CONTRIBUTOR","body":"> Please change this pull request to the staging branch (since it rebuilds quite a lot).\r\n> This will also require a local rebase + force push usually.\r\n> Alternatively you can use `git cherry-pick` on the checked out staging branch.\r\n\r\nGenerally I agree that patches should go in staging. This change however is required for any Rust project which builds static libraries and changes a very small amount of code - it is a required bugfix for anyone writing Rust FFI code which depends on static libraries. IMO this qualifies for a change that should be expeditiously merged into master. If the final commit is deemed to not be appropriate (final) and requires extra future rebuilds then rebasing onto staging seems like a better idea but I don't think this is the case here. "}}
{"actor":{"display_login":"et4te"}}