{"action":"created","issue":{"url":"https://api.github.com/repos/bcgov/smk/issues/192","repository_url":"https://api.github.com/repos/bcgov/smk","labels_url":"https://api.github.com/repos/bcgov/smk/issues/192/labels{/name}","comments_url":"https://api.github.com/repos/bcgov/smk/issues/192/comments","events_url":"https://api.github.com/repos/bcgov/smk/issues/192/events","html_url":"https://github.com/bcgov/smk/issues/192","id":329134342,"node_id":"MDU6SXNzdWUzMjkxMzQzNDI=","number":192,"title":"WMS and WFS should be completely different input types.. ","user":{"login":"webgismich","id":5844788,"node_id":"MDQ6VXNlcjU4NDQ3ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/5844788?v=4","gravatar_id":"","url":"https://api.github.com/users/webgismich","html_url":"https://github.com/webgismich","followers_url":"https://api.github.com/users/webgismich/followers","following_url":"https://api.github.com/users/webgismich/following{/other_user}","gists_url":"https://api.github.com/users/webgismich/gists{/gist_id}","starred_url":"https://api.github.com/users/webgismich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webgismich/subscriptions","organizations_url":"https://api.github.com/users/webgismich/orgs","repos_url":"https://api.github.com/users/webgismich/repos","events_url":"https://api.github.com/users/webgismich/events{/privacy}","received_events_url":"https://api.github.com/users/webgismich/received_events","type":"User","site_admin":false},"labels":[{"id":801010519,"node_id":"MDU6TGFiZWw4MDEwMTA1MTk=","url":"https://api.github.com/repos/bcgov/smk/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-04T16:43:02Z","updated_at":"2018-06-13T22:27:27Z","closed_at":null,"author_association":"NONE","body":"When you click on a WMS to (point or polygon) identify, why do WFS GetFeature? .. and not WMS Getfeatureinfo? I can understand WFS if it is for a ‘selected set' but this should be explicitly different than using a WMS service..\n\n (not all WMS have equivalent WFS, and this will eliminate basic query access of a WMS service (that doesn't offer WFS at the same URL). WFS and WMS should be completely different input types in SMK."},"comment":{"url":"https://api.github.com/repos/bcgov/smk/issues/comments/397107996","html_url":"https://github.com/bcgov/smk/issues/192#issuecomment-397107996","issue_url":"https://api.github.com/repos/bcgov/smk/issues/192","id":397107996,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzEwNzk5Ng==","user":{"login":"qqnluaq","id":20274603,"node_id":"MDQ6VXNlcjIwMjc0NjAz","avatar_url":"https://avatars3.githubusercontent.com/u/20274603?v=4","gravatar_id":"","url":"https://api.github.com/users/qqnluaq","html_url":"https://github.com/qqnluaq","followers_url":"https://api.github.com/users/qqnluaq/followers","following_url":"https://api.github.com/users/qqnluaq/following{/other_user}","gists_url":"https://api.github.com/users/qqnluaq/gists{/gist_id}","starred_url":"https://api.github.com/users/qqnluaq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qqnluaq/subscriptions","organizations_url":"https://api.github.com/users/qqnluaq/orgs","repos_url":"https://api.github.com/users/qqnluaq/repos","events_url":"https://api.github.com/users/qqnluaq/events{/privacy}","received_events_url":"https://api.github.com/users/qqnluaq/received_events","type":"User","site_admin":false},"created_at":"2018-06-13T22:27:27Z","updated_at":"2018-06-13T22:27:27Z","author_association":"COLLABORATOR","body":"The main reason I elected to use WFS for querying WMS layers is consistency with the other layer types used in SMK. The vector layers, and the esri dynamic layers are queried by constructing a circle a of a certain radius (in pixels) around the click point, and then find features that intersect that circle. WFS allows the code to function the same way with the WMS layers.\r\n\r\nThere is configuration for the identify tool to control the hit radius in pixels, (`tolerance`). If that isn't enough control, all layer objects also have a `tolerance` configuration value, which takes precedence over the value set for the identify tool.\r\n\r\nAt some point it will probably be necessary to add configuration to the `wms` layer object, so that particular flavour of WMS and WFS that is used for that layer can be specified. It may be necessary to force particular layers to use GetFeatureInfo as well. "}}
{"actor":{"display_login":"qqnluaq"}}