{"action":"created","issue":{"url":"https://api.github.com/repos/linuxppc/linux/issues/148","repository_url":"https://api.github.com/repos/linuxppc/linux","labels_url":"https://api.github.com/repos/linuxppc/linux/issues/148/labels{/name}","comments_url":"https://api.github.com/repos/linuxppc/linux/issues/148/comments","events_url":"https://api.github.com/repos/linuxppc/linux/issues/148/events","html_url":"https://github.com/linuxppc/linux/issues/148","id":321951746,"number":148,"title":"Emulate step tests fail on Power6 ","user":{"login":"mpe","id":54119,"avatar_url":"https://avatars3.githubusercontent.com/u/54119?v=4","gravatar_id":"","url":"https://api.github.com/users/mpe","html_url":"https://github.com/mpe","followers_url":"https://api.github.com/users/mpe/followers","following_url":"https://api.github.com/users/mpe/following{/other_user}","gists_url":"https://api.github.com/users/mpe/gists{/gist_id}","starred_url":"https://api.github.com/users/mpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpe/subscriptions","organizations_url":"https://api.github.com/users/mpe/orgs","repos_url":"https://api.github.com/users/mpe/repos","events_url":"https://api.github.com/users/mpe/events{/privacy}","received_events_url":"https://api.github.com/users/mpe/received_events","type":"User","site_admin":false},"labels":[{"id":258178887,"url":"https://api.github.com/repos/linuxppc/linux/labels/bug","name":"bug","color":"fc2929","default":true},{"id":288866483,"url":"https://api.github.com/repos/linuxppc/linux/labels/medium","name":"medium","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-10T14:27:58Z","updated_at":"2018-05-11T01:13:40Z","closed_at":null,"author_association":"OWNER","body":"The faulting instruction is `stxvd2x vs0,r1,r8`, which is Power7 and later only.\r\n\r\n```\r\nemulate_step_test: ld             : PASS\r\nemulate_step_test: lwz            : PASS\r\nemulate_step_test: lwzx           : PASS\r\nemulate_step_test: std            : PASS\r\nemulate_step_test: ldarx / stdcx. : PASS\r\nemulate_step_test: lfsx           : PASS\r\nemulate_step_test: stfsx          : PASS\r\nemulate_step_test: lfdx           : PASS\r\nemulate_step_test: stfdx          : PASS\r\nemulate_step_test: lvx            : PASS\r\nemulate_step_test: stvx           : PASS\r\nOops: Exception in kernel mode, sig: 4 [#1]\r\nBE SMP NR_CPUS=2048 NUMA pSeries\r\nModules linked in:\r\nCPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.17.0-rc4-gcc5x-g036db8b #1\r\nNIP:  c000000000095c24 LR: c000000000094bdc CTR: c00000000008f4a0\r\nREGS: c0000000494c34f0 TRAP: 0700   Not tainted  (4.17.0-rc4-gcc5x-g036db8b)\r\nMSR:  8000000000089032 <SF,EE,ME,IR,DR,RI>  CR: 48004224  XER: 20000009\r\nCFAR: c000000000094bd0 SOFTE: 0 \r\nGPR00: c000000000094bdc c0000000494c3770 c000000001238400 0000000000000027 \r\nGPR04: c0000000494c3870 0000000000000008 8000000000009032 8000000000809032 \r\nGPR08: 0000000000000070 800000000280b032 c0000000494c0000 0000000000000000 \r\nGPR12: 0000000044000428 c000000007fff300 c00000000000e1c0 0000000000000000 \r\nGPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000 \r\nGPR20: 0000000000000000 bfffffffffffffff c0000000494c3870 0000000000000027 \r\nGPR24: c0000000494c3860 0000000000000000 c000000000da0538 c0000000494c3b90 \r\nGPR28: 0000000000000000 c0000000494c3970 c0000000494c3a20 0000000000000008 \r\nNIP [c000000000095c24] .load_vsrn+0x28/0x54\r\nLR [c000000000094bdc] .emulate_loadstore+0x167c/0x17b0\r\nCall Trace:\r\n[c0000000494c3770] [40fe240c7ae147ae] 0x40fe240c7ae147ae (unreliable)\r\n[c0000000494c37f0] [c000000000094bdc] .emulate_loadstore+0x167c/0x17b0\r\n[c0000000494c3900] [c000000000094f6c] .emulate_step+0x25c/0x5bc\r\n[c0000000494c39b0] [c000000000ec90dc] .test_lxvd2x_stxvd2x+0x64/0x154\r\n[c0000000494c3b90] [c000000000ec9204] .test_emulate_step+0x38/0x4c\r\n[c0000000494c3c00] [c00000000000de2c] .do_one_initcall+0x5c/0x2c0\r\n[c0000000494c3cd0] [c000000000eb4bf8] .kernel_init_freeable+0x314/0x4cc\r\n[c0000000494c3db0] [c00000000000e1e4] .kernel_init+0x24/0x160\r\n[c0000000494c3e30] [c00000000000bc24] .ret_from_kernel_thread+0x58/0xb4\r\nInstruction dump:\r\n7c0803a6 4e800420 f821ff81 7c0802a6 f8010090 7cc000a6 64c70080 2f830000 \r\n39000070 7ce00164 4c00012c 419e0008 <7c014798> 7c002698 419e000c 4bfffdad \r\n---[ end trace ed1cbaede8d2aee4 ]---\r\n```"},"comment":{"url":"https://api.github.com/repos/linuxppc/linux/issues/comments/388230626","html_url":"https://github.com/linuxppc/linux/issues/148#issuecomment-388230626","issue_url":"https://api.github.com/repos/linuxppc/linux/issues/148","id":388230626,"user":{"login":"mikey","id":115961,"avatar_url":"https://avatars0.githubusercontent.com/u/115961?v=4","gravatar_id":"","url":"https://api.github.com/users/mikey","html_url":"https://github.com/mikey","followers_url":"https://api.github.com/users/mikey/followers","following_url":"https://api.github.com/users/mikey/following{/other_user}","gists_url":"https://api.github.com/users/mikey/gists{/gist_id}","starred_url":"https://api.github.com/users/mikey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikey/subscriptions","organizations_url":"https://api.github.com/users/mikey/orgs","repos_url":"https://api.github.com/users/mikey/repos","events_url":"https://api.github.com/users/mikey/events{/privacy}","received_events_url":"https://api.github.com/users/mikey/received_events","type":"User","site_admin":false},"created_at":"2018-05-11T01:13:40Z","updated_at":"2018-05-11T01:13:40Z","author_association":"MEMBER","body":"Patch is simply this:\r\n```\r\ndiff --git a/arch/powerpc/lib/test_emulate_step.c b/arch/powerpc/lib/test_emulate_step.c\r\nindex 2534c14475..f2f2d6e728 100644\r\n--- a/arch/powerpc/lib/test_emulate_step.c\r\n+++ b/arch/powerpc/lib/test_emulate_step.c\r\n@@ -371,6 +371,12 @@ static void __init test_lxvd2x_stxvd2x(void)\r\n \tu32 cached_b[4];\r\n \tint stepped = -1;\r\n \r\n+\tif (!cpu_has_feature(CPU_FTR_VSX)) {\r\n+\t\tshow_result(\"lxvd2x\", \"SKIP (no VSX on this CPU)\");\r\n+\t\tshow_result(\"stxvd2x\", \"SKIP (no VSX on this CPU)\");\r\n+\t\treturn;\r\n+\t}\r\n+\r\n \tinit_pt_regs(&regs);\r\n \r\n \r\n```\r\n\r\nI've not tested on P6 but on P9 with vsx disabled via firmware I see this in boot:\r\n\r\n> emulate_step_test: lxvd2x         : SKIP (no VSX on this CPU)\r\n> emulate_step_test: stxvd2x        : SKIP (no VSX on this CPU)\r\n\r\nI'll post to the list.\r\n"}}
{"actor":{"display_login":"mikey"}}