{"action":"created","comment":{"url":"https://api.github.com/repos/Katello/katello/pulls/comments/212192575","pull_request_review_id":148769556,"id":212192575,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjE5MjU3NQ==","diff_hunk":"@@ -0,0 +1,31 @@\n+import React from 'react';\n+import { Link } from 'react-router-dom';\n+import helpers from '../../../../move_to_foreman/common/helpers';\n+\n+export const subscriptionTypeFormatter = (value, { rowData }) => {\n+  let cellContent;\n+\n+  if (rowData.virt_only === false) {\n+    cellContent = __('Physical');\n+  } else if (rowData.hypervisor) {\n+    cellContent = (\n+      <span>\n+        {__('Guests of')}\n+        {' '}","path":"webpack/scenes/Subscriptions/components/SubscriptionsTable/SubscriptionTypeFormatter.js","position":14,"original_position":14,"commit_id":"4f3ec4ec43e1bd2e9377870f74f3ddcec9df6005","original_commit_id":"4f3ec4ec43e1bd2e9377870f74f3ddcec9df6005","user":{"login":"tstrachota","id":1186631,"node_id":"MDQ6VXNlcjExODY2MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1186631?v=4","gravatar_id":"","url":"https://api.github.com/users/tstrachota","html_url":"https://github.com/tstrachota","followers_url":"https://api.github.com/users/tstrachota/followers","following_url":"https://api.github.com/users/tstrachota/following{/other_user}","gists_url":"https://api.github.com/users/tstrachota/gists{/gist_id}","starred_url":"https://api.github.com/users/tstrachota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstrachota/subscriptions","organizations_url":"https://api.github.com/users/tstrachota/orgs","repos_url":"https://api.github.com/users/tstrachota/repos","events_url":"https://api.github.com/users/tstrachota/events{/privacy}","received_events_url":"https://api.github.com/users/tstrachota/received_events","type":"User","site_admin":false},"body":"I'm afraid you can't join components with strings. Or did you mean just `{ [__('Guests of'), ' '].join('') }`? I can do that if you find it better.","created_at":"2018-08-23T06:14:56Z","updated_at":"2018-08-23T06:14:56Z","html_url":"https://github.com/Katello/katello/pull/7647#discussion_r212192575","pull_request_url":"https://api.github.com/repos/Katello/katello/pulls/7647","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments/212192575"},"html":{"href":"https://github.com/Katello/katello/pull/7647#discussion_r212192575"},"pull_request":{"href":"https://api.github.com/repos/Katello/katello/pulls/7647"}},"in_reply_to_id":211920012},"pull_request":{"url":"https://api.github.com/repos/Katello/katello/pulls/7647","id":210062503,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDYyNTAz","html_url":"https://github.com/Katello/katello/pull/7647","diff_url":"https://github.com/Katello/katello/pull/7647.diff","patch_url":"https://github.com/Katello/katello/pull/7647.patch","issue_url":"https://api.github.com/repos/Katello/katello/issues/7647","number":7647,"state":"open","locked":false,"title":"Fixes #24617 - add subscription type column","user":{"login":"tstrachota","id":1186631,"node_id":"MDQ6VXNlcjExODY2MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1186631?v=4","gravatar_id":"","url":"https://api.github.com/users/tstrachota","html_url":"https://github.com/tstrachota","followers_url":"https://api.github.com/users/tstrachota/followers","following_url":"https://api.github.com/users/tstrachota/following{/other_user}","gists_url":"https://api.github.com/users/tstrachota/gists{/gist_id}","starred_url":"https://api.github.com/users/tstrachota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstrachota/subscriptions","organizations_url":"https://api.github.com/users/tstrachota/orgs","repos_url":"https://api.github.com/users/tstrachota/repos","events_url":"https://api.github.com/users/tstrachota/events{/privacy}","received_events_url":"https://api.github.com/users/tstrachota/received_events","type":"User","site_admin":false},"body":"Adds equivalent of a [subscription type column](https://github.com/Katello/katello/blob/8def2f53052a7516a3d3409465d855d33b511454/engines/bastion_katello/app/assets/javascripts/bastion_katello/subscriptions/views/subscription-type.html) from the angular UI onto the new subscriptions page.","created_at":"2018-08-22T08:54:19Z","updated_at":"2018-08-23T06:14:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d28938eaa664eff7c1840b3b24c16056043b61e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":117819343,"node_id":"MDU6TGFiZWwxMTc4MTkzNDM=","url":"https://api.github.com/repos/Katello/katello/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false},{"id":117819415,"node_id":"MDU6TGFiZWwxMTc4MTk0MTU=","url":"https://api.github.com/repos/Katello/katello/labels/Not%20yet%20reviewed","name":"Not yet reviewed","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Katello/katello/pulls/7647/commits","review_comments_url":"https://api.github.com/repos/Katello/katello/pulls/7647/comments","review_comment_url":"https://api.github.com/repos/Katello/katello/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Katello/katello/issues/7647/comments","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/4f3ec4ec43e1bd2e9377870f74f3ddcec9df6005","head":{"label":"tstrachota:subscription_type_column","ref":"subscription_type_column","sha":"4f3ec4ec43e1bd2e9377870f74f3ddcec9df6005","user":{"login":"tstrachota","id":1186631,"node_id":"MDQ6VXNlcjExODY2MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1186631?v=4","gravatar_id":"","url":"https://api.github.com/users/tstrachota","html_url":"https://github.com/tstrachota","followers_url":"https://api.github.com/users/tstrachota/followers","following_url":"https://api.github.com/users/tstrachota/following{/other_user}","gists_url":"https://api.github.com/users/tstrachota/gists{/gist_id}","starred_url":"https://api.github.com/users/tstrachota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstrachota/subscriptions","organizations_url":"https://api.github.com/users/tstrachota/orgs","repos_url":"https://api.github.com/users/tstrachota/repos","events_url":"https://api.github.com/users/tstrachota/events{/privacy}","received_events_url":"https://api.github.com/users/tstrachota/received_events","type":"User","site_admin":false},"repo":{"id":4040551,"node_id":"MDEwOlJlcG9zaXRvcnk0MDQwNTUx","name":"katello","full_name":"tstrachota/katello","owner":{"login":"tstrachota","id":1186631,"node_id":"MDQ6VXNlcjExODY2MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1186631?v=4","gravatar_id":"","url":"https://api.github.com/users/tstrachota","html_url":"https://github.com/tstrachota","followers_url":"https://api.github.com/users/tstrachota/followers","following_url":"https://api.github.com/users/tstrachota/following{/other_user}","gists_url":"https://api.github.com/users/tstrachota/gists{/gist_id}","starred_url":"https://api.github.com/users/tstrachota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstrachota/subscriptions","organizations_url":"https://api.github.com/users/tstrachota/orgs","repos_url":"https://api.github.com/users/tstrachota/repos","events_url":"https://api.github.com/users/tstrachota/events{/privacy}","received_events_url":"https://api.github.com/users/tstrachota/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tstrachota/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":true,"url":"https://api.github.com/repos/tstrachota/katello","forks_url":"https://api.github.com/repos/tstrachota/katello/forks","keys_url":"https://api.github.com/repos/tstrachota/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tstrachota/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tstrachota/katello/teams","hooks_url":"https://api.github.com/repos/tstrachota/katello/hooks","issue_events_url":"https://api.github.com/repos/tstrachota/katello/issues/events{/number}","events_url":"https://api.github.com/repos/tstrachota/katello/events","assignees_url":"https://api.github.com/repos/tstrachota/katello/assignees{/user}","branches_url":"https://api.github.com/repos/tstrachota/katello/branches{/branch}","tags_url":"https://api.github.com/repos/tstrachota/katello/tags","blobs_url":"https://api.github.com/repos/tstrachota/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tstrachota/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tstrachota/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/tstrachota/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tstrachota/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/tstrachota/katello/languages","stargazers_url":"https://api.github.com/repos/tstrachota/katello/stargazers","contributors_url":"https://api.github.com/repos/tstrachota/katello/contributors","subscribers_url":"https://api.github.com/repos/tstrachota/katello/subscribers","subscription_url":"https://api.github.com/repos/tstrachota/katello/subscription","commits_url":"https://api.github.com/repos/tstrachota/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/tstrachota/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/tstrachota/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/tstrachota/katello/issues/comments{/number}","contents_url":"https://api.github.com/repos/tstrachota/katello/contents/{+path}","compare_url":"https://api.github.com/repos/tstrachota/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tstrachota/katello/merges","archive_url":"https://api.github.com/repos/tstrachota/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tstrachota/katello/downloads","issues_url":"https://api.github.com/repos/tstrachota/katello/issues{/number}","pulls_url":"https://api.github.com/repos/tstrachota/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/tstrachota/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/tstrachota/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tstrachota/katello/labels{/name}","releases_url":"https://api.github.com/repos/tstrachota/katello/releases{/id}","deployments_url":"https://api.github.com/repos/tstrachota/katello/deployments","created_at":"2012-04-16T12:26:26Z","updated_at":"2018-08-07T08:59:19Z","pushed_at":"2018-08-22T08:50:44Z","git_url":"git://github.com/tstrachota/katello.git","ssh_url":"git@github.com:tstrachota/katello.git","clone_url":"https://github.com/tstrachota/katello.git","svn_url":"https://github.com/tstrachota/katello","homepage":"katello.org","size":91929,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Katello:master","ref":"master","sha":"009546913c01fe3387743d5216338c0ef92ddff8","user":{"login":"Katello","id":1316386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTYzODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1316386?v=4","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"repo":{"id":4007018,"node_id":"MDEwOlJlcG9zaXRvcnk0MDA3MDE4","name":"katello","full_name":"Katello/katello","owner":{"login":"Katello","id":1316386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTYzODY=","avatar_url":"https://avatars0.githubusercontent.com/u/1316386?v=4","gravatar_id":"","url":"https://api.github.com/users/Katello","html_url":"https://github.com/Katello","followers_url":"https://api.github.com/users/Katello/followers","following_url":"https://api.github.com/users/Katello/following{/other_user}","gists_url":"https://api.github.com/users/Katello/gists{/gist_id}","starred_url":"https://api.github.com/users/Katello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katello/subscriptions","organizations_url":"https://api.github.com/users/Katello/orgs","repos_url":"https://api.github.com/users/Katello/repos","events_url":"https://api.github.com/users/Katello/events{/privacy}","received_events_url":"https://api.github.com/users/Katello/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Katello/katello","description":"Katello integrates open source systems management tools into a single solution for controlling the lifecycle of your machines.","fork":false,"url":"https://api.github.com/repos/Katello/katello","forks_url":"https://api.github.com/repos/Katello/katello/forks","keys_url":"https://api.github.com/repos/Katello/katello/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katello/katello/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katello/katello/teams","hooks_url":"https://api.github.com/repos/Katello/katello/hooks","issue_events_url":"https://api.github.com/repos/Katello/katello/issues/events{/number}","events_url":"https://api.github.com/repos/Katello/katello/events","assignees_url":"https://api.github.com/repos/Katello/katello/assignees{/user}","branches_url":"https://api.github.com/repos/Katello/katello/branches{/branch}","tags_url":"https://api.github.com/repos/Katello/katello/tags","blobs_url":"https://api.github.com/repos/Katello/katello/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katello/katello/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katello/katello/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katello/katello/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katello/katello/statuses/{sha}","languages_url":"https://api.github.com/repos/Katello/katello/languages","stargazers_url":"https://api.github.com/repos/Katello/katello/stargazers","contributors_url":"https://api.github.com/repos/Katello/katello/contributors","subscribers_url":"https://api.github.com/repos/Katello/katello/subscribers","subscription_url":"https://api.github.com/repos/Katello/katello/subscription","commits_url":"https://api.github.com/repos/Katello/katello/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katello/katello/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katello/katello/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katello/katello/issues/comments{/number}","contents_url":"https://api.github.com/repos/Katello/katello/contents/{+path}","compare_url":"https://api.github.com/repos/Katello/katello/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katello/katello/merges","archive_url":"https://api.github.com/repos/Katello/katello/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katello/katello/downloads","issues_url":"https://api.github.com/repos/Katello/katello/issues{/number}","pulls_url":"https://api.github.com/repos/Katello/katello/pulls{/number}","milestones_url":"https://api.github.com/repos/Katello/katello/milestones{/number}","notifications_url":"https://api.github.com/repos/Katello/katello/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katello/katello/labels{/name}","releases_url":"https://api.github.com/repos/Katello/katello/releases{/id}","deployments_url":"https://api.github.com/repos/Katello/katello/deployments","created_at":"2012-04-12T16:59:08Z","updated_at":"2018-08-22T14:53:09Z","pushed_at":"2018-08-22T21:32:33Z","git_url":"git://github.com/Katello/katello.git","ssh_url":"git@github.com:Katello/katello.git","clone_url":"https://github.com/Katello/katello.git","svn_url":"https://github.com/Katello/katello","homepage":"katello.org","size":96070,"stargazers_count":242,"watchers_count":242,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":208,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":208,"open_issues":128,"watchers":242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Katello/katello/pulls/7647"},"html":{"href":"https://github.com/Katello/katello/pull/7647"},"issue":{"href":"https://api.github.com/repos/Katello/katello/issues/7647"},"comments":{"href":"https://api.github.com/repos/Katello/katello/issues/7647/comments"},"review_comments":{"href":"https://api.github.com/repos/Katello/katello/pulls/7647/comments"},"review_comment":{"href":"https://api.github.com/repos/Katello/katello/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Katello/katello/pulls/7647/commits"},"statuses":{"href":"https://api.github.com/repos/Katello/katello/statuses/4f3ec4ec43e1bd2e9377870f74f3ddcec9df6005"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tstrachota"}}