{"action":"created","comment":{"url":"https://api.github.com/repos/Prospress/action-scheduler/pulls/comments/174617319","pull_request_review_id":103963575,"id":174617319,"diff_hunk":"@@ -93,7 +93,7 @@ protected function save_action_group( $post_id, $group ) {\n \n \tpublic function fetch_action( $action_id ) {\n \t\t$post = $this->get_post( $action_id );\n-\t\tif ( empty($post) || $post->post_type != self::POST_TYPE || $post->post_status == 'trash' ) {\n+\t\tif ( empty($post) || $post->post_type != self::POST_TYPE ) {","path":"classes/ActionScheduler_wpPostStore.php","position":5,"original_position":5,"commit_id":"ddfb7e223cdbd3ec8331da983cb8154b6e01ac05","original_commit_id":"ddfb7e223cdbd3ec8331da983cb8154b6e01ac05","user":{"login":"JPry","id":871924,"avatar_url":"https://avatars0.githubusercontent.com/u/871924?v=4","gravatar_id":"","url":"https://api.github.com/users/JPry","html_url":"https://github.com/JPry","followers_url":"https://api.github.com/users/JPry/followers","following_url":"https://api.github.com/users/JPry/following{/other_user}","gists_url":"https://api.github.com/users/JPry/gists{/gist_id}","starred_url":"https://api.github.com/users/JPry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JPry/subscriptions","organizations_url":"https://api.github.com/users/JPry/orgs","repos_url":"https://api.github.com/users/JPry/repos","events_url":"https://api.github.com/users/JPry/events{/privacy}","received_events_url":"https://api.github.com/users/JPry/received_events","type":"User","site_admin":false},"body":"Since this line is already being modified, the `empty($post)` statement should be formatted for WP standards","created_at":"2018-03-14T21:34:51Z","updated_at":"2018-03-14T22:00:54Z","html_url":"https://github.com/Prospress/action-scheduler/pull/113#discussion_r174617319","pull_request_url":"https://api.github.com/repos/Prospress/action-scheduler/pulls/113","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Prospress/action-scheduler/pulls/comments/174617319"},"html":{"href":"https://github.com/Prospress/action-scheduler/pull/113#discussion_r174617319"},"pull_request":{"href":"https://api.github.com/repos/Prospress/action-scheduler/pulls/113"}}},"pull_request":{"url":"https://api.github.com/repos/Prospress/action-scheduler/pulls/113","id":174513236,"html_url":"https://github.com/Prospress/action-scheduler/pull/113","diff_url":"https://github.com/Prospress/action-scheduler/pull/113.diff","patch_url":"https://github.com/Prospress/action-scheduler/pull/113.patch","issue_url":"https://api.github.com/repos/Prospress/action-scheduler/issues/113","number":113,"state":"open","locked":false,"title":"Add new Admin UI using data store instead of post APIs","user":{"login":"thenbrent","id":235523,"avatar_url":"https://avatars3.githubusercontent.com/u/235523?v=4","gravatar_id":"","url":"https://api.github.com/users/thenbrent","html_url":"https://github.com/thenbrent","followers_url":"https://api.github.com/users/thenbrent/followers","following_url":"https://api.github.com/users/thenbrent/following{/other_user}","gists_url":"https://api.github.com/users/thenbrent/gists{/gist_id}","starred_url":"https://api.github.com/users/thenbrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thenbrent/subscriptions","organizations_url":"https://api.github.com/users/thenbrent/orgs","repos_url":"https://api.github.com/users/thenbrent/repos","events_url":"https://api.github.com/users/thenbrent/events{/privacy}","received_events_url":"https://api.github.com/users/thenbrent/received_events","type":"User","site_admin":false},"body":"This is a redo of PR #88 for Issue #85. I'm opening a new PR as #88 has become unwieldy in its history. This PR has merged `1-6-dev` (I couldn't rebase without losing subtree data for the pp list table), and adds additional commits to add sortable columns, display Claim ID and a few other patches to bring the admin UI closer to completeness. The only feature remaining for it to have feature parity with the old admin UI and close #85 is a _Search_ box.\r\n\r\nThis PR also negates #110, which attempted to solve the problem of accessing an actions data by moving that data into the action itself. The changes required to achieve that are excessive, so I've opted to return to the approach of using the data store for accessing that data, as it is much cleaner for now. It also avoids issues like whether data on the action should be changed, e.g. if it's a _pending_ action's status should be changed to _completed_ after `execute()` is called - something which makes sense, but which is an entirely new paradigm for Action Scheduler, and which may have unforeseen implications.\r\n\r\nThis PR is ready for review, but I'd encourage you to avoid reviewing the commit history, as it's still unwieldy.","created_at":"2018-03-12T22:34:00Z","updated_at":"2018-03-14T22:00:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c0d7b7759abaebf5d504bebc7519ebb6d03e49b","assignee":{"login":"thenbrent","id":235523,"avatar_url":"https://avatars3.githubusercontent.com/u/235523?v=4","gravatar_id":"","url":"https://api.github.com/users/thenbrent","html_url":"https://github.com/thenbrent","followers_url":"https://api.github.com/users/thenbrent/followers","following_url":"https://api.github.com/users/thenbrent/following{/other_user}","gists_url":"https://api.github.com/users/thenbrent/gists{/gist_id}","starred_url":"https://api.github.com/users/thenbrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thenbrent/subscriptions","organizations_url":"https://api.github.com/users/thenbrent/orgs","repos_url":"https://api.github.com/users/thenbrent/repos","events_url":"https://api.github.com/users/thenbrent/events{/privacy}","received_events_url":"https://api.github.com/users/thenbrent/received_events","type":"User","site_admin":false},"assignees":[{"login":"thenbrent","id":235523,"avatar_url":"https://avatars3.githubusercontent.com/u/235523?v=4","gravatar_id":"","url":"https://api.github.com/users/thenbrent","html_url":"https://github.com/thenbrent","followers_url":"https://api.github.com/users/thenbrent/followers","following_url":"https://api.github.com/users/thenbrent/following{/other_user}","gists_url":"https://api.github.com/users/thenbrent/gists{/gist_id}","starred_url":"https://api.github.com/users/thenbrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thenbrent/subscriptions","organizations_url":"https://api.github.com/users/thenbrent/orgs","repos_url":"https://api.github.com/users/thenbrent/repos","events_url":"https://api.github.com/users/thenbrent/events{/privacy}","received_events_url":"https://api.github.com/users/thenbrent/received_events","type":"User","site_admin":false},{"login":"JPry","id":871924,"avatar_url":"https://avatars0.githubusercontent.com/u/871924?v=4","gravatar_id":"","url":"https://api.github.com/users/JPry","html_url":"https://github.com/JPry","followers_url":"https://api.github.com/users/JPry/followers","following_url":"https://api.github.com/users/JPry/following{/other_user}","gists_url":"https://api.github.com/users/JPry/gists{/gist_id}","starred_url":"https://api.github.com/users/JPry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JPry/subscriptions","organizations_url":"https://api.github.com/users/JPry/orgs","repos_url":"https://api.github.com/users/JPry/repos","events_url":"https://api.github.com/users/JPry/events{/privacy}","received_events_url":"https://api.github.com/users/JPry/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/Prospress/action-scheduler/milestones/1","html_url":"https://github.com/Prospress/action-scheduler/milestone/1","labels_url":"https://api.github.com/repos/Prospress/action-scheduler/milestones/1/labels","id":2522584,"number":1,"title":"2.0","description":"","creator":{"login":"thenbrent","id":235523,"avatar_url":"https://avatars3.githubusercontent.com/u/235523?v=4","gravatar_id":"","url":"https://api.github.com/users/thenbrent","html_url":"https://github.com/thenbrent","followers_url":"https://api.github.com/users/thenbrent/followers","following_url":"https://api.github.com/users/thenbrent/following{/other_user}","gists_url":"https://api.github.com/users/thenbrent/gists{/gist_id}","starred_url":"https://api.github.com/users/thenbrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thenbrent/subscriptions","organizations_url":"https://api.github.com/users/thenbrent/orgs","repos_url":"https://api.github.com/users/thenbrent/repos","events_url":"https://api.github.com/users/thenbrent/events{/privacy}","received_events_url":"https://api.github.com/users/thenbrent/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":1,"state":"open","created_at":"2017-05-15T21:02:31Z","updated_at":"2018-03-13T18:40:04Z","due_on":"2018-03-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Prospress/action-scheduler/pulls/113/commits","review_comments_url":"https://api.github.com/repos/Prospress/action-scheduler/pulls/113/comments","review_comment_url":"https://api.github.com/repos/Prospress/action-scheduler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Prospress/action-scheduler/issues/113/comments","statuses_url":"https://api.github.com/repos/Prospress/action-scheduler/statuses/ddfb7e223cdbd3ec8331da983cb8154b6e01ac05","head":{"label":"Prospress:issue_85_datastore_redux","ref":"issue_85_datastore_redux","sha":"ddfb7e223cdbd3ec8331da983cb8154b6e01ac05","user":{"login":"Prospress","id":7764284,"avatar_url":"https://avatars1.githubusercontent.com/u/7764284?v=4","gravatar_id":"","url":"https://api.github.com/users/Prospress","html_url":"https://github.com/Prospress","followers_url":"https://api.github.com/users/Prospress/followers","following_url":"https://api.github.com/users/Prospress/following{/other_user}","gists_url":"https://api.github.com/users/Prospress/gists{/gist_id}","starred_url":"https://api.github.com/users/Prospress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prospress/subscriptions","organizations_url":"https://api.github.com/users/Prospress/orgs","repos_url":"https://api.github.com/users/Prospress/repos","events_url":"https://api.github.com/users/Prospress/events{/privacy}","received_events_url":"https://api.github.com/users/Prospress/received_events","type":"Organization","site_admin":false},"repo":{"id":14875275,"name":"action-scheduler","full_name":"Prospress/action-scheduler","owner":{"login":"Prospress","id":7764284,"avatar_url":"https://avatars1.githubusercontent.com/u/7764284?v=4","gravatar_id":"","url":"https://api.github.com/users/Prospress","html_url":"https://github.com/Prospress","followers_url":"https://api.github.com/users/Prospress/followers","following_url":"https://api.github.com/users/Prospress/following{/other_user}","gists_url":"https://api.github.com/users/Prospress/gists{/gist_id}","starred_url":"https://api.github.com/users/Prospress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prospress/subscriptions","organizations_url":"https://api.github.com/users/Prospress/orgs","repos_url":"https://api.github.com/users/Prospress/repos","events_url":"https://api.github.com/users/Prospress/events{/privacy}","received_events_url":"https://api.github.com/users/Prospress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Prospress/action-scheduler","description":"A robust scheduling library for use in WordPress plugins and WooCommerce extensions.","fork":false,"url":"https://api.github.com/repos/Prospress/action-scheduler","forks_url":"https://api.github.com/repos/Prospress/action-scheduler/forks","keys_url":"https://api.github.com/repos/Prospress/action-scheduler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Prospress/action-scheduler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Prospress/action-scheduler/teams","hooks_url":"https://api.github.com/repos/Prospress/action-scheduler/hooks","issue_events_url":"https://api.github.com/repos/Prospress/action-scheduler/issues/events{/number}","events_url":"https://api.github.com/repos/Prospress/action-scheduler/events","assignees_url":"https://api.github.com/repos/Prospress/action-scheduler/assignees{/user}","branches_url":"https://api.github.com/repos/Prospress/action-scheduler/branches{/branch}","tags_url":"https://api.github.com/repos/Prospress/action-scheduler/tags","blobs_url":"https://api.github.com/repos/Prospress/action-scheduler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Prospress/action-scheduler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Prospress/action-scheduler/git/refs{/sha}","trees_url":"https://api.github.com/repos/Prospress/action-scheduler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Prospress/action-scheduler/statuses/{sha}","languages_url":"https://api.github.com/repos/Prospress/action-scheduler/languages","stargazers_url":"https://api.github.com/repos/Prospress/action-scheduler/stargazers","contributors_url":"https://api.github.com/repos/Prospress/action-scheduler/contributors","subscribers_url":"https://api.github.com/repos/Prospress/action-scheduler/subscribers","subscription_url":"https://api.github.com/repos/Prospress/action-scheduler/subscription","commits_url":"https://api.github.com/repos/Prospress/action-scheduler/commits{/sha}","git_commits_url":"https://api.github.com/repos/Prospress/action-scheduler/git/commits{/sha}","comments_url":"https://api.github.com/repos/Prospress/action-scheduler/comments{/number}","issue_comment_url":"https://api.github.com/repos/Prospress/action-scheduler/issues/comments{/number}","contents_url":"https://api.github.com/repos/Prospress/action-scheduler/contents/{+path}","compare_url":"https://api.github.com/repos/Prospress/action-scheduler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Prospress/action-scheduler/merges","archive_url":"https://api.github.com/repos/Prospress/action-scheduler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Prospress/action-scheduler/downloads","issues_url":"https://api.github.com/repos/Prospress/action-scheduler/issues{/number}","pulls_url":"https://api.github.com/repos/Prospress/action-scheduler/pulls{/number}","milestones_url":"https://api.github.com/repos/Prospress/action-scheduler/milestones{/number}","notifications_url":"https://api.github.com/repos/Prospress/action-scheduler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Prospress/action-scheduler/labels{/name}","releases_url":"https://api.github.com/repos/Prospress/action-scheduler/releases{/id}","deployments_url":"https://api.github.com/repos/Prospress/action-scheduler/deployments","created_at":"2013-12-02T21:23:35Z","updated_at":"2018-03-14T12:40:43Z","pushed_at":"2018-03-14T15:33:40Z","git_url":"git://github.com/Prospress/action-scheduler.git","ssh_url":"git@github.com:Prospress/action-scheduler.git","clone_url":"https://github.com/Prospress/action-scheduler.git","svn_url":"https://github.com/Prospress/action-scheduler","homepage":"","size":438,"stargazers_count":96,"watchers_count":96,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":17,"open_issues":19,"watchers":96,"default_branch":"master"}},"base":{"label":"Prospress:1-6-dev","ref":"1-6-dev","sha":"cf3647d87a109aa46361561edb3698260c2b6218","user":{"login":"Prospress","id":7764284,"avatar_url":"https://avatars1.githubusercontent.com/u/7764284?v=4","gravatar_id":"","url":"https://api.github.com/users/Prospress","html_url":"https://github.com/Prospress","followers_url":"https://api.github.com/users/Prospress/followers","following_url":"https://api.github.com/users/Prospress/following{/other_user}","gists_url":"https://api.github.com/users/Prospress/gists{/gist_id}","starred_url":"https://api.github.com/users/Prospress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prospress/subscriptions","organizations_url":"https://api.github.com/users/Prospress/orgs","repos_url":"https://api.github.com/users/Prospress/repos","events_url":"https://api.github.com/users/Prospress/events{/privacy}","received_events_url":"https://api.github.com/users/Prospress/received_events","type":"Organization","site_admin":false},"repo":{"id":14875275,"name":"action-scheduler","full_name":"Prospress/action-scheduler","owner":{"login":"Prospress","id":7764284,"avatar_url":"https://avatars1.githubusercontent.com/u/7764284?v=4","gravatar_id":"","url":"https://api.github.com/users/Prospress","html_url":"https://github.com/Prospress","followers_url":"https://api.github.com/users/Prospress/followers","following_url":"https://api.github.com/users/Prospress/following{/other_user}","gists_url":"https://api.github.com/users/Prospress/gists{/gist_id}","starred_url":"https://api.github.com/users/Prospress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prospress/subscriptions","organizations_url":"https://api.github.com/users/Prospress/orgs","repos_url":"https://api.github.com/users/Prospress/repos","events_url":"https://api.github.com/users/Prospress/events{/privacy}","received_events_url":"https://api.github.com/users/Prospress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Prospress/action-scheduler","description":"A robust scheduling library for use in WordPress plugins and WooCommerce extensions.","fork":false,"url":"https://api.github.com/repos/Prospress/action-scheduler","forks_url":"https://api.github.com/repos/Prospress/action-scheduler/forks","keys_url":"https://api.github.com/repos/Prospress/action-scheduler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Prospress/action-scheduler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Prospress/action-scheduler/teams","hooks_url":"https://api.github.com/repos/Prospress/action-scheduler/hooks","issue_events_url":"https://api.github.com/repos/Prospress/action-scheduler/issues/events{/number}","events_url":"https://api.github.com/repos/Prospress/action-scheduler/events","assignees_url":"https://api.github.com/repos/Prospress/action-scheduler/assignees{/user}","branches_url":"https://api.github.com/repos/Prospress/action-scheduler/branches{/branch}","tags_url":"https://api.github.com/repos/Prospress/action-scheduler/tags","blobs_url":"https://api.github.com/repos/Prospress/action-scheduler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Prospress/action-scheduler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Prospress/action-scheduler/git/refs{/sha}","trees_url":"https://api.github.com/repos/Prospress/action-scheduler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Prospress/action-scheduler/statuses/{sha}","languages_url":"https://api.github.com/repos/Prospress/action-scheduler/languages","stargazers_url":"https://api.github.com/repos/Prospress/action-scheduler/stargazers","contributors_url":"https://api.github.com/repos/Prospress/action-scheduler/contributors","subscribers_url":"https://api.github.com/repos/Prospress/action-scheduler/subscribers","subscription_url":"https://api.github.com/repos/Prospress/action-scheduler/subscription","commits_url":"https://api.github.com/repos/Prospress/action-scheduler/commits{/sha}","git_commits_url":"https://api.github.com/repos/Prospress/action-scheduler/git/commits{/sha}","comments_url":"https://api.github.com/repos/Prospress/action-scheduler/comments{/number}","issue_comment_url":"https://api.github.com/repos/Prospress/action-scheduler/issues/comments{/number}","contents_url":"https://api.github.com/repos/Prospress/action-scheduler/contents/{+path}","compare_url":"https://api.github.com/repos/Prospress/action-scheduler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Prospress/action-scheduler/merges","archive_url":"https://api.github.com/repos/Prospress/action-scheduler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Prospress/action-scheduler/downloads","issues_url":"https://api.github.com/repos/Prospress/action-scheduler/issues{/number}","pulls_url":"https://api.github.com/repos/Prospress/action-scheduler/pulls{/number}","milestones_url":"https://api.github.com/repos/Prospress/action-scheduler/milestones{/number}","notifications_url":"https://api.github.com/repos/Prospress/action-scheduler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Prospress/action-scheduler/labels{/name}","releases_url":"https://api.github.com/repos/Prospress/action-scheduler/releases{/id}","deployments_url":"https://api.github.com/repos/Prospress/action-scheduler/deployments","created_at":"2013-12-02T21:23:35Z","updated_at":"2018-03-14T12:40:43Z","pushed_at":"2018-03-14T15:33:40Z","git_url":"git://github.com/Prospress/action-scheduler.git","ssh_url":"git@github.com:Prospress/action-scheduler.git","clone_url":"https://github.com/Prospress/action-scheduler.git","svn_url":"https://github.com/Prospress/action-scheduler","homepage":"","size":438,"stargazers_count":96,"watchers_count":96,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":17,"open_issues":19,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Prospress/action-scheduler/pulls/113"},"html":{"href":"https://github.com/Prospress/action-scheduler/pull/113"},"issue":{"href":"https://api.github.com/repos/Prospress/action-scheduler/issues/113"},"comments":{"href":"https://api.github.com/repos/Prospress/action-scheduler/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/Prospress/action-scheduler/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/Prospress/action-scheduler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Prospress/action-scheduler/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/Prospress/action-scheduler/statuses/ddfb7e223cdbd3ec8331da983cb8154b6e01ac05"}},"author_association":"OWNER"}}
{"actor":{"display_login":"JPry"}}