{"action":"created","comment":{"url":"https://api.github.com/repos/xqemu/xqemu/pulls/comments/202819834","pull_request_review_id":137591413,"id":202819834,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjgxOTgzNA==","diff_hunk":"@@ -30,11 +37,23 @@ def main():\n \t\tif dll_name.startswith('???'):\r\n \t\t\tprint('Unknown DLL?')\r\n \t\t\tcontinue\r\n-\t\tif dll_path.lower().startswith('/c/windows') or dll_path.lower().startswith('c:/windows'):\r\n+\t\tif has_cygpath:\r","path":"get_deps.py","position":19,"original_position":19,"commit_id":"94b86c22d28524e29da1f326fe92546bfc7da229","original_commit_id":"94b86c22d28524e29da1f326fe92546bfc7da229","user":{"login":"muemart","id":15017699,"node_id":"MDQ6VXNlcjE1MDE3Njk5","avatar_url":"https://avatars0.githubusercontent.com/u/15017699?v=4","gravatar_id":"","url":"https://api.github.com/users/muemart","html_url":"https://github.com/muemart","followers_url":"https://api.github.com/users/muemart/followers","following_url":"https://api.github.com/users/muemart/following{/other_user}","gists_url":"https://api.github.com/users/muemart/gists{/gist_id}","starred_url":"https://api.github.com/users/muemart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muemart/subscriptions","organizations_url":"https://api.github.com/users/muemart/orgs","repos_url":"https://api.github.com/users/muemart/repos","events_url":"https://api.github.com/users/muemart/events{/privacy}","received_events_url":"https://api.github.com/users/muemart/received_events","type":"User","site_admin":false},"body":"For the record, this is the output in the mingw64 shell after installing `mingw-w64-x86_64-python2`:\r\n```\r\n$ python2\r\nPython 2.7.15 (default, May  4 2018, 07:39:01)  [GCC 7.3.0 64 bit (AMD64)] on win32\r\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\r\n>>> import os.path\r\n>>> os.path.abspath('/c/windows.notepad.exe')\r\n'C:/c/windows.notepad.exe'\r\n>>> os.path.abspath('c:\\\\windows\\\\notepad.exe')\r\n'c:/windows/notepad.exe'\r\n>>>\r\n```","created_at":"2018-07-16T20:49:29Z","updated_at":"2018-07-16T20:49:29Z","html_url":"https://github.com/xqemu/xqemu/pull/82#discussion_r202819834","pull_request_url":"https://api.github.com/repos/xqemu/xqemu/pulls/82","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/xqemu/xqemu/pulls/comments/202819834"},"html":{"href":"https://github.com/xqemu/xqemu/pull/82#discussion_r202819834"},"pull_request":{"href":"https://api.github.com/repos/xqemu/xqemu/pulls/82"}},"in_reply_to_id":202557122},"pull_request":{"url":"https://api.github.com/repos/xqemu/xqemu/pulls/82","id":201372505,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzcyNTA1","html_url":"https://github.com/xqemu/xqemu/pull/82","diff_url":"https://github.com/xqemu/xqemu/pull/82.diff","patch_url":"https://github.com/xqemu/xqemu/pull/82.patch","issue_url":"https://api.github.com/repos/xqemu/xqemu/issues/82","number":82,"state":"open","locked":false,"title":"Fix copying of DLLs on Windows","user":{"login":"muemart","id":15017699,"node_id":"MDQ6VXNlcjE1MDE3Njk5","avatar_url":"https://avatars0.githubusercontent.com/u/15017699?v=4","gravatar_id":"","url":"https://api.github.com/users/muemart","html_url":"https://github.com/muemart","followers_url":"https://api.github.com/users/muemart/followers","following_url":"https://api.github.com/users/muemart/following{/other_user}","gists_url":"https://api.github.com/users/muemart/gists{/gist_id}","starred_url":"https://api.github.com/users/muemart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muemart/subscriptions","organizations_url":"https://api.github.com/users/muemart/orgs","repos_url":"https://api.github.com/users/muemart/repos","events_url":"https://api.github.com/users/muemart/events{/privacy}","received_events_url":"https://api.github.com/users/muemart/received_events","type":"User","site_admin":false},"body":"This fixes the Python script copying the DLLs by converting the Unix path to Windows paths. Apparently Python recognizes that it's running on Windows and thus interprets the paths wrong.\r\nI was building on Drive D, and Python interpreted the path \"/mingw64/bin/libgcc_s_seh-1.dll\" as \"D:/mingw64/bin/libgcc_s_seh-1.dll\", which was wrong in my case.\r\nThis fixes #62.","created_at":"2018-07-13T18:53:25Z","updated_at":"2018-07-16T20:49:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bf0fd4b8fe28869e3621b3b5857874895158a18","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xqemu/xqemu/pulls/82/commits","review_comments_url":"https://api.github.com/repos/xqemu/xqemu/pulls/82/comments","review_comment_url":"https://api.github.com/repos/xqemu/xqemu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xqemu/xqemu/issues/82/comments","statuses_url":"https://api.github.com/repos/xqemu/xqemu/statuses/94b86c22d28524e29da1f326fe92546bfc7da229","head":{"label":"muemart:deps","ref":"deps","sha":"94b86c22d28524e29da1f326fe92546bfc7da229","user":{"login":"muemart","id":15017699,"node_id":"MDQ6VXNlcjE1MDE3Njk5","avatar_url":"https://avatars0.githubusercontent.com/u/15017699?v=4","gravatar_id":"","url":"https://api.github.com/users/muemart","html_url":"https://github.com/muemart","followers_url":"https://api.github.com/users/muemart/followers","following_url":"https://api.github.com/users/muemart/following{/other_user}","gists_url":"https://api.github.com/users/muemart/gists{/gist_id}","starred_url":"https://api.github.com/users/muemart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muemart/subscriptions","organizations_url":"https://api.github.com/users/muemart/orgs","repos_url":"https://api.github.com/users/muemart/repos","events_url":"https://api.github.com/users/muemart/events{/privacy}","received_events_url":"https://api.github.com/users/muemart/received_events","type":"User","site_admin":false},"repo":{"id":140881341,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA4ODEzNDE=","name":"xqemu","full_name":"muemart/xqemu","owner":{"login":"muemart","id":15017699,"node_id":"MDQ6VXNlcjE1MDE3Njk5","avatar_url":"https://avatars0.githubusercontent.com/u/15017699?v=4","gravatar_id":"","url":"https://api.github.com/users/muemart","html_url":"https://github.com/muemart","followers_url":"https://api.github.com/users/muemart/followers","following_url":"https://api.github.com/users/muemart/following{/other_user}","gists_url":"https://api.github.com/users/muemart/gists{/gist_id}","starred_url":"https://api.github.com/users/muemart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muemart/subscriptions","organizations_url":"https://api.github.com/users/muemart/orgs","repos_url":"https://api.github.com/users/muemart/repos","events_url":"https://api.github.com/users/muemart/events{/privacy}","received_events_url":"https://api.github.com/users/muemart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muemart/xqemu","description":"Open-source emulator to play original Xbox games on Windows, macOS, and Linux","fork":true,"url":"https://api.github.com/repos/muemart/xqemu","forks_url":"https://api.github.com/repos/muemart/xqemu/forks","keys_url":"https://api.github.com/repos/muemart/xqemu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muemart/xqemu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muemart/xqemu/teams","hooks_url":"https://api.github.com/repos/muemart/xqemu/hooks","issue_events_url":"https://api.github.com/repos/muemart/xqemu/issues/events{/number}","events_url":"https://api.github.com/repos/muemart/xqemu/events","assignees_url":"https://api.github.com/repos/muemart/xqemu/assignees{/user}","branches_url":"https://api.github.com/repos/muemart/xqemu/branches{/branch}","tags_url":"https://api.github.com/repos/muemart/xqemu/tags","blobs_url":"https://api.github.com/repos/muemart/xqemu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muemart/xqemu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muemart/xqemu/git/refs{/sha}","trees_url":"https://api.github.com/repos/muemart/xqemu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muemart/xqemu/statuses/{sha}","languages_url":"https://api.github.com/repos/muemart/xqemu/languages","stargazers_url":"https://api.github.com/repos/muemart/xqemu/stargazers","contributors_url":"https://api.github.com/repos/muemart/xqemu/contributors","subscribers_url":"https://api.github.com/repos/muemart/xqemu/subscribers","subscription_url":"https://api.github.com/repos/muemart/xqemu/subscription","commits_url":"https://api.github.com/repos/muemart/xqemu/commits{/sha}","git_commits_url":"https://api.github.com/repos/muemart/xqemu/git/commits{/sha}","comments_url":"https://api.github.com/repos/muemart/xqemu/comments{/number}","issue_comment_url":"https://api.github.com/repos/muemart/xqemu/issues/comments{/number}","contents_url":"https://api.github.com/repos/muemart/xqemu/contents/{+path}","compare_url":"https://api.github.com/repos/muemart/xqemu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muemart/xqemu/merges","archive_url":"https://api.github.com/repos/muemart/xqemu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muemart/xqemu/downloads","issues_url":"https://api.github.com/repos/muemart/xqemu/issues{/number}","pulls_url":"https://api.github.com/repos/muemart/xqemu/pulls{/number}","milestones_url":"https://api.github.com/repos/muemart/xqemu/milestones{/number}","notifications_url":"https://api.github.com/repos/muemart/xqemu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muemart/xqemu/labels{/name}","releases_url":"https://api.github.com/repos/muemart/xqemu/releases{/id}","deployments_url":"https://api.github.com/repos/muemart/xqemu/deployments","created_at":"2018-07-13T18:37:01Z","updated_at":"2018-07-13T18:37:23Z","pushed_at":"2018-07-15T10:39:00Z","git_url":"git://github.com/muemart/xqemu.git","ssh_url":"git@github.com:muemart/xqemu.git","clone_url":"https://github.com/muemart/xqemu.git","svn_url":"https://github.com/muemart/xqemu","homepage":"https://xqemu.com","size":179694,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xqemu:master","ref":"master","sha":"4ffe83b6967e80a24e11f36575ddc5341da3f4da","user":{"login":"xqemu","id":13059056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDU5MDU2","avatar_url":"https://avatars1.githubusercontent.com/u/13059056?v=4","gravatar_id":"","url":"https://api.github.com/users/xqemu","html_url":"https://github.com/xqemu","followers_url":"https://api.github.com/users/xqemu/followers","following_url":"https://api.github.com/users/xqemu/following{/other_user}","gists_url":"https://api.github.com/users/xqemu/gists{/gist_id}","starred_url":"https://api.github.com/users/xqemu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xqemu/subscriptions","organizations_url":"https://api.github.com/users/xqemu/orgs","repos_url":"https://api.github.com/users/xqemu/repos","events_url":"https://api.github.com/users/xqemu/events{/privacy}","received_events_url":"https://api.github.com/users/xqemu/received_events","type":"Organization","site_admin":false},"repo":{"id":126295707,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyOTU3MDc=","name":"xqemu","full_name":"xqemu/xqemu","owner":{"login":"xqemu","id":13059056,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDU5MDU2","avatar_url":"https://avatars1.githubusercontent.com/u/13059056?v=4","gravatar_id":"","url":"https://api.github.com/users/xqemu","html_url":"https://github.com/xqemu","followers_url":"https://api.github.com/users/xqemu/followers","following_url":"https://api.github.com/users/xqemu/following{/other_user}","gists_url":"https://api.github.com/users/xqemu/gists{/gist_id}","starred_url":"https://api.github.com/users/xqemu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xqemu/subscriptions","organizations_url":"https://api.github.com/users/xqemu/orgs","repos_url":"https://api.github.com/users/xqemu/repos","events_url":"https://api.github.com/users/xqemu/events{/privacy}","received_events_url":"https://api.github.com/users/xqemu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xqemu/xqemu","description":"Open-source emulator to play original Xbox games on Windows, macOS, and Linux","fork":false,"url":"https://api.github.com/repos/xqemu/xqemu","forks_url":"https://api.github.com/repos/xqemu/xqemu/forks","keys_url":"https://api.github.com/repos/xqemu/xqemu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xqemu/xqemu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xqemu/xqemu/teams","hooks_url":"https://api.github.com/repos/xqemu/xqemu/hooks","issue_events_url":"https://api.github.com/repos/xqemu/xqemu/issues/events{/number}","events_url":"https://api.github.com/repos/xqemu/xqemu/events","assignees_url":"https://api.github.com/repos/xqemu/xqemu/assignees{/user}","branches_url":"https://api.github.com/repos/xqemu/xqemu/branches{/branch}","tags_url":"https://api.github.com/repos/xqemu/xqemu/tags","blobs_url":"https://api.github.com/repos/xqemu/xqemu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xqemu/xqemu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xqemu/xqemu/git/refs{/sha}","trees_url":"https://api.github.com/repos/xqemu/xqemu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xqemu/xqemu/statuses/{sha}","languages_url":"https://api.github.com/repos/xqemu/xqemu/languages","stargazers_url":"https://api.github.com/repos/xqemu/xqemu/stargazers","contributors_url":"https://api.github.com/repos/xqemu/xqemu/contributors","subscribers_url":"https://api.github.com/repos/xqemu/xqemu/subscribers","subscription_url":"https://api.github.com/repos/xqemu/xqemu/subscription","commits_url":"https://api.github.com/repos/xqemu/xqemu/commits{/sha}","git_commits_url":"https://api.github.com/repos/xqemu/xqemu/git/commits{/sha}","comments_url":"https://api.github.com/repos/xqemu/xqemu/comments{/number}","issue_comment_url":"https://api.github.com/repos/xqemu/xqemu/issues/comments{/number}","contents_url":"https://api.github.com/repos/xqemu/xqemu/contents/{+path}","compare_url":"https://api.github.com/repos/xqemu/xqemu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xqemu/xqemu/merges","archive_url":"https://api.github.com/repos/xqemu/xqemu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xqemu/xqemu/downloads","issues_url":"https://api.github.com/repos/xqemu/xqemu/issues{/number}","pulls_url":"https://api.github.com/repos/xqemu/xqemu/pulls{/number}","milestones_url":"https://api.github.com/repos/xqemu/xqemu/milestones{/number}","notifications_url":"https://api.github.com/repos/xqemu/xqemu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xqemu/xqemu/labels{/name}","releases_url":"https://api.github.com/repos/xqemu/xqemu/releases{/id}","deployments_url":"https://api.github.com/repos/xqemu/xqemu/deployments","created_at":"2018-03-22T07:23:11Z","updated_at":"2018-07-16T09:22:08Z","pushed_at":"2018-07-16T02:33:57Z","git_url":"git://github.com/xqemu/xqemu.git","ssh_url":"git@github.com:xqemu/xqemu.git","clone_url":"https://github.com/xqemu/xqemu.git","svn_url":"https://github.com/xqemu/xqemu","homepage":"https://xqemu.com","size":179628,"stargazers_count":52,"watchers_count":52,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12,"open_issues":54,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xqemu/xqemu/pulls/82"},"html":{"href":"https://github.com/xqemu/xqemu/pull/82"},"issue":{"href":"https://api.github.com/repos/xqemu/xqemu/issues/82"},"comments":{"href":"https://api.github.com/repos/xqemu/xqemu/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/xqemu/xqemu/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/xqemu/xqemu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xqemu/xqemu/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/xqemu/xqemu/statuses/94b86c22d28524e29da1f326fe92546bfc7da229"}},"author_association":"NONE"}}
{"actor":{"display_login":"muemart"}}