{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/14198","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/14198/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/14198/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/14198/events","html_url":"https://github.com/highfidelity/hifi/pull/14198","id":369666283,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNTUyODY3","number":14198,"title":"Entity list type filter and X to clear search","user":{"login":"dback2","id":31390055,"node_id":"MDQ6VXNlcjMxMzkwMDU1","avatar_url":"https://avatars3.githubusercontent.com/u/31390055?v=4","gravatar_id":"","url":"https://api.github.com/users/dback2","html_url":"https://github.com/dback2","followers_url":"https://api.github.com/users/dback2/followers","following_url":"https://api.github.com/users/dback2/following{/other_user}","gists_url":"https://api.github.com/users/dback2/gists{/gist_id}","starred_url":"https://api.github.com/users/dback2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dback2/subscriptions","organizations_url":"https://api.github.com/users/dback2/orgs","repos_url":"https://api.github.com/users/dback2/repos","events_url":"https://api.github.com/users/dback2/events{/privacy}","received_events_url":"https://api.github.com/users/dback2/received_events","type":"User","site_admin":false},"labels":[{"id":751510477,"node_id":"MDU6TGFiZWw3NTE1MTA0Nzc=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Create","name":"Create","color":"e288db","default":false},{"id":278749229,"node_id":"MDU6TGFiZWwyNzg3NDkyMjk=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Feedback%20Welcome","name":"Feedback Welcome","color":"cafc94","default":false},{"id":461634431,"node_id":"MDU6TGFiZWw0NjE2MzQ0MzE=","url":"https://api.github.com/repos/highfidelity/hifi/labels/HMD%20required","name":"HMD required","color":"d4c5f9","default":false},{"id":733764234,"node_id":"MDU6TGFiZWw3MzM3NjQyMzQ=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Project%20Approved","name":"Project Approved","color":"009800","default":false},{"id":313595519,"node_id":"MDU6TGFiZWwzMTM1OTU1MTk=","url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Ready","name":"QA Ready","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/35","html_url":"https://github.com/highfidelity/hifi/milestone/35","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/35/labels","id":3290834,"node_id":"MDk6TWlsZXN0b25lMzI5MDgzNA==","number":35,"title":"v0.75.0","description":"","creator":{"login":"conklin94122","id":12115653,"node_id":"MDQ6VXNlcjEyMTE1NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"open_issues":54,"closed_issues":37,"state":"open","created_at":"2018-04-23T19:27:18Z","updated_at":"2018-10-19T02:52:47Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2018-10-12T18:41:15Z","updated_at":"2018-10-19T14:29:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/14198","html_url":"https://github.com/highfidelity/hifi/pull/14198","diff_url":"https://github.com/highfidelity/hifi/pull/14198.diff","patch_url":"https://github.com/highfidelity/hifi/pull/14198.patch"},"body":"Add a dropdown to the entity list next to the search filter that includes type checkboxes for each type to filter.\r\n\r\nAdd an X to clear button to the search filter box.\r\n\r\nAdjust no entities found message.\r\n\r\nSmall styling issue still remains where I am unable to add spacing before the first and last items in the types dropdown to match the design.\r\n\r\nAddresses:\r\nhttps://highfidelity.manuscript.com/f/cases/19060/\r\nhttps://highfidelity.manuscript.com/f/cases/18325/\r\n\r\nDesign:\r\nhttps://www.figma.com/file/XlBbq7NNdCCLZt0zCojTac/Entity-List (filters in Version 3, with the exception that the radius filter has no camera icon, it's text is left-aligned, and the Search Radius label is still present)\r\n\r\nTest Plan:\r\n- Enter Interface in desktop mode\r\n- Open Create and view the entity list\r\n- Verify that an All Types dropdown box is visible to the left of the search filter box\r\n- Click the All Types to open the dropdown and verify that all types are checked, that the order is Shape, Model, Image, Light, Zone, Web, Material, ParticleEffect, Text, and each have a black checkbox and associated icon next to them matching the design above\r\n- Verify when unchecking each type that the dropdown text changes to \"Types...\", that those entity types are filtered out of the entity list, and that they are filtered back in when rechecking each type\r\n- Verify when unchecking all types that the dropdown text changes to \"No Types\" and that the no entities message  displays\r\n- Verify when clicking anywhere outside of the types dropdown on the Entity List window that the types dropdown closes\r\n- Verify the search filter box placeholder text is now \"Search\" instead of \"Filter\"\r\n- Resize the entity list window and verify the search filter box resizes it's width appropriately to maintain the same gaps between it and the types dropdown on the left and the filter in view button on the right\r\n- Enter different texts in the search filter box to verify it is filtering as expected and with each key stroke\r\n- Verify that once any text is entered in the search box that a circular X to clear button appears on the right side, and that clicking it clears the search filter and resets the displayed entities as expected\r\n- Verify the same no entities message \"There are no entities to display. Please check your filters or create an entity to begin.\" appears when the list is empty from a search filter that doesn't match any entities\r\n- Verify the radius filter box no longer has the step up/down buttons on the right side and instead now has the m unit on the right side\r\n- Verify the radius filter box numbers are now italic, that you can't type more than 9 characters and thus can't overlap the m unit, and that the entity results filter as expected as you type\r\n- Verify the same no entities message \"There are no entities to display. Please check your filters or create an entity to begin.\" appears when the list is empty from a radius of 0\r\n- Enter HMD and open Create to entity list\r\n- Verify the types dropdown, search filter box with X to clear button, and search radius look the same as desktop and perform as expected"},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/431382406","html_url":"https://github.com/highfidelity/hifi/pull/14198#issuecomment-431382406","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/14198","id":431382406,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTM4MjQwNg==","user":{"login":"QliCknox","id":39308687,"node_id":"MDQ6VXNlcjM5MzA4Njg3","avatar_url":"https://avatars0.githubusercontent.com/u/39308687?v=4","gravatar_id":"","url":"https://api.github.com/users/QliCknox","html_url":"https://github.com/QliCknox","followers_url":"https://api.github.com/users/QliCknox/followers","following_url":"https://api.github.com/users/QliCknox/following{/other_user}","gists_url":"https://api.github.com/users/QliCknox/gists{/gist_id}","starred_url":"https://api.github.com/users/QliCknox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QliCknox/subscriptions","organizations_url":"https://api.github.com/users/QliCknox/orgs","repos_url":"https://api.github.com/users/QliCknox/repos","events_url":"https://api.github.com/users/QliCknox/events{/privacy}","received_events_url":"https://api.github.com/users/QliCknox/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T14:29:12Z","updated_at":"2018-10-19T14:29:12Z","author_association":"NONE","body":"Currently Testing"}}
{"actor":{"display_login":"QliCknox"}}