{"action":"created","issue":{"url":"https://api.github.com/repos/ashtuchkin/iconv-lite/issues/182","repository_url":"https://api.github.com/repos/ashtuchkin/iconv-lite","labels_url":"https://api.github.com/repos/ashtuchkin/iconv-lite/issues/182/labels{/name}","comments_url":"https://api.github.com/repos/ashtuchkin/iconv-lite/issues/182/comments","events_url":"https://api.github.com/repos/ashtuchkin/iconv-lite/issues/182/events","html_url":"https://github.com/ashtuchkin/iconv-lite/pull/182","id":315697610,"number":182,"title":"Use older semver style for old Node.js 0.10 npm versions","user":{"login":"dougwilson","id":67512,"avatar_url":"https://avatars3.githubusercontent.com/u/67512?v=4","gravatar_id":"","url":"https://api.github.com/users/dougwilson","html_url":"https://github.com/dougwilson","followers_url":"https://api.github.com/users/dougwilson/followers","following_url":"https://api.github.com/users/dougwilson/following{/other_user}","gists_url":"https://api.github.com/users/dougwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/dougwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougwilson/subscriptions","organizations_url":"https://api.github.com/users/dougwilson/orgs","repos_url":"https://api.github.com/users/dougwilson/repos","events_url":"https://api.github.com/users/dougwilson/events{/privacy}","received_events_url":"https://api.github.com/users/dougwilson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-04-19T01:39:23Z","updated_at":"2018-05-05T21:26:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ashtuchkin/iconv-lite/pulls/182","html_url":"https://github.com/ashtuchkin/iconv-lite/pull/182","diff_url":"https://github.com/ashtuchkin/iconv-lite/pull/182.diff","patch_url":"https://github.com/ashtuchkin/iconv-lite/pull/182.patch"},"body":"So with the previous PR that added the `safer-buffer`, it used a semver range indicator `^`. I've been using this module in a Node.js 8 project, but we have a PaaS system from a vendor that is really annoying, in that it will automatically pull down the newest Node.js version we need (good), but will always run `npm install` with a built-in version of npm, which is an older version bundled originally with Node.js 0.10.11. This version of `npm` doesn't understand the `^` range. There are some really ugly work-arounds I can use, but I figured that since this module (currently) supports `\"node\": \">=0.10.0\"`, maybe others may encounter this issue, and so it would be neat to have a range that is compatible.\r\n\r\nThis PR pins the version, but there are other options, if you like another better:\r\n- `2.1.2` (current PR)\r\n- `~2.1.2` (floats the patch above `2`)\r\n- `>= 2.1.2 < 3` (more like the current `^2.1.2`)\r\n\r\nAlso if you don't want to do any of these, I understand, so you can close it."},"comment":{"url":"https://api.github.com/repos/ashtuchkin/iconv-lite/issues/comments/386836142","html_url":"https://github.com/ashtuchkin/iconv-lite/pull/182#issuecomment-386836142","issue_url":"https://api.github.com/repos/ashtuchkin/iconv-lite/issues/182","id":386836142,"user":{"login":"dougwilson","id":67512,"avatar_url":"https://avatars3.githubusercontent.com/u/67512?v=4","gravatar_id":"","url":"https://api.github.com/users/dougwilson","html_url":"https://github.com/dougwilson","followers_url":"https://api.github.com/users/dougwilson/followers","following_url":"https://api.github.com/users/dougwilson/following{/other_user}","gists_url":"https://api.github.com/users/dougwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/dougwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougwilson/subscriptions","organizations_url":"https://api.github.com/users/dougwilson/orgs","repos_url":"https://api.github.com/users/dougwilson/repos","events_url":"https://api.github.com/users/dougwilson/events{/privacy}","received_events_url":"https://api.github.com/users/dougwilson/received_events","type":"User","site_admin":false},"created_at":"2018-05-05T21:26:39Z","updated_at":"2018-05-05T21:26:39Z","author_association":"CONTRIBUTOR","body":"Yea, oops. Still trying to figure out how to get npm 1.2.4 to work (which is the default for 0.10.0). If I can't get it working, I'm probably going to just cut my losses here and just fork the module and move everything over to the fork, since I'll probably end up spending the same amount of time doing that 👍 "}}
{"actor":{"display_login":"dougwilson"}}