{"action":"created","issue":{"url":"https://api.github.com/repos/kubermatic/machine-controller/issues/278","repository_url":"https://api.github.com/repos/kubermatic/machine-controller","labels_url":"https://api.github.com/repos/kubermatic/machine-controller/issues/278/labels{/name}","comments_url":"https://api.github.com/repos/kubermatic/machine-controller/issues/278/comments","events_url":"https://api.github.com/repos/kubermatic/machine-controller/issues/278/events","html_url":"https://github.com/kubermatic/machine-controller/pull/278","id":342685403,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNTI1Njcw","number":278,"title":"use an instantiated prometheus registry instead of the global instance","user":{"login":"kdomanski","id":993296,"node_id":"MDQ6VXNlcjk5MzI5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/993296?v=4","gravatar_id":"","url":"https://api.github.com/users/kdomanski","html_url":"https://github.com/kdomanski","followers_url":"https://api.github.com/users/kdomanski/followers","following_url":"https://api.github.com/users/kdomanski/following{/other_user}","gists_url":"https://api.github.com/users/kdomanski/gists{/gist_id}","starred_url":"https://api.github.com/users/kdomanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdomanski/subscriptions","organizations_url":"https://api.github.com/users/kdomanski/orgs","repos_url":"https://api.github.com/users/kdomanski/repos","events_url":"https://api.github.com/users/kdomanski/events{/privacy}","received_events_url":"https://api.github.com/users/kdomanski/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"kdomanski","id":993296,"node_id":"MDQ6VXNlcjk5MzI5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/993296?v=4","gravatar_id":"","url":"https://api.github.com/users/kdomanski","html_url":"https://github.com/kdomanski","followers_url":"https://api.github.com/users/kdomanski/followers","following_url":"https://api.github.com/users/kdomanski/following{/other_user}","gists_url":"https://api.github.com/users/kdomanski/gists{/gist_id}","starred_url":"https://api.github.com/users/kdomanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdomanski/subscriptions","organizations_url":"https://api.github.com/users/kdomanski/orgs","repos_url":"https://api.github.com/users/kdomanski/repos","events_url":"https://api.github.com/users/kdomanski/events{/privacy}","received_events_url":"https://api.github.com/users/kdomanski/received_events","type":"User","site_admin":false},"assignees":[{"login":"kdomanski","id":993296,"node_id":"MDQ6VXNlcjk5MzI5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/993296?v=4","gravatar_id":"","url":"https://api.github.com/users/kdomanski","html_url":"https://github.com/kdomanski","followers_url":"https://api.github.com/users/kdomanski/followers","following_url":"https://api.github.com/users/kdomanski/following{/other_user}","gists_url":"https://api.github.com/users/kdomanski/gists{/gist_id}","starred_url":"https://api.github.com/users/kdomanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdomanski/subscriptions","organizations_url":"https://api.github.com/users/kdomanski/orgs","repos_url":"https://api.github.com/users/kdomanski/repos","events_url":"https://api.github.com/users/kdomanski/events{/privacy}","received_events_url":"https://api.github.com/users/kdomanski/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-07-19T11:15:18Z","updated_at":"2018-07-19T19:35:35Z","closed_at":"2018-07-19T11:32:05Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubermatic/machine-controller/pulls/278","html_url":"https://github.com/kubermatic/machine-controller/pull/278","diff_url":"https://github.com/kubermatic/machine-controller/pull/278.diff","patch_url":"https://github.com/kubermatic/machine-controller/pull/278.patch"},"body":"This allows creating multiple instance of machine controller, e.g. for testing."},"comment":{"url":"https://api.github.com/repos/kubermatic/machine-controller/issues/comments/406389851","html_url":"https://github.com/kubermatic/machine-controller/pull/278#issuecomment-406389851","issue_url":"https://api.github.com/repos/kubermatic/machine-controller/issues/278","id":406389851,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjM4OTg1MQ==","user":{"login":"kdomanski","id":993296,"node_id":"MDQ6VXNlcjk5MzI5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/993296?v=4","gravatar_id":"","url":"https://api.github.com/users/kdomanski","html_url":"https://github.com/kdomanski","followers_url":"https://api.github.com/users/kdomanski/followers","following_url":"https://api.github.com/users/kdomanski/following{/other_user}","gists_url":"https://api.github.com/users/kdomanski/gists{/gist_id}","starred_url":"https://api.github.com/users/kdomanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdomanski/subscriptions","organizations_url":"https://api.github.com/users/kdomanski/orgs","repos_url":"https://api.github.com/users/kdomanski/repos","events_url":"https://api.github.com/users/kdomanski/events{/privacy}","received_events_url":"https://api.github.com/users/kdomanski/received_events","type":"User","site_admin":false},"created_at":"2018-07-19T19:35:34Z","updated_at":"2018-07-19T19:35:34Z","author_association":"CONTRIBUTOR","body":"We need that for better unit tests with multiple test cases. There's more singleton-like behavior there, e.g. https://github.com/kubermatic/machine-controller/blob/fb97b80461354c14660e60c7b1c2abf33ac24851/pkg/controller/machine.go#L124 but we can deal with it as we run into more testing issues."}}
{"actor":{"display_login":"kdomanski"}}