{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/184908186","pull_request_review_id":116193000,"id":184908186,"diff_hunk":"@@ -143,6 +145,7 @@ def security_config(self):\n \n     def open_port(self, protocol):\n         self.port_mappings[protocol] = self.port_mappings[protocol]._replace(open=True)\n+        self.broker_ports.append(self.port_mappings[protocol].number)","path":"tests/kafkatest/services/kafka/kafka.py","position":20,"original_position":20,"commit_id":"c5d3e984fbe6a72aa409bede62926605965f7901","original_commit_id":"c5d3e984fbe6a72aa409bede62926605965f7901","user":{"login":"ewencp","id":47366,"avatar_url":"https://avatars3.githubusercontent.com/u/47366?v=4","gravatar_id":"","url":"https://api.github.com/users/ewencp","html_url":"https://github.com/ewencp","followers_url":"https://api.github.com/users/ewencp/followers","following_url":"https://api.github.com/users/ewencp/following{/other_user}","gists_url":"https://api.github.com/users/ewencp/gists{/gist_id}","starred_url":"https://api.github.com/users/ewencp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewencp/subscriptions","organizations_url":"https://api.github.com/users/ewencp/orgs","repos_url":"https://api.github.com/users/ewencp/repos","events_url":"https://api.github.com/users/ewencp/events{/privacy}","received_events_url":"https://api.github.com/users/ewencp/received_events","type":"User","site_admin":false},"body":"Is `open_port` guaranteed to be called once? If not, `broker_ports` should be a `set` instead of a `list`. Alternatively, it could be an accessor that gets the full *current* list from `port_mappings`.","created_at":"2018-04-30T03:40:09Z","updated_at":"2018-04-30T03:47:11Z","html_url":"https://github.com/apache/kafka/pull/4589#discussion_r184908186","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/4589","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/184908186"},"html":{"href":"https://github.com/apache/kafka/pull/4589#discussion_r184908186"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/4589"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/4589","id":169924761,"html_url":"https://github.com/apache/kafka/pull/4589","diff_url":"https://github.com/apache/kafka/pull/4589.diff","patch_url":"https://github.com/apache/kafka/pull/4589.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/4589","number":4589,"state":"open","locked":false,"title":"KAFKA-6332: Kafka system tests should use nc instead of log grep to d…","user":{"login":"asasvari","id":18190331,"avatar_url":"https://avatars0.githubusercontent.com/u/18190331?v=4","gravatar_id":"","url":"https://api.github.com/users/asasvari","html_url":"https://github.com/asasvari","followers_url":"https://api.github.com/users/asasvari/followers","following_url":"https://api.github.com/users/asasvari/following{/other_user}","gists_url":"https://api.github.com/users/asasvari/gists{/gist_id}","starred_url":"https://api.github.com/users/asasvari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asasvari/subscriptions","organizations_url":"https://api.github.com/users/asasvari/orgs","repos_url":"https://api.github.com/users/asasvari/repos","events_url":"https://api.github.com/users/asasvari/events{/privacy}","received_events_url":"https://api.github.com/users/asasvari/received_events","type":"User","site_admin":false},"body":"…etect start-up\r\n\r\n- Extracted a new function (listening) in system test utils module to test whether a specified port on a specified node is listening for connections.\r\n- Refactored system tests to use the new function to test whether a particular server is started / listening on a port (instead of grepping for lines in server logs). \r\n- Specified kdc.port for the MiniKdc server in minikdc.properties so that the server does not listen for connections on a \"random\" port.\r\n- Fixed a typo in the documentation of the node_is_reachable function in utils/util.py\r\n\r\nTesting done:\r\n- Executed the following system tests:\r\nsanity_checks tests,  simple_consumer_shell_test.py, consumer_group_command_test.py, trogdor_test.py, zookeeper_security_upgrade_test.py\r\n\r\n### Committer Checklist (excluded from commit message)\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation (including upgrade notes)\r\n","created_at":"2018-02-19T10:30:45Z","updated_at":"2018-04-30T03:47:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b85bc69a126b1c723bd1c18aa251024748ca390","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/4589/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/4589/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/4589/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/c5d3e984fbe6a72aa409bede62926605965f7901","head":{"label":"asasvari:KAFKA-6332","ref":"KAFKA-6332","sha":"c5d3e984fbe6a72aa409bede62926605965f7901","user":{"login":"asasvari","id":18190331,"avatar_url":"https://avatars0.githubusercontent.com/u/18190331?v=4","gravatar_id":"","url":"https://api.github.com/users/asasvari","html_url":"https://github.com/asasvari","followers_url":"https://api.github.com/users/asasvari/followers","following_url":"https://api.github.com/users/asasvari/following{/other_user}","gists_url":"https://api.github.com/users/asasvari/gists{/gist_id}","starred_url":"https://api.github.com/users/asasvari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asasvari/subscriptions","organizations_url":"https://api.github.com/users/asasvari/orgs","repos_url":"https://api.github.com/users/asasvari/repos","events_url":"https://api.github.com/users/asasvari/events{/privacy}","received_events_url":"https://api.github.com/users/asasvari/received_events","type":"User","site_admin":false},"repo":{"id":121440999,"name":"kafka","full_name":"asasvari/kafka","owner":{"login":"asasvari","id":18190331,"avatar_url":"https://avatars0.githubusercontent.com/u/18190331?v=4","gravatar_id":"","url":"https://api.github.com/users/asasvari","html_url":"https://github.com/asasvari","followers_url":"https://api.github.com/users/asasvari/followers","following_url":"https://api.github.com/users/asasvari/following{/other_user}","gists_url":"https://api.github.com/users/asasvari/gists{/gist_id}","starred_url":"https://api.github.com/users/asasvari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asasvari/subscriptions","organizations_url":"https://api.github.com/users/asasvari/orgs","repos_url":"https://api.github.com/users/asasvari/repos","events_url":"https://api.github.com/users/asasvari/events{/privacy}","received_events_url":"https://api.github.com/users/asasvari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asasvari/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/asasvari/kafka","forks_url":"https://api.github.com/repos/asasvari/kafka/forks","keys_url":"https://api.github.com/repos/asasvari/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asasvari/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asasvari/kafka/teams","hooks_url":"https://api.github.com/repos/asasvari/kafka/hooks","issue_events_url":"https://api.github.com/repos/asasvari/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/asasvari/kafka/events","assignees_url":"https://api.github.com/repos/asasvari/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/asasvari/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/asasvari/kafka/tags","blobs_url":"https://api.github.com/repos/asasvari/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asasvari/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asasvari/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/asasvari/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asasvari/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/asasvari/kafka/languages","stargazers_url":"https://api.github.com/repos/asasvari/kafka/stargazers","contributors_url":"https://api.github.com/repos/asasvari/kafka/contributors","subscribers_url":"https://api.github.com/repos/asasvari/kafka/subscribers","subscription_url":"https://api.github.com/repos/asasvari/kafka/subscription","commits_url":"https://api.github.com/repos/asasvari/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/asasvari/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/asasvari/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/asasvari/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/asasvari/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/asasvari/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asasvari/kafka/merges","archive_url":"https://api.github.com/repos/asasvari/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asasvari/kafka/downloads","issues_url":"https://api.github.com/repos/asasvari/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/asasvari/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/asasvari/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/asasvari/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asasvari/kafka/labels{/name}","releases_url":"https://api.github.com/repos/asasvari/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/asasvari/kafka/deployments","created_at":"2018-02-13T21:53:39Z","updated_at":"2018-03-19T12:25:45Z","pushed_at":"2018-04-03T12:13:11Z","git_url":"git://github.com/asasvari/kafka.git","ssh_url":"git@github.com:asasvari/kafka.git","clone_url":"https://github.com/asasvari/kafka.git","svn_url":"https://github.com/asasvari/kafka","homepage":null,"size":63655,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"604b93cfdee7a8c5c879ef2217d50be88e39ac89","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-04-29T18:01:09Z","pushed_at":"2018-04-29T22:26:49Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":64634,"stargazers_count":8132,"watchers_count":8132,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4784,"mirror_url":null,"archived":false,"open_issues_count":456,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4784,"open_issues":456,"watchers":8132,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/4589"},"html":{"href":"https://github.com/apache/kafka/pull/4589"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/4589"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/4589/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/4589/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/4589/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/c5d3e984fbe6a72aa409bede62926605965f7901"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ewencp"}}