{"action":"created","issue":{"url":"https://api.github.com/repos/semuxproject/semux/issues/730","repository_url":"https://api.github.com/repos/semuxproject/semux","labels_url":"https://api.github.com/repos/semuxproject/semux/issues/730/labels{/name}","comments_url":"https://api.github.com/repos/semuxproject/semux/issues/730/comments","events_url":"https://api.github.com/repos/semuxproject/semux/issues/730/events","html_url":"https://github.com/semuxproject/semux/pull/730","id":305270452,"number":730,"title":"API: add a configuration 'api.returnNumbersAsStrings'","user":{"login":"cryptokat","id":32390172,"avatar_url":"https://avatars1.githubusercontent.com/u/32390172?v=4","gravatar_id":"","url":"https://api.github.com/users/cryptokat","html_url":"https://github.com/cryptokat","followers_url":"https://api.github.com/users/cryptokat/followers","following_url":"https://api.github.com/users/cryptokat/following{/other_user}","gists_url":"https://api.github.com/users/cryptokat/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptokat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptokat/subscriptions","organizations_url":"https://api.github.com/users/cryptokat/orgs","repos_url":"https://api.github.com/users/cryptokat/repos","events_url":"https://api.github.com/users/cryptokat/events{/privacy}","received_events_url":"https://api.github.com/users/cryptokat/received_events","type":"User","site_admin":false},"labels":[{"id":821741089,"url":"https://api.github.com/repos/semuxproject/semux/labels/WIP","name":"WIP","color":"fbca04","default":false},{"id":659159308,"url":"https://api.github.com/repos/semuxproject/semux/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/semuxproject/semux/milestones/2","html_url":"https://github.com/semuxproject/semux/milestone/2","labels_url":"https://api.github.com/repos/semuxproject/semux/milestones/2/labels","id":3104883,"number":2,"title":"v1.0.2","description":"","creator":{"login":"semuxdev","id":35751971,"avatar_url":"https://avatars1.githubusercontent.com/u/35751971?v=4","gravatar_id":"","url":"https://api.github.com/users/semuxdev","html_url":"https://github.com/semuxdev","followers_url":"https://api.github.com/users/semuxdev/followers","following_url":"https://api.github.com/users/semuxdev/following{/other_user}","gists_url":"https://api.github.com/users/semuxdev/gists{/gist_id}","starred_url":"https://api.github.com/users/semuxdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/semuxdev/subscriptions","organizations_url":"https://api.github.com/users/semuxdev/orgs","repos_url":"https://api.github.com/users/semuxdev/repos","events_url":"https://api.github.com/users/semuxdev/events{/privacy}","received_events_url":"https://api.github.com/users/semuxdev/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":1,"state":"open","created_at":"2018-02-10T20:59:38Z","updated_at":"2018-03-14T18:06:15Z","due_on":"2018-04-15T07:00:00Z","closed_at":null},"comments":2,"created_at":"2018-03-14T18:06:14Z","updated_at":"2018-03-15T10:00:37Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/semuxproject/semux/pulls/730","html_url":"https://github.com/semuxproject/semux/pull/730","diff_url":"https://github.com/semuxproject/semux/pull/730.diff","patch_url":"https://github.com/semuxproject/semux/pull/730.patch"},"body":"To fix #729 \r\n\r\n### Common Changes\r\n\r\n- [x] A new configuration property `api.returnNumbersAsStrings=true|false` is added to define whether the API server should return numbers as strings by default.\r\n- [x] A new global GET parameter `returnNumbersAsStrings=true|false` is added for allowing API consumers to decide whether to get numbers as strings in runtime.\r\n- [ ] Introduce API version prefix in place of the configuration\r\n\r\n### Breaking Change on Fresh Installs\r\n\r\n`api.returnNumbersAsStrings` is enabled by default in `config/semux.properties` which may break existing API consumers.\r\n\r\n### Change on Legacy Installs\r\n\r\n`api.returnNumbersAsStrings` is disabled by default when the configuration is undefined in `config/semux.properties`, while a warning message that informs users about issue #729 will be shown in `debug.log` and console."},"comment":{"url":"https://api.github.com/repos/semuxproject/semux/issues/comments/373322407","html_url":"https://github.com/semuxproject/semux/pull/730#issuecomment-373322407","issue_url":"https://api.github.com/repos/semuxproject/semux/issues/730","id":373322407,"user":{"login":"cryptokat","id":32390172,"avatar_url":"https://avatars1.githubusercontent.com/u/32390172?v=4","gravatar_id":"","url":"https://api.github.com/users/cryptokat","html_url":"https://github.com/cryptokat","followers_url":"https://api.github.com/users/cryptokat/followers","following_url":"https://api.github.com/users/cryptokat/following{/other_user}","gists_url":"https://api.github.com/users/cryptokat/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptokat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptokat/subscriptions","organizations_url":"https://api.github.com/users/cryptokat/orgs","repos_url":"https://api.github.com/users/cryptokat/repos","events_url":"https://api.github.com/users/cryptokat/events{/privacy}","received_events_url":"https://api.github.com/users/cryptokat/received_events","type":"User","site_admin":false},"created_at":"2018-03-15T10:00:37Z","updated_at":"2018-03-15T10:00:37Z","author_association":"MEMBER","body":"Changed to WIP for introducing API versioning."}}
{"actor":{"display_login":"cryptokat"}}