{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/197986381","pull_request_review_id":131835124,"id":197986381,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzk4NjM4MQ==","diff_hunk":"@@ -28,33 +28,39 @@ endfunction(add_npm_command)\n \n if(WITH_MGR_DASHBOARD_FRONTEND AND NOT CMAKE_SYSTEM_PROCESSOR MATCHES \"aarch64|AARCH64|arm|ARM\")\n \n-set(mgr-dashboard-nodeenv ${CMAKE_CURRENT_BINARY_DIR}/node-env)\n+if(NOT WITH_SYSTEM_NPM)\n+  set(mgr-dashboard-node-env ${CMAKE_CURRENT_BINARY_DIR}/node-env)\n \n-add_custom_command(\n-  OUTPUT \"${mgr-dashboard-nodeenv}/bin/npm\"\n-  COMMAND ${CMAKE_SOURCE_DIR}/src/tools/setup-virtualenv.sh --python=${MGR_PYTHON_EXECUTABLE} ${mgr-dashboard-nodeenv}\n-  COMMAND ${mgr-dashboard-nodeenv}/bin/pip install nodeenv\n-  COMMAND ${mgr-dashboard-nodeenv}/bin/nodeenv -p -n 8.11.3\n-  WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}\n-  COMMENT \"dashboard nodeenv is being installed\"\n-)\n-add_custom_target(mgr-dashboard-nodeenv\n-  DEPENDS ${mgr-dashboard-nodeenv}/bin/npm\n-  WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}\n-)\n+  add_custom_command(\n+    OUTPUT \"${mgr-dashboard-node-env}/bin/npm\"\n+    COMMAND ${CMAKE_SOURCE_DIR}/src/tools/setup-virtualenv.sh --python=${MGR_PYTHON_EXECUTABLE} ${mgr-dashboard-node-env}\n+    COMMAND ${mgr-dashboard-node-env}/bin/pip install nodeenv\n+    COMMAND ${mgr-dashboard-node-env}/bin/nodeenv -p -n 8.11.3\n+    WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}\n+    COMMENT \"dashboard nodeenv is being installed\"\n+  )\n+  add_custom_target(mgr-dashboard-nodeenv\n+    DEPENDS ${mgr-dashboard-node-env}/bin/npm\n+    WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}\n+  )\n+  set(mgr-dashboard-nodeenv mgr-dashboard-nodeenv)\n+  set(nodeenv NODEENV)\n+else()\n+  set(mgr-dashboard-nodeenv )\n+  set(nodeenv \"\")\n+endif()\n \n+add_custom_target(mgr-dashboard-frontend-deps","path":"src/pybind/mgr/dashboard/CMakeLists.txt","position":39,"original_position":39,"commit_id":"f7eca85d572c9dfd0c2bf7625e5cff008f172742","original_commit_id":"f7eca85d572c9dfd0c2bf7625e5cff008f172742","user":{"login":"tchaikov","id":59071,"node_id":"MDQ6VXNlcjU5MDcx","avatar_url":"https://avatars2.githubusercontent.com/u/59071?v=4","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"why shall we move `add_custom_target(mgr-dashboard-frontend-deps ...)` up here?","created_at":"2018-06-26T01:04:09Z","updated_at":"2018-06-26T01:11:16Z","html_url":"https://github.com/ceph/ceph/pull/22562#discussion_r197986381","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/22562","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/197986381"},"html":{"href":"https://github.com/ceph/ceph/pull/22562#discussion_r197986381"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22562"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/22562","id":194892514,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0ODkyNTE0","html_url":"https://github.com/ceph/ceph/pull/22562","diff_url":"https://github.com/ceph/ceph/pull/22562.diff","patch_url":"https://github.com/ceph/ceph/pull/22562.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/22562","number":22562,"state":"open","locked":false,"title":"dashboard: Fix building under FreeBSD","user":{"login":"wjwithagen","id":16081914,"node_id":"MDQ6VXNlcjE2MDgxOTE0","avatar_url":"https://avatars0.githubusercontent.com/u/16081914?v=4","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"body":"The nodeenv version fetched is not working on FreeBSD. And further packaged\nfetched are not available. So install without going through nodeenv\n\nOn FreeBSD we will need to preinstall all the tools that are required for\nbuilding dashboard, because online downloading does not work during package\nbuilding. It is only allowed in the fetch-phase, so that will require an\nextra script. Which will be added in a future commit.\n\nSigned-off-by: Willem Jan Withagen <wjw@digiware.nl>","created_at":"2018-06-14T13:25:06Z","updated_at":"2018-06-26T01:11:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fda9427b7454c3800a15db99153222e05088261","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tspmelo","id":399326,"node_id":"MDQ6VXNlcjM5OTMyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/399326?v=4","gravatar_id":"","url":"https://api.github.com/users/tspmelo","html_url":"https://github.com/tspmelo","followers_url":"https://api.github.com/users/tspmelo/followers","following_url":"https://api.github.com/users/tspmelo/following{/other_user}","gists_url":"https://api.github.com/users/tspmelo/gists{/gist_id}","starred_url":"https://api.github.com/users/tspmelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tspmelo/subscriptions","organizations_url":"https://api.github.com/users/tspmelo/orgs","repos_url":"https://api.github.com/users/tspmelo/repos","events_url":"https://api.github.com/users/tspmelo/events{/privacy}","received_events_url":"https://api.github.com/users/tspmelo/received_events","type":"User","site_admin":false},{"login":"jcsp","id":944640,"node_id":"MDQ6VXNlcjk0NDY0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/944640?v=4","gravatar_id":"","url":"https://api.github.com/users/jcsp","html_url":"https://github.com/jcsp","followers_url":"https://api.github.com/users/jcsp/followers","following_url":"https://api.github.com/users/jcsp/following{/other_user}","gists_url":"https://api.github.com/users/jcsp/gists{/gist_id}","starred_url":"https://api.github.com/users/jcsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcsp/subscriptions","organizations_url":"https://api.github.com/users/jcsp/orgs","repos_url":"https://api.github.com/users/jcsp/repos","events_url":"https://api.github.com/users/jcsp/events{/privacy}","received_events_url":"https://api.github.com/users/jcsp/received_events","type":"User","site_admin":false},{"login":"rjfd","id":17119885,"node_id":"MDQ6VXNlcjE3MTE5ODg1","avatar_url":"https://avatars0.githubusercontent.com/u/17119885?v=4","gravatar_id":"","url":"https://api.github.com/users/rjfd","html_url":"https://github.com/rjfd","followers_url":"https://api.github.com/users/rjfd/followers","following_url":"https://api.github.com/users/rjfd/following{/other_user}","gists_url":"https://api.github.com/users/rjfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rjfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjfd/subscriptions","organizations_url":"https://api.github.com/users/rjfd/orgs","repos_url":"https://api.github.com/users/rjfd/repos","events_url":"https://api.github.com/users/rjfd/events{/privacy}","received_events_url":"https://api.github.com/users/rjfd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":199293022,"node_id":"MDU6TGFiZWwxOTkyOTMwMjI=","url":"https://api.github.com/repos/ceph/ceph/labels/build/ops","name":"build/ops","color":"fcff00","default":false},{"id":850326757,"node_id":"MDU6TGFiZWw4NTAzMjY3NTc=","url":"https://api.github.com/repos/ceph/ceph/labels/dashboard","name":"dashboard","color":"68a2c1","default":false},{"id":454906768,"node_id":"MDU6TGFiZWw0NTQ5MDY3Njg=","url":"https://api.github.com/repos/ceph/ceph/labels/mgr","name":"mgr","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/22562/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/22562/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/22562/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/f7eca85d572c9dfd0c2bf7625e5cff008f172742","head":{"label":"wjwithagen:wjw-fix-dashboard-build","ref":"wjw-fix-dashboard-build","sha":"f7eca85d572c9dfd0c2bf7625e5cff008f172742","user":{"login":"wjwithagen","id":16081914,"node_id":"MDQ6VXNlcjE2MDgxOTE0","avatar_url":"https://avatars0.githubusercontent.com/u/16081914?v=4","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"repo":{"id":50789401,"node_id":"MDEwOlJlcG9zaXRvcnk1MDc4OTQwMQ==","name":"ceph","full_name":"wjwithagen/ceph","owner":{"login":"wjwithagen","id":16081914,"node_id":"MDQ6VXNlcjE2MDgxOTE0","avatar_url":"https://avatars0.githubusercontent.com/u/16081914?v=4","gravatar_id":"","url":"https://api.github.com/users/wjwithagen","html_url":"https://github.com/wjwithagen","followers_url":"https://api.github.com/users/wjwithagen/followers","following_url":"https://api.github.com/users/wjwithagen/following{/other_user}","gists_url":"https://api.github.com/users/wjwithagen/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwithagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwithagen/subscriptions","organizations_url":"https://api.github.com/users/wjwithagen/orgs","repos_url":"https://api.github.com/users/wjwithagen/repos","events_url":"https://api.github.com/users/wjwithagen/events{/privacy}","received_events_url":"https://api.github.com/users/wjwithagen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wjwithagen/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/wjwithagen/ceph","forks_url":"https://api.github.com/repos/wjwithagen/ceph/forks","keys_url":"https://api.github.com/repos/wjwithagen/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wjwithagen/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wjwithagen/ceph/teams","hooks_url":"https://api.github.com/repos/wjwithagen/ceph/hooks","issue_events_url":"https://api.github.com/repos/wjwithagen/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/wjwithagen/ceph/events","assignees_url":"https://api.github.com/repos/wjwithagen/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/wjwithagen/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/wjwithagen/ceph/tags","blobs_url":"https://api.github.com/repos/wjwithagen/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wjwithagen/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wjwithagen/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/wjwithagen/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wjwithagen/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/wjwithagen/ceph/languages","stargazers_url":"https://api.github.com/repos/wjwithagen/ceph/stargazers","contributors_url":"https://api.github.com/repos/wjwithagen/ceph/contributors","subscribers_url":"https://api.github.com/repos/wjwithagen/ceph/subscribers","subscription_url":"https://api.github.com/repos/wjwithagen/ceph/subscription","commits_url":"https://api.github.com/repos/wjwithagen/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/wjwithagen/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/wjwithagen/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/wjwithagen/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/wjwithagen/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/wjwithagen/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wjwithagen/ceph/merges","archive_url":"https://api.github.com/repos/wjwithagen/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wjwithagen/ceph/downloads","issues_url":"https://api.github.com/repos/wjwithagen/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/wjwithagen/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/wjwithagen/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/wjwithagen/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wjwithagen/ceph/labels{/name}","releases_url":"https://api.github.com/repos/wjwithagen/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/wjwithagen/ceph/deployments","created_at":"2016-01-31T18:48:17Z","updated_at":"2018-06-25T22:57:25Z","pushed_at":"2018-06-26T00:45:55Z","git_url":"git://github.com/wjwithagen/ceph.git","ssh_url":"git@github.com:wjwithagen/ceph.git","clone_url":"https://github.com/wjwithagen/ceph.git","svn_url":"https://github.com/wjwithagen/ceph","homepage":"http://ceph.com","size":279290,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"9829f56c075f851ff6a6869ba0f9661210c589aa","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-06-25T22:50:57Z","pushed_at":"2018-06-26T01:02:40Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":292660,"stargazers_count":4657,"watchers_count":4657,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2497,"mirror_url":null,"archived":false,"open_issues_count":661,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2497,"open_issues":661,"watchers":4657,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22562"},"html":{"href":"https://github.com/ceph/ceph/pull/22562"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/22562"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/22562/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22562/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22562/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/f7eca85d572c9dfd0c2bf7625e5cff008f172742"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tchaikov"}}