{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/foreman/issues/6307","repository_url":"https://api.github.com/repos/theforeman/foreman","labels_url":"https://api.github.com/repos/theforeman/foreman/issues/6307/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/6307/comments","events_url":"https://api.github.com/repos/theforeman/foreman/issues/6307/events","html_url":"https://github.com/theforeman/foreman/pull/6307","id":387703872,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MTMxNzA3","number":6307,"title":"Fixes #25629: Fix changing disc size","user":{"login":"leewaa","id":5164431,"node_id":"MDQ6VXNlcjUxNjQ0MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/5164431?v=4","gravatar_id":"","url":"https://api.github.com/users/leewaa","html_url":"https://github.com/leewaa","followers_url":"https://api.github.com/users/leewaa/followers","following_url":"https://api.github.com/users/leewaa/following{/other_user}","gists_url":"https://api.github.com/users/leewaa/gists{/gist_id}","starred_url":"https://api.github.com/users/leewaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leewaa/subscriptions","organizations_url":"https://api.github.com/users/leewaa/orgs","repos_url":"https://api.github.com/users/leewaa/repos","events_url":"https://api.github.com/users/leewaa/events{/privacy}","received_events_url":"https://api.github.com/users/leewaa/received_events","type":"User","site_admin":false},"labels":[{"id":79040689,"node_id":"MDU6TGFiZWw3OTA0MDY4OQ==","url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-05T11:02:26Z","updated_at":"2018-12-21T08:55:08Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/6307","html_url":"https://github.com/theforeman/foreman/pull/6307","diff_url":"https://github.com/theforeman/foreman/pull/6307.diff","patch_url":"https://github.com/theforeman/foreman/pull/6307.patch"},"body":"Problem here was the type check for `volume_attrs` against `Hash` when its actually a `HashWithIndifferentAccess`. I made this more solid with `vm_volume.size_gb = volume_attrs[:size_gb] if volume_attrs[:size_gb].present?`. After testing this seems to be fine. We need to implement some happy path feature tests then things like this would be caught much earlier.\r\n"},"comment":{"url":"https://api.github.com/repos/theforeman/foreman/issues/comments/449317323","html_url":"https://github.com/theforeman/foreman/pull/6307#issuecomment-449317323","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/6307","id":449317323,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTMxNzMyMw==","user":{"login":"timogoebel","id":4107560,"node_id":"MDQ6VXNlcjQxMDc1NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4107560?v=4","gravatar_id":"","url":"https://api.github.com/users/timogoebel","html_url":"https://github.com/timogoebel","followers_url":"https://api.github.com/users/timogoebel/followers","following_url":"https://api.github.com/users/timogoebel/following{/other_user}","gists_url":"https://api.github.com/users/timogoebel/gists{/gist_id}","starred_url":"https://api.github.com/users/timogoebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timogoebel/subscriptions","organizations_url":"https://api.github.com/users/timogoebel/orgs","repos_url":"https://api.github.com/users/timogoebel/repos","events_url":"https://api.github.com/users/timogoebel/events{/privacy}","received_events_url":"https://api.github.com/users/timogoebel/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T08:55:08Z","updated_at":"2018-12-21T08:55:08Z","author_association":"MEMBER","body":"@chris1984: That would be awesome."}}
{"actor":{"display_login":"timogoebel"}}