{"action":"closed","number":4201,"pull_request":{"url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/4201","id":218937168,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4OTM3MTY4","html_url":"https://github.com/ReactiveX/rxjs/pull/4201","diff_url":"https://github.com/ReactiveX/rxjs/pull/4201.diff","patch_url":"https://github.com/ReactiveX/rxjs/pull/4201.patch","issue_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/4201","number":4201,"state":"closed","locked":false,"title":"build(docs_app): upgrade to latest SW and other fixes","user":{"login":"gkalpak","id":8604205,"node_id":"MDQ6VXNlcjg2MDQyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8604205?v=4","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"body":"**Description:**\r\nIncludes the following changes to the docs app:\r\n\r\n1. Remove unused files/scripts (that were unnecessarily copied over from angular.io).\r\n\r\n2. Upgrade `@angular/service-worker` to 6.1.9.\r\n    This essentially includes the (relevant) commits from angular/angular#25997 (plus a couple minor ones).\r\n    The current `ngsw-config.json` seems reasonable, but you might want to tweak it.\r\n\r\n3. Remove unused images (mainly to avoid fetching them from the SW and unnecessarily consuming bandwidth).\r\n\r\n4. Replace Angular images and headline with RxJS ones:\r\n    **a.** In the 404 page:\r\n        _Before:_\r\n        ![rxjs-404-before](https://user-images.githubusercontent.com/8604205/46205596-e81b9f80-c329-11e8-9785-307de11c123c.png)\r\n        _After:_\r\n        ![rxjs-404-after](https://user-images.githubusercontent.com/8604205/46205613-f964ac00-c329-11e8-9bb3-f1e95e5b5e36.png)\r\n        **NOTE:**\r\n        I hacked together an RxJS sad logo (similar to the Angular one), but you probably want to provide your own.\r\n        (Still, it is better than showing the Angular logo :grin:)\r\n    **b.** In the \"no JavaScript\" page (shown when JavaScript is disabled):\r\n        _Before:_\r\n        ![rxjs-nojs-before](https://user-images.githubusercontent.com/8604205/46205707-5c564300-c32a-11e8-8333-316eabf8fa6a.png)\r\n        _After:_\r\n        ![rxjs-nojs-after](https://user-images.githubusercontent.com/8604205/46205701-55c7cb80-c32a-11e8-85f6-6c2738ae7234.png)\r\n\r\n\r\n\r\n\r\n**Related issue (if exists):**\r\nFixes #4178.\r\n","created_at":"2018-09-28T11:25:53Z","updated_at":"2018-09-28T15:18:11Z","closed_at":"2018-09-28T15:18:11Z","merged_at":"2018-09-28T15:18:11Z","merge_commit_sha":"d2f7083baada8edf0696969aad7390e46ac99235","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/4201/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/4201/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/4201/comments","statuses_url":"https://api.github.com/repos/ReactiveX/rxjs/statuses/88e88b05bc168cea4c3e9d72d7b4241197d35289","head":{"label":"gkalpak:docs-app-update-sw","ref":"docs-app-update-sw","sha":"88e88b05bc168cea4c3e9d72d7b4241197d35289","user":{"login":"gkalpak","id":8604205,"node_id":"MDQ6VXNlcjg2MDQyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8604205?v=4","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"repo":{"id":79099833,"node_id":"MDEwOlJlcG9zaXRvcnk3OTA5OTgzMw==","name":"rxjs","full_name":"gkalpak/rxjs","private":false,"owner":{"login":"gkalpak","id":8604205,"node_id":"MDQ6VXNlcjg2MDQyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8604205?v=4","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gkalpak/rxjs","description":"A reactive programming library for JavaScript","fork":true,"url":"https://api.github.com/repos/gkalpak/rxjs","forks_url":"https://api.github.com/repos/gkalpak/rxjs/forks","keys_url":"https://api.github.com/repos/gkalpak/rxjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gkalpak/rxjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gkalpak/rxjs/teams","hooks_url":"https://api.github.com/repos/gkalpak/rxjs/hooks","issue_events_url":"https://api.github.com/repos/gkalpak/rxjs/issues/events{/number}","events_url":"https://api.github.com/repos/gkalpak/rxjs/events","assignees_url":"https://api.github.com/repos/gkalpak/rxjs/assignees{/user}","branches_url":"https://api.github.com/repos/gkalpak/rxjs/branches{/branch}","tags_url":"https://api.github.com/repos/gkalpak/rxjs/tags","blobs_url":"https://api.github.com/repos/gkalpak/rxjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gkalpak/rxjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gkalpak/rxjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gkalpak/rxjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gkalpak/rxjs/statuses/{sha}","languages_url":"https://api.github.com/repos/gkalpak/rxjs/languages","stargazers_url":"https://api.github.com/repos/gkalpak/rxjs/stargazers","contributors_url":"https://api.github.com/repos/gkalpak/rxjs/contributors","subscribers_url":"https://api.github.com/repos/gkalpak/rxjs/subscribers","subscription_url":"https://api.github.com/repos/gkalpak/rxjs/subscription","commits_url":"https://api.github.com/repos/gkalpak/rxjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gkalpak/rxjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gkalpak/rxjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gkalpak/rxjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gkalpak/rxjs/contents/{+path}","compare_url":"https://api.github.com/repos/gkalpak/rxjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gkalpak/rxjs/merges","archive_url":"https://api.github.com/repos/gkalpak/rxjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gkalpak/rxjs/downloads","issues_url":"https://api.github.com/repos/gkalpak/rxjs/issues{/number}","pulls_url":"https://api.github.com/repos/gkalpak/rxjs/pulls{/number}","milestones_url":"https://api.github.com/repos/gkalpak/rxjs/milestones{/number}","notifications_url":"https://api.github.com/repos/gkalpak/rxjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gkalpak/rxjs/labels{/name}","releases_url":"https://api.github.com/repos/gkalpak/rxjs/releases{/id}","deployments_url":"https://api.github.com/repos/gkalpak/rxjs/deployments","created_at":"2017-01-16T08:52:47Z","updated_at":"2018-09-28T08:08:25Z","pushed_at":"2018-09-28T11:17:11Z","git_url":"git://github.com/gkalpak/rxjs.git","ssh_url":"git@github.com:gkalpak/rxjs.git","clone_url":"https://github.com/gkalpak/rxjs.git","svn_url":"https://github.com/gkalpak/rxjs","homepage":"http://reactivex.io/rxjs","size":80844,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveX:master","ref":"master","sha":"6a2b524bc62cb1039123ecc45c7ccc65358d9eb1","user":{"login":"ReactiveX","id":6407041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MDcwNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6407041?v=4","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":32247847,"node_id":"MDEwOlJlcG9zaXRvcnkzMjI0Nzg0Nw==","name":"rxjs","full_name":"ReactiveX/rxjs","private":false,"owner":{"login":"ReactiveX","id":6407041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MDcwNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/6407041?v=4","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ReactiveX/rxjs","description":"A reactive programming library for JavaScript","fork":false,"url":"https://api.github.com/repos/ReactiveX/rxjs","forks_url":"https://api.github.com/repos/ReactiveX/rxjs/forks","keys_url":"https://api.github.com/repos/ReactiveX/rxjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/rxjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/rxjs/teams","hooks_url":"https://api.github.com/repos/ReactiveX/rxjs/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/rxjs/events","assignees_url":"https://api.github.com/repos/ReactiveX/rxjs/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/rxjs/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/rxjs/tags","blobs_url":"https://api.github.com/repos/ReactiveX/rxjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/rxjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/rxjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/rxjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/rxjs/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/rxjs/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/rxjs/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/rxjs/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/rxjs/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/rxjs/subscription","commits_url":"https://api.github.com/repos/ReactiveX/rxjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/rxjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/rxjs/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/rxjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/rxjs/merges","archive_url":"https://api.github.com/repos/ReactiveX/rxjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/rxjs/downloads","issues_url":"https://api.github.com/repos/ReactiveX/rxjs/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/rxjs/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/rxjs/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/rxjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/rxjs/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/rxjs/releases{/id}","deployments_url":"https://api.github.com/repos/ReactiveX/rxjs/deployments","created_at":"2015-03-15T06:17:10Z","updated_at":"2018-09-28T15:15:00Z","pushed_at":"2018-09-28T15:18:11Z","git_url":"git://github.com/ReactiveX/rxjs.git","ssh_url":"git@github.com:ReactiveX/rxjs.git","clone_url":"https://github.com/ReactiveX/rxjs.git","svn_url":"https://github.com/ReactiveX/rxjs","homepage":"http://reactivex.io/rxjs","size":101617,"stargazers_count":15010,"watchers_count":15010,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1493,"mirror_url":null,"archived":false,"open_issues_count":240,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1493,"open_issues":240,"watchers":15010,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/4201"},"html":{"href":"https://github.com/ReactiveX/rxjs/pull/4201"},"issue":{"href":"https://api.github.com/repos/ReactiveX/rxjs/issues/4201"},"comments":{"href":"https://api.github.com/repos/ReactiveX/rxjs/issues/4201/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/4201/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/rxjs/pulls/4201/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/rxjs/statuses/88e88b05bc168cea4c3e9d72d7b4241197d35289"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"benlesh","id":1540597,"node_id":"MDQ6VXNlcjE1NDA1OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1540597?v=4","gravatar_id":"","url":"https://api.github.com/users/benlesh","html_url":"https://github.com/benlesh","followers_url":"https://api.github.com/users/benlesh/followers","following_url":"https://api.github.com/users/benlesh/following{/other_user}","gists_url":"https://api.github.com/users/benlesh/gists{/gist_id}","starred_url":"https://api.github.com/users/benlesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlesh/subscriptions","organizations_url":"https://api.github.com/users/benlesh/orgs","repos_url":"https://api.github.com/users/benlesh/repos","events_url":"https://api.github.com/users/benlesh/events{/privacy}","received_events_url":"https://api.github.com/users/benlesh/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":4021,"deletions":25704,"changed_files":242}}
{"actor":{"display_login":"benlesh"}}