{"action":"created","issue":{"url":"https://api.github.com/repos/coredns/coredns/issues/2037","repository_url":"https://api.github.com/repos/coredns/coredns","labels_url":"https://api.github.com/repos/coredns/coredns/issues/2037/labels{/name}","comments_url":"https://api.github.com/repos/coredns/coredns/issues/2037/comments","events_url":"https://api.github.com/repos/coredns/coredns/issues/2037/events","html_url":"https://github.com/coredns/coredns/pull/2037","id":351896873,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzU2Mzkw","number":2037,"title":"plugin/forward: Add comment about external dependency","user":{"login":"ekleiner","id":19671699,"node_id":"MDQ6VXNlcjE5NjcxNjk5","avatar_url":"https://avatars1.githubusercontent.com/u/19671699?v=4","gravatar_id":"","url":"https://api.github.com/users/ekleiner","html_url":"https://github.com/ekleiner","followers_url":"https://api.github.com/users/ekleiner/followers","following_url":"https://api.github.com/users/ekleiner/following{/other_user}","gists_url":"https://api.github.com/users/ekleiner/gists{/gist_id}","starred_url":"https://api.github.com/users/ekleiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekleiner/subscriptions","organizations_url":"https://api.github.com/users/ekleiner/orgs","repos_url":"https://api.github.com/users/ekleiner/repos","events_url":"https://api.github.com/users/ekleiner/events{/privacy}","received_events_url":"https://api.github.com/users/ekleiner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-19T11:52:36Z","updated_at":"2018-08-19T11:58:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/coredns/coredns/pulls/2037","html_url":"https://github.com/coredns/coredns/pull/2037","diff_url":"https://github.com/coredns/coredns/pull/2037.diff","patch_url":"https://github.com/coredns/coredns/pull/2037.patch"},"body":"<!--\r\nThank you for contributing to CoreDNS!\r\nPlease provide the following information to help us make the most of your pull request:\r\n-->\r\n\r\n### 1. Why is this pull request needed and what does it do?\r\nAdd comment about external dependency separated setup function not to be refactored in future.\r\nNo code changes.\r\n### 2. Which issues (if any) are related?\r\nhttps://github.com/coredns/fallback/issues/9\r\n### 3. Which documentation changes (if any) need to be made?\r\n"},"comment":{"url":"https://api.github.com/repos/coredns/coredns/issues/comments/414122972","html_url":"https://github.com/coredns/coredns/pull/2037#issuecomment-414122972","issue_url":"https://api.github.com/repos/coredns/coredns/issues/2037","id":414122972,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDEyMjk3Mg==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-08-19T11:58:30Z","updated_at":"2018-08-19T11:58:30Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/coredns/coredns/pull/2037?src=pr&el=h1) Report\n> Merging [#2037](https://codecov.io/gh/coredns/coredns/pull/2037?src=pr&el=desc) into [master](https://codecov.io/gh/coredns/coredns/commit/b87ed01bb24e2c82b931b022dadeb4da3869c782?src=pr&el=desc) will **decrease** coverage by `0.02%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/coredns/coredns/pull/2037/graphs/tree.svg?src=pr&token=Ji3zZaIzpC&width=650&height=150)](https://codecov.io/gh/coredns/coredns/pull/2037?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #2037      +/-   ##\n==========================================\n- Coverage      55%   54.98%   -0.03%     \n==========================================\n  Files         200      200              \n  Lines        9734     9734              \n==========================================\n- Hits         5354     5352       -2     \n- Misses       3970     3972       +2     \n  Partials      410      410\n```\n\n\n| [Impacted Files](https://codecov.io/gh/coredns/coredns/pull/2037?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [plugin/forward/setup.go](https://codecov.io/gh/coredns/coredns/pull/2037/diff?src=pr&el=tree#diff-cGx1Z2luL2ZvcndhcmQvc2V0dXAuZ28=) | `58.82% <ø> (ø)` | :arrow_up: |\n| [plugin/file/reload.go](https://codecov.io/gh/coredns/coredns/pull/2037/diff?src=pr&el=tree#diff-cGx1Z2luL2ZpbGUvcmVsb2FkLmdv) | `68.57% <0%> (-5.72%)` | :arrow_down: |\n| [plugin/forward/connect.go](https://codecov.io/gh/coredns/coredns/pull/2037/diff?src=pr&el=tree#diff-cGx1Z2luL2ZvcndhcmQvY29ubmVjdC5nbw==) | `82.43% <0%> (-4.06%)` | :arrow_down: |\n| [plugin/forward/persistent.go](https://codecov.io/gh/coredns/coredns/pull/2037/diff?src=pr&el=tree#diff-cGx1Z2luL2ZvcndhcmQvcGVyc2lzdGVudC5nbw==) | `98.59% <0%> (+2.81%)` | :arrow_up: |\n| [plugin/forward/proxy.go](https://codecov.io/gh/coredns/coredns/pull/2037/diff?src=pr&el=tree#diff-cGx1Z2luL2ZvcndhcmQvcHJveHkuZ28=) | `100% <0%> (+3.57%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/coredns/coredns/pull/2037?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/coredns/coredns/pull/2037?src=pr&el=footer). Last update [b87ed01...e48c1cc](https://codecov.io/gh/coredns/coredns/pull/2037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}