{"action":"created","issue":{"url":"https://api.github.com/repos/curl/curl/issues/2189","repository_url":"https://api.github.com/repos/curl/curl","labels_url":"https://api.github.com/repos/curl/curl/issues/2189/labels{/name}","comments_url":"https://api.github.com/repos/curl/curl/issues/2189/comments","events_url":"https://api.github.com/repos/curl/curl/issues/2189/events","html_url":"https://github.com/curl/curl/pull/2189","id":284259874,"number":2189,"title":"build-openssl.bat: Refer to VS2017 as VC14.1 instead of VC15","user":{"login":"jay","id":965580,"avatar_url":"https://avatars1.githubusercontent.com/u/965580?v=4","gravatar_id":"","url":"https://api.github.com/users/jay","html_url":"https://github.com/jay","followers_url":"https://api.github.com/users/jay/followers","following_url":"https://api.github.com/users/jay/following{/other_user}","gists_url":"https://api.github.com/users/jay/gists{/gist_id}","starred_url":"https://api.github.com/users/jay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jay/subscriptions","organizations_url":"https://api.github.com/users/jay/orgs","repos_url":"https://api.github.com/users/jay/repos","events_url":"https://api.github.com/users/jay/events{/privacy}","received_events_url":"https://api.github.com/users/jay/received_events","type":"User","site_admin":false},"labels":[{"id":184118182,"url":"https://api.github.com/repos/curl/curl/labels/build","name":"build","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-12-22T22:05:13Z","updated_at":"2018-02-10T00:14:27Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/curl/curl/pulls/2189","html_url":"https://github.com/curl/curl/pull/2189","diff_url":"https://github.com/curl/curl/pull/2189.diff","patch_url":"https://github.com/curl/curl/pull/2189.patch"},"body":".. and do the same for build-wolfssl.bat.\r\n\r\n- Refer to VS2017 as VC14.1 instead of VC15.\r\n\r\n- Support Enterprise and Professional variants.\r\n\r\nCloses #xxxx\r\n\r\n---\r\n\r\nAnother WIP. @captain-caveman2k as far as I can tell VS2017 is referred to as VC14.1 not VC15. I had some related confusion about this last year and I asked on the MS forums whether it's 14.10 or 14.1 and [they said 14.1](https://social.technet.microsoft.com/Forums/en-US/98c25d63-c345-4ac1-a522-9c6e93183250/does-visual-studio-2017-come-with-visual-c-141-or-1410?forum=visualstudiogeneral).\r\n\r\nRegarding Enterprise/Professional I haven't tested them yet but I assume they are the same. Basically I added an autodetect so the build script could find the version in order of preference Enterprise -> Professional -> Community\r\n\r\nAlso there is a Microsoft tool [vswhere](https://github.com/Microsoft/vswhere/wiki) for more precise Visual Studio location for 2010+."},"comment":{"url":"https://api.github.com/repos/curl/curl/issues/comments/364605926","html_url":"https://github.com/curl/curl/pull/2189#issuecomment-364605926","issue_url":"https://api.github.com/repos/curl/curl/issues/2189","id":364605926,"user":{"login":"captain-caveman2k","id":1523871,"avatar_url":"https://avatars1.githubusercontent.com/u/1523871?v=4","gravatar_id":"","url":"https://api.github.com/users/captain-caveman2k","html_url":"https://github.com/captain-caveman2k","followers_url":"https://api.github.com/users/captain-caveman2k/followers","following_url":"https://api.github.com/users/captain-caveman2k/following{/other_user}","gists_url":"https://api.github.com/users/captain-caveman2k/gists{/gist_id}","starred_url":"https://api.github.com/users/captain-caveman2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/captain-caveman2k/subscriptions","organizations_url":"https://api.github.com/users/captain-caveman2k/orgs","repos_url":"https://api.github.com/users/captain-caveman2k/repos","events_url":"https://api.github.com/users/captain-caveman2k/events{/privacy}","received_events_url":"https://api.github.com/users/captain-caveman2k/received_events","type":"User","site_admin":false},"created_at":"2018-02-10T00:14:27Z","updated_at":"2018-02-10T00:14:27Z","author_association":"OWNER","body":"> The remaining issue is calling it VC14.1 instead of VC15\r\n\r\nI believe 14.1 is the version of the compiler and also the toolchain.\r\n\r\nThe VC in VC15 is kind of short for Visual C++ from the days before Visual Studio. Visual Studio 2017 itself is version 15.\r\n\r\nIf memory serves me correctly it was known as Dev15 during development and VS \"15\" during beta - the latest non-preview release is 15.5.6 which I'm running.\r\n"}}
{"actor":{"display_login":"captain-caveman2k"}}