{"action":"created","issue":{"url":"https://api.github.com/repos/ArkEcosystem/cpp-crypto/issues/36","repository_url":"https://api.github.com/repos/ArkEcosystem/cpp-crypto","labels_url":"https://api.github.com/repos/ArkEcosystem/cpp-crypto/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/ArkEcosystem/cpp-crypto/issues/36/comments","events_url":"https://api.github.com/repos/ArkEcosystem/cpp-crypto/issues/36/events","html_url":"https://github.com/ArkEcosystem/cpp-crypto/pull/36","id":391104754,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NzE2NDc3","number":36,"title":"refactor: cmake_example/main.cpp","user":{"login":"kalgoop","id":17824093,"node_id":"MDQ6VXNlcjE3ODI0MDkz","avatar_url":"https://avatars0.githubusercontent.com/u/17824093?v=4","gravatar_id":"","url":"https://api.github.com/users/kalgoop","html_url":"https://github.com/kalgoop","followers_url":"https://api.github.com/users/kalgoop/followers","following_url":"https://api.github.com/users/kalgoop/following{/other_user}","gists_url":"https://api.github.com/users/kalgoop/gists{/gist_id}","starred_url":"https://api.github.com/users/kalgoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalgoop/subscriptions","organizations_url":"https://api.github.com/users/kalgoop/orgs","repos_url":"https://api.github.com/users/kalgoop/repos","events_url":"https://api.github.com/users/kalgoop/events{/privacy}","received_events_url":"https://api.github.com/users/kalgoop/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-14T13:09:05Z","updated_at":"2018-12-14T13:17:15Z","closed_at":"2018-12-14T13:12:40Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ArkEcosystem/cpp-crypto/pulls/36","html_url":"https://github.com/ArkEcosystem/cpp-crypto/pull/36","diff_url":"https://github.com/ArkEcosystem/cpp-crypto/pull/36.diff","patch_url":"https://github.com/ArkEcosystem/cpp-crypto/pull/36.patch"},"body":"\r\n## Proposed changes\r\n<!--\r\nDescribe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.\r\n-->\r\ninstead of using std::cout << every time, we can 'use std::cout' for cout.\r\n'using namespace std' is sometimes refered as dangerous due to conflicts that may arise in function names.\r\n\r\n\r\n## Types of changes\r\n<!--\r\nWhat types of changes does your code introduce?\r\n_Put an `x` in the boxes that apply and remove the rest of them: keep this PR as concise, but descriptive, as possible.._\r\n-->\r\n\r\n- [x] Refactoring (improve a current implementation without adding a new feature or fixing a bug)\r\n\r\n\r\n## Checklist\r\n<!--\r\n_Put an `x` in the boxes that apply and remove this text and the rest of them. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._\r\n-->\r\n\r\n- [x] I have read the [CONTRIBUTING](https://docs.ark.io/guidebook/contribution-guidelines/contributing.html) documentation\r\n- [x] Lint and unit tests pass locally with my changes\r\n\r\n## Further comments\r\n<!--\r\nIf this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/ArkEcosystem/cpp-crypto/issues/comments/447322510","html_url":"https://github.com/ArkEcosystem/cpp-crypto/pull/36#issuecomment-447322510","issue_url":"https://api.github.com/repos/ArkEcosystem/cpp-crypto/issues/36","id":447322510,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzMyMjUxMA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-12-14T13:17:15Z","updated_at":"2018-12-14T13:17:15Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/ArkEcosystem/cpp-crypto/pull/36?src=pr&el=h1) Report\n> Merging [#36](https://codecov.io/gh/ArkEcosystem/cpp-crypto/pull/36?src=pr&el=desc) into [master](https://codecov.io/gh/ArkEcosystem/cpp-crypto/commit/b0cc3aad88d0900014c134e0adbb5e6c4d353d7b?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/ArkEcosystem/cpp-crypto/pull/36/graphs/tree.svg?width=650&token=6S8W0bcufU&height=150&src=pr)](https://codecov.io/gh/ArkEcosystem/cpp-crypto/pull/36?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##           master      #36   +/-   ##\n=======================================\n  Coverage   64.16%   64.16%           \n=======================================\n  Files          41       41           \n  Lines        2799     2799           \n=======================================\n  Hits         1796     1796           \n  Misses       1003     1003\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/ArkEcosystem/cpp-crypto/pull/36?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/ArkEcosystem/cpp-crypto/pull/36?src=pr&el=footer). Last update [b0cc3aa...d769424](https://codecov.io/gh/ArkEcosystem/cpp-crypto/pull/36?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}