{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/200127119","pull_request_review_id":134380917,"id":200127119,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDEyNzExOQ==","diff_hunk":"@@ -47,14 +47,8 @@ public function onInit($id = 'dynamic_recaptcha_1')\n \n \t\tif ($this->params->get('version', '1.0') === '1.0')\n \t\t{\n-\t\t\tJHtml::_('jquery.framework');\n-\n-\t\t\t$theme\t= $this->params->get('theme', 'clean');\n-\t\t\t$file\t= 'https://www.google.com/recaptcha/api/js/recaptcha_ajax.js';\n-\n-\t\t\tJHtml::_('script', $file);\n-\t\t\tJFactory::getDocument()->addScriptDeclaration('jQuery( document ).ready(function()\n-\t\t\t\t{Recaptcha.create(\"' . $pubkey . '\", \"' . $id . '\", {theme: \"' . $theme . '\",' . $this->_getLanguage() . 'tabindex: 0});});');\n+            // Deprecated - @see https://developers.google.com/recaptcha/docs/faq#what-happens-to-recaptcha-v1","path":"plugins/captcha/recaptcha/recaptcha.php","position":12,"original_position":12,"commit_id":"9d9526c9461afd1b6942bbf026a9b3ee05aac732","original_commit_id":"9d9526c9461afd1b6942bbf026a9b3ee05aac732","user":{"login":"PhilETaylor","id":400092,"node_id":"MDQ6VXNlcjQwMDA5Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/400092?v=4","gravatar_id":"","url":"https://api.github.com/users/PhilETaylor","html_url":"https://github.com/PhilETaylor","followers_url":"https://api.github.com/users/PhilETaylor/followers","following_url":"https://api.github.com/users/PhilETaylor/following{/other_user}","gists_url":"https://api.github.com/users/PhilETaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilETaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilETaylor/subscriptions","organizations_url":"https://api.github.com/users/PhilETaylor/orgs","repos_url":"https://api.github.com/users/PhilETaylor/repos","events_url":"https://api.github.com/users/PhilETaylor/events{/privacy}","received_events_url":"https://api.github.com/users/PhilETaylor/received_events","type":"User","site_admin":false},"body":"phpStorm is starting to annoy me. It clearly states at the top of the file it was using tabs for indentation :( ","created_at":"2018-07-04T13:29:40Z","updated_at":"2018-07-04T13:29:40Z","html_url":"https://github.com/joomla/joomla-cms/pull/20965#discussion_r200127119","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20965","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/200127119"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/20965#discussion_r200127119"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/20965"}},"in_reply_to_id":199983873},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20965","id":199003313,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDAzMzEz","html_url":"https://github.com/joomla/joomla-cms/pull/20965","diff_url":"https://github.com/joomla/joomla-cms/pull/20965.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/20965.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20965","number":20965,"state":"open","locked":false,"title":"Allow form submission if Google Captcha v1 is enabled","user":{"login":"PhilETaylor","id":400092,"node_id":"MDQ6VXNlcjQwMDA5Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/400092?v=4","gravatar_id":"","url":"https://api.github.com/users/PhilETaylor","html_url":"https://github.com/PhilETaylor","followers_url":"https://api.github.com/users/PhilETaylor/followers","following_url":"https://api.github.com/users/PhilETaylor/following{/other_user}","gists_url":"https://api.github.com/users/PhilETaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilETaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilETaylor/subscriptions","organizations_url":"https://api.github.com/users/PhilETaylor/orgs","repos_url":"https://api.github.com/users/PhilETaylor/repos","events_url":"https://api.github.com/users/PhilETaylor/events{/privacy}","received_events_url":"https://api.github.com/users/PhilETaylor/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue #20960 .\r\n\r\n### Summary of Changes\r\n\r\nallow form submission if Google Recaptcha v1 enabled \r\n\r\n**Will allow spamming of forms configured with v1 captcha where those forms are relying on the (broken/discontinued) API,** but will now also provide backward compatibility allowing of real users to submit the form.\r\n\r\nWill remove the JS warnings in Console.\r\n\r\n### Testing Instructions\r\n\r\nConfigure Google recaptcha v1 with a fake key\r\n\r\n### Expected result\r\n\r\nYou can still submit forms - proving b/c works and the absence of a working google api is not blocking form submissions\r\n","created_at":"2018-07-03T15:31:46Z","updated_at":"2018-07-04T13:29:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0db9ea02496731f4b2a33e6ee1c02766774d570","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":60721348,"node_id":"MDU6TGFiZWw2MDcyMTM0OA==","url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20965/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20965/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20965/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/9d9526c9461afd1b6942bbf026a9b3ee05aac732","head":{"label":"PhilETaylor:googlecaptchav1","ref":"googlecaptchav1","sha":"9d9526c9461afd1b6942bbf026a9b3ee05aac732","user":{"login":"PhilETaylor","id":400092,"node_id":"MDQ6VXNlcjQwMDA5Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/400092?v=4","gravatar_id":"","url":"https://api.github.com/users/PhilETaylor","html_url":"https://github.com/PhilETaylor","followers_url":"https://api.github.com/users/PhilETaylor/followers","following_url":"https://api.github.com/users/PhilETaylor/following{/other_user}","gists_url":"https://api.github.com/users/PhilETaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilETaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilETaylor/subscriptions","organizations_url":"https://api.github.com/users/PhilETaylor/orgs","repos_url":"https://api.github.com/users/PhilETaylor/repos","events_url":"https://api.github.com/users/PhilETaylor/events{/privacy}","received_events_url":"https://api.github.com/users/PhilETaylor/received_events","type":"User","site_admin":false},"repo":{"id":82957793,"node_id":"MDEwOlJlcG9zaXRvcnk4Mjk1Nzc5Mw==","name":"joomla-cms","full_name":"PhilETaylor/joomla-cms","owner":{"login":"PhilETaylor","id":400092,"node_id":"MDQ6VXNlcjQwMDA5Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/400092?v=4","gravatar_id":"","url":"https://api.github.com/users/PhilETaylor","html_url":"https://github.com/PhilETaylor","followers_url":"https://api.github.com/users/PhilETaylor/followers","following_url":"https://api.github.com/users/PhilETaylor/following{/other_user}","gists_url":"https://api.github.com/users/PhilETaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilETaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilETaylor/subscriptions","organizations_url":"https://api.github.com/users/PhilETaylor/orgs","repos_url":"https://api.github.com/users/PhilETaylor/repos","events_url":"https://api.github.com/users/PhilETaylor/events{/privacy}","received_events_url":"https://api.github.com/users/PhilETaylor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PhilETaylor/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/PhilETaylor/joomla-cms","forks_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/forks","keys_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/teams","hooks_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/events","assignees_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/tags","blobs_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/subscription","commits_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/merges","archive_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/downloads","issues_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/PhilETaylor/joomla-cms/deployments","created_at":"2017-02-23T18:22:12Z","updated_at":"2017-02-23T18:22:30Z","pushed_at":"2018-07-03T15:21:23Z","git_url":"git://github.com/PhilETaylor/joomla-cms.git","ssh_url":"git@github.com:PhilETaylor/joomla-cms.git","clone_url":"https://github.com/PhilETaylor/joomla-cms.git","svn_url":"https://github.com/PhilETaylor/joomla-cms","homepage":"https://www.joomla.org","size":235588,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"899e7c93ba4c56558ab0a58a69281260b8b4af06","user":{"login":"joomla","id":751633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MTYzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"node_id":"MDEwOlJlcG9zaXRvcnkyNDY0OTA4","name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MTYzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2018-07-03T15:52:42Z","pushed_at":"2018-07-04T12:50:27Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":236995,"stargazers_count":2786,"watchers_count":2786,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2701,"mirror_url":null,"archived":false,"open_issues_count":832,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":2701,"open_issues":832,"watchers":2786,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/20965"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/20965"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/20965"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/20965/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/20965/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/20965/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/9d9526c9461afd1b6942bbf026a9b3ee05aac732"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"PhilETaylor"}}