{"action":"created","comment":{"url":"https://api.github.com/repos/status-im/status-react/pulls/comments/203308457","pull_request_review_id":138169172,"id":203308457,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzMwODQ1Nw==","diff_hunk":"@@ -62,11 +59,10 @@\n \n ;; same as re-frame dispatch-later but using background timer for long\n ;; running timeouts\n-(re-frame/reg-fx\n- :utils/dispatch-later\n- (fn [params]\n-   (doseq [{:keys [ms dispatch]} params]\n-     (set-timeout #(re-frame/dispatch dispatch) ms))))\n+(re-frame/reg-fx :utils/dispatch-later\n+                 (fn [params]","path":"src/status_im/utils/utils.cljs","position":70,"original_position":70,"commit_id":"728d93ff4504a7db95448e15628e86647480bd60","original_commit_id":"728d93ff4504a7db95448e15628e86647480bd60","user":{"login":"kennytilton","id":240190,"node_id":"MDQ6VXNlcjI0MDE5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/240190?v=4","gravatar_id":"","url":"https://api.github.com/users/kennytilton","html_url":"https://github.com/kennytilton","followers_url":"https://api.github.com/users/kennytilton/followers","following_url":"https://api.github.com/users/kennytilton/following{/other_user}","gists_url":"https://api.github.com/users/kennytilton/gists{/gist_id}","starred_url":"https://api.github.com/users/kennytilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennytilton/subscriptions","organizations_url":"https://api.github.com/users/kennytilton/orgs","repos_url":"https://api.github.com/users/kennytilton/repos","events_url":"https://api.github.com/users/kennytilton/events{/privacy}","received_events_url":"https://api.github.com/users/kennytilton/received_events","type":"User","site_admin":false},"body":"Let me look into this. I will use `nano` or `sublime` and repeat the exercise. I edit with IntelliJ/Cursive and frequently use the \"reformat all option\" during development, maybe I did that unconsciously even during my sanity check.","created_at":"2018-07-18T09:20:48Z","updated_at":"2018-07-18T09:20:48Z","html_url":"https://github.com/status-im/status-react/pull/5206#discussion_r203308457","pull_request_url":"https://api.github.com/repos/status-im/status-react/pulls/5206","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/status-im/status-react/pulls/comments/203308457"},"html":{"href":"https://github.com/status-im/status-react/pull/5206#discussion_r203308457"},"pull_request":{"href":"https://api.github.com/repos/status-im/status-react/pulls/5206"}},"in_reply_to_id":203296382},"pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/5206","id":201987314,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxOTg3MzE0","html_url":"https://github.com/status-im/status-react/pull/5206","diff_url":"https://github.com/status-im/status-react/pull/5206.diff","patch_url":"https://github.com/status-im/status-react/pull/5206.patch","issue_url":"https://api.github.com/repos/status-im/status-react/issues/5206","number":5206,"state":"open","locked":false,"title":"[FIX #3604] ui, screens, home, subs: Deduplicate chat list of browses","user":{"login":"kennytilton","id":240190,"node_id":"MDQ6VXNlcjI0MDE5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/240190?v=4","gravatar_id":"","url":"https://api.github.com/users/kennytilton","html_url":"https://github.com/kennytilton","followers_url":"https://api.github.com/users/kennytilton/followers","following_url":"https://api.github.com/users/kennytilton/following{/other_user}","gists_url":"https://api.github.com/users/kennytilton/gists{/gist_id}","starred_url":"https://api.github.com/users/kennytilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennytilton/subscriptions","organizations_url":"https://api.github.com/users/kennytilton/orgs","repos_url":"https://api.github.com/users/kennytilton/repos","events_url":"https://api.github.com/users/kennytilton/events{/privacy}","received_events_url":"https://api.github.com/users/kennytilton/received_events","type":"User","site_admin":false},"body":"Fixes #3604 \"Multiple chat elements for one browsed URL\"\r\n\r\nTo reduce clutter in the chat list we de-duplicate browser elements where the URLs are the same, keeping the most recent.\r\n\r\nstatus: ready\r\n","created_at":"2018-07-17T15:47:36Z","updated_at":"2018-07-18T09:20:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"412a523bb83188057c33d612046a19713785fbd0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"janherich","id":1910609,"node_id":"MDQ6VXNlcjE5MTA2MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1910609?v=4","gravatar_id":"","url":"https://api.github.com/users/janherich","html_url":"https://github.com/janherich","followers_url":"https://api.github.com/users/janherich/followers","following_url":"https://api.github.com/users/janherich/following{/other_user}","gists_url":"https://api.github.com/users/janherich/gists{/gist_id}","starred_url":"https://api.github.com/users/janherich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janherich/subscriptions","organizations_url":"https://api.github.com/users/janherich/orgs","repos_url":"https://api.github.com/users/janherich/repos","events_url":"https://api.github.com/users/janherich/events{/privacy}","received_events_url":"https://api.github.com/users/janherich/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/status-react/pulls/5206/commits","review_comments_url":"https://api.github.com/repos/status-im/status-react/pulls/5206/comments","review_comment_url":"https://api.github.com/repos/status-im/status-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/5206/comments","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/728d93ff4504a7db95448e15628e86647480bd60","head":{"label":"kennytilton:fix/3604-deduplicate-browsers-in-chat-list","ref":"fix/3604-deduplicate-browsers-in-chat-list","sha":"728d93ff4504a7db95448e15628e86647480bd60","user":{"login":"kennytilton","id":240190,"node_id":"MDQ6VXNlcjI0MDE5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/240190?v=4","gravatar_id":"","url":"https://api.github.com/users/kennytilton","html_url":"https://github.com/kennytilton","followers_url":"https://api.github.com/users/kennytilton/followers","following_url":"https://api.github.com/users/kennytilton/following{/other_user}","gists_url":"https://api.github.com/users/kennytilton/gists{/gist_id}","starred_url":"https://api.github.com/users/kennytilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennytilton/subscriptions","organizations_url":"https://api.github.com/users/kennytilton/orgs","repos_url":"https://api.github.com/users/kennytilton/repos","events_url":"https://api.github.com/users/kennytilton/events{/privacy}","received_events_url":"https://api.github.com/users/kennytilton/received_events","type":"User","site_admin":false},"repo":{"id":140037623,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwMzc2MjM=","name":"status-react","full_name":"kennytilton/status-react","owner":{"login":"kennytilton","id":240190,"node_id":"MDQ6VXNlcjI0MDE5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/240190?v=4","gravatar_id":"","url":"https://api.github.com/users/kennytilton","html_url":"https://github.com/kennytilton","followers_url":"https://api.github.com/users/kennytilton/followers","following_url":"https://api.github.com/users/kennytilton/following{/other_user}","gists_url":"https://api.github.com/users/kennytilton/gists{/gist_id}","starred_url":"https://api.github.com/users/kennytilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennytilton/subscriptions","organizations_url":"https://api.github.com/users/kennytilton/orgs","repos_url":"https://api.github.com/users/kennytilton/repos","events_url":"https://api.github.com/users/kennytilton/events{/privacy}","received_events_url":"https://api.github.com/users/kennytilton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kennytilton/status-react","description":"a free (libre) open source, mobile OS for Ethereum","fork":true,"url":"https://api.github.com/repos/kennytilton/status-react","forks_url":"https://api.github.com/repos/kennytilton/status-react/forks","keys_url":"https://api.github.com/repos/kennytilton/status-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kennytilton/status-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kennytilton/status-react/teams","hooks_url":"https://api.github.com/repos/kennytilton/status-react/hooks","issue_events_url":"https://api.github.com/repos/kennytilton/status-react/issues/events{/number}","events_url":"https://api.github.com/repos/kennytilton/status-react/events","assignees_url":"https://api.github.com/repos/kennytilton/status-react/assignees{/user}","branches_url":"https://api.github.com/repos/kennytilton/status-react/branches{/branch}","tags_url":"https://api.github.com/repos/kennytilton/status-react/tags","blobs_url":"https://api.github.com/repos/kennytilton/status-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kennytilton/status-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kennytilton/status-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/kennytilton/status-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kennytilton/status-react/statuses/{sha}","languages_url":"https://api.github.com/repos/kennytilton/status-react/languages","stargazers_url":"https://api.github.com/repos/kennytilton/status-react/stargazers","contributors_url":"https://api.github.com/repos/kennytilton/status-react/contributors","subscribers_url":"https://api.github.com/repos/kennytilton/status-react/subscribers","subscription_url":"https://api.github.com/repos/kennytilton/status-react/subscription","commits_url":"https://api.github.com/repos/kennytilton/status-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/kennytilton/status-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/kennytilton/status-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/kennytilton/status-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/kennytilton/status-react/contents/{+path}","compare_url":"https://api.github.com/repos/kennytilton/status-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kennytilton/status-react/merges","archive_url":"https://api.github.com/repos/kennytilton/status-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kennytilton/status-react/downloads","issues_url":"https://api.github.com/repos/kennytilton/status-react/issues{/number}","pulls_url":"https://api.github.com/repos/kennytilton/status-react/pulls{/number}","milestones_url":"https://api.github.com/repos/kennytilton/status-react/milestones{/number}","notifications_url":"https://api.github.com/repos/kennytilton/status-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kennytilton/status-react/labels{/name}","releases_url":"https://api.github.com/repos/kennytilton/status-react/releases{/id}","deployments_url":"https://api.github.com/repos/kennytilton/status-react/deployments","created_at":"2018-07-06T23:20:13Z","updated_at":"2018-07-06T23:20:17Z","pushed_at":"2018-07-17T15:38:16Z","git_url":"git://github.com/kennytilton/status-react.git","ssh_url":"git@github.com:kennytilton/status-react.git","clone_url":"https://github.com/kennytilton/status-react.git","svn_url":"https://github.com/kennytilton/status-react","homepage":"https://status.im","size":59354,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"status-im:develop","ref":"develop","sha":"3ada73af896bbdcda4304c733643f3bfdb8ae007","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":52308441,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMwODQ0MQ==","name":"status-react","full_name":"status-im/status-react","owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-react","description":"a free (libre) open source, mobile OS for Ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-react","forks_url":"https://api.github.com/repos/status-im/status-react/forks","keys_url":"https://api.github.com/repos/status-im/status-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-react/teams","hooks_url":"https://api.github.com/repos/status-im/status-react/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-react/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-react/events","assignees_url":"https://api.github.com/repos/status-im/status-react/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-react/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-react/tags","blobs_url":"https://api.github.com/repos/status-im/status-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-react/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-react/languages","stargazers_url":"https://api.github.com/repos/status-im/status-react/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-react/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-react/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-react/subscription","commits_url":"https://api.github.com/repos/status-im/status-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-react/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-react/merges","archive_url":"https://api.github.com/repos/status-im/status-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-react/downloads","issues_url":"https://api.github.com/repos/status-im/status-react/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-react/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-react/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-react/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-react/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-react/deployments","created_at":"2016-02-22T21:48:48Z","updated_at":"2018-07-18T04:00:31Z","pushed_at":"2018-07-18T09:18:54Z","git_url":"git://github.com/status-im/status-react.git","ssh_url":"git@github.com:status-im/status-react.git","clone_url":"https://github.com/status-im/status-react.git","svn_url":"https://github.com/status-im/status-react","homepage":"https://status.im","size":59631,"stargazers_count":2314,"watchers_count":2314,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":569,"mirror_url":null,"archived":false,"open_issues_count":682,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":569,"open_issues":682,"watchers":2314,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-react/pulls/5206"},"html":{"href":"https://github.com/status-im/status-react/pull/5206"},"issue":{"href":"https://api.github.com/repos/status-im/status-react/issues/5206"},"comments":{"href":"https://api.github.com/repos/status-im/status-react/issues/5206/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-react/pulls/5206/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-react/pulls/5206/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-react/statuses/728d93ff4504a7db95448e15628e86647480bd60"}},"author_association":"NONE"}}
{"actor":{"display_login":"kennytilton"}}