{"action":"created","issue":{"url":"https://api.github.com/repos/nlohmann/json/issues/1153","repository_url":"https://api.github.com/repos/nlohmann/json","labels_url":"https://api.github.com/repos/nlohmann/json/issues/1153/labels{/name}","comments_url":"https://api.github.com/repos/nlohmann/json/issues/1153/comments","events_url":"https://api.github.com/repos/nlohmann/json/issues/1153/events","html_url":"https://github.com/nlohmann/json/pull/1153","id":337885688,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4OTUyOTAy","number":1153,"title":"Refactor/no virtual sax","user":{"login":"theodelrieu","id":15652306,"node_id":"MDQ6VXNlcjE1NjUyMzA2","avatar_url":"https://avatars1.githubusercontent.com/u/15652306?v=4","gravatar_id":"","url":"https://api.github.com/users/theodelrieu","html_url":"https://github.com/theodelrieu","followers_url":"https://api.github.com/users/theodelrieu/followers","following_url":"https://api.github.com/users/theodelrieu/following{/other_user}","gists_url":"https://api.github.com/users/theodelrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/theodelrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theodelrieu/subscriptions","organizations_url":"https://api.github.com/users/theodelrieu/orgs","repos_url":"https://api.github.com/users/theodelrieu/repos","events_url":"https://api.github.com/users/theodelrieu/events{/privacy}","received_events_url":"https://api.github.com/users/theodelrieu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-03T12:52:05Z","updated_at":"2018-07-04T06:16:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nlohmann/json/pulls/1153","html_url":"https://github.com/nlohmann/json/pull/1153","diff_url":"https://github.com/nlohmann/json/pull/1153.diff","patch_url":"https://github.com/nlohmann/json/pull/1153.patch"},"body":"This PR is a WIP, to show a different API for SAX-related functions.\r\n\r\nI'd like to have other people running benchmarks, my results are not that significant, even after removing every optimization flag. There is a 40ms improvement on `jeopardy.json` from time to time though.\r\n\r\nFew minor improvements that could be done:\r\n\r\n* Passing by reference instead of pointers?.\r\n* I removed the `no_limit` value, I used `std::size_t(-1)` instead.\r\n\r\nAs you can see, the public interface stays the same, there is no `static_assert` on the SAX interface for now. If we decide to go this route, I'll add detailed and useful ones (unlike those that exist today).\r\n\r\n* * *\r\n\r\n## Pull request checklist\r\n\r\nRead the [Contribution Guidelines](https://github.com/nlohmann/json/blob/develop/.github/CONTRIBUTING.md) for detailed information.\r\n\r\n- [ ]  Changes are described in the pull request, or an [existing issue is referenced](https://github.com/nlohmann/json/issues).\r\n- [ ]  The test suite [compiles and runs](https://github.com/nlohmann/json/blob/develop/README.md#execute-unit-tests) without error.\r\n- [ ]  [Code coverage](https://coveralls.io/github/nlohmann/json) is 100%. Test cases can be added by editing the [test suite](https://github.com/nlohmann/json/tree/develop/test/src).\r\n- [ ]  The source code is amalgamated; that is, after making changes to the sources in the `include/nlohmann` directory, run `make amalgamate` to create the single-header file `single_include/nlohmann/json.hpp`. The whole process is described [here](https://github.com/nlohmann/json/blob/develop/.github/CONTRIBUTING.md#files-to-change)."},"comment":{"url":"https://api.github.com/repos/nlohmann/json/issues/comments/402374597","html_url":"https://github.com/nlohmann/json/pull/1153#issuecomment-402374597","issue_url":"https://api.github.com/repos/nlohmann/json/issues/1153","id":402374597,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjM3NDU5Nw==","user":{"login":"maddanio","id":366903,"node_id":"MDQ6VXNlcjM2NjkwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/366903?v=4","gravatar_id":"","url":"https://api.github.com/users/maddanio","html_url":"https://github.com/maddanio","followers_url":"https://api.github.com/users/maddanio/followers","following_url":"https://api.github.com/users/maddanio/following{/other_user}","gists_url":"https://api.github.com/users/maddanio/gists{/gist_id}","starred_url":"https://api.github.com/users/maddanio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maddanio/subscriptions","organizations_url":"https://api.github.com/users/maddanio/orgs","repos_url":"https://api.github.com/users/maddanio/repos","events_url":"https://api.github.com/users/maddanio/events{/privacy}","received_events_url":"https://api.github.com/users/maddanio/received_events","type":"User","site_admin":false},"created_at":"2018-07-04T06:16:06Z","updated_at":"2018-07-04T06:16:06Z","author_association":"NONE","body":"ah, funny, i was just wondering about this yesterday, why it has to be virtual :)."}}
{"actor":{"display_login":"maddanio"}}