{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaIO/MAT.jl/pulls/comments/223045377","pull_request_review_id":162084360,"id":223045377,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzA0NTM3Nw==","diff_hunk":"@@ -290,12 +284,12 @@ elseif length(s) > 63\n end\n \n toarray(x::Array) = x\n-toarray(x::Array{Bool}) = reinterpret(UInt8, x)\n+toarray(x::Array{Bool}) = reinterpret.(UInt8, x)","path":"src/MAT_HDF5.jl","position":94,"original_position":92,"commit_id":"a1e7ae622f5d22f71c7253a87c3cb76b96cc0345","original_commit_id":"c60910b46a1b2ebb3137e3fdd9b3314138581732","user":{"login":"yuyichao","id":712232,"node_id":"MDQ6VXNlcjcxMjIzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/712232?v=4","gravatar_id":"","url":"https://api.github.com/users/yuyichao","html_url":"https://github.com/yuyichao","followers_url":"https://api.github.com/users/yuyichao/followers","following_url":"https://api.github.com/users/yuyichao/following{/other_user}","gists_url":"https://api.github.com/users/yuyichao/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyichao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyichao/subscriptions","organizations_url":"https://api.github.com/users/yuyichao/orgs","repos_url":"https://api.github.com/users/yuyichao/repos","events_url":"https://api.github.com/users/yuyichao/events{/privacy}","received_events_url":"https://api.github.com/users/yuyichao/received_events","type":"User","site_admin":false},"body":"No that s copying","created_at":"2018-10-05T15:21:11Z","updated_at":"2018-10-05T15:21:12Z","html_url":"https://github.com/JuliaIO/MAT.jl/pull/86#discussion_r223045377","pull_request_url":"https://api.github.com/repos/JuliaIO/MAT.jl/pulls/86","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/JuliaIO/MAT.jl/pulls/comments/223045377"},"html":{"href":"https://github.com/JuliaIO/MAT.jl/pull/86#discussion_r223045377"},"pull_request":{"href":"https://api.github.com/repos/JuliaIO/MAT.jl/pulls/86"}},"in_reply_to_id":219182028},"pull_request":{"url":"https://api.github.com/repos/JuliaIO/MAT.jl/pulls/86","id":204928045,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0OTI4MDQ1","html_url":"https://github.com/JuliaIO/MAT.jl/pull/86","diff_url":"https://github.com/JuliaIO/MAT.jl/pull/86.diff","patch_url":"https://github.com/JuliaIO/MAT.jl/pull/86.patch","issue_url":"https://api.github.com/repos/JuliaIO/MAT.jl/issues/86","number":86,"state":"open","locked":false,"title":"Resolve deprecation warnings for v0.7","user":{"login":"halleysfifthinc","id":7356205,"node_id":"MDQ6VXNlcjczNTYyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/7356205?v=4","gravatar_id":"","url":"https://api.github.com/users/halleysfifthinc","html_url":"https://github.com/halleysfifthinc","followers_url":"https://api.github.com/users/halleysfifthinc/followers","following_url":"https://api.github.com/users/halleysfifthinc/following{/other_user}","gists_url":"https://api.github.com/users/halleysfifthinc/gists{/gist_id}","starred_url":"https://api.github.com/users/halleysfifthinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halleysfifthinc/subscriptions","organizations_url":"https://api.github.com/users/halleysfifthinc/orgs","repos_url":"https://api.github.com/users/halleysfifthinc/repos","events_url":"https://api.github.com/users/halleysfifthinc/events{/privacy}","received_events_url":"https://api.github.com/users/halleysfifthinc/received_events","type":"User","site_admin":false},"body":"According to the testsuite, this fixes all the deprecations.\n\nThe only things I'm unsure of is the change in v0.7 for reinterpret/reshape to return `reinterpret`/`reshape` types. Since the tests check type equality (and error if mismatched type) before checking for equality in the contents, this required me to add a `collect` (for most of the cases) around the reinterpret or reshape. This will now allocate when it did not before, and may affect the read/write performance, however I don't see a way around this (other than changing the types of the test data to make the tests pass with reinterpret/reshape types).","created_at":"2018-07-30T20:58:32Z","updated_at":"2018-10-05T15:21:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2889fbc9f46083171cd14d26b0b8747c26aa817e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaIO/MAT.jl/pulls/86/commits","review_comments_url":"https://api.github.com/repos/JuliaIO/MAT.jl/pulls/86/comments","review_comment_url":"https://api.github.com/repos/JuliaIO/MAT.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaIO/MAT.jl/issues/86/comments","statuses_url":"https://api.github.com/repos/JuliaIO/MAT.jl/statuses/a1e7ae622f5d22f71c7253a87c3cb76b96cc0345","head":{"label":"halleysfifthinc:v0.7-update","ref":"v0.7-update","sha":"a1e7ae622f5d22f71c7253a87c3cb76b96cc0345","user":{"login":"halleysfifthinc","id":7356205,"node_id":"MDQ6VXNlcjczNTYyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/7356205?v=4","gravatar_id":"","url":"https://api.github.com/users/halleysfifthinc","html_url":"https://github.com/halleysfifthinc","followers_url":"https://api.github.com/users/halleysfifthinc/followers","following_url":"https://api.github.com/users/halleysfifthinc/following{/other_user}","gists_url":"https://api.github.com/users/halleysfifthinc/gists{/gist_id}","starred_url":"https://api.github.com/users/halleysfifthinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halleysfifthinc/subscriptions","organizations_url":"https://api.github.com/users/halleysfifthinc/orgs","repos_url":"https://api.github.com/users/halleysfifthinc/repos","events_url":"https://api.github.com/users/halleysfifthinc/events{/privacy}","received_events_url":"https://api.github.com/users/halleysfifthinc/received_events","type":"User","site_admin":false},"repo":{"id":142926988,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI5MjY5ODg=","name":"MAT.jl","full_name":"halleysfifthinc/MAT.jl","private":false,"owner":{"login":"halleysfifthinc","id":7356205,"node_id":"MDQ6VXNlcjczNTYyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/7356205?v=4","gravatar_id":"","url":"https://api.github.com/users/halleysfifthinc","html_url":"https://github.com/halleysfifthinc","followers_url":"https://api.github.com/users/halleysfifthinc/followers","following_url":"https://api.github.com/users/halleysfifthinc/following{/other_user}","gists_url":"https://api.github.com/users/halleysfifthinc/gists{/gist_id}","starred_url":"https://api.github.com/users/halleysfifthinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halleysfifthinc/subscriptions","organizations_url":"https://api.github.com/users/halleysfifthinc/orgs","repos_url":"https://api.github.com/users/halleysfifthinc/repos","events_url":"https://api.github.com/users/halleysfifthinc/events{/privacy}","received_events_url":"https://api.github.com/users/halleysfifthinc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/halleysfifthinc/MAT.jl","description":"Julia module for reading MATLAB files","fork":true,"url":"https://api.github.com/repos/halleysfifthinc/MAT.jl","forks_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/forks","keys_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/teams","hooks_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/hooks","issue_events_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/issues/events{/number}","events_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/events","assignees_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/assignees{/user}","branches_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/branches{/branch}","tags_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/tags","blobs_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/languages","stargazers_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/stargazers","contributors_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/contributors","subscribers_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/subscribers","subscription_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/subscription","commits_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/contents/{+path}","compare_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/merges","archive_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/downloads","issues_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/issues{/number}","pulls_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/labels{/name}","releases_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/releases{/id}","deployments_url":"https://api.github.com/repos/halleysfifthinc/MAT.jl/deployments","created_at":"2018-07-30T20:52:19Z","updated_at":"2018-07-30T20:52:21Z","pushed_at":"2018-09-20T17:18:59Z","git_url":"git://github.com/halleysfifthinc/MAT.jl.git","ssh_url":"git@github.com:halleysfifthinc/MAT.jl.git","clone_url":"https://github.com/halleysfifthinc/MAT.jl.git","svn_url":"https://github.com/halleysfifthinc/MAT.jl","homepage":"","size":979,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaIO:master","ref":"master","sha":"9e022320a1b52e1650a0864c8ba05004cf02d141","user":{"login":"JuliaIO","id":11489324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDg5MzI0","avatar_url":"https://avatars0.githubusercontent.com/u/11489324?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaIO","html_url":"https://github.com/JuliaIO","followers_url":"https://api.github.com/users/JuliaIO/followers","following_url":"https://api.github.com/users/JuliaIO/following{/other_user}","gists_url":"https://api.github.com/users/JuliaIO/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaIO/subscriptions","organizations_url":"https://api.github.com/users/JuliaIO/orgs","repos_url":"https://api.github.com/users/JuliaIO/repos","events_url":"https://api.github.com/users/JuliaIO/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaIO/received_events","type":"Organization","site_admin":false},"repo":{"id":6964619,"node_id":"MDEwOlJlcG9zaXRvcnk2OTY0NjE5","name":"MAT.jl","full_name":"JuliaIO/MAT.jl","private":false,"owner":{"login":"JuliaIO","id":11489324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDg5MzI0","avatar_url":"https://avatars0.githubusercontent.com/u/11489324?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaIO","html_url":"https://github.com/JuliaIO","followers_url":"https://api.github.com/users/JuliaIO/followers","following_url":"https://api.github.com/users/JuliaIO/following{/other_user}","gists_url":"https://api.github.com/users/JuliaIO/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaIO/subscriptions","organizations_url":"https://api.github.com/users/JuliaIO/orgs","repos_url":"https://api.github.com/users/JuliaIO/repos","events_url":"https://api.github.com/users/JuliaIO/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaIO/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JuliaIO/MAT.jl","description":"Julia module for reading MATLAB files","fork":false,"url":"https://api.github.com/repos/JuliaIO/MAT.jl","forks_url":"https://api.github.com/repos/JuliaIO/MAT.jl/forks","keys_url":"https://api.github.com/repos/JuliaIO/MAT.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaIO/MAT.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaIO/MAT.jl/teams","hooks_url":"https://api.github.com/repos/JuliaIO/MAT.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaIO/MAT.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaIO/MAT.jl/events","assignees_url":"https://api.github.com/repos/JuliaIO/MAT.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaIO/MAT.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaIO/MAT.jl/tags","blobs_url":"https://api.github.com/repos/JuliaIO/MAT.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaIO/MAT.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaIO/MAT.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaIO/MAT.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaIO/MAT.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaIO/MAT.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaIO/MAT.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaIO/MAT.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaIO/MAT.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaIO/MAT.jl/subscription","commits_url":"https://api.github.com/repos/JuliaIO/MAT.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaIO/MAT.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaIO/MAT.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaIO/MAT.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaIO/MAT.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaIO/MAT.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaIO/MAT.jl/merges","archive_url":"https://api.github.com/repos/JuliaIO/MAT.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaIO/MAT.jl/downloads","issues_url":"https://api.github.com/repos/JuliaIO/MAT.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaIO/MAT.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaIO/MAT.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaIO/MAT.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaIO/MAT.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaIO/MAT.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaIO/MAT.jl/deployments","created_at":"2012-12-02T07:54:47Z","updated_at":"2018-09-30T17:41:52Z","pushed_at":"2018-10-04T20:50:39Z","git_url":"git://github.com/JuliaIO/MAT.jl.git","ssh_url":"git@github.com:JuliaIO/MAT.jl.git","clone_url":"https://github.com/JuliaIO/MAT.jl.git","svn_url":"https://github.com/JuliaIO/MAT.jl","homepage":"","size":966,"stargazers_count":101,"watchers_count":101,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":45,"open_issues":26,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaIO/MAT.jl/pulls/86"},"html":{"href":"https://github.com/JuliaIO/MAT.jl/pull/86"},"issue":{"href":"https://api.github.com/repos/JuliaIO/MAT.jl/issues/86"},"comments":{"href":"https://api.github.com/repos/JuliaIO/MAT.jl/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaIO/MAT.jl/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaIO/MAT.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaIO/MAT.jl/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaIO/MAT.jl/statuses/a1e7ae622f5d22f71c7253a87c3cb76b96cc0345"}},"author_association":"NONE"}}
{"actor":{"display_login":"yuyichao"}}