{"action":"created","comment":{"url":"https://api.github.com/repos/apache/couchdb-pkg/pulls/comments/232012910","pull_request_review_id":173110886,"id":232012910,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjAxMjkxMA==","diff_hunk":"@@ -33,29 +33,49 @@ ExclusiveArch: x86_64\n Exclusiveos:   linux\n Packager:      CouchDB Developers <dev@couchdb.apache.org>\n \n+%if 0%{?suse_version}\n+BuildRequires: erlang\n+BuildRequires: erlang-rebar\n+BuildRequires: erlang-reltool\n+BuildRequires: erlang-epmd\n+BuildRequires: gcc-c++\n+BuildRequires: pkg-config\n+Requires(pre): shadow\n+BuildRequires: python3\n+Requires(post): python3-progressbar\n+Requires(post): python3-requests\n+%else\n BuildRequires: esl-erlang\n BuildRequires: gcc\n+Requires(pre): shadow-utils\n+BuildRequires: python >= 2.6\n+#BuildRequires: python-pip\n+#BuildRequires: python-sphinx >= 1.5.3\n+Requires(post): python-progressbar\n+Requires(post): python-requests\n+%endif\n+\n BuildRequires: git\n BuildRequires: help2man\n #BuildRequires: couch-js-devel = 1:1.8.5\n BuildRequires: libcurl-devel\n BuildRequires: libicu-devel\n BuildRequires: nodejs >= 6.10.1\n-BuildRequires: python >= 2.6\n-#BuildRequires: python-pip\n-#BuildRequires: python-sphinx >= 1.5.3\n-\n-Requires(pre): shadow-utils\n \n Requires(post): curl\n Requires(post): couch-js = 1:1.8.5\n Requires(post): libicu >= 4.2.1\n Requires(post): procps\n-Requires(post): python-progressbar\n-Requires(post): python-requests\n+%if 0%{?suse_version}\n+Requires(post): erlang","path":"rpm/SPECS/couchdb.spec","position":45,"original_position":45,"commit_id":"b66021f03946af5129ed0b8df4a8fa26cc8aac09","original_commit_id":"b66021f03946af5129ed0b8df4a8fa26cc8aac09","user":{"login":"rolfn","id":1469001,"node_id":"MDQ6VXNlcjE0NjkwMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1469001?v=4","gravatar_id":"","url":"https://api.github.com/users/rolfn","html_url":"https://github.com/rolfn","followers_url":"https://api.github.com/users/rolfn/followers","following_url":"https://api.github.com/users/rolfn/following{/other_user}","gists_url":"https://api.github.com/users/rolfn/gists{/gist_id}","starred_url":"https://api.github.com/users/rolfn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolfn/subscriptions","organizations_url":"https://api.github.com/users/rolfn/orgs","repos_url":"https://api.github.com/users/rolfn/repos","events_url":"https://api.github.com/users/rolfn/events{/privacy}","received_events_url":"https://api.github.com/users/rolfn/received_events","type":"User","site_admin":false},"body":"OK. I will remove it.","created_at":"2018-11-08T18:36:20Z","updated_at":"2018-11-08T18:36:20Z","html_url":"https://github.com/apache/couchdb-pkg/pull/36#discussion_r232012910","pull_request_url":"https://api.github.com/repos/apache/couchdb-pkg/pulls/36","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/couchdb-pkg/pulls/comments/232012910"},"html":{"href":"https://github.com/apache/couchdb-pkg/pull/36#discussion_r232012910"},"pull_request":{"href":"https://api.github.com/repos/apache/couchdb-pkg/pulls/36"}},"in_reply_to_id":231577236},"pull_request":{"url":"https://api.github.com/repos/apache/couchdb-pkg/pulls/36","id":228166186,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTY2MTg2","html_url":"https://github.com/apache/couchdb-pkg/pull/36","diff_url":"https://github.com/apache/couchdb-pkg/pull/36.diff","patch_url":"https://github.com/apache/couchdb-pkg/pull/36.patch","issue_url":"https://api.github.com/repos/apache/couchdb-pkg/issues/36","number":36,"state":"open","locked":false,"title":"Modifications for openSUSE support","user":{"login":"rolfn","id":1469001,"node_id":"MDQ6VXNlcjE0NjkwMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1469001?v=4","gravatar_id":"","url":"https://api.github.com/users/rolfn","html_url":"https://github.com/rolfn","followers_url":"https://api.github.com/users/rolfn/followers","following_url":"https://api.github.com/users/rolfn/following{/other_user}","gists_url":"https://api.github.com/users/rolfn/gists{/gist_id}","starred_url":"https://api.github.com/users/rolfn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolfn/subscriptions","organizations_url":"https://api.github.com/users/rolfn/orgs","repos_url":"https://api.github.com/users/rolfn/repos","events_url":"https://api.github.com/users/rolfn/events{/privacy}","received_events_url":"https://api.github.com/users/rolfn/received_events","type":"User","site_admin":false},"body":"<!-- Thank you for your contribution!\r\n\r\n     Please file this form by replacing the Markdown comments\r\n     with your text. If a section needs no action - remove it.\r\n\r\n     Also remember, that CouchDB uses the Review-Then-Commit (RTC) model\r\n     of code collaboration. Positive feedback is represented +1 from committers\r\n     and negative is a -1. The -1 also means veto, and needs to be addressed\r\n     to proceed. Once there are no objections, the PR can be merged by a\r\n     CouchDB committer.\r\n\r\n     See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->\r\n\r\n## Overview\r\n\r\nI changed the files `Makefile`, `js/rpm/SPECS/js.spec`, and `rpm/SPECS/couchdb.spec` to make the creation of rpm files for openSUSE  possible (only newer systemd based versions).\r\n\r\n<!-- Please give a short brief for the pull request,\r\n     what problem it solves or how it makes things better. -->\r\n\r\n## Testing recommendations\r\n\r\nI compiled \"couch-js\" and \"couchdb\" succesful for \"openSUSE Tumbleweed\" in the following way:\r\n```\r\nURL=https://www.apache.org/dist/couchdb/source/2.2.0/apache-couchdb-2.2.0.tar.gz \\\r\nmake download-couch\r\nmake couch-js-rpms \r\nsudo zypper install $HOME/rpmbuild/RPMS/x86_64/couch-js-devel-1.8.5-21.x86_64.rpm \\\r\n  $HOME/rpmbuild/RPMS/x86_64/couch-js-1.8.5-21.x86_64.rpm\r\nmake openSUSE \r\n```\r\nAt this time I can only confirm the correct compilation, no run time test. I will test the fresh compiled couchDB in a couple of days\r\n\r\n<!-- Describe how we can test your changes.\r\n     Does it provides any behaviour that the end users\r\n     could notice? -->\r\n\r\n## GitHub issue number\r\n\r\n<!-- If this is a significant change, please file a separate issue at:\r\n     https://github.com/apache/couchdb-pkg/issues\r\n     and include the number here and in commit message(s) using\r\n     syntax like \"Fixes #472\" or \"Fixes apache/couchdb#472\".  -->\r\n\r\n## Related Pull Requests\r\n\r\n<!-- If your changes affects multiple components in different\r\n     repositories please put links to those pull requests here.  -->\r\n\r\n## Checklist\r\n\r\n- [ ] Code is written and works correctly;\r\n- [ ] Changes are covered by tests;\r\n- [ ] Documentation reflects the changes;\r\n","created_at":"2018-11-04T09:26:37Z","updated_at":"2018-11-08T18:36:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a15e4ea31448536e8197a754d7334bccfbadac9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/couchdb-pkg/pulls/36/commits","review_comments_url":"https://api.github.com/repos/apache/couchdb-pkg/pulls/36/comments","review_comment_url":"https://api.github.com/repos/apache/couchdb-pkg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/couchdb-pkg/issues/36/comments","statuses_url":"https://api.github.com/repos/apache/couchdb-pkg/statuses/b66021f03946af5129ed0b8df4a8fa26cc8aac09","head":{"label":"rolfn:master","ref":"master","sha":"b66021f03946af5129ed0b8df4a8fa26cc8aac09","user":{"login":"rolfn","id":1469001,"node_id":"MDQ6VXNlcjE0NjkwMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1469001?v=4","gravatar_id":"","url":"https://api.github.com/users/rolfn","html_url":"https://github.com/rolfn","followers_url":"https://api.github.com/users/rolfn/followers","following_url":"https://api.github.com/users/rolfn/following{/other_user}","gists_url":"https://api.github.com/users/rolfn/gists{/gist_id}","starred_url":"https://api.github.com/users/rolfn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolfn/subscriptions","organizations_url":"https://api.github.com/users/rolfn/orgs","repos_url":"https://api.github.com/users/rolfn/repos","events_url":"https://api.github.com/users/rolfn/events{/privacy}","received_events_url":"https://api.github.com/users/rolfn/received_events","type":"User","site_admin":false},"repo":{"id":155963228,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU5NjMyMjg=","name":"couchdb-pkg","full_name":"rolfn/couchdb-pkg","private":false,"owner":{"login":"rolfn","id":1469001,"node_id":"MDQ6VXNlcjE0NjkwMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1469001?v=4","gravatar_id":"","url":"https://api.github.com/users/rolfn","html_url":"https://github.com/rolfn","followers_url":"https://api.github.com/users/rolfn/followers","following_url":"https://api.github.com/users/rolfn/following{/other_user}","gists_url":"https://api.github.com/users/rolfn/gists{/gist_id}","starred_url":"https://api.github.com/users/rolfn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolfn/subscriptions","organizations_url":"https://api.github.com/users/rolfn/orgs","repos_url":"https://api.github.com/users/rolfn/repos","events_url":"https://api.github.com/users/rolfn/events{/privacy}","received_events_url":"https://api.github.com/users/rolfn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rolfn/couchdb-pkg","description":"Apache CouchDB Packaging support files","fork":true,"url":"https://api.github.com/repos/rolfn/couchdb-pkg","forks_url":"https://api.github.com/repos/rolfn/couchdb-pkg/forks","keys_url":"https://api.github.com/repos/rolfn/couchdb-pkg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rolfn/couchdb-pkg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rolfn/couchdb-pkg/teams","hooks_url":"https://api.github.com/repos/rolfn/couchdb-pkg/hooks","issue_events_url":"https://api.github.com/repos/rolfn/couchdb-pkg/issues/events{/number}","events_url":"https://api.github.com/repos/rolfn/couchdb-pkg/events","assignees_url":"https://api.github.com/repos/rolfn/couchdb-pkg/assignees{/user}","branches_url":"https://api.github.com/repos/rolfn/couchdb-pkg/branches{/branch}","tags_url":"https://api.github.com/repos/rolfn/couchdb-pkg/tags","blobs_url":"https://api.github.com/repos/rolfn/couchdb-pkg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rolfn/couchdb-pkg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rolfn/couchdb-pkg/git/refs{/sha}","trees_url":"https://api.github.com/repos/rolfn/couchdb-pkg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rolfn/couchdb-pkg/statuses/{sha}","languages_url":"https://api.github.com/repos/rolfn/couchdb-pkg/languages","stargazers_url":"https://api.github.com/repos/rolfn/couchdb-pkg/stargazers","contributors_url":"https://api.github.com/repos/rolfn/couchdb-pkg/contributors","subscribers_url":"https://api.github.com/repos/rolfn/couchdb-pkg/subscribers","subscription_url":"https://api.github.com/repos/rolfn/couchdb-pkg/subscription","commits_url":"https://api.github.com/repos/rolfn/couchdb-pkg/commits{/sha}","git_commits_url":"https://api.github.com/repos/rolfn/couchdb-pkg/git/commits{/sha}","comments_url":"https://api.github.com/repos/rolfn/couchdb-pkg/comments{/number}","issue_comment_url":"https://api.github.com/repos/rolfn/couchdb-pkg/issues/comments{/number}","contents_url":"https://api.github.com/repos/rolfn/couchdb-pkg/contents/{+path}","compare_url":"https://api.github.com/repos/rolfn/couchdb-pkg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rolfn/couchdb-pkg/merges","archive_url":"https://api.github.com/repos/rolfn/couchdb-pkg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rolfn/couchdb-pkg/downloads","issues_url":"https://api.github.com/repos/rolfn/couchdb-pkg/issues{/number}","pulls_url":"https://api.github.com/repos/rolfn/couchdb-pkg/pulls{/number}","milestones_url":"https://api.github.com/repos/rolfn/couchdb-pkg/milestones{/number}","notifications_url":"https://api.github.com/repos/rolfn/couchdb-pkg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rolfn/couchdb-pkg/labels{/name}","releases_url":"https://api.github.com/repos/rolfn/couchdb-pkg/releases{/id}","deployments_url":"https://api.github.com/repos/rolfn/couchdb-pkg/deployments","created_at":"2018-11-03T08:08:45Z","updated_at":"2018-11-04T09:09:35Z","pushed_at":"2018-11-04T09:09:34Z","git_url":"git://github.com/rolfn/couchdb-pkg.git","ssh_url":"git@github.com:rolfn/couchdb-pkg.git","clone_url":"https://github.com/rolfn/couchdb-pkg.git","svn_url":"https://github.com/rolfn/couchdb-pkg","homepage":"","size":25826,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2c63fe067a7f5e52e216d4870cfcb724b423b6db","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":87245701,"node_id":"MDEwOlJlcG9zaXRvcnk4NzI0NTcwMQ==","name":"couchdb-pkg","full_name":"apache/couchdb-pkg","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/couchdb-pkg","description":"Apache CouchDB Packaging support files","fork":false,"url":"https://api.github.com/repos/apache/couchdb-pkg","forks_url":"https://api.github.com/repos/apache/couchdb-pkg/forks","keys_url":"https://api.github.com/repos/apache/couchdb-pkg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/couchdb-pkg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/couchdb-pkg/teams","hooks_url":"https://api.github.com/repos/apache/couchdb-pkg/hooks","issue_events_url":"https://api.github.com/repos/apache/couchdb-pkg/issues/events{/number}","events_url":"https://api.github.com/repos/apache/couchdb-pkg/events","assignees_url":"https://api.github.com/repos/apache/couchdb-pkg/assignees{/user}","branches_url":"https://api.github.com/repos/apache/couchdb-pkg/branches{/branch}","tags_url":"https://api.github.com/repos/apache/couchdb-pkg/tags","blobs_url":"https://api.github.com/repos/apache/couchdb-pkg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/couchdb-pkg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/couchdb-pkg/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/couchdb-pkg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/couchdb-pkg/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/couchdb-pkg/languages","stargazers_url":"https://api.github.com/repos/apache/couchdb-pkg/stargazers","contributors_url":"https://api.github.com/repos/apache/couchdb-pkg/contributors","subscribers_url":"https://api.github.com/repos/apache/couchdb-pkg/subscribers","subscription_url":"https://api.github.com/repos/apache/couchdb-pkg/subscription","commits_url":"https://api.github.com/repos/apache/couchdb-pkg/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/couchdb-pkg/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/couchdb-pkg/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/couchdb-pkg/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/couchdb-pkg/contents/{+path}","compare_url":"https://api.github.com/repos/apache/couchdb-pkg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/couchdb-pkg/merges","archive_url":"https://api.github.com/repos/apache/couchdb-pkg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/couchdb-pkg/downloads","issues_url":"https://api.github.com/repos/apache/couchdb-pkg/issues{/number}","pulls_url":"https://api.github.com/repos/apache/couchdb-pkg/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/couchdb-pkg/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/couchdb-pkg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/couchdb-pkg/labels{/name}","releases_url":"https://api.github.com/repos/apache/couchdb-pkg/releases{/id}","deployments_url":"https://api.github.com/repos/apache/couchdb-pkg/deployments","created_at":"2017-04-04T23:46:10Z","updated_at":"2018-11-02T19:51:19Z","pushed_at":"2018-11-08T01:18:47Z","git_url":"git://github.com/apache/couchdb-pkg.git","ssh_url":"git@github.com:apache/couchdb-pkg.git","clone_url":"https://github.com/apache/couchdb-pkg.git","svn_url":"https://github.com/apache/couchdb-pkg","homepage":"","size":25823,"stargazers_count":10,"watchers_count":10,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":3,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/couchdb-pkg/pulls/36"},"html":{"href":"https://github.com/apache/couchdb-pkg/pull/36"},"issue":{"href":"https://api.github.com/repos/apache/couchdb-pkg/issues/36"},"comments":{"href":"https://api.github.com/repos/apache/couchdb-pkg/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/couchdb-pkg/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/couchdb-pkg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/couchdb-pkg/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/apache/couchdb-pkg/statuses/b66021f03946af5129ed0b8df4a8fa26cc8aac09"}},"author_association":"NONE"}}
{"actor":{"display_login":"rolfn"}}