{"action":"closed","number":4202,"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/4202","id":205070477,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MDcwNDc3","html_url":"https://github.com/facebook/rocksdb/pull/4202","diff_url":"https://github.com/facebook/rocksdb/pull/4202.diff","patch_url":"https://github.com/facebook/rocksdb/pull/4202.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/4202","number":4202,"state":"closed","locked":false,"title":"Improve FullFilterBitsReader::HashMayMatch's doc","user":{"login":"yaojingguo","id":516386,"node_id":"MDQ6VXNlcjUxNjM4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/516386?v=4","gravatar_id":"","url":"https://api.github.com/users/yaojingguo","html_url":"https://github.com/yaojingguo","followers_url":"https://api.github.com/users/yaojingguo/followers","following_url":"https://api.github.com/users/yaojingguo/following{/other_user}","gists_url":"https://api.github.com/users/yaojingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/yaojingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaojingguo/subscriptions","organizations_url":"https://api.github.com/users/yaojingguo/orgs","repos_url":"https://api.github.com/users/yaojingguo/repos","events_url":"https://api.github.com/users/yaojingguo/events{/privacy}","received_events_url":"https://api.github.com/users/yaojingguo/received_events","type":"User","site_admin":false},"body":"HashMayMatch is related to AddKey() instead of CreateFilter().\r\nAlso applies some minor Fixes #4191 #4200 #3910","created_at":"2018-07-31T10:46:02Z","updated_at":"2018-08-06T18:13:58Z","closed_at":"2018-08-06T18:13:58Z","merged_at":null,"merge_commit_sha":"26c3b7d11ba6e6d1215cb52d604733ddb6428869","assignee":{"login":"maysamyabandeh","id":1167741,"node_id":"MDQ6VXNlcjExNjc3NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1167741?v=4","gravatar_id":"","url":"https://api.github.com/users/maysamyabandeh","html_url":"https://github.com/maysamyabandeh","followers_url":"https://api.github.com/users/maysamyabandeh/followers","following_url":"https://api.github.com/users/maysamyabandeh/following{/other_user}","gists_url":"https://api.github.com/users/maysamyabandeh/gists{/gist_id}","starred_url":"https://api.github.com/users/maysamyabandeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maysamyabandeh/subscriptions","organizations_url":"https://api.github.com/users/maysamyabandeh/orgs","repos_url":"https://api.github.com/users/maysamyabandeh/repos","events_url":"https://api.github.com/users/maysamyabandeh/events{/privacy}","received_events_url":"https://api.github.com/users/maysamyabandeh/received_events","type":"User","site_admin":false},"assignees":[{"login":"maysamyabandeh","id":1167741,"node_id":"MDQ6VXNlcjExNjc3NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1167741?v=4","gravatar_id":"","url":"https://api.github.com/users/maysamyabandeh","html_url":"https://github.com/maysamyabandeh","followers_url":"https://api.github.com/users/maysamyabandeh/followers","following_url":"https://api.github.com/users/maysamyabandeh/following{/other_user}","gists_url":"https://api.github.com/users/maysamyabandeh/gists{/gist_id}","starred_url":"https://api.github.com/users/maysamyabandeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maysamyabandeh/subscriptions","organizations_url":"https://api.github.com/users/maysamyabandeh/orgs","repos_url":"https://api.github.com/users/maysamyabandeh/repos","events_url":"https://api.github.com/users/maysamyabandeh/events{/privacy}","received_events_url":"https://api.github.com/users/maysamyabandeh/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196859108,"node_id":"MDU6TGFiZWwxOTY4NTkxMDg=","url":"https://api.github.com/repos/facebook/rocksdb/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/4202/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/4202/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/4202/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/8d6bbf262419b0092e9ba30f3b4f49e64b7b64f4","head":{"label":"yaojingguo:HashMayMatch-comment","ref":"HashMayMatch-comment","sha":"8d6bbf262419b0092e9ba30f3b4f49e64b7b64f4","user":{"login":"yaojingguo","id":516386,"node_id":"MDQ6VXNlcjUxNjM4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/516386?v=4","gravatar_id":"","url":"https://api.github.com/users/yaojingguo","html_url":"https://github.com/yaojingguo","followers_url":"https://api.github.com/users/yaojingguo/followers","following_url":"https://api.github.com/users/yaojingguo/following{/other_user}","gists_url":"https://api.github.com/users/yaojingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/yaojingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaojingguo/subscriptions","organizations_url":"https://api.github.com/users/yaojingguo/orgs","repos_url":"https://api.github.com/users/yaojingguo/repos","events_url":"https://api.github.com/users/yaojingguo/events{/privacy}","received_events_url":"https://api.github.com/users/yaojingguo/received_events","type":"User","site_admin":false},"repo":{"id":124318908,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQzMTg5MDg=","name":"rocksdb","full_name":"yaojingguo/rocksdb","owner":{"login":"yaojingguo","id":516386,"node_id":"MDQ6VXNlcjUxNjM4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/516386?v=4","gravatar_id":"","url":"https://api.github.com/users/yaojingguo","html_url":"https://github.com/yaojingguo","followers_url":"https://api.github.com/users/yaojingguo/followers","following_url":"https://api.github.com/users/yaojingguo/following{/other_user}","gists_url":"https://api.github.com/users/yaojingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/yaojingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaojingguo/subscriptions","organizations_url":"https://api.github.com/users/yaojingguo/orgs","repos_url":"https://api.github.com/users/yaojingguo/repos","events_url":"https://api.github.com/users/yaojingguo/events{/privacy}","received_events_url":"https://api.github.com/users/yaojingguo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yaojingguo/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/yaojingguo/rocksdb","forks_url":"https://api.github.com/repos/yaojingguo/rocksdb/forks","keys_url":"https://api.github.com/repos/yaojingguo/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yaojingguo/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yaojingguo/rocksdb/teams","hooks_url":"https://api.github.com/repos/yaojingguo/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/yaojingguo/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/yaojingguo/rocksdb/events","assignees_url":"https://api.github.com/repos/yaojingguo/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/yaojingguo/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/yaojingguo/rocksdb/tags","blobs_url":"https://api.github.com/repos/yaojingguo/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yaojingguo/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yaojingguo/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/yaojingguo/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yaojingguo/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/yaojingguo/rocksdb/languages","stargazers_url":"https://api.github.com/repos/yaojingguo/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/yaojingguo/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/yaojingguo/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/yaojingguo/rocksdb/subscription","commits_url":"https://api.github.com/repos/yaojingguo/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/yaojingguo/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/yaojingguo/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/yaojingguo/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/yaojingguo/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/yaojingguo/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yaojingguo/rocksdb/merges","archive_url":"https://api.github.com/repos/yaojingguo/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yaojingguo/rocksdb/downloads","issues_url":"https://api.github.com/repos/yaojingguo/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/yaojingguo/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/yaojingguo/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/yaojingguo/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yaojingguo/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/yaojingguo/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/yaojingguo/rocksdb/deployments","created_at":"2018-03-08T01:33:56Z","updated_at":"2018-03-08T01:34:03Z","pushed_at":"2018-08-04T02:40:35Z","git_url":"git://github.com/yaojingguo/rocksdb.git","ssh_url":"git@github.com:yaojingguo/rocksdb.git","clone_url":"https://github.com/yaojingguo/rocksdb.git","svn_url":"https://github.com/yaojingguo/rocksdb","homepage":"http://rocksdb.org","size":96777,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"1f802773bc11c99e24fcc43bce6ac599e95be6af","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"node_id":"MDEwOlJlcG9zaXRvcnk2OTM0Mzk1","name":"rocksdb","full_name":"facebook/rocksdb","owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2018-08-06T16:32:04Z","pushed_at":"2018-08-06T18:13:39Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":116701,"stargazers_count":11202,"watchers_count":11202,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2462,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2462,"open_issues":210,"watchers":11202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/4202"},"html":{"href":"https://github.com/facebook/rocksdb/pull/4202"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/4202"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/4202/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/4202/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/4202/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/8d6bbf262419b0092e9ba30f3b4f49e64b7b64f4"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":7,"changed_files":4}}
{"actor":{"display_login":"facebook-github-bot"}}