{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/5952","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/5952/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/5952/comments","events_url":"https://api.github.com/repos/istio/istio/issues/5952/events","html_url":"https://github.com/istio/istio/pull/5952","id":328249493,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODM3NzI2","number":5952,"title":"Refactor Istio Dashboards to support larger meshes","user":{"login":"douglas-reid","id":21148125,"node_id":"MDQ6VXNlcjIxMTQ4MTI1","avatar_url":"https://avatars3.githubusercontent.com/u/21148125?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false},"labels":[{"id":659652351,"node_id":"MDU6TGFiZWw2NTk2NTIzNTE=","url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":813133538,"node_id":"MDU6TGFiZWw4MTMxMzM1Mzg=","url":"https://api.github.com/repos/istio/istio/labels/area/policies%20and%20telemetry","name":"area/policies and telemetry","color":"0e8a16","default":false},{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":671106566,"node_id":"MDU6TGFiZWw2NzExMDY1NjY=","url":"https://api.github.com/repos/istio/istio/labels/kind/needed%20for%201.0","name":"kind/needed for 1.0","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-05-31T18:32:20Z","updated_at":"2018-06-05T17:26:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/5952","html_url":"https://github.com/istio/istio/pull/5952","diff_url":"https://github.com/istio/istio/pull/5952.diff","patch_url":"https://github.com/istio/istio/pull/5952.patch"},"body":"The original Istio Dashboard provided a panel (and several charts) per service within the mesh, in addition to mesh-wide charts. This does not scale for meshes beyond trivial sizes.\r\n\r\nIn order to support medium-to-large meshes, this PR refactors the setup by introducing two new single service dashboards (one for TCP and one for HTTP/GRPC) and replacing the panels on the main dashboard with a table of service metrics.\r\n\r\nTo drill down to individual service dashboards, the \"destination service\" column in the tables provides a clickable-link for navigation purposes. The tables provides a scrollable set of 25 rows, with pagination for cases when there are more than 25 services.\r\n\r\nA few notes:\r\n- in preparation for the attribute update and service -> workload refactor, some of the advanced filtering features have been removed (dropdowns for source, version, etc.).\r\n- the new service dashboards are bare-bones. follow-on PRs will be necessary to fully-flesh them out. that work is intended to be carried out in parallel to the client-side reporting and attribute change work.\r\n\r\nScreenshots in action:\r\n\r\n![istio-mesh-dashboard](https://user-images.githubusercontent.com/21148125/40800634-c81742ce-64c5-11e8-8689-6b9645feeb50.png)\r\n![http-service-dashboard](https://user-images.githubusercontent.com/21148125/40800637-ca16ce00-64c5-11e8-92ab-428aca7ef18e.png)\r\n![tcp-service-dashboard](https://user-images.githubusercontent.com/21148125/40800639-cbffdd9c-64c5-11e8-89db-ad0e266c794d.png)\r\n\r\nReviewers:\r\n\r\n- I have not verified image creation and e2e test passage yet. I wanted to put this out for comment before proceeding further.\r\n- I am looking for feedback on overall approach and design. This was my first thought. Always open to better suggestions, etc."},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/394793566","html_url":"https://github.com/istio/istio/pull/5952#issuecomment-394793566","issue_url":"https://api.github.com/repos/istio/istio/issues/5952","id":394793566,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDc5MzU2Ng==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-06-05T17:26:39Z","updated_at":"2018-06-05T17:26:39Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/istio/istio/pull/5952?src=pr&el=h1) Report\n> Merging [#5952](https://codecov.io/gh/istio/istio/pull/5952?src=pr&el=desc) into [master](https://codecov.io/gh/istio/istio/commit/9f7e2259b9c5ddbdd60a49d67737cfdada105fda?src=pr&el=desc) will **increase** coverage by `2%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/istio/istio/pull/5952/graphs/tree.svg?width=650&src=pr&token=nYtepj7fDQ&height=150)](https://codecov.io/gh/istio/istio/pull/5952?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff            @@\n##           master   #5952     +/-   ##\n========================================\n+ Coverage      67%     69%     +2%     \n========================================\n  Files         334     321     -13     \n  Lines       28851   27709   -1142     \n========================================\n- Hits        19165   18881    -284     \n+ Misses       8918    8111    -807     \n+ Partials      768     717     -51\n```\n\n\n| [Impacted Files](https://codecov.io/gh/istio/istio/pull/5952?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [pilot/pkg/model/authentication.go](https://codecov.io/gh/istio/istio/pull/5952/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL21vZGVsL2F1dGhlbnRpY2F0aW9uLmdv) | `57% <0%> (-15%)` | :arrow_down: |\n| [pilot/pkg/config/memory/monitor.go](https://codecov.io/gh/istio/istio/pull/5952/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL2NvbmZpZy9tZW1vcnkvbW9uaXRvci5nbw==) | `82% <0%> (-9%)` | :arrow_down: |\n| [mixer/adapter/stackdriver/helper/common.go](https://codecov.io/gh/istio/istio/pull/5952/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9zdGFja2RyaXZlci9oZWxwZXIvY29tbW9uLmdv) | `78% <0%> (-5%)` | :arrow_down: |\n| [mixer/adapter/fluentd/fluentd.go](https://codecov.io/gh/istio/istio/pull/5952/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9mbHVlbnRkL2ZsdWVudGQuZ28=) | `76% <0%> (-3%)` | :arrow_down: |\n| [mixer/pkg/runtime/dispatcher/dispatcher.go](https://codecov.io/gh/istio/istio/pull/5952/diff?src=pr&el=tree#diff-bWl4ZXIvcGtnL3J1bnRpbWUvZGlzcGF0Y2hlci9kaXNwYXRjaGVyLmdv) | `98% <0%> (-2%)` | :arrow_down: |\n| [galley/pkg/resource/accessor.go](https://codecov.io/gh/istio/istio/pull/5952/diff?src=pr&el=tree#diff-Z2FsbGV5L3BrZy9yZXNvdXJjZS9hY2Nlc3Nvci5nbw==) | `92% <0%> (-2%)` | :arrow_down: |\n| [mixer/adapter/servicecontrol/testhelper.go](https://codecov.io/gh/istio/istio/pull/5952/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9zZXJ2aWNlY29udHJvbC90ZXN0aGVscGVyLmdv) | `70% <0%> (-1%)` | :arrow_down: |\n| [mixer/adapter/statsd/statsd.go](https://codecov.io/gh/istio/istio/pull/5952/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9zdGF0c2Qvc3RhdHNkLmdv) | `96% <0%> (-1%)` | :arrow_down: |\n| [pilot/pkg/config/monitor/copilot\\_snapshot.go](https://codecov.io/gh/istio/istio/pull/5952/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL2NvbmZpZy9tb25pdG9yL2NvcGlsb3Rfc25hcHNob3QuZ28=) | `98% <0%> (ø)` | :arrow_down: |\n| [pilot/pkg/config/kube/crd/client.go](https://codecov.io/gh/istio/istio/pull/5952/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL2NvbmZpZy9rdWJlL2NyZC9jbGllbnQuZ28=) | `1% <0%> (ø)` | :arrow_down: |\n| ... and [43 more](https://codecov.io/gh/istio/istio/pull/5952/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/istio/istio/pull/5952?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/istio/istio/pull/5952?src=pr&el=footer). Last update [9f7e225...64efdfb](https://codecov.io/gh/istio/istio/pull/5952?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}