{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/239828062","pull_request_review_id":182719381,"id":239828062,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTgyODA2Mg==","diff_hunk":"@@ -104,9 +115,11 @@ void ConfigureDialog::UpdateVisibleTabs() {\n         return;\n \n     const QHash<QString, QWidget*> widgets = {\n-        {\"General\", ui->generalTab},   {\"System\", ui->systemTab}, {\"Input\", ui->inputTab},\n-        {\"Graphics\", ui->graphicsTab}, {\"Audio\", ui->audioTab},   {\"Camera\", ui->cameraTab},\n-        {\"Debug\", ui->debugTab},       {\"Web\", ui->webTab},       {\"UI\", ui->uiTab}};\n+        {tr(\"General\"), ui->generalTab},   {tr(\"System\"), ui->systemTab},\n+        {tr(\"Input\"), ui->inputTab},       {tr(\"Hotkeys\"), ui->hotkeysTab},\n+        {tr(\"Graphics\"), ui->graphicsTab}, {tr(\"Audio\"), ui->audioTab},\n+        {tr(\"Camera\"), ui->cameraTab},     {tr(\"Debug\"), ui->debugTab},\n+        {tr(\"Web\"), ui->webTab},           {tr(\"UI\"), ui->uiTab}};","path":"src/citra_qt/configuration/configure_dialog.cpp","position":69,"original_position":69,"commit_id":"c3803f4af9a4273dcdfdd436e78c7217cc2c10b6","original_commit_id":"c3803f4af9a4273dcdfdd436e78c7217cc2c10b6","user":{"login":"zhaowenlan1779","id":21307832,"node_id":"MDQ6VXNlcjIxMzA3ODMy","avatar_url":"https://avatars0.githubusercontent.com/u/21307832?v=4","gravatar_id":"","url":"https://api.github.com/users/zhaowenlan1779","html_url":"https://github.com/zhaowenlan1779","followers_url":"https://api.github.com/users/zhaowenlan1779/followers","following_url":"https://api.github.com/users/zhaowenlan1779/following{/other_user}","gists_url":"https://api.github.com/users/zhaowenlan1779/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaowenlan1779/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaowenlan1779/subscriptions","organizations_url":"https://api.github.com/users/zhaowenlan1779/orgs","repos_url":"https://api.github.com/users/zhaowenlan1779/repos","events_url":"https://api.github.com/users/zhaowenlan1779/events{/privacy}","received_events_url":"https://api.github.com/users/zhaowenlan1779/received_events","type":"User","site_admin":false},"body":"Please do not translate them here","created_at":"2018-12-07T14:37:38Z","updated_at":"2018-12-07T14:37:41Z","html_url":"https://github.com/citra-emu/citra/pull/4437#discussion_r239828062","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/4437","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/239828062"},"html":{"href":"https://github.com/citra-emu/citra/pull/4437#discussion_r239828062"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/4437"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/4437","id":231590801,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNTkwODAx","html_url":"https://github.com/citra-emu/citra/pull/4437","diff_url":"https://github.com/citra-emu/citra/pull/4437.diff","patch_url":"https://github.com/citra-emu/citra/pull/4437.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/4437","number":4437,"state":"open","locked":false,"title":"citra-qt: Make hotkeys configurable via the GUI (Attempt 2)","user":{"login":"adityaruplaha","id":30696515,"node_id":"MDQ6VXNlcjMwNjk2NTE1","avatar_url":"https://avatars1.githubusercontent.com/u/30696515?v=4","gravatar_id":"","url":"https://api.github.com/users/adityaruplaha","html_url":"https://github.com/adityaruplaha","followers_url":"https://api.github.com/users/adityaruplaha/followers","following_url":"https://api.github.com/users/adityaruplaha/following{/other_user}","gists_url":"https://api.github.com/users/adityaruplaha/gists{/gist_id}","starred_url":"https://api.github.com/users/adityaruplaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityaruplaha/subscriptions","organizations_url":"https://api.github.com/users/adityaruplaha/orgs","repos_url":"https://api.github.com/users/adityaruplaha/repos","events_url":"https://api.github.com/users/adityaruplaha/events{/privacy}","received_events_url":"https://api.github.com/users/adityaruplaha/received_events","type":"User","site_admin":false},"body":"This is take 2 at this. Take 1 is at #3786. All its commits have been merged into the first one to make rebase easier. \r\nTested on both MSVC & MinGW locally. All works & looks ok.\r\n\r\nOriginal description is as follows.\r\n\r\n---\r\nBig thanks to @Kloen for letting me ~~steal~~ see & edit his code from Kloen/citra:hotkeys-once-again (originally #2773)!\r\n**EDIT**: I've rewritten a lot of his code and have gone through the rest, so I can answer review questions regarding nearly all parts of it.\r\n\r\nPretty self explanatory. See the code for more details.\r\n**Note: This doesn't allow hotkeys to be bound to controllers.**\r\n\r\n---\r\n# Major changes:\r\n* Hotkeys separated into its own tab.\r\n* Registration code for hotkeys has been rewritten by @Kloen.\r\n* Config code for hotkeys has been almost completely rewritten.\r\n\r\n# Current Issues:\r\n* [x] Need to restart for hotkeys to refresh. (@B3n30)\r\n* [x] Some hotkeys aren't implemented in this PR. Their functionality will be lost. But they can easily (imo more easily than before) be added back. Among them:\r\n    * Frame Advance\r\n    * Amiibo\r\n\r\n# Screenshots:\r\n![capture](https://user-images.githubusercontent.com/30696515/48635171-696be600-e9ed-11e8-90c0-b8cbbe75376e.PNG)\r\nFor more, see the original PR.\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/citra-emu/citra/4437)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-11-16T16:44:35Z","updated_at":"2018-12-07T14:37:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d35fbc9d81392afce2028b1b51f1a9ce4c1cade1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":811880815,"node_id":"MDU6TGFiZWw4MTE4ODA4MTU=","url":"https://api.github.com/repos/citra-emu/citra/labels/canary-merge","name":"canary-merge","color":"11916f","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/4437/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/4437/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/4437/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/c3803f4af9a4273dcdfdd436e78c7217cc2c10b6","head":{"label":"adityaruplaha:hotkey-config-squashed","ref":"hotkey-config-squashed","sha":"c3803f4af9a4273dcdfdd436e78c7217cc2c10b6","user":{"login":"adityaruplaha","id":30696515,"node_id":"MDQ6VXNlcjMwNjk2NTE1","avatar_url":"https://avatars1.githubusercontent.com/u/30696515?v=4","gravatar_id":"","url":"https://api.github.com/users/adityaruplaha","html_url":"https://github.com/adityaruplaha","followers_url":"https://api.github.com/users/adityaruplaha/followers","following_url":"https://api.github.com/users/adityaruplaha/following{/other_user}","gists_url":"https://api.github.com/users/adityaruplaha/gists{/gist_id}","starred_url":"https://api.github.com/users/adityaruplaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityaruplaha/subscriptions","organizations_url":"https://api.github.com/users/adityaruplaha/orgs","repos_url":"https://api.github.com/users/adityaruplaha/repos","events_url":"https://api.github.com/users/adityaruplaha/events{/privacy}","received_events_url":"https://api.github.com/users/adityaruplaha/received_events","type":"User","site_admin":false},"repo":{"id":125715497,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU3MTU0OTc=","name":"citra","full_name":"adityaruplaha/citra","private":false,"owner":{"login":"adityaruplaha","id":30696515,"node_id":"MDQ6VXNlcjMwNjk2NTE1","avatar_url":"https://avatars1.githubusercontent.com/u/30696515?v=4","gravatar_id":"","url":"https://api.github.com/users/adityaruplaha","html_url":"https://github.com/adityaruplaha","followers_url":"https://api.github.com/users/adityaruplaha/followers","following_url":"https://api.github.com/users/adityaruplaha/following{/other_user}","gists_url":"https://api.github.com/users/adityaruplaha/gists{/gist_id}","starred_url":"https://api.github.com/users/adityaruplaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityaruplaha/subscriptions","organizations_url":"https://api.github.com/users/adityaruplaha/orgs","repos_url":"https://api.github.com/users/adityaruplaha/repos","events_url":"https://api.github.com/users/adityaruplaha/events{/privacy}","received_events_url":"https://api.github.com/users/adityaruplaha/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adityaruplaha/citra","description":"A Nintendo 3DS Emulator","fork":true,"url":"https://api.github.com/repos/adityaruplaha/citra","forks_url":"https://api.github.com/repos/adityaruplaha/citra/forks","keys_url":"https://api.github.com/repos/adityaruplaha/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adityaruplaha/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adityaruplaha/citra/teams","hooks_url":"https://api.github.com/repos/adityaruplaha/citra/hooks","issue_events_url":"https://api.github.com/repos/adityaruplaha/citra/issues/events{/number}","events_url":"https://api.github.com/repos/adityaruplaha/citra/events","assignees_url":"https://api.github.com/repos/adityaruplaha/citra/assignees{/user}","branches_url":"https://api.github.com/repos/adityaruplaha/citra/branches{/branch}","tags_url":"https://api.github.com/repos/adityaruplaha/citra/tags","blobs_url":"https://api.github.com/repos/adityaruplaha/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adityaruplaha/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adityaruplaha/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/adityaruplaha/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adityaruplaha/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/adityaruplaha/citra/languages","stargazers_url":"https://api.github.com/repos/adityaruplaha/citra/stargazers","contributors_url":"https://api.github.com/repos/adityaruplaha/citra/contributors","subscribers_url":"https://api.github.com/repos/adityaruplaha/citra/subscribers","subscription_url":"https://api.github.com/repos/adityaruplaha/citra/subscription","commits_url":"https://api.github.com/repos/adityaruplaha/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/adityaruplaha/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/adityaruplaha/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/adityaruplaha/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/adityaruplaha/citra/contents/{+path}","compare_url":"https://api.github.com/repos/adityaruplaha/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adityaruplaha/citra/merges","archive_url":"https://api.github.com/repos/adityaruplaha/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adityaruplaha/citra/downloads","issues_url":"https://api.github.com/repos/adityaruplaha/citra/issues{/number}","pulls_url":"https://api.github.com/repos/adityaruplaha/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/adityaruplaha/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/adityaruplaha/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adityaruplaha/citra/labels{/name}","releases_url":"https://api.github.com/repos/adityaruplaha/citra/releases{/id}","deployments_url":"https://api.github.com/repos/adityaruplaha/citra/deployments","created_at":"2018-03-18T10:54:26Z","updated_at":"2018-11-17T08:58:57Z","pushed_at":"2018-12-05T13:43:36Z","git_url":"git://github.com/adityaruplaha/citra.git","ssh_url":"git@github.com:adityaruplaha/citra.git","clone_url":"https://github.com/adityaruplaha/citra.git","svn_url":"https://github.com/adityaruplaha/citra","homepage":"https://citra-emu.org","size":27474,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"cd80a0df8c9722bec37cf15c4fd0522385b8f6c0","user":{"login":"citra-emu","id":7605670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDU2NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/7605670?v=4","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg2NjczMA==","name":"citra","full_name":"citra-emu/citra","private":false,"owner":{"login":"citra-emu","id":7605670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDU2NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/7605670?v=4","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/citra-emu/citra","description":"A Nintendo 3DS Emulator","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","deployments_url":"https://api.github.com/repos/citra-emu/citra/deployments","created_at":"2014-05-16T18:33:15Z","updated_at":"2018-12-07T00:17:35Z","pushed_at":"2018-12-07T00:17:28Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":"https://citra-emu.org","size":51343,"stargazers_count":4497,"watchers_count":4497,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1003,"mirror_url":null,"archived":false,"open_issues_count":399,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1003,"open_issues":399,"watchers":4497,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/4437"},"html":{"href":"https://github.com/citra-emu/citra/pull/4437"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/4437"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/4437/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/4437/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/4437/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/c3803f4af9a4273dcdfdd436e78c7217cc2c10b6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zhaowenlan1779"}}