{"action":"closed","number":1090,"pull_request":{"url":"https://api.github.com/repos/apollographql/apollo-server/pulls/1090","id":190168842,"html_url":"https://github.com/apollographql/apollo-server/pull/1090","diff_url":"https://github.com/apollographql/apollo-server/pull/1090.diff","patch_url":"https://github.com/apollographql/apollo-server/pull/1090.patch","issue_url":"https://api.github.com/repos/apollographql/apollo-server/issues/1090","number":1090,"state":"closed","locked":false,"title":"apollo-server: remove extra configuration of registerServer from listen","user":{"login":"evans","id":5565407,"avatar_url":"https://avatars0.githubusercontent.com/u/5565407?v=4","gravatar_id":"","url":"https://api.github.com/users/evans","html_url":"https://github.com/evans","followers_url":"https://api.github.com/users/evans/followers","following_url":"https://api.github.com/users/evans/following{/other_user}","gists_url":"https://api.github.com/users/evans/gists{/gist_id}","starred_url":"https://api.github.com/users/evans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evans/subscriptions","organizations_url":"https://api.github.com/users/evans/orgs","repos_url":"https://api.github.com/users/evans/repos","events_url":"https://api.github.com/users/evans/events{/privacy}","received_events_url":"https://api.github.com/users/evans/received_events","type":"User","site_admin":false},"body":"This removes the healthcheck, body parser, and cors from the `listen` configurations in the default apollo-server. Since the `listen` interface is shared across all standalone node integrations, it was quite important to make the listen interface cleaner. The defaults are generous, with cors set to * and body parser limit to 50mb to allow large file uploads.\r\n\r\n<!--**Pull Request Labels**\r\n\r\nWhile not necessary, you can help organize our pull requests by labeling this issue when you open it.  To add a label automatically, simply [x] mark the appropriate box below:\r\n\r\n- [ ] feature\r\n- [ ] blocking\r\n- [ ] docs\r\n\r\nTo add a label not listed above, simply place `/label another-label-name` on a line by itself.\r\n-->","created_at":"2018-05-24T04:47:22Z","updated_at":"2018-05-24T04:52:48Z","closed_at":"2018-05-24T04:52:48Z","merged_at":"2018-05-24T04:52:48Z","merge_commit_sha":"5d109e9e37c6d992a83827bbc756035f54a35242","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/apollographql/apollo-server/milestones/3","html_url":"https://github.com/apollographql/apollo-server/milestone/3","labels_url":"https://api.github.com/repos/apollographql/apollo-server/milestones/3/labels","id":3303349,"number":3,"title":"Release 2.0","description":"","creator":{"login":"abernix","id":841294,"avatar_url":"https://avatars0.githubusercontent.com/u/841294?v=4","gravatar_id":"","url":"https://api.github.com/users/abernix","html_url":"https://github.com/abernix","followers_url":"https://api.github.com/users/abernix/followers","following_url":"https://api.github.com/users/abernix/following{/other_user}","gists_url":"https://api.github.com/users/abernix/gists{/gist_id}","starred_url":"https://api.github.com/users/abernix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abernix/subscriptions","organizations_url":"https://api.github.com/users/abernix/orgs","repos_url":"https://api.github.com/users/abernix/repos","events_url":"https://api.github.com/users/abernix/events{/privacy}","received_events_url":"https://api.github.com/users/abernix/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":23,"state":"open","created_at":"2018-04-27T05:30:43Z","updated_at":"2018-05-24T04:52:48Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/apollographql/apollo-server/pulls/1090/commits","review_comments_url":"https://api.github.com/repos/apollographql/apollo-server/pulls/1090/comments","review_comment_url":"https://api.github.com/repos/apollographql/apollo-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollographql/apollo-server/issues/1090/comments","statuses_url":"https://api.github.com/repos/apollographql/apollo-server/statuses/508fdf62af0d5e74981cf64ea707964c1b146001","head":{"label":"apollographql:server-2.0/simplify-default-listen","ref":"server-2.0/simplify-default-listen","sha":"508fdf62af0d5e74981cf64ea707964c1b146001","user":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":56760633,"name":"apollo-server","full_name":"apollographql/apollo-server","owner":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollographql/apollo-server","description":":earth_africa: GraphQL server for Express, Connect, Hapi, Koa and more","fork":false,"url":"https://api.github.com/repos/apollographql/apollo-server","forks_url":"https://api.github.com/repos/apollographql/apollo-server/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-server/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-server/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-server/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-server/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-server/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-server/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-server/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-server/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-server/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-server/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-server/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-server/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-server/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-server/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-server/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-server/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-server/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-server/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-server/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-server/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-server/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-server/deployments","created_at":"2016-04-21T09:26:01Z","updated_at":"2018-05-24T02:43:03Z","pushed_at":"2018-05-24T04:52:48Z","git_url":"git://github.com/apollographql/apollo-server.git","ssh_url":"git@github.com:apollographql/apollo-server.git","clone_url":"https://github.com/apollographql/apollo-server.git","svn_url":"https://github.com/apollographql/apollo-server","homepage":"https://www.apollographql.com/docs/apollo-server/","size":3070,"stargazers_count":3949,"watchers_count":3949,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":402,"mirror_url":null,"archived":false,"open_issues_count":123,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":402,"open_issues":123,"watchers":3949,"default_branch":"master"}},"base":{"label":"apollographql:refactor-2.0","ref":"refactor-2.0","sha":"45d3614f1e77ff25d1786df43425d75a233f15d7","user":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":56760633,"name":"apollo-server","full_name":"apollographql/apollo-server","owner":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollographql/apollo-server","description":":earth_africa: GraphQL server for Express, Connect, Hapi, Koa and more","fork":false,"url":"https://api.github.com/repos/apollographql/apollo-server","forks_url":"https://api.github.com/repos/apollographql/apollo-server/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-server/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-server/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-server/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-server/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-server/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-server/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-server/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-server/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-server/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-server/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-server/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-server/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-server/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-server/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-server/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-server/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-server/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-server/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-server/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-server/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-server/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-server/deployments","created_at":"2016-04-21T09:26:01Z","updated_at":"2018-05-24T02:43:03Z","pushed_at":"2018-05-24T04:52:48Z","git_url":"git://github.com/apollographql/apollo-server.git","ssh_url":"git@github.com:apollographql/apollo-server.git","clone_url":"https://github.com/apollographql/apollo-server.git","svn_url":"https://github.com/apollographql/apollo-server","homepage":"https://www.apollographql.com/docs/apollo-server/","size":3070,"stargazers_count":3949,"watchers_count":3949,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":402,"mirror_url":null,"archived":false,"open_issues_count":123,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":402,"open_issues":123,"watchers":3949,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-server/pulls/1090"},"html":{"href":"https://github.com/apollographql/apollo-server/pull/1090"},"issue":{"href":"https://api.github.com/repos/apollographql/apollo-server/issues/1090"},"comments":{"href":"https://api.github.com/repos/apollographql/apollo-server/issues/1090/comments"},"review_comments":{"href":"https://api.github.com/repos/apollographql/apollo-server/pulls/1090/comments"},"review_comment":{"href":"https://api.github.com/repos/apollographql/apollo-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollographql/apollo-server/pulls/1090/commits"},"statuses":{"href":"https://api.github.com/repos/apollographql/apollo-server/statuses/508fdf62af0d5e74981cf64ea707964c1b146001"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"evans","id":5565407,"avatar_url":"https://avatars0.githubusercontent.com/u/5565407?v=4","gravatar_id":"","url":"https://api.github.com/users/evans","html_url":"https://github.com/evans","followers_url":"https://api.github.com/users/evans/followers","following_url":"https://api.github.com/users/evans/following{/other_user}","gists_url":"https://api.github.com/users/evans/gists{/gist_id}","starred_url":"https://api.github.com/users/evans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evans/subscriptions","organizations_url":"https://api.github.com/users/evans/orgs","repos_url":"https://api.github.com/users/evans/repos","events_url":"https://api.github.com/users/evans/events{/privacy}","received_events_url":"https://api.github.com/users/evans/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":21,"changed_files":1}}
{"actor":{"display_login":"evans"}}