{"action":"created","comment":{"url":"https://api.github.com/repos/Rise-Vision/common-template/pulls/comments/229801011","pull_request_review_id":170387884,"id":229801011,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTgwMTAxMQ==","diff_hunk":"@@ -1,20 +1,33 @@\n version: 2.1\n \n jobs:\n-  build_and_test:\n+  install:\n     docker: &BUILDIMAGE\n       - image: jenkinsrise/cci-v2-components:0.0.4\n     steps:\n       - checkout\n+      - restore_cache:\n+          key: node-cache-{{ checksum \"package.json\" }}\n       - run: sudo npm install -g gulp\n       - run: npm install\n+      - save_cache:\n+          key: node-cache-{{ checksum \"package.json\" }}\n+          paths:\n+            - ./node_modules\n+\n+  build_and_test:","path":".circleci/config.yml","position":19,"original_position":19,"commit_id":"3e841af4878092ad1e463022bf422926de7069e3","original_commit_id":"3e841af4878092ad1e463022bf422926de7069e3","user":{"login":"stulees","id":7407007,"node_id":"MDQ6VXNlcjc0MDcwMDc=","avatar_url":"https://avatars3.githubusercontent.com/u/7407007?v=4","gravatar_id":"","url":"https://api.github.com/users/stulees","html_url":"https://github.com/stulees","followers_url":"https://api.github.com/users/stulees/followers","following_url":"https://api.github.com/users/stulees/following{/other_user}","gists_url":"https://api.github.com/users/stulees/gists{/gist_id}","starred_url":"https://api.github.com/users/stulees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stulees/subscriptions","organizations_url":"https://api.github.com/users/stulees/orgs","repos_url":"https://api.github.com/users/stulees/repos","events_url":"https://api.github.com/users/stulees/events{/privacy}","received_events_url":"https://api.github.com/users/stulees/received_events","type":"User","site_admin":false},"body":"@santiagonoguez Because PhantomJS isn't compatible with ES6, the unit tests have to test built `dist/` files instead of directly to their source. So the name _build_and_test_ reflects that process as defined in the gulp task _test_.  ","created_at":"2018-10-31T17:45:33Z","updated_at":"2018-10-31T17:45:34Z","html_url":"https://github.com/Rise-Vision/common-template/pull/18#discussion_r229801011","pull_request_url":"https://api.github.com/repos/Rise-Vision/common-template/pulls/18","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Rise-Vision/common-template/pulls/comments/229801011"},"html":{"href":"https://github.com/Rise-Vision/common-template/pull/18#discussion_r229801011"},"pull_request":{"href":"https://api.github.com/repos/Rise-Vision/common-template/pulls/18"}},"in_reply_to_id":229763227},"pull_request":{"url":"https://api.github.com/repos/Rise-Vision/common-template/pulls/18","id":227347951,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MzQ3OTUx","html_url":"https://github.com/Rise-Vision/common-template/pull/18","diff_url":"https://github.com/Rise-Vision/common-template/pull/18.diff","patch_url":"https://github.com/Rise-Vision/common-template/pull/18.patch","issue_url":"https://api.github.com/repos/Rise-Vision/common-template/issues/18","number":18,"state":"open","locked":false,"title":"Consolidating template scripts and deploying to stage","user":{"login":"stulees","id":7407007,"node_id":"MDQ6VXNlcjc0MDcwMDc=","avatar_url":"https://avatars3.githubusercontent.com/u/7407007?v=4","gravatar_id":"","url":"https://api.github.com/users/stulees","html_url":"https://github.com/stulees","followers_url":"https://api.github.com/users/stulees/followers","following_url":"https://api.github.com/users/stulees/following{/other_user}","gists_url":"https://api.github.com/users/stulees/gists{/gist_id}","starred_url":"https://api.github.com/users/stulees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stulees/subscriptions","organizations_url":"https://api.github.com/users/stulees/orgs","repos_url":"https://api.github.com/users/stulees/repos","events_url":"https://api.github.com/users/stulees/events{/privacy}","received_events_url":"https://api.github.com/users/stulees/received_events","type":"User","site_admin":false},"body":"- Consolidating all template common scripts to a minified and unminified _common-template.js_ file\r\n- Config files remain separate files from _common-template.js_\r\n- Adding a `deploy-stage` job to CCI build so we can manually test with staged versions.\r\n\r\nManually validated _common-template.js_ and _config-test.js_ are working as expected in the financial data component demo. Used the staged version of those files from https://circleci.com/workflow-run/6b063356-aefa-494a-b44c-87ae35a2b380 build. ","created_at":"2018-10-31T16:07:00Z","updated_at":"2018-10-31T17:45:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7b6ee77f3c3e48a424ff8da2d8841de89be5a03","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Rise-Vision/common-template/pulls/18/commits","review_comments_url":"https://api.github.com/repos/Rise-Vision/common-template/pulls/18/comments","review_comment_url":"https://api.github.com/repos/Rise-Vision/common-template/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Rise-Vision/common-template/issues/18/comments","statuses_url":"https://api.github.com/repos/Rise-Vision/common-template/statuses/3e841af4878092ad1e463022bf422926de7069e3","head":{"label":"Rise-Vision:staging/consolidate-scripts","ref":"staging/consolidate-scripts","sha":"3e841af4878092ad1e463022bf422926de7069e3","user":{"login":"Rise-Vision","id":6840223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDAyMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6840223?v=4","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"repo":{"id":150109433,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxMDk0MzM=","name":"common-template","full_name":"Rise-Vision/common-template","private":false,"owner":{"login":"Rise-Vision","id":6840223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDAyMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6840223?v=4","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Rise-Vision/common-template","description":"Common scripts for Rise Templates","fork":false,"url":"https://api.github.com/repos/Rise-Vision/common-template","forks_url":"https://api.github.com/repos/Rise-Vision/common-template/forks","keys_url":"https://api.github.com/repos/Rise-Vision/common-template/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rise-Vision/common-template/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rise-Vision/common-template/teams","hooks_url":"https://api.github.com/repos/Rise-Vision/common-template/hooks","issue_events_url":"https://api.github.com/repos/Rise-Vision/common-template/issues/events{/number}","events_url":"https://api.github.com/repos/Rise-Vision/common-template/events","assignees_url":"https://api.github.com/repos/Rise-Vision/common-template/assignees{/user}","branches_url":"https://api.github.com/repos/Rise-Vision/common-template/branches{/branch}","tags_url":"https://api.github.com/repos/Rise-Vision/common-template/tags","blobs_url":"https://api.github.com/repos/Rise-Vision/common-template/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rise-Vision/common-template/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rise-Vision/common-template/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rise-Vision/common-template/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rise-Vision/common-template/statuses/{sha}","languages_url":"https://api.github.com/repos/Rise-Vision/common-template/languages","stargazers_url":"https://api.github.com/repos/Rise-Vision/common-template/stargazers","contributors_url":"https://api.github.com/repos/Rise-Vision/common-template/contributors","subscribers_url":"https://api.github.com/repos/Rise-Vision/common-template/subscribers","subscription_url":"https://api.github.com/repos/Rise-Vision/common-template/subscription","commits_url":"https://api.github.com/repos/Rise-Vision/common-template/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rise-Vision/common-template/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rise-Vision/common-template/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rise-Vision/common-template/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rise-Vision/common-template/contents/{+path}","compare_url":"https://api.github.com/repos/Rise-Vision/common-template/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rise-Vision/common-template/merges","archive_url":"https://api.github.com/repos/Rise-Vision/common-template/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rise-Vision/common-template/downloads","issues_url":"https://api.github.com/repos/Rise-Vision/common-template/issues{/number}","pulls_url":"https://api.github.com/repos/Rise-Vision/common-template/pulls{/number}","milestones_url":"https://api.github.com/repos/Rise-Vision/common-template/milestones{/number}","notifications_url":"https://api.github.com/repos/Rise-Vision/common-template/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rise-Vision/common-template/labels{/name}","releases_url":"https://api.github.com/repos/Rise-Vision/common-template/releases{/id}","deployments_url":"https://api.github.com/repos/Rise-Vision/common-template/deployments","created_at":"2018-09-24T13:47:01Z","updated_at":"2018-10-30T14:55:55Z","pushed_at":"2018-10-31T17:20:45Z","git_url":"git://github.com/Rise-Vision/common-template.git","ssh_url":"git@github.com:Rise-Vision/common-template.git","clone_url":"https://github.com/Rise-Vision/common-template.git","svn_url":"https://github.com/Rise-Vision/common-template","homepage":null,"size":223,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Rise-Vision:master","ref":"master","sha":"f08fc10833670bd770ab1d2246da3e95dd9dd0e6","user":{"login":"Rise-Vision","id":6840223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDAyMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6840223?v=4","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"repo":{"id":150109433,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxMDk0MzM=","name":"common-template","full_name":"Rise-Vision/common-template","private":false,"owner":{"login":"Rise-Vision","id":6840223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDAyMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6840223?v=4","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Rise-Vision/common-template","description":"Common scripts for Rise Templates","fork":false,"url":"https://api.github.com/repos/Rise-Vision/common-template","forks_url":"https://api.github.com/repos/Rise-Vision/common-template/forks","keys_url":"https://api.github.com/repos/Rise-Vision/common-template/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rise-Vision/common-template/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rise-Vision/common-template/teams","hooks_url":"https://api.github.com/repos/Rise-Vision/common-template/hooks","issue_events_url":"https://api.github.com/repos/Rise-Vision/common-template/issues/events{/number}","events_url":"https://api.github.com/repos/Rise-Vision/common-template/events","assignees_url":"https://api.github.com/repos/Rise-Vision/common-template/assignees{/user}","branches_url":"https://api.github.com/repos/Rise-Vision/common-template/branches{/branch}","tags_url":"https://api.github.com/repos/Rise-Vision/common-template/tags","blobs_url":"https://api.github.com/repos/Rise-Vision/common-template/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rise-Vision/common-template/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rise-Vision/common-template/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rise-Vision/common-template/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rise-Vision/common-template/statuses/{sha}","languages_url":"https://api.github.com/repos/Rise-Vision/common-template/languages","stargazers_url":"https://api.github.com/repos/Rise-Vision/common-template/stargazers","contributors_url":"https://api.github.com/repos/Rise-Vision/common-template/contributors","subscribers_url":"https://api.github.com/repos/Rise-Vision/common-template/subscribers","subscription_url":"https://api.github.com/repos/Rise-Vision/common-template/subscription","commits_url":"https://api.github.com/repos/Rise-Vision/common-template/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rise-Vision/common-template/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rise-Vision/common-template/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rise-Vision/common-template/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rise-Vision/common-template/contents/{+path}","compare_url":"https://api.github.com/repos/Rise-Vision/common-template/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rise-Vision/common-template/merges","archive_url":"https://api.github.com/repos/Rise-Vision/common-template/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rise-Vision/common-template/downloads","issues_url":"https://api.github.com/repos/Rise-Vision/common-template/issues{/number}","pulls_url":"https://api.github.com/repos/Rise-Vision/common-template/pulls{/number}","milestones_url":"https://api.github.com/repos/Rise-Vision/common-template/milestones{/number}","notifications_url":"https://api.github.com/repos/Rise-Vision/common-template/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rise-Vision/common-template/labels{/name}","releases_url":"https://api.github.com/repos/Rise-Vision/common-template/releases{/id}","deployments_url":"https://api.github.com/repos/Rise-Vision/common-template/deployments","created_at":"2018-09-24T13:47:01Z","updated_at":"2018-10-30T14:55:55Z","pushed_at":"2018-10-31T17:20:45Z","git_url":"git://github.com/Rise-Vision/common-template.git","ssh_url":"git@github.com:Rise-Vision/common-template.git","clone_url":"https://github.com/Rise-Vision/common-template.git","svn_url":"https://github.com/Rise-Vision/common-template","homepage":null,"size":223,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Rise-Vision/common-template/pulls/18"},"html":{"href":"https://github.com/Rise-Vision/common-template/pull/18"},"issue":{"href":"https://api.github.com/repos/Rise-Vision/common-template/issues/18"},"comments":{"href":"https://api.github.com/repos/Rise-Vision/common-template/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/Rise-Vision/common-template/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/Rise-Vision/common-template/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Rise-Vision/common-template/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/Rise-Vision/common-template/statuses/3e841af4878092ad1e463022bf422926de7069e3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stulees"}}