{"action":"created","comment":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/218715323","pull_request_review_id":156710895,"id":218715323,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODcxNTMyMw==","diff_hunk":"@@ -300,5 +300,12 @@ module.exports = {\n         created_by: {type: 'string', maxlength: 24, nullable: false},\n         updated_at: {type: 'dateTime', nullable: true},\n         updated_by: {type: 'string', maxlength: 24, nullable: true}\n+    },\n+    sessions: {\n+        id: {type: 'string', maxlength: 32, nullable: false, primary: true},\n+        user_id: {type: 'string', maxlength: 24, nullable: false},\n+        session_data: {type: 'text', maxlength: 2000, nullable: false},","path":"core/server/data/schema/schema.js","position":8,"original_position":8,"commit_id":"b846894343d9a88bb3ca1f56502549fabf90e533","original_commit_id":"b846894343d9a88bb3ca1f56502549fabf90e533","user":{"login":"allouis","id":3218915,"node_id":"MDQ6VXNlcjMyMTg5MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3218915?v=4","gravatar_id":"","url":"https://api.github.com/users/allouis","html_url":"https://github.com/allouis","followers_url":"https://api.github.com/users/allouis/followers","following_url":"https://api.github.com/users/allouis/following{/other_user}","gists_url":"https://api.github.com/users/allouis/gists{/gist_id}","starred_url":"https://api.github.com/users/allouis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allouis/subscriptions","organizations_url":"https://api.github.com/users/allouis/orgs","repos_url":"https://api.github.com/users/allouis/repos","events_url":"https://api.github.com/users/allouis/events{/privacy}","received_events_url":"https://api.github.com/users/allouis/received_events","type":"User","site_admin":false},"body":"Because the `json` type defaults to `text` when not inside of postgres, so i stuck with that.","created_at":"2018-09-19T08:38:00Z","updated_at":"2018-09-19T08:38:00Z","html_url":"https://github.com/TryGhost/Ghost/pull/9867#discussion_r218715323","pull_request_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/9867","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/218715323"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/9867#discussion_r218715323"},"pull_request":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/9867"}},"in_reply_to_id":218711805},"pull_request":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/9867","id":215209363,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MjA5MzYz","html_url":"https://github.com/TryGhost/Ghost/pull/9867","diff_url":"https://github.com/TryGhost/Ghost/pull/9867.diff","patch_url":"https://github.com/TryGhost/Ghost/pull/9867.patch","issue_url":"https://api.github.com/repos/TryGhost/Ghost/issues/9867","number":9867,"state":"open","locked":false,"title":"Session based auth ","user":{"login":"allouis","id":3218915,"node_id":"MDQ6VXNlcjMyMTg5MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3218915?v=4","gravatar_id":"","url":"https://api.github.com/users/allouis","html_url":"https://github.com/allouis","followers_url":"https://api.github.com/users/allouis/followers","following_url":"https://api.github.com/users/allouis/following{/other_user}","gists_url":"https://api.github.com/users/allouis/gists{/gist_id}","starred_url":"https://api.github.com/users/allouis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allouis/subscriptions","organizations_url":"https://api.github.com/users/allouis/orgs","repos_url":"https://api.github.com/users/allouis/repos","events_url":"https://api.github.com/users/allouis/events{/privacy}","received_events_url":"https://api.github.com/users/allouis/received_events","type":"User","site_admin":false},"body":"This is the session side of #9865 \r\n\r\nThis adds a \"session auth\" service, which exposes some middleware to be used by the admin api.\r\n - `getSession` - populates `req.session`\r\n - `cookieCsrfProtection` - makes sure request is made from same origin session was created\r\n - `safeGetSession` - the above two mixed together\r\n - `getUser` - populates `req.user` based on `req.session.user_id`\r\n - `ensureUser` - responds with 401 if the user is missing\r\n - `createSession` - accepts user credentials and creates a user session (login)\r\n - `destroySession` - deletes the current session (logout)\r\n","created_at":"2018-09-13T08:54:16Z","updated_at":"2018-09-19T08:38:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c260bfb5960023313bd2538eda3648bda6f591e","assignee":{"login":"kevinansfield","id":415,"node_id":"MDQ6VXNlcjQxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/415?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinansfield","html_url":"https://github.com/kevinansfield","followers_url":"https://api.github.com/users/kevinansfield/followers","following_url":"https://api.github.com/users/kevinansfield/following{/other_user}","gists_url":"https://api.github.com/users/kevinansfield/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinansfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinansfield/subscriptions","organizations_url":"https://api.github.com/users/kevinansfield/orgs","repos_url":"https://api.github.com/users/kevinansfield/repos","events_url":"https://api.github.com/users/kevinansfield/events{/privacy}","received_events_url":"https://api.github.com/users/kevinansfield/received_events","type":"User","site_admin":false},"assignees":[{"login":"kevinansfield","id":415,"node_id":"MDQ6VXNlcjQxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/415?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinansfield","html_url":"https://github.com/kevinansfield","followers_url":"https://api.github.com/users/kevinansfield/followers","following_url":"https://api.github.com/users/kevinansfield/following{/other_user}","gists_url":"https://api.github.com/users/kevinansfield/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinansfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinansfield/subscriptions","organizations_url":"https://api.github.com/users/kevinansfield/orgs","repos_url":"https://api.github.com/users/kevinansfield/repos","events_url":"https://api.github.com/users/kevinansfield/events{/privacy}","received_events_url":"https://api.github.com/users/kevinansfield/received_events","type":"User","site_admin":false},{"login":"kirrg001","id":1160712,"node_id":"MDQ6VXNlcjExNjA3MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1160712?v=4","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/9867/commits","review_comments_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/9867/comments","review_comment_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/issues/9867/comments","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/b846894343d9a88bb3ca1f56502549fabf90e533","head":{"label":"TryGhost:session-auth","ref":"session-auth","sha":"b846894343d9a88bb3ca1f56502549fabf90e533","user":{"login":"TryGhost","id":2178663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzg2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2178663?v=4","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":9852918,"node_id":"MDEwOlJlcG9zaXRvcnk5ODUyOTE4","name":"Ghost","full_name":"TryGhost/Ghost","private":false,"owner":{"login":"TryGhost","id":2178663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzg2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2178663?v=4","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TryGhost/Ghost","description":"The platform for professional publishers","fork":false,"url":"https://api.github.com/repos/TryGhost/Ghost","forks_url":"https://api.github.com/repos/TryGhost/Ghost/forks","keys_url":"https://api.github.com/repos/TryGhost/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/Ghost/teams","hooks_url":"https://api.github.com/repos/TryGhost/Ghost/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/Ghost/events","assignees_url":"https://api.github.com/repos/TryGhost/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/Ghost/tags","blobs_url":"https://api.github.com/repos/TryGhost/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/Ghost/languages","stargazers_url":"https://api.github.com/repos/TryGhost/Ghost/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/Ghost/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/Ghost/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/Ghost/subscription","commits_url":"https://api.github.com/repos/TryGhost/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/TryGhost/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/Ghost/merges","archive_url":"https://api.github.com/repos/TryGhost/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/Ghost/downloads","issues_url":"https://api.github.com/repos/TryGhost/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/Ghost/releases{/id}","deployments_url":"https://api.github.com/repos/TryGhost/Ghost/deployments","created_at":"2013-05-04T11:09:13Z","updated_at":"2018-09-19T06:31:58Z","pushed_at":"2018-09-19T08:05:52Z","git_url":"git://github.com/TryGhost/Ghost.git","ssh_url":"git@github.com:TryGhost/Ghost.git","clone_url":"https://github.com/TryGhost/Ghost.git","svn_url":"https://github.com/TryGhost/Ghost","homepage":"https://ghost.org","size":33163,"stargazers_count":27424,"watchers_count":27424,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5898,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5898,"open_issues":136,"watchers":27424,"default_branch":"master"}},"base":{"label":"TryGhost:master","ref":"master","sha":"0549c9f7d45597199365d65141bc0c17c4f2df4a","user":{"login":"TryGhost","id":2178663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzg2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2178663?v=4","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":9852918,"node_id":"MDEwOlJlcG9zaXRvcnk5ODUyOTE4","name":"Ghost","full_name":"TryGhost/Ghost","private":false,"owner":{"login":"TryGhost","id":2178663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzg2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2178663?v=4","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TryGhost/Ghost","description":"The platform for professional publishers","fork":false,"url":"https://api.github.com/repos/TryGhost/Ghost","forks_url":"https://api.github.com/repos/TryGhost/Ghost/forks","keys_url":"https://api.github.com/repos/TryGhost/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/Ghost/teams","hooks_url":"https://api.github.com/repos/TryGhost/Ghost/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/Ghost/events","assignees_url":"https://api.github.com/repos/TryGhost/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/Ghost/tags","blobs_url":"https://api.github.com/repos/TryGhost/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/Ghost/languages","stargazers_url":"https://api.github.com/repos/TryGhost/Ghost/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/Ghost/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/Ghost/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/Ghost/subscription","commits_url":"https://api.github.com/repos/TryGhost/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/TryGhost/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/Ghost/merges","archive_url":"https://api.github.com/repos/TryGhost/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/Ghost/downloads","issues_url":"https://api.github.com/repos/TryGhost/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/Ghost/releases{/id}","deployments_url":"https://api.github.com/repos/TryGhost/Ghost/deployments","created_at":"2013-05-04T11:09:13Z","updated_at":"2018-09-19T06:31:58Z","pushed_at":"2018-09-19T08:05:52Z","git_url":"git://github.com/TryGhost/Ghost.git","ssh_url":"git@github.com:TryGhost/Ghost.git","clone_url":"https://github.com/TryGhost/Ghost.git","svn_url":"https://github.com/TryGhost/Ghost","homepage":"https://ghost.org","size":33163,"stargazers_count":27424,"watchers_count":27424,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5898,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5898,"open_issues":136,"watchers":27424,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/9867"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/9867"},"issue":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/9867"},"comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/9867/comments"},"review_comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/9867/comments"},"review_comment":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/9867/commits"},"statuses":{"href":"https://api.github.com/repos/TryGhost/Ghost/statuses/b846894343d9a88bb3ca1f56502549fabf90e533"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"allouis"}}