{"action":"created","comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/244826309","pull_request_review_id":188793380,"id":244826309,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDgyNjMwOQ==","diff_hunk":"@@ -114,6 +114,42 @@ def test_fig_close(backend):\n     assert init_figs == Gcf.figs\n \n \n+@pytest.mark.backend('Qt5Agg')\n+def test_fig_close_ioff(qt_module):\n+    # Turn off interactive mode\n+    plt.ioff()\n+\n+    # Create a figure\n+    fig = plt.figure()\n+\n+    # Callback to exit event loop\n+    def QuitApp(event):\n+        from matplotlib.backends.backend_qt5 import qApp\n+        qApp.exit()\n+\n+    # Connect callback to drawing (requires no user interaction)\n+    fig.canvas.mpl_connect('draw_event', QuitApp)\n+\n+    # Save original SIGINT handler\n+    import signal\n+    original_signal = signal.getsignal(signal.SIGINT)\n+\n+    # Use our own SIGINT handler to be 100% sure this is working\n+    def CustomHandler(signum, frame):\n+        pass\n+\n+    signal.signal(signal.SIGINT, CustomHandler)\n+\n+    # Show window- fires callback and exits\n+    plt.show()","path":"lib/matplotlib/tests/test_backend_qt.py","position":null,"original_position":31,"commit_id":"30828964d36958ddecfd80cea5721e9e5d7aa289","original_commit_id":"745a4e9e20bdf4f76b83796aa4b1b8fe47086276","user":{"login":"joelfrederico","id":458871,"node_id":"MDQ6VXNlcjQ1ODg3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/458871?v=4","gravatar_id":"","url":"https://api.github.com/users/joelfrederico","html_url":"https://github.com/joelfrederico","followers_url":"https://api.github.com/users/joelfrederico/followers","following_url":"https://api.github.com/users/joelfrederico/following{/other_user}","gists_url":"https://api.github.com/users/joelfrederico/gists{/gist_id}","starred_url":"https://api.github.com/users/joelfrederico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelfrederico/subscriptions","organizations_url":"https://api.github.com/users/joelfrederico/orgs","repos_url":"https://api.github.com/users/joelfrederico/repos","events_url":"https://api.github.com/users/joelfrederico/events{/privacy}","received_events_url":"https://api.github.com/users/joelfrederico/received_events","type":"User","site_admin":false},"body":"Did this in the new commit","created_at":"2019-01-02T19:17:02Z","updated_at":"2019-01-02T19:17:02Z","html_url":"https://github.com/matplotlib/matplotlib/pull/13027#discussion_r244826309","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/13027","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/244826309"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/13027#discussion_r244826309"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/13027"}},"in_reply_to_id":244506513},"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/13027","id":240087601,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMDg3NjAx","html_url":"https://github.com/matplotlib/matplotlib/pull/13027","diff_url":"https://github.com/matplotlib/matplotlib/pull/13027.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/13027.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/13027","number":13027,"state":"open","locked":false,"title":"Qt5 reset signals after non-interactive plotting","user":{"login":"joelfrederico","id":458871,"node_id":"MDQ6VXNlcjQ1ODg3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/458871?v=4","gravatar_id":"","url":"https://api.github.com/users/joelfrederico","html_url":"https://github.com/joelfrederico","followers_url":"https://api.github.com/users/joelfrederico/followers","following_url":"https://api.github.com/users/joelfrederico/following{/other_user}","gists_url":"https://api.github.com/users/joelfrederico/gists{/gist_id}","starred_url":"https://api.github.com/users/joelfrederico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelfrederico/subscriptions","organizations_url":"https://api.github.com/users/joelfrederico/orgs","repos_url":"https://api.github.com/users/joelfrederico/repos","events_url":"https://api.github.com/users/joelfrederico/events{/privacy}","received_events_url":"https://api.github.com/users/joelfrederico/received_events","type":"User","site_admin":false},"body":"## PR Summary\r\n\r\nNon-interactive plots change the signal handler after they have been closed. They should reset it instead\r\n\r\n## PR Checklist\r\n\r\n- [x] Has Pytest style unit tests\r\n- [x] Code is [Flake 8](http://flake8.pycqa.org/en/latest/) compliant","created_at":"2018-12-20T08:26:50Z","updated_at":"2019-01-02T19:17:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3defaeac5fedcfe913af147086361f01c8d21a9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":151678814,"node_id":"MDU6TGFiZWwxNTE2Nzg4MTQ=","url":"https://api.github.com/repos/matplotlib/matplotlib/labels/GUI/Qt","name":"GUI/Qt","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/35","html_url":"https://github.com/matplotlib/matplotlib/milestone/35","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/35/labels","id":3382328,"node_id":"MDk6TWlsZXN0b25lMzM4MjMyOA==","number":35,"title":"v3.1","description":"","creator":{"login":"tacaswell","id":199813,"node_id":"MDQ6VXNlcjE5OTgxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/199813?v=4","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":307,"closed_issues":376,"state":"open","created_at":"2018-05-29T02:12:40Z","updated_at":"2019-01-02T18:18:05Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/13027/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/13027/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/13027/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/30828964d36958ddecfd80cea5721e9e5d7aa289","head":{"label":"joelfrederico:qt5-reset-signals","ref":"qt5-reset-signals","sha":"30828964d36958ddecfd80cea5721e9e5d7aa289","user":{"login":"joelfrederico","id":458871,"node_id":"MDQ6VXNlcjQ1ODg3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/458871?v=4","gravatar_id":"","url":"https://api.github.com/users/joelfrederico","html_url":"https://github.com/joelfrederico","followers_url":"https://api.github.com/users/joelfrederico/followers","following_url":"https://api.github.com/users/joelfrederico/following{/other_user}","gists_url":"https://api.github.com/users/joelfrederico/gists{/gist_id}","starred_url":"https://api.github.com/users/joelfrederico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelfrederico/subscriptions","organizations_url":"https://api.github.com/users/joelfrederico/orgs","repos_url":"https://api.github.com/users/joelfrederico/repos","events_url":"https://api.github.com/users/joelfrederico/events{/privacy}","received_events_url":"https://api.github.com/users/joelfrederico/received_events","type":"User","site_admin":false},"repo":{"id":162543432,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI1NDM0MzI=","name":"matplotlib","full_name":"joelfrederico/matplotlib","private":false,"owner":{"login":"joelfrederico","id":458871,"node_id":"MDQ6VXNlcjQ1ODg3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/458871?v=4","gravatar_id":"","url":"https://api.github.com/users/joelfrederico","html_url":"https://github.com/joelfrederico","followers_url":"https://api.github.com/users/joelfrederico/followers","following_url":"https://api.github.com/users/joelfrederico/following{/other_user}","gists_url":"https://api.github.com/users/joelfrederico/gists{/gist_id}","starred_url":"https://api.github.com/users/joelfrederico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelfrederico/subscriptions","organizations_url":"https://api.github.com/users/joelfrederico/orgs","repos_url":"https://api.github.com/users/joelfrederico/repos","events_url":"https://api.github.com/users/joelfrederico/events{/privacy}","received_events_url":"https://api.github.com/users/joelfrederico/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joelfrederico/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/joelfrederico/matplotlib","forks_url":"https://api.github.com/repos/joelfrederico/matplotlib/forks","keys_url":"https://api.github.com/repos/joelfrederico/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joelfrederico/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joelfrederico/matplotlib/teams","hooks_url":"https://api.github.com/repos/joelfrederico/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/joelfrederico/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/joelfrederico/matplotlib/events","assignees_url":"https://api.github.com/repos/joelfrederico/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/joelfrederico/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/joelfrederico/matplotlib/tags","blobs_url":"https://api.github.com/repos/joelfrederico/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joelfrederico/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joelfrederico/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/joelfrederico/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joelfrederico/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/joelfrederico/matplotlib/languages","stargazers_url":"https://api.github.com/repos/joelfrederico/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/joelfrederico/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/joelfrederico/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/joelfrederico/matplotlib/subscription","commits_url":"https://api.github.com/repos/joelfrederico/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/joelfrederico/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/joelfrederico/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/joelfrederico/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/joelfrederico/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/joelfrederico/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joelfrederico/matplotlib/merges","archive_url":"https://api.github.com/repos/joelfrederico/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joelfrederico/matplotlib/downloads","issues_url":"https://api.github.com/repos/joelfrederico/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/joelfrederico/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/joelfrederico/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/joelfrederico/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joelfrederico/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/joelfrederico/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/joelfrederico/matplotlib/deployments","created_at":"2018-12-20T07:35:27Z","updated_at":"2018-12-20T07:35:35Z","pushed_at":"2019-01-02T19:16:17Z","git_url":"git://github.com/joelfrederico/matplotlib.git","ssh_url":"git@github.com:joelfrederico/matplotlib.git","clone_url":"https://github.com/joelfrederico/matplotlib.git","svn_url":"https://github.com/joelfrederico/matplotlib","homepage":"http://matplotlib.org/","size":339781,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matplotlib:master","ref":"master","sha":"083fefed670f319dd6ca927497cbb307c0b9df8c","user":{"login":"matplotlib","id":215947,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNTk0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg1MTIy","name":"matplotlib","full_name":"matplotlib/matplotlib","private":false,"owner":{"login":"matplotlib","id":215947,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNTk0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/matplotlib/matplotlib/deployments","created_at":"2011-02-19T03:17:12Z","updated_at":"2019-01-02T17:42:26Z","pushed_at":"2019-01-02T19:16:19Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":340042,"stargazers_count":8449,"watchers_count":8449,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3881,"mirror_url":null,"archived":false,"open_issues_count":1486,"license":null,"forks":3881,"open_issues":1486,"watchers":8449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/13027"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/13027"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/13027"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/13027/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/13027/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/13027/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/30828964d36958ddecfd80cea5721e9e5d7aa289"}},"author_association":"NONE"}}
{"actor":{"display_login":"joelfrederico"}}