{"action":"created","comment":{"url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/comments/240242451","pull_request_review_id":183225803,"id":240242451,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDI0MjQ1MQ==","diff_hunk":"@@ -392,6 +392,13 @@ ELSE(CMAKE_TOOLCHAIN_FILE)\n   # Check that a C++ 14 standard library is configured\n   include(CMake/TestCxx14Library.cmake)\n \n+  #------------------------------\n+  #  check Intel compiler version\n+  #------------------------------\n+  if ((${COMPILER} MATCHES \"Intel\") AND (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 18.0))","path":"CMakeLists.txt","position":7,"original_position":7,"commit_id":"3eb8e7173fd0b6077688ecdd54ef5258cf56242f","original_commit_id":"3eb8e7173fd0b6077688ecdd54ef5258cf56242f","user":{"login":"prckent","id":13683814,"node_id":"MDQ6VXNlcjEzNjgzODE0","avatar_url":"https://avatars0.githubusercontent.com/u/13683814?v=4","gravatar_id":"","url":"https://api.github.com/users/prckent","html_url":"https://github.com/prckent","followers_url":"https://api.github.com/users/prckent/followers","following_url":"https://api.github.com/users/prckent/following{/other_user}","gists_url":"https://api.github.com/users/prckent/gists{/gist_id}","starred_url":"https://api.github.com/users/prckent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prckent/subscriptions","organizations_url":"https://api.github.com/users/prckent/orgs","repos_url":"https://api.github.com/users/prckent/repos","events_url":"https://api.github.com/users/prckent/events{/privacy}","received_events_url":"https://api.github.com/users/prckent/received_events","type":"User","site_admin":false},"body":"Agreed.\r\n\r\nThe only reason to name specific compiler versions should be if we know they are problematically buggy.\r\n","created_at":"2018-12-10T14:58:08Z","updated_at":"2018-12-10T14:58:09Z","html_url":"https://github.com/QMCPACK/qmcpack/pull/1235#discussion_r240242451","pull_request_url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1235","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/comments/240242451"},"html":{"href":"https://github.com/QMCPACK/qmcpack/pull/1235#discussion_r240242451"},"pull_request":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1235"}},"in_reply_to_id":240215888},"pull_request":{"url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1235","id":237206629,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MjA2NjI5","html_url":"https://github.com/QMCPACK/qmcpack/pull/1235","diff_url":"https://github.com/QMCPACK/qmcpack/pull/1235.diff","patch_url":"https://github.com/QMCPACK/qmcpack/pull/1235.patch","issue_url":"https://api.github.com/repos/QMCPACK/qmcpack/issues/1235","number":1235,"state":"open","locked":false,"title":"Use MPI3 wrapper","user":{"login":"markdewing","id":266185,"node_id":"MDQ6VXNlcjI2NjE4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/266185?v=4","gravatar_id":"","url":"https://api.github.com/users/markdewing","html_url":"https://github.com/markdewing","followers_url":"https://api.github.com/users/markdewing/followers","following_url":"https://api.github.com/users/markdewing/following{/other_user}","gists_url":"https://api.github.com/users/markdewing/gists{/gist_id}","starred_url":"https://api.github.com/users/markdewing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdewing/subscriptions","organizations_url":"https://api.github.com/users/markdewing/orgs","repos_url":"https://api.github.com/users/markdewing/repos","events_url":"https://api.github.com/users/markdewing/events{/privacy}","received_events_url":"https://api.github.com/users/markdewing/received_events","type":"User","site_admin":false},"body":"Includes some updates from the mpi3 wrapper repo that are needed to compile, especially with gcc 5.3 on Rhea.   Also need load the boost module on Rhea to get a newer boost (1.58)\r\n\r\nThis PR puts the new mpi3 wrapper in charge of initializing MPI, and the old OOMPI wrappers are initialized from that by passing an MPI communicator.\r\n\r\nA check is on the Intel compiler version is added and the manual updated.\r\n","created_at":"2018-12-10T06:01:29Z","updated_at":"2018-12-10T14:58:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd8ba0cb74ff2b64e6b12e80a300f22de8904634","assignee":{"login":"markdewing","id":266185,"node_id":"MDQ6VXNlcjI2NjE4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/266185?v=4","gravatar_id":"","url":"https://api.github.com/users/markdewing","html_url":"https://github.com/markdewing","followers_url":"https://api.github.com/users/markdewing/followers","following_url":"https://api.github.com/users/markdewing/following{/other_user}","gists_url":"https://api.github.com/users/markdewing/gists{/gist_id}","starred_url":"https://api.github.com/users/markdewing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdewing/subscriptions","organizations_url":"https://api.github.com/users/markdewing/orgs","repos_url":"https://api.github.com/users/markdewing/repos","events_url":"https://api.github.com/users/markdewing/events{/privacy}","received_events_url":"https://api.github.com/users/markdewing/received_events","type":"User","site_admin":false},"assignees":[{"login":"markdewing","id":266185,"node_id":"MDQ6VXNlcjI2NjE4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/266185?v=4","gravatar_id":"","url":"https://api.github.com/users/markdewing","html_url":"https://github.com/markdewing","followers_url":"https://api.github.com/users/markdewing/followers","following_url":"https://api.github.com/users/markdewing/following{/other_user}","gists_url":"https://api.github.com/users/markdewing/gists{/gist_id}","starred_url":"https://api.github.com/users/markdewing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdewing/subscriptions","organizations_url":"https://api.github.com/users/markdewing/orgs","repos_url":"https://api.github.com/users/markdewing/repos","events_url":"https://api.github.com/users/markdewing/events{/privacy}","received_events_url":"https://api.github.com/users/markdewing/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":728832643,"node_id":"MDU6TGFiZWw3Mjg4MzI2NDM=","url":"https://api.github.com/repos/QMCPACK/qmcpack/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1235/commits","review_comments_url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1235/comments","review_comment_url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QMCPACK/qmcpack/issues/1235/comments","statuses_url":"https://api.github.com/repos/QMCPACK/qmcpack/statuses/3eb8e7173fd0b6077688ecdd54ef5258cf56242f","head":{"label":"markdewing:use_mpi_wrapper_with_wrapper_updates","ref":"use_mpi_wrapper_with_wrapper_updates","sha":"3eb8e7173fd0b6077688ecdd54ef5258cf56242f","user":{"login":"markdewing","id":266185,"node_id":"MDQ6VXNlcjI2NjE4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/266185?v=4","gravatar_id":"","url":"https://api.github.com/users/markdewing","html_url":"https://github.com/markdewing","followers_url":"https://api.github.com/users/markdewing/followers","following_url":"https://api.github.com/users/markdewing/following{/other_user}","gists_url":"https://api.github.com/users/markdewing/gists{/gist_id}","starred_url":"https://api.github.com/users/markdewing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdewing/subscriptions","organizations_url":"https://api.github.com/users/markdewing/orgs","repos_url":"https://api.github.com/users/markdewing/repos","events_url":"https://api.github.com/users/markdewing/events{/privacy}","received_events_url":"https://api.github.com/users/markdewing/received_events","type":"User","site_admin":false},"repo":{"id":79161005,"node_id":"MDEwOlJlcG9zaXRvcnk3OTE2MTAwNQ==","name":"qmcpack","full_name":"markdewing/qmcpack","private":false,"owner":{"login":"markdewing","id":266185,"node_id":"MDQ6VXNlcjI2NjE4NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/266185?v=4","gravatar_id":"","url":"https://api.github.com/users/markdewing","html_url":"https://github.com/markdewing","followers_url":"https://api.github.com/users/markdewing/followers","following_url":"https://api.github.com/users/markdewing/following{/other_user}","gists_url":"https://api.github.com/users/markdewing/gists{/gist_id}","starred_url":"https://api.github.com/users/markdewing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdewing/subscriptions","organizations_url":"https://api.github.com/users/markdewing/orgs","repos_url":"https://api.github.com/users/markdewing/repos","events_url":"https://api.github.com/users/markdewing/events{/privacy}","received_events_url":"https://api.github.com/users/markdewing/received_events","type":"User","site_admin":false},"html_url":"https://github.com/markdewing/qmcpack","description":"Main repository for QMCPACK, an open-source production level many-body ab initio Quantum Monte Carlo code for computing the electronic structure of atoms, molecules, and solids.","fork":true,"url":"https://api.github.com/repos/markdewing/qmcpack","forks_url":"https://api.github.com/repos/markdewing/qmcpack/forks","keys_url":"https://api.github.com/repos/markdewing/qmcpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markdewing/qmcpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markdewing/qmcpack/teams","hooks_url":"https://api.github.com/repos/markdewing/qmcpack/hooks","issue_events_url":"https://api.github.com/repos/markdewing/qmcpack/issues/events{/number}","events_url":"https://api.github.com/repos/markdewing/qmcpack/events","assignees_url":"https://api.github.com/repos/markdewing/qmcpack/assignees{/user}","branches_url":"https://api.github.com/repos/markdewing/qmcpack/branches{/branch}","tags_url":"https://api.github.com/repos/markdewing/qmcpack/tags","blobs_url":"https://api.github.com/repos/markdewing/qmcpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markdewing/qmcpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markdewing/qmcpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/markdewing/qmcpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markdewing/qmcpack/statuses/{sha}","languages_url":"https://api.github.com/repos/markdewing/qmcpack/languages","stargazers_url":"https://api.github.com/repos/markdewing/qmcpack/stargazers","contributors_url":"https://api.github.com/repos/markdewing/qmcpack/contributors","subscribers_url":"https://api.github.com/repos/markdewing/qmcpack/subscribers","subscription_url":"https://api.github.com/repos/markdewing/qmcpack/subscription","commits_url":"https://api.github.com/repos/markdewing/qmcpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/markdewing/qmcpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/markdewing/qmcpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/markdewing/qmcpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/markdewing/qmcpack/contents/{+path}","compare_url":"https://api.github.com/repos/markdewing/qmcpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markdewing/qmcpack/merges","archive_url":"https://api.github.com/repos/markdewing/qmcpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markdewing/qmcpack/downloads","issues_url":"https://api.github.com/repos/markdewing/qmcpack/issues{/number}","pulls_url":"https://api.github.com/repos/markdewing/qmcpack/pulls{/number}","milestones_url":"https://api.github.com/repos/markdewing/qmcpack/milestones{/number}","notifications_url":"https://api.github.com/repos/markdewing/qmcpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markdewing/qmcpack/labels{/name}","releases_url":"https://api.github.com/repos/markdewing/qmcpack/releases{/id}","deployments_url":"https://api.github.com/repos/markdewing/qmcpack/deployments","created_at":"2017-01-16T21:26:29Z","updated_at":"2018-08-17T18:28:19Z","pushed_at":"2018-12-10T03:33:08Z","git_url":"git://github.com/markdewing/qmcpack.git","ssh_url":"git@github.com:markdewing/qmcpack.git","clone_url":"https://github.com/markdewing/qmcpack.git","svn_url":"https://github.com/markdewing/qmcpack","homepage":"http://www.qmcpack.org","size":174252,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"QMCPACK:develop","ref":"develop","sha":"c4193faa843d9a36702c1504b89c1abd4216137a","user":{"login":"QMCPACK","id":22754046,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzU0MDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/22754046?v=4","gravatar_id":"","url":"https://api.github.com/users/QMCPACK","html_url":"https://github.com/QMCPACK","followers_url":"https://api.github.com/users/QMCPACK/followers","following_url":"https://api.github.com/users/QMCPACK/following{/other_user}","gists_url":"https://api.github.com/users/QMCPACK/gists{/gist_id}","starred_url":"https://api.github.com/users/QMCPACK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QMCPACK/subscriptions","organizations_url":"https://api.github.com/users/QMCPACK/orgs","repos_url":"https://api.github.com/users/QMCPACK/repos","events_url":"https://api.github.com/users/QMCPACK/events{/privacy}","received_events_url":"https://api.github.com/users/QMCPACK/received_events","type":"Organization","site_admin":false},"repo":{"id":78669859,"node_id":"MDEwOlJlcG9zaXRvcnk3ODY2OTg1OQ==","name":"qmcpack","full_name":"QMCPACK/qmcpack","private":false,"owner":{"login":"QMCPACK","id":22754046,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzU0MDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/22754046?v=4","gravatar_id":"","url":"https://api.github.com/users/QMCPACK","html_url":"https://github.com/QMCPACK","followers_url":"https://api.github.com/users/QMCPACK/followers","following_url":"https://api.github.com/users/QMCPACK/following{/other_user}","gists_url":"https://api.github.com/users/QMCPACK/gists{/gist_id}","starred_url":"https://api.github.com/users/QMCPACK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QMCPACK/subscriptions","organizations_url":"https://api.github.com/users/QMCPACK/orgs","repos_url":"https://api.github.com/users/QMCPACK/repos","events_url":"https://api.github.com/users/QMCPACK/events{/privacy}","received_events_url":"https://api.github.com/users/QMCPACK/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/QMCPACK/qmcpack","description":"Main repository for QMCPACK, an open-source production level many-body ab initio Quantum Monte Carlo code for computing the electronic structure of atoms, molecules, and solids.","fork":false,"url":"https://api.github.com/repos/QMCPACK/qmcpack","forks_url":"https://api.github.com/repos/QMCPACK/qmcpack/forks","keys_url":"https://api.github.com/repos/QMCPACK/qmcpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QMCPACK/qmcpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QMCPACK/qmcpack/teams","hooks_url":"https://api.github.com/repos/QMCPACK/qmcpack/hooks","issue_events_url":"https://api.github.com/repos/QMCPACK/qmcpack/issues/events{/number}","events_url":"https://api.github.com/repos/QMCPACK/qmcpack/events","assignees_url":"https://api.github.com/repos/QMCPACK/qmcpack/assignees{/user}","branches_url":"https://api.github.com/repos/QMCPACK/qmcpack/branches{/branch}","tags_url":"https://api.github.com/repos/QMCPACK/qmcpack/tags","blobs_url":"https://api.github.com/repos/QMCPACK/qmcpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QMCPACK/qmcpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QMCPACK/qmcpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/QMCPACK/qmcpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QMCPACK/qmcpack/statuses/{sha}","languages_url":"https://api.github.com/repos/QMCPACK/qmcpack/languages","stargazers_url":"https://api.github.com/repos/QMCPACK/qmcpack/stargazers","contributors_url":"https://api.github.com/repos/QMCPACK/qmcpack/contributors","subscribers_url":"https://api.github.com/repos/QMCPACK/qmcpack/subscribers","subscription_url":"https://api.github.com/repos/QMCPACK/qmcpack/subscription","commits_url":"https://api.github.com/repos/QMCPACK/qmcpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/QMCPACK/qmcpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/QMCPACK/qmcpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/QMCPACK/qmcpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/QMCPACK/qmcpack/contents/{+path}","compare_url":"https://api.github.com/repos/QMCPACK/qmcpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QMCPACK/qmcpack/merges","archive_url":"https://api.github.com/repos/QMCPACK/qmcpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QMCPACK/qmcpack/downloads","issues_url":"https://api.github.com/repos/QMCPACK/qmcpack/issues{/number}","pulls_url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls{/number}","milestones_url":"https://api.github.com/repos/QMCPACK/qmcpack/milestones{/number}","notifications_url":"https://api.github.com/repos/QMCPACK/qmcpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QMCPACK/qmcpack/labels{/name}","releases_url":"https://api.github.com/repos/QMCPACK/qmcpack/releases{/id}","deployments_url":"https://api.github.com/repos/QMCPACK/qmcpack/deployments","created_at":"2017-01-11T19:02:29Z","updated_at":"2018-12-09T00:18:21Z","pushed_at":"2018-12-10T06:01:30Z","git_url":"git://github.com/QMCPACK/qmcpack.git","ssh_url":"git@github.com:QMCPACK/qmcpack.git","clone_url":"https://github.com/QMCPACK/qmcpack.git","svn_url":"https://github.com/QMCPACK/qmcpack","homepage":"http://www.qmcpack.org","size":173341,"stargazers_count":71,"watchers_count":71,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":199,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":52,"open_issues":199,"watchers":71,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1235"},"html":{"href":"https://github.com/QMCPACK/qmcpack/pull/1235"},"issue":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/issues/1235"},"comments":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/issues/1235/comments"},"review_comments":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1235/comments"},"review_comment":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1235/commits"},"statuses":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/statuses/3eb8e7173fd0b6077688ecdd54ef5258cf56242f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"prckent"}}