{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59753","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59753/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59753/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59753/events","html_url":"https://github.com/kubernetes/kubernetes/pull/59753","id":296370065,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY4NTc1MDAw","number":59753,"title":"Make kubeadm config imageRepository can implement coredns","user":{"login":"nashasha1","id":9858380,"node_id":"MDQ6VXNlcjk4NTgzODA=","avatar_url":"https://avatars0.githubusercontent.com/u/9858380?v=4","gravatar_id":"","url":"https://api.github.com/users/nashasha1","html_url":"https://github.com/nashasha1","followers_url":"https://api.github.com/users/nashasha1/followers","following_url":"https://api.github.com/users/nashasha1/following{/other_user}","gists_url":"https://api.github.com/users/nashasha1/gists{/gist_id}","starred_url":"https://api.github.com/users/nashasha1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashasha1/subscriptions","organizations_url":"https://api.github.com/users/nashasha1/orgs","repos_url":"https://api.github.com/users/nashasha1/repos","events_url":"https://api.github.com/users/nashasha1/events{/privacy}","received_events_url":"https://api.github.com/users/nashasha1/received_events","type":"User","site_admin":false},"labels":[{"id":451459590,"node_id":"MDU6TGFiZWw0NTE0NTk1OTA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubeadm","name":"area/kubeadm","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173494222,"node_id":"MDU6TGFiZWwxNzM0OTQyMjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":614023989,"node_id":"MDU6TGFiZWw2MTQwMjM5ODk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/release","name":"sig/release","color":"d2b48c","default":false},{"id":253450895,"node_id":"MDU6TGFiZWwyNTM0NTA4OTU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"timothysc","id":169553,"node_id":"MDQ6VXNlcjE2OTU1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"assignees":[{"login":"timothysc","id":169553,"node_id":"MDQ6VXNlcjE2OTU1Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":20,"created_at":"2018-02-12T13:11:51Z","updated_at":"2018-06-04T22:06:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59753","html_url":"https://github.com/kubernetes/kubernetes/pull/59753","diff_url":"https://github.com/kubernetes/kubernetes/pull/59753.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/59753.patch"},"body":"**What this PR does / why we need it**:\r\nThis PR make the kubeadm's config `imageRepository` can implement on `coredns`.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\nI know coredns images configuration for the Deployment are using index.docker.io as a registry, and I think we should support overwriting the registry just like other repositories. There are occasions or places where access to grc.io or index.docker.io registry is restricted, therefore there should be a way to set a mirror as a fallback. The only downside from this implementation would be to add an external process to sync coredns images to the default registry. I am aware that this could add complexity to the process, and I am open to discuss further a solution to this problem, including changing this pull-request to satisfy both needs.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\n      Kubeadm's coredns deployment configuration using imageRepository just like other images\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/394515555","html_url":"https://github.com/kubernetes/kubernetes/pull/59753#issuecomment-394515555","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59753","id":394515555,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDUxNTU1NQ==","user":{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T22:06:46Z","updated_at":"2018-06-04T22:06:46Z","author_association":"MEMBER","body":"Images are pushed to k8s.gcr.io now"}}
{"actor":{"display_login":"thockin"}}