{"action":"created","comment":{"url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/pulls/comments/202535607","pull_request_review_id":137259036,"id":202535607,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjUzNTYwNw==","diff_hunk":"@@ -117,6 +120,7 @@ def actual_check(self) -> LintCheckResult:\n class CheckEnvInject(JobLinter):\n     \"\"\"Ensure that required environment variables are injected.\"\"\"\n \n+    short_code = 'L003'","path":"jenkins_job_linter/linters.py","position":28,"original_position":28,"commit_id":"8d1549dda40f6ab0e6ad366f9f2e3b217869895d","original_commit_id":"923ba69d6f439bbd783cac1c4d757f9535f619ba","user":{"login":"ardaguclu","id":11172207,"node_id":"MDQ6VXNlcjExMTcyMjA3","avatar_url":"https://avatars0.githubusercontent.com/u/11172207?v=4","gravatar_id":"","url":"https://api.github.com/users/ardaguclu","html_url":"https://github.com/ardaguclu","followers_url":"https://api.github.com/users/ardaguclu/followers","following_url":"https://api.github.com/users/ardaguclu/following{/other_user}","gists_url":"https://api.github.com/users/ardaguclu/gists{/gist_id}","starred_url":"https://api.github.com/users/ardaguclu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ardaguclu/subscriptions","organizations_url":"https://api.github.com/users/ardaguclu/orgs","repos_url":"https://api.github.com/users/ardaguclu/repos","events_url":"https://api.github.com/users/ardaguclu/events{/privacy}","received_events_url":"https://api.github.com/users/ardaguclu/received_events","type":"User","site_admin":false},"body":"short_code should be populated using enums and should not be assigning hard coded strings","created_at":"2018-07-15T08:44:14Z","updated_at":"2018-07-15T08:44:40Z","html_url":"https://github.com/CanonicalLtd/jenkins-job-linter-fit-halibut/pull/1#discussion_r202535607","pull_request_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/pulls/comments/202535607"},"html":{"href":"https://github.com/CanonicalLtd/jenkins-job-linter-fit-halibut/pull/1#discussion_r202535607"},"pull_request":{"href":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/pulls/1","id":196559811,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NTU5ODEx","html_url":"https://github.com/CanonicalLtd/jenkins-job-linter-fit-halibut/pull/1","diff_url":"https://github.com/CanonicalLtd/jenkins-job-linter-fit-halibut/pull/1.diff","patch_url":"https://github.com/CanonicalLtd/jenkins-job-linter-fit-halibut/pull/1.patch","issue_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/issues/1","number":1,"state":"open","locked":false,"title":"Introduce short-hand codes for checks","user":{"login":"philroche","id":247131,"node_id":"MDQ6VXNlcjI0NzEzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/247131?v=4","gravatar_id":"","url":"https://api.github.com/users/philroche","html_url":"https://github.com/philroche","followers_url":"https://api.github.com/users/philroche/followers","following_url":"https://api.github.com/users/philroche/following{/other_user}","gists_url":"https://api.github.com/users/philroche/gists{/gist_id}","starred_url":"https://api.github.com/users/philroche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philroche/subscriptions","organizations_url":"https://api.github.com/users/philroche/orgs","repos_url":"https://api.github.com/users/philroche/repos","events_url":"https://api.github.com/users/philroche/events{/privacy}","received_events_url":"https://api.github.com/users/philroche/received_events","type":"User","site_admin":false},"body":"Like other linting tools do, each check that a linter performs should have a separate, distinct short code (e.g. J123, L123) which can be used for easily referring to issues.","created_at":"2018-06-21T20:00:49Z","updated_at":"2018-07-15T08:44:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9eb869f2b98c0d4d7a891ceba02a81a8f327e66f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/pulls/1/commits","review_comments_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/pulls/1/comments","review_comment_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/issues/1/comments","statuses_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/statuses/8d1549dda40f6ab0e6ad366f9f2e3b217869895d","head":{"label":"philroche:feature/linter-short-codes","ref":"feature/linter-short-codes","sha":"8d1549dda40f6ab0e6ad366f9f2e3b217869895d","user":{"login":"philroche","id":247131,"node_id":"MDQ6VXNlcjI0NzEzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/247131?v=4","gravatar_id":"","url":"https://api.github.com/users/philroche","html_url":"https://github.com/philroche","followers_url":"https://api.github.com/users/philroche/followers","following_url":"https://api.github.com/users/philroche/following{/other_user}","gists_url":"https://api.github.com/users/philroche/gists{/gist_id}","starred_url":"https://api.github.com/users/philroche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philroche/subscriptions","organizations_url":"https://api.github.com/users/philroche/orgs","repos_url":"https://api.github.com/users/philroche/repos","events_url":"https://api.github.com/users/philroche/events{/privacy}","received_events_url":"https://api.github.com/users/philroche/received_events","type":"User","site_admin":false},"repo":{"id":138216050,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyMTYwNTA=","name":"jenkins-job-linter-fit-halibut","full_name":"philroche/jenkins-job-linter-fit-halibut","owner":{"login":"philroche","id":247131,"node_id":"MDQ6VXNlcjI0NzEzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/247131?v=4","gravatar_id":"","url":"https://api.github.com/users/philroche","html_url":"https://github.com/philroche","followers_url":"https://api.github.com/users/philroche/followers","following_url":"https://api.github.com/users/philroche/following{/other_user}","gists_url":"https://api.github.com/users/philroche/gists{/gist_id}","starred_url":"https://api.github.com/users/philroche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philroche/subscriptions","organizations_url":"https://api.github.com/users/philroche/orgs","repos_url":"https://api.github.com/users/philroche/repos","events_url":"https://api.github.com/users/philroche/events{/privacy}","received_events_url":"https://api.github.com/users/philroche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philroche/jenkins-job-linter-fit-halibut","description":"Perform linting checks against a directory of Jenkins job XML","fork":true,"url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut","forks_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/forks","keys_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/teams","hooks_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/hooks","issue_events_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/issues/events{/number}","events_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/events","assignees_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/assignees{/user}","branches_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/branches{/branch}","tags_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/tags","blobs_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/git/refs{/sha}","trees_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/statuses/{sha}","languages_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/languages","stargazers_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/stargazers","contributors_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/contributors","subscribers_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/subscribers","subscription_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/subscription","commits_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/commits{/sha}","git_commits_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/git/commits{/sha}","comments_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/comments{/number}","issue_comment_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/issues/comments{/number}","contents_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/contents/{+path}","compare_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/merges","archive_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/downloads","issues_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/issues{/number}","pulls_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/pulls{/number}","milestones_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/milestones{/number}","notifications_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/labels{/name}","releases_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/releases{/id}","deployments_url":"https://api.github.com/repos/philroche/jenkins-job-linter-fit-halibut/deployments","created_at":"2018-06-21T20:00:42Z","updated_at":"2018-06-21T20:00:45Z","pushed_at":"2018-06-21T20:00:49Z","git_url":"git://github.com/philroche/jenkins-job-linter-fit-halibut.git","ssh_url":"git@github.com:philroche/jenkins-job-linter-fit-halibut.git","clone_url":"https://github.com/philroche/jenkins-job-linter-fit-halibut.git","svn_url":"https://github.com/philroche/jenkins-job-linter-fit-halibut","homepage":null,"size":158,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"CanonicalLtd:devel","ref":"devel","sha":"b964ab82128adbb0cd7528d0c6dd5420eb6e3be1","user":{"login":"CanonicalLtd","id":7490288,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0OTAyODg=","avatar_url":"https://avatars0.githubusercontent.com/u/7490288?v=4","gravatar_id":"","url":"https://api.github.com/users/CanonicalLtd","html_url":"https://github.com/CanonicalLtd","followers_url":"https://api.github.com/users/CanonicalLtd/followers","following_url":"https://api.github.com/users/CanonicalLtd/following{/other_user}","gists_url":"https://api.github.com/users/CanonicalLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/CanonicalLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanonicalLtd/subscriptions","organizations_url":"https://api.github.com/users/CanonicalLtd/orgs","repos_url":"https://api.github.com/users/CanonicalLtd/repos","events_url":"https://api.github.com/users/CanonicalLtd/events{/privacy}","received_events_url":"https://api.github.com/users/CanonicalLtd/received_events","type":"Organization","site_admin":false},"repo":{"id":138216040,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyMTYwNDA=","name":"jenkins-job-linter-fit-halibut","full_name":"CanonicalLtd/jenkins-job-linter-fit-halibut","owner":{"login":"CanonicalLtd","id":7490288,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0OTAyODg=","avatar_url":"https://avatars0.githubusercontent.com/u/7490288?v=4","gravatar_id":"","url":"https://api.github.com/users/CanonicalLtd","html_url":"https://github.com/CanonicalLtd","followers_url":"https://api.github.com/users/CanonicalLtd/followers","following_url":"https://api.github.com/users/CanonicalLtd/following{/other_user}","gists_url":"https://api.github.com/users/CanonicalLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/CanonicalLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanonicalLtd/subscriptions","organizations_url":"https://api.github.com/users/CanonicalLtd/orgs","repos_url":"https://api.github.com/users/CanonicalLtd/repos","events_url":"https://api.github.com/users/CanonicalLtd/events{/privacy}","received_events_url":"https://api.github.com/users/CanonicalLtd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanonicalLtd/jenkins-job-linter-fit-halibut","description":"Perform linting checks against a directory of Jenkins job XML","fork":false,"url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut","forks_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/forks","keys_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/teams","hooks_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/hooks","issue_events_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/issues/events{/number}","events_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/events","assignees_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/assignees{/user}","branches_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/branches{/branch}","tags_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/tags","blobs_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/statuses/{sha}","languages_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/languages","stargazers_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/stargazers","contributors_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/contributors","subscribers_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/subscribers","subscription_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/subscription","commits_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/contents/{+path}","compare_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/merges","archive_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/downloads","issues_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/issues{/number}","pulls_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/pulls{/number}","milestones_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/milestones{/number}","notifications_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/labels{/name}","releases_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/releases{/id}","deployments_url":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/deployments","created_at":"2018-06-21T20:00:35Z","updated_at":"2018-06-21T20:00:50Z","pushed_at":"2018-06-21T20:00:50Z","git_url":"git://github.com/CanonicalLtd/jenkins-job-linter-fit-halibut.git","ssh_url":"git@github.com:CanonicalLtd/jenkins-job-linter-fit-halibut.git","clone_url":"https://github.com/CanonicalLtd/jenkins-job-linter-fit-halibut.git","svn_url":"https://github.com/CanonicalLtd/jenkins-job-linter-fit-halibut","homepage":null,"size":153,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/pulls/1"},"html":{"href":"https://github.com/CanonicalLtd/jenkins-job-linter-fit-halibut/pull/1"},"issue":{"href":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/issues/1"},"comments":{"href":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/CanonicalLtd/jenkins-job-linter-fit-halibut/statuses/8d1549dda40f6ab0e6ad366f9f2e3b217869895d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ardaguclu"}}