{"action":"created","comment":{"url":"https://api.github.com/repos/toggl/mobileapp/pulls/comments/199225564","pull_request_review_id":133308283,"id":199225564,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTIyNTU2NA==","diff_hunk":"@@ -51,7 +53,8 @@ public void ExtractsTheProjectNameWhileTyping(NonEmptyString nonEmptyString)\n                     if (text.Length < 2 || text.Contains(\"#\") || text.Contains(\"@\"))\n                         return;\n \n-                    var textFieldInfo = TextFieldInfo.Empty(1).WithTextAndCursor(text, text.Length);\n+                    var textFieldInfo = TextFieldInfo.Empty(1)","path":"Toggl.Foundation.Tests/Autocomplete/QueryInfoTests.cs","position":36,"original_position":36,"commit_id":"02e28cc86ad633a10705efb828e8d40ae30dbcf8","original_commit_id":"02e28cc86ad633a10705efb828e8d40ae30dbcf8","user":{"login":"willsb","id":7688727,"node_id":"MDQ6VXNlcjc2ODg3Mjc=","avatar_url":"https://avatars3.githubusercontent.com/u/7688727?v=4","gravatar_id":"","url":"https://api.github.com/users/willsb","html_url":"https://github.com/willsb","followers_url":"https://api.github.com/users/willsb/followers","following_url":"https://api.github.com/users/willsb/following{/other_user}","gists_url":"https://api.github.com/users/willsb/gists{/gist_id}","starred_url":"https://api.github.com/users/willsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willsb/subscriptions","organizations_url":"https://api.github.com/users/willsb/orgs","repos_url":"https://api.github.com/users/willsb/repos","events_url":"https://api.github.com/users/willsb/events{/privacy}","received_events_url":"https://api.github.com/users/willsb/received_events","type":"User","site_admin":false},"body":"The naming was like that before, so in order to keep this PR from getting bigger, how about we refactor those on another PR?","created_at":"2018-06-29T17:15:13Z","updated_at":"2018-06-29T17:15:13Z","html_url":"https://github.com/toggl/mobileapp/pull/2498#discussion_r199225564","pull_request_url":"https://api.github.com/repos/toggl/mobileapp/pulls/2498","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/comments/199225564"},"html":{"href":"https://github.com/toggl/mobileapp/pull/2498#discussion_r199225564"},"pull_request":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/2498"}},"in_reply_to_id":199010932},"pull_request":{"url":"https://api.github.com/repos/toggl/mobileapp/pulls/2498","id":195930921,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTMwOTIx","html_url":"https://github.com/toggl/mobileapp/pull/2498","diff_url":"https://github.com/toggl/mobileapp/pull/2498.diff","patch_url":"https://github.com/toggl/mobileapp/pull/2498.patch","issue_url":"https://api.github.com/repos/toggl/mobileapp/issues/2498","number":2498,"state":"open","locked":false,"title":"Refactor TextFieldInfo","user":{"login":"willsb","id":7688727,"node_id":"MDQ6VXNlcjc2ODg3Mjc=","avatar_url":"https://avatars3.githubusercontent.com/u/7688727?v=4","gravatar_id":"","url":"https://api.github.com/users/willsb","html_url":"https://github.com/willsb","followers_url":"https://api.github.com/users/willsb/followers","following_url":"https://api.github.com/users/willsb/following{/other_user}","gists_url":"https://api.github.com/users/willsb/gists{/gist_id}","starred_url":"https://api.github.com/users/willsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willsb/subscriptions","organizations_url":"https://api.github.com/users/willsb/orgs","repos_url":"https://api.github.com/users/willsb/repos","events_url":"https://api.github.com/users/willsb/events{/privacy}","received_events_url":"https://api.github.com/users/willsb/received_events","type":"User","site_admin":false},"body":"Closes #2471\r\nCloses #2472\r\nCloses #2534 \r\n\r\nMakes #2562 obsolete\r\n\r\nThis completely rewrites the way we handle Chips/Tokens<sup>1</sup> on the `StartTimeEntryViewModel`. We are now simply listening to a stream of events (text changes and cursor position changes), transforming those events into a representation that the ViewModel understands and then letting the native platform handle all the text bureaucracy. We only ask for re-rendering when the user requests a change the comes from the ViewModel. This allows us to not maintain tons of code related to multi-character editing, heuristics as to whether the user is editing in a region or not and, as an added benefit, allows us to have Chips/Tokens anywhere in our text.\r\n\r\nI achieved that by using the `ISpan` interface, a concept that's very close to what both platforms have. It should be well tested, but don't hesitate in asking for more tests on the Foundation side of things, should you deem necessary.\r\n\r\nPlease test this thoroughly, as it's a huge change, on both platforms. I'd like one review from @simonrozsival, one from an Android person (@daividssilverio, since he already reviewed) and one from any iOS dev).\r\n\r\n<sup>1</sup> Please don't call them `tags` for business logic reasons)","created_at":"2018-06-19T19:19:03Z","updated_at":"2018-06-29T17:15:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"420962f579673de2b439dca4cbdff22dbf4fc708","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":772341325,"node_id":"MDU6TGFiZWw3NzIzNDEzMjU=","url":"https://api.github.com/repos/toggl/mobileapp/labels/android","name":"android","color":"A4C639","default":false},{"id":831152836,"node_id":"MDU6TGFiZWw4MzExNTI4MzY=","url":"https://api.github.com/repos/toggl/mobileapp/labels/foundation","name":"foundation","color":"646490","default":false},{"id":773208974,"node_id":"MDU6TGFiZWw3NzMyMDg5NzQ=","url":"https://api.github.com/repos/toggl/mobileapp/labels/ios","name":"ios","color":"51bdf7","default":false},{"id":829930771,"node_id":"MDU6TGFiZWw4Mjk5MzA3NzE=","url":"https://api.github.com/repos/toggl/mobileapp/labels/refactoring","name":"refactoring","color":"ffe787","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/toggl/mobileapp/pulls/2498/commits","review_comments_url":"https://api.github.com/repos/toggl/mobileapp/pulls/2498/comments","review_comment_url":"https://api.github.com/repos/toggl/mobileapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/toggl/mobileapp/issues/2498/comments","statuses_url":"https://api.github.com/repos/toggl/mobileapp/statuses/02e28cc86ad633a10705efb828e8d40ae30dbcf8","head":{"label":"toggl:edit-text-memes","ref":"edit-text-memes","sha":"02e28cc86ad633a10705efb828e8d40ae30dbcf8","user":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"repo":{"id":87079363,"node_id":"MDEwOlJlcG9zaXRvcnk4NzA3OTM2Mw==","name":"mobileapp","full_name":"toggl/mobileapp","owner":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/toggl/mobileapp","description":"Toggl's mobile apps","fork":false,"url":"https://api.github.com/repos/toggl/mobileapp","forks_url":"https://api.github.com/repos/toggl/mobileapp/forks","keys_url":"https://api.github.com/repos/toggl/mobileapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toggl/mobileapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toggl/mobileapp/teams","hooks_url":"https://api.github.com/repos/toggl/mobileapp/hooks","issue_events_url":"https://api.github.com/repos/toggl/mobileapp/issues/events{/number}","events_url":"https://api.github.com/repos/toggl/mobileapp/events","assignees_url":"https://api.github.com/repos/toggl/mobileapp/assignees{/user}","branches_url":"https://api.github.com/repos/toggl/mobileapp/branches{/branch}","tags_url":"https://api.github.com/repos/toggl/mobileapp/tags","blobs_url":"https://api.github.com/repos/toggl/mobileapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toggl/mobileapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toggl/mobileapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/toggl/mobileapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toggl/mobileapp/statuses/{sha}","languages_url":"https://api.github.com/repos/toggl/mobileapp/languages","stargazers_url":"https://api.github.com/repos/toggl/mobileapp/stargazers","contributors_url":"https://api.github.com/repos/toggl/mobileapp/contributors","subscribers_url":"https://api.github.com/repos/toggl/mobileapp/subscribers","subscription_url":"https://api.github.com/repos/toggl/mobileapp/subscription","commits_url":"https://api.github.com/repos/toggl/mobileapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/toggl/mobileapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/toggl/mobileapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/toggl/mobileapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/toggl/mobileapp/contents/{+path}","compare_url":"https://api.github.com/repos/toggl/mobileapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toggl/mobileapp/merges","archive_url":"https://api.github.com/repos/toggl/mobileapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toggl/mobileapp/downloads","issues_url":"https://api.github.com/repos/toggl/mobileapp/issues{/number}","pulls_url":"https://api.github.com/repos/toggl/mobileapp/pulls{/number}","milestones_url":"https://api.github.com/repos/toggl/mobileapp/milestones{/number}","notifications_url":"https://api.github.com/repos/toggl/mobileapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toggl/mobileapp/labels{/name}","releases_url":"https://api.github.com/repos/toggl/mobileapp/releases{/id}","deployments_url":"https://api.github.com/repos/toggl/mobileapp/deployments","created_at":"2017-04-03T13:48:06Z","updated_at":"2018-06-28T15:31:49Z","pushed_at":"2018-06-29T16:55:11Z","git_url":"git://github.com/toggl/mobileapp.git","ssh_url":"git@github.com:toggl/mobileapp.git","clone_url":"https://github.com/toggl/mobileapp.git","svn_url":"https://github.com/toggl/mobileapp","homepage":"","size":23364,"stargazers_count":72,"watchers_count":72,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":146,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":146,"watchers":72,"default_branch":"develop"}},"base":{"label":"toggl:develop","ref":"develop","sha":"500ca5a7685c43d7c8edd1b5261446c2900bee94","user":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"repo":{"id":87079363,"node_id":"MDEwOlJlcG9zaXRvcnk4NzA3OTM2Mw==","name":"mobileapp","full_name":"toggl/mobileapp","owner":{"login":"toggl","id":316475,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjQ3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/316475?v=4","gravatar_id":"","url":"https://api.github.com/users/toggl","html_url":"https://github.com/toggl","followers_url":"https://api.github.com/users/toggl/followers","following_url":"https://api.github.com/users/toggl/following{/other_user}","gists_url":"https://api.github.com/users/toggl/gists{/gist_id}","starred_url":"https://api.github.com/users/toggl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toggl/subscriptions","organizations_url":"https://api.github.com/users/toggl/orgs","repos_url":"https://api.github.com/users/toggl/repos","events_url":"https://api.github.com/users/toggl/events{/privacy}","received_events_url":"https://api.github.com/users/toggl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/toggl/mobileapp","description":"Toggl's mobile apps","fork":false,"url":"https://api.github.com/repos/toggl/mobileapp","forks_url":"https://api.github.com/repos/toggl/mobileapp/forks","keys_url":"https://api.github.com/repos/toggl/mobileapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toggl/mobileapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toggl/mobileapp/teams","hooks_url":"https://api.github.com/repos/toggl/mobileapp/hooks","issue_events_url":"https://api.github.com/repos/toggl/mobileapp/issues/events{/number}","events_url":"https://api.github.com/repos/toggl/mobileapp/events","assignees_url":"https://api.github.com/repos/toggl/mobileapp/assignees{/user}","branches_url":"https://api.github.com/repos/toggl/mobileapp/branches{/branch}","tags_url":"https://api.github.com/repos/toggl/mobileapp/tags","blobs_url":"https://api.github.com/repos/toggl/mobileapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toggl/mobileapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toggl/mobileapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/toggl/mobileapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toggl/mobileapp/statuses/{sha}","languages_url":"https://api.github.com/repos/toggl/mobileapp/languages","stargazers_url":"https://api.github.com/repos/toggl/mobileapp/stargazers","contributors_url":"https://api.github.com/repos/toggl/mobileapp/contributors","subscribers_url":"https://api.github.com/repos/toggl/mobileapp/subscribers","subscription_url":"https://api.github.com/repos/toggl/mobileapp/subscription","commits_url":"https://api.github.com/repos/toggl/mobileapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/toggl/mobileapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/toggl/mobileapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/toggl/mobileapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/toggl/mobileapp/contents/{+path}","compare_url":"https://api.github.com/repos/toggl/mobileapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toggl/mobileapp/merges","archive_url":"https://api.github.com/repos/toggl/mobileapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toggl/mobileapp/downloads","issues_url":"https://api.github.com/repos/toggl/mobileapp/issues{/number}","pulls_url":"https://api.github.com/repos/toggl/mobileapp/pulls{/number}","milestones_url":"https://api.github.com/repos/toggl/mobileapp/milestones{/number}","notifications_url":"https://api.github.com/repos/toggl/mobileapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toggl/mobileapp/labels{/name}","releases_url":"https://api.github.com/repos/toggl/mobileapp/releases{/id}","deployments_url":"https://api.github.com/repos/toggl/mobileapp/deployments","created_at":"2017-04-03T13:48:06Z","updated_at":"2018-06-28T15:31:49Z","pushed_at":"2018-06-29T16:55:11Z","git_url":"git://github.com/toggl/mobileapp.git","ssh_url":"git@github.com:toggl/mobileapp.git","clone_url":"https://github.com/toggl/mobileapp.git","svn_url":"https://github.com/toggl/mobileapp","homepage":"","size":23364,"stargazers_count":72,"watchers_count":72,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":146,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":146,"watchers":72,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/2498"},"html":{"href":"https://github.com/toggl/mobileapp/pull/2498"},"issue":{"href":"https://api.github.com/repos/toggl/mobileapp/issues/2498"},"comments":{"href":"https://api.github.com/repos/toggl/mobileapp/issues/2498/comments"},"review_comments":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/2498/comments"},"review_comment":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/toggl/mobileapp/pulls/2498/commits"},"statuses":{"href":"https://api.github.com/repos/toggl/mobileapp/statuses/02e28cc86ad633a10705efb828e8d40ae30dbcf8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"willsb"}}