{"action":"created","comment":{"url":"https://api.github.com/repos/tknerr/linus-kitchen/pulls/comments/234794146","pull_request_review_id":176513117,"id":234794146,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDc5NDE0Ng==","diff_hunk":"@@ -6,18 +6,21 @@ LOGIN_PASS=$2\n # create the login user if it does not already exist\n if getent passwd $LOGIN_USER >/dev/null; then\n   echo \"Login User '$LOGIN_USER' already created...\"\n-else\n-  # create user, set password and add it to the usual groups\n-  adduser $LOGIN_USER --gecos \"\" --home \"/home/$LOGIN_USER\" --disabled-password\n-  echo \"$LOGIN_USER:$LOGIN_PASS\" | chpasswd\n-  usermod -a -G adm,cdrom,sudo,dip,plugdev,lpadmin,sambashare $LOGIN_USER\n+  exit 0\n+fi\n \n-  # ensure the new user can do passwordless sudo\n-  echo \"$LOGIN_USER ALL=(ALL) NOPASSWD: ALL\" | sudo tee /etc/sudoers.d/$LOGIN_USER\n+# create user, set password and add it to the usual groups\n+adduser $LOGIN_USER --gecos \"\" --home \"/home/$LOGIN_USER\" --disabled-password\n+echo \"$LOGIN_USER:$LOGIN_PASS\" | chpasswd\n+usermod -a -G adm,cdrom,sudo,dip,plugdev,lpadmin,sambashare $LOGIN_USER\n \n-  # set the new user as the default in the login screen and lock the current (vagrant user's) screen session\n-  if [[ $(which dm-tool) ]]; then\n-    echo -e \"[SeatDefaults]\\nautologin-user=$LOGIN_USER\" | sudo tee /etc/lightdm/lightdm.conf\n-    XDG_SEAT_PATH=/org/freedesktop/DisplayManager/Seat0 dm-tool lock","path":"scripts/setup-vm-user.sh","position":22,"original_position":22,"commit_id":"d02e596974924a933e6ba651dd6a07c7e4378a58","original_commit_id":"d02e596974924a933e6ba651dd6a07c7e4378a58","user":{"login":"tknerr","id":365744,"node_id":"MDQ6VXNlcjM2NTc0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/365744?v=4","gravatar_id":"","url":"https://api.github.com/users/tknerr","html_url":"https://github.com/tknerr","followers_url":"https://api.github.com/users/tknerr/followers","following_url":"https://api.github.com/users/tknerr/following{/other_user}","gists_url":"https://api.github.com/users/tknerr/gists{/gist_id}","starred_url":"https://api.github.com/users/tknerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tknerr/subscriptions","organizations_url":"https://api.github.com/users/tknerr/orgs","repos_url":"https://api.github.com/users/tknerr/repos","events_url":"https://api.github.com/users/tknerr/events{/privacy}","received_events_url":"https://api.github.com/users/tknerr/received_events","type":"User","site_admin":false},"body":"Based on the commit message from 2d5f3d143264047bf19f22b3118bc7fdb989cc00, I wanted to avoid that you accidentally use the VM with the vagrant user, where you actually should log out and log in as `$LOGIN_USER` instead. Locking the screen with the auto login user `$LOGIN_USER` somehow solved that.","created_at":"2018-11-19T21:48:32Z","updated_at":"2018-11-19T21:48:32Z","html_url":"https://github.com/tknerr/linus-kitchen/pull/68#discussion_r234794146","pull_request_url":"https://api.github.com/repos/tknerr/linus-kitchen/pulls/68","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/tknerr/linus-kitchen/pulls/comments/234794146"},"html":{"href":"https://github.com/tknerr/linus-kitchen/pull/68#discussion_r234794146"},"pull_request":{"href":"https://api.github.com/repos/tknerr/linus-kitchen/pulls/68"}},"in_reply_to_id":234776368},"pull_request":{"url":"https://api.github.com/repos/tknerr/linus-kitchen/pulls/68","id":229980560,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTgwNTYw","html_url":"https://github.com/tknerr/linus-kitchen/pull/68","diff_url":"https://github.com/tknerr/linus-kitchen/pull/68.diff","patch_url":"https://github.com/tknerr/linus-kitchen/pull/68.patch","issue_url":"https://api.github.com/repos/tknerr/linus-kitchen/issues/68","number":68,"state":"open","locked":false,"title":"Update to bionic","user":{"login":"fasmat","id":5011972,"node_id":"MDQ6VXNlcjUwMTE5NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/5011972?v=4","gravatar_id":"","url":"https://api.github.com/users/fasmat","html_url":"https://github.com/fasmat","followers_url":"https://api.github.com/users/fasmat/followers","following_url":"https://api.github.com/users/fasmat/following{/other_user}","gists_url":"https://api.github.com/users/fasmat/gists{/gist_id}","starred_url":"https://api.github.com/users/fasmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fasmat/subscriptions","organizations_url":"https://api.github.com/users/fasmat/orgs","repos_url":"https://api.github.com/users/fasmat/repos","events_url":"https://api.github.com/users/fasmat/events{/privacy}","received_events_url":"https://api.github.com/users/fasmat/received_events","type":"User","site_admin":false},"body":"Updated linus-kitchen to Bionic\r\n","created_at":"2018-11-11T21:48:11Z","updated_at":"2018-11-19T21:48:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5b43c5ce0c463cbac119e28c8ec54ab0dcfeda8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tknerr/linus-kitchen/pulls/68/commits","review_comments_url":"https://api.github.com/repos/tknerr/linus-kitchen/pulls/68/comments","review_comment_url":"https://api.github.com/repos/tknerr/linus-kitchen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tknerr/linus-kitchen/issues/68/comments","statuses_url":"https://api.github.com/repos/tknerr/linus-kitchen/statuses/d02e596974924a933e6ba651dd6a07c7e4378a58","head":{"label":"fasmat:update-to-bionic","ref":"update-to-bionic","sha":"d02e596974924a933e6ba651dd6a07c7e4378a58","user":{"login":"fasmat","id":5011972,"node_id":"MDQ6VXNlcjUwMTE5NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/5011972?v=4","gravatar_id":"","url":"https://api.github.com/users/fasmat","html_url":"https://github.com/fasmat","followers_url":"https://api.github.com/users/fasmat/followers","following_url":"https://api.github.com/users/fasmat/following{/other_user}","gists_url":"https://api.github.com/users/fasmat/gists{/gist_id}","starred_url":"https://api.github.com/users/fasmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fasmat/subscriptions","organizations_url":"https://api.github.com/users/fasmat/orgs","repos_url":"https://api.github.com/users/fasmat/repos","events_url":"https://api.github.com/users/fasmat/events{/privacy}","received_events_url":"https://api.github.com/users/fasmat/received_events","type":"User","site_admin":false},"repo":{"id":157069963,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcwNjk5NjM=","name":"linus-kitchen","full_name":"fasmat/linus-kitchen","private":false,"owner":{"login":"fasmat","id":5011972,"node_id":"MDQ6VXNlcjUwMTE5NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/5011972?v=4","gravatar_id":"","url":"https://api.github.com/users/fasmat","html_url":"https://github.com/fasmat","followers_url":"https://api.github.com/users/fasmat/followers","following_url":"https://api.github.com/users/fasmat/following{/other_user}","gists_url":"https://api.github.com/users/fasmat/gists{/gist_id}","starred_url":"https://api.github.com/users/fasmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fasmat/subscriptions","organizations_url":"https://api.github.com/users/fasmat/orgs","repos_url":"https://api.github.com/users/fasmat/repos","events_url":"https://api.github.com/users/fasmat/events{/privacy}","received_events_url":"https://api.github.com/users/fasmat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fasmat/linus-kitchen","description":"An Ubuntu-based developer VM for hacking with Chef, Vagrant, Docker & Co","fork":true,"url":"https://api.github.com/repos/fasmat/linus-kitchen","forks_url":"https://api.github.com/repos/fasmat/linus-kitchen/forks","keys_url":"https://api.github.com/repos/fasmat/linus-kitchen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fasmat/linus-kitchen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fasmat/linus-kitchen/teams","hooks_url":"https://api.github.com/repos/fasmat/linus-kitchen/hooks","issue_events_url":"https://api.github.com/repos/fasmat/linus-kitchen/issues/events{/number}","events_url":"https://api.github.com/repos/fasmat/linus-kitchen/events","assignees_url":"https://api.github.com/repos/fasmat/linus-kitchen/assignees{/user}","branches_url":"https://api.github.com/repos/fasmat/linus-kitchen/branches{/branch}","tags_url":"https://api.github.com/repos/fasmat/linus-kitchen/tags","blobs_url":"https://api.github.com/repos/fasmat/linus-kitchen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fasmat/linus-kitchen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fasmat/linus-kitchen/git/refs{/sha}","trees_url":"https://api.github.com/repos/fasmat/linus-kitchen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fasmat/linus-kitchen/statuses/{sha}","languages_url":"https://api.github.com/repos/fasmat/linus-kitchen/languages","stargazers_url":"https://api.github.com/repos/fasmat/linus-kitchen/stargazers","contributors_url":"https://api.github.com/repos/fasmat/linus-kitchen/contributors","subscribers_url":"https://api.github.com/repos/fasmat/linus-kitchen/subscribers","subscription_url":"https://api.github.com/repos/fasmat/linus-kitchen/subscription","commits_url":"https://api.github.com/repos/fasmat/linus-kitchen/commits{/sha}","git_commits_url":"https://api.github.com/repos/fasmat/linus-kitchen/git/commits{/sha}","comments_url":"https://api.github.com/repos/fasmat/linus-kitchen/comments{/number}","issue_comment_url":"https://api.github.com/repos/fasmat/linus-kitchen/issues/comments{/number}","contents_url":"https://api.github.com/repos/fasmat/linus-kitchen/contents/{+path}","compare_url":"https://api.github.com/repos/fasmat/linus-kitchen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fasmat/linus-kitchen/merges","archive_url":"https://api.github.com/repos/fasmat/linus-kitchen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fasmat/linus-kitchen/downloads","issues_url":"https://api.github.com/repos/fasmat/linus-kitchen/issues{/number}","pulls_url":"https://api.github.com/repos/fasmat/linus-kitchen/pulls{/number}","milestones_url":"https://api.github.com/repos/fasmat/linus-kitchen/milestones{/number}","notifications_url":"https://api.github.com/repos/fasmat/linus-kitchen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fasmat/linus-kitchen/labels{/name}","releases_url":"https://api.github.com/repos/fasmat/linus-kitchen/releases{/id}","deployments_url":"https://api.github.com/repos/fasmat/linus-kitchen/deployments","created_at":"2018-11-11T10:46:08Z","updated_at":"2018-11-11T10:46:11Z","pushed_at":"2018-11-17T23:41:23Z","git_url":"git://github.com/fasmat/linus-kitchen.git","ssh_url":"git@github.com:fasmat/linus-kitchen.git","clone_url":"https://github.com/fasmat/linus-kitchen.git","svn_url":"https://github.com/fasmat/linus-kitchen","homepage":"","size":799,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tknerr:master","ref":"master","sha":"3788e38e1173bc0604c8fb89c0dd0da9a5cb77ad","user":{"login":"tknerr","id":365744,"node_id":"MDQ6VXNlcjM2NTc0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/365744?v=4","gravatar_id":"","url":"https://api.github.com/users/tknerr","html_url":"https://github.com/tknerr","followers_url":"https://api.github.com/users/tknerr/followers","following_url":"https://api.github.com/users/tknerr/following{/other_user}","gists_url":"https://api.github.com/users/tknerr/gists{/gist_id}","starred_url":"https://api.github.com/users/tknerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tknerr/subscriptions","organizations_url":"https://api.github.com/users/tknerr/orgs","repos_url":"https://api.github.com/users/tknerr/repos","events_url":"https://api.github.com/users/tknerr/events{/privacy}","received_events_url":"https://api.github.com/users/tknerr/received_events","type":"User","site_admin":false},"repo":{"id":12154453,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE1NDQ1Mw==","name":"linus-kitchen","full_name":"tknerr/linus-kitchen","private":false,"owner":{"login":"tknerr","id":365744,"node_id":"MDQ6VXNlcjM2NTc0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/365744?v=4","gravatar_id":"","url":"https://api.github.com/users/tknerr","html_url":"https://github.com/tknerr","followers_url":"https://api.github.com/users/tknerr/followers","following_url":"https://api.github.com/users/tknerr/following{/other_user}","gists_url":"https://api.github.com/users/tknerr/gists{/gist_id}","starred_url":"https://api.github.com/users/tknerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tknerr/subscriptions","organizations_url":"https://api.github.com/users/tknerr/orgs","repos_url":"https://api.github.com/users/tknerr/repos","events_url":"https://api.github.com/users/tknerr/events{/privacy}","received_events_url":"https://api.github.com/users/tknerr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tknerr/linus-kitchen","description":"An Ubuntu-based developer VM for hacking with Chef, Vagrant, Docker & Co","fork":false,"url":"https://api.github.com/repos/tknerr/linus-kitchen","forks_url":"https://api.github.com/repos/tknerr/linus-kitchen/forks","keys_url":"https://api.github.com/repos/tknerr/linus-kitchen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tknerr/linus-kitchen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tknerr/linus-kitchen/teams","hooks_url":"https://api.github.com/repos/tknerr/linus-kitchen/hooks","issue_events_url":"https://api.github.com/repos/tknerr/linus-kitchen/issues/events{/number}","events_url":"https://api.github.com/repos/tknerr/linus-kitchen/events","assignees_url":"https://api.github.com/repos/tknerr/linus-kitchen/assignees{/user}","branches_url":"https://api.github.com/repos/tknerr/linus-kitchen/branches{/branch}","tags_url":"https://api.github.com/repos/tknerr/linus-kitchen/tags","blobs_url":"https://api.github.com/repos/tknerr/linus-kitchen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tknerr/linus-kitchen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tknerr/linus-kitchen/git/refs{/sha}","trees_url":"https://api.github.com/repos/tknerr/linus-kitchen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tknerr/linus-kitchen/statuses/{sha}","languages_url":"https://api.github.com/repos/tknerr/linus-kitchen/languages","stargazers_url":"https://api.github.com/repos/tknerr/linus-kitchen/stargazers","contributors_url":"https://api.github.com/repos/tknerr/linus-kitchen/contributors","subscribers_url":"https://api.github.com/repos/tknerr/linus-kitchen/subscribers","subscription_url":"https://api.github.com/repos/tknerr/linus-kitchen/subscription","commits_url":"https://api.github.com/repos/tknerr/linus-kitchen/commits{/sha}","git_commits_url":"https://api.github.com/repos/tknerr/linus-kitchen/git/commits{/sha}","comments_url":"https://api.github.com/repos/tknerr/linus-kitchen/comments{/number}","issue_comment_url":"https://api.github.com/repos/tknerr/linus-kitchen/issues/comments{/number}","contents_url":"https://api.github.com/repos/tknerr/linus-kitchen/contents/{+path}","compare_url":"https://api.github.com/repos/tknerr/linus-kitchen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tknerr/linus-kitchen/merges","archive_url":"https://api.github.com/repos/tknerr/linus-kitchen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tknerr/linus-kitchen/downloads","issues_url":"https://api.github.com/repos/tknerr/linus-kitchen/issues{/number}","pulls_url":"https://api.github.com/repos/tknerr/linus-kitchen/pulls{/number}","milestones_url":"https://api.github.com/repos/tknerr/linus-kitchen/milestones{/number}","notifications_url":"https://api.github.com/repos/tknerr/linus-kitchen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tknerr/linus-kitchen/labels{/name}","releases_url":"https://api.github.com/repos/tknerr/linus-kitchen/releases{/id}","deployments_url":"https://api.github.com/repos/tknerr/linus-kitchen/deployments","created_at":"2013-08-16T08:38:46Z","updated_at":"2018-11-16T20:39:50Z","pushed_at":"2018-11-17T12:14:15Z","git_url":"git://github.com/tknerr/linus-kitchen.git","ssh_url":"git@github.com:tknerr/linus-kitchen.git","clone_url":"https://github.com/tknerr/linus-kitchen.git","svn_url":"https://github.com/tknerr/linus-kitchen","homepage":"","size":780,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":8,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tknerr/linus-kitchen/pulls/68"},"html":{"href":"https://github.com/tknerr/linus-kitchen/pull/68"},"issue":{"href":"https://api.github.com/repos/tknerr/linus-kitchen/issues/68"},"comments":{"href":"https://api.github.com/repos/tknerr/linus-kitchen/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/tknerr/linus-kitchen/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/tknerr/linus-kitchen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tknerr/linus-kitchen/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/tknerr/linus-kitchen/statuses/d02e596974924a933e6ba651dd6a07c7e4378a58"}},"author_association":"NONE"}}
{"actor":{"display_login":"tknerr"}}