{"action":"created","issue":{"url":"https://api.github.com/repos/justcoding121/Titanium-Web-Proxy/issues/454","repository_url":"https://api.github.com/repos/justcoding121/Titanium-Web-Proxy","labels_url":"https://api.github.com/repos/justcoding121/Titanium-Web-Proxy/issues/454/labels{/name}","comments_url":"https://api.github.com/repos/justcoding121/Titanium-Web-Proxy/issues/454/comments","events_url":"https://api.github.com/repos/justcoding121/Titanium-Web-Proxy/issues/454/events","html_url":"https://github.com/justcoding121/Titanium-Web-Proxy/pull/454","id":327872151,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTYwMDgy","number":454,"title":"Fix PlatformNotSupportedException when running in docker on Linux","user":{"login":"lmarszal","id":26798897,"node_id":"MDQ6VXNlcjI2Nzk4ODk3","avatar_url":"https://avatars0.githubusercontent.com/u/26798897?v=4","gravatar_id":"","url":"https://api.github.com/users/lmarszal","html_url":"https://github.com/lmarszal","followers_url":"https://api.github.com/users/lmarszal/followers","following_url":"https://api.github.com/users/lmarszal/following{/other_user}","gists_url":"https://api.github.com/users/lmarszal/gists{/gist_id}","starred_url":"https://api.github.com/users/lmarszal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmarszal/subscriptions","organizations_url":"https://api.github.com/users/lmarszal/orgs","repos_url":"https://api.github.com/users/lmarszal/repos","events_url":"https://api.github.com/users/lmarszal/events{/privacy}","received_events_url":"https://api.github.com/users/lmarszal/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-30T19:43:20Z","updated_at":"2018-06-18T13:16:38Z","closed_at":"2018-06-18T13:16:38Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/justcoding121/Titanium-Web-Proxy/pulls/454","html_url":"https://github.com/justcoding121/Titanium-Web-Proxy/pull/454","diff_url":"https://github.com/justcoding121/Titanium-Web-Proxy/pull/454.diff","patch_url":"https://github.com/justcoding121/Titanium-Web-Proxy/pull/454.patch"},"body":"Doneness:\r\n- [x] Build is okay - I made sure that this change is building successfully.\r\n- [x] No Bugs - I made sure that this change is working properly as expected. It doesn't have any bugs that you are aware of. \r\n- [ ] Branching - If this is not a hotfix, I am making this request against develop branch \r\n\r\n\r\nTried to run Titanium-Web-Proxy in docker. Run into two problems:\r\n1) Setting `FriendlyName` on `X509Certificate2` is not supported on Linux - and there was a bug here that it was being set always for .net standard (see pull request)\r\n2) SNI is not supported for SslStream in .NET Core 2.0 on Linux. Will be added in .NET Core 2.1, as per this pull request: https://github.com/dotnet/corefx/pull/28278 - I'm willing to update wiki to let others know about this issue.\r\n\r\nI've also decided to remove this `doNotSetFriendlyName` variable, as we know that `FriendlyName` is just not suppored on Linux and should do it only for Windows."},"comment":{"url":"https://api.github.com/repos/justcoding121/Titanium-Web-Proxy/issues/comments/398050401","html_url":"https://github.com/justcoding121/Titanium-Web-Proxy/pull/454#issuecomment-398050401","issue_url":"https://api.github.com/repos/justcoding121/Titanium-Web-Proxy/issues/454","id":398050401,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODA1MDQwMQ==","user":{"login":"lmarszal","id":26798897,"node_id":"MDQ6VXNlcjI2Nzk4ODk3","avatar_url":"https://avatars0.githubusercontent.com/u/26798897?v=4","gravatar_id":"","url":"https://api.github.com/users/lmarszal","html_url":"https://github.com/lmarszal","followers_url":"https://api.github.com/users/lmarszal/followers","following_url":"https://api.github.com/users/lmarszal/following{/other_user}","gists_url":"https://api.github.com/users/lmarszal/gists{/gist_id}","starred_url":"https://api.github.com/users/lmarszal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmarszal/subscriptions","organizations_url":"https://api.github.com/users/lmarszal/orgs","repos_url":"https://api.github.com/users/lmarszal/repos","events_url":"https://api.github.com/users/lmarszal/events{/privacy}","received_events_url":"https://api.github.com/users/lmarszal/received_events","type":"User","site_admin":false},"created_at":"2018-06-18T13:16:38Z","updated_at":"2018-06-18T13:16:38Z","author_association":"NONE","body":"> I've removed the wrong property set line.\r\n\r\nThanks.\r\n> `not suppored on Linux and should do it only for Windows`\r\n> What about for Mac and Mono in Windows/Linux? .NET core on Windows?\r\n> Are you sure that it is correct everywhere?\r\n> I prefer to keep the current code, because it will work automatically when they implement this property.\r\n\r\nDidn't test it on Mac or Mono. On .NET core windows works fine. And yes - current code is OK, I just don't like exception-driven logic. But it's only my preferences.\r\nWe can leave code as is (with your change mentioned above) and close this PR."}}
{"actor":{"display_login":"lmarszal"}}