{"action":"created","issue":{"url":"https://api.github.com/repos/dlang/dmd/issues/8018","repository_url":"https://api.github.com/repos/dlang/dmd","labels_url":"https://api.github.com/repos/dlang/dmd/issues/8018/labels{/name}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/8018/comments","events_url":"https://api.github.com/repos/dlang/dmd/issues/8018/events","html_url":"https://github.com/dlang/dmd/pull/8018","id":304540712,"number":8018,"title":"Fix Issue 18325 - Don't display TLS variables when building DMD","user":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars3.githubusercontent.com/u/4370550?v=4","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"labels":[{"id":537492633,"url":"https://api.github.com/repos/dlang/dmd/labels/Bug%20Fix","name":"Bug Fix","color":"0052cc","default":false},{"id":119377879,"url":"https://api.github.com/repos/dlang/dmd/labels/Needs%20Approval","name":"Needs Approval","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-03-12T21:08:26Z","updated_at":"2018-03-16T11:42:45Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/8018","html_url":"https://github.com/dlang/dmd/pull/8018","diff_url":"https://github.com/dlang/dmd/pull/8018.diff","patch_url":"https://github.com/dlang/dmd/pull/8018.patch"},"body":"The first `-vtls` flag was added in https://github.com/dlang/dmd/commit/7a087dcb4d51586868a0e08f4d8e8e269d4b41cb, but no one seems to know anymore why it was added.\n\nAFAICT was `-vtls` is a legacy flag from the [long gone migration to shared](https://dlang.org/articles/migrate-to-shared.html).\n\nAlternative PR: https://github.com/dlang/druntime/pull/2138"},"comment":{"url":"https://api.github.com/repos/dlang/dmd/issues/comments/373689087","html_url":"https://github.com/dlang/dmd/pull/8018#issuecomment-373689087","issue_url":"https://api.github.com/repos/dlang/dmd/issues/8018","id":373689087,"user":{"login":"schveiguy","id":580778,"avatar_url":"https://avatars0.githubusercontent.com/u/580778?v=4","gravatar_id":"","url":"https://api.github.com/users/schveiguy","html_url":"https://github.com/schveiguy","followers_url":"https://api.github.com/users/schveiguy/followers","following_url":"https://api.github.com/users/schveiguy/following{/other_user}","gists_url":"https://api.github.com/users/schveiguy/gists{/gist_id}","starred_url":"https://api.github.com/users/schveiguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schveiguy/subscriptions","organizations_url":"https://api.github.com/users/schveiguy/orgs","repos_url":"https://api.github.com/users/schveiguy/repos","events_url":"https://api.github.com/users/schveiguy/events{/privacy}","received_events_url":"https://api.github.com/users/schveiguy/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T11:42:45Z","updated_at":"2018-03-16T11:42:45Z","author_association":"MEMBER","body":"@ibuclaw I have no problem with that idea, but clearly, TLS *is* used inside the front end (as druntime is using it), and is currently passing all CI tests (therefore, there is no automated test for checking for TLS variables). The result is: the flag isn't doing anything productive.\r\n\r\nWe should either remove the druntime usage (perhaps for a DMD-only build) and *enforce* that TLS usage is gone from the front end, or figure out a way that front end can reliably use TLS.\r\n\r\nThe current situation is like fixing a bug and not adding a test for it."}}
{"actor":{"display_login":"schveiguy"}}