{"action":"created","comment":{"url":"https://api.github.com/repos/PowerShell/SharePointDsc/pulls/comments/171696511","pull_request_review_id":100596562,"id":171696511,"diff_hunk":"@@ -4,9 +4,20 @@ This resource will provision an instance of the user profile service to the\n farm. It creates the required databases using the parameters that are passed\n in to it (although these are only used during the initial provisioning).\n \n-The specified InstallAccount or PSDSCRunAsCredential has to be the Farm Account.\n-This is done to ensure that the databases are created with the correct schema\n-owners and allow the user profile sync service to operate correctly.\n+The specified InstallAccount or PSDSCRunAsCredential shouldn't be the Farm Account.\n+The resource will throw an error when it is. However, the FarmAccount parameter\n+should be the Farm Account. The resource will throw an error if it is not. This is","path":"Modules/SharePointDsc/DSCResources/MSFT_SPUserProfileServiceApp/readme.md","position":9,"original_position":9,"commit_id":"8a55d4bc11c219e2bac2518d696a68f351cf0cd7","original_commit_id":"8a55d4bc11c219e2bac2518d696a68f351cf0cd7","user":{"login":"ykuijs","id":15103891,"avatar_url":"https://avatars3.githubusercontent.com/u/15103891?v=4","gravatar_id":"","url":"https://api.github.com/users/ykuijs","html_url":"https://github.com/ykuijs","followers_url":"https://api.github.com/users/ykuijs/followers","following_url":"https://api.github.com/users/ykuijs/following{/other_user}","gists_url":"https://api.github.com/users/ykuijs/gists{/gist_id}","starred_url":"https://api.github.com/users/ykuijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ykuijs/subscriptions","organizations_url":"https://api.github.com/users/ykuijs/orgs","repos_url":"https://api.github.com/users/ykuijs/repos","events_url":"https://api.github.com/users/ykuijs/events{/privacy}","received_events_url":"https://api.github.com/users/ykuijs/received_events","type":"User","site_admin":false},"body":"Since I initially added the FarmAccount parameter and later on replaced this with retrieving the account from the Managed Accounts, I forgot to update the Readme file. Will correct.","created_at":"2018-03-01T21:18:29Z","updated_at":"2018-03-01T21:18:30Z","html_url":"https://github.com/PowerShell/SharePointDsc/pull/775#discussion_r171696511","pull_request_url":"https://api.github.com/repos/PowerShell/SharePointDsc/pulls/775","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/PowerShell/SharePointDsc/pulls/comments/171696511"},"html":{"href":"https://github.com/PowerShell/SharePointDsc/pull/775#discussion_r171696511"},"pull_request":{"href":"https://api.github.com/repos/PowerShell/SharePointDsc/pulls/775"}},"in_reply_to_id":171674929},"pull_request":{"url":"https://api.github.com/repos/PowerShell/SharePointDsc/pulls/775","id":172186969,"html_url":"https://github.com/PowerShell/SharePointDsc/pull/775","diff_url":"https://github.com/PowerShell/SharePointDsc/pull/775.diff","patch_url":"https://github.com/PowerShell/SharePointDsc/pull/775.patch","issue_url":"https://api.github.com/repos/PowerShell/SharePointDsc/issues/775","number":775,"state":"open","locked":false,"title":"Bugfix rollup, incl UPS fixes","user":{"login":"ykuijs","id":15103891,"avatar_url":"https://avatars3.githubusercontent.com/u/15103891?v=4","gravatar_id":"","url":"https://api.github.com/users/ykuijs","html_url":"https://github.com/ykuijs","followers_url":"https://api.github.com/users/ykuijs/followers","following_url":"https://api.github.com/users/ykuijs/following{/other_user}","gists_url":"https://api.github.com/users/ykuijs/gists{/gist_id}","starred_url":"https://api.github.com/users/ykuijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ykuijs/subscriptions","organizations_url":"https://api.github.com/users/ykuijs/orgs","repos_url":"https://api.github.com/users/ykuijs/repos","events_url":"https://api.github.com/users/ykuijs/events{/privacy}","received_events_url":"https://api.github.com/users/ykuijs/received_events","type":"User","site_admin":false},"body":"This PR fixes issues #745, #764 and #768\r\n\r\nIt also corrects the issue with UPS provisioning introduced with the v2.0 release (#709)\r\n\r\n@NikCharlebois Can you please review this PR?\r\n\r\n- [X] Change details added to Unreleased section of changelog.md?\r\n- [X] Added/updated documentation and descriptions in .schema.mof files where appropriate?\r\n- [X] Examples updated for both the single server and small farm templates in the examples folder?\r\n- [X] New/changed code adheres to [Style Guidelines](https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md)?\r\n- [X] [Unit and Integration tests](https://github.com/PowerShell/DscResources/blob/master/TestsGuidelines.md) created/updated where possible?\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/powershell/sharepointdsc/775)\n<!-- Reviewable:end -->\n","created_at":"2018-03-01T09:46:01Z","updated_at":"2018-03-01T21:18:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf1aa49dbf1d76933c844042a2906ccd832012b2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerShell/SharePointDsc/pulls/775/commits","review_comments_url":"https://api.github.com/repos/PowerShell/SharePointDsc/pulls/775/comments","review_comment_url":"https://api.github.com/repos/PowerShell/SharePointDsc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerShell/SharePointDsc/issues/775/comments","statuses_url":"https://api.github.com/repos/PowerShell/SharePointDsc/statuses/8a55d4bc11c219e2bac2518d696a68f351cf0cd7","head":{"label":"ykuijs:Rollup","ref":"Rollup","sha":"8a55d4bc11c219e2bac2518d696a68f351cf0cd7","user":{"login":"ykuijs","id":15103891,"avatar_url":"https://avatars3.githubusercontent.com/u/15103891?v=4","gravatar_id":"","url":"https://api.github.com/users/ykuijs","html_url":"https://github.com/ykuijs","followers_url":"https://api.github.com/users/ykuijs/followers","following_url":"https://api.github.com/users/ykuijs/following{/other_user}","gists_url":"https://api.github.com/users/ykuijs/gists{/gist_id}","starred_url":"https://api.github.com/users/ykuijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ykuijs/subscriptions","organizations_url":"https://api.github.com/users/ykuijs/orgs","repos_url":"https://api.github.com/users/ykuijs/repos","events_url":"https://api.github.com/users/ykuijs/events{/privacy}","received_events_url":"https://api.github.com/users/ykuijs/received_events","type":"User","site_admin":false},"repo":{"id":44166688,"name":"SharePointDsc","full_name":"ykuijs/SharePointDsc","owner":{"login":"ykuijs","id":15103891,"avatar_url":"https://avatars3.githubusercontent.com/u/15103891?v=4","gravatar_id":"","url":"https://api.github.com/users/ykuijs","html_url":"https://github.com/ykuijs","followers_url":"https://api.github.com/users/ykuijs/followers","following_url":"https://api.github.com/users/ykuijs/following{/other_user}","gists_url":"https://api.github.com/users/ykuijs/gists{/gist_id}","starred_url":"https://api.github.com/users/ykuijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ykuijs/subscriptions","organizations_url":"https://api.github.com/users/ykuijs/orgs","repos_url":"https://api.github.com/users/ykuijs/repos","events_url":"https://api.github.com/users/ykuijs/events{/privacy}","received_events_url":"https://api.github.com/users/ykuijs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ykuijs/SharePointDsc","description":"The SharePointDsc PowerShell module provides DSC resources that can be used to deploy and manage a SharePoint farm","fork":true,"url":"https://api.github.com/repos/ykuijs/SharePointDsc","forks_url":"https://api.github.com/repos/ykuijs/SharePointDsc/forks","keys_url":"https://api.github.com/repos/ykuijs/SharePointDsc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ykuijs/SharePointDsc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ykuijs/SharePointDsc/teams","hooks_url":"https://api.github.com/repos/ykuijs/SharePointDsc/hooks","issue_events_url":"https://api.github.com/repos/ykuijs/SharePointDsc/issues/events{/number}","events_url":"https://api.github.com/repos/ykuijs/SharePointDsc/events","assignees_url":"https://api.github.com/repos/ykuijs/SharePointDsc/assignees{/user}","branches_url":"https://api.github.com/repos/ykuijs/SharePointDsc/branches{/branch}","tags_url":"https://api.github.com/repos/ykuijs/SharePointDsc/tags","blobs_url":"https://api.github.com/repos/ykuijs/SharePointDsc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ykuijs/SharePointDsc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ykuijs/SharePointDsc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ykuijs/SharePointDsc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ykuijs/SharePointDsc/statuses/{sha}","languages_url":"https://api.github.com/repos/ykuijs/SharePointDsc/languages","stargazers_url":"https://api.github.com/repos/ykuijs/SharePointDsc/stargazers","contributors_url":"https://api.github.com/repos/ykuijs/SharePointDsc/contributors","subscribers_url":"https://api.github.com/repos/ykuijs/SharePointDsc/subscribers","subscription_url":"https://api.github.com/repos/ykuijs/SharePointDsc/subscription","commits_url":"https://api.github.com/repos/ykuijs/SharePointDsc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ykuijs/SharePointDsc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ykuijs/SharePointDsc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ykuijs/SharePointDsc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ykuijs/SharePointDsc/contents/{+path}","compare_url":"https://api.github.com/repos/ykuijs/SharePointDsc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ykuijs/SharePointDsc/merges","archive_url":"https://api.github.com/repos/ykuijs/SharePointDsc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ykuijs/SharePointDsc/downloads","issues_url":"https://api.github.com/repos/ykuijs/SharePointDsc/issues{/number}","pulls_url":"https://api.github.com/repos/ykuijs/SharePointDsc/pulls{/number}","milestones_url":"https://api.github.com/repos/ykuijs/SharePointDsc/milestones{/number}","notifications_url":"https://api.github.com/repos/ykuijs/SharePointDsc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ykuijs/SharePointDsc/labels{/name}","releases_url":"https://api.github.com/repos/ykuijs/SharePointDsc/releases{/id}","deployments_url":"https://api.github.com/repos/ykuijs/SharePointDsc/deployments","created_at":"2015-10-13T09:42:56Z","updated_at":"2017-11-30T22:00:54Z","pushed_at":"2018-03-01T11:13:20Z","git_url":"git://github.com/ykuijs/SharePointDsc.git","ssh_url":"git@github.com:ykuijs/SharePointDsc.git","clone_url":"https://github.com/ykuijs/SharePointDsc.git","svn_url":"https://github.com/ykuijs/SharePointDsc","homepage":"","size":6554,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"PowerShell:dev","ref":"dev","sha":"9bb603e0fff021254b397a813038c4a5bfbc9c83","user":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":34434722,"name":"SharePointDsc","full_name":"PowerShell/SharePointDsc","owner":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerShell/SharePointDsc","description":"The SharePointDsc PowerShell module provides DSC resources that can be used to deploy and manage a SharePoint farm","fork":false,"url":"https://api.github.com/repos/PowerShell/SharePointDsc","forks_url":"https://api.github.com/repos/PowerShell/SharePointDsc/forks","keys_url":"https://api.github.com/repos/PowerShell/SharePointDsc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/SharePointDsc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/SharePointDsc/teams","hooks_url":"https://api.github.com/repos/PowerShell/SharePointDsc/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/SharePointDsc/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/SharePointDsc/events","assignees_url":"https://api.github.com/repos/PowerShell/SharePointDsc/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/SharePointDsc/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/SharePointDsc/tags","blobs_url":"https://api.github.com/repos/PowerShell/SharePointDsc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/SharePointDsc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/SharePointDsc/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/SharePointDsc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/SharePointDsc/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/SharePointDsc/languages","stargazers_url":"https://api.github.com/repos/PowerShell/SharePointDsc/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/SharePointDsc/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/SharePointDsc/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/SharePointDsc/subscription","commits_url":"https://api.github.com/repos/PowerShell/SharePointDsc/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/SharePointDsc/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/SharePointDsc/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/SharePointDsc/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/SharePointDsc/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/SharePointDsc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/SharePointDsc/merges","archive_url":"https://api.github.com/repos/PowerShell/SharePointDsc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/SharePointDsc/downloads","issues_url":"https://api.github.com/repos/PowerShell/SharePointDsc/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/SharePointDsc/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/SharePointDsc/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/SharePointDsc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/SharePointDsc/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/SharePointDsc/releases{/id}","deployments_url":"https://api.github.com/repos/PowerShell/SharePointDsc/deployments","created_at":"2015-04-23T05:00:16Z","updated_at":"2018-02-27T22:16:05Z","pushed_at":"2018-03-01T11:13:26Z","git_url":"git://github.com/PowerShell/SharePointDsc.git","ssh_url":"git@github.com:PowerShell/SharePointDsc.git","clone_url":"https://github.com/PowerShell/SharePointDsc.git","svn_url":"https://github.com/PowerShell/SharePointDsc","homepage":"","size":6873,"stargazers_count":137,"watchers_count":137,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":77,"open_issues":40,"watchers":137,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerShell/SharePointDsc/pulls/775"},"html":{"href":"https://github.com/PowerShell/SharePointDsc/pull/775"},"issue":{"href":"https://api.github.com/repos/PowerShell/SharePointDsc/issues/775"},"comments":{"href":"https://api.github.com/repos/PowerShell/SharePointDsc/issues/775/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerShell/SharePointDsc/pulls/775/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerShell/SharePointDsc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerShell/SharePointDsc/pulls/775/commits"},"statuses":{"href":"https://api.github.com/repos/PowerShell/SharePointDsc/statuses/8a55d4bc11c219e2bac2518d696a68f351cf0cd7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ykuijs"}}