{"action":"closed","issue":{"url":"https://api.github.com/repos/SpiNNakerManchester/JavaSpiNNaker/issues/194","repository_url":"https://api.github.com/repos/SpiNNakerManchester/JavaSpiNNaker","labels_url":"https://api.github.com/repos/SpiNNakerManchester/JavaSpiNNaker/issues/194/labels{/name}","comments_url":"https://api.github.com/repos/SpiNNakerManchester/JavaSpiNNaker/issues/194/comments","events_url":"https://api.github.com/repos/SpiNNakerManchester/JavaSpiNNaker/issues/194/events","html_url":"https://github.com/SpiNNakerManchester/JavaSpiNNaker/issues/194","id":388689659,"node_id":"MDU6SXNzdWUzODg2ODk2NTk=","number":194,"title":"mutible","user":{"login":"alan-stokes","id":7520968,"node_id":"MDQ6VXNlcjc1MjA5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/7520968?v=4","gravatar_id":"","url":"https://api.github.com/users/alan-stokes","html_url":"https://github.com/alan-stokes","followers_url":"https://api.github.com/users/alan-stokes/followers","following_url":"https://api.github.com/users/alan-stokes/following{/other_user}","gists_url":"https://api.github.com/users/alan-stokes/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-stokes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-stokes/subscriptions","organizations_url":"https://api.github.com/users/alan-stokes/orgs","repos_url":"https://api.github.com/users/alan-stokes/repos","events_url":"https://api.github.com/users/alan-stokes/events{/privacy}","received_events_url":"https://api.github.com/users/alan-stokes/received_events","type":"User","site_admin":false},"labels":[{"id":975663138,"node_id":"MDU6TGFiZWw5NzU2NjMxMzg=","url":"https://api.github.com/repos/SpiNNakerManchester/JavaSpiNNaker/labels/bug","name":"bug","color":"d73a4a","default":true},{"id":975711851,"node_id":"MDU6TGFiZWw5NzU3MTE4NTE=","url":"https://api.github.com/repos/SpiNNakerManchester/JavaSpiNNaker/labels/minor","name":"minor","color":"fef2c0","default":false}],"state":"closed","locked":false,"assignee":{"login":"Christian-B","id":548453,"node_id":"MDQ6VXNlcjU0ODQ1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/548453?v=4","gravatar_id":"","url":"https://api.github.com/users/Christian-B","html_url":"https://github.com/Christian-B","followers_url":"https://api.github.com/users/Christian-B/followers","following_url":"https://api.github.com/users/Christian-B/following{/other_user}","gists_url":"https://api.github.com/users/Christian-B/gists{/gist_id}","starred_url":"https://api.github.com/users/Christian-B/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Christian-B/subscriptions","organizations_url":"https://api.github.com/users/Christian-B/orgs","repos_url":"https://api.github.com/users/Christian-B/repos","events_url":"https://api.github.com/users/Christian-B/events{/privacy}","received_events_url":"https://api.github.com/users/Christian-B/received_events","type":"User","site_admin":false},"assignees":[{"login":"Christian-B","id":548453,"node_id":"MDQ6VXNlcjU0ODQ1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/548453?v=4","gravatar_id":"","url":"https://api.github.com/users/Christian-B","html_url":"https://github.com/Christian-B","followers_url":"https://api.github.com/users/Christian-B/followers","following_url":"https://api.github.com/users/Christian-B/following{/other_user}","gists_url":"https://api.github.com/users/Christian-B/gists{/gist_id}","starred_url":"https://api.github.com/users/Christian-B/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Christian-B/subscriptions","organizations_url":"https://api.github.com/users/Christian-B/orgs","repos_url":"https://api.github.com/users/Christian-B/repos","events_url":"https://api.github.com/users/Christian-B/events{/privacy}","received_events_url":"https://api.github.com/users/Christian-B/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-12-07T15:01:35Z","updated_at":"2018-12-10T11:43:35Z","closed_at":"2018-12-10T11:43:35Z","author_association":"CONTRIBUTOR","body":"Full path to where you find the problem:\r\nC:\\Users\\alan\\Documents\\software\\JavaSpiNNaker\\SpiNNaker-machine\\src\\main\\java\\uk\\ac\\manchester\\spinnaker\\machine\\RoutingEntry.java\r\n\r\nWhat is the problem you see?\r\n    /**\r\n     * Removes a link ID/Direction if it existed.\r\n     *\r\n     * @param oldValue The Id of the processor to remove.\r\n     * @return {@code true} If this entry contained the specified\r\n     *      link/direction.\r\n     */\r\n    public boolean removeLinkID(Direction oldValue) {\r\n        return linkIDs.remove(oldValue);\r\n    }\r\n\r\nWhat do you think it should do instead?\r\nthis makes the class mutable. Which is against our mantra about spinnMachine. Its only ever used by 1 test, which makes it even more stinky. \r\n\r\nremove the test and the method\r\n\r\nWhat version of our software are you using?\r\nmaster\r\n"}}
{"actor":{"display_login":"dkfellows"}}