{"action":"created","issue":{"url":"https://api.github.com/repos/jacebrowning/doorstop/issues/312","repository_url":"https://api.github.com/repos/jacebrowning/doorstop","labels_url":"https://api.github.com/repos/jacebrowning/doorstop/issues/312/labels{/name}","comments_url":"https://api.github.com/repos/jacebrowning/doorstop/issues/312/comments","events_url":"https://api.github.com/repos/jacebrowning/doorstop/issues/312/events","html_url":"https://github.com/jacebrowning/doorstop/pull/312","id":372769283,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0ODY3MDMw","number":312,"title":"OS specific end-line","user":{"login":"fragmuffin","id":2626190,"node_id":"MDQ6VXNlcjI2MjYxOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2626190?v=4","gravatar_id":"","url":"https://api.github.com/users/fragmuffin","html_url":"https://github.com/fragmuffin","followers_url":"https://api.github.com/users/fragmuffin/followers","following_url":"https://api.github.com/users/fragmuffin/following{/other_user}","gists_url":"https://api.github.com/users/fragmuffin/gists{/gist_id}","starred_url":"https://api.github.com/users/fragmuffin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fragmuffin/subscriptions","organizations_url":"https://api.github.com/users/fragmuffin/orgs","repos_url":"https://api.github.com/users/fragmuffin/repos","events_url":"https://api.github.com/users/fragmuffin/events{/privacy}","received_events_url":"https://api.github.com/users/fragmuffin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-23T01:45:40Z","updated_at":"2018-10-23T02:19:16Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jacebrowning/doorstop/pulls/312","html_url":"https://github.com/jacebrowning/doorstop/pull/312","diff_url":"https://github.com/jacebrowning/doorstop/pull/312.diff","patch_url":"https://github.com/jacebrowning/doorstop/pull/312.patch"},"body":"Save YAML files with line-endings prescribed by the executing OS (#310).\r\nDoesn't effect loading of yaml:\r\n\r\n_note_\r\n```\r\n>>> with open('REQ001.yml', 'r') as fh:\r\n...     content = fh.read()\r\n... \r\n>>> import yaml\r\n>>> yaml.load(content) == yaml.load(content.replace('\\n', '\\r\\n'))\r\nTrue\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/jacebrowning/doorstop/issues/comments/432062234","html_url":"https://github.com/jacebrowning/doorstop/pull/312#issuecomment-432062234","issue_url":"https://api.github.com/repos/jacebrowning/doorstop/issues/312","id":432062234,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjA2MjIzNA==","user":{"login":"jacebrowning","id":939501,"node_id":"MDQ6VXNlcjkzOTUwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/939501?v=4","gravatar_id":"","url":"https://api.github.com/users/jacebrowning","html_url":"https://github.com/jacebrowning","followers_url":"https://api.github.com/users/jacebrowning/followers","following_url":"https://api.github.com/users/jacebrowning/following{/other_user}","gists_url":"https://api.github.com/users/jacebrowning/gists{/gist_id}","starred_url":"https://api.github.com/users/jacebrowning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacebrowning/subscriptions","organizations_url":"https://api.github.com/users/jacebrowning/orgs","repos_url":"https://api.github.com/users/jacebrowning/repos","events_url":"https://api.github.com/users/jacebrowning/events{/privacy}","received_events_url":"https://api.github.com/users/jacebrowning/received_events","type":"User","site_admin":false},"created_at":"2018-10-23T02:19:16Z","updated_at":"2018-10-23T02:19:16Z","author_association":"OWNER","body":"I believe the place to do this is not while manipulating strings (`'\\n'` means newline regardless of opperating system: https://pythonconquerstheuniverse.wordpress.com/2011/05/08/newline-conversion-in-python-3/), but when writing to disk, which occurs in https://github.com/jacebrowning/doorstop/blob/develop/doorstop/common.py.\r\n\r\nHave said that, I'm not sure the proposed change is a good idea as I think it will result in constant file changes when working on the same project accross multiple opperating systems.\r\n\r\n\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"jacebrowning"}}