{"action":"created","comment":{"url":"https://api.github.com/repos/ewasm/hera/pulls/comments/213012736","pull_request_review_id":149757397,"id":213012736,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzAxMjczNg==","diff_hunk":"@@ -30,12 +30,17 @@ These are to be used via EVMC `set_option`:\n \n - `engine=<engine>` will select the underlying WebAssembly engine, where the only accepted value currently is `binaryen`\n - `metering=true` will enable metering of bytecode at deployment using the [Sentinel system contract](https://github.com/ewasm/design/blob/master/system_contracts.md#sentinel-contract) (set to `false` by default)\n-- `evm2wasm=true` will enable metering of bytecode at deployment using the [EVM Transcompiler](https://github.com/ewasm/design/blob/master/system_contracts.md#evm-transcompiler) (set to `false` by default)\n-- `fallback=true` will allow EVM bytecode to be passed through to the client for execution (if set to `false`, the default, it will be rejected as invalid) (note: is ignored if `evm2wasm` is `true`)\n-- `evm2wasm.js=true` will use a `evm2wasm.js` as an external commandline tool instead of the system contract\n-- `evm2wasm.js-trace=true` will turn on EVM tracing for `evm2wasm.js`\n-- `evm2wasm.cpp=true` will use a `evm2wasm` as a compiled-in dependency instead of the system contract\n-- `evm2wasm.cpp-trace=true` will turn on EVM tracing for `evm2wasm.cpp`\n+- `evm=<evmmode>` will select how EVM bytecode is handled","path":"README.md","position":10,"original_position":10,"commit_id":"92ec3031f836c330d1d48cafa4291c591fa9b8b1","original_commit_id":"92ec3031f836c330d1d48cafa4291c591fa9b8b1","user":{"login":"cdetrio","id":997681,"node_id":"MDQ6VXNlcjk5NzY4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/997681?v=4","gravatar_id":"","url":"https://api.github.com/users/cdetrio","html_url":"https://github.com/cdetrio","followers_url":"https://api.github.com/users/cdetrio/followers","following_url":"https://api.github.com/users/cdetrio/following{/other_user}","gists_url":"https://api.github.com/users/cdetrio/gists{/gist_id}","starred_url":"https://api.github.com/users/cdetrio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdetrio/subscriptions","organizations_url":"https://api.github.com/users/cdetrio/orgs","repos_url":"https://api.github.com/users/cdetrio/repos","events_url":"https://api.github.com/users/cdetrio/events{/privacy}","received_events_url":"https://api.github.com/users/cdetrio/received_events","type":"User","site_admin":false},"body":"will it look like `--evmc evm1mode=evm2wasm.js` ?","created_at":"2018-08-27T15:18:12Z","updated_at":"2018-08-27T15:18:13Z","html_url":"https://github.com/ewasm/hera/pull/367#discussion_r213012736","pull_request_url":"https://api.github.com/repos/ewasm/hera/pulls/367","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ewasm/hera/pulls/comments/213012736"},"html":{"href":"https://github.com/ewasm/hera/pull/367#discussion_r213012736"},"pull_request":{"href":"https://api.github.com/repos/ewasm/hera/pulls/367"}},"in_reply_to_id":212966715},"pull_request":{"url":"https://api.github.com/repos/ewasm/hera/pulls/367","id":210949194,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTQ5MTk0","html_url":"https://github.com/ewasm/hera/pull/367","diff_url":"https://github.com/ewasm/hera/pull/367.diff","patch_url":"https://github.com/ewasm/hera/pull/367.patch","issue_url":"https://api.github.com/repos/ewasm/hera/issues/367","number":367,"state":"open","locked":false,"title":"Move evm2wasm options into a single EVMC option called 'evm'","user":{"login":"axic","id":20340,"node_id":"MDQ6VXNlcjIwMzQw","avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-26T12:30:17Z","updated_at":"2018-08-27T15:18:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93a3267c9f0545c4967cc746dea09871f49c8edc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jakelang","id":7409799,"node_id":"MDQ6VXNlcjc0MDk3OTk=","avatar_url":"https://avatars2.githubusercontent.com/u/7409799?v=4","gravatar_id":"","url":"https://api.github.com/users/jakelang","html_url":"https://github.com/jakelang","followers_url":"https://api.github.com/users/jakelang/followers","following_url":"https://api.github.com/users/jakelang/following{/other_user}","gists_url":"https://api.github.com/users/jakelang/gists{/gist_id}","starred_url":"https://api.github.com/users/jakelang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakelang/subscriptions","organizations_url":"https://api.github.com/users/jakelang/orgs","repos_url":"https://api.github.com/users/jakelang/repos","events_url":"https://api.github.com/users/jakelang/events{/privacy}","received_events_url":"https://api.github.com/users/jakelang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":805186671,"node_id":"MDU6TGFiZWw4MDUxODY2NzE=","url":"https://api.github.com/repos/ewasm/hera/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ewasm/hera/pulls/367/commits","review_comments_url":"https://api.github.com/repos/ewasm/hera/pulls/367/comments","review_comment_url":"https://api.github.com/repos/ewasm/hera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ewasm/hera/issues/367/comments","statuses_url":"https://api.github.com/repos/ewasm/hera/statuses/92ec3031f836c330d1d48cafa4291c591fa9b8b1","head":{"label":"ewasm:evm-mode","ref":"evm-mode","sha":"92ec3031f836c330d1d48cafa4291c591fa9b8b1","user":{"login":"ewasm","id":20602854,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjAyODU0","avatar_url":"https://avatars1.githubusercontent.com/u/20602854?v=4","gravatar_id":"","url":"https://api.github.com/users/ewasm","html_url":"https://github.com/ewasm","followers_url":"https://api.github.com/users/ewasm/followers","following_url":"https://api.github.com/users/ewasm/following{/other_user}","gists_url":"https://api.github.com/users/ewasm/gists{/gist_id}","starred_url":"https://api.github.com/users/ewasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewasm/subscriptions","organizations_url":"https://api.github.com/users/ewasm/orgs","repos_url":"https://api.github.com/users/ewasm/repos","events_url":"https://api.github.com/users/ewasm/events{/privacy}","received_events_url":"https://api.github.com/users/ewasm/received_events","type":"Organization","site_admin":false},"repo":{"id":66198886,"node_id":"MDEwOlJlcG9zaXRvcnk2NjE5ODg4Ng==","name":"hera","full_name":"ewasm/hera","owner":{"login":"ewasm","id":20602854,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjAyODU0","avatar_url":"https://avatars1.githubusercontent.com/u/20602854?v=4","gravatar_id":"","url":"https://api.github.com/users/ewasm","html_url":"https://github.com/ewasm","followers_url":"https://api.github.com/users/ewasm/followers","following_url":"https://api.github.com/users/ewasm/following{/other_user}","gists_url":"https://api.github.com/users/ewasm/gists{/gist_id}","starred_url":"https://api.github.com/users/ewasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewasm/subscriptions","organizations_url":"https://api.github.com/users/ewasm/orgs","repos_url":"https://api.github.com/users/ewasm/repos","events_url":"https://api.github.com/users/ewasm/events{/privacy}","received_events_url":"https://api.github.com/users/ewasm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ewasm/hera","description":"Hera: ewasm virtual machine conforming to the EVMC API","fork":false,"url":"https://api.github.com/repos/ewasm/hera","forks_url":"https://api.github.com/repos/ewasm/hera/forks","keys_url":"https://api.github.com/repos/ewasm/hera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ewasm/hera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ewasm/hera/teams","hooks_url":"https://api.github.com/repos/ewasm/hera/hooks","issue_events_url":"https://api.github.com/repos/ewasm/hera/issues/events{/number}","events_url":"https://api.github.com/repos/ewasm/hera/events","assignees_url":"https://api.github.com/repos/ewasm/hera/assignees{/user}","branches_url":"https://api.github.com/repos/ewasm/hera/branches{/branch}","tags_url":"https://api.github.com/repos/ewasm/hera/tags","blobs_url":"https://api.github.com/repos/ewasm/hera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ewasm/hera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ewasm/hera/git/refs{/sha}","trees_url":"https://api.github.com/repos/ewasm/hera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ewasm/hera/statuses/{sha}","languages_url":"https://api.github.com/repos/ewasm/hera/languages","stargazers_url":"https://api.github.com/repos/ewasm/hera/stargazers","contributors_url":"https://api.github.com/repos/ewasm/hera/contributors","subscribers_url":"https://api.github.com/repos/ewasm/hera/subscribers","subscription_url":"https://api.github.com/repos/ewasm/hera/subscription","commits_url":"https://api.github.com/repos/ewasm/hera/commits{/sha}","git_commits_url":"https://api.github.com/repos/ewasm/hera/git/commits{/sha}","comments_url":"https://api.github.com/repos/ewasm/hera/comments{/number}","issue_comment_url":"https://api.github.com/repos/ewasm/hera/issues/comments{/number}","contents_url":"https://api.github.com/repos/ewasm/hera/contents/{+path}","compare_url":"https://api.github.com/repos/ewasm/hera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ewasm/hera/merges","archive_url":"https://api.github.com/repos/ewasm/hera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ewasm/hera/downloads","issues_url":"https://api.github.com/repos/ewasm/hera/issues{/number}","pulls_url":"https://api.github.com/repos/ewasm/hera/pulls{/number}","milestones_url":"https://api.github.com/repos/ewasm/hera/milestones{/number}","notifications_url":"https://api.github.com/repos/ewasm/hera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ewasm/hera/labels{/name}","releases_url":"https://api.github.com/repos/ewasm/hera/releases{/id}","deployments_url":"https://api.github.com/repos/ewasm/hera/deployments","created_at":"2016-08-21T12:58:03Z","updated_at":"2018-08-26T23:58:15Z","pushed_at":"2018-08-27T14:17:55Z","git_url":"git://github.com/ewasm/hera.git","ssh_url":"git@github.com:ewasm/hera.git","clone_url":"https://github.com/ewasm/hera.git","svn_url":"https://github.com/ewasm/hera","homepage":"","size":628,"stargazers_count":64,"watchers_count":64,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":26,"watchers":64,"default_branch":"master"}},"base":{"label":"ewasm:master","ref":"master","sha":"3b99bf0c2c5f18df7efc20e49ce858eee9b4b352","user":{"login":"ewasm","id":20602854,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjAyODU0","avatar_url":"https://avatars1.githubusercontent.com/u/20602854?v=4","gravatar_id":"","url":"https://api.github.com/users/ewasm","html_url":"https://github.com/ewasm","followers_url":"https://api.github.com/users/ewasm/followers","following_url":"https://api.github.com/users/ewasm/following{/other_user}","gists_url":"https://api.github.com/users/ewasm/gists{/gist_id}","starred_url":"https://api.github.com/users/ewasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewasm/subscriptions","organizations_url":"https://api.github.com/users/ewasm/orgs","repos_url":"https://api.github.com/users/ewasm/repos","events_url":"https://api.github.com/users/ewasm/events{/privacy}","received_events_url":"https://api.github.com/users/ewasm/received_events","type":"Organization","site_admin":false},"repo":{"id":66198886,"node_id":"MDEwOlJlcG9zaXRvcnk2NjE5ODg4Ng==","name":"hera","full_name":"ewasm/hera","owner":{"login":"ewasm","id":20602854,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjAyODU0","avatar_url":"https://avatars1.githubusercontent.com/u/20602854?v=4","gravatar_id":"","url":"https://api.github.com/users/ewasm","html_url":"https://github.com/ewasm","followers_url":"https://api.github.com/users/ewasm/followers","following_url":"https://api.github.com/users/ewasm/following{/other_user}","gists_url":"https://api.github.com/users/ewasm/gists{/gist_id}","starred_url":"https://api.github.com/users/ewasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewasm/subscriptions","organizations_url":"https://api.github.com/users/ewasm/orgs","repos_url":"https://api.github.com/users/ewasm/repos","events_url":"https://api.github.com/users/ewasm/events{/privacy}","received_events_url":"https://api.github.com/users/ewasm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ewasm/hera","description":"Hera: ewasm virtual machine conforming to the EVMC API","fork":false,"url":"https://api.github.com/repos/ewasm/hera","forks_url":"https://api.github.com/repos/ewasm/hera/forks","keys_url":"https://api.github.com/repos/ewasm/hera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ewasm/hera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ewasm/hera/teams","hooks_url":"https://api.github.com/repos/ewasm/hera/hooks","issue_events_url":"https://api.github.com/repos/ewasm/hera/issues/events{/number}","events_url":"https://api.github.com/repos/ewasm/hera/events","assignees_url":"https://api.github.com/repos/ewasm/hera/assignees{/user}","branches_url":"https://api.github.com/repos/ewasm/hera/branches{/branch}","tags_url":"https://api.github.com/repos/ewasm/hera/tags","blobs_url":"https://api.github.com/repos/ewasm/hera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ewasm/hera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ewasm/hera/git/refs{/sha}","trees_url":"https://api.github.com/repos/ewasm/hera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ewasm/hera/statuses/{sha}","languages_url":"https://api.github.com/repos/ewasm/hera/languages","stargazers_url":"https://api.github.com/repos/ewasm/hera/stargazers","contributors_url":"https://api.github.com/repos/ewasm/hera/contributors","subscribers_url":"https://api.github.com/repos/ewasm/hera/subscribers","subscription_url":"https://api.github.com/repos/ewasm/hera/subscription","commits_url":"https://api.github.com/repos/ewasm/hera/commits{/sha}","git_commits_url":"https://api.github.com/repos/ewasm/hera/git/commits{/sha}","comments_url":"https://api.github.com/repos/ewasm/hera/comments{/number}","issue_comment_url":"https://api.github.com/repos/ewasm/hera/issues/comments{/number}","contents_url":"https://api.github.com/repos/ewasm/hera/contents/{+path}","compare_url":"https://api.github.com/repos/ewasm/hera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ewasm/hera/merges","archive_url":"https://api.github.com/repos/ewasm/hera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ewasm/hera/downloads","issues_url":"https://api.github.com/repos/ewasm/hera/issues{/number}","pulls_url":"https://api.github.com/repos/ewasm/hera/pulls{/number}","milestones_url":"https://api.github.com/repos/ewasm/hera/milestones{/number}","notifications_url":"https://api.github.com/repos/ewasm/hera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ewasm/hera/labels{/name}","releases_url":"https://api.github.com/repos/ewasm/hera/releases{/id}","deployments_url":"https://api.github.com/repos/ewasm/hera/deployments","created_at":"2016-08-21T12:58:03Z","updated_at":"2018-08-26T23:58:15Z","pushed_at":"2018-08-27T14:17:55Z","git_url":"git://github.com/ewasm/hera.git","ssh_url":"git@github.com:ewasm/hera.git","clone_url":"https://github.com/ewasm/hera.git","svn_url":"https://github.com/ewasm/hera","homepage":"","size":628,"stargazers_count":64,"watchers_count":64,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":26,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ewasm/hera/pulls/367"},"html":{"href":"https://github.com/ewasm/hera/pull/367"},"issue":{"href":"https://api.github.com/repos/ewasm/hera/issues/367"},"comments":{"href":"https://api.github.com/repos/ewasm/hera/issues/367/comments"},"review_comments":{"href":"https://api.github.com/repos/ewasm/hera/pulls/367/comments"},"review_comment":{"href":"https://api.github.com/repos/ewasm/hera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ewasm/hera/pulls/367/commits"},"statuses":{"href":"https://api.github.com/repos/ewasm/hera/statuses/92ec3031f836c330d1d48cafa4291c591fa9b8b1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cdetrio"}}