{"action":"created","issue":{"url":"https://api.github.com/repos/videojs/http-streaming/issues/204","repository_url":"https://api.github.com/repos/videojs/http-streaming","labels_url":"https://api.github.com/repos/videojs/http-streaming/issues/204/labels{/name}","comments_url":"https://api.github.com/repos/videojs/http-streaming/issues/204/comments","events_url":"https://api.github.com/repos/videojs/http-streaming/issues/204/events","html_url":"https://github.com/videojs/http-streaming/pull/204","id":353876260,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwODA5MzE5","number":204,"title":"fix: fix replay functionality","user":{"login":"forbesjo","id":7529098,"node_id":"MDQ6VXNlcjc1MjkwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/7529098?v=4","gravatar_id":"","url":"https://api.github.com/users/forbesjo","html_url":"https://github.com/forbesjo","followers_url":"https://api.github.com/users/forbesjo/followers","following_url":"https://api.github.com/users/forbesjo/following{/other_user}","gists_url":"https://api.github.com/users/forbesjo/gists{/gist_id}","starred_url":"https://api.github.com/users/forbesjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forbesjo/subscriptions","organizations_url":"https://api.github.com/users/forbesjo/orgs","repos_url":"https://api.github.com/users/forbesjo/repos","events_url":"https://api.github.com/users/forbesjo/events{/privacy}","received_events_url":"https://api.github.com/users/forbesjo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-24T18:01:54Z","updated_at":"2018-08-24T21:45:34Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/videojs/http-streaming/pulls/204","html_url":"https://github.com/videojs/http-streaming/pull/204","diff_url":"https://github.com/videojs/http-streaming/pull/204.diff","patch_url":"https://github.com/videojs/http-streaming/pull/204.patch"},"body":"## Description\r\nFixes #201 \r\n\r\n## Specific Changes proposed\r\nReplay is broken because VHS is not loading the buffer when the video element seeks on replay. This previously worked because VHS would react to video element seek events. The seek caused by replay does not call `player.currentTime()` so the middleware does not kick in. This adds an additional middleware to call VHS's during play calls. \r\n\r\nPreviously the play method of VHS would not go down the ended -> seek to 0 path because the tech would have already seeked to 0 on it's own, then emitted a play event.\r\n\r\n## Requirements Checklist\r\n- [ ] Feature implemented / Bug fixed\r\n- [x] If necessary, more likely in a feature request than a bug fix\r\n  - [x] Unit Tests updated or fixed\r\n  - [ ] Docs/guides updated\r\n  - [ ] Example created ([starter template on JSBin](https://jsbin.com/gejugat/edit?html,output))\r\n- [ ] Reviewed by Two Core Contributors\r\n"},"comment":{"url":"https://api.github.com/repos/videojs/http-streaming/issues/comments/415890770","html_url":"https://github.com/videojs/http-streaming/pull/204#issuecomment-415890770","issue_url":"https://api.github.com/repos/videojs/http-streaming/issues/204","id":415890770,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTg5MDc3MA==","user":{"login":"forbesjo","id":7529098,"node_id":"MDQ6VXNlcjc1MjkwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/7529098?v=4","gravatar_id":"","url":"https://api.github.com/users/forbesjo","html_url":"https://github.com/forbesjo","followers_url":"https://api.github.com/users/forbesjo/followers","following_url":"https://api.github.com/users/forbesjo/following{/other_user}","gists_url":"https://api.github.com/users/forbesjo/gists{/gist_id}","starred_url":"https://api.github.com/users/forbesjo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forbesjo/subscriptions","organizations_url":"https://api.github.com/users/forbesjo/orgs","repos_url":"https://api.github.com/users/forbesjo/repos","events_url":"https://api.github.com/users/forbesjo/events{/privacy}","received_events_url":"https://api.github.com/users/forbesjo/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T21:45:34Z","updated_at":"2018-08-24T21:45:34Z","author_association":"COLLABORATOR","body":"Instead of calling VHS's play before the tech's play, I am syncing VHS with the player after play. This is because I had an issue with live streams where the VHS play assumes that the player is in a playing state."}}
{"actor":{"display_login":"forbesjo"}}