{"action":"created","comment":{"url":"https://api.github.com/repos/vcmi/vcmi/pulls/comments/177308808","pull_request_review_id":107153194,"id":177308808,"diff_hunk":"@@ -134,6 +134,9 @@ std::vector<std::shared_ptr<Bonus>> SpecialtyBonusToBonuses(const SSpecialtyBonu\n \r\n class DLL_LINKAGE CHeroClass\r\n {\r\n+private:\r\n+\t// used to store mapping until secondary skills have been loaded\r\n+\tstd::map<std::string, int> secSkillProbabilityMap;\r","path":"lib/CHeroHandler.h","position":6,"original_position":6,"commit_id":"f3298e17084efd254e91b8030b658e781ec37c25","original_commit_id":"e74025765a067a1c8e681461ae65f0adcea65f24","user":{"login":"alexvins","id":1083924,"avatar_url":"https://avatars0.githubusercontent.com/u/1083924?v=4","gravatar_id":"","url":"https://api.github.com/users/alexvins","html_url":"https://github.com/alexvins","followers_url":"https://api.github.com/users/alexvins/followers","following_url":"https://api.github.com/users/alexvins/following{/other_user}","gists_url":"https://api.github.com/users/alexvins/gists{/gist_id}","starred_url":"https://api.github.com/users/alexvins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexvins/subscriptions","organizations_url":"https://api.github.com/users/alexvins/orgs","repos_url":"https://api.github.com/users/alexvins/repos","events_url":"https://api.github.com/users/alexvins/events{/privacy}","received_events_url":"https://api.github.com/users/alexvins/received_events","type":"User","site_admin":false},"body":"You`re right this is yet another legacy","created_at":"2018-03-27T05:02:48Z","updated_at":"2018-03-27T05:02:49Z","html_url":"https://github.com/vcmi/vcmi/pull/438#discussion_r177308808","pull_request_url":"https://api.github.com/repos/vcmi/vcmi/pulls/438","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/vcmi/vcmi/pulls/comments/177308808"},"html":{"href":"https://github.com/vcmi/vcmi/pull/438#discussion_r177308808"},"pull_request":{"href":"https://api.github.com/repos/vcmi/vcmi/pulls/438"}},"in_reply_to_id":176991087},"pull_request":{"url":"https://api.github.com/repos/vcmi/vcmi/pulls/438","id":177257944,"html_url":"https://github.com/vcmi/vcmi/pull/438","diff_url":"https://github.com/vcmi/vcmi/pull/438.diff","patch_url":"https://github.com/vcmi/vcmi/pull/438.patch","issue_url":"https://api.github.com/repos/vcmi/vcmi/issues/438","number":438,"state":"open","locked":false,"title":"Allow the creation of new secondary skills","user":{"login":"henningkoehlernz","id":20719746,"avatar_url":"https://avatars2.githubusercontent.com/u/20719746?v=4","gravatar_id":"","url":"https://api.github.com/users/henningkoehlernz","html_url":"https://github.com/henningkoehlernz","followers_url":"https://api.github.com/users/henningkoehlernz/followers","following_url":"https://api.github.com/users/henningkoehlernz/following{/other_user}","gists_url":"https://api.github.com/users/henningkoehlernz/gists{/gist_id}","starred_url":"https://api.github.com/users/henningkoehlernz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henningkoehlernz/subscriptions","organizations_url":"https://api.github.com/users/henningkoehlernz/orgs","repos_url":"https://api.github.com/users/henningkoehlernz/repos","events_url":"https://api.github.com/users/henningkoehlernz/events{/privacy}","received_events_url":"https://api.github.com/users/henningkoehlernz/received_events","type":"User","site_admin":false},"body":"Skills gain the following new attributes (required for new skills, auto-populated for existing):\r\n* Images used for basic, advanced and expert level\r\n* Default probabilities to gain them for might/magic heroes (heroClass can override)\r\n\r\nKnown Limitations:\r\n* Maps cannot specify whether new skills are permitted (they always are)\r\n* Witch huts from loaded (as opposed to randomly generated) maps will never offer new skills\r\n\r\nMod for testing is available at https://github.com/henningkoehlernz/vcmi-mods (new_skills)","created_at":"2018-03-24T20:44:44Z","updated_at":"2018-03-27T05:02:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5dc064a13d7fe9d7cb54d3688ae0359fc5d999e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":90538254,"url":"https://api.github.com/repos/vcmi/vcmi/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/vcmi/vcmi/pulls/438/commits","review_comments_url":"https://api.github.com/repos/vcmi/vcmi/pulls/438/comments","review_comment_url":"https://api.github.com/repos/vcmi/vcmi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vcmi/vcmi/issues/438/comments","statuses_url":"https://api.github.com/repos/vcmi/vcmi/statuses/f3298e17084efd254e91b8030b658e781ec37c25","head":{"label":"vcmi:NEW_SECSKILLS","ref":"NEW_SECSKILLS","sha":"f3298e17084efd254e91b8030b658e781ec37c25","user":{"login":"vcmi","id":2861395,"avatar_url":"https://avatars3.githubusercontent.com/u/2861395?v=4","gravatar_id":"","url":"https://api.github.com/users/vcmi","html_url":"https://github.com/vcmi","followers_url":"https://api.github.com/users/vcmi/followers","following_url":"https://api.github.com/users/vcmi/following{/other_user}","gists_url":"https://api.github.com/users/vcmi/gists{/gist_id}","starred_url":"https://api.github.com/users/vcmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcmi/subscriptions","organizations_url":"https://api.github.com/users/vcmi/orgs","repos_url":"https://api.github.com/users/vcmi/repos","events_url":"https://api.github.com/users/vcmi/events{/privacy}","received_events_url":"https://api.github.com/users/vcmi/received_events","type":"Organization","site_admin":false},"repo":{"id":18490421,"name":"vcmi","full_name":"vcmi/vcmi","owner":{"login":"vcmi","id":2861395,"avatar_url":"https://avatars3.githubusercontent.com/u/2861395?v=4","gravatar_id":"","url":"https://api.github.com/users/vcmi","html_url":"https://github.com/vcmi","followers_url":"https://api.github.com/users/vcmi/followers","following_url":"https://api.github.com/users/vcmi/following{/other_user}","gists_url":"https://api.github.com/users/vcmi/gists{/gist_id}","starred_url":"https://api.github.com/users/vcmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcmi/subscriptions","organizations_url":"https://api.github.com/users/vcmi/orgs","repos_url":"https://api.github.com/users/vcmi/repos","events_url":"https://api.github.com/users/vcmi/events{/privacy}","received_events_url":"https://api.github.com/users/vcmi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vcmi/vcmi","description":"Open-source engine for Heroes of Might and Magic III","fork":false,"url":"https://api.github.com/repos/vcmi/vcmi","forks_url":"https://api.github.com/repos/vcmi/vcmi/forks","keys_url":"https://api.github.com/repos/vcmi/vcmi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vcmi/vcmi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vcmi/vcmi/teams","hooks_url":"https://api.github.com/repos/vcmi/vcmi/hooks","issue_events_url":"https://api.github.com/repos/vcmi/vcmi/issues/events{/number}","events_url":"https://api.github.com/repos/vcmi/vcmi/events","assignees_url":"https://api.github.com/repos/vcmi/vcmi/assignees{/user}","branches_url":"https://api.github.com/repos/vcmi/vcmi/branches{/branch}","tags_url":"https://api.github.com/repos/vcmi/vcmi/tags","blobs_url":"https://api.github.com/repos/vcmi/vcmi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vcmi/vcmi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vcmi/vcmi/git/refs{/sha}","trees_url":"https://api.github.com/repos/vcmi/vcmi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vcmi/vcmi/statuses/{sha}","languages_url":"https://api.github.com/repos/vcmi/vcmi/languages","stargazers_url":"https://api.github.com/repos/vcmi/vcmi/stargazers","contributors_url":"https://api.github.com/repos/vcmi/vcmi/contributors","subscribers_url":"https://api.github.com/repos/vcmi/vcmi/subscribers","subscription_url":"https://api.github.com/repos/vcmi/vcmi/subscription","commits_url":"https://api.github.com/repos/vcmi/vcmi/commits{/sha}","git_commits_url":"https://api.github.com/repos/vcmi/vcmi/git/commits{/sha}","comments_url":"https://api.github.com/repos/vcmi/vcmi/comments{/number}","issue_comment_url":"https://api.github.com/repos/vcmi/vcmi/issues/comments{/number}","contents_url":"https://api.github.com/repos/vcmi/vcmi/contents/{+path}","compare_url":"https://api.github.com/repos/vcmi/vcmi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vcmi/vcmi/merges","archive_url":"https://api.github.com/repos/vcmi/vcmi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vcmi/vcmi/downloads","issues_url":"https://api.github.com/repos/vcmi/vcmi/issues{/number}","pulls_url":"https://api.github.com/repos/vcmi/vcmi/pulls{/number}","milestones_url":"https://api.github.com/repos/vcmi/vcmi/milestones{/number}","notifications_url":"https://api.github.com/repos/vcmi/vcmi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vcmi/vcmi/labels{/name}","releases_url":"https://api.github.com/repos/vcmi/vcmi/releases{/id}","deployments_url":"https://api.github.com/repos/vcmi/vcmi/deployments","created_at":"2014-04-06T13:42:23Z","updated_at":"2018-03-24T16:10:04Z","pushed_at":"2018-03-26T23:28:05Z","git_url":"git://github.com/vcmi/vcmi.git","ssh_url":"git@github.com:vcmi/vcmi.git","clone_url":"https://github.com/vcmi/vcmi.git","svn_url":"https://github.com/vcmi/vcmi","homepage":"https://vcmi.eu/","size":35544,"stargazers_count":780,"watchers_count":780,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":147,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":147,"open_issues":14,"watchers":780,"default_branch":"develop"}},"base":{"label":"vcmi:develop","ref":"develop","sha":"2b64bf29ed13a96e652e23746564022f8f65f7a1","user":{"login":"vcmi","id":2861395,"avatar_url":"https://avatars3.githubusercontent.com/u/2861395?v=4","gravatar_id":"","url":"https://api.github.com/users/vcmi","html_url":"https://github.com/vcmi","followers_url":"https://api.github.com/users/vcmi/followers","following_url":"https://api.github.com/users/vcmi/following{/other_user}","gists_url":"https://api.github.com/users/vcmi/gists{/gist_id}","starred_url":"https://api.github.com/users/vcmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcmi/subscriptions","organizations_url":"https://api.github.com/users/vcmi/orgs","repos_url":"https://api.github.com/users/vcmi/repos","events_url":"https://api.github.com/users/vcmi/events{/privacy}","received_events_url":"https://api.github.com/users/vcmi/received_events","type":"Organization","site_admin":false},"repo":{"id":18490421,"name":"vcmi","full_name":"vcmi/vcmi","owner":{"login":"vcmi","id":2861395,"avatar_url":"https://avatars3.githubusercontent.com/u/2861395?v=4","gravatar_id":"","url":"https://api.github.com/users/vcmi","html_url":"https://github.com/vcmi","followers_url":"https://api.github.com/users/vcmi/followers","following_url":"https://api.github.com/users/vcmi/following{/other_user}","gists_url":"https://api.github.com/users/vcmi/gists{/gist_id}","starred_url":"https://api.github.com/users/vcmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcmi/subscriptions","organizations_url":"https://api.github.com/users/vcmi/orgs","repos_url":"https://api.github.com/users/vcmi/repos","events_url":"https://api.github.com/users/vcmi/events{/privacy}","received_events_url":"https://api.github.com/users/vcmi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vcmi/vcmi","description":"Open-source engine for Heroes of Might and Magic III","fork":false,"url":"https://api.github.com/repos/vcmi/vcmi","forks_url":"https://api.github.com/repos/vcmi/vcmi/forks","keys_url":"https://api.github.com/repos/vcmi/vcmi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vcmi/vcmi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vcmi/vcmi/teams","hooks_url":"https://api.github.com/repos/vcmi/vcmi/hooks","issue_events_url":"https://api.github.com/repos/vcmi/vcmi/issues/events{/number}","events_url":"https://api.github.com/repos/vcmi/vcmi/events","assignees_url":"https://api.github.com/repos/vcmi/vcmi/assignees{/user}","branches_url":"https://api.github.com/repos/vcmi/vcmi/branches{/branch}","tags_url":"https://api.github.com/repos/vcmi/vcmi/tags","blobs_url":"https://api.github.com/repos/vcmi/vcmi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vcmi/vcmi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vcmi/vcmi/git/refs{/sha}","trees_url":"https://api.github.com/repos/vcmi/vcmi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vcmi/vcmi/statuses/{sha}","languages_url":"https://api.github.com/repos/vcmi/vcmi/languages","stargazers_url":"https://api.github.com/repos/vcmi/vcmi/stargazers","contributors_url":"https://api.github.com/repos/vcmi/vcmi/contributors","subscribers_url":"https://api.github.com/repos/vcmi/vcmi/subscribers","subscription_url":"https://api.github.com/repos/vcmi/vcmi/subscription","commits_url":"https://api.github.com/repos/vcmi/vcmi/commits{/sha}","git_commits_url":"https://api.github.com/repos/vcmi/vcmi/git/commits{/sha}","comments_url":"https://api.github.com/repos/vcmi/vcmi/comments{/number}","issue_comment_url":"https://api.github.com/repos/vcmi/vcmi/issues/comments{/number}","contents_url":"https://api.github.com/repos/vcmi/vcmi/contents/{+path}","compare_url":"https://api.github.com/repos/vcmi/vcmi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vcmi/vcmi/merges","archive_url":"https://api.github.com/repos/vcmi/vcmi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vcmi/vcmi/downloads","issues_url":"https://api.github.com/repos/vcmi/vcmi/issues{/number}","pulls_url":"https://api.github.com/repos/vcmi/vcmi/pulls{/number}","milestones_url":"https://api.github.com/repos/vcmi/vcmi/milestones{/number}","notifications_url":"https://api.github.com/repos/vcmi/vcmi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vcmi/vcmi/labels{/name}","releases_url":"https://api.github.com/repos/vcmi/vcmi/releases{/id}","deployments_url":"https://api.github.com/repos/vcmi/vcmi/deployments","created_at":"2014-04-06T13:42:23Z","updated_at":"2018-03-24T16:10:04Z","pushed_at":"2018-03-26T23:28:05Z","git_url":"git://github.com/vcmi/vcmi.git","ssh_url":"git@github.com:vcmi/vcmi.git","clone_url":"https://github.com/vcmi/vcmi.git","svn_url":"https://github.com/vcmi/vcmi","homepage":"https://vcmi.eu/","size":35544,"stargazers_count":780,"watchers_count":780,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":147,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":147,"open_issues":14,"watchers":780,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/vcmi/vcmi/pulls/438"},"html":{"href":"https://github.com/vcmi/vcmi/pull/438"},"issue":{"href":"https://api.github.com/repos/vcmi/vcmi/issues/438"},"comments":{"href":"https://api.github.com/repos/vcmi/vcmi/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/vcmi/vcmi/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/vcmi/vcmi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vcmi/vcmi/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/vcmi/vcmi/statuses/f3298e17084efd254e91b8030b658e781ec37c25"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"alexvins"}}