{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/docs/pulls/comments/173764836","pull_request_review_id":103004576,"id":173764836,"diff_hunk":"@@ -133,6 +133,8 @@ zookeeper_addrs = \"192.168.0.11:2181,192.168.0.12:2181,192.168.0.13:2181\"\n         to configure the file path of Pump; if you specifies the configuration file, Pump reads the configuration first; if the corresponding configuration also exists in the command line argument, Pump uses the command line configuration to cover that in the configuration file\n     -data-dir string\n         the path of storing Pump data\n+    -enable-tolerant\n+\tafter enable tolerant, pump wouldn't return error if it fails to write binlog (default true)","path":"tools/tidb-binlog-kafka.md","position":5,"original_position":5,"commit_id":"63c199d29c6b0e8ca9144e4a2e7a6fdda99e5242","original_commit_id":"63c199d29c6b0e8ca9144e4a2e7a6fdda99e5242","user":{"login":"lilin90","id":30922556,"avatar_url":"https://avatars1.githubusercontent.com/u/30922556?v=4","gravatar_id":"","url":"https://api.github.com/users/lilin90","html_url":"https://github.com/lilin90","followers_url":"https://api.github.com/users/lilin90/followers","following_url":"https://api.github.com/users/lilin90/following{/other_user}","gists_url":"https://api.github.com/users/lilin90/gists{/gist_id}","starred_url":"https://api.github.com/users/lilin90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilin90/subscriptions","organizations_url":"https://api.github.com/users/lilin90/orgs","repos_url":"https://api.github.com/users/lilin90/repos","events_url":"https://api.github.com/users/lilin90/events{/privacy}","received_events_url":"https://api.github.com/users/lilin90/received_events","type":"User","site_admin":false},"body":"- after enable -> after enabling\r\n- pump -> Pump","created_at":"2018-03-12T11:27:20Z","updated_at":"2018-03-12T11:27:20Z","html_url":"https://github.com/pingcap/docs/pull/345#discussion_r173764836","pull_request_url":"https://api.github.com/repos/pingcap/docs/pulls/345","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pingcap/docs/pulls/comments/173764836"},"html":{"href":"https://github.com/pingcap/docs/pull/345#discussion_r173764836"},"pull_request":{"href":"https://api.github.com/repos/pingcap/docs/pulls/345"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/docs/pulls/345","id":167614593,"html_url":"https://github.com/pingcap/docs/pull/345","diff_url":"https://github.com/pingcap/docs/pull/345.diff","patch_url":"https://github.com/pingcap/docs/pull/345.patch","issue_url":"https://api.github.com/repos/pingcap/docs/issues/345","number":345,"state":"open","locked":false,"title":"binlog: add new cmd flag","user":{"login":"GregoryIan","id":10701973,"avatar_url":"https://avatars3.githubusercontent.com/u/10701973?v=4","gravatar_id":"","url":"https://api.github.com/users/GregoryIan","html_url":"https://github.com/GregoryIan","followers_url":"https://api.github.com/users/GregoryIan/followers","following_url":"https://api.github.com/users/GregoryIan/following{/other_user}","gists_url":"https://api.github.com/users/GregoryIan/gists{/gist_id}","starred_url":"https://api.github.com/users/GregoryIan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregoryIan/subscriptions","organizations_url":"https://api.github.com/users/GregoryIan/orgs","repos_url":"https://api.github.com/users/GregoryIan/repos","events_url":"https://api.github.com/users/GregoryIan/events{/privacy}","received_events_url":"https://api.github.com/users/GregoryIan/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-07T07:14:49Z","updated_at":"2018-03-12T11:27:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cfe22794b7993bd3a8f93be844479be5da4755f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/docs/pulls/345/commits","review_comments_url":"https://api.github.com/repos/pingcap/docs/pulls/345/comments","review_comment_url":"https://api.github.com/repos/pingcap/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/docs/issues/345/comments","statuses_url":"https://api.github.com/repos/pingcap/docs/statuses/63c199d29c6b0e8ca9144e4a2e7a6fdda99e5242","head":{"label":"pingcap:ian/binlog","ref":"ian/binlog","sha":"63c199d29c6b0e8ca9144e4a2e7a6fdda99e5242","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":63995402,"name":"docs","full_name":"pingcap/docs","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/docs","description":"TiDB/TiKV/PD documents.","fork":false,"url":"https://api.github.com/repos/pingcap/docs","forks_url":"https://api.github.com/repos/pingcap/docs/forks","keys_url":"https://api.github.com/repos/pingcap/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/docs/teams","hooks_url":"https://api.github.com/repos/pingcap/docs/hooks","issue_events_url":"https://api.github.com/repos/pingcap/docs/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/docs/events","assignees_url":"https://api.github.com/repos/pingcap/docs/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/docs/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/docs/tags","blobs_url":"https://api.github.com/repos/pingcap/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/docs/languages","stargazers_url":"https://api.github.com/repos/pingcap/docs/stargazers","contributors_url":"https://api.github.com/repos/pingcap/docs/contributors","subscribers_url":"https://api.github.com/repos/pingcap/docs/subscribers","subscription_url":"https://api.github.com/repos/pingcap/docs/subscription","commits_url":"https://api.github.com/repos/pingcap/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/docs/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/docs/merges","archive_url":"https://api.github.com/repos/pingcap/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/docs/downloads","issues_url":"https://api.github.com/repos/pingcap/docs/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/docs/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/docs/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/docs/deployments","created_at":"2016-07-23T02:39:04Z","updated_at":"2018-03-12T10:09:41Z","pushed_at":"2018-03-12T11:12:56Z","git_url":"git://github.com/pingcap/docs.git","ssh_url":"git@github.com:pingcap/docs.git","clone_url":"https://github.com/pingcap/docs.git","svn_url":"https://github.com/pingcap/docs","homepage":"https://pingcap.github.io/docs","size":2991,"stargazers_count":107,"watchers_count":107,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":76,"open_issues":17,"watchers":107,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"8c83f12af8ca2efed88e50e3f8cd2c2c6f501546","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":63995402,"name":"docs","full_name":"pingcap/docs","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/docs","description":"TiDB/TiKV/PD documents.","fork":false,"url":"https://api.github.com/repos/pingcap/docs","forks_url":"https://api.github.com/repos/pingcap/docs/forks","keys_url":"https://api.github.com/repos/pingcap/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/docs/teams","hooks_url":"https://api.github.com/repos/pingcap/docs/hooks","issue_events_url":"https://api.github.com/repos/pingcap/docs/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/docs/events","assignees_url":"https://api.github.com/repos/pingcap/docs/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/docs/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/docs/tags","blobs_url":"https://api.github.com/repos/pingcap/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/docs/languages","stargazers_url":"https://api.github.com/repos/pingcap/docs/stargazers","contributors_url":"https://api.github.com/repos/pingcap/docs/contributors","subscribers_url":"https://api.github.com/repos/pingcap/docs/subscribers","subscription_url":"https://api.github.com/repos/pingcap/docs/subscription","commits_url":"https://api.github.com/repos/pingcap/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/docs/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/docs/merges","archive_url":"https://api.github.com/repos/pingcap/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/docs/downloads","issues_url":"https://api.github.com/repos/pingcap/docs/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/docs/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/docs/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/docs/deployments","created_at":"2016-07-23T02:39:04Z","updated_at":"2018-03-12T10:09:41Z","pushed_at":"2018-03-12T11:12:56Z","git_url":"git://github.com/pingcap/docs.git","ssh_url":"git@github.com:pingcap/docs.git","clone_url":"https://github.com/pingcap/docs.git","svn_url":"https://github.com/pingcap/docs","homepage":"https://pingcap.github.io/docs","size":2991,"stargazers_count":107,"watchers_count":107,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":76,"open_issues":17,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/docs/pulls/345"},"html":{"href":"https://github.com/pingcap/docs/pull/345"},"issue":{"href":"https://api.github.com/repos/pingcap/docs/issues/345"},"comments":{"href":"https://api.github.com/repos/pingcap/docs/issues/345/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/docs/pulls/345/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/docs/pulls/345/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/docs/statuses/63c199d29c6b0e8ca9144e4a2e7a6fdda99e5242"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lilin90"}}