{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/167720294","pull_request_review_id":95980407,"id":167720294,"diff_hunk":"@@ -0,0 +1,72 @@\n+OpenAMP Example Application\n+===========================\n+\n+Overview\n+--------\n+\n+This application demostrates how to use OpenAMP with Zephyr. It is designed to\n+be an OpenAMP counterpart to the RPMsg-Lite example for the LPCXpresso5411x\n+chip, to be used for comparison and benchmarking of the two RPC libraries.\n+\n+Building this application\n+-------------------------","path":"samples/subsys/ipc/openamp/README.md","position":12,"original_position":12,"commit_id":"fc2989edad3b593cb993c224f1e2a55e02ba2aa2","original_commit_id":"fc2989edad3b593cb993c224f1e2a55e02ba2aa2","user":{"login":"dbkinder","id":11063618,"avatar_url":"https://avatars0.githubusercontent.com/u/11063618?v=4","gravatar_id":"","url":"https://api.github.com/users/dbkinder","html_url":"https://github.com/dbkinder","followers_url":"https://api.github.com/users/dbkinder/followers","following_url":"https://api.github.com/users/dbkinder/following{/other_user}","gists_url":"https://api.github.com/users/dbkinder/gists{/gist_id}","starred_url":"https://api.github.com/users/dbkinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbkinder/subscriptions","organizations_url":"https://api.github.com/users/dbkinder/orgs","repos_url":"https://api.github.com/users/dbkinder/repos","events_url":"https://api.github.com/users/dbkinder/events{/privacy}","received_events_url":"https://api.github.com/users/dbkinder/received_events","type":"User","site_admin":false},"body":"use *** underlines here","created_at":"2018-02-12T23:31:40Z","updated_at":"2018-02-12T23:52:00Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/6153#discussion_r167720294","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/6153","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/167720294"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/6153#discussion_r167720294"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/6153"}}},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/6153","id":168598340,"html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/6153","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/6153.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/6153.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/6153","number":6153,"state":"open","locked":false,"title":"[DNM][RFC] RPMsg-Lite and OpenAMP side-by-side","user":{"login":"skordal","id":1273064,"avatar_url":"https://avatars1.githubusercontent.com/u/1273064?v=4","gravatar_id":"","url":"https://api.github.com/users/skordal","html_url":"https://github.com/skordal","followers_url":"https://api.github.com/users/skordal/followers","following_url":"https://api.github.com/users/skordal/following{/other_user}","gists_url":"https://api.github.com/users/skordal/gists{/gist_id}","starred_url":"https://api.github.com/users/skordal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skordal/subscriptions","organizations_url":"https://api.github.com/users/skordal/orgs","repos_url":"https://api.github.com/users/skordal/repos","events_url":"https://api.github.com/users/skordal/events{/privacy}","received_events_url":"https://api.github.com/users/skordal/received_events","type":"User","site_admin":false},"body":"This pull request adds an example application using OpenAMP to do multiprocessor communication. It is adapted from the recently posted RPMsg-Lite example application, from PR #5960. This application is intended to provide a starting-point for comparison and benchmarking of RPMsg-Lite and OpenAMP, see issue #3065.\r\n\r\nThe relevant commit in this PR is the most recent commit, fc2989e. However, since the code is dependent on changes included in PR #5960, the commits from that PR is also included here.\r\n\r\nI have added build instructions in a README.md file, located in samples/subsys/ipc/openamp/README.md.\r\n\r\nSome details:\r\n- The OpenAMP example uses the SRAMX RAM block as shared memory, to provide better separation between shared RAM and the RAM that is being used by the application. This also simplified the linking of the application.\r\n- Heap size had to be overridden in the default board configuration for both the cores in the LPC54114. This is because the heap size is needed (at compile-time) for libmetal, and when compiling libraries outside of the zephyr application folders, only the default board configuration is used.\r\n- Due to the use of static libraries, the order that the libraries are provided to the linker in matters. The libkernel.a must be linked last, and the CMakeLists.txt files contains code to fix this.\r\n\r\n","created_at":"2018-02-12T14:50:24Z","updated_at":"2018-02-12T23:52:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"nashif","id":180017,"avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false},{"login":"MaureenHelm","id":6172539,"avatar_url":"https://avatars2.githubusercontent.com/u/6172539?v=4","gravatar_id":"","url":"https://api.github.com/users/MaureenHelm","html_url":"https://github.com/MaureenHelm","followers_url":"https://api.github.com/users/MaureenHelm/followers","following_url":"https://api.github.com/users/MaureenHelm/following{/other_user}","gists_url":"https://api.github.com/users/MaureenHelm/gists{/gist_id}","starred_url":"https://api.github.com/users/MaureenHelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaureenHelm/subscriptions","organizations_url":"https://api.github.com/users/MaureenHelm/orgs","repos_url":"https://api.github.com/users/MaureenHelm/repos","events_url":"https://api.github.com/users/MaureenHelm/events{/privacy}","received_events_url":"https://api.github.com/users/MaureenHelm/received_events","type":"User","site_admin":false},{"login":"galak","id":16417047,"avatar_url":"https://avatars2.githubusercontent.com/u/16417047?v=4","gravatar_id":"","url":"https://api.github.com/users/galak","html_url":"https://github.com/galak","followers_url":"https://api.github.com/users/galak/followers","following_url":"https://api.github.com/users/galak/following{/other_user}","gists_url":"https://api.github.com/users/galak/gists{/gist_id}","starred_url":"https://api.github.com/users/galak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galak/subscriptions","organizations_url":"https://api.github.com/users/galak/orgs","repos_url":"https://api.github.com/users/galak/repos","events_url":"https://api.github.com/users/galak/events{/privacy}","received_events_url":"https://api.github.com/users/galak/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/6153/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/6153/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/6153/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/fc2989edad3b593cb993c224f1e2a55e02ba2aa2","head":{"label":"skordal:openamp-example","ref":"openamp-example","sha":"fc2989edad3b593cb993c224f1e2a55e02ba2aa2","user":{"login":"skordal","id":1273064,"avatar_url":"https://avatars1.githubusercontent.com/u/1273064?v=4","gravatar_id":"","url":"https://api.github.com/users/skordal","html_url":"https://github.com/skordal","followers_url":"https://api.github.com/users/skordal/followers","following_url":"https://api.github.com/users/skordal/following{/other_user}","gists_url":"https://api.github.com/users/skordal/gists{/gist_id}","starred_url":"https://api.github.com/users/skordal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skordal/subscriptions","organizations_url":"https://api.github.com/users/skordal/orgs","repos_url":"https://api.github.com/users/skordal/repos","events_url":"https://api.github.com/users/skordal/events{/privacy}","received_events_url":"https://api.github.com/users/skordal/received_events","type":"User","site_admin":false},"repo":{"id":117664007,"name":"zephyr","full_name":"skordal/zephyr","owner":{"login":"skordal","id":1273064,"avatar_url":"https://avatars1.githubusercontent.com/u/1273064?v=4","gravatar_id":"","url":"https://api.github.com/users/skordal","html_url":"https://github.com/skordal","followers_url":"https://api.github.com/users/skordal/followers","following_url":"https://api.github.com/users/skordal/following{/other_user}","gists_url":"https://api.github.com/users/skordal/gists{/gist_id}","starred_url":"https://api.github.com/users/skordal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skordal/subscriptions","organizations_url":"https://api.github.com/users/skordal/orgs","repos_url":"https://api.github.com/users/skordal/repos","events_url":"https://api.github.com/users/skordal/events{/privacy}","received_events_url":"https://api.github.com/users/skordal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skordal/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/skordal/zephyr","forks_url":"https://api.github.com/repos/skordal/zephyr/forks","keys_url":"https://api.github.com/repos/skordal/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skordal/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skordal/zephyr/teams","hooks_url":"https://api.github.com/repos/skordal/zephyr/hooks","issue_events_url":"https://api.github.com/repos/skordal/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/skordal/zephyr/events","assignees_url":"https://api.github.com/repos/skordal/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/skordal/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/skordal/zephyr/tags","blobs_url":"https://api.github.com/repos/skordal/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skordal/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skordal/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/skordal/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skordal/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/skordal/zephyr/languages","stargazers_url":"https://api.github.com/repos/skordal/zephyr/stargazers","contributors_url":"https://api.github.com/repos/skordal/zephyr/contributors","subscribers_url":"https://api.github.com/repos/skordal/zephyr/subscribers","subscription_url":"https://api.github.com/repos/skordal/zephyr/subscription","commits_url":"https://api.github.com/repos/skordal/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/skordal/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/skordal/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/skordal/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/skordal/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/skordal/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skordal/zephyr/merges","archive_url":"https://api.github.com/repos/skordal/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skordal/zephyr/downloads","issues_url":"https://api.github.com/repos/skordal/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/skordal/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/skordal/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/skordal/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skordal/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/skordal/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/skordal/zephyr/deployments","created_at":"2018-01-16T09:39:28Z","updated_at":"2018-01-16T09:40:03Z","pushed_at":"2018-02-12T14:43:24Z","git_url":"git://github.com/skordal/zephyr.git","ssh_url":"git@github.com:skordal/zephyr.git","clone_url":"https://github.com/skordal/zephyr.git","svn_url":"https://github.com/skordal/zephyr","homepage":"http://zephyrproject.org/doc","size":100188,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"bd2838bb78898c34dfc8bc9c3b91c42ee9405f07","user":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"name":"zephyr","full_name":"zephyrproject-rtos/zephyr","owner":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-02-11T21:01:01Z","pushed_at":"2018-02-12T23:24:56Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"http://zephyrproject.org/doc","size":101109,"stargazers_count":630,"watchers_count":630,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":454,"mirror_url":null,"archived":false,"open_issues_count":771,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":454,"open_issues":771,"watchers":630,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/6153"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/6153"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/6153"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/6153/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/6153/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/6153/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/fc2989edad3b593cb993c224f1e2a55e02ba2aa2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dbkinder"}}