{"action":"created","issue":{"url":"https://api.github.com/repos/bosnet/sebak/issues/240","repository_url":"https://api.github.com/repos/bosnet/sebak","labels_url":"https://api.github.com/repos/bosnet/sebak/issues/240/labels{/name}","comments_url":"https://api.github.com/repos/bosnet/sebak/issues/240/comments","events_url":"https://api.github.com/repos/bosnet/sebak/issues/240/events","html_url":"https://github.com/bosnet/sebak/pull/240","id":349895106,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODc1Mzcz","number":240,"title":"fixed bugs from latest new-proposer","user":{"login":"spikeekips","id":174565,"node_id":"MDQ6VXNlcjE3NDU2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174565?v=4","gravatar_id":"","url":"https://api.github.com/users/spikeekips","html_url":"https://github.com/spikeekips","followers_url":"https://api.github.com/users/spikeekips/followers","following_url":"https://api.github.com/users/spikeekips/following{/other_user}","gists_url":"https://api.github.com/users/spikeekips/gists{/gist_id}","starred_url":"https://api.github.com/users/spikeekips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikeekips/subscriptions","organizations_url":"https://api.github.com/users/spikeekips/orgs","repos_url":"https://api.github.com/users/spikeekips/repos","events_url":"https://api.github.com/users/spikeekips/events{/privacy}","received_events_url":"https://api.github.com/users/spikeekips/received_events","type":"User","site_admin":false},"labels":[{"id":1017735127,"node_id":"MDU6TGFiZWwxMDE3NzM1MTI3","url":"https://api.github.com/repos/bosnet/sebak/labels/Consensus","name":"Consensus","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":{"login":"spikeekips","id":174565,"node_id":"MDQ6VXNlcjE3NDU2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174565?v=4","gravatar_id":"","url":"https://api.github.com/users/spikeekips","html_url":"https://github.com/spikeekips","followers_url":"https://api.github.com/users/spikeekips/followers","following_url":"https://api.github.com/users/spikeekips/following{/other_user}","gists_url":"https://api.github.com/users/spikeekips/gists{/gist_id}","starred_url":"https://api.github.com/users/spikeekips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikeekips/subscriptions","organizations_url":"https://api.github.com/users/spikeekips/orgs","repos_url":"https://api.github.com/users/spikeekips/repos","events_url":"https://api.github.com/users/spikeekips/events{/privacy}","received_events_url":"https://api.github.com/users/spikeekips/received_events","type":"User","site_admin":false},"assignees":[{"login":"spikeekips","id":174565,"node_id":"MDQ6VXNlcjE3NDU2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174565?v=4","gravatar_id":"","url":"https://api.github.com/users/spikeekips","html_url":"https://github.com/spikeekips","followers_url":"https://api.github.com/users/spikeekips/followers","following_url":"https://api.github.com/users/spikeekips/following{/other_user}","gists_url":"https://api.github.com/users/spikeekips/gists{/gist_id}","starred_url":"https://api.github.com/users/spikeekips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikeekips/subscriptions","organizations_url":"https://api.github.com/users/spikeekips/orgs","repos_url":"https://api.github.com/users/spikeekips/repos","events_url":"https://api.github.com/users/spikeekips/events{/privacy}","received_events_url":"https://api.github.com/users/spikeekips/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/bosnet/sebak/milestones/2","html_url":"https://github.com/bosnet/sebak/milestone/2","labels_url":"https://api.github.com/repos/bosnet/sebak/milestones/2/labels","id":3392946,"node_id":"MDk6TWlsZXN0b25lMzM5Mjk0Ng==","number":2,"title":"After Opening Testnet","description":"Implemented the Must-Be features to complete testnet","creator":{"login":"spikeekips","id":174565,"node_id":"MDQ6VXNlcjE3NDU2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174565?v=4","gravatar_id":"","url":"https://api.github.com/users/spikeekips","html_url":"https://github.com/spikeekips","followers_url":"https://api.github.com/users/spikeekips/followers","following_url":"https://api.github.com/users/spikeekips/following{/other_user}","gists_url":"https://api.github.com/users/spikeekips/gists{/gist_id}","starred_url":"https://api.github.com/users/spikeekips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikeekips/subscriptions","organizations_url":"https://api.github.com/users/spikeekips/orgs","repos_url":"https://api.github.com/users/spikeekips/repos","events_url":"https://api.github.com/users/spikeekips/events{/privacy}","received_events_url":"https://api.github.com/users/spikeekips/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":7,"state":"open","created_at":"2018-06-01T09:57:53Z","updated_at":"2018-08-15T04:19:09Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2018-08-13T05:49:19Z","updated_at":"2018-08-16T06:26:59Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bosnet/sebak/pulls/240","html_url":"https://github.com/bosnet/sebak/pull/240","diff_url":"https://github.com/bosnet/sebak/pull/240.diff","patch_url":"https://github.com/bosnet/sebak/pull/240.patch"},"body":"### Github Issue\r\nresolve #216 \r\n\r\n### Background\r\nThe latest commit, ab675b4428e57fafb10fd2645bc3654d8d654255 of new-proposer has some bugs.\r\n\r\n* `cmd/sebak/cmd/run.go` does not have `SIGN` and `ACCEPT` threshold.\r\n* `CheckNodeRunnerHandleACCEPTBallotValidateResult` is duplicated with `CheckNodeRunnerHandleBallotCheckResult`.\r\n* `checker.FinishedVotingHole` in `checker.NodeRunner.Consensus().CloseConsensus()` \r\n* `checkTransactionSourceCheck` moved to `Transaction.Validate()`\r\n* some test code fixed.\r\n\r\nI tried to fix them. And further more, added documentations for functions in `node_runner_checker.go` and `node_runner_transaction_checker.go`."},"comment":{"url":"https://api.github.com/repos/bosnet/sebak/issues/comments/413439494","html_url":"https://github.com/bosnet/sebak/pull/240#issuecomment-413439494","issue_url":"https://api.github.com/repos/bosnet/sebak/issues/240","id":413439494,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzQzOTQ5NA==","user":{"login":"spikeekips","id":174565,"node_id":"MDQ6VXNlcjE3NDU2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174565?v=4","gravatar_id":"","url":"https://api.github.com/users/spikeekips","html_url":"https://github.com/spikeekips","followers_url":"https://api.github.com/users/spikeekips/followers","following_url":"https://api.github.com/users/spikeekips/following{/other_user}","gists_url":"https://api.github.com/users/spikeekips/gists{/gist_id}","starred_url":"https://api.github.com/users/spikeekips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikeekips/subscriptions","organizations_url":"https://api.github.com/users/spikeekips/orgs","repos_url":"https://api.github.com/users/spikeekips/repos","events_url":"https://api.github.com/users/spikeekips/events{/privacy}","received_events_url":"https://api.github.com/users/spikeekips/received_events","type":"User","site_admin":false},"created_at":"2018-08-16T06:26:59Z","updated_at":"2018-08-16T06:26:59Z","author_association":"MEMBER","body":"@Geod24 Ping a316fbbfae7393bef7c462de0a3c9d6b94ac6297 "}}
{"actor":{"display_login":"spikeekips"}}