{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/beacon_chain/issues/100","repository_url":"https://api.github.com/repos/ethereum/beacon_chain","labels_url":"https://api.github.com/repos/ethereum/beacon_chain/issues/100/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/beacon_chain/issues/100/comments","events_url":"https://api.github.com/repos/ethereum/beacon_chain/issues/100/events","html_url":"https://github.com/ethereum/beacon_chain/issues/100","id":360615245,"node_id":"MDU6SXNzdWUzNjA2MTUyNDU=","number":100,"title":"Refactor and write tests for Simple Serialization (SSZ)","user":{"login":"hwwhww","id":9263930,"node_id":"MDQ6VXNlcjkyNjM5MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/9263930?v=4","gravatar_id":"","url":"https://api.github.com/users/hwwhww","html_url":"https://github.com/hwwhww","followers_url":"https://api.github.com/users/hwwhww/followers","following_url":"https://api.github.com/users/hwwhww/following{/other_user}","gists_url":"https://api.github.com/users/hwwhww/gists{/gist_id}","starred_url":"https://api.github.com/users/hwwhww/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwwhww/subscriptions","organizations_url":"https://api.github.com/users/hwwhww/orgs","repos_url":"https://api.github.com/users/hwwhww/repos","events_url":"https://api.github.com/users/hwwhww/events{/privacy}","received_events_url":"https://api.github.com/users/hwwhww/received_events","type":"User","site_admin":false},"labels":[{"id":965973847,"node_id":"MDU6TGFiZWw5NjU5NzM4NDc=","url":"https://api.github.com/repos/ethereum/beacon_chain/labels/good%20first%20issue","name":"good first issue","color":"7057ff","default":true},{"id":1056430166,"node_id":"MDU6TGFiZWwxMDU2NDMwMTY2","url":"https://api.github.com/repos/ethereum/beacon_chain/labels/ssz","name":"ssz","color":"8ad802","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-16T08:01:52Z","updated_at":"2018-09-20T07:28:19Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"### What's wrong?\r\nCurrently, the tests are at [tests/utils/test_serialization.py](https://github.com/ethereum/beacon_chain/blob/ad1cbc8896b2ba2d623e5499b3c58244d068878e/tests/utils/test_serialization.py), and it's using `ActiveState` and `PartialCrosslinkRecord` classes for testing. It will be nice to use some testing-only Foo classes to cover more testing cases instead of having a dependency of `beacon_chain`.\r\n\r\n### How can it be fixed\r\nWrite new tests at `tests/ssz/test_*.py`. Cover all test cases.\r\nIncludes:\r\n1. Add tests of serialization and deserialization of every type (ref: https://github.com/sigp/lighthouse/tree/ssz-readme/ssz#serializeencode)\r\n2. Refactor SSZ module\r\n    * Error handling\r\n    * Does it make sense to make a [Serializable class like RLP](https://github.com/ethereum/pyrlp/blob/dac32a31336c9452ee92a59eb0c8f460573abea2/rlp/sedes/serializable.py#L189)?\r\n"},"comment":{"url":"https://api.github.com/repos/ethereum/beacon_chain/issues/comments/423071368","html_url":"https://github.com/ethereum/beacon_chain/issues/100#issuecomment-423071368","issue_url":"https://api.github.com/repos/ethereum/beacon_chain/issues/100","id":423071368,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzA3MTM2OA==","user":{"login":"Poseyy","id":33185528,"node_id":"MDQ6VXNlcjMzMTg1NTI4","avatar_url":"https://avatars2.githubusercontent.com/u/33185528?v=4","gravatar_id":"","url":"https://api.github.com/users/Poseyy","html_url":"https://github.com/Poseyy","followers_url":"https://api.github.com/users/Poseyy/followers","following_url":"https://api.github.com/users/Poseyy/following{/other_user}","gists_url":"https://api.github.com/users/Poseyy/gists{/gist_id}","starred_url":"https://api.github.com/users/Poseyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Poseyy/subscriptions","organizations_url":"https://api.github.com/users/Poseyy/orgs","repos_url":"https://api.github.com/users/Poseyy/repos","events_url":"https://api.github.com/users/Poseyy/events{/privacy}","received_events_url":"https://api.github.com/users/Poseyy/received_events","type":"User","site_admin":false},"created_at":"2018-09-20T07:28:19Z","updated_at":"2018-09-20T07:28:19Z","author_association":"CONTRIBUTOR","body":"Ah! That makes a lot more sense. Thanks for the assist! "}}
{"actor":{"display_login":"Poseyy"}}