{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/fxa-email-service/pulls/comments/196547061","pull_request_review_id":130121531,"id":196547061,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjU0NzA2MQ==","diff_hunk":"@@ -32,6 +32,18 @@ impl MessageData {\n         }\n     }\n \n+    pub fn consume(&self, message_id: &str) -> Result<String, MessageDataError> {\n+        let key = self.generate_key(message_id)?;\n+        let key_str = key.as_str();\n+        self.client\n+            .get(key_str)\n+            .map(|metadata| {\n+                self.client.del::<&str, u8>(key_str).ok();","path":"src/message_data/mod.rs","position":10,"original_position":10,"commit_id":"de804e1aeb72a15dcf14d367083d8cb5b283c518","original_commit_id":"de804e1aeb72a15dcf14d367083d8cb5b283c518","user":{"login":"philbooth","id":64367,"node_id":"MDQ6VXNlcjY0MzY3","avatar_url":"https://avatars2.githubusercontent.com/u/64367?v=4","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"body":"(that's probably not it, I'm just thinking out loud tbh)","created_at":"2018-06-19T19:18:28Z","updated_at":"2018-06-19T19:18:28Z","html_url":"https://github.com/mozilla/fxa-email-service/pull/73#discussion_r196547061","pull_request_url":"https://api.github.com/repos/mozilla/fxa-email-service/pulls/73","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-email-service/pulls/comments/196547061"},"html":{"href":"https://github.com/mozilla/fxa-email-service/pull/73#discussion_r196547061"},"pull_request":{"href":"https://api.github.com/repos/mozilla/fxa-email-service/pulls/73"}},"in_reply_to_id":196541825},"pull_request":{"url":"https://api.github.com/repos/mozilla/fxa-email-service/pulls/73","id":194629496,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NjI5NDk2","html_url":"https://github.com/mozilla/fxa-email-service/pull/73","diff_url":"https://github.com/mozilla/fxa-email-service/pull/73.diff","patch_url":"https://github.com/mozilla/fxa-email-service/pull/73.patch","issue_url":"https://api.github.com/repos/mozilla/fxa-email-service/issues/73","number":73,"state":"open","locked":false,"title":"feat(metadata): send message metadata in outgoing notifications","user":{"login":"philbooth","id":64367,"node_id":"MDQ6VXNlcjY0MzY3","avatar_url":"https://avatars2.githubusercontent.com/u/64367?v=4","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"body":"Depends on #72. Fixes #4.\r\n\r\nAdds the ability to consume stored metadata from Redis and add it to the outgoing notification.\r\n\r\nAgain, no rush to review this, it can wait until after the All Hands.","created_at":"2018-06-13T15:36:15Z","updated_at":"2018-06-19T19:18:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de547242ea86df3ecda3cfbd8c6a1e79aa27f38b","assignee":{"login":"philbooth","id":64367,"node_id":"MDQ6VXNlcjY0MzY3","avatar_url":"https://avatars2.githubusercontent.com/u/64367?v=4","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"assignees":[{"login":"philbooth","id":64367,"node_id":"MDQ6VXNlcjY0MzY3","avatar_url":"https://avatars2.githubusercontent.com/u/64367?v=4","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":913435798,"node_id":"MDU6TGFiZWw5MTM0MzU3OTg=","url":"https://api.github.com/repos/mozilla/fxa-email-service/labels/waffle:review","name":"waffle:review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fxa-email-service/pulls/73/commits","review_comments_url":"https://api.github.com/repos/mozilla/fxa-email-service/pulls/73/comments","review_comment_url":"https://api.github.com/repos/mozilla/fxa-email-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/fxa-email-service/issues/73/comments","statuses_url":"https://api.github.com/repos/mozilla/fxa-email-service/statuses/de804e1aeb72a15dcf14d367083d8cb5b283c518","head":{"label":"mozilla:pb/4-b","ref":"pb/4-b","sha":"de804e1aeb72a15dcf14d367083d8cb5b283c518","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":130983020,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA5ODMwMjA=","name":"fxa-email-service","full_name":"mozilla/fxa-email-service","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-email-service","description":"Service for sending email to Firefox Accounts","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-email-service","forks_url":"https://api.github.com/repos/mozilla/fxa-email-service/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-email-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-email-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-email-service/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-email-service/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-email-service/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-email-service/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-email-service/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-email-service/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-email-service/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-email-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-email-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-email-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-email-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-email-service/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-email-service/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-email-service/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-email-service/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-email-service/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-email-service/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-email-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-email-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-email-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-email-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-email-service/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-email-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-email-service/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-email-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-email-service/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-email-service/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-email-service/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-email-service/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-email-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-email-service/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-email-service/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/fxa-email-service/deployments","created_at":"2018-04-25T09:29:39Z","updated_at":"2018-06-19T07:34:58Z","pushed_at":"2018-06-19T15:39:32Z","git_url":"git://github.com/mozilla/fxa-email-service.git","ssh_url":"git@github.com:mozilla/fxa-email-service.git","clone_url":"https://github.com/mozilla/fxa-email-service.git","svn_url":"https://github.com/mozilla/fxa-email-service","homepage":"","size":174,"stargazers_count":3,"watchers_count":3,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":3,"open_issues":25,"watchers":3,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"98b738a9c648813bd3605cdd2cad58a7bc75879f","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":130983020,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA5ODMwMjA=","name":"fxa-email-service","full_name":"mozilla/fxa-email-service","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fxa-email-service","description":"Service for sending email to Firefox Accounts","fork":false,"url":"https://api.github.com/repos/mozilla/fxa-email-service","forks_url":"https://api.github.com/repos/mozilla/fxa-email-service/forks","keys_url":"https://api.github.com/repos/mozilla/fxa-email-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fxa-email-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fxa-email-service/teams","hooks_url":"https://api.github.com/repos/mozilla/fxa-email-service/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fxa-email-service/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fxa-email-service/events","assignees_url":"https://api.github.com/repos/mozilla/fxa-email-service/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fxa-email-service/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fxa-email-service/tags","blobs_url":"https://api.github.com/repos/mozilla/fxa-email-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fxa-email-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fxa-email-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fxa-email-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fxa-email-service/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fxa-email-service/languages","stargazers_url":"https://api.github.com/repos/mozilla/fxa-email-service/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fxa-email-service/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fxa-email-service/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fxa-email-service/subscription","commits_url":"https://api.github.com/repos/mozilla/fxa-email-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fxa-email-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fxa-email-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fxa-email-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/fxa-email-service/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fxa-email-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fxa-email-service/merges","archive_url":"https://api.github.com/repos/mozilla/fxa-email-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fxa-email-service/downloads","issues_url":"https://api.github.com/repos/mozilla/fxa-email-service/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fxa-email-service/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fxa-email-service/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fxa-email-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fxa-email-service/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fxa-email-service/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/fxa-email-service/deployments","created_at":"2018-04-25T09:29:39Z","updated_at":"2018-06-19T07:34:58Z","pushed_at":"2018-06-19T15:39:32Z","git_url":"git://github.com/mozilla/fxa-email-service.git","ssh_url":"git@github.com:mozilla/fxa-email-service.git","clone_url":"https://github.com/mozilla/fxa-email-service.git","svn_url":"https://github.com/mozilla/fxa-email-service","homepage":"","size":174,"stargazers_count":3,"watchers_count":3,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":3,"open_issues":25,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fxa-email-service/pulls/73"},"html":{"href":"https://github.com/mozilla/fxa-email-service/pull/73"},"issue":{"href":"https://api.github.com/repos/mozilla/fxa-email-service/issues/73"},"comments":{"href":"https://api.github.com/repos/mozilla/fxa-email-service/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fxa-email-service/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fxa-email-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fxa-email-service/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fxa-email-service/statuses/de804e1aeb72a15dcf14d367083d8cb5b283c518"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"philbooth"}}