{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/173011666","pull_request_review_id":102129169,"id":173011666,"diff_hunk":"@@ -340,11 +340,11 @@ export class SafeframeHostApi {\n       // AMP's built in resize methodology that we use only allows expansion\n       // to the right and bottom, so we enforce that here.\n       'allowedExpansion_r': viewportSize.width -\n-          iframeBox.width,\n+          iframeBox.right,\n       'allowedExpansion_b': viewportSize.height -\n-          iframeBox.height,\n-      'allowedExpansion_t': 0,\n-      'allowedExpansion_l': 0,\n+          iframeBox.bottom,\n+      'allowedExpansion_t': iframeBox.top,","path":"extensions/amp-ad-network-doubleclick-impl/0.1/safeframe-host.js","position":11,"original_position":11,"commit_id":"8b60b70f9da16cfc387bdb613e438c04ad17acb0","original_commit_id":"8b60b70f9da16cfc387bdb613e438c04ad17acb0","user":{"login":"warrengm","id":5326842,"avatar_url":"https://avatars2.githubusercontent.com/u/5326842?v=4","gravatar_id":"","url":"https://api.github.com/users/warrengm","html_url":"https://github.com/warrengm","followers_url":"https://api.github.com/users/warrengm/followers","following_url":"https://api.github.com/users/warrengm/following{/other_user}","gists_url":"https://api.github.com/users/warrengm/gists{/gist_id}","starred_url":"https://api.github.com/users/warrengm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warrengm/subscriptions","organizations_url":"https://api.github.com/users/warrengm/orgs","repos_url":"https://api.github.com/users/warrengm/repos","events_url":"https://api.github.com/users/warrengm/events{/privacy}","received_events_url":"https://api.github.com/users/warrengm/received_events","type":"User","site_admin":false},"body":"I don't think it's possible to expand to the top or to the left because resizing is done based on changing height/width attributes (the position of the element is unchanged).\r\n\r\nI'm not as familiar with AMP runtime. @bradfrizzell  to confirm.","created_at":"2018-03-07T22:51:46Z","updated_at":"2018-03-07T22:57:17Z","html_url":"https://github.com/ampproject/amphtml/pull/13859#discussion_r173011666","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/13859","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/173011666"},"html":{"href":"https://github.com/ampproject/amphtml/pull/13859#discussion_r173011666"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/13859"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/13859","id":173578223,"html_url":"https://github.com/ampproject/amphtml/pull/13859","diff_url":"https://github.com/ampproject/amphtml/pull/13859.diff","patch_url":"https://github.com/ampproject/amphtml/pull/13859.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/13859","number":13859,"state":"open","locked":false,"title":"Fix Exp in Amp Dfp Safeframes to return data consistent with DFP safeframes","user":{"login":"jasminenoack","id":9314256,"avatar_url":"https://avatars2.githubusercontent.com/u/9314256?v=4","gravatar_id":"","url":"https://api.github.com/users/jasminenoack","html_url":"https://github.com/jasminenoack","followers_url":"https://api.github.com/users/jasminenoack/followers","following_url":"https://api.github.com/users/jasminenoack/following{/other_user}","gists_url":"https://api.github.com/users/jasminenoack/gists{/gist_id}","starred_url":"https://api.github.com/users/jasminenoack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasminenoack/subscriptions","organizations_url":"https://api.github.com/users/jasminenoack/orgs","repos_url":"https://api.github.com/users/jasminenoack/repos","events_url":"https://api.github.com/users/jasminenoack/events{/privacy}","received_events_url":"https://api.github.com/users/jasminenoack/received_events","type":"User","site_admin":false},"body":"Fixes Exp in Amp Dfp to return the distance available to expand in each direction like the dfp safeframes do. \r\n\r\nExp is expected to return the distance that can be expanded in each direction from the item to the outside of the screen. For example, it is expected to be the distance from the left side of the content to the left side of the screen or from the top side to the top of the screen, etc. Previously the code returned the size of the screen minus the size of the safeframe for right and bottom, and then 0 for top and left. ","created_at":"2018-03-07T21:27:52Z","updated_at":"2018-03-07T22:57:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fe19f0e8cedbd2533b356f57160bf7663060fc9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":596633554,"url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/13859/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/13859/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/13859/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/8b60b70f9da16cfc387bdb613e438c04ad17acb0","head":{"label":"yieldmo:fix-exp-in-safeframes","ref":"fix-exp-in-safeframes","sha":"8b60b70f9da16cfc387bdb613e438c04ad17acb0","user":{"login":"yieldmo","id":6540368,"avatar_url":"https://avatars1.githubusercontent.com/u/6540368?v=4","gravatar_id":"","url":"https://api.github.com/users/yieldmo","html_url":"https://github.com/yieldmo","followers_url":"https://api.github.com/users/yieldmo/followers","following_url":"https://api.github.com/users/yieldmo/following{/other_user}","gists_url":"https://api.github.com/users/yieldmo/gists{/gist_id}","starred_url":"https://api.github.com/users/yieldmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yieldmo/subscriptions","organizations_url":"https://api.github.com/users/yieldmo/orgs","repos_url":"https://api.github.com/users/yieldmo/repos","events_url":"https://api.github.com/users/yieldmo/events{/privacy}","received_events_url":"https://api.github.com/users/yieldmo/received_events","type":"Organization","site_admin":false},"repo":{"id":76975198,"name":"amphtml","full_name":"yieldmo/amphtml","owner":{"login":"yieldmo","id":6540368,"avatar_url":"https://avatars1.githubusercontent.com/u/6540368?v=4","gravatar_id":"","url":"https://api.github.com/users/yieldmo","html_url":"https://github.com/yieldmo","followers_url":"https://api.github.com/users/yieldmo/followers","following_url":"https://api.github.com/users/yieldmo/following{/other_user}","gists_url":"https://api.github.com/users/yieldmo/gists{/gist_id}","starred_url":"https://api.github.com/users/yieldmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yieldmo/subscriptions","organizations_url":"https://api.github.com/users/yieldmo/orgs","repos_url":"https://api.github.com/users/yieldmo/repos","events_url":"https://api.github.com/users/yieldmo/events{/privacy}","received_events_url":"https://api.github.com/users/yieldmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yieldmo/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/yieldmo/amphtml","forks_url":"https://api.github.com/repos/yieldmo/amphtml/forks","keys_url":"https://api.github.com/repos/yieldmo/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yieldmo/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yieldmo/amphtml/teams","hooks_url":"https://api.github.com/repos/yieldmo/amphtml/hooks","issue_events_url":"https://api.github.com/repos/yieldmo/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/yieldmo/amphtml/events","assignees_url":"https://api.github.com/repos/yieldmo/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/yieldmo/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/yieldmo/amphtml/tags","blobs_url":"https://api.github.com/repos/yieldmo/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yieldmo/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yieldmo/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/yieldmo/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yieldmo/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/yieldmo/amphtml/languages","stargazers_url":"https://api.github.com/repos/yieldmo/amphtml/stargazers","contributors_url":"https://api.github.com/repos/yieldmo/amphtml/contributors","subscribers_url":"https://api.github.com/repos/yieldmo/amphtml/subscribers","subscription_url":"https://api.github.com/repos/yieldmo/amphtml/subscription","commits_url":"https://api.github.com/repos/yieldmo/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/yieldmo/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/yieldmo/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/yieldmo/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/yieldmo/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/yieldmo/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yieldmo/amphtml/merges","archive_url":"https://api.github.com/repos/yieldmo/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yieldmo/amphtml/downloads","issues_url":"https://api.github.com/repos/yieldmo/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/yieldmo/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/yieldmo/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/yieldmo/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yieldmo/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/yieldmo/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/yieldmo/amphtml/deployments","created_at":"2016-12-20T16:58:52Z","updated_at":"2016-12-20T16:59:00Z","pushed_at":"2018-03-07T21:42:24Z","git_url":"git://github.com/yieldmo/amphtml.git","ssh_url":"git@github.com:yieldmo/amphtml.git","clone_url":"https://github.com/yieldmo/amphtml.git","svn_url":"https://github.com/yieldmo/amphtml","homepage":"https://ampproject.org","size":412033,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"c3519f1a2a12cfe139b6e39b02ba7a0e6f7eb82e","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-03-07T21:34:25Z","pushed_at":"2018-03-07T22:52:13Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":413237,"stargazers_count":11195,"watchers_count":11195,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2269,"mirror_url":null,"archived":false,"open_issues_count":1150,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2269,"open_issues":1150,"watchers":11195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/13859"},"html":{"href":"https://github.com/ampproject/amphtml/pull/13859"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/13859"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/13859/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/13859/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/13859/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/8b60b70f9da16cfc387bdb613e438c04ad17acb0"}},"author_association":"NONE"}}
{"actor":{"display_login":"warrengm"}}