{"action":"created","comment":{"url":"https://api.github.com/repos/dharmaprotocol/dharma.js/pulls/comments/182921290","pull_request_review_id":113820724,"id":182921290,"diff_hunk":"@@ -1,10 +1,11 @@\n // libraries\n-import { BigNumber } from \"utils/bignumber\";\n import * as ABIDecoder from \"abi-decoder\";\n+import { BigNumber } from \"../../utils/bignumber\";\n import * as compact from \"lodash.compact\";\n import * as Web3 from \"web3\";\n \n // utils\n+import { TOKEN_REGISTRY_TRACKED_TOKENS } from \"utils/constants\";","path":"__test__/integration/token_api.spec.ts","position":9,"original_position":9,"commit_id":"14bc46e141d66b78dffcca79528aa533d366926e","original_commit_id":"14bc46e141d66b78dffcca79528aa533d366926e","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Submodule import paths from this package are disallowed; import from the root instead","created_at":"2018-04-20T00:40:30Z","updated_at":"2018-04-20T00:40:30Z","html_url":"https://github.com/dharmaprotocol/dharma.js/pull/117#discussion_r182921290","pull_request_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/pulls/117","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dharmaprotocol/dharma.js/pulls/comments/182921290"},"html":{"href":"https://github.com/dharmaprotocol/dharma.js/pull/117#discussion_r182921290"},"pull_request":{"href":"https://api.github.com/repos/dharmaprotocol/dharma.js/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/dharmaprotocol/dharma.js/pulls/117","id":182679172,"html_url":"https://github.com/dharmaprotocol/dharma.js/pull/117","diff_url":"https://github.com/dharmaprotocol/dharma.js/pull/117.diff","patch_url":"https://github.com/dharmaprotocol/dharma.js/pull/117.patch","issue_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/issues/117","number":117,"state":"open","locked":false,"title":"[#156904185] Fix interest rate scaling issues by bumping charta","user":{"login":"nadavhollander","id":3241822,"avatar_url":"https://avatars1.githubusercontent.com/u/3241822?v=4","gravatar_id":"","url":"https://api.github.com/users/nadavhollander","html_url":"https://github.com/nadavhollander","followers_url":"https://api.github.com/users/nadavhollander/followers","following_url":"https://api.github.com/users/nadavhollander/following{/other_user}","gists_url":"https://api.github.com/users/nadavhollander/gists{/gist_id}","starred_url":"https://api.github.com/users/nadavhollander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadavhollander/subscriptions","organizations_url":"https://api.github.com/users/nadavhollander/orgs","repos_url":"https://api.github.com/users/nadavhollander/repos","events_url":"https://api.github.com/users/nadavhollander/events{/privacy}","received_events_url":"https://api.github.com/users/nadavhollander/received_events","type":"User","site_admin":false},"body":"This PR introduces the following changes:\r\n\r\n- Bumps the contracts version to include a fix for the interest rate bug reported by @frostiq\r\n- Fixed tests that were broken by the new contracts\r\n- Misc fix: split collateralized adapter into two files to placate tslint over there being two classes in the same file. \r\n- Misc fix: updated tslint settings to play nicely with prettier\r\n\r\n@saturnial @graemecode @chrismin note that a side-effect of the new contracts version is that we no longer deterministically know that index X will always be associated with token Y -- the order at which the tokens are inserted into the registry during the migrations is non-deterministic, meaning token indices in the registry must be determined dynamically in the tests.","created_at":"2018-04-19T06:38:59Z","updated_at":"2018-04-20T00:40:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cd94e5be367ac76644e9397db267c2c002da4ae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/pulls/117/commits","review_comments_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/pulls/117/comments","review_comment_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/issues/117/comments","statuses_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/statuses/14bc46e141d66b78dffcca79528aa533d366926e","head":{"label":"dharmaprotocol:156904185-fix-interest-scaling","ref":"156904185-fix-interest-scaling","sha":"14bc46e141d66b78dffcca79528aa533d366926e","user":{"login":"dharmaprotocol","id":28667653,"avatar_url":"https://avatars3.githubusercontent.com/u/28667653?v=4","gravatar_id":"","url":"https://api.github.com/users/dharmaprotocol","html_url":"https://github.com/dharmaprotocol","followers_url":"https://api.github.com/users/dharmaprotocol/followers","following_url":"https://api.github.com/users/dharmaprotocol/following{/other_user}","gists_url":"https://api.github.com/users/dharmaprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/dharmaprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dharmaprotocol/subscriptions","organizations_url":"https://api.github.com/users/dharmaprotocol/orgs","repos_url":"https://api.github.com/users/dharmaprotocol/repos","events_url":"https://api.github.com/users/dharmaprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/dharmaprotocol/received_events","type":"Organization","site_admin":false},"repo":{"id":119430692,"name":"dharma.js","full_name":"dharmaprotocol/dharma.js","owner":{"login":"dharmaprotocol","id":28667653,"avatar_url":"https://avatars3.githubusercontent.com/u/28667653?v=4","gravatar_id":"","url":"https://api.github.com/users/dharmaprotocol","html_url":"https://github.com/dharmaprotocol","followers_url":"https://api.github.com/users/dharmaprotocol/followers","following_url":"https://api.github.com/users/dharmaprotocol/following{/other_user}","gists_url":"https://api.github.com/users/dharmaprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/dharmaprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dharmaprotocol/subscriptions","organizations_url":"https://api.github.com/users/dharmaprotocol/orgs","repos_url":"https://api.github.com/users/dharmaprotocol/repos","events_url":"https://api.github.com/users/dharmaprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/dharmaprotocol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dharmaprotocol/dharma.js","description":"Javascript Developer library for interacting with Dharma Protocol","fork":false,"url":"https://api.github.com/repos/dharmaprotocol/dharma.js","forks_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/forks","keys_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/teams","hooks_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/hooks","issue_events_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/issues/events{/number}","events_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/events","assignees_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/assignees{/user}","branches_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/branches{/branch}","tags_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/tags","blobs_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/statuses/{sha}","languages_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/languages","stargazers_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/stargazers","contributors_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/contributors","subscribers_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/subscribers","subscription_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/subscription","commits_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/contents/{+path}","compare_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/merges","archive_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/downloads","issues_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/issues{/number}","pulls_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/pulls{/number}","milestones_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/milestones{/number}","notifications_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/labels{/name}","releases_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/releases{/id}","deployments_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/deployments","created_at":"2018-01-29T19:30:13Z","updated_at":"2018-04-19T23:32:41Z","pushed_at":"2018-04-20T00:40:16Z","git_url":"git://github.com/dharmaprotocol/dharma.js.git","ssh_url":"git@github.com:dharmaprotocol/dharma.js.git","clone_url":"https://github.com/dharmaprotocol/dharma.js.git","svn_url":"https://github.com/dharmaprotocol/dharma.js","homepage":"https://dharma.io","size":6455,"stargazers_count":16,"watchers_count":16,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8,"open_issues":1,"watchers":16,"default_branch":"master"}},"base":{"label":"dharmaprotocol:master","ref":"master","sha":"4efefe78cca37b7d3efa7974c276c4a0cf210197","user":{"login":"dharmaprotocol","id":28667653,"avatar_url":"https://avatars3.githubusercontent.com/u/28667653?v=4","gravatar_id":"","url":"https://api.github.com/users/dharmaprotocol","html_url":"https://github.com/dharmaprotocol","followers_url":"https://api.github.com/users/dharmaprotocol/followers","following_url":"https://api.github.com/users/dharmaprotocol/following{/other_user}","gists_url":"https://api.github.com/users/dharmaprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/dharmaprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dharmaprotocol/subscriptions","organizations_url":"https://api.github.com/users/dharmaprotocol/orgs","repos_url":"https://api.github.com/users/dharmaprotocol/repos","events_url":"https://api.github.com/users/dharmaprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/dharmaprotocol/received_events","type":"Organization","site_admin":false},"repo":{"id":119430692,"name":"dharma.js","full_name":"dharmaprotocol/dharma.js","owner":{"login":"dharmaprotocol","id":28667653,"avatar_url":"https://avatars3.githubusercontent.com/u/28667653?v=4","gravatar_id":"","url":"https://api.github.com/users/dharmaprotocol","html_url":"https://github.com/dharmaprotocol","followers_url":"https://api.github.com/users/dharmaprotocol/followers","following_url":"https://api.github.com/users/dharmaprotocol/following{/other_user}","gists_url":"https://api.github.com/users/dharmaprotocol/gists{/gist_id}","starred_url":"https://api.github.com/users/dharmaprotocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dharmaprotocol/subscriptions","organizations_url":"https://api.github.com/users/dharmaprotocol/orgs","repos_url":"https://api.github.com/users/dharmaprotocol/repos","events_url":"https://api.github.com/users/dharmaprotocol/events{/privacy}","received_events_url":"https://api.github.com/users/dharmaprotocol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dharmaprotocol/dharma.js","description":"Javascript Developer library for interacting with Dharma Protocol","fork":false,"url":"https://api.github.com/repos/dharmaprotocol/dharma.js","forks_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/forks","keys_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/teams","hooks_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/hooks","issue_events_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/issues/events{/number}","events_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/events","assignees_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/assignees{/user}","branches_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/branches{/branch}","tags_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/tags","blobs_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/statuses/{sha}","languages_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/languages","stargazers_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/stargazers","contributors_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/contributors","subscribers_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/subscribers","subscription_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/subscription","commits_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/contents/{+path}","compare_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/merges","archive_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/downloads","issues_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/issues{/number}","pulls_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/pulls{/number}","milestones_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/milestones{/number}","notifications_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/labels{/name}","releases_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/releases{/id}","deployments_url":"https://api.github.com/repos/dharmaprotocol/dharma.js/deployments","created_at":"2018-01-29T19:30:13Z","updated_at":"2018-04-19T23:32:41Z","pushed_at":"2018-04-20T00:40:16Z","git_url":"git://github.com/dharmaprotocol/dharma.js.git","ssh_url":"git@github.com:dharmaprotocol/dharma.js.git","clone_url":"https://github.com/dharmaprotocol/dharma.js.git","svn_url":"https://github.com/dharmaprotocol/dharma.js","homepage":"https://dharma.io","size":6455,"stargazers_count":16,"watchers_count":16,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8,"open_issues":1,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dharmaprotocol/dharma.js/pulls/117"},"html":{"href":"https://github.com/dharmaprotocol/dharma.js/pull/117"},"issue":{"href":"https://api.github.com/repos/dharmaprotocol/dharma.js/issues/117"},"comments":{"href":"https://api.github.com/repos/dharmaprotocol/dharma.js/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/dharmaprotocol/dharma.js/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/dharmaprotocol/dharma.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dharmaprotocol/dharma.js/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/dharmaprotocol/dharma.js/statuses/14bc46e141d66b78dffcca79528aa533d366926e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}