{"push_id":2538905930,"size":132,"distinct_size":1,"ref":"refs/heads/bg/tmp","head":"28234bc1d1f2381a8e9c720764039ebe450db092","before":"2c37d6f6ec87138feec03a09588506424274dd69","commits":[{"sha":"a99d51cb501d4a4022273aeb0622e1a8eaac2657","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"auth-manager: fix potential issue iterating modified CList in _dbus_new_proxy_cb()\n\nIn the loop, we invoke callbacks. What the callbacks do, is out of control\nof NMAuthManager. For example, they could cancel or schedule new\nrequests. Especially, cancelling invalidate the stored @safe pointer.\n\nFix that, by always iterate from the start of the list.\n\nFixes: d0563f0733ed293d67e9a0f6503e28c3f1c08f1b","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/a99d51cb501d4a4022273aeb0622e1a8eaac2657"},{"sha":"458b422468b30b4738eb245c35c150925c8399e9","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"shared: add NM_CAST_STRV_*() helper macros","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/458b422468b30b4738eb245c35c150925c8399e9"},{"sha":"be9a5ab308f13977f07a33135b3792ccbd1d6e67","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"shared: add nm_utils_strv_sort() helper","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/be9a5ab308f13977f07a33135b3792ccbd1d6e67"},{"sha":"56a3f3bba93f49611cc5ac1e34acb607143bb3a2","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"shared: add nm_utils_dbus_normalize_object_path() helper","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/56a3f3bba93f49611cc5ac1e34acb607143bb3a2"},{"sha":"6ec4dfce6983b1f30166dbffd11d79fa3fabcbec","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"libnm-core: improve documentation for autoconnect and autoconnect-slaves properties","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/6ec4dfce6983b1f30166dbffd11d79fa3fabcbec"},{"sha":"34bbcc70b8823cc1650407418f42d5f4cf4a1131","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"core: sort D-Bus paths in nm_dbus_utils_g_value_set_object_path_from_hash()","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/34bbcc70b8823cc1650407418f42d5f4cf4a1131"},{"sha":"5284690f180e7671d040bb6992fb3dcf3f5aa9e0","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"core: use nm_utils_dbus_normalize_object_path() to cleanup D-Bus argument","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/5284690f180e7671d040bb6992fb3dcf3f5aa9e0"},{"sha":"476208d223f7bc14622bb853fd83d7732065f581","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"core: don't explicitly set D-Bus path properties to \"/\"\n\nNMDBusObject already gets this right, by calling nm_dbus_utils_get_property(),\nwhich calls g_dbus_gvalue_to_gvariant(), which correctly converts NULL\nobject paths to \"/\".\n\nWe already rely on that elsewhere. No need for this workaround.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/476208d223f7bc14622bb853fd83d7732065f581"},{"sha":"580a11da3a5ea8b56e7714e3ebb34eb4149a456d","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"core: minor cleanup of handling specific-object in NMActiveConnection\n\n- use nm_assert() for something that ~really~ always should be given.\n- use nm_streq0() and nm_clear_g_free().","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/580a11da3a5ea8b56e7714e3ebb34eb4149a456d"},{"sha":"1a33ab17de3ad2d9afe409295b7fd393c013f863","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"core: downgrade assertion to nm_assert()\n\nIt can be easily verified, that these assertions should not ever fail.\nDisable in production builds.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/1a33ab17de3ad2d9afe409295b7fd393c013f863"},{"sha":"f94167d8b1f94e59fb04f711cb999f380b083314","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"core: add nm_auth_is_subject_in_acl_set_error() helper","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/f94167d8b1f94e59fb04f711cb999f380b083314"},{"sha":"aa86327e45fa5062620c489de4c78270c603f1c4","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"core: cleanup code by using nm_auth_is_subject_in_acl_set_error()","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/aa86327e45fa5062620c489de4c78270c603f1c4"},{"sha":"bac7a2821f3a52107f5c5dc447f337fdc56e3233","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"core: cleanup NMManager's validate_activation_request()\n\n- there are only two callers of validate_activation_request(). One of them,\n  might already lookup the device before calling the validate function.\n  Safe to looking up again. But this is not only an optimization, more importantly,\n  it feels odd to first lookup a device, and then later look it up again. Are\n  we guaranteed to use the same path? Why? Just avoid that question.\n- re-order some error checking for missing device, so that it is clearer.\n- use cleanup attribute to handle return value and drop the \"goto error\".","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/bac7a2821f3a52107f5c5dc447f337fdc56e3233"},{"sha":"bdc622fd31b7da46e36c0416b022c9d86e34d653","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"manager/trivial: rename boolean variable \"vpn\" to \"is_vpn\"","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/bdc622fd31b7da46e36c0416b022c9d86e34d653"},{"sha":"7fcdca29b6443083703f1350bacf70199b6b6eb7","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"manager: add _connection_is_vpn() helper to unify checks for VPN type","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/7fcdca29b6443083703f1350bacf70199b6b6eb7"},{"sha":"3e3d53ce6960dc0195c29a32c46cecafee3a8a70","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"manager: add is-vpn argument to _new_active_connection() and avoid searching existing activations\n\n- pass is-vpn to _new_active_connection(). It is confusing that _new_active_connection()\n  would re-determine whether a connection is a VPN type, although that was already\n  established previously. The confusing part is: will they come to the\n  same result? Why? What if not?\n  Instead pass it as argument and assert that we got it right.\n\n- the check for existing connections should look whether there is an existing\n  active connection of type NMVpnConnection. Instead, what matters is,\n  - do we have a connection of type VPN (otherwise, don't even bother\n    to search for existing-ac)\n  - is the connection already active?\n  Checking whether the connection is already active, and ask backwards\n  whether it's of type NMVpnConnection is odd, maybe even wrong in\n  some cases.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/3e3d53ce6960dc0195c29a32c46cecafee3a8a70"},{"sha":"0458e4bb28434e338947e9e2174f9c1fbad2287e","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"manager: use cleanup attribute in impl_manager_add_and_activate_connection() and related\n\nAlso, in _add_and_activate_auth_done(), always steal the connection\nfrom active's user-data. Otherwise, the lifetime of the connection\nis extended until active gets destroyed. For example, if we would leak\nactive, we would also leak connection that way.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/0458e4bb28434e338947e9e2174f9c1fbad2287e"},{"sha":"10753c36168a82cd658df8a7da800960fddd78ed","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"manager: merge VPN handling into _new_active_connection()\n\nMerge _new_vpn_active_connection() into _new_active_connection(). It was the\nonly caller, and it is simpler to have all the code visible at one place.\n\nThat also shows, that the device argument is ignored and not handled.\nEnsure that no device is specified for VPN type activations.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/10753c36168a82cd658df8a7da800960fddd78ed"},{"sha":"5c4a6e9b6dfc5fe432c0bfacb4ae64a19b17042d","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"manager: ensure valid specific_object path is passed to _new_active_connection()\n\nFrom the D-Bus layer, no specific-object is represented by \"/\". We\nshould early on normalize such values to NULL, and not expect or\nhandle them later (like during _new_active_connection()).","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/5c4a6e9b6dfc5fe432c0bfacb4ae64a19b17042d"},{"sha":"9fe4239f33d13f06cf375ffb900071f612079193","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"manager: some refactoring of error paths to return early\n\nOften, functions perform a series of steps, and when they fail,\nthey bail out. It's simpler if the code is structured that way,\nso you can read it from top to bottom and whenever something is\nwrong, either return directly (or goto a cleanup label at the\nbottom).","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/9fe4239f33d13f06cf375ffb900071f612079193"}]}
{"actor":{"display_login":"lkundrak"}}