{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/213822862","pull_request_review_id":150740870,"id":213822862,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzgyMjg2Mg==","diff_hunk":"@@ -47,21 +53,15 @@ class CollisionPickResult : public PickResult {\n     QVariantMap toVariantMap() const override;\n \n     bool doesIntersect() const override { return intersects; }\n+    bool needsToCompareResults() const override { return true; }","path":"interface/src/raypick/CollisionPick.h","position":32,"original_position":32,"commit_id":"6f6e70a470e10cb237a8392d23c1e242ccc6fff5","original_commit_id":"6f6e70a470e10cb237a8392d23c1e242ccc6fff5","user":{"login":"sabrina-shanman","id":39919756,"node_id":"MDQ6VXNlcjM5OTE5NzU2","avatar_url":"https://avatars2.githubusercontent.com/u/39919756?v=4","gravatar_id":"","url":"https://api.github.com/users/sabrina-shanman","html_url":"https://github.com/sabrina-shanman","followers_url":"https://api.github.com/users/sabrina-shanman/followers","following_url":"https://api.github.com/users/sabrina-shanman/following{/other_user}","gists_url":"https://api.github.com/users/sabrina-shanman/gists{/gist_id}","starred_url":"https://api.github.com/users/sabrina-shanman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabrina-shanman/subscriptions","organizations_url":"https://api.github.com/users/sabrina-shanman/orgs","repos_url":"https://api.github.com/users/sabrina-shanman/repos","events_url":"https://api.github.com/users/sabrina-shanman/events{/privacy}","received_events_url":"https://api.github.com/users/sabrina-shanman/received_events","type":"User","site_admin":false},"body":"Yes, because of the loaded parameter which checks whether the model was loaded.","created_at":"2018-08-29T20:28:30Z","updated_at":"2018-08-29T20:28:30Z","html_url":"https://github.com/highfidelity/hifi/pull/13873#discussion_r213822862","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13873","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/213822862"},"html":{"href":"https://github.com/highfidelity/hifi/pull/13873#discussion_r213822862"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13873"}},"in_reply_to_id":213793061},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/13873","id":210607882,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNjA3ODgy","html_url":"https://github.com/highfidelity/hifi/pull/13873","diff_url":"https://github.com/highfidelity/hifi/pull/13873.diff","patch_url":"https://github.com/highfidelity/hifi/pull/13873.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/13873","number":13873,"state":"open","locked":false,"title":"Collision Pick Parenting","user":{"login":"sabrina-shanman","id":39919756,"node_id":"MDQ6VXNlcjM5OTE5NzU2","avatar_url":"https://avatars2.githubusercontent.com/u/39919756?v=4","gravatar_id":"","url":"https://api.github.com/users/sabrina-shanman","html_url":"https://github.com/sabrina-shanman","followers_url":"https://api.github.com/users/sabrina-shanman/followers","following_url":"https://api.github.com/users/sabrina-shanman/following{/other_user}","gists_url":"https://api.github.com/users/sabrina-shanman/gists{/gist_id}","starred_url":"https://api.github.com/users/sabrina-shanman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabrina-shanman/subscriptions","organizations_url":"https://api.github.com/users/sabrina-shanman/orgs","repos_url":"https://api.github.com/users/sabrina-shanman/repos","events_url":"https://api.github.com/users/sabrina-shanman/events{/privacy}","received_events_url":"https://api.github.com/users/sabrina-shanman/received_events","type":"User","site_admin":false},"body":"This PR is a follow-up to https://github.com/highfidelity/hifi/pull/13714. It implements the upcoming parenting system for Collision Picks, which are needed for the teleportation safety improvement.\r\n\r\n## TEST PLAN\r\n- Run the manual test at https://github.com/sabrina-shanman/hifi_tests/tree/safe-teleport-target/tests/engine/interaction/pick/collision/parenting_on_server\r\n- Run all the tests in https://github.com/sabrina-shanman/hifi_tests/tree/safe-teleport-target/tests/engine/interaction/pointer","created_at":"2018-08-24T00:10:06Z","updated_at":"2018-08-29T20:28:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a162048a9c25e885a0a16ebb51a0fc11deb493d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":675876856,"node_id":"MDU6TGFiZWw2NzU4NzY4NTY=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Engine","name":"Engine","color":"A2277C","default":false},{"id":461634431,"node_id":"MDU6TGFiZWw0NjE2MzQ0MzE=","url":"https://api.github.com/repos/highfidelity/hifi/labels/HMD%20required","name":"HMD required","color":"d4c5f9","default":false},{"id":911263442,"node_id":"MDU6TGFiZWw5MTEyNjM0NDI=","url":"https://api.github.com/repos/highfidelity/hifi/labels/JSDocs","name":"JSDocs","color":"98d4e0","default":false},{"id":751529405,"node_id":"MDU6TGFiZWw3NTE1Mjk0MDU=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Scripting%20API%20change","name":"Scripting API change","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/33","html_url":"https://github.com/highfidelity/hifi/milestone/33","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/33/labels","id":3290832,"node_id":"MDk6TWlsZXN0b25lMzI5MDgzMg==","number":33,"title":"v0.73.0","description":"","creator":{"login":"conklin94122","id":12115653,"node_id":"MDQ6VXNlcjEyMTE1NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":18,"state":"open","created_at":"2018-04-23T19:27:12Z","updated_at":"2018-08-29T20:20:04Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13873/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13873/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/13873/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/6f6e70a470e10cb237a8392d23c1e242ccc6fff5","head":{"label":"sabrina-shanman:stt_parenting","ref":"stt_parenting","sha":"6f6e70a470e10cb237a8392d23c1e242ccc6fff5","user":{"login":"sabrina-shanman","id":39919756,"node_id":"MDQ6VXNlcjM5OTE5NzU2","avatar_url":"https://avatars2.githubusercontent.com/u/39919756?v=4","gravatar_id":"","url":"https://api.github.com/users/sabrina-shanman","html_url":"https://github.com/sabrina-shanman","followers_url":"https://api.github.com/users/sabrina-shanman/followers","following_url":"https://api.github.com/users/sabrina-shanman/following{/other_user}","gists_url":"https://api.github.com/users/sabrina-shanman/gists{/gist_id}","starred_url":"https://api.github.com/users/sabrina-shanman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabrina-shanman/subscriptions","organizations_url":"https://api.github.com/users/sabrina-shanman/orgs","repos_url":"https://api.github.com/users/sabrina-shanman/repos","events_url":"https://api.github.com/users/sabrina-shanman/events{/privacy}","received_events_url":"https://api.github.com/users/sabrina-shanman/received_events","type":"User","site_admin":false},"repo":{"id":136213223,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYyMTMyMjM=","name":"hifi","full_name":"sabrina-shanman/hifi","owner":{"login":"sabrina-shanman","id":39919756,"node_id":"MDQ6VXNlcjM5OTE5NzU2","avatar_url":"https://avatars2.githubusercontent.com/u/39919756?v=4","gravatar_id":"","url":"https://api.github.com/users/sabrina-shanman","html_url":"https://github.com/sabrina-shanman","followers_url":"https://api.github.com/users/sabrina-shanman/followers","following_url":"https://api.github.com/users/sabrina-shanman/following{/other_user}","gists_url":"https://api.github.com/users/sabrina-shanman/gists{/gist_id}","starred_url":"https://api.github.com/users/sabrina-shanman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabrina-shanman/subscriptions","organizations_url":"https://api.github.com/users/sabrina-shanman/orgs","repos_url":"https://api.github.com/users/sabrina-shanman/repos","events_url":"https://api.github.com/users/sabrina-shanman/events{/privacy}","received_events_url":"https://api.github.com/users/sabrina-shanman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sabrina-shanman/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://docs.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":true,"url":"https://api.github.com/repos/sabrina-shanman/hifi","forks_url":"https://api.github.com/repos/sabrina-shanman/hifi/forks","keys_url":"https://api.github.com/repos/sabrina-shanman/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sabrina-shanman/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sabrina-shanman/hifi/teams","hooks_url":"https://api.github.com/repos/sabrina-shanman/hifi/hooks","issue_events_url":"https://api.github.com/repos/sabrina-shanman/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/sabrina-shanman/hifi/events","assignees_url":"https://api.github.com/repos/sabrina-shanman/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/sabrina-shanman/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/sabrina-shanman/hifi/tags","blobs_url":"https://api.github.com/repos/sabrina-shanman/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sabrina-shanman/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sabrina-shanman/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/sabrina-shanman/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sabrina-shanman/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/sabrina-shanman/hifi/languages","stargazers_url":"https://api.github.com/repos/sabrina-shanman/hifi/stargazers","contributors_url":"https://api.github.com/repos/sabrina-shanman/hifi/contributors","subscribers_url":"https://api.github.com/repos/sabrina-shanman/hifi/subscribers","subscription_url":"https://api.github.com/repos/sabrina-shanman/hifi/subscription","commits_url":"https://api.github.com/repos/sabrina-shanman/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/sabrina-shanman/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/sabrina-shanman/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/sabrina-shanman/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/sabrina-shanman/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/sabrina-shanman/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sabrina-shanman/hifi/merges","archive_url":"https://api.github.com/repos/sabrina-shanman/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sabrina-shanman/hifi/downloads","issues_url":"https://api.github.com/repos/sabrina-shanman/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/sabrina-shanman/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/sabrina-shanman/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/sabrina-shanman/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sabrina-shanman/hifi/labels{/name}","releases_url":"https://api.github.com/repos/sabrina-shanman/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/sabrina-shanman/hifi/deployments","created_at":"2018-06-05T17:39:26Z","updated_at":"2018-08-24T22:48:13Z","pushed_at":"2018-08-28T15:48:23Z","git_url":"git://github.com/sabrina-shanman/hifi.git","ssh_url":"git@github.com:sabrina-shanman/hifi.git","clone_url":"https://github.com/sabrina-shanman/hifi.git","svn_url":"https://github.com/sabrina-shanman/hifi","homepage":"","size":552390,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"fcdbc6c6d2194c1767b8117d5518d7207b159f8f","user":{"login":"highfidelity","id":1565370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"node_id":"MDEwOlJlcG9zaXRvcnk1MzcyODcy","name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://docs.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2018-08-29T20:20:23Z","pushed_at":"2018-08-29T20:20:05Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":552218,"stargazers_count":641,"watchers_count":641,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":411,"mirror_url":null,"archived":false,"open_issues_count":181,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":411,"open_issues":181,"watchers":641,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13873"},"html":{"href":"https://github.com/highfidelity/hifi/pull/13873"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/13873"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/13873/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13873/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13873/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/6f6e70a470e10cb237a8392d23c1e242ccc6fff5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sabrina-shanman"}}