{"action":"created","comment":{"url":"https://api.github.com/repos/CanonicalLtd/netplan/pulls/comments/240447798","pull_request_review_id":183480332,"id":240447798,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDQ0Nzc5OA==","diff_hunk":"@@ -317,44 +317,68 @@ similar to ``gateway*``, and ``search:`` is a list of search domains.\n :   Configure policy routing for the device; see the ``Routing`` section below.\n \n ## DHCP Overrides\n-Several DHCP behavior overrides are available. Currently this is only supported\n-via the ``networkd`` backend.\n+Several DHCP behavior overrides are available. Most are only available\n+via the ``networkd`` backend, with the notable exception of ``use-routes``\n+and ``default-metric``.\n \n Overrides only have an effect if the corresponding ``dhcp4`` or ``dhcp6`` is\n set to ``true``.\n \n If both ``dhcp4`` and ``dhcp6`` are ``true``, the ``networkd`` backend requires\n that ``dhcp4-overrides`` and ``dhcp6-overrides`` contain the same keys and values.\n \n+When using the ``NetworkManager`` backend, overrides may be different between\n+DHCPv4 and DHCPv6.\n+","path":"doc/netplan.md","position":18,"original_position":18,"commit_id":"c3b9d447d5ca48bf88116ba3aa6ed1ea3fcbe93e","original_commit_id":"c3b9d447d5ca48bf88116ba3aa6ed1ea3fcbe93e","user":{"login":"cyphermox","id":119845,"node_id":"MDQ6VXNlcjExOTg0NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/119845?v=4","gravatar_id":"","url":"https://api.github.com/users/cyphermox","html_url":"https://github.com/cyphermox","followers_url":"https://api.github.com/users/cyphermox/followers","following_url":"https://api.github.com/users/cyphermox/following{/other_user}","gists_url":"https://api.github.com/users/cyphermox/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphermox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphermox/subscriptions","organizations_url":"https://api.github.com/users/cyphermox/orgs","repos_url":"https://api.github.com/users/cyphermox/repos","events_url":"https://api.github.com/users/cyphermox/events{/privacy}","received_events_url":"https://api.github.com/users/cyphermox/received_events","type":"User","site_admin":false},"body":"Reworked the text as much as I could for clarity. If further changes are necessary, please suggest edits. I'm out of ideas :)","created_at":"2018-12-11T01:46:06Z","updated_at":"2018-12-11T01:46:06Z","html_url":"https://github.com/CanonicalLtd/netplan/pull/64#discussion_r240447798","pull_request_url":"https://api.github.com/repos/CanonicalLtd/netplan/pulls/64","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/CanonicalLtd/netplan/pulls/comments/240447798"},"html":{"href":"https://github.com/CanonicalLtd/netplan/pull/64#discussion_r240447798"},"pull_request":{"href":"https://api.github.com/repos/CanonicalLtd/netplan/pulls/64"}},"in_reply_to_id":240420477},"pull_request":{"url":"https://api.github.com/repos/CanonicalLtd/netplan/pulls/64","id":237409904,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDA5OTA0","html_url":"https://github.com/CanonicalLtd/netplan/pull/64","diff_url":"https://github.com/CanonicalLtd/netplan/pull/64.diff","patch_url":"https://github.com/CanonicalLtd/netplan/pull/64.patch","issue_url":"https://api.github.com/repos/CanonicalLtd/netplan/issues/64","number":64,"state":"open","locked":false,"title":"Allow ignoring routes from DHCP","user":{"login":"cyphermox","id":119845,"node_id":"MDQ6VXNlcjExOTg0NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/119845?v=4","gravatar_id":"","url":"https://api.github.com/users/cyphermox","html_url":"https://github.com/cyphermox","followers_url":"https://api.github.com/users/cyphermox/followers","following_url":"https://api.github.com/users/cyphermox/following{/other_user}","gists_url":"https://api.github.com/users/cyphermox/gists{/gist_id}","starred_url":"https://api.github.com/users/cyphermox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyphermox/subscriptions","organizations_url":"https://api.github.com/users/cyphermox/orgs","repos_url":"https://api.github.com/users/cyphermox/repos","events_url":"https://api.github.com/users/cyphermox/events{/privacy}","received_events_url":"https://api.github.com/users/cyphermox/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nAllow ignoring routes from DHCP\r\n\r\n## Checklist\r\n\r\n- [x] Runs `make check` successfully.\r\n- [x] Retains 100% code coverage (`make check-coverage`).\r\n- [x] New/changed keys in YAML format are documented.\r\n- [ ] \\(Optional\\) Closes an open bug in Launchpad.\r\n\r\n","created_at":"2018-12-10T17:47:10Z","updated_at":"2018-12-11T01:46:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa4613670c972a671d7c38901302dbfc34acc28d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CanonicalLtd/netplan/pulls/64/commits","review_comments_url":"https://api.github.com/repos/CanonicalLtd/netplan/pulls/64/comments","review_comment_url":"https://api.github.com/repos/CanonicalLtd/netplan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanonicalLtd/netplan/issues/64/comments","statuses_url":"https://api.github.com/repos/CanonicalLtd/netplan/statuses/c3b9d447d5ca48bf88116ba3aa6ed1ea3fcbe93e","head":{"label":"CanonicalLtd:use-routes","ref":"use-routes","sha":"c3b9d447d5ca48bf88116ba3aa6ed1ea3fcbe93e","user":{"login":"CanonicalLtd","id":7490288,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0OTAyODg=","avatar_url":"https://avatars0.githubusercontent.com/u/7490288?v=4","gravatar_id":"","url":"https://api.github.com/users/CanonicalLtd","html_url":"https://github.com/CanonicalLtd","followers_url":"https://api.github.com/users/CanonicalLtd/followers","following_url":"https://api.github.com/users/CanonicalLtd/following{/other_user}","gists_url":"https://api.github.com/users/CanonicalLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/CanonicalLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanonicalLtd/subscriptions","organizations_url":"https://api.github.com/users/CanonicalLtd/orgs","repos_url":"https://api.github.com/users/CanonicalLtd/repos","events_url":"https://api.github.com/users/CanonicalLtd/events{/privacy}","received_events_url":"https://api.github.com/users/CanonicalLtd/received_events","type":"Organization","site_admin":false},"repo":{"id":118829640,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4Mjk2NDA=","name":"netplan","full_name":"CanonicalLtd/netplan","private":false,"owner":{"login":"CanonicalLtd","id":7490288,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0OTAyODg=","avatar_url":"https://avatars0.githubusercontent.com/u/7490288?v=4","gravatar_id":"","url":"https://api.github.com/users/CanonicalLtd","html_url":"https://github.com/CanonicalLtd","followers_url":"https://api.github.com/users/CanonicalLtd/followers","following_url":"https://api.github.com/users/CanonicalLtd/following{/other_user}","gists_url":"https://api.github.com/users/CanonicalLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/CanonicalLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanonicalLtd/subscriptions","organizations_url":"https://api.github.com/users/CanonicalLtd/orgs","repos_url":"https://api.github.com/users/CanonicalLtd/repos","events_url":"https://api.github.com/users/CanonicalLtd/events{/privacy}","received_events_url":"https://api.github.com/users/CanonicalLtd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CanonicalLtd/netplan","description":"Backend-agnostic network configuration in YAML","fork":false,"url":"https://api.github.com/repos/CanonicalLtd/netplan","forks_url":"https://api.github.com/repos/CanonicalLtd/netplan/forks","keys_url":"https://api.github.com/repos/CanonicalLtd/netplan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanonicalLtd/netplan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanonicalLtd/netplan/teams","hooks_url":"https://api.github.com/repos/CanonicalLtd/netplan/hooks","issue_events_url":"https://api.github.com/repos/CanonicalLtd/netplan/issues/events{/number}","events_url":"https://api.github.com/repos/CanonicalLtd/netplan/events","assignees_url":"https://api.github.com/repos/CanonicalLtd/netplan/assignees{/user}","branches_url":"https://api.github.com/repos/CanonicalLtd/netplan/branches{/branch}","tags_url":"https://api.github.com/repos/CanonicalLtd/netplan/tags","blobs_url":"https://api.github.com/repos/CanonicalLtd/netplan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanonicalLtd/netplan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanonicalLtd/netplan/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanonicalLtd/netplan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanonicalLtd/netplan/statuses/{sha}","languages_url":"https://api.github.com/repos/CanonicalLtd/netplan/languages","stargazers_url":"https://api.github.com/repos/CanonicalLtd/netplan/stargazers","contributors_url":"https://api.github.com/repos/CanonicalLtd/netplan/contributors","subscribers_url":"https://api.github.com/repos/CanonicalLtd/netplan/subscribers","subscription_url":"https://api.github.com/repos/CanonicalLtd/netplan/subscription","commits_url":"https://api.github.com/repos/CanonicalLtd/netplan/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanonicalLtd/netplan/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanonicalLtd/netplan/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanonicalLtd/netplan/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanonicalLtd/netplan/contents/{+path}","compare_url":"https://api.github.com/repos/CanonicalLtd/netplan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanonicalLtd/netplan/merges","archive_url":"https://api.github.com/repos/CanonicalLtd/netplan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanonicalLtd/netplan/downloads","issues_url":"https://api.github.com/repos/CanonicalLtd/netplan/issues{/number}","pulls_url":"https://api.github.com/repos/CanonicalLtd/netplan/pulls{/number}","milestones_url":"https://api.github.com/repos/CanonicalLtd/netplan/milestones{/number}","notifications_url":"https://api.github.com/repos/CanonicalLtd/netplan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanonicalLtd/netplan/labels{/name}","releases_url":"https://api.github.com/repos/CanonicalLtd/netplan/releases{/id}","deployments_url":"https://api.github.com/repos/CanonicalLtd/netplan/deployments","created_at":"2018-01-24T22:22:14Z","updated_at":"2018-12-10T17:21:36Z","pushed_at":"2018-12-11T01:35:39Z","git_url":"git://github.com/CanonicalLtd/netplan.git","ssh_url":"git@github.com:CanonicalLtd/netplan.git","clone_url":"https://github.com/CanonicalLtd/netplan.git","svn_url":"https://github.com/CanonicalLtd/netplan","homepage":"http://netplan.io","size":1387,"stargazers_count":80,"watchers_count":80,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":24,"open_issues":8,"watchers":80,"default_branch":"master"}},"base":{"label":"CanonicalLtd:master","ref":"master","sha":"39296815472c0103ea7e323fef1f79712864ba59","user":{"login":"CanonicalLtd","id":7490288,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0OTAyODg=","avatar_url":"https://avatars0.githubusercontent.com/u/7490288?v=4","gravatar_id":"","url":"https://api.github.com/users/CanonicalLtd","html_url":"https://github.com/CanonicalLtd","followers_url":"https://api.github.com/users/CanonicalLtd/followers","following_url":"https://api.github.com/users/CanonicalLtd/following{/other_user}","gists_url":"https://api.github.com/users/CanonicalLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/CanonicalLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanonicalLtd/subscriptions","organizations_url":"https://api.github.com/users/CanonicalLtd/orgs","repos_url":"https://api.github.com/users/CanonicalLtd/repos","events_url":"https://api.github.com/users/CanonicalLtd/events{/privacy}","received_events_url":"https://api.github.com/users/CanonicalLtd/received_events","type":"Organization","site_admin":false},"repo":{"id":118829640,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4Mjk2NDA=","name":"netplan","full_name":"CanonicalLtd/netplan","private":false,"owner":{"login":"CanonicalLtd","id":7490288,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0OTAyODg=","avatar_url":"https://avatars0.githubusercontent.com/u/7490288?v=4","gravatar_id":"","url":"https://api.github.com/users/CanonicalLtd","html_url":"https://github.com/CanonicalLtd","followers_url":"https://api.github.com/users/CanonicalLtd/followers","following_url":"https://api.github.com/users/CanonicalLtd/following{/other_user}","gists_url":"https://api.github.com/users/CanonicalLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/CanonicalLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanonicalLtd/subscriptions","organizations_url":"https://api.github.com/users/CanonicalLtd/orgs","repos_url":"https://api.github.com/users/CanonicalLtd/repos","events_url":"https://api.github.com/users/CanonicalLtd/events{/privacy}","received_events_url":"https://api.github.com/users/CanonicalLtd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CanonicalLtd/netplan","description":"Backend-agnostic network configuration in YAML","fork":false,"url":"https://api.github.com/repos/CanonicalLtd/netplan","forks_url":"https://api.github.com/repos/CanonicalLtd/netplan/forks","keys_url":"https://api.github.com/repos/CanonicalLtd/netplan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanonicalLtd/netplan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanonicalLtd/netplan/teams","hooks_url":"https://api.github.com/repos/CanonicalLtd/netplan/hooks","issue_events_url":"https://api.github.com/repos/CanonicalLtd/netplan/issues/events{/number}","events_url":"https://api.github.com/repos/CanonicalLtd/netplan/events","assignees_url":"https://api.github.com/repos/CanonicalLtd/netplan/assignees{/user}","branches_url":"https://api.github.com/repos/CanonicalLtd/netplan/branches{/branch}","tags_url":"https://api.github.com/repos/CanonicalLtd/netplan/tags","blobs_url":"https://api.github.com/repos/CanonicalLtd/netplan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanonicalLtd/netplan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanonicalLtd/netplan/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanonicalLtd/netplan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanonicalLtd/netplan/statuses/{sha}","languages_url":"https://api.github.com/repos/CanonicalLtd/netplan/languages","stargazers_url":"https://api.github.com/repos/CanonicalLtd/netplan/stargazers","contributors_url":"https://api.github.com/repos/CanonicalLtd/netplan/contributors","subscribers_url":"https://api.github.com/repos/CanonicalLtd/netplan/subscribers","subscription_url":"https://api.github.com/repos/CanonicalLtd/netplan/subscription","commits_url":"https://api.github.com/repos/CanonicalLtd/netplan/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanonicalLtd/netplan/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanonicalLtd/netplan/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanonicalLtd/netplan/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanonicalLtd/netplan/contents/{+path}","compare_url":"https://api.github.com/repos/CanonicalLtd/netplan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanonicalLtd/netplan/merges","archive_url":"https://api.github.com/repos/CanonicalLtd/netplan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanonicalLtd/netplan/downloads","issues_url":"https://api.github.com/repos/CanonicalLtd/netplan/issues{/number}","pulls_url":"https://api.github.com/repos/CanonicalLtd/netplan/pulls{/number}","milestones_url":"https://api.github.com/repos/CanonicalLtd/netplan/milestones{/number}","notifications_url":"https://api.github.com/repos/CanonicalLtd/netplan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanonicalLtd/netplan/labels{/name}","releases_url":"https://api.github.com/repos/CanonicalLtd/netplan/releases{/id}","deployments_url":"https://api.github.com/repos/CanonicalLtd/netplan/deployments","created_at":"2018-01-24T22:22:14Z","updated_at":"2018-12-10T17:21:36Z","pushed_at":"2018-12-11T01:35:39Z","git_url":"git://github.com/CanonicalLtd/netplan.git","ssh_url":"git@github.com:CanonicalLtd/netplan.git","clone_url":"https://github.com/CanonicalLtd/netplan.git","svn_url":"https://github.com/CanonicalLtd/netplan","homepage":"http://netplan.io","size":1387,"stargazers_count":80,"watchers_count":80,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":24,"open_issues":8,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CanonicalLtd/netplan/pulls/64"},"html":{"href":"https://github.com/CanonicalLtd/netplan/pull/64"},"issue":{"href":"https://api.github.com/repos/CanonicalLtd/netplan/issues/64"},"comments":{"href":"https://api.github.com/repos/CanonicalLtd/netplan/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/CanonicalLtd/netplan/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/CanonicalLtd/netplan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanonicalLtd/netplan/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/CanonicalLtd/netplan/statuses/c3b9d447d5ca48bf88116ba3aa6ed1ea3fcbe93e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"cyphermox"}}