{"action":"created","issue":{"url":"https://api.github.com/repos/consul/consul/issues/2763","repository_url":"https://api.github.com/repos/consul/consul","labels_url":"https://api.github.com/repos/consul/consul/issues/2763/labels{/name}","comments_url":"https://api.github.com/repos/consul/consul/issues/2763/comments","events_url":"https://api.github.com/repos/consul/consul/issues/2763/events","html_url":"https://github.com/consul/consul/issues/2763","id":340995666,"node_id":"MDU6SXNzdWUzNDA5OTU2NjY=","number":2763,"title":"Make Milestones Polymorphic","user":{"login":"voodoorai2000","id":4169,"node_id":"MDQ6VXNlcjQxNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/4169?v=4","gravatar_id":"","url":"https://api.github.com/users/voodoorai2000","html_url":"https://github.com/voodoorai2000","followers_url":"https://api.github.com/users/voodoorai2000/followers","following_url":"https://api.github.com/users/voodoorai2000/following{/other_user}","gists_url":"https://api.github.com/users/voodoorai2000/gists{/gist_id}","starred_url":"https://api.github.com/users/voodoorai2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voodoorai2000/subscriptions","organizations_url":"https://api.github.com/users/voodoorai2000/orgs","repos_url":"https://api.github.com/users/voodoorai2000/repos","events_url":"https://api.github.com/users/voodoorai2000/events{/privacy}","received_events_url":"https://api.github.com/users/voodoorai2000/received_events","type":"User","site_admin":false},"labels":[{"id":242431640,"node_id":"MDU6TGFiZWwyNDI0MzE2NDA=","url":"https://api.github.com/repos/consul/consul/labels/Admin","name":"Admin","color":"008baa","default":false},{"id":518653838,"node_id":"MDU6TGFiZWw1MTg2NTM4Mzg=","url":"https://api.github.com/repos/consul/consul/labels/Budget","name":"Budget","color":"fecc59","default":false},{"id":618248985,"node_id":"MDU6TGFiZWw2MTgyNDg5ODU=","url":"https://api.github.com/repos/consul/consul/labels/Citizen%20proposals","name":"Citizen proposals","color":"fecc59","default":false},{"id":618247628,"node_id":"MDU6TGFiZWw2MTgyNDc2Mjg=","url":"https://api.github.com/repos/consul/consul/labels/Legislation","name":"Legislation","color":"fecc59","default":false}],"state":"open","locked":false,"assignee":{"login":"mlovic","id":7111622,"node_id":"MDQ6VXNlcjcxMTE2MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/7111622?v=4","gravatar_id":"","url":"https://api.github.com/users/mlovic","html_url":"https://github.com/mlovic","followers_url":"https://api.github.com/users/mlovic/followers","following_url":"https://api.github.com/users/mlovic/following{/other_user}","gists_url":"https://api.github.com/users/mlovic/gists{/gist_id}","starred_url":"https://api.github.com/users/mlovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlovic/subscriptions","organizations_url":"https://api.github.com/users/mlovic/orgs","repos_url":"https://api.github.com/users/mlovic/repos","events_url":"https://api.github.com/users/mlovic/events{/privacy}","received_events_url":"https://api.github.com/users/mlovic/received_events","type":"User","site_admin":false},"assignees":[{"login":"mlovic","id":7111622,"node_id":"MDQ6VXNlcjcxMTE2MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/7111622?v=4","gravatar_id":"","url":"https://api.github.com/users/mlovic","html_url":"https://github.com/mlovic","followers_url":"https://api.github.com/users/mlovic/followers","following_url":"https://api.github.com/users/mlovic/following{/other_user}","gists_url":"https://api.github.com/users/mlovic/gists{/gist_id}","starred_url":"https://api.github.com/users/mlovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlovic/subscriptions","organizations_url":"https://api.github.com/users/mlovic/orgs","repos_url":"https://api.github.com/users/mlovic/repos","events_url":"https://api.github.com/users/mlovic/events{/privacy}","received_events_url":"https://api.github.com/users/mlovic/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-07-13T12:11:27Z","updated_at":"2018-07-13T13:50:56Z","closed_at":null,"author_association":"MEMBER","body":"Context\r\n===\r\nBudget investments have [Milestones](https://github.com/consul/consul/pull/1688) to be able display the chronological order of events from becoming a winning investment to becoming an executed investment in real life\r\n\r\nWe would also like to add Milestone to [Proposals](https://github.com/consul/consul/issues/2740) and [Legislations](https://github.com/consul/consul/issues/2743)\r\n\r\nWhat\r\n===\r\n- Make Milestones  [polymorphic](http://guides.rubyonrails.org/association_basics.html#polymorphic-associations)\r\n\r\nHow\r\n===\r\n- Creating a `Milestonable` Concern\r\n- Adding it to Budgets\r\n- Creating the corresponding rake tasks to migrate data from the now obsolete table `Budget::Investment::Milestone`\r\n\r\nUpdate\r\n===\r\nTake into account the related migration from a `Budget::Investment::Status` to for example a `Milestone::Status`"},"comment":{"url":"https://api.github.com/repos/consul/consul/issues/comments/404839471","html_url":"https://github.com/consul/consul/issues/2763#issuecomment-404839471","issue_url":"https://api.github.com/repos/consul/consul/issues/2763","id":404839471,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDgzOTQ3MQ==","user":{"login":"voodoorai2000","id":4169,"node_id":"MDQ6VXNlcjQxNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/4169?v=4","gravatar_id":"","url":"https://api.github.com/users/voodoorai2000","html_url":"https://github.com/voodoorai2000","followers_url":"https://api.github.com/users/voodoorai2000/followers","following_url":"https://api.github.com/users/voodoorai2000/following{/other_user}","gists_url":"https://api.github.com/users/voodoorai2000/gists{/gist_id}","starred_url":"https://api.github.com/users/voodoorai2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voodoorai2000/subscriptions","organizations_url":"https://api.github.com/users/voodoorai2000/orgs","repos_url":"https://api.github.com/users/voodoorai2000/repos","events_url":"https://api.github.com/users/voodoorai2000/events{/privacy}","received_events_url":"https://api.github.com/users/voodoorai2000/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T13:50:56Z","updated_at":"2018-07-13T13:50:56Z","author_association":"MEMBER","body":"Great, yes that's pretty much it 😌\r\n(I think 4 will have to be the first step though)\r\n\r\nAvailability is very important, but yes I think we can assume no writes will happen between 1 and 4\r\n\r\nI would do 1-4 in this PR and include it in the upcoming release (right now 0.16)\r\nAnd 5 in a separate PR and include it in the subsequent release (0.17) 👌"}}
{"actor":{"display_login":"voodoorai2000"}}