{"action":"created","comment":{"url":"https://api.github.com/repos/uber/zanzibar/pulls/comments/179850970","pull_request_review_id":110177796,"id":179850970,"diff_hunk":"@@ -0,0 +1,54 @@\n+package bar_test\n+\n+import (\n+\t\"encoding/json\"\n+\t\"io/ioutil\"\n+\t\"net/http\"\n+\t\"testing\"\n+\n+\tclientsBarBar \"github.com/uber/zanzibar/examples/example-gateway/build/gen-code/clients/bar/bar\"\n+\tendpointsBarBar \"github.com/uber/zanzibar/examples/example-gateway/build/gen-code/endpoints/bar/bar\"\n+\tms \"github.com/uber/zanzibar/examples/example-gateway/build/services/example-gateway/mock-service\"\n+\n+\t\"github.com/golang/mock/gomock\"\n+\t\"github.com/stretchr/testify/assert\"\n+)\n+\n+func TestBarCall(t *testing.T) {\n+\tms := ms.MustCreateTestService(t)\n+\tms.Start()\n+\tdefer ms.Stop()\n+\n+\tuserUUID := \"1-1-1-1\"\n+\texpectedRequest := &clientsBarBar.Bar_ArgWithQueryParams_Args{\n+\t\tName:     \"kot\",\n+\t\tUserUUID: &userUUID,\n+\t\t// This is currently broken due to https://github.com/uber/zanzibar/issues/371\n+\t\t// Tags:     []string{\"foo\", \"bar\"},\n+\t\tTags: []string{},\n+\t}\n+\texpectedHeaders := map[string]string{}\n+\tbarClientResp := &clientsBarBar.BarResponse{\n+\t\tStringField: \"foobar\",\n+\t\tBinaryField: []byte(\"\"),\n+\t}\n+\n+\tms.MockClients().Bar.EXPECT().ArgWithQueryParams(gomock.Any(), expectedHeaders, expectedRequest).\n+\t\tReturn(barClientResp, map[string]string{}, nil)\n+\n+\tresp, err := ms.MakeHTTPRequest(\"GET\", \"/bar/argWithQueryParams?tags=foo&tags=bar&userUUID=1-1-1-1&name=kot\", map[string]string{}, nil)\n+\tassert.NoError(t, err)\n+\tassert.Equal(t, http.StatusOK, resp.StatusCode)\n+\n+\trespBytes, err := ioutil.ReadAll(resp.Body)\n+\tassert.NoError(t, err)\n+\n+\trespBody := &endpointsBarBar.BarResponse{}\n+\terr = json.Unmarshal(respBytes, respBody)\n+\tassert.NoError(t, err)\n+\n+\t// t.Logf(\"Resp body: %s\", respBytes)\n+\t// t.Logf(\"Resp body: %+v\", respBody)\n+\n+\tassert.Equal(t, \"foobar\", respBody.StringField)\n+}","path":"examples/example-gateway/endpoints/bar/bar_call_test.go","position":54,"original_position":54,"commit_id":"a7084e31dc655997d5d875fd6a9d839504418200","original_commit_id":"a7084e31dc655997d5d875fd6a9d839504418200","user":{"login":"ChuntaoLu","id":5065819,"avatar_url":"https://avatars0.githubusercontent.com/u/5065819?v=4","gravatar_id":"","url":"https://api.github.com/users/ChuntaoLu","html_url":"https://github.com/ChuntaoLu","followers_url":"https://api.github.com/users/ChuntaoLu/followers","following_url":"https://api.github.com/users/ChuntaoLu/following{/other_user}","gists_url":"https://api.github.com/users/ChuntaoLu/gists{/gist_id}","starred_url":"https://api.github.com/users/ChuntaoLu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChuntaoLu/subscriptions","organizations_url":"https://api.github.com/users/ChuntaoLu/orgs","repos_url":"https://api.github.com/users/ChuntaoLu/repos","events_url":"https://api.github.com/users/ChuntaoLu/events{/privacy}","received_events_url":"https://api.github.com/users/ChuntaoLu/received_events","type":"User","site_admin":false},"body":"> Creates a failing test for #371\r\n\r\nDoes this test fail?","created_at":"2018-04-06T19:12:07Z","updated_at":"2018-04-06T19:12:08Z","html_url":"https://github.com/uber/zanzibar/pull/372#discussion_r179850970","pull_request_url":"https://api.github.com/repos/uber/zanzibar/pulls/372","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/comments/179850970"},"html":{"href":"https://github.com/uber/zanzibar/pull/372#discussion_r179850970"},"pull_request":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/372"}}},"pull_request":{"url":"https://api.github.com/repos/uber/zanzibar/pulls/372","id":179813853,"html_url":"https://github.com/uber/zanzibar/pull/372","diff_url":"https://github.com/uber/zanzibar/pull/372.diff","patch_url":"https://github.com/uber/zanzibar/pull/372.patch","issue_url":"https://api.github.com/repos/uber/zanzibar/issues/372","number":372,"state":"open","locked":false,"title":"Add test case for HTTP query parameters of type list","user":{"login":"jacobgreenleaf","id":2646558,"avatar_url":"https://avatars3.githubusercontent.com/u/2646558?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobgreenleaf","html_url":"https://github.com/jacobgreenleaf","followers_url":"https://api.github.com/users/jacobgreenleaf/followers","following_url":"https://api.github.com/users/jacobgreenleaf/following{/other_user}","gists_url":"https://api.github.com/users/jacobgreenleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobgreenleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobgreenleaf/subscriptions","organizations_url":"https://api.github.com/users/jacobgreenleaf/orgs","repos_url":"https://api.github.com/users/jacobgreenleaf/repos","events_url":"https://api.github.com/users/jacobgreenleaf/events{/privacy}","received_events_url":"https://api.github.com/users/jacobgreenleaf/received_events","type":"User","site_admin":false},"body":"Creates a failing test for #371 and removes the panic on generate. Instead the value will be nil until we add support for this. ","created_at":"2018-04-05T22:30:36Z","updated_at":"2018-04-06T19:12:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2a20112a02112a05f7cee55e5816d8341d81796","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/zanzibar/pulls/372/commits","review_comments_url":"https://api.github.com/repos/uber/zanzibar/pulls/372/comments","review_comment_url":"https://api.github.com/repos/uber/zanzibar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/zanzibar/issues/372/comments","statuses_url":"https://api.github.com/repos/uber/zanzibar/statuses/a7084e31dc655997d5d875fd6a9d839504418200","head":{"label":"uber:jg-panic-list","ref":"jg-panic-list","sha":"a7084e31dc655997d5d875fd6a9d839504418200","user":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":85628655,"name":"zanzibar","full_name":"uber/zanzibar","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/zanzibar","description":"A build system & configuration system to generate versioned API gateways.","fork":false,"url":"https://api.github.com/repos/uber/zanzibar","forks_url":"https://api.github.com/repos/uber/zanzibar/forks","keys_url":"https://api.github.com/repos/uber/zanzibar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/zanzibar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/zanzibar/teams","hooks_url":"https://api.github.com/repos/uber/zanzibar/hooks","issue_events_url":"https://api.github.com/repos/uber/zanzibar/issues/events{/number}","events_url":"https://api.github.com/repos/uber/zanzibar/events","assignees_url":"https://api.github.com/repos/uber/zanzibar/assignees{/user}","branches_url":"https://api.github.com/repos/uber/zanzibar/branches{/branch}","tags_url":"https://api.github.com/repos/uber/zanzibar/tags","blobs_url":"https://api.github.com/repos/uber/zanzibar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/zanzibar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/zanzibar/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/zanzibar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/zanzibar/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/zanzibar/languages","stargazers_url":"https://api.github.com/repos/uber/zanzibar/stargazers","contributors_url":"https://api.github.com/repos/uber/zanzibar/contributors","subscribers_url":"https://api.github.com/repos/uber/zanzibar/subscribers","subscription_url":"https://api.github.com/repos/uber/zanzibar/subscription","commits_url":"https://api.github.com/repos/uber/zanzibar/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/zanzibar/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/zanzibar/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/zanzibar/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/zanzibar/contents/{+path}","compare_url":"https://api.github.com/repos/uber/zanzibar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/zanzibar/merges","archive_url":"https://api.github.com/repos/uber/zanzibar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/zanzibar/downloads","issues_url":"https://api.github.com/repos/uber/zanzibar/issues{/number}","pulls_url":"https://api.github.com/repos/uber/zanzibar/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/zanzibar/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/zanzibar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/zanzibar/labels{/name}","releases_url":"https://api.github.com/repos/uber/zanzibar/releases{/id}","deployments_url":"https://api.github.com/repos/uber/zanzibar/deployments","created_at":"2017-03-20T21:22:09Z","updated_at":"2018-03-29T00:31:25Z","pushed_at":"2018-04-06T19:10:37Z","git_url":"git://github.com/uber/zanzibar.git","ssh_url":"git@github.com:uber/zanzibar.git","clone_url":"https://github.com/uber/zanzibar.git","svn_url":"https://github.com/uber/zanzibar","homepage":"","size":13836,"stargazers_count":60,"watchers_count":60,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":13,"open_issues":28,"watchers":60,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"d9ca73240723ab98ae657fd9c4de1c8d5a25050d","user":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":85628655,"name":"zanzibar","full_name":"uber/zanzibar","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/zanzibar","description":"A build system & configuration system to generate versioned API gateways.","fork":false,"url":"https://api.github.com/repos/uber/zanzibar","forks_url":"https://api.github.com/repos/uber/zanzibar/forks","keys_url":"https://api.github.com/repos/uber/zanzibar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/zanzibar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/zanzibar/teams","hooks_url":"https://api.github.com/repos/uber/zanzibar/hooks","issue_events_url":"https://api.github.com/repos/uber/zanzibar/issues/events{/number}","events_url":"https://api.github.com/repos/uber/zanzibar/events","assignees_url":"https://api.github.com/repos/uber/zanzibar/assignees{/user}","branches_url":"https://api.github.com/repos/uber/zanzibar/branches{/branch}","tags_url":"https://api.github.com/repos/uber/zanzibar/tags","blobs_url":"https://api.github.com/repos/uber/zanzibar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/zanzibar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/zanzibar/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/zanzibar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/zanzibar/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/zanzibar/languages","stargazers_url":"https://api.github.com/repos/uber/zanzibar/stargazers","contributors_url":"https://api.github.com/repos/uber/zanzibar/contributors","subscribers_url":"https://api.github.com/repos/uber/zanzibar/subscribers","subscription_url":"https://api.github.com/repos/uber/zanzibar/subscription","commits_url":"https://api.github.com/repos/uber/zanzibar/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/zanzibar/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/zanzibar/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/zanzibar/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/zanzibar/contents/{+path}","compare_url":"https://api.github.com/repos/uber/zanzibar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/zanzibar/merges","archive_url":"https://api.github.com/repos/uber/zanzibar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/zanzibar/downloads","issues_url":"https://api.github.com/repos/uber/zanzibar/issues{/number}","pulls_url":"https://api.github.com/repos/uber/zanzibar/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/zanzibar/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/zanzibar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/zanzibar/labels{/name}","releases_url":"https://api.github.com/repos/uber/zanzibar/releases{/id}","deployments_url":"https://api.github.com/repos/uber/zanzibar/deployments","created_at":"2017-03-20T21:22:09Z","updated_at":"2018-03-29T00:31:25Z","pushed_at":"2018-04-06T19:10:37Z","git_url":"git://github.com/uber/zanzibar.git","ssh_url":"git@github.com:uber/zanzibar.git","clone_url":"https://github.com/uber/zanzibar.git","svn_url":"https://github.com/uber/zanzibar","homepage":"","size":13836,"stargazers_count":60,"watchers_count":60,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":13,"open_issues":28,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/372"},"html":{"href":"https://github.com/uber/zanzibar/pull/372"},"issue":{"href":"https://api.github.com/repos/uber/zanzibar/issues/372"},"comments":{"href":"https://api.github.com/repos/uber/zanzibar/issues/372/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/372/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/372/commits"},"statuses":{"href":"https://api.github.com/repos/uber/zanzibar/statuses/a7084e31dc655997d5d875fd6a9d839504418200"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ChuntaoLu"}}