{"action":"created","issue":{"url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/473","repository_url":"https://api.github.com/repos/mendersoftware/meta-mender","labels_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/473/labels{/name}","comments_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/473/comments","events_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/473/events","html_url":"https://github.com/mendersoftware/meta-mender/pull/473","id":296671485,"number":473,"title":"fix support of CONVERSIONTYPES for sdimg","user":{"login":"mirzak","id":5717557,"avatar_url":"https://avatars2.githubusercontent.com/u/5717557?v=4","gravatar_id":"","url":"https://api.github.com/users/mirzak","html_url":"https://github.com/mirzak","followers_url":"https://api.github.com/users/mirzak/followers","following_url":"https://api.github.com/users/mirzak/following{/other_user}","gists_url":"https://api.github.com/users/mirzak/gists{/gist_id}","starred_url":"https://api.github.com/users/mirzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirzak/subscriptions","organizations_url":"https://api.github.com/users/mirzak/orgs","repos_url":"https://api.github.com/users/mirzak/repos","events_url":"https://api.github.com/users/mirzak/events{/privacy}","received_events_url":"https://api.github.com/users/mirzak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-13T09:42:40Z","updated_at":"2018-02-14T19:45:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/473","html_url":"https://github.com/mendersoftware/meta-mender/pull/473","diff_url":"https://github.com/mendersoftware/meta-mender/pull/473.diff","patch_url":"https://github.com/mendersoftware/meta-mender/pull/473.patch"},"body":"The image_types.bbclass defines a set of conversion types that can be\r\napplied to images (gz, xz, bz2 and more).\r\n\r\nWith the current state it is not possible to apply an conversion type\r\non the sdimg using:\r\n\r\n\tIMAGE_FSTYPES += \"sdimg.gz\"\r\n\r\nBecause the conversion types assume that that the image is named in the\r\nfollowing format:\r\n\r\n\t${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}\r\n\r\nIMAGE_NAME_SUFFIX defaults to \".rootfs\" which breaks things for us. By\r\nsetting IMAGE_NAME_SUFFIX to an empty string the expected image name\r\nformat is correct and the sdimg type can support all the conversiontypes\r\nthat are present in image_types.bbclass.\r\n\r\nAbove is really helpfull to compress the \"sdimg\" file as it mostly consist\r\nof zero's and by compressing it is much easier to handle, transfer between\r\ndevices or between servers.\r\n\r\nNote that this change does not generate a compressed sdimg by default, but\r\nonly adds support for it.\r\n\r\nChangelog: None\r\n\r\nSigned-off-by: Mirza Krak <mirza.krak@endian.se>"},"comment":{"url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/comments/365723090","html_url":"https://github.com/mendersoftware/meta-mender/pull/473#issuecomment-365723090","issue_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/473","id":365723090,"user":{"login":"drewmoseley","id":1001846,"avatar_url":"https://avatars0.githubusercontent.com/u/1001846?v=4","gravatar_id":"","url":"https://api.github.com/users/drewmoseley","html_url":"https://github.com/drewmoseley","followers_url":"https://api.github.com/users/drewmoseley/followers","following_url":"https://api.github.com/users/drewmoseley/following{/other_user}","gists_url":"https://api.github.com/users/drewmoseley/gists{/gist_id}","starred_url":"https://api.github.com/users/drewmoseley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewmoseley/subscriptions","organizations_url":"https://api.github.com/users/drewmoseley/orgs","repos_url":"https://api.github.com/users/drewmoseley/repos","events_url":"https://api.github.com/users/drewmoseley/events{/privacy}","received_events_url":"https://api.github.com/users/drewmoseley/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T19:45:26Z","updated_at":"2018-02-14T19:45:26Z","author_association":"CONTRIBUTOR","body":"@mirzak this patch removes the \"rootfs\" suffix from all images, and doesn't just fix the conversion of sdimg files.  That feels like it will break many deployment and CI scripts since the file names for so many things will change.\r\n\r\nWhile it's not logically a single rootfs, would we be better off adding ${IMAGE_NAME_SUFFIX} to the sdimg files?  Or maybe create a symlink so that we have both the old and the new style names?\r\n\r\nFWIW, it looks like the ubimg class is using ${IMAGE_NAME_SUFFIX} already.\r\n\r\n@kacf thoughts?"}}
{"actor":{"display_login":"drewmoseley"}}