{"action":"closed","issue":{"url":"https://api.github.com/repos/jamesmunns/nrf52-hal/issues/9","repository_url":"https://api.github.com/repos/jamesmunns/nrf52-hal","labels_url":"https://api.github.com/repos/jamesmunns/nrf52-hal/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/jamesmunns/nrf52-hal/issues/9/comments","events_url":"https://api.github.com/repos/jamesmunns/nrf52-hal/issues/9/events","html_url":"https://github.com/jamesmunns/nrf52-hal/issues/9","id":353236708,"node_id":"MDU6SXNzdWUzNTMyMzY3MDg=","number":9,"title":"RFC: shared hal impl for nrf52840?","user":{"login":"wez","id":117777,"node_id":"MDQ6VXNlcjExNzc3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/117777?v=4","gravatar_id":"","url":"https://api.github.com/users/wez","html_url":"https://github.com/wez","followers_url":"https://api.github.com/users/wez/followers","following_url":"https://api.github.com/users/wez/following{/other_user}","gists_url":"https://api.github.com/users/wez/gists{/gist_id}","starred_url":"https://api.github.com/users/wez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wez/subscriptions","organizations_url":"https://api.github.com/users/wez/orgs","repos_url":"https://api.github.com/users/wez/repos","events_url":"https://api.github.com/users/wez/events{/privacy}","received_events_url":"https://api.github.com/users/wez/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-08-23T06:04:35Z","updated_at":"2018-09-09T18:41:22Z","closed_at":"2018-09-09T18:41:21Z","author_association":"COLLABORATOR","body":"I've got my eye on these nrf52840 based boards: https://www.particle.io/mesh, so I'm doing some prep work.  https://github.com/wez/nrf52840 has an up to date set of bindings generated by svd2rust, and it appears from diffing nrf52 vs that repo that most of the core peripherals have equivalent definitions.\r\n\r\nIt feels in the spirit of DRY to have a HAL that can target both nrf52 and nrf52840.\r\n\r\nWhat are your thoughts on how best to structure this?\r\n\r\nIn https://github.com/wez/atsamd21-rs/ I have a collection of svd2rust generated bindings, a single hal that targets them, and some board crates that consume the hal.  It's *a* way to do something like this, but maybe not the best way.\r\n"}}
{"actor":{"display_login":"jamesmunns"}}