{"action":"created","comment":{"url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/comments/230675946","pull_request_review_id":171464441,"id":230675946,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDY3NTk0Ng==","diff_hunk":"@@ -243,7 +243,7 @@ func TestTime_DayOfWeek(t *testing.T) {\n \t\t{\"null date\", sql.NewRow(nil), nil, false},\n \t\t{\"invalid type\", sql.NewRow([]byte{0, 1, 2}), nil, false},\n \t\t{\"date as string\", sql.NewRow(stringDate), int32(3), false},\n-\t\t{\"date as time\", sql.NewRow(time.Now()), int32(time.Now().UTC().Weekday()+1) % 7, false},\n+\t\t{\"date as time\", sql.NewRow(time.Now()), int32(time.Now().UTC().Weekday() + 1), false},","path":"sql/expression/function/time_test.go","position":5,"original_position":5,"commit_id":"0977d9b2468e61aaf71cbfdc573ccddd7355f8ab","original_commit_id":"0977d9b2468e61aaf71cbfdc573ccddd7355f8ab","user":{"login":"mcarmonaa","id":16907441,"node_id":"MDQ6VXNlcjE2OTA3NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/16907441?v=4","gravatar_id":"","url":"https://api.github.com/users/mcarmonaa","html_url":"https://github.com/mcarmonaa","followers_url":"https://api.github.com/users/mcarmonaa/followers","following_url":"https://api.github.com/users/mcarmonaa/following{/other_user}","gists_url":"https://api.github.com/users/mcarmonaa/gists{/gist_id}","starred_url":"https://api.github.com/users/mcarmonaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcarmonaa/subscriptions","organizations_url":"https://api.github.com/users/mcarmonaa/orgs","repos_url":"https://api.github.com/users/mcarmonaa/repos","events_url":"https://api.github.com/users/mcarmonaa/events{/privacy}","received_events_url":"https://api.github.com/users/mcarmonaa/received_events","type":"User","site_admin":false},"body":"if weekday == 6 it would return 7, MySQL weekday index range is [0, 6] https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_weekday","created_at":"2018-11-05T09:16:10Z","updated_at":"2018-11-05T09:16:14Z","html_url":"https://github.com/src-d/go-mysql-server/pull/525#discussion_r230675946","pull_request_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/525","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/comments/230675946"},"html":{"href":"https://github.com/src-d/go-mysql-server/pull/525#discussion_r230675946"},"pull_request":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/525"}}},"pull_request":{"url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/525","id":227790894,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NzkwODk0","html_url":"https://github.com/src-d/go-mysql-server/pull/525","diff_url":"https://github.com/src-d/go-mysql-server/pull/525.diff","patch_url":"https://github.com/src-d/go-mysql-server/pull/525.patch","issue_url":"https://api.github.com/repos/src-d/go-mysql-server/issues/525","number":525,"state":"open","locked":false,"title":"Implement group by index","user":{"login":"kuba--","id":4056521,"node_id":"MDQ6VXNlcjQwNTY1MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/4056521?v=4","gravatar_id":"","url":"https://api.github.com/users/kuba--","html_url":"https://github.com/kuba--","followers_url":"https://api.github.com/users/kuba--/followers","following_url":"https://api.github.com/users/kuba--/following{/other_user}","gists_url":"https://api.github.com/users/kuba--/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba--/subscriptions","organizations_url":"https://api.github.com/users/kuba--/orgs","repos_url":"https://api.github.com/users/kuba--/repos","events_url":"https://api.github.com/users/kuba--/events{/privacy}","received_events_url":"https://api.github.com/users/kuba--/received_events","type":"User","site_admin":false},"body":"Signed-off-by: kuba-- <kuba@sourced.tech>\r\n\r\nCloses: https://github.com/src-d/go-mysql-server/issues/520, https://github.com/src-d/go-mysql-server/issues/524","created_at":"2018-11-01T23:32:47Z","updated_at":"2018-11-05T09:16:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d86c9adf7c34c231a49d4218946ac342e1db48d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":835651612,"node_id":"MDU6TGFiZWw4MzU2NTE2MTI=","url":"https://api.github.com/repos/src-d/go-mysql-server/labels/bug","name":"bug","color":"d73a4a","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/525/commits","review_comments_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/525/comments","review_comment_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/src-d/go-mysql-server/issues/525/comments","statuses_url":"https://api.github.com/repos/src-d/go-mysql-server/statuses/0977d9b2468e61aaf71cbfdc573ccddd7355f8ab","head":{"label":"kuba--:tableau-520/group-by","ref":"tableau-520/group-by","sha":"0977d9b2468e61aaf71cbfdc573ccddd7355f8ab","user":{"login":"kuba--","id":4056521,"node_id":"MDQ6VXNlcjQwNTY1MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/4056521?v=4","gravatar_id":"","url":"https://api.github.com/users/kuba--","html_url":"https://github.com/kuba--","followers_url":"https://api.github.com/users/kuba--/followers","following_url":"https://api.github.com/users/kuba--/following{/other_user}","gists_url":"https://api.github.com/users/kuba--/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba--/subscriptions","organizations_url":"https://api.github.com/users/kuba--/orgs","repos_url":"https://api.github.com/users/kuba--/repos","events_url":"https://api.github.com/users/kuba--/events{/privacy}","received_events_url":"https://api.github.com/users/kuba--/received_events","type":"User","site_admin":false},"repo":{"id":143021670,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwMjE2NzA=","name":"go-mysql-server","full_name":"kuba--/go-mysql-server","private":false,"owner":{"login":"kuba--","id":4056521,"node_id":"MDQ6VXNlcjQwNTY1MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/4056521?v=4","gravatar_id":"","url":"https://api.github.com/users/kuba--","html_url":"https://github.com/kuba--","followers_url":"https://api.github.com/users/kuba--/followers","following_url":"https://api.github.com/users/kuba--/following{/other_user}","gists_url":"https://api.github.com/users/kuba--/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba--/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba--/subscriptions","organizations_url":"https://api.github.com/users/kuba--/orgs","repos_url":"https://api.github.com/users/kuba--/repos","events_url":"https://api.github.com/users/kuba--/events{/privacy}","received_events_url":"https://api.github.com/users/kuba--/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kuba--/go-mysql-server","description":"An extensible MySQL server implementation in Go.","fork":true,"url":"https://api.github.com/repos/kuba--/go-mysql-server","forks_url":"https://api.github.com/repos/kuba--/go-mysql-server/forks","keys_url":"https://api.github.com/repos/kuba--/go-mysql-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kuba--/go-mysql-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kuba--/go-mysql-server/teams","hooks_url":"https://api.github.com/repos/kuba--/go-mysql-server/hooks","issue_events_url":"https://api.github.com/repos/kuba--/go-mysql-server/issues/events{/number}","events_url":"https://api.github.com/repos/kuba--/go-mysql-server/events","assignees_url":"https://api.github.com/repos/kuba--/go-mysql-server/assignees{/user}","branches_url":"https://api.github.com/repos/kuba--/go-mysql-server/branches{/branch}","tags_url":"https://api.github.com/repos/kuba--/go-mysql-server/tags","blobs_url":"https://api.github.com/repos/kuba--/go-mysql-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kuba--/go-mysql-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kuba--/go-mysql-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/kuba--/go-mysql-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kuba--/go-mysql-server/statuses/{sha}","languages_url":"https://api.github.com/repos/kuba--/go-mysql-server/languages","stargazers_url":"https://api.github.com/repos/kuba--/go-mysql-server/stargazers","contributors_url":"https://api.github.com/repos/kuba--/go-mysql-server/contributors","subscribers_url":"https://api.github.com/repos/kuba--/go-mysql-server/subscribers","subscription_url":"https://api.github.com/repos/kuba--/go-mysql-server/subscription","commits_url":"https://api.github.com/repos/kuba--/go-mysql-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/kuba--/go-mysql-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/kuba--/go-mysql-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/kuba--/go-mysql-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/kuba--/go-mysql-server/contents/{+path}","compare_url":"https://api.github.com/repos/kuba--/go-mysql-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kuba--/go-mysql-server/merges","archive_url":"https://api.github.com/repos/kuba--/go-mysql-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kuba--/go-mysql-server/downloads","issues_url":"https://api.github.com/repos/kuba--/go-mysql-server/issues{/number}","pulls_url":"https://api.github.com/repos/kuba--/go-mysql-server/pulls{/number}","milestones_url":"https://api.github.com/repos/kuba--/go-mysql-server/milestones{/number}","notifications_url":"https://api.github.com/repos/kuba--/go-mysql-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kuba--/go-mysql-server/labels{/name}","releases_url":"https://api.github.com/repos/kuba--/go-mysql-server/releases{/id}","deployments_url":"https://api.github.com/repos/kuba--/go-mysql-server/deployments","created_at":"2018-07-31T13:58:14Z","updated_at":"2018-11-05T00:22:47Z","pushed_at":"2018-11-05T00:22:45Z","git_url":"git://github.com/kuba--/go-mysql-server.git","ssh_url":"git@github.com:kuba--/go-mysql-server.git","clone_url":"https://github.com/kuba--/go-mysql-server.git","svn_url":"https://github.com/kuba--/go-mysql-server","homepage":"","size":1892,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"src-d:master","ref":"master","sha":"4a751c09d9fd0d59f790ad8edd28a9799fe669f8","user":{"login":"src-d","id":15128793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTI4Nzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"repo":{"id":121319560,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEzMTk1NjA=","name":"go-mysql-server","full_name":"src-d/go-mysql-server","private":false,"owner":{"login":"src-d","id":15128793,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MTI4Nzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15128793?v=4","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/src-d/go-mysql-server","description":"An extensible MySQL server implementation in Go.","fork":false,"url":"https://api.github.com/repos/src-d/go-mysql-server","forks_url":"https://api.github.com/repos/src-d/go-mysql-server/forks","keys_url":"https://api.github.com/repos/src-d/go-mysql-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/src-d/go-mysql-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/src-d/go-mysql-server/teams","hooks_url":"https://api.github.com/repos/src-d/go-mysql-server/hooks","issue_events_url":"https://api.github.com/repos/src-d/go-mysql-server/issues/events{/number}","events_url":"https://api.github.com/repos/src-d/go-mysql-server/events","assignees_url":"https://api.github.com/repos/src-d/go-mysql-server/assignees{/user}","branches_url":"https://api.github.com/repos/src-d/go-mysql-server/branches{/branch}","tags_url":"https://api.github.com/repos/src-d/go-mysql-server/tags","blobs_url":"https://api.github.com/repos/src-d/go-mysql-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/src-d/go-mysql-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/src-d/go-mysql-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/src-d/go-mysql-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/src-d/go-mysql-server/statuses/{sha}","languages_url":"https://api.github.com/repos/src-d/go-mysql-server/languages","stargazers_url":"https://api.github.com/repos/src-d/go-mysql-server/stargazers","contributors_url":"https://api.github.com/repos/src-d/go-mysql-server/contributors","subscribers_url":"https://api.github.com/repos/src-d/go-mysql-server/subscribers","subscription_url":"https://api.github.com/repos/src-d/go-mysql-server/subscription","commits_url":"https://api.github.com/repos/src-d/go-mysql-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/src-d/go-mysql-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/src-d/go-mysql-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/src-d/go-mysql-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/src-d/go-mysql-server/contents/{+path}","compare_url":"https://api.github.com/repos/src-d/go-mysql-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/src-d/go-mysql-server/merges","archive_url":"https://api.github.com/repos/src-d/go-mysql-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/src-d/go-mysql-server/downloads","issues_url":"https://api.github.com/repos/src-d/go-mysql-server/issues{/number}","pulls_url":"https://api.github.com/repos/src-d/go-mysql-server/pulls{/number}","milestones_url":"https://api.github.com/repos/src-d/go-mysql-server/milestones{/number}","notifications_url":"https://api.github.com/repos/src-d/go-mysql-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/src-d/go-mysql-server/labels{/name}","releases_url":"https://api.github.com/repos/src-d/go-mysql-server/releases{/id}","deployments_url":"https://api.github.com/repos/src-d/go-mysql-server/deployments","created_at":"2018-02-13T00:24:19Z","updated_at":"2018-11-05T09:09:07Z","pushed_at":"2018-11-05T09:09:05Z","git_url":"git://github.com/src-d/go-mysql-server.git","ssh_url":"git@github.com:src-d/go-mysql-server.git","clone_url":"https://github.com/src-d/go-mysql-server.git","svn_url":"https://github.com/src-d/go-mysql-server","homepage":"","size":1897,"stargazers_count":504,"watchers_count":504,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":54,"open_issues":31,"watchers":504,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/525"},"html":{"href":"https://github.com/src-d/go-mysql-server/pull/525"},"issue":{"href":"https://api.github.com/repos/src-d/go-mysql-server/issues/525"},"comments":{"href":"https://api.github.com/repos/src-d/go-mysql-server/issues/525/comments"},"review_comments":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/525/comments"},"review_comment":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/src-d/go-mysql-server/pulls/525/commits"},"statuses":{"href":"https://api.github.com/repos/src-d/go-mysql-server/statuses/0977d9b2468e61aaf71cbfdc573ccddd7355f8ab"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mcarmonaa"}}