{"action":"closed","number":2767,"pull_request":{"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/2767","id":217675585,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3Njc1NTg1","html_url":"https://github.com/openfoodfoundation/openfoodnetwork/pull/2767","diff_url":"https://github.com/openfoodfoundation/openfoodnetwork/pull/2767.diff","patch_url":"https://github.com/openfoodfoundation/openfoodnetwork/pull/2767.patch","issue_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2767","number":2767,"state":"closed","locked":false,"title":"[Spree Upgrade] Destroy all shipments when clearing order","user":{"login":"luisramos0","id":1640378,"node_id":"MDQ6VXNlcjE2NDAzNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1640378?v=4","gravatar_id":"","url":"https://api.github.com/users/luisramos0","html_url":"https://github.com/luisramos0","followers_url":"https://api.github.com/users/luisramos0/followers","following_url":"https://api.github.com/users/luisramos0/following{/other_user}","gists_url":"https://api.github.com/users/luisramos0/gists{/gist_id}","starred_url":"https://api.github.com/users/luisramos0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisramos0/subscriptions","organizations_url":"https://api.github.com/users/luisramos0/orgs","repos_url":"https://api.github.com/users/luisramos0/repos","events_url":"https://api.github.com/users/luisramos0/events{/privacy}","received_events_url":"https://api.github.com/users/luisramos0/received_events","type":"User","site_admin":false},"body":"Now we only clear the order's shipping_method, and in Spree 2.0 it can have many shipments.\r\n\r\n#### What? Why?\r\n\r\nCloses #2681 \r\n\r\nI think @sauloperez solution is valid. This PR is just cherry picking the commit and resolving conflicts.\r\n\r\n#### What should we test?\r\nFixes order.empty route.","created_at":"2018-09-24T14:27:36Z","updated_at":"2018-09-26T06:54:12Z","closed_at":"2018-09-26T06:54:12Z","merged_at":"2018-09-26T06:54:12Z","merge_commit_sha":"037432d1a79bc4f1568ce9dac96cbb67f139fd22","assignee":{"login":"luisramos0","id":1640378,"node_id":"MDQ6VXNlcjE2NDAzNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1640378?v=4","gravatar_id":"","url":"https://api.github.com/users/luisramos0","html_url":"https://github.com/luisramos0","followers_url":"https://api.github.com/users/luisramos0/followers","following_url":"https://api.github.com/users/luisramos0/following{/other_user}","gists_url":"https://api.github.com/users/luisramos0/gists{/gist_id}","starred_url":"https://api.github.com/users/luisramos0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisramos0/subscriptions","organizations_url":"https://api.github.com/users/luisramos0/orgs","repos_url":"https://api.github.com/users/luisramos0/repos","events_url":"https://api.github.com/users/luisramos0/events{/privacy}","received_events_url":"https://api.github.com/users/luisramos0/received_events","type":"User","site_admin":false},"assignees":[{"login":"luisramos0","id":1640378,"node_id":"MDQ6VXNlcjE2NDAzNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1640378?v=4","gravatar_id":"","url":"https://api.github.com/users/luisramos0","html_url":"https://github.com/luisramos0","followers_url":"https://api.github.com/users/luisramos0/followers","following_url":"https://api.github.com/users/luisramos0/following{/other_user}","gists_url":"https://api.github.com/users/luisramos0/gists{/gist_id}","starred_url":"https://api.github.com/users/luisramos0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisramos0/subscriptions","organizations_url":"https://api.github.com/users/luisramos0/orgs","repos_url":"https://api.github.com/users/luisramos0/repos","events_url":"https://api.github.com/users/luisramos0/events{/privacy}","received_events_url":"https://api.github.com/users/luisramos0/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/2767/commits","review_comments_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/2767/comments","review_comment_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2767/comments","statuses_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/statuses/eb64569c9ad1230b0f3669636128d8e087e275e4","head":{"label":"luisramos0:order_empty","ref":"order_empty","sha":"eb64569c9ad1230b0f3669636128d8e087e275e4","user":{"login":"luisramos0","id":1640378,"node_id":"MDQ6VXNlcjE2NDAzNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1640378?v=4","gravatar_id":"","url":"https://api.github.com/users/luisramos0","html_url":"https://github.com/luisramos0","followers_url":"https://api.github.com/users/luisramos0/followers","following_url":"https://api.github.com/users/luisramos0/following{/other_user}","gists_url":"https://api.github.com/users/luisramos0/gists{/gist_id}","starred_url":"https://api.github.com/users/luisramos0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisramos0/subscriptions","organizations_url":"https://api.github.com/users/luisramos0/orgs","repos_url":"https://api.github.com/users/luisramos0/repos","events_url":"https://api.github.com/users/luisramos0/events{/privacy}","received_events_url":"https://api.github.com/users/luisramos0/received_events","type":"User","site_admin":false},"repo":{"id":134475188,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0NzUxODg=","name":"openfoodnetwork","full_name":"luisramos0/openfoodnetwork","private":false,"owner":{"login":"luisramos0","id":1640378,"node_id":"MDQ6VXNlcjE2NDAzNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1640378?v=4","gravatar_id":"","url":"https://api.github.com/users/luisramos0","html_url":"https://github.com/luisramos0","followers_url":"https://api.github.com/users/luisramos0/followers","following_url":"https://api.github.com/users/luisramos0/following{/other_user}","gists_url":"https://api.github.com/users/luisramos0/gists{/gist_id}","starred_url":"https://api.github.com/users/luisramos0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisramos0/subscriptions","organizations_url":"https://api.github.com/users/luisramos0/orgs","repos_url":"https://api.github.com/users/luisramos0/repos","events_url":"https://api.github.com/users/luisramos0/events{/privacy}","received_events_url":"https://api.github.com/users/luisramos0/received_events","type":"User","site_admin":false},"html_url":"https://github.com/luisramos0/openfoodnetwork","description":"Connect suppliers, distributors and consumers for the sale and purchase of local produce","fork":true,"url":"https://api.github.com/repos/luisramos0/openfoodnetwork","forks_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/forks","keys_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/teams","hooks_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/hooks","issue_events_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/events","assignees_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/tags","blobs_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/languages","stargazers_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/stargazers","contributors_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/contributors","subscribers_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/subscribers","subscription_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/subscription","commits_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/merges","archive_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/downloads","issues_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/labels{/name}","releases_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/releases{/id}","deployments_url":"https://api.github.com/repos/luisramos0/openfoodnetwork/deployments","created_at":"2018-05-22T20:58:53Z","updated_at":"2018-09-24T13:59:03Z","pushed_at":"2018-09-25T18:02:52Z","git_url":"git://github.com/luisramos0/openfoodnetwork.git","ssh_url":"git@github.com:luisramos0/openfoodnetwork.git","clone_url":"https://github.com/luisramos0/openfoodnetwork.git","svn_url":"https://github.com/luisramos0/openfoodnetwork","homepage":"http://openfoodnetwork.org/","size":39039,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openfoodfoundation:2-0-stable","ref":"2-0-stable","sha":"08104c62bef3c936b460de973c968d924e9a4d0b","user":{"login":"openfoodfoundation","id":2578987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Nzg5ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2578987?v=4","gravatar_id":"","url":"https://api.github.com/users/openfoodfoundation","html_url":"https://github.com/openfoodfoundation","followers_url":"https://api.github.com/users/openfoodfoundation/followers","following_url":"https://api.github.com/users/openfoodfoundation/following{/other_user}","gists_url":"https://api.github.com/users/openfoodfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/openfoodfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfoodfoundation/subscriptions","organizations_url":"https://api.github.com/users/openfoodfoundation/orgs","repos_url":"https://api.github.com/users/openfoodfoundation/repos","events_url":"https://api.github.com/users/openfoodfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/openfoodfoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":6257856,"node_id":"MDEwOlJlcG9zaXRvcnk2MjU3ODU2","name":"openfoodnetwork","full_name":"openfoodfoundation/openfoodnetwork","private":false,"owner":{"login":"openfoodfoundation","id":2578987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Nzg5ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2578987?v=4","gravatar_id":"","url":"https://api.github.com/users/openfoodfoundation","html_url":"https://github.com/openfoodfoundation","followers_url":"https://api.github.com/users/openfoodfoundation/followers","following_url":"https://api.github.com/users/openfoodfoundation/following{/other_user}","gists_url":"https://api.github.com/users/openfoodfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/openfoodfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openfoodfoundation/subscriptions","organizations_url":"https://api.github.com/users/openfoodfoundation/orgs","repos_url":"https://api.github.com/users/openfoodfoundation/repos","events_url":"https://api.github.com/users/openfoodfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/openfoodfoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openfoodfoundation/openfoodnetwork","description":"Connect suppliers, distributors and consumers to trade local produce","fork":false,"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork","forks_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/forks","keys_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/teams","hooks_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/hooks","issue_events_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/events","assignees_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/tags","blobs_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/languages","stargazers_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/stargazers","contributors_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/contributors","subscribers_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/subscribers","subscription_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/subscription","commits_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/merges","archive_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/downloads","issues_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/labels{/name}","releases_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/releases{/id}","deployments_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/deployments","created_at":"2012-10-17T07:56:23Z","updated_at":"2018-09-25T20:33:36Z","pushed_at":"2018-09-26T06:54:12Z","git_url":"git://github.com/openfoodfoundation/openfoodnetwork.git","ssh_url":"git@github.com:openfoodfoundation/openfoodnetwork.git","clone_url":"https://github.com/openfoodfoundation/openfoodnetwork.git","svn_url":"https://github.com/openfoodfoundation/openfoodnetwork","homepage":"http://openfoodnetwork.org/","size":39148,"stargazers_count":320,"watchers_count":320,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":212,"mirror_url":null,"archived":false,"open_issues_count":446,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":212,"open_issues":446,"watchers":320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/2767"},"html":{"href":"https://github.com/openfoodfoundation/openfoodnetwork/pull/2767"},"issue":{"href":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2767"},"comments":{"href":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2767/comments"},"review_comments":{"href":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/2767/comments"},"review_comment":{"href":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/pulls/2767/commits"},"statuses":{"href":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/statuses/eb64569c9ad1230b0f3669636128d8e087e275e4"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sauloperez","id":762088,"node_id":"MDQ6VXNlcjc2MjA4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/762088?v=4","gravatar_id":"","url":"https://api.github.com/users/sauloperez","html_url":"https://github.com/sauloperez","followers_url":"https://api.github.com/users/sauloperez/followers","following_url":"https://api.github.com/users/sauloperez/following{/other_user}","gists_url":"https://api.github.com/users/sauloperez/gists{/gist_id}","starred_url":"https://api.github.com/users/sauloperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sauloperez/subscriptions","organizations_url":"https://api.github.com/users/sauloperez/orgs","repos_url":"https://api.github.com/users/sauloperez/repos","events_url":"https://api.github.com/users/sauloperez/events{/privacy}","received_events_url":"https://api.github.com/users/sauloperez/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"sauloperez"}}