{"action":"created","issue":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/9531","repository_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/9531/labels{/name}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/9531/comments","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/9531/events","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/9531","id":329941796,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMDcwNTMx","number":9531,"title":"WebKitViewController nav bar buttons color for accessibility bold text","user":{"login":"etoledom","id":9772967,"node_id":"MDQ6VXNlcjk3NzI5Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/9772967?v=4","gravatar_id":"","url":"https://api.github.com/users/etoledom","html_url":"https://github.com/etoledom","followers_url":"https://api.github.com/users/etoledom/followers","following_url":"https://api.github.com/users/etoledom/following{/other_user}","gists_url":"https://api.github.com/users/etoledom/gists{/gist_id}","starred_url":"https://api.github.com/users/etoledom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etoledom/subscriptions","organizations_url":"https://api.github.com/users/etoledom/orgs","repos_url":"https://api.github.com/users/etoledom/repos","events_url":"https://api.github.com/users/etoledom/events{/privacy}","received_events_url":"https://api.github.com/users/etoledom/received_events","type":"User","site_admin":false},"labels":[{"id":67301423,"node_id":"MDU6TGFiZWw2NzMwMTQyMw==","url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/labels/Accessibility","name":"Accessibility","color":"006b75","default":false}],"state":"open","locked":false,"assignee":{"login":"etoledom","id":9772967,"node_id":"MDQ6VXNlcjk3NzI5Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/9772967?v=4","gravatar_id":"","url":"https://api.github.com/users/etoledom","html_url":"https://github.com/etoledom","followers_url":"https://api.github.com/users/etoledom/followers","following_url":"https://api.github.com/users/etoledom/following{/other_user}","gists_url":"https://api.github.com/users/etoledom/gists{/gist_id}","starred_url":"https://api.github.com/users/etoledom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etoledom/subscriptions","organizations_url":"https://api.github.com/users/etoledom/orgs","repos_url":"https://api.github.com/users/etoledom/repos","events_url":"https://api.github.com/users/etoledom/events{/privacy}","received_events_url":"https://api.github.com/users/etoledom/received_events","type":"User","site_admin":false},"assignees":[{"login":"etoledom","id":9772967,"node_id":"MDQ6VXNlcjk3NzI5Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/9772967?v=4","gravatar_id":"","url":"https://api.github.com/users/etoledom","html_url":"https://github.com/etoledom","followers_url":"https://api.github.com/users/etoledom/followers","following_url":"https://api.github.com/users/etoledom/following{/other_user}","gists_url":"https://api.github.com/users/etoledom/gists{/gist_id}","starred_url":"https://api.github.com/users/etoledom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etoledom/subscriptions","organizations_url":"https://api.github.com/users/etoledom/orgs","repos_url":"https://api.github.com/users/etoledom/repos","events_url":"https://api.github.com/users/etoledom/events{/privacy}","received_events_url":"https://api.github.com/users/etoledom/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones/107","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/milestone/107","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones/107/labels","id":3360568,"node_id":"MDk6TWlsZXN0b25lMzM2MDU2OA==","number":107,"title":"10.3","description":"Code freeze: Jun 18th, 2018 App Store submission: Jul 2nd, 2018","creator":{"login":"loremattei","id":4836764,"node_id":"MDQ6VXNlcjQ4MzY3NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4836764?v=4","gravatar_id":"","url":"https://api.github.com/users/loremattei","html_url":"https://github.com/loremattei","followers_url":"https://api.github.com/users/loremattei/followers","following_url":"https://api.github.com/users/loremattei/following{/other_user}","gists_url":"https://api.github.com/users/loremattei/gists{/gist_id}","starred_url":"https://api.github.com/users/loremattei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loremattei/subscriptions","organizations_url":"https://api.github.com/users/loremattei/orgs","repos_url":"https://api.github.com/users/loremattei/repos","events_url":"https://api.github.com/users/loremattei/events{/privacy}","received_events_url":"https://api.github.com/users/loremattei/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":15,"state":"open","created_at":"2018-05-21T07:37:36Z","updated_at":"2018-06-08T14:31:44Z","due_on":"2018-06-18T07:00:00Z","closed_at":null},"comments":3,"created_at":"2018-06-06T16:25:13Z","updated_at":"2018-06-08T14:35:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/9531","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/9531","diff_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/9531.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/9531.patch"},"body":"Fixes #9396 \r\n\r\nThis PR fixes the UIBarButtonItem tint color on the `WebKitViewController` when `UIAccessibilityBoldText` is enabled.\r\n\r\n![img_2979](https://user-images.githubusercontent.com/9772967/41050926-543eb5f8-697a-11e8-9666-f9dc87595867.png)\r\n\r\n**Notes**:\r\n- The issue is a iOS 11 bug where the `UIBarButtonItem.appearance().tintColor` conflict with the tint color of the item instance. This was fixed by re-setting the bar tint color to override the appearance setting.\r\n- Tool bar button items also had this problem, but the color was changing to a darker one.\r\n- There was a thread error in this class. This also was addressed.\r\n- I took the opportunity for a small refactor to organize the code and remove a couple of (harmless) optionals and `!`s.\r\n\r\n@koke could you please take a look? :)\r\n\r\nTo test:\r\n - Go to the system Settings app > General > Accessibility > Bold Text and turn it on. \r\n![screen shot 2018-05-17 at 5 00 15 pm](https://user-images.githubusercontent.com/17755234/40203623-cadd53c2-59f3-11e8-8139-c86c42dd9d76.png)\r\n- Reopen the WordPress app, go to the Reader, click on any result and then click on a link to open the page in the app's internal browser. \r\n- Alternatively, go to My Sites > \"Pick any site\" > External > and tap on \"View Site\" to open the site in the app's internal browser.\r\n- Check that the navigation bar buttons and the toolbar buttons are styled as expected."},"comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/comments/395780256","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/9531#issuecomment-395780256","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/9531","id":395780256,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTc4MDI1Ng==","user":{"login":"koke","id":8739,"node_id":"MDQ6VXNlcjg3Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/8739?v=4","gravatar_id":"","url":"https://api.github.com/users/koke","html_url":"https://github.com/koke","followers_url":"https://api.github.com/users/koke/followers","following_url":"https://api.github.com/users/koke/following{/other_user}","gists_url":"https://api.github.com/users/koke/gists{/gist_id}","starred_url":"https://api.github.com/users/koke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koke/subscriptions","organizations_url":"https://api.github.com/users/koke/orgs","repos_url":"https://api.github.com/users/koke/repos","events_url":"https://api.github.com/users/koke/events{/privacy}","received_events_url":"https://api.github.com/users/koke/received_events","type":"User","site_admin":false},"created_at":"2018-06-08T14:35:00Z","updated_at":"2018-06-08T14:35:00Z","author_association":"MEMBER","body":"👍 thanks, 🚢 :shipit: 🚢 "}}
{"actor":{"display_login":"koke"}}