{"action":"created","issue":{"url":"https://api.github.com/repos/reactiveui/refit/issues/494","repository_url":"https://api.github.com/repos/reactiveui/refit","labels_url":"https://api.github.com/repos/reactiveui/refit/issues/494/labels{/name}","comments_url":"https://api.github.com/repos/reactiveui/refit/issues/494/comments","events_url":"https://api.github.com/repos/reactiveui/refit/issues/494/events","html_url":"https://github.com/reactiveui/refit/pull/494","id":328767375,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjExOTcz","number":494,"title":"Modify interface to support HttpClientFactory users","user":{"login":"thecontrarycat","id":1482576,"node_id":"MDQ6VXNlcjE0ODI1NzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1482576?v=4","gravatar_id":"","url":"https://api.github.com/users/thecontrarycat","html_url":"https://github.com/thecontrarycat","followers_url":"https://api.github.com/users/thecontrarycat/followers","following_url":"https://api.github.com/users/thecontrarycat/following{/other_user}","gists_url":"https://api.github.com/users/thecontrarycat/gists{/gist_id}","starred_url":"https://api.github.com/users/thecontrarycat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thecontrarycat/subscriptions","organizations_url":"https://api.github.com/users/thecontrarycat/orgs","repos_url":"https://api.github.com/users/thecontrarycat/repos","events_url":"https://api.github.com/users/thecontrarycat/events{/privacy}","received_events_url":"https://api.github.com/users/thecontrarycat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-06-02T18:41:07Z","updated_at":"2018-06-18T15:59:12Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/reactiveui/refit/pulls/494","html_url":"https://github.com/reactiveui/refit/pull/494","diff_url":"https://github.com/reactiveui/refit/pull/494.diff","patch_url":"https://github.com/reactiveui/refit/pull/494.patch"},"body":"PR for #491"},"comment":{"url":"https://api.github.com/repos/reactiveui/refit/issues/comments/398104991","html_url":"https://github.com/reactiveui/refit/pull/494#issuecomment-398104991","issue_url":"https://api.github.com/repos/reactiveui/refit/issues/494","id":398104991,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODEwNDk5MQ==","user":{"login":"thecontrarycat","id":1482576,"node_id":"MDQ6VXNlcjE0ODI1NzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1482576?v=4","gravatar_id":"","url":"https://api.github.com/users/thecontrarycat","html_url":"https://github.com/thecontrarycat","followers_url":"https://api.github.com/users/thecontrarycat/followers","following_url":"https://api.github.com/users/thecontrarycat/following{/other_user}","gists_url":"https://api.github.com/users/thecontrarycat/gists{/gist_id}","starred_url":"https://api.github.com/users/thecontrarycat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thecontrarycat/subscriptions","organizations_url":"https://api.github.com/users/thecontrarycat/orgs","repos_url":"https://api.github.com/users/thecontrarycat/repos","events_url":"https://api.github.com/users/thecontrarycat/events{/privacy}","received_events_url":"https://api.github.com/users/thecontrarycat/received_events","type":"User","site_admin":false},"created_at":"2018-06-18T15:59:12Z","updated_at":"2018-06-18T15:59:12Z","author_association":"NONE","body":"I think it would be complicated to do a single `IServiceCollection.AddRefit<T>()` method because we'd need to implement the whole `HttpClient` configuration part (there are additional lines you can put between the `AddHttpClient` and `AddTypedClient` methods to customise the handlers used by the client).\r\n\r\nI did start thinking that we could make `IRequestHandler` become `IRequestHandler<T>` and we could then replace the `AddTypedClient` call with an `AddRefitClient<T>` call where we could singleton register the appropriate `IRequestHandler<T>` in the same call.  \r\n\r\nRefactoring the IRequestHandler was a larger job than I wanted to do unless you think it makes sense."}}
{"actor":{"display_login":"thecontrarycat"}}