{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/cli/pulls/comments/229818433","pull_request_review_id":170409278,"id":229818433,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTgxODQzMw==","diff_hunk":"@@ -16,12 +17,19 @@ internal struct ToolManifestPackage : IEquatable<ToolManifestPackage>\n         public PackageId PackageId { get; }\n         public NuGetVersion Version { get; }\n         public ToolCommandName[] CommandNames { get; }\n+        /// <summary>\n+        /// The directory the will take affect first.\n+        /// When it is under .config directory, it is not .config directory\n+        /// it is .config's parent directory\n+        /// </summary>\n+        public DirectoryPath FirstAffectDirectory { get; }","path":"src/dotnet/ToolManifest/ToolManifestPackage.cs","position":null,"original_position":17,"commit_id":"872bae4e57fb0dfe509713b609dfcbcaa4e91733","original_commit_id":"02c1c0d0e970fb10e7c70857f9e01c02d540f2c6","user":{"login":"wli3","id":6993335,"node_id":"MDQ6VXNlcjY5OTMzMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6993335?v=4","gravatar_id":"","url":"https://api.github.com/users/wli3","html_url":"https://github.com/wli3","followers_url":"https://api.github.com/users/wli3/followers","following_url":"https://api.github.com/users/wli3/following{/other_user}","gists_url":"https://api.github.com/users/wli3/gists{/gist_id}","starred_url":"https://api.github.com/users/wli3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wli3/subscriptions","organizations_url":"https://api.github.com/users/wli3/orgs","repos_url":"https://api.github.com/users/wli3/repos","events_url":"https://api.github.com/users/wli3/events{/privacy}","received_events_url":"https://api.github.com/users/wli3/received_events","type":"User","site_admin":false},"body":"fixed, I changed all affect to effectDirectory including tuples","created_at":"2018-10-31T18:31:15Z","updated_at":"2018-10-31T18:31:15Z","html_url":"https://github.com/dotnet/cli/pull/10246#discussion_r229818433","pull_request_url":"https://api.github.com/repos/dotnet/cli/pulls/10246","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments/229818433"},"html":{"href":"https://github.com/dotnet/cli/pull/10246#discussion_r229818433"},"pull_request":{"href":"https://api.github.com/repos/dotnet/cli/pulls/10246"}},"in_reply_to_id":229801257},"pull_request":{"url":"https://api.github.com/repos/dotnet/cli/pulls/10246","id":226251908,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjUxOTA4","html_url":"https://github.com/dotnet/cli/pull/10246","diff_url":"https://github.com/dotnet/cli/pull/10246.diff","patch_url":"https://github.com/dotnet/cli/pull/10246.patch","issue_url":"https://api.github.com/repos/dotnet/cli/issues/10246","number":10246,"state":"open","locked":false,"title":"NuGet prob nuget.config should start from the directory of the manifest file","user":{"login":"wli3","id":6993335,"node_id":"MDQ6VXNlcjY5OTMzMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6993335?v=4","gravatar_id":"","url":"https://api.github.com/users/wli3","html_url":"https://github.com/wli3","followers_url":"https://api.github.com/users/wli3/followers","following_url":"https://api.github.com/users/wli3/following{/other_user}","gists_url":"https://api.github.com/users/wli3/gists{/gist_id}","starred_url":"https://api.github.com/users/wli3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wli3/subscriptions","organizations_url":"https://api.github.com/users/wli3/orgs","repos_url":"https://api.github.com/users/wli3/repos","events_url":"https://api.github.com/users/wli3/events{/privacy}","received_events_url":"https://api.github.com/users/wli3/received_events","type":"User","site_admin":false},"body":"The production change is rather small. However, nuget prob nuget config\r\nand CLI prob manifest file is quite complex problem logic and it is even\r\nworse when 2 are combined. The bug caused by it would be very nasty, as\r\nin the test’s scenario. So, I added infrastructure to simulate this situation.\r\n","created_at":"2018-10-26T23:41:47Z","updated_at":"2018-10-31T18:31:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76187e75598d85c7497cfb00a620f53c5a54db5e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":813202779,"node_id":"MDU6TGFiZWw4MTMyMDI3Nzk=","url":"https://api.github.com/repos/dotnet/cli/labels/tool","name":"tool","color":"d93f0b","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/cli/milestones/23","html_url":"https://github.com/dotnet/cli/milestone/23","labels_url":"https://api.github.com/repos/dotnet/cli/milestones/23/labels","id":3439375,"node_id":"MDk6TWlsZXN0b25lMzQzOTM3NQ==","number":23,"title":"3.0.1xx","description":"","creator":{"login":"livarcocc","id":367554,"node_id":"MDQ6VXNlcjM2NzU1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/367554?v=4","gravatar_id":"","url":"https://api.github.com/users/livarcocc","html_url":"https://github.com/livarcocc","followers_url":"https://api.github.com/users/livarcocc/followers","following_url":"https://api.github.com/users/livarcocc/following{/other_user}","gists_url":"https://api.github.com/users/livarcocc/gists{/gist_id}","starred_url":"https://api.github.com/users/livarcocc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livarcocc/subscriptions","organizations_url":"https://api.github.com/users/livarcocc/orgs","repos_url":"https://api.github.com/users/livarcocc/repos","events_url":"https://api.github.com/users/livarcocc/events{/privacy}","received_events_url":"https://api.github.com/users/livarcocc/received_events","type":"User","site_admin":false},"open_issues":119,"closed_issues":76,"state":"open","created_at":"2018-06-20T17:23:30Z","updated_at":"2018-10-31T18:13:11Z","due_on":"2019-04-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/cli/pulls/10246/commits","review_comments_url":"https://api.github.com/repos/dotnet/cli/pulls/10246/comments","review_comment_url":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/cli/issues/10246/comments","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/872bae4e57fb0dfe509713b609dfcbcaa4e91733","head":{"label":"wli3:local-tools-correct-nugetconfig-prob-and-parallel3","ref":"local-tools-correct-nugetconfig-prob-and-parallel3","sha":"872bae4e57fb0dfe509713b609dfcbcaa4e91733","user":{"login":"wli3","id":6993335,"node_id":"MDQ6VXNlcjY5OTMzMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6993335?v=4","gravatar_id":"","url":"https://api.github.com/users/wli3","html_url":"https://github.com/wli3","followers_url":"https://api.github.com/users/wli3/followers","following_url":"https://api.github.com/users/wli3/following{/other_user}","gists_url":"https://api.github.com/users/wli3/gists{/gist_id}","starred_url":"https://api.github.com/users/wli3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wli3/subscriptions","organizations_url":"https://api.github.com/users/wli3/orgs","repos_url":"https://api.github.com/users/wli3/repos","events_url":"https://api.github.com/users/wli3/events{/privacy}","received_events_url":"https://api.github.com/users/wli3/received_events","type":"User","site_admin":false},"repo":{"id":67354897,"node_id":"MDEwOlJlcG9zaXRvcnk2NzM1NDg5Nw==","name":"cli","full_name":"wli3/cli","private":false,"owner":{"login":"wli3","id":6993335,"node_id":"MDQ6VXNlcjY5OTMzMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6993335?v=4","gravatar_id":"","url":"https://api.github.com/users/wli3","html_url":"https://github.com/wli3","followers_url":"https://api.github.com/users/wli3/followers","following_url":"https://api.github.com/users/wli3/following{/other_user}","gists_url":"https://api.github.com/users/wli3/gists{/gist_id}","starred_url":"https://api.github.com/users/wli3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wli3/subscriptions","organizations_url":"https://api.github.com/users/wli3/orgs","repos_url":"https://api.github.com/users/wli3/repos","events_url":"https://api.github.com/users/wli3/events{/privacy}","received_events_url":"https://api.github.com/users/wli3/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wli3/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":true,"url":"https://api.github.com/repos/wli3/cli","forks_url":"https://api.github.com/repos/wli3/cli/forks","keys_url":"https://api.github.com/repos/wli3/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wli3/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wli3/cli/teams","hooks_url":"https://api.github.com/repos/wli3/cli/hooks","issue_events_url":"https://api.github.com/repos/wli3/cli/issues/events{/number}","events_url":"https://api.github.com/repos/wli3/cli/events","assignees_url":"https://api.github.com/repos/wli3/cli/assignees{/user}","branches_url":"https://api.github.com/repos/wli3/cli/branches{/branch}","tags_url":"https://api.github.com/repos/wli3/cli/tags","blobs_url":"https://api.github.com/repos/wli3/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wli3/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wli3/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/wli3/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wli3/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/wli3/cli/languages","stargazers_url":"https://api.github.com/repos/wli3/cli/stargazers","contributors_url":"https://api.github.com/repos/wli3/cli/contributors","subscribers_url":"https://api.github.com/repos/wli3/cli/subscribers","subscription_url":"https://api.github.com/repos/wli3/cli/subscription","commits_url":"https://api.github.com/repos/wli3/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/wli3/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/wli3/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/wli3/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/wli3/cli/contents/{+path}","compare_url":"https://api.github.com/repos/wli3/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wli3/cli/merges","archive_url":"https://api.github.com/repos/wli3/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wli3/cli/downloads","issues_url":"https://api.github.com/repos/wli3/cli/issues{/number}","pulls_url":"https://api.github.com/repos/wli3/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/wli3/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/wli3/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wli3/cli/labels{/name}","releases_url":"https://api.github.com/repos/wli3/cli/releases{/id}","deployments_url":"https://api.github.com/repos/wli3/cli/deployments","created_at":"2016-09-04T16:06:24Z","updated_at":"2016-09-04T16:06:28Z","pushed_at":"2018-10-31T18:28:05Z","git_url":"git://github.com/wli3/cli.git","ssh_url":"git@github.com:wli3/cli.git","clone_url":"https://github.com/wli3/cli.git","svn_url":"https://github.com/wli3/cli","homepage":"https://docs.microsoft.com/dotnet/ ","size":44684,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"rel/1.0.0"}},"base":{"label":"dotnet:master","ref":"master","sha":"0bc24bff775e22352c2309ef990281280f92dbaa","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":43568107,"node_id":"MDEwOlJlcG9zaXRvcnk0MzU2ODEwNw==","name":"cli","full_name":"dotnet/cli","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":false,"url":"https://api.github.com/repos/dotnet/cli","forks_url":"https://api.github.com/repos/dotnet/cli/forks","keys_url":"https://api.github.com/repos/dotnet/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/cli/teams","hooks_url":"https://api.github.com/repos/dotnet/cli/hooks","issue_events_url":"https://api.github.com/repos/dotnet/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/cli/events","assignees_url":"https://api.github.com/repos/dotnet/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/cli/tags","blobs_url":"https://api.github.com/repos/dotnet/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/cli/languages","stargazers_url":"https://api.github.com/repos/dotnet/cli/stargazers","contributors_url":"https://api.github.com/repos/dotnet/cli/contributors","subscribers_url":"https://api.github.com/repos/dotnet/cli/subscribers","subscription_url":"https://api.github.com/repos/dotnet/cli/subscription","commits_url":"https://api.github.com/repos/dotnet/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/cli/merges","archive_url":"https://api.github.com/repos/dotnet/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/cli/downloads","issues_url":"https://api.github.com/repos/dotnet/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/cli/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/cli/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/cli/deployments","created_at":"2015-10-02T18:03:15Z","updated_at":"2018-10-31T15:22:40Z","pushed_at":"2018-10-31T18:28:08Z","git_url":"git://github.com/dotnet/cli.git","ssh_url":"git@github.com:dotnet/cli.git","clone_url":"https://github.com/dotnet/cli.git","svn_url":"https://github.com/dotnet/cli","homepage":"https://github.com/dotnet/core","size":43286,"stargazers_count":2943,"watchers_count":2943,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":935,"mirror_url":null,"archived":false,"open_issues_count":489,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":935,"open_issues":489,"watchers":2943,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/10246"},"html":{"href":"https://github.com/dotnet/cli/pull/10246"},"issue":{"href":"https://api.github.com/repos/dotnet/cli/issues/10246"},"comments":{"href":"https://api.github.com/repos/dotnet/cli/issues/10246/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/cli/pulls/10246/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/cli/pulls/10246/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/cli/statuses/872bae4e57fb0dfe509713b609dfcbcaa4e91733"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"wli3"}}