{"action":"created","comment":{"url":"https://api.github.com/repos/discordia-space/CEV-Eris/pulls/comments/220971556","pull_request_review_id":159507669,"id":220971556,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDk3MTU1Ng==","diff_hunk":"@@ -35,52 +39,217 @@ var/list/flooring_types\n \tvar/build_time = 0  // BYOND ticks.\n \n \tvar/descriptor = \"tiles\"\n-\tvar/flags\n+\tvar/flags = TURF_CAN_BURN | TURF_CAN_BREAK\n \tvar/can_paint\n \n+\tvar/is_plating = FALSE\n+\n+\t//Plating types, can be overridden\n+\tvar/plating_type = /decl/flooring/reinforced/plating\n+\n+\t//Resistance is subtracted from all incoming damage\n+\tvar/resistance = 3\n+\n+\t//Damage the floor can take before being destroyed\n+\tvar/health = 50\n+\n+\tvar/removal_time = WORKTIME_FAST * 0.75\n+\n+\n+//Flooring Procs\n+/decl/flooring/proc/get_plating_type(var/turf/location)\n+\treturn plating_type\n+\n+\n+//Used to check if we can build the specified type of floor ontop of this one\n+/decl/flooring/proc/can_build_floor(var/decl/flooring/newfloor)\n+\treturn FALSE\n+\n+\n+//Used when someone attacks the floor\n+/decl/flooring/proc/attackby(var/obj/item/I, var/mob/user, var/turf/T)\n+\treturn FALSE\n+\n+\n+/decl/flooring/proc/Entered(mob/living/M as mob)\n+\treturn\n+\n+\n /decl/flooring/grass\n \tname = \"grass\"\n \tdesc = \"Do they smoke grass out in space, Bowie? Or do they smoke AstroTurf?\"\n \ticon = 'icons/turf/flooring/grass.dmi'\n \ticon_base = \"grass\"\n \thas_base_range = 3\n \tdamage_temperature = T0C+80\n-\tflags = TURF_REMOVE_SHOVEL\n+\tflags = TURF_REMOVE_SHOVEL | SMOOTH_ONLY_WITH_ITSELF | TURF_HAS_EDGES | TURF_EDGES_EXTERNAL\n \tbuild_type = /obj/item/stack/tile/grass\n+\tplating_type = /decl/flooring/dirt\n+\tfootstep_sound = \"grass\"\n+\n+/decl/flooring/dirt\n+\tname = \"dirt\"\n+\tdesc = \"Do they smoke grass out in space, Bowie? Or do they smoke AstroTurf?\"\n+\ticon = 'icons/turf/flooring/dirt.dmi'\n+\ticon_base = \"dirt\"\n+\tflags = TURF_REMOVE_SHOVEL | SMOOTH_ONLY_WITH_ITSELF\n+\tbuild_type = null //Todo: add bags of fertilised soil or something to create dirt floors\n+\tfootstep_sound = \"gravel\"\n \n /decl/flooring/asteroid\n \tname = \"coarse sand\"\n \tdesc = \"Gritty and unpleasant.\"\n \ticon = 'icons/turf/flooring/asteroid.dmi'\n \ticon_base = \"asteroid\"\n-\tflags = TURF_HAS_EDGES | TURF_REMOVE_SHOVEL\n+\tflags = TURF_HAS_EDGES | TURF_REMOVE_SHOVEL | TURF_CAN_BURN | TURF_CAN_BREAK","path":"code/game/turfs/flooring/flooring.dm","position":80,"original_position":80,"commit_id":"a30b1d0428b33162c54dcf367087d694f2213789","original_commit_id":"a30b1d0428b33162c54dcf367087d694f2213789","user":{"login":"NanakoAC","id":18094775,"node_id":"MDQ6VXNlcjE4MDk0Nzc1","avatar_url":"https://avatars1.githubusercontent.com/u/18094775?v=4","gravatar_id":"","url":"https://api.github.com/users/NanakoAC","html_url":"https://github.com/NanakoAC","followers_url":"https://api.github.com/users/NanakoAC/followers","following_url":"https://api.github.com/users/NanakoAC/following{/other_user}","gists_url":"https://api.github.com/users/NanakoAC/gists{/gist_id}","starred_url":"https://api.github.com/users/NanakoAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanakoAC/subscriptions","organizations_url":"https://api.github.com/users/NanakoAC/orgs","repos_url":"https://api.github.com/users/NanakoAC/repos","events_url":"https://api.github.com/users/NanakoAC/events{/privacy}","received_events_url":"https://api.github.com/users/NanakoAC/received_events","type":"User","site_admin":false},"body":"Burn and break flags are applied a lot more extensively. They simply mean that the turf can recieve those overlays, not necessarily that it's flammable","created_at":"2018-09-27T15:31:13Z","updated_at":"2018-09-27T15:31:13Z","html_url":"https://github.com/discordia-space/CEV-Eris/pull/2030#discussion_r220971556","pull_request_url":"https://api.github.com/repos/discordia-space/CEV-Eris/pulls/2030","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/discordia-space/CEV-Eris/pulls/comments/220971556"},"html":{"href":"https://github.com/discordia-space/CEV-Eris/pull/2030#discussion_r220971556"},"pull_request":{"href":"https://api.github.com/repos/discordia-space/CEV-Eris/pulls/2030"}}},"pull_request":{"url":"https://api.github.com/repos/discordia-space/CEV-Eris/pulls/2030","id":218693130,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NjkzMTMw","html_url":"https://github.com/discordia-space/CEV-Eris/pull/2030","diff_url":"https://github.com/discordia-space/CEV-Eris/pull/2030.diff","patch_url":"https://github.com/discordia-space/CEV-Eris/pull/2030.patch","issue_url":"https://api.github.com/repos/discordia-space/CEV-Eris/issues/2030","number":2030,"state":"open","locked":false,"title":"Earth Below Us","user":{"login":"NanakoAC","id":18094775,"node_id":"MDQ6VXNlcjE4MDk0Nzc1","avatar_url":"https://avatars1.githubusercontent.com/u/18094775?v=4","gravatar_id":"","url":"https://api.github.com/users/NanakoAC","html_url":"https://github.com/NanakoAC","followers_url":"https://api.github.com/users/NanakoAC/followers","following_url":"https://api.github.com/users/NanakoAC/following{/other_user}","gists_url":"https://api.github.com/users/NanakoAC/gists{/gist_id}","starred_url":"https://api.github.com/users/NanakoAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanakoAC/subscriptions","organizations_url":"https://api.github.com/users/NanakoAC/orgs","repos_url":"https://api.github.com/users/NanakoAC/repos","events_url":"https://api.github.com/users/NanakoAC/events{/privacy}","received_events_url":"https://api.github.com/users/NanakoAC/received_events","type":"User","site_admin":false},"body":"The first and probably largest part of the much anticipated Floor Rework\r\n\r\nThis PR is largely concerned with the guts and internal plumbing of floors. Fixing lots of bugs, making mechanics work correctly\r\n\r\nHere's a shortlist of changes:\r\n\r\n1. Floors are now multilayered. Inter-storey floors have three layers - tiles, plating, and underplating. \r\nFloors which are on the bottom or top of the ship have one additional layer, hull plating\r\n\r\n2. Damaging floors now goes through each layer in sequence, exhausting its health fully before moving to the next. Every type of floor also has a resistance value, subtracting a flat amount from incoming damage\r\n\r\n3. Every floor has a flooring. Special behaviour in the /turf/simulated/floor atom itselfis not allowed anymore. All special behaviour belongs to the /decl/flooring assigned to it. The only purpose of floor definitions is to allow floorings to be placed in the map editor\r\n\r\n4. Footstep sounds are moved to the flooring too. And some new footstep sounds for grass and dirt were ported from aurora\r\n\r\n5. Grass is reworked, it now has external borders which protrude into neighboring tiles, it looks great\r\n\r\n6. Floor layers can now be constructed and deconstructed properly.\r\nBuild a lattice with rods, add steel sheets to make underplating, and more steel sheets to make normal plating. Plasteel sheets are used to make hull\r\nTo deconstruct, a welder cuts plating, a wrench disassembles underplating, and a welder again cuts through hull. these three have very long deconstruction times\r\n\r\n7. Fixes a bunch of bugs, lets see, uh...\r\nfixes #2007 \r\nfixes #318 \r\nfixes #1882 \r\nfixes #1890 \r\n\r\n8. You can now hit floors with stuff. Just use harm intent. Overrides every other interaction, so you can use tools to attack the floor. Switch out of harm intent to perform tool actions and other interactions\r\n\r\nKnown issues:\r\nAll the ones in this milestone which aren't mentioned above\r\nhttps://github.com/discordia-space/CEV-Eris/milestone/17","created_at":"2018-09-27T15:20:33Z","updated_at":"2018-09-27T15:31:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1779d08429327349c785f12e2fc0faced833b3a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/discordia-space/CEV-Eris/pulls/2030/commits","review_comments_url":"https://api.github.com/repos/discordia-space/CEV-Eris/pulls/2030/comments","review_comment_url":"https://api.github.com/repos/discordia-space/CEV-Eris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/discordia-space/CEV-Eris/issues/2030/comments","statuses_url":"https://api.github.com/repos/discordia-space/CEV-Eris/statuses/a30b1d0428b33162c54dcf367087d694f2213789","head":{"label":"discordia-space:FloorRefactor","ref":"FloorRefactor","sha":"a30b1d0428b33162c54dcf367087d694f2213789","user":{"login":"discordia-space","id":17249734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjQ5NzM0","avatar_url":"https://avatars2.githubusercontent.com/u/17249734?v=4","gravatar_id":"","url":"https://api.github.com/users/discordia-space","html_url":"https://github.com/discordia-space","followers_url":"https://api.github.com/users/discordia-space/followers","following_url":"https://api.github.com/users/discordia-space/following{/other_user}","gists_url":"https://api.github.com/users/discordia-space/gists{/gist_id}","starred_url":"https://api.github.com/users/discordia-space/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discordia-space/subscriptions","organizations_url":"https://api.github.com/users/discordia-space/orgs","repos_url":"https://api.github.com/users/discordia-space/repos","events_url":"https://api.github.com/users/discordia-space/events{/privacy}","received_events_url":"https://api.github.com/users/discordia-space/received_events","type":"Organization","site_admin":false},"repo":{"id":51751615,"node_id":"MDEwOlJlcG9zaXRvcnk1MTc1MTYxNQ==","name":"CEV-Eris","full_name":"discordia-space/CEV-Eris","private":false,"owner":{"login":"discordia-space","id":17249734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjQ5NzM0","avatar_url":"https://avatars2.githubusercontent.com/u/17249734?v=4","gravatar_id":"","url":"https://api.github.com/users/discordia-space","html_url":"https://github.com/discordia-space","followers_url":"https://api.github.com/users/discordia-space/followers","following_url":"https://api.github.com/users/discordia-space/following{/other_user}","gists_url":"https://api.github.com/users/discordia-space/gists{/gist_id}","starred_url":"https://api.github.com/users/discordia-space/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discordia-space/subscriptions","organizations_url":"https://api.github.com/users/discordia-space/orgs","repos_url":"https://api.github.com/users/discordia-space/repos","events_url":"https://api.github.com/users/discordia-space/events{/privacy}","received_events_url":"https://api.github.com/users/discordia-space/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/discordia-space/CEV-Eris","description":"Death is our destination","fork":false,"url":"https://api.github.com/repos/discordia-space/CEV-Eris","forks_url":"https://api.github.com/repos/discordia-space/CEV-Eris/forks","keys_url":"https://api.github.com/repos/discordia-space/CEV-Eris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/discordia-space/CEV-Eris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/discordia-space/CEV-Eris/teams","hooks_url":"https://api.github.com/repos/discordia-space/CEV-Eris/hooks","issue_events_url":"https://api.github.com/repos/discordia-space/CEV-Eris/issues/events{/number}","events_url":"https://api.github.com/repos/discordia-space/CEV-Eris/events","assignees_url":"https://api.github.com/repos/discordia-space/CEV-Eris/assignees{/user}","branches_url":"https://api.github.com/repos/discordia-space/CEV-Eris/branches{/branch}","tags_url":"https://api.github.com/repos/discordia-space/CEV-Eris/tags","blobs_url":"https://api.github.com/repos/discordia-space/CEV-Eris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/discordia-space/CEV-Eris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/discordia-space/CEV-Eris/git/refs{/sha}","trees_url":"https://api.github.com/repos/discordia-space/CEV-Eris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/discordia-space/CEV-Eris/statuses/{sha}","languages_url":"https://api.github.com/repos/discordia-space/CEV-Eris/languages","stargazers_url":"https://api.github.com/repos/discordia-space/CEV-Eris/stargazers","contributors_url":"https://api.github.com/repos/discordia-space/CEV-Eris/contributors","subscribers_url":"https://api.github.com/repos/discordia-space/CEV-Eris/subscribers","subscription_url":"https://api.github.com/repos/discordia-space/CEV-Eris/subscription","commits_url":"https://api.github.com/repos/discordia-space/CEV-Eris/commits{/sha}","git_commits_url":"https://api.github.com/repos/discordia-space/CEV-Eris/git/commits{/sha}","comments_url":"https://api.github.com/repos/discordia-space/CEV-Eris/comments{/number}","issue_comment_url":"https://api.github.com/repos/discordia-space/CEV-Eris/issues/comments{/number}","contents_url":"https://api.github.com/repos/discordia-space/CEV-Eris/contents/{+path}","compare_url":"https://api.github.com/repos/discordia-space/CEV-Eris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/discordia-space/CEV-Eris/merges","archive_url":"https://api.github.com/repos/discordia-space/CEV-Eris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/discordia-space/CEV-Eris/downloads","issues_url":"https://api.github.com/repos/discordia-space/CEV-Eris/issues{/number}","pulls_url":"https://api.github.com/repos/discordia-space/CEV-Eris/pulls{/number}","milestones_url":"https://api.github.com/repos/discordia-space/CEV-Eris/milestones{/number}","notifications_url":"https://api.github.com/repos/discordia-space/CEV-Eris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/discordia-space/CEV-Eris/labels{/name}","releases_url":"https://api.github.com/repos/discordia-space/CEV-Eris/releases{/id}","deployments_url":"https://api.github.com/repos/discordia-space/CEV-Eris/deployments","created_at":"2016-02-15T11:38:52Z","updated_at":"2018-09-27T12:31:31Z","pushed_at":"2018-09-27T15:20:33Z","git_url":"git://github.com/discordia-space/CEV-Eris.git","ssh_url":"git@github.com:discordia-space/CEV-Eris.git","clone_url":"https://github.com/discordia-space/CEV-Eris.git","svn_url":"https://github.com/discordia-space/CEV-Eris","homepage":"https://discord.gg/QfEg7K7","size":288898,"stargazers_count":33,"watchers_count":33,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":289,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":83,"open_issues":289,"watchers":33,"default_branch":"master"}},"base":{"label":"discordia-space:master","ref":"master","sha":"4514622a568c78656cf95f8062b76fb3f124abe3","user":{"login":"discordia-space","id":17249734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjQ5NzM0","avatar_url":"https://avatars2.githubusercontent.com/u/17249734?v=4","gravatar_id":"","url":"https://api.github.com/users/discordia-space","html_url":"https://github.com/discordia-space","followers_url":"https://api.github.com/users/discordia-space/followers","following_url":"https://api.github.com/users/discordia-space/following{/other_user}","gists_url":"https://api.github.com/users/discordia-space/gists{/gist_id}","starred_url":"https://api.github.com/users/discordia-space/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discordia-space/subscriptions","organizations_url":"https://api.github.com/users/discordia-space/orgs","repos_url":"https://api.github.com/users/discordia-space/repos","events_url":"https://api.github.com/users/discordia-space/events{/privacy}","received_events_url":"https://api.github.com/users/discordia-space/received_events","type":"Organization","site_admin":false},"repo":{"id":51751615,"node_id":"MDEwOlJlcG9zaXRvcnk1MTc1MTYxNQ==","name":"CEV-Eris","full_name":"discordia-space/CEV-Eris","private":false,"owner":{"login":"discordia-space","id":17249734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjQ5NzM0","avatar_url":"https://avatars2.githubusercontent.com/u/17249734?v=4","gravatar_id":"","url":"https://api.github.com/users/discordia-space","html_url":"https://github.com/discordia-space","followers_url":"https://api.github.com/users/discordia-space/followers","following_url":"https://api.github.com/users/discordia-space/following{/other_user}","gists_url":"https://api.github.com/users/discordia-space/gists{/gist_id}","starred_url":"https://api.github.com/users/discordia-space/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discordia-space/subscriptions","organizations_url":"https://api.github.com/users/discordia-space/orgs","repos_url":"https://api.github.com/users/discordia-space/repos","events_url":"https://api.github.com/users/discordia-space/events{/privacy}","received_events_url":"https://api.github.com/users/discordia-space/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/discordia-space/CEV-Eris","description":"Death is our destination","fork":false,"url":"https://api.github.com/repos/discordia-space/CEV-Eris","forks_url":"https://api.github.com/repos/discordia-space/CEV-Eris/forks","keys_url":"https://api.github.com/repos/discordia-space/CEV-Eris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/discordia-space/CEV-Eris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/discordia-space/CEV-Eris/teams","hooks_url":"https://api.github.com/repos/discordia-space/CEV-Eris/hooks","issue_events_url":"https://api.github.com/repos/discordia-space/CEV-Eris/issues/events{/number}","events_url":"https://api.github.com/repos/discordia-space/CEV-Eris/events","assignees_url":"https://api.github.com/repos/discordia-space/CEV-Eris/assignees{/user}","branches_url":"https://api.github.com/repos/discordia-space/CEV-Eris/branches{/branch}","tags_url":"https://api.github.com/repos/discordia-space/CEV-Eris/tags","blobs_url":"https://api.github.com/repos/discordia-space/CEV-Eris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/discordia-space/CEV-Eris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/discordia-space/CEV-Eris/git/refs{/sha}","trees_url":"https://api.github.com/repos/discordia-space/CEV-Eris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/discordia-space/CEV-Eris/statuses/{sha}","languages_url":"https://api.github.com/repos/discordia-space/CEV-Eris/languages","stargazers_url":"https://api.github.com/repos/discordia-space/CEV-Eris/stargazers","contributors_url":"https://api.github.com/repos/discordia-space/CEV-Eris/contributors","subscribers_url":"https://api.github.com/repos/discordia-space/CEV-Eris/subscribers","subscription_url":"https://api.github.com/repos/discordia-space/CEV-Eris/subscription","commits_url":"https://api.github.com/repos/discordia-space/CEV-Eris/commits{/sha}","git_commits_url":"https://api.github.com/repos/discordia-space/CEV-Eris/git/commits{/sha}","comments_url":"https://api.github.com/repos/discordia-space/CEV-Eris/comments{/number}","issue_comment_url":"https://api.github.com/repos/discordia-space/CEV-Eris/issues/comments{/number}","contents_url":"https://api.github.com/repos/discordia-space/CEV-Eris/contents/{+path}","compare_url":"https://api.github.com/repos/discordia-space/CEV-Eris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/discordia-space/CEV-Eris/merges","archive_url":"https://api.github.com/repos/discordia-space/CEV-Eris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/discordia-space/CEV-Eris/downloads","issues_url":"https://api.github.com/repos/discordia-space/CEV-Eris/issues{/number}","pulls_url":"https://api.github.com/repos/discordia-space/CEV-Eris/pulls{/number}","milestones_url":"https://api.github.com/repos/discordia-space/CEV-Eris/milestones{/number}","notifications_url":"https://api.github.com/repos/discordia-space/CEV-Eris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/discordia-space/CEV-Eris/labels{/name}","releases_url":"https://api.github.com/repos/discordia-space/CEV-Eris/releases{/id}","deployments_url":"https://api.github.com/repos/discordia-space/CEV-Eris/deployments","created_at":"2016-02-15T11:38:52Z","updated_at":"2018-09-27T12:31:31Z","pushed_at":"2018-09-27T15:20:33Z","git_url":"git://github.com/discordia-space/CEV-Eris.git","ssh_url":"git@github.com:discordia-space/CEV-Eris.git","clone_url":"https://github.com/discordia-space/CEV-Eris.git","svn_url":"https://github.com/discordia-space/CEV-Eris","homepage":"https://discord.gg/QfEg7K7","size":288898,"stargazers_count":33,"watchers_count":33,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":289,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":83,"open_issues":289,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/discordia-space/CEV-Eris/pulls/2030"},"html":{"href":"https://github.com/discordia-space/CEV-Eris/pull/2030"},"issue":{"href":"https://api.github.com/repos/discordia-space/CEV-Eris/issues/2030"},"comments":{"href":"https://api.github.com/repos/discordia-space/CEV-Eris/issues/2030/comments"},"review_comments":{"href":"https://api.github.com/repos/discordia-space/CEV-Eris/pulls/2030/comments"},"review_comment":{"href":"https://api.github.com/repos/discordia-space/CEV-Eris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/discordia-space/CEV-Eris/pulls/2030/commits"},"statuses":{"href":"https://api.github.com/repos/discordia-space/CEV-Eris/statuses/a30b1d0428b33162c54dcf367087d694f2213789"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"NanakoAC"}}