{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/220733039","pull_request_review_id":159210633,"id":220733039,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDczMzAzOQ==","diff_hunk":"@@ -2701,6 +2701,11 @@ ConstraintSystem::SolutionKind ConstraintSystem::simplifyConformsToConstraint(\n     return result;\n   }\n \n+  // Let's not try to fix missing conformance for Void\n+  // and Never because that doesn't really make sense.\n+  if (type->isVoid() || type->isUninhabited())","path":"lib/Sema/CSSimplify.cpp","position":6,"original_position":6,"commit_id":"c25515b6a8f1249c8b7f2a6d3c127c4bfaf42137","original_commit_id":"c25515b6a8f1249c8b7f2a6d3c127c4bfaf42137","user":{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"`Never` can totally conform to things. See [SE-0215](https://github.com/apple/swift-evolution/blob/master/proposals/0215-conform-never-to-hashable-and-equatable.md).","created_at":"2018-09-26T21:42:34Z","updated_at":"2018-09-26T21:42:34Z","html_url":"https://github.com/apple/swift/pull/19566#discussion_r220733039","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/19566","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/220733039"},"html":{"href":"https://github.com/apple/swift/pull/19566#discussion_r220733039"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/19566"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/19566","id":218415359,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDE1MzU5","html_url":"https://github.com/apple/swift/pull/19566","diff_url":"https://github.com/apple/swift/pull/19566.diff","patch_url":"https://github.com/apple/swift/pull/19566.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/19566","number":19566,"state":"closed","locked":false,"title":"[CSDiagnostics] Don't try to fix conformances for `Void` and `Never`","user":{"login":"xedin","id":21240,"node_id":"MDQ6VXNlcjIxMjQw","avatar_url":"https://avatars1.githubusercontent.com/u/21240?v=4","gravatar_id":"","url":"https://api.github.com/users/xedin","html_url":"https://github.com/xedin","followers_url":"https://api.github.com/users/xedin/followers","following_url":"https://api.github.com/users/xedin/following{/other_user}","gists_url":"https://api.github.com/users/xedin/gists{/gist_id}","starred_url":"https://api.github.com/users/xedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xedin/subscriptions","organizations_url":"https://api.github.com/users/xedin/orgs","repos_url":"https://api.github.com/users/xedin/repos","events_url":"https://api.github.com/users/xedin/events{/privacy}","received_events_url":"https://api.github.com/users/xedin/received_events","type":"User","site_admin":false},"body":"There are cases when adding missing conformance fix doesn't really\r\nmake sense like in case of `Void` and `Never` types because that\r\nwouldn't result in a useful diagnostic.\r\n\r\nThis is a follow-up for rdar://problem/44770297\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->\r\n","created_at":"2018-09-26T18:40:03Z","updated_at":"2018-09-26T21:42:34Z","closed_at":"2018-09-26T20:02:36Z","merged_at":"2018-09-26T20:02:36Z","merge_commit_sha":"c9f1312bb5b177c30fa40dea62bc4d800ade67c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/19566/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/19566/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/19566/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/c25515b6a8f1249c8b7f2a6d3c127c4bfaf42137","head":{"label":"xedin:rdar-44770297-diag-followup","ref":"rdar-44770297-diag-followup","sha":"c25515b6a8f1249c8b7f2a6d3c127c4bfaf42137","user":{"login":"xedin","id":21240,"node_id":"MDQ6VXNlcjIxMjQw","avatar_url":"https://avatars1.githubusercontent.com/u/21240?v=4","gravatar_id":"","url":"https://api.github.com/users/xedin","html_url":"https://github.com/xedin","followers_url":"https://api.github.com/users/xedin/followers","following_url":"https://api.github.com/users/xedin/following{/other_user}","gists_url":"https://api.github.com/users/xedin/gists{/gist_id}","starred_url":"https://api.github.com/users/xedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xedin/subscriptions","organizations_url":"https://api.github.com/users/xedin/orgs","repos_url":"https://api.github.com/users/xedin/repos","events_url":"https://api.github.com/users/xedin/events{/privacy}","received_events_url":"https://api.github.com/users/xedin/received_events","type":"User","site_admin":false},"repo":{"id":66491687,"node_id":"MDEwOlJlcG9zaXRvcnk2NjQ5MTY4Nw==","name":"swift","full_name":"xedin/swift","private":false,"owner":{"login":"xedin","id":21240,"node_id":"MDQ6VXNlcjIxMjQw","avatar_url":"https://avatars1.githubusercontent.com/u/21240?v=4","gravatar_id":"","url":"https://api.github.com/users/xedin","html_url":"https://github.com/xedin","followers_url":"https://api.github.com/users/xedin/followers","following_url":"https://api.github.com/users/xedin/following{/other_user}","gists_url":"https://api.github.com/users/xedin/gists{/gist_id}","starred_url":"https://api.github.com/users/xedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xedin/subscriptions","organizations_url":"https://api.github.com/users/xedin/orgs","repos_url":"https://api.github.com/users/xedin/repos","events_url":"https://api.github.com/users/xedin/events{/privacy}","received_events_url":"https://api.github.com/users/xedin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xedin/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/xedin/swift","forks_url":"https://api.github.com/repos/xedin/swift/forks","keys_url":"https://api.github.com/repos/xedin/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xedin/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xedin/swift/teams","hooks_url":"https://api.github.com/repos/xedin/swift/hooks","issue_events_url":"https://api.github.com/repos/xedin/swift/issues/events{/number}","events_url":"https://api.github.com/repos/xedin/swift/events","assignees_url":"https://api.github.com/repos/xedin/swift/assignees{/user}","branches_url":"https://api.github.com/repos/xedin/swift/branches{/branch}","tags_url":"https://api.github.com/repos/xedin/swift/tags","blobs_url":"https://api.github.com/repos/xedin/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xedin/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xedin/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/xedin/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xedin/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/xedin/swift/languages","stargazers_url":"https://api.github.com/repos/xedin/swift/stargazers","contributors_url":"https://api.github.com/repos/xedin/swift/contributors","subscribers_url":"https://api.github.com/repos/xedin/swift/subscribers","subscription_url":"https://api.github.com/repos/xedin/swift/subscription","commits_url":"https://api.github.com/repos/xedin/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/xedin/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/xedin/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/xedin/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/xedin/swift/contents/{+path}","compare_url":"https://api.github.com/repos/xedin/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xedin/swift/merges","archive_url":"https://api.github.com/repos/xedin/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xedin/swift/downloads","issues_url":"https://api.github.com/repos/xedin/swift/issues{/number}","pulls_url":"https://api.github.com/repos/xedin/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/xedin/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/xedin/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xedin/swift/labels{/name}","releases_url":"https://api.github.com/repos/xedin/swift/releases{/id}","deployments_url":"https://api.github.com/repos/xedin/swift/deployments","created_at":"2016-08-24T19:04:17Z","updated_at":"2016-08-24T19:04:41Z","pushed_at":"2018-09-26T18:39:12Z","git_url":"git://github.com/xedin/swift.git","ssh_url":"git@github.com:xedin/swift.git","clone_url":"https://github.com/xedin/swift.git","svn_url":"https://github.com/xedin/swift","homepage":"https://swift.org/","size":327476,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"de697dcae17a773b4dc3721ba450126e404b09c5","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-09-26T20:27:46Z","pushed_at":"2018-09-26T21:42:03Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":344098,"stargazers_count":45309,"watchers_count":45309,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7164,"mirror_url":null,"archived":false,"open_issues_count":387,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7164,"open_issues":387,"watchers":45309,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/19566"},"html":{"href":"https://github.com/apple/swift/pull/19566"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/19566"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/19566/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/19566/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/19566/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/c25515b6a8f1249c8b7f2a6d3c127c4bfaf42137"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jrose-apple"}}