{"action":"opened","number":293,"pull_request":{"url":"https://api.github.com/repos/sobolevn/git-secret/pulls/293","id":241445432,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDQ1NDMy","html_url":"https://github.com/sobolevn/git-secret/pull/293","diff_url":"https://github.com/sobolevn/git-secret/pull/293.diff","patch_url":"https://github.com/sobolevn/git-secret/pull/293.patch","issue_url":"https://api.github.com/repos/sobolevn/git-secret/issues/293","number":293,"state":"open","locked":false,"title":"tests and comments about 'changes' for #291","user":{"login":"joshrabinowitz","id":699993,"node_id":"MDQ6VXNlcjY5OTk5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/699993?v=4","gravatar_id":"","url":"https://api.github.com/users/joshrabinowitz","html_url":"https://github.com/joshrabinowitz","followers_url":"https://api.github.com/users/joshrabinowitz/followers","following_url":"https://api.github.com/users/joshrabinowitz/following{/other_user}","gists_url":"https://api.github.com/users/joshrabinowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/joshrabinowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshrabinowitz/subscriptions","organizations_url":"https://api.github.com/users/joshrabinowitz/orgs","repos_url":"https://api.github.com/users/joshrabinowitz/repos","events_url":"https://api.github.com/users/joshrabinowitz/events{/privacy}","received_events_url":"https://api.github.com/users/joshrabinowitz/received_events","type":"User","site_admin":false},"body":"@sobolevn @brandoncssanders  I think issue #291 & PR #292 might not be relevant for git-secret master.\r\n\r\nI cannot reproduce #291 in my tests with git-secret master, (see the test \"run 'changes' with no file changed\"  in tests/test_changes.bats )\r\n\r\nAlso I did some experimenting with #292 and master and I'm not sure it improves things.\r\n(See new comments in src/commands/git_secret_changes.sh]\r\n\r\nAm I missing something? Is there an issue with git-secret changes in master?\r\n","created_at":"2018-12-29T13:03:36Z","updated_at":"2018-12-29T13:03:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sobolevn/git-secret/pulls/293/commits","review_comments_url":"https://api.github.com/repos/sobolevn/git-secret/pulls/293/comments","review_comment_url":"https://api.github.com/repos/sobolevn/git-secret/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sobolevn/git-secret/issues/293/comments","statuses_url":"https://api.github.com/repos/sobolevn/git-secret/statuses/6995c03d4622fd557fa6570f4e2d6228ccca0ff9","head":{"label":"joshrabinowitz:test-for-changes","ref":"test-for-changes","sha":"6995c03d4622fd557fa6570f4e2d6228ccca0ff9","user":{"login":"joshrabinowitz","id":699993,"node_id":"MDQ6VXNlcjY5OTk5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/699993?v=4","gravatar_id":"","url":"https://api.github.com/users/joshrabinowitz","html_url":"https://github.com/joshrabinowitz","followers_url":"https://api.github.com/users/joshrabinowitz/followers","following_url":"https://api.github.com/users/joshrabinowitz/following{/other_user}","gists_url":"https://api.github.com/users/joshrabinowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/joshrabinowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshrabinowitz/subscriptions","organizations_url":"https://api.github.com/users/joshrabinowitz/orgs","repos_url":"https://api.github.com/users/joshrabinowitz/repos","events_url":"https://api.github.com/users/joshrabinowitz/events{/privacy}","received_events_url":"https://api.github.com/users/joshrabinowitz/received_events","type":"User","site_admin":false},"repo":{"id":132931581,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI5MzE1ODE=","name":"git-secret","full_name":"joshrabinowitz/git-secret","private":false,"owner":{"login":"joshrabinowitz","id":699993,"node_id":"MDQ6VXNlcjY5OTk5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/699993?v=4","gravatar_id":"","url":"https://api.github.com/users/joshrabinowitz","html_url":"https://github.com/joshrabinowitz","followers_url":"https://api.github.com/users/joshrabinowitz/followers","following_url":"https://api.github.com/users/joshrabinowitz/following{/other_user}","gists_url":"https://api.github.com/users/joshrabinowitz/gists{/gist_id}","starred_url":"https://api.github.com/users/joshrabinowitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshrabinowitz/subscriptions","organizations_url":"https://api.github.com/users/joshrabinowitz/orgs","repos_url":"https://api.github.com/users/joshrabinowitz/repos","events_url":"https://api.github.com/users/joshrabinowitz/events{/privacy}","received_events_url":"https://api.github.com/users/joshrabinowitz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joshrabinowitz/git-secret","description":":busts_in_silhouette: A bash-tool to store your private data inside a git repository.","fork":true,"url":"https://api.github.com/repos/joshrabinowitz/git-secret","forks_url":"https://api.github.com/repos/joshrabinowitz/git-secret/forks","keys_url":"https://api.github.com/repos/joshrabinowitz/git-secret/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshrabinowitz/git-secret/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshrabinowitz/git-secret/teams","hooks_url":"https://api.github.com/repos/joshrabinowitz/git-secret/hooks","issue_events_url":"https://api.github.com/repos/joshrabinowitz/git-secret/issues/events{/number}","events_url":"https://api.github.com/repos/joshrabinowitz/git-secret/events","assignees_url":"https://api.github.com/repos/joshrabinowitz/git-secret/assignees{/user}","branches_url":"https://api.github.com/repos/joshrabinowitz/git-secret/branches{/branch}","tags_url":"https://api.github.com/repos/joshrabinowitz/git-secret/tags","blobs_url":"https://api.github.com/repos/joshrabinowitz/git-secret/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshrabinowitz/git-secret/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshrabinowitz/git-secret/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshrabinowitz/git-secret/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshrabinowitz/git-secret/statuses/{sha}","languages_url":"https://api.github.com/repos/joshrabinowitz/git-secret/languages","stargazers_url":"https://api.github.com/repos/joshrabinowitz/git-secret/stargazers","contributors_url":"https://api.github.com/repos/joshrabinowitz/git-secret/contributors","subscribers_url":"https://api.github.com/repos/joshrabinowitz/git-secret/subscribers","subscription_url":"https://api.github.com/repos/joshrabinowitz/git-secret/subscription","commits_url":"https://api.github.com/repos/joshrabinowitz/git-secret/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshrabinowitz/git-secret/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshrabinowitz/git-secret/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshrabinowitz/git-secret/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshrabinowitz/git-secret/contents/{+path}","compare_url":"https://api.github.com/repos/joshrabinowitz/git-secret/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshrabinowitz/git-secret/merges","archive_url":"https://api.github.com/repos/joshrabinowitz/git-secret/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshrabinowitz/git-secret/downloads","issues_url":"https://api.github.com/repos/joshrabinowitz/git-secret/issues{/number}","pulls_url":"https://api.github.com/repos/joshrabinowitz/git-secret/pulls{/number}","milestones_url":"https://api.github.com/repos/joshrabinowitz/git-secret/milestones{/number}","notifications_url":"https://api.github.com/repos/joshrabinowitz/git-secret/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshrabinowitz/git-secret/labels{/name}","releases_url":"https://api.github.com/repos/joshrabinowitz/git-secret/releases{/id}","deployments_url":"https://api.github.com/repos/joshrabinowitz/git-secret/deployments","created_at":"2018-05-10T17:13:07Z","updated_at":"2018-12-18T15:03:25Z","pushed_at":"2018-12-29T12:55:37Z","git_url":"git://github.com/joshrabinowitz/git-secret.git","ssh_url":"git@github.com:joshrabinowitz/git-secret.git","clone_url":"https://github.com/joshrabinowitz/git-secret.git","svn_url":"https://github.com/joshrabinowitz/git-secret","homepage":"http://git-secret.io","size":2446,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"sobolevn:master","ref":"master","sha":"14eea46cc993b7969b53d1fc5875ecba517ec20b","user":{"login":"sobolevn","id":4660275,"node_id":"MDQ6VXNlcjQ2NjAyNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/4660275?v=4","gravatar_id":"","url":"https://api.github.com/users/sobolevn","html_url":"https://github.com/sobolevn","followers_url":"https://api.github.com/users/sobolevn/followers","following_url":"https://api.github.com/users/sobolevn/following{/other_user}","gists_url":"https://api.github.com/users/sobolevn/gists{/gist_id}","starred_url":"https://api.github.com/users/sobolevn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sobolevn/subscriptions","organizations_url":"https://api.github.com/users/sobolevn/orgs","repos_url":"https://api.github.com/users/sobolevn/repos","events_url":"https://api.github.com/users/sobolevn/events{/privacy}","received_events_url":"https://api.github.com/users/sobolevn/received_events","type":"User","site_admin":false},"repo":{"id":51747445,"node_id":"MDEwOlJlcG9zaXRvcnk1MTc0NzQ0NQ==","name":"git-secret","full_name":"sobolevn/git-secret","private":false,"owner":{"login":"sobolevn","id":4660275,"node_id":"MDQ6VXNlcjQ2NjAyNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/4660275?v=4","gravatar_id":"","url":"https://api.github.com/users/sobolevn","html_url":"https://github.com/sobolevn","followers_url":"https://api.github.com/users/sobolevn/followers","following_url":"https://api.github.com/users/sobolevn/following{/other_user}","gists_url":"https://api.github.com/users/sobolevn/gists{/gist_id}","starred_url":"https://api.github.com/users/sobolevn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sobolevn/subscriptions","organizations_url":"https://api.github.com/users/sobolevn/orgs","repos_url":"https://api.github.com/users/sobolevn/repos","events_url":"https://api.github.com/users/sobolevn/events{/privacy}","received_events_url":"https://api.github.com/users/sobolevn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sobolevn/git-secret","description":":busts_in_silhouette: A bash-tool to store your private data inside a git repository.","fork":false,"url":"https://api.github.com/repos/sobolevn/git-secret","forks_url":"https://api.github.com/repos/sobolevn/git-secret/forks","keys_url":"https://api.github.com/repos/sobolevn/git-secret/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sobolevn/git-secret/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sobolevn/git-secret/teams","hooks_url":"https://api.github.com/repos/sobolevn/git-secret/hooks","issue_events_url":"https://api.github.com/repos/sobolevn/git-secret/issues/events{/number}","events_url":"https://api.github.com/repos/sobolevn/git-secret/events","assignees_url":"https://api.github.com/repos/sobolevn/git-secret/assignees{/user}","branches_url":"https://api.github.com/repos/sobolevn/git-secret/branches{/branch}","tags_url":"https://api.github.com/repos/sobolevn/git-secret/tags","blobs_url":"https://api.github.com/repos/sobolevn/git-secret/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sobolevn/git-secret/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sobolevn/git-secret/git/refs{/sha}","trees_url":"https://api.github.com/repos/sobolevn/git-secret/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sobolevn/git-secret/statuses/{sha}","languages_url":"https://api.github.com/repos/sobolevn/git-secret/languages","stargazers_url":"https://api.github.com/repos/sobolevn/git-secret/stargazers","contributors_url":"https://api.github.com/repos/sobolevn/git-secret/contributors","subscribers_url":"https://api.github.com/repos/sobolevn/git-secret/subscribers","subscription_url":"https://api.github.com/repos/sobolevn/git-secret/subscription","commits_url":"https://api.github.com/repos/sobolevn/git-secret/commits{/sha}","git_commits_url":"https://api.github.com/repos/sobolevn/git-secret/git/commits{/sha}","comments_url":"https://api.github.com/repos/sobolevn/git-secret/comments{/number}","issue_comment_url":"https://api.github.com/repos/sobolevn/git-secret/issues/comments{/number}","contents_url":"https://api.github.com/repos/sobolevn/git-secret/contents/{+path}","compare_url":"https://api.github.com/repos/sobolevn/git-secret/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sobolevn/git-secret/merges","archive_url":"https://api.github.com/repos/sobolevn/git-secret/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sobolevn/git-secret/downloads","issues_url":"https://api.github.com/repos/sobolevn/git-secret/issues{/number}","pulls_url":"https://api.github.com/repos/sobolevn/git-secret/pulls{/number}","milestones_url":"https://api.github.com/repos/sobolevn/git-secret/milestones{/number}","notifications_url":"https://api.github.com/repos/sobolevn/git-secret/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sobolevn/git-secret/labels{/name}","releases_url":"https://api.github.com/repos/sobolevn/git-secret/releases{/id}","deployments_url":"https://api.github.com/repos/sobolevn/git-secret/deployments","created_at":"2016-02-15T10:16:53Z","updated_at":"2018-12-28T21:29:59Z","pushed_at":"2018-12-28T20:06:46Z","git_url":"git://github.com/sobolevn/git-secret.git","ssh_url":"git@github.com:sobolevn/git-secret.git","clone_url":"https://github.com/sobolevn/git-secret.git","svn_url":"https://github.com/sobolevn/git-secret","homepage":"http://git-secret.io","size":2331,"stargazers_count":1169,"watchers_count":1169,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":88,"open_issues":37,"watchers":1169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sobolevn/git-secret/pulls/293"},"html":{"href":"https://github.com/sobolevn/git-secret/pull/293"},"issue":{"href":"https://api.github.com/repos/sobolevn/git-secret/issues/293"},"comments":{"href":"https://api.github.com/repos/sobolevn/git-secret/issues/293/comments"},"review_comments":{"href":"https://api.github.com/repos/sobolevn/git-secret/pulls/293/comments"},"review_comment":{"href":"https://api.github.com/repos/sobolevn/git-secret/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sobolevn/git-secret/pulls/293/commits"},"statuses":{"href":"https://api.github.com/repos/sobolevn/git-secret/statuses/6995c03d4622fd557fa6570f4e2d6228ccca0ff9"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":39,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"joshrabinowitz"}}