{"action":"closed","number":4241,"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/4241","id":189792591,"html_url":"https://github.com/material-components/material-components-ios/pull/4241","diff_url":"https://github.com/material-components/material-components-ios/pull/4241.diff","patch_url":"https://github.com/material-components/material-components-ios/pull/4241.patch","issue_url":"https://api.github.com/repos/material-components/material-components-ios/issues/4241","number":4241,"state":"closed","locked":false,"title":"[BottomSheet] Fix layout issues caused by invoking self.dismissOnBackgroundTap in -init","user":{"login":"jverkoey","id":45670,"avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false},"body":"This PR was forked from https://github.com/material-components/material-components-ios/pull/3424. This PR removes the UI tests that were originally included in that PR because the UI tests do not run on our infrastructure without increasing flakiness (this is due to bazel problems, not the PR).\r\n\r\n> MDCBottomSheetController had a few subtle issues when the content view controller contained a scroll view.\r\n>\r\n> Setting `controller.trackingScrollView` had no effect, because the call to `self.dismissOnBackgroundTap = YES` added in a1c6621 had the side effect of invoking `-[MDCBottomSheetTransitionController presentationControllerForPresentedViewController:presentingViewController:sourceViewController:]`, and as soon as that method was invoked, the transition controller read the (then-nil) value of `controller.trackingScrollView`, and never read it again.\r\n>\r\n> This fixes the issue by ensuring we don't access\r\n> `self.mdc_bottomSheetPresentationController` in the initializer.","created_at":"2018-05-22T21:07:10Z","updated_at":"2018-05-24T16:22:18Z","closed_at":"2018-05-24T16:22:18Z","merged_at":"2018-05-24T16:22:18Z","merge_commit_sha":"2c80a9509e35d0288f26c9b6f720b4eb5fd95d83","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bhamiltoncx","id":671827,"avatar_url":"https://avatars3.githubusercontent.com/u/671827?v=4","gravatar_id":"","url":"https://api.github.com/users/bhamiltoncx","html_url":"https://github.com/bhamiltoncx","followers_url":"https://api.github.com/users/bhamiltoncx/followers","following_url":"https://api.github.com/users/bhamiltoncx/following{/other_user}","gists_url":"https://api.github.com/users/bhamiltoncx/gists{/gist_id}","starred_url":"https://api.github.com/users/bhamiltoncx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhamiltoncx/subscriptions","organizations_url":"https://api.github.com/users/bhamiltoncx/orgs","repos_url":"https://api.github.com/users/bhamiltoncx/repos","events_url":"https://api.github.com/users/bhamiltoncx/events{/privacy}","received_events_url":"https://api.github.com/users/bhamiltoncx/received_events","type":"User","site_admin":false},{"login":"jmdetloff","id":1418389,"avatar_url":"https://avatars2.githubusercontent.com/u/1418389?v=4","gravatar_id":"","url":"https://api.github.com/users/jmdetloff","html_url":"https://github.com/jmdetloff","followers_url":"https://api.github.com/users/jmdetloff/followers","following_url":"https://api.github.com/users/jmdetloff/following{/other_user}","gists_url":"https://api.github.com/users/jmdetloff/gists{/gist_id}","starred_url":"https://api.github.com/users/jmdetloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmdetloff/subscriptions","organizations_url":"https://api.github.com/users/jmdetloff/orgs","repos_url":"https://api.github.com/users/jmdetloff/repos","events_url":"https://api.github.com/users/jmdetloff/events{/privacy}","received_events_url":"https://api.github.com/users/jmdetloff/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":666268722,"url":"https://api.github.com/repos/material-components/material-components-ios/labels/[BottomSheet]","name":"[BottomSheet]","color":"eeeeee","default":false},{"id":273191333,"url":"https://api.github.com/repos/material-components/material-components-ios/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/4241/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/4241/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/issues/4241/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/851aef507fca16a7f07371d2502285dc98244391","head":{"label":"jverkoey:bhamiltoncx-bottomsheet-scrollview-part2-3","ref":"bhamiltoncx-bottomsheet-scrollview-part2-3","sha":"851aef507fca16a7f07371d2502285dc98244391","user":{"login":"jverkoey","id":45670,"avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false},"repo":{"id":91832448,"name":"material-components-ios","full_name":"jverkoey/material-components-ios","owner":{"login":"jverkoey","id":45670,"avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jverkoey/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":true,"url":"https://api.github.com/repos/jverkoey/material-components-ios","forks_url":"https://api.github.com/repos/jverkoey/material-components-ios/forks","keys_url":"https://api.github.com/repos/jverkoey/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jverkoey/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jverkoey/material-components-ios/teams","hooks_url":"https://api.github.com/repos/jverkoey/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/jverkoey/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/jverkoey/material-components-ios/events","assignees_url":"https://api.github.com/repos/jverkoey/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/jverkoey/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/jverkoey/material-components-ios/tags","blobs_url":"https://api.github.com/repos/jverkoey/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jverkoey/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jverkoey/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/jverkoey/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jverkoey/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/jverkoey/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/jverkoey/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/jverkoey/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/jverkoey/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/jverkoey/material-components-ios/subscription","commits_url":"https://api.github.com/repos/jverkoey/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/jverkoey/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/jverkoey/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/jverkoey/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/jverkoey/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/jverkoey/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jverkoey/material-components-ios/merges","archive_url":"https://api.github.com/repos/jverkoey/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jverkoey/material-components-ios/downloads","issues_url":"https://api.github.com/repos/jverkoey/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/jverkoey/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/jverkoey/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/jverkoey/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jverkoey/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/jverkoey/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/jverkoey/material-components-ios/deployments","created_at":"2017-05-19T18:02:30Z","updated_at":"2018-05-19T14:30:43Z","pushed_at":"2018-05-23T16:22:55Z","git_url":"git://github.com/jverkoey/material-components-ios.git","ssh_url":"git@github.com:jverkoey/material-components-ios.git","clone_url":"https://github.com/jverkoey/material-components-ios.git","svn_url":"https://github.com/jverkoey/material-components-ios","homepage":"","size":112922,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"material-components:develop","ref":"develop","sha":"5f0e12550df56a9db112aaae5617cad4f4a1ff6d","user":{"login":"material-components","id":19478152,"avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":43820219,"name":"material-components-ios","full_name":"material-components/material-components-ios","owner":{"login":"material-components","id":19478152,"avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":false,"url":"https://api.github.com/repos/material-components/material-components-ios","forks_url":"https://api.github.com/repos/material-components/material-components-ios/forks","keys_url":"https://api.github.com/repos/material-components/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-ios/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-ios/events","assignees_url":"https://api.github.com/repos/material-components/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-ios/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-ios/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-ios/merges","archive_url":"https://api.github.com/repos/material-components/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-ios/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-ios/deployments","created_at":"2015-10-07T14:12:39Z","updated_at":"2018-05-24T14:58:48Z","pushed_at":"2018-05-24T16:22:18Z","git_url":"git://github.com/material-components/material-components-ios.git","ssh_url":"git@github.com:material-components/material-components-ios.git","clone_url":"https://github.com/material-components/material-components-ios.git","svn_url":"https://github.com/material-components/material-components-ios","homepage":"","size":112811,"stargazers_count":2366,"watchers_count":2366,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":340,"mirror_url":null,"archived":false,"open_issues_count":1024,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":340,"open_issues":1024,"watchers":2366,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/4241"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/4241"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/4241"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/4241/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/4241/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/4241/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-ios/statuses/851aef507fca16a7f07371d2502285dc98244391"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jverkoey","id":45670,"avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":4,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"jverkoey"}}