{"action":"created","issue":{"url":"https://api.github.com/repos/brick/money/issues/19","repository_url":"https://api.github.com/repos/brick/money","labels_url":"https://api.github.com/repos/brick/money/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/brick/money/issues/19/comments","events_url":"https://api.github.com/repos/brick/money/issues/19/events","html_url":"https://github.com/brick/money/issues/19","id":333088095,"node_id":"MDU6SXNzdWUzMzMwODgwOTU=","number":19,"title":"Formatting the Number part in toString or add formatting functions","user":{"login":"mtangoo","id":1502872,"node_id":"MDQ6VXNlcjE1MDI4NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1502872?v=4","gravatar_id":"","url":"https://api.github.com/users/mtangoo","html_url":"https://github.com/mtangoo","followers_url":"https://api.github.com/users/mtangoo/followers","following_url":"https://api.github.com/users/mtangoo/following{/other_user}","gists_url":"https://api.github.com/users/mtangoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mtangoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtangoo/subscriptions","organizations_url":"https://api.github.com/users/mtangoo/orgs","repos_url":"https://api.github.com/users/mtangoo/repos","events_url":"https://api.github.com/users/mtangoo/events{/privacy}","received_events_url":"https://api.github.com/users/mtangoo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-06-17T19:50:39Z","updated_at":"2018-06-18T08:16:19Z","closed_at":"2018-06-17T23:19:11Z","author_association":"NONE","body":"Hi,\r\nIs there a way to format string echo-ed? I meanis `echo Money::of(5000, 'TZS')` should display TZS 5,000.00 instead of current `TZS 5000.00`. It makes reading big number easier.\r\n\r\nPHP [have already number formatting function](http://php.net/manual/en/function.number-format.php) and it wouldn't be very hard to add its. \r\n\r\nI'm not sure if every currency have corresponding separator or even if there is such a thing as universal separator. If indeed there is separator per currency we can check the currency and apply `number_format` accordingly. If not, then we can add a `format($separator=',')` function to money class that works the same as `toString()` but formats the number part of the result.\r\n\r\nWhat do you think?"},"comment":{"url":"https://api.github.com/repos/brick/money/issues/comments/397976479","html_url":"https://github.com/brick/money/issues/19#issuecomment-397976479","issue_url":"https://api.github.com/repos/brick/money/issues/19","id":397976479,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Nzk3NjQ3OQ==","user":{"login":"mtangoo","id":1502872,"node_id":"MDQ6VXNlcjE1MDI4NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1502872?v=4","gravatar_id":"","url":"https://api.github.com/users/mtangoo","html_url":"https://github.com/mtangoo","followers_url":"https://api.github.com/users/mtangoo/followers","following_url":"https://api.github.com/users/mtangoo/following{/other_user}","gists_url":"https://api.github.com/users/mtangoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mtangoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtangoo/subscriptions","organizations_url":"https://api.github.com/users/mtangoo/orgs","repos_url":"https://api.github.com/users/mtangoo/repos","events_url":"https://api.github.com/users/mtangoo/events{/privacy}","received_events_url":"https://api.github.com/users/mtangoo/received_events","type":"User","site_admin":false},"created_at":"2018-06-18T08:16:19Z","updated_at":"2018-06-18T08:16:19Z","author_association":"NONE","body":"@Vasek, \r\nI didn't put word locale at all :)\r\nActually there's simple formatter for numbers to make them readable and have nothing to do with locale.  PHP includes one so at least it exists.\r\n\r\nI was suggesting that the library handles that too.  But since it seems a bad idea,  I will extend Money class and add it there,  problem solved! \r\n\r\nThe library already offers a lot for free and would not complain if such simple thing is missing \r\n\r\nCheers! "}}
{"actor":{"display_login":"mtangoo"}}