{"action":"created","comment":{"url":"https://api.github.com/repos/legion-platform/legion/pulls/comments/206771034","pull_request_review_id":142246441,"id":206771034,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjc3MTAzNA==","diff_hunk":"@@ -13,20 +13,26 @@\n #    See the License for the specific language governing permissions and\n #    limitations under the License.\n #\n-FROM alpine:3.7\n+FROM ubuntu:16.04\n \n-RUN apk add --update --no-cache \\\n-    python3 g++ python3-dev py-pip py-setuptools file wget git fribidi\\\n-    tiff-dev jpeg-dev zlib-dev tcl-dev tk-dev python2-tkinter \\\n-    python3-tkinter-tests freetype-dev lcms2-dev libwebp harfbuzz \\\n-    libstdc++ musl-dev linux-headers build-base pcre pcre-dev\\\n-    openblas-dev freetype-dev pkgconfig \\\n-    && ln -s locale.h /usr/include/xlocale.h\n+ENV DEBIAN_FRONTEND=noninteractive\n \n-ADD requirements.txt /root/requirements.txt\n+# Add Python3.6 repository\n+RUN apt-get update && apt-get install -y software-properties-common && \\","path":"base-python-image/Dockerfile","position":18,"original_position":18,"commit_id":"ee808377e75f43e7eea69ac3c7220b691ce96952","original_commit_id":"ee808377e75f43e7eea69ac3c7220b691ce96952","user":{"login":"alexander-semenets","id":13346594,"node_id":"MDQ6VXNlcjEzMzQ2NTk0","avatar_url":"https://avatars1.githubusercontent.com/u/13346594?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-semenets","html_url":"https://github.com/alexander-semenets","followers_url":"https://api.github.com/users/alexander-semenets/followers","following_url":"https://api.github.com/users/alexander-semenets/following{/other_user}","gists_url":"https://api.github.com/users/alexander-semenets/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-semenets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-semenets/subscriptions","organizations_url":"https://api.github.com/users/alexander-semenets/orgs","repos_url":"https://api.github.com/users/alexander-semenets/repos","events_url":"https://api.github.com/users/alexander-semenets/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-semenets/received_events","type":"User","site_admin":false},"body":"we have to add repositories and apt tools before proceeding, also python repo and basic ubuntu tools supposed to be changed much rarely then dependencies packages and libs so makes sense to have them in separate layers for better layers reuse","created_at":"2018-08-01T06:51:15Z","updated_at":"2018-08-01T06:51:30Z","html_url":"https://github.com/legion-platform/legion/pull/242#discussion_r206771034","pull_request_url":"https://api.github.com/repos/legion-platform/legion/pulls/242","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/legion-platform/legion/pulls/comments/206771034"},"html":{"href":"https://github.com/legion-platform/legion/pull/242#discussion_r206771034"},"pull_request":{"href":"https://api.github.com/repos/legion-platform/legion/pulls/242"}},"in_reply_to_id":206122917},"pull_request":{"url":"https://api.github.com/repos/legion-platform/legion/pulls/242","id":202460951,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNDYwOTUx","html_url":"https://github.com/legion-platform/legion/pull/242","diff_url":"https://github.com/legion-platform/legion/pull/242.diff","patch_url":"https://github.com/legion-platform/legion/pull/242.patch","issue_url":"https://api.github.com/repos/legion-platform/legion/issues/242","number":242,"state":"open","locked":false,"title":"[#233] ubuntu base python image","user":{"login":"alexander-semenets","id":13346594,"node_id":"MDQ6VXNlcjEzMzQ2NTk0","avatar_url":"https://avatars1.githubusercontent.com/u/13346594?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-semenets","html_url":"https://github.com/alexander-semenets","followers_url":"https://api.github.com/users/alexander-semenets/followers","following_url":"https://api.github.com/users/alexander-semenets/following{/other_user}","gists_url":"https://api.github.com/users/alexander-semenets/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-semenets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-semenets/subscriptions","organizations_url":"https://api.github.com/users/alexander-semenets/orgs","repos_url":"https://api.github.com/users/alexander-semenets/repos","events_url":"https://api.github.com/users/alexander-semenets/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-semenets/received_events","type":"User","site_admin":false},"body":"- base-python-image is based on ubuntu minimal instead of alpine\r\n- temp packages cleanup added\r\n- airflow image is based on base-python-image\r\n- python3.6 is used as default python3 interpreter\r\n- packages installation updated in according to new distribution\r\n","created_at":"2018-07-19T06:52:30Z","updated_at":"2018-08-01T06:51:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6965e98774cf9ec48eeb24db3148da7052607783","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/legion-platform/legion/pulls/242/commits","review_comments_url":"https://api.github.com/repos/legion-platform/legion/pulls/242/comments","review_comment_url":"https://api.github.com/repos/legion-platform/legion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/legion-platform/legion/issues/242/comments","statuses_url":"https://api.github.com/repos/legion-platform/legion/statuses/ee808377e75f43e7eea69ac3c7220b691ce96952","head":{"label":"legion-platform:feat/233-ubuntu-base-python-image","ref":"feat/233-ubuntu-base-python-image","sha":"ee808377e75f43e7eea69ac3c7220b691ce96952","user":{"login":"legion-platform","id":38894075,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODk0MDc1","avatar_url":"https://avatars0.githubusercontent.com/u/38894075?v=4","gravatar_id":"","url":"https://api.github.com/users/legion-platform","html_url":"https://github.com/legion-platform","followers_url":"https://api.github.com/users/legion-platform/followers","following_url":"https://api.github.com/users/legion-platform/following{/other_user}","gists_url":"https://api.github.com/users/legion-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/legion-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legion-platform/subscriptions","organizations_url":"https://api.github.com/users/legion-platform/orgs","repos_url":"https://api.github.com/users/legion-platform/repos","events_url":"https://api.github.com/users/legion-platform/events{/privacy}","received_events_url":"https://api.github.com/users/legion-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":117873483,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc4NzM0ODM=","name":"legion","full_name":"legion-platform/legion","owner":{"login":"legion-platform","id":38894075,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODk0MDc1","avatar_url":"https://avatars0.githubusercontent.com/u/38894075?v=4","gravatar_id":"","url":"https://api.github.com/users/legion-platform","html_url":"https://github.com/legion-platform","followers_url":"https://api.github.com/users/legion-platform/followers","following_url":"https://api.github.com/users/legion-platform/following{/other_user}","gists_url":"https://api.github.com/users/legion-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/legion-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legion-platform/subscriptions","organizations_url":"https://api.github.com/users/legion-platform/orgs","repos_url":"https://api.github.com/users/legion-platform/repos","events_url":"https://api.github.com/users/legion-platform/events{/privacy}","received_events_url":"https://api.github.com/users/legion-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/legion-platform/legion","description":"The Toolchain agnostic Runtime AI platform","fork":false,"url":"https://api.github.com/repos/legion-platform/legion","forks_url":"https://api.github.com/repos/legion-platform/legion/forks","keys_url":"https://api.github.com/repos/legion-platform/legion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/legion-platform/legion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/legion-platform/legion/teams","hooks_url":"https://api.github.com/repos/legion-platform/legion/hooks","issue_events_url":"https://api.github.com/repos/legion-platform/legion/issues/events{/number}","events_url":"https://api.github.com/repos/legion-platform/legion/events","assignees_url":"https://api.github.com/repos/legion-platform/legion/assignees{/user}","branches_url":"https://api.github.com/repos/legion-platform/legion/branches{/branch}","tags_url":"https://api.github.com/repos/legion-platform/legion/tags","blobs_url":"https://api.github.com/repos/legion-platform/legion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/legion-platform/legion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/legion-platform/legion/git/refs{/sha}","trees_url":"https://api.github.com/repos/legion-platform/legion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/legion-platform/legion/statuses/{sha}","languages_url":"https://api.github.com/repos/legion-platform/legion/languages","stargazers_url":"https://api.github.com/repos/legion-platform/legion/stargazers","contributors_url":"https://api.github.com/repos/legion-platform/legion/contributors","subscribers_url":"https://api.github.com/repos/legion-platform/legion/subscribers","subscription_url":"https://api.github.com/repos/legion-platform/legion/subscription","commits_url":"https://api.github.com/repos/legion-platform/legion/commits{/sha}","git_commits_url":"https://api.github.com/repos/legion-platform/legion/git/commits{/sha}","comments_url":"https://api.github.com/repos/legion-platform/legion/comments{/number}","issue_comment_url":"https://api.github.com/repos/legion-platform/legion/issues/comments{/number}","contents_url":"https://api.github.com/repos/legion-platform/legion/contents/{+path}","compare_url":"https://api.github.com/repos/legion-platform/legion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/legion-platform/legion/merges","archive_url":"https://api.github.com/repos/legion-platform/legion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/legion-platform/legion/downloads","issues_url":"https://api.github.com/repos/legion-platform/legion/issues{/number}","pulls_url":"https://api.github.com/repos/legion-platform/legion/pulls{/number}","milestones_url":"https://api.github.com/repos/legion-platform/legion/milestones{/number}","notifications_url":"https://api.github.com/repos/legion-platform/legion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/legion-platform/legion/labels{/name}","releases_url":"https://api.github.com/repos/legion-platform/legion/releases{/id}","deployments_url":"https://api.github.com/repos/legion-platform/legion/deployments","created_at":"2018-01-17T18:05:57Z","updated_at":"2018-07-12T00:38:42Z","pushed_at":"2018-07-31T14:21:55Z","git_url":"git://github.com/legion-platform/legion.git","ssh_url":"git@github.com:legion-platform/legion.git","clone_url":"https://github.com/legion-platform/legion.git","svn_url":"https://github.com/legion-platform/legion","homepage":"http://legion-platform.org","size":3595,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":81,"watchers":7,"default_branch":"master"}},"base":{"label":"legion-platform:develop","ref":"develop","sha":"589537719b01bda34484d7bdaa50842ea80e93a5","user":{"login":"legion-platform","id":38894075,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODk0MDc1","avatar_url":"https://avatars0.githubusercontent.com/u/38894075?v=4","gravatar_id":"","url":"https://api.github.com/users/legion-platform","html_url":"https://github.com/legion-platform","followers_url":"https://api.github.com/users/legion-platform/followers","following_url":"https://api.github.com/users/legion-platform/following{/other_user}","gists_url":"https://api.github.com/users/legion-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/legion-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legion-platform/subscriptions","organizations_url":"https://api.github.com/users/legion-platform/orgs","repos_url":"https://api.github.com/users/legion-platform/repos","events_url":"https://api.github.com/users/legion-platform/events{/privacy}","received_events_url":"https://api.github.com/users/legion-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":117873483,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc4NzM0ODM=","name":"legion","full_name":"legion-platform/legion","owner":{"login":"legion-platform","id":38894075,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODk0MDc1","avatar_url":"https://avatars0.githubusercontent.com/u/38894075?v=4","gravatar_id":"","url":"https://api.github.com/users/legion-platform","html_url":"https://github.com/legion-platform","followers_url":"https://api.github.com/users/legion-platform/followers","following_url":"https://api.github.com/users/legion-platform/following{/other_user}","gists_url":"https://api.github.com/users/legion-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/legion-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legion-platform/subscriptions","organizations_url":"https://api.github.com/users/legion-platform/orgs","repos_url":"https://api.github.com/users/legion-platform/repos","events_url":"https://api.github.com/users/legion-platform/events{/privacy}","received_events_url":"https://api.github.com/users/legion-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/legion-platform/legion","description":"The Toolchain agnostic Runtime AI platform","fork":false,"url":"https://api.github.com/repos/legion-platform/legion","forks_url":"https://api.github.com/repos/legion-platform/legion/forks","keys_url":"https://api.github.com/repos/legion-platform/legion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/legion-platform/legion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/legion-platform/legion/teams","hooks_url":"https://api.github.com/repos/legion-platform/legion/hooks","issue_events_url":"https://api.github.com/repos/legion-platform/legion/issues/events{/number}","events_url":"https://api.github.com/repos/legion-platform/legion/events","assignees_url":"https://api.github.com/repos/legion-platform/legion/assignees{/user}","branches_url":"https://api.github.com/repos/legion-platform/legion/branches{/branch}","tags_url":"https://api.github.com/repos/legion-platform/legion/tags","blobs_url":"https://api.github.com/repos/legion-platform/legion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/legion-platform/legion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/legion-platform/legion/git/refs{/sha}","trees_url":"https://api.github.com/repos/legion-platform/legion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/legion-platform/legion/statuses/{sha}","languages_url":"https://api.github.com/repos/legion-platform/legion/languages","stargazers_url":"https://api.github.com/repos/legion-platform/legion/stargazers","contributors_url":"https://api.github.com/repos/legion-platform/legion/contributors","subscribers_url":"https://api.github.com/repos/legion-platform/legion/subscribers","subscription_url":"https://api.github.com/repos/legion-platform/legion/subscription","commits_url":"https://api.github.com/repos/legion-platform/legion/commits{/sha}","git_commits_url":"https://api.github.com/repos/legion-platform/legion/git/commits{/sha}","comments_url":"https://api.github.com/repos/legion-platform/legion/comments{/number}","issue_comment_url":"https://api.github.com/repos/legion-platform/legion/issues/comments{/number}","contents_url":"https://api.github.com/repos/legion-platform/legion/contents/{+path}","compare_url":"https://api.github.com/repos/legion-platform/legion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/legion-platform/legion/merges","archive_url":"https://api.github.com/repos/legion-platform/legion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/legion-platform/legion/downloads","issues_url":"https://api.github.com/repos/legion-platform/legion/issues{/number}","pulls_url":"https://api.github.com/repos/legion-platform/legion/pulls{/number}","milestones_url":"https://api.github.com/repos/legion-platform/legion/milestones{/number}","notifications_url":"https://api.github.com/repos/legion-platform/legion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/legion-platform/legion/labels{/name}","releases_url":"https://api.github.com/repos/legion-platform/legion/releases{/id}","deployments_url":"https://api.github.com/repos/legion-platform/legion/deployments","created_at":"2018-01-17T18:05:57Z","updated_at":"2018-07-12T00:38:42Z","pushed_at":"2018-07-31T14:21:55Z","git_url":"git://github.com/legion-platform/legion.git","ssh_url":"git@github.com:legion-platform/legion.git","clone_url":"https://github.com/legion-platform/legion.git","svn_url":"https://github.com/legion-platform/legion","homepage":"http://legion-platform.org","size":3595,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":81,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/legion-platform/legion/pulls/242"},"html":{"href":"https://github.com/legion-platform/legion/pull/242"},"issue":{"href":"https://api.github.com/repos/legion-platform/legion/issues/242"},"comments":{"href":"https://api.github.com/repos/legion-platform/legion/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/legion-platform/legion/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/legion-platform/legion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/legion-platform/legion/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/legion-platform/legion/statuses/ee808377e75f43e7eea69ac3c7220b691ce96952"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"alexander-semenets"}}