{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/206858872","pull_request_review_id":142351630,"id":206858872,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjg1ODg3Mg==","diff_hunk":"@@ -813,40 +664,58 @@ static void light_lightness_set_unack(struct bt_mesh_model *model,\n \t\t\t\t      struct bt_mesh_msg_ctx *ctx,\n \t\t\t\t      struct net_buf_simple *buf)\n {\n-\tu8_t tid;\n+\tu8_t tid, buf_len, delay;\n \tu16_t actual;\n+\ts64_t now;\n \tstruct net_buf_simple *msg = model->pub->msg;\n \tstruct light_lightness_state *state = model->user_data;\n \n+\tbuf_len = buf->len;\n \tactual = net_buf_simple_pull_le16(buf);\n \ttid = net_buf_simple_pull_u8(buf);\n \n-\tif (state->last_tid == tid && state->last_tx_addr == ctx->addr) {\n+\tnow = k_uptime_get();\n+\tif (state->last_tid == tid && state->last_tx_addr == ctx->addr &&\n+\t    (now - state->last_msg_timestamp <= 6000)) {","path":"samples/boards/nrf52/mesh/onoff_level_lighting_vnd_app/src/mesh/device_composition.c","position":456,"original_position":821,"commit_id":"777ad20e0939177452dfe976bb24951d9e9af3ff","original_commit_id":"7ed885f9f8ee664b87c5d33ff89b909fc189b96d","user":{"login":"vikrant8051","id":5979717,"node_id":"MDQ6VXNlcjU5Nzk3MTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5979717?v=4","gravatar_id":"","url":"https://api.github.com/users/vikrant8051","html_url":"https://github.com/vikrant8051","followers_url":"https://api.github.com/users/vikrant8051/followers","following_url":"https://api.github.com/users/vikrant8051/following{/other_user}","gists_url":"https://api.github.com/users/vikrant8051/gists{/gist_id}","starred_url":"https://api.github.com/users/vikrant8051/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikrant8051/subscriptions","organizations_url":"https://api.github.com/users/vikrant8051/orgs","repos_url":"https://api.github.com/users/vikrant8051/repos","events_url":"https://api.github.com/users/vikrant8051/events{/privacy}","received_events_url":"https://api.github.com/users/vikrant8051/received_events","type":"User","site_admin":false},"body":"I will do it shortly.","created_at":"2018-08-01T12:29:10Z","updated_at":"2018-08-01T12:29:10Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/8926#discussion_r206858872","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8926","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/206858872"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/8926#discussion_r206858872"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8926"}},"in_reply_to_id":206789995},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8926","id":201341097,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzQxMDk3","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/8926","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/8926.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/8926.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8926","number":8926,"state":"open","locked":false,"title":"samples: mesh: nrf52: revised implementation, fixed bugs, upgrade further to pass PTS test, upgrade coding style","user":{"login":"vikrant8051","id":5979717,"node_id":"MDQ6VXNlcjU5Nzk3MTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5979717?v=4","gravatar_id":"","url":"https://api.github.com/users/vikrant8051","html_url":"https://github.com/vikrant8051","followers_url":"https://api.github.com/users/vikrant8051/followers","following_url":"https://api.github.com/users/vikrant8051/following{/other_user}","gists_url":"https://api.github.com/users/vikrant8051/gists{/gist_id}","starred_url":"https://api.github.com/users/vikrant8051/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikrant8051/subscriptions","organizations_url":"https://api.github.com/users/vikrant8051/orgs","repos_url":"https://api.github.com/users/vikrant8051/repos","events_url":"https://api.github.com/users/vikrant8051/events{/privacy}","received_events_url":"https://api.github.com/users/vikrant8051/received_events","type":"User","site_admin":false},"body":"Removed redundancy from App & revised overall implementation.\r\nFixed Bugs. Upgraded coding style. Added & replaced comments to\r\nimprove code readability.\r\n\r\nUpgrade State Binding algorithm by adding ceiling() & constrain\r\nfunctions.\r\n\r\nIf particular Server model receive Prohibited values as per\r\nMesh Model Specification then that message will not get entertained.\r\n\r\nNow proper status code will get send if user upgrade\r\nlight_lightness_range_state & light_ctl_temperature_range_state.\r\n\r\nAdded time stamp based message filtering as per Bluetooth Mesh\r\nDeveloper study guide for each Server. Now even if message\r\nsource address & TID is same even after 6 seconds then\r\nthat will get proceed otherwise will get ignored.\r\n\r\nAdded transition time support. With this it was possible to implement gen_move_set/gen_move_set_unack message handlers.\r\n\r\nSigned-off-by: Vikrant More <vikrant8051@gmail.com>","created_at":"2018-07-13T16:31:44Z","updated_at":"2018-08-01T12:29:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"538def6ed3f2dc0f4e8a564eab27e9134fac55e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8926/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8926/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8926/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/777ad20e0939177452dfe976bb24951d9e9af3ff","head":{"label":"vikrant8051:fix_bugs7","ref":"fix_bugs7","sha":"777ad20e0939177452dfe976bb24951d9e9af3ff","user":{"login":"vikrant8051","id":5979717,"node_id":"MDQ6VXNlcjU5Nzk3MTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5979717?v=4","gravatar_id":"","url":"https://api.github.com/users/vikrant8051","html_url":"https://github.com/vikrant8051","followers_url":"https://api.github.com/users/vikrant8051/followers","following_url":"https://api.github.com/users/vikrant8051/following{/other_user}","gists_url":"https://api.github.com/users/vikrant8051/gists{/gist_id}","starred_url":"https://api.github.com/users/vikrant8051/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikrant8051/subscriptions","organizations_url":"https://api.github.com/users/vikrant8051/orgs","repos_url":"https://api.github.com/users/vikrant8051/repos","events_url":"https://api.github.com/users/vikrant8051/events{/privacy}","received_events_url":"https://api.github.com/users/vikrant8051/received_events","type":"User","site_admin":false},"repo":{"id":140851031,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA4NTEwMzE=","name":"zephyr","full_name":"vikrant8051/zephyr","owner":{"login":"vikrant8051","id":5979717,"node_id":"MDQ6VXNlcjU5Nzk3MTc=","avatar_url":"https://avatars2.githubusercontent.com/u/5979717?v=4","gravatar_id":"","url":"https://api.github.com/users/vikrant8051","html_url":"https://github.com/vikrant8051","followers_url":"https://api.github.com/users/vikrant8051/followers","following_url":"https://api.github.com/users/vikrant8051/following{/other_user}","gists_url":"https://api.github.com/users/vikrant8051/gists{/gist_id}","starred_url":"https://api.github.com/users/vikrant8051/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikrant8051/subscriptions","organizations_url":"https://api.github.com/users/vikrant8051/orgs","repos_url":"https://api.github.com/users/vikrant8051/repos","events_url":"https://api.github.com/users/vikrant8051/events{/privacy}","received_events_url":"https://api.github.com/users/vikrant8051/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vikrant8051/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/vikrant8051/zephyr","forks_url":"https://api.github.com/repos/vikrant8051/zephyr/forks","keys_url":"https://api.github.com/repos/vikrant8051/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vikrant8051/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vikrant8051/zephyr/teams","hooks_url":"https://api.github.com/repos/vikrant8051/zephyr/hooks","issue_events_url":"https://api.github.com/repos/vikrant8051/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/vikrant8051/zephyr/events","assignees_url":"https://api.github.com/repos/vikrant8051/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/vikrant8051/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/vikrant8051/zephyr/tags","blobs_url":"https://api.github.com/repos/vikrant8051/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vikrant8051/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vikrant8051/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/vikrant8051/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vikrant8051/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/vikrant8051/zephyr/languages","stargazers_url":"https://api.github.com/repos/vikrant8051/zephyr/stargazers","contributors_url":"https://api.github.com/repos/vikrant8051/zephyr/contributors","subscribers_url":"https://api.github.com/repos/vikrant8051/zephyr/subscribers","subscription_url":"https://api.github.com/repos/vikrant8051/zephyr/subscription","commits_url":"https://api.github.com/repos/vikrant8051/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/vikrant8051/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/vikrant8051/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/vikrant8051/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/vikrant8051/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/vikrant8051/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vikrant8051/zephyr/merges","archive_url":"https://api.github.com/repos/vikrant8051/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vikrant8051/zephyr/downloads","issues_url":"https://api.github.com/repos/vikrant8051/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/vikrant8051/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/vikrant8051/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/vikrant8051/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vikrant8051/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/vikrant8051/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/vikrant8051/zephyr/deployments","created_at":"2018-07-13T13:34:37Z","updated_at":"2018-07-19T18:37:49Z","pushed_at":"2018-08-01T12:12:28Z","git_url":"git://github.com/vikrant8051/zephyr.git","ssh_url":"git@github.com:vikrant8051/zephyr.git","clone_url":"https://github.com/vikrant8051/zephyr.git","svn_url":"https://github.com/vikrant8051/zephyr","homepage":"https://docs.zephyrproject.org","size":122455,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"528f7f8f2b18a4b62a93aaa6e68e9d75db2f53ac","user":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"node_id":"MDEwOlJlcG9zaXRvcnk1OTc3MTQyNQ==","name":"zephyr","full_name":"zephyrproject-rtos/zephyr","owner":{"login":"zephyrproject-rtos","id":19595895,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTk1ODk1","avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-08-01T12:00:15Z","pushed_at":"2018-08-01T12:26:01Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"https://docs.zephyrproject.org","size":123267,"stargazers_count":1016,"watchers_count":1016,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":716,"mirror_url":null,"archived":false,"open_issues_count":971,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":716,"open_issues":971,"watchers":1016,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8926"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/8926"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8926"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8926/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8926/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8926/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/777ad20e0939177452dfe976bb24951d9e9af3ff"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vikrant8051"}}