{"action":"created","comment":{"url":"https://api.github.com/repos/tendermint/go-amino/pulls/comments/190431494","pull_request_review_id":122805482,"id":190431494,"diff_hunk":"@@ -695,18 +696,158 @@ func (cdc *Codec) decodeReflectBinaryStruct(bz []byte, info *TypeInfo, rv reflec\n \n \t\t// Read \"StructTerm\".\n \t\t// NOTE: In the future, we'll need to break out of a loop\n-\t\t// when encoutering an StructTerm typ3 byte.\n-\t\tvar typ = Typ3(0x00)\n+\t\t// when encountering an StructTerm typ3 byte.\n+\n+\t\tvar typ Typ3\n+\t\t// we have read all, or do we? consume the rest\n+\t\tfor len(bz) > 2 && bz[0]&0xF8 != 0 && Typ3(bz[0]) != Typ3_StructTerm {\n+\t\t\tfnum, typ3, _n, _ := decodeFieldNumberAndTyp3(bz)","path":"binary-decode.go","position":42,"original_position":42,"commit_id":"8db11eac5d7a3d4fa4a581a8b4d6f27ef9cbec3a","original_commit_id":"8db11eac5d7a3d4fa4a581a8b4d6f27ef9cbec3a","user":{"login":"Liamsi","id":7441766,"avatar_url":"https://avatars3.githubusercontent.com/u/7441766?v=4","gravatar_id":"","url":"https://api.github.com/users/Liamsi","html_url":"https://github.com/Liamsi","followers_url":"https://api.github.com/users/Liamsi/followers","following_url":"https://api.github.com/users/Liamsi/following{/other_user}","gists_url":"https://api.github.com/users/Liamsi/gists{/gist_id}","starred_url":"https://api.github.com/users/Liamsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liamsi/subscriptions","organizations_url":"https://api.github.com/users/Liamsi/orgs","repos_url":"https://api.github.com/users/Liamsi/repos","events_url":"https://api.github.com/users/Liamsi/events{/privacy}","received_events_url":"https://api.github.com/users/Liamsi/received_events","type":"User","site_admin":false},"body":"good catch! The whole purpose of this added lines is to catch potential errors ...","created_at":"2018-05-23T23:46:18Z","updated_at":"2018-05-23T23:46:18Z","html_url":"https://github.com/tendermint/go-amino/pull/155#discussion_r190431494","pull_request_url":"https://api.github.com/repos/tendermint/go-amino/pulls/155","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tendermint/go-amino/pulls/comments/190431494"},"html":{"href":"https://github.com/tendermint/go-amino/pull/155#discussion_r190431494"},"pull_request":{"href":"https://api.github.com/repos/tendermint/go-amino/pulls/155"}},"in_reply_to_id":190130421},"pull_request":{"url":"https://api.github.com/repos/tendermint/go-amino/pulls/155","id":189412396,"html_url":"https://github.com/tendermint/go-amino/pull/155","diff_url":"https://github.com/tendermint/go-amino/pull/155.diff","patch_url":"https://github.com/tendermint/go-amino/pull/155.patch","issue_url":"https://api.github.com/repos/tendermint/go-amino/issues/155","number":155,"state":"open","locked":false,"title":"Basic backwards compatibility","user":{"login":"Liamsi","id":7441766,"avatar_url":"https://avatars3.githubusercontent.com/u/7441766?v=4","gravatar_id":"","url":"https://api.github.com/users/Liamsi","html_url":"https://github.com/Liamsi","followers_url":"https://api.github.com/users/Liamsi/followers","following_url":"https://api.github.com/users/Liamsi/following{/other_user}","gists_url":"https://api.github.com/users/Liamsi/gists{/gist_id}","starred_url":"https://api.github.com/users/Liamsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liamsi/subscriptions","organizations_url":"https://api.github.com/users/Liamsi/orgs","repos_url":"https://api.github.com/users/Liamsi/repos","events_url":"https://api.github.com/users/Liamsi/events{/privacy}","received_events_url":"https://api.github.com/users/Liamsi/received_events","type":"User","site_admin":false},"body":"To achieve basic backwards compatibility, we continue reading the passed buffer even if all fields were already read. We only check if what follows is valid amino encoding.\r\n\r\nresolves #143 \r\n\r\nthis also includes changes of #153 which \r\nresolves #145","created_at":"2018-05-21T15:30:55Z","updated_at":"2018-05-23T23:46:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f52cbe49e4dbf6fd9f72411a60d4899812b593c7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tendermint/go-amino/pulls/155/commits","review_comments_url":"https://api.github.com/repos/tendermint/go-amino/pulls/155/comments","review_comment_url":"https://api.github.com/repos/tendermint/go-amino/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tendermint/go-amino/issues/155/comments","statuses_url":"https://api.github.com/repos/tendermint/go-amino/statuses/8db11eac5d7a3d4fa4a581a8b4d6f27ef9cbec3a","head":{"label":"Liamsi:backwards_compat","ref":"backwards_compat","sha":"8db11eac5d7a3d4fa4a581a8b4d6f27ef9cbec3a","user":{"login":"Liamsi","id":7441766,"avatar_url":"https://avatars3.githubusercontent.com/u/7441766?v=4","gravatar_id":"","url":"https://api.github.com/users/Liamsi","html_url":"https://github.com/Liamsi","followers_url":"https://api.github.com/users/Liamsi/followers","following_url":"https://api.github.com/users/Liamsi/following{/other_user}","gists_url":"https://api.github.com/users/Liamsi/gists{/gist_id}","starred_url":"https://api.github.com/users/Liamsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liamsi/subscriptions","organizations_url":"https://api.github.com/users/Liamsi/orgs","repos_url":"https://api.github.com/users/Liamsi/repos","events_url":"https://api.github.com/users/Liamsi/events{/privacy}","received_events_url":"https://api.github.com/users/Liamsi/received_events","type":"User","site_admin":false},"repo":{"id":128542033,"name":"go-amino","full_name":"Liamsi/go-amino","owner":{"login":"Liamsi","id":7441766,"avatar_url":"https://avatars3.githubusercontent.com/u/7441766?v=4","gravatar_id":"","url":"https://api.github.com/users/Liamsi","html_url":"https://github.com/Liamsi","followers_url":"https://api.github.com/users/Liamsi/followers","following_url":"https://api.github.com/users/Liamsi/following{/other_user}","gists_url":"https://api.github.com/users/Liamsi/gists{/gist_id}","starred_url":"https://api.github.com/users/Liamsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liamsi/subscriptions","organizations_url":"https://api.github.com/users/Liamsi/orgs","repos_url":"https://api.github.com/users/Liamsi/repos","events_url":"https://api.github.com/users/Liamsi/events{/privacy}","received_events_url":"https://api.github.com/users/Liamsi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Liamsi/go-amino","description":"Like Protobuf3 but better - Designed for blockchains (deterministic, upgradeable, fast, and compact)","fork":true,"url":"https://api.github.com/repos/Liamsi/go-amino","forks_url":"https://api.github.com/repos/Liamsi/go-amino/forks","keys_url":"https://api.github.com/repos/Liamsi/go-amino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Liamsi/go-amino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Liamsi/go-amino/teams","hooks_url":"https://api.github.com/repos/Liamsi/go-amino/hooks","issue_events_url":"https://api.github.com/repos/Liamsi/go-amino/issues/events{/number}","events_url":"https://api.github.com/repos/Liamsi/go-amino/events","assignees_url":"https://api.github.com/repos/Liamsi/go-amino/assignees{/user}","branches_url":"https://api.github.com/repos/Liamsi/go-amino/branches{/branch}","tags_url":"https://api.github.com/repos/Liamsi/go-amino/tags","blobs_url":"https://api.github.com/repos/Liamsi/go-amino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Liamsi/go-amino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Liamsi/go-amino/git/refs{/sha}","trees_url":"https://api.github.com/repos/Liamsi/go-amino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Liamsi/go-amino/statuses/{sha}","languages_url":"https://api.github.com/repos/Liamsi/go-amino/languages","stargazers_url":"https://api.github.com/repos/Liamsi/go-amino/stargazers","contributors_url":"https://api.github.com/repos/Liamsi/go-amino/contributors","subscribers_url":"https://api.github.com/repos/Liamsi/go-amino/subscribers","subscription_url":"https://api.github.com/repos/Liamsi/go-amino/subscription","commits_url":"https://api.github.com/repos/Liamsi/go-amino/commits{/sha}","git_commits_url":"https://api.github.com/repos/Liamsi/go-amino/git/commits{/sha}","comments_url":"https://api.github.com/repos/Liamsi/go-amino/comments{/number}","issue_comment_url":"https://api.github.com/repos/Liamsi/go-amino/issues/comments{/number}","contents_url":"https://api.github.com/repos/Liamsi/go-amino/contents/{+path}","compare_url":"https://api.github.com/repos/Liamsi/go-amino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Liamsi/go-amino/merges","archive_url":"https://api.github.com/repos/Liamsi/go-amino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Liamsi/go-amino/downloads","issues_url":"https://api.github.com/repos/Liamsi/go-amino/issues{/number}","pulls_url":"https://api.github.com/repos/Liamsi/go-amino/pulls{/number}","milestones_url":"https://api.github.com/repos/Liamsi/go-amino/milestones{/number}","notifications_url":"https://api.github.com/repos/Liamsi/go-amino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Liamsi/go-amino/labels{/name}","releases_url":"https://api.github.com/repos/Liamsi/go-amino/releases{/id}","deployments_url":"https://api.github.com/repos/Liamsi/go-amino/deployments","created_at":"2018-04-07T15:31:10Z","updated_at":"2018-04-07T15:31:13Z","pushed_at":"2018-05-21T15:36:53Z","git_url":"git://github.com/Liamsi/go-amino.git","ssh_url":"git@github.com:Liamsi/go-amino.git","clone_url":"https://github.com/Liamsi/go-amino.git","svn_url":"https://github.com/Liamsi/go-amino","homepage":"","size":6914,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tendermint:develop","ref":"develop","sha":"50745aab48d8a16d05a4b4b4ab2257ed09ac10c5","user":{"login":"tendermint","id":7572940,"avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"repo":{"id":44698621,"name":"go-amino","full_name":"tendermint/go-amino","owner":{"login":"tendermint","id":7572940,"avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tendermint/go-amino","description":"Like Protobuf3 but better - Designed for blockchains (deterministic, upgradeable, fast, and compact)","fork":false,"url":"https://api.github.com/repos/tendermint/go-amino","forks_url":"https://api.github.com/repos/tendermint/go-amino/forks","keys_url":"https://api.github.com/repos/tendermint/go-amino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tendermint/go-amino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tendermint/go-amino/teams","hooks_url":"https://api.github.com/repos/tendermint/go-amino/hooks","issue_events_url":"https://api.github.com/repos/tendermint/go-amino/issues/events{/number}","events_url":"https://api.github.com/repos/tendermint/go-amino/events","assignees_url":"https://api.github.com/repos/tendermint/go-amino/assignees{/user}","branches_url":"https://api.github.com/repos/tendermint/go-amino/branches{/branch}","tags_url":"https://api.github.com/repos/tendermint/go-amino/tags","blobs_url":"https://api.github.com/repos/tendermint/go-amino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tendermint/go-amino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tendermint/go-amino/git/refs{/sha}","trees_url":"https://api.github.com/repos/tendermint/go-amino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tendermint/go-amino/statuses/{sha}","languages_url":"https://api.github.com/repos/tendermint/go-amino/languages","stargazers_url":"https://api.github.com/repos/tendermint/go-amino/stargazers","contributors_url":"https://api.github.com/repos/tendermint/go-amino/contributors","subscribers_url":"https://api.github.com/repos/tendermint/go-amino/subscribers","subscription_url":"https://api.github.com/repos/tendermint/go-amino/subscription","commits_url":"https://api.github.com/repos/tendermint/go-amino/commits{/sha}","git_commits_url":"https://api.github.com/repos/tendermint/go-amino/git/commits{/sha}","comments_url":"https://api.github.com/repos/tendermint/go-amino/comments{/number}","issue_comment_url":"https://api.github.com/repos/tendermint/go-amino/issues/comments{/number}","contents_url":"https://api.github.com/repos/tendermint/go-amino/contents/{+path}","compare_url":"https://api.github.com/repos/tendermint/go-amino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tendermint/go-amino/merges","archive_url":"https://api.github.com/repos/tendermint/go-amino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tendermint/go-amino/downloads","issues_url":"https://api.github.com/repos/tendermint/go-amino/issues{/number}","pulls_url":"https://api.github.com/repos/tendermint/go-amino/pulls{/number}","milestones_url":"https://api.github.com/repos/tendermint/go-amino/milestones{/number}","notifications_url":"https://api.github.com/repos/tendermint/go-amino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tendermint/go-amino/labels{/name}","releases_url":"https://api.github.com/repos/tendermint/go-amino/releases{/id}","deployments_url":"https://api.github.com/repos/tendermint/go-amino/deployments","created_at":"2015-10-21T19:16:59Z","updated_at":"2018-05-21T21:57:58Z","pushed_at":"2018-05-21T15:36:55Z","git_url":"git://github.com/tendermint/go-amino.git","ssh_url":"git@github.com:tendermint/go-amino.git","clone_url":"https://github.com/tendermint/go-amino.git","svn_url":"https://github.com/tendermint/go-amino","homepage":"","size":6968,"stargazers_count":83,"watchers_count":83,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":24,"open_issues":55,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tendermint/go-amino/pulls/155"},"html":{"href":"https://github.com/tendermint/go-amino/pull/155"},"issue":{"href":"https://api.github.com/repos/tendermint/go-amino/issues/155"},"comments":{"href":"https://api.github.com/repos/tendermint/go-amino/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/tendermint/go-amino/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/tendermint/go-amino/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tendermint/go-amino/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/tendermint/go-amino/statuses/8db11eac5d7a3d4fa4a581a8b4d6f27ef9cbec3a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Liamsi"}}