{"action":"created","comment":{"url":"https://api.github.com/repos/redealumni/qb_hr_mobile/pulls/comments/197953944","pull_request_review_id":131798061,"id":197953944,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzk1Mzk0NA==","diff_hunk":"@@ -1,14 +1,15 @@\n module OfferHelper\n   def build_search_criteria(params)\n     unscoped = Offer.unscoped.includes(:university, :course).joins(:university, :course)\n-\n-    api_hash = params.permit(\"university_id\", \"course_id\", \"kind\", \"level\", \"shift\", \"discount_percentage_min\", \"offered_price_max\").to_h\n+    \n+    api_hash = params.permit(:discount_percentage_min, :offered_price_max, :shift => [], :kind => [], :level => [], :university_id => [], :subject_id => []).to_h\n \n     courses_hash = {}\n \n     courses_hash.store(\"kind\", api_hash.delete(\"kind\")) unless !api_hash.has_key? (\"kind\")\n     courses_hash.store(\"level\", api_hash.delete(\"level\")) unless !api_hash.has_key? (\"level\")\n     courses_hash.store(\"shift\", api_hash.delete(\"shift\")) unless !api_hash.has_key? (\"shift\")\n+    courses_hash.store(\"subject_id\", api_hash.delete(\"subject_id\")) unless !api_hash.has_key? (\"subject_id\")","path":"back/app/controllers/concerns/offer_helper.rb","position":14,"original_position":14,"commit_id":"2615b093df6b3aa8c3f880754cc54b482476be82","original_commit_id":"2615b093df6b3aa8c3f880754cc54b482476be82","user":{"login":"ebert[bot]","id":23344435,"node_id":"MDM6Qm90MjMzNDQ0MzU=","avatar_url":"https://avatars3.githubusercontent.com/in/597?v=4","gravatar_id":"","url":"https://api.github.com/users/ebert%5Bbot%5D","html_url":"https://github.com/apps/ebert","followers_url":"https://api.github.com/users/ebert%5Bbot%5D/followers","following_url":"https://api.github.com/users/ebert%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/ebert%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/ebert%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebert%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/ebert%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/ebert%5Bbot%5D/repos","events_url":"https://api.github.com/users/ebert%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/ebert%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Prefer single-quoted strings when you don't need string interpolation or special symbols.\n\n[Read more about it here.](http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/StringLiterals)","created_at":"2018-06-25T21:51:31Z","updated_at":"2018-06-25T21:51:34Z","html_url":"https://github.com/redealumni/qb_hr_mobile/pull/4#discussion_r197953944","pull_request_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/redealumni/qb_hr_mobile/pulls/comments/197953944"},"html":{"href":"https://github.com/redealumni/qb_hr_mobile/pull/4#discussion_r197953944"},"pull_request":{"href":"https://api.github.com/repos/redealumni/qb_hr_mobile/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/redealumni/qb_hr_mobile/pulls/4","id":196916051,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTE2MDUx","html_url":"https://github.com/redealumni/qb_hr_mobile/pull/4","diff_url":"https://github.com/redealumni/qb_hr_mobile/pull/4.diff","patch_url":"https://github.com/redealumni/qb_hr_mobile/pull/4.patch","issue_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/issues/4","number":4,"state":"open","locked":false,"title":"Submission of the test requirements for job application","user":{"login":"LHSP","id":669994,"node_id":"MDQ6VXNlcjY2OTk5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/669994?v=4","gravatar_id":"","url":"https://api.github.com/users/LHSP","html_url":"https://github.com/LHSP","followers_url":"https://api.github.com/users/LHSP/followers","following_url":"https://api.github.com/users/LHSP/following{/other_user}","gists_url":"https://api.github.com/users/LHSP/gists{/gist_id}","starred_url":"https://api.github.com/users/LHSP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LHSP/subscriptions","organizations_url":"https://api.github.com/users/LHSP/orgs","repos_url":"https://api.github.com/users/LHSP/repos","events_url":"https://api.github.com/users/LHSP/events{/privacy}","received_events_url":"https://api.github.com/users/LHSP/received_events","type":"User","site_admin":false},"body":"### Changes\r\nDevelop the required scenes with all features requested and style them according to a layout of my own\r\n\r\n**Highlights**\r\n- Implements Infinite Scroll View for offer listing\r\n- Stores state between all scenes\r\n- Automatically reload offer listing when filters change\r\n- Beautiful layout :smiley: ","created_at":"2018-06-23T18:54:56Z","updated_at":"2018-06-25T21:51:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cac003bf0f2f331e161b86f9d327aeed2298313b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/pulls/4/commits","review_comments_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/pulls/4/comments","review_comment_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/issues/4/comments","statuses_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/statuses/2615b093df6b3aa8c3f880754cc54b482476be82","head":{"label":"LHSP:main","ref":"main","sha":"2615b093df6b3aa8c3f880754cc54b482476be82","user":{"login":"LHSP","id":669994,"node_id":"MDQ6VXNlcjY2OTk5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/669994?v=4","gravatar_id":"","url":"https://api.github.com/users/LHSP","html_url":"https://github.com/LHSP","followers_url":"https://api.github.com/users/LHSP/followers","following_url":"https://api.github.com/users/LHSP/following{/other_user}","gists_url":"https://api.github.com/users/LHSP/gists{/gist_id}","starred_url":"https://api.github.com/users/LHSP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LHSP/subscriptions","organizations_url":"https://api.github.com/users/LHSP/orgs","repos_url":"https://api.github.com/users/LHSP/repos","events_url":"https://api.github.com/users/LHSP/events{/privacy}","received_events_url":"https://api.github.com/users/LHSP/received_events","type":"User","site_admin":false},"repo":{"id":137391194,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczOTExOTQ=","name":"qb_hr_mobile","full_name":"LHSP/qb_hr_mobile","owner":{"login":"LHSP","id":669994,"node_id":"MDQ6VXNlcjY2OTk5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/669994?v=4","gravatar_id":"","url":"https://api.github.com/users/LHSP","html_url":"https://github.com/LHSP","followers_url":"https://api.github.com/users/LHSP/followers","following_url":"https://api.github.com/users/LHSP/following{/other_user}","gists_url":"https://api.github.com/users/LHSP/gists{/gist_id}","starred_url":"https://api.github.com/users/LHSP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LHSP/subscriptions","organizations_url":"https://api.github.com/users/LHSP/orgs","repos_url":"https://api.github.com/users/LHSP/repos","events_url":"https://api.github.com/users/LHSP/events{/privacy}","received_events_url":"https://api.github.com/users/LHSP/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LHSP/qb_hr_mobile","description":null,"fork":true,"url":"https://api.github.com/repos/LHSP/qb_hr_mobile","forks_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/forks","keys_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/teams","hooks_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/hooks","issue_events_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/issues/events{/number}","events_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/events","assignees_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/assignees{/user}","branches_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/branches{/branch}","tags_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/tags","blobs_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/languages","stargazers_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/stargazers","contributors_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/contributors","subscribers_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/subscribers","subscription_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/subscription","commits_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/contents/{+path}","compare_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/merges","archive_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/downloads","issues_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/issues{/number}","pulls_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/labels{/name}","releases_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/releases{/id}","deployments_url":"https://api.github.com/repos/LHSP/qb_hr_mobile/deployments","created_at":"2018-06-14T17:54:31Z","updated_at":"2018-06-23T18:46:19Z","pushed_at":"2018-06-23T18:46:18Z","git_url":"git://github.com/LHSP/qb_hr_mobile.git","ssh_url":"git@github.com:LHSP/qb_hr_mobile.git","clone_url":"https://github.com/LHSP/qb_hr_mobile.git","svn_url":"https://github.com/LHSP/qb_hr_mobile","homepage":null,"size":1291,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"main"}},"base":{"label":"redealumni:main","ref":"main","sha":"615df57538ab4c574dd5c9145d1e0646475a5483","user":{"login":"redealumni","id":178298,"node_id":"MDQ6VXNlcjE3ODI5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/178298?v=4","gravatar_id":"","url":"https://api.github.com/users/redealumni","html_url":"https://github.com/redealumni","followers_url":"https://api.github.com/users/redealumni/followers","following_url":"https://api.github.com/users/redealumni/following{/other_user}","gists_url":"https://api.github.com/users/redealumni/gists{/gist_id}","starred_url":"https://api.github.com/users/redealumni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redealumni/subscriptions","organizations_url":"https://api.github.com/users/redealumni/orgs","repos_url":"https://api.github.com/users/redealumni/repos","events_url":"https://api.github.com/users/redealumni/events{/privacy}","received_events_url":"https://api.github.com/users/redealumni/received_events","type":"User","site_admin":false},"repo":{"id":133876971,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM4NzY5NzE=","name":"qb_hr_mobile","full_name":"redealumni/qb_hr_mobile","owner":{"login":"redealumni","id":178298,"node_id":"MDQ6VXNlcjE3ODI5OA==","avatar_url":"https://avatars1.githubusercontent.com/u/178298?v=4","gravatar_id":"","url":"https://api.github.com/users/redealumni","html_url":"https://github.com/redealumni","followers_url":"https://api.github.com/users/redealumni/followers","following_url":"https://api.github.com/users/redealumni/following{/other_user}","gists_url":"https://api.github.com/users/redealumni/gists{/gist_id}","starred_url":"https://api.github.com/users/redealumni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redealumni/subscriptions","organizations_url":"https://api.github.com/users/redealumni/orgs","repos_url":"https://api.github.com/users/redealumni/repos","events_url":"https://api.github.com/users/redealumni/events{/privacy}","received_events_url":"https://api.github.com/users/redealumni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/redealumni/qb_hr_mobile","description":null,"fork":false,"url":"https://api.github.com/repos/redealumni/qb_hr_mobile","forks_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/forks","keys_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/teams","hooks_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/hooks","issue_events_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/issues/events{/number}","events_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/events","assignees_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/assignees{/user}","branches_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/branches{/branch}","tags_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/tags","blobs_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/languages","stargazers_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/stargazers","contributors_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/contributors","subscribers_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/subscribers","subscription_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/subscription","commits_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/contents/{+path}","compare_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/merges","archive_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/downloads","issues_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/issues{/number}","pulls_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/labels{/name}","releases_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/releases{/id}","deployments_url":"https://api.github.com/repos/redealumni/qb_hr_mobile/deployments","created_at":"2018-05-17T23:03:48Z","updated_at":"2018-05-26T02:08:00Z","pushed_at":"2018-06-25T18:36:09Z","git_url":"git://github.com/redealumni/qb_hr_mobile.git","ssh_url":"git@github.com:redealumni/qb_hr_mobile.git","clone_url":"https://github.com/redealumni/qb_hr_mobile.git","svn_url":"https://github.com/redealumni/qb_hr_mobile","homepage":null,"size":1224,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":6,"open_issues":3,"watchers":0,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/redealumni/qb_hr_mobile/pulls/4"},"html":{"href":"https://github.com/redealumni/qb_hr_mobile/pull/4"},"issue":{"href":"https://api.github.com/repos/redealumni/qb_hr_mobile/issues/4"},"comments":{"href":"https://api.github.com/repos/redealumni/qb_hr_mobile/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/redealumni/qb_hr_mobile/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/redealumni/qb_hr_mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redealumni/qb_hr_mobile/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/redealumni/qb_hr_mobile/statuses/2615b093df6b3aa8c3f880754cc54b482476be82"}},"author_association":"NONE"}}
{"actor":{"display_login":"ebert"}}