{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/242413428","pull_request_review_id":185914822,"id":242413428,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjQxMzQyOA==","diff_hunk":"@@ -688,6 +688,14 @@ void ConnectionManagerImpl::ActiveStream::decodeHeaders(HeaderMapPtr&& headers,\n \n   decodeHeaders(nullptr, *request_headers_, end_stream);\n \n+  if (Grpc::Common::hasGrpcContentType(*request_headers_) && stream_idle_timer_ != nullptr) {","path":"source/common/http/conn_manager_impl.cc","position":4,"original_position":4,"commit_id":"8341154393c22d019ce668351c1b2ba7ff1874ae","original_commit_id":"8341154393c22d019ce668351c1b2ba7ff1874ae","user":{"login":"ramaraochavali","id":17204904,"node_id":"MDQ6VXNlcjE3MjA0OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/17204904?v=4","gravatar_id":"","url":"https://api.github.com/users/ramaraochavali","html_url":"https://github.com/ramaraochavali","followers_url":"https://api.github.com/users/ramaraochavali/followers","following_url":"https://api.github.com/users/ramaraochavali/following{/other_user}","gists_url":"https://api.github.com/users/ramaraochavali/gists{/gist_id}","starred_url":"https://api.github.com/users/ramaraochavali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramaraochavali/subscriptions","organizations_url":"https://api.github.com/users/ramaraochavali/orgs","repos_url":"https://api.github.com/users/ramaraochavali/repos","events_url":"https://api.github.com/users/ramaraochavali/events{/privacy}","received_events_url":"https://api.github.com/users/ramaraochavali/received_events","type":"User","site_admin":false},"body":"I agree though that `idle timeout` and `max-grpc-timeout ` are fundamentally different. gRPC connectivity semantics seems to talk about idleness though https://github.com/grpc/grpc/blob/master/doc/connectivity-semantics-and-api.md?","created_at":"2018-12-18T05:50:17Z","updated_at":"2018-12-18T05:50:17Z","html_url":"https://github.com/envoyproxy/envoy/pull/5294#discussion_r242413428","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/5294","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/242413428"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/5294#discussion_r242413428"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/5294"}},"in_reply_to_id":241588642},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/5294","id":238551862,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTUxODYy","html_url":"https://github.com/envoyproxy/envoy/pull/5294","diff_url":"https://github.com/envoyproxy/envoy/pull/5294.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/5294.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/5294","number":5294,"state":"open","locked":false,"title":"conn_manager: Disable stream idle timeout for gRPC requests","user":{"login":"jrajahalme","id":6518235,"node_id":"MDQ6VXNlcjY1MTgyMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6518235?v=4","gravatar_id":"","url":"https://api.github.com/users/jrajahalme","html_url":"https://github.com/jrajahalme","followers_url":"https://api.github.com/users/jrajahalme/followers","following_url":"https://api.github.com/users/jrajahalme/following{/other_user}","gists_url":"https://api.github.com/users/jrajahalme/gists{/gist_id}","starred_url":"https://api.github.com/users/jrajahalme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrajahalme/subscriptions","organizations_url":"https://api.github.com/users/jrajahalme/orgs","repos_url":"https://api.github.com/users/jrajahalme/repos","events_url":"https://api.github.com/users/jrajahalme/events{/privacy}","received_events_url":"https://api.github.com/users/jrajahalme/received_events","type":"User","site_admin":false},"body":"gRPC requests are bounded by their 'grpc-timeout' header, which is\r\nbounded by 'max-grpc-timeout' configuration option. Stream idle\r\ntimeouts, if enabled, will interfere with these gRPC timeouts when the\r\ngRPC stream is idle for longer than the stream idle timeout\r\ntime. However, the expectation of a gRPC streaming client (and server)\r\nis that a gRPC stream is not timed out before the 'grpc-timeout' (as\r\nbounded by 'gax-grpc-timeout') even if the stream is idle.\r\n\r\nProvide the expected gRPC behavior by disabling the stream idle\r\ntimeout for streams that have a pending gRPC request. This allows same\r\nroutes be shared by both HTTP and gRPC requests, as an idle timeout\r\nmeaningful for HTTP can be configured without it affecting gRPC\r\ntraffic. A 'max-grpc-timeout' can be configured to control the upper\r\nlimit of gRPC requests at the same time on the same routes.\r\n\r\nRisk Level: Low\r\nTesting: HTTP/2 integration test amended to verify the new functionality.\r\nDocs Changes: None\r\nFixes: #5142 \r\n","created_at":"2018-12-13T22:22:52Z","updated_at":"2018-12-18T05:50:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a0f8181f26747ccb109e2e5274bea2f76827fa8","assignee":{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1115137091,"node_id":"MDU6TGFiZWwxMTE1MTM3MDkx","url":"https://api.github.com/repos/envoyproxy/envoy/labels/waiting","name":"waiting","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/5294/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/5294/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/5294/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/8341154393c22d019ce668351c1b2ba7ff1874ae","head":{"label":"jrajahalme:grpc-idle-timeout-fix","ref":"grpc-idle-timeout-fix","sha":"8341154393c22d019ce668351c1b2ba7ff1874ae","user":{"login":"jrajahalme","id":6518235,"node_id":"MDQ6VXNlcjY1MTgyMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6518235?v=4","gravatar_id":"","url":"https://api.github.com/users/jrajahalme","html_url":"https://github.com/jrajahalme","followers_url":"https://api.github.com/users/jrajahalme/followers","following_url":"https://api.github.com/users/jrajahalme/following{/other_user}","gists_url":"https://api.github.com/users/jrajahalme/gists{/gist_id}","starred_url":"https://api.github.com/users/jrajahalme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrajahalme/subscriptions","organizations_url":"https://api.github.com/users/jrajahalme/orgs","repos_url":"https://api.github.com/users/jrajahalme/repos","events_url":"https://api.github.com/users/jrajahalme/events{/privacy}","received_events_url":"https://api.github.com/users/jrajahalme/received_events","type":"User","site_admin":false},"repo":{"id":93890834,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzg5MDgzNA==","name":"envoy","full_name":"jrajahalme/envoy","private":false,"owner":{"login":"jrajahalme","id":6518235,"node_id":"MDQ6VXNlcjY1MTgyMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6518235?v=4","gravatar_id":"","url":"https://api.github.com/users/jrajahalme","html_url":"https://github.com/jrajahalme","followers_url":"https://api.github.com/users/jrajahalme/followers","following_url":"https://api.github.com/users/jrajahalme/following{/other_user}","gists_url":"https://api.github.com/users/jrajahalme/gists{/gist_id}","starred_url":"https://api.github.com/users/jrajahalme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrajahalme/subscriptions","organizations_url":"https://api.github.com/users/jrajahalme/orgs","repos_url":"https://api.github.com/users/jrajahalme/repos","events_url":"https://api.github.com/users/jrajahalme/events{/privacy}","received_events_url":"https://api.github.com/users/jrajahalme/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jrajahalme/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/jrajahalme/envoy","forks_url":"https://api.github.com/repos/jrajahalme/envoy/forks","keys_url":"https://api.github.com/repos/jrajahalme/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrajahalme/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrajahalme/envoy/teams","hooks_url":"https://api.github.com/repos/jrajahalme/envoy/hooks","issue_events_url":"https://api.github.com/repos/jrajahalme/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/jrajahalme/envoy/events","assignees_url":"https://api.github.com/repos/jrajahalme/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/jrajahalme/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/jrajahalme/envoy/tags","blobs_url":"https://api.github.com/repos/jrajahalme/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrajahalme/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrajahalme/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrajahalme/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrajahalme/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/jrajahalme/envoy/languages","stargazers_url":"https://api.github.com/repos/jrajahalme/envoy/stargazers","contributors_url":"https://api.github.com/repos/jrajahalme/envoy/contributors","subscribers_url":"https://api.github.com/repos/jrajahalme/envoy/subscribers","subscription_url":"https://api.github.com/repos/jrajahalme/envoy/subscription","commits_url":"https://api.github.com/repos/jrajahalme/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrajahalme/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrajahalme/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrajahalme/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrajahalme/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/jrajahalme/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrajahalme/envoy/merges","archive_url":"https://api.github.com/repos/jrajahalme/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrajahalme/envoy/downloads","issues_url":"https://api.github.com/repos/jrajahalme/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/jrajahalme/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/jrajahalme/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/jrajahalme/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrajahalme/envoy/labels{/name}","releases_url":"https://api.github.com/repos/jrajahalme/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/jrajahalme/envoy/deployments","created_at":"2017-06-09T19:31:57Z","updated_at":"2018-12-14T21:25:00Z","pushed_at":"2018-12-16T01:13:34Z","git_url":"git://github.com/jrajahalme/envoy.git","ssh_url":"git@github.com:jrajahalme/envoy.git","clone_url":"https://github.com/jrajahalme/envoy.git","svn_url":"https://github.com/jrajahalme/envoy","homepage":"https://lyft.github.io/envoy","size":44764,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"00663d89ae5e21c7348b18a9b529c30578d1d35a","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","private":false,"owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-12-18T04:04:58Z","pushed_at":"2018-12-18T05:43:25Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":25098,"stargazers_count":7615,"watchers_count":7615,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1090,"mirror_url":null,"archived":false,"open_issues_count":378,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1090,"open_issues":378,"watchers":7615,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/5294"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/5294"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/5294"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/5294/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/5294/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/5294/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/8341154393c22d019ce668351c1b2ba7ff1874ae"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ramaraochavali"}}