{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/remoting/issues/289","repository_url":"https://api.github.com/repos/jenkinsci/remoting","labels_url":"https://api.github.com/repos/jenkinsci/remoting/issues/289/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/remoting/issues/289/comments","events_url":"https://api.github.com/repos/jenkinsci/remoting/issues/289/events","html_url":"https://github.com/jenkinsci/remoting/pull/289","id":361847119,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NzE1NTAz","number":289,"title":"[JENKINS-53569] Remove unnecessary locking.","user":{"login":"jeffret-b","id":37345299,"node_id":"MDQ6VXNlcjM3MzQ1Mjk5","avatar_url":"https://avatars0.githubusercontent.com/u/37345299?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffret-b","html_url":"https://github.com/jeffret-b","followers_url":"https://api.github.com/users/jeffret-b/followers","following_url":"https://api.github.com/users/jeffret-b/following{/other_user}","gists_url":"https://api.github.com/users/jeffret-b/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffret-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffret-b/subscriptions","organizations_url":"https://api.github.com/users/jeffret-b/orgs","repos_url":"https://api.github.com/users/jeffret-b/repos","events_url":"https://api.github.com/users/jeffret-b/events{/privacy}","received_events_url":"https://api.github.com/users/jeffret-b/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-19T17:19:10Z","updated_at":"2018-09-24T17:40:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jenkinsci/remoting/pulls/289","html_url":"https://github.com/jenkinsci/remoting/pull/289","diff_url":"https://github.com/jenkinsci/remoting/pull/289.diff","patch_url":"https://github.com/jenkinsci/remoting/pull/289.patch"},"body":"See [JENKINS-53569](https://issues.jenkins-ci.org/browse/JENKINS-53569) for a description of the deadlock, including stack traces of the deadlocked threads.\r\n\r\nThere is no indication that this section of code constitutes a critical section. The only meaningful thing it does is atomic and is handled elsewhere in the code by good design. The extra checks serve no significant purpose.\r\n\r\nThe code in Filter that calls this grabs a lock on Filter before it calls this meaning that it already holds one lock. If another thread grabs the lock on ProtocolStack before the Filter than a thread is always possible. Locking occurs too frequently without a strategy for preventing deadlock.\r\n\r\nLocking is complex enough without abusing locks in weird ways.\r\n\r\n@reviewbybees "},"comment":{"url":"https://api.github.com/repos/jenkinsci/remoting/issues/comments/424061323","html_url":"https://github.com/jenkinsci/remoting/pull/289#issuecomment-424061323","issue_url":"https://api.github.com/repos/jenkinsci/remoting/issues/289","id":424061323,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDA2MTMyMw==","user":{"login":"jeffret-b","id":37345299,"node_id":"MDQ6VXNlcjM3MzQ1Mjk5","avatar_url":"https://avatars0.githubusercontent.com/u/37345299?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffret-b","html_url":"https://github.com/jeffret-b","followers_url":"https://api.github.com/users/jeffret-b/followers","following_url":"https://api.github.com/users/jeffret-b/following{/other_user}","gists_url":"https://api.github.com/users/jeffret-b/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffret-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffret-b/subscriptions","organizations_url":"https://api.github.com/users/jeffret-b/orgs","repos_url":"https://api.github.com/users/jeffret-b/repos","events_url":"https://api.github.com/users/jeffret-b/events{/privacy}","received_events_url":"https://api.github.com/users/jeffret-b/received_events","type":"User","site_admin":false},"created_at":"2018-09-24T17:40:12Z","updated_at":"2018-09-24T17:40:12Z","author_association":"CONTRIBUTOR","body":"@stephenc, do you have any further comments or concerns after I attached the testing results?"}}
{"actor":{"display_login":"jeffret-b"}}