{"action":"closed","number":60636,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60636","id":172197263,"html_url":"https://github.com/kubernetes/kubernetes/pull/60636","diff_url":"https://github.com/kubernetes/kubernetes/pull/60636.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/60636.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60636","number":60636,"state":"closed","locked":false,"title":"Allow env from resource with keys & updated tests","user":{"login":"PhilipGough","id":5781491,"avatar_url":"https://avatars1.githubusercontent.com/u/5781491?v=4","gravatar_id":"","url":"https://api.github.com/users/PhilipGough","html_url":"https://github.com/PhilipGough","followers_url":"https://api.github.com/users/PhilipGough/followers","following_url":"https://api.github.com/users/PhilipGough/following{/other_user}","gists_url":"https://api.github.com/users/PhilipGough/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilipGough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilipGough/subscriptions","organizations_url":"https://api.github.com/users/PhilipGough/orgs","repos_url":"https://api.github.com/users/PhilipGough/repos","events_url":"https://api.github.com/users/PhilipGough/events{/privacy}","received_events_url":"https://api.github.com/users/PhilipGough/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nThis change allows users to pull environment from specific keys in secrets and configmaps using the `kubectl set env` command. User can provide a list of comma-separated keys with the `--keys` flag.\r\n\r\nThis can be useful when a number of applications want to share a configuration object but don't want to pollute a resource with unused environment\r\n\r\nImproves test coverage of set env command\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```\r\nAllow kubectl set env to specify which keys to import from a resource\r\n```\r\n","created_at":"2018-03-01T10:28:48Z","updated_at":"2018-05-23T22:51:02Z","closed_at":"2018-05-23T22:51:01Z","merged_at":"2018-05-23T22:51:01Z","merge_commit_sha":"420071d86e0e1b9ea06c9be31cfcd5489d7c29c7","assignee":{"login":"soltysh","id":576341,"avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"assignees":[{"login":"soltysh","id":576341,"avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":267761362,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":496752236,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-longterm","name":"priority/important-longterm","color":"eb6420","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":450823910,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cli","name":"sig/cli","color":"d2b48c","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false},{"id":611767149,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/status/approved-for-milestone","name":"status/approved-for-milestone","color":"fef2c0","default":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/38","html_url":"https://github.com/kubernetes/kubernetes/milestone/38","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/38/labels","id":2848396,"number":38,"title":"v1.11","description":null,"creator":{"login":"mtaufen","id":903617,"avatar_url":"https://avatars1.githubusercontent.com/u/903617?v=4","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":121,"state":"open","created_at":"2017-10-18T17:24:38Z","updated_at":"2018-05-23T22:51:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60636/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60636/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60636/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/027d15e58c05059cf1e6fdbf202b95b9f962ae2c","head":{"label":"PhilipGough:keys-from-cm-patch","ref":"keys-from-cm-patch","sha":"027d15e58c05059cf1e6fdbf202b95b9f962ae2c","user":{"login":"PhilipGough","id":5781491,"avatar_url":"https://avatars1.githubusercontent.com/u/5781491?v=4","gravatar_id":"","url":"https://api.github.com/users/PhilipGough","html_url":"https://github.com/PhilipGough","followers_url":"https://api.github.com/users/PhilipGough/followers","following_url":"https://api.github.com/users/PhilipGough/following{/other_user}","gists_url":"https://api.github.com/users/PhilipGough/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilipGough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilipGough/subscriptions","organizations_url":"https://api.github.com/users/PhilipGough/orgs","repos_url":"https://api.github.com/users/PhilipGough/repos","events_url":"https://api.github.com/users/PhilipGough/events{/privacy}","received_events_url":"https://api.github.com/users/PhilipGough/received_events","type":"User","site_admin":false},"repo":{"id":122052515,"name":"kubernetes","full_name":"PhilipGough/kubernetes","owner":{"login":"PhilipGough","id":5781491,"avatar_url":"https://avatars1.githubusercontent.com/u/5781491?v=4","gravatar_id":"","url":"https://api.github.com/users/PhilipGough","html_url":"https://github.com/PhilipGough","followers_url":"https://api.github.com/users/PhilipGough/followers","following_url":"https://api.github.com/users/PhilipGough/following{/other_user}","gists_url":"https://api.github.com/users/PhilipGough/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilipGough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilipGough/subscriptions","organizations_url":"https://api.github.com/users/PhilipGough/orgs","repos_url":"https://api.github.com/users/PhilipGough/repos","events_url":"https://api.github.com/users/PhilipGough/events{/privacy}","received_events_url":"https://api.github.com/users/PhilipGough/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PhilipGough/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/PhilipGough/kubernetes","forks_url":"https://api.github.com/repos/PhilipGough/kubernetes/forks","keys_url":"https://api.github.com/repos/PhilipGough/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PhilipGough/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PhilipGough/kubernetes/teams","hooks_url":"https://api.github.com/repos/PhilipGough/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/PhilipGough/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/PhilipGough/kubernetes/events","assignees_url":"https://api.github.com/repos/PhilipGough/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/PhilipGough/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/PhilipGough/kubernetes/tags","blobs_url":"https://api.github.com/repos/PhilipGough/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PhilipGough/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PhilipGough/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/PhilipGough/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PhilipGough/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/PhilipGough/kubernetes/languages","stargazers_url":"https://api.github.com/repos/PhilipGough/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/PhilipGough/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/PhilipGough/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/PhilipGough/kubernetes/subscription","commits_url":"https://api.github.com/repos/PhilipGough/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/PhilipGough/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/PhilipGough/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/PhilipGough/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/PhilipGough/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/PhilipGough/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PhilipGough/kubernetes/merges","archive_url":"https://api.github.com/repos/PhilipGough/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PhilipGough/kubernetes/downloads","issues_url":"https://api.github.com/repos/PhilipGough/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/PhilipGough/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/PhilipGough/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/PhilipGough/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PhilipGough/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/PhilipGough/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/PhilipGough/kubernetes/deployments","created_at":"2018-02-19T11:21:22Z","updated_at":"2018-02-19T11:21:59Z","pushed_at":"2018-05-22T08:05:22Z","git_url":"git://github.com/PhilipGough/kubernetes.git","ssh_url":"git@github.com:PhilipGough/kubernetes.git","clone_url":"https://github.com/PhilipGough/kubernetes.git","svn_url":"https://github.com/PhilipGough/kubernetes","homepage":"http://kubernetes.io","size":559177,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a0036fcae173f299ffcb6038f9878ffe7ee1a51f","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-05-23T21:36:06Z","pushed_at":"2018-05-23T22:51:01Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":780117,"stargazers_count":36682,"watchers_count":36682,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12903,"mirror_url":null,"archived":false,"open_issues_count":3258,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12903,"open_issues":3258,"watchers":36682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60636"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/60636"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/60636"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/60636/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60636/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/60636/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/027d15e58c05059cf1e6fdbf202b95b9f962ae2c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars0.githubusercontent.com/u/13653959?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"comments":25,"review_comments":31,"maintainer_can_modify":false,"commits":1,"additions":203,"deletions":21,"changed_files":3}}
{"actor":{"display_login":"k8s-merge-robot"}}