{"action":"opened","number":980,"pull_request":{"url":"https://api.github.com/repos/trufflesuite/truffle/pulls/980","id":192287367,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjg3MzY3","html_url":"https://github.com/trufflesuite/truffle/pull/980","diff_url":"https://github.com/trufflesuite/truffle/pull/980.diff","patch_url":"https://github.com/trufflesuite/truffle/pull/980.patch","issue_url":"https://api.github.com/repos/trufflesuite/truffle/issues/980","number":980,"state":"open","locked":false,"title":"Defining constructors as functions with the same name as the contract is deprecated.","user":{"login":"noelyoo","id":25740248,"node_id":"MDQ6VXNlcjI1NzQwMjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/25740248?v=4","gravatar_id":"","url":"https://api.github.com/users/noelyoo","html_url":"https://github.com/noelyoo","followers_url":"https://api.github.com/users/noelyoo/followers","following_url":"https://api.github.com/users/noelyoo/following{/other_user}","gists_url":"https://api.github.com/users/noelyoo/gists{/gist_id}","starred_url":"https://api.github.com/users/noelyoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noelyoo/subscriptions","organizations_url":"https://api.github.com/users/noelyoo/orgs","repos_url":"https://api.github.com/users/noelyoo/repos","events_url":"https://api.github.com/users/noelyoo/events{/privacy}","received_events_url":"https://api.github.com/users/noelyoo/received_events","type":"User","site_admin":false},"body":"## Expected Behavior\r\nyou compile with truffle successfully\r\n\r\n## Actual Behavior\r\nWhen you compile with truffle, this compilation warning encountered:\r\n```\r\n/Users/noel/petshop/contracts/Migrations.sol:11:3: Warning: Defining constructors as functions with the same name as the contract is deprecated. Use \"constructor(...) { ... }\" instead.\r\n  function Migrations() public {\r\n  ^ (Relevant source part starts here and spans across multiple lines).\r\n\r\n```\r\n## Steps to Reproduce the Problem\r\n1. unbox pet-shop with truffle\r\n2. run `truffle compile`\r\n3. get warning in Migrations.sol\r\n","created_at":"2018-06-04T03:03:01Z","updated_at":"2018-06-04T03:03:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/trufflesuite/truffle/pulls/980/commits","review_comments_url":"https://api.github.com/repos/trufflesuite/truffle/pulls/980/comments","review_comment_url":"https://api.github.com/repos/trufflesuite/truffle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trufflesuite/truffle/issues/980/comments","statuses_url":"https://api.github.com/repos/trufflesuite/truffle/statuses/4b614399f77194e356c9796fcfe260df3ffba0d9","head":{"label":"noelyoo:develop","ref":"develop","sha":"4b614399f77194e356c9796fcfe260df3ffba0d9","user":{"login":"noelyoo","id":25740248,"node_id":"MDQ6VXNlcjI1NzQwMjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/25740248?v=4","gravatar_id":"","url":"https://api.github.com/users/noelyoo","html_url":"https://github.com/noelyoo","followers_url":"https://api.github.com/users/noelyoo/followers","following_url":"https://api.github.com/users/noelyoo/following{/other_user}","gists_url":"https://api.github.com/users/noelyoo/gists{/gist_id}","starred_url":"https://api.github.com/users/noelyoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noelyoo/subscriptions","organizations_url":"https://api.github.com/users/noelyoo/orgs","repos_url":"https://api.github.com/users/noelyoo/repos","events_url":"https://api.github.com/users/noelyoo/events{/privacy}","received_events_url":"https://api.github.com/users/noelyoo/received_events","type":"User","site_admin":false},"repo":{"id":131334358,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEzMzQzNTg=","name":"truffle","full_name":"noelyoo/truffle","owner":{"login":"noelyoo","id":25740248,"node_id":"MDQ6VXNlcjI1NzQwMjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/25740248?v=4","gravatar_id":"","url":"https://api.github.com/users/noelyoo","html_url":"https://github.com/noelyoo","followers_url":"https://api.github.com/users/noelyoo/followers","following_url":"https://api.github.com/users/noelyoo/following{/other_user}","gists_url":"https://api.github.com/users/noelyoo/gists{/gist_id}","starred_url":"https://api.github.com/users/noelyoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noelyoo/subscriptions","organizations_url":"https://api.github.com/users/noelyoo/orgs","repos_url":"https://api.github.com/users/noelyoo/repos","events_url":"https://api.github.com/users/noelyoo/events{/privacy}","received_events_url":"https://api.github.com/users/noelyoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/noelyoo/truffle","description":"The most popular Ethereum development framework","fork":true,"url":"https://api.github.com/repos/noelyoo/truffle","forks_url":"https://api.github.com/repos/noelyoo/truffle/forks","keys_url":"https://api.github.com/repos/noelyoo/truffle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noelyoo/truffle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noelyoo/truffle/teams","hooks_url":"https://api.github.com/repos/noelyoo/truffle/hooks","issue_events_url":"https://api.github.com/repos/noelyoo/truffle/issues/events{/number}","events_url":"https://api.github.com/repos/noelyoo/truffle/events","assignees_url":"https://api.github.com/repos/noelyoo/truffle/assignees{/user}","branches_url":"https://api.github.com/repos/noelyoo/truffle/branches{/branch}","tags_url":"https://api.github.com/repos/noelyoo/truffle/tags","blobs_url":"https://api.github.com/repos/noelyoo/truffle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noelyoo/truffle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noelyoo/truffle/git/refs{/sha}","trees_url":"https://api.github.com/repos/noelyoo/truffle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noelyoo/truffle/statuses/{sha}","languages_url":"https://api.github.com/repos/noelyoo/truffle/languages","stargazers_url":"https://api.github.com/repos/noelyoo/truffle/stargazers","contributors_url":"https://api.github.com/repos/noelyoo/truffle/contributors","subscribers_url":"https://api.github.com/repos/noelyoo/truffle/subscribers","subscription_url":"https://api.github.com/repos/noelyoo/truffle/subscription","commits_url":"https://api.github.com/repos/noelyoo/truffle/commits{/sha}","git_commits_url":"https://api.github.com/repos/noelyoo/truffle/git/commits{/sha}","comments_url":"https://api.github.com/repos/noelyoo/truffle/comments{/number}","issue_comment_url":"https://api.github.com/repos/noelyoo/truffle/issues/comments{/number}","contents_url":"https://api.github.com/repos/noelyoo/truffle/contents/{+path}","compare_url":"https://api.github.com/repos/noelyoo/truffle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noelyoo/truffle/merges","archive_url":"https://api.github.com/repos/noelyoo/truffle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noelyoo/truffle/downloads","issues_url":"https://api.github.com/repos/noelyoo/truffle/issues{/number}","pulls_url":"https://api.github.com/repos/noelyoo/truffle/pulls{/number}","milestones_url":"https://api.github.com/repos/noelyoo/truffle/milestones{/number}","notifications_url":"https://api.github.com/repos/noelyoo/truffle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noelyoo/truffle/labels{/name}","releases_url":"https://api.github.com/repos/noelyoo/truffle/releases{/id}","deployments_url":"https://api.github.com/repos/noelyoo/truffle/deployments","created_at":"2018-04-27T18:57:07Z","updated_at":"2018-06-04T02:53:22Z","pushed_at":"2018-06-04T02:53:21Z","git_url":"git://github.com/noelyoo/truffle.git","ssh_url":"git@github.com:noelyoo/truffle.git","clone_url":"https://github.com/noelyoo/truffle.git","svn_url":"https://github.com/noelyoo/truffle","homepage":"http://truffleframework.com","size":43945,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"trufflesuite:develop","ref":"develop","sha":"2d722ce8df62271aece9dd3f652489d50c5f7b4b","user":{"login":"trufflesuite","id":22205159,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjA1MTU5","avatar_url":"https://avatars1.githubusercontent.com/u/22205159?v=4","gravatar_id":"","url":"https://api.github.com/users/trufflesuite","html_url":"https://github.com/trufflesuite","followers_url":"https://api.github.com/users/trufflesuite/followers","following_url":"https://api.github.com/users/trufflesuite/following{/other_user}","gists_url":"https://api.github.com/users/trufflesuite/gists{/gist_id}","starred_url":"https://api.github.com/users/trufflesuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trufflesuite/subscriptions","organizations_url":"https://api.github.com/users/trufflesuite/orgs","repos_url":"https://api.github.com/users/trufflesuite/repos","events_url":"https://api.github.com/users/trufflesuite/events{/privacy}","received_events_url":"https://api.github.com/users/trufflesuite/received_events","type":"Organization","site_admin":false},"repo":{"id":38267641,"node_id":"MDEwOlJlcG9zaXRvcnkzODI2NzY0MQ==","name":"truffle","full_name":"trufflesuite/truffle","owner":{"login":"trufflesuite","id":22205159,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjA1MTU5","avatar_url":"https://avatars1.githubusercontent.com/u/22205159?v=4","gravatar_id":"","url":"https://api.github.com/users/trufflesuite","html_url":"https://github.com/trufflesuite","followers_url":"https://api.github.com/users/trufflesuite/followers","following_url":"https://api.github.com/users/trufflesuite/following{/other_user}","gists_url":"https://api.github.com/users/trufflesuite/gists{/gist_id}","starred_url":"https://api.github.com/users/trufflesuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trufflesuite/subscriptions","organizations_url":"https://api.github.com/users/trufflesuite/orgs","repos_url":"https://api.github.com/users/trufflesuite/repos","events_url":"https://api.github.com/users/trufflesuite/events{/privacy}","received_events_url":"https://api.github.com/users/trufflesuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trufflesuite/truffle","description":"The most popular Ethereum development framework","fork":false,"url":"https://api.github.com/repos/trufflesuite/truffle","forks_url":"https://api.github.com/repos/trufflesuite/truffle/forks","keys_url":"https://api.github.com/repos/trufflesuite/truffle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trufflesuite/truffle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trufflesuite/truffle/teams","hooks_url":"https://api.github.com/repos/trufflesuite/truffle/hooks","issue_events_url":"https://api.github.com/repos/trufflesuite/truffle/issues/events{/number}","events_url":"https://api.github.com/repos/trufflesuite/truffle/events","assignees_url":"https://api.github.com/repos/trufflesuite/truffle/assignees{/user}","branches_url":"https://api.github.com/repos/trufflesuite/truffle/branches{/branch}","tags_url":"https://api.github.com/repos/trufflesuite/truffle/tags","blobs_url":"https://api.github.com/repos/trufflesuite/truffle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trufflesuite/truffle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trufflesuite/truffle/git/refs{/sha}","trees_url":"https://api.github.com/repos/trufflesuite/truffle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trufflesuite/truffle/statuses/{sha}","languages_url":"https://api.github.com/repos/trufflesuite/truffle/languages","stargazers_url":"https://api.github.com/repos/trufflesuite/truffle/stargazers","contributors_url":"https://api.github.com/repos/trufflesuite/truffle/contributors","subscribers_url":"https://api.github.com/repos/trufflesuite/truffle/subscribers","subscription_url":"https://api.github.com/repos/trufflesuite/truffle/subscription","commits_url":"https://api.github.com/repos/trufflesuite/truffle/commits{/sha}","git_commits_url":"https://api.github.com/repos/trufflesuite/truffle/git/commits{/sha}","comments_url":"https://api.github.com/repos/trufflesuite/truffle/comments{/number}","issue_comment_url":"https://api.github.com/repos/trufflesuite/truffle/issues/comments{/number}","contents_url":"https://api.github.com/repos/trufflesuite/truffle/contents/{+path}","compare_url":"https://api.github.com/repos/trufflesuite/truffle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trufflesuite/truffle/merges","archive_url":"https://api.github.com/repos/trufflesuite/truffle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trufflesuite/truffle/downloads","issues_url":"https://api.github.com/repos/trufflesuite/truffle/issues{/number}","pulls_url":"https://api.github.com/repos/trufflesuite/truffle/pulls{/number}","milestones_url":"https://api.github.com/repos/trufflesuite/truffle/milestones{/number}","notifications_url":"https://api.github.com/repos/trufflesuite/truffle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trufflesuite/truffle/labels{/name}","releases_url":"https://api.github.com/repos/trufflesuite/truffle/releases{/id}","deployments_url":"https://api.github.com/repos/trufflesuite/truffle/deployments","created_at":"2015-06-29T19:46:53Z","updated_at":"2018-06-04T02:53:09Z","pushed_at":"2018-05-30T00:27:03Z","git_url":"git://github.com/trufflesuite/truffle.git","ssh_url":"git@github.com:trufflesuite/truffle.git","clone_url":"https://github.com/trufflesuite/truffle.git","svn_url":"https://github.com/trufflesuite/truffle","homepage":"http://truffleframework.com","size":50075,"stargazers_count":6092,"watchers_count":6092,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":767,"mirror_url":null,"archived":false,"open_issues_count":166,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":767,"open_issues":166,"watchers":6092,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/trufflesuite/truffle/pulls/980"},"html":{"href":"https://github.com/trufflesuite/truffle/pull/980"},"issue":{"href":"https://api.github.com/repos/trufflesuite/truffle/issues/980"},"comments":{"href":"https://api.github.com/repos/trufflesuite/truffle/issues/980/comments"},"review_comments":{"href":"https://api.github.com/repos/trufflesuite/truffle/pulls/980/comments"},"review_comment":{"href":"https://api.github.com/repos/trufflesuite/truffle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trufflesuite/truffle/pulls/980/commits"},"statuses":{"href":"https://api.github.com/repos/trufflesuite/truffle/statuses/4b614399f77194e356c9796fcfe260df3ffba0d9"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"noelyoo"}}