{"action":"created","comment":{"url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments/221474764","pull_request_review_id":160129952,"id":221474764,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTQ3NDc2NA==","diff_hunk":"@@ -352,7 +352,7 @@ const CaptionsRenderer = function (viewModel) {\n     function loadWebVttPolyfill() {\n         return require.ensure(['polyfills/webvtt'], function (require) {\n             _WebVTT = require('polyfills/webvtt').default;\n-        }, chunkLoadErrorHandler(121), 'polyfills.webvtt');","path":"src/js/view/captionsrenderer.js","position":24,"original_position":24,"commit_id":"3c46088a81214e9564ec811f27dfb86b7a6818f6","original_commit_id":"3c46088a81214e9564ec811f27dfb86b7a6818f6","user":{"login":"dannyfinks","id":9535273,"node_id":"MDQ6VXNlcjk1MzUyNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/9535273?v=4","gravatar_id":"","url":"https://api.github.com/users/dannyfinks","html_url":"https://github.com/dannyfinks","followers_url":"https://api.github.com/users/dannyfinks/followers","following_url":"https://api.github.com/users/dannyfinks/following{/other_user}","gists_url":"https://api.github.com/users/dannyfinks/gists{/gist_id}","starred_url":"https://api.github.com/users/dannyfinks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannyfinks/subscriptions","organizations_url":"https://api.github.com/users/dannyfinks/orgs","repos_url":"https://api.github.com/users/dannyfinks/repos","events_url":"https://api.github.com/users/dannyfinks/events{/privacy}","received_events_url":"https://api.github.com/users/dannyfinks/received_events","type":"User","site_admin":false},"body":"@johnBartos @robwalch 2 things to address here.\r\n1. In our Error List/Jira ticket we have set the code 301121 for vttparser.js and 301131 for polyfills.webvtt.js - considering this code used to be \"121\" this must have been a mistake and we should just update our documentation.\r\n2. Need to fix the code here from 300 to 301","created_at":"2018-09-30T21:50:43Z","updated_at":"2018-09-30T21:50:47Z","html_url":"https://github.com/jwplayer/jwplayer/pull/3067#discussion_r221474764","pull_request_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/3067","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments/221474764"},"html":{"href":"https://github.com/jwplayer/jwplayer/pull/3067#discussion_r221474764"},"pull_request":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/3067"}}},"pull_request":{"url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/3067","id":216092208,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MDkyMjA4","html_url":"https://github.com/jwplayer/jwplayer/pull/3067","diff_url":"https://github.com/jwplayer/jwplayer/pull/3067.diff","patch_url":"https://github.com/jwplayer/jwplayer/pull/3067.patch","issue_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/3067","number":3067,"state":"closed","locked":false,"title":"Implement standardized warnings","user":{"login":"johnBartos","id":5042276,"node_id":"MDQ6VXNlcjUwNDIyNzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5042276?v=4","gravatar_id":"","url":"https://api.github.com/users/johnBartos","html_url":"https://github.com/johnBartos","followers_url":"https://api.github.com/users/johnBartos/followers","following_url":"https://api.github.com/users/johnBartos/following{/other_user}","gists_url":"https://api.github.com/users/johnBartos/gists{/gist_id}","starred_url":"https://api.github.com/users/johnBartos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnBartos/subscriptions","organizations_url":"https://api.github.com/users/johnBartos/orgs","repos_url":"https://api.github.com/users/johnBartos/repos","events_url":"https://api.github.com/users/johnBartos/events{/privacy}","received_events_url":"https://api.github.com/users/johnBartos/received_events","type":"User","site_admin":false},"body":"### This PR will...\r\n- Convert non-fatal plugin load errors to warnings\r\n- Convert non-fatal webpack component load errors to warnings\r\n- Convert captions errors to warnings (no caption error is fatal)\r\n- Refactor Setup to return a `setupResult` object, which contains warnings thrown during setup\r\n- Emit and `console.warn` warnings found in `setupResult` *before* ready\r\n\r\n### Why is this Pull Request needed?\r\n\r\nSo that errors can be tracked; and be consumed by developers via the new `WARNING` event\r\n\r\n### Are there any points in the code the reviewer needs to double check?\r\nDo the codes & keys make sense? Did I miss any existing logs or errors which could be warnings? Do I need to localize the warnings messages?\r\n\r\n### Are there any Pull Requests open in other repos which need to be merged with this?\r\nhttps://github.com/jwplayer/jwplayer-commercial/pull/5709\r\n\r\n#### Addresses Issue(s):\r\n\r\nJW8-1504\r\n\r\n","created_at":"2018-09-17T19:41:10Z","updated_at":"2018-09-30T21:50:47Z","closed_at":"2018-09-26T16:37:53Z","merged_at":"2018-09-26T16:37:53Z","merge_commit_sha":"ea628736140633698a1cda6077b8fbb14dfda55c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/jwplayer/jwplayer/milestones/101","html_url":"https://github.com/jwplayer/jwplayer/milestone/101","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones/101/labels","id":3562667,"node_id":"MDk6TWlsZXN0b25lMzU2MjY2Nw==","number":101,"title":"v8.6.0","description":"","creator":{"login":"robwalch","id":333258,"node_id":"MDQ6VXNlcjMzMzI1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/333258?v=4","gravatar_id":"","url":"https://api.github.com/users/robwalch","html_url":"https://github.com/robwalch","followers_url":"https://api.github.com/users/robwalch/followers","following_url":"https://api.github.com/users/robwalch/following{/other_user}","gists_url":"https://api.github.com/users/robwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/robwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robwalch/subscriptions","organizations_url":"https://api.github.com/users/robwalch/orgs","repos_url":"https://api.github.com/users/robwalch/repos","events_url":"https://api.github.com/users/robwalch/events{/privacy}","received_events_url":"https://api.github.com/users/robwalch/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":23,"state":"open","created_at":"2018-08-11T18:49:57Z","updated_at":"2018-09-30T16:59:05Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/3067/commits","review_comments_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/3067/comments","review_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/3067/comments","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/3c46088a81214e9564ec811f27dfb86b7a6818f6","head":{"label":"jwplayer:feature/standard-warnings","ref":"feature/standard-warnings","sha":"3c46088a81214e9564ec811f27dfb86b7a6818f6","user":{"login":"jwplayer","id":5090060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwOTAwNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"repo":{"id":18307175,"node_id":"MDEwOlJlcG9zaXRvcnkxODMwNzE3NQ==","name":"jwplayer","full_name":"jwplayer/jwplayer","private":false,"owner":{"login":"jwplayer","id":5090060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwOTAwNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jwplayer/jwplayer","description":"JW Player is the world's most popular embeddable media player.","fork":false,"url":"https://api.github.com/repos/jwplayer/jwplayer","forks_url":"https://api.github.com/repos/jwplayer/jwplayer/forks","keys_url":"https://api.github.com/repos/jwplayer/jwplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwplayer/jwplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwplayer/jwplayer/teams","hooks_url":"https://api.github.com/repos/jwplayer/jwplayer/hooks","issue_events_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/events{/number}","events_url":"https://api.github.com/repos/jwplayer/jwplayer/events","assignees_url":"https://api.github.com/repos/jwplayer/jwplayer/assignees{/user}","branches_url":"https://api.github.com/repos/jwplayer/jwplayer/branches{/branch}","tags_url":"https://api.github.com/repos/jwplayer/jwplayer/tags","blobs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwplayer/jwplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwplayer/jwplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/jwplayer/jwplayer/languages","stargazers_url":"https://api.github.com/repos/jwplayer/jwplayer/stargazers","contributors_url":"https://api.github.com/repos/jwplayer/jwplayer/contributors","subscribers_url":"https://api.github.com/repos/jwplayer/jwplayer/subscribers","subscription_url":"https://api.github.com/repos/jwplayer/jwplayer/subscription","commits_url":"https://api.github.com/repos/jwplayer/jwplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwplayer/jwplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwplayer/jwplayer/contents/{+path}","compare_url":"https://api.github.com/repos/jwplayer/jwplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwplayer/jwplayer/merges","archive_url":"https://api.github.com/repos/jwplayer/jwplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwplayer/jwplayer/downloads","issues_url":"https://api.github.com/repos/jwplayer/jwplayer/issues{/number}","pulls_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/jwplayer/jwplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/labels{/name}","releases_url":"https://api.github.com/repos/jwplayer/jwplayer/releases{/id}","deployments_url":"https://api.github.com/repos/jwplayer/jwplayer/deployments","created_at":"2014-03-31T20:34:20Z","updated_at":"2018-09-28T20:33:14Z","pushed_at":"2018-09-30T16:59:05Z","git_url":"git://github.com/jwplayer/jwplayer.git","ssh_url":"git@github.com:jwplayer/jwplayer.git","clone_url":"https://github.com/jwplayer/jwplayer.git","svn_url":"https://github.com/jwplayer/jwplayer","homepage":"https://developer.jwplayer.com/","size":86570,"stargazers_count":1726,"watchers_count":1726,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":770,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":770,"open_issues":106,"watchers":1726,"default_branch":"master"}},"base":{"label":"jwplayer:master","ref":"master","sha":"be02f2d34ad4e1961429b4b115a5892822669ed0","user":{"login":"jwplayer","id":5090060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwOTAwNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"repo":{"id":18307175,"node_id":"MDEwOlJlcG9zaXRvcnkxODMwNzE3NQ==","name":"jwplayer","full_name":"jwplayer/jwplayer","private":false,"owner":{"login":"jwplayer","id":5090060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwOTAwNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jwplayer/jwplayer","description":"JW Player is the world's most popular embeddable media player.","fork":false,"url":"https://api.github.com/repos/jwplayer/jwplayer","forks_url":"https://api.github.com/repos/jwplayer/jwplayer/forks","keys_url":"https://api.github.com/repos/jwplayer/jwplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwplayer/jwplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwplayer/jwplayer/teams","hooks_url":"https://api.github.com/repos/jwplayer/jwplayer/hooks","issue_events_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/events{/number}","events_url":"https://api.github.com/repos/jwplayer/jwplayer/events","assignees_url":"https://api.github.com/repos/jwplayer/jwplayer/assignees{/user}","branches_url":"https://api.github.com/repos/jwplayer/jwplayer/branches{/branch}","tags_url":"https://api.github.com/repos/jwplayer/jwplayer/tags","blobs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwplayer/jwplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwplayer/jwplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/jwplayer/jwplayer/languages","stargazers_url":"https://api.github.com/repos/jwplayer/jwplayer/stargazers","contributors_url":"https://api.github.com/repos/jwplayer/jwplayer/contributors","subscribers_url":"https://api.github.com/repos/jwplayer/jwplayer/subscribers","subscription_url":"https://api.github.com/repos/jwplayer/jwplayer/subscription","commits_url":"https://api.github.com/repos/jwplayer/jwplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwplayer/jwplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwplayer/jwplayer/contents/{+path}","compare_url":"https://api.github.com/repos/jwplayer/jwplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwplayer/jwplayer/merges","archive_url":"https://api.github.com/repos/jwplayer/jwplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwplayer/jwplayer/downloads","issues_url":"https://api.github.com/repos/jwplayer/jwplayer/issues{/number}","pulls_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/jwplayer/jwplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/labels{/name}","releases_url":"https://api.github.com/repos/jwplayer/jwplayer/releases{/id}","deployments_url":"https://api.github.com/repos/jwplayer/jwplayer/deployments","created_at":"2014-03-31T20:34:20Z","updated_at":"2018-09-28T20:33:14Z","pushed_at":"2018-09-30T16:59:05Z","git_url":"git://github.com/jwplayer/jwplayer.git","ssh_url":"git@github.com:jwplayer/jwplayer.git","clone_url":"https://github.com/jwplayer/jwplayer.git","svn_url":"https://github.com/jwplayer/jwplayer","homepage":"https://developer.jwplayer.com/","size":86570,"stargazers_count":1726,"watchers_count":1726,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":770,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":770,"open_issues":106,"watchers":1726,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/3067"},"html":{"href":"https://github.com/jwplayer/jwplayer/pull/3067"},"issue":{"href":"https://api.github.com/repos/jwplayer/jwplayer/issues/3067"},"comments":{"href":"https://api.github.com/repos/jwplayer/jwplayer/issues/3067/comments"},"review_comments":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/3067/comments"},"review_comment":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/3067/commits"},"statuses":{"href":"https://api.github.com/repos/jwplayer/jwplayer/statuses/3c46088a81214e9564ec811f27dfb86b7a6818f6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dannyfinks"}}