{"action":"created","comment":{"url":"https://api.github.com/repos/discourse/discourse/pulls/comments/221884758","pull_request_review_id":160638714,"id":221884758,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTg4NDc1OA==","diff_hunk":"@@ -0,0 +1,17 @@\n+(function() {\n+  const authenticationData = JSON.parse(\n+    document.getElementById(\"data-authentication\").dataset.authenticationData\n+  );\n+\n+  Discourse.showingSignup = true;\n+  require(\"discourse/routes/application\").default.reopen({\n+    actions: {\n+      didTransition: function() {\n+        Em.run.next(function() {\n+          Discourse.authenticationComplete(authenticationData);","path":"app/assets/javascripts/authentication-complete.js","position":11,"original_position":11,"commit_id":"49830efd4d0fa3de511abe59c9b90626abec23f3","original_commit_id":"49830efd4d0fa3de511abe59c9b90626abec23f3","user":{"login":"xrav3nz","id":6376558,"node_id":"MDQ6VXNlcjYzNzY1NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6376558?v=4","gravatar_id":"","url":"https://api.github.com/users/xrav3nz","html_url":"https://github.com/xrav3nz","followers_url":"https://api.github.com/users/xrav3nz/followers","following_url":"https://api.github.com/users/xrav3nz/following{/other_user}","gists_url":"https://api.github.com/users/xrav3nz/gists{/gist_id}","starred_url":"https://api.github.com/users/xrav3nz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrav3nz/subscriptions","organizations_url":"https://api.github.com/users/xrav3nz/orgs","repos_url":"https://api.github.com/users/xrav3nz/repos","events_url":"https://api.github.com/users/xrav3nz/events{/privacy}","received_events_url":"https://api.github.com/users/xrav3nz/received_events","type":"User","site_admin":false},"body":"Tested this locally with the Linkedin OAuth plugin with [`full_screen_login: true`](https://github.com/discourse/discourse/blob/a515ba86120d605cdd5b77f36ecff94169dd229a/app/controllers/users/omniauth_callbacks_controller.rb#L65).","created_at":"2018-10-02T09:37:58Z","updated_at":"2018-10-02T09:42:36Z","html_url":"https://github.com/discourse/discourse/pull/6441#discussion_r221884758","pull_request_url":"https://api.github.com/repos/discourse/discourse/pulls/6441","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/discourse/discourse/pulls/comments/221884758"},"html":{"href":"https://github.com/discourse/discourse/pull/6441#discussion_r221884758"},"pull_request":{"href":"https://api.github.com/repos/discourse/discourse/pulls/6441"}}},"pull_request":{"url":"https://api.github.com/repos/discourse/discourse/pulls/6441","id":219640747,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NjQwNzQ3","html_url":"https://github.com/discourse/discourse/pull/6441","diff_url":"https://github.com/discourse/discourse/pull/6441.diff","patch_url":"https://github.com/discourse/discourse/pull/6441.patch","issue_url":"https://api.github.com/repos/discourse/discourse/issues/6441","number":6441,"state":"open","locked":false,"title":"✂️ `discourse_javascript.html.erb`","user":{"login":"xrav3nz","id":6376558,"node_id":"MDQ6VXNlcjYzNzY1NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6376558?v=4","gravatar_id":"","url":"https://api.github.com/users/xrav3nz","html_url":"https://github.com/xrav3nz","followers_url":"https://api.github.com/users/xrav3nz/followers","following_url":"https://api.github.com/users/xrav3nz/following{/other_user}","gists_url":"https://api.github.com/users/xrav3nz/gists{/gist_id}","starred_url":"https://api.github.com/users/xrav3nz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrav3nz/subscriptions","organizations_url":"https://api.github.com/users/xrav3nz/orgs","repos_url":"https://api.github.com/users/xrav3nz/repos","events_url":"https://api.github.com/users/xrav3nz/events{/privacy}","received_events_url":"https://api.github.com/users/xrav3nz/received_events","type":"User","site_admin":false},"body":"This extracts the last bits of inline JavaScript in our HTML partials, and remove `discourse_javascript.html.erb` 🎉","created_at":"2018-10-02T09:34:31Z","updated_at":"2018-10-02T09:42:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05a3950ffe04beea63f708ef3f373b7985391a8c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/discourse/discourse/pulls/6441/commits","review_comments_url":"https://api.github.com/repos/discourse/discourse/pulls/6441/comments","review_comment_url":"https://api.github.com/repos/discourse/discourse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/discourse/discourse/issues/6441/comments","statuses_url":"https://api.github.com/repos/discourse/discourse/statuses/49830efd4d0fa3de511abe59c9b90626abec23f3","head":{"label":"xrav3nz:csp/inline-js/rip-discourse-javascript-partial","ref":"csp/inline-js/rip-discourse-javascript-partial","sha":"49830efd4d0fa3de511abe59c9b90626abec23f3","user":{"login":"xrav3nz","id":6376558,"node_id":"MDQ6VXNlcjYzNzY1NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6376558?v=4","gravatar_id":"","url":"https://api.github.com/users/xrav3nz","html_url":"https://github.com/xrav3nz","followers_url":"https://api.github.com/users/xrav3nz/followers","following_url":"https://api.github.com/users/xrav3nz/following{/other_user}","gists_url":"https://api.github.com/users/xrav3nz/gists{/gist_id}","starred_url":"https://api.github.com/users/xrav3nz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrav3nz/subscriptions","organizations_url":"https://api.github.com/users/xrav3nz/orgs","repos_url":"https://api.github.com/users/xrav3nz/repos","events_url":"https://api.github.com/users/xrav3nz/events{/privacy}","received_events_url":"https://api.github.com/users/xrav3nz/received_events","type":"User","site_admin":false},"repo":{"id":99668064,"node_id":"MDEwOlJlcG9zaXRvcnk5OTY2ODA2NA==","name":"discourse","full_name":"xrav3nz/discourse","private":false,"owner":{"login":"xrav3nz","id":6376558,"node_id":"MDQ6VXNlcjYzNzY1NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6376558?v=4","gravatar_id":"","url":"https://api.github.com/users/xrav3nz","html_url":"https://github.com/xrav3nz","followers_url":"https://api.github.com/users/xrav3nz/followers","following_url":"https://api.github.com/users/xrav3nz/following{/other_user}","gists_url":"https://api.github.com/users/xrav3nz/gists{/gist_id}","starred_url":"https://api.github.com/users/xrav3nz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrav3nz/subscriptions","organizations_url":"https://api.github.com/users/xrav3nz/orgs","repos_url":"https://api.github.com/users/xrav3nz/repos","events_url":"https://api.github.com/users/xrav3nz/events{/privacy}","received_events_url":"https://api.github.com/users/xrav3nz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xrav3nz/discourse","description":"A platform for community discussion. Free, open, simple.","fork":true,"url":"https://api.github.com/repos/xrav3nz/discourse","forks_url":"https://api.github.com/repos/xrav3nz/discourse/forks","keys_url":"https://api.github.com/repos/xrav3nz/discourse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xrav3nz/discourse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xrav3nz/discourse/teams","hooks_url":"https://api.github.com/repos/xrav3nz/discourse/hooks","issue_events_url":"https://api.github.com/repos/xrav3nz/discourse/issues/events{/number}","events_url":"https://api.github.com/repos/xrav3nz/discourse/events","assignees_url":"https://api.github.com/repos/xrav3nz/discourse/assignees{/user}","branches_url":"https://api.github.com/repos/xrav3nz/discourse/branches{/branch}","tags_url":"https://api.github.com/repos/xrav3nz/discourse/tags","blobs_url":"https://api.github.com/repos/xrav3nz/discourse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xrav3nz/discourse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xrav3nz/discourse/git/refs{/sha}","trees_url":"https://api.github.com/repos/xrav3nz/discourse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xrav3nz/discourse/statuses/{sha}","languages_url":"https://api.github.com/repos/xrav3nz/discourse/languages","stargazers_url":"https://api.github.com/repos/xrav3nz/discourse/stargazers","contributors_url":"https://api.github.com/repos/xrav3nz/discourse/contributors","subscribers_url":"https://api.github.com/repos/xrav3nz/discourse/subscribers","subscription_url":"https://api.github.com/repos/xrav3nz/discourse/subscription","commits_url":"https://api.github.com/repos/xrav3nz/discourse/commits{/sha}","git_commits_url":"https://api.github.com/repos/xrav3nz/discourse/git/commits{/sha}","comments_url":"https://api.github.com/repos/xrav3nz/discourse/comments{/number}","issue_comment_url":"https://api.github.com/repos/xrav3nz/discourse/issues/comments{/number}","contents_url":"https://api.github.com/repos/xrav3nz/discourse/contents/{+path}","compare_url":"https://api.github.com/repos/xrav3nz/discourse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xrav3nz/discourse/merges","archive_url":"https://api.github.com/repos/xrav3nz/discourse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xrav3nz/discourse/downloads","issues_url":"https://api.github.com/repos/xrav3nz/discourse/issues{/number}","pulls_url":"https://api.github.com/repos/xrav3nz/discourse/pulls{/number}","milestones_url":"https://api.github.com/repos/xrav3nz/discourse/milestones{/number}","notifications_url":"https://api.github.com/repos/xrav3nz/discourse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xrav3nz/discourse/labels{/name}","releases_url":"https://api.github.com/repos/xrav3nz/discourse/releases{/id}","deployments_url":"https://api.github.com/repos/xrav3nz/discourse/deployments","created_at":"2017-08-08T08:13:56Z","updated_at":"2018-08-26T14:44:15Z","pushed_at":"2018-10-02T09:25:04Z","git_url":"git://github.com/xrav3nz/discourse.git","ssh_url":"git@github.com:xrav3nz/discourse.git","clone_url":"https://github.com/xrav3nz/discourse.git","svn_url":"https://github.com/xrav3nz/discourse","homepage":"https://www.discourse.org","size":233314,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"discourse:master","ref":"master","sha":"a515ba86120d605cdd5b77f36ecff94169dd229a","user":{"login":"discourse","id":3220138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjAxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3220138?v=4","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"repo":{"id":7569578,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY5NTc4","name":"discourse","full_name":"discourse/discourse","private":false,"owner":{"login":"discourse","id":3220138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjAxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3220138?v=4","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/discourse/discourse","description":"A platform for community discussion. Free, open, simple.","fork":false,"url":"https://api.github.com/repos/discourse/discourse","forks_url":"https://api.github.com/repos/discourse/discourse/forks","keys_url":"https://api.github.com/repos/discourse/discourse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/discourse/discourse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/discourse/discourse/teams","hooks_url":"https://api.github.com/repos/discourse/discourse/hooks","issue_events_url":"https://api.github.com/repos/discourse/discourse/issues/events{/number}","events_url":"https://api.github.com/repos/discourse/discourse/events","assignees_url":"https://api.github.com/repos/discourse/discourse/assignees{/user}","branches_url":"https://api.github.com/repos/discourse/discourse/branches{/branch}","tags_url":"https://api.github.com/repos/discourse/discourse/tags","blobs_url":"https://api.github.com/repos/discourse/discourse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/discourse/discourse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/discourse/discourse/git/refs{/sha}","trees_url":"https://api.github.com/repos/discourse/discourse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/discourse/discourse/statuses/{sha}","languages_url":"https://api.github.com/repos/discourse/discourse/languages","stargazers_url":"https://api.github.com/repos/discourse/discourse/stargazers","contributors_url":"https://api.github.com/repos/discourse/discourse/contributors","subscribers_url":"https://api.github.com/repos/discourse/discourse/subscribers","subscription_url":"https://api.github.com/repos/discourse/discourse/subscription","commits_url":"https://api.github.com/repos/discourse/discourse/commits{/sha}","git_commits_url":"https://api.github.com/repos/discourse/discourse/git/commits{/sha}","comments_url":"https://api.github.com/repos/discourse/discourse/comments{/number}","issue_comment_url":"https://api.github.com/repos/discourse/discourse/issues/comments{/number}","contents_url":"https://api.github.com/repos/discourse/discourse/contents/{+path}","compare_url":"https://api.github.com/repos/discourse/discourse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/discourse/discourse/merges","archive_url":"https://api.github.com/repos/discourse/discourse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/discourse/discourse/downloads","issues_url":"https://api.github.com/repos/discourse/discourse/issues{/number}","pulls_url":"https://api.github.com/repos/discourse/discourse/pulls{/number}","milestones_url":"https://api.github.com/repos/discourse/discourse/milestones{/number}","notifications_url":"https://api.github.com/repos/discourse/discourse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/discourse/discourse/labels{/name}","releases_url":"https://api.github.com/repos/discourse/discourse/releases{/id}","deployments_url":"https://api.github.com/repos/discourse/discourse/deployments","created_at":"2013-01-12T00:25:55Z","updated_at":"2018-10-02T09:27:52Z","pushed_at":"2018-10-02T09:41:10Z","git_url":"git://github.com/discourse/discourse.git","ssh_url":"git@github.com:discourse/discourse.git","clone_url":"https://github.com/discourse/discourse.git","svn_url":"https://github.com/discourse/discourse","homepage":"https://www.discourse.org","size":234297,"stargazers_count":26209,"watchers_count":26209,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6199,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6199,"open_issues":19,"watchers":26209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/discourse/discourse/pulls/6441"},"html":{"href":"https://github.com/discourse/discourse/pull/6441"},"issue":{"href":"https://api.github.com/repos/discourse/discourse/issues/6441"},"comments":{"href":"https://api.github.com/repos/discourse/discourse/issues/6441/comments"},"review_comments":{"href":"https://api.github.com/repos/discourse/discourse/pulls/6441/comments"},"review_comment":{"href":"https://api.github.com/repos/discourse/discourse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/discourse/discourse/pulls/6441/commits"},"statuses":{"href":"https://api.github.com/repos/discourse/discourse/statuses/49830efd4d0fa3de511abe59c9b90626abec23f3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"xrav3nz"}}