{"push_id":2300300992,"size":49,"distinct_size":41,"ref":"refs/heads/master","head":"1a6d88a6c1fd862d934e2ecdffb61785fd9cf4b7","before":"e873ee5116864f1b10608759ac51a7f578fafa12","commits":[{"sha":"141764bcccb4ca4f7bafad170a41a3150be7e9d3","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"Use `mustBeAdmin` middleware to authenticate Private auth API","distinct":false,"url":"https://api.github.com/repos/TerriaJS/magda/commits/141764bcccb4ca4f7bafad170a41a3150be7e9d3"},{"sha":"b3c044f8d39aaf7318770ffb9f035fb99c23cf8c","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"1> Fix: only admin users are authorised to access the Private API\n2> Should not use mustBeAdmin as it sends requests back to Auth API","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/b3c044f8d39aaf7318770ffb9f035fb99c23cf8c"},{"sha":"3a7285e60436e4cd9512970283e878db5c5450fa","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"fix: getUserIdHandling doesnot return a promise","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/3a7285e60436e4cd9512970283e878db5c5450fa"},{"sha":"ff7dfe506bb7792e46db575febab3510eb16d3ec","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"When Authentication failed, props.location.state has actually no `from` property.\nHere is one example (the content of `props.location.state`):\n`{\"signInError\":\"unauthorized\"}`\nThus, `props.location.state.from.pathname` will trigger an accessing `undefined` property error when it happens. And this will stop other component from being loaded.","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/ff7dfe506bb7792e46db575febab3510eb16d3ec"},{"sha":"8972391e9818fffa5140b0d86bd67856029b0b54","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"Avoid invalid JSON repsonse causing `unhandled promise rejection` error.","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/8972391e9818fffa5140b0d86bd67856029b0b54"},{"sha":"003b858e041c1745b744e749bed24325062731dd","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"1> allow ApiClient to send request to Auth API as default admin user\n2> gateway will talk to Auth API as default User\n3> Add default user ID to gateway argument list","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/003b858e041c1745b744e749bed24325062731dd"},{"sha":"c3b1dbaf5d16a9607e0b823061e5ceaa226250d8","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"Adjustment on lauch.json for debuging\n1> Add userId to the parameter list\n2> fix the config for auth api module:\nthe `--inspect` after `-r` has no effect","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/c3b1dbaf5d16a9607e0b823061e5ceaa226250d8"},{"sha":"9a8e4d3d0f70ed8e09c34ac9f724c4fe9a764308","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"Should allow public API access through ApiClient with jwtSecret & userId","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/9a8e4d3d0f70ed8e09c34ac9f724c4fe9a764308"},{"sha":"dd6b709e40b9c01f07d15a3c2772d7bae40f7053","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"apiClient.getUser is actually a private Auth API call. Auth API will check whether the request is from an Admin user in the first palce.","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/dd6b709e40b9c01f07d15a3c2772d7bae40f7053"},{"sha":"2d08383c51d10539610d540f798ab3b6a42a74d0","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"1> Fix: make sure ApiClient.ts can handle non JSON response from server\n2> Add jwtSecret & SESSION_SECRET config to package.json of magda-authorization-api module","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/2d08383c51d10539610d540f798ab3b6a42a74d0"},{"sha":"13a9e0d5ce73883c435be22f5fb125224a07d92d","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"Fix: mustBeAdmin could leave unhandled rejection, which lead to failure of `magda-admin-api` module unit test","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/13a9e0d5ce73883c435be22f5fb125224a07d92d"},{"sha":"90ee88d4acb78bed910b9de9035c22487e1516c3","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"solve the issue of `magda-admin-api` module unit test cannot pass. The actual admin user checking logic has been implemented at Auth API side.","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/90ee88d4acb78bed910b9de9035c22487e1516c3"},{"sha":"1e89cee6d87cc66b1f12c0a624e5215d822cad46","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"Based on Alex's feedback, we will have more consistent response statusCode from AuthApi:\n1> 401 indicates non-existent user\n2> 403 indicates Forbidden","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/1e89cee6d87cc66b1f12c0a624e5215d822cad46"},{"sha":"b21a0874c3ec4037e46f3b24dab6931a83f1979e","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"Simplify the code using lodash merge","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/b21a0874c3ec4037e46f3b24dab6931a83f1979e"},{"sha":"a903ef188d2ce9e411d1df3794c8ec6cecb73f59","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"remove debug code; get object directly via res.json()","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/a903ef188d2ce9e411d1df3794c8ec6cecb73f59"},{"sha":"2ea4414aa536606b9fa7630b2a2f83a4f95da850","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"1> Base on Alex's feedback: Make code more clearer by using `.catch` instead of the second argument of `.then`\n2> Fix similar issue in `statsActions.js`","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/2ea4414aa536606b9fa7630b2a2f83a4f95da850"},{"sha":"696c9f3460241659fe96f69128b1effdc9a03092","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"Use prettier to re-format code","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/696c9f3460241659fe96f69128b1effdc9a03092"},{"sha":"5e69207e2088f50285aae8a7d94540234086b1d7","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"Move AuthError def into a seperate file","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/5e69207e2088f50285aae8a7d94540234086b1d7"},{"sha":"6919fd1db8bd4ca000e4077c72dd6fddc971cf57","author":{"name":"Jiang","email":"e545d24e76ba6b5a6e6b260b450e3c93fcf9f914@spin-ev.nexus.csiro.au"},"message":"AuthApi should be put in common module","distinct":true,"url":"https://api.github.com/repos/TerriaJS/magda/commits/6919fd1db8bd4ca000e4077c72dd6fddc971cf57"},{"sha":"80f8d26882cc1e6f1b38a1e4fd62986a104da475","author":{"name":"Alex Gilleran","email":"798b74eb5231f5a5884ef50449e7d863b0210c9c@nicta.com.au"},"message":"added a failing test for query-record-by-aspect-value.","distinct":false,"url":"https://api.github.com/repos/TerriaJS/magda/commits/80f8d26882cc1e6f1b38a1e4fd62986a104da475"}]}
{"actor":{"display_login":"AlexGilleran"}}