{"action":"created","comment":{"url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/comments/179721666","pull_request_review_id":110019653,"id":179721666,"diff_hunk":"@@ -202,6 +164,58 @@ map<string, PeakGroup> IsotopeDetection::getIsotopes(PeakGroup* parentgroup, vec\n     return isotopes;\n }\n \n+bool IsotopeDetection::filterIsotope(Isotope x, bool C13Flag, bool N15Flag, bool S34Flag, bool D2Flag, float parentPeakIntensity, float isotopePeakIntensity, mzSample* sample, PeakGroup *parentGroup) ","path":"src/core/libmaven/isotopeDetection.cpp","position":53,"original_position":53,"commit_id":"b06b1947a57fd500f7f5054e1fd8f757b9e3a051","original_commit_id":"b06b1947a57fd500f7f5054e1fd8f757b9e3a051","user":{"login":"shubhra-agrawal","id":28925846,"avatar_url":"https://avatars3.githubusercontent.com/u/28925846?v=4","gravatar_id":"","url":"https://api.github.com/users/shubhra-agrawal","html_url":"https://github.com/shubhra-agrawal","followers_url":"https://api.github.com/users/shubhra-agrawal/followers","following_url":"https://api.github.com/users/shubhra-agrawal/following{/other_user}","gists_url":"https://api.github.com/users/shubhra-agrawal/gists{/gist_id}","starred_url":"https://api.github.com/users/shubhra-agrawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubhra-agrawal/subscriptions","organizations_url":"https://api.github.com/users/shubhra-agrawal/orgs","repos_url":"https://api.github.com/users/shubhra-agrawal/repos","events_url":"https://api.github.com/users/shubhra-agrawal/events{/privacy}","received_events_url":"https://api.github.com/users/shubhra-agrawal/received_events","type":"User","site_admin":false},"body":"@IpankajI Done in future branches.","created_at":"2018-04-06T10:45:08Z","updated_at":"2018-04-06T10:45:09Z","html_url":"https://github.com/ElucidataInc/ElMaven/pull/636#discussion_r179721666","pull_request_url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/636","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/comments/179721666"},"html":{"href":"https://github.com/ElucidataInc/ElMaven/pull/636#discussion_r179721666"},"pull_request":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/636"}},"in_reply_to_id":179721461},"pull_request":{"url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/636","id":176793438,"html_url":"https://github.com/ElucidataInc/ElMaven/pull/636","diff_url":"https://github.com/ElucidataInc/ElMaven/pull/636.diff","patch_url":"https://github.com/ElucidataInc/ElMaven/pull/636.patch","issue_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/636","number":636,"state":"open","locked":false,"title":"Refactor get isotope","user":{"login":"shubhra-agrawal","id":28925846,"avatar_url":"https://avatars3.githubusercontent.com/u/28925846?v=4","gravatar_id":"","url":"https://api.github.com/users/shubhra-agrawal","html_url":"https://github.com/shubhra-agrawal","followers_url":"https://api.github.com/users/shubhra-agrawal/followers","following_url":"https://api.github.com/users/shubhra-agrawal/following{/other_user}","gists_url":"https://api.github.com/users/shubhra-agrawal/gists{/gist_id}","starred_url":"https://api.github.com/users/shubhra-agrawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubhra-agrawal/subscriptions","organizations_url":"https://api.github.com/users/shubhra-agrawal/orgs","repos_url":"https://api.github.com/users/shubhra-agrawal/repos","events_url":"https://api.github.com/users/shubhra-agrawal/events{/privacy}","received_events_url":"https://api.github.com/users/shubhra-agrawal/received_events","type":"User","site_admin":false},"body":"Abundance error and correlation check are done both in isotopeDetection and isotopeWidget. Moving the code block into a separate function to get rid of duplicate code later.","created_at":"2018-03-22T14:20:10Z","updated_at":"2018-04-06T10:45:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a28c999280ce81ffd3401258503f48b1a8b34cb","assignee":{"login":"IpankajI","id":19559785,"avatar_url":"https://avatars1.githubusercontent.com/u/19559785?v=4","gravatar_id":"","url":"https://api.github.com/users/IpankajI","html_url":"https://github.com/IpankajI","followers_url":"https://api.github.com/users/IpankajI/followers","following_url":"https://api.github.com/users/IpankajI/following{/other_user}","gists_url":"https://api.github.com/users/IpankajI/gists{/gist_id}","starred_url":"https://api.github.com/users/IpankajI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IpankajI/subscriptions","organizations_url":"https://api.github.com/users/IpankajI/orgs","repos_url":"https://api.github.com/users/IpankajI/repos","events_url":"https://api.github.com/users/IpankajI/events{/privacy}","received_events_url":"https://api.github.com/users/IpankajI/received_events","type":"User","site_admin":false},"assignees":[{"login":"IpankajI","id":19559785,"avatar_url":"https://avatars1.githubusercontent.com/u/19559785?v=4","gravatar_id":"","url":"https://api.github.com/users/IpankajI","html_url":"https://github.com/IpankajI","followers_url":"https://api.github.com/users/IpankajI/followers","following_url":"https://api.github.com/users/IpankajI/following{/other_user}","gists_url":"https://api.github.com/users/IpankajI/gists{/gist_id}","starred_url":"https://api.github.com/users/IpankajI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IpankajI/subscriptions","organizations_url":"https://api.github.com/users/IpankajI/orgs","repos_url":"https://api.github.com/users/IpankajI/repos","events_url":"https://api.github.com/users/IpankajI/events{/privacy}","received_events_url":"https://api.github.com/users/IpankajI/received_events","type":"User","site_admin":false},{"login":"sahil21","id":21240516,"avatar_url":"https://avatars0.githubusercontent.com/u/21240516?v=4","gravatar_id":"","url":"https://api.github.com/users/sahil21","html_url":"https://github.com/sahil21","followers_url":"https://api.github.com/users/sahil21/followers","following_url":"https://api.github.com/users/sahil21/following{/other_user}","gists_url":"https://api.github.com/users/sahil21/gists{/gist_id}","starred_url":"https://api.github.com/users/sahil21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahil21/subscriptions","organizations_url":"https://api.github.com/users/sahil21/orgs","repos_url":"https://api.github.com/users/sahil21/repos","events_url":"https://api.github.com/users/sahil21/events{/privacy}","received_events_url":"https://api.github.com/users/sahil21/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/636/commits","review_comments_url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/636/comments","review_comment_url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/636/comments","statuses_url":"https://api.github.com/repos/ElucidataInc/ElMaven/statuses/b06b1947a57fd500f7f5054e1fd8f757b9e3a051","head":{"label":"ElucidataInc:ref_getIsotope","ref":"ref_getIsotope","sha":"b06b1947a57fd500f7f5054e1fd8f757b9e3a051","user":{"login":"ElucidataInc","id":22674262,"avatar_url":"https://avatars2.githubusercontent.com/u/22674262?v=4","gravatar_id":"","url":"https://api.github.com/users/ElucidataInc","html_url":"https://github.com/ElucidataInc","followers_url":"https://api.github.com/users/ElucidataInc/followers","following_url":"https://api.github.com/users/ElucidataInc/following{/other_user}","gists_url":"https://api.github.com/users/ElucidataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/ElucidataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElucidataInc/subscriptions","organizations_url":"https://api.github.com/users/ElucidataInc/orgs","repos_url":"https://api.github.com/users/ElucidataInc/repos","events_url":"https://api.github.com/users/ElucidataInc/events{/privacy}","received_events_url":"https://api.github.com/users/ElucidataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":70220005,"name":"ElMaven","full_name":"ElucidataInc/ElMaven","owner":{"login":"ElucidataInc","id":22674262,"avatar_url":"https://avatars2.githubusercontent.com/u/22674262?v=4","gravatar_id":"","url":"https://api.github.com/users/ElucidataInc","html_url":"https://github.com/ElucidataInc","followers_url":"https://api.github.com/users/ElucidataInc/followers","following_url":"https://api.github.com/users/ElucidataInc/following{/other_user}","gists_url":"https://api.github.com/users/ElucidataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/ElucidataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElucidataInc/subscriptions","organizations_url":"https://api.github.com/users/ElucidataInc/orgs","repos_url":"https://api.github.com/users/ElucidataInc/repos","events_url":"https://api.github.com/users/ElucidataInc/events{/privacy}","received_events_url":"https://api.github.com/users/ElucidataInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ElucidataInc/ElMaven","description":"LC-MS data processing engine for large-scale metabolomic experiments.","fork":false,"url":"https://api.github.com/repos/ElucidataInc/ElMaven","forks_url":"https://api.github.com/repos/ElucidataInc/ElMaven/forks","keys_url":"https://api.github.com/repos/ElucidataInc/ElMaven/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElucidataInc/ElMaven/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElucidataInc/ElMaven/teams","hooks_url":"https://api.github.com/repos/ElucidataInc/ElMaven/hooks","issue_events_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/events{/number}","events_url":"https://api.github.com/repos/ElucidataInc/ElMaven/events","assignees_url":"https://api.github.com/repos/ElucidataInc/ElMaven/assignees{/user}","branches_url":"https://api.github.com/repos/ElucidataInc/ElMaven/branches{/branch}","tags_url":"https://api.github.com/repos/ElucidataInc/ElMaven/tags","blobs_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElucidataInc/ElMaven/statuses/{sha}","languages_url":"https://api.github.com/repos/ElucidataInc/ElMaven/languages","stargazers_url":"https://api.github.com/repos/ElucidataInc/ElMaven/stargazers","contributors_url":"https://api.github.com/repos/ElucidataInc/ElMaven/contributors","subscribers_url":"https://api.github.com/repos/ElucidataInc/ElMaven/subscribers","subscription_url":"https://api.github.com/repos/ElucidataInc/ElMaven/subscription","commits_url":"https://api.github.com/repos/ElucidataInc/ElMaven/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElucidataInc/ElMaven/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElucidataInc/ElMaven/contents/{+path}","compare_url":"https://api.github.com/repos/ElucidataInc/ElMaven/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElucidataInc/ElMaven/merges","archive_url":"https://api.github.com/repos/ElucidataInc/ElMaven/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElucidataInc/ElMaven/downloads","issues_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues{/number}","pulls_url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls{/number}","milestones_url":"https://api.github.com/repos/ElucidataInc/ElMaven/milestones{/number}","notifications_url":"https://api.github.com/repos/ElucidataInc/ElMaven/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElucidataInc/ElMaven/labels{/name}","releases_url":"https://api.github.com/repos/ElucidataInc/ElMaven/releases{/id}","deployments_url":"https://api.github.com/repos/ElucidataInc/ElMaven/deployments","created_at":"2016-10-07T06:06:47Z","updated_at":"2018-04-05T09:20:47Z","pushed_at":"2018-04-06T10:27:14Z","git_url":"git://github.com/ElucidataInc/ElMaven.git","ssh_url":"git@github.com:ElucidataInc/ElMaven.git","clone_url":"https://github.com/ElucidataInc/ElMaven.git","svn_url":"https://github.com/ElucidataInc/ElMaven","homepage":"https://elucidatainc.github.io/ElMaven","size":361124,"stargazers_count":45,"watchers_count":45,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":218,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":9,"open_issues":218,"watchers":45,"default_branch":"develop"}},"base":{"label":"ElucidataInc:develop","ref":"develop","sha":"60541c321ecfb58be100475dce5292727700e499","user":{"login":"ElucidataInc","id":22674262,"avatar_url":"https://avatars2.githubusercontent.com/u/22674262?v=4","gravatar_id":"","url":"https://api.github.com/users/ElucidataInc","html_url":"https://github.com/ElucidataInc","followers_url":"https://api.github.com/users/ElucidataInc/followers","following_url":"https://api.github.com/users/ElucidataInc/following{/other_user}","gists_url":"https://api.github.com/users/ElucidataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/ElucidataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElucidataInc/subscriptions","organizations_url":"https://api.github.com/users/ElucidataInc/orgs","repos_url":"https://api.github.com/users/ElucidataInc/repos","events_url":"https://api.github.com/users/ElucidataInc/events{/privacy}","received_events_url":"https://api.github.com/users/ElucidataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":70220005,"name":"ElMaven","full_name":"ElucidataInc/ElMaven","owner":{"login":"ElucidataInc","id":22674262,"avatar_url":"https://avatars2.githubusercontent.com/u/22674262?v=4","gravatar_id":"","url":"https://api.github.com/users/ElucidataInc","html_url":"https://github.com/ElucidataInc","followers_url":"https://api.github.com/users/ElucidataInc/followers","following_url":"https://api.github.com/users/ElucidataInc/following{/other_user}","gists_url":"https://api.github.com/users/ElucidataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/ElucidataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElucidataInc/subscriptions","organizations_url":"https://api.github.com/users/ElucidataInc/orgs","repos_url":"https://api.github.com/users/ElucidataInc/repos","events_url":"https://api.github.com/users/ElucidataInc/events{/privacy}","received_events_url":"https://api.github.com/users/ElucidataInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ElucidataInc/ElMaven","description":"LC-MS data processing engine for large-scale metabolomic experiments.","fork":false,"url":"https://api.github.com/repos/ElucidataInc/ElMaven","forks_url":"https://api.github.com/repos/ElucidataInc/ElMaven/forks","keys_url":"https://api.github.com/repos/ElucidataInc/ElMaven/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElucidataInc/ElMaven/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElucidataInc/ElMaven/teams","hooks_url":"https://api.github.com/repos/ElucidataInc/ElMaven/hooks","issue_events_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/events{/number}","events_url":"https://api.github.com/repos/ElucidataInc/ElMaven/events","assignees_url":"https://api.github.com/repos/ElucidataInc/ElMaven/assignees{/user}","branches_url":"https://api.github.com/repos/ElucidataInc/ElMaven/branches{/branch}","tags_url":"https://api.github.com/repos/ElucidataInc/ElMaven/tags","blobs_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElucidataInc/ElMaven/statuses/{sha}","languages_url":"https://api.github.com/repos/ElucidataInc/ElMaven/languages","stargazers_url":"https://api.github.com/repos/ElucidataInc/ElMaven/stargazers","contributors_url":"https://api.github.com/repos/ElucidataInc/ElMaven/contributors","subscribers_url":"https://api.github.com/repos/ElucidataInc/ElMaven/subscribers","subscription_url":"https://api.github.com/repos/ElucidataInc/ElMaven/subscription","commits_url":"https://api.github.com/repos/ElucidataInc/ElMaven/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElucidataInc/ElMaven/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElucidataInc/ElMaven/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElucidataInc/ElMaven/contents/{+path}","compare_url":"https://api.github.com/repos/ElucidataInc/ElMaven/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElucidataInc/ElMaven/merges","archive_url":"https://api.github.com/repos/ElucidataInc/ElMaven/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElucidataInc/ElMaven/downloads","issues_url":"https://api.github.com/repos/ElucidataInc/ElMaven/issues{/number}","pulls_url":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls{/number}","milestones_url":"https://api.github.com/repos/ElucidataInc/ElMaven/milestones{/number}","notifications_url":"https://api.github.com/repos/ElucidataInc/ElMaven/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElucidataInc/ElMaven/labels{/name}","releases_url":"https://api.github.com/repos/ElucidataInc/ElMaven/releases{/id}","deployments_url":"https://api.github.com/repos/ElucidataInc/ElMaven/deployments","created_at":"2016-10-07T06:06:47Z","updated_at":"2018-04-05T09:20:47Z","pushed_at":"2018-04-06T10:27:14Z","git_url":"git://github.com/ElucidataInc/ElMaven.git","ssh_url":"git@github.com:ElucidataInc/ElMaven.git","clone_url":"https://github.com/ElucidataInc/ElMaven.git","svn_url":"https://github.com/ElucidataInc/ElMaven","homepage":"https://elucidatainc.github.io/ElMaven","size":361124,"stargazers_count":45,"watchers_count":45,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":218,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":9,"open_issues":218,"watchers":45,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/636"},"html":{"href":"https://github.com/ElucidataInc/ElMaven/pull/636"},"issue":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/636"},"comments":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/issues/636/comments"},"review_comments":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/636/comments"},"review_comment":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/pulls/636/commits"},"statuses":{"href":"https://api.github.com/repos/ElucidataInc/ElMaven/statuses/b06b1947a57fd500f7f5054e1fd8f757b9e3a051"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"shubhra-agrawal"}}