{"push_id":2674335059,"size":9,"distinct_size":9,"ref":"refs/heads/master","head":"99ca6481d41d5044364d87883ee09068516bad3c","before":"055652d5cea2b6a2fde00cfc331add6e413af636","commits":[{"sha":"d6dd2ce33f43a13623c367460f7d659c1618e1a1","author":{"name":"Graeme Connell","email":"cc51e71fd71556dc3886d492c221246e722ed4c9@gmail.com"},"message":"Random fixes for golint.","distinct":true,"url":"https://api.github.com/repos/vgraveto/gopacket/commits/d6dd2ce33f43a13623c367460f7d659c1618e1a1"},{"sha":"b3bbc52482b07ed8b3544deb6fc91f89373c5d72","author":{"name":"Graeme Connell","email":"cc51e71fd71556dc3886d492c221246e722ed4c9@gmail.com"},"message":"Fix install dep.\n\nUse this:\nhttps://docs.travis-ci.com/user/installing-dependencies/","distinct":true,"url":"https://api.github.com/repos/vgraveto/gopacket/commits/b3bbc52482b07ed8b3544deb6fc91f89373c5d72"},{"sha":"05f186d6f8f5e5e764b375e54aec3f8b6672db82","author":{"name":"Graeme Connell","email":"cc51e71fd71556dc3886d492c221246e722ed4c9@gmail.com"},"message":"govet checks for includes, we can't vet pfring :(","distinct":true,"url":"https://api.github.com/repos/vgraveto/gopacket/commits/05f186d6f8f5e5e764b375e54aec3f8b6672db82"},{"sha":"165a0afa8d2975ef02eff12550e6aa75d6a1c828","author":{"name":"Richard Strand","email":"320bca71fc381a4a025636043ca86e734e31cf8b@nubolabs.com"},"message":"Fix infinite loop when parsing malformed OSPF packet","distinct":true,"url":"https://api.github.com/repos/vgraveto/gopacket/commits/165a0afa8d2975ef02eff12550e6aa75d6a1c828"},{"sha":"10a4317e6f5f0b72993a89ecfaa8ad207347df34","author":{"name":"Assaf Morami","email":"7751e39b615cecb9feb59a64e4050f6afbae7e9a@gmail.com"},"message":"SetSnaplen to better control read parameters\n\nTo better control what packet size to allow to read and what packet size to dump","distinct":true,"url":"https://api.github.com/repos/vgraveto/gopacket/commits/10a4317e6f5f0b72993a89ecfaa8ad207347df34"},{"sha":"c03e107cbba27aa2a0114b1308fce8d35da8b1f4","author":{"name":"Assaf Morami","email":"7751e39b615cecb9feb59a64e4050f6afbae7e9a@gmail.com"},"message":"Comment on SetSnaplen existence\n\nSetSnaplen sets the snapshot length of the capture file.\r\n\r\nThis is useful when a pcap file contains packets bigger than then snaplen. Pcapgo will error when reading packets bigger than snaplen, then it dumps those packets and reads the next 16 bytes, which are part of the \"faulty\" packet's payload, but pcapgo thinks it's the next header, which is probably also faulty because it's not really a packet header. **This can lead to a lot of faulty reads.**\r\n\r\nThe SetSnaplen function can be used to set a bigger snaplen to prevent those read errors.\r\n\r\nThis snaplen situation can happen when a pcap writer doesn't truncate packets to the snaplen size while writing packets to file. E.g. In Python, dpkt.pcap.Writer sets snaplen by default to 1500 (https:dpkt.readthedocs.io/en/latest/api/api_auto.html#dpkt.pcap.Writer) but doesn't enforce this when writing packets (https:dpkt.readthedocs.io/en/latest/_modules/dpkt/pcap.html#Writer.writepkt).\r\n\r\nWhen reading, tools like tcpdump, tcpslice, mergecap and wireshark ignore the snaplen and use their own defined snaplen. E.g. When reading packets, tcpdump defines MAXIMUM_SNAPLEN (https:github.com/the-tcpdump-group/tcpdump/blob/6e80fcdbe9c41366df3fa244ffe4ac8cce2ab597/netdissect.h#L290) and uses it (https:github.com/the-tcpdump-group/tcpdump/blob/66384fa15b04b47ad08c063d4728df3b9c1c0677/print.c#L343-L358).\r\n\r\nFor further reading:\r\n- https:github.com/the-tcpdump-group/tcpdump/issues/389\r\n- https:bugs.wireshark.org/bugzilla/show_bug.cgi?id=8808\r\n- https:www.wireshark.org/lists/wireshark-dev/201307/msg00061.html\r\n- https:github.com/wireshark/wireshark/blob/bfd51199e707c1d5c28732be34b44a9ee8a91cd8/wiretap/pcap-common.c#L723-L742\r\n  - https:github.com/wireshark/wireshark/blob/f07fb6cdfc0904905627707b88450054e921f092/wiretap/libpcap.c#L592-L598\r\n  - https:github.com/wireshark/wireshark/blob/f07fb6cdfc0904905627707b88450054e921f092/wiretap/libpcap.c#L714-L727\r\n- https:github.com/the-tcpdump-group/tcpdump/commit/d033c1bc381c76d13e4aface97a4f4ec8c3beca2\r\n- https:github.com/the-tcpdump-group/tcpdump/blob/88e87cb2cb74c5f939792171379acd9e0efd8b9a/netdissect.h#L263-L290","distinct":true,"url":"https://api.github.com/repos/vgraveto/gopacket/commits/c03e107cbba27aa2a0114b1308fce8d35da8b1f4"},{"sha":"ba058f115a8652241305fd890bde2f68d0cf5f07","author":{"name":"Vitor Graveto","email":"ddd80347cc894536655615ccf7805ebc23683866@wexcedo.com"},"message":"Adding new protocol ModbusTCP decoder","distinct":true,"url":"https://api.github.com/repos/vgraveto/gopacket/commits/ba058f115a8652241305fd890bde2f68d0cf5f07"},{"sha":"c48513245224f7fecaf207becc562ed18430e210","author":{"name":"Vitor Graveto","email":"ddd80347cc894536655615ccf7805ebc23683866@wexcedo.com"},"message":"Declaring the new LayerTypeModbusTCP","distinct":true,"url":"https://api.github.com/repos/vgraveto/gopacket/commits/c48513245224f7fecaf207becc562ed18430e210"},{"sha":"99ca6481d41d5044364d87883ee09068516bad3c","author":{"name":"Vitor Graveto","email":"ddd80347cc894536655615ccf7805ebc23683866@wexcedo.com"},"message":"Mapping ModbusTCP to TCP port 502","distinct":true,"url":"https://api.github.com/repos/vgraveto/gopacket/commits/99ca6481d41d5044364d87883ee09068516bad3c"}]}
{"actor":{"display_login":"vgraveto"}}