{"action":"created","comment":{"url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/comments/186547632","pull_request_review_id":118148491,"id":186547632,"diff_hunk":"@@ -118,7 +118,7 @@ def create_discrete_state_encoder(self, s_size, h_size, activation, num_layers):\n     def create_new_obs(self, num_streams, h_size, num_layers):\n         brain = self.brain\n         s_size = brain.vector_observation_space_size * brain.num_stacked_vector_observations\n-        if brain.vector_action_space_type == \"continuous\":\n+        if brain.vector_action_space_size == \"continuous\":","path":"python/unitytrainers/models.py","position":null,"original_position":5,"commit_id":"c24ecb44f38623e0dfa5f5be3b878b6e608e5821","original_commit_id":"8b5df84bbd509f8f5d2714f717ed16026a4bb182","user":{"login":"awjuliani","id":9065325,"avatar_url":"https://avatars2.githubusercontent.com/u/9065325?v=4","gravatar_id":"","url":"https://api.github.com/users/awjuliani","html_url":"https://github.com/awjuliani","followers_url":"https://api.github.com/users/awjuliani/followers","following_url":"https://api.github.com/users/awjuliani/following{/other_user}","gists_url":"https://api.github.com/users/awjuliani/gists{/gist_id}","starred_url":"https://api.github.com/users/awjuliani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awjuliani/subscriptions","organizations_url":"https://api.github.com/users/awjuliani/orgs","repos_url":"https://api.github.com/users/awjuliani/repos","events_url":"https://api.github.com/users/awjuliani/events{/privacy}","received_events_url":"https://api.github.com/users/awjuliani/received_events","type":"User","site_admin":false},"body":"No. It was a typo that has been fixed.","created_at":"2018-05-07T20:56:53Z","updated_at":"2018-05-07T20:56:53Z","html_url":"https://github.com/Unity-Technologies/ml-agents/pull/720#discussion_r186547632","pull_request_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/720","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/comments/186547632"},"html":{"href":"https://github.com/Unity-Technologies/ml-agents/pull/720#discussion_r186547632"},"pull_request":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/720"}},"in_reply_to_id":186329780},"pull_request":{"url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/720","id":186246294,"html_url":"https://github.com/Unity-Technologies/ml-agents/pull/720","diff_url":"https://github.com/Unity-Technologies/ml-agents/pull/720.diff","patch_url":"https://github.com/Unity-Technologies/ml-agents/pull/720.patch","issue_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/720","number":720,"state":"open","locked":false,"title":"Walker Environment","user":{"login":"awjuliani","id":9065325,"avatar_url":"https://avatars2.githubusercontent.com/u/9065325?v=4","gravatar_id":"","url":"https://api.github.com/users/awjuliani","html_url":"https://github.com/awjuliani","followers_url":"https://api.github.com/users/awjuliani/followers","following_url":"https://api.github.com/users/awjuliani/following{/other_user}","gists_url":"https://api.github.com/users/awjuliani/gists{/gist_id}","starred_url":"https://api.github.com/users/awjuliani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awjuliani/subscriptions","organizations_url":"https://api.github.com/users/awjuliani/orgs","repos_url":"https://api.github.com/users/awjuliani/repos","events_url":"https://api.github.com/users/awjuliani/events{/privacy}","received_events_url":"https://api.github.com/users/awjuliani/received_events","type":"User","site_admin":false},"body":"💃 🕺 \r\n\r\n<img width=\"948\" alt=\"walker\" src=\"https://user-images.githubusercontent.com/9065325/39683331-bfba106c-5169-11e8-89fc-a1c5b74def19.png\">\r\n","created_at":"2018-05-07T03:12:42Z","updated_at":"2018-05-07T20:56:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1db7b1ece142e99e87ce30fbb53af104b91e6dc0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"eshvk","id":807898,"avatar_url":"https://avatars0.githubusercontent.com/u/807898?v=4","gravatar_id":"","url":"https://api.github.com/users/eshvk","html_url":"https://github.com/eshvk","followers_url":"https://api.github.com/users/eshvk/followers","following_url":"https://api.github.com/users/eshvk/following{/other_user}","gists_url":"https://api.github.com/users/eshvk/gists{/gist_id}","starred_url":"https://api.github.com/users/eshvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eshvk/subscriptions","organizations_url":"https://api.github.com/users/eshvk/orgs","repos_url":"https://api.github.com/users/eshvk/repos","events_url":"https://api.github.com/users/eshvk/events{/privacy}","received_events_url":"https://api.github.com/users/eshvk/received_events","type":"User","site_admin":false},{"login":"xiaomaogy","id":5985076,"avatar_url":"https://avatars3.githubusercontent.com/u/5985076?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaomaogy","html_url":"https://github.com/xiaomaogy","followers_url":"https://api.github.com/users/xiaomaogy/followers","following_url":"https://api.github.com/users/xiaomaogy/following{/other_user}","gists_url":"https://api.github.com/users/xiaomaogy/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaomaogy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaomaogy/subscriptions","organizations_url":"https://api.github.com/users/xiaomaogy/orgs","repos_url":"https://api.github.com/users/xiaomaogy/repos","events_url":"https://api.github.com/users/xiaomaogy/events{/privacy}","received_events_url":"https://api.github.com/users/xiaomaogy/received_events","type":"User","site_admin":false},{"login":"Hunter-Unity","id":19273127,"avatar_url":"https://avatars2.githubusercontent.com/u/19273127?v=4","gravatar_id":"","url":"https://api.github.com/users/Hunter-Unity","html_url":"https://github.com/Hunter-Unity","followers_url":"https://api.github.com/users/Hunter-Unity/followers","following_url":"https://api.github.com/users/Hunter-Unity/following{/other_user}","gists_url":"https://api.github.com/users/Hunter-Unity/gists{/gist_id}","starred_url":"https://api.github.com/users/Hunter-Unity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hunter-Unity/subscriptions","organizations_url":"https://api.github.com/users/Hunter-Unity/orgs","repos_url":"https://api.github.com/users/Hunter-Unity/repos","events_url":"https://api.github.com/users/Hunter-Unity/events{/privacy}","received_events_url":"https://api.github.com/users/Hunter-Unity/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/720/commits","review_comments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/720/comments","review_comment_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/720/comments","statuses_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/statuses/c24ecb44f38623e0dfa5f5be3b878b6e608e5821","head":{"label":"Unity-Technologies:develop-walker","ref":"develop-walker","sha":"c24ecb44f38623e0dfa5f5be3b878b6e608e5821","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":102904613,"name":"ml-agents","full_name":"Unity-Technologies/ml-agents","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/ml-agents","description":"Unity Machine Learning Agents","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/ml-agents","forks_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/deployments","created_at":"2017-09-08T21:09:04Z","updated_at":"2018-05-07T18:45:40Z","pushed_at":"2018-05-07T20:46:44Z","git_url":"git://github.com/Unity-Technologies/ml-agents.git","ssh_url":"git@github.com:Unity-Technologies/ml-agents.git","clone_url":"https://github.com/Unity-Technologies/ml-agents.git","svn_url":"https://github.com/Unity-Technologies/ml-agents","homepage":"https://unity3d.ai","size":216748,"stargazers_count":2906,"watchers_count":2906,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":605,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":605,"open_issues":125,"watchers":2906,"default_branch":"master"}},"base":{"label":"Unity-Technologies:develop","ref":"develop","sha":"7003c9176dbb65bd773a347cec59a9ac40d5b81a","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":102904613,"name":"ml-agents","full_name":"Unity-Technologies/ml-agents","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars0.githubusercontent.com/u/426196?v=4","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/ml-agents","description":"Unity Machine Learning Agents","fork":false,"url":"https://api.github.com/repos/Unity-Technologies/ml-agents","forks_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/ml-agents/deployments","created_at":"2017-09-08T21:09:04Z","updated_at":"2018-05-07T18:45:40Z","pushed_at":"2018-05-07T20:46:44Z","git_url":"git://github.com/Unity-Technologies/ml-agents.git","ssh_url":"git@github.com:Unity-Technologies/ml-agents.git","clone_url":"https://github.com/Unity-Technologies/ml-agents.git","svn_url":"https://github.com/Unity-Technologies/ml-agents","homepage":"https://unity3d.ai","size":216748,"stargazers_count":2906,"watchers_count":2906,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":605,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":605,"open_issues":125,"watchers":2906,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/720"},"html":{"href":"https://github.com/Unity-Technologies/ml-agents/pull/720"},"issue":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/720"},"comments":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/issues/720/comments"},"review_comments":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/720/comments"},"review_comment":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/pulls/720/commits"},"statuses":{"href":"https://api.github.com/repos/Unity-Technologies/ml-agents/statuses/c24ecb44f38623e0dfa5f5be3b878b6e608e5821"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"awjuliani"}}