{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-cli-extensions/pulls/comments/182807770","pull_request_review_id":113673345,"id":182807770,"diff_hunk":"@@ -0,0 +1,19 @@\n+# --------------------------------------------------------------------------------------------\n+# Copyright (c) Microsoft Corporation. All rights reserved.\n+# Licensed under the MIT License. See License.txt in the project root for license information.\n+# --------------------------------------------------------------------------------------------\n+\n+\n+from azext_signalr.signalr.models import KeyType\n+\n+\n+def signalr_key_list(client, resource_group_name, signalr_name):\n+    return client.list_keys(resource_group_name, signalr_name)\n+\n+\n+def signalr_key_renew(client, resource_group_name, signalr_name, key_type):\n+    if key_type == 'primary':\n+        key_type = KeyType.primary\n+    else:\n+        key_type = KeyType.secondary\n+    return client.regenerate_key(resource_group_name, signalr_name, key_type, polling=False)","path":"src/signalr/azext_signalr/key.py","position":19,"original_position":19,"commit_id":"40dfdeda09a612adc31b108ff62fc641ae36c4c0","original_commit_id":"40dfdeda09a612adc31b108ff62fc641ae36c4c0","user":{"login":"derekbekoe","id":16448634,"avatar_url":"https://avatars3.githubusercontent.com/u/16448634?v=4","gravatar_id":"","url":"https://api.github.com/users/derekbekoe","html_url":"https://github.com/derekbekoe","followers_url":"https://api.github.com/users/derekbekoe/followers","following_url":"https://api.github.com/users/derekbekoe/following{/other_user}","gists_url":"https://api.github.com/users/derekbekoe/gists{/gist_id}","starred_url":"https://api.github.com/users/derekbekoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekbekoe/subscriptions","organizations_url":"https://api.github.com/users/derekbekoe/orgs","repos_url":"https://api.github.com/users/derekbekoe/repos","events_url":"https://api.github.com/users/derekbekoe/events{/privacy}","received_events_url":"https://api.github.com/users/derekbekoe/received_events","type":"User","site_admin":false},"body":"Change this to:\r\n```\r\nsdk_no_wait(True, client.regenerate_key, resource_group_name, signalr_name, key_type)\r\n```\r\nhttps://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/azure/cli/core/util.py#L251","created_at":"2018-04-19T16:28:15Z","updated_at":"2018-04-19T16:33:55Z","html_url":"https://github.com/Azure/azure-cli-extensions/pull/142#discussion_r182807770","pull_request_url":"https://api.github.com/repos/Azure/azure-cli-extensions/pulls/142","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli-extensions/pulls/comments/182807770"},"html":{"href":"https://github.com/Azure/azure-cli-extensions/pull/142#discussion_r182807770"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-cli-extensions/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-cli-extensions/pulls/142","id":182710428,"html_url":"https://github.com/Azure/azure-cli-extensions/pull/142","diff_url":"https://github.com/Azure/azure-cli-extensions/pull/142.diff","patch_url":"https://github.com/Azure/azure-cli-extensions/pull/142.patch","issue_url":"https://api.github.com/repos/Azure/azure-cli-extensions/issues/142","number":142,"state":"open","locked":false,"title":"Initial PR for SignalR Service preview CLI extension","user":{"login":"zackliu","id":7847428,"avatar_url":"https://avatars0.githubusercontent.com/u/7847428?v=4","gravatar_id":"","url":"https://api.github.com/users/zackliu","html_url":"https://github.com/zackliu","followers_url":"https://api.github.com/users/zackliu/followers","following_url":"https://api.github.com/users/zackliu/following{/other_user}","gists_url":"https://api.github.com/users/zackliu/gists{/gist_id}","starred_url":"https://api.github.com/users/zackliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zackliu/subscriptions","organizations_url":"https://api.github.com/users/zackliu/orgs","repos_url":"https://api.github.com/users/zackliu/repos","events_url":"https://api.github.com/users/zackliu/events{/privacy}","received_events_url":"https://api.github.com/users/zackliu/received_events","type":"User","site_admin":false},"body":"---\r\n\r\nThis checklist is used to make sure that common guidelines for a pull request are followed.\r\n\r\n### General Guidelines\r\n\r\n- [ ] Have you run `./scripts/ci/test_static.sh` locally? (`pip install pylint flake8` required)\r\n- [ ] Have you run `python scripts/ci/test_index.py -q` locally?\r\n\r\nFor new extensions:\r\n\r\n- [ ] My extension description/summary conforms to the [Extension Summary Guidelines](https://github.com/Azure/azure-cli-extensions/blob/master/docs/extension_summary_guidelines.md).\r\n","created_at":"2018-04-19T09:05:58Z","updated_at":"2018-04-19T16:33:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09d95950153d2a1c841f5cc894ee109f2f0fa08b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-cli-extensions/pulls/142/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-cli-extensions/pulls/142/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-cli-extensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-cli-extensions/issues/142/comments","statuses_url":"https://api.github.com/repos/Azure/azure-cli-extensions/statuses/40dfdeda09a612adc31b108ff62fc641ae36c4c0","head":{"label":"zackliu:signalr","ref":"signalr","sha":"40dfdeda09a612adc31b108ff62fc641ae36c4c0","user":{"login":"zackliu","id":7847428,"avatar_url":"https://avatars0.githubusercontent.com/u/7847428?v=4","gravatar_id":"","url":"https://api.github.com/users/zackliu","html_url":"https://github.com/zackliu","followers_url":"https://api.github.com/users/zackliu/followers","following_url":"https://api.github.com/users/zackliu/following{/other_user}","gists_url":"https://api.github.com/users/zackliu/gists{/gist_id}","starred_url":"https://api.github.com/users/zackliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zackliu/subscriptions","organizations_url":"https://api.github.com/users/zackliu/orgs","repos_url":"https://api.github.com/users/zackliu/repos","events_url":"https://api.github.com/users/zackliu/events{/privacy}","received_events_url":"https://api.github.com/users/zackliu/received_events","type":"User","site_admin":false},"repo":{"id":130154280,"name":"azure-cli-extensions","full_name":"zackliu/azure-cli-extensions","owner":{"login":"zackliu","id":7847428,"avatar_url":"https://avatars0.githubusercontent.com/u/7847428?v=4","gravatar_id":"","url":"https://api.github.com/users/zackliu","html_url":"https://github.com/zackliu","followers_url":"https://api.github.com/users/zackliu/followers","following_url":"https://api.github.com/users/zackliu/following{/other_user}","gists_url":"https://api.github.com/users/zackliu/gists{/gist_id}","starred_url":"https://api.github.com/users/zackliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zackliu/subscriptions","organizations_url":"https://api.github.com/users/zackliu/orgs","repos_url":"https://api.github.com/users/zackliu/repos","events_url":"https://api.github.com/users/zackliu/events{/privacy}","received_events_url":"https://api.github.com/users/zackliu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zackliu/azure-cli-extensions","description":"Public Repository for Extensions of Azure CLI 2.0","fork":true,"url":"https://api.github.com/repos/zackliu/azure-cli-extensions","forks_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/forks","keys_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/teams","hooks_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/hooks","issue_events_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/events","assignees_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/tags","blobs_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/languages","stargazers_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/stargazers","contributors_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/contributors","subscribers_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/subscribers","subscription_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/subscription","commits_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/merges","archive_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/downloads","issues_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/labels{/name}","releases_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/zackliu/azure-cli-extensions/deployments","created_at":"2018-04-19T03:30:17Z","updated_at":"2018-04-19T03:30:19Z","pushed_at":"2018-04-19T10:56:43Z","git_url":"git://github.com/zackliu/azure-cli-extensions.git","ssh_url":"git@github.com:zackliu/azure-cli-extensions.git","clone_url":"https://github.com/zackliu/azure-cli-extensions.git","svn_url":"https://github.com/zackliu/azure-cli-extensions","homepage":"","size":779,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"5b8570005365e6999cf46ae65b4aa92ceb60151d","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":106580024,"name":"azure-cli-extensions","full_name":"Azure/azure-cli-extensions","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-cli-extensions","description":"Public Repository for Extensions of Azure CLI 2.0","fork":false,"url":"https://api.github.com/repos/Azure/azure-cli-extensions","forks_url":"https://api.github.com/repos/Azure/azure-cli-extensions/forks","keys_url":"https://api.github.com/repos/Azure/azure-cli-extensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-cli-extensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-cli-extensions/teams","hooks_url":"https://api.github.com/repos/Azure/azure-cli-extensions/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-cli-extensions/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-cli-extensions/events","assignees_url":"https://api.github.com/repos/Azure/azure-cli-extensions/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-cli-extensions/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-cli-extensions/tags","blobs_url":"https://api.github.com/repos/Azure/azure-cli-extensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-cli-extensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-cli-extensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-cli-extensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-cli-extensions/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-cli-extensions/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-cli-extensions/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-cli-extensions/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-cli-extensions/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-cli-extensions/subscription","commits_url":"https://api.github.com/repos/Azure/azure-cli-extensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-cli-extensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-cli-extensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-cli-extensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-cli-extensions/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-cli-extensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-cli-extensions/merges","archive_url":"https://api.github.com/repos/Azure/azure-cli-extensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-cli-extensions/downloads","issues_url":"https://api.github.com/repos/Azure/azure-cli-extensions/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-cli-extensions/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-cli-extensions/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-cli-extensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-cli-extensions/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-cli-extensions/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-cli-extensions/deployments","created_at":"2017-10-11T16:27:31Z","updated_at":"2018-04-18T23:35:20Z","pushed_at":"2018-04-19T10:56:45Z","git_url":"git://github.com/Azure/azure-cli-extensions.git","ssh_url":"git@github.com:Azure/azure-cli-extensions.git","clone_url":"https://github.com/Azure/azure-cli-extensions.git","svn_url":"https://github.com/Azure/azure-cli-extensions","homepage":"","size":717,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":34,"open_issues":20,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli-extensions/pulls/142"},"html":{"href":"https://github.com/Azure/azure-cli-extensions/pull/142"},"issue":{"href":"https://api.github.com/repos/Azure/azure-cli-extensions/issues/142"},"comments":{"href":"https://api.github.com/repos/Azure/azure-cli-extensions/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-cli-extensions/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-cli-extensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-cli-extensions/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-cli-extensions/statuses/40dfdeda09a612adc31b108ff62fc641ae36c4c0"}},"author_association":"NONE"}}
{"actor":{"display_login":"derekbekoe"}}