{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments/240708468","pull_request_review_id":183799297,"id":240708468,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDcwODQ2OA==","diff_hunk":"@@ -457,7 +457,14 @@ static CLLocationCoordinate2D toLocationCoordinate2D(const mbgl::Point<T> &point\n         NSExpression *identifierExpression = [NSExpression expressionForConstantValue:identifier];\n         feature.id = [identifierExpression mgl_featureIdentifier];\n     }\n-    feature.properties = [attributes mgl_propertyMap];\n+\n+    // Expression 'feature.properties = [attributes mgl_propertyMap]' for attributes dictionary of nil value\n+    // prouces std::unordered_map with max_load_factor of 0.0, while the default value must be 1.0.\n+    // Therefore, overflow exception is thrown when new key is inserted into the mbgl::Feature properties.\n+    if (attributes) {","path":"platform/darwin/src/MGLFeature.mm","position":9,"original_position":9,"commit_id":"dccc06fd04f7bd64e63e755bce63f1f26db042cd","original_commit_id":"dccc06fd04f7bd64e63e755bce63f1f26db042cd","user":{"login":"1ec5","id":1231218,"node_id":"MDQ6VXNlcjEyMzEyMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1231218?v=4","gravatar_id":"","url":"https://api.github.com/users/1ec5","html_url":"https://github.com/1ec5","followers_url":"https://api.github.com/users/1ec5/followers","following_url":"https://api.github.com/users/1ec5/following{/other_user}","gists_url":"https://api.github.com/users/1ec5/gists{/gist_id}","starred_url":"https://api.github.com/users/1ec5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1ec5/subscriptions","organizations_url":"https://api.github.com/users/1ec5/orgs","repos_url":"https://api.github.com/users/1ec5/repos","events_url":"https://api.github.com/users/1ec5/events{/privacy}","received_events_url":"https://api.github.com/users/1ec5/received_events","type":"User","site_admin":false},"body":"If `attributes` can be `nil`, then it should be marked as `nullable` in the signature of this function.","created_at":"2018-12-11T17:15:55Z","updated_at":"2018-12-11T17:18:05Z","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/13543#discussion_r240708468","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/13543","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments/240708468"},"html":{"href":"https://github.com/mapbox/mapbox-gl-native/pull/13543#discussion_r240708468"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/13543"}}},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/13543","id":237727775,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NzI3Nzc1","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/13543","diff_url":"https://github.com/mapbox/mapbox-gl-native/pull/13543.diff","patch_url":"https://github.com/mapbox/mapbox-gl-native/pull/13543.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/13543","number":13543,"state":"open","locked":false,"title":"[ios, darwin] Check if MGLFeature.attributes is nil and add integration test","user":{"login":"alexshalamov","id":1001009,"node_id":"MDQ6VXNlcjEwMDEwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/1001009?v=4","gravatar_id":"","url":"https://api.github.com/users/alexshalamov","html_url":"https://github.com/alexshalamov","followers_url":"https://api.github.com/users/alexshalamov/followers","following_url":"https://api.github.com/users/alexshalamov/following{/other_user}","gists_url":"https://api.github.com/users/alexshalamov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexshalamov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexshalamov/subscriptions","organizations_url":"https://api.github.com/users/alexshalamov/orgs","repos_url":"https://api.github.com/users/alexshalamov/repos","events_url":"https://api.github.com/users/alexshalamov/events{/privacy}","received_events_url":"https://api.github.com/users/alexshalamov/received_events","type":"User","site_admin":false},"body":"This PR introduces check for nil attributes, when MGLFeature object is converted to core mbgl::Feature.\r\n\r\nIntegration test \"testShapeSourceWithLineDistanceMetrics\" is added to verify that MGLFeature is correctly converted.\r\n\r\nFixes issue #13378","created_at":"2018-12-11T15:44:54Z","updated_at":"2018-12-11T17:18:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52e6743801d5ce92702dc02fe78898b1f2585e93","assignee":null,"assignees":[],"requested_reviewers":[{"login":"frederoni","id":764476,"node_id":"MDQ6VXNlcjc2NDQ3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/764476?v=4","gravatar_id":"","url":"https://api.github.com/users/frederoni","html_url":"https://github.com/frederoni","followers_url":"https://api.github.com/users/frederoni/followers","following_url":"https://api.github.com/users/frederoni/following{/other_user}","gists_url":"https://api.github.com/users/frederoni/gists{/gist_id}","starred_url":"https://api.github.com/users/frederoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frederoni/subscriptions","organizations_url":"https://api.github.com/users/frederoni/orgs","repos_url":"https://api.github.com/users/frederoni/repos","events_url":"https://api.github.com/users/frederoni/events{/privacy}","received_events_url":"https://api.github.com/users/frederoni/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"maps-ios-reviewers","id":2987920,"node_id":"MDQ6VGVhbTI5ODc5MjA=","slug":"maps-ios-reviewers","description":"Subset of the maps-ios team requested (not required) for macos/ios PRs","privacy":"closed","url":"https://api.github.com/teams/2987920","members_url":"https://api.github.com/teams/2987920/members{/member}","repositories_url":"https://api.github.com/teams/2987920/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/13543/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/13543/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/13543/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/dccc06fd04f7bd64e63e755bce63f1f26db042cd","head":{"label":"mapbox:alexshalamov_fix_for_13378","ref":"alexshalamov_fix_for_13378","sha":"dccc06fd04f7bd64e63e755bce63f1f26db042cd","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":16286131,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI4NjEzMQ==","name":"mapbox-gl-native","full_name":"mapbox/mapbox-gl-native","private":false,"owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapbox/mapbox-gl-native","description":"Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native","forks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/deployments","created_at":"2014-01-27T17:14:48Z","updated_at":"2018-12-11T17:08:27Z","pushed_at":"2018-12-11T17:08:20Z","git_url":"git://github.com/mapbox/mapbox-gl-native.git","ssh_url":"git@github.com:mapbox/mapbox-gl-native.git","clone_url":"https://github.com/mapbox/mapbox-gl-native.git","svn_url":"https://github.com/mapbox/mapbox-gl-native","homepage":"https://mapbox.com/mobile","size":329004,"stargazers_count":2995,"watchers_count":2995,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":934,"mirror_url":null,"archived":false,"open_issues_count":486,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":934,"open_issues":486,"watchers":2995,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"c043d01e14900461935ebee490fd93e492c5e7ae","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":16286131,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI4NjEzMQ==","name":"mapbox-gl-native","full_name":"mapbox/mapbox-gl-native","private":false,"owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapbox/mapbox-gl-native","description":"Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native","forks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/deployments","created_at":"2014-01-27T17:14:48Z","updated_at":"2018-12-11T17:08:27Z","pushed_at":"2018-12-11T17:08:20Z","git_url":"git://github.com/mapbox/mapbox-gl-native.git","ssh_url":"git@github.com:mapbox/mapbox-gl-native.git","clone_url":"https://github.com/mapbox/mapbox-gl-native.git","svn_url":"https://github.com/mapbox/mapbox-gl-native","homepage":"https://mapbox.com/mobile","size":329004,"stargazers_count":2995,"watchers_count":2995,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":934,"mirror_url":null,"archived":false,"open_issues_count":486,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":934,"open_issues":486,"watchers":2995,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/13543"},"html":{"href":"https://github.com/mapbox/mapbox-gl-native/pull/13543"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/13543"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/13543/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/13543/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/13543/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/dccc06fd04f7bd64e63e755bce63f1f26db042cd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"1ec5"}}