{"action":"created","comment":{"url":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/comments/206504636","pull_request_review_id":141924701,"id":206504636,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjUwNDYzNg==","diff_hunk":"@@ -136,6 +147,8 @@ const updateCurrency = (state, action) => {\n     return loop(state, Cmd.action(modalAction.openConfirmCurrencyChange(action.payload.currency)))\n   }\n \n+  const countryCode = state.location ? state.location.countryCode : config.defaultCurrency","path":"src/app/reducer-next/core.js","position":71,"original_position":71,"commit_id":"6e17a8decbe2a0bc207bc95cf62cfef29af381b0","original_commit_id":"6e17a8decbe2a0bc207bc95cf62cfef29af381b0","user":{"login":"webholics","id":101841,"node_id":"MDQ6VXNlcjEwMTg0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/101841?v=4","gravatar_id":"","url":"https://api.github.com/users/webholics","html_url":"https://github.com/webholics","followers_url":"https://api.github.com/users/webholics/followers","following_url":"https://api.github.com/users/webholics/following{/other_user}","gists_url":"https://api.github.com/users/webholics/gists{/gist_id}","starred_url":"https://api.github.com/users/webholics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webholics/subscriptions","organizations_url":"https://api.github.com/users/webholics/orgs","repos_url":"https://api.github.com/users/webholics/repos","events_url":"https://api.github.com/users/webholics/events{/privacy}","received_events_url":"https://api.github.com/users/webholics/received_events","type":"User","site_admin":false},"body":"warum is der fallback für countryCode die defaultCurrency? das erschließt sich mir nicht.","created_at":"2018-07-31T12:24:35Z","updated_at":"2018-07-31T12:31:38Z","html_url":"https://github.com/all3dp/printing-engine-client/pull/682#discussion_r206504636","pull_request_url":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/682","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/comments/206504636"},"html":{"href":"https://github.com/all3dp/printing-engine-client/pull/682#discussion_r206504636"},"pull_request":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/682"}}},"pull_request":{"url":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/682","id":204822034,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODIyMDM0","html_url":"https://github.com/all3dp/printing-engine-client/pull/682","diff_url":"https://github.com/all3dp/printing-engine-client/pull/682.diff","patch_url":"https://github.com/all3dp/printing-engine-client/pull/682.patch","issue_url":"https://api.github.com/repos/all3dp/printing-engine-client/issues/682","number":682,"state":"open","locked":false,"title":"Move existing sections to material page and bind to state","user":{"login":"dreampulse","id":307704,"node_id":"MDQ6VXNlcjMwNzcwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/307704?v=4","gravatar_id":"","url":"https://api.github.com/users/dreampulse","html_url":"https://github.com/dreampulse","followers_url":"https://api.github.com/users/dreampulse/followers","following_url":"https://api.github.com/users/dreampulse/following{/other_user}","gists_url":"https://api.github.com/users/dreampulse/gists{/gist_id}","starred_url":"https://api.github.com/users/dreampulse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreampulse/subscriptions","organizations_url":"https://api.github.com/users/dreampulse/orgs","repos_url":"https://api.github.com/users/dreampulse/repos","events_url":"https://api.github.com/users/dreampulse/events{/privacy}","received_events_url":"https://api.github.com/users/dreampulse/received_events","type":"User","site_admin":false},"body":"Resolves #645\r\nResolves #681\r\n\r\n# Definition of Done\r\n\r\n- [x] The code does at least what is defined in the ticket and does not affect any other functionality\r\n- [x] The PR has a meaningful title\r\n- [x] There is a link to the issue-id\r\n- [x] There are no 'hacks' or shortcuts refactoring is preferred\r\n- [x] The happy case of the app was tested at least once manually\r\n\r\n\r\n# Open TODOs\r\n- [x] Add shipping price request\r\n- [x] Add missing tests\r\n- [x] Move untested functions from the container to a lib","created_at":"2018-07-30T14:25:26Z","updated_at":"2018-07-31T12:31:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7380b0d0bc0624463207150555b07f71380a3992","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":533982629,"node_id":"MDU6TGFiZWw1MzM5ODI2Mjk=","url":"https://api.github.com/repos/all3dp/printing-engine-client/labels/needs%20review","name":"needs review","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/682/commits","review_comments_url":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/682/comments","review_comment_url":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/all3dp/printing-engine-client/issues/682/comments","statuses_url":"https://api.github.com/repos/all3dp/printing-engine-client/statuses/6e17a8decbe2a0bc207bc95cf62cfef29af381b0","head":{"label":"all3dp:dev/material-page","ref":"dev/material-page","sha":"6e17a8decbe2a0bc207bc95cf62cfef29af381b0","user":{"login":"all3dp","id":11058590,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDU4NTkw","avatar_url":"https://avatars2.githubusercontent.com/u/11058590?v=4","gravatar_id":"","url":"https://api.github.com/users/all3dp","html_url":"https://github.com/all3dp","followers_url":"https://api.github.com/users/all3dp/followers","following_url":"https://api.github.com/users/all3dp/following{/other_user}","gists_url":"https://api.github.com/users/all3dp/gists{/gist_id}","starred_url":"https://api.github.com/users/all3dp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all3dp/subscriptions","organizations_url":"https://api.github.com/users/all3dp/orgs","repos_url":"https://api.github.com/users/all3dp/repos","events_url":"https://api.github.com/users/all3dp/events{/privacy}","received_events_url":"https://api.github.com/users/all3dp/received_events","type":"Organization","site_admin":false},"repo":{"id":74679671,"node_id":"MDEwOlJlcG9zaXRvcnk3NDY3OTY3MQ==","name":"printing-engine-client","full_name":"all3dp/printing-engine-client","owner":{"login":"all3dp","id":11058590,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDU4NTkw","avatar_url":"https://avatars2.githubusercontent.com/u/11058590?v=4","gravatar_id":"","url":"https://api.github.com/users/all3dp","html_url":"https://github.com/all3dp","followers_url":"https://api.github.com/users/all3dp/followers","following_url":"https://api.github.com/users/all3dp/following{/other_user}","gists_url":"https://api.github.com/users/all3dp/gists{/gist_id}","starred_url":"https://api.github.com/users/all3dp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all3dp/subscriptions","organizations_url":"https://api.github.com/users/all3dp/orgs","repos_url":"https://api.github.com/users/all3dp/repos","events_url":"https://api.github.com/users/all3dp/events{/privacy}","received_events_url":"https://api.github.com/users/all3dp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/all3dp/printing-engine-client","description":"The price comparison client","fork":false,"url":"https://api.github.com/repos/all3dp/printing-engine-client","forks_url":"https://api.github.com/repos/all3dp/printing-engine-client/forks","keys_url":"https://api.github.com/repos/all3dp/printing-engine-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all3dp/printing-engine-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all3dp/printing-engine-client/teams","hooks_url":"https://api.github.com/repos/all3dp/printing-engine-client/hooks","issue_events_url":"https://api.github.com/repos/all3dp/printing-engine-client/issues/events{/number}","events_url":"https://api.github.com/repos/all3dp/printing-engine-client/events","assignees_url":"https://api.github.com/repos/all3dp/printing-engine-client/assignees{/user}","branches_url":"https://api.github.com/repos/all3dp/printing-engine-client/branches{/branch}","tags_url":"https://api.github.com/repos/all3dp/printing-engine-client/tags","blobs_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all3dp/printing-engine-client/statuses/{sha}","languages_url":"https://api.github.com/repos/all3dp/printing-engine-client/languages","stargazers_url":"https://api.github.com/repos/all3dp/printing-engine-client/stargazers","contributors_url":"https://api.github.com/repos/all3dp/printing-engine-client/contributors","subscribers_url":"https://api.github.com/repos/all3dp/printing-engine-client/subscribers","subscription_url":"https://api.github.com/repos/all3dp/printing-engine-client/subscription","commits_url":"https://api.github.com/repos/all3dp/printing-engine-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/all3dp/printing-engine-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/all3dp/printing-engine-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/all3dp/printing-engine-client/contents/{+path}","compare_url":"https://api.github.com/repos/all3dp/printing-engine-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all3dp/printing-engine-client/merges","archive_url":"https://api.github.com/repos/all3dp/printing-engine-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all3dp/printing-engine-client/downloads","issues_url":"https://api.github.com/repos/all3dp/printing-engine-client/issues{/number}","pulls_url":"https://api.github.com/repos/all3dp/printing-engine-client/pulls{/number}","milestones_url":"https://api.github.com/repos/all3dp/printing-engine-client/milestones{/number}","notifications_url":"https://api.github.com/repos/all3dp/printing-engine-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all3dp/printing-engine-client/labels{/name}","releases_url":"https://api.github.com/repos/all3dp/printing-engine-client/releases{/id}","deployments_url":"https://api.github.com/repos/all3dp/printing-engine-client/deployments","created_at":"2016-11-24T14:19:39Z","updated_at":"2018-07-30T14:38:06Z","pushed_at":"2018-07-31T10:06:40Z","git_url":"git://github.com/all3dp/printing-engine-client.git","ssh_url":"git@github.com:all3dp/printing-engine-client.git","clone_url":"https://github.com/all3dp/printing-engine-client.git","svn_url":"https://github.com/all3dp/printing-engine-client","homepage":"http://print.all3dp.com","size":3084,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":132,"watchers":1,"default_branch":"multi-model-upload"}},"base":{"label":"all3dp:multi-model-upload","ref":"multi-model-upload","sha":"d8e1177db45d661a22dea2ad9399b9c7c251f82d","user":{"login":"all3dp","id":11058590,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDU4NTkw","avatar_url":"https://avatars2.githubusercontent.com/u/11058590?v=4","gravatar_id":"","url":"https://api.github.com/users/all3dp","html_url":"https://github.com/all3dp","followers_url":"https://api.github.com/users/all3dp/followers","following_url":"https://api.github.com/users/all3dp/following{/other_user}","gists_url":"https://api.github.com/users/all3dp/gists{/gist_id}","starred_url":"https://api.github.com/users/all3dp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all3dp/subscriptions","organizations_url":"https://api.github.com/users/all3dp/orgs","repos_url":"https://api.github.com/users/all3dp/repos","events_url":"https://api.github.com/users/all3dp/events{/privacy}","received_events_url":"https://api.github.com/users/all3dp/received_events","type":"Organization","site_admin":false},"repo":{"id":74679671,"node_id":"MDEwOlJlcG9zaXRvcnk3NDY3OTY3MQ==","name":"printing-engine-client","full_name":"all3dp/printing-engine-client","owner":{"login":"all3dp","id":11058590,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDU4NTkw","avatar_url":"https://avatars2.githubusercontent.com/u/11058590?v=4","gravatar_id":"","url":"https://api.github.com/users/all3dp","html_url":"https://github.com/all3dp","followers_url":"https://api.github.com/users/all3dp/followers","following_url":"https://api.github.com/users/all3dp/following{/other_user}","gists_url":"https://api.github.com/users/all3dp/gists{/gist_id}","starred_url":"https://api.github.com/users/all3dp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all3dp/subscriptions","organizations_url":"https://api.github.com/users/all3dp/orgs","repos_url":"https://api.github.com/users/all3dp/repos","events_url":"https://api.github.com/users/all3dp/events{/privacy}","received_events_url":"https://api.github.com/users/all3dp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/all3dp/printing-engine-client","description":"The price comparison client","fork":false,"url":"https://api.github.com/repos/all3dp/printing-engine-client","forks_url":"https://api.github.com/repos/all3dp/printing-engine-client/forks","keys_url":"https://api.github.com/repos/all3dp/printing-engine-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all3dp/printing-engine-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all3dp/printing-engine-client/teams","hooks_url":"https://api.github.com/repos/all3dp/printing-engine-client/hooks","issue_events_url":"https://api.github.com/repos/all3dp/printing-engine-client/issues/events{/number}","events_url":"https://api.github.com/repos/all3dp/printing-engine-client/events","assignees_url":"https://api.github.com/repos/all3dp/printing-engine-client/assignees{/user}","branches_url":"https://api.github.com/repos/all3dp/printing-engine-client/branches{/branch}","tags_url":"https://api.github.com/repos/all3dp/printing-engine-client/tags","blobs_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all3dp/printing-engine-client/statuses/{sha}","languages_url":"https://api.github.com/repos/all3dp/printing-engine-client/languages","stargazers_url":"https://api.github.com/repos/all3dp/printing-engine-client/stargazers","contributors_url":"https://api.github.com/repos/all3dp/printing-engine-client/contributors","subscribers_url":"https://api.github.com/repos/all3dp/printing-engine-client/subscribers","subscription_url":"https://api.github.com/repos/all3dp/printing-engine-client/subscription","commits_url":"https://api.github.com/repos/all3dp/printing-engine-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/all3dp/printing-engine-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/all3dp/printing-engine-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/all3dp/printing-engine-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/all3dp/printing-engine-client/contents/{+path}","compare_url":"https://api.github.com/repos/all3dp/printing-engine-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all3dp/printing-engine-client/merges","archive_url":"https://api.github.com/repos/all3dp/printing-engine-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all3dp/printing-engine-client/downloads","issues_url":"https://api.github.com/repos/all3dp/printing-engine-client/issues{/number}","pulls_url":"https://api.github.com/repos/all3dp/printing-engine-client/pulls{/number}","milestones_url":"https://api.github.com/repos/all3dp/printing-engine-client/milestones{/number}","notifications_url":"https://api.github.com/repos/all3dp/printing-engine-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all3dp/printing-engine-client/labels{/name}","releases_url":"https://api.github.com/repos/all3dp/printing-engine-client/releases{/id}","deployments_url":"https://api.github.com/repos/all3dp/printing-engine-client/deployments","created_at":"2016-11-24T14:19:39Z","updated_at":"2018-07-30T14:38:06Z","pushed_at":"2018-07-31T10:06:40Z","git_url":"git://github.com/all3dp/printing-engine-client.git","ssh_url":"git@github.com:all3dp/printing-engine-client.git","clone_url":"https://github.com/all3dp/printing-engine-client.git","svn_url":"https://github.com/all3dp/printing-engine-client","homepage":"http://print.all3dp.com","size":3084,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":132,"watchers":1,"default_branch":"multi-model-upload"}},"_links":{"self":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/682"},"html":{"href":"https://github.com/all3dp/printing-engine-client/pull/682"},"issue":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/issues/682"},"comments":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/issues/682/comments"},"review_comments":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/682/comments"},"review_comment":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/pulls/682/commits"},"statuses":{"href":"https://api.github.com/repos/all3dp/printing-engine-client/statuses/6e17a8decbe2a0bc207bc95cf62cfef29af381b0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"webholics"}}