{"action":"created","comment":{"url":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments/202102353","pull_request_review_id":136734593,"id":202102353,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjEwMjM1Mw==","diff_hunk":"@@ -94,7 +94,6 @@\n \n    public JDBCJournalImpl(DataSource dataSource,\n                           SQLProvider provider,\n-                          String tableName,","path":"artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/journal/JDBCJournalImpl.java","position":4,"original_position":4,"commit_id":"9df9a1a4586a5f960a818cfa94299bc45fe8ba04","original_commit_id":"9df9a1a4586a5f960a818cfa94299bc45fe8ba04","user":{"login":"clebertsuconic","id":750514,"node_id":"MDQ6VXNlcjc1MDUxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/750514?v=4","gravatar_id":"","url":"https://api.github.com/users/clebertsuconic","html_url":"https://github.com/clebertsuconic","followers_url":"https://api.github.com/users/clebertsuconic/followers","following_url":"https://api.github.com/users/clebertsuconic/following{/other_user}","gists_url":"https://api.github.com/users/clebertsuconic/gists{/gist_id}","starred_url":"https://api.github.com/users/clebertsuconic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebertsuconic/subscriptions","organizations_url":"https://api.github.com/users/clebertsuconic/orgs","repos_url":"https://api.github.com/users/clebertsuconic/repos","events_url":"https://api.github.com/users/clebertsuconic/events{/privacy}","received_events_url":"https://api.github.com/users/clebertsuconic/received_events","type":"User","site_admin":false},"body":"nice catch!","created_at":"2018-07-12T16:39:33Z","updated_at":"2018-07-12T16:39:33Z","html_url":"https://github.com/apache/activemq-artemis/pull/2182#discussion_r202102353","pull_request_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2182","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments/202102353"},"html":{"href":"https://github.com/apache/activemq-artemis/pull/2182#discussion_r202102353"},"pull_request":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/2182"}}},"pull_request":{"url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2182","id":201000437,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDAwNDM3","html_url":"https://github.com/apache/activemq-artemis/pull/2182","diff_url":"https://github.com/apache/activemq-artemis/pull/2182.diff","patch_url":"https://github.com/apache/activemq-artemis/pull/2182.patch","issue_url":"https://api.github.com/repos/apache/activemq-artemis/issues/2182","number":2182,"state":"open","locked":false,"title":"ARTEMIS-1981 JDBCJournalImpl constructor isn't using tableName parameter","user":{"login":"franz1981","id":13125299,"node_id":"MDQ6VXNlcjEzMTI1Mjk5","avatar_url":"https://avatars2.githubusercontent.com/u/13125299?v=4","gravatar_id":"","url":"https://api.github.com/users/franz1981","html_url":"https://github.com/franz1981","followers_url":"https://api.github.com/users/franz1981/followers","following_url":"https://api.github.com/users/franz1981/following{/other_user}","gists_url":"https://api.github.com/users/franz1981/gists{/gist_id}","starred_url":"https://api.github.com/users/franz1981/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franz1981/subscriptions","organizations_url":"https://api.github.com/users/franz1981/orgs","repos_url":"https://api.github.com/users/franz1981/repos","events_url":"https://api.github.com/users/franz1981/events{/privacy}","received_events_url":"https://api.github.com/users/franz1981/received_events","type":"User","site_admin":false},"body":"Removed the unused/redundant constructor parameter tableName","created_at":"2018-07-12T13:25:33Z","updated_at":"2018-07-12T16:39:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cb07a14a7a22e3e469a96ff32009f2ab5c8e8ac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2182/commits","review_comments_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2182/comments","review_comment_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/activemq-artemis/issues/2182/comments","statuses_url":"https://api.github.com/repos/apache/activemq-artemis/statuses/9df9a1a4586a5f960a818cfa94299bc45fe8ba04","head":{"label":"franz1981:ARTEMIS-1981","ref":"ARTEMIS-1981","sha":"9df9a1a4586a5f960a818cfa94299bc45fe8ba04","user":{"login":"franz1981","id":13125299,"node_id":"MDQ6VXNlcjEzMTI1Mjk5","avatar_url":"https://avatars2.githubusercontent.com/u/13125299?v=4","gravatar_id":"","url":"https://api.github.com/users/franz1981","html_url":"https://github.com/franz1981","followers_url":"https://api.github.com/users/franz1981/followers","following_url":"https://api.github.com/users/franz1981/following{/other_user}","gists_url":"https://api.github.com/users/franz1981/gists{/gist_id}","starred_url":"https://api.github.com/users/franz1981/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franz1981/subscriptions","organizations_url":"https://api.github.com/users/franz1981/orgs","repos_url":"https://api.github.com/users/franz1981/repos","events_url":"https://api.github.com/users/franz1981/events{/privacy}","received_events_url":"https://api.github.com/users/franz1981/received_events","type":"User","site_admin":false},"repo":{"id":57105719,"node_id":"MDEwOlJlcG9zaXRvcnk1NzEwNTcxOQ==","name":"activemq-artemis","full_name":"franz1981/activemq-artemis","owner":{"login":"franz1981","id":13125299,"node_id":"MDQ6VXNlcjEzMTI1Mjk5","avatar_url":"https://avatars2.githubusercontent.com/u/13125299?v=4","gravatar_id":"","url":"https://api.github.com/users/franz1981","html_url":"https://github.com/franz1981","followers_url":"https://api.github.com/users/franz1981/followers","following_url":"https://api.github.com/users/franz1981/following{/other_user}","gists_url":"https://api.github.com/users/franz1981/gists{/gist_id}","starred_url":"https://api.github.com/users/franz1981/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franz1981/subscriptions","organizations_url":"https://api.github.com/users/franz1981/orgs","repos_url":"https://api.github.com/users/franz1981/repos","events_url":"https://api.github.com/users/franz1981/events{/privacy}","received_events_url":"https://api.github.com/users/franz1981/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/franz1981/activemq-artemis","description":"Mirror of Apache ActiveMQ Artemis","fork":true,"url":"https://api.github.com/repos/franz1981/activemq-artemis","forks_url":"https://api.github.com/repos/franz1981/activemq-artemis/forks","keys_url":"https://api.github.com/repos/franz1981/activemq-artemis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/franz1981/activemq-artemis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/franz1981/activemq-artemis/teams","hooks_url":"https://api.github.com/repos/franz1981/activemq-artemis/hooks","issue_events_url":"https://api.github.com/repos/franz1981/activemq-artemis/issues/events{/number}","events_url":"https://api.github.com/repos/franz1981/activemq-artemis/events","assignees_url":"https://api.github.com/repos/franz1981/activemq-artemis/assignees{/user}","branches_url":"https://api.github.com/repos/franz1981/activemq-artemis/branches{/branch}","tags_url":"https://api.github.com/repos/franz1981/activemq-artemis/tags","blobs_url":"https://api.github.com/repos/franz1981/activemq-artemis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/franz1981/activemq-artemis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/franz1981/activemq-artemis/git/refs{/sha}","trees_url":"https://api.github.com/repos/franz1981/activemq-artemis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/franz1981/activemq-artemis/statuses/{sha}","languages_url":"https://api.github.com/repos/franz1981/activemq-artemis/languages","stargazers_url":"https://api.github.com/repos/franz1981/activemq-artemis/stargazers","contributors_url":"https://api.github.com/repos/franz1981/activemq-artemis/contributors","subscribers_url":"https://api.github.com/repos/franz1981/activemq-artemis/subscribers","subscription_url":"https://api.github.com/repos/franz1981/activemq-artemis/subscription","commits_url":"https://api.github.com/repos/franz1981/activemq-artemis/commits{/sha}","git_commits_url":"https://api.github.com/repos/franz1981/activemq-artemis/git/commits{/sha}","comments_url":"https://api.github.com/repos/franz1981/activemq-artemis/comments{/number}","issue_comment_url":"https://api.github.com/repos/franz1981/activemq-artemis/issues/comments{/number}","contents_url":"https://api.github.com/repos/franz1981/activemq-artemis/contents/{+path}","compare_url":"https://api.github.com/repos/franz1981/activemq-artemis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/franz1981/activemq-artemis/merges","archive_url":"https://api.github.com/repos/franz1981/activemq-artemis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/franz1981/activemq-artemis/downloads","issues_url":"https://api.github.com/repos/franz1981/activemq-artemis/issues{/number}","pulls_url":"https://api.github.com/repos/franz1981/activemq-artemis/pulls{/number}","milestones_url":"https://api.github.com/repos/franz1981/activemq-artemis/milestones{/number}","notifications_url":"https://api.github.com/repos/franz1981/activemq-artemis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/franz1981/activemq-artemis/labels{/name}","releases_url":"https://api.github.com/repos/franz1981/activemq-artemis/releases{/id}","deployments_url":"https://api.github.com/repos/franz1981/activemq-artemis/deployments","created_at":"2016-04-26T07:03:57Z","updated_at":"2016-04-26T07:04:06Z","pushed_at":"2018-07-12T13:24:55Z","git_url":"git://github.com/franz1981/activemq-artemis.git","ssh_url":"git@github.com:franz1981/activemq-artemis.git","clone_url":"https://github.com/franz1981/activemq-artemis.git","svn_url":"https://github.com/franz1981/activemq-artemis","homepage":"","size":56250,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7d7daa1ff24522dab7be1902a2494a3fe5f2e7d1","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":36057260,"node_id":"MDEwOlJlcG9zaXRvcnkzNjA1NzI2MA==","name":"activemq-artemis","full_name":"apache/activemq-artemis","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/activemq-artemis","description":"Mirror of Apache ActiveMQ Artemis","fork":false,"url":"https://api.github.com/repos/apache/activemq-artemis","forks_url":"https://api.github.com/repos/apache/activemq-artemis/forks","keys_url":"https://api.github.com/repos/apache/activemq-artemis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/activemq-artemis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/activemq-artemis/teams","hooks_url":"https://api.github.com/repos/apache/activemq-artemis/hooks","issue_events_url":"https://api.github.com/repos/apache/activemq-artemis/issues/events{/number}","events_url":"https://api.github.com/repos/apache/activemq-artemis/events","assignees_url":"https://api.github.com/repos/apache/activemq-artemis/assignees{/user}","branches_url":"https://api.github.com/repos/apache/activemq-artemis/branches{/branch}","tags_url":"https://api.github.com/repos/apache/activemq-artemis/tags","blobs_url":"https://api.github.com/repos/apache/activemq-artemis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/activemq-artemis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/activemq-artemis/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/activemq-artemis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/activemq-artemis/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/activemq-artemis/languages","stargazers_url":"https://api.github.com/repos/apache/activemq-artemis/stargazers","contributors_url":"https://api.github.com/repos/apache/activemq-artemis/contributors","subscribers_url":"https://api.github.com/repos/apache/activemq-artemis/subscribers","subscription_url":"https://api.github.com/repos/apache/activemq-artemis/subscription","commits_url":"https://api.github.com/repos/apache/activemq-artemis/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/activemq-artemis/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/activemq-artemis/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/activemq-artemis/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/activemq-artemis/contents/{+path}","compare_url":"https://api.github.com/repos/apache/activemq-artemis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/activemq-artemis/merges","archive_url":"https://api.github.com/repos/apache/activemq-artemis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/activemq-artemis/downloads","issues_url":"https://api.github.com/repos/apache/activemq-artemis/issues{/number}","pulls_url":"https://api.github.com/repos/apache/activemq-artemis/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/activemq-artemis/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/activemq-artemis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/activemq-artemis/labels{/name}","releases_url":"https://api.github.com/repos/apache/activemq-artemis/releases{/id}","deployments_url":"https://api.github.com/repos/apache/activemq-artemis/deployments","created_at":"2015-05-22T07:00:05Z","updated_at":"2018-07-12T14:55:21Z","pushed_at":"2018-07-12T14:55:15Z","git_url":"git://github.com/apache/activemq-artemis.git","ssh_url":"git@github.com:apache/activemq-artemis.git","clone_url":"https://github.com/apache/activemq-artemis.git","svn_url":"https://github.com/apache/activemq-artemis","homepage":"","size":52709,"stargazers_count":329,"watchers_count":329,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":357,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":357,"open_issues":24,"watchers":329,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/2182"},"html":{"href":"https://github.com/apache/activemq-artemis/pull/2182"},"issue":{"href":"https://api.github.com/repos/apache/activemq-artemis/issues/2182"},"comments":{"href":"https://api.github.com/repos/apache/activemq-artemis/issues/2182/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/2182/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/2182/commits"},"statuses":{"href":"https://api.github.com/repos/apache/activemq-artemis/statuses/9df9a1a4586a5f960a818cfa94299bc45fe8ba04"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"clebertsuconic"}}