{"action":"opened","number":1105,"pull_request":{"url":"https://api.github.com/repos/transcom/mymove/pulls/1105","id":221614884,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNjE0ODg0","html_url":"https://github.com/transcom/mymove/pull/1105","diff_url":"https://github.com/transcom/mymove/pull/1105.diff","patch_url":"https://github.com/transcom/mymove/pull/1105.patch","issue_url":"https://api.github.com/repos/transcom/mymove/issues/1105","number":1105,"state":"open","locked":false,"title":"Fix test data for TSPs (GBLOCs and Duty Stations)","user":{"login":"chrisgilmerproj","id":219296,"node_id":"MDQ6VXNlcjIxOTI5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/219296?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisgilmerproj","html_url":"https://github.com/chrisgilmerproj","followers_url":"https://api.github.com/users/chrisgilmerproj/followers","following_url":"https://api.github.com/users/chrisgilmerproj/following{/other_user}","gists_url":"https://api.github.com/users/chrisgilmerproj/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisgilmerproj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisgilmerproj/subscriptions","organizations_url":"https://api.github.com/users/chrisgilmerproj/orgs","repos_url":"https://api.github.com/users/chrisgilmerproj/repos","events_url":"https://api.github.com/users/chrisgilmerproj/events{/privacy}","received_events_url":"https://api.github.com/users/chrisgilmerproj/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nRan into an issue while trying to get the moves dates summary where the move had 0 miles.  That's because the data was incorrect and I try to address it in this PR.\r\n\r\nTwo things here to make test data better:\r\n\r\n- Separate the Source and Destination GBLOC's (and use realistic data)\r\n- Make the New Duty Station a different zip code than the Service Member Duty Station\r\n\r\n## Reviewer Notes\r\n\r\nNope.\r\n\r\n## Setup\r\n\r\n```sh\r\n make db_dev_reset && make db_dev_migrate && go run ./cmd/generate_test_data/main.go -scenario=7\r\n```\r\n\r\nGo to http://tsplocal:3000/internal/docs#/moves/showMoveDatesSummary\r\n\r\nEnter a MoveID and a date (format like `2018-10-09`) and execute.  You should get a 200 response back.\r\n\r\n## Code Review Verification Steps\r\n\r\n* [ ] End to end tests pass (`make e2e_test`).\r\n* [x] Request review from a member of a different team.","created_at":"2018-10-09T23:17:22Z","updated_at":"2018-10-09T23:17:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"chrisgilmerproj","id":219296,"node_id":"MDQ6VXNlcjIxOTI5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/219296?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisgilmerproj","html_url":"https://github.com/chrisgilmerproj","followers_url":"https://api.github.com/users/chrisgilmerproj/followers","following_url":"https://api.github.com/users/chrisgilmerproj/following{/other_user}","gists_url":"https://api.github.com/users/chrisgilmerproj/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisgilmerproj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisgilmerproj/subscriptions","organizations_url":"https://api.github.com/users/chrisgilmerproj/orgs","repos_url":"https://api.github.com/users/chrisgilmerproj/repos","events_url":"https://api.github.com/users/chrisgilmerproj/events{/privacy}","received_events_url":"https://api.github.com/users/chrisgilmerproj/received_events","type":"User","site_admin":false},"assignees":[{"login":"chrisgilmerproj","id":219296,"node_id":"MDQ6VXNlcjIxOTI5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/219296?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisgilmerproj","html_url":"https://github.com/chrisgilmerproj","followers_url":"https://api.github.com/users/chrisgilmerproj/followers","following_url":"https://api.github.com/users/chrisgilmerproj/following{/other_user}","gists_url":"https://api.github.com/users/chrisgilmerproj/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisgilmerproj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisgilmerproj/subscriptions","organizations_url":"https://api.github.com/users/chrisgilmerproj/orgs","repos_url":"https://api.github.com/users/chrisgilmerproj/repos","events_url":"https://api.github.com/users/chrisgilmerproj/events{/privacy}","received_events_url":"https://api.github.com/users/chrisgilmerproj/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/transcom/mymove/pulls/1105/commits","review_comments_url":"https://api.github.com/repos/transcom/mymove/pulls/1105/comments","review_comment_url":"https://api.github.com/repos/transcom/mymove/pulls/comments{/number}","comments_url":"https://api.github.com/repos/transcom/mymove/issues/1105/comments","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/6dbf402526b59c52d63ac42cbf9b6c5a315f4368","head":{"label":"transcom:cg_destination_gbloc_and_diff_duty_stations","ref":"cg_destination_gbloc_and_diff_duty_stations","sha":"6dbf402526b59c52d63ac42cbf9b6c5a315f4368","user":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"repo":{"id":114694829,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2OTQ4Mjk=","name":"mymove","full_name":"transcom/mymove","private":false,"owner":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/transcom/mymove","description":"Personal Property Prototype","fork":false,"url":"https://api.github.com/repos/transcom/mymove","forks_url":"https://api.github.com/repos/transcom/mymove/forks","keys_url":"https://api.github.com/repos/transcom/mymove/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transcom/mymove/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transcom/mymove/teams","hooks_url":"https://api.github.com/repos/transcom/mymove/hooks","issue_events_url":"https://api.github.com/repos/transcom/mymove/issues/events{/number}","events_url":"https://api.github.com/repos/transcom/mymove/events","assignees_url":"https://api.github.com/repos/transcom/mymove/assignees{/user}","branches_url":"https://api.github.com/repos/transcom/mymove/branches{/branch}","tags_url":"https://api.github.com/repos/transcom/mymove/tags","blobs_url":"https://api.github.com/repos/transcom/mymove/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transcom/mymove/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transcom/mymove/git/refs{/sha}","trees_url":"https://api.github.com/repos/transcom/mymove/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/{sha}","languages_url":"https://api.github.com/repos/transcom/mymove/languages","stargazers_url":"https://api.github.com/repos/transcom/mymove/stargazers","contributors_url":"https://api.github.com/repos/transcom/mymove/contributors","subscribers_url":"https://api.github.com/repos/transcom/mymove/subscribers","subscription_url":"https://api.github.com/repos/transcom/mymove/subscription","commits_url":"https://api.github.com/repos/transcom/mymove/commits{/sha}","git_commits_url":"https://api.github.com/repos/transcom/mymove/git/commits{/sha}","comments_url":"https://api.github.com/repos/transcom/mymove/comments{/number}","issue_comment_url":"https://api.github.com/repos/transcom/mymove/issues/comments{/number}","contents_url":"https://api.github.com/repos/transcom/mymove/contents/{+path}","compare_url":"https://api.github.com/repos/transcom/mymove/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transcom/mymove/merges","archive_url":"https://api.github.com/repos/transcom/mymove/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transcom/mymove/downloads","issues_url":"https://api.github.com/repos/transcom/mymove/issues{/number}","pulls_url":"https://api.github.com/repos/transcom/mymove/pulls{/number}","milestones_url":"https://api.github.com/repos/transcom/mymove/milestones{/number}","notifications_url":"https://api.github.com/repos/transcom/mymove/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transcom/mymove/labels{/name}","releases_url":"https://api.github.com/repos/transcom/mymove/releases{/id}","deployments_url":"https://api.github.com/repos/transcom/mymove/deployments","created_at":"2017-12-18T22:41:12Z","updated_at":"2018-10-09T22:28:38Z","pushed_at":"2018-10-09T23:16:35Z","git_url":"git://github.com/transcom/mymove.git","ssh_url":"git@github.com:transcom/mymove.git","clone_url":"https://github.com/transcom/mymove.git","svn_url":"https://github.com/transcom/mymove","homepage":null,"size":27862,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":20,"watchers":15,"default_branch":"master"}},"base":{"label":"transcom:master","ref":"master","sha":"c77e4204feab1c06e67a4197f2d8c10de17549ae","user":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"repo":{"id":114694829,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2OTQ4Mjk=","name":"mymove","full_name":"transcom/mymove","private":false,"owner":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/transcom/mymove","description":"Personal Property Prototype","fork":false,"url":"https://api.github.com/repos/transcom/mymove","forks_url":"https://api.github.com/repos/transcom/mymove/forks","keys_url":"https://api.github.com/repos/transcom/mymove/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transcom/mymove/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transcom/mymove/teams","hooks_url":"https://api.github.com/repos/transcom/mymove/hooks","issue_events_url":"https://api.github.com/repos/transcom/mymove/issues/events{/number}","events_url":"https://api.github.com/repos/transcom/mymove/events","assignees_url":"https://api.github.com/repos/transcom/mymove/assignees{/user}","branches_url":"https://api.github.com/repos/transcom/mymove/branches{/branch}","tags_url":"https://api.github.com/repos/transcom/mymove/tags","blobs_url":"https://api.github.com/repos/transcom/mymove/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transcom/mymove/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transcom/mymove/git/refs{/sha}","trees_url":"https://api.github.com/repos/transcom/mymove/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/{sha}","languages_url":"https://api.github.com/repos/transcom/mymove/languages","stargazers_url":"https://api.github.com/repos/transcom/mymove/stargazers","contributors_url":"https://api.github.com/repos/transcom/mymove/contributors","subscribers_url":"https://api.github.com/repos/transcom/mymove/subscribers","subscription_url":"https://api.github.com/repos/transcom/mymove/subscription","commits_url":"https://api.github.com/repos/transcom/mymove/commits{/sha}","git_commits_url":"https://api.github.com/repos/transcom/mymove/git/commits{/sha}","comments_url":"https://api.github.com/repos/transcom/mymove/comments{/number}","issue_comment_url":"https://api.github.com/repos/transcom/mymove/issues/comments{/number}","contents_url":"https://api.github.com/repos/transcom/mymove/contents/{+path}","compare_url":"https://api.github.com/repos/transcom/mymove/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transcom/mymove/merges","archive_url":"https://api.github.com/repos/transcom/mymove/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transcom/mymove/downloads","issues_url":"https://api.github.com/repos/transcom/mymove/issues{/number}","pulls_url":"https://api.github.com/repos/transcom/mymove/pulls{/number}","milestones_url":"https://api.github.com/repos/transcom/mymove/milestones{/number}","notifications_url":"https://api.github.com/repos/transcom/mymove/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transcom/mymove/labels{/name}","releases_url":"https://api.github.com/repos/transcom/mymove/releases{/id}","deployments_url":"https://api.github.com/repos/transcom/mymove/deployments","created_at":"2017-12-18T22:41:12Z","updated_at":"2018-10-09T22:28:38Z","pushed_at":"2018-10-09T23:16:35Z","git_url":"git://github.com/transcom/mymove.git","ssh_url":"git@github.com:transcom/mymove.git","clone_url":"https://github.com/transcom/mymove.git","svn_url":"https://github.com/transcom/mymove","homepage":null,"size":27862,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":20,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/transcom/mymove/pulls/1105"},"html":{"href":"https://github.com/transcom/mymove/pull/1105"},"issue":{"href":"https://api.github.com/repos/transcom/mymove/issues/1105"},"comments":{"href":"https://api.github.com/repos/transcom/mymove/issues/1105/comments"},"review_comments":{"href":"https://api.github.com/repos/transcom/mymove/pulls/1105/comments"},"review_comment":{"href":"https://api.github.com/repos/transcom/mymove/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/transcom/mymove/pulls/1105/commits"},"statuses":{"href":"https://api.github.com/repos/transcom/mymove/statuses/6dbf402526b59c52d63ac42cbf9b6c5a315f4368"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":66,"deletions":14,"changed_files":9}}
{"actor":{"display_login":"chrisgilmerproj"}}