{"action":"created","issue":{"url":"https://api.github.com/repos/jfoenixadmin/JFoenix/issues/743","repository_url":"https://api.github.com/repos/jfoenixadmin/JFoenix","labels_url":"https://api.github.com/repos/jfoenixadmin/JFoenix/issues/743/labels{/name}","comments_url":"https://api.github.com/repos/jfoenixadmin/JFoenix/issues/743/comments","events_url":"https://api.github.com/repos/jfoenixadmin/JFoenix/issues/743/events","html_url":"https://github.com/jfoenixadmin/JFoenix/issues/743","id":329745059,"node_id":"MDU6SXNzdWUzMjk3NDUwNTk=","number":743,"title":"Resources should be in com.jfoenix package","user":{"login":"yushijinhun","id":8373027,"node_id":"MDQ6VXNlcjgzNzMwMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/8373027?v=4","gravatar_id":"","url":"https://api.github.com/users/yushijinhun","html_url":"https://github.com/yushijinhun","followers_url":"https://api.github.com/users/yushijinhun/followers","following_url":"https://api.github.com/users/yushijinhun/following{/other_user}","gists_url":"https://api.github.com/users/yushijinhun/gists{/gist_id}","starred_url":"https://api.github.com/users/yushijinhun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yushijinhun/subscriptions","organizations_url":"https://api.github.com/users/yushijinhun/orgs","repos_url":"https://api.github.com/users/yushijinhun/repos","events_url":"https://api.github.com/users/yushijinhun/events{/privacy}","received_events_url":"https://api.github.com/users/yushijinhun/received_events","type":"User","site_admin":false},"labels":[{"id":257791944,"node_id":"MDU6TGFiZWwyNTc3OTE5NDQ=","url":"https://api.github.com/repos/jfoenixadmin/JFoenix/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"84b6eb","default":false},{"id":909157407,"node_id":"MDU6TGFiZWw5MDkxNTc0MDc=","url":"https://api.github.com/repos/jfoenixadmin/JFoenix/labels/Version:%209.x","name":"Version: 9.x","color":"ef2d95","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-06T07:32:02Z","updated_at":"2018-06-06T16:53:04Z","closed_at":null,"author_association":"NONE","body":"## Description\r\nCurrently, the resources of JFoenix are in `css` and `font.roboto` packages. They should be in their own packages like `com.jfoenix.css` and `com.jfoenix.font.roboto`. Otherwise, if another module also puts its resources in such a package, a conflict will occur. Notice that this only happens on Java 9.\r\n\r\n## How to reproduce\r\nFile `module-info.java`:\r\n```java\r\nmodule moe.yushi.test {\r\n\trequires com.jfoenix;\r\n}\r\n```\r\nFile `moe/yushi/test/Test.java`:\r\n```java\r\npackage moe.yushi.test;\r\npublic class Test {\r\n\tpublic static void main(String[] args) {\r\n\t\tTest.class.getResourceAsStream(\"/css/something.fxml\");\r\n\t}\r\n}\r\n```\r\nFile `css/something.fxml`:\r\n```\r\nsomething\r\n```\r\n\r\nOutput:\r\n```\r\nError occurred during initialization of boot layer\r\njava.lang.LayerInstantiationException: Package css in both module com.jfoenix and module moe.yushi.test\r\n```"},"comment":{"url":"https://api.github.com/repos/jfoenixadmin/JFoenix/issues/comments/395138877","html_url":"https://github.com/jfoenixadmin/JFoenix/issues/743#issuecomment-395138877","issue_url":"https://api.github.com/repos/jfoenixadmin/JFoenix/issues/743","id":395138877,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTEzODg3Nw==","user":{"login":"skmedix","id":3246162,"node_id":"MDQ6VXNlcjMyNDYxNjI=","avatar_url":"https://avatars1.githubusercontent.com/u/3246162?v=4","gravatar_id":"","url":"https://api.github.com/users/skmedix","html_url":"https://github.com/skmedix","followers_url":"https://api.github.com/users/skmedix/followers","following_url":"https://api.github.com/users/skmedix/following{/other_user}","gists_url":"https://api.github.com/users/skmedix/gists{/gist_id}","starred_url":"https://api.github.com/users/skmedix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skmedix/subscriptions","organizations_url":"https://api.github.com/users/skmedix/orgs","repos_url":"https://api.github.com/users/skmedix/repos","events_url":"https://api.github.com/users/skmedix/events{/privacy}","received_events_url":"https://api.github.com/users/skmedix/received_events","type":"User","site_admin":false},"created_at":"2018-06-06T16:53:04Z","updated_at":"2018-06-06T16:53:04Z","author_association":"COLLABORATOR","body":"IMO it would be better to move `css` and `font`_s_ to `assets` package like:\r\n`com.jfoenix.assets.css`\r\n`com.jfoenix.assets.fonts.roboto`"}}
{"actor":{"display_login":"skmedix"}}