{"action":"created","comment":{"url":"https://api.github.com/repos/open-wc/open-wc/pulls/comments/238097286","pull_request_review_id":180560083,"id":238097286,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODA5NzI4Ng==","diff_hunk":"@@ -1,13 +1,22 @@\n /* eslint-disable */\n-const regex = /(?!\\()import.meta.url(?=\\))/g;\n+const regex = /import\\.meta/g;\n \n-/** Webpack loader to rewrite `import.meta.url` in modules to the source code file location. */\n+/**\n+ * Webpack loader to rewrite `import.meta` in modules with url data to the source code file location.\n+ *\n+ * @example\n+ * return import.meta;\n+ * // becomes: return ({ url: dummyGetHostWithNoSlashAtEnd() + '/relative/path/to/file.js' });\n+ *\n+ * return import.meta.url;\n+ * // becomes: return ({ url: dummyGetHostWithNoSlashAtEnd() + '/relative/path/to/file.js' }).url;\n+ */\n module.exports = function (source) {\n   const relativePath = this.context.substring(\n     this.context.indexOf(this.rootContext) + this.rootContext.length + 1,\n     this.resource.lastIndexOf('/') + 1\n   );\n \n   const fileName = this.resource.substring(this.resource.lastIndexOf('/') + 1);\n-  return source.replace(regex, () => `'./${relativePath}/${fileName}'`);\n+  return source.replace(regex, () => `({ url: window.location.href.replace(/((?:\\\\/[^/\\\\r\\\\n]*))$/g, '') + '/${relativePath}/${fileName}' })`);","path":"packages/webpack/loaders/import-meta-url-loader.js","position":24,"original_position":24,"commit_id":"e3d5ceb4e04b0dc111481eeba0d57026c8be157b","original_commit_id":"42e4a79243f157854cdf2d6dbb31609539e1d09a","user":{"login":"LarsDenBakker","id":11994993,"node_id":"MDQ6VXNlcjExOTk0OTkz","avatar_url":"https://avatars3.githubusercontent.com/u/11994993?v=4","gravatar_id":"","url":"https://api.github.com/users/LarsDenBakker","html_url":"https://github.com/LarsDenBakker","followers_url":"https://api.github.com/users/LarsDenBakker/followers","following_url":"https://api.github.com/users/LarsDenBakker/following{/other_user}","gists_url":"https://api.github.com/users/LarsDenBakker/gists{/gist_id}","starred_url":"https://api.github.com/users/LarsDenBakker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LarsDenBakker/subscriptions","organizations_url":"https://api.github.com/users/LarsDenBakker/orgs","repos_url":"https://api.github.com/users/LarsDenBakker/repos","events_url":"https://api.github.com/users/LarsDenBakker/events{/privacy}","received_events_url":"https://api.github.com/users/LarsDenBakker/received_events","type":"User","site_admin":false},"body":"Will do, when I finish my karma stuff","created_at":"2018-12-02T12:45:52Z","updated_at":"2018-12-02T12:45:53Z","html_url":"https://github.com/open-wc/open-wc/pull/64#discussion_r238097286","pull_request_url":"https://api.github.com/repos/open-wc/open-wc/pulls/64","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/open-wc/open-wc/pulls/comments/238097286"},"html":{"href":"https://github.com/open-wc/open-wc/pull/64#discussion_r238097286"},"pull_request":{"href":"https://api.github.com/repos/open-wc/open-wc/pulls/64"}},"in_reply_to_id":238094799},"pull_request":{"url":"https://api.github.com/repos/open-wc/open-wc/pulls/64","id":235225282,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjI1Mjgy","html_url":"https://github.com/open-wc/open-wc/pull/64","diff_url":"https://github.com/open-wc/open-wc/pull/64.diff","patch_url":"https://github.com/open-wc/open-wc/pull/64.patch","issue_url":"https://api.github.com/repos/open-wc/open-wc/issues/64","number":64,"state":"open","locked":false,"title":"fix(webpack): support import.meta; new URL(./, import.meta.url)","user":{"login":"daKmoR","id":24378,"node_id":"MDQ6VXNlcjI0Mzc4","avatar_url":"https://avatars2.githubusercontent.com/u/24378?v=4","gravatar_id":"","url":"https://api.github.com/users/daKmoR","html_url":"https://github.com/daKmoR","followers_url":"https://api.github.com/users/daKmoR/followers","following_url":"https://api.github.com/users/daKmoR/following{/other_user}","gists_url":"https://api.github.com/users/daKmoR/gists{/gist_id}","starred_url":"https://api.github.com/users/daKmoR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daKmoR/subscriptions","organizations_url":"https://api.github.com/users/daKmoR/orgs","repos_url":"https://api.github.com/users/daKmoR/repos","events_url":"https://api.github.com/users/daKmoR/events{/privacy}","received_events_url":"https://api.github.com/users/daKmoR/received_events","type":"User","site_admin":false},"body":"is ready now :)\r\n\r\ncloses: https://github.com/open-wc/open-wc/issues/62","created_at":"2018-12-01T23:14:45Z","updated_at":"2018-12-02T12:45:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2995aa3cad9b20a8f77d3c1ad8794d8d4b8e9ba9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-wc/open-wc/pulls/64/commits","review_comments_url":"https://api.github.com/repos/open-wc/open-wc/pulls/64/comments","review_comment_url":"https://api.github.com/repos/open-wc/open-wc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-wc/open-wc/issues/64/comments","statuses_url":"https://api.github.com/repos/open-wc/open-wc/statuses/e3d5ceb4e04b0dc111481eeba0d57026c8be157b","head":{"label":"open-wc:fix/metaUrl","ref":"fix/metaUrl","sha":"e3d5ceb4e04b0dc111481eeba0d57026c8be157b","user":{"login":"open-wc","id":42938647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyOTM4NjQ3","avatar_url":"https://avatars0.githubusercontent.com/u/42938647?v=4","gravatar_id":"","url":"https://api.github.com/users/open-wc","html_url":"https://github.com/open-wc","followers_url":"https://api.github.com/users/open-wc/followers","following_url":"https://api.github.com/users/open-wc/following{/other_user}","gists_url":"https://api.github.com/users/open-wc/gists{/gist_id}","starred_url":"https://api.github.com/users/open-wc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-wc/subscriptions","organizations_url":"https://api.github.com/users/open-wc/orgs","repos_url":"https://api.github.com/users/open-wc/repos","events_url":"https://api.github.com/users/open-wc/events{/privacy}","received_events_url":"https://api.github.com/users/open-wc/received_events","type":"Organization","site_admin":false},"repo":{"id":149014578,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkwMTQ1Nzg=","name":"open-wc","full_name":"open-wc/open-wc","private":false,"owner":{"login":"open-wc","id":42938647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyOTM4NjQ3","avatar_url":"https://avatars0.githubusercontent.com/u/42938647?v=4","gravatar_id":"","url":"https://api.github.com/users/open-wc","html_url":"https://github.com/open-wc","followers_url":"https://api.github.com/users/open-wc/followers","following_url":"https://api.github.com/users/open-wc/following{/other_user}","gists_url":"https://api.github.com/users/open-wc/gists{/gist_id}","starred_url":"https://api.github.com/users/open-wc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-wc/subscriptions","organizations_url":"https://api.github.com/users/open-wc/orgs","repos_url":"https://api.github.com/users/open-wc/repos","events_url":"https://api.github.com/users/open-wc/events{/privacy}","received_events_url":"https://api.github.com/users/open-wc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-wc/open-wc","description":"We want to provide a good set of default on how to facilitate your web component.","fork":false,"url":"https://api.github.com/repos/open-wc/open-wc","forks_url":"https://api.github.com/repos/open-wc/open-wc/forks","keys_url":"https://api.github.com/repos/open-wc/open-wc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-wc/open-wc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-wc/open-wc/teams","hooks_url":"https://api.github.com/repos/open-wc/open-wc/hooks","issue_events_url":"https://api.github.com/repos/open-wc/open-wc/issues/events{/number}","events_url":"https://api.github.com/repos/open-wc/open-wc/events","assignees_url":"https://api.github.com/repos/open-wc/open-wc/assignees{/user}","branches_url":"https://api.github.com/repos/open-wc/open-wc/branches{/branch}","tags_url":"https://api.github.com/repos/open-wc/open-wc/tags","blobs_url":"https://api.github.com/repos/open-wc/open-wc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-wc/open-wc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-wc/open-wc/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-wc/open-wc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-wc/open-wc/statuses/{sha}","languages_url":"https://api.github.com/repos/open-wc/open-wc/languages","stargazers_url":"https://api.github.com/repos/open-wc/open-wc/stargazers","contributors_url":"https://api.github.com/repos/open-wc/open-wc/contributors","subscribers_url":"https://api.github.com/repos/open-wc/open-wc/subscribers","subscription_url":"https://api.github.com/repos/open-wc/open-wc/subscription","commits_url":"https://api.github.com/repos/open-wc/open-wc/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-wc/open-wc/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-wc/open-wc/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-wc/open-wc/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-wc/open-wc/contents/{+path}","compare_url":"https://api.github.com/repos/open-wc/open-wc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-wc/open-wc/merges","archive_url":"https://api.github.com/repos/open-wc/open-wc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-wc/open-wc/downloads","issues_url":"https://api.github.com/repos/open-wc/open-wc/issues{/number}","pulls_url":"https://api.github.com/repos/open-wc/open-wc/pulls{/number}","milestones_url":"https://api.github.com/repos/open-wc/open-wc/milestones{/number}","notifications_url":"https://api.github.com/repos/open-wc/open-wc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-wc/open-wc/labels{/name}","releases_url":"https://api.github.com/repos/open-wc/open-wc/releases{/id}","deployments_url":"https://api.github.com/repos/open-wc/open-wc/deployments","created_at":"2018-09-16T16:35:09Z","updated_at":"2018-12-01T10:11:28Z","pushed_at":"2018-12-02T11:52:12Z","git_url":"git://github.com/open-wc/open-wc.git","ssh_url":"git@github.com:open-wc/open-wc.git","clone_url":"https://github.com/open-wc/open-wc.git","svn_url":"https://github.com/open-wc/open-wc","homepage":"https://open-wc.org/","size":449,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":7,"watchers":11,"default_branch":"master"}},"base":{"label":"open-wc:master","ref":"master","sha":"f3ba461f8479827be90e9596afd435360366c9bf","user":{"login":"open-wc","id":42938647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyOTM4NjQ3","avatar_url":"https://avatars0.githubusercontent.com/u/42938647?v=4","gravatar_id":"","url":"https://api.github.com/users/open-wc","html_url":"https://github.com/open-wc","followers_url":"https://api.github.com/users/open-wc/followers","following_url":"https://api.github.com/users/open-wc/following{/other_user}","gists_url":"https://api.github.com/users/open-wc/gists{/gist_id}","starred_url":"https://api.github.com/users/open-wc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-wc/subscriptions","organizations_url":"https://api.github.com/users/open-wc/orgs","repos_url":"https://api.github.com/users/open-wc/repos","events_url":"https://api.github.com/users/open-wc/events{/privacy}","received_events_url":"https://api.github.com/users/open-wc/received_events","type":"Organization","site_admin":false},"repo":{"id":149014578,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkwMTQ1Nzg=","name":"open-wc","full_name":"open-wc/open-wc","private":false,"owner":{"login":"open-wc","id":42938647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyOTM4NjQ3","avatar_url":"https://avatars0.githubusercontent.com/u/42938647?v=4","gravatar_id":"","url":"https://api.github.com/users/open-wc","html_url":"https://github.com/open-wc","followers_url":"https://api.github.com/users/open-wc/followers","following_url":"https://api.github.com/users/open-wc/following{/other_user}","gists_url":"https://api.github.com/users/open-wc/gists{/gist_id}","starred_url":"https://api.github.com/users/open-wc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-wc/subscriptions","organizations_url":"https://api.github.com/users/open-wc/orgs","repos_url":"https://api.github.com/users/open-wc/repos","events_url":"https://api.github.com/users/open-wc/events{/privacy}","received_events_url":"https://api.github.com/users/open-wc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-wc/open-wc","description":"We want to provide a good set of default on how to facilitate your web component.","fork":false,"url":"https://api.github.com/repos/open-wc/open-wc","forks_url":"https://api.github.com/repos/open-wc/open-wc/forks","keys_url":"https://api.github.com/repos/open-wc/open-wc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-wc/open-wc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-wc/open-wc/teams","hooks_url":"https://api.github.com/repos/open-wc/open-wc/hooks","issue_events_url":"https://api.github.com/repos/open-wc/open-wc/issues/events{/number}","events_url":"https://api.github.com/repos/open-wc/open-wc/events","assignees_url":"https://api.github.com/repos/open-wc/open-wc/assignees{/user}","branches_url":"https://api.github.com/repos/open-wc/open-wc/branches{/branch}","tags_url":"https://api.github.com/repos/open-wc/open-wc/tags","blobs_url":"https://api.github.com/repos/open-wc/open-wc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-wc/open-wc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-wc/open-wc/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-wc/open-wc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-wc/open-wc/statuses/{sha}","languages_url":"https://api.github.com/repos/open-wc/open-wc/languages","stargazers_url":"https://api.github.com/repos/open-wc/open-wc/stargazers","contributors_url":"https://api.github.com/repos/open-wc/open-wc/contributors","subscribers_url":"https://api.github.com/repos/open-wc/open-wc/subscribers","subscription_url":"https://api.github.com/repos/open-wc/open-wc/subscription","commits_url":"https://api.github.com/repos/open-wc/open-wc/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-wc/open-wc/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-wc/open-wc/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-wc/open-wc/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-wc/open-wc/contents/{+path}","compare_url":"https://api.github.com/repos/open-wc/open-wc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-wc/open-wc/merges","archive_url":"https://api.github.com/repos/open-wc/open-wc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-wc/open-wc/downloads","issues_url":"https://api.github.com/repos/open-wc/open-wc/issues{/number}","pulls_url":"https://api.github.com/repos/open-wc/open-wc/pulls{/number}","milestones_url":"https://api.github.com/repos/open-wc/open-wc/milestones{/number}","notifications_url":"https://api.github.com/repos/open-wc/open-wc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-wc/open-wc/labels{/name}","releases_url":"https://api.github.com/repos/open-wc/open-wc/releases{/id}","deployments_url":"https://api.github.com/repos/open-wc/open-wc/deployments","created_at":"2018-09-16T16:35:09Z","updated_at":"2018-12-01T10:11:28Z","pushed_at":"2018-12-02T11:52:12Z","git_url":"git://github.com/open-wc/open-wc.git","ssh_url":"git@github.com:open-wc/open-wc.git","clone_url":"https://github.com/open-wc/open-wc.git","svn_url":"https://github.com/open-wc/open-wc","homepage":"https://open-wc.org/","size":449,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":7,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-wc/open-wc/pulls/64"},"html":{"href":"https://github.com/open-wc/open-wc/pull/64"},"issue":{"href":"https://api.github.com/repos/open-wc/open-wc/issues/64"},"comments":{"href":"https://api.github.com/repos/open-wc/open-wc/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/open-wc/open-wc/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/open-wc/open-wc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-wc/open-wc/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/open-wc/open-wc/statuses/e3d5ceb4e04b0dc111481eeba0d57026c8be157b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"LarsDenBakker"}}