{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/3265","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/3265/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3265/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/3265/events","html_url":"https://github.com/codice/ddf/pull/3265","id":325811779,"number":3265,"title":"DDF-3696: Minor Logout Fixes","user":{"login":"blen-desta","id":29550062,"avatar_url":"https://avatars0.githubusercontent.com/u/29550062?v=4","gravatar_id":"","url":"https://api.github.com/users/blen-desta","html_url":"https://github.com/blen-desta","followers_url":"https://api.github.com/users/blen-desta/followers","following_url":"https://api.github.com/users/blen-desta/following{/other_user}","gists_url":"https://api.github.com/users/blen-desta/gists{/gist_id}","starred_url":"https://api.github.com/users/blen-desta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blen-desta/subscriptions","organizations_url":"https://api.github.com/users/blen-desta/orgs","repos_url":"https://api.github.com/users/blen-desta/repos","events_url":"https://api.github.com/users/blen-desta/events{/privacy}","received_events_url":"https://api.github.com/users/blen-desta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"coyotesqrl","id":1469860,"avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},"assignees":[{"login":"coyotesqrl","id":1469860,"avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},{"login":"stustison","id":4391679,"avatar_url":"https://avatars0.githubusercontent.com/u/4391679?v=4","gravatar_id":"","url":"https://api.github.com/users/stustison","html_url":"https://github.com/stustison","followers_url":"https://api.github.com/users/stustison/followers","following_url":"https://api.github.com/users/stustison/following{/other_user}","gists_url":"https://api.github.com/users/stustison/gists{/gist_id}","starred_url":"https://api.github.com/users/stustison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stustison/subscriptions","organizations_url":"https://api.github.com/users/stustison/orgs","repos_url":"https://api.github.com/users/stustison/repos","events_url":"https://api.github.com/users/stustison/events{/privacy}","received_events_url":"https://api.github.com/users/stustison/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-05-23T17:54:44Z","updated_at":"2018-05-25T00:53:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3265","html_url":"https://github.com/codice/ddf/pull/3265","diff_url":"https://github.com/codice/ddf/pull/3265.diff","patch_url":"https://github.com/codice/ddf/pull/3265.patch"},"body":"#### What does this PR do?\r\n- Added URL encoding to relay state when validating and creating logout request signatures\r\n- Made sure the destination on the response is the correct binding URL\r\n\r\n#### Who is reviewing it? \r\n@bakejeyner \r\n@brjeter \r\n\r\n#### Ask 2 committers to review/merge the PR and tag them here. If you don't know who to ask, you can request reviews in https://groups.google.com/forum/#!forum/ddf-developers .\r\n(please choose ONLY two committers from below, delete the rest)\r\n@coyotesqrl \r\n@stustison \r\n\r\n#### How should this be tested? (List steps with links to updated documentation)\r\n- Successful login and logout \r\n- Running the SAML Conformance Test Kit against it\r\n\r\n#### Any background context you want to provide?\r\nThe Relay State has to be URL encoded when creating and validating signatures according to the Binding Spec.\r\n\r\n> To construct the signature, a string consisting of the concatenation of the RelayState \r\n> (if present), SigAlg, and SAMLRequest (or SAMLResponse) query string parameters \r\n> (**each one URLencoded**)\r\n> is constructed in one of the following ways (ordered as below):\r\n> `SAMLRequest=value&RelayState=value&SigAlg=value`\r\n> `SAMLResponse=value&RelayState=value&SigAlg=value`\r\n\r\n#### What are the relevant tickets?\r\n[DDF-3696](https://codice.atlassian.net/browse/DDF-3696)\r\n\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/391909117","html_url":"https://github.com/codice/ddf/pull/3265#issuecomment-391909117","issue_url":"https://api.github.com/repos/codice/ddf/issues/3265","id":391909117,"user":{"login":"cxbot","id":21088360,"avatar_url":"https://avatars2.githubusercontent.com/u/21088360?v=4","gravatar_id":"","url":"https://api.github.com/users/cxbot","html_url":"https://github.com/cxbot","followers_url":"https://api.github.com/users/cxbot/followers","following_url":"https://api.github.com/users/cxbot/following{/other_user}","gists_url":"https://api.github.com/users/cxbot/gists{/gist_id}","starred_url":"https://api.github.com/users/cxbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxbot/subscriptions","organizations_url":"https://api.github.com/users/cxbot/orgs","repos_url":"https://api.github.com/users/cxbot/repos","events_url":"https://api.github.com/users/cxbot/events{/privacy}","received_events_url":"https://api.github.com/users/cxbot/received_events","type":"User","site_admin":false},"created_at":"2018-05-25T00:53:15Z","updated_at":"2018-05-25T00:53:15Z","author_association":"COLLABORATOR","body":"\nRefer to this link for build results (access rights to CI server needed): \nhttps://jenkins.codice.org/job/DDF-Jobs/job/pr/job/Linux/4155/\n:white_check_mark: JOB SUCCESS\n"}}
{"actor":{"display_login":"cxbot"}}