{"action":"created","comment":{"url":"https://api.github.com/repos/storybooks/storybook/pulls/comments/169322586","pull_request_review_id":97828559,"id":169322586,"diff_hunk":"@@ -20,33 +20,31 @@ const acornConfig = {\n   },\n };\n \n-function generateSourceWithoutUglyComments(source, comments) {\n+function isUglyComment(comment, uglyCommentsRegex) {\n+  return uglyCommentsRegex.find(regex => regex.test(comment));","path":"addons/storysource/src/loader/generate-helpers.js","position":null,"original_position":6,"commit_id":"302031797352cca1e3ad6f66c4382ed357941bc9","original_commit_id":"d781fbd5aae5d6b430f33d9d24f45394439ede97","user":{"login":"Hypnosphi","id":6651625,"avatar_url":"https://avatars3.githubusercontent.com/u/6651625?v=4","gravatar_id":"","url":"https://api.github.com/users/Hypnosphi","html_url":"https://github.com/Hypnosphi","followers_url":"https://api.github.com/users/Hypnosphi/followers","following_url":"https://api.github.com/users/Hypnosphi/following{/other_user}","gists_url":"https://api.github.com/users/Hypnosphi/gists{/gist_id}","starred_url":"https://api.github.com/users/Hypnosphi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hypnosphi/subscriptions","organizations_url":"https://api.github.com/users/Hypnosphi/orgs","repos_url":"https://api.github.com/users/Hypnosphi/repos","events_url":"https://api.github.com/users/Hypnosphi/events{/privacy}","received_events_url":"https://api.github.com/users/Hypnosphi/received_events","type":"User","site_admin":false},"body":"`.some` not `.find`","created_at":"2018-02-20T13:49:17Z","updated_at":"2018-02-20T13:49:17Z","html_url":"https://github.com/storybooks/storybook/pull/3040#discussion_r169322586","pull_request_url":"https://api.github.com/repos/storybooks/storybook/pulls/3040","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/storybooks/storybook/pulls/comments/169322586"},"html":{"href":"https://github.com/storybooks/storybook/pull/3040#discussion_r169322586"},"pull_request":{"href":"https://api.github.com/repos/storybooks/storybook/pulls/3040"}}},"pull_request":{"url":"https://api.github.com/repos/storybooks/storybook/pulls/3040","id":170155431,"html_url":"https://github.com/storybooks/storybook/pull/3040","diff_url":"https://github.com/storybooks/storybook/pull/3040.diff","patch_url":"https://github.com/storybooks/storybook/pull/3040.patch","issue_url":"https://api.github.com/repos/storybooks/storybook/issues/3040","number":3040,"state":"open","locked":false,"title":"Addon Storysource improvements","user":{"login":"igor-dv","id":7867954,"avatar_url":"https://avatars3.githubusercontent.com/u/7867954?v=4","gravatar_id":"","url":"https://api.github.com/users/igor-dv","html_url":"https://github.com/igor-dv","followers_url":"https://api.github.com/users/igor-dv/followers","following_url":"https://api.github.com/users/igor-dv/following{/other_user}","gists_url":"https://api.github.com/users/igor-dv/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-dv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-dv/subscriptions","organizations_url":"https://api.github.com/users/igor-dv/orgs","repos_url":"https://api.github.com/users/igor-dv/repos","events_url":"https://api.github.com/users/igor-dv/events{/privacy}","received_events_url":"https://api.github.com/users/igor-dv/received_events","type":"User","site_admin":false},"body":"## What I did\r\n- Use acorn to calculate locations instead of \"line-column\" pkg.\r\n- Remove ugly comments from the storysource (currently only eslint things)\r\n- Make \"prettier\" and \"uglyComments\" configurable in loader","created_at":"2018-02-20T10:42:18Z","updated_at":"2018-02-20T13:49:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adc33f84209cbae2fab2ea899582f44923255005","assignee":{"login":"igor-dv","id":7867954,"avatar_url":"https://avatars3.githubusercontent.com/u/7867954?v=4","gravatar_id":"","url":"https://api.github.com/users/igor-dv","html_url":"https://github.com/igor-dv","followers_url":"https://api.github.com/users/igor-dv/followers","following_url":"https://api.github.com/users/igor-dv/following{/other_user}","gists_url":"https://api.github.com/users/igor-dv/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-dv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-dv/subscriptions","organizations_url":"https://api.github.com/users/igor-dv/orgs","repos_url":"https://api.github.com/users/igor-dv/repos","events_url":"https://api.github.com/users/igor-dv/events{/privacy}","received_events_url":"https://api.github.com/users/igor-dv/received_events","type":"User","site_admin":false},"assignees":[{"login":"igor-dv","id":7867954,"avatar_url":"https://avatars3.githubusercontent.com/u/7867954?v=4","gravatar_id":"","url":"https://api.github.com/users/igor-dv","html_url":"https://github.com/igor-dv","followers_url":"https://api.github.com/users/igor-dv/followers","following_url":"https://api.github.com/users/igor-dv/following{/other_user}","gists_url":"https://api.github.com/users/igor-dv/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-dv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-dv/subscriptions","organizations_url":"https://api.github.com/users/igor-dv/orgs","repos_url":"https://api.github.com/users/igor-dv/repos","events_url":"https://api.github.com/users/igor-dv/events{/privacy}","received_events_url":"https://api.github.com/users/igor-dv/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":842009233,"url":"https://api.github.com/repos/storybooks/storybook/labels/addon:%20storysource","name":"addon: storysource","color":"fbca04","default":false},{"id":343576456,"url":"https://api.github.com/repos/storybooks/storybook/labels/feature%20request","name":"feature request","color":"9B58D8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/storybooks/storybook/pulls/3040/commits","review_comments_url":"https://api.github.com/repos/storybooks/storybook/pulls/3040/comments","review_comment_url":"https://api.github.com/repos/storybooks/storybook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/storybooks/storybook/issues/3040/comments","statuses_url":"https://api.github.com/repos/storybooks/storybook/statuses/302031797352cca1e3ad6f66c4382ed357941bc9","head":{"label":"storybooks:storysource-adjustments","ref":"storysource-adjustments","sha":"302031797352cca1e3ad6f66c4382ed357941bc9","user":{"login":"storybooks","id":22632046,"avatar_url":"https://avatars3.githubusercontent.com/u/22632046?v=4","gravatar_id":"","url":"https://api.github.com/users/storybooks","html_url":"https://github.com/storybooks","followers_url":"https://api.github.com/users/storybooks/followers","following_url":"https://api.github.com/users/storybooks/following{/other_user}","gists_url":"https://api.github.com/users/storybooks/gists{/gist_id}","starred_url":"https://api.github.com/users/storybooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storybooks/subscriptions","organizations_url":"https://api.github.com/users/storybooks/orgs","repos_url":"https://api.github.com/users/storybooks/repos","events_url":"https://api.github.com/users/storybooks/events{/privacy}","received_events_url":"https://api.github.com/users/storybooks/received_events","type":"Organization","site_admin":false},"repo":{"id":54173593,"name":"storybook","full_name":"storybooks/storybook","owner":{"login":"storybooks","id":22632046,"avatar_url":"https://avatars3.githubusercontent.com/u/22632046?v=4","gravatar_id":"","url":"https://api.github.com/users/storybooks","html_url":"https://github.com/storybooks","followers_url":"https://api.github.com/users/storybooks/followers","following_url":"https://api.github.com/users/storybooks/following{/other_user}","gists_url":"https://api.github.com/users/storybooks/gists{/gist_id}","starred_url":"https://api.github.com/users/storybooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storybooks/subscriptions","organizations_url":"https://api.github.com/users/storybooks/orgs","repos_url":"https://api.github.com/users/storybooks/repos","events_url":"https://api.github.com/users/storybooks/events{/privacy}","received_events_url":"https://api.github.com/users/storybooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/storybooks/storybook","description":"Interactive UI component dev & test: React, React Native, Vue, Angular","fork":false,"url":"https://api.github.com/repos/storybooks/storybook","forks_url":"https://api.github.com/repos/storybooks/storybook/forks","keys_url":"https://api.github.com/repos/storybooks/storybook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/storybooks/storybook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/storybooks/storybook/teams","hooks_url":"https://api.github.com/repos/storybooks/storybook/hooks","issue_events_url":"https://api.github.com/repos/storybooks/storybook/issues/events{/number}","events_url":"https://api.github.com/repos/storybooks/storybook/events","assignees_url":"https://api.github.com/repos/storybooks/storybook/assignees{/user}","branches_url":"https://api.github.com/repos/storybooks/storybook/branches{/branch}","tags_url":"https://api.github.com/repos/storybooks/storybook/tags","blobs_url":"https://api.github.com/repos/storybooks/storybook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/storybooks/storybook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/storybooks/storybook/git/refs{/sha}","trees_url":"https://api.github.com/repos/storybooks/storybook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/storybooks/storybook/statuses/{sha}","languages_url":"https://api.github.com/repos/storybooks/storybook/languages","stargazers_url":"https://api.github.com/repos/storybooks/storybook/stargazers","contributors_url":"https://api.github.com/repos/storybooks/storybook/contributors","subscribers_url":"https://api.github.com/repos/storybooks/storybook/subscribers","subscription_url":"https://api.github.com/repos/storybooks/storybook/subscription","commits_url":"https://api.github.com/repos/storybooks/storybook/commits{/sha}","git_commits_url":"https://api.github.com/repos/storybooks/storybook/git/commits{/sha}","comments_url":"https://api.github.com/repos/storybooks/storybook/comments{/number}","issue_comment_url":"https://api.github.com/repos/storybooks/storybook/issues/comments{/number}","contents_url":"https://api.github.com/repos/storybooks/storybook/contents/{+path}","compare_url":"https://api.github.com/repos/storybooks/storybook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/storybooks/storybook/merges","archive_url":"https://api.github.com/repos/storybooks/storybook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/storybooks/storybook/downloads","issues_url":"https://api.github.com/repos/storybooks/storybook/issues{/number}","pulls_url":"https://api.github.com/repos/storybooks/storybook/pulls{/number}","milestones_url":"https://api.github.com/repos/storybooks/storybook/milestones{/number}","notifications_url":"https://api.github.com/repos/storybooks/storybook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/storybooks/storybook/labels{/name}","releases_url":"https://api.github.com/repos/storybooks/storybook/releases{/id}","deployments_url":"https://api.github.com/repos/storybooks/storybook/deployments","created_at":"2016-03-18T04:23:44Z","updated_at":"2018-02-20T13:33:33Z","pushed_at":"2018-02-20T13:22:28Z","git_url":"git://github.com/storybooks/storybook.git","ssh_url":"git@github.com:storybooks/storybook.git","clone_url":"https://github.com/storybooks/storybook.git","svn_url":"https://github.com/storybooks/storybook","homepage":"https://storybook.js.org","size":81958,"stargazers_count":20329,"watchers_count":20329,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1356,"mirror_url":null,"archived":false,"open_issues_count":171,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1356,"open_issues":171,"watchers":20329,"default_branch":"master"}},"base":{"label":"storybooks:master","ref":"master","sha":"96d6a7ef6d3a7d296911be57a5e69b8f74f9b3d2","user":{"login":"storybooks","id":22632046,"avatar_url":"https://avatars3.githubusercontent.com/u/22632046?v=4","gravatar_id":"","url":"https://api.github.com/users/storybooks","html_url":"https://github.com/storybooks","followers_url":"https://api.github.com/users/storybooks/followers","following_url":"https://api.github.com/users/storybooks/following{/other_user}","gists_url":"https://api.github.com/users/storybooks/gists{/gist_id}","starred_url":"https://api.github.com/users/storybooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storybooks/subscriptions","organizations_url":"https://api.github.com/users/storybooks/orgs","repos_url":"https://api.github.com/users/storybooks/repos","events_url":"https://api.github.com/users/storybooks/events{/privacy}","received_events_url":"https://api.github.com/users/storybooks/received_events","type":"Organization","site_admin":false},"repo":{"id":54173593,"name":"storybook","full_name":"storybooks/storybook","owner":{"login":"storybooks","id":22632046,"avatar_url":"https://avatars3.githubusercontent.com/u/22632046?v=4","gravatar_id":"","url":"https://api.github.com/users/storybooks","html_url":"https://github.com/storybooks","followers_url":"https://api.github.com/users/storybooks/followers","following_url":"https://api.github.com/users/storybooks/following{/other_user}","gists_url":"https://api.github.com/users/storybooks/gists{/gist_id}","starred_url":"https://api.github.com/users/storybooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storybooks/subscriptions","organizations_url":"https://api.github.com/users/storybooks/orgs","repos_url":"https://api.github.com/users/storybooks/repos","events_url":"https://api.github.com/users/storybooks/events{/privacy}","received_events_url":"https://api.github.com/users/storybooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/storybooks/storybook","description":"Interactive UI component dev & test: React, React Native, Vue, Angular","fork":false,"url":"https://api.github.com/repos/storybooks/storybook","forks_url":"https://api.github.com/repos/storybooks/storybook/forks","keys_url":"https://api.github.com/repos/storybooks/storybook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/storybooks/storybook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/storybooks/storybook/teams","hooks_url":"https://api.github.com/repos/storybooks/storybook/hooks","issue_events_url":"https://api.github.com/repos/storybooks/storybook/issues/events{/number}","events_url":"https://api.github.com/repos/storybooks/storybook/events","assignees_url":"https://api.github.com/repos/storybooks/storybook/assignees{/user}","branches_url":"https://api.github.com/repos/storybooks/storybook/branches{/branch}","tags_url":"https://api.github.com/repos/storybooks/storybook/tags","blobs_url":"https://api.github.com/repos/storybooks/storybook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/storybooks/storybook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/storybooks/storybook/git/refs{/sha}","trees_url":"https://api.github.com/repos/storybooks/storybook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/storybooks/storybook/statuses/{sha}","languages_url":"https://api.github.com/repos/storybooks/storybook/languages","stargazers_url":"https://api.github.com/repos/storybooks/storybook/stargazers","contributors_url":"https://api.github.com/repos/storybooks/storybook/contributors","subscribers_url":"https://api.github.com/repos/storybooks/storybook/subscribers","subscription_url":"https://api.github.com/repos/storybooks/storybook/subscription","commits_url":"https://api.github.com/repos/storybooks/storybook/commits{/sha}","git_commits_url":"https://api.github.com/repos/storybooks/storybook/git/commits{/sha}","comments_url":"https://api.github.com/repos/storybooks/storybook/comments{/number}","issue_comment_url":"https://api.github.com/repos/storybooks/storybook/issues/comments{/number}","contents_url":"https://api.github.com/repos/storybooks/storybook/contents/{+path}","compare_url":"https://api.github.com/repos/storybooks/storybook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/storybooks/storybook/merges","archive_url":"https://api.github.com/repos/storybooks/storybook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/storybooks/storybook/downloads","issues_url":"https://api.github.com/repos/storybooks/storybook/issues{/number}","pulls_url":"https://api.github.com/repos/storybooks/storybook/pulls{/number}","milestones_url":"https://api.github.com/repos/storybooks/storybook/milestones{/number}","notifications_url":"https://api.github.com/repos/storybooks/storybook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/storybooks/storybook/labels{/name}","releases_url":"https://api.github.com/repos/storybooks/storybook/releases{/id}","deployments_url":"https://api.github.com/repos/storybooks/storybook/deployments","created_at":"2016-03-18T04:23:44Z","updated_at":"2018-02-20T13:33:33Z","pushed_at":"2018-02-20T13:22:28Z","git_url":"git://github.com/storybooks/storybook.git","ssh_url":"git@github.com:storybooks/storybook.git","clone_url":"https://github.com/storybooks/storybook.git","svn_url":"https://github.com/storybooks/storybook","homepage":"https://storybook.js.org","size":81958,"stargazers_count":20329,"watchers_count":20329,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1356,"mirror_url":null,"archived":false,"open_issues_count":171,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1356,"open_issues":171,"watchers":20329,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/storybooks/storybook/pulls/3040"},"html":{"href":"https://github.com/storybooks/storybook/pull/3040"},"issue":{"href":"https://api.github.com/repos/storybooks/storybook/issues/3040"},"comments":{"href":"https://api.github.com/repos/storybooks/storybook/issues/3040/comments"},"review_comments":{"href":"https://api.github.com/repos/storybooks/storybook/pulls/3040/comments"},"review_comment":{"href":"https://api.github.com/repos/storybooks/storybook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/storybooks/storybook/pulls/3040/commits"},"statuses":{"href":"https://api.github.com/repos/storybooks/storybook/statuses/302031797352cca1e3ad6f66c4382ed357941bc9"}},"author_association":"OWNER"}}
{"actor":{"display_login":"Hypnosphi"}}