{"action":"created","comment":{"url":"https://api.github.com/repos/pweil-/azure-ccp-api/pulls/comments/198926230","pull_request_review_id":132947828,"id":198926230,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODkyNjIzMA==","diff_hunk":"@@ -0,0 +1,63 @@\n+package plugins\n+\n+// OpenShiftAzureConfig is a new, Red Hat owned type defined in an external project.  It\n+// represents a superset of the configuration required for all steps in the plugin process *after*\n+// the manifest is validated.\n+//\n+// OpenShiftAzureConfig is a versioned type.  It is expected that the configuration will change\n+// between releases and may require migration steps in the future.  The storage of this type\n+// is opaque to the plugins, they only require that it be passed in.  However, it must be retained\n+// to allow it to be lifecycled from version to version.\n+type OpenShiftAzureConfig struct{}\n+\n+// ManagedOpenShiftCluster is the external schema that is passed to the RP.  It is defined in\n+// acs-engine.  ManagedOpenShiftCluster will reuse many of the lower level objects shared by\n+// ManagedCluster but is separated in order to keep the relationship with AKS clear.\n+type ManagedOpenShiftCluster struct{}\n+\n+// Validator interface is the first plugin in the chain.  It is responsible for validation of\n+// both ManagedOpenShiftCluster.  ManagedOpenShiftCluster enters this process in a versioned state.\n+// It is validated both according to the version and against the previous state of the world.\n+// Versioned validation should occur first.  The manifest, if acceptable, may then be converted\n+// into the internal representation and validated against the previous state of the world.","path":"pkg/plugins/plugins.go","position":22,"original_position":22,"commit_id":"c380965cf093fcfea9528762683521a00cbc7309","original_commit_id":"c380965cf093fcfea9528762683521a00cbc7309","user":{"login":"jim-minter","id":1038301,"node_id":"MDQ6VXNlcjEwMzgzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"body":"> internal representation\r\n\r\nAre there 2 types then?  Do both need to be mentioned explicitly in this file?","created_at":"2018-06-28T17:39:30Z","updated_at":"2018-06-28T17:39:30Z","html_url":"https://github.com/pweil-/azure-ccp-api/pull/1#discussion_r198926230","pull_request_url":"https://api.github.com/repos/pweil-/azure-ccp-api/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pweil-/azure-ccp-api/pulls/comments/198926230"},"html":{"href":"https://github.com/pweil-/azure-ccp-api/pull/1#discussion_r198926230"},"pull_request":{"href":"https://api.github.com/repos/pweil-/azure-ccp-api/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/pweil-/azure-ccp-api/pulls/1","id":197101868,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MTAxODY4","html_url":"https://github.com/pweil-/azure-ccp-api/pull/1","diff_url":"https://github.com/pweil-/azure-ccp-api/pull/1.diff","patch_url":"https://github.com/pweil-/azure-ccp-api/pull/1.patch","issue_url":"https://api.github.com/repos/pweil-/azure-ccp-api/issues/1","number":1,"state":"open","locked":false,"title":"WIP interfaces","user":{"login":"pweil-","id":5230419,"node_id":"MDQ6VXNlcjUyMzA0MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/5230419?v=4","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-25T12:49:36Z","updated_at":"2018-06-28T17:39:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"170243902de471ac4cc4d2d73bab56cbb35b2854","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pweil-/azure-ccp-api/pulls/1/commits","review_comments_url":"https://api.github.com/repos/pweil-/azure-ccp-api/pulls/1/comments","review_comment_url":"https://api.github.com/repos/pweil-/azure-ccp-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pweil-/azure-ccp-api/issues/1/comments","statuses_url":"https://api.github.com/repos/pweil-/azure-ccp-api/statuses/c380965cf093fcfea9528762683521a00cbc7309","head":{"label":"pweil-:plugins","ref":"plugins","sha":"c380965cf093fcfea9528762683521a00cbc7309","user":{"login":"pweil-","id":5230419,"node_id":"MDQ6VXNlcjUyMzA0MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/5230419?v=4","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"repo":{"id":138589895,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg1ODk4OTU=","name":"azure-ccp-api","full_name":"pweil-/azure-ccp-api","owner":{"login":"pweil-","id":5230419,"node_id":"MDQ6VXNlcjUyMzA0MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/5230419?v=4","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pweil-/azure-ccp-api","description":null,"fork":false,"url":"https://api.github.com/repos/pweil-/azure-ccp-api","forks_url":"https://api.github.com/repos/pweil-/azure-ccp-api/forks","keys_url":"https://api.github.com/repos/pweil-/azure-ccp-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pweil-/azure-ccp-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pweil-/azure-ccp-api/teams","hooks_url":"https://api.github.com/repos/pweil-/azure-ccp-api/hooks","issue_events_url":"https://api.github.com/repos/pweil-/azure-ccp-api/issues/events{/number}","events_url":"https://api.github.com/repos/pweil-/azure-ccp-api/events","assignees_url":"https://api.github.com/repos/pweil-/azure-ccp-api/assignees{/user}","branches_url":"https://api.github.com/repos/pweil-/azure-ccp-api/branches{/branch}","tags_url":"https://api.github.com/repos/pweil-/azure-ccp-api/tags","blobs_url":"https://api.github.com/repos/pweil-/azure-ccp-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pweil-/azure-ccp-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pweil-/azure-ccp-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/pweil-/azure-ccp-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pweil-/azure-ccp-api/statuses/{sha}","languages_url":"https://api.github.com/repos/pweil-/azure-ccp-api/languages","stargazers_url":"https://api.github.com/repos/pweil-/azure-ccp-api/stargazers","contributors_url":"https://api.github.com/repos/pweil-/azure-ccp-api/contributors","subscribers_url":"https://api.github.com/repos/pweil-/azure-ccp-api/subscribers","subscription_url":"https://api.github.com/repos/pweil-/azure-ccp-api/subscription","commits_url":"https://api.github.com/repos/pweil-/azure-ccp-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/pweil-/azure-ccp-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/pweil-/azure-ccp-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/pweil-/azure-ccp-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/pweil-/azure-ccp-api/contents/{+path}","compare_url":"https://api.github.com/repos/pweil-/azure-ccp-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pweil-/azure-ccp-api/merges","archive_url":"https://api.github.com/repos/pweil-/azure-ccp-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pweil-/azure-ccp-api/downloads","issues_url":"https://api.github.com/repos/pweil-/azure-ccp-api/issues{/number}","pulls_url":"https://api.github.com/repos/pweil-/azure-ccp-api/pulls{/number}","milestones_url":"https://api.github.com/repos/pweil-/azure-ccp-api/milestones{/number}","notifications_url":"https://api.github.com/repos/pweil-/azure-ccp-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pweil-/azure-ccp-api/labels{/name}","releases_url":"https://api.github.com/repos/pweil-/azure-ccp-api/releases{/id}","deployments_url":"https://api.github.com/repos/pweil-/azure-ccp-api/deployments","created_at":"2018-06-25T12:07:59Z","updated_at":"2018-06-25T12:08:02Z","pushed_at":"2018-06-25T12:49:36Z","git_url":"git://github.com/pweil-/azure-ccp-api.git","ssh_url":"git@github.com:pweil-/azure-ccp-api.git","clone_url":"https://github.com/pweil-/azure-ccp-api.git","svn_url":"https://github.com/pweil-/azure-ccp-api","homepage":null,"size":6,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pweil-:master","ref":"master","sha":"19d5d2edcab5c3bc17588c6bd7b5898e1070d762","user":{"login":"pweil-","id":5230419,"node_id":"MDQ6VXNlcjUyMzA0MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/5230419?v=4","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"repo":{"id":138589895,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg1ODk4OTU=","name":"azure-ccp-api","full_name":"pweil-/azure-ccp-api","owner":{"login":"pweil-","id":5230419,"node_id":"MDQ6VXNlcjUyMzA0MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/5230419?v=4","gravatar_id":"","url":"https://api.github.com/users/pweil-","html_url":"https://github.com/pweil-","followers_url":"https://api.github.com/users/pweil-/followers","following_url":"https://api.github.com/users/pweil-/following{/other_user}","gists_url":"https://api.github.com/users/pweil-/gists{/gist_id}","starred_url":"https://api.github.com/users/pweil-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pweil-/subscriptions","organizations_url":"https://api.github.com/users/pweil-/orgs","repos_url":"https://api.github.com/users/pweil-/repos","events_url":"https://api.github.com/users/pweil-/events{/privacy}","received_events_url":"https://api.github.com/users/pweil-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pweil-/azure-ccp-api","description":null,"fork":false,"url":"https://api.github.com/repos/pweil-/azure-ccp-api","forks_url":"https://api.github.com/repos/pweil-/azure-ccp-api/forks","keys_url":"https://api.github.com/repos/pweil-/azure-ccp-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pweil-/azure-ccp-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pweil-/azure-ccp-api/teams","hooks_url":"https://api.github.com/repos/pweil-/azure-ccp-api/hooks","issue_events_url":"https://api.github.com/repos/pweil-/azure-ccp-api/issues/events{/number}","events_url":"https://api.github.com/repos/pweil-/azure-ccp-api/events","assignees_url":"https://api.github.com/repos/pweil-/azure-ccp-api/assignees{/user}","branches_url":"https://api.github.com/repos/pweil-/azure-ccp-api/branches{/branch}","tags_url":"https://api.github.com/repos/pweil-/azure-ccp-api/tags","blobs_url":"https://api.github.com/repos/pweil-/azure-ccp-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pweil-/azure-ccp-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pweil-/azure-ccp-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/pweil-/azure-ccp-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pweil-/azure-ccp-api/statuses/{sha}","languages_url":"https://api.github.com/repos/pweil-/azure-ccp-api/languages","stargazers_url":"https://api.github.com/repos/pweil-/azure-ccp-api/stargazers","contributors_url":"https://api.github.com/repos/pweil-/azure-ccp-api/contributors","subscribers_url":"https://api.github.com/repos/pweil-/azure-ccp-api/subscribers","subscription_url":"https://api.github.com/repos/pweil-/azure-ccp-api/subscription","commits_url":"https://api.github.com/repos/pweil-/azure-ccp-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/pweil-/azure-ccp-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/pweil-/azure-ccp-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/pweil-/azure-ccp-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/pweil-/azure-ccp-api/contents/{+path}","compare_url":"https://api.github.com/repos/pweil-/azure-ccp-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pweil-/azure-ccp-api/merges","archive_url":"https://api.github.com/repos/pweil-/azure-ccp-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pweil-/azure-ccp-api/downloads","issues_url":"https://api.github.com/repos/pweil-/azure-ccp-api/issues{/number}","pulls_url":"https://api.github.com/repos/pweil-/azure-ccp-api/pulls{/number}","milestones_url":"https://api.github.com/repos/pweil-/azure-ccp-api/milestones{/number}","notifications_url":"https://api.github.com/repos/pweil-/azure-ccp-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pweil-/azure-ccp-api/labels{/name}","releases_url":"https://api.github.com/repos/pweil-/azure-ccp-api/releases{/id}","deployments_url":"https://api.github.com/repos/pweil-/azure-ccp-api/deployments","created_at":"2018-06-25T12:07:59Z","updated_at":"2018-06-25T12:08:02Z","pushed_at":"2018-06-25T12:49:36Z","git_url":"git://github.com/pweil-/azure-ccp-api.git","ssh_url":"git@github.com:pweil-/azure-ccp-api.git","clone_url":"https://github.com/pweil-/azure-ccp-api.git","svn_url":"https://github.com/pweil-/azure-ccp-api","homepage":null,"size":6,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pweil-/azure-ccp-api/pulls/1"},"html":{"href":"https://github.com/pweil-/azure-ccp-api/pull/1"},"issue":{"href":"https://api.github.com/repos/pweil-/azure-ccp-api/issues/1"},"comments":{"href":"https://api.github.com/repos/pweil-/azure-ccp-api/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/pweil-/azure-ccp-api/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/pweil-/azure-ccp-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pweil-/azure-ccp-api/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/pweil-/azure-ccp-api/statuses/c380965cf093fcfea9528762683521a00cbc7309"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jim-minter"}}