{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/eclipse-collections/issues/531","repository_url":"https://api.github.com/repos/eclipse/eclipse-collections","labels_url":"https://api.github.com/repos/eclipse/eclipse-collections/issues/531/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/eclipse-collections/issues/531/comments","events_url":"https://api.github.com/repos/eclipse/eclipse-collections/issues/531/events","html_url":"https://github.com/eclipse/eclipse-collections/pull/531","id":330863943,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzY0NTM4","number":531,"title":"Fix #529. Populate CollectPrimitiveProcedure.java by stg file","user":{"login":"henohenotsuyoshi","id":7744411,"node_id":"MDQ6VXNlcjc3NDQ0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7744411?v=4","gravatar_id":"","url":"https://api.github.com/users/henohenotsuyoshi","html_url":"https://github.com/henohenotsuyoshi","followers_url":"https://api.github.com/users/henohenotsuyoshi/followers","following_url":"https://api.github.com/users/henohenotsuyoshi/following{/other_user}","gists_url":"https://api.github.com/users/henohenotsuyoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/henohenotsuyoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henohenotsuyoshi/subscriptions","organizations_url":"https://api.github.com/users/henohenotsuyoshi/orgs","repos_url":"https://api.github.com/users/henohenotsuyoshi/repos","events_url":"https://api.github.com/users/henohenotsuyoshi/events{/privacy}","received_events_url":"https://api.github.com/users/henohenotsuyoshi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-09T07:52:49Z","updated_at":"2018-06-13T22:37:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/eclipse/eclipse-collections/pulls/531","html_url":"https://github.com/eclipse/eclipse-collections/pull/531","diff_url":"https://github.com/eclipse/eclipse-collections/pull/531.diff","patch_url":"https://github.com/eclipse/eclipse-collections/pull/531.patch"},"body":"This is for issue #529 \r\nSigned-off-by: sone tsuyoshi <Tsuyoshi.Sone@gs.com>"},"comment":{"url":"https://api.github.com/repos/eclipse/eclipse-collections/issues/comments/397110150","html_url":"https://github.com/eclipse/eclipse-collections/pull/531#issuecomment-397110150","issue_url":"https://api.github.com/repos/eclipse/eclipse-collections/issues/531","id":397110150,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzExMDE1MA==","user":{"login":"nikhilnanivadekar","id":9932381,"node_id":"MDQ6VXNlcjk5MzIzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/9932381?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhilnanivadekar","html_url":"https://github.com/nikhilnanivadekar","followers_url":"https://api.github.com/users/nikhilnanivadekar/followers","following_url":"https://api.github.com/users/nikhilnanivadekar/following{/other_user}","gists_url":"https://api.github.com/users/nikhilnanivadekar/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhilnanivadekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhilnanivadekar/subscriptions","organizations_url":"https://api.github.com/users/nikhilnanivadekar/orgs","repos_url":"https://api.github.com/users/nikhilnanivadekar/repos","events_url":"https://api.github.com/users/nikhilnanivadekar/events{/privacy}","received_events_url":"https://api.github.com/users/nikhilnanivadekar/received_events","type":"User","site_admin":false},"created_at":"2018-06-13T22:37:22Z","updated_at":"2018-06-13T22:37:22Z","author_association":"CONTRIBUTOR","body":"This looks good to me from a code perspective. \r\nHowever, we need to make sure that serialization is not broken. Since it is a major version, I am fine to break serialization, however, I would like to point it in the release notes.\r\nSeems like there are no serialization tests for CollectPrimitiveProcedures. Please add serialization tests similar to org.eclipse.collections.impl.block.procedure.CollectProcedureSerializationTest#serializedForm\r\nand let me know if serialization is broken. Also, if it is broken if I am not mistake you will have to increment the serial version UUID as well. You can also code generate the tests 😄 \r\nI am totally fine if for transparency, you want to create another PR just for the serialization tests and get it merged before checking on this PR."}}
{"actor":{"display_login":"nikhilnanivadekar"}}