{"action":"created","comment":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/comments/214493923","pull_request_review_id":151569189,"id":214493923,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDQ5MzkyMw==","diff_hunk":"@@ -115,6 +116,16 @@ func (state State) MakeBlock(\n \t// Fill rest of header with state data.\n \tblock.ChainID = state.ChainID\n \n+\t// Set time\n+\tif height == 1 {\n+\t\tblock.Time = tmtime.Now()\n+\t\tif block.Time.Before(state.LastBlockTime) {\n+\t\t\tblock.Time = state.LastBlockTime // state.LastBlockTime for height == 1 is genesis time","path":"state/state.go","position":16,"original_position":16,"commit_id":"412ba201541a138c632fa4eb50f7b3e328c5e06c","original_commit_id":"412ba201541a138c632fa4eb50f7b3e328c5e06c","user":{"login":"ebuchman","id":2300911,"node_id":"MDQ6VXNlcjIzMDA5MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2300911?v=4","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false},"body":"This suggests that https://github.com/tendermint/tendermint/issues/2294 isnt fixed here? Or at least it's still possible for a proposer to make a block before their local time reaches the genesis time. In any case I think we would want the first block to happen *after* the genesis time, and ala #2294, an honest proposer shouldn't make a block until they're locally at least that time.","created_at":"2018-08-31T23:19:14Z","updated_at":"2018-08-31T23:29:24Z","html_url":"https://github.com/tendermint/tendermint/pull/2203#discussion_r214493923","pull_request_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2203","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/comments/214493923"},"html":{"href":"https://github.com/tendermint/tendermint/pull/2203#discussion_r214493923"},"pull_request":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2203"}}},"pull_request":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/2203","id":207685519,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3Njg1NTE5","html_url":"https://github.com/tendermint/tendermint/pull/2203","diff_url":"https://github.com/tendermint/tendermint/pull/2203.diff","patch_url":"https://github.com/tendermint/tendermint/pull/2203.patch","issue_url":"https://api.github.com/repos/tendermint/tendermint/issues/2203","number":2203,"state":"open","locked":false,"title":"Implement BFT time","user":{"login":"milosevic","id":1465543,"node_id":"MDQ6VXNlcjE0NjU1NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1465543?v=4","gravatar_id":"","url":"https://api.github.com/users/milosevic","html_url":"https://github.com/milosevic","followers_url":"https://api.github.com/users/milosevic/followers","following_url":"https://api.github.com/users/milosevic/following{/other_user}","gists_url":"https://api.github.com/users/milosevic/gists{/gist_id}","starred_url":"https://api.github.com/users/milosevic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milosevic/subscriptions","organizations_url":"https://api.github.com/users/milosevic/orgs","repos_url":"https://api.github.com/users/milosevic/repos","events_url":"https://api.github.com/users/milosevic/events{/privacy}","received_events_url":"https://api.github.com/users/milosevic/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for filing a PR! Before hitting the button, please check the following items.-->\r\n\r\n* [x] Updated all relevant documentation in docs\r\n* [x] Updated all code comments where relevant\r\n* [x] Wrote tests\r\n* [x] Updated CHANGELOG_PENDING.md\r\n\r\nFix https://github.com/tendermint/tendermint/issues/2013.","created_at":"2018-08-10T18:12:57Z","updated_at":"2018-08-31T23:29:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1816c3e8bf06fdc896c6039a9712288e559a05a7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"xla","id":1585,"node_id":"MDQ6VXNlcjE1ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/1585?v=4","gravatar_id":"","url":"https://api.github.com/users/xla","html_url":"https://github.com/xla","followers_url":"https://api.github.com/users/xla/followers","following_url":"https://api.github.com/users/xla/following{/other_user}","gists_url":"https://api.github.com/users/xla/gists{/gist_id}","starred_url":"https://api.github.com/users/xla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xla/subscriptions","organizations_url":"https://api.github.com/users/xla/orgs","repos_url":"https://api.github.com/users/xla/repos","events_url":"https://api.github.com/users/xla/events{/privacy}","received_events_url":"https://api.github.com/users/xla/received_events","type":"User","site_admin":false},{"login":"zramsay","id":8304391,"node_id":"MDQ6VXNlcjgzMDQzOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8304391?v=4","gravatar_id":"","url":"https://api.github.com/users/zramsay","html_url":"https://github.com/zramsay","followers_url":"https://api.github.com/users/zramsay/followers","following_url":"https://api.github.com/users/zramsay/following{/other_user}","gists_url":"https://api.github.com/users/zramsay/gists{/gist_id}","starred_url":"https://api.github.com/users/zramsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zramsay/subscriptions","organizations_url":"https://api.github.com/users/zramsay/orgs","repos_url":"https://api.github.com/users/zramsay/repos","events_url":"https://api.github.com/users/zramsay/events{/privacy}","received_events_url":"https://api.github.com/users/zramsay/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":795907908,"node_id":"MDU6TGFiZWw3OTU5MDc5MDg=","url":"https://api.github.com/repos/tendermint/tendermint/labels/consensus","name":"consensus","color":"fafad2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2203/commits","review_comments_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2203/comments","review_comment_url":"https://api.github.com/repos/tendermint/tendermint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tendermint/tendermint/issues/2203/comments","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/412ba201541a138c632fa4eb50f7b3e328c5e06c","head":{"label":"tendermint:zarko/2013-fix-bft-time","ref":"zarko/2013-fix-bft-time","sha":"412ba201541a138c632fa4eb50f7b3e328c5e06c","user":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"repo":{"id":19799491,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc5OTQ5MQ==","name":"tendermint","full_name":"tendermint/tendermint","owner":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tendermint/tendermint","description":"⟁ Tendermint Core (BFT Consensus) in Go","fork":false,"url":"https://api.github.com/repos/tendermint/tendermint","forks_url":"https://api.github.com/repos/tendermint/tendermint/forks","keys_url":"https://api.github.com/repos/tendermint/tendermint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tendermint/tendermint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tendermint/tendermint/teams","hooks_url":"https://api.github.com/repos/tendermint/tendermint/hooks","issue_events_url":"https://api.github.com/repos/tendermint/tendermint/issues/events{/number}","events_url":"https://api.github.com/repos/tendermint/tendermint/events","assignees_url":"https://api.github.com/repos/tendermint/tendermint/assignees{/user}","branches_url":"https://api.github.com/repos/tendermint/tendermint/branches{/branch}","tags_url":"https://api.github.com/repos/tendermint/tendermint/tags","blobs_url":"https://api.github.com/repos/tendermint/tendermint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tendermint/tendermint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tendermint/tendermint/git/refs{/sha}","trees_url":"https://api.github.com/repos/tendermint/tendermint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/{sha}","languages_url":"https://api.github.com/repos/tendermint/tendermint/languages","stargazers_url":"https://api.github.com/repos/tendermint/tendermint/stargazers","contributors_url":"https://api.github.com/repos/tendermint/tendermint/contributors","subscribers_url":"https://api.github.com/repos/tendermint/tendermint/subscribers","subscription_url":"https://api.github.com/repos/tendermint/tendermint/subscription","commits_url":"https://api.github.com/repos/tendermint/tendermint/commits{/sha}","git_commits_url":"https://api.github.com/repos/tendermint/tendermint/git/commits{/sha}","comments_url":"https://api.github.com/repos/tendermint/tendermint/comments{/number}","issue_comment_url":"https://api.github.com/repos/tendermint/tendermint/issues/comments{/number}","contents_url":"https://api.github.com/repos/tendermint/tendermint/contents/{+path}","compare_url":"https://api.github.com/repos/tendermint/tendermint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tendermint/tendermint/merges","archive_url":"https://api.github.com/repos/tendermint/tendermint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tendermint/tendermint/downloads","issues_url":"https://api.github.com/repos/tendermint/tendermint/issues{/number}","pulls_url":"https://api.github.com/repos/tendermint/tendermint/pulls{/number}","milestones_url":"https://api.github.com/repos/tendermint/tendermint/milestones{/number}","notifications_url":"https://api.github.com/repos/tendermint/tendermint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tendermint/tendermint/labels{/name}","releases_url":"https://api.github.com/repos/tendermint/tendermint/releases{/id}","deployments_url":"https://api.github.com/repos/tendermint/tendermint/deployments","created_at":"2014-05-14T23:21:35Z","updated_at":"2018-08-31T19:19:44Z","pushed_at":"2018-08-31T19:16:41Z","git_url":"git://github.com/tendermint/tendermint.git","ssh_url":"git@github.com:tendermint/tendermint.git","clone_url":"https://github.com/tendermint/tendermint.git","svn_url":"https://github.com/tendermint/tendermint","homepage":"https://tendermint.com/","size":51001,"stargazers_count":2233,"watchers_count":2233,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":533,"mirror_url":null,"archived":false,"open_issues_count":311,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":533,"open_issues":311,"watchers":2233,"default_branch":"master"}},"base":{"label":"tendermint:develop","ref":"develop","sha":"3a6cc5e6afc122b7242686ae32276035ac5f8ef6","user":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"repo":{"id":19799491,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc5OTQ5MQ==","name":"tendermint","full_name":"tendermint/tendermint","owner":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tendermint/tendermint","description":"⟁ Tendermint Core (BFT Consensus) in Go","fork":false,"url":"https://api.github.com/repos/tendermint/tendermint","forks_url":"https://api.github.com/repos/tendermint/tendermint/forks","keys_url":"https://api.github.com/repos/tendermint/tendermint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tendermint/tendermint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tendermint/tendermint/teams","hooks_url":"https://api.github.com/repos/tendermint/tendermint/hooks","issue_events_url":"https://api.github.com/repos/tendermint/tendermint/issues/events{/number}","events_url":"https://api.github.com/repos/tendermint/tendermint/events","assignees_url":"https://api.github.com/repos/tendermint/tendermint/assignees{/user}","branches_url":"https://api.github.com/repos/tendermint/tendermint/branches{/branch}","tags_url":"https://api.github.com/repos/tendermint/tendermint/tags","blobs_url":"https://api.github.com/repos/tendermint/tendermint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tendermint/tendermint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tendermint/tendermint/git/refs{/sha}","trees_url":"https://api.github.com/repos/tendermint/tendermint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/{sha}","languages_url":"https://api.github.com/repos/tendermint/tendermint/languages","stargazers_url":"https://api.github.com/repos/tendermint/tendermint/stargazers","contributors_url":"https://api.github.com/repos/tendermint/tendermint/contributors","subscribers_url":"https://api.github.com/repos/tendermint/tendermint/subscribers","subscription_url":"https://api.github.com/repos/tendermint/tendermint/subscription","commits_url":"https://api.github.com/repos/tendermint/tendermint/commits{/sha}","git_commits_url":"https://api.github.com/repos/tendermint/tendermint/git/commits{/sha}","comments_url":"https://api.github.com/repos/tendermint/tendermint/comments{/number}","issue_comment_url":"https://api.github.com/repos/tendermint/tendermint/issues/comments{/number}","contents_url":"https://api.github.com/repos/tendermint/tendermint/contents/{+path}","compare_url":"https://api.github.com/repos/tendermint/tendermint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tendermint/tendermint/merges","archive_url":"https://api.github.com/repos/tendermint/tendermint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tendermint/tendermint/downloads","issues_url":"https://api.github.com/repos/tendermint/tendermint/issues{/number}","pulls_url":"https://api.github.com/repos/tendermint/tendermint/pulls{/number}","milestones_url":"https://api.github.com/repos/tendermint/tendermint/milestones{/number}","notifications_url":"https://api.github.com/repos/tendermint/tendermint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tendermint/tendermint/labels{/name}","releases_url":"https://api.github.com/repos/tendermint/tendermint/releases{/id}","deployments_url":"https://api.github.com/repos/tendermint/tendermint/deployments","created_at":"2014-05-14T23:21:35Z","updated_at":"2018-08-31T19:19:44Z","pushed_at":"2018-08-31T19:16:41Z","git_url":"git://github.com/tendermint/tendermint.git","ssh_url":"git@github.com:tendermint/tendermint.git","clone_url":"https://github.com/tendermint/tendermint.git","svn_url":"https://github.com/tendermint/tendermint","homepage":"https://tendermint.com/","size":51001,"stargazers_count":2233,"watchers_count":2233,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":533,"mirror_url":null,"archived":false,"open_issues_count":311,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":533,"open_issues":311,"watchers":2233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2203"},"html":{"href":"https://github.com/tendermint/tendermint/pull/2203"},"issue":{"href":"https://api.github.com/repos/tendermint/tendermint/issues/2203"},"comments":{"href":"https://api.github.com/repos/tendermint/tendermint/issues/2203/comments"},"review_comments":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2203/comments"},"review_comment":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2203/commits"},"statuses":{"href":"https://api.github.com/repos/tendermint/tendermint/statuses/412ba201541a138c632fa4eb50f7b3e328c5e06c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ebuchman"}}