{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/228957148","pull_request_review_id":169340426,"id":228957148,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODk1NzE0OA==","diff_hunk":"@@ -87,6 +87,13 @@ kiali:\n istio_cni:\n   enabled: false\n \n+#","path":"install/kubernetes/helm/istio/values.yaml","position":4,"original_position":4,"commit_id":"712331aeb1eb2ad2129a8ed0c7f17baeddd52087","original_commit_id":"712331aeb1eb2ad2129a8ed0c7f17baeddd52087","user":{"login":"sdake","id":755849,"node_id":"MDQ6VXNlcjc1NTg0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/755849?v=4","gravatar_id":"","url":"https://api.github.com/users/sdake","html_url":"https://github.com/sdake","followers_url":"https://api.github.com/users/sdake/followers","following_url":"https://api.github.com/users/sdake/following{/other_user}","gists_url":"https://api.github.com/users/sdake/gists{/gist_id}","starred_url":"https://api.github.com/users/sdake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdake/subscriptions","organizations_url":"https://api.github.com/users/sdake/orgs","repos_url":"https://api.github.com/users/sdake/repos","events_url":"https://api.github.com/users/sdake/events{/privacy}","received_events_url":"https://api.github.com/users/sdake/received_events","type":"User","site_admin":false},"body":"please revert changes to this file.  The values.yaml are inherited from the subcharts subdir.","created_at":"2018-10-29T14:48:37Z","updated_at":"2018-10-29T14:48:38Z","html_url":"https://github.com/istio/istio/pull/9606#discussion_r228957148","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/9606","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/228957148"},"html":{"href":"https://github.com/istio/istio/pull/9606#discussion_r228957148"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/9606"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/9606","id":226576350,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NTc2MzUw","html_url":"https://github.com/istio/istio/pull/9606","diff_url":"https://github.com/istio/istio/pull/9606.diff","patch_url":"https://github.com/istio/istio/pull/9606.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/9606","number":9606,"state":"open","locked":false,"title":"Add telemetry-gateway subchart to helm requirements.yaml file","user":{"login":"cezarsa","id":11041,"node_id":"MDQ6VXNlcjExMDQx","avatar_url":"https://avatars1.githubusercontent.com/u/11041?v=4","gravatar_id":"","url":"https://api.github.com/users/cezarsa","html_url":"https://github.com/cezarsa","followers_url":"https://api.github.com/users/cezarsa/followers","following_url":"https://api.github.com/users/cezarsa/following{/other_user}","gists_url":"https://api.github.com/users/cezarsa/gists{/gist_id}","starred_url":"https://api.github.com/users/cezarsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cezarsa/subscriptions","organizations_url":"https://api.github.com/users/cezarsa/orgs","repos_url":"https://api.github.com/users/cezarsa/repos","events_url":"https://api.github.com/users/cezarsa/events{/privacy}","received_events_url":"https://api.github.com/users/cezarsa/received_events","type":"User","site_admin":false},"body":"It looks like the telemetry-gateway subchart was forgotten when the `requirements.yaml` was modified during the migration to subcharts in #9306.\r\n\r\nThis PR adds a reference to the existing telemetry-gateway subchart to the requirements.yaml file.\r\n\r\ncc @sdake","created_at":"2018-10-29T14:15:51Z","updated_at":"2018-10-29T14:48:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9be6ee0035740ba7f11e552ec44ecef929f5fb0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},{"login":"gyliu513","id":4461983,"node_id":"MDQ6VXNlcjQ0NjE5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/4461983?v=4","gravatar_id":"","url":"https://api.github.com/users/gyliu513","html_url":"https://github.com/gyliu513","followers_url":"https://api.github.com/users/gyliu513/followers","following_url":"https://api.github.com/users/gyliu513/following{/other_user}","gists_url":"https://api.github.com/users/gyliu513/gists{/gist_id}","starred_url":"https://api.github.com/users/gyliu513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyliu513/subscriptions","organizations_url":"https://api.github.com/users/gyliu513/orgs","repos_url":"https://api.github.com/users/gyliu513/repos","events_url":"https://api.github.com/users/gyliu513/events{/privacy}","received_events_url":"https://api.github.com/users/gyliu513/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":644159920,"node_id":"MDU6TGFiZWw2NDQxNTk5MjA=","url":"https://api.github.com/repos/istio/istio/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/9606/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/9606/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/9606/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/712331aeb1eb2ad2129a8ed0c7f17baeddd52087","head":{"label":"cezarsa:telemetry","ref":"telemetry","sha":"712331aeb1eb2ad2129a8ed0c7f17baeddd52087","user":{"login":"cezarsa","id":11041,"node_id":"MDQ6VXNlcjExMDQx","avatar_url":"https://avatars1.githubusercontent.com/u/11041?v=4","gravatar_id":"","url":"https://api.github.com/users/cezarsa","html_url":"https://github.com/cezarsa","followers_url":"https://api.github.com/users/cezarsa/followers","following_url":"https://api.github.com/users/cezarsa/following{/other_user}","gists_url":"https://api.github.com/users/cezarsa/gists{/gist_id}","starred_url":"https://api.github.com/users/cezarsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cezarsa/subscriptions","organizations_url":"https://api.github.com/users/cezarsa/orgs","repos_url":"https://api.github.com/users/cezarsa/repos","events_url":"https://api.github.com/users/cezarsa/events{/privacy}","received_events_url":"https://api.github.com/users/cezarsa/received_events","type":"User","site_admin":false},"repo":{"id":153957690,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM5NTc2OTA=","name":"istio","full_name":"cezarsa/istio","private":false,"owner":{"login":"cezarsa","id":11041,"node_id":"MDQ6VXNlcjExMDQx","avatar_url":"https://avatars1.githubusercontent.com/u/11041?v=4","gravatar_id":"","url":"https://api.github.com/users/cezarsa","html_url":"https://github.com/cezarsa","followers_url":"https://api.github.com/users/cezarsa/followers","following_url":"https://api.github.com/users/cezarsa/following{/other_user}","gists_url":"https://api.github.com/users/cezarsa/gists{/gist_id}","starred_url":"https://api.github.com/users/cezarsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cezarsa/subscriptions","organizations_url":"https://api.github.com/users/cezarsa/orgs","repos_url":"https://api.github.com/users/cezarsa/repos","events_url":"https://api.github.com/users/cezarsa/events{/privacy}","received_events_url":"https://api.github.com/users/cezarsa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cezarsa/istio","description":"Connect, secure, control, and observe services.","fork":true,"url":"https://api.github.com/repos/cezarsa/istio","forks_url":"https://api.github.com/repos/cezarsa/istio/forks","keys_url":"https://api.github.com/repos/cezarsa/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cezarsa/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cezarsa/istio/teams","hooks_url":"https://api.github.com/repos/cezarsa/istio/hooks","issue_events_url":"https://api.github.com/repos/cezarsa/istio/issues/events{/number}","events_url":"https://api.github.com/repos/cezarsa/istio/events","assignees_url":"https://api.github.com/repos/cezarsa/istio/assignees{/user}","branches_url":"https://api.github.com/repos/cezarsa/istio/branches{/branch}","tags_url":"https://api.github.com/repos/cezarsa/istio/tags","blobs_url":"https://api.github.com/repos/cezarsa/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cezarsa/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cezarsa/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/cezarsa/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cezarsa/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/cezarsa/istio/languages","stargazers_url":"https://api.github.com/repos/cezarsa/istio/stargazers","contributors_url":"https://api.github.com/repos/cezarsa/istio/contributors","subscribers_url":"https://api.github.com/repos/cezarsa/istio/subscribers","subscription_url":"https://api.github.com/repos/cezarsa/istio/subscription","commits_url":"https://api.github.com/repos/cezarsa/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/cezarsa/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/cezarsa/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/cezarsa/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/cezarsa/istio/contents/{+path}","compare_url":"https://api.github.com/repos/cezarsa/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cezarsa/istio/merges","archive_url":"https://api.github.com/repos/cezarsa/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cezarsa/istio/downloads","issues_url":"https://api.github.com/repos/cezarsa/istio/issues{/number}","pulls_url":"https://api.github.com/repos/cezarsa/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/cezarsa/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/cezarsa/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cezarsa/istio/labels{/name}","releases_url":"https://api.github.com/repos/cezarsa/istio/releases{/id}","deployments_url":"https://api.github.com/repos/cezarsa/istio/deployments","created_at":"2018-10-20T23:36:50Z","updated_at":"2018-10-20T23:36:59Z","pushed_at":"2018-10-29T14:45:11Z","git_url":"git://github.com/cezarsa/istio.git","ssh_url":"git@github.com:cezarsa/istio.git","clone_url":"https://github.com/cezarsa/istio.git","svn_url":"https://github.com/cezarsa/istio","homepage":"https://istio.io","size":52491,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"cb6f5fc5055636295b9dc434ab070a63490e16fc","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/istio","description":"Connect, secure, control, and observe services.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-10-29T13:18:34Z","pushed_at":"2018-10-29T14:47:03Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":52768,"stargazers_count":12656,"watchers_count":12656,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1887,"mirror_url":null,"archived":false,"open_issues_count":1060,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1887,"open_issues":1060,"watchers":12656,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/9606"},"html":{"href":"https://github.com/istio/istio/pull/9606"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/9606"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/9606/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/9606/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/9606/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/712331aeb1eb2ad2129a8ed0c7f17baeddd52087"}},"author_association":"NONE"}}
{"actor":{"display_login":"sdake"}}