{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/comments/174595035","pull_request_review_id":103980628,"id":174595035,"diff_hunk":"@@ -0,0 +1,36 @@\n+syntax = \"proto3\";\n+\n+package envoy.api.v2.core;\n+\n+import \"validate/validate.proto\";\n+\n+// Envoy external URI descriptor\n+// [#not-implemented-hide:]\n+message HttpUri {\n+  // The HTTP server URI. It should be a full FQDN with protocol, host and path.\n+  //\n+  // Example:\n+  //\n+  // .. code-block:: yaml\n+  //\n+  //    uri: https://www.googleapis.com/oauth2/v1/certs\n+  //\n+  string uri = 1 [(validate.rules).string.min_bytes = 1];\n+\n+  // Specify how `uri` is to be fetched. Today, this requires an explicit\n+  // cluster, but in the future we may support dynamic cluster creation or\n+  // inline DNS resolution. See `issue\n+  // <https://github.com/envoyproxy/envoy/issues/1606>`_.\n+  oneof http_upstream_type {\n+    // A cluster is created in the Envoy \"cluster_manager\" config\n+    // section. This field specifies the cluster name.\n+    //\n+    // Example:\n+    //\n+    // .. code-block:: yaml\n+    //\n+    //    cluster: jwks_cluster\n+    //\n+    string cluster = 2;","path":"envoy/api/v2/core/http_uri.proto","position":34,"original_position":34,"commit_id":"f6e154eb3fdef0f8572e28227d7bd2eaf1ce4c59","original_commit_id":"f6e154eb3fdef0f8572e28227d7bd2eaf1ce4c59","user":{"login":"lizan","id":1016047,"avatar_url":"https://avatars1.githubusercontent.com/u/1016047?v=4","gravatar_id":"","url":"https://api.github.com/users/lizan","html_url":"https://github.com/lizan","followers_url":"https://api.github.com/users/lizan/followers","following_url":"https://api.github.com/users/lizan/following{/other_user}","gists_url":"https://api.github.com/users/lizan/gists{/gist_id}","starred_url":"https://api.github.com/users/lizan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizan/subscriptions","organizations_url":"https://api.github.com/users/lizan/orgs","repos_url":"https://api.github.com/users/lizan/repos","events_url":"https://api.github.com/users/lizan/events{/privacy}","received_events_url":"https://api.github.com/users/lizan/received_events","type":"User","site_admin":false},"body":"please add validate rules (also for oneof)","created_at":"2018-03-14T20:11:16Z","updated_at":"2018-03-14T20:11:16Z","html_url":"https://github.com/envoyproxy/data-plane-api/pull/538#discussion_r174595035","pull_request_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/538","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/comments/174595035"},"html":{"href":"https://github.com/envoyproxy/data-plane-api/pull/538#discussion_r174595035"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/538"}}},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/538","id":174755261,"html_url":"https://github.com/envoyproxy/data-plane-api/pull/538","diff_url":"https://github.com/envoyproxy/data-plane-api/pull/538.diff","patch_url":"https://github.com/envoyproxy/data-plane-api/pull/538.patch","issue_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/538","number":538,"state":"open","locked":false,"title":"Add http_uri proto.","user":{"login":"qiwzhang","id":11790727,"avatar_url":"https://avatars0.githubusercontent.com/u/11790727?v=4","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"body":"Per discuss from PR: https://github.com/envoyproxy/data-plane-api/pull/530\r\nAdd EnvoyHttpTarget meesage\r\n\r\nSigned-off-by: Wayne Zhang <qiwzhang@google.com>","created_at":"2018-03-13T18:46:01Z","updated_at":"2018-03-14T20:11:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f2e9dd11ed9449d763740a4e1b01cff0fc19869","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/538/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/538/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/538/comments","statuses_url":"https://api.github.com/repos/envoyproxy/data-plane-api/statuses/f6e154eb3fdef0f8572e28227d7bd2eaf1ce4c59","head":{"label":"qiwzhang:envoy_http","ref":"envoy_http","sha":"f6e154eb3fdef0f8572e28227d7bd2eaf1ce4c59","user":{"login":"qiwzhang","id":11790727,"avatar_url":"https://avatars0.githubusercontent.com/u/11790727?v=4","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"repo":{"id":124310285,"name":"data-plane-api","full_name":"qiwzhang/data-plane-api","owner":{"login":"qiwzhang","id":11790727,"avatar_url":"https://avatars0.githubusercontent.com/u/11790727?v=4","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qiwzhang/data-plane-api","description":"Envoy REST/proto API definitions","fork":true,"url":"https://api.github.com/repos/qiwzhang/data-plane-api","forks_url":"https://api.github.com/repos/qiwzhang/data-plane-api/forks","keys_url":"https://api.github.com/repos/qiwzhang/data-plane-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qiwzhang/data-plane-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qiwzhang/data-plane-api/teams","hooks_url":"https://api.github.com/repos/qiwzhang/data-plane-api/hooks","issue_events_url":"https://api.github.com/repos/qiwzhang/data-plane-api/issues/events{/number}","events_url":"https://api.github.com/repos/qiwzhang/data-plane-api/events","assignees_url":"https://api.github.com/repos/qiwzhang/data-plane-api/assignees{/user}","branches_url":"https://api.github.com/repos/qiwzhang/data-plane-api/branches{/branch}","tags_url":"https://api.github.com/repos/qiwzhang/data-plane-api/tags","blobs_url":"https://api.github.com/repos/qiwzhang/data-plane-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qiwzhang/data-plane-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qiwzhang/data-plane-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/qiwzhang/data-plane-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qiwzhang/data-plane-api/statuses/{sha}","languages_url":"https://api.github.com/repos/qiwzhang/data-plane-api/languages","stargazers_url":"https://api.github.com/repos/qiwzhang/data-plane-api/stargazers","contributors_url":"https://api.github.com/repos/qiwzhang/data-plane-api/contributors","subscribers_url":"https://api.github.com/repos/qiwzhang/data-plane-api/subscribers","subscription_url":"https://api.github.com/repos/qiwzhang/data-plane-api/subscription","commits_url":"https://api.github.com/repos/qiwzhang/data-plane-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/qiwzhang/data-plane-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/qiwzhang/data-plane-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/qiwzhang/data-plane-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/qiwzhang/data-plane-api/contents/{+path}","compare_url":"https://api.github.com/repos/qiwzhang/data-plane-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qiwzhang/data-plane-api/merges","archive_url":"https://api.github.com/repos/qiwzhang/data-plane-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qiwzhang/data-plane-api/downloads","issues_url":"https://api.github.com/repos/qiwzhang/data-plane-api/issues{/number}","pulls_url":"https://api.github.com/repos/qiwzhang/data-plane-api/pulls{/number}","milestones_url":"https://api.github.com/repos/qiwzhang/data-plane-api/milestones{/number}","notifications_url":"https://api.github.com/repos/qiwzhang/data-plane-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qiwzhang/data-plane-api/labels{/name}","releases_url":"https://api.github.com/repos/qiwzhang/data-plane-api/releases{/id}","deployments_url":"https://api.github.com/repos/qiwzhang/data-plane-api/deployments","created_at":"2018-03-08T00:01:37Z","updated_at":"2018-03-08T00:01:39Z","pushed_at":"2018-03-14T16:21:53Z","git_url":"git://github.com/qiwzhang/data-plane-api.git","ssh_url":"git@github.com:qiwzhang/data-plane-api.git","clone_url":"https://github.com/qiwzhang/data-plane-api.git","svn_url":"https://github.com/qiwzhang/data-plane-api","homepage":null,"size":1277,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"a6378e5f707f41ef51c9be2bb9462224087ed65b","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":90675549,"name":"data-plane-api","full_name":"envoyproxy/data-plane-api","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/data-plane-api","description":"Envoy REST/proto API definitions and documentation","fork":false,"url":"https://api.github.com/repos/envoyproxy/data-plane-api","forks_url":"https://api.github.com/repos/envoyproxy/data-plane-api/forks","keys_url":"https://api.github.com/repos/envoyproxy/data-plane-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/data-plane-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/data-plane-api/teams","hooks_url":"https://api.github.com/repos/envoyproxy/data-plane-api/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/data-plane-api/events","assignees_url":"https://api.github.com/repos/envoyproxy/data-plane-api/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/data-plane-api/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/data-plane-api/tags","blobs_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/data-plane-api/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/data-plane-api/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/data-plane-api/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/data-plane-api/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/data-plane-api/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/data-plane-api/subscription","commits_url":"https://api.github.com/repos/envoyproxy/data-plane-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/data-plane-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/data-plane-api/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/data-plane-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/data-plane-api/merges","archive_url":"https://api.github.com/repos/envoyproxy/data-plane-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/data-plane-api/downloads","issues_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/data-plane-api/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/data-plane-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/data-plane-api/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/data-plane-api/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/data-plane-api/deployments","created_at":"2017-05-08T21:50:29Z","updated_at":"2018-03-14T16:42:54Z","pushed_at":"2018-03-14T20:10:04Z","git_url":"git://github.com/envoyproxy/data-plane-api.git","ssh_url":"git@github.com:envoyproxy/data-plane-api.git","clone_url":"https://github.com/envoyproxy/data-plane-api.git","svn_url":"https://github.com/envoyproxy/data-plane-api","homepage":"","size":1259,"stargazers_count":91,"watchers_count":91,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":105,"open_issues":26,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/538"},"html":{"href":"https://github.com/envoyproxy/data-plane-api/pull/538"},"issue":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/538"},"comments":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/538/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/538/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/538/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/statuses/f6e154eb3fdef0f8572e28227d7bd2eaf1ce4c59"}},"author_association":"NONE"}}
{"actor":{"display_login":"lizan"}}