{"action":"created","comment":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/172972716","pull_request_review_id":102083164,"id":172972716,"diff_hunk":"@@ -1043,8 +1043,8 @@ Dictionary PTLightingEngineFactory::get_params_metadata()\n         \"max_diffuse_bounces\",\n         Dictionary()\n             .insert(\"type\", \"int\")\n-            .insert(\"default\", \"8\")\n-            .insert(\"unlimited\", \"true\")\n+            .insert(\"default\", \"3\")\n+            .insert(\"unlimited\", \"false\")","path":"src/appleseed/renderer/kernel/lighting/pt/ptlightingengine.cpp","position":7,"original_position":7,"commit_id":"9a7a6947890bd7e8cf7c205ccb992c82768ed676","original_commit_id":"9a7a6947890bd7e8cf7c205ccb992c82768ed676","user":{"login":"dictoon","id":321290,"avatar_url":"https://avatars1.githubusercontent.com/u/321290?v=4","gravatar_id":"","url":"https://api.github.com/users/dictoon","html_url":"https://github.com/dictoon","followers_url":"https://api.github.com/users/dictoon/followers","following_url":"https://api.github.com/users/dictoon/following{/other_user}","gists_url":"https://api.github.com/users/dictoon/gists{/gist_id}","starred_url":"https://api.github.com/users/dictoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dictoon/subscriptions","organizations_url":"https://api.github.com/users/dictoon/orgs","repos_url":"https://api.github.com/users/dictoon/repos","events_url":"https://api.github.com/users/dictoon/events{/privacy}","received_events_url":"https://api.github.com/users/dictoon/received_events","type":"User","site_admin":false},"body":"To clarify: what it's supposed to mean that the property's value _can_ be unlimited. The name is less than ideal, I agree.","created_at":"2018-03-07T20:22:12Z","updated_at":"2018-03-07T20:22:12Z","html_url":"https://github.com/appleseedhq/appleseed/pull/1889#discussion_r172972716","pull_request_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1889","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/172972716"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/1889#discussion_r172972716"},"pull_request":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1889"}},"in_reply_to_id":172972347},"pull_request":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1889","id":173244038,"html_url":"https://github.com/appleseedhq/appleseed/pull/1889","diff_url":"https://github.com/appleseedhq/appleseed/pull/1889.diff","patch_url":"https://github.com/appleseedhq/appleseed/pull/1889.patch","issue_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/1889","number":1889,"state":"open","locked":false,"title":"Change default max_diffuse_bounces to 3","user":{"login":"rgirish28","id":1740009,"avatar_url":"https://avatars3.githubusercontent.com/u/1740009?v=4","gravatar_id":"","url":"https://api.github.com/users/rgirish28","html_url":"https://github.com/rgirish28","followers_url":"https://api.github.com/users/rgirish28/followers","following_url":"https://api.github.com/users/rgirish28/following{/other_user}","gists_url":"https://api.github.com/users/rgirish28/gists{/gist_id}","starred_url":"https://api.github.com/users/rgirish28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgirish28/subscriptions","organizations_url":"https://api.github.com/users/rgirish28/orgs","repos_url":"https://api.github.com/users/rgirish28/repos","events_url":"https://api.github.com/users/rgirish28/events{/privacy}","received_events_url":"https://api.github.com/users/rgirish28/received_events","type":"User","site_admin":false},"body":"Changed default max_diffuse_bounces to 3 as required in #1848 \r\nI'm not sure if I have found every instance of where the default value is set. \r\nWould you want the default setting to be unlimited bounces or just 3 bounces? I can make the change to the commit if that's the case. ","created_at":"2018-03-06T18:33:01Z","updated_at":"2018-03-07T20:22:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e6b491559da2b7d06aae93d1c6aa15b92596624","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1889/commits","review_comments_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1889/comments","review_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/1889/comments","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/9a7a6947890bd7e8cf7c205ccb992c82768ed676","head":{"label":"rgirish28:diffuse-bounce-fix","ref":"diffuse-bounce-fix","sha":"9a7a6947890bd7e8cf7c205ccb992c82768ed676","user":{"login":"rgirish28","id":1740009,"avatar_url":"https://avatars3.githubusercontent.com/u/1740009?v=4","gravatar_id":"","url":"https://api.github.com/users/rgirish28","html_url":"https://github.com/rgirish28","followers_url":"https://api.github.com/users/rgirish28/followers","following_url":"https://api.github.com/users/rgirish28/following{/other_user}","gists_url":"https://api.github.com/users/rgirish28/gists{/gist_id}","starred_url":"https://api.github.com/users/rgirish28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgirish28/subscriptions","organizations_url":"https://api.github.com/users/rgirish28/orgs","repos_url":"https://api.github.com/users/rgirish28/repos","events_url":"https://api.github.com/users/rgirish28/events{/privacy}","received_events_url":"https://api.github.com/users/rgirish28/received_events","type":"User","site_admin":false},"repo":{"id":123490353,"name":"appleseed","full_name":"rgirish28/appleseed","owner":{"login":"rgirish28","id":1740009,"avatar_url":"https://avatars3.githubusercontent.com/u/1740009?v=4","gravatar_id":"","url":"https://api.github.com/users/rgirish28","html_url":"https://github.com/rgirish28","followers_url":"https://api.github.com/users/rgirish28/followers","following_url":"https://api.github.com/users/rgirish28/following{/other_user}","gists_url":"https://api.github.com/users/rgirish28/gists{/gist_id}","starred_url":"https://api.github.com/users/rgirish28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgirish28/subscriptions","organizations_url":"https://api.github.com/users/rgirish28/orgs","repos_url":"https://api.github.com/users/rgirish28/repos","events_url":"https://api.github.com/users/rgirish28/events{/privacy}","received_events_url":"https://api.github.com/users/rgirish28/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgirish28/appleseed","description":"A modern open source rendering engine for animation and visual effects","fork":true,"url":"https://api.github.com/repos/rgirish28/appleseed","forks_url":"https://api.github.com/repos/rgirish28/appleseed/forks","keys_url":"https://api.github.com/repos/rgirish28/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgirish28/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgirish28/appleseed/teams","hooks_url":"https://api.github.com/repos/rgirish28/appleseed/hooks","issue_events_url":"https://api.github.com/repos/rgirish28/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/rgirish28/appleseed/events","assignees_url":"https://api.github.com/repos/rgirish28/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/rgirish28/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/rgirish28/appleseed/tags","blobs_url":"https://api.github.com/repos/rgirish28/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgirish28/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgirish28/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgirish28/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgirish28/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/rgirish28/appleseed/languages","stargazers_url":"https://api.github.com/repos/rgirish28/appleseed/stargazers","contributors_url":"https://api.github.com/repos/rgirish28/appleseed/contributors","subscribers_url":"https://api.github.com/repos/rgirish28/appleseed/subscribers","subscription_url":"https://api.github.com/repos/rgirish28/appleseed/subscription","commits_url":"https://api.github.com/repos/rgirish28/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgirish28/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgirish28/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgirish28/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgirish28/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/rgirish28/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgirish28/appleseed/merges","archive_url":"https://api.github.com/repos/rgirish28/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgirish28/appleseed/downloads","issues_url":"https://api.github.com/repos/rgirish28/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/rgirish28/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/rgirish28/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/rgirish28/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgirish28/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/rgirish28/appleseed/releases{/id}","deployments_url":"https://api.github.com/repos/rgirish28/appleseed/deployments","created_at":"2018-03-01T20:45:22Z","updated_at":"2018-03-01T20:45:36Z","pushed_at":"2018-03-07T20:04:35Z","git_url":"git://github.com/rgirish28/appleseed.git","ssh_url":"git@github.com:rgirish28/appleseed.git","clone_url":"https://github.com/rgirish28/appleseed.git","svn_url":"https://github.com/rgirish28/appleseed","homepage":"http://appleseedhq.net/","size":1196607,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appleseedhq:master","ref":"master","sha":"bf6f9939738c344ae48b1cb6b02f3abc8f0e102e","user":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"repo":{"id":753784,"name":"appleseed","full_name":"appleseedhq/appleseed","owner":{"login":"appleseedhq","id":6373510,"avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appleseedhq/appleseed","description":"A modern open source rendering engine for animation and visual effects","fork":false,"url":"https://api.github.com/repos/appleseedhq/appleseed","forks_url":"https://api.github.com/repos/appleseedhq/appleseed/forks","keys_url":"https://api.github.com/repos/appleseedhq/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appleseedhq/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appleseedhq/appleseed/teams","hooks_url":"https://api.github.com/repos/appleseedhq/appleseed/hooks","issue_events_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/appleseedhq/appleseed/events","assignees_url":"https://api.github.com/repos/appleseedhq/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/appleseedhq/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/appleseedhq/appleseed/tags","blobs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appleseedhq/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/appleseedhq/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/appleseedhq/appleseed/languages","stargazers_url":"https://api.github.com/repos/appleseedhq/appleseed/stargazers","contributors_url":"https://api.github.com/repos/appleseedhq/appleseed/contributors","subscribers_url":"https://api.github.com/repos/appleseedhq/appleseed/subscribers","subscription_url":"https://api.github.com/repos/appleseedhq/appleseed/subscription","commits_url":"https://api.github.com/repos/appleseedhq/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/appleseedhq/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/appleseedhq/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/appleseedhq/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appleseedhq/appleseed/merges","archive_url":"https://api.github.com/repos/appleseedhq/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appleseedhq/appleseed/downloads","issues_url":"https://api.github.com/repos/appleseedhq/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/appleseedhq/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/appleseedhq/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appleseedhq/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/appleseedhq/appleseed/releases{/id}","deployments_url":"https://api.github.com/repos/appleseedhq/appleseed/deployments","created_at":"2010-07-02T16:33:51Z","updated_at":"2018-03-07T08:02:16Z","pushed_at":"2018-03-07T16:08:12Z","git_url":"git://github.com/appleseedhq/appleseed.git","ssh_url":"git@github.com:appleseedhq/appleseed.git","clone_url":"https://github.com/appleseedhq/appleseed.git","svn_url":"https://github.com/appleseedhq/appleseed","homepage":"http://appleseedhq.net/","size":1197242,"stargazers_count":909,"watchers_count":909,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"archived":false,"open_issues_count":328,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":177,"open_issues":328,"watchers":909,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1889"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/1889"},"issue":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/1889"},"comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/1889/comments"},"review_comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1889/comments"},"review_comment":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/1889/commits"},"statuses":{"href":"https://api.github.com/repos/appleseedhq/appleseed/statuses/9a7a6947890bd7e8cf7c205ccb992c82768ed676"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dictoon"}}