{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/196030891","pull_request_review_id":129505256,"id":196030891,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjAzMDg5MQ==","diff_hunk":"@@ -84,6 +85,9 @@ export const updateOldState = (visState) => {\n     delete newState.params.metric.autoExtend;\n     newState.params.metric.metricColorMode = newState.params.metric.gaugeColorMode;\n     delete newState.params.metric.gaugeColorMode;\n+  } else if(visState.type === 'metric' && _.get(visState.params, 'gauge.gaugeType', 'Metric') !== 'Metric') {","path":"src/ui/public/vis/vis_update_state.js","position":12,"original_position":12,"commit_id":"b7c4fe9ebf3e3f527cda5a1527ed44e45ea81837","original_commit_id":"b7c4fe9ebf3e3f527cda5a1527ed44e45ea81837","user":{"login":"timroes","id":877229,"node_id":"MDQ6VXNlcjg3NzIyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/877229?v=4","gravatar_id":"","url":"https://api.github.com/users/timroes","html_url":"https://github.com/timroes","followers_url":"https://api.github.com/users/timroes/followers","following_url":"https://api.github.com/users/timroes/following{/other_user}","gists_url":"https://api.github.com/users/timroes/gists{/gist_id}","starred_url":"https://api.github.com/users/timroes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timroes/subscriptions","organizations_url":"https://api.github.com/users/timroes/orgs","repos_url":"https://api.github.com/users/timroes/repos","events_url":"https://api.github.com/users/timroes/events{/privacy}","received_events_url":"https://api.github.com/users/timroes/received_events","type":"User","site_admin":false},"body":"We now assume `Metric` as default, because in case you only created a metric and never switched to gauge, `gauge.gaugeType` won't even exist. So we only want to transfer to gauge if we really have a gaugeType, that is not `Metric`.","created_at":"2018-06-18T10:28:31Z","updated_at":"2018-06-18T10:28:31Z","html_url":"https://github.com/elastic/kibana/pull/19853#discussion_r196030891","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/19853","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/196030891"},"html":{"href":"https://github.com/elastic/kibana/pull/19853#discussion_r196030891"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/19853"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/19853","id":194581221,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTgxMjIx","html_url":"https://github.com/elastic/kibana/pull/19853","diff_url":"https://github.com/elastic/kibana/pull/19853.diff","patch_url":"https://github.com/elastic/kibana/pull/19853.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/19853","number":19853,"state":"open","locked":false,"title":"Fix broken migration for old gauge format","user":{"login":"timroes","id":877229,"node_id":"MDQ6VXNlcjg3NzIyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/877229?v=4","gravatar_id":"","url":"https://api.github.com/users/timroes","html_url":"https://github.com/timroes","followers_url":"https://api.github.com/users/timroes/followers","following_url":"https://api.github.com/users/timroes/following{/other_user}","gists_url":"https://api.github.com/users/timroes/gists{/gist_id}","starred_url":"https://api.github.com/users/timroes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timroes/subscriptions","organizations_url":"https://api.github.com/users/timroes/orgs","repos_url":"https://api.github.com/users/timroes/repos","events_url":"https://api.github.com/users/timroes/events{/privacy}","received_events_url":"https://api.github.com/users/timroes/received_events","type":"User","site_admin":false},"body":"This fixes #19823 and now correctly convert gauge charts that have initially be created as metrics and then switched to type gauge in the 5.6/6.0 implementation, to a proper gauge chart.\r\n\r\nAlso I moved the related tests to jest, since they don't rely on Angular at all.","created_at":"2018-06-13T13:11:17Z","updated_at":"2018-06-18T10:28:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dcde8d38d6ed4c0d8cc4a43964df106cf85568b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"markov00","id":1421091,"node_id":"MDQ6VXNlcjE0MjEwOTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1421091?v=4","gravatar_id":"","url":"https://api.github.com/users/markov00","html_url":"https://github.com/markov00","followers_url":"https://api.github.com/users/markov00/followers","following_url":"https://api.github.com/users/markov00/following{/other_user}","gists_url":"https://api.github.com/users/markov00/gists{/gist_id}","starred_url":"https://api.github.com/users/markov00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markov00/subscriptions","organizations_url":"https://api.github.com/users/markov00/orgs","repos_url":"https://api.github.com/users/markov00/repos","events_url":"https://api.github.com/users/markov00/events{/privacy}","received_events_url":"https://api.github.com/users/markov00/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":462161355,"node_id":"MDU6TGFiZWw0NjIxNjEzNTU=","url":"https://api.github.com/repos/elastic/kibana/labels/:Visualizations","name":":Visualizations","color":"fef2c0","default":false},{"id":26198234,"node_id":"MDU6TGFiZWwyNjE5ODIzNA==","url":"https://api.github.com/repos/elastic/kibana/labels/bug","name":"bug","color":"9e2c2c","default":true},{"id":883958396,"node_id":"MDU6TGFiZWw4ODM5NTgzOTY=","url":"https://api.github.com/repos/elastic/kibana/labels/v6.4.0","name":"v6.4.0","color":"ffffff","default":false},{"id":654061976,"node_id":"MDU6TGFiZWw2NTQwNjE5NzY=","url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/19853/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/19853/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/19853/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/b7c4fe9ebf3e3f527cda5a1527ed44e45ea81837","head":{"label":"timroes:fix-gauge-migration","ref":"fix-gauge-migration","sha":"b7c4fe9ebf3e3f527cda5a1527ed44e45ea81837","user":{"login":"timroes","id":877229,"node_id":"MDQ6VXNlcjg3NzIyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/877229?v=4","gravatar_id":"","url":"https://api.github.com/users/timroes","html_url":"https://github.com/timroes","followers_url":"https://api.github.com/users/timroes/followers","following_url":"https://api.github.com/users/timroes/following{/other_user}","gists_url":"https://api.github.com/users/timroes/gists{/gist_id}","starred_url":"https://api.github.com/users/timroes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timroes/subscriptions","organizations_url":"https://api.github.com/users/timroes/orgs","repos_url":"https://api.github.com/users/timroes/repos","events_url":"https://api.github.com/users/timroes/events{/privacy}","received_events_url":"https://api.github.com/users/timroes/received_events","type":"User","site_admin":false},"repo":{"id":30105345,"node_id":"MDEwOlJlcG9zaXRvcnkzMDEwNTM0NQ==","name":"kibana","full_name":"timroes/kibana","owner":{"login":"timroes","id":877229,"node_id":"MDQ6VXNlcjg3NzIyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/877229?v=4","gravatar_id":"","url":"https://api.github.com/users/timroes","html_url":"https://github.com/timroes","followers_url":"https://api.github.com/users/timroes/followers","following_url":"https://api.github.com/users/timroes/following{/other_user}","gists_url":"https://api.github.com/users/timroes/gists{/gist_id}","starred_url":"https://api.github.com/users/timroes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timroes/subscriptions","organizations_url":"https://api.github.com/users/timroes/orgs","repos_url":"https://api.github.com/users/timroes/repos","events_url":"https://api.github.com/users/timroes/events{/privacy}","received_events_url":"https://api.github.com/users/timroes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timroes/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/timroes/kibana","forks_url":"https://api.github.com/repos/timroes/kibana/forks","keys_url":"https://api.github.com/repos/timroes/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timroes/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timroes/kibana/teams","hooks_url":"https://api.github.com/repos/timroes/kibana/hooks","issue_events_url":"https://api.github.com/repos/timroes/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/timroes/kibana/events","assignees_url":"https://api.github.com/repos/timroes/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/timroes/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/timroes/kibana/tags","blobs_url":"https://api.github.com/repos/timroes/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timroes/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timroes/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/timroes/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timroes/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/timroes/kibana/languages","stargazers_url":"https://api.github.com/repos/timroes/kibana/stargazers","contributors_url":"https://api.github.com/repos/timroes/kibana/contributors","subscribers_url":"https://api.github.com/repos/timroes/kibana/subscribers","subscription_url":"https://api.github.com/repos/timroes/kibana/subscription","commits_url":"https://api.github.com/repos/timroes/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/timroes/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/timroes/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/timroes/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/timroes/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/timroes/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timroes/kibana/merges","archive_url":"https://api.github.com/repos/timroes/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timroes/kibana/downloads","issues_url":"https://api.github.com/repos/timroes/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/timroes/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/timroes/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/timroes/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timroes/kibana/labels{/name}","releases_url":"https://api.github.com/repos/timroes/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/timroes/kibana/deployments","created_at":"2015-01-31T07:05:20Z","updated_at":"2016-12-17T07:34:21Z","pushed_at":"2018-06-18T10:27:42Z","git_url":"git://github.com/timroes/kibana.git","ssh_url":"git@github.com:timroes/kibana.git","clone_url":"https://github.com/timroes/kibana.git","svn_url":"https://github.com/timroes/kibana","homepage":"http://www.elasticsearch.org/overview/kibana/","size":395078,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"6bc29db0849bf219d578eeac2ff1f7a06238a379","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-06-18T09:19:41Z","pushed_at":"2018-06-18T10:27:45Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":415814,"stargazers_count":9517,"watchers_count":9517,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3698,"mirror_url":null,"archived":false,"open_issues_count":3186,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3698,"open_issues":3186,"watchers":9517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/19853"},"html":{"href":"https://github.com/elastic/kibana/pull/19853"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/19853"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/19853/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/19853/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/19853/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/b7c4fe9ebf3e3f527cda5a1527ed44e45ea81837"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"timroes"}}