{"action":"created","comment":{"url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/comments/232959612","pull_request_review_id":174267476,"id":232959612,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjk1OTYxMg==","diff_hunk":"@@ -62,13 +62,13 @@ Rectangle {\n \n             ComboBox {\n                 id: basemapComboBox\n+                property int modelWidth: 0\n+                Layout.minimumWidth: modelWidth + leftPadding + rightPadding + indicator.width\n                 Layout.margins: 5\n                 Layout.fillWidth: true\n                 model: [\"Streets\", \"Imagery\", \"Topographic\", \"Oceans\"]\n \n-                property int modelWidth: 0\n-                Layout.minimumWidth: modelWidth + leftPadding + rightPadding + indicator.width\n-                Component.onCompleted : {\n+               Component.onCompleted : {","path":"ArcGISRuntimeSDKQt_CppSamples/Maps/CreateAndSaveMap/LayerWindow.qml","position":10,"original_position":13,"commit_id":"c1c4a8def6e30014705103131a8eae79f69724fa","original_commit_id":"c1c4a8def6e30014705103131a8eae79f69724fa","user":{"login":"lsmallwood","id":19823035,"node_id":"MDQ6VXNlcjE5ODIzMDM1","avatar_url":"https://avatars1.githubusercontent.com/u/19823035?v=4","gravatar_id":"","url":"https://api.github.com/users/lsmallwood","html_url":"https://github.com/lsmallwood","followers_url":"https://api.github.com/users/lsmallwood/followers","following_url":"https://api.github.com/users/lsmallwood/following{/other_user}","gists_url":"https://api.github.com/users/lsmallwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lsmallwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsmallwood/subscriptions","organizations_url":"https://api.github.com/users/lsmallwood/orgs","repos_url":"https://api.github.com/users/lsmallwood/repos","events_url":"https://api.github.com/users/lsmallwood/events{/privacy}","received_events_url":"https://api.github.com/users/lsmallwood/received_events","type":"User","site_admin":false},"body":"indentation?","created_at":"2018-11-13T09:38:17Z","updated_at":"2018-11-13T09:39:47Z","html_url":"https://github.com/Esri/arcgis-runtime-samples-qt/pull/798#discussion_r232959612","pull_request_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/798","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/comments/232959612"},"html":{"href":"https://github.com/Esri/arcgis-runtime-samples-qt/pull/798#discussion_r232959612"},"pull_request":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/798"}}},"pull_request":{"url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/798","id":230169879,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTY5ODc5","html_url":"https://github.com/Esri/arcgis-runtime-samples-qt/pull/798","diff_url":"https://github.com/Esri/arcgis-runtime-samples-qt/pull/798.diff","patch_url":"https://github.com/Esri/arcgis-runtime-samples-qt/pull/798.patch","issue_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues/798","number":798,"state":"closed","locked":false,"title":"Combo boxes now resize to the text","user":{"login":"anmacdonald","id":42203545,"node_id":"MDQ6VXNlcjQyMjAzNTQ1","avatar_url":"https://avatars1.githubusercontent.com/u/42203545?v=4","gravatar_id":"","url":"https://api.github.com/users/anmacdonald","html_url":"https://github.com/anmacdonald","followers_url":"https://api.github.com/users/anmacdonald/followers","following_url":"https://api.github.com/users/anmacdonald/following{/other_user}","gists_url":"https://api.github.com/users/anmacdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/anmacdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmacdonald/subscriptions","organizations_url":"https://api.github.com/users/anmacdonald/orgs","repos_url":"https://api.github.com/users/anmacdonald/repos","events_url":"https://api.github.com/users/anmacdonald/events{/privacy}","received_events_url":"https://api.github.com/users/anmacdonald/received_events","type":"User","site_admin":false},"body":"Combo boxes now resize to the text width of the largest potential model contents they hold.\r\n\r\nSome row/column combinations have been expunged in favour of GridLayout to ensure correct resizing around text contents.\r\n\r\nFor this reason several UI files were deleted from the ``BlendRaster`` sample as it relied on old method of row encapsulation.","created_at":"2018-11-12T15:19:34Z","updated_at":"2018-11-13T09:39:47Z","closed_at":"2018-11-12T19:05:46Z","merged_at":"2018-11-12T19:05:46Z","merge_commit_sha":"2a0b987f19d8c45f39c34c443bd2735758e32c32","assignee":{"login":"lsmallwood","id":19823035,"node_id":"MDQ6VXNlcjE5ODIzMDM1","avatar_url":"https://avatars1.githubusercontent.com/u/19823035?v=4","gravatar_id":"","url":"https://api.github.com/users/lsmallwood","html_url":"https://github.com/lsmallwood","followers_url":"https://api.github.com/users/lsmallwood/followers","following_url":"https://api.github.com/users/lsmallwood/following{/other_user}","gists_url":"https://api.github.com/users/lsmallwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lsmallwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsmallwood/subscriptions","organizations_url":"https://api.github.com/users/lsmallwood/orgs","repos_url":"https://api.github.com/users/lsmallwood/repos","events_url":"https://api.github.com/users/lsmallwood/events{/privacy}","received_events_url":"https://api.github.com/users/lsmallwood/received_events","type":"User","site_admin":false},"assignees":[{"login":"lsmallwood","id":19823035,"node_id":"MDQ6VXNlcjE5ODIzMDM1","avatar_url":"https://avatars1.githubusercontent.com/u/19823035?v=4","gravatar_id":"","url":"https://api.github.com/users/lsmallwood","html_url":"https://github.com/lsmallwood","followers_url":"https://api.github.com/users/lsmallwood/followers","following_url":"https://api.github.com/users/lsmallwood/following{/other_user}","gists_url":"https://api.github.com/users/lsmallwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lsmallwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsmallwood/subscriptions","organizations_url":"https://api.github.com/users/lsmallwood/orgs","repos_url":"https://api.github.com/users/lsmallwood/repos","events_url":"https://api.github.com/users/lsmallwood/events{/privacy}","received_events_url":"https://api.github.com/users/lsmallwood/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/798/commits","review_comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/798/comments","review_comment_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues/798/comments","statuses_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/statuses/c1c4a8def6e30014705103131a8eae79f69724fa","head":{"label":"Esri:anmacdonald/combobox_resizing","ref":"anmacdonald/combobox_resizing","sha":"c1c4a8def6e30014705103131a8eae79f69724fa","user":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"repo":{"id":33001079,"node_id":"MDEwOlJlcG9zaXRvcnkzMzAwMTA3OQ==","name":"arcgis-runtime-samples-qt","full_name":"Esri/arcgis-runtime-samples-qt","private":false,"owner":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Esri/arcgis-runtime-samples-qt","description":"ArcGIS Runtime SDK for Qt samples for Qt Creator. ","fork":false,"url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt","forks_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/forks","keys_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/teams","hooks_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/hooks","issue_events_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues/events{/number}","events_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/events","assignees_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/assignees{/user}","branches_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/branches{/branch}","tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/tags","blobs_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/statuses/{sha}","languages_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/languages","stargazers_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/stargazers","contributors_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/contributors","subscribers_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/subscribers","subscription_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/subscription","commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/contents/{+path}","compare_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/merges","archive_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/downloads","issues_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues{/number}","pulls_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls{/number}","milestones_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/milestones{/number}","notifications_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/labels{/name}","releases_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/releases{/id}","deployments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/deployments","created_at":"2015-03-27T17:55:54Z","updated_at":"2018-10-22T13:03:50Z","pushed_at":"2018-11-13T08:04:38Z","git_url":"git://github.com/Esri/arcgis-runtime-samples-qt.git","ssh_url":"git@github.com:Esri/arcgis-runtime-samples-qt.git","clone_url":"https://github.com/Esri/arcgis-runtime-samples-qt.git","svn_url":"https://github.com/Esri/arcgis-runtime-samples-qt","homepage":"","size":149038,"stargazers_count":40,"watchers_count":40,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":62,"open_issues":2,"watchers":40,"default_branch":"master"}},"base":{"label":"Esri:v.next","ref":"v.next","sha":"efaffcd905441367a781575ba1d8a9a4bcceaf9b","user":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"repo":{"id":33001079,"node_id":"MDEwOlJlcG9zaXRvcnkzMzAwMTA3OQ==","name":"arcgis-runtime-samples-qt","full_name":"Esri/arcgis-runtime-samples-qt","private":false,"owner":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Esri/arcgis-runtime-samples-qt","description":"ArcGIS Runtime SDK for Qt samples for Qt Creator. ","fork":false,"url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt","forks_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/forks","keys_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/teams","hooks_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/hooks","issue_events_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues/events{/number}","events_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/events","assignees_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/assignees{/user}","branches_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/branches{/branch}","tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/tags","blobs_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/statuses/{sha}","languages_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/languages","stargazers_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/stargazers","contributors_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/contributors","subscribers_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/subscribers","subscription_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/subscription","commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/contents/{+path}","compare_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/merges","archive_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/downloads","issues_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues{/number}","pulls_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls{/number}","milestones_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/milestones{/number}","notifications_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/labels{/name}","releases_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/releases{/id}","deployments_url":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/deployments","created_at":"2015-03-27T17:55:54Z","updated_at":"2018-10-22T13:03:50Z","pushed_at":"2018-11-13T08:04:38Z","git_url":"git://github.com/Esri/arcgis-runtime-samples-qt.git","ssh_url":"git@github.com:Esri/arcgis-runtime-samples-qt.git","clone_url":"https://github.com/Esri/arcgis-runtime-samples-qt.git","svn_url":"https://github.com/Esri/arcgis-runtime-samples-qt","homepage":"","size":149038,"stargazers_count":40,"watchers_count":40,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":62,"open_issues":2,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/798"},"html":{"href":"https://github.com/Esri/arcgis-runtime-samples-qt/pull/798"},"issue":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues/798"},"comments":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/issues/798/comments"},"review_comments":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/798/comments"},"review_comment":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/pulls/798/commits"},"statuses":{"href":"https://api.github.com/repos/Esri/arcgis-runtime-samples-qt/statuses/c1c4a8def6e30014705103131a8eae79f69724fa"}},"author_association":"NONE"}}
{"actor":{"display_login":"lsmallwood"}}