{"action":"created","issue":{"url":"https://api.github.com/repos/flutter/flutter/issues/21760","repository_url":"https://api.github.com/repos/flutter/flutter","labels_url":"https://api.github.com/repos/flutter/flutter/issues/21760/labels{/name}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/21760/comments","events_url":"https://api.github.com/repos/flutter/flutter/issues/21760/events","html_url":"https://github.com/flutter/flutter/pull/21760","id":359687770,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MTIzODY0","number":21760,"title":"Simplify gradle compiler output","user":{"login":"gspencergoog","id":8867023,"node_id":"MDQ6VXNlcjg4NjcwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8867023?v=4","gravatar_id":"","url":"https://api.github.com/users/gspencergoog","html_url":"https://github.com/gspencergoog","followers_url":"https://api.github.com/users/gspencergoog/followers","following_url":"https://api.github.com/users/gspencergoog/following{/other_user}","gists_url":"https://api.github.com/users/gspencergoog/gists{/gist_id}","starred_url":"https://api.github.com/users/gspencergoog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gspencergoog/subscriptions","organizations_url":"https://api.github.com/users/gspencergoog/orgs","repos_url":"https://api.github.com/users/gspencergoog/repos","events_url":"https://api.github.com/users/gspencergoog/events{/privacy}","received_events_url":"https://api.github.com/users/gspencergoog/received_events","type":"User","site_admin":false},"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-09-12T23:25:21Z","updated_at":"2018-09-14T17:28:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/21760","html_url":"https://github.com/flutter/flutter/pull/21760","diff_url":"https://github.com/flutter/flutter/pull/21760.diff","patch_url":"https://github.com/flutter/flutter/pull/21760.patch"},"body":"This changes the compiler output for gradle to be less verbose and more easily read.\r\n\r\nIt changes this:\r\n```\r\nhello_world > flutter build apk\r\nInitializing gradle...                                       1.0s\r\nResolving dependencies...                                    8.9s\r\nRunning 'gradlew assembleRelease'...                             \r\ncompiler message: lib/main.dart:7:43: Error: Method not found: 'Txt'.\r\ncompiler message: void main() => runApp(const Center(child: Txt('Hello, world!', textDirection: TextDirection.ltr)));\r\ncompiler message:                                           ^\r\nCompiler terminated unexpectedly.\r\n\r\nFAILURE: Build failed with an exception.\r\n\r\n* Where:\r\nScript '/usr/local/google/home/gspencer/code/flutter/packages/flutter_tools/gradle/flutter.gradle' line: 428\r\n\r\n* What went wrong:\r\nExecution failed for task ':app:flutterBuildRelease'.\r\n> Process 'command '/usr/local/google/home/gspencer/code/flutter/bin/flutter'' finished with non-zero exit value 1\r\n\r\n* Try:\r\nRun with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.\r\n\r\n* Get more help at https://help.gradle.org\r\n\r\nBUILD FAILED in 6s\r\n 7.1s\r\nGradle build failed: 1\r\n```\r\n\r\nTo this:\r\n```\r\nhello_world > flutter build apk\r\nBuilding flutter tool...\r\nRunning \"flutter packages get\" in hello_world...             0.7s\r\nInitializing gradle...                                       0.8s\r\nResolving dependencies...                                    1.4s\r\nGradle task 'assembleRelease'...                                 \r\n\r\nCompiler message:\r\nlib/main.dart:7:43: Error: Method not found: 'Txt'.\r\nvoid main() => runApp(const Center(child: Txt('Hello, world!', textDirection: TextDirection.ltr)));\r\n                                          ^\r\nCompiler terminated unexpectedly.\r\n    \r\nGradle task 'assembleRelease'... Done                        6.7s\r\nGradle task assembleRelease failed with exit code 1\r\n\r\n```\r\n\r\nThis only applies to compilation error messages: other gradle messages will continue to print as before.\r\n\r\nIt also fixes a small problem with the performance measurement printing (see that \"7.1s\" on it's own line in the original?) so that if something is expected to have multiple lines of output, it prints an initial line, and a \"Done\" line with the elapsed time, so that it's possible to know what the time applies to.\r\n\r\nAddresses https://github.com/flutter/flutter/issues/17307"},"comment":{"url":"https://api.github.com/repos/flutter/flutter/issues/comments/421429162","html_url":"https://github.com/flutter/flutter/pull/21760#issuecomment-421429162","issue_url":"https://api.github.com/repos/flutter/flutter/issues/21760","id":421429162,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTQyOTE2Mg==","user":{"login":"gspencergoog","id":8867023,"node_id":"MDQ6VXNlcjg4NjcwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8867023?v=4","gravatar_id":"","url":"https://api.github.com/users/gspencergoog","html_url":"https://github.com/gspencergoog","followers_url":"https://api.github.com/users/gspencergoog/followers","following_url":"https://api.github.com/users/gspencergoog/following{/other_user}","gists_url":"https://api.github.com/users/gspencergoog/gists{/gist_id}","starred_url":"https://api.github.com/users/gspencergoog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gspencergoog/subscriptions","organizations_url":"https://api.github.com/users/gspencergoog/orgs","repos_url":"https://api.github.com/users/gspencergoog/repos","events_url":"https://api.github.com/users/gspencergoog/events{/privacy}","received_events_url":"https://api.github.com/users/gspencergoog/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T17:28:56Z","updated_at":"2018-09-14T17:28:56Z","author_association":"CONTRIBUTOR","body":"@kandarpksk, here's that PR with the compiler message change.  There's also another PR (https://github.com/flutter/flutter/pull/20958) that will change the color of the error itself to be red."}}
{"actor":{"display_login":"gspencergoog"}}