{"action":"created","issue":{"url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/476","repository_url":"https://api.github.com/repos/bazelbuild/rules_scala","labels_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/476/labels{/name}","comments_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/476/comments","events_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/476/events","html_url":"https://github.com/bazelbuild/rules_scala/issues/476","id":312528657,"number":476,"title":"Should `scala_import` return jar output file provider (in addition to java_common provider)?","user":{"login":"natansil","id":11754053,"avatar_url":"https://avatars0.githubusercontent.com/u/11754053?v=4","gravatar_id":"","url":"https://api.github.com/users/natansil","html_url":"https://github.com/natansil","followers_url":"https://api.github.com/users/natansil/followers","following_url":"https://api.github.com/users/natansil/following{/other_user}","gists_url":"https://api.github.com/users/natansil/gists{/gist_id}","starred_url":"https://api.github.com/users/natansil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natansil/subscriptions","organizations_url":"https://api.github.com/users/natansil/orgs","repos_url":"https://api.github.com/users/natansil/repos","events_url":"https://api.github.com/users/natansil/events{/privacy}","received_events_url":"https://api.github.com/users/natansil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"iirina","id":1687706,"avatar_url":"https://avatars3.githubusercontent.com/u/1687706?v=4","gravatar_id":"","url":"https://api.github.com/users/iirina","html_url":"https://github.com/iirina","followers_url":"https://api.github.com/users/iirina/followers","following_url":"https://api.github.com/users/iirina/following{/other_user}","gists_url":"https://api.github.com/users/iirina/gists{/gist_id}","starred_url":"https://api.github.com/users/iirina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iirina/subscriptions","organizations_url":"https://api.github.com/users/iirina/orgs","repos_url":"https://api.github.com/users/iirina/repos","events_url":"https://api.github.com/users/iirina/events{/privacy}","received_events_url":"https://api.github.com/users/iirina/received_events","type":"User","site_admin":false},"assignees":[{"login":"iirina","id":1687706,"avatar_url":"https://avatars3.githubusercontent.com/u/1687706?v=4","gravatar_id":"","url":"https://api.github.com/users/iirina","html_url":"https://github.com/iirina","followers_url":"https://api.github.com/users/iirina/followers","following_url":"https://api.github.com/users/iirina/following{/other_user}","gists_url":"https://api.github.com/users/iirina/gists{/gist_id}","starred_url":"https://api.github.com/users/iirina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iirina/subscriptions","organizations_url":"https://api.github.com/users/iirina/orgs","repos_url":"https://api.github.com/users/iirina/repos","events_url":"https://api.github.com/users/iirina/events{/privacy}","received_events_url":"https://api.github.com/users/iirina/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-04-09T13:22:23Z","updated_at":"2018-04-13T03:35:05Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"During work on this [PR](https://github.com/bazelbuild/rules_scala/pull/473) I've noticed that location expansion of jars exposed by `scala_import` fails:\r\nFor [example](https://github.com/bazelbuild/rules_scala/blob/aaa6c7d4db4f231a541f20a60760420f4bdd11e8/third_party/plugin/src/test/BUILD#L19)\r\n`$(location @com_google_guava_guava_21_0//jar)` fails with `label '@com_google_guava_guava_21_0//jar:jar' in $(location) expression expands to no files.` when the jar target is of type `rules_scala`\r\n\r\nSo it seems that `scala_import` is missing a feature for exposing jar output files.\r\n\r\n@lberki are bazel rules idiomatically expected to output files?"},"comment":{"url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/comments/381011822","html_url":"https://github.com/bazelbuild/rules_scala/issues/476#issuecomment-381011822","issue_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/476","id":381011822,"user":{"login":"ittaiz","id":1378327,"avatar_url":"https://avatars2.githubusercontent.com/u/1378327?v=4","gravatar_id":"","url":"https://api.github.com/users/ittaiz","html_url":"https://github.com/ittaiz","followers_url":"https://api.github.com/users/ittaiz/followers","following_url":"https://api.github.com/users/ittaiz/following{/other_user}","gists_url":"https://api.github.com/users/ittaiz/gists{/gist_id}","starred_url":"https://api.github.com/users/ittaiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ittaiz/subscriptions","organizations_url":"https://api.github.com/users/ittaiz/orgs","repos_url":"https://api.github.com/users/ittaiz/repos","events_url":"https://api.github.com/users/ittaiz/events{/privacy}","received_events_url":"https://api.github.com/users/ittaiz/received_events","type":"User","site_admin":false},"created_at":"2018-04-13T03:35:04Z","updated_at":"2018-04-13T03:35:04Z","author_association":"MEMBER","body":"Do you have a problem this would solve?\nIf not let’s please not add this to 477 which is already a hard PR to\nreview due to the rewrite\nOn Fri, 13 Apr 2018 at 6:24 James Judd <notifications@github.com> wrote:\n\n> I ran into this issue and noticed #477\n> <https://github.com/bazelbuild/rules_scala/pull/477> to refactor\n> scala_import. I opened a PR to #477\n> <https://github.com/bazelbuild/rules_scala/pull/477>'s branch branch to\n> add a DefaultInfo with files: andyscott#1\n> <https://github.com/andyscott/rules_scala/pull/1>\n>\n> There's no test. I can add one. I'm interested in getting people's\n> feedback, considering I'm not very familiar with DefaultInfo and that the\n> documentation is a bit sparse.\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/bazelbuild/rules_scala/issues/476#issuecomment-381010407>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ABUIF8NcAkesf67bAPG97vKVJ_cqMVrPks5toBqEgaJpZM4TMh9C>\n> .\n>\n"}}
{"actor":{"display_login":"ittaiz"}}