{"action":"created","comment":{"url":"https://api.github.com/repos/nvaccess/nvda/pulls/comments/182537327","pull_request_review_id":113352760,"id":182537327,"diff_hunk":"@@ -333,7 +335,15 @@ def _getColumnContentRaw(self, index):\n \t\treturn buffer.value if buffer else None\r\n \r\n \tdef _getColumnContent(self, column):\r\n-\t\treturn self._getColumnContentRaw(self.parent._columnOrderArray[column - 1])\r\n+\t\ttargetColumn = self.parent._columnOrderArray[column - 1]\r\n+\t\ttry:\r\n+\t\t\treturn self._getColumnContentRaw(targetColumn)\r\n+\t\texcept ArgumentError:\r","path":"source/NVDAObjects/IAccessible/sysListView32.py","position":26,"original_position":26,"commit_id":"a98f6b3239353ec7c196d9c8f8db6e2ba5fded0a","original_commit_id":"a98f6b3239353ec7c196d9c8f8db6e2ba5fded0a","user":{"login":"leonardder","id":3049216,"avatar_url":"https://avatars1.githubusercontent.com/u/3049216?v=4","gravatar_id":"","url":"https://api.github.com/users/leonardder","html_url":"https://github.com/leonardder","followers_url":"https://api.github.com/users/leonardder/followers","following_url":"https://api.github.com/users/leonardder/following{/other_user}","gists_url":"https://api.github.com/users/leonardder/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardder/subscriptions","organizations_url":"https://api.github.com/users/leonardder/orgs","repos_url":"https://api.github.com/users/leonardder/repos","events_url":"https://api.github.com/users/leonardder/events{/privacy}","received_events_url":"https://api.github.com/users/leonardder/received_events","type":"User","site_admin":false},"body":"Could you please log a debugWarning here? Like:\r\n\r\n```\r\nexcept ArgumentError as e:\r\n\t\t\tlog.debugWarning(\"Could not retrieve content for column %d, %r\" % (column, e))\r\n```\r\n\r\nThis might be a bit obnoxious in the log though. May be log.debug would be enough here, I'm not sure. @MichaelDCurran might have some thoughts about this.","created_at":"2018-04-18T19:06:29Z","updated_at":"2018-04-18T19:07:11Z","html_url":"https://github.com/nvaccess/nvda/pull/8190#discussion_r182537327","pull_request_url":"https://api.github.com/repos/nvaccess/nvda/pulls/8190","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/comments/182537327"},"html":{"href":"https://github.com/nvaccess/nvda/pull/8190#discussion_r182537327"},"pull_request":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/8190"}}},"pull_request":{"url":"https://api.github.com/repos/nvaccess/nvda/pulls/8190","id":182389298,"html_url":"https://github.com/nvaccess/nvda/pull/8190","diff_url":"https://github.com/nvaccess/nvda/pull/8190.diff","patch_url":"https://github.com/nvaccess/nvda/pull/8190.patch","issue_url":"https://api.github.com/repos/nvaccess/nvda/issues/8190","number":8190,"state":"open","locked":false,"title":"return valid text for list views in 64-bit mode","user":{"login":"Robert-J-H","id":11905420,"avatar_url":"https://avatars1.githubusercontent.com/u/11905420?v=4","gravatar_id":"","url":"https://api.github.com/users/Robert-J-H","html_url":"https://github.com/Robert-J-H","followers_url":"https://api.github.com/users/Robert-J-H/followers","following_url":"https://api.github.com/users/Robert-J-H/following{/other_user}","gists_url":"https://api.github.com/users/Robert-J-H/gists{/gist_id}","starred_url":"https://api.github.com/users/Robert-J-H/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robert-J-H/subscriptions","organizations_url":"https://api.github.com/users/Robert-J-H/orgs","repos_url":"https://api.github.com/users/Robert-J-H/repos","events_url":"https://api.github.com/users/Robert-J-H/events{/privacy}","received_events_url":"https://api.github.com/users/Robert-J-H/received_events","type":"User","site_admin":false},"body":"### Link to issue number:\r\nCloses #8175 \r\n\r\n### Summary of the issue:\r\nItem text in a list view can't be retrieved if the returned pointer is 64 bits long.\r\nExample: Tortoise SVN on a 64-bit machine.\r\nCurrently, no exception handling is performed for this case.\r\n\r\n### Description of how this pull request fixes the issue:\r\nThe workaround will first attempt to get the item text by the native procedure.  \r\nIf this fails, the item text will be retrieved from the display text instead. \r\nCare is taken to limit the text to the column width without splitting words if possible.\r\n\r\n### Testing performed:\r\nOnly with Tortoise SVN. \r\nNavigating with arrow keys works fine, so does table navigation.\r\n\r\n### Known issues with pull request:\r\nTortoise's list view has some peculiarities itself that aren't addressed with this commit.\r\nFor instance, the first and last entries for an update are not related to the headers, thus,\r\n\"Update completed at: Revision xxx\" will be rendered as\r\n\r\n\"Update completed at: Path Revision xxx\" if announcing of headers is enabled.\r\n\r\n### Change log entry:\r\nNot changed yet, would probably go under\r\n* Bug fixes\r\n","created_at":"2018-04-18T07:26:01Z","updated_at":"2018-04-18T19:07:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1824f48add18e282b9e4f10ec5eb914e79f7c982","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nvaccess/nvda/pulls/8190/commits","review_comments_url":"https://api.github.com/repos/nvaccess/nvda/pulls/8190/comments","review_comment_url":"https://api.github.com/repos/nvaccess/nvda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nvaccess/nvda/issues/8190/comments","statuses_url":"https://api.github.com/repos/nvaccess/nvda/statuses/a98f6b3239353ec7c196d9c8f8db6e2ba5fded0a","head":{"label":"Robert-J-H:sysListView32","ref":"sysListView32","sha":"a98f6b3239353ec7c196d9c8f8db6e2ba5fded0a","user":{"login":"Robert-J-H","id":11905420,"avatar_url":"https://avatars1.githubusercontent.com/u/11905420?v=4","gravatar_id":"","url":"https://api.github.com/users/Robert-J-H","html_url":"https://github.com/Robert-J-H","followers_url":"https://api.github.com/users/Robert-J-H/followers","following_url":"https://api.github.com/users/Robert-J-H/following{/other_user}","gists_url":"https://api.github.com/users/Robert-J-H/gists{/gist_id}","starred_url":"https://api.github.com/users/Robert-J-H/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robert-J-H/subscriptions","organizations_url":"https://api.github.com/users/Robert-J-H/orgs","repos_url":"https://api.github.com/users/Robert-J-H/repos","events_url":"https://api.github.com/users/Robert-J-H/events{/privacy}","received_events_url":"https://api.github.com/users/Robert-J-H/received_events","type":"User","site_admin":false},"repo":{"id":129406561,"name":"nvda","full_name":"Robert-J-H/nvda","owner":{"login":"Robert-J-H","id":11905420,"avatar_url":"https://avatars1.githubusercontent.com/u/11905420?v=4","gravatar_id":"","url":"https://api.github.com/users/Robert-J-H","html_url":"https://github.com/Robert-J-H","followers_url":"https://api.github.com/users/Robert-J-H/followers","following_url":"https://api.github.com/users/Robert-J-H/following{/other_user}","gists_url":"https://api.github.com/users/Robert-J-H/gists{/gist_id}","starred_url":"https://api.github.com/users/Robert-J-H/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robert-J-H/subscriptions","organizations_url":"https://api.github.com/users/Robert-J-H/orgs","repos_url":"https://api.github.com/users/Robert-J-H/repos","events_url":"https://api.github.com/users/Robert-J-H/events{/privacy}","received_events_url":"https://api.github.com/users/Robert-J-H/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Robert-J-H/nvda","description":"NVDA, the free and open source Screen Reader for Microsoft Windows","fork":true,"url":"https://api.github.com/repos/Robert-J-H/nvda","forks_url":"https://api.github.com/repos/Robert-J-H/nvda/forks","keys_url":"https://api.github.com/repos/Robert-J-H/nvda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Robert-J-H/nvda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Robert-J-H/nvda/teams","hooks_url":"https://api.github.com/repos/Robert-J-H/nvda/hooks","issue_events_url":"https://api.github.com/repos/Robert-J-H/nvda/issues/events{/number}","events_url":"https://api.github.com/repos/Robert-J-H/nvda/events","assignees_url":"https://api.github.com/repos/Robert-J-H/nvda/assignees{/user}","branches_url":"https://api.github.com/repos/Robert-J-H/nvda/branches{/branch}","tags_url":"https://api.github.com/repos/Robert-J-H/nvda/tags","blobs_url":"https://api.github.com/repos/Robert-J-H/nvda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Robert-J-H/nvda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Robert-J-H/nvda/git/refs{/sha}","trees_url":"https://api.github.com/repos/Robert-J-H/nvda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Robert-J-H/nvda/statuses/{sha}","languages_url":"https://api.github.com/repos/Robert-J-H/nvda/languages","stargazers_url":"https://api.github.com/repos/Robert-J-H/nvda/stargazers","contributors_url":"https://api.github.com/repos/Robert-J-H/nvda/contributors","subscribers_url":"https://api.github.com/repos/Robert-J-H/nvda/subscribers","subscription_url":"https://api.github.com/repos/Robert-J-H/nvda/subscription","commits_url":"https://api.github.com/repos/Robert-J-H/nvda/commits{/sha}","git_commits_url":"https://api.github.com/repos/Robert-J-H/nvda/git/commits{/sha}","comments_url":"https://api.github.com/repos/Robert-J-H/nvda/comments{/number}","issue_comment_url":"https://api.github.com/repos/Robert-J-H/nvda/issues/comments{/number}","contents_url":"https://api.github.com/repos/Robert-J-H/nvda/contents/{+path}","compare_url":"https://api.github.com/repos/Robert-J-H/nvda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Robert-J-H/nvda/merges","archive_url":"https://api.github.com/repos/Robert-J-H/nvda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Robert-J-H/nvda/downloads","issues_url":"https://api.github.com/repos/Robert-J-H/nvda/issues{/number}","pulls_url":"https://api.github.com/repos/Robert-J-H/nvda/pulls{/number}","milestones_url":"https://api.github.com/repos/Robert-J-H/nvda/milestones{/number}","notifications_url":"https://api.github.com/repos/Robert-J-H/nvda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Robert-J-H/nvda/labels{/name}","releases_url":"https://api.github.com/repos/Robert-J-H/nvda/releases{/id}","deployments_url":"https://api.github.com/repos/Robert-J-H/nvda/deployments","created_at":"2018-04-13T13:33:01Z","updated_at":"2018-04-17T08:02:27Z","pushed_at":"2018-04-18T13:38:44Z","git_url":"git://github.com/Robert-J-H/nvda.git","ssh_url":"git@github.com:Robert-J-H/nvda.git","clone_url":"https://github.com/Robert-J-H/nvda.git","svn_url":"https://github.com/Robert-J-H/nvda","homepage":null,"size":137732,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nvaccess:master","ref":"master","sha":"110b27179dc5f968a160f708bb68bde06ad30f80","user":{"login":"nvaccess","id":4166525,"avatar_url":"https://avatars2.githubusercontent.com/u/4166525?v=4","gravatar_id":"","url":"https://api.github.com/users/nvaccess","html_url":"https://github.com/nvaccess","followers_url":"https://api.github.com/users/nvaccess/followers","following_url":"https://api.github.com/users/nvaccess/following{/other_user}","gists_url":"https://api.github.com/users/nvaccess/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaccess/subscriptions","organizations_url":"https://api.github.com/users/nvaccess/orgs","repos_url":"https://api.github.com/users/nvaccess/repos","events_url":"https://api.github.com/users/nvaccess/events{/privacy}","received_events_url":"https://api.github.com/users/nvaccess/received_events","type":"Organization","site_admin":false},"repo":{"id":45885732,"name":"nvda","full_name":"nvaccess/nvda","owner":{"login":"nvaccess","id":4166525,"avatar_url":"https://avatars2.githubusercontent.com/u/4166525?v=4","gravatar_id":"","url":"https://api.github.com/users/nvaccess","html_url":"https://github.com/nvaccess","followers_url":"https://api.github.com/users/nvaccess/followers","following_url":"https://api.github.com/users/nvaccess/following{/other_user}","gists_url":"https://api.github.com/users/nvaccess/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaccess/subscriptions","organizations_url":"https://api.github.com/users/nvaccess/orgs","repos_url":"https://api.github.com/users/nvaccess/repos","events_url":"https://api.github.com/users/nvaccess/events{/privacy}","received_events_url":"https://api.github.com/users/nvaccess/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nvaccess/nvda","description":"NVDA, the free and open source Screen Reader for Microsoft Windows","fork":false,"url":"https://api.github.com/repos/nvaccess/nvda","forks_url":"https://api.github.com/repos/nvaccess/nvda/forks","keys_url":"https://api.github.com/repos/nvaccess/nvda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvaccess/nvda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvaccess/nvda/teams","hooks_url":"https://api.github.com/repos/nvaccess/nvda/hooks","issue_events_url":"https://api.github.com/repos/nvaccess/nvda/issues/events{/number}","events_url":"https://api.github.com/repos/nvaccess/nvda/events","assignees_url":"https://api.github.com/repos/nvaccess/nvda/assignees{/user}","branches_url":"https://api.github.com/repos/nvaccess/nvda/branches{/branch}","tags_url":"https://api.github.com/repos/nvaccess/nvda/tags","blobs_url":"https://api.github.com/repos/nvaccess/nvda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvaccess/nvda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvaccess/nvda/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvaccess/nvda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvaccess/nvda/statuses/{sha}","languages_url":"https://api.github.com/repos/nvaccess/nvda/languages","stargazers_url":"https://api.github.com/repos/nvaccess/nvda/stargazers","contributors_url":"https://api.github.com/repos/nvaccess/nvda/contributors","subscribers_url":"https://api.github.com/repos/nvaccess/nvda/subscribers","subscription_url":"https://api.github.com/repos/nvaccess/nvda/subscription","commits_url":"https://api.github.com/repos/nvaccess/nvda/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvaccess/nvda/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvaccess/nvda/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvaccess/nvda/issues/comments{/number}","contents_url":"https://api.github.com/repos/nvaccess/nvda/contents/{+path}","compare_url":"https://api.github.com/repos/nvaccess/nvda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvaccess/nvda/merges","archive_url":"https://api.github.com/repos/nvaccess/nvda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvaccess/nvda/downloads","issues_url":"https://api.github.com/repos/nvaccess/nvda/issues{/number}","pulls_url":"https://api.github.com/repos/nvaccess/nvda/pulls{/number}","milestones_url":"https://api.github.com/repos/nvaccess/nvda/milestones{/number}","notifications_url":"https://api.github.com/repos/nvaccess/nvda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvaccess/nvda/labels{/name}","releases_url":"https://api.github.com/repos/nvaccess/nvda/releases{/id}","deployments_url":"https://api.github.com/repos/nvaccess/nvda/deployments","created_at":"2015-11-10T03:47:11Z","updated_at":"2018-04-18T14:38:48Z","pushed_at":"2018-04-18T13:38:46Z","git_url":"git://github.com/nvaccess/nvda.git","ssh_url":"git@github.com:nvaccess/nvda.git","clone_url":"https://github.com/nvaccess/nvda.git","svn_url":"https://github.com/nvaccess/nvda","homepage":null,"size":137810,"stargazers_count":451,"watchers_count":451,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":2160,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":188,"open_issues":2160,"watchers":451,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/8190"},"html":{"href":"https://github.com/nvaccess/nvda/pull/8190"},"issue":{"href":"https://api.github.com/repos/nvaccess/nvda/issues/8190"},"comments":{"href":"https://api.github.com/repos/nvaccess/nvda/issues/8190/comments"},"review_comments":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/8190/comments"},"review_comment":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/8190/commits"},"statuses":{"href":"https://api.github.com/repos/nvaccess/nvda/statuses/a98f6b3239353ec7c196d9c8f8db6e2ba5fded0a"}},"author_association":"NONE"}}
{"actor":{"display_login":"leonardder"}}