{"action":"closed","number":82,"pull_request":{"url":"https://api.github.com/repos/ktr0731/evans/pulls/82","id":208987318,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTg3MzE4","html_url":"https://github.com/ktr0731/evans/pull/82","diff_url":"https://github.com/ktr0731/evans/pull/82.diff","patch_url":"https://github.com/ktr0731/evans/pull/82.patch","issue_url":"https://api.github.com/repos/ktr0731/evans/issues/82","number":82,"state":"closed","locked":false,"title":"Stop putting directories from the file names onto the import path","user":{"login":"ecbaldwin","id":609832,"node_id":"MDQ6VXNlcjYwOTgzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/609832?v=4","gravatar_id":"","url":"https://api.github.com/users/ecbaldwin","html_url":"https://github.com/ecbaldwin","followers_url":"https://api.github.com/users/ecbaldwin/followers","following_url":"https://api.github.com/users/ecbaldwin/following{/other_user}","gists_url":"https://api.github.com/users/ecbaldwin/gists{/gist_id}","starred_url":"https://api.github.com/users/ecbaldwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecbaldwin/subscriptions","organizations_url":"https://api.github.com/users/ecbaldwin/orgs","repos_url":"https://api.github.com/users/ecbaldwin/repos","events_url":"https://api.github.com/users/ecbaldwin/events{/privacy}","received_events_url":"https://api.github.com/users/ecbaldwin/received_events","type":"User","site_admin":false},"body":"This behavior was incorrect and led to strange behaviors. Proto files are meant\r\nto be importable using hierarchical names which should be found relative to the\r\nimport paths. Hence, adding the directory part of the given path names to the\r\nimport path only encourages incorrect use of hierarchical names\r\n\r\nFor example, if my proto file is named api.proto and is not meant to be\r\nimported with a hierarchical name, it is incorrect to allow me to specify it as\r\n`path/to/api.proto` because if I import a second file which happens to import\r\n`api.proto` the parser has no way of knowing that it is supposed to be the same\r\nas `path/to/api.proto` which I originally gave it.\r\n\r\nAddresses issue #80","created_at":"2018-08-16T21:17:26Z","updated_at":"2018-08-17T09:37:33Z","closed_at":"2018-08-17T09:37:33Z","merged_at":"2018-08-17T09:37:33Z","merge_commit_sha":"638748badd37905289dfa41c79b5edf7d6e74e01","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ktr0731/evans/pulls/82/commits","review_comments_url":"https://api.github.com/repos/ktr0731/evans/pulls/82/comments","review_comment_url":"https://api.github.com/repos/ktr0731/evans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ktr0731/evans/issues/82/comments","statuses_url":"https://api.github.com/repos/ktr0731/evans/statuses/e6409a258cd31751959a2a3f6a205b7f1781c07f","head":{"label":"ecbaldwin:stop-putting-dirs-on-import-path","ref":"stop-putting-dirs-on-import-path","sha":"e6409a258cd31751959a2a3f6a205b7f1781c07f","user":{"login":"ecbaldwin","id":609832,"node_id":"MDQ6VXNlcjYwOTgzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/609832?v=4","gravatar_id":"","url":"https://api.github.com/users/ecbaldwin","html_url":"https://github.com/ecbaldwin","followers_url":"https://api.github.com/users/ecbaldwin/followers","following_url":"https://api.github.com/users/ecbaldwin/following{/other_user}","gists_url":"https://api.github.com/users/ecbaldwin/gists{/gist_id}","starred_url":"https://api.github.com/users/ecbaldwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecbaldwin/subscriptions","organizations_url":"https://api.github.com/users/ecbaldwin/orgs","repos_url":"https://api.github.com/users/ecbaldwin/repos","events_url":"https://api.github.com/users/ecbaldwin/events{/privacy}","received_events_url":"https://api.github.com/users/ecbaldwin/received_events","type":"User","site_admin":false},"repo":{"id":145035066,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwMzUwNjY=","name":"evans","full_name":"ecbaldwin/evans","owner":{"login":"ecbaldwin","id":609832,"node_id":"MDQ6VXNlcjYwOTgzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/609832?v=4","gravatar_id":"","url":"https://api.github.com/users/ecbaldwin","html_url":"https://github.com/ecbaldwin","followers_url":"https://api.github.com/users/ecbaldwin/followers","following_url":"https://api.github.com/users/ecbaldwin/following{/other_user}","gists_url":"https://api.github.com/users/ecbaldwin/gists{/gist_id}","starred_url":"https://api.github.com/users/ecbaldwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecbaldwin/subscriptions","organizations_url":"https://api.github.com/users/ecbaldwin/orgs","repos_url":"https://api.github.com/users/ecbaldwin/repos","events_url":"https://api.github.com/users/ecbaldwin/events{/privacy}","received_events_url":"https://api.github.com/users/ecbaldwin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ecbaldwin/evans","description":"Evans: more expressive universal gRPC client","fork":true,"url":"https://api.github.com/repos/ecbaldwin/evans","forks_url":"https://api.github.com/repos/ecbaldwin/evans/forks","keys_url":"https://api.github.com/repos/ecbaldwin/evans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ecbaldwin/evans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ecbaldwin/evans/teams","hooks_url":"https://api.github.com/repos/ecbaldwin/evans/hooks","issue_events_url":"https://api.github.com/repos/ecbaldwin/evans/issues/events{/number}","events_url":"https://api.github.com/repos/ecbaldwin/evans/events","assignees_url":"https://api.github.com/repos/ecbaldwin/evans/assignees{/user}","branches_url":"https://api.github.com/repos/ecbaldwin/evans/branches{/branch}","tags_url":"https://api.github.com/repos/ecbaldwin/evans/tags","blobs_url":"https://api.github.com/repos/ecbaldwin/evans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ecbaldwin/evans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ecbaldwin/evans/git/refs{/sha}","trees_url":"https://api.github.com/repos/ecbaldwin/evans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ecbaldwin/evans/statuses/{sha}","languages_url":"https://api.github.com/repos/ecbaldwin/evans/languages","stargazers_url":"https://api.github.com/repos/ecbaldwin/evans/stargazers","contributors_url":"https://api.github.com/repos/ecbaldwin/evans/contributors","subscribers_url":"https://api.github.com/repos/ecbaldwin/evans/subscribers","subscription_url":"https://api.github.com/repos/ecbaldwin/evans/subscription","commits_url":"https://api.github.com/repos/ecbaldwin/evans/commits{/sha}","git_commits_url":"https://api.github.com/repos/ecbaldwin/evans/git/commits{/sha}","comments_url":"https://api.github.com/repos/ecbaldwin/evans/comments{/number}","issue_comment_url":"https://api.github.com/repos/ecbaldwin/evans/issues/comments{/number}","contents_url":"https://api.github.com/repos/ecbaldwin/evans/contents/{+path}","compare_url":"https://api.github.com/repos/ecbaldwin/evans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ecbaldwin/evans/merges","archive_url":"https://api.github.com/repos/ecbaldwin/evans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ecbaldwin/evans/downloads","issues_url":"https://api.github.com/repos/ecbaldwin/evans/issues{/number}","pulls_url":"https://api.github.com/repos/ecbaldwin/evans/pulls{/number}","milestones_url":"https://api.github.com/repos/ecbaldwin/evans/milestones{/number}","notifications_url":"https://api.github.com/repos/ecbaldwin/evans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ecbaldwin/evans/labels{/name}","releases_url":"https://api.github.com/repos/ecbaldwin/evans/releases{/id}","deployments_url":"https://api.github.com/repos/ecbaldwin/evans/deployments","created_at":"2018-08-16T20:16:53Z","updated_at":"2018-08-16T20:16:55Z","pushed_at":"2018-08-16T21:17:18Z","git_url":"git://github.com/ecbaldwin/evans.git","ssh_url":"git@github.com:ecbaldwin/evans.git","clone_url":"https://github.com/ecbaldwin/evans.git","svn_url":"https://github.com/ecbaldwin/evans","homepage":"https://evans.syfm.me","size":54120,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ktr0731:master","ref":"master","sha":"10a53769b9d6469b725b7015e8959461a8df3198","user":{"login":"ktr0731","id":12953836,"node_id":"MDQ6VXNlcjEyOTUzODM2","avatar_url":"https://avatars1.githubusercontent.com/u/12953836?v=4","gravatar_id":"","url":"https://api.github.com/users/ktr0731","html_url":"https://github.com/ktr0731","followers_url":"https://api.github.com/users/ktr0731/followers","following_url":"https://api.github.com/users/ktr0731/following{/other_user}","gists_url":"https://api.github.com/users/ktr0731/gists{/gist_id}","starred_url":"https://api.github.com/users/ktr0731/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktr0731/subscriptions","organizations_url":"https://api.github.com/users/ktr0731/orgs","repos_url":"https://api.github.com/users/ktr0731/repos","events_url":"https://api.github.com/users/ktr0731/events{/privacy}","received_events_url":"https://api.github.com/users/ktr0731/received_events","type":"User","site_admin":false},"repo":{"id":97361468,"node_id":"MDEwOlJlcG9zaXRvcnk5NzM2MTQ2OA==","name":"evans","full_name":"ktr0731/evans","owner":{"login":"ktr0731","id":12953836,"node_id":"MDQ6VXNlcjEyOTUzODM2","avatar_url":"https://avatars1.githubusercontent.com/u/12953836?v=4","gravatar_id":"","url":"https://api.github.com/users/ktr0731","html_url":"https://github.com/ktr0731","followers_url":"https://api.github.com/users/ktr0731/followers","following_url":"https://api.github.com/users/ktr0731/following{/other_user}","gists_url":"https://api.github.com/users/ktr0731/gists{/gist_id}","starred_url":"https://api.github.com/users/ktr0731/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktr0731/subscriptions","organizations_url":"https://api.github.com/users/ktr0731/orgs","repos_url":"https://api.github.com/users/ktr0731/repos","events_url":"https://api.github.com/users/ktr0731/events{/privacy}","received_events_url":"https://api.github.com/users/ktr0731/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ktr0731/evans","description":"Evans: more expressive universal gRPC client","fork":false,"url":"https://api.github.com/repos/ktr0731/evans","forks_url":"https://api.github.com/repos/ktr0731/evans/forks","keys_url":"https://api.github.com/repos/ktr0731/evans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ktr0731/evans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ktr0731/evans/teams","hooks_url":"https://api.github.com/repos/ktr0731/evans/hooks","issue_events_url":"https://api.github.com/repos/ktr0731/evans/issues/events{/number}","events_url":"https://api.github.com/repos/ktr0731/evans/events","assignees_url":"https://api.github.com/repos/ktr0731/evans/assignees{/user}","branches_url":"https://api.github.com/repos/ktr0731/evans/branches{/branch}","tags_url":"https://api.github.com/repos/ktr0731/evans/tags","blobs_url":"https://api.github.com/repos/ktr0731/evans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ktr0731/evans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ktr0731/evans/git/refs{/sha}","trees_url":"https://api.github.com/repos/ktr0731/evans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ktr0731/evans/statuses/{sha}","languages_url":"https://api.github.com/repos/ktr0731/evans/languages","stargazers_url":"https://api.github.com/repos/ktr0731/evans/stargazers","contributors_url":"https://api.github.com/repos/ktr0731/evans/contributors","subscribers_url":"https://api.github.com/repos/ktr0731/evans/subscribers","subscription_url":"https://api.github.com/repos/ktr0731/evans/subscription","commits_url":"https://api.github.com/repos/ktr0731/evans/commits{/sha}","git_commits_url":"https://api.github.com/repos/ktr0731/evans/git/commits{/sha}","comments_url":"https://api.github.com/repos/ktr0731/evans/comments{/number}","issue_comment_url":"https://api.github.com/repos/ktr0731/evans/issues/comments{/number}","contents_url":"https://api.github.com/repos/ktr0731/evans/contents/{+path}","compare_url":"https://api.github.com/repos/ktr0731/evans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ktr0731/evans/merges","archive_url":"https://api.github.com/repos/ktr0731/evans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ktr0731/evans/downloads","issues_url":"https://api.github.com/repos/ktr0731/evans/issues{/number}","pulls_url":"https://api.github.com/repos/ktr0731/evans/pulls{/number}","milestones_url":"https://api.github.com/repos/ktr0731/evans/milestones{/number}","notifications_url":"https://api.github.com/repos/ktr0731/evans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ktr0731/evans/labels{/name}","releases_url":"https://api.github.com/repos/ktr0731/evans/releases{/id}","deployments_url":"https://api.github.com/repos/ktr0731/evans/deployments","created_at":"2017-07-16T05:10:41Z","updated_at":"2018-08-16T13:22:38Z","pushed_at":"2018-08-17T09:37:33Z","git_url":"git://github.com/ktr0731/evans.git","ssh_url":"git@github.com:ktr0731/evans.git","clone_url":"https://github.com/ktr0731/evans.git","svn_url":"https://github.com/ktr0731/evans","homepage":"https://evans.syfm.me","size":54117,"stargazers_count":356,"watchers_count":356,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":6,"watchers":356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ktr0731/evans/pulls/82"},"html":{"href":"https://github.com/ktr0731/evans/pull/82"},"issue":{"href":"https://api.github.com/repos/ktr0731/evans/issues/82"},"comments":{"href":"https://api.github.com/repos/ktr0731/evans/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/ktr0731/evans/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/ktr0731/evans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ktr0731/evans/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/ktr0731/evans/statuses/e6409a258cd31751959a2a3f6a205b7f1781c07f"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ktr0731","id":12953836,"node_id":"MDQ6VXNlcjEyOTUzODM2","avatar_url":"https://avatars1.githubusercontent.com/u/12953836?v=4","gravatar_id":"","url":"https://api.github.com/users/ktr0731","html_url":"https://github.com/ktr0731","followers_url":"https://api.github.com/users/ktr0731/followers","following_url":"https://api.github.com/users/ktr0731/following{/other_user}","gists_url":"https://api.github.com/users/ktr0731/gists{/gist_id}","starred_url":"https://api.github.com/users/ktr0731/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktr0731/subscriptions","organizations_url":"https://api.github.com/users/ktr0731/orgs","repos_url":"https://api.github.com/users/ktr0731/repos","events_url":"https://api.github.com/users/ktr0731/events{/privacy}","received_events_url":"https://api.github.com/users/ktr0731/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":27,"changed_files":5}}
{"actor":{"display_login":"ktr0731"}}