{"action":"created","comment":{"url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/comments/166335623","pull_request_review_id":94381267,"id":166335623,"diff_hunk":"@@ -416,27 +430,39 @@ treeListCore.registerModule(\"selection\", extend(true, {}, selectionModule, {\n                     return result;\n                 },\n \n+                /**\n+                * @name dxTreeListMethods_getSelectedRowKeys\n+                * @publicName getSelectedRowKeys(leavesOnly)\n+                * @param1 leavesOnly:boolean\n+                * @return Array<any>\n+                * @deprecated\n+                */\n+\n                 /**\n                 * @name dxTreeListMethods_getSelectedRowKeys\n                 * @publicName getSelectedRowKeys(mode)\n-                * @param1 mode:string|boolean\n+                * @param1 mode:string\n                 * @return Array<any>\n                 */\n                 getSelectedRowKeys: function(mode) {\n                     var that = this,\n                         dataController = that._dataController,\n                         selectedRowKeys = that.callBase.apply(that, arguments) || [];\n \n-                    if(this.isRecursiveSelection() && dataController) {\n-                        if(that._isModeLeavesOnly(mode)) {\n-                            selectedRowKeys = dataController.getNodeLeafKeys(selectedRowKeys, function(childNode, nodes) {\n-                                return !childNode.hasChildren && that.isRowSelected(childNode.key);\n-                            });\n+                    mode = mode || \"excludeRecursive\";\n+\n+                    if(dataController) {\n+                        if(mode === true) {\n+                            errors.log(\"W0002\", \"dxTreeList\", \"getSelectedRowKeys(leavesOnly)\", \"18.1\", \"Use the 'getSelectedRowKeys(mode)' method with a string parameter instead\");\n                         }\n \n-                        if(mode === \"all\") {\n+                        if(this.isRecursiveSelection() && mode !== \"excludeRecursive\") {","path":"js/ui/tree_list/ui.tree_list.selection.js","position":74,"original_position":74,"commit_id":"5d92567833c0d50efcc4b6bb0212f265949098e8","original_commit_id":"5d92567833c0d50efcc4b6bb0212f265949098e8","user":{"login":"sometimesElen","id":22657165,"avatar_url":"https://avatars2.githubusercontent.com/u/22657165?v=4","gravatar_id":"","url":"https://api.github.com/users/sometimesElen","html_url":"https://github.com/sometimesElen","followers_url":"https://api.github.com/users/sometimesElen/followers","following_url":"https://api.github.com/users/sometimesElen/following{/other_user}","gists_url":"https://api.github.com/users/sometimesElen/gists{/gist_id}","starred_url":"https://api.github.com/users/sometimesElen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sometimesElen/subscriptions","organizations_url":"https://api.github.com/users/sometimesElen/orgs","repos_url":"https://api.github.com/users/sometimesElen/repos","events_url":"https://api.github.com/users/sometimesElen/events{/privacy}","received_events_url":"https://api.github.com/users/sometimesElen/received_events","type":"User","site_admin":false},"body":"After refix this string can look like this or ```mode === \"includeRecursive\" || mode === \"leavesOnly\"```","created_at":"2018-02-06T15:19:07Z","updated_at":"2018-02-06T15:19:07Z","html_url":"https://github.com/DevExpress/DevExtreme/pull/2839#discussion_r166335623","pull_request_url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/2839","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/comments/166335623"},"html":{"href":"https://github.com/DevExpress/DevExtreme/pull/2839#discussion_r166335623"},"pull_request":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/2839"}},"in_reply_to_id":166321157},"pull_request":{"url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/2839","id":166817021,"html_url":"https://github.com/DevExpress/DevExtreme/pull/2839","diff_url":"https://github.com/DevExpress/DevExtreme/pull/2839.diff","patch_url":"https://github.com/DevExpress/DevExtreme/pull/2839.patch","issue_url":"https://api.github.com/repos/DevExpress/DevExtreme/issues/2839","number":2839,"state":"open","locked":false,"title":" Fix TreeList getSelectedRowKeys behaviour in leavesOnly case","user":{"login":"sometimesElen","id":22657165,"avatar_url":"https://avatars2.githubusercontent.com/u/22657165?v=4","gravatar_id":"","url":"https://api.github.com/users/sometimesElen","html_url":"https://github.com/sometimesElen","followers_url":"https://api.github.com/users/sometimesElen/followers","following_url":"https://api.github.com/users/sometimesElen/following{/other_user}","gists_url":"https://api.github.com/users/sometimesElen/gists{/gist_id}","starred_url":"https://api.github.com/users/sometimesElen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sometimesElen/subscriptions","organizations_url":"https://api.github.com/users/sometimesElen/orgs","repos_url":"https://api.github.com/users/sometimesElen/repos","events_url":"https://api.github.com/users/sometimesElen/events{/privacy}","received_events_url":"https://api.github.com/users/sometimesElen/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-02T14:35:19Z","updated_at":"2018-02-06T15:19:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f73bcff537dbcadd09f9f9deeb179e54a9da9458","assignee":{"login":"sometimesElen","id":22657165,"avatar_url":"https://avatars2.githubusercontent.com/u/22657165?v=4","gravatar_id":"","url":"https://api.github.com/users/sometimesElen","html_url":"https://github.com/sometimesElen","followers_url":"https://api.github.com/users/sometimesElen/followers","following_url":"https://api.github.com/users/sometimesElen/following{/other_user}","gists_url":"https://api.github.com/users/sometimesElen/gists{/gist_id}","starred_url":"https://api.github.com/users/sometimesElen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sometimesElen/subscriptions","organizations_url":"https://api.github.com/users/sometimesElen/orgs","repos_url":"https://api.github.com/users/sometimesElen/repos","events_url":"https://api.github.com/users/sometimesElen/events{/privacy}","received_events_url":"https://api.github.com/users/sometimesElen/received_events","type":"User","site_admin":false},"assignees":[{"login":"sometimesElen","id":22657165,"avatar_url":"https://avatars2.githubusercontent.com/u/22657165?v=4","gravatar_id":"","url":"https://api.github.com/users/sometimesElen","html_url":"https://github.com/sometimesElen","followers_url":"https://api.github.com/users/sometimesElen/followers","following_url":"https://api.github.com/users/sometimesElen/following{/other_user}","gists_url":"https://api.github.com/users/sometimesElen/gists{/gist_id}","starred_url":"https://api.github.com/users/sometimesElen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sometimesElen/subscriptions","organizations_url":"https://api.github.com/users/sometimesElen/orgs","repos_url":"https://api.github.com/users/sometimesElen/repos","events_url":"https://api.github.com/users/sometimesElen/events{/privacy}","received_events_url":"https://api.github.com/users/sometimesElen/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/2839/commits","review_comments_url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/2839/comments","review_comment_url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DevExpress/DevExtreme/issues/2839/comments","statuses_url":"https://api.github.com/repos/DevExpress/DevExtreme/statuses/5d92567833c0d50efcc4b6bb0212f265949098e8","head":{"label":"sometimesElen:getSelectedRowKeys_rework","ref":"getSelectedRowKeys_rework","sha":"5d92567833c0d50efcc4b6bb0212f265949098e8","user":{"login":"sometimesElen","id":22657165,"avatar_url":"https://avatars2.githubusercontent.com/u/22657165?v=4","gravatar_id":"","url":"https://api.github.com/users/sometimesElen","html_url":"https://github.com/sometimesElen","followers_url":"https://api.github.com/users/sometimesElen/followers","following_url":"https://api.github.com/users/sometimesElen/following{/other_user}","gists_url":"https://api.github.com/users/sometimesElen/gists{/gist_id}","starred_url":"https://api.github.com/users/sometimesElen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sometimesElen/subscriptions","organizations_url":"https://api.github.com/users/sometimesElen/orgs","repos_url":"https://api.github.com/users/sometimesElen/repos","events_url":"https://api.github.com/users/sometimesElen/events{/privacy}","received_events_url":"https://api.github.com/users/sometimesElen/received_events","type":"User","site_admin":false},"repo":{"id":89578502,"name":"DevExtreme","full_name":"sometimesElen/DevExtreme","owner":{"login":"sometimesElen","id":22657165,"avatar_url":"https://avatars2.githubusercontent.com/u/22657165?v=4","gravatar_id":"","url":"https://api.github.com/users/sometimesElen","html_url":"https://github.com/sometimesElen","followers_url":"https://api.github.com/users/sometimesElen/followers","following_url":"https://api.github.com/users/sometimesElen/following{/other_user}","gists_url":"https://api.github.com/users/sometimesElen/gists{/gist_id}","starred_url":"https://api.github.com/users/sometimesElen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sometimesElen/subscriptions","organizations_url":"https://api.github.com/users/sometimesElen/orgs","repos_url":"https://api.github.com/users/sometimesElen/repos","events_url":"https://api.github.com/users/sometimesElen/events{/privacy}","received_events_url":"https://api.github.com/users/sometimesElen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sometimesElen/DevExtreme","description":"HTML5 JavaScript Component Suite for Responsive Web Development","fork":true,"url":"https://api.github.com/repos/sometimesElen/DevExtreme","forks_url":"https://api.github.com/repos/sometimesElen/DevExtreme/forks","keys_url":"https://api.github.com/repos/sometimesElen/DevExtreme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sometimesElen/DevExtreme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sometimesElen/DevExtreme/teams","hooks_url":"https://api.github.com/repos/sometimesElen/DevExtreme/hooks","issue_events_url":"https://api.github.com/repos/sometimesElen/DevExtreme/issues/events{/number}","events_url":"https://api.github.com/repos/sometimesElen/DevExtreme/events","assignees_url":"https://api.github.com/repos/sometimesElen/DevExtreme/assignees{/user}","branches_url":"https://api.github.com/repos/sometimesElen/DevExtreme/branches{/branch}","tags_url":"https://api.github.com/repos/sometimesElen/DevExtreme/tags","blobs_url":"https://api.github.com/repos/sometimesElen/DevExtreme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sometimesElen/DevExtreme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sometimesElen/DevExtreme/git/refs{/sha}","trees_url":"https://api.github.com/repos/sometimesElen/DevExtreme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sometimesElen/DevExtreme/statuses/{sha}","languages_url":"https://api.github.com/repos/sometimesElen/DevExtreme/languages","stargazers_url":"https://api.github.com/repos/sometimesElen/DevExtreme/stargazers","contributors_url":"https://api.github.com/repos/sometimesElen/DevExtreme/contributors","subscribers_url":"https://api.github.com/repos/sometimesElen/DevExtreme/subscribers","subscription_url":"https://api.github.com/repos/sometimesElen/DevExtreme/subscription","commits_url":"https://api.github.com/repos/sometimesElen/DevExtreme/commits{/sha}","git_commits_url":"https://api.github.com/repos/sometimesElen/DevExtreme/git/commits{/sha}","comments_url":"https://api.github.com/repos/sometimesElen/DevExtreme/comments{/number}","issue_comment_url":"https://api.github.com/repos/sometimesElen/DevExtreme/issues/comments{/number}","contents_url":"https://api.github.com/repos/sometimesElen/DevExtreme/contents/{+path}","compare_url":"https://api.github.com/repos/sometimesElen/DevExtreme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sometimesElen/DevExtreme/merges","archive_url":"https://api.github.com/repos/sometimesElen/DevExtreme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sometimesElen/DevExtreme/downloads","issues_url":"https://api.github.com/repos/sometimesElen/DevExtreme/issues{/number}","pulls_url":"https://api.github.com/repos/sometimesElen/DevExtreme/pulls{/number}","milestones_url":"https://api.github.com/repos/sometimesElen/DevExtreme/milestones{/number}","notifications_url":"https://api.github.com/repos/sometimesElen/DevExtreme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sometimesElen/DevExtreme/labels{/name}","releases_url":"https://api.github.com/repos/sometimesElen/DevExtreme/releases{/id}","deployments_url":"https://api.github.com/repos/sometimesElen/DevExtreme/deployments","created_at":"2017-04-27T09:08:30Z","updated_at":"2017-04-27T09:08:37Z","pushed_at":"2018-02-06T14:03:55Z","git_url":"git://github.com/sometimesElen/DevExtreme.git","ssh_url":"git@github.com:sometimesElen/DevExtreme.git","clone_url":"https://github.com/sometimesElen/DevExtreme.git","svn_url":"https://github.com/sometimesElen/DevExtreme","homepage":"https://js.devexpress.com/","size":17592,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"17_1"}},"base":{"label":"DevExpress:18_1","ref":"18_1","sha":"9d7fce9ad98d5b49a84a533c096c4f3e9eb1b66b","user":{"login":"DevExpress","id":4243232,"avatar_url":"https://avatars0.githubusercontent.com/u/4243232?v=4","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"repo":{"id":88523356,"name":"DevExtreme","full_name":"DevExpress/DevExtreme","owner":{"login":"DevExpress","id":4243232,"avatar_url":"https://avatars0.githubusercontent.com/u/4243232?v=4","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DevExpress/DevExtreme","description":"HTML5 JavaScript Component Suite for Responsive Web Development","fork":false,"url":"https://api.github.com/repos/DevExpress/DevExtreme","forks_url":"https://api.github.com/repos/DevExpress/DevExtreme/forks","keys_url":"https://api.github.com/repos/DevExpress/DevExtreme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevExpress/DevExtreme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevExpress/DevExtreme/teams","hooks_url":"https://api.github.com/repos/DevExpress/DevExtreme/hooks","issue_events_url":"https://api.github.com/repos/DevExpress/DevExtreme/issues/events{/number}","events_url":"https://api.github.com/repos/DevExpress/DevExtreme/events","assignees_url":"https://api.github.com/repos/DevExpress/DevExtreme/assignees{/user}","branches_url":"https://api.github.com/repos/DevExpress/DevExtreme/branches{/branch}","tags_url":"https://api.github.com/repos/DevExpress/DevExtreme/tags","blobs_url":"https://api.github.com/repos/DevExpress/DevExtreme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevExpress/DevExtreme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevExpress/DevExtreme/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevExpress/DevExtreme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevExpress/DevExtreme/statuses/{sha}","languages_url":"https://api.github.com/repos/DevExpress/DevExtreme/languages","stargazers_url":"https://api.github.com/repos/DevExpress/DevExtreme/stargazers","contributors_url":"https://api.github.com/repos/DevExpress/DevExtreme/contributors","subscribers_url":"https://api.github.com/repos/DevExpress/DevExtreme/subscribers","subscription_url":"https://api.github.com/repos/DevExpress/DevExtreme/subscription","commits_url":"https://api.github.com/repos/DevExpress/DevExtreme/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevExpress/DevExtreme/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevExpress/DevExtreme/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevExpress/DevExtreme/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevExpress/DevExtreme/contents/{+path}","compare_url":"https://api.github.com/repos/DevExpress/DevExtreme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevExpress/DevExtreme/merges","archive_url":"https://api.github.com/repos/DevExpress/DevExtreme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevExpress/DevExtreme/downloads","issues_url":"https://api.github.com/repos/DevExpress/DevExtreme/issues{/number}","pulls_url":"https://api.github.com/repos/DevExpress/DevExtreme/pulls{/number}","milestones_url":"https://api.github.com/repos/DevExpress/DevExtreme/milestones{/number}","notifications_url":"https://api.github.com/repos/DevExpress/DevExtreme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevExpress/DevExtreme/labels{/name}","releases_url":"https://api.github.com/repos/DevExpress/DevExtreme/releases{/id}","deployments_url":"https://api.github.com/repos/DevExpress/DevExtreme/deployments","created_at":"2017-04-17T15:43:34Z","updated_at":"2018-02-06T15:03:34Z","pushed_at":"2018-02-06T14:54:27Z","git_url":"git://github.com/DevExpress/DevExtreme.git","ssh_url":"git@github.com:DevExpress/DevExtreme.git","clone_url":"https://github.com/DevExpress/DevExtreme.git","svn_url":"https://github.com/DevExpress/DevExtreme","homepage":"https://js.devexpress.com/","size":17694,"stargazers_count":778,"watchers_count":778,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":141,"open_issues":12,"watchers":778,"default_branch":"18_1"}},"_links":{"self":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/2839"},"html":{"href":"https://github.com/DevExpress/DevExtreme/pull/2839"},"issue":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/issues/2839"},"comments":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/issues/2839/comments"},"review_comments":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/2839/comments"},"review_comment":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/pulls/2839/commits"},"statuses":{"href":"https://api.github.com/repos/DevExpress/DevExtreme/statuses/5d92567833c0d50efcc4b6bb0212f265949098e8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sometimesElen"}}