{"action":"opened","issue":{"url":"https://api.github.com/repos/jxnblk/rebass/issues/463","repository_url":"https://api.github.com/repos/jxnblk/rebass","labels_url":"https://api.github.com/repos/jxnblk/rebass/issues/463/labels{/name}","comments_url":"https://api.github.com/repos/jxnblk/rebass/issues/463/comments","events_url":"https://api.github.com/repos/jxnblk/rebass/issues/463/events","html_url":"https://github.com/jxnblk/rebass/issues/463","id":352864867,"node_id":"MDU6SXNzdWUzNTI4NjQ4Njc=","number":463,"title":"Setting padding does not override default horizontal and vertical padding. ","user":{"login":"jckw","id":11884004,"node_id":"MDQ6VXNlcjExODg0MDA0","avatar_url":"https://avatars1.githubusercontent.com/u/11884004?v=4","gravatar_id":"","url":"https://api.github.com/users/jckw","html_url":"https://github.com/jckw","followers_url":"https://api.github.com/users/jckw/followers","following_url":"https://api.github.com/users/jckw/following{/other_user}","gists_url":"https://api.github.com/users/jckw/gists{/gist_id}","starred_url":"https://api.github.com/users/jckw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jckw/subscriptions","organizations_url":"https://api.github.com/users/jckw/orgs","repos_url":"https://api.github.com/users/jckw/repos","events_url":"https://api.github.com/users/jckw/events{/privacy}","received_events_url":"https://api.github.com/users/jckw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-22T09:06:33Z","updated_at":"2018-08-22T09:06:33Z","closed_at":null,"author_association":"NONE","body":"Take a `Button` with padding 5 (which maps to a value of `32px`):\r\n\r\n```\r\n<Button p={5}>Click here</Button>\r\n```\r\n\r\nThe resulting CSS includes the custom padding **before** the defaults.\r\n\r\n![image](https://user-images.githubusercontent.com/11884004/44453771-dab81a80-a5f1-11e8-8cb3-2cd2527a0eb2.png)\r\n\r\nThis is because `Button` has `px={3}` and `py={2}` set as a default, which are not overridden. \r\n\r\nCreating a button like this solves the problem:\r\n\r\n```\r\n<Button px={5} py={5}>Click here</Button>\r\n```\r\n\r\nThe ideal functionality is to remove `px` and `py` if they're not specified when `p` is, but alternatively a quick fix would be to define the default values *before* the specified values when the CSS is generated.\r\n"}}
{"actor":{"display_login":"jckw"}}