{"action":"created","issue":{"url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/539","repository_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui","labels_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/539/labels{/name}","comments_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/539/comments","events_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/539/events","html_url":"https://github.com/jsdrupal/drupal-admin-ui/issues/539","id":379563086,"node_id":"MDU6SXNzdWUzNzk1NjMwODY=","number":539,"title":"Linting: Check ts and tsx files. ","user":{"login":"martinfrances107","id":1259969,"node_id":"MDQ6VXNlcjEyNTk5Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1259969?v=4","gravatar_id":"","url":"https://api.github.com/users/martinfrances107","html_url":"https://github.com/martinfrances107","followers_url":"https://api.github.com/users/martinfrances107/followers","following_url":"https://api.github.com/users/martinfrances107/following{/other_user}","gists_url":"https://api.github.com/users/martinfrances107/gists{/gist_id}","starred_url":"https://api.github.com/users/martinfrances107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinfrances107/subscriptions","organizations_url":"https://api.github.com/users/martinfrances107/orgs","repos_url":"https://api.github.com/users/martinfrances107/repos","events_url":"https://api.github.com/users/martinfrances107/events{/privacy}","received_events_url":"https://api.github.com/users/martinfrances107/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-11T21:03:54Z","updated_at":"2018-11-12T16:16:32Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"We are dipping our toes  into typescript ... which makes me happy.\r\n\r\nI just want to iron out a little kink.\r\n\r\nyarn run test:lint \r\n\r\nafter inspecting \r\n\r\n reports/eslint-junit.xml\r\n\r\nIt is clear that only js files are inspected, even if  ts files are present\r\n\r\nI am going to cut and paste the relevant config from the typescript branch and make a PR.\r\n"},"comment":{"url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/comments/437939721","html_url":"https://github.com/jsdrupal/drupal-admin-ui/issues/539#issuecomment-437939721","issue_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/539","id":437939721,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzkzOTcyMQ==","user":{"login":"martinfrances107","id":1259969,"node_id":"MDQ6VXNlcjEyNTk5Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1259969?v=4","gravatar_id":"","url":"https://api.github.com/users/martinfrances107","html_url":"https://github.com/martinfrances107","followers_url":"https://api.github.com/users/martinfrances107/followers","following_url":"https://api.github.com/users/martinfrances107/following{/other_user}","gists_url":"https://api.github.com/users/martinfrances107/gists{/gist_id}","starred_url":"https://api.github.com/users/martinfrances107/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinfrances107/subscriptions","organizations_url":"https://api.github.com/users/martinfrances107/orgs","repos_url":"https://api.github.com/users/martinfrances107/repos","events_url":"https://api.github.com/users/martinfrances107/events{/privacy}","received_events_url":"https://api.github.com/users/martinfrances107/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T16:16:32Z","updated_at":"2018-11-12T16:16:32Z","author_association":"CONTRIBUTOR","body":"I am trying to move the project in a positive direction, but what I am doing maybe controversial -- so I best highlight it ( see B) \r\n\r\nA) I have moved tsconfig.json and tslint.json up into the top level directory ... so it acts on every project just like .eslintrc.json did.\r\n\r\nB) This is the controversial bit, because I extend \"js:recommeded\" see tslint.json\r\nwe pick up a few rules which spew out lots of failures. In the first version I am turing off the following rules from that standard\r\n\r\n      \"trailing-comma\": false,\r\n+      \"semicolon\": false,\r\n+      \"quotemark\": false,\r\n+      \"object-literal-sort-keys\": false,\r\n+      \"no-shadowed-variable\": false,\r\n+      \"max-line-length\": false,\r\n+      \"no-empty\": false,\r\n\r\nMy line is that with a autofixer ... it is trivial to fix these issues in our design. ( shadowed-variable ) will take some manual care to fix.  \r\n\r\nIf we are in agreement I will file new issue and let the autofix blow away our troubles. ( please think autumn and leaf blowers I am not a wannabe gangster. ) \r\n\r\n "}}
{"actor":{"display_login":"martinfrances107"}}