{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/25063","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25063/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25063/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25063/events","html_url":"https://github.com/cms-sw/cmssw/pull/25063","id":375731531,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MTEwMzAy","number":25063,"title":"1st Version of MTD Hit-Finder and Track Refitter","user":{"login":"lgray","id":1068089,"node_id":"MDQ6VXNlcjEwNjgwODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1068089?v=4","gravatar_id":"","url":"https://api.github.com/users/lgray","html_url":"https://github.com/lgray","followers_url":"https://api.github.com/users/lgray/followers","following_url":"https://api.github.com/users/lgray/following{/other_user}","gists_url":"https://api.github.com/users/lgray/gists{/gist_id}","starred_url":"https://api.github.com/users/lgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgray/subscriptions","organizations_url":"https://api.github.com/users/lgray/orgs","repos_url":"https://api.github.com/users/lgray/repos","events_url":"https://api.github.com/users/lgray/events{/privacy}","received_events_url":"https://api.github.com/users/lgray/received_events","type":"User","site_admin":false},"labels":[{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88653795,"node_id":"MDU6TGFiZWw4ODY1Mzc5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52820549,"node_id":"MDU6TGFiZWw1MjgyMDU0OQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04","default":false},{"id":52881721,"node_id":"MDU6TGFiZWw1Mjg4MTcyMQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/geometry-pending","name":"geometry-pending","color":"fbca04","default":false},{"id":52822551,"node_id":"MDU6TGFiZWw1MjgyMjU1MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/hlt-pending","name":"hlt-pending","color":"fbca04","default":false},{"id":69634213,"node_id":"MDU6TGFiZWw2OTYzNDIxMw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/new-package-pending","name":"new-package-pending","color":"e11d21","default":false},{"id":52881747,"node_id":"MDU6TGFiZWw1Mjg4MTc0Nw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/operations-pending","name":"operations-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820010,"node_id":"MDU6TGFiZWw1MjgyMDAxMA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":52820523,"node_id":"MDU6TGFiZWw1MjgyMDUyMw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":170521617,"node_id":"MDU6TGFiZWwxNzA1MjE2MTc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"ff8000","default":false},{"id":530655448,"node_id":"MDU6TGFiZWw1MzA2NTU0NDg=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/upgrade-pending","name":"upgrade-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/79","html_url":"https://github.com/cms-sw/cmssw/milestone/79","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/79/labels","id":3914873,"node_id":"MDk6TWlsZXN0b25lMzkxNDg3Mw==","number":79,"title":"CMSSW_10_5_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":61,"closed_issues":6,"state":"open","created_at":"2018-12-20T07:56:25Z","updated_at":"2018-12-20T19:29:28Z","due_on":null,"closed_at":null},"comments":195,"created_at":"2018-10-30T23:07:53Z","updated_at":"2018-12-20T21:21:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/25063","html_url":"https://github.com/cms-sw/cmssw/pull/25063","diff_url":"https://github.com/cms-sw/cmssw/pull/25063.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/25063.patch"},"body":"This pull requests integrates a first functioning version of the MTD \"TrackExtender\".\r\nIt extrapolates tracks to the MTD surface, finds all dets compatible with the track extrapolation, searches for the hit with the best estimated chi2, and if found adds it to the track.\r\n\r\nThe amount of updating that is done to the track is presently configurable.\r\nIt is possible to update separately the hit pattern, TrackExtra, and the track parameters.\r\nThis allows MTD to perform studies while not directly impacting the tracking performance, where we presently see a 3% degradation in resolution for 1GeV single muons when including the MTD hits in the track fit. Likely due to material mis-modeling.\r\n\r\nThere is a test configuration in RecoMTD/TrackExtender/test/ that will run the track extender and produce products for the D24 scenario. Otherwise the TrackExtender is not included in the RECO, and that integration will come in a separate PR.\r\n\r\nEfficiency vs. Eta at 0.7 GeV (1k events, single muon):\r\n<img width=\"699\" alt=\"0p7gevmuon_mtd\" src=\"https://user-images.githubusercontent.com/1068089/47789417-7943b480-dce2-11e8-9e5b-13811cbe0ef0.png\">\r\n\r\nEfficiency vs. Eta at 1 GeV (1k events single muon):\r\n<img width=\"699\" alt=\"1gevmuon_mtd\" src=\"https://user-images.githubusercontent.com/1068089/47789442-852f7680-dce2-11e8-9404-61716072e134.png\">\r\n\r\nEfficiency vs. Eta at 5 GeV (1k events single muon):\r\n<img width=\"698\" alt=\"5gevmuon_mtd\" src=\"https://user-images.githubusercontent.com/1068089/47789467-98424680-dce2-11e8-8b81-84aae5730810.png\">\r\n\r\nEffect of MTD hits in track refit for 1 GeV single muons (red is with MTD, blue without):\r\n<img width=\"700\" alt=\"screen shot 2018-10-26 at 7 59 39 am\" src=\"https://user-images.githubusercontent.com/1068089/47789503-b3ad5180-dce2-11e8-9d2e-454958ea6219.png\">\r\n\r\n@VinInn @mtosi \r\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/449139240","html_url":"https://github.com/cms-sw/cmssw/pull/25063#issuecomment-449139240","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25063","id":449139240,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTEzOTI0MA==","user":{"login":"slava77","id":4676718,"node_id":"MDQ6VXNlcjQ2NzY3MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4676718?v=4","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2018-12-20T21:21:29Z","updated_at":"2018-12-20T21:21:29Z","author_association":"CONTRIBUTOR","body":"On 12/20/18 1:12 PM, Chris Jones wrote:\n> @slava77\n> is there a traceback as part of the crash?\n> \n> —\n\nI couldn't get a repeatable crash yet.\nThey come out pointing to random places\nsometimes in a running module, sometimes in the event data\ncleanup/destructors after all modules are done.\n\nI've seen something remotely similar in a case of duplicate symbols\ndefined in different libraries.\nIs there an easy way to spot this (to reject this possibility)?\n\n"}}
{"actor":{"display_login":"slava77"}}