{"action":"created","comment":{"url":"https://api.github.com/repos/apache/drill/pulls/comments/223412915","pull_request_review_id":162533627,"id":223412915,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzQxMjkxNQ==","diff_hunk":"@@ -511,7 +511,7 @@\n                   This is likely due to you adding new dependencies to a java-exec and not updating the excludes in this module. This is important as it minimizes the size of the dependency of Drill application users.\n \n                   </message>\n-                  <maxsize>39000000</maxsize>\n+                  <maxsize>39100000</maxsize>","path":"exec/jdbc-all/pom.xml","position":5,"original_position":5,"commit_id":"72e82bf646c5e03d4722ae9a3663530a08949372","original_commit_id":"72e82bf646c5e03d4722ae9a3663530a08949372","user":{"login":"vvysotskyi","id":20928429,"node_id":"MDQ6VXNlcjIwOTI4NDI5","avatar_url":"https://avatars3.githubusercontent.com/u/20928429?v=4","gravatar_id":"","url":"https://api.github.com/users/vvysotskyi","html_url":"https://github.com/vvysotskyi","followers_url":"https://api.github.com/users/vvysotskyi/followers","following_url":"https://api.github.com/users/vvysotskyi/following{/other_user}","gists_url":"https://api.github.com/users/vvysotskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/vvysotskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvysotskyi/subscriptions","organizations_url":"https://api.github.com/users/vvysotskyi/orgs","repos_url":"https://api.github.com/users/vvysotskyi/repos","events_url":"https://api.github.com/users/vvysotskyi/events{/privacy}","received_events_url":"https://api.github.com/users/vvysotskyi/received_events","type":"User","site_admin":false},"body":"Please rebase onto the master and revert this change, since there was PR, were excluded some classes from the JAR.","created_at":"2018-10-08T15:47:40Z","updated_at":"2018-10-08T15:47:40Z","html_url":"https://github.com/apache/drill/pull/1481#discussion_r223412915","pull_request_url":"https://api.github.com/repos/apache/drill/pulls/1481","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/comments/223412915"},"html":{"href":"https://github.com/apache/drill/pull/1481#discussion_r223412915"},"pull_request":{"href":"https://api.github.com/repos/apache/drill/pulls/1481"}}},"pull_request":{"url":"https://api.github.com/repos/apache/drill/pulls/1481","id":218183212,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MTgzMjEy","html_url":"https://github.com/apache/drill/pull/1481","diff_url":"https://github.com/apache/drill/pull/1481.diff","patch_url":"https://github.com/apache/drill/pull/1481.patch","issue_url":"https://api.github.com/repos/apache/drill/issues/1481","number":1481,"state":"open","locked":false,"title":"DRILL-6763: Codegen optimization of SQL functions with constant values","user":{"login":"lushuifeng","id":1677203,"node_id":"MDQ6VXNlcjE2NzcyMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1677203?v=4","gravatar_id":"","url":"https://api.github.com/users/lushuifeng","html_url":"https://github.com/lushuifeng","followers_url":"https://api.github.com/users/lushuifeng/followers","following_url":"https://api.github.com/users/lushuifeng/following{/other_user}","gists_url":"https://api.github.com/users/lushuifeng/gists{/gist_id}","starred_url":"https://api.github.com/users/lushuifeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lushuifeng/subscriptions","organizations_url":"https://api.github.com/users/lushuifeng/orgs","repos_url":"https://api.github.com/users/lushuifeng/repos","events_url":"https://api.github.com/users/lushuifeng/events{/privacy}","received_events_url":"https://api.github.com/users/lushuifeng/received_events","type":"User","site_admin":false},"body":"Details in [DRILL-6763](https://issues.apache.org/jira/projects/DRILL/issues/DRILL-6763):\r\n\r\nHere is the descriptions of the change:\r\n<del>1. add system option `exec.optimize_function_compilation` to toggle to state of this functionality.</del>\r\n2. codegen is changed by declaring setter method in EvaluationVisitor#visitXXXconstants\r\n3. the member declared in step2 is initialized when the instance of the class is created in XXBatch and others\r\n4. attachment is the code of the same query mentioned in DRILL-6763 generated by setting the value of exec.optimize_function_compilation to true\r\n@arina-ielchiieva @vdiravka Would you please take a look?\r\nWhat kind of unit tests should be added?\r\n[query.txt](https://github.com/apache/drill/files/2418035/query.txt)\r\n\r\n\r\n","created_at":"2018-09-26T04:06:15Z","updated_at":"2018-10-08T15:47:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f8bb8b19932639e892ed32b88a7992bb698f00b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/drill/pulls/1481/commits","review_comments_url":"https://api.github.com/repos/apache/drill/pulls/1481/comments","review_comment_url":"https://api.github.com/repos/apache/drill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/drill/issues/1481/comments","statuses_url":"https://api.github.com/repos/apache/drill/statuses/72e82bf646c5e03d4722ae9a3663530a08949372","head":{"label":"lushuifeng:DRILL-6763","ref":"DRILL-6763","sha":"72e82bf646c5e03d4722ae9a3663530a08949372","user":{"login":"lushuifeng","id":1677203,"node_id":"MDQ6VXNlcjE2NzcyMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1677203?v=4","gravatar_id":"","url":"https://api.github.com/users/lushuifeng","html_url":"https://github.com/lushuifeng","followers_url":"https://api.github.com/users/lushuifeng/followers","following_url":"https://api.github.com/users/lushuifeng/following{/other_user}","gists_url":"https://api.github.com/users/lushuifeng/gists{/gist_id}","starred_url":"https://api.github.com/users/lushuifeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lushuifeng/subscriptions","organizations_url":"https://api.github.com/users/lushuifeng/orgs","repos_url":"https://api.github.com/users/lushuifeng/repos","events_url":"https://api.github.com/users/lushuifeng/events{/privacy}","received_events_url":"https://api.github.com/users/lushuifeng/received_events","type":"User","site_admin":false},"repo":{"id":150193496,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxOTM0OTY=","name":"drill","full_name":"lushuifeng/drill","private":false,"owner":{"login":"lushuifeng","id":1677203,"node_id":"MDQ6VXNlcjE2NzcyMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1677203?v=4","gravatar_id":"","url":"https://api.github.com/users/lushuifeng","html_url":"https://github.com/lushuifeng","followers_url":"https://api.github.com/users/lushuifeng/followers","following_url":"https://api.github.com/users/lushuifeng/following{/other_user}","gists_url":"https://api.github.com/users/lushuifeng/gists{/gist_id}","starred_url":"https://api.github.com/users/lushuifeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lushuifeng/subscriptions","organizations_url":"https://api.github.com/users/lushuifeng/orgs","repos_url":"https://api.github.com/users/lushuifeng/repos","events_url":"https://api.github.com/users/lushuifeng/events{/privacy}","received_events_url":"https://api.github.com/users/lushuifeng/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lushuifeng/drill","description":"Apache Drill","fork":true,"url":"https://api.github.com/repos/lushuifeng/drill","forks_url":"https://api.github.com/repos/lushuifeng/drill/forks","keys_url":"https://api.github.com/repos/lushuifeng/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lushuifeng/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lushuifeng/drill/teams","hooks_url":"https://api.github.com/repos/lushuifeng/drill/hooks","issue_events_url":"https://api.github.com/repos/lushuifeng/drill/issues/events{/number}","events_url":"https://api.github.com/repos/lushuifeng/drill/events","assignees_url":"https://api.github.com/repos/lushuifeng/drill/assignees{/user}","branches_url":"https://api.github.com/repos/lushuifeng/drill/branches{/branch}","tags_url":"https://api.github.com/repos/lushuifeng/drill/tags","blobs_url":"https://api.github.com/repos/lushuifeng/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lushuifeng/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lushuifeng/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/lushuifeng/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lushuifeng/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/lushuifeng/drill/languages","stargazers_url":"https://api.github.com/repos/lushuifeng/drill/stargazers","contributors_url":"https://api.github.com/repos/lushuifeng/drill/contributors","subscribers_url":"https://api.github.com/repos/lushuifeng/drill/subscribers","subscription_url":"https://api.github.com/repos/lushuifeng/drill/subscription","commits_url":"https://api.github.com/repos/lushuifeng/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/lushuifeng/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/lushuifeng/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/lushuifeng/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/lushuifeng/drill/contents/{+path}","compare_url":"https://api.github.com/repos/lushuifeng/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lushuifeng/drill/merges","archive_url":"https://api.github.com/repos/lushuifeng/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lushuifeng/drill/downloads","issues_url":"https://api.github.com/repos/lushuifeng/drill/issues{/number}","pulls_url":"https://api.github.com/repos/lushuifeng/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/lushuifeng/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/lushuifeng/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lushuifeng/drill/labels{/name}","releases_url":"https://api.github.com/repos/lushuifeng/drill/releases{/id}","deployments_url":"https://api.github.com/repos/lushuifeng/drill/deployments","created_at":"2018-09-25T02:00:24Z","updated_at":"2018-09-25T02:00:39Z","pushed_at":"2018-10-08T11:27:22Z","git_url":"git://github.com/lushuifeng/drill.git","ssh_url":"git@github.com:lushuifeng/drill.git","clone_url":"https://github.com/lushuifeng/drill.git","svn_url":"https://github.com/lushuifeng/drill","homepage":"","size":64918,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3bc3b66919536dc94015dc23ce43e7254623de5d","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":5683653,"node_id":"MDEwOlJlcG9zaXRvcnk1NjgzNjUz","name":"drill","full_name":"apache/drill","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/drill","description":"Apache Drill","fork":false,"url":"https://api.github.com/repos/apache/drill","forks_url":"https://api.github.com/repos/apache/drill/forks","keys_url":"https://api.github.com/repos/apache/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/drill/teams","hooks_url":"https://api.github.com/repos/apache/drill/hooks","issue_events_url":"https://api.github.com/repos/apache/drill/issues/events{/number}","events_url":"https://api.github.com/repos/apache/drill/events","assignees_url":"https://api.github.com/repos/apache/drill/assignees{/user}","branches_url":"https://api.github.com/repos/apache/drill/branches{/branch}","tags_url":"https://api.github.com/repos/apache/drill/tags","blobs_url":"https://api.github.com/repos/apache/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/drill/languages","stargazers_url":"https://api.github.com/repos/apache/drill/stargazers","contributors_url":"https://api.github.com/repos/apache/drill/contributors","subscribers_url":"https://api.github.com/repos/apache/drill/subscribers","subscription_url":"https://api.github.com/repos/apache/drill/subscription","commits_url":"https://api.github.com/repos/apache/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/drill/contents/{+path}","compare_url":"https://api.github.com/repos/apache/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/drill/merges","archive_url":"https://api.github.com/repos/apache/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/drill/downloads","issues_url":"https://api.github.com/repos/apache/drill/issues{/number}","pulls_url":"https://api.github.com/repos/apache/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/drill/labels{/name}","releases_url":"https://api.github.com/repos/apache/drill/releases{/id}","deployments_url":"https://api.github.com/repos/apache/drill/deployments","created_at":"2012-09-05T07:00:26Z","updated_at":"2018-10-08T13:19:06Z","pushed_at":"2018-10-08T15:15:31Z","git_url":"git://github.com/apache/drill.git","ssh_url":"git@github.com:apache/drill.git","clone_url":"https://github.com/apache/drill.git","svn_url":"https://github.com/apache/drill","homepage":"","size":64986,"stargazers_count":1042,"watchers_count":1042,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":696,"mirror_url":null,"archived":false,"open_issues_count":95,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":696,"open_issues":95,"watchers":1042,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/1481"},"html":{"href":"https://github.com/apache/drill/pull/1481"},"issue":{"href":"https://api.github.com/repos/apache/drill/issues/1481"},"comments":{"href":"https://api.github.com/repos/apache/drill/issues/1481/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/drill/pulls/1481/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/drill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/drill/pulls/1481/commits"},"statuses":{"href":"https://api.github.com/repos/apache/drill/statuses/72e82bf646c5e03d4722ae9a3663530a08949372"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vvysotskyi"}}