{"action":"created","issue":{"url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4633","repository_url":"https://api.github.com/repos/reactioncommerce/reaction","labels_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4633/labels{/name}","comments_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4633/comments","events_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4633/events","html_url":"https://github.com/reactioncommerce/reaction/issues/4633","id":360996707,"node_id":"MDU6SXNzdWUzNjA5OTY3MDc=","number":4633,"title":"Sidebar buttons no longer open side panel on product grid","user":{"login":"mikemurray","id":42217,"node_id":"MDQ6VXNlcjQyMjE3","avatar_url":"https://avatars3.githubusercontent.com/u/42217?v=4","gravatar_id":"","url":"https://api.github.com/users/mikemurray","html_url":"https://github.com/mikemurray","followers_url":"https://api.github.com/users/mikemurray/followers","following_url":"https://api.github.com/users/mikemurray/following{/other_user}","gists_url":"https://api.github.com/users/mikemurray/gists{/gist_id}","starred_url":"https://api.github.com/users/mikemurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikemurray/subscriptions","organizations_url":"https://api.github.com/users/mikemurray/orgs","repos_url":"https://api.github.com/users/mikemurray/repos","events_url":"https://api.github.com/users/mikemurray/events{/privacy}","received_events_url":"https://api.github.com/users/mikemurray/received_events","type":"User","site_admin":false},"labels":[{"id":377481506,"node_id":"MDU6TGFiZWwzNzc0ODE1MDY=","url":"https://api.github.com/repos/reactioncommerce/reaction/labels/bug","name":"bug","color":"ff3737","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/reactioncommerce/reaction/milestones/84","html_url":"https://github.com/reactioncommerce/reaction/milestone/84","labels_url":"https://api.github.com/repos/reactioncommerce/reaction/milestones/84/labels","id":3574914,"node_id":"MDk6TWlsZXN0b25lMzU3NDkxNA==","number":84,"title":"Massive","description":"Core team milestone\nSep 4 - 17, 2018","creator":{"login":"spencern","id":1203639,"node_id":"MDQ6VXNlcjEyMDM2Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1203639?v=4","gravatar_id":"","url":"https://api.github.com/users/spencern","html_url":"https://github.com/spencern","followers_url":"https://api.github.com/users/spencern/followers","following_url":"https://api.github.com/users/spencern/following{/other_user}","gists_url":"https://api.github.com/users/spencern/gists{/gist_id}","starred_url":"https://api.github.com/users/spencern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencern/subscriptions","organizations_url":"https://api.github.com/users/spencern/orgs","repos_url":"https://api.github.com/users/spencern/repos","events_url":"https://api.github.com/users/spencern/events{/privacy}","received_events_url":"https://api.github.com/users/spencern/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":21,"state":"open","created_at":"2018-08-15T23:28:10Z","updated_at":"2018-09-17T18:54:25Z","due_on":"2018-09-17T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-09-17T18:50:50Z","updated_at":"2018-09-17T21:58:45Z","closed_at":null,"author_association":"MEMBER","body":"## Issue Description\r\n\r\nClicking the sidebar buttons no longer opens the sidebar when on the grid page\r\n\r\n![reaction](https://user-images.githubusercontent.com/42217/45643134-2afa8f00-ba6f-11e8-9fe3-c89a4123d3d1.png)\r\n\r\n## Steps to Reproduce\r\n\r\n1. On the grid, click a sidebar button\r\n2. See it doesn't open\r\n3. Then click on a product\r\n4. Then click a sidebar button again, see the panel change\r\n\r\n## Possible Solution\r\n\r\nThe button in the sidebar probably isn't setting the right state to open the side panel, though it does change the contents.\r\n\r\n### Versions\r\n\r\nNode: 10.7.0\r\nNPM: 6.2.0\r\nMeteor Node: 8.11.4\r\nMeteor NPM: 6.4.1\r\nReaction CLI: 0.29.0\r\nReaction: 1.16.0\r\nReaction branch: release-2.0.0\r\nDocker: 18.06.0-ce\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/reactioncommerce/reaction/issues/comments/422185691","html_url":"https://github.com/reactioncommerce/reaction/issues/4633#issuecomment-422185691","issue_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4633","id":422185691,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjE4NTY5MQ==","user":{"login":"aldeed","id":3012067,"node_id":"MDQ6VXNlcjMwMTIwNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3012067?v=4","gravatar_id":"","url":"https://api.github.com/users/aldeed","html_url":"https://github.com/aldeed","followers_url":"https://api.github.com/users/aldeed/followers","following_url":"https://api.github.com/users/aldeed/following{/other_user}","gists_url":"https://api.github.com/users/aldeed/gists{/gist_id}","starred_url":"https://api.github.com/users/aldeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldeed/subscriptions","organizations_url":"https://api.github.com/users/aldeed/orgs","repos_url":"https://api.github.com/users/aldeed/repos","events_url":"https://api.github.com/users/aldeed/events{/privacy}","received_events_url":"https://api.github.com/users/aldeed/received_events","type":"User","site_admin":false},"created_at":"2018-09-17T21:58:45Z","updated_at":"2018-09-17T21:58:45Z","author_association":"MEMBER","body":"I bet it's because of this code I changed: https://github.com/reactioncommerce/reaction/blob/release-2.0.0/imports/plugins/included/product-variant/containers/productsContainerAdmin.js#L170-L180\r\n\r\nIt should hide the action view only if it's currently showing productSettings, or even just not hide it."}}
{"actor":{"display_login":"aldeed"}}