{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/204247132","pull_request_review_id":139293636,"id":204247132,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDI0NzEzMg==","diff_hunk":"@@ -54,6 +56,15 @@ func setupKvstore() {\n \t\t\t\tkvStoreOpts[k] = v\n \t\t\t}\n \t\t}\n+\n+\t\tk8sclient.Configure(\"\", \"/var/lib/cilium/cilium.kubeconfig\")","path":"cilium/cmd/kvstore.go","position":14,"original_position":14,"commit_id":"da2289c40ab9f1e3b6e1f1b3379def0d8d4fde10","original_commit_id":"09ad0eb3e2bf2d64027ec4037b46cb9d09aab0ec","user":{"login":"aanm","id":5714066,"node_id":"MDQ6VXNlcjU3MTQwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/5714066?v=4","gravatar_id":"","url":"https://api.github.com/users/aanm","html_url":"https://github.com/aanm","followers_url":"https://api.github.com/users/aanm/followers","following_url":"https://api.github.com/users/aanm/following{/other_user}","gists_url":"https://api.github.com/users/aanm/gists{/gist_id}","starred_url":"https://api.github.com/users/aanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanm/subscriptions","organizations_url":"https://api.github.com/users/aanm/orgs","repos_url":"https://api.github.com/users/aanm/repos","events_url":"https://api.github.com/users/aanm/events{/privacy}","received_events_url":"https://api.github.com/users/aanm/received_events","type":"User","site_admin":false},"body":"This is a leftover, it needs to be fixed as when using `cilium kvstore get` the cilium CLI command does not have the necessary configuration to contact kubernetes, to retrieve the certificates to contact etcd.","created_at":"2018-07-22T17:03:51Z","updated_at":"2018-07-22T17:03:52Z","html_url":"https://github.com/cilium/cilium/pull/4921#discussion_r204247132","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/4921","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/204247132"},"html":{"href":"https://github.com/cilium/cilium/pull/4921#discussion_r204247132"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4921"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/4921","id":202971139,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTcxMTM5","html_url":"https://github.com/cilium/cilium/pull/4921","diff_url":"https://github.com/cilium/cilium/pull/4921.diff","patch_url":"https://github.com/cilium/cilium/pull/4921.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/4921","number":4921,"state":"open","locked":false,"title":"Add etcd-operator seamless integration with TLS","user":{"login":"aanm","id":5714066,"node_id":"MDQ6VXNlcjU3MTQwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/5714066?v=4","gravatar_id":"","url":"https://api.github.com/users/aanm","html_url":"https://github.com/aanm","followers_url":"https://api.github.com/users/aanm/followers","following_url":"https://api.github.com/users/aanm/following{/other_user}","gists_url":"https://api.github.com/users/aanm/gists{/gist_id}","starred_url":"https://api.github.com/users/aanm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanm/subscriptions","organizations_url":"https://api.github.com/users/aanm/orgs","repos_url":"https://api.github.com/users/aanm/repos","events_url":"https://api.github.com/users/aanm/events{/privacy}","received_events_url":"https://api.github.com/users/aanm/received_events","type":"User","site_admin":false},"body":"Sorry for the refatoring but it was necessary as kvstore package needs the k8s client and it was creating a import cycle.\r\n\r\n**Summary of changes**:\r\n\r\nAdd seamless integration for etcd-operator running with TLS.\r\n\r\nA developer cilium.yaml is available in `examples/kubernetes/addons/etcd-operator/cilium-development.yaml` which contains the necessary options to run etcd-operator.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/4921)\n<!-- Reviewable:end -->\n","created_at":"2018-07-20T22:38:18Z","updated_at":"2018-07-22T17:03:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e2079d7aa2e8a3f56e4617b483107df18875a14","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"kvstore","id":2519783,"node_id":"MDQ6VGVhbTI1MTk3ODM=","slug":"kvstore","description":"Key/Value store integrations","privacy":"closed","url":"https://api.github.com/teams/2519783","members_url":"https://api.github.com/teams/2519783/members{/member}","repositories_url":"https://api.github.com/teams/2519783/repos","permission":"pull"},{"name":"kubernetes","id":2519785,"node_id":"MDQ6VGVhbTI1MTk3ODU=","slug":"kubernetes","description":"Kubernetes integration","privacy":"closed","url":"https://api.github.com/teams/2519785","members_url":"https://api.github.com/teams/2519785/members{/member}","repositories_url":"https://api.github.com/teams/2519785/repos","permission":"pull"},{"name":"proxy","id":2519788,"node_id":"MDQ6VGVhbTI1MTk3ODg=","slug":"proxy","description":"Proxy layer","privacy":"closed","url":"https://api.github.com/teams/2519788","members_url":"https://api.github.com/teams/2519788/members{/member}","repositories_url":"https://api.github.com/teams/2519788/repos","permission":"pull"},{"name":"docs","id":2519789,"node_id":"MDQ6VGVhbTI1MTk3ODk=","slug":"docs","description":"Documentation","privacy":"closed","url":"https://api.github.com/teams/2519789","members_url":"https://api.github.com/teams/2519789/members{/member}","repositories_url":"https://api.github.com/teams/2519789/repos","permission":"pull"},{"name":"vendor","id":2519791,"node_id":"MDQ6VGVhbTI1MTk3OTE=","slug":"vendor","description":"Vendor dependencies","privacy":"closed","url":"https://api.github.com/teams/2519791","members_url":"https://api.github.com/teams/2519791/members{/member}","repositories_url":"https://api.github.com/teams/2519791/repos","permission":"pull"},{"name":"agent","id":2519792,"node_id":"MDQ6VGVhbTI1MTk3OTI=","slug":"agent","description":"Cilium Agent","privacy":"closed","url":"https://api.github.com/teams/2519792","members_url":"https://api.github.com/teams/2519792/members{/member}","repositories_url":"https://api.github.com/teams/2519792/repos","permission":"pull"},{"name":"cli","id":2519794,"node_id":"MDQ6VGVhbTI1MTk3OTQ=","slug":"cli","description":"Command Line Interface tools","privacy":"closed","url":"https://api.github.com/teams/2519794","members_url":"https://api.github.com/teams/2519794/members{/member}","repositories_url":"https://api.github.com/teams/2519794/repos","permission":"pull"},{"name":"janitors","id":2519796,"node_id":"MDQ6VGVhbTI1MTk3OTY=","slug":"janitors","description":"Rotating team of janitors for unowned code","privacy":"closed","url":"https://api.github.com/teams/2519796","members_url":"https://api.github.com/teams/2519796/members{/member}","repositories_url":"https://api.github.com/teams/2519796/repos","permission":"pull"},{"name":"endpoint","id":2519798,"node_id":"MDQ6VGVhbTI1MTk3OTg=","slug":"endpoint","description":"Endpoint abstraction","privacy":"closed","url":"https://api.github.com/teams/2519798","members_url":"https://api.github.com/teams/2519798/members{/member}","repositories_url":"https://api.github.com/teams/2519798/repos","permission":"pull"},{"name":"health","id":2579952,"node_id":"MDQ6VGVhbTI1Nzk5NTI=","slug":"health","description":"Health API","privacy":"closed","url":"https://api.github.com/teams/2579952","members_url":"https://api.github.com/teams/2579952/members{/member}","repositories_url":"https://api.github.com/teams/2579952/repos","permission":"pull"}],"labels":[{"id":721366651,"node_id":"MDU6TGFiZWw3MjEzNjY2NTE=","url":"https://api.github.com/repos/cilium/cilium/labels/area/k8s","name":"area/k8s","color":"2c3aa0","default":false},{"id":403149902,"node_id":"MDU6TGFiZWw0MDMxNDk5MDI=","url":"https://api.github.com/repos/cilium/cilium/labels/pending-review","name":"pending-review","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/cilium/cilium/milestones/13","html_url":"https://github.com/cilium/cilium/milestone/13","labels_url":"https://api.github.com/repos/cilium/cilium/milestones/13/labels","id":3461101,"node_id":"MDk6TWlsZXN0b25lMzQ2MTEwMQ==","number":13,"title":"1.2-bugfix","description":"","creator":{"login":"tgraf","id":1417913,"node_id":"MDQ6VXNlcjE0MTc5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":59,"state":"open","created_at":"2018-06-28T23:38:41Z","updated_at":"2018-07-22T16:06:20Z","due_on":"2018-07-20T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/4921/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/4921/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/4921/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/da2289c40ab9f1e3b6e1f1b3379def0d8d4fde10","head":{"label":"cilium:pr/add-etcd-operator-seamless-integration","ref":"pr/add-etcd-operator-seamless-integration","sha":"da2289c40ab9f1e3b6e1f1b3379def0d8d4fde10","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-07-22T16:19:03Z","pushed_at":"2018-07-22T16:08:57Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":55224,"stargazers_count":2565,"watchers_count":2565,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":229,"mirror_url":null,"archived":false,"open_issues_count":501,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":229,"open_issues":501,"watchers":2565,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"a39563e1c83419971782153c8f58541be7e3214f","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-07-22T16:19:03Z","pushed_at":"2018-07-22T16:08:57Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":55224,"stargazers_count":2565,"watchers_count":2565,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":229,"mirror_url":null,"archived":false,"open_issues_count":501,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":229,"open_issues":501,"watchers":2565,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4921"},"html":{"href":"https://github.com/cilium/cilium/pull/4921"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/4921"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/4921/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4921/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4921/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/da2289c40ab9f1e3b6e1f1b3379def0d8d4fde10"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aanm"}}