{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/172317465","pull_request_review_id":101314302,"id":172317465,"diff_hunk":"@@ -158,26 +158,23 @@ func (d *Dispatcher) isVSAN(ds *object.Datastore) bool {\n func (d *Dispatcher) deleteFilesIteratively(m *object.DatastoreFileManager, ds *object.Datastore, dsPath string) error {\n \tdefer trace.End(trace.Begin(dsPath, d.op))\n ","path":"lib/install/management/store_files.go","position":3,"original_position":3,"commit_id":"a5ff572061445d2a1c7d07c342116c3b7afeae49","original_commit_id":"a5ff572061445d2a1c7d07c342116c3b7afeae49","user":{"login":"hickeng","id":3923729,"avatar_url":"https://avatars1.githubusercontent.com/u/3923729?v=4","gravatar_id":"","url":"https://api.github.com/users/hickeng","html_url":"https://github.com/hickeng","followers_url":"https://api.github.com/users/hickeng/followers","following_url":"https://api.github.com/users/hickeng/following{/other_user}","gists_url":"https://api.github.com/users/hickeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hickeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hickeng/subscriptions","organizations_url":"https://api.github.com/users/hickeng/orgs","repos_url":"https://api.github.com/users/hickeng/repos","events_url":"https://api.github.com/users/hickeng/events{/privacy}","received_events_url":"https://api.github.com/users/hickeng/received_events","type":"User","site_admin":false},"body":"sorry for the whiplash Angie - given this isn't a direct revert if addressing anchal's comments, could we add a recursive delete _attempt_ as the first thing, then fail over into the current path.\r\nSo adding the following at the top:\r\n```go\r\n// don't check errors given detail process of any remaining files will occur after\r\nd.deleteVMFSFiles(m, ds, dsPath)\r\n```","created_at":"2018-03-05T20:25:14Z","updated_at":"2018-03-05T20:25:44Z","html_url":"https://github.com/vmware/vic/pull/7441#discussion_r172317465","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/7441","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/172317465"},"html":{"href":"https://github.com/vmware/vic/pull/7441#discussion_r172317465"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/7441"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/7441","id":172623552,"html_url":"https://github.com/vmware/vic/pull/7441","diff_url":"https://github.com/vmware/vic/pull/7441.diff","patch_url":"https://github.com/vmware/vic/pull/7441.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/7441","number":7441,"state":"open","locked":false,"title":"Delete datastore files recursively for all datastore types","user":{"login":"AngieCris","id":6562128,"avatar_url":"https://avatars1.githubusercontent.com/u/6562128?v=4","gravatar_id":"","url":"https://api.github.com/users/AngieCris","html_url":"https://github.com/AngieCris","followers_url":"https://api.github.com/users/AngieCris/followers","following_url":"https://api.github.com/users/AngieCris/following{/other_user}","gists_url":"https://api.github.com/users/AngieCris/gists{/gist_id}","starred_url":"https://api.github.com/users/AngieCris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngieCris/subscriptions","organizations_url":"https://api.github.com/users/AngieCris/orgs","repos_url":"https://api.github.com/users/AngieCris/repos","events_url":"https://api.github.com/users/AngieCris/events{/privacy}","received_events_url":"https://api.github.com/users/AngieCris/received_events","type":"User","site_admin":false},"body":"`[specific ci=6-03-Delete --suite 1-02-Docker-Pull]`\r\n\r\nFixes #7359 \r\n\r\nRevert of commit https://github.com/vmware/vic/commit/1fd1e7fa361da3623a6e629759687315d0f323fe PR #6951 \r\n\r\nFor non-vSAN type datastores, sometimes it complains when we try to delete non-empty datastore folders with child image files, causing trailing VCH datastore folders after vic-machine delete finishes.","created_at":"2018-03-02T22:47:28Z","updated_at":"2018-03-05T20:25:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"368d3bfd84374b5222079c6706fce3901dd345b4","assignee":{"login":"AngieCris","id":6562128,"avatar_url":"https://avatars1.githubusercontent.com/u/6562128?v=4","gravatar_id":"","url":"https://api.github.com/users/AngieCris","html_url":"https://github.com/AngieCris","followers_url":"https://api.github.com/users/AngieCris/followers","following_url":"https://api.github.com/users/AngieCris/following{/other_user}","gists_url":"https://api.github.com/users/AngieCris/gists{/gist_id}","starred_url":"https://api.github.com/users/AngieCris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngieCris/subscriptions","organizations_url":"https://api.github.com/users/AngieCris/orgs","repos_url":"https://api.github.com/users/AngieCris/repos","events_url":"https://api.github.com/users/AngieCris/events{/privacy}","received_events_url":"https://api.github.com/users/AngieCris/received_events","type":"User","site_admin":false},"assignees":[{"login":"AngieCris","id":6562128,"avatar_url":"https://avatars1.githubusercontent.com/u/6562128?v=4","gravatar_id":"","url":"https://api.github.com/users/AngieCris","html_url":"https://github.com/AngieCris","followers_url":"https://api.github.com/users/AngieCris/followers","following_url":"https://api.github.com/users/AngieCris/following{/other_user}","gists_url":"https://api.github.com/users/AngieCris/gists{/gist_id}","starred_url":"https://api.github.com/users/AngieCris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngieCris/subscriptions","organizations_url":"https://api.github.com/users/AngieCris/orgs","repos_url":"https://api.github.com/users/AngieCris/repos","events_url":"https://api.github.com/users/AngieCris/events{/privacy}","received_events_url":"https://api.github.com/users/AngieCris/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"emlin","id":1091772,"avatar_url":"https://avatars0.githubusercontent.com/u/1091772?v=4","gravatar_id":"","url":"https://api.github.com/users/emlin","html_url":"https://github.com/emlin","followers_url":"https://api.github.com/users/emlin/followers","following_url":"https://api.github.com/users/emlin/following{/other_user}","gists_url":"https://api.github.com/users/emlin/gists{/gist_id}","starred_url":"https://api.github.com/users/emlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlin/subscriptions","organizations_url":"https://api.github.com/users/emlin/orgs","repos_url":"https://api.github.com/users/emlin/repos","events_url":"https://api.github.com/users/emlin/events{/privacy}","received_events_url":"https://api.github.com/users/emlin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":353174341,"url":"https://api.github.com/repos/vmware/vic/labels/cla-not-required","name":"cla-not-required","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/7441/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/7441/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/7441/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/a5ff572061445d2a1c7d07c342116c3b7afeae49","head":{"label":"AngieCris:vic/7359","ref":"vic/7359","sha":"a5ff572061445d2a1c7d07c342116c3b7afeae49","user":{"login":"AngieCris","id":6562128,"avatar_url":"https://avatars1.githubusercontent.com/u/6562128?v=4","gravatar_id":"","url":"https://api.github.com/users/AngieCris","html_url":"https://github.com/AngieCris","followers_url":"https://api.github.com/users/AngieCris/followers","following_url":"https://api.github.com/users/AngieCris/following{/other_user}","gists_url":"https://api.github.com/users/AngieCris/gists{/gist_id}","starred_url":"https://api.github.com/users/AngieCris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngieCris/subscriptions","organizations_url":"https://api.github.com/users/AngieCris/orgs","repos_url":"https://api.github.com/users/AngieCris/repos","events_url":"https://api.github.com/users/AngieCris/events{/privacy}","received_events_url":"https://api.github.com/users/AngieCris/received_events","type":"User","site_admin":false},"repo":{"id":99621691,"name":"vic","full_name":"AngieCris/vic","owner":{"login":"AngieCris","id":6562128,"avatar_url":"https://avatars1.githubusercontent.com/u/6562128?v=4","gravatar_id":"","url":"https://api.github.com/users/AngieCris","html_url":"https://github.com/AngieCris","followers_url":"https://api.github.com/users/AngieCris/followers","following_url":"https://api.github.com/users/AngieCris/following{/other_user}","gists_url":"https://api.github.com/users/AngieCris/gists{/gist_id}","starred_url":"https://api.github.com/users/AngieCris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AngieCris/subscriptions","organizations_url":"https://api.github.com/users/AngieCris/orgs","repos_url":"https://api.github.com/users/AngieCris/repos","events_url":"https://api.github.com/users/AngieCris/events{/privacy}","received_events_url":"https://api.github.com/users/AngieCris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AngieCris/vic","description":"Integrated containers engine on vSphere","fork":true,"url":"https://api.github.com/repos/AngieCris/vic","forks_url":"https://api.github.com/repos/AngieCris/vic/forks","keys_url":"https://api.github.com/repos/AngieCris/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AngieCris/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AngieCris/vic/teams","hooks_url":"https://api.github.com/repos/AngieCris/vic/hooks","issue_events_url":"https://api.github.com/repos/AngieCris/vic/issues/events{/number}","events_url":"https://api.github.com/repos/AngieCris/vic/events","assignees_url":"https://api.github.com/repos/AngieCris/vic/assignees{/user}","branches_url":"https://api.github.com/repos/AngieCris/vic/branches{/branch}","tags_url":"https://api.github.com/repos/AngieCris/vic/tags","blobs_url":"https://api.github.com/repos/AngieCris/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AngieCris/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AngieCris/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/AngieCris/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AngieCris/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/AngieCris/vic/languages","stargazers_url":"https://api.github.com/repos/AngieCris/vic/stargazers","contributors_url":"https://api.github.com/repos/AngieCris/vic/contributors","subscribers_url":"https://api.github.com/repos/AngieCris/vic/subscribers","subscription_url":"https://api.github.com/repos/AngieCris/vic/subscription","commits_url":"https://api.github.com/repos/AngieCris/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/AngieCris/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/AngieCris/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/AngieCris/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/AngieCris/vic/contents/{+path}","compare_url":"https://api.github.com/repos/AngieCris/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AngieCris/vic/merges","archive_url":"https://api.github.com/repos/AngieCris/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AngieCris/vic/downloads","issues_url":"https://api.github.com/repos/AngieCris/vic/issues{/number}","pulls_url":"https://api.github.com/repos/AngieCris/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/AngieCris/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/AngieCris/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AngieCris/vic/labels{/name}","releases_url":"https://api.github.com/repos/AngieCris/vic/releases{/id}","deployments_url":"https://api.github.com/repos/AngieCris/vic/deployments","created_at":"2017-08-07T21:23:23Z","updated_at":"2017-08-07T21:23:27Z","pushed_at":"2018-03-02T22:44:32Z","git_url":"git://github.com/AngieCris/vic.git","ssh_url":"git@github.com:AngieCris/vic.git","clone_url":"https://github.com/AngieCris/vic.git","svn_url":"https://github.com/AngieCris/vic","homepage":"http://vmware.github.io/vic","size":70028,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"1912c1709a96c098516f45af15fb29acf58553a3","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars0.githubusercontent.com/u/473334?v=4","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers engine on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2018-03-01T08:12:59Z","pushed_at":"2018-03-05T20:21:08Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":"http://vmware.github.io/vic","size":69904,"stargazers_count":310,"watchers_count":310,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":122,"mirror_url":null,"archived":false,"open_issues_count":1044,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":122,"open_issues":1044,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/7441"},"html":{"href":"https://github.com/vmware/vic/pull/7441"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/7441"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/7441/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/7441/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/7441/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/a5ff572061445d2a1c7d07c342116c3b7afeae49"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hickeng"}}