{"action":"created","issue":{"url":"https://api.github.com/repos/uber/prototool/issues/205","repository_url":"https://api.github.com/repos/uber/prototool","labels_url":"https://api.github.com/repos/uber/prototool/issues/205/labels{/name}","comments_url":"https://api.github.com/repos/uber/prototool/issues/205/comments","events_url":"https://api.github.com/repos/uber/prototool/issues/205/events","html_url":"https://github.com/uber/prototool/pull/205","id":353832869,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzc2NjEy","number":205,"title":"Add script to generate assets for Homebrew and update README.md installation instructions","user":{"login":"peter-edge","id":4228796,"node_id":"MDQ6VXNlcjQyMjg3OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4228796?v=4","gravatar_id":"","url":"https://api.github.com/users/peter-edge","html_url":"https://github.com/peter-edge","followers_url":"https://api.github.com/users/peter-edge/followers","following_url":"https://api.github.com/users/peter-edge/following{/other_user}","gists_url":"https://api.github.com/users/peter-edge/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-edge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-edge/subscriptions","organizations_url":"https://api.github.com/users/peter-edge/orgs","repos_url":"https://api.github.com/users/peter-edge/repos","events_url":"https://api.github.com/users/peter-edge/events{/privacy}","received_events_url":"https://api.github.com/users/peter-edge/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-24T15:37:33Z","updated_at":"2018-08-24T15:40:58Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/uber/prototool/pulls/205","html_url":"https://github.com/uber/prototool/pull/205","diff_url":"https://github.com/uber/prototool/pull/205.diff","patch_url":"https://github.com/uber/prototool/pull/205.patch"},"body":"This fixes #203, and also inadvertently fixes #191.\r\n\r\nThis adds helper functionality to build Prototool for Homebrew. In #203, there's a question about whether to do this in our own Tap versus homebrew-core - I personally vote for homebrew-core, as once the initial formula is added, the maintainers are *extremely* quick to update to new versions, and it reduces the complexity for external developers. We've gotten some great feedback, including discovery of some nasty bugs, from external developers, so anything we can do to increase that pipeline, especially now that this is v1.0, would be valuable. If there's a separate tap, external developers will instinctively be less likely to install (at least that would be my instinct, for whatever that's worth).\r\n\r\nFor the same reason, I'm in favor of doing this sooner than later - customer demand is sort of a chicken and egg problem, if we make it easier for customers to install Prototool, we'll have more demand. @AlexAPB @amckinney @abhinav thoughts?\r\n\r\nThis adds `etc/bin/brewgen.sh`, which is effectively a customized `etc/bin/releasegen.sh`. We could merge the two scripts, but doing so (and then having options in each script) ends up being just as complicated, if not more bug prone.\r\n\r\nThis also adds `make brewgen`, which is what the formula calls. We could just call the script directly in the Homebrew formula and remove the `automake` dependency, but we later might want to move more functionality into the Makefile for the build, so this makes it easier to do so.\r\n\r\nThe corresponding formula can be seen at https://github.com/peter-edge/homebrew-core/compare/master...peter-edge:prototool-1.0.0?expand=1 - note that `--HEAD` will not work right now, as this PR would need to be merged first. I've tested this locally, and it's pretty cool.\r\n\r\n```\r\n$ brew info prototool\r\nprototool: stable v1.0.0, HEAD\r\nYour Swiss Army Knife for Protocol Buffers\r\nhttps://github.com/uber/prototool\r\n/usr/local/Cellar/prototool/v1.0.0 (17 files, 16.6MB) *\r\n  Built from source on 2018-08-24 at 17:26:56\r\nFrom: https://github.com/Homebrew/homebrew-core/blob/master/Formula/prototool.rb\r\n==> Dependencies\r\nBuild: automake ✔, glide ✔, go ✔\r\n==> Options\r\n--HEAD\r\n\tInstall HEAD version\r\n==> Caveats\r\nBash completion has been installed to:\r\n  /usr/local/etc/bash_completion.d\r\n\r\nzsh functions have been installed to:\r\n  /usr/local/share/zsh/site-functions\r\n```\r\n\r\nThis formula will also need to be updated - assumedly, if we merge this, we'll need to do a `v1.1.0` for the changes here, and then the Formula will be updated to have this version and sha256, as opposed to pointing to this branch.\r\n\r\nHomebrew is really easy to use, so this results in the bash completion, zsh completion, and man pages being installed as well. Future updates to homebrew-core will be extremely easy since all the build functionality is wrapped in the `etc/bin/brewgen.sh` script."},"comment":{"url":"https://api.github.com/repos/uber/prototool/issues/comments/415798139","html_url":"https://github.com/uber/prototool/pull/205#issuecomment-415798139","issue_url":"https://api.github.com/repos/uber/prototool/issues/205","id":415798139,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTc5ODEzOQ==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T15:40:58Z","updated_at":"2018-08-24T15:40:58Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/uber/prototool/pull/205?src=pr&el=h1) Report\n> Merging [#205](https://codecov.io/gh/uber/prototool/pull/205?src=pr&el=desc) into [dev](https://codecov.io/gh/uber/prototool/commit/eb695b64acb5abe198e5fedee7a7448eb7c65c55?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/uber/prototool/pull/205/graphs/tree.svg?width=650&height=150&src=pr&token=A9V0DApqZg)](https://codecov.io/gh/uber/prototool/pull/205?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##              dev     #205   +/-   ##\n=======================================\n  Coverage   68.77%   68.77%           \n=======================================\n  Files          73       73           \n  Lines        3712     3712           \n=======================================\n  Hits         2553     2553           \n  Misses        838      838           \n  Partials      321      321\n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/uber/prototool/pull/205?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/uber/prototool/pull/205?src=pr&el=footer). Last update [eb695b6...deac7c3](https://codecov.io/gh/uber/prototool/pull/205?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}