{"action":"created","comment":{"url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/comments/169036420","pull_request_review_id":97497259,"id":169036420,"diff_hunk":"@@ -176,6 +176,67 @@ python() {\n         bb.fatal(\"MENDER_PARTITION_ALIGNMENT_MB is deprecated. Please define MENDER_PARTITION_ALIGNMENT_KB instead.\")\n }\n \n+addhandler mender_vars_handler\n+python mender_vars_handler() {\n+    if(isinstance(e, bb.event.ParseCompleted)):\n+        from bb import data\n+        import os\n+        import re \n+        import json\n+\n+        path = d.getVar(\"LAYERDIR_MENDER\")\n+        path = os.path.join(path, \"conf/mender-vars.json\")\n+\n+        if( (os.path.isfile(path))):","path":"meta-mender-core/classes/mender-setup.bbclass","position":15,"original_position":15,"commit_id":"e0af3ba890050adc40c71e47441d5d6af0d2921e","original_commit_id":"e0af3ba890050adc40c71e47441d5d6af0d2921e","user":{"login":"oleorhagen","id":29454137,"avatar_url":"https://avatars3.githubusercontent.com/u/29454137?v=4","gravatar_id":"","url":"https://api.github.com/users/oleorhagen","html_url":"https://github.com/oleorhagen","followers_url":"https://api.github.com/users/oleorhagen/followers","following_url":"https://api.github.com/users/oleorhagen/following{/other_user}","gists_url":"https://api.github.com/users/oleorhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/oleorhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleorhagen/subscriptions","organizations_url":"https://api.github.com/users/oleorhagen/orgs","repos_url":"https://api.github.com/users/oleorhagen/repos","events_url":"https://api.github.com/users/oleorhagen/events{/privacy}","received_events_url":"https://api.github.com/users/oleorhagen/received_events","type":"User","site_admin":false},"body":"haha, didn't even notice :see_no_evil: ","created_at":"2018-02-19T10:32:22Z","updated_at":"2018-02-19T10:32:22Z","html_url":"https://github.com/mendersoftware/meta-mender/pull/477#discussion_r169036420","pull_request_url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/477","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/comments/169036420"},"html":{"href":"https://github.com/mendersoftware/meta-mender/pull/477#discussion_r169036420"},"pull_request":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/477"}},"in_reply_to_id":169032272},"pull_request":{"url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/477","id":169654624,"html_url":"https://github.com/mendersoftware/meta-mender/pull/477","diff_url":"https://github.com/mendersoftware/meta-mender/pull/477.diff","patch_url":"https://github.com/mendersoftware/meta-mender/pull/477.patch","issue_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/477","number":477,"state":"open","locked":false,"title":"title: Warn on unused MENDER_* variables","user":{"login":"alfrunes","id":35835176,"avatar_url":"https://avatars3.githubusercontent.com/u/35835176?v=4","gravatar_id":"","url":"https://api.github.com/users/alfrunes","html_url":"https://github.com/alfrunes","followers_url":"https://api.github.com/users/alfrunes/followers","following_url":"https://api.github.com/users/alfrunes/following{/other_user}","gists_url":"https://api.github.com/users/alfrunes/gists{/gist_id}","starred_url":"https://api.github.com/users/alfrunes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfrunes/subscriptions","organizations_url":"https://api.github.com/users/alfrunes/orgs","repos_url":"https://api.github.com/users/alfrunes/repos","events_url":"https://api.github.com/users/alfrunes/events{/privacy}","received_events_url":"https://api.github.com/users/alfrunes/received_events","type":"User","site_admin":false},"body":"changelog: title\r\n\r\nSigned-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>","created_at":"2018-02-16T15:38:07Z","updated_at":"2018-02-19T10:32:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b307e8c79430288c96446b4c022ce49aa4936fb5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/477/commits","review_comments_url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/477/comments","review_comment_url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/477/comments","statuses_url":"https://api.github.com/repos/mendersoftware/meta-mender/statuses/e0af3ba890050adc40c71e47441d5d6af0d2921e","head":{"label":"alfrunes:master","ref":"master","sha":"e0af3ba890050adc40c71e47441d5d6af0d2921e","user":{"login":"alfrunes","id":35835176,"avatar_url":"https://avatars3.githubusercontent.com/u/35835176?v=4","gravatar_id":"","url":"https://api.github.com/users/alfrunes","html_url":"https://github.com/alfrunes","followers_url":"https://api.github.com/users/alfrunes/followers","following_url":"https://api.github.com/users/alfrunes/following{/other_user}","gists_url":"https://api.github.com/users/alfrunes/gists{/gist_id}","starred_url":"https://api.github.com/users/alfrunes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfrunes/subscriptions","organizations_url":"https://api.github.com/users/alfrunes/orgs","repos_url":"https://api.github.com/users/alfrunes/repos","events_url":"https://api.github.com/users/alfrunes/events{/privacy}","received_events_url":"https://api.github.com/users/alfrunes/received_events","type":"User","site_admin":false},"repo":{"id":119034897,"name":"meta-mender","full_name":"alfrunes/meta-mender","owner":{"login":"alfrunes","id":35835176,"avatar_url":"https://avatars3.githubusercontent.com/u/35835176?v=4","gravatar_id":"","url":"https://api.github.com/users/alfrunes","html_url":"https://github.com/alfrunes","followers_url":"https://api.github.com/users/alfrunes/followers","following_url":"https://api.github.com/users/alfrunes/following{/other_user}","gists_url":"https://api.github.com/users/alfrunes/gists{/gist_id}","starred_url":"https://api.github.com/users/alfrunes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfrunes/subscriptions","organizations_url":"https://api.github.com/users/alfrunes/orgs","repos_url":"https://api.github.com/users/alfrunes/repos","events_url":"https://api.github.com/users/alfrunes/events{/privacy}","received_events_url":"https://api.github.com/users/alfrunes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alfrunes/meta-mender","description":"Yocto meta layer","fork":true,"url":"https://api.github.com/repos/alfrunes/meta-mender","forks_url":"https://api.github.com/repos/alfrunes/meta-mender/forks","keys_url":"https://api.github.com/repos/alfrunes/meta-mender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alfrunes/meta-mender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alfrunes/meta-mender/teams","hooks_url":"https://api.github.com/repos/alfrunes/meta-mender/hooks","issue_events_url":"https://api.github.com/repos/alfrunes/meta-mender/issues/events{/number}","events_url":"https://api.github.com/repos/alfrunes/meta-mender/events","assignees_url":"https://api.github.com/repos/alfrunes/meta-mender/assignees{/user}","branches_url":"https://api.github.com/repos/alfrunes/meta-mender/branches{/branch}","tags_url":"https://api.github.com/repos/alfrunes/meta-mender/tags","blobs_url":"https://api.github.com/repos/alfrunes/meta-mender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alfrunes/meta-mender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alfrunes/meta-mender/git/refs{/sha}","trees_url":"https://api.github.com/repos/alfrunes/meta-mender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alfrunes/meta-mender/statuses/{sha}","languages_url":"https://api.github.com/repos/alfrunes/meta-mender/languages","stargazers_url":"https://api.github.com/repos/alfrunes/meta-mender/stargazers","contributors_url":"https://api.github.com/repos/alfrunes/meta-mender/contributors","subscribers_url":"https://api.github.com/repos/alfrunes/meta-mender/subscribers","subscription_url":"https://api.github.com/repos/alfrunes/meta-mender/subscription","commits_url":"https://api.github.com/repos/alfrunes/meta-mender/commits{/sha}","git_commits_url":"https://api.github.com/repos/alfrunes/meta-mender/git/commits{/sha}","comments_url":"https://api.github.com/repos/alfrunes/meta-mender/comments{/number}","issue_comment_url":"https://api.github.com/repos/alfrunes/meta-mender/issues/comments{/number}","contents_url":"https://api.github.com/repos/alfrunes/meta-mender/contents/{+path}","compare_url":"https://api.github.com/repos/alfrunes/meta-mender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alfrunes/meta-mender/merges","archive_url":"https://api.github.com/repos/alfrunes/meta-mender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alfrunes/meta-mender/downloads","issues_url":"https://api.github.com/repos/alfrunes/meta-mender/issues{/number}","pulls_url":"https://api.github.com/repos/alfrunes/meta-mender/pulls{/number}","milestones_url":"https://api.github.com/repos/alfrunes/meta-mender/milestones{/number}","notifications_url":"https://api.github.com/repos/alfrunes/meta-mender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alfrunes/meta-mender/labels{/name}","releases_url":"https://api.github.com/repos/alfrunes/meta-mender/releases{/id}","deployments_url":"https://api.github.com/repos/alfrunes/meta-mender/deployments","created_at":"2018-01-26T09:49:40Z","updated_at":"2018-01-26T09:49:42Z","pushed_at":"2018-02-17T17:17:19Z","git_url":"git://github.com/alfrunes/meta-mender.git","ssh_url":"git@github.com:alfrunes/meta-mender.git","clone_url":"https://github.com/alfrunes/meta-mender.git","svn_url":"https://github.com/alfrunes/meta-mender","homepage":"https://mender.io","size":1326,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mendersoftware:master","ref":"master","sha":"dac0ff295c9de3c1feed3739089bd1e9b49cd408","user":{"login":"mendersoftware","id":15040539,"avatar_url":"https://avatars1.githubusercontent.com/u/15040539?v=4","gravatar_id":"","url":"https://api.github.com/users/mendersoftware","html_url":"https://github.com/mendersoftware","followers_url":"https://api.github.com/users/mendersoftware/followers","following_url":"https://api.github.com/users/mendersoftware/following{/other_user}","gists_url":"https://api.github.com/users/mendersoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/mendersoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendersoftware/subscriptions","organizations_url":"https://api.github.com/users/mendersoftware/orgs","repos_url":"https://api.github.com/users/mendersoftware/repos","events_url":"https://api.github.com/users/mendersoftware/events{/privacy}","received_events_url":"https://api.github.com/users/mendersoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":47542851,"name":"meta-mender","full_name":"mendersoftware/meta-mender","owner":{"login":"mendersoftware","id":15040539,"avatar_url":"https://avatars1.githubusercontent.com/u/15040539?v=4","gravatar_id":"","url":"https://api.github.com/users/mendersoftware","html_url":"https://github.com/mendersoftware","followers_url":"https://api.github.com/users/mendersoftware/followers","following_url":"https://api.github.com/users/mendersoftware/following{/other_user}","gists_url":"https://api.github.com/users/mendersoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/mendersoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendersoftware/subscriptions","organizations_url":"https://api.github.com/users/mendersoftware/orgs","repos_url":"https://api.github.com/users/mendersoftware/repos","events_url":"https://api.github.com/users/mendersoftware/events{/privacy}","received_events_url":"https://api.github.com/users/mendersoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mendersoftware/meta-mender","description":"Yocto meta layer","fork":false,"url":"https://api.github.com/repos/mendersoftware/meta-mender","forks_url":"https://api.github.com/repos/mendersoftware/meta-mender/forks","keys_url":"https://api.github.com/repos/mendersoftware/meta-mender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mendersoftware/meta-mender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mendersoftware/meta-mender/teams","hooks_url":"https://api.github.com/repos/mendersoftware/meta-mender/hooks","issue_events_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/events{/number}","events_url":"https://api.github.com/repos/mendersoftware/meta-mender/events","assignees_url":"https://api.github.com/repos/mendersoftware/meta-mender/assignees{/user}","branches_url":"https://api.github.com/repos/mendersoftware/meta-mender/branches{/branch}","tags_url":"https://api.github.com/repos/mendersoftware/meta-mender/tags","blobs_url":"https://api.github.com/repos/mendersoftware/meta-mender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mendersoftware/meta-mender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mendersoftware/meta-mender/git/refs{/sha}","trees_url":"https://api.github.com/repos/mendersoftware/meta-mender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mendersoftware/meta-mender/statuses/{sha}","languages_url":"https://api.github.com/repos/mendersoftware/meta-mender/languages","stargazers_url":"https://api.github.com/repos/mendersoftware/meta-mender/stargazers","contributors_url":"https://api.github.com/repos/mendersoftware/meta-mender/contributors","subscribers_url":"https://api.github.com/repos/mendersoftware/meta-mender/subscribers","subscription_url":"https://api.github.com/repos/mendersoftware/meta-mender/subscription","commits_url":"https://api.github.com/repos/mendersoftware/meta-mender/commits{/sha}","git_commits_url":"https://api.github.com/repos/mendersoftware/meta-mender/git/commits{/sha}","comments_url":"https://api.github.com/repos/mendersoftware/meta-mender/comments{/number}","issue_comment_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/comments{/number}","contents_url":"https://api.github.com/repos/mendersoftware/meta-mender/contents/{+path}","compare_url":"https://api.github.com/repos/mendersoftware/meta-mender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mendersoftware/meta-mender/merges","archive_url":"https://api.github.com/repos/mendersoftware/meta-mender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mendersoftware/meta-mender/downloads","issues_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues{/number}","pulls_url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls{/number}","milestones_url":"https://api.github.com/repos/mendersoftware/meta-mender/milestones{/number}","notifications_url":"https://api.github.com/repos/mendersoftware/meta-mender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mendersoftware/meta-mender/labels{/name}","releases_url":"https://api.github.com/repos/mendersoftware/meta-mender/releases{/id}","deployments_url":"https://api.github.com/repos/mendersoftware/meta-mender/deployments","created_at":"2015-12-07T09:37:44Z","updated_at":"2018-02-13T10:51:54Z","pushed_at":"2018-02-17T17:17:20Z","git_url":"git://github.com/mendersoftware/meta-mender.git","ssh_url":"git@github.com:mendersoftware/meta-mender.git","clone_url":"https://github.com/mendersoftware/meta-mender.git","svn_url":"https://github.com/mendersoftware/meta-mender","homepage":"https://mender.io","size":1334,"stargazers_count":51,"watchers_count":51,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":40,"open_issues":9,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/477"},"html":{"href":"https://github.com/mendersoftware/meta-mender/pull/477"},"issue":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/issues/477"},"comments":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/issues/477/comments"},"review_comments":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/477/comments"},"review_comment":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/477/commits"},"statuses":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/statuses/e0af3ba890050adc40c71e47441d5d6af0d2921e"}},"author_association":"NONE"}}
{"actor":{"display_login":"oleorhagen"}}