{"action":"closed","number":417,"pull_request":{"url":"https://api.github.com/repos/google/truth/pulls/417","id":169472611,"html_url":"https://github.com/google/truth/pull/417","diff_url":"https://github.com/google/truth/pull/417.diff","patch_url":"https://github.com/google/truth/pull/417.patch","issue_url":"https://api.github.com/repos/google/truth/issues/417","number":417,"state":"closed","locked":false,"title":"Moe Sync","user":{"login":"ronshapiro","id":792797,"avatar_url":"https://avatars2.githubusercontent.com/u/792797?v=4","gravatar_id":"","url":"https://api.github.com/users/ronshapiro","html_url":"https://github.com/ronshapiro","followers_url":"https://api.github.com/users/ronshapiro/followers","following_url":"https://api.github.com/users/ronshapiro/following{/other_user}","gists_url":"https://api.github.com/users/ronshapiro/gists{/gist_id}","starred_url":"https://api.github.com/users/ronshapiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronshapiro/subscriptions","organizations_url":"https://api.github.com/users/ronshapiro/orgs","repos_url":"https://api.github.com/users/ronshapiro/repos","events_url":"https://api.github.com/users/ronshapiro/events{/privacy}","received_events_url":"https://api.github.com/users/ronshapiro/received_events","type":"User","site_admin":false},"body":"This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.\n\nCommits:\n=====\n<p> Mark actualCustomStringRepresentation() as @ForOverride.\n\nThe intention is:\n- actualAsString() is the method that people call.\n- actualCustomStringRepresentation() is the method that people override.\n\nFortunately, no one actually calls actualCustomStringRepresentation(), aside from some tests that call it to test a subject's implementation. That's easy enough to work around by extracting a method.\n(Arguably @ForOverride should permit calls from tests in some cases (now that Error Prone knows how to identify test code). But it's not entirely clear, since, e.g., people shouldn't be testing Converter.doForward(null) because the method can never be invoked that way.\n\nf4d80687812b09c275893eec7e272b3733e3b4d3\n\n-------\n\n<p> Migrate from deprecated getDisplaySubject() to equivalent actualAsString().\n\n8f0aff2573fb925c7178ab3fe1eebf3d02c1b0b1\n\n-------\n\n<p> Delete getDisplaySubject().\n\nRELNOTES=Removed `getDisplaySubject()`. Callers should use `actualAsString()`; overriders should use `actualCustomStringRepresentation()`.\n\nc19e2ba17519c3d517acdeb9c44b56d527575cda","created_at":"2018-02-15T20:09:00Z","updated_at":"2018-02-15T21:48:32Z","closed_at":"2018-02-15T21:48:32Z","merged_at":"2018-02-15T21:48:32Z","merge_commit_sha":"47ea976e18210179444ee6a193cb68a7be9fbe11","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":147909092,"url":"https://api.github.com/repos/google/truth/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/truth/pulls/417/commits","review_comments_url":"https://api.github.com/repos/google/truth/pulls/417/comments","review_comment_url":"https://api.github.com/repos/google/truth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/truth/issues/417/comments","statuses_url":"https://api.github.com/repos/google/truth/statuses/c19e2ba17519c3d517acdeb9c44b56d527575cda","head":{"label":"google:sync-master-2018/02/15","ref":"sync-master-2018/02/15","sha":"c19e2ba17519c3d517acdeb9c44b56d527575cda","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":1936771,"name":"truth","full_name":"google/truth","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/truth","description":"Fluent assertions for Java","fork":false,"url":"https://api.github.com/repos/google/truth","forks_url":"https://api.github.com/repos/google/truth/forks","keys_url":"https://api.github.com/repos/google/truth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/truth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/truth/teams","hooks_url":"https://api.github.com/repos/google/truth/hooks","issue_events_url":"https://api.github.com/repos/google/truth/issues/events{/number}","events_url":"https://api.github.com/repos/google/truth/events","assignees_url":"https://api.github.com/repos/google/truth/assignees{/user}","branches_url":"https://api.github.com/repos/google/truth/branches{/branch}","tags_url":"https://api.github.com/repos/google/truth/tags","blobs_url":"https://api.github.com/repos/google/truth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/truth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/truth/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/truth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/truth/statuses/{sha}","languages_url":"https://api.github.com/repos/google/truth/languages","stargazers_url":"https://api.github.com/repos/google/truth/stargazers","contributors_url":"https://api.github.com/repos/google/truth/contributors","subscribers_url":"https://api.github.com/repos/google/truth/subscribers","subscription_url":"https://api.github.com/repos/google/truth/subscription","commits_url":"https://api.github.com/repos/google/truth/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/truth/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/truth/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/truth/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/truth/contents/{+path}","compare_url":"https://api.github.com/repos/google/truth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/truth/merges","archive_url":"https://api.github.com/repos/google/truth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/truth/downloads","issues_url":"https://api.github.com/repos/google/truth/issues{/number}","pulls_url":"https://api.github.com/repos/google/truth/pulls{/number}","milestones_url":"https://api.github.com/repos/google/truth/milestones{/number}","notifications_url":"https://api.github.com/repos/google/truth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/truth/labels{/name}","releases_url":"https://api.github.com/repos/google/truth/releases{/id}","deployments_url":"https://api.github.com/repos/google/truth/deployments","created_at":"2011-06-22T18:55:12Z","updated_at":"2018-02-14T10:05:05Z","pushed_at":"2018-02-15T21:48:32Z","git_url":"git://github.com/google/truth.git","ssh_url":"git@github.com:google/truth.git","clone_url":"https://github.com/google/truth.git","svn_url":"https://github.com/google/truth","homepage":"http://google.github.io/truth","size":23787,"stargazers_count":1341,"watchers_count":1341,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":149,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":149,"open_issues":48,"watchers":1341,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"b00942127329c8ff8f9587a391c0b610f764efc1","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":1936771,"name":"truth","full_name":"google/truth","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/truth","description":"Fluent assertions for Java","fork":false,"url":"https://api.github.com/repos/google/truth","forks_url":"https://api.github.com/repos/google/truth/forks","keys_url":"https://api.github.com/repos/google/truth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/truth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/truth/teams","hooks_url":"https://api.github.com/repos/google/truth/hooks","issue_events_url":"https://api.github.com/repos/google/truth/issues/events{/number}","events_url":"https://api.github.com/repos/google/truth/events","assignees_url":"https://api.github.com/repos/google/truth/assignees{/user}","branches_url":"https://api.github.com/repos/google/truth/branches{/branch}","tags_url":"https://api.github.com/repos/google/truth/tags","blobs_url":"https://api.github.com/repos/google/truth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/truth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/truth/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/truth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/truth/statuses/{sha}","languages_url":"https://api.github.com/repos/google/truth/languages","stargazers_url":"https://api.github.com/repos/google/truth/stargazers","contributors_url":"https://api.github.com/repos/google/truth/contributors","subscribers_url":"https://api.github.com/repos/google/truth/subscribers","subscription_url":"https://api.github.com/repos/google/truth/subscription","commits_url":"https://api.github.com/repos/google/truth/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/truth/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/truth/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/truth/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/truth/contents/{+path}","compare_url":"https://api.github.com/repos/google/truth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/truth/merges","archive_url":"https://api.github.com/repos/google/truth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/truth/downloads","issues_url":"https://api.github.com/repos/google/truth/issues{/number}","pulls_url":"https://api.github.com/repos/google/truth/pulls{/number}","milestones_url":"https://api.github.com/repos/google/truth/milestones{/number}","notifications_url":"https://api.github.com/repos/google/truth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/truth/labels{/name}","releases_url":"https://api.github.com/repos/google/truth/releases{/id}","deployments_url":"https://api.github.com/repos/google/truth/deployments","created_at":"2011-06-22T18:55:12Z","updated_at":"2018-02-14T10:05:05Z","pushed_at":"2018-02-15T21:48:32Z","git_url":"git://github.com/google/truth.git","ssh_url":"git@github.com:google/truth.git","clone_url":"https://github.com/google/truth.git","svn_url":"https://github.com/google/truth","homepage":"http://google.github.io/truth","size":23787,"stargazers_count":1341,"watchers_count":1341,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":149,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":149,"open_issues":48,"watchers":1341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/truth/pulls/417"},"html":{"href":"https://github.com/google/truth/pull/417"},"issue":{"href":"https://api.github.com/repos/google/truth/issues/417"},"comments":{"href":"https://api.github.com/repos/google/truth/issues/417/comments"},"review_comments":{"href":"https://api.github.com/repos/google/truth/pulls/417/comments"},"review_comment":{"href":"https://api.github.com/repos/google/truth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/truth/pulls/417/commits"},"statuses":{"href":"https://api.github.com/repos/google/truth/statuses/c19e2ba17519c3d517acdeb9c44b56d527575cda"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ronshapiro","id":792797,"avatar_url":"https://avatars2.githubusercontent.com/u/792797?v=4","gravatar_id":"","url":"https://api.github.com/users/ronshapiro","html_url":"https://github.com/ronshapiro","followers_url":"https://api.github.com/users/ronshapiro/followers","following_url":"https://api.github.com/users/ronshapiro/following{/other_user}","gists_url":"https://api.github.com/users/ronshapiro/gists{/gist_id}","starred_url":"https://api.github.com/users/ronshapiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronshapiro/subscriptions","organizations_url":"https://api.github.com/users/ronshapiro/orgs","repos_url":"https://api.github.com/users/ronshapiro/repos","events_url":"https://api.github.com/users/ronshapiro/events{/privacy}","received_events_url":"https://api.github.com/users/ronshapiro/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":15,"deletions":20,"changed_files":2}}
{"actor":{"display_login":"ronshapiro"}}