{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/24269","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/24269/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24269/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/24269/events","html_url":"https://github.com/nodejs/node/pull/24269","id":379080913,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NjMwNjU4","number":24269,"title":"crypto: put legacy _handle accessors on prototypes","user":{"login":"targos","id":2352663,"node_id":"MDQ6VXNlcjIzNTI2NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"labels":[{"id":155267357,"node_id":"MDU6TGFiZWwxNTUyNjczNTc=","url":"https://api.github.com/repos/nodejs/node/labels/crypto","name":"crypto","color":"009800","default":false},{"id":326905670,"node_id":"MDU6TGFiZWwzMjY5MDU2NzA=","url":"https://api.github.com/repos/nodejs/node/labels/performance","name":"performance","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-09T09:15:11Z","updated_at":"2018-11-09T17:07:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24269","html_url":"https://github.com/nodejs/node/pull/24269","diff_url":"https://github.com/nodejs/node/pull/24269.diff","patch_url":"https://github.com/nodejs/node/pull/24269.patch"},"body":"Creating deprecated accessors each time an object is created is very\r\ntime consuming.\r\n\r\nRefs: https://github.com/nodejs/node/pull/22747\r\nFixes: https://github.com/nodejs/node/issues/24266\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/437426808","html_url":"https://github.com/nodejs/node/pull/24269#issuecomment-437426808","issue_url":"https://api.github.com/repos/nodejs/node/issues/24269","id":437426808,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzQyNjgwOA==","user":{"login":"tniessen","id":3109072,"node_id":"MDQ6VXNlcjMxMDkwNzI=","avatar_url":"https://avatars3.githubusercontent.com/u/3109072?v=4","gravatar_id":"","url":"https://api.github.com/users/tniessen","html_url":"https://github.com/tniessen","followers_url":"https://api.github.com/users/tniessen/followers","following_url":"https://api.github.com/users/tniessen/following{/other_user}","gists_url":"https://api.github.com/users/tniessen/gists{/gist_id}","starred_url":"https://api.github.com/users/tniessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tniessen/subscriptions","organizations_url":"https://api.github.com/users/tniessen/orgs","repos_url":"https://api.github.com/users/tniessen/repos","events_url":"https://api.github.com/users/tniessen/events{/privacy}","received_events_url":"https://api.github.com/users/tniessen/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T17:07:56Z","updated_at":"2018-11-09T17:07:56Z","author_association":"MEMBER","body":"I originally proposed to remove them, but we agreed to add a deprecation cycle first."}}
{"actor":{"display_login":"tniessen"}}