{"action":"created","comment":{"url":"https://api.github.com/repos/heptio/ark/pulls/comments/194825712","pull_request_review_id":128070867,"id":194825712,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDgyNTcxMg==","diff_hunk":"@@ -269,16 +273,22 @@ func (controller *backupController) processBackup(key string) error {\n \n \tlogContext.Debug(\"Running backup\")\n \t// execution & upload of backup\n+\tbackupName := kubeutil.NamespaceAndName(backup)\n+\tbackupScheduleName := getBackupScheduleName(backup)\n+\tcontroller.metrics.RegisterBackupAttempt(backupName, backupScheduleName)\n+\n \tif err := controller.runBackup(backup, controller.bucket); err != nil {\n \t\tlogContext.WithError(err).Error(\"backup failed\")\n \t\tbackup.Status.Phase = api.BackupPhaseFailed\n+\t\tcontroller.metrics.RegisterBackupFailed(backupName, backupScheduleName)","path":"pkg/controller/backup_controller.go","position":43,"original_position":43,"commit_id":"3378019cdb0e029bb2982c26ad8a08ad58a2b1fb","original_commit_id":"e1dc15555304bbf11d7e6800bb9046c4dc96a667","user":{"login":"ashish-amarnath","id":22872138,"node_id":"MDQ6VXNlcjIyODcyMTM4","avatar_url":"https://avatars1.githubusercontent.com/u/22872138?v=4","gravatar_id":"","url":"https://api.github.com/users/ashish-amarnath","html_url":"https://github.com/ashish-amarnath","followers_url":"https://api.github.com/users/ashish-amarnath/followers","following_url":"https://api.github.com/users/ashish-amarnath/following{/other_user}","gists_url":"https://api.github.com/users/ashish-amarnath/gists{/gist_id}","starred_url":"https://api.github.com/users/ashish-amarnath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashish-amarnath/subscriptions","organizations_url":"https://api.github.com/users/ashish-amarnath/orgs","repos_url":"https://api.github.com/users/ashish-amarnath/repos","events_url":"https://api.github.com/users/ashish-amarnath/events{/privacy}","received_events_url":"https://api.github.com/users/ashish-amarnath/received_events","type":"User","site_admin":false},"body":"@nrb thanks for running the test for me and catching this bug! Pushed a change with the fix.","created_at":"2018-06-12T17:31:37Z","updated_at":"2018-06-12T17:31:38Z","html_url":"https://github.com/heptio/ark/pull/531#discussion_r194825712","pull_request_url":"https://api.github.com/repos/heptio/ark/pulls/531","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/heptio/ark/pulls/comments/194825712"},"html":{"href":"https://github.com/heptio/ark/pull/531#discussion_r194825712"},"pull_request":{"href":"https://api.github.com/repos/heptio/ark/pulls/531"}},"in_reply_to_id":194749353},"pull_request":{"url":"https://api.github.com/repos/heptio/ark/pulls/531","id":193150932,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTUwOTMy","html_url":"https://github.com/heptio/ark/pull/531","diff_url":"https://github.com/heptio/ark/pull/531.diff","patch_url":"https://github.com/heptio/ark/pull/531.patch","issue_url":"https://api.github.com/repos/heptio/ark/issues/531","number":531,"state":"open","locked":false,"title":"Add metrics package to publish metrics","user":{"login":"ashish-amarnath","id":22872138,"node_id":"MDQ6VXNlcjIyODcyMTM4","avatar_url":"https://avatars1.githubusercontent.com/u/22872138?v=4","gravatar_id":"","url":"https://api.github.com/users/ashish-amarnath","html_url":"https://github.com/ashish-amarnath","followers_url":"https://api.github.com/users/ashish-amarnath/followers","following_url":"https://api.github.com/users/ashish-amarnath/following{/other_user}","gists_url":"https://api.github.com/users/ashish-amarnath/gists{/gist_id}","starred_url":"https://api.github.com/users/ashish-amarnath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashish-amarnath/subscriptions","organizations_url":"https://api.github.com/users/ashish-amarnath/orgs","repos_url":"https://api.github.com/users/ashish-amarnath/repos","events_url":"https://api.github.com/users/ashish-amarnath/events{/privacy}","received_events_url":"https://api.github.com/users/ashish-amarnath/received_events","type":"User","site_admin":false},"body":"Add a metrics package to handle metric registration and publishing\r\nAdd a metricsAddress field to the server struct\r\nStart a metrics endpoint as part of starting the controllers\r\nReport backup status on backup completion","created_at":"2018-06-06T21:51:17Z","updated_at":"2018-06-12T17:31:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f097d1d12fc8992d8470ea0445c298e12911225d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"skriss","id":5241206,"node_id":"MDQ6VXNlcjUyNDEyMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5241206?v=4","gravatar_id":"","url":"https://api.github.com/users/skriss","html_url":"https://github.com/skriss","followers_url":"https://api.github.com/users/skriss/followers","following_url":"https://api.github.com/users/skriss/following{/other_user}","gists_url":"https://api.github.com/users/skriss/gists{/gist_id}","starred_url":"https://api.github.com/users/skriss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skriss/subscriptions","organizations_url":"https://api.github.com/users/skriss/orgs","repos_url":"https://api.github.com/users/skriss/repos","events_url":"https://api.github.com/users/skriss/events{/privacy}","received_events_url":"https://api.github.com/users/skriss/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":660493776,"node_id":"MDU6TGFiZWw2NjA0OTM3NzY=","url":"https://api.github.com/repos/heptio/ark/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/heptio/ark/pulls/531/commits","review_comments_url":"https://api.github.com/repos/heptio/ark/pulls/531/comments","review_comment_url":"https://api.github.com/repos/heptio/ark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heptio/ark/issues/531/comments","statuses_url":"https://api.github.com/repos/heptio/ark/statuses/3378019cdb0e029bb2982c26ad8a08ad58a2b1fb","head":{"label":"ashish-amarnath:add-backup-metrics","ref":"add-backup-metrics","sha":"3378019cdb0e029bb2982c26ad8a08ad58a2b1fb","user":{"login":"ashish-amarnath","id":22872138,"node_id":"MDQ6VXNlcjIyODcyMTM4","avatar_url":"https://avatars1.githubusercontent.com/u/22872138?v=4","gravatar_id":"","url":"https://api.github.com/users/ashish-amarnath","html_url":"https://github.com/ashish-amarnath","followers_url":"https://api.github.com/users/ashish-amarnath/followers","following_url":"https://api.github.com/users/ashish-amarnath/following{/other_user}","gists_url":"https://api.github.com/users/ashish-amarnath/gists{/gist_id}","starred_url":"https://api.github.com/users/ashish-amarnath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashish-amarnath/subscriptions","organizations_url":"https://api.github.com/users/ashish-amarnath/orgs","repos_url":"https://api.github.com/users/ashish-amarnath/repos","events_url":"https://api.github.com/users/ashish-amarnath/events{/privacy}","received_events_url":"https://api.github.com/users/ashish-amarnath/received_events","type":"User","site_admin":false},"repo":{"id":104366505,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQzNjY1MDU=","name":"ark","full_name":"ashish-amarnath/ark","owner":{"login":"ashish-amarnath","id":22872138,"node_id":"MDQ6VXNlcjIyODcyMTM4","avatar_url":"https://avatars1.githubusercontent.com/u/22872138?v=4","gravatar_id":"","url":"https://api.github.com/users/ashish-amarnath","html_url":"https://github.com/ashish-amarnath","followers_url":"https://api.github.com/users/ashish-amarnath/followers","following_url":"https://api.github.com/users/ashish-amarnath/following{/other_user}","gists_url":"https://api.github.com/users/ashish-amarnath/gists{/gist_id}","starred_url":"https://api.github.com/users/ashish-amarnath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashish-amarnath/subscriptions","organizations_url":"https://api.github.com/users/ashish-amarnath/orgs","repos_url":"https://api.github.com/users/ashish-amarnath/repos","events_url":"https://api.github.com/users/ashish-amarnath/events{/privacy}","received_events_url":"https://api.github.com/users/ashish-amarnath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashish-amarnath/ark","description":"Heptio Ark is a utility for managing disaster recovery, specifically for your Kubernetes cluster resources and persistent volumes. Brought to you by Heptio.","fork":true,"url":"https://api.github.com/repos/ashish-amarnath/ark","forks_url":"https://api.github.com/repos/ashish-amarnath/ark/forks","keys_url":"https://api.github.com/repos/ashish-amarnath/ark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashish-amarnath/ark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashish-amarnath/ark/teams","hooks_url":"https://api.github.com/repos/ashish-amarnath/ark/hooks","issue_events_url":"https://api.github.com/repos/ashish-amarnath/ark/issues/events{/number}","events_url":"https://api.github.com/repos/ashish-amarnath/ark/events","assignees_url":"https://api.github.com/repos/ashish-amarnath/ark/assignees{/user}","branches_url":"https://api.github.com/repos/ashish-amarnath/ark/branches{/branch}","tags_url":"https://api.github.com/repos/ashish-amarnath/ark/tags","blobs_url":"https://api.github.com/repos/ashish-amarnath/ark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashish-amarnath/ark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashish-amarnath/ark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashish-amarnath/ark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashish-amarnath/ark/statuses/{sha}","languages_url":"https://api.github.com/repos/ashish-amarnath/ark/languages","stargazers_url":"https://api.github.com/repos/ashish-amarnath/ark/stargazers","contributors_url":"https://api.github.com/repos/ashish-amarnath/ark/contributors","subscribers_url":"https://api.github.com/repos/ashish-amarnath/ark/subscribers","subscription_url":"https://api.github.com/repos/ashish-amarnath/ark/subscription","commits_url":"https://api.github.com/repos/ashish-amarnath/ark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashish-amarnath/ark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashish-amarnath/ark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashish-amarnath/ark/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashish-amarnath/ark/contents/{+path}","compare_url":"https://api.github.com/repos/ashish-amarnath/ark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashish-amarnath/ark/merges","archive_url":"https://api.github.com/repos/ashish-amarnath/ark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashish-amarnath/ark/downloads","issues_url":"https://api.github.com/repos/ashish-amarnath/ark/issues{/number}","pulls_url":"https://api.github.com/repos/ashish-amarnath/ark/pulls{/number}","milestones_url":"https://api.github.com/repos/ashish-amarnath/ark/milestones{/number}","notifications_url":"https://api.github.com/repos/ashish-amarnath/ark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashish-amarnath/ark/labels{/name}","releases_url":"https://api.github.com/repos/ashish-amarnath/ark/releases{/id}","deployments_url":"https://api.github.com/repos/ashish-amarnath/ark/deployments","created_at":"2017-09-21T15:34:45Z","updated_at":"2017-10-04T02:15:43Z","pushed_at":"2018-06-12T17:30:36Z","git_url":"git://github.com/ashish-amarnath/ark.git","ssh_url":"git@github.com:ashish-amarnath/ark.git","clone_url":"https://github.com/ashish-amarnath/ark.git","svn_url":"https://github.com/ashish-amarnath/ark","homepage":"http://www.heptio.com","size":9365,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"heptio:master","ref":"master","sha":"0396ca1deef2eee7297615e24d28f2f55558c33d","user":{"login":"heptio","id":22035492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/22035492?v=4","gravatar_id":"","url":"https://api.github.com/users/heptio","html_url":"https://github.com/heptio","followers_url":"https://api.github.com/users/heptio/followers","following_url":"https://api.github.com/users/heptio/following{/other_user}","gists_url":"https://api.github.com/users/heptio/gists{/gist_id}","starred_url":"https://api.github.com/users/heptio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heptio/subscriptions","organizations_url":"https://api.github.com/users/heptio/orgs","repos_url":"https://api.github.com/users/heptio/repos","events_url":"https://api.github.com/users/heptio/events{/privacy}","received_events_url":"https://api.github.com/users/heptio/received_events","type":"Organization","site_admin":false},"repo":{"id":99143276,"node_id":"MDEwOlJlcG9zaXRvcnk5OTE0MzI3Ng==","name":"ark","full_name":"heptio/ark","owner":{"login":"heptio","id":22035492,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NDky","avatar_url":"https://avatars0.githubusercontent.com/u/22035492?v=4","gravatar_id":"","url":"https://api.github.com/users/heptio","html_url":"https://github.com/heptio","followers_url":"https://api.github.com/users/heptio/followers","following_url":"https://api.github.com/users/heptio/following{/other_user}","gists_url":"https://api.github.com/users/heptio/gists{/gist_id}","starred_url":"https://api.github.com/users/heptio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heptio/subscriptions","organizations_url":"https://api.github.com/users/heptio/orgs","repos_url":"https://api.github.com/users/heptio/repos","events_url":"https://api.github.com/users/heptio/events{/privacy}","received_events_url":"https://api.github.com/users/heptio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/heptio/ark","description":"Heptio Ark is a utility for managing disaster recovery, specifically for your Kubernetes cluster resources and persistent volumes. Brought to you by Heptio.","fork":false,"url":"https://api.github.com/repos/heptio/ark","forks_url":"https://api.github.com/repos/heptio/ark/forks","keys_url":"https://api.github.com/repos/heptio/ark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heptio/ark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heptio/ark/teams","hooks_url":"https://api.github.com/repos/heptio/ark/hooks","issue_events_url":"https://api.github.com/repos/heptio/ark/issues/events{/number}","events_url":"https://api.github.com/repos/heptio/ark/events","assignees_url":"https://api.github.com/repos/heptio/ark/assignees{/user}","branches_url":"https://api.github.com/repos/heptio/ark/branches{/branch}","tags_url":"https://api.github.com/repos/heptio/ark/tags","blobs_url":"https://api.github.com/repos/heptio/ark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heptio/ark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heptio/ark/git/refs{/sha}","trees_url":"https://api.github.com/repos/heptio/ark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heptio/ark/statuses/{sha}","languages_url":"https://api.github.com/repos/heptio/ark/languages","stargazers_url":"https://api.github.com/repos/heptio/ark/stargazers","contributors_url":"https://api.github.com/repos/heptio/ark/contributors","subscribers_url":"https://api.github.com/repos/heptio/ark/subscribers","subscription_url":"https://api.github.com/repos/heptio/ark/subscription","commits_url":"https://api.github.com/repos/heptio/ark/commits{/sha}","git_commits_url":"https://api.github.com/repos/heptio/ark/git/commits{/sha}","comments_url":"https://api.github.com/repos/heptio/ark/comments{/number}","issue_comment_url":"https://api.github.com/repos/heptio/ark/issues/comments{/number}","contents_url":"https://api.github.com/repos/heptio/ark/contents/{+path}","compare_url":"https://api.github.com/repos/heptio/ark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heptio/ark/merges","archive_url":"https://api.github.com/repos/heptio/ark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heptio/ark/downloads","issues_url":"https://api.github.com/repos/heptio/ark/issues{/number}","pulls_url":"https://api.github.com/repos/heptio/ark/pulls{/number}","milestones_url":"https://api.github.com/repos/heptio/ark/milestones{/number}","notifications_url":"https://api.github.com/repos/heptio/ark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heptio/ark/labels{/name}","releases_url":"https://api.github.com/repos/heptio/ark/releases{/id}","deployments_url":"https://api.github.com/repos/heptio/ark/deployments","created_at":"2017-08-02T17:22:11Z","updated_at":"2018-06-12T17:17:25Z","pushed_at":"2018-06-12T17:30:37Z","git_url":"git://github.com/heptio/ark.git","ssh_url":"git@github.com:heptio/ark.git","clone_url":"https://github.com/heptio/ark.git","svn_url":"https://github.com/heptio/ark","homepage":"https://www.heptio.com","size":9310,"stargazers_count":1185,"watchers_count":1185,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":155,"mirror_url":null,"archived":false,"open_issues_count":116,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":155,"open_issues":116,"watchers":1185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heptio/ark/pulls/531"},"html":{"href":"https://github.com/heptio/ark/pull/531"},"issue":{"href":"https://api.github.com/repos/heptio/ark/issues/531"},"comments":{"href":"https://api.github.com/repos/heptio/ark/issues/531/comments"},"review_comments":{"href":"https://api.github.com/repos/heptio/ark/pulls/531/comments"},"review_comment":{"href":"https://api.github.com/repos/heptio/ark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heptio/ark/pulls/531/commits"},"statuses":{"href":"https://api.github.com/repos/heptio/ark/statuses/3378019cdb0e029bb2982c26ad8a08ad58a2b1fb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ashish-amarnath"}}