{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/comments/218612083","pull_request_review_id":156590306,"id":218612083,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODYxMjA4Mw==","diff_hunk":"@@ -751,13 +751,12 @@ Members\n ^^^^^^^\n \n **length**:\n-    Arrays have a ``length`` member to hold their number of elements.\n-    Dynamic arrays can be resized in storage (not in memory) by changing the\n-    ``.length`` member. This does not happen automatically when attempting to access elements outside the current length. The size of memory arrays is fixed (but dynamic, i.e. it can depend on runtime parameters) once they are created.\n+    Fixed-length arrays (storage or memory) have a read-only ``length`` member to access their number of elements.\n+    Dynamically-sized arrays (only available for storage) have a read-write ``length`` member to resize the array. Increasing the length adds uninitialized elements to the array, this has O(1) complexity. Reducing the length performs ``delete`` on each removed element and is O(n) complexity where n is the number of elements being deleted. Please note that calling ``length--`` on an empty array will set the length of the array to 2^256-1 due to uint256 underflow wrapping.\n **push**:\n      Dynamic storage arrays and ``bytes`` (not ``string``) have a member function called ``push`` that can be used to append an element at the end of the array. The function returns the new length.\n **pop**:\n-     Dynamic storage arrays and ``bytes`` (not ``string``) have a member function called ``pop`` that can be used to remove an element from the end of the array.\n+     Dynamic storage arrays and ``bytes`` (not ``string``) have a member function called ``pop`` that can be used to remove an element from the end of the array. This will also implicitly call ``delete`` on the removed element.","path":"docs/types.rst","position":13,"original_position":13,"commit_id":"61286b341a63146b1dd943dae251c38da0280666","original_commit_id":"61286b341a63146b1dd943dae251c38da0280666","user":{"login":"axic","id":20340,"node_id":"MDQ6VXNlcjIwMzQw","avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false},"body":"Do we have a section for documenting delete properly? If so, can you link to it here and above?","created_at":"2018-09-18T22:11:05Z","updated_at":"2018-09-18T22:11:05Z","html_url":"https://github.com/ethereum/solidity/pull/4865#discussion_r218612083","pull_request_url":"https://api.github.com/repos/ethereum/solidity/pulls/4865","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments/218612083"},"html":{"href":"https://github.com/ethereum/solidity/pull/4865#discussion_r218612083"},"pull_request":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4865"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/4865","id":211292716,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjkyNzE2","html_url":"https://github.com/ethereum/solidity/pull/4865","diff_url":"https://github.com/ethereum/solidity/pull/4865.diff","patch_url":"https://github.com/ethereum/solidity/pull/4865.patch","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/4865","number":4865,"state":"open","locked":false,"title":"Document array length changing behaviors","user":{"login":"fulldecent","id":382183,"node_id":"MDQ6VXNlcjM4MjE4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/382183?v=4","gravatar_id":"","url":"https://api.github.com/users/fulldecent","html_url":"https://github.com/fulldecent","followers_url":"https://api.github.com/users/fulldecent/followers","following_url":"https://api.github.com/users/fulldecent/following{/other_user}","gists_url":"https://api.github.com/users/fulldecent/gists{/gist_id}","starred_url":"https://api.github.com/users/fulldecent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fulldecent/subscriptions","organizations_url":"https://api.github.com/users/fulldecent/orgs","repos_url":"https://api.github.com/users/fulldecent/repos","events_url":"https://api.github.com/users/fulldecent/events{/privacy}","received_events_url":"https://api.github.com/users/fulldecent/received_events","type":"User","site_admin":false},"body":"Fixes #4802 \r\n\r\n### Your checklist for this pull request\r\n\r\nPlease review the [guidelines for contributing](http://solidity.readthedocs.io/en/latest/contributing.html) to this repository.\r\n\r\nPlease also note that this project is released with a [Contributor Code of Conduct](CONDUCT.md). By participating in this project you agree to abide by its terms.\r\n\r\n### Checklist\r\n- [ ] Code compiles correctly\r\n- [ ] All tests are passing\r\n- [ ] New tests have been created which fail without the change (if possible)\r\n- [ ] README / documentation was extended, if necessary\r\n- [ ] Changelog entry (if change is visible to the user)\r\n- [x] Used meaningful commit messages\r\n\r\n### Description\r\nPlease explain the changes you made here.\r\n\r\nThank you for your help!\r\n","created_at":"2018-08-28T03:43:21Z","updated_at":"2018-09-18T22:11:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62e1690dcd16127b5b9546283828386d8b6110be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/solidity/pulls/4865/commits","review_comments_url":"https://api.github.com/repos/ethereum/solidity/pulls/4865/comments","review_comment_url":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/4865/comments","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/61286b341a63146b1dd943dae251c38da0280666","head":{"label":"fulldecent:patch-8","ref":"patch-8","sha":"61286b341a63146b1dd943dae251c38da0280666","user":{"login":"fulldecent","id":382183,"node_id":"MDQ6VXNlcjM4MjE4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/382183?v=4","gravatar_id":"","url":"https://api.github.com/users/fulldecent","html_url":"https://github.com/fulldecent","followers_url":"https://api.github.com/users/fulldecent/followers","following_url":"https://api.github.com/users/fulldecent/following{/other_user}","gists_url":"https://api.github.com/users/fulldecent/gists{/gist_id}","starred_url":"https://api.github.com/users/fulldecent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fulldecent/subscriptions","organizations_url":"https://api.github.com/users/fulldecent/orgs","repos_url":"https://api.github.com/users/fulldecent/repos","events_url":"https://api.github.com/users/fulldecent/events{/privacy}","received_events_url":"https://api.github.com/users/fulldecent/received_events","type":"User","site_admin":false},"repo":{"id":115385083,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUzODUwODM=","name":"solidity","full_name":"fulldecent/solidity","private":false,"owner":{"login":"fulldecent","id":382183,"node_id":"MDQ6VXNlcjM4MjE4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/382183?v=4","gravatar_id":"","url":"https://api.github.com/users/fulldecent","html_url":"https://github.com/fulldecent","followers_url":"https://api.github.com/users/fulldecent/followers","following_url":"https://api.github.com/users/fulldecent/following{/other_user}","gists_url":"https://api.github.com/users/fulldecent/gists{/gist_id}","starred_url":"https://api.github.com/users/fulldecent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fulldecent/subscriptions","organizations_url":"https://api.github.com/users/fulldecent/orgs","repos_url":"https://api.github.com/users/fulldecent/repos","events_url":"https://api.github.com/users/fulldecent/events{/privacy}","received_events_url":"https://api.github.com/users/fulldecent/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fulldecent/solidity","description":"The Solidity Contract-Oriented Programming Language","fork":true,"url":"https://api.github.com/repos/fulldecent/solidity","forks_url":"https://api.github.com/repos/fulldecent/solidity/forks","keys_url":"https://api.github.com/repos/fulldecent/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fulldecent/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fulldecent/solidity/teams","hooks_url":"https://api.github.com/repos/fulldecent/solidity/hooks","issue_events_url":"https://api.github.com/repos/fulldecent/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/fulldecent/solidity/events","assignees_url":"https://api.github.com/repos/fulldecent/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/fulldecent/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/fulldecent/solidity/tags","blobs_url":"https://api.github.com/repos/fulldecent/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fulldecent/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fulldecent/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/fulldecent/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fulldecent/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/fulldecent/solidity/languages","stargazers_url":"https://api.github.com/repos/fulldecent/solidity/stargazers","contributors_url":"https://api.github.com/repos/fulldecent/solidity/contributors","subscribers_url":"https://api.github.com/repos/fulldecent/solidity/subscribers","subscription_url":"https://api.github.com/repos/fulldecent/solidity/subscription","commits_url":"https://api.github.com/repos/fulldecent/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/fulldecent/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/fulldecent/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/fulldecent/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/fulldecent/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/fulldecent/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fulldecent/solidity/merges","archive_url":"https://api.github.com/repos/fulldecent/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fulldecent/solidity/downloads","issues_url":"https://api.github.com/repos/fulldecent/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/fulldecent/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/fulldecent/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/fulldecent/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fulldecent/solidity/labels{/name}","releases_url":"https://api.github.com/repos/fulldecent/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/fulldecent/solidity/deployments","created_at":"2017-12-26T04:22:06Z","updated_at":"2017-12-26T04:22:10Z","pushed_at":"2018-09-06T02:37:39Z","git_url":"git://github.com/fulldecent/solidity.git","ssh_url":"git@github.com:fulldecent/solidity.git","clone_url":"https://github.com/fulldecent/solidity.git","svn_url":"https://github.com/fulldecent/solidity","homepage":"","size":22680,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"410d288dfc2e08c42df58c7e01ad5c332ce92727","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"node_id":"MDEwOlJlcG9zaXRvcnk0MDg5MjgxNw==","name":"solidity","full_name":"ethereum/solidity","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/solidity","description":"Solidity, the Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2018-09-18T20:23:43Z","pushed_at":"2018-09-18T20:38:13Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"https://solidity.readthedocs.io","size":23118,"stargazers_count":5974,"watchers_count":5974,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1589,"mirror_url":null,"archived":false,"open_issues_count":595,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1589,"open_issues":595,"watchers":5974,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4865"},"html":{"href":"https://github.com/ethereum/solidity/pull/4865"},"issue":{"href":"https://api.github.com/repos/ethereum/solidity/issues/4865"},"comments":{"href":"https://api.github.com/repos/ethereum/solidity/issues/4865/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4865/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4865/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/solidity/statuses/61286b341a63146b1dd943dae251c38da0280666"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"axic"}}