{"action":"created","comment":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/185669647","pull_request_review_id":117106062,"id":185669647,"diff_hunk":"@@ -313,11 +313,7 @@ if(NOT LLVM_FOUND)\n else()\n \tadd_definitions(${LLVM_DEFINITIONS})\n \tadd_definitions(-DLLVM_AVAILABLE)\n-\tif(CMAKE_BUILD_TYPE STREQUAL \"Release\")\n-\t\tllvm_map_components_to_libnames(LLVM_LIBS core support executionengine object runtimedyld x86desc x86info scalaropts mcjit vectorize ipo x86codegen x86disassembler)\n-\telse()\n-\t\tllvm_map_components_to_libnames(LLVM_LIBS core support executionengine object runtimedyld x86desc x86info scalaropts mcjit vectorize ipo x86codegen x86disassembler mcdisassembler)\n-\tendif()\n+\tset(LLVM_LIBS LLVMMCJIT LLVMX86CodeGen)","path":"rpcs3/CMakeLists.txt","position":18,"original_position":18,"commit_id":"72a8400476abbeb2ded4e261645b4254672dd6b1","original_commit_id":"72a8400476abbeb2ded4e261645b4254672dd6b1","user":{"login":"Orphis","id":300430,"avatar_url":"https://avatars1.githubusercontent.com/u/300430?v=4","gravatar_id":"","url":"https://api.github.com/users/Orphis","html_url":"https://github.com/Orphis","followers_url":"https://api.github.com/users/Orphis/followers","following_url":"https://api.github.com/users/Orphis/following{/other_user}","gists_url":"https://api.github.com/users/Orphis/gists{/gist_id}","starred_url":"https://api.github.com/users/Orphis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orphis/subscriptions","organizations_url":"https://api.github.com/users/Orphis/orgs","repos_url":"https://api.github.com/users/Orphis/repos","events_url":"https://api.github.com/users/Orphis/events{/privacy}","received_events_url":"https://api.github.com/users/Orphis/received_events","type":"User","site_admin":false},"body":"It's the name of the target, not the name of the build artifact. Target names are stable.","created_at":"2018-05-02T23:45:03Z","updated_at":"2018-05-02T23:45:03Z","html_url":"https://github.com/RPCS3/rpcs3/pull/4507#discussion_r185669647","pull_request_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4507","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/185669647"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/4507#discussion_r185669647"},"pull_request":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4507"}},"in_reply_to_id":185483895},"pull_request":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4507","id":185299740,"html_url":"https://github.com/RPCS3/rpcs3/pull/4507","diff_url":"https://github.com/RPCS3/rpcs3/pull/4507.diff","patch_url":"https://github.com/RPCS3/rpcs3/pull/4507.patch","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/4507","number":4507,"state":"open","locked":false,"title":"CMake build optimization","user":{"login":"Orphis","id":300430,"avatar_url":"https://avatars1.githubusercontent.com/u/300430?v=4","gravatar_id":"","url":"https://api.github.com/users/Orphis","html_url":"https://github.com/Orphis","followers_url":"https://api.github.com/users/Orphis/followers","following_url":"https://api.github.com/users/Orphis/following{/other_user}","gists_url":"https://api.github.com/users/Orphis/gists{/gist_id}","starred_url":"https://api.github.com/users/Orphis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orphis/subscriptions","organizations_url":"https://api.github.com/users/Orphis/orgs","repos_url":"https://api.github.com/users/Orphis/repos","events_url":"https://api.github.com/users/Orphis/events{/privacy}","received_events_url":"https://api.github.com/users/Orphis/received_events","type":"User","site_admin":false},"body":"Marks all the 3rd party dependencies with EXCLUDE_FROM_ALL, so they will only be built if requested.\r\nLinks only against the main top level LLVM targets, which avoids linking against unneeded LLVM targets.\r\n\r\nThose 2 changes make the full build (with LLVM) compile about 20% less files.","created_at":"2018-05-01T23:17:35Z","updated_at":"2018-05-02T23:45:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15c89470d9bf03658b1165d29ebb984b43917188","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4507/commits","review_comments_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4507/comments","review_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/4507/comments","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/72a8400476abbeb2ded4e261645b4254672dd6b1","head":{"label":"Orphis:build_optimization","ref":"build_optimization","sha":"72a8400476abbeb2ded4e261645b4254672dd6b1","user":{"login":"Orphis","id":300430,"avatar_url":"https://avatars1.githubusercontent.com/u/300430?v=4","gravatar_id":"","url":"https://api.github.com/users/Orphis","html_url":"https://github.com/Orphis","followers_url":"https://api.github.com/users/Orphis/followers","following_url":"https://api.github.com/users/Orphis/following{/other_user}","gists_url":"https://api.github.com/users/Orphis/gists{/gist_id}","starred_url":"https://api.github.com/users/Orphis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orphis/subscriptions","organizations_url":"https://api.github.com/users/Orphis/orgs","repos_url":"https://api.github.com/users/Orphis/repos","events_url":"https://api.github.com/users/Orphis/events{/privacy}","received_events_url":"https://api.github.com/users/Orphis/received_events","type":"User","site_admin":false},"repo":{"id":131759628,"name":"rpcs3","full_name":"Orphis/rpcs3","owner":{"login":"Orphis","id":300430,"avatar_url":"https://avatars1.githubusercontent.com/u/300430?v=4","gravatar_id":"","url":"https://api.github.com/users/Orphis","html_url":"https://github.com/Orphis","followers_url":"https://api.github.com/users/Orphis/followers","following_url":"https://api.github.com/users/Orphis/following{/other_user}","gists_url":"https://api.github.com/users/Orphis/gists{/gist_id}","starred_url":"https://api.github.com/users/Orphis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orphis/subscriptions","organizations_url":"https://api.github.com/users/Orphis/orgs","repos_url":"https://api.github.com/users/Orphis/repos","events_url":"https://api.github.com/users/Orphis/events{/privacy}","received_events_url":"https://api.github.com/users/Orphis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Orphis/rpcs3","description":"PS3 emulator/debugger","fork":true,"url":"https://api.github.com/repos/Orphis/rpcs3","forks_url":"https://api.github.com/repos/Orphis/rpcs3/forks","keys_url":"https://api.github.com/repos/Orphis/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Orphis/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Orphis/rpcs3/teams","hooks_url":"https://api.github.com/repos/Orphis/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/Orphis/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/Orphis/rpcs3/events","assignees_url":"https://api.github.com/repos/Orphis/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/Orphis/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/Orphis/rpcs3/tags","blobs_url":"https://api.github.com/repos/Orphis/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Orphis/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Orphis/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Orphis/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Orphis/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/Orphis/rpcs3/languages","stargazers_url":"https://api.github.com/repos/Orphis/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/Orphis/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/Orphis/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/Orphis/rpcs3/subscription","commits_url":"https://api.github.com/repos/Orphis/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Orphis/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Orphis/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Orphis/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Orphis/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/Orphis/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Orphis/rpcs3/merges","archive_url":"https://api.github.com/repos/Orphis/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Orphis/rpcs3/downloads","issues_url":"https://api.github.com/repos/Orphis/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/Orphis/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/Orphis/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/Orphis/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Orphis/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/Orphis/rpcs3/releases{/id}","deployments_url":"https://api.github.com/repos/Orphis/rpcs3/deployments","created_at":"2018-05-01T20:26:34Z","updated_at":"2018-05-01T20:26:39Z","pushed_at":"2018-05-01T23:15:22Z","git_url":"git://github.com/Orphis/rpcs3.git","ssh_url":"git@github.com:Orphis/rpcs3.git","clone_url":"https://github.com/Orphis/rpcs3.git","svn_url":"https://github.com/Orphis/rpcs3","homepage":"https://rpcs3.net/","size":49159,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RPCS3:master","ref":"master","sha":"25ec899cfe2ff656da4384bed8656d5ff5c75b45","user":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars3.githubusercontent.com/u/8070735?v=4","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"repo":{"id":6520784,"name":"rpcs3","full_name":"RPCS3/rpcs3","owner":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars3.githubusercontent.com/u/8070735?v=4","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RPCS3/rpcs3","description":"PS3 emulator/debugger","fork":false,"url":"https://api.github.com/repos/RPCS3/rpcs3","forks_url":"https://api.github.com/repos/RPCS3/rpcs3/forks","keys_url":"https://api.github.com/repos/RPCS3/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RPCS3/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RPCS3/rpcs3/teams","hooks_url":"https://api.github.com/repos/RPCS3/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/RPCS3/rpcs3/events","assignees_url":"https://api.github.com/repos/RPCS3/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/RPCS3/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/RPCS3/rpcs3/tags","blobs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RPCS3/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/RPCS3/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/RPCS3/rpcs3/languages","stargazers_url":"https://api.github.com/repos/RPCS3/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/RPCS3/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/RPCS3/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/RPCS3/rpcs3/subscription","commits_url":"https://api.github.com/repos/RPCS3/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/RPCS3/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/RPCS3/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/RPCS3/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RPCS3/rpcs3/merges","archive_url":"https://api.github.com/repos/RPCS3/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RPCS3/rpcs3/downloads","issues_url":"https://api.github.com/repos/RPCS3/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/RPCS3/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/RPCS3/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/RPCS3/rpcs3/releases{/id}","deployments_url":"https://api.github.com/repos/RPCS3/rpcs3/deployments","created_at":"2012-11-03T15:16:18Z","updated_at":"2018-05-02T20:26:24Z","pushed_at":"2018-05-02T23:36:43Z","git_url":"git://github.com/RPCS3/rpcs3.git","ssh_url":"git@github.com:RPCS3/rpcs3.git","clone_url":"https://github.com/RPCS3/rpcs3.git","svn_url":"https://github.com/RPCS3/rpcs3","homepage":"https://rpcs3.net/","size":49157,"stargazers_count":4872,"watchers_count":4872,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":893,"mirror_url":null,"archived":false,"open_issues_count":333,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":893,"open_issues":333,"watchers":4872,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4507"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/4507"},"issue":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/4507"},"comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/4507/comments"},"review_comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4507/comments"},"review_comment":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/4507/commits"},"statuses":{"href":"https://api.github.com/repos/RPCS3/rpcs3/statuses/72a8400476abbeb2ded4e261645b4254672dd6b1"}},"author_association":"NONE"}}
{"actor":{"display_login":"Orphis"}}