{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/170713984","pull_request_review_id":99440578,"id":170713984,"diff_hunk":"@@ -276,15 +276,13 @@ public void shouldThrowOnUnassignedStateStoreAccess() throws Exception {\n \n         try {\n             new ProcessorTopologyTestDriver(streamsConfig, topology.internalTopologyBuilder);\n+            fail(\"Should have thrown StreamsException\");\n         } catch (final StreamsException e) {\n-            final Throwable cause = e.getCause();\n-            if (cause != null\n-                && cause instanceof TopologyBuilderException\n-                && cause.getMessage().equals(\"Invalid topology building: Processor \" + badNodeName + \" has no access to StateStore \" + LocalMockProcessorSupplier.STORE_NAME)) {\n-                throw (TopologyBuilderException) cause;\n-            } else {\n-                throw new RuntimeException(\"Did expect different exception. Did catch:\", e);\n-            }\n+            final String error = e.getCause().toString();\n+            final String expectedMessage = \"Processor \" + badNodeName + \" has no access to StateStore \" +\n+                    LocalMockProcessorSupplier.STORE_NAME;\n+            \n+            assertTrue(error.contains(expectedMessage));","path":"streams/src/test/java/org/apache/kafka/streams/TopologyTest.java","position":43,"original_position":43,"commit_id":"8d624df3f179f5eb5afd3bfd7d91c4119860adb4","original_commit_id":"8d624df3f179f5eb5afd3bfd7d91c4119860adb4","user":{"login":"mjsax","id":8959638,"avatar_url":"https://avatars1.githubusercontent.com/u/8959638?v=4","gravatar_id":"","url":"https://api.github.com/users/mjsax","html_url":"https://github.com/mjsax","followers_url":"https://api.github.com/users/mjsax/followers","following_url":"https://api.github.com/users/mjsax/following{/other_user}","gists_url":"https://api.github.com/users/mjsax/gists{/gist_id}","starred_url":"https://api.github.com/users/mjsax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjsax/subscriptions","organizations_url":"https://api.github.com/users/mjsax/orgs","repos_url":"https://api.github.com/users/mjsax/repos","events_url":"https://api.github.com/users/mjsax/events{/privacy}","received_events_url":"https://api.github.com/users/mjsax/received_events","type":"User","site_admin":false},"body":"Why not `assertEquals` ?","created_at":"2018-02-26T19:49:13Z","updated_at":"2018-02-26T19:52:33Z","html_url":"https://github.com/apache/kafka/pull/4605#discussion_r170713984","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/4605","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/170713984"},"html":{"href":"https://github.com/apache/kafka/pull/4605#discussion_r170713984"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/4605"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/4605","id":170331282,"html_url":"https://github.com/apache/kafka/pull/4605","diff_url":"https://github.com/apache/kafka/pull/4605.diff","patch_url":"https://github.com/apache/kafka/pull/4605.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/4605","number":4605,"state":"open","locked":false,"title":"KAFKA-5660: Don't throw TopologyBuilderException during runtime","user":{"login":"nafshartous","id":10177239,"avatar_url":"https://avatars3.githubusercontent.com/u/10177239?v=4","gravatar_id":"","url":"https://api.github.com/users/nafshartous","html_url":"https://github.com/nafshartous","followers_url":"https://api.github.com/users/nafshartous/followers","following_url":"https://api.github.com/users/nafshartous/following{/other_user}","gists_url":"https://api.github.com/users/nafshartous/gists{/gist_id}","starred_url":"https://api.github.com/users/nafshartous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nafshartous/subscriptions","organizations_url":"https://api.github.com/users/nafshartous/orgs","repos_url":"https://api.github.com/users/nafshartous/repos","events_url":"https://api.github.com/users/nafshartous/events{/privacy}","received_events_url":"https://api.github.com/users/nafshartous/received_events","type":"User","site_admin":false},"body":"\r\nTopologyBuilderException is a pre-runtime exception that should only be thrown before KafkaStreams#start() is called.","created_at":"2018-02-20T22:49:49Z","updated_at":"2018-02-26T19:52:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0604d648dd95911b37caced29707c2d3e0fbbe6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dguy","id":54829,"avatar_url":"https://avatars2.githubusercontent.com/u/54829?v=4","gravatar_id":"","url":"https://api.github.com/users/dguy","html_url":"https://github.com/dguy","followers_url":"https://api.github.com/users/dguy/followers","following_url":"https://api.github.com/users/dguy/following{/other_user}","gists_url":"https://api.github.com/users/dguy/gists{/gist_id}","starred_url":"https://api.github.com/users/dguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguy/subscriptions","organizations_url":"https://api.github.com/users/dguy/orgs","repos_url":"https://api.github.com/users/dguy/repos","events_url":"https://api.github.com/users/dguy/events{/privacy}","received_events_url":"https://api.github.com/users/dguy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":820747028,"url":"https://api.github.com/repos/apache/kafka/labels/streams","name":"streams","color":"63edea","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/4605/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/4605/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/4605/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/8d624df3f179f5eb5afd3bfd7d91c4119860adb4","head":{"label":"nafshartous:KAFKA-5660","ref":"KAFKA-5660","sha":"8d624df3f179f5eb5afd3bfd7d91c4119860adb4","user":{"login":"nafshartous","id":10177239,"avatar_url":"https://avatars3.githubusercontent.com/u/10177239?v=4","gravatar_id":"","url":"https://api.github.com/users/nafshartous","html_url":"https://github.com/nafshartous","followers_url":"https://api.github.com/users/nafshartous/followers","following_url":"https://api.github.com/users/nafshartous/following{/other_user}","gists_url":"https://api.github.com/users/nafshartous/gists{/gist_id}","starred_url":"https://api.github.com/users/nafshartous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nafshartous/subscriptions","organizations_url":"https://api.github.com/users/nafshartous/orgs","repos_url":"https://api.github.com/users/nafshartous/repos","events_url":"https://api.github.com/users/nafshartous/events{/privacy}","received_events_url":"https://api.github.com/users/nafshartous/received_events","type":"User","site_admin":false},"repo":{"id":121673895,"name":"kafka","full_name":"nafshartous/kafka","owner":{"login":"nafshartous","id":10177239,"avatar_url":"https://avatars3.githubusercontent.com/u/10177239?v=4","gravatar_id":"","url":"https://api.github.com/users/nafshartous","html_url":"https://github.com/nafshartous","followers_url":"https://api.github.com/users/nafshartous/followers","following_url":"https://api.github.com/users/nafshartous/following{/other_user}","gists_url":"https://api.github.com/users/nafshartous/gists{/gist_id}","starred_url":"https://api.github.com/users/nafshartous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nafshartous/subscriptions","organizations_url":"https://api.github.com/users/nafshartous/orgs","repos_url":"https://api.github.com/users/nafshartous/repos","events_url":"https://api.github.com/users/nafshartous/events{/privacy}","received_events_url":"https://api.github.com/users/nafshartous/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nafshartous/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/nafshartous/kafka","forks_url":"https://api.github.com/repos/nafshartous/kafka/forks","keys_url":"https://api.github.com/repos/nafshartous/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nafshartous/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nafshartous/kafka/teams","hooks_url":"https://api.github.com/repos/nafshartous/kafka/hooks","issue_events_url":"https://api.github.com/repos/nafshartous/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/nafshartous/kafka/events","assignees_url":"https://api.github.com/repos/nafshartous/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/nafshartous/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/nafshartous/kafka/tags","blobs_url":"https://api.github.com/repos/nafshartous/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nafshartous/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nafshartous/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/nafshartous/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nafshartous/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/nafshartous/kafka/languages","stargazers_url":"https://api.github.com/repos/nafshartous/kafka/stargazers","contributors_url":"https://api.github.com/repos/nafshartous/kafka/contributors","subscribers_url":"https://api.github.com/repos/nafshartous/kafka/subscribers","subscription_url":"https://api.github.com/repos/nafshartous/kafka/subscription","commits_url":"https://api.github.com/repos/nafshartous/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/nafshartous/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/nafshartous/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/nafshartous/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/nafshartous/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/nafshartous/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nafshartous/kafka/merges","archive_url":"https://api.github.com/repos/nafshartous/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nafshartous/kafka/downloads","issues_url":"https://api.github.com/repos/nafshartous/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/nafshartous/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/nafshartous/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/nafshartous/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nafshartous/kafka/labels{/name}","releases_url":"https://api.github.com/repos/nafshartous/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/nafshartous/kafka/deployments","created_at":"2018-02-15T19:41:25Z","updated_at":"2018-02-15T19:41:36Z","pushed_at":"2018-02-25T22:26:34Z","git_url":"git://github.com/nafshartous/kafka.git","ssh_url":"git@github.com:nafshartous/kafka.git","clone_url":"https://github.com/nafshartous/kafka.git","svn_url":"https://github.com/nafshartous/kafka","homepage":null,"size":63141,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"75df8cc77adc61746b3abd0e48d2c7a343e805f6","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-02-26T10:45:11Z","pushed_at":"2018-02-26T19:38:52Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":63325,"stargazers_count":7497,"watchers_count":7497,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4492,"mirror_url":null,"archived":false,"open_issues_count":400,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4492,"open_issues":400,"watchers":7497,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/4605"},"html":{"href":"https://github.com/apache/kafka/pull/4605"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/4605"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/4605/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/4605/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/4605/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/8d624df3f179f5eb5afd3bfd7d91c4119860adb4"}},"author_association":"NONE"}}
{"actor":{"display_login":"mjsax"}}