{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/175216866","pull_request_review_id":104720948,"id":175216866,"diff_hunk":"@@ -22,6 +22,26 @@\n namespace Envoy {\n namespace Upstream {\n \n+/**\n+ * ClusterUpdateCallbacks provide a way to exposes Cluster lifecycle event in the\n+ * ClusterManager.\n+ */\n+class ClusterUpdateCallbacks {\n+public:\n+  virtual ~ClusterUpdateCallbacks() {}\n+\n+  /**\n+   * onClusterAddOrUpdate is called when a new cluster is added or an existing cluster\n+   * is updated in the ClusterManager.","path":"include/envoy/upstream/cluster_manager.h","position":14,"original_position":14,"commit_id":"fe53d550d66fa516849bae0a959405c72f3ea4f8","original_commit_id":"792d6efb4f1eac614b7604140e35c972cb56d6de","user":{"login":"nt","id":212786,"avatar_url":"https://avatars3.githubusercontent.com/u/212786?v=4","gravatar_id":"","url":"https://api.github.com/users/nt","html_url":"https://github.com/nt","followers_url":"https://api.github.com/users/nt/followers","following_url":"https://api.github.com/users/nt/following{/other_user}","gists_url":"https://api.github.com/users/nt/gists{/gist_id}","starred_url":"https://api.github.com/users/nt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nt/subscriptions","organizations_url":"https://api.github.com/users/nt/orgs","repos_url":"https://api.github.com/users/nt/repos","events_url":"https://api.github.com/users/nt/events{/privacy}","received_events_url":"https://api.github.com/users/nt/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-03-16T21:19:13Z","updated_at":"2018-03-16T21:19:13Z","html_url":"https://github.com/envoyproxy/envoy/pull/2814#discussion_r175216866","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2814","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/175216866"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/2814#discussion_r175216866"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2814"}},"in_reply_to_id":175150521},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2814","id":175111630,"html_url":"https://github.com/envoyproxy/envoy/pull/2814","diff_url":"https://github.com/envoyproxy/envoy/pull/2814.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/2814.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2814","number":2814,"state":"open","locked":false,"title":"Add cluster update callbacks","user":{"login":"nt","id":212786,"avatar_url":"https://avatars3.githubusercontent.com/u/212786?v=4","gravatar_id":"","url":"https://api.github.com/users/nt","html_url":"https://github.com/nt","followers_url":"https://api.github.com/users/nt/followers","following_url":"https://api.github.com/users/nt/following{/other_user}","gists_url":"https://api.github.com/users/nt/gists{/gist_id}","starred_url":"https://api.github.com/users/nt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nt/subscriptions","organizations_url":"https://api.github.com/users/nt/orgs","repos_url":"https://api.github.com/users/nt/repos","events_url":"https://api.github.com/users/nt/events{/privacy}","received_events_url":"https://api.github.com/users/nt/received_events","type":"User","site_admin":false},"body":"This change allows filters to subscribe to Cluster lifecycle events.\r\n\r\nRisk Level: Low","created_at":"2018-03-14T23:25:09Z","updated_at":"2018-03-16T21:19:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac04c4b6c7b0d33db779fa8c9e3bb8c73cbec7f2","assignee":{"login":"mattklein123","id":6305260,"avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattklein123","id":6305260,"avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2814/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2814/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2814/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/fe53d550d66fa516849bae0a959405c72f3ea4f8","head":{"label":"nt:cluster-callbacks","ref":"cluster-callbacks","sha":"fe53d550d66fa516849bae0a959405c72f3ea4f8","user":{"login":"nt","id":212786,"avatar_url":"https://avatars3.githubusercontent.com/u/212786?v=4","gravatar_id":"","url":"https://api.github.com/users/nt","html_url":"https://github.com/nt","followers_url":"https://api.github.com/users/nt/followers","following_url":"https://api.github.com/users/nt/following{/other_user}","gists_url":"https://api.github.com/users/nt/gists{/gist_id}","starred_url":"https://api.github.com/users/nt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nt/subscriptions","organizations_url":"https://api.github.com/users/nt/orgs","repos_url":"https://api.github.com/users/nt/repos","events_url":"https://api.github.com/users/nt/events{/privacy}","received_events_url":"https://api.github.com/users/nt/received_events","type":"User","site_admin":false},"repo":{"id":119728981,"name":"envoy","full_name":"nt/envoy","owner":{"login":"nt","id":212786,"avatar_url":"https://avatars3.githubusercontent.com/u/212786?v=4","gravatar_id":"","url":"https://api.github.com/users/nt","html_url":"https://github.com/nt","followers_url":"https://api.github.com/users/nt/followers","following_url":"https://api.github.com/users/nt/following{/other_user}","gists_url":"https://api.github.com/users/nt/gists{/gist_id}","starred_url":"https://api.github.com/users/nt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nt/subscriptions","organizations_url":"https://api.github.com/users/nt/orgs","repos_url":"https://api.github.com/users/nt/repos","events_url":"https://api.github.com/users/nt/events{/privacy}","received_events_url":"https://api.github.com/users/nt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nt/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/nt/envoy","forks_url":"https://api.github.com/repos/nt/envoy/forks","keys_url":"https://api.github.com/repos/nt/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nt/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nt/envoy/teams","hooks_url":"https://api.github.com/repos/nt/envoy/hooks","issue_events_url":"https://api.github.com/repos/nt/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/nt/envoy/events","assignees_url":"https://api.github.com/repos/nt/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/nt/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/nt/envoy/tags","blobs_url":"https://api.github.com/repos/nt/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nt/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nt/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/nt/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nt/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/nt/envoy/languages","stargazers_url":"https://api.github.com/repos/nt/envoy/stargazers","contributors_url":"https://api.github.com/repos/nt/envoy/contributors","subscribers_url":"https://api.github.com/repos/nt/envoy/subscribers","subscription_url":"https://api.github.com/repos/nt/envoy/subscription","commits_url":"https://api.github.com/repos/nt/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/nt/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/nt/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/nt/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/nt/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/nt/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nt/envoy/merges","archive_url":"https://api.github.com/repos/nt/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nt/envoy/downloads","issues_url":"https://api.github.com/repos/nt/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/nt/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/nt/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/nt/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nt/envoy/labels{/name}","releases_url":"https://api.github.com/repos/nt/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/nt/envoy/deployments","created_at":"2018-01-31T18:51:33Z","updated_at":"2018-03-14T23:03:16Z","pushed_at":"2018-03-16T21:18:32Z","git_url":"git://github.com/nt/envoy.git","ssh_url":"git@github.com:nt/envoy.git","clone_url":"https://github.com/nt/envoy.git","svn_url":"https://github.com/nt/envoy","homepage":"https://envoyproxy.github.io/","size":54303,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"f539082c6be18c341d82d0c4aa024c293b939e9c","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-03-16T19:48:34Z","pushed_at":"2018-03-16T21:18:36Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://envoyproxy.github.io/","size":12894,"stargazers_count":4188,"watchers_count":4188,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":518,"mirror_url":null,"archived":false,"open_issues_count":268,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":518,"open_issues":268,"watchers":4188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2814"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/2814"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/2814"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/2814/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2814/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/2814/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/fe53d550d66fa516849bae0a959405c72f3ea4f8"}},"author_association":"NONE"}}
{"actor":{"display_login":"nt"}}