{"action":"created","issue":{"url":"https://api.github.com/repos/bromite/bromite/issues/114","repository_url":"https://api.github.com/repos/bromite/bromite","labels_url":"https://api.github.com/repos/bromite/bromite/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/bromite/bromite/issues/114/comments","events_url":"https://api.github.com/repos/bromite/bromite/issues/114/events","html_url":"https://github.com/bromite/bromite/issues/114","id":353983365,"node_id":"MDU6SXNzdWUzNTM5ODMzNjU=","number":114,"title":"Help to generate adblock_entries.h","user":{"login":"pceiley","id":1720468,"node_id":"MDQ6VXNlcjE3MjA0Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/1720468?v=4","gravatar_id":"","url":"https://api.github.com/users/pceiley","html_url":"https://github.com/pceiley","followers_url":"https://api.github.com/users/pceiley/followers","following_url":"https://api.github.com/users/pceiley/following{/other_user}","gists_url":"https://api.github.com/users/pceiley/gists{/gist_id}","starred_url":"https://api.github.com/users/pceiley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pceiley/subscriptions","organizations_url":"https://api.github.com/users/pceiley/orgs","repos_url":"https://api.github.com/users/pceiley/repos","events_url":"https://api.github.com/users/pceiley/events{/privacy}","received_events_url":"https://api.github.com/users/pceiley/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-25T04:44:43Z","updated_at":"2018-12-17T20:11:34Z","closed_at":"2018-08-25T12:50:38Z","author_association":"NONE","body":"**Is your feature request related to privacy?**\r\nIndirectly\r\n\r\n**Is there a patch available for this feature somewhere?**\r\nNo\r\n\r\n**Describe the solution you'd like**\r\nAre you able to share scripts or code in order to generate the adblock_entries.h file?\r\n\r\n**Describe alternatives you've considered**\r\nI'm toying with a project at the moment using your adblock engine - but I'd like to adapt it with a different set of filters.  It would save me some time if you could share your code/method to generate the file?\r\n"},"comment":{"url":"https://api.github.com/repos/bromite/bromite/issues/comments/447982286","html_url":"https://github.com/bromite/bromite/issues/114#issuecomment-447982286","issue_url":"https://api.github.com/repos/bromite/bromite/issues/114","id":447982286,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzk4MjI4Ng==","user":{"login":"csagan5","id":32685696,"node_id":"MDQ6VXNlcjMyNjg1Njk2","avatar_url":"https://avatars0.githubusercontent.com/u/32685696?v=4","gravatar_id":"","url":"https://api.github.com/users/csagan5","html_url":"https://github.com/csagan5","followers_url":"https://api.github.com/users/csagan5/followers","following_url":"https://api.github.com/users/csagan5/following{/other_user}","gists_url":"https://api.github.com/users/csagan5/gists{/gist_id}","starred_url":"https://api.github.com/users/csagan5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csagan5/subscriptions","organizations_url":"https://api.github.com/users/csagan5/orgs","repos_url":"https://api.github.com/users/csagan5/repos","events_url":"https://api.github.com/users/csagan5/events{/privacy}","received_events_url":"https://api.github.com/users/csagan5/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T20:11:34Z","updated_at":"2018-12-17T20:11:34Z","author_association":"CONTRIBUTOR","body":"> @csagan5 appreciate it the fast answer. Adding that explanation to the README would be beneficial for users like myself -- I literally was opening every issue (opened/closed) to find one with appropriate comments to reply to.\r\n\r\nI am sorry for the struggle; this is the current build section of the README: https://github.com/bromite/bromite#how-to-build\r\n\r\n> # How to build\r\n> \r\n> The [Bromite main repository](https://github.com/bromite/bromite) contains tags for each corresponding Chromium release (see https://chromium.googlesource.com/chromium/src.git).\r\n> \r\n> Please refer to [official Chromium build documentation](https://www.chromium.org/developers/how-tos/get-the-code) to get started on how to build Chromium; if you can build Chromium for Android, you can build Bromite.\r\n> \r\n\r\nHow would you change it? You can also make a PR and I will adjust it as needed. I will mention the GN flags after starting to publish them.\r\n\r\n> Here's an image from that issue, the left is pre-MD refresh and what my patch reverts the UI to and the right is the current UI:\r\n>\r\n\r\nI had noticed this change but I thought it was an Android change; I have read on the upstream issue that you have tried to dig more into it. It indeed looks ugly (and Matt Damon in there as well, but I digress).\r\n\r\n> I hadn't planned on making a pull request per [Can you add dark mode/some cool themes](https://github.com/bromite/bromite/blob/master/README.md#can-you-add-dark-modesome-cool-themes). I could argue the patch is not just UI related, but performance related for users with an AMOLED screen -- but what I understood from that section of the README is that you are only interested in privacy and ad-block related patches, so I wasn't even going to bother\r\n\r\nThat F.A.Q. is to (try to) avoid the off-topic feature requests, but generally I have said in the past (XDA forums, reddit) that the biggest problem with non-privacy patches is that I would not have interest/commitment to maintain them.\r\n\r\nIf you can submit a patch that builds against v71 and does not cause issues I will be glad to integrate it; I will even try to port it to v72 when the time comes and then eventually notify you if it does not.\r\n\r\nNow we have officially gone off-topic for this issue :blush: please open a separate issue and/or PR if you wish to proceed with the submission; the part about improving the README we can keep discussing here."}}
{"actor":{"display_login":"csagan5"}}