{"action":"closed","number":11167,"pull_request":{"url":"https://api.github.com/repos/keras-team/keras/pulls/11167","id":215941464,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTQxNDY0","html_url":"https://github.com/keras-team/keras/pull/11167","diff_url":"https://github.com/keras-team/keras/pull/11167.diff","patch_url":"https://github.com/keras-team/keras/pull/11167.patch","issue_url":"https://api.github.com/repos/keras-team/keras/issues/11167","number":11167,"state":"closed","locked":false,"title":"Grouped common function calls together in the test_callbacks.py.","user":{"login":"gabrieldemarmiesse","id":12891691,"node_id":"MDQ6VXNlcjEyODkxNjkx","avatar_url":"https://avatars1.githubusercontent.com/u/12891691?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrieldemarmiesse","html_url":"https://github.com/gabrieldemarmiesse","followers_url":"https://api.github.com/users/gabrieldemarmiesse/followers","following_url":"https://api.github.com/users/gabrieldemarmiesse/following{/other_user}","gists_url":"https://api.github.com/users/gabrieldemarmiesse/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrieldemarmiesse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrieldemarmiesse/subscriptions","organizations_url":"https://api.github.com/users/gabrieldemarmiesse/orgs","repos_url":"https://api.github.com/users/gabrieldemarmiesse/repos","events_url":"https://api.github.com/users/gabrieldemarmiesse/events{/privacy}","received_events_url":"https://api.github.com/users/gabrieldemarmiesse/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\nReaders expect frequent patterns to be defaults when calling functions. Reading though `test_callbacks.py` isn't easy because one have to check all the arguments of `get_test_data` every time to check that something out of the ordinary isn't there.\r\nThis PR allows the reader to quickly know what differs from one test to another. I think it improves readability.\r\n\r\n### Related Issues\r\n\r\n### PR Overview\r\n\r\n- [ ] This PR requires new unit tests [y/n] (make sure tests are included)\r\n- [ ] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)\r\n- [x] This PR is backwards compatible [y/n]\r\n- [ ] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)\r\n","created_at":"2018-09-17T10:54:33Z","updated_at":"2018-09-17T17:09:18Z","closed_at":"2018-09-17T17:09:18Z","merged_at":"2018-09-17T17:09:18Z","merge_commit_sha":"d6388ed6457465ab35da8a34ae4abf5847a50cd0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keras-team/keras/pulls/11167/commits","review_comments_url":"https://api.github.com/repos/keras-team/keras/pulls/11167/comments","review_comment_url":"https://api.github.com/repos/keras-team/keras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keras-team/keras/issues/11167/comments","statuses_url":"https://api.github.com/repos/keras-team/keras/statuses/70f3a41f08365aea83973f06060b023119e41731","head":{"label":"gabrieldemarmiesse:duplicate_in_tests","ref":"duplicate_in_tests","sha":"70f3a41f08365aea83973f06060b023119e41731","user":{"login":"gabrieldemarmiesse","id":12891691,"node_id":"MDQ6VXNlcjEyODkxNjkx","avatar_url":"https://avatars1.githubusercontent.com/u/12891691?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrieldemarmiesse","html_url":"https://github.com/gabrieldemarmiesse","followers_url":"https://api.github.com/users/gabrieldemarmiesse/followers","following_url":"https://api.github.com/users/gabrieldemarmiesse/following{/other_user}","gists_url":"https://api.github.com/users/gabrieldemarmiesse/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrieldemarmiesse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrieldemarmiesse/subscriptions","organizations_url":"https://api.github.com/users/gabrieldemarmiesse/orgs","repos_url":"https://api.github.com/users/gabrieldemarmiesse/repos","events_url":"https://api.github.com/users/gabrieldemarmiesse/events{/privacy}","received_events_url":"https://api.github.com/users/gabrieldemarmiesse/received_events","type":"User","site_admin":false},"repo":{"id":115792873,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU3OTI4NzM=","name":"keras","full_name":"gabrieldemarmiesse/keras","private":false,"owner":{"login":"gabrieldemarmiesse","id":12891691,"node_id":"MDQ6VXNlcjEyODkxNjkx","avatar_url":"https://avatars1.githubusercontent.com/u/12891691?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrieldemarmiesse","html_url":"https://github.com/gabrieldemarmiesse","followers_url":"https://api.github.com/users/gabrieldemarmiesse/followers","following_url":"https://api.github.com/users/gabrieldemarmiesse/following{/other_user}","gists_url":"https://api.github.com/users/gabrieldemarmiesse/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrieldemarmiesse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrieldemarmiesse/subscriptions","organizations_url":"https://api.github.com/users/gabrieldemarmiesse/orgs","repos_url":"https://api.github.com/users/gabrieldemarmiesse/repos","events_url":"https://api.github.com/users/gabrieldemarmiesse/events{/privacy}","received_events_url":"https://api.github.com/users/gabrieldemarmiesse/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gabrieldemarmiesse/keras","description":"Deep Learning for humans","fork":true,"url":"https://api.github.com/repos/gabrieldemarmiesse/keras","forks_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/forks","keys_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/teams","hooks_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/hooks","issue_events_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/issues/events{/number}","events_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/events","assignees_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/assignees{/user}","branches_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/branches{/branch}","tags_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/tags","blobs_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/statuses/{sha}","languages_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/languages","stargazers_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/stargazers","contributors_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/contributors","subscribers_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/subscribers","subscription_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/subscription","commits_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/contents/{+path}","compare_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/merges","archive_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/downloads","issues_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/issues{/number}","pulls_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/pulls{/number}","milestones_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/milestones{/number}","notifications_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/labels{/name}","releases_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/releases{/id}","deployments_url":"https://api.github.com/repos/gabrieldemarmiesse/keras/deployments","created_at":"2017-12-30T11:36:02Z","updated_at":"2018-09-17T09:49:47Z","pushed_at":"2018-09-17T10:50:23Z","git_url":"git://github.com/gabrieldemarmiesse/keras.git","ssh_url":"git@github.com:gabrieldemarmiesse/keras.git","clone_url":"https://github.com/gabrieldemarmiesse/keras.git","svn_url":"https://github.com/gabrieldemarmiesse/keras","homepage":"http://keras.io/","size":11984,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"keras-team:master","ref":"master","sha":"ef0c95aca2fd19666711422c14a6b16f8025ed84","user":{"login":"keras-team","id":34455048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDU1MDQ4","avatar_url":"https://avatars0.githubusercontent.com/u/34455048?v=4","gravatar_id":"","url":"https://api.github.com/users/keras-team","html_url":"https://github.com/keras-team","followers_url":"https://api.github.com/users/keras-team/followers","following_url":"https://api.github.com/users/keras-team/following{/other_user}","gists_url":"https://api.github.com/users/keras-team/gists{/gist_id}","starred_url":"https://api.github.com/users/keras-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keras-team/subscriptions","organizations_url":"https://api.github.com/users/keras-team/orgs","repos_url":"https://api.github.com/users/keras-team/repos","events_url":"https://api.github.com/users/keras-team/events{/privacy}","received_events_url":"https://api.github.com/users/keras-team/received_events","type":"Organization","site_admin":false},"repo":{"id":33015583,"node_id":"MDEwOlJlcG9zaXRvcnkzMzAxNTU4Mw==","name":"keras","full_name":"keras-team/keras","private":false,"owner":{"login":"keras-team","id":34455048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDU1MDQ4","avatar_url":"https://avatars0.githubusercontent.com/u/34455048?v=4","gravatar_id":"","url":"https://api.github.com/users/keras-team","html_url":"https://github.com/keras-team","followers_url":"https://api.github.com/users/keras-team/followers","following_url":"https://api.github.com/users/keras-team/following{/other_user}","gists_url":"https://api.github.com/users/keras-team/gists{/gist_id}","starred_url":"https://api.github.com/users/keras-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keras-team/subscriptions","organizations_url":"https://api.github.com/users/keras-team/orgs","repos_url":"https://api.github.com/users/keras-team/repos","events_url":"https://api.github.com/users/keras-team/events{/privacy}","received_events_url":"https://api.github.com/users/keras-team/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keras-team/keras","description":"Deep Learning for humans","fork":false,"url":"https://api.github.com/repos/keras-team/keras","forks_url":"https://api.github.com/repos/keras-team/keras/forks","keys_url":"https://api.github.com/repos/keras-team/keras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keras-team/keras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keras-team/keras/teams","hooks_url":"https://api.github.com/repos/keras-team/keras/hooks","issue_events_url":"https://api.github.com/repos/keras-team/keras/issues/events{/number}","events_url":"https://api.github.com/repos/keras-team/keras/events","assignees_url":"https://api.github.com/repos/keras-team/keras/assignees{/user}","branches_url":"https://api.github.com/repos/keras-team/keras/branches{/branch}","tags_url":"https://api.github.com/repos/keras-team/keras/tags","blobs_url":"https://api.github.com/repos/keras-team/keras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keras-team/keras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keras-team/keras/git/refs{/sha}","trees_url":"https://api.github.com/repos/keras-team/keras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keras-team/keras/statuses/{sha}","languages_url":"https://api.github.com/repos/keras-team/keras/languages","stargazers_url":"https://api.github.com/repos/keras-team/keras/stargazers","contributors_url":"https://api.github.com/repos/keras-team/keras/contributors","subscribers_url":"https://api.github.com/repos/keras-team/keras/subscribers","subscription_url":"https://api.github.com/repos/keras-team/keras/subscription","commits_url":"https://api.github.com/repos/keras-team/keras/commits{/sha}","git_commits_url":"https://api.github.com/repos/keras-team/keras/git/commits{/sha}","comments_url":"https://api.github.com/repos/keras-team/keras/comments{/number}","issue_comment_url":"https://api.github.com/repos/keras-team/keras/issues/comments{/number}","contents_url":"https://api.github.com/repos/keras-team/keras/contents/{+path}","compare_url":"https://api.github.com/repos/keras-team/keras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keras-team/keras/merges","archive_url":"https://api.github.com/repos/keras-team/keras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keras-team/keras/downloads","issues_url":"https://api.github.com/repos/keras-team/keras/issues{/number}","pulls_url":"https://api.github.com/repos/keras-team/keras/pulls{/number}","milestones_url":"https://api.github.com/repos/keras-team/keras/milestones{/number}","notifications_url":"https://api.github.com/repos/keras-team/keras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keras-team/keras/labels{/name}","releases_url":"https://api.github.com/repos/keras-team/keras/releases{/id}","deployments_url":"https://api.github.com/repos/keras-team/keras/deployments","created_at":"2015-03-28T00:35:42Z","updated_at":"2018-09-17T16:01:31Z","pushed_at":"2018-09-17T17:09:18Z","git_url":"git://github.com/keras-team/keras.git","ssh_url":"git@github.com:keras-team/keras.git","clone_url":"https://github.com/keras-team/keras.git","svn_url":"https://github.com/keras-team/keras","homepage":"http://keras.io/","size":11623,"stargazers_count":33582,"watchers_count":33582,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12666,"mirror_url":null,"archived":false,"open_issues_count":1865,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12666,"open_issues":1865,"watchers":33582,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keras-team/keras/pulls/11167"},"html":{"href":"https://github.com/keras-team/keras/pull/11167"},"issue":{"href":"https://api.github.com/repos/keras-team/keras/issues/11167"},"comments":{"href":"https://api.github.com/repos/keras-team/keras/issues/11167/comments"},"review_comments":{"href":"https://api.github.com/repos/keras-team/keras/pulls/11167/comments"},"review_comment":{"href":"https://api.github.com/repos/keras-team/keras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keras-team/keras/pulls/11167/commits"},"statuses":{"href":"https://api.github.com/repos/keras-team/keras/statuses/70f3a41f08365aea83973f06060b023119e41731"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Dref360","id":8976546,"node_id":"MDQ6VXNlcjg5NzY1NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/8976546?v=4","gravatar_id":"","url":"https://api.github.com/users/Dref360","html_url":"https://github.com/Dref360","followers_url":"https://api.github.com/users/Dref360/followers","following_url":"https://api.github.com/users/Dref360/following{/other_user}","gists_url":"https://api.github.com/users/Dref360/gists{/gist_id}","starred_url":"https://api.github.com/users/Dref360/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dref360/subscriptions","organizations_url":"https://api.github.com/users/Dref360/orgs","repos_url":"https://api.github.com/users/Dref360/repos","events_url":"https://api.github.com/users/Dref360/events{/privacy}","received_events_url":"https://api.github.com/users/Dref360/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":37,"deletions":88,"changed_files":1}}
{"actor":{"display_login":"Dref360"}}