{"action":"opened","number":8418,"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/8418","id":215291645,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MjkxNjQ1","html_url":"https://github.com/google/ggrc-core/pull/8418","diff_url":"https://github.com/google/ggrc-core/pull/8418.diff","patch_url":"https://github.com/google/ggrc-core/pull/8418.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/8418","number":8418,"state":"open","locked":false,"title":"GGRC-5948 Add 'Not applicable' option to 'Assertions' for Control object.","user":{"login":"melnik-ivan","id":25271294,"node_id":"MDQ6VXNlcjI1MjcxMjk0","avatar_url":"https://avatars2.githubusercontent.com/u/25271294?v=4","gravatar_id":"","url":"https://api.github.com/users/melnik-ivan","html_url":"https://github.com/melnik-ivan","followers_url":"https://api.github.com/users/melnik-ivan/followers","following_url":"https://api.github.com/users/melnik-ivan/following{/other_user}","gists_url":"https://api.github.com/users/melnik-ivan/gists{/gist_id}","starred_url":"https://api.github.com/users/melnik-ivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melnik-ivan/subscriptions","organizations_url":"https://api.github.com/users/melnik-ivan/orgs","repos_url":"https://api.github.com/users/melnik-ivan/repos","events_url":"https://api.github.com/users/melnik-ivan/events{/privacy}","received_events_url":"https://api.github.com/users/melnik-ivan/received_events","type":"User","site_admin":false},"body":"<!-- If your PR depends on other tickets or PRs, you can list them here\r\n# Dependencies\r\n\r\nThis PR is `on hold` until the dependencies are merged:\r\n\r\n- [ ] GGRC-1234\r\n- [ ] #1234\r\n-->\r\n\r\n# Issue description\r\n\r\nAdd 'Not applicable' option to 'Assertions' for Control object.\r\n\r\n# Steps to test the changes\r\n\r\n1. Log in to GGRC\r\n2. Invoke new Control popup\r\n3. Expand 'Assertions' dropdown list\r\n\r\n**Expected Result:** 'Not applicable' option should be displayed for 'Assertions' field.\r\n![sh_2](https://user-images.githubusercontent.com/25271294/45492688-a14c7800-b775-11e8-9d48-a5d28a3b36e7.png)\r\n\r\n\r\n# Solution description\r\n\r\nAdd migration which adds new 'Not applicable' value in 'categories' table.\r\n\r\n# Sanity checklist\r\n\r\n- [x] I have clicked through the app to make sure my changes work and not break the app.\r\n- [ ] I have applied the correct milestone and labels.\r\n- [x] My changes fix the issue described in the description (and do nothing else). 🤞\r\n- [ ] My changes are covered by tests.\r\n- [x] My changes follow our [performance guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/performance.rst).\r\n- [x] My changes follow our [js](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/javascript.rst) and/or [python](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/python.rst) guidelines.\r\n- [x] My commits follow our [commit guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/how_to_write_a_commit_message.rst).\r\n\r\n<!-- If your PR includes a migration include the additional checklist items\r\n# Migration checklist\r\n- [ ] Migration passes all checks from our [PR review guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/reviewing_pull_requests.rst#reviewing-a-pr-containing-database-migration-scripts)\r\n-->\r\n\r\n# PR Review checklist\r\n\r\n- [ ] The changes fix the issue and don't cause any apparent regressions.\r\n- [ ] Labels and milestone are correctly set.\r\n- [ ] The solution description matches the changes in the code.\r\n- [ ] There is no apparent way to improve the performance & design of the new code.\r\n- [ ] The pull request is opened against the correct base branch.\r\n- [ ] Upon merging, the Jira ticket's fixversion is correctly set and the ticket is moved to \"QA - In Progress\".\r\n\r\n<!-- If your code is not finished yet can include a TODO check list\r\n# TODO\r\n\r\n- [ ] First item on the TODO\r\n-->\r\n","created_at":"2018-09-13T13:56:07Z","updated_at":"2018-09-13T13:56:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/8418/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/8418/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/8418/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/62fda2ee84a09c657d91367051ae6ac594fed5da","head":{"label":"melnik-ivan:GGRC-5948","ref":"GGRC-5948","sha":"62fda2ee84a09c657d91367051ae6ac594fed5da","user":{"login":"melnik-ivan","id":25271294,"node_id":"MDQ6VXNlcjI1MjcxMjk0","avatar_url":"https://avatars2.githubusercontent.com/u/25271294?v=4","gravatar_id":"","url":"https://api.github.com/users/melnik-ivan","html_url":"https://github.com/melnik-ivan","followers_url":"https://api.github.com/users/melnik-ivan/followers","following_url":"https://api.github.com/users/melnik-ivan/following{/other_user}","gists_url":"https://api.github.com/users/melnik-ivan/gists{/gist_id}","starred_url":"https://api.github.com/users/melnik-ivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melnik-ivan/subscriptions","organizations_url":"https://api.github.com/users/melnik-ivan/orgs","repos_url":"https://api.github.com/users/melnik-ivan/repos","events_url":"https://api.github.com/users/melnik-ivan/events{/privacy}","received_events_url":"https://api.github.com/users/melnik-ivan/received_events","type":"User","site_admin":false},"repo":{"id":142274826,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIyNzQ4MjY=","name":"ggrc-core","full_name":"melnik-ivan/ggrc-core","owner":{"login":"melnik-ivan","id":25271294,"node_id":"MDQ6VXNlcjI1MjcxMjk0","avatar_url":"https://avatars2.githubusercontent.com/u/25271294?v=4","gravatar_id":"","url":"https://api.github.com/users/melnik-ivan","html_url":"https://github.com/melnik-ivan","followers_url":"https://api.github.com/users/melnik-ivan/followers","following_url":"https://api.github.com/users/melnik-ivan/following{/other_user}","gists_url":"https://api.github.com/users/melnik-ivan/gists{/gist_id}","starred_url":"https://api.github.com/users/melnik-ivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melnik-ivan/subscriptions","organizations_url":"https://api.github.com/users/melnik-ivan/orgs","repos_url":"https://api.github.com/users/melnik-ivan/repos","events_url":"https://api.github.com/users/melnik-ivan/events{/privacy}","received_events_url":"https://api.github.com/users/melnik-ivan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/melnik-ivan/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/melnik-ivan/ggrc-core","forks_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/forks","keys_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/teams","hooks_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/events","assignees_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/tags","blobs_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/subscription","commits_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/merges","archive_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/downloads","issues_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/melnik-ivan/ggrc-core/deployments","created_at":"2018-07-25T09:01:16Z","updated_at":"2018-09-13T12:42:47Z","pushed_at":"2018-09-13T13:36:50Z","git_url":"git://github.com/melnik-ivan/ggrc-core.git","ssh_url":"git@github.com:melnik-ivan/ggrc-core.git","clone_url":"https://github.com/melnik-ivan/ggrc-core.git","svn_url":"https://github.com/melnik-ivan/ggrc-core","homepage":null,"size":80953,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"google:dev","ref":"dev","sha":"1a63474591e9ed990ccbd47b885065f71f5a51aa","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA0NjM3","name":"ggrc-core","full_name":"google/ggrc-core","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/google/ggrc-core/deployments","created_at":"2013-04-08T19:16:28Z","updated_at":"2018-09-13T13:55:22Z","pushed_at":"2018-09-13T13:55:13Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":80965,"stargazers_count":318,"watchers_count":318,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":234,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":234,"open_issues":51,"watchers":318,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/8418"},"html":{"href":"https://github.com/google/ggrc-core/pull/8418"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/8418"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/8418/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/8418/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/8418/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/62fda2ee84a09c657d91367051ae6ac594fed5da"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":29,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"melnik-ivan"}}