{"action":"closed","number":1704,"pull_request":{"url":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1704","id":230910016,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTEwMDE2","html_url":"https://github.com/tilezen/vector-datasource/pull/1704","diff_url":"https://github.com/tilezen/vector-datasource/pull/1704.diff","patch_url":"https://github.com/tilezen/vector-datasource/pull/1704.patch","issue_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/1704","number":1704,"state":"closed","locked":false,"title":"Fix buffer topology problem with building merging","user":{"login":"zerebubuth","id":271360,"node_id":"MDQ6VXNlcjI3MTM2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/271360?v=4","gravatar_id":"","url":"https://api.github.com/users/zerebubuth","html_url":"https://github.com/zerebubuth","followers_url":"https://api.github.com/users/zerebubuth/followers","following_url":"https://api.github.com/users/zerebubuth/following{/other_user}","gists_url":"https://api.github.com/users/zerebubuth/gists{/gist_id}","starred_url":"https://api.github.com/users/zerebubuth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerebubuth/subscriptions","organizations_url":"https://api.github.com/users/zerebubuth/orgs","repos_url":"https://api.github.com/users/zerebubuth/repos","events_url":"https://api.github.com/users/zerebubuth/events{/privacy}","received_events_url":"https://api.github.com/users/zerebubuth/received_events","type":"User","site_admin":false},"body":"Building merging expands building footprints using `buffer`, simplifies them and then contracts them back. This means that a saddle point, where two buildings meet, creates two buffered out points which then collapse back onto exactly the same point when buffered negatively. This can, but doesn't usually, result in a topological error, and creates an invalid polygon.\r\n\r\nInstead of this, we can buffer out by a very, very slightly smaller value, which should tie-break the points coming back in, and mean that there's enough precision for the inside/outside or left-of/right-of tests to work properly.\r\n\r\n![error when two points on opposing sides collapse exactly back onto eachother](https://user-images.githubusercontent.com/271360/48498568-74c4e300-e82e-11e8-9b67-89c73bc4e943.png)\r\n\r\n\r\n","created_at":"2018-11-14T16:58:44Z","updated_at":"2018-11-15T09:34:13Z","closed_at":"2018-11-15T09:34:13Z","merged_at":"2018-11-15T09:34:13Z","merge_commit_sha":"935a6ee920464379275ace3d29c3ef17ec94a255","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1704/commits","review_comments_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1704/comments","review_comment_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/1704/comments","statuses_url":"https://api.github.com/repos/tilezen/vector-datasource/statuses/abb1b68aaa1c8c31d0bd4ef113682f25602e3fa9","head":{"label":"tilezen:zerebubuth/fix-buffer-topology-problem","ref":"zerebubuth/fix-buffer-topology-problem","sha":"abb1b68aaa1c8c31d0bd4ef113682f25602e3fa9","user":{"login":"tilezen","id":19462720,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDYyNzIw","avatar_url":"https://avatars2.githubusercontent.com/u/19462720?v=4","gravatar_id":"","url":"https://api.github.com/users/tilezen","html_url":"https://github.com/tilezen","followers_url":"https://api.github.com/users/tilezen/followers","following_url":"https://api.github.com/users/tilezen/following{/other_user}","gists_url":"https://api.github.com/users/tilezen/gists{/gist_id}","starred_url":"https://api.github.com/users/tilezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilezen/subscriptions","organizations_url":"https://api.github.com/users/tilezen/orgs","repos_url":"https://api.github.com/users/tilezen/repos","events_url":"https://api.github.com/users/tilezen/events{/privacy}","received_events_url":"https://api.github.com/users/tilezen/received_events","type":"Organization","site_admin":false},"repo":{"id":13446739,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0NjczOQ==","name":"vector-datasource","full_name":"tilezen/vector-datasource","private":false,"owner":{"login":"tilezen","id":19462720,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDYyNzIw","avatar_url":"https://avatars2.githubusercontent.com/u/19462720?v=4","gravatar_id":"","url":"https://api.github.com/users/tilezen","html_url":"https://github.com/tilezen","followers_url":"https://api.github.com/users/tilezen/followers","following_url":"https://api.github.com/users/tilezen/following{/other_user}","gists_url":"https://api.github.com/users/tilezen/gists{/gist_id}","starred_url":"https://api.github.com/users/tilezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilezen/subscriptions","organizations_url":"https://api.github.com/users/tilezen/orgs","repos_url":"https://api.github.com/users/tilezen/repos","events_url":"https://api.github.com/users/tilezen/events{/privacy}","received_events_url":"https://api.github.com/users/tilezen/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tilezen/vector-datasource","description":"Mapzen vector tile service - OpenStreetMap data in several formats","fork":false,"url":"https://api.github.com/repos/tilezen/vector-datasource","forks_url":"https://api.github.com/repos/tilezen/vector-datasource/forks","keys_url":"https://api.github.com/repos/tilezen/vector-datasource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tilezen/vector-datasource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tilezen/vector-datasource/teams","hooks_url":"https://api.github.com/repos/tilezen/vector-datasource/hooks","issue_events_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/events{/number}","events_url":"https://api.github.com/repos/tilezen/vector-datasource/events","assignees_url":"https://api.github.com/repos/tilezen/vector-datasource/assignees{/user}","branches_url":"https://api.github.com/repos/tilezen/vector-datasource/branches{/branch}","tags_url":"https://api.github.com/repos/tilezen/vector-datasource/tags","blobs_url":"https://api.github.com/repos/tilezen/vector-datasource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tilezen/vector-datasource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tilezen/vector-datasource/git/refs{/sha}","trees_url":"https://api.github.com/repos/tilezen/vector-datasource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tilezen/vector-datasource/statuses/{sha}","languages_url":"https://api.github.com/repos/tilezen/vector-datasource/languages","stargazers_url":"https://api.github.com/repos/tilezen/vector-datasource/stargazers","contributors_url":"https://api.github.com/repos/tilezen/vector-datasource/contributors","subscribers_url":"https://api.github.com/repos/tilezen/vector-datasource/subscribers","subscription_url":"https://api.github.com/repos/tilezen/vector-datasource/subscription","commits_url":"https://api.github.com/repos/tilezen/vector-datasource/commits{/sha}","git_commits_url":"https://api.github.com/repos/tilezen/vector-datasource/git/commits{/sha}","comments_url":"https://api.github.com/repos/tilezen/vector-datasource/comments{/number}","issue_comment_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/comments{/number}","contents_url":"https://api.github.com/repos/tilezen/vector-datasource/contents/{+path}","compare_url":"https://api.github.com/repos/tilezen/vector-datasource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tilezen/vector-datasource/merges","archive_url":"https://api.github.com/repos/tilezen/vector-datasource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tilezen/vector-datasource/downloads","issues_url":"https://api.github.com/repos/tilezen/vector-datasource/issues{/number}","pulls_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls{/number}","milestones_url":"https://api.github.com/repos/tilezen/vector-datasource/milestones{/number}","notifications_url":"https://api.github.com/repos/tilezen/vector-datasource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tilezen/vector-datasource/labels{/name}","releases_url":"https://api.github.com/repos/tilezen/vector-datasource/releases{/id}","deployments_url":"https://api.github.com/repos/tilezen/vector-datasource/deployments","created_at":"2013-10-09T15:54:45Z","updated_at":"2018-11-14T11:00:46Z","pushed_at":"2018-11-15T09:34:13Z","git_url":"git://github.com/tilezen/vector-datasource.git","ssh_url":"git@github.com:tilezen/vector-datasource.git","clone_url":"https://github.com/tilezen/vector-datasource.git","svn_url":"https://github.com/tilezen/vector-datasource","homepage":"https://mapzen.com/projects/vector-tiles/","size":66726,"stargazers_count":357,"watchers_count":357,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":336,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":100,"open_issues":336,"watchers":357,"default_branch":"master"}},"base":{"label":"tilezen:master","ref":"master","sha":"d4f15bf891ece0024225176efb63d910ad5bc16a","user":{"login":"tilezen","id":19462720,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDYyNzIw","avatar_url":"https://avatars2.githubusercontent.com/u/19462720?v=4","gravatar_id":"","url":"https://api.github.com/users/tilezen","html_url":"https://github.com/tilezen","followers_url":"https://api.github.com/users/tilezen/followers","following_url":"https://api.github.com/users/tilezen/following{/other_user}","gists_url":"https://api.github.com/users/tilezen/gists{/gist_id}","starred_url":"https://api.github.com/users/tilezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilezen/subscriptions","organizations_url":"https://api.github.com/users/tilezen/orgs","repos_url":"https://api.github.com/users/tilezen/repos","events_url":"https://api.github.com/users/tilezen/events{/privacy}","received_events_url":"https://api.github.com/users/tilezen/received_events","type":"Organization","site_admin":false},"repo":{"id":13446739,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0NjczOQ==","name":"vector-datasource","full_name":"tilezen/vector-datasource","private":false,"owner":{"login":"tilezen","id":19462720,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDYyNzIw","avatar_url":"https://avatars2.githubusercontent.com/u/19462720?v=4","gravatar_id":"","url":"https://api.github.com/users/tilezen","html_url":"https://github.com/tilezen","followers_url":"https://api.github.com/users/tilezen/followers","following_url":"https://api.github.com/users/tilezen/following{/other_user}","gists_url":"https://api.github.com/users/tilezen/gists{/gist_id}","starred_url":"https://api.github.com/users/tilezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilezen/subscriptions","organizations_url":"https://api.github.com/users/tilezen/orgs","repos_url":"https://api.github.com/users/tilezen/repos","events_url":"https://api.github.com/users/tilezen/events{/privacy}","received_events_url":"https://api.github.com/users/tilezen/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tilezen/vector-datasource","description":"Mapzen vector tile service - OpenStreetMap data in several formats","fork":false,"url":"https://api.github.com/repos/tilezen/vector-datasource","forks_url":"https://api.github.com/repos/tilezen/vector-datasource/forks","keys_url":"https://api.github.com/repos/tilezen/vector-datasource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tilezen/vector-datasource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tilezen/vector-datasource/teams","hooks_url":"https://api.github.com/repos/tilezen/vector-datasource/hooks","issue_events_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/events{/number}","events_url":"https://api.github.com/repos/tilezen/vector-datasource/events","assignees_url":"https://api.github.com/repos/tilezen/vector-datasource/assignees{/user}","branches_url":"https://api.github.com/repos/tilezen/vector-datasource/branches{/branch}","tags_url":"https://api.github.com/repos/tilezen/vector-datasource/tags","blobs_url":"https://api.github.com/repos/tilezen/vector-datasource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tilezen/vector-datasource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tilezen/vector-datasource/git/refs{/sha}","trees_url":"https://api.github.com/repos/tilezen/vector-datasource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tilezen/vector-datasource/statuses/{sha}","languages_url":"https://api.github.com/repos/tilezen/vector-datasource/languages","stargazers_url":"https://api.github.com/repos/tilezen/vector-datasource/stargazers","contributors_url":"https://api.github.com/repos/tilezen/vector-datasource/contributors","subscribers_url":"https://api.github.com/repos/tilezen/vector-datasource/subscribers","subscription_url":"https://api.github.com/repos/tilezen/vector-datasource/subscription","commits_url":"https://api.github.com/repos/tilezen/vector-datasource/commits{/sha}","git_commits_url":"https://api.github.com/repos/tilezen/vector-datasource/git/commits{/sha}","comments_url":"https://api.github.com/repos/tilezen/vector-datasource/comments{/number}","issue_comment_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/comments{/number}","contents_url":"https://api.github.com/repos/tilezen/vector-datasource/contents/{+path}","compare_url":"https://api.github.com/repos/tilezen/vector-datasource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tilezen/vector-datasource/merges","archive_url":"https://api.github.com/repos/tilezen/vector-datasource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tilezen/vector-datasource/downloads","issues_url":"https://api.github.com/repos/tilezen/vector-datasource/issues{/number}","pulls_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls{/number}","milestones_url":"https://api.github.com/repos/tilezen/vector-datasource/milestones{/number}","notifications_url":"https://api.github.com/repos/tilezen/vector-datasource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tilezen/vector-datasource/labels{/name}","releases_url":"https://api.github.com/repos/tilezen/vector-datasource/releases{/id}","deployments_url":"https://api.github.com/repos/tilezen/vector-datasource/deployments","created_at":"2013-10-09T15:54:45Z","updated_at":"2018-11-14T11:00:46Z","pushed_at":"2018-11-15T09:34:13Z","git_url":"git://github.com/tilezen/vector-datasource.git","ssh_url":"git@github.com:tilezen/vector-datasource.git","clone_url":"https://github.com/tilezen/vector-datasource.git","svn_url":"https://github.com/tilezen/vector-datasource","homepage":"https://mapzen.com/projects/vector-tiles/","size":66726,"stargazers_count":357,"watchers_count":357,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":336,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":100,"open_issues":336,"watchers":357,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1704"},"html":{"href":"https://github.com/tilezen/vector-datasource/pull/1704"},"issue":{"href":"https://api.github.com/repos/tilezen/vector-datasource/issues/1704"},"comments":{"href":"https://api.github.com/repos/tilezen/vector-datasource/issues/1704/comments"},"review_comments":{"href":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1704/comments"},"review_comment":{"href":"https://api.github.com/repos/tilezen/vector-datasource/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1704/commits"},"statuses":{"href":"https://api.github.com/repos/tilezen/vector-datasource/statuses/abb1b68aaa1c8c31d0bd4ef113682f25602e3fa9"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"zerebubuth","id":271360,"node_id":"MDQ6VXNlcjI3MTM2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/271360?v=4","gravatar_id":"","url":"https://api.github.com/users/zerebubuth","html_url":"https://github.com/zerebubuth","followers_url":"https://api.github.com/users/zerebubuth/followers","following_url":"https://api.github.com/users/zerebubuth/following{/other_user}","gists_url":"https://api.github.com/users/zerebubuth/gists{/gist_id}","starred_url":"https://api.github.com/users/zerebubuth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerebubuth/subscriptions","organizations_url":"https://api.github.com/users/zerebubuth/orgs","repos_url":"https://api.github.com/users/zerebubuth/repos","events_url":"https://api.github.com/users/zerebubuth/events{/privacy}","received_events_url":"https://api.github.com/users/zerebubuth/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"maintainer_can_modify":false,"commits":1,"additions":30,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"zerebubuth"}}