{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tikv/pulls/comments/172399991","pull_request_review_id":101408646,"id":172399991,"diff_hunk":"@@ -101,6 +103,21 @@ pub trait Engine: Send + Debug {\n         }\n     }\n \n+    fn future_snapshot(\n+        &self,\n+        ctx: &Context,\n+    ) -> Box<Future<Item = Box<Snapshot + 'static>, Error = Error> + Send> {","path":"src/storage/engine/mod.rs","position":23,"original_position":23,"commit_id":"e84f92c03cd0381832bed7985d0ff71a45d2c5e6","original_commit_id":"e84f92c03cd0381832bed7985d0ff71a45d2c5e6","user":{"login":"siddontang","id":1080370,"avatar_url":"https://avatars2.githubusercontent.com/u/1080370?v=4","gravatar_id":"","url":"https://api.github.com/users/siddontang","html_url":"https://github.com/siddontang","followers_url":"https://api.github.com/users/siddontang/followers","following_url":"https://api.github.com/users/siddontang/following{/other_user}","gists_url":"https://api.github.com/users/siddontang/gists{/gist_id}","starred_url":"https://api.github.com/users/siddontang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siddontang/subscriptions","organizations_url":"https://api.github.com/users/siddontang/orgs","repos_url":"https://api.github.com/users/siddontang/repos","events_url":"https://api.github.com/users/siddontang/events{/privacy}","received_events_url":"https://api.github.com/users/siddontang/received_events","type":"User","site_admin":false},"body":"can we use impl Future here?","created_at":"2018-03-06T03:24:39Z","updated_at":"2018-03-06T03:24:39Z","html_url":"https://github.com/pingcap/tikv/pull/2713#discussion_r172399991","pull_request_url":"https://api.github.com/repos/pingcap/tikv/pulls/2713","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/comments/172399991"},"html":{"href":"https://github.com/pingcap/tikv/pull/2713#discussion_r172399991"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/2713"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tikv/pulls/2713","id":165150223,"html_url":"https://github.com/pingcap/tikv/pull/2713","diff_url":"https://github.com/pingcap/tikv/pull/2713.diff","patch_url":"https://github.com/pingcap/tikv/pull/2713.patch","issue_url":"https://api.github.com/repos/pingcap/tikv/issues/2713","number":2713,"state":"open","locked":false,"title":"Move Storage Read Operations into Readpool","user":{"login":"breeswish","id":1916485,"avatar_url":"https://avatars3.githubusercontent.com/u/1916485?v=4","gravatar_id":"","url":"https://api.github.com/users/breeswish","html_url":"https://github.com/breeswish","followers_url":"https://api.github.com/users/breeswish/followers","following_url":"https://api.github.com/users/breeswish/following{/other_user}","gists_url":"https://api.github.com/users/breeswish/gists{/gist_id}","starred_url":"https://api.github.com/users/breeswish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breeswish/subscriptions","organizations_url":"https://api.github.com/users/breeswish/orgs","repos_url":"https://api.github.com/users/breeswish/repos","events_url":"https://api.github.com/users/breeswish/events{/privacy}","received_events_url":"https://api.github.com/users/breeswish/received_events","type":"User","site_admin":false},"body":"- [x] Storage::KvGet\r\n- [x] Storage::KvBatchGet\r\n- [x] Storage::KvScan\r\n- [x] Storage::RawGet\r\n- [x] Storage::RawScan\r\n- [x] Metrics\r\n\r\nPerformance: KvGet QPS 155K -> 205K","created_at":"2018-01-25T15:34:43Z","updated_at":"2018-03-06T03:24:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6260f3c5de9ffadad550bd21f8ea34277d71b07f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"BusyJay","id":1701473,"avatar_url":"https://avatars3.githubusercontent.com/u/1701473?v=4","gravatar_id":"","url":"https://api.github.com/users/BusyJay","html_url":"https://github.com/BusyJay","followers_url":"https://api.github.com/users/BusyJay/followers","following_url":"https://api.github.com/users/BusyJay/following{/other_user}","gists_url":"https://api.github.com/users/BusyJay/gists{/gist_id}","starred_url":"https://api.github.com/users/BusyJay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BusyJay/subscriptions","organizations_url":"https://api.github.com/users/BusyJay/orgs","repos_url":"https://api.github.com/users/BusyJay/repos","events_url":"https://api.github.com/users/BusyJay/events{/privacy}","received_events_url":"https://api.github.com/users/BusyJay/received_events","type":"User","site_admin":false},{"login":"zhangjinpeng1987","id":19700528,"avatar_url":"https://avatars2.githubusercontent.com/u/19700528?v=4","gravatar_id":"","url":"https://api.github.com/users/zhangjinpeng1987","html_url":"https://github.com/zhangjinpeng1987","followers_url":"https://api.github.com/users/zhangjinpeng1987/followers","following_url":"https://api.github.com/users/zhangjinpeng1987/following{/other_user}","gists_url":"https://api.github.com/users/zhangjinpeng1987/gists{/gist_id}","starred_url":"https://api.github.com/users/zhangjinpeng1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhangjinpeng1987/subscriptions","organizations_url":"https://api.github.com/users/zhangjinpeng1987/orgs","repos_url":"https://api.github.com/users/zhangjinpeng1987/repos","events_url":"https://api.github.com/users/zhangjinpeng1987/events{/privacy}","received_events_url":"https://api.github.com/users/zhangjinpeng1987/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tikv/pulls/2713/commits","review_comments_url":"https://api.github.com/repos/pingcap/tikv/pulls/2713/comments","review_comment_url":"https://api.github.com/repos/pingcap/tikv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tikv/issues/2713/comments","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/e84f92c03cd0381832bed7985d0ff71a45d2c5e6","head":{"label":"breeswish:wenxuan/readpool-integration","ref":"wenxuan/readpool-integration","sha":"e84f92c03cd0381832bed7985d0ff71a45d2c5e6","user":{"login":"breeswish","id":1916485,"avatar_url":"https://avatars3.githubusercontent.com/u/1916485?v=4","gravatar_id":"","url":"https://api.github.com/users/breeswish","html_url":"https://github.com/breeswish","followers_url":"https://api.github.com/users/breeswish/followers","following_url":"https://api.github.com/users/breeswish/following{/other_user}","gists_url":"https://api.github.com/users/breeswish/gists{/gist_id}","starred_url":"https://api.github.com/users/breeswish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breeswish/subscriptions","organizations_url":"https://api.github.com/users/breeswish/orgs","repos_url":"https://api.github.com/users/breeswish/repos","events_url":"https://api.github.com/users/breeswish/events{/privacy}","received_events_url":"https://api.github.com/users/breeswish/received_events","type":"User","site_admin":false},"repo":{"id":113962357,"name":"tikv","full_name":"breeswish/tikv","owner":{"login":"breeswish","id":1916485,"avatar_url":"https://avatars3.githubusercontent.com/u/1916485?v=4","gravatar_id":"","url":"https://api.github.com/users/breeswish","html_url":"https://github.com/breeswish","followers_url":"https://api.github.com/users/breeswish/followers","following_url":"https://api.github.com/users/breeswish/following{/other_user}","gists_url":"https://api.github.com/users/breeswish/gists{/gist_id}","starred_url":"https://api.github.com/users/breeswish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breeswish/subscriptions","organizations_url":"https://api.github.com/users/breeswish/orgs","repos_url":"https://api.github.com/users/breeswish/repos","events_url":"https://api.github.com/users/breeswish/events{/privacy}","received_events_url":"https://api.github.com/users/breeswish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/breeswish/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":true,"url":"https://api.github.com/repos/breeswish/tikv","forks_url":"https://api.github.com/repos/breeswish/tikv/forks","keys_url":"https://api.github.com/repos/breeswish/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/breeswish/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/breeswish/tikv/teams","hooks_url":"https://api.github.com/repos/breeswish/tikv/hooks","issue_events_url":"https://api.github.com/repos/breeswish/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/breeswish/tikv/events","assignees_url":"https://api.github.com/repos/breeswish/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/breeswish/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/breeswish/tikv/tags","blobs_url":"https://api.github.com/repos/breeswish/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/breeswish/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/breeswish/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/breeswish/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/breeswish/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/breeswish/tikv/languages","stargazers_url":"https://api.github.com/repos/breeswish/tikv/stargazers","contributors_url":"https://api.github.com/repos/breeswish/tikv/contributors","subscribers_url":"https://api.github.com/repos/breeswish/tikv/subscribers","subscription_url":"https://api.github.com/repos/breeswish/tikv/subscription","commits_url":"https://api.github.com/repos/breeswish/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/breeswish/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/breeswish/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/breeswish/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/breeswish/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/breeswish/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/breeswish/tikv/merges","archive_url":"https://api.github.com/repos/breeswish/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/breeswish/tikv/downloads","issues_url":"https://api.github.com/repos/breeswish/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/breeswish/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/breeswish/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/breeswish/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/breeswish/tikv/labels{/name}","releases_url":"https://api.github.com/repos/breeswish/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/breeswish/tikv/deployments","created_at":"2017-12-12T08:14:53Z","updated_at":"2017-12-12T08:14:55Z","pushed_at":"2018-03-06T02:07:29Z","git_url":"git://github.com/breeswish/tikv.git","ssh_url":"git@github.com:breeswish/tikv.git","clone_url":"https://github.com/breeswish/tikv.git","svn_url":"https://github.com/breeswish/tikv","homepage":"https://pingcap.com","size":12776,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"aea24b228d89cd8826238156dfb096c0f9493c39","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":48833910,"name":"tikv","full_name":"pingcap/tikv","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tikv","description":"Distributed transactional key value database powered by Rust and Raft","fork":false,"url":"https://api.github.com/repos/pingcap/tikv","forks_url":"https://api.github.com/repos/pingcap/tikv/forks","keys_url":"https://api.github.com/repos/pingcap/tikv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tikv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tikv/teams","hooks_url":"https://api.github.com/repos/pingcap/tikv/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tikv/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tikv/events","assignees_url":"https://api.github.com/repos/pingcap/tikv/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tikv/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tikv/tags","blobs_url":"https://api.github.com/repos/pingcap/tikv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tikv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tikv/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tikv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tikv/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tikv/languages","stargazers_url":"https://api.github.com/repos/pingcap/tikv/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tikv/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tikv/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tikv/subscription","commits_url":"https://api.github.com/repos/pingcap/tikv/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tikv/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tikv/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tikv/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tikv/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tikv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tikv/merges","archive_url":"https://api.github.com/repos/pingcap/tikv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tikv/downloads","issues_url":"https://api.github.com/repos/pingcap/tikv/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tikv/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tikv/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tikv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tikv/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tikv/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tikv/deployments","created_at":"2015-12-31T04:51:32Z","updated_at":"2018-03-06T03:03:50Z","pushed_at":"2018-03-06T03:23:00Z","git_url":"git://github.com/pingcap/tikv.git","ssh_url":"git@github.com:pingcap/tikv.git","clone_url":"https://github.com/pingcap/tikv.git","svn_url":"https://github.com/pingcap/tikv","homepage":"https://pingcap.com","size":12010,"stargazers_count":2767,"watchers_count":2767,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":342,"mirror_url":null,"archived":false,"open_issues_count":175,"license":null,"forks":342,"open_issues":175,"watchers":2767,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/2713"},"html":{"href":"https://github.com/pingcap/tikv/pull/2713"},"issue":{"href":"https://api.github.com/repos/pingcap/tikv/issues/2713"},"comments":{"href":"https://api.github.com/repos/pingcap/tikv/issues/2713/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/2713/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tikv/pulls/2713/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tikv/statuses/e84f92c03cd0381832bed7985d0ff71a45d2c5e6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"siddontang"}}