{"action":"created","comment":{"url":"https://api.github.com/repos/autotest/autotest-docker/pulls/comments/179507518","pull_request_review_id":109764937,"id":179507518,"diff_hunk":"@@ -22,6 +22,9 @@ docker_options =\n #: Max runtime in seconds for any docker command (auto-converts to float)\n docker_timeout = 300.0\n \n+#: Time (seconds) to wait for READY from container","path":"config_defaults/defaults.ini","position":4,"original_position":4,"commit_id":"1defb5f58ae5d45ed4f03d305b73ef8966cbfae5","original_commit_id":"10190a64afb38eadc7e1f6f31355e127e5990247","user":{"login":"cevich","id":1183438,"avatar_url":"https://avatars2.githubusercontent.com/u/1183438?v=4","gravatar_id":"","url":"https://api.github.com/users/cevich","html_url":"https://github.com/cevich","followers_url":"https://api.github.com/users/cevich/followers","following_url":"https://api.github.com/users/cevich/following{/other_user}","gists_url":"https://api.github.com/users/cevich/gists{/gist_id}","starred_url":"https://api.github.com/users/cevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cevich/subscriptions","organizations_url":"https://api.github.com/users/cevich/orgs","repos_url":"https://api.github.com/users/cevich/repos","events_url":"https://api.github.com/users/cevich/events{/privacy}","received_events_url":"https://api.github.com/users/cevich/received_events","type":"User","site_admin":false},"body":"Actually...in ``wait_for_ready()`` it has access to the test configuration.  Would it make sense if that method used ``self.subtest.config[\"wait_ready\"]`` as the default value ``if timeout is None``?","created_at":"2018-04-05T15:40:07Z","updated_at":"2018-04-05T15:40:07Z","html_url":"https://github.com/autotest/autotest-docker/pull/772#discussion_r179507518","pull_request_url":"https://api.github.com/repos/autotest/autotest-docker/pulls/772","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/comments/179507518"},"html":{"href":"https://github.com/autotest/autotest-docker/pull/772#discussion_r179507518"},"pull_request":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/772"}},"in_reply_to_id":179499769},"pull_request":{"url":"https://api.github.com/repos/autotest/autotest-docker/pulls/772","id":178073970,"html_url":"https://github.com/autotest/autotest-docker/pull/772","diff_url":"https://github.com/autotest/autotest-docker/pull/772.diff","patch_url":"https://github.com/autotest/autotest-docker/pull/772.patch","issue_url":"https://api.github.com/repos/autotest/autotest-docker/issues/772","number":772,"state":"open","locked":false,"title":"wait_for_ready(): refactor","user":{"login":"edsantiago","id":265639,"avatar_url":"https://avatars1.githubusercontent.com/u/265639?v=4","gravatar_id":"","url":"https://api.github.com/users/edsantiago","html_url":"https://github.com/edsantiago","followers_url":"https://api.github.com/users/edsantiago/followers","following_url":"https://api.github.com/users/edsantiago/following{/other_user}","gists_url":"https://api.github.com/users/edsantiago/gists{/gist_id}","starred_url":"https://api.github.com/users/edsantiago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsantiago/subscriptions","organizations_url":"https://api.github.com/users/edsantiago/orgs","repos_url":"https://api.github.com/users/edsantiago/repos","events_url":"https://api.github.com/users/edsantiago/events{/privacy}","received_events_url":"https://api.github.com/users/edsantiago/received_events","type":"User","site_admin":false},"body":"add a common 'wait_ready' setting (default: 60s). Allow individual\r\nsubtest .ini files to override, and continue allowing overriding\r\nin code itself.\r\n\r\nGoal is to eliminate various 5- and 10-second timeouts: these are\r\ncausing sporadic and irreproducible test failures.\r\n\r\nSigned-off-by: Ed Santiago <santiago@redhat.com>","created_at":"2018-03-28T15:18:31Z","updated_at":"2018-04-05T15:40:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56f54b5ca8f0b522fd8d736b4de92e44d7aba5c5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/autotest/autotest-docker/pulls/772/commits","review_comments_url":"https://api.github.com/repos/autotest/autotest-docker/pulls/772/comments","review_comment_url":"https://api.github.com/repos/autotest/autotest-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/autotest/autotest-docker/issues/772/comments","statuses_url":"https://api.github.com/repos/autotest/autotest-docker/statuses/1defb5f58ae5d45ed4f03d305b73ef8966cbfae5","head":{"label":"edsantiago:refactor_wait_start","ref":"refactor_wait_start","sha":"1defb5f58ae5d45ed4f03d305b73ef8966cbfae5","user":{"login":"edsantiago","id":265639,"avatar_url":"https://avatars1.githubusercontent.com/u/265639?v=4","gravatar_id":"","url":"https://api.github.com/users/edsantiago","html_url":"https://github.com/edsantiago","followers_url":"https://api.github.com/users/edsantiago/followers","following_url":"https://api.github.com/users/edsantiago/following{/other_user}","gists_url":"https://api.github.com/users/edsantiago/gists{/gist_id}","starred_url":"https://api.github.com/users/edsantiago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsantiago/subscriptions","organizations_url":"https://api.github.com/users/edsantiago/orgs","repos_url":"https://api.github.com/users/edsantiago/repos","events_url":"https://api.github.com/users/edsantiago/events{/privacy}","received_events_url":"https://api.github.com/users/edsantiago/received_events","type":"User","site_admin":false},"repo":{"id":51094257,"name":"autotest-docker","full_name":"edsantiago/autotest-docker","owner":{"login":"edsantiago","id":265639,"avatar_url":"https://avatars1.githubusercontent.com/u/265639?v=4","gravatar_id":"","url":"https://api.github.com/users/edsantiago","html_url":"https://github.com/edsantiago","followers_url":"https://api.github.com/users/edsantiago/followers","following_url":"https://api.github.com/users/edsantiago/following{/other_user}","gists_url":"https://api.github.com/users/edsantiago/gists{/gist_id}","starred_url":"https://api.github.com/users/edsantiago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edsantiago/subscriptions","organizations_url":"https://api.github.com/users/edsantiago/orgs","repos_url":"https://api.github.com/users/edsantiago/repos","events_url":"https://api.github.com/users/edsantiago/events{/privacy}","received_events_url":"https://api.github.com/users/edsantiago/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edsantiago/autotest-docker","description":"Autotest client test containing functional & integration subtests for the Docker project","fork":true,"url":"https://api.github.com/repos/edsantiago/autotest-docker","forks_url":"https://api.github.com/repos/edsantiago/autotest-docker/forks","keys_url":"https://api.github.com/repos/edsantiago/autotest-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edsantiago/autotest-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edsantiago/autotest-docker/teams","hooks_url":"https://api.github.com/repos/edsantiago/autotest-docker/hooks","issue_events_url":"https://api.github.com/repos/edsantiago/autotest-docker/issues/events{/number}","events_url":"https://api.github.com/repos/edsantiago/autotest-docker/events","assignees_url":"https://api.github.com/repos/edsantiago/autotest-docker/assignees{/user}","branches_url":"https://api.github.com/repos/edsantiago/autotest-docker/branches{/branch}","tags_url":"https://api.github.com/repos/edsantiago/autotest-docker/tags","blobs_url":"https://api.github.com/repos/edsantiago/autotest-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edsantiago/autotest-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edsantiago/autotest-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/edsantiago/autotest-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edsantiago/autotest-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/edsantiago/autotest-docker/languages","stargazers_url":"https://api.github.com/repos/edsantiago/autotest-docker/stargazers","contributors_url":"https://api.github.com/repos/edsantiago/autotest-docker/contributors","subscribers_url":"https://api.github.com/repos/edsantiago/autotest-docker/subscribers","subscription_url":"https://api.github.com/repos/edsantiago/autotest-docker/subscription","commits_url":"https://api.github.com/repos/edsantiago/autotest-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/edsantiago/autotest-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/edsantiago/autotest-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/edsantiago/autotest-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/edsantiago/autotest-docker/contents/{+path}","compare_url":"https://api.github.com/repos/edsantiago/autotest-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edsantiago/autotest-docker/merges","archive_url":"https://api.github.com/repos/edsantiago/autotest-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edsantiago/autotest-docker/downloads","issues_url":"https://api.github.com/repos/edsantiago/autotest-docker/issues{/number}","pulls_url":"https://api.github.com/repos/edsantiago/autotest-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/edsantiago/autotest-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/edsantiago/autotest-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edsantiago/autotest-docker/labels{/name}","releases_url":"https://api.github.com/repos/edsantiago/autotest-docker/releases{/id}","deployments_url":"https://api.github.com/repos/edsantiago/autotest-docker/deployments","created_at":"2016-02-04T17:56:14Z","updated_at":"2016-02-04T17:56:15Z","pushed_at":"2018-04-05T15:32:05Z","git_url":"git://github.com/edsantiago/autotest-docker.git","ssh_url":"git@github.com:edsantiago/autotest-docker.git","clone_url":"https://github.com/edsantiago/autotest-docker.git","svn_url":"https://github.com/edsantiago/autotest-docker","homepage":null,"size":2572,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"autotest:master","ref":"master","sha":"44a2fe30916335fcd0b6c66850c4475e979aab6e","user":{"login":"autotest","id":472856,"avatar_url":"https://avatars1.githubusercontent.com/u/472856?v=4","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"repo":{"id":17869790,"name":"autotest-docker","full_name":"autotest/autotest-docker","owner":{"login":"autotest","id":472856,"avatar_url":"https://avatars1.githubusercontent.com/u/472856?v=4","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autotest/autotest-docker","description":"Autotest client test containing functional & integration subtests for the Docker project","fork":false,"url":"https://api.github.com/repos/autotest/autotest-docker","forks_url":"https://api.github.com/repos/autotest/autotest-docker/forks","keys_url":"https://api.github.com/repos/autotest/autotest-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autotest/autotest-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autotest/autotest-docker/teams","hooks_url":"https://api.github.com/repos/autotest/autotest-docker/hooks","issue_events_url":"https://api.github.com/repos/autotest/autotest-docker/issues/events{/number}","events_url":"https://api.github.com/repos/autotest/autotest-docker/events","assignees_url":"https://api.github.com/repos/autotest/autotest-docker/assignees{/user}","branches_url":"https://api.github.com/repos/autotest/autotest-docker/branches{/branch}","tags_url":"https://api.github.com/repos/autotest/autotest-docker/tags","blobs_url":"https://api.github.com/repos/autotest/autotest-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autotest/autotest-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autotest/autotest-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/autotest/autotest-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autotest/autotest-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/autotest/autotest-docker/languages","stargazers_url":"https://api.github.com/repos/autotest/autotest-docker/stargazers","contributors_url":"https://api.github.com/repos/autotest/autotest-docker/contributors","subscribers_url":"https://api.github.com/repos/autotest/autotest-docker/subscribers","subscription_url":"https://api.github.com/repos/autotest/autotest-docker/subscription","commits_url":"https://api.github.com/repos/autotest/autotest-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/autotest/autotest-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/autotest/autotest-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/autotest/autotest-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/autotest/autotest-docker/contents/{+path}","compare_url":"https://api.github.com/repos/autotest/autotest-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autotest/autotest-docker/merges","archive_url":"https://api.github.com/repos/autotest/autotest-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autotest/autotest-docker/downloads","issues_url":"https://api.github.com/repos/autotest/autotest-docker/issues{/number}","pulls_url":"https://api.github.com/repos/autotest/autotest-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/autotest/autotest-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/autotest/autotest-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autotest/autotest-docker/labels{/name}","releases_url":"https://api.github.com/repos/autotest/autotest-docker/releases{/id}","deployments_url":"https://api.github.com/repos/autotest/autotest-docker/deployments","created_at":"2014-03-18T14:53:27Z","updated_at":"2018-04-05T15:31:37Z","pushed_at":"2018-04-05T15:32:06Z","git_url":"git://github.com/autotest/autotest-docker.git","ssh_url":"git@github.com:autotest/autotest-docker.git","clone_url":"https://github.com/autotest/autotest-docker.git","svn_url":"https://github.com/autotest/autotest-docker","homepage":null,"size":2525,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":28,"open_issues":22,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/772"},"html":{"href":"https://github.com/autotest/autotest-docker/pull/772"},"issue":{"href":"https://api.github.com/repos/autotest/autotest-docker/issues/772"},"comments":{"href":"https://api.github.com/repos/autotest/autotest-docker/issues/772/comments"},"review_comments":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/772/comments"},"review_comment":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/autotest/autotest-docker/pulls/772/commits"},"statuses":{"href":"https://api.github.com/repos/autotest/autotest-docker/statuses/1defb5f58ae5d45ed4f03d305b73ef8966cbfae5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"cevich"}}