{"action":"created","comment":{"url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/comments/209289501","pull_request_review_id":145279051,"id":209289501,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTI4OTUwMQ==","diff_hunk":"@@ -2762,27 +2762,41 @@ Normalize path middleware\n ^^^^^^^^^^^^^^^^^^^^^^^^^\n \n .. function:: normalize_path_middleware(*, \\\n-                                        append_slash=True, merge_slashes=True)\n+                                        append_slash=True, \\\n+                                        remove_slash=False, \\\n+                                        merge_slashes=True, \\\n+                                        redirect_class=HTTPMovedPermanently)\n \n-  Middleware factory which produces a middleware that normalizes\n-  the path of a request. By normalizing it means:\n+   Middleware factory which produces a middleware that normalizes","path":"docs/web_reference.rst","position":12,"original_position":12,"commit_id":"968c17f12f0cf8b1e6e9f2d00062a661b6383ab4","original_commit_id":"968c17f12f0cf8b1e6e9f2d00062a661b6383ab4","user":{"login":"kryptn","id":644071,"node_id":"MDQ6VXNlcjY0NDA3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/644071?v=4","gravatar_id":"","url":"https://api.github.com/users/kryptn","html_url":"https://github.com/kryptn","followers_url":"https://api.github.com/users/kryptn/followers","following_url":"https://api.github.com/users/kryptn/following{/other_user}","gists_url":"https://api.github.com/users/kryptn/gists{/gist_id}","starred_url":"https://api.github.com/users/kryptn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kryptn/subscriptions","organizations_url":"https://api.github.com/users/kryptn/orgs","repos_url":"https://api.github.com/users/kryptn/repos","events_url":"https://api.github.com/users/kryptn/events{/privacy}","received_events_url":"https://api.github.com/users/kryptn/received_events","type":"User","site_admin":false},"body":"The indentation in that section was two, it's now three. I noticed the difference when adding the `.. versionadded::` tag. ","created_at":"2018-08-10T15:01:36Z","updated_at":"2018-08-10T15:01:37Z","html_url":"https://github.com/aio-libs/aiohttp/pull/3173#discussion_r209289501","pull_request_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3173","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/comments/209289501"},"html":{"href":"https://github.com/aio-libs/aiohttp/pull/3173#discussion_r209289501"},"pull_request":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3173"}},"in_reply_to_id":209225382},"pull_request":{"url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3173","id":206136228,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MTM2MjI4","html_url":"https://github.com/aio-libs/aiohttp/pull/3173","diff_url":"https://github.com/aio-libs/aiohttp/pull/3173.diff","patch_url":"https://github.com/aio-libs/aiohttp/pull/3173.patch","issue_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/3173","number":3173,"state":"open","locked":false,"title":"Add option to remove slash to `normalize_path_middleware`","user":{"login":"kryptn","id":644071,"node_id":"MDQ6VXNlcjY0NDA3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/644071?v=4","gravatar_id":"","url":"https://api.github.com/users/kryptn","html_url":"https://github.com/kryptn","followers_url":"https://api.github.com/users/kryptn/followers","following_url":"https://api.github.com/users/kryptn/following{/other_user}","gists_url":"https://api.github.com/users/kryptn/gists{/gist_id}","starred_url":"https://api.github.com/users/kryptn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kryptn/subscriptions","organizations_url":"https://api.github.com/users/kryptn/orgs","repos_url":"https://api.github.com/users/kryptn/repos","events_url":"https://api.github.com/users/kryptn/events{/privacy}","received_events_url":"https://api.github.com/users/kryptn/received_events","type":"User","site_admin":false},"body":"<!-- Thank you for your contribution! -->\r\n\r\n## What do these changes do?\r\n\r\nThis change adds new functionality to the `normalize_path_middleware`. I wanted the option to remove trailing slashes and it made sense to just add the functionality to the existing middleware.\r\n\r\n## Are there changes in behavior for the user?\r\n\r\nNo breaking changes to existing usage. The `normalize_path_middleware` factory only accepts keyword arguments, and because there's now an assertion that only one of `append_slash` and `remove_slash` can be enabled this change shouldn't be breaking.\r\n\r\n## Related issue number\r\n\r\nNone that I could find.\r\n\r\n## Checklist\r\n\r\n- [x] I think the code is well written\r\n- [x] Unit tests for the changes exist\r\n- [x] Documentation reflects the changes\r\n- [x] If you provide code modification, please add yourself to `CONTRIBUTORS.txt`\r\n  * The format is &lt;Name&gt; &lt;Surname&gt;.\r\n  * Please keep alphabetical order, the file is sorted by names. \r\n- [x] Add a new news fragment into the `CHANGES` folder\r\n  * name it `<issue_id>.<type>` for example (588.bugfix)\r\n  * if you don't have an `issue_id` change it to the pr id after creating the pr\r\n  * ensure type is one of the following:\r\n    * `.feature`: Signifying a new feature.\r\n    * `.bugfix`: Signifying a bug fix.\r\n    * `.doc`: Signifying a documentation improvement.\r\n    * `.removal`: Signifying a deprecation or removal of public API.\r\n    * `.misc`: A ticket has been closed, but it is not of interest to users.\r\n  * Make sure to use full sentences with correct case and punctuation, for example: \"Fix issue with non-ascii contents in doctest text files.\"\r\n","created_at":"2018-08-03T20:52:57Z","updated_at":"2018-08-10T15:01:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fc2e19de86a10146aeecc8a974dd7033cc2f781","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3173/commits","review_comments_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3173/comments","review_comment_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/3173/comments","statuses_url":"https://api.github.com/repos/aio-libs/aiohttp/statuses/968c17f12f0cf8b1e6e9f2d00062a661b6383ab4","head":{"label":"kryptn:expand-normalize-middleware","ref":"expand-normalize-middleware","sha":"968c17f12f0cf8b1e6e9f2d00062a661b6383ab4","user":{"login":"kryptn","id":644071,"node_id":"MDQ6VXNlcjY0NDA3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/644071?v=4","gravatar_id":"","url":"https://api.github.com/users/kryptn","html_url":"https://github.com/kryptn","followers_url":"https://api.github.com/users/kryptn/followers","following_url":"https://api.github.com/users/kryptn/following{/other_user}","gists_url":"https://api.github.com/users/kryptn/gists{/gist_id}","starred_url":"https://api.github.com/users/kryptn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kryptn/subscriptions","organizations_url":"https://api.github.com/users/kryptn/orgs","repos_url":"https://api.github.com/users/kryptn/repos","events_url":"https://api.github.com/users/kryptn/events{/privacy}","received_events_url":"https://api.github.com/users/kryptn/received_events","type":"User","site_admin":false},"repo":{"id":143334821,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzMzQ4MjE=","name":"aiohttp","full_name":"kryptn/aiohttp","owner":{"login":"kryptn","id":644071,"node_id":"MDQ6VXNlcjY0NDA3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/644071?v=4","gravatar_id":"","url":"https://api.github.com/users/kryptn","html_url":"https://github.com/kryptn","followers_url":"https://api.github.com/users/kryptn/followers","following_url":"https://api.github.com/users/kryptn/following{/other_user}","gists_url":"https://api.github.com/users/kryptn/gists{/gist_id}","starred_url":"https://api.github.com/users/kryptn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kryptn/subscriptions","organizations_url":"https://api.github.com/users/kryptn/orgs","repos_url":"https://api.github.com/users/kryptn/repos","events_url":"https://api.github.com/users/kryptn/events{/privacy}","received_events_url":"https://api.github.com/users/kryptn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kryptn/aiohttp","description":"HTTP client/server framework for asyncio ","fork":true,"url":"https://api.github.com/repos/kryptn/aiohttp","forks_url":"https://api.github.com/repos/kryptn/aiohttp/forks","keys_url":"https://api.github.com/repos/kryptn/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kryptn/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kryptn/aiohttp/teams","hooks_url":"https://api.github.com/repos/kryptn/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/kryptn/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/kryptn/aiohttp/events","assignees_url":"https://api.github.com/repos/kryptn/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/kryptn/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/kryptn/aiohttp/tags","blobs_url":"https://api.github.com/repos/kryptn/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kryptn/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kryptn/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/kryptn/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kryptn/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/kryptn/aiohttp/languages","stargazers_url":"https://api.github.com/repos/kryptn/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/kryptn/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/kryptn/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/kryptn/aiohttp/subscription","commits_url":"https://api.github.com/repos/kryptn/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/kryptn/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/kryptn/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/kryptn/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/kryptn/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/kryptn/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kryptn/aiohttp/merges","archive_url":"https://api.github.com/repos/kryptn/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kryptn/aiohttp/downloads","issues_url":"https://api.github.com/repos/kryptn/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/kryptn/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/kryptn/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/kryptn/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kryptn/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/kryptn/aiohttp/releases{/id}","deployments_url":"https://api.github.com/repos/kryptn/aiohttp/deployments","created_at":"2018-08-02T19:07:31Z","updated_at":"2018-08-02T19:07:34Z","pushed_at":"2018-08-07T20:26:42Z","git_url":"git://github.com/kryptn/aiohttp.git","ssh_url":"git@github.com:kryptn/aiohttp.git","clone_url":"https://github.com/kryptn/aiohttp.git","svn_url":"https://github.com/kryptn/aiohttp","homepage":"http://docs.aiohttp.org","size":12909,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aio-libs:master","ref":"master","sha":"cf3a384f7042e5e00f749fd5c65f158d11d6b964","user":{"login":"aio-libs","id":7049303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDkzMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7049303?v=4","gravatar_id":"","url":"https://api.github.com/users/aio-libs","html_url":"https://github.com/aio-libs","followers_url":"https://api.github.com/users/aio-libs/followers","following_url":"https://api.github.com/users/aio-libs/following{/other_user}","gists_url":"https://api.github.com/users/aio-libs/gists{/gist_id}","starred_url":"https://api.github.com/users/aio-libs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aio-libs/subscriptions","organizations_url":"https://api.github.com/users/aio-libs/orgs","repos_url":"https://api.github.com/users/aio-libs/repos","events_url":"https://api.github.com/users/aio-libs/events{/privacy}","received_events_url":"https://api.github.com/users/aio-libs/received_events","type":"Organization","site_admin":false},"repo":{"id":13258039,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI1ODAzOQ==","name":"aiohttp","full_name":"aio-libs/aiohttp","owner":{"login":"aio-libs","id":7049303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDkzMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7049303?v=4","gravatar_id":"","url":"https://api.github.com/users/aio-libs","html_url":"https://github.com/aio-libs","followers_url":"https://api.github.com/users/aio-libs/followers","following_url":"https://api.github.com/users/aio-libs/following{/other_user}","gists_url":"https://api.github.com/users/aio-libs/gists{/gist_id}","starred_url":"https://api.github.com/users/aio-libs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aio-libs/subscriptions","organizations_url":"https://api.github.com/users/aio-libs/orgs","repos_url":"https://api.github.com/users/aio-libs/repos","events_url":"https://api.github.com/users/aio-libs/events{/privacy}","received_events_url":"https://api.github.com/users/aio-libs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aio-libs/aiohttp","description":"HTTP client/server framework for asyncio ","fork":false,"url":"https://api.github.com/repos/aio-libs/aiohttp","forks_url":"https://api.github.com/repos/aio-libs/aiohttp/forks","keys_url":"https://api.github.com/repos/aio-libs/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aio-libs/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aio-libs/aiohttp/teams","hooks_url":"https://api.github.com/repos/aio-libs/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/aio-libs/aiohttp/events","assignees_url":"https://api.github.com/repos/aio-libs/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/aio-libs/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/aio-libs/aiohttp/tags","blobs_url":"https://api.github.com/repos/aio-libs/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aio-libs/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aio-libs/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/aio-libs/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aio-libs/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/aio-libs/aiohttp/languages","stargazers_url":"https://api.github.com/repos/aio-libs/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/aio-libs/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/aio-libs/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/aio-libs/aiohttp/subscription","commits_url":"https://api.github.com/repos/aio-libs/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/aio-libs/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/aio-libs/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/aio-libs/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/aio-libs/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aio-libs/aiohttp/merges","archive_url":"https://api.github.com/repos/aio-libs/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aio-libs/aiohttp/downloads","issues_url":"https://api.github.com/repos/aio-libs/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/aio-libs/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/aio-libs/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aio-libs/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/aio-libs/aiohttp/releases{/id}","deployments_url":"https://api.github.com/repos/aio-libs/aiohttp/deployments","created_at":"2013-10-01T23:04:01Z","updated_at":"2018-08-10T14:25:16Z","pushed_at":"2018-08-08T16:29:41Z","git_url":"git://github.com/aio-libs/aiohttp.git","ssh_url":"git@github.com:aio-libs/aiohttp.git","clone_url":"https://github.com/aio-libs/aiohttp.git","svn_url":"https://github.com/aio-libs/aiohttp","homepage":"http://docs.aiohttp.org","size":12906,"stargazers_count":5779,"watchers_count":5779,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":909,"mirror_url":null,"archived":false,"open_issues_count":150,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":909,"open_issues":150,"watchers":5779,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3173"},"html":{"href":"https://github.com/aio-libs/aiohttp/pull/3173"},"issue":{"href":"https://api.github.com/repos/aio-libs/aiohttp/issues/3173"},"comments":{"href":"https://api.github.com/repos/aio-libs/aiohttp/issues/3173/comments"},"review_comments":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3173/comments"},"review_comment":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/3173/commits"},"statuses":{"href":"https://api.github.com/repos/aio-libs/aiohttp/statuses/968c17f12f0cf8b1e6e9f2d00062a661b6383ab4"}},"author_association":"NONE"}}
{"actor":{"display_login":"kryptn"}}