{"action":"created","issue":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/16656","repository_url":"https://api.github.com/repos/home-assistant/home-assistant","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/16656/labels{/name}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/16656/comments","events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/16656/events","html_url":"https://github.com/home-assistant/home-assistant/pull/16656","id":360729541,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1ODc4MTkx","number":16656,"title":"Netdata configuration change: Allows multiple elements per group","user":{"login":"reefab","id":873778,"node_id":"MDQ6VXNlcjg3Mzc3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/873778?v=4","gravatar_id":"","url":"https://api.github.com/users/reefab","html_url":"https://github.com/reefab","followers_url":"https://api.github.com/users/reefab/followers","following_url":"https://api.github.com/users/reefab/following{/other_user}","gists_url":"https://api.github.com/users/reefab/gists{/gist_id}","starred_url":"https://api.github.com/users/reefab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reefab/subscriptions","organizations_url":"https://api.github.com/users/reefab/orgs","repos_url":"https://api.github.com/users/reefab/repos","events_url":"https://api.github.com/users/reefab/events{/privacy}","received_events_url":"https://api.github.com/users/reefab/received_events","type":"User","site_admin":false},"labels":[{"id":457646398,"node_id":"MDU6TGFiZWw0NTc2NDYzOTg=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/breaking%20change","name":"breaking change","color":"d93f0b","default":false},{"id":527871105,"node_id":"MDU6TGFiZWw1Mjc4NzExMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":955422305,"node_id":"MDU6TGFiZWw5NTU0MjIzMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":549641476,"node_id":"MDU6TGFiZWw1NDk2NDE0NzY=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20sensor.netdata","name":"platform: sensor.netdata","color":"ededed","default":false},{"id":832964196,"node_id":"MDU6TGFiZWw4MzI5NjQxOTY=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/small-pr","name":"small-pr","color":"e5bd7e","default":false}],"state":"open","locked":false,"assignee":{"login":"fabaff","id":116184,"node_id":"MDQ6VXNlcjExNjE4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/116184?v=4","gravatar_id":"","url":"https://api.github.com/users/fabaff","html_url":"https://github.com/fabaff","followers_url":"https://api.github.com/users/fabaff/followers","following_url":"https://api.github.com/users/fabaff/following{/other_user}","gists_url":"https://api.github.com/users/fabaff/gists{/gist_id}","starred_url":"https://api.github.com/users/fabaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabaff/subscriptions","organizations_url":"https://api.github.com/users/fabaff/orgs","repos_url":"https://api.github.com/users/fabaff/repos","events_url":"https://api.github.com/users/fabaff/events{/privacy}","received_events_url":"https://api.github.com/users/fabaff/received_events","type":"User","site_admin":false},"assignees":[{"login":"fabaff","id":116184,"node_id":"MDQ6VXNlcjExNjE4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/116184?v=4","gravatar_id":"","url":"https://api.github.com/users/fabaff","html_url":"https://github.com/fabaff","followers_url":"https://api.github.com/users/fabaff/followers","following_url":"https://api.github.com/users/fabaff/following{/other_user}","gists_url":"https://api.github.com/users/fabaff/gists{/gist_id}","starred_url":"https://api.github.com/users/fabaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabaff/subscriptions","organizations_url":"https://api.github.com/users/fabaff/orgs","repos_url":"https://api.github.com/users/fabaff/repos","events_url":"https://api.github.com/users/fabaff/events{/privacy}","received_events_url":"https://api.github.com/users/fabaff/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-09-17T05:48:29Z","updated_at":"2018-09-18T21:34:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16656","html_url":"https://github.com/home-assistant/home-assistant/pull/16656","diff_url":"https://github.com/home-assistant/home-assistant/pull/16656.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/16656.patch"},"body":"## Description:\r\n\r\nCurrent Netdata component sensor configuration syntax only allows for one element per group.\r\nThis is an issue as this it is often needed to manage two different element at the same time, eg: download and upload for one network interface.\r\n\r\n**Related issue (if applicable):** ref #14897 Called for a PR on that particular issue.\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#6296\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n\r\nCurrent syntax:\r\n\r\n```yaml\r\nsensor:\r\n  - platform: netdata\r\n    resources:\r\n      snmp_router.bandwidth_eth0:\r\n        element: in\r\n        icon: mdi:download\r\n        name: Download\r\n       snmp_router.bandwidth_eth0:\r\n         element: out\r\n         icon: mdi:upload\r\n         name: Upload\r\n```\r\nDoesn't work because of the duplicated  `snmp_router.bandwidth_eth0` key.\r\n\r\nNew syntax:\r\n\r\n```yaml\r\nsensor:\r\n  - platform: netdata\r\n    host: 192.168.1.89\r\n    resources:    \r\n      Download:\r\n        data_group: snmp_router.bandwidth_eth0\r\n        element: in\r\n        icon: mdi:download\r\n      Upload:\r\n        data_group: snmp_router.bandwidth_eth0\r\n        element: out\r\n        icon: mdi:upload\r\n```\r\n\r\nThe previous `name` option is now mandatory and used as the key. As the name is used as part of the friendly name of the sensor, I'm not 100% sure if this is the right way to do it and I would like confirmation on that point.\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [x] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54"},"comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments/422563838","html_url":"https://github.com/home-assistant/home-assistant/pull/16656#issuecomment-422563838","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/16656","id":422563838,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjU2MzgzOA==","user":{"login":"fabaff","id":116184,"node_id":"MDQ6VXNlcjExNjE4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/116184?v=4","gravatar_id":"","url":"https://api.github.com/users/fabaff","html_url":"https://github.com/fabaff","followers_url":"https://api.github.com/users/fabaff/followers","following_url":"https://api.github.com/users/fabaff/following{/other_user}","gists_url":"https://api.github.com/users/fabaff/gists{/gist_id}","starred_url":"https://api.github.com/users/fabaff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabaff/subscriptions","organizations_url":"https://api.github.com/users/fabaff/orgs","repos_url":"https://api.github.com/users/fabaff/repos","events_url":"https://api.github.com/users/fabaff/events{/privacy}","received_events_url":"https://api.github.com/users/fabaff/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T21:34:02Z","updated_at":"2018-09-18T21:34:02Z","author_association":"MEMBER","body":"**Breaking change:**\r\nThe `netdata` sensor platform now supports multiple values from the same data group. This requires you to update your existing configuration:\r\n\r\n```yaml\r\nsensor:\r\n  - platform: netdata\r\n    host: 192.168.1.89\r\n    resources:    \r\n      Download:\r\n        data_group: snmp_router.bandwidth_eth0\r\n        element: in\r\n        icon: mdi:download\r\n      Upload:\r\n        data_group: snmp_router.bandwidth_eth0\r\n        element: out\r\n        icon: mdi:upload\r\n```"}}
{"actor":{"display_login":"fabaff"}}