{"action":"created","issue":{"url":"https://api.github.com/repos/ory/editor/issues/580","repository_url":"https://api.github.com/repos/ory/editor","labels_url":"https://api.github.com/repos/ory/editor/issues/580/labels{/name}","comments_url":"https://api.github.com/repos/ory/editor/issues/580/comments","events_url":"https://api.github.com/repos/ory/editor/issues/580/events","html_url":"https://github.com/ory/editor/issues/580","id":355581183,"node_id":"MDU6SXNzdWUzNTU1ODExODM=","number":580,"title":"Make plugin controls and render components replaceable ","user":{"login":"PeterKottas","id":10601911,"node_id":"MDQ6VXNlcjEwNjAxOTEx","avatar_url":"https://avatars0.githubusercontent.com/u/10601911?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterKottas","html_url":"https://github.com/PeterKottas","followers_url":"https://api.github.com/users/PeterKottas/followers","following_url":"https://api.github.com/users/PeterKottas/following{/other_user}","gists_url":"https://api.github.com/users/PeterKottas/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterKottas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterKottas/subscriptions","organizations_url":"https://api.github.com/users/PeterKottas/orgs","repos_url":"https://api.github.com/users/PeterKottas/repos","events_url":"https://api.github.com/users/PeterKottas/events{/privacy}","received_events_url":"https://api.github.com/users/PeterKottas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-08-30T13:17:55Z","updated_at":"2018-09-03T14:58:45Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Let's first talk about this. \r\nRight now I am working on the client app, place where the content is rendered but not modified. Problem is right now I am forced to install material-ui which I would like to avoid. It seems that in order for the HTML (and later react-native) renderer, this lib is not required but as both serialize/deserialize and the rest of UI is in one file, you need it even when it's not used. My thinking is we could separate it away into another file (renderer.js for example) then the plugin index.js could load and include this but you would also have an option to just load the bare-bones necessary for the rendering. It sounds simple but it seems like I might be forgetting about something, plus I am doing this AFK so I am almost sure I definitely am. Let me know your thoughts. (also this would make implementing RN much simpler)"},"comment":{"url":"https://api.github.com/repos/ory/editor/issues/comments/418138906","html_url":"https://github.com/ory/editor/issues/580#issuecomment-418138906","issue_url":"https://api.github.com/repos/ory/editor/issues/580","id":418138906,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODEzODkwNg==","user":{"login":"PeterKottas","id":10601911,"node_id":"MDQ6VXNlcjEwNjAxOTEx","avatar_url":"https://avatars0.githubusercontent.com/u/10601911?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterKottas","html_url":"https://github.com/PeterKottas","followers_url":"https://api.github.com/users/PeterKottas/followers","following_url":"https://api.github.com/users/PeterKottas/following{/other_user}","gists_url":"https://api.github.com/users/PeterKottas/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterKottas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterKottas/subscriptions","organizations_url":"https://api.github.com/users/PeterKottas/orgs","repos_url":"https://api.github.com/users/PeterKottas/repos","events_url":"https://api.github.com/users/PeterKottas/events{/privacy}","received_events_url":"https://api.github.com/users/PeterKottas/received_events","type":"User","site_admin":false},"created_at":"2018-09-03T14:58:45Z","updated_at":"2018-09-03T14:58:45Z","author_association":"CONTRIBUTOR","body":"Awesome! I though the video would help, it's just easier to explain stuff like that when you can see what I had in mind. At the moment, we made a decision to postpone react-native app for android and IOS. We will only have the web version for now. That means there's less pressure and we can think about this more. I will be out of office from 21st of September till 7th of October, I think you mentioned on another issue you are gone for the next 2 weeks. That means we can focus on this after 7th of October I guess. It's not a great deal of work, it just needs to be though of and done properly the first time around. I would also like to make sure all plugins are functions (not objects) plus like you've said, typescript will just make this an amazing, strongly typed, easy to use suite of powerful and modifiable ecosystem. Can't wait! \r\nI also like the ory-editor-mui-ui, we could maybe do a \"withMuiControls\" and \"withHtmlRendering\" high order functions that you could use to wrap plugins (and inject UI automatically). Existing stuff ahead!"}}
{"actor":{"display_login":"PeterKottas"}}