{"action":"created","comment":{"url":"https://api.github.com/repos/contao/contao/pulls/comments/242811298","pull_request_review_id":186412453,"id":242811298,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjgxMTI5OA==","diff_hunk":"@@ -599,21 +584,69 @@ public function show()\n \t\t\t\t\t\t\t$label = $i;\n \t\t\t\t\t\t}\n \n-\t\t\t\t\t\t// Always encode special characters (thanks to Oliver Klee)","path":"core-bundle/src/Resources/contao/drivers/DC_Table.php","position":58,"original_position":58,"commit_id":"b491472920aeec9d2a9253cf766fcbd902cf43c1","original_commit_id":"81747ebb08c17438471839eb698359fb0291218c","user":{"login":"qzminski","id":193483,"node_id":"MDQ6VXNlcjE5MzQ4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/193483?v=4","gravatar_id":"","url":"https://api.github.com/users/qzminski","html_url":"https://github.com/qzminski","followers_url":"https://api.github.com/users/qzminski/followers","following_url":"https://api.github.com/users/qzminski/following{/other_user}","gists_url":"https://api.github.com/users/qzminski/gists{/gist_id}","starred_url":"https://api.github.com/users/qzminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzminski/subscriptions","organizations_url":"https://api.github.com/users/qzminski/orgs","repos_url":"https://api.github.com/users/qzminski/repos","events_url":"https://api.github.com/users/qzminski/events{/privacy}","received_events_url":"https://api.github.com/users/qzminski/received_events","type":"User","site_admin":false},"body":"Of course, restored in 8788aaa0b and b491472920aeec9d2a9253cf766fcbd902cf43c1.","created_at":"2018-12-19T07:22:30Z","updated_at":"2018-12-19T07:22:30Z","html_url":"https://github.com/contao/contao/pull/235#discussion_r242811298","pull_request_url":"https://api.github.com/repos/contao/contao/pulls/235","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/contao/contao/pulls/comments/242811298"},"html":{"href":"https://github.com/contao/contao/pull/235#discussion_r242811298"},"pull_request":{"href":"https://api.github.com/repos/contao/contao/pulls/235"}},"in_reply_to_id":242687808},"pull_request":{"url":"https://api.github.com/repos/contao/contao/pulls/235","id":238374080,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4Mzc0MDgw","html_url":"https://github.com/contao/contao/pull/235","diff_url":"https://github.com/contao/contao/pull/235.diff","patch_url":"https://github.com/contao/contao/pull/235.patch","issue_url":"https://api.github.com/repos/contao/contao/issues/235","number":235,"state":"open","locked":false,"title":"[RFC] Added the onshow_callback to DC_Table","user":{"login":"qzminski","id":193483,"node_id":"MDQ6VXNlcjE5MzQ4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/193483?v=4","gravatar_id":"","url":"https://api.github.com/users/qzminski","html_url":"https://github.com/qzminski","followers_url":"https://api.github.com/users/qzminski/followers","following_url":"https://api.github.com/users/qzminski/following{/other_user}","gists_url":"https://api.github.com/users/qzminski/gists{/gist_id}","starred_url":"https://api.github.com/users/qzminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzminski/subscriptions","organizations_url":"https://api.github.com/users/qzminski/orgs","repos_url":"https://api.github.com/users/qzminski/repos","events_url":"https://api.github.com/users/qzminski/events{/privacy}","received_events_url":"https://api.github.com/users/qzminski/received_events","type":"User","site_admin":false},"body":"This adds the `onshow_callback` to `DC_Table` which can be used to alter the tables displayed in popup when clicking the `show` record operation. The syntax is as follows:\r\n\r\n```php\r\n$GLOBALS['TL_DCA']['tl_table']['config']['onshow_callback'][] = [TableListener::class, 'onShowCallback'];\r\n\r\nclass TableListener {\r\n    /**\r\n     * On data container record show callback.\r\n     * \r\n     * @param array         $data The computed table data.\r\n     * @param array         $row  The genuine row data.\r\n     * @param DataContainer $dc\r\n     *\r\n     * @return array\r\n     */\r\n    public function onShowCallback(array $data, array $row, DataContainer $dc): array \r\n    {\r\n        $data[$dc->table]['my_field']['value'] = strtoupper($row['my_field']);\r\n        \r\n        return $data;\r\n    }\r\n}\r\n```\r\n\r\nI have also tweaked a display of the `tl_undo` table a bit as you can see on the screenshot:\r\n\r\n![tl_undo](https://user-images.githubusercontent.com/193483/49938876-750ed780-fedb-11e8-9177-f911ab151777.png)\r\n\r\nThe regular view remains the same:\r\n\r\n![tl_movie](https://user-images.githubusercontent.com/193483/49938885-7e983f80-fedb-11e8-84c9-da27a1965873.png)\r\n\r\nWith regards to #225.","created_at":"2018-12-13T12:35:36Z","updated_at":"2018-12-19T07:22:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0abee940adfe16aab9017bee25c8cebedeea15d5","assignee":{"login":"qzminski","id":193483,"node_id":"MDQ6VXNlcjE5MzQ4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/193483?v=4","gravatar_id":"","url":"https://api.github.com/users/qzminski","html_url":"https://github.com/qzminski","followers_url":"https://api.github.com/users/qzminski/followers","following_url":"https://api.github.com/users/qzminski/following{/other_user}","gists_url":"https://api.github.com/users/qzminski/gists{/gist_id}","starred_url":"https://api.github.com/users/qzminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzminski/subscriptions","organizations_url":"https://api.github.com/users/qzminski/orgs","repos_url":"https://api.github.com/users/qzminski/repos","events_url":"https://api.github.com/users/qzminski/events{/privacy}","received_events_url":"https://api.github.com/users/qzminski/received_events","type":"User","site_admin":false},"assignees":[{"login":"qzminski","id":193483,"node_id":"MDQ6VXNlcjE5MzQ4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/193483?v=4","gravatar_id":"","url":"https://api.github.com/users/qzminski","html_url":"https://github.com/qzminski","followers_url":"https://api.github.com/users/qzminski/followers","following_url":"https://api.github.com/users/qzminski/following{/other_user}","gists_url":"https://api.github.com/users/qzminski/gists{/gist_id}","starred_url":"https://api.github.com/users/qzminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzminski/subscriptions","organizations_url":"https://api.github.com/users/qzminski/orgs","repos_url":"https://api.github.com/users/qzminski/repos","events_url":"https://api.github.com/users/qzminski/events{/privacy}","received_events_url":"https://api.github.com/users/qzminski/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1028270366,"node_id":"MDU6TGFiZWwxMDI4MjcwMzY2","url":"https://api.github.com/repos/contao/contao/labels/feature","name":"feature","color":"3364b7","default":false}],"milestone":{"url":"https://api.github.com/repos/contao/contao/milestones/2","html_url":"https://github.com/contao/contao/milestone/2","labels_url":"https://api.github.com/repos/contao/contao/milestones/2/labels","id":3583777,"node_id":"MDk6TWlsZXN0b25lMzU4Mzc3Nw==","number":2,"title":"4.7.0","description":"","creator":{"login":"leofeyer","id":1192057,"node_id":"MDQ6VXNlcjExOTIwNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1192057?v=4","gravatar_id":"","url":"https://api.github.com/users/leofeyer","html_url":"https://github.com/leofeyer","followers_url":"https://api.github.com/users/leofeyer/followers","following_url":"https://api.github.com/users/leofeyer/following{/other_user}","gists_url":"https://api.github.com/users/leofeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/leofeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leofeyer/subscriptions","organizations_url":"https://api.github.com/users/leofeyer/orgs","repos_url":"https://api.github.com/users/leofeyer/repos","events_url":"https://api.github.com/users/leofeyer/events{/privacy}","received_events_url":"https://api.github.com/users/leofeyer/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":35,"state":"open","created_at":"2018-08-20T14:28:40Z","updated_at":"2018-12-18T20:04:25Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/contao/contao/pulls/235/commits","review_comments_url":"https://api.github.com/repos/contao/contao/pulls/235/comments","review_comment_url":"https://api.github.com/repos/contao/contao/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contao/contao/issues/235/comments","statuses_url":"https://api.github.com/repos/contao/contao/statuses/b491472920aeec9d2a9253cf766fcbd902cf43c1","head":{"label":"qzminski:feature/dca-onshow-callback","ref":"feature/dca-onshow-callback","sha":"b491472920aeec9d2a9253cf766fcbd902cf43c1","user":{"login":"qzminski","id":193483,"node_id":"MDQ6VXNlcjE5MzQ4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/193483?v=4","gravatar_id":"","url":"https://api.github.com/users/qzminski","html_url":"https://github.com/qzminski","followers_url":"https://api.github.com/users/qzminski/followers","following_url":"https://api.github.com/users/qzminski/following{/other_user}","gists_url":"https://api.github.com/users/qzminski/gists{/gist_id}","starred_url":"https://api.github.com/users/qzminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzminski/subscriptions","organizations_url":"https://api.github.com/users/qzminski/orgs","repos_url":"https://api.github.com/users/qzminski/repos","events_url":"https://api.github.com/users/qzminski/events{/privacy}","received_events_url":"https://api.github.com/users/qzminski/received_events","type":"User","site_admin":false},"repo":{"id":145690693,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU2OTA2OTM=","name":"contao","full_name":"qzminski/contao","private":false,"owner":{"login":"qzminski","id":193483,"node_id":"MDQ6VXNlcjE5MzQ4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/193483?v=4","gravatar_id":"","url":"https://api.github.com/users/qzminski","html_url":"https://github.com/qzminski","followers_url":"https://api.github.com/users/qzminski/followers","following_url":"https://api.github.com/users/qzminski/following{/other_user}","gists_url":"https://api.github.com/users/qzminski/gists{/gist_id}","starred_url":"https://api.github.com/users/qzminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qzminski/subscriptions","organizations_url":"https://api.github.com/users/qzminski/orgs","repos_url":"https://api.github.com/users/qzminski/repos","events_url":"https://api.github.com/users/qzminski/events{/privacy}","received_events_url":"https://api.github.com/users/qzminski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/qzminski/contao","description":"Contao 4 bundles","fork":true,"url":"https://api.github.com/repos/qzminski/contao","forks_url":"https://api.github.com/repos/qzminski/contao/forks","keys_url":"https://api.github.com/repos/qzminski/contao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qzminski/contao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qzminski/contao/teams","hooks_url":"https://api.github.com/repos/qzminski/contao/hooks","issue_events_url":"https://api.github.com/repos/qzminski/contao/issues/events{/number}","events_url":"https://api.github.com/repos/qzminski/contao/events","assignees_url":"https://api.github.com/repos/qzminski/contao/assignees{/user}","branches_url":"https://api.github.com/repos/qzminski/contao/branches{/branch}","tags_url":"https://api.github.com/repos/qzminski/contao/tags","blobs_url":"https://api.github.com/repos/qzminski/contao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qzminski/contao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qzminski/contao/git/refs{/sha}","trees_url":"https://api.github.com/repos/qzminski/contao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qzminski/contao/statuses/{sha}","languages_url":"https://api.github.com/repos/qzminski/contao/languages","stargazers_url":"https://api.github.com/repos/qzminski/contao/stargazers","contributors_url":"https://api.github.com/repos/qzminski/contao/contributors","subscribers_url":"https://api.github.com/repos/qzminski/contao/subscribers","subscription_url":"https://api.github.com/repos/qzminski/contao/subscription","commits_url":"https://api.github.com/repos/qzminski/contao/commits{/sha}","git_commits_url":"https://api.github.com/repos/qzminski/contao/git/commits{/sha}","comments_url":"https://api.github.com/repos/qzminski/contao/comments{/number}","issue_comment_url":"https://api.github.com/repos/qzminski/contao/issues/comments{/number}","contents_url":"https://api.github.com/repos/qzminski/contao/contents/{+path}","compare_url":"https://api.github.com/repos/qzminski/contao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qzminski/contao/merges","archive_url":"https://api.github.com/repos/qzminski/contao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qzminski/contao/downloads","issues_url":"https://api.github.com/repos/qzminski/contao/issues{/number}","pulls_url":"https://api.github.com/repos/qzminski/contao/pulls{/number}","milestones_url":"https://api.github.com/repos/qzminski/contao/milestones{/number}","notifications_url":"https://api.github.com/repos/qzminski/contao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qzminski/contao/labels{/name}","releases_url":"https://api.github.com/repos/qzminski/contao/releases{/id}","deployments_url":"https://api.github.com/repos/qzminski/contao/deployments","created_at":"2018-08-22T10:00:30Z","updated_at":"2018-12-13T12:23:11Z","pushed_at":"2018-12-19T07:22:08Z","git_url":"git://github.com/qzminski/contao.git","ssh_url":"git@github.com:qzminski/contao.git","clone_url":"https://github.com/qzminski/contao.git","svn_url":"https://github.com/qzminski/contao","homepage":"","size":61142,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"contao:master","ref":"master","sha":"d915e9f89d161c78780c9adb4f3243b8e1d71aa4","user":{"login":"contao","id":1206136,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDYxMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1206136?v=4","gravatar_id":"","url":"https://api.github.com/users/contao","html_url":"https://github.com/contao","followers_url":"https://api.github.com/users/contao/followers","following_url":"https://api.github.com/users/contao/following{/other_user}","gists_url":"https://api.github.com/users/contao/gists{/gist_id}","starred_url":"https://api.github.com/users/contao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contao/subscriptions","organizations_url":"https://api.github.com/users/contao/orgs","repos_url":"https://api.github.com/users/contao/repos","events_url":"https://api.github.com/users/contao/events{/privacy}","received_events_url":"https://api.github.com/users/contao/received_events","type":"Organization","site_admin":false},"repo":{"id":144819408,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4MTk0MDg=","name":"contao","full_name":"contao/contao","private":false,"owner":{"login":"contao","id":1206136,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDYxMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1206136?v=4","gravatar_id":"","url":"https://api.github.com/users/contao","html_url":"https://github.com/contao","followers_url":"https://api.github.com/users/contao/followers","following_url":"https://api.github.com/users/contao/following{/other_user}","gists_url":"https://api.github.com/users/contao/gists{/gist_id}","starred_url":"https://api.github.com/users/contao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contao/subscriptions","organizations_url":"https://api.github.com/users/contao/orgs","repos_url":"https://api.github.com/users/contao/repos","events_url":"https://api.github.com/users/contao/events{/privacy}","received_events_url":"https://api.github.com/users/contao/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/contao/contao","description":"Contao 4 bundles","fork":false,"url":"https://api.github.com/repos/contao/contao","forks_url":"https://api.github.com/repos/contao/contao/forks","keys_url":"https://api.github.com/repos/contao/contao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contao/contao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contao/contao/teams","hooks_url":"https://api.github.com/repos/contao/contao/hooks","issue_events_url":"https://api.github.com/repos/contao/contao/issues/events{/number}","events_url":"https://api.github.com/repos/contao/contao/events","assignees_url":"https://api.github.com/repos/contao/contao/assignees{/user}","branches_url":"https://api.github.com/repos/contao/contao/branches{/branch}","tags_url":"https://api.github.com/repos/contao/contao/tags","blobs_url":"https://api.github.com/repos/contao/contao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contao/contao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contao/contao/git/refs{/sha}","trees_url":"https://api.github.com/repos/contao/contao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contao/contao/statuses/{sha}","languages_url":"https://api.github.com/repos/contao/contao/languages","stargazers_url":"https://api.github.com/repos/contao/contao/stargazers","contributors_url":"https://api.github.com/repos/contao/contao/contributors","subscribers_url":"https://api.github.com/repos/contao/contao/subscribers","subscription_url":"https://api.github.com/repos/contao/contao/subscription","commits_url":"https://api.github.com/repos/contao/contao/commits{/sha}","git_commits_url":"https://api.github.com/repos/contao/contao/git/commits{/sha}","comments_url":"https://api.github.com/repos/contao/contao/comments{/number}","issue_comment_url":"https://api.github.com/repos/contao/contao/issues/comments{/number}","contents_url":"https://api.github.com/repos/contao/contao/contents/{+path}","compare_url":"https://api.github.com/repos/contao/contao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contao/contao/merges","archive_url":"https://api.github.com/repos/contao/contao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contao/contao/downloads","issues_url":"https://api.github.com/repos/contao/contao/issues{/number}","pulls_url":"https://api.github.com/repos/contao/contao/pulls{/number}","milestones_url":"https://api.github.com/repos/contao/contao/milestones{/number}","notifications_url":"https://api.github.com/repos/contao/contao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contao/contao/labels{/name}","releases_url":"https://api.github.com/repos/contao/contao/releases{/id}","deployments_url":"https://api.github.com/repos/contao/contao/deployments","created_at":"2018-08-15T07:18:30Z","updated_at":"2018-12-17T09:16:59Z","pushed_at":"2018-12-19T07:22:09Z","git_url":"git://github.com/contao/contao.git","ssh_url":"git@github.com:contao/contao.git","clone_url":"https://github.com/contao/contao.git","svn_url":"https://github.com/contao/contao","homepage":"","size":61226,"stargazers_count":32,"watchers_count":32,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":28,"open_issues":59,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contao/contao/pulls/235"},"html":{"href":"https://github.com/contao/contao/pull/235"},"issue":{"href":"https://api.github.com/repos/contao/contao/issues/235"},"comments":{"href":"https://api.github.com/repos/contao/contao/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/contao/contao/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/contao/contao/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contao/contao/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/contao/contao/statuses/b491472920aeec9d2a9253cf766fcbd902cf43c1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"qzminski"}}