{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cloudstack/issues/2449","repository_url":"https://api.github.com/repos/apache/cloudstack","labels_url":"https://api.github.com/repos/apache/cloudstack/issues/2449/labels{/name}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/2449/comments","events_url":"https://api.github.com/repos/apache/cloudstack/issues/2449/events","html_url":"https://github.com/apache/cloudstack/pull/2449","id":295911851,"number":2449,"title":"WIP CLOUDSTACK-10278 idempotent column addition","user":{"login":"ernjvr","id":30108093,"avatar_url":"https://avatars3.githubusercontent.com/u/30108093?v=4","gravatar_id":"","url":"https://api.github.com/users/ernjvr","html_url":"https://github.com/ernjvr","followers_url":"https://api.github.com/users/ernjvr/followers","following_url":"https://api.github.com/users/ernjvr/following{/other_user}","gists_url":"https://api.github.com/users/ernjvr/gists{/gist_id}","starred_url":"https://api.github.com/users/ernjvr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ernjvr/subscriptions","organizations_url":"https://api.github.com/users/ernjvr/orgs","repos_url":"https://api.github.com/users/ernjvr/repos","events_url":"https://api.github.com/users/ernjvr/events{/privacy}","received_events_url":"https://api.github.com/users/ernjvr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/apache/cloudstack/milestones/5","html_url":"https://github.com/apache/cloudstack/milestone/5","labels_url":"https://api.github.com/repos/apache/cloudstack/milestones/5/labels","id":3033298,"number":5,"title":"4.11.1.0","description":"Milestone covering PRs for the next 4.11.1.0 release. All PRs using this milestone should send PR against the 4.11 branch.","creator":{"login":"DaanHoogland","id":2486961,"avatar_url":"https://avatars1.githubusercontent.com/u/2486961?v=4","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":27,"state":"open","created_at":"2018-01-13T20:06:17Z","updated_at":"2018-03-19T06:10:58Z","due_on":null,"closed_at":null},"comments":44,"created_at":"2018-02-09T15:38:17Z","updated_at":"2018-03-19T12:14:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/2449","html_url":"https://github.com/apache/cloudstack/pull/2449","diff_url":"https://github.com/apache/cloudstack/pull/2449.diff","patch_url":"https://github.com/apache/cloudstack/pull/2449.patch"},"body":"this script has been modified to add a stored procedure that allows a developer to call it in order to add a column in an idempotent manner to a table. This means that running the same script more than once will not cause an error trying to add the same column again. It will have not effect. The script needs to tested by running an upgrade from 410 to 411 and then re-run the upgrade to test if it is idempotency."},"comment":{"url":"https://api.github.com/repos/apache/cloudstack/issues/comments/374191891","html_url":"https://github.com/apache/cloudstack/pull/2449#issuecomment-374191891","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/2449","id":374191891,"user":{"login":"ernjvr","id":30108093,"avatar_url":"https://avatars3.githubusercontent.com/u/30108093?v=4","gravatar_id":"","url":"https://api.github.com/users/ernjvr","html_url":"https://github.com/ernjvr","followers_url":"https://api.github.com/users/ernjvr/followers","following_url":"https://api.github.com/users/ernjvr/following{/other_user}","gists_url":"https://api.github.com/users/ernjvr/gists{/gist_id}","starred_url":"https://api.github.com/users/ernjvr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ernjvr/subscriptions","organizations_url":"https://api.github.com/users/ernjvr/orgs","repos_url":"https://api.github.com/users/ernjvr/repos","events_url":"https://api.github.com/users/ernjvr/events{/privacy}","received_events_url":"https://api.github.com/users/ernjvr/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T12:14:39Z","updated_at":"2018-03-19T12:14:39Z","author_association":"CONTRIBUTOR","body":"@marcaurele using these stored procedures adds functionality independent of any database version. I did consider the IF NOT EXISTS option. According to the link you supplied it is only available from version 10.3.0 but the according to the installation guide \"CloudStack has been tested with MySQL 5.1 and 5.5. These versions are included in RHEL/CentOS and Ubuntu.\" The stored procedures also address foreign keys and indexes."}}
{"actor":{"display_login":"ernjvr"}}