{"action":"created","comment":{"url":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/comments/211930494","pull_request_review_id":148452477,"id":211930494,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTkzMDQ5NA==","diff_hunk":"@@ -32,6 +32,67 @@ TEST_CASE(\"change trust\", \"[tx][changetrust]\")\n     auto gateway = root.create(\"gw\", minBalance2);\n     Asset idr = makeAsset(gateway, \"IDR\");\n \n+    SECTION(\"crust tests\")\n+    {\n+        SECTION(\"create+trust\") {\n+            for_all_versions(*app, [&] {\n+                auto sk = getAccount(\"crust1\");\n+\n+                auto ca = createAccount(sk.getPublicKey(), app->getLedgerManager().getMinBalance(0) * 2);\n+                auto ct = changeTrust(idr, 10000, sk.getPublicKey());\n+\n+                REQUIRE_NOTHROW(applyTx(root.tx({ca, ct}),\n+                                        *app));\n+\n+                auto af = loadAccount(sk.getPublicKey(), *app, false);\n+\n+                auto a1 = TestAccount(*app, sk);\n+\n+                REQUIRE_NOTHROW(gateway.pay(a1, idr, 1)); \n+            });\n+        }\n+        SECTION(\"create+trust (multiple)\") {\n+            for_all_versions(*app, [&] {\n+                auto sk1 = getAccount(\"crust1\");\n+                auto sk2 = getAccount(\"crust2\");\n+\n+                auto ca1 = createAccount(sk1.getPublicKey(), app->getLedgerManager().getMinBalance(0) * 2);\n+                auto ct1 = changeTrust(idr, 10000, sk1.getPublicKey());\n+\n+                auto ca2 = createAccount(sk2.getPublicKey(), app->getLedgerManager().getMinBalance(0) * 2);\n+                auto ct2 = changeTrust(idr, 10000, sk2.getPublicKey());\n+\n+                REQUIRE_NOTHROW(applyTx(root.tx({ca1, ct1, ca2, ct2}),\n+                                        *app));\n+\n+                auto af1 = loadAccount(sk1.getPublicKey(), *app, false);\n+                auto af2 = loadAccount(sk2.getPublicKey(), *app, false);\n+\n+                auto a1 = TestAccount(*app, sk1);\n+                auto a2 = TestAccount(*app, sk2);\n+\n+                REQUIRE_NOTHROW(gateway.pay(a1, idr, 1));","path":"src/transactions/ChangeTrustTests.cpp","position":43,"original_position":43,"commit_id":"8a5fa0570ace6632a48a1b0662a371f8e84c0a61","original_commit_id":"8a5fa0570ace6632a48a1b0662a371f8e84c0a61","user":{"login":"doodyparizada","id":965572,"node_id":"MDQ6VXNlcjk2NTU3Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/965572?v=4","gravatar_id":"","url":"https://api.github.com/users/doodyparizada","html_url":"https://github.com/doodyparizada","followers_url":"https://api.github.com/users/doodyparizada/followers","following_url":"https://api.github.com/users/doodyparizada/following{/other_user}","gists_url":"https://api.github.com/users/doodyparizada/gists{/gist_id}","starred_url":"https://api.github.com/users/doodyparizada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doodyparizada/subscriptions","organizations_url":"https://api.github.com/users/doodyparizada/orgs","repos_url":"https://api.github.com/users/doodyparizada/repos","events_url":"https://api.github.com/users/doodyparizada/events{/privacy}","received_events_url":"https://api.github.com/users/doodyparizada/received_events","type":"User","site_admin":false},"body":"Maybe add a payment from a1 to a2? I want to see that transactions from a force-trusted account works","created_at":"2018-08-22T12:12:39Z","updated_at":"2018-08-22T12:12:39Z","html_url":"https://github.com/kinecosystem/stellar-core/pull/2#discussion_r211930494","pull_request_url":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/2","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/comments/211930494"},"html":{"href":"https://github.com/kinecosystem/stellar-core/pull/2#discussion_r211930494"},"pull_request":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/2","id":207205827,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MjA1ODI3","html_url":"https://github.com/kinecosystem/stellar-core/pull/2","diff_url":"https://github.com/kinecosystem/stellar-core/pull/2.diff","patch_url":"https://github.com/kinecosystem/stellar-core/pull/2.patch","issue_url":"https://api.github.com/repos/kinecosystem/stellar-core/issues/2","number":2,"state":"open","locked":false,"title":"Allow account creators to establish trust lines for the new account(s).","user":{"login":"avi-kik","id":33251112,"node_id":"MDQ6VXNlcjMzMjUxMTEy","avatar_url":"https://avatars0.githubusercontent.com/u/33251112?v=4","gravatar_id":"","url":"https://api.github.com/users/avi-kik","html_url":"https://github.com/avi-kik","followers_url":"https://api.github.com/users/avi-kik/followers","following_url":"https://api.github.com/users/avi-kik/following{/other_user}","gists_url":"https://api.github.com/users/avi-kik/gists{/gist_id}","starred_url":"https://api.github.com/users/avi-kik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avi-kik/subscriptions","organizations_url":"https://api.github.com/users/avi-kik/orgs","repos_url":"https://api.github.com/users/avi-kik/repos","events_url":"https://api.github.com/users/avi-kik/events{/privacy}","received_events_url":"https://api.github.com/users/avi-kik/received_events","type":"User","site_admin":false},"body":"A transaction which includes a `CREATE_ACCOUNT` operation may also include one or more `CHANGE_TRUST` operations for the new account.  It is unnecessary for the new account to sign the transaction.","created_at":"2018-08-09T05:39:31Z","updated_at":"2018-08-22T12:12:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e33e0bcfd6d8da837bcc76cc3c94abbebcc754e9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"oryband","id":115387,"node_id":"MDQ6VXNlcjExNTM4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/115387?v=4","gravatar_id":"","url":"https://api.github.com/users/oryband","html_url":"https://github.com/oryband","followers_url":"https://api.github.com/users/oryband/followers","following_url":"https://api.github.com/users/oryband/following{/other_user}","gists_url":"https://api.github.com/users/oryband/gists{/gist_id}","starred_url":"https://api.github.com/users/oryband/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oryband/subscriptions","organizations_url":"https://api.github.com/users/oryband/orgs","repos_url":"https://api.github.com/users/oryband/repos","events_url":"https://api.github.com/users/oryband/events{/privacy}","received_events_url":"https://api.github.com/users/oryband/received_events","type":"User","site_admin":false},{"login":"gadisr","id":454859,"node_id":"MDQ6VXNlcjQ1NDg1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/454859?v=4","gravatar_id":"","url":"https://api.github.com/users/gadisr","html_url":"https://github.com/gadisr","followers_url":"https://api.github.com/users/gadisr/followers","following_url":"https://api.github.com/users/gadisr/following{/other_user}","gists_url":"https://api.github.com/users/gadisr/gists{/gist_id}","starred_url":"https://api.github.com/users/gadisr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gadisr/subscriptions","organizations_url":"https://api.github.com/users/gadisr/orgs","repos_url":"https://api.github.com/users/gadisr/repos","events_url":"https://api.github.com/users/gadisr/events{/privacy}","received_events_url":"https://api.github.com/users/gadisr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/2/commits","review_comments_url":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/2/comments","review_comment_url":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kinecosystem/stellar-core/issues/2/comments","statuses_url":"https://api.github.com/repos/kinecosystem/stellar-core/statuses/8a5fa0570ace6632a48a1b0662a371f8e84c0a61","head":{"label":"kinecosystem:crust","ref":"crust","sha":"8a5fa0570ace6632a48a1b0662a371f8e84c0a61","user":{"login":"kinecosystem","id":28860603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODYwNjAz","avatar_url":"https://avatars2.githubusercontent.com/u/28860603?v=4","gravatar_id":"","url":"https://api.github.com/users/kinecosystem","html_url":"https://github.com/kinecosystem","followers_url":"https://api.github.com/users/kinecosystem/followers","following_url":"https://api.github.com/users/kinecosystem/following{/other_user}","gists_url":"https://api.github.com/users/kinecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/kinecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinecosystem/subscriptions","organizations_url":"https://api.github.com/users/kinecosystem/orgs","repos_url":"https://api.github.com/users/kinecosystem/repos","events_url":"https://api.github.com/users/kinecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/kinecosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":143736474,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3MzY0NzQ=","name":"stellar-core","full_name":"kinecosystem/stellar-core","owner":{"login":"kinecosystem","id":28860603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODYwNjAz","avatar_url":"https://avatars2.githubusercontent.com/u/28860603?v=4","gravatar_id":"","url":"https://api.github.com/users/kinecosystem","html_url":"https://github.com/kinecosystem","followers_url":"https://api.github.com/users/kinecosystem/followers","following_url":"https://api.github.com/users/kinecosystem/following{/other_user}","gists_url":"https://api.github.com/users/kinecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/kinecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinecosystem/subscriptions","organizations_url":"https://api.github.com/users/kinecosystem/orgs","repos_url":"https://api.github.com/users/kinecosystem/repos","events_url":"https://api.github.com/users/kinecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/kinecosystem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kinecosystem/stellar-core","description":"stellar-core is the backbone of the Stellar network. It maintains a local copy of the ledger, communicating and staying in sync with other instances of stellar-core on the network. Optionally, stellar-core can store historical records of the ledger and participate in consensus.","fork":true,"url":"https://api.github.com/repos/kinecosystem/stellar-core","forks_url":"https://api.github.com/repos/kinecosystem/stellar-core/forks","keys_url":"https://api.github.com/repos/kinecosystem/stellar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinecosystem/stellar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinecosystem/stellar-core/teams","hooks_url":"https://api.github.com/repos/kinecosystem/stellar-core/hooks","issue_events_url":"https://api.github.com/repos/kinecosystem/stellar-core/issues/events{/number}","events_url":"https://api.github.com/repos/kinecosystem/stellar-core/events","assignees_url":"https://api.github.com/repos/kinecosystem/stellar-core/assignees{/user}","branches_url":"https://api.github.com/repos/kinecosystem/stellar-core/branches{/branch}","tags_url":"https://api.github.com/repos/kinecosystem/stellar-core/tags","blobs_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinecosystem/stellar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/kinecosystem/stellar-core/languages","stargazers_url":"https://api.github.com/repos/kinecosystem/stellar-core/stargazers","contributors_url":"https://api.github.com/repos/kinecosystem/stellar-core/contributors","subscribers_url":"https://api.github.com/repos/kinecosystem/stellar-core/subscribers","subscription_url":"https://api.github.com/repos/kinecosystem/stellar-core/subscription","commits_url":"https://api.github.com/repos/kinecosystem/stellar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinecosystem/stellar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinecosystem/stellar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinecosystem/stellar-core/contents/{+path}","compare_url":"https://api.github.com/repos/kinecosystem/stellar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinecosystem/stellar-core/merges","archive_url":"https://api.github.com/repos/kinecosystem/stellar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinecosystem/stellar-core/downloads","issues_url":"https://api.github.com/repos/kinecosystem/stellar-core/issues{/number}","pulls_url":"https://api.github.com/repos/kinecosystem/stellar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/kinecosystem/stellar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/kinecosystem/stellar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinecosystem/stellar-core/labels{/name}","releases_url":"https://api.github.com/repos/kinecosystem/stellar-core/releases{/id}","deployments_url":"https://api.github.com/repos/kinecosystem/stellar-core/deployments","created_at":"2018-08-06T14:01:00Z","updated_at":"2018-08-06T14:01:05Z","pushed_at":"2018-08-22T05:28:11Z","git_url":"git://github.com/kinecosystem/stellar-core.git","ssh_url":"git@github.com:kinecosystem/stellar-core.git","clone_url":"https://github.com/kinecosystem/stellar-core.git","svn_url":"https://github.com/kinecosystem/stellar-core","homepage":"","size":15144,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kinecosystem:kin_master","ref":"kin_master","sha":"7561c1d53366ec79b908de533726269e08474f77","user":{"login":"kinecosystem","id":28860603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODYwNjAz","avatar_url":"https://avatars2.githubusercontent.com/u/28860603?v=4","gravatar_id":"","url":"https://api.github.com/users/kinecosystem","html_url":"https://github.com/kinecosystem","followers_url":"https://api.github.com/users/kinecosystem/followers","following_url":"https://api.github.com/users/kinecosystem/following{/other_user}","gists_url":"https://api.github.com/users/kinecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/kinecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinecosystem/subscriptions","organizations_url":"https://api.github.com/users/kinecosystem/orgs","repos_url":"https://api.github.com/users/kinecosystem/repos","events_url":"https://api.github.com/users/kinecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/kinecosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":143736474,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3MzY0NzQ=","name":"stellar-core","full_name":"kinecosystem/stellar-core","owner":{"login":"kinecosystem","id":28860603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODYwNjAz","avatar_url":"https://avatars2.githubusercontent.com/u/28860603?v=4","gravatar_id":"","url":"https://api.github.com/users/kinecosystem","html_url":"https://github.com/kinecosystem","followers_url":"https://api.github.com/users/kinecosystem/followers","following_url":"https://api.github.com/users/kinecosystem/following{/other_user}","gists_url":"https://api.github.com/users/kinecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/kinecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinecosystem/subscriptions","organizations_url":"https://api.github.com/users/kinecosystem/orgs","repos_url":"https://api.github.com/users/kinecosystem/repos","events_url":"https://api.github.com/users/kinecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/kinecosystem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kinecosystem/stellar-core","description":"stellar-core is the backbone of the Stellar network. It maintains a local copy of the ledger, communicating and staying in sync with other instances of stellar-core on the network. Optionally, stellar-core can store historical records of the ledger and participate in consensus.","fork":true,"url":"https://api.github.com/repos/kinecosystem/stellar-core","forks_url":"https://api.github.com/repos/kinecosystem/stellar-core/forks","keys_url":"https://api.github.com/repos/kinecosystem/stellar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinecosystem/stellar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinecosystem/stellar-core/teams","hooks_url":"https://api.github.com/repos/kinecosystem/stellar-core/hooks","issue_events_url":"https://api.github.com/repos/kinecosystem/stellar-core/issues/events{/number}","events_url":"https://api.github.com/repos/kinecosystem/stellar-core/events","assignees_url":"https://api.github.com/repos/kinecosystem/stellar-core/assignees{/user}","branches_url":"https://api.github.com/repos/kinecosystem/stellar-core/branches{/branch}","tags_url":"https://api.github.com/repos/kinecosystem/stellar-core/tags","blobs_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinecosystem/stellar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/kinecosystem/stellar-core/languages","stargazers_url":"https://api.github.com/repos/kinecosystem/stellar-core/stargazers","contributors_url":"https://api.github.com/repos/kinecosystem/stellar-core/contributors","subscribers_url":"https://api.github.com/repos/kinecosystem/stellar-core/subscribers","subscription_url":"https://api.github.com/repos/kinecosystem/stellar-core/subscription","commits_url":"https://api.github.com/repos/kinecosystem/stellar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinecosystem/stellar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinecosystem/stellar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinecosystem/stellar-core/contents/{+path}","compare_url":"https://api.github.com/repos/kinecosystem/stellar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinecosystem/stellar-core/merges","archive_url":"https://api.github.com/repos/kinecosystem/stellar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinecosystem/stellar-core/downloads","issues_url":"https://api.github.com/repos/kinecosystem/stellar-core/issues{/number}","pulls_url":"https://api.github.com/repos/kinecosystem/stellar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/kinecosystem/stellar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/kinecosystem/stellar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinecosystem/stellar-core/labels{/name}","releases_url":"https://api.github.com/repos/kinecosystem/stellar-core/releases{/id}","deployments_url":"https://api.github.com/repos/kinecosystem/stellar-core/deployments","created_at":"2018-08-06T14:01:00Z","updated_at":"2018-08-06T14:01:05Z","pushed_at":"2018-08-22T05:28:11Z","git_url":"git://github.com/kinecosystem/stellar-core.git","ssh_url":"git@github.com:kinecosystem/stellar-core.git","clone_url":"https://github.com/kinecosystem/stellar-core.git","svn_url":"https://github.com/kinecosystem/stellar-core","homepage":"","size":15144,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/2"},"html":{"href":"https://github.com/kinecosystem/stellar-core/pull/2"},"issue":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/issues/2"},"comments":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/statuses/8a5fa0570ace6632a48a1b0662a371f8e84c0a61"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"doodyparizada"}}