{"action":"created","issue":{"url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/1130","repository_url":"https://api.github.com/repos/OpenCPN/OpenCPN","labels_url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/1130/labels{/name}","comments_url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/1130/comments","events_url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/1130/events","html_url":"https://github.com/OpenCPN/OpenCPN/pull/1130","id":354092224,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTQ5OTIx","number":1130,"title":"Bundling","user":{"login":"leamas","id":405541,"node_id":"MDQ6VXNlcjQwNTU0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/405541?v=4","gravatar_id":"","url":"https://api.github.com/users/leamas","html_url":"https://github.com/leamas","followers_url":"https://api.github.com/users/leamas/followers","following_url":"https://api.github.com/users/leamas/following{/other_user}","gists_url":"https://api.github.com/users/leamas/gists{/gist_id}","starred_url":"https://api.github.com/users/leamas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leamas/subscriptions","organizations_url":"https://api.github.com/users/leamas/orgs","repos_url":"https://api.github.com/users/leamas/repos","events_url":"https://api.github.com/users/leamas/events{/privacy}","received_events_url":"https://api.github.com/users/leamas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":27,"created_at":"2018-08-26T12:47:42Z","updated_at":"2018-08-28T21:16:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OpenCPN/OpenCPN/pulls/1130","html_url":"https://github.com/OpenCPN/OpenCPN/pull/1130","diff_url":"https://github.com/OpenCPN/OpenCPN/pull/1130.diff","patch_url":"https://github.com/OpenCPN/OpenCPN/pull/1130.patch"},"body":"This PR looks for wxcurl, wxsvg, unarr, nmea0183 and lz24 using pkg-config and uses the system libs if available. Given the large number of libs here is just a manual USE_BUNDLED_LIBS master switch, by default ON on non-unix, platfoms, OFF on unix.\r\n\r\nMost of these packages are not yet available, but I have test versions and have tested the code on one platform. Have to start somewhere.\r\n\r\nThis should be reasonably safe on non-unix platforms where USE_BUNDLED_LIBS is ON by default. On Linux there might of course be one or two surprises, but the manual -DUSE_BUNDLED_LIBS=ON should be safe on all platforms.\r\n\r\nPart of the bundling issue #1124"},"comment":{"url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/comments/416743382","html_url":"https://github.com/OpenCPN/OpenCPN/pull/1130#issuecomment-416743382","issue_url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/1130","id":416743382,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjc0MzM4Mg==","user":{"login":"leamas","id":405541,"node_id":"MDQ6VXNlcjQwNTU0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/405541?v=4","gravatar_id":"","url":"https://api.github.com/users/leamas","html_url":"https://github.com/leamas","followers_url":"https://api.github.com/users/leamas/followers","following_url":"https://api.github.com/users/leamas/following{/other_user}","gists_url":"https://api.github.com/users/leamas/gists{/gist_id}","starred_url":"https://api.github.com/users/leamas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leamas/subscriptions","organizations_url":"https://api.github.com/users/leamas/orgs","repos_url":"https://api.github.com/users/leamas/repos","events_url":"https://api.github.com/users/leamas/events{/privacy}","received_events_url":"https://api.github.com/users/leamas/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T21:16:12Z","updated_at":"2018-08-28T21:16:12Z","author_association":"CONTRIBUTOR","body":"@bdbcat: technical problems solved by a nights sleep. No need change cmake version for this.\r\n\r\nNew patchset much smaller and less invasive, but needs more testing,"}}
{"actor":{"display_login":"leamas"}}