{"comment":{"url":"https://api.github.com/repos/apalos/odp/comments/27535012","html_url":"https://github.com/apalos/odp/commit/ae4d3b0bbc2f0ddcfa8aa9015228e164ebf4034f#commitcomment-27535012","id":27535012,"user":{"login":"MykytaI","id":32538337,"avatar_url":"https://avatars2.githubusercontent.com/u/32538337?v=4","gravatar_id":"","url":"https://api.github.com/users/MykytaI","html_url":"https://github.com/MykytaI","followers_url":"https://api.github.com/users/MykytaI/followers","following_url":"https://api.github.com/users/MykytaI/following{/other_user}","gists_url":"https://api.github.com/users/MykytaI/gists{/gist_id}","starred_url":"https://api.github.com/users/MykytaI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MykytaI/subscriptions","organizations_url":"https://api.github.com/users/MykytaI/orgs","repos_url":"https://api.github.com/users/MykytaI/repos","events_url":"https://api.github.com/users/MykytaI/events{/privacy}","received_events_url":"https://api.github.com/users/MykytaI/received_events","type":"User","site_admin":false},"position":127,"line":127,"path":"platform/linux-generic/odp_pcapng.c","commit_id":"ae4d3b0bbc2f0ddcfa8aa9015228e164ebf4034f","created_at":"2018-02-13T15:36:24Z","updated_at":"2018-02-13T15:36:24Z","author_association":"COLLABORATOR","body":"How do you handle incomplete reads ? Consider this: you read 64 bytes which consists of 2 complete messages and beginning of 3rd one. Then first 2 will be handled, and portion of 3rd message discarded. All upcoming reads will return 'corrupt' data after that.\r\n\r\nWould it be better to read(sizeof(inotify_event)) followed by read(event->len) ? This is most dumb and reliable approach I guess ..."}}
{"actor":{"display_login":"MykytaI"}}