{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/3685","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/3685/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3685/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/3685/events","html_url":"https://github.com/codice/ddf/pull/3685","id":356109128,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNDgyNzk4","number":3685,"title":"[2.13.x] DDF-3903 The IdP should add its entity ID in the NameQualifier field of all Persistent Identifiers","user":{"login":"blen-desta","id":29550062,"node_id":"MDQ6VXNlcjI5NTUwMDYy","avatar_url":"https://avatars0.githubusercontent.com/u/29550062?v=4","gravatar_id":"","url":"https://api.github.com/users/blen-desta","html_url":"https://github.com/blen-desta","followers_url":"https://api.github.com/users/blen-desta/followers","following_url":"https://api.github.com/users/blen-desta/following{/other_user}","gists_url":"https://api.github.com/users/blen-desta/gists{/gist_id}","starred_url":"https://api.github.com/users/blen-desta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blen-desta/subscriptions","organizations_url":"https://api.github.com/users/blen-desta/orgs","repos_url":"https://api.github.com/users/blen-desta/repos","events_url":"https://api.github.com/users/blen-desta/events{/privacy}","received_events_url":"https://api.github.com/users/blen-desta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/codice/ddf/milestones/23","html_url":"https://github.com/codice/ddf/milestone/23","labels_url":"https://api.github.com/repos/codice/ddf/milestones/23/labels","id":3566137,"node_id":"MDk6TWlsZXN0b25lMzU2NjEzNw==","number":23,"title":"2.13.2","description":"","creator":{"login":"clockard","id":5248090,"node_id":"MDQ6VXNlcjUyNDgwOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5248090?v=4","gravatar_id":"","url":"https://api.github.com/users/clockard","html_url":"https://github.com/clockard","followers_url":"https://api.github.com/users/clockard/followers","following_url":"https://api.github.com/users/clockard/following{/other_user}","gists_url":"https://api.github.com/users/clockard/gists{/gist_id}","starred_url":"https://api.github.com/users/clockard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clockard/subscriptions","organizations_url":"https://api.github.com/users/clockard/orgs","repos_url":"https://api.github.com/users/clockard/repos","events_url":"https://api.github.com/users/clockard/events{/privacy}","received_events_url":"https://api.github.com/users/clockard/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":9,"state":"open","created_at":"2018-08-13T15:58:34Z","updated_at":"2018-09-04T18:29:56Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2018-08-31T20:07:02Z","updated_at":"2018-09-04T19:07:33Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3685","html_url":"https://github.com/codice/ddf/pull/3685","diff_url":"https://github.com/codice/ddf/pull/3685.diff","patch_url":"https://github.com/codice/ddf/pull/3685.patch"},"body":"#### What does this PR do?\r\nBackport of https://github.com/codice/ddf/pull/3354\r\nThe IdP should add its entity ID in the NameQualifier field of all Persistent Identifiers\r\n\r\n#### Who is reviewing it? \r\n@bantillo @brjeter @bakejeyner \r\n\r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n@coyotesqrl\r\n@shaundmorris\r\n\r\n#### How should this be tested?\r\nRun the [SAML-CTK](https://github.com/codice/saml-conformance) tests against it.\r\n\r\n#### What are the relevant tickets?\r\n[DDF-3903](https://codice.atlassian.net/browse/DDF-3903)\r\n\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [x] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/418483076","html_url":"https://github.com/codice/ddf/pull/3685#issuecomment-418483076","issue_url":"https://api.github.com/repos/codice/ddf/issues/3685","id":418483076,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODQ4MzA3Ng==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-09-04T19:07:33Z","updated_at":"2018-09-04T19:07:33Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/codice/ddf/pull/3685?src=pr&el=h1) Report\n> Merging [#3685](https://codecov.io/gh/codice/ddf/pull/3685?src=pr&el=desc) into [2.13.x](https://codecov.io/gh/codice/ddf/commit/8db29bb0dcf19095f1b0d6cbadde5d60bb3d8d6b?src=pr&el=desc) will **increase** coverage by `2.26%`.\n> The diff coverage is `100%`.\n\n```diff\n@@             Coverage Diff              @@\n##             2.13.x    #3685      +/-   ##\n============================================\n+ Coverage     62.97%   65.24%   +2.26%     \n+ Complexity    15151      257   -14894     \n============================================\n  Files          1458       56    -1402     \n  Lines         84734     2889   -81845     \n  Branches       9792      505    -9287     \n============================================\n- Hits          53364     1885   -51479     \n+ Misses        27265      926   -26339     \n+ Partials       4105       78    -4027\n```\n"}}
{"actor":{"display_login":"codecov"}}