{"action":"created","issue":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/issues/129","repository_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/issues/129/labels{/name}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/issues/129/comments","events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/issues/129/events","html_url":"https://github.com/jaegertracing/jaeger-client-python/pull/129","id":299957961,"number":129,"title":"Make Metrics consistent with Go client.","user":{"login":"eundoosong","id":35110445,"avatar_url":"https://avatars2.githubusercontent.com/u/35110445?v=4","gravatar_id":"","url":"https://api.github.com/users/eundoosong","html_url":"https://github.com/eundoosong","followers_url":"https://api.github.com/users/eundoosong/followers","following_url":"https://api.github.com/users/eundoosong/following{/other_user}","gists_url":"https://api.github.com/users/eundoosong/gists{/gist_id}","starred_url":"https://api.github.com/users/eundoosong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eundoosong/subscriptions","organizations_url":"https://api.github.com/users/eundoosong/orgs","repos_url":"https://api.github.com/users/eundoosong/repos","events_url":"https://api.github.com/users/eundoosong/events{/privacy}","received_events_url":"https://api.github.com/users/eundoosong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-24T17:38:25Z","updated_at":"2018-02-26T13:34:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/pulls/129","html_url":"https://github.com/jaegertracing/jaeger-client-python/pull/129","diff_url":"https://github.com/jaegertracing/jaeger-client-python/pull/129.diff","patch_url":"https://github.com/jaegertracing/jaeger-client-python/pull/129.patch"},"body":"Make Metrics consistent with Go client.\r\n\r\nNow the metric name shows consistent with go-client as you see below prometheus test I did.\r\n- in sampler, add SamplerMetrics which has 4 types of metrics, as go-client has.\r\n- in tracer, add spans_finished \r\nIssue : #102 \r\n\r\nPlease review.\r\n\r\n```\r\n# HELP jaeger:traces jaeger:traces\r\n# TYPE jaeger:traces counter\r\njaeger:traces{sampled=\"n\",state=\"started\"} 6.0\r\njaeger:traces{sampled=\"y\",state=\"started\"} 0.0\r\njaeger:traces{sampled=\"y\",state=\"joined\"} 0.0\r\njaeger:traces{sampled=\"n\",state=\"joined\"} 0.0\r\n# HELP jaeger:sampler_updates jaeger:sampler_updates\r\n# TYPE jaeger:sampler_updates counter\r\njaeger:sampler_updates{result=\"err\"} 0.0\r\njaeger:sampler_updates{result=\"ok\"} 0.0\r\n# HELP python_info Python platform information\r\n# TYPE python_info gauge\r\npython_info{implementation=\"CPython\",major=\"2\",minor=\"7\",patchlevel=\"10\",version=\"2.7.10\"} 1.0\r\n# HELP jaeger:sampler_queries jaeger:sampler_queries\r\n# TYPE jaeger:sampler_queries counter\r\njaeger:sampler_queries{result=\"err\"} 0.0\r\njaeger:sampler_queries{result=\"ok\"} 0.0\r\n# HELP jaeger:started_spans jaeger:started_spans\r\n# TYPE jaeger:started_spans counter\r\njaeger:started_spans{sampled=\"n\"} 12.0\r\njaeger:started_spans{sampled=\"y\"} 0.0\r\n# HELP jaeger:finished_spans jaeger:finished_spans\r\n# TYPE jaeger:finished_spans counter\r\njaeger:finished_spans 0.0\r\n# HELP jaeger:reporter_spans jaeger:reporter_spans\r\n# TYPE jaeger:reporter_spans counter\r\njaeger:reporter_spans{result=\"dropped\"} 0.0\r\njaeger:reporter_spans{result=\"socket_error\"} 0.0\r\njaeger:reporter_spans{result=\"err\"} 0.0\r\njaeger:reporter_spans{result=\"ok\"} 0.0\r\n```\r\n\r\nSigned-off-by: eundoo-song <eundoo.song@gmail.com>"},"comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/issues/comments/368505282","html_url":"https://github.com/jaegertracing/jaeger-client-python/pull/129#issuecomment-368505282","issue_url":"https://api.github.com/repos/jaegertracing/jaeger-client-python/issues/129","id":368505282,"user":{"login":"jpkrohling","id":13387,"avatar_url":"https://avatars2.githubusercontent.com/u/13387?v=4","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false},"created_at":"2018-02-26T13:34:17Z","updated_at":"2018-02-26T13:34:17Z","author_association":"MEMBER","body":"LGTM. Looks like the Python version is missing a gauge (`reporter_queue_length`) and has an extra counter (`jaeger:reporter_spans{'result': 'socket_error}`), but I think those differences are OK."}}
{"actor":{"display_login":"jpkrohling"}}