{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/8242","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/8242/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/8242/comments","events_url":"https://api.github.com/repos/istio/istio/issues/8242/events","html_url":"https://github.com/istio/istio/pull/8242","id":354017038,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTA1MjI5","number":8242,"title":"Fix data races in TestAdsReconnectWithNonce and Discovery","user":{"login":"ymesika","id":26809068,"node_id":"MDQ6VXNlcjI2ODA5MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/26809068?v=4","gravatar_id":"","url":"https://api.github.com/users/ymesika","html_url":"https://github.com/ymesika","followers_url":"https://api.github.com/users/ymesika/followers","following_url":"https://api.github.com/users/ymesika/following{/other_user}","gists_url":"https://api.github.com/users/ymesika/gists{/gist_id}","starred_url":"https://api.github.com/users/ymesika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymesika/subscriptions","organizations_url":"https://api.github.com/users/ymesika/orgs","repos_url":"https://api.github.com/users/ymesika/repos","events_url":"https://api.github.com/users/ymesika/events{/privacy}","received_events_url":"https://api.github.com/users/ymesika/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-25T14:33:39Z","updated_at":"2018-08-26T07:15:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/8242","html_url":"https://github.com/istio/istio/pull/8242","diff_url":"https://github.com/istio/istio/pull/8242.diff","patch_url":"https://github.com/istio/istio/pull/8242.patch"},"body":"`racetest` has been steadily failing since changes to `push_context.go` began modifying the VirtualService fields. The changes introduced a data race between these writes and Monitor's read of the same configs.\r\n\r\nExample of failed racetest: https://k8s-gubernator.appspot.com/build/istio-circleci/racetest/168014\r\n\r\nThis PR is also fixing one more (unrelated) race errors I encounters in `discover.go` while testing the changes of this PR."},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/416019297","html_url":"https://github.com/istio/istio/pull/8242#issuecomment-416019297","issue_url":"https://api.github.com/repos/istio/istio/issues/8242","id":416019297,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjAxOTI5Nw==","user":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2018-08-26T07:15:24Z","updated_at":"2018-08-26T07:15:24Z","author_association":"COLLABORATOR","body":"@ymesika: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nprow/istio-pilot-multicluster-e2e.sh | 73445e1c1e718b14b6458faea8fa5f7fd50e89f5 | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/8242/istio-pilot-multicluster-e2e/1060/) | `/test istio-pilot-multicluster-e2e`\nprow/istio-unit-tests.sh | fe82d2954995fe26f06a17622e97f6a6713eeacf | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/8242/istio-unit-tests/12282/) | `/test istio-unit-tests`\nprow/e2e-mixer-no_auth.sh | fe82d2954995fe26f06a17622e97f6a6713eeacf | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/8242/e2e-mixer-no_auth/3226/) | `/test e2e-mixer-no_auth`\nprow/e2e-bookInfoTests-v1alpha3.sh | fe82d2954995fe26f06a17622e97f6a6713eeacf | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/8242/e2e-bookInfoTests-envoyv2-v1alpha3/5432/) | `/test e2e-bookInfo-envoyv2-v1alpha3`\nprow/e2e-simpleTests.sh | fe82d2954995fe26f06a17622e97f6a6713eeacf | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/8242/e2e-simpleTests/8431/) | `/test e2e-simple`\nprow/e2e-dashboard.sh | fe82d2954995fe26f06a17622e97f6a6713eeacf | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/8242/e2e-dashboard/3063/) | `/test e2e-dashboard`\nprow/istio-pilot-e2e-envoyv2-v1alpha3.sh | fe82d2954995fe26f06a17622e97f6a6713eeacf | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/8242/istio-pilot-e2e-envoyv2-v1alpha3/6240/) | `/test istio-pilot-e2e-envoyv2-v1alpha3`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"istio-testing"}}