{"action":"created","comment":{"url":"https://api.github.com/repos/websockets/ws/pulls/comments/166037512","pull_request_review_id":94055218,"id":166037512,"diff_hunk":"@@ -724,4 +724,24 @@ describe('WebSocketServer', function () {\n       });\n     });\n   });\n+\n+  describe('Server address', function () {","path":"test/websocket-server.test.js","position":5,"original_position":5,"commit_id":"3b4f12498cba46013e5af1f9e8dfe86b88f881ce","original_commit_id":"3b4f12498cba46013e5af1f9e8dfe86b88f881ce","user":{"login":"lpinca","id":1443911,"avatar_url":"https://avatars0.githubusercontent.com/u/1443911?v=4","gravatar_id":"","url":"https://api.github.com/users/lpinca","html_url":"https://github.com/lpinca","followers_url":"https://api.github.com/users/lpinca/followers","following_url":"https://api.github.com/users/lpinca/following{/other_user}","gists_url":"https://api.github.com/users/lpinca/gists{/gist_id}","starred_url":"https://api.github.com/users/lpinca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpinca/subscriptions","organizations_url":"https://api.github.com/users/lpinca/orgs","repos_url":"https://api.github.com/users/lpinca/repos","events_url":"https://api.github.com/users/lpinca/events{/privacy}","received_events_url":"https://api.github.com/users/lpinca/received_events","type":"User","site_admin":false},"body":"Please move this block after `describe('#ctor', ...);` and use `'#address'` as title","created_at":"2018-02-05T16:57:24Z","updated_at":"2018-02-05T16:57:43Z","html_url":"https://github.com/websockets/ws/pull/1294#discussion_r166037512","pull_request_url":"https://api.github.com/repos/websockets/ws/pulls/1294","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/websockets/ws/pulls/comments/166037512"},"html":{"href":"https://github.com/websockets/ws/pull/1294#discussion_r166037512"},"pull_request":{"href":"https://api.github.com/repos/websockets/ws/pulls/1294"}}},"pull_request":{"url":"https://api.github.com/repos/websockets/ws/pulls/1294","id":167019791,"html_url":"https://github.com/websockets/ws/pull/1294","diff_url":"https://github.com/websockets/ws/pull/1294.diff","patch_url":"https://github.com/websockets/ws/pull/1294.patch","issue_url":"https://api.github.com/repos/websockets/ws/issues/1294","number":1294,"state":"open","locked":false,"title":"Provide http server port directly from _server","user":{"login":"tspn","id":7426678,"avatar_url":"https://avatars0.githubusercontent.com/u/7426678?v=4","gravatar_id":"","url":"https://api.github.com/users/tspn","html_url":"https://github.com/tspn","followers_url":"https://api.github.com/users/tspn/followers","following_url":"https://api.github.com/users/tspn/following{/other_user}","gists_url":"https://api.github.com/users/tspn/gists{/gist_id}","starred_url":"https://api.github.com/users/tspn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tspn/subscriptions","organizations_url":"https://api.github.com/users/tspn/orgs","repos_url":"https://api.github.com/users/tspn/repos","events_url":"https://api.github.com/users/tspn/events{/privacy}","received_events_url":"https://api.github.com/users/tspn/received_events","type":"User","site_admin":false},"body":"Provide http server port directly from _server\r\n\r\nDo I need to write test or anything else to complete this PR ?\r\nOr better way to get port if I bind with 0\r\n\r\nThanks","created_at":"2018-02-04T17:17:33Z","updated_at":"2018-02-05T16:57:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dce6896c2a64cea466d0e281763b6cd995009b04","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/websockets/ws/pulls/1294/commits","review_comments_url":"https://api.github.com/repos/websockets/ws/pulls/1294/comments","review_comment_url":"https://api.github.com/repos/websockets/ws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/websockets/ws/issues/1294/comments","statuses_url":"https://api.github.com/repos/websockets/ws/statuses/3b4f12498cba46013e5af1f9e8dfe86b88f881ce","head":{"label":"tspn:feature/server-port","ref":"feature/server-port","sha":"3b4f12498cba46013e5af1f9e8dfe86b88f881ce","user":{"login":"tspn","id":7426678,"avatar_url":"https://avatars0.githubusercontent.com/u/7426678?v=4","gravatar_id":"","url":"https://api.github.com/users/tspn","html_url":"https://github.com/tspn","followers_url":"https://api.github.com/users/tspn/followers","following_url":"https://api.github.com/users/tspn/following{/other_user}","gists_url":"https://api.github.com/users/tspn/gists{/gist_id}","starred_url":"https://api.github.com/users/tspn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tspn/subscriptions","organizations_url":"https://api.github.com/users/tspn/orgs","repos_url":"https://api.github.com/users/tspn/repos","events_url":"https://api.github.com/users/tspn/events{/privacy}","received_events_url":"https://api.github.com/users/tspn/received_events","type":"User","site_admin":false},"repo":{"id":120204780,"name":"ws","full_name":"tspn/ws","owner":{"login":"tspn","id":7426678,"avatar_url":"https://avatars0.githubusercontent.com/u/7426678?v=4","gravatar_id":"","url":"https://api.github.com/users/tspn","html_url":"https://github.com/tspn","followers_url":"https://api.github.com/users/tspn/followers","following_url":"https://api.github.com/users/tspn/following{/other_user}","gists_url":"https://api.github.com/users/tspn/gists{/gist_id}","starred_url":"https://api.github.com/users/tspn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tspn/subscriptions","organizations_url":"https://api.github.com/users/tspn/orgs","repos_url":"https://api.github.com/users/tspn/repos","events_url":"https://api.github.com/users/tspn/events{/privacy}","received_events_url":"https://api.github.com/users/tspn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tspn/ws","description":"Simple to use, blazing fast and thoroughly tested WebSocket client and server for Node.js","fork":true,"url":"https://api.github.com/repos/tspn/ws","forks_url":"https://api.github.com/repos/tspn/ws/forks","keys_url":"https://api.github.com/repos/tspn/ws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tspn/ws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tspn/ws/teams","hooks_url":"https://api.github.com/repos/tspn/ws/hooks","issue_events_url":"https://api.github.com/repos/tspn/ws/issues/events{/number}","events_url":"https://api.github.com/repos/tspn/ws/events","assignees_url":"https://api.github.com/repos/tspn/ws/assignees{/user}","branches_url":"https://api.github.com/repos/tspn/ws/branches{/branch}","tags_url":"https://api.github.com/repos/tspn/ws/tags","blobs_url":"https://api.github.com/repos/tspn/ws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tspn/ws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tspn/ws/git/refs{/sha}","trees_url":"https://api.github.com/repos/tspn/ws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tspn/ws/statuses/{sha}","languages_url":"https://api.github.com/repos/tspn/ws/languages","stargazers_url":"https://api.github.com/repos/tspn/ws/stargazers","contributors_url":"https://api.github.com/repos/tspn/ws/contributors","subscribers_url":"https://api.github.com/repos/tspn/ws/subscribers","subscription_url":"https://api.github.com/repos/tspn/ws/subscription","commits_url":"https://api.github.com/repos/tspn/ws/commits{/sha}","git_commits_url":"https://api.github.com/repos/tspn/ws/git/commits{/sha}","comments_url":"https://api.github.com/repos/tspn/ws/comments{/number}","issue_comment_url":"https://api.github.com/repos/tspn/ws/issues/comments{/number}","contents_url":"https://api.github.com/repos/tspn/ws/contents/{+path}","compare_url":"https://api.github.com/repos/tspn/ws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tspn/ws/merges","archive_url":"https://api.github.com/repos/tspn/ws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tspn/ws/downloads","issues_url":"https://api.github.com/repos/tspn/ws/issues{/number}","pulls_url":"https://api.github.com/repos/tspn/ws/pulls{/number}","milestones_url":"https://api.github.com/repos/tspn/ws/milestones{/number}","notifications_url":"https://api.github.com/repos/tspn/ws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tspn/ws/labels{/name}","releases_url":"https://api.github.com/repos/tspn/ws/releases{/id}","deployments_url":"https://api.github.com/repos/tspn/ws/deployments","created_at":"2018-02-04T17:03:35Z","updated_at":"2018-02-04T17:03:38Z","pushed_at":"2018-02-05T16:14:12Z","git_url":"git://github.com/tspn/ws.git","ssh_url":"git@github.com:tspn/ws.git","clone_url":"https://github.com/tspn/ws.git","svn_url":"https://github.com/tspn/ws","homepage":"","size":8222,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"websockets:master","ref":"master","sha":"66b0d553d146cfc9fa17c93f954d2540667b4731","user":{"login":"websockets","id":10721323,"avatar_url":"https://avatars0.githubusercontent.com/u/10721323?v=4","gravatar_id":"","url":"https://api.github.com/users/websockets","html_url":"https://github.com/websockets","followers_url":"https://api.github.com/users/websockets/followers","following_url":"https://api.github.com/users/websockets/following{/other_user}","gists_url":"https://api.github.com/users/websockets/gists{/gist_id}","starred_url":"https://api.github.com/users/websockets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/websockets/subscriptions","organizations_url":"https://api.github.com/users/websockets/orgs","repos_url":"https://api.github.com/users/websockets/repos","events_url":"https://api.github.com/users/websockets/events{/privacy}","received_events_url":"https://api.github.com/users/websockets/received_events","type":"Organization","site_admin":false},"repo":{"id":2744972,"name":"ws","full_name":"websockets/ws","owner":{"login":"websockets","id":10721323,"avatar_url":"https://avatars0.githubusercontent.com/u/10721323?v=4","gravatar_id":"","url":"https://api.github.com/users/websockets","html_url":"https://github.com/websockets","followers_url":"https://api.github.com/users/websockets/followers","following_url":"https://api.github.com/users/websockets/following{/other_user}","gists_url":"https://api.github.com/users/websockets/gists{/gist_id}","starred_url":"https://api.github.com/users/websockets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/websockets/subscriptions","organizations_url":"https://api.github.com/users/websockets/orgs","repos_url":"https://api.github.com/users/websockets/repos","events_url":"https://api.github.com/users/websockets/events{/privacy}","received_events_url":"https://api.github.com/users/websockets/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/websockets/ws","description":"Simple to use, blazing fast and thoroughly tested WebSocket client and server for Node.js","fork":false,"url":"https://api.github.com/repos/websockets/ws","forks_url":"https://api.github.com/repos/websockets/ws/forks","keys_url":"https://api.github.com/repos/websockets/ws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/websockets/ws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/websockets/ws/teams","hooks_url":"https://api.github.com/repos/websockets/ws/hooks","issue_events_url":"https://api.github.com/repos/websockets/ws/issues/events{/number}","events_url":"https://api.github.com/repos/websockets/ws/events","assignees_url":"https://api.github.com/repos/websockets/ws/assignees{/user}","branches_url":"https://api.github.com/repos/websockets/ws/branches{/branch}","tags_url":"https://api.github.com/repos/websockets/ws/tags","blobs_url":"https://api.github.com/repos/websockets/ws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/websockets/ws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/websockets/ws/git/refs{/sha}","trees_url":"https://api.github.com/repos/websockets/ws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/websockets/ws/statuses/{sha}","languages_url":"https://api.github.com/repos/websockets/ws/languages","stargazers_url":"https://api.github.com/repos/websockets/ws/stargazers","contributors_url":"https://api.github.com/repos/websockets/ws/contributors","subscribers_url":"https://api.github.com/repos/websockets/ws/subscribers","subscription_url":"https://api.github.com/repos/websockets/ws/subscription","commits_url":"https://api.github.com/repos/websockets/ws/commits{/sha}","git_commits_url":"https://api.github.com/repos/websockets/ws/git/commits{/sha}","comments_url":"https://api.github.com/repos/websockets/ws/comments{/number}","issue_comment_url":"https://api.github.com/repos/websockets/ws/issues/comments{/number}","contents_url":"https://api.github.com/repos/websockets/ws/contents/{+path}","compare_url":"https://api.github.com/repos/websockets/ws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/websockets/ws/merges","archive_url":"https://api.github.com/repos/websockets/ws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/websockets/ws/downloads","issues_url":"https://api.github.com/repos/websockets/ws/issues{/number}","pulls_url":"https://api.github.com/repos/websockets/ws/pulls{/number}","milestones_url":"https://api.github.com/repos/websockets/ws/milestones{/number}","notifications_url":"https://api.github.com/repos/websockets/ws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/websockets/ws/labels{/name}","releases_url":"https://api.github.com/repos/websockets/ws/releases{/id}","deployments_url":"https://api.github.com/repos/websockets/ws/deployments","created_at":"2011-11-09T22:32:45Z","updated_at":"2018-02-05T15:47:14Z","pushed_at":"2018-02-05T16:14:14Z","git_url":"git://github.com/websockets/ws.git","ssh_url":"git@github.com:websockets/ws.git","clone_url":"https://github.com/websockets/ws.git","svn_url":"https://github.com/websockets/ws","homepage":"","size":8210,"stargazers_count":7546,"watchers_count":7546,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1109,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1109,"open_issues":20,"watchers":7546,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/websockets/ws/pulls/1294"},"html":{"href":"https://github.com/websockets/ws/pull/1294"},"issue":{"href":"https://api.github.com/repos/websockets/ws/issues/1294"},"comments":{"href":"https://api.github.com/repos/websockets/ws/issues/1294/comments"},"review_comments":{"href":"https://api.github.com/repos/websockets/ws/pulls/1294/comments"},"review_comment":{"href":"https://api.github.com/repos/websockets/ws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/websockets/ws/pulls/1294/commits"},"statuses":{"href":"https://api.github.com/repos/websockets/ws/statuses/3b4f12498cba46013e5af1f9e8dfe86b88f881ce"}},"author_association":"NONE"}}
{"actor":{"display_login":"lpinca"}}