{"action":"created","comment":{"url":"https://api.github.com/repos/skyfielders/python-skyfield/pulls/comments/176949581","pull_request_review_id":106739168,"id":176949581,"diff_hunk":"@@ -152,18 +151,61 @@ def separation_from(self, another_icrf):\n         c = dots(u1, u2)\n         return Angle(radians=arccos(clip(c, -1.0, 1.0)))\n \n-    def ecliptic_position(self):\n-        \"\"\"Compute J2000 ecliptic coordinates (x, y, z)\"\"\"\n-        vector = _ECLIPJ2000.dot(self.position.au)\n-        return Distance(vector)\n+    def ecliptic_xyz(self, epoch=None):","path":"skyfield/positionlib.py","position":17,"original_position":17,"commit_id":"44e2ea1796cd3f643b128b01fdce5b3ac28db867","original_commit_id":"44e2ea1796cd3f643b128b01fdce5b3ac28db867","user":{"login":"GammaSagittarii","id":32195338,"avatar_url":"https://avatars2.githubusercontent.com/u/32195338?v=4","gravatar_id":"","url":"https://api.github.com/users/GammaSagittarii","html_url":"https://github.com/GammaSagittarii","followers_url":"https://api.github.com/users/GammaSagittarii/followers","following_url":"https://api.github.com/users/GammaSagittarii/following{/other_user}","gists_url":"https://api.github.com/users/GammaSagittarii/gists{/gist_id}","starred_url":"https://api.github.com/users/GammaSagittarii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GammaSagittarii/subscriptions","organizations_url":"https://api.github.com/users/GammaSagittarii/orgs","repos_url":"https://api.github.com/users/GammaSagittarii/repos","events_url":"https://api.github.com/users/GammaSagittarii/events{/privacy}","received_events_url":"https://api.github.com/users/GammaSagittarii/received_events","type":"User","site_admin":false},"body":"This should pose no problem.","created_at":"2018-03-25T18:39:30Z","updated_at":"2018-03-25T18:39:30Z","html_url":"https://github.com/skyfielders/python-skyfield/pull/141#discussion_r176949581","pull_request_url":"https://api.github.com/repos/skyfielders/python-skyfield/pulls/141","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/skyfielders/python-skyfield/pulls/comments/176949581"},"html":{"href":"https://github.com/skyfielders/python-skyfield/pull/141#discussion_r176949581"},"pull_request":{"href":"https://api.github.com/repos/skyfielders/python-skyfield/pulls/141"}},"in_reply_to_id":176949273},"pull_request":{"url":"https://api.github.com/repos/skyfielders/python-skyfield/pulls/141","id":142604943,"html_url":"https://github.com/skyfielders/python-skyfield/pull/141","diff_url":"https://github.com/skyfielders/python-skyfield/pull/141.diff","patch_url":"https://github.com/skyfielders/python-skyfield/pull/141.patch","issue_url":"https://api.github.com/repos/skyfielders/python-skyfield/issues/141","number":141,"state":"open","locked":false,"title":"#106 support ecliptic coordinates for the epoch of date","user":{"login":"GammaSagittarii","id":32195338,"avatar_url":"https://avatars2.githubusercontent.com/u/32195338?v=4","gravatar_id":"","url":"https://api.github.com/users/GammaSagittarii","html_url":"https://github.com/GammaSagittarii","followers_url":"https://api.github.com/users/GammaSagittarii/followers","following_url":"https://api.github.com/users/GammaSagittarii/following{/other_user}","gists_url":"https://api.github.com/users/GammaSagittarii/gists{/gist_id}","starred_url":"https://api.github.com/users/GammaSagittarii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GammaSagittarii/subscriptions","organizations_url":"https://api.github.com/users/GammaSagittarii/orgs","repos_url":"https://api.github.com/users/GammaSagittarii/repos","events_url":"https://api.github.com/users/GammaSagittarii/events{/privacy}","received_events_url":"https://api.github.com/users/GammaSagittarii/received_events","type":"User","site_admin":false},"body":"This is basically an implementation of what novas equ2ecl function does, and we get results as expected when equ2ecl function is called for the true equator and equinox of date.\r\n\r\nI have not provided the ability to ask for coordinates for non epoch of date as ecliptic coordinates are by their nature very much tied to the dynamical system, I hope that is not a problem. \r\n\r\nHowever, we still do not match jpl horizons, because we do not match them for apparent coordinates for the epoch of date, (for example in ra, dec form) and as far as I can tell that is because they use iau76 constants, as is theorized in this discussion [https://github.com/oorb/oorb/issues/16](url) . I think because of this, matching horizons deserves its own issue.","created_at":"2017-09-22T15:19:29Z","updated_at":"2018-03-25T18:39:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3d1119409fbc89211c224ca2cd9a558280586b6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/skyfielders/python-skyfield/pulls/141/commits","review_comments_url":"https://api.github.com/repos/skyfielders/python-skyfield/pulls/141/comments","review_comment_url":"https://api.github.com/repos/skyfielders/python-skyfield/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skyfielders/python-skyfield/issues/141/comments","statuses_url":"https://api.github.com/repos/skyfielders/python-skyfield/statuses/44e2ea1796cd3f643b128b01fdce5b3ac28db867","head":{"label":"GammaSagittarii:Issue106","ref":"Issue106","sha":"44e2ea1796cd3f643b128b01fdce5b3ac28db867","user":{"login":"GammaSagittarii","id":32195338,"avatar_url":"https://avatars2.githubusercontent.com/u/32195338?v=4","gravatar_id":"","url":"https://api.github.com/users/GammaSagittarii","html_url":"https://github.com/GammaSagittarii","followers_url":"https://api.github.com/users/GammaSagittarii/followers","following_url":"https://api.github.com/users/GammaSagittarii/following{/other_user}","gists_url":"https://api.github.com/users/GammaSagittarii/gists{/gist_id}","starred_url":"https://api.github.com/users/GammaSagittarii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GammaSagittarii/subscriptions","organizations_url":"https://api.github.com/users/GammaSagittarii/orgs","repos_url":"https://api.github.com/users/GammaSagittarii/repos","events_url":"https://api.github.com/users/GammaSagittarii/events{/privacy}","received_events_url":"https://api.github.com/users/GammaSagittarii/received_events","type":"User","site_admin":false},"repo":{"id":104464347,"name":"python-skyfield","full_name":"GammaSagittarii/python-skyfield","owner":{"login":"GammaSagittarii","id":32195338,"avatar_url":"https://avatars2.githubusercontent.com/u/32195338?v=4","gravatar_id":"","url":"https://api.github.com/users/GammaSagittarii","html_url":"https://github.com/GammaSagittarii","followers_url":"https://api.github.com/users/GammaSagittarii/followers","following_url":"https://api.github.com/users/GammaSagittarii/following{/other_user}","gists_url":"https://api.github.com/users/GammaSagittarii/gists{/gist_id}","starred_url":"https://api.github.com/users/GammaSagittarii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GammaSagittarii/subscriptions","organizations_url":"https://api.github.com/users/GammaSagittarii/orgs","repos_url":"https://api.github.com/users/GammaSagittarii/repos","events_url":"https://api.github.com/users/GammaSagittarii/events{/privacy}","received_events_url":"https://api.github.com/users/GammaSagittarii/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GammaSagittarii/python-skyfield","description":"Elegant astronomy for Python","fork":true,"url":"https://api.github.com/repos/GammaSagittarii/python-skyfield","forks_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/forks","keys_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/teams","hooks_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/hooks","issue_events_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/issues/events{/number}","events_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/events","assignees_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/assignees{/user}","branches_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/branches{/branch}","tags_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/tags","blobs_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/git/refs{/sha}","trees_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/statuses/{sha}","languages_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/languages","stargazers_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/stargazers","contributors_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/contributors","subscribers_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/subscribers","subscription_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/subscription","commits_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/commits{/sha}","git_commits_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/git/commits{/sha}","comments_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/comments{/number}","issue_comment_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/issues/comments{/number}","contents_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/contents/{+path}","compare_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/merges","archive_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/downloads","issues_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/issues{/number}","pulls_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/pulls{/number}","milestones_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/milestones{/number}","notifications_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/labels{/name}","releases_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/releases{/id}","deployments_url":"https://api.github.com/repos/GammaSagittarii/python-skyfield/deployments","created_at":"2017-09-22T10:52:25Z","updated_at":"2017-09-22T10:52:26Z","pushed_at":"2017-09-26T13:24:48Z","git_url":"git://github.com/GammaSagittarii/python-skyfield.git","ssh_url":"git@github.com:GammaSagittarii/python-skyfield.git","clone_url":"https://github.com/GammaSagittarii/python-skyfield.git","svn_url":"https://github.com/GammaSagittarii/python-skyfield","homepage":null,"size":1466,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"skyfielders:master","ref":"master","sha":"242e7d37fb9418093abc8e15dd6939ba58a9cdf2","user":{"login":"skyfielders","id":11967071,"avatar_url":"https://avatars2.githubusercontent.com/u/11967071?v=4","gravatar_id":"","url":"https://api.github.com/users/skyfielders","html_url":"https://github.com/skyfielders","followers_url":"https://api.github.com/users/skyfielders/followers","following_url":"https://api.github.com/users/skyfielders/following{/other_user}","gists_url":"https://api.github.com/users/skyfielders/gists{/gist_id}","starred_url":"https://api.github.com/users/skyfielders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyfielders/subscriptions","organizations_url":"https://api.github.com/users/skyfielders/orgs","repos_url":"https://api.github.com/users/skyfielders/repos","events_url":"https://api.github.com/users/skyfielders/events{/privacy}","received_events_url":"https://api.github.com/users/skyfielders/received_events","type":"Organization","site_admin":false},"repo":{"id":7924113,"name":"python-skyfield","full_name":"skyfielders/python-skyfield","owner":{"login":"skyfielders","id":11967071,"avatar_url":"https://avatars2.githubusercontent.com/u/11967071?v=4","gravatar_id":"","url":"https://api.github.com/users/skyfielders","html_url":"https://github.com/skyfielders","followers_url":"https://api.github.com/users/skyfielders/followers","following_url":"https://api.github.com/users/skyfielders/following{/other_user}","gists_url":"https://api.github.com/users/skyfielders/gists{/gist_id}","starred_url":"https://api.github.com/users/skyfielders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyfielders/subscriptions","organizations_url":"https://api.github.com/users/skyfielders/orgs","repos_url":"https://api.github.com/users/skyfielders/repos","events_url":"https://api.github.com/users/skyfielders/events{/privacy}","received_events_url":"https://api.github.com/users/skyfielders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skyfielders/python-skyfield","description":"Elegant astronomy for Python","fork":false,"url":"https://api.github.com/repos/skyfielders/python-skyfield","forks_url":"https://api.github.com/repos/skyfielders/python-skyfield/forks","keys_url":"https://api.github.com/repos/skyfielders/python-skyfield/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skyfielders/python-skyfield/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skyfielders/python-skyfield/teams","hooks_url":"https://api.github.com/repos/skyfielders/python-skyfield/hooks","issue_events_url":"https://api.github.com/repos/skyfielders/python-skyfield/issues/events{/number}","events_url":"https://api.github.com/repos/skyfielders/python-skyfield/events","assignees_url":"https://api.github.com/repos/skyfielders/python-skyfield/assignees{/user}","branches_url":"https://api.github.com/repos/skyfielders/python-skyfield/branches{/branch}","tags_url":"https://api.github.com/repos/skyfielders/python-skyfield/tags","blobs_url":"https://api.github.com/repos/skyfielders/python-skyfield/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skyfielders/python-skyfield/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skyfielders/python-skyfield/git/refs{/sha}","trees_url":"https://api.github.com/repos/skyfielders/python-skyfield/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skyfielders/python-skyfield/statuses/{sha}","languages_url":"https://api.github.com/repos/skyfielders/python-skyfield/languages","stargazers_url":"https://api.github.com/repos/skyfielders/python-skyfield/stargazers","contributors_url":"https://api.github.com/repos/skyfielders/python-skyfield/contributors","subscribers_url":"https://api.github.com/repos/skyfielders/python-skyfield/subscribers","subscription_url":"https://api.github.com/repos/skyfielders/python-skyfield/subscription","commits_url":"https://api.github.com/repos/skyfielders/python-skyfield/commits{/sha}","git_commits_url":"https://api.github.com/repos/skyfielders/python-skyfield/git/commits{/sha}","comments_url":"https://api.github.com/repos/skyfielders/python-skyfield/comments{/number}","issue_comment_url":"https://api.github.com/repos/skyfielders/python-skyfield/issues/comments{/number}","contents_url":"https://api.github.com/repos/skyfielders/python-skyfield/contents/{+path}","compare_url":"https://api.github.com/repos/skyfielders/python-skyfield/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skyfielders/python-skyfield/merges","archive_url":"https://api.github.com/repos/skyfielders/python-skyfield/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skyfielders/python-skyfield/downloads","issues_url":"https://api.github.com/repos/skyfielders/python-skyfield/issues{/number}","pulls_url":"https://api.github.com/repos/skyfielders/python-skyfield/pulls{/number}","milestones_url":"https://api.github.com/repos/skyfielders/python-skyfield/milestones{/number}","notifications_url":"https://api.github.com/repos/skyfielders/python-skyfield/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skyfielders/python-skyfield/labels{/name}","releases_url":"https://api.github.com/repos/skyfielders/python-skyfield/releases{/id}","deployments_url":"https://api.github.com/repos/skyfielders/python-skyfield/deployments","created_at":"2013-01-30T21:19:21Z","updated_at":"2018-03-25T17:56:51Z","pushed_at":"2018-03-25T17:56:49Z","git_url":"git://github.com/skyfielders/python-skyfield.git","ssh_url":"git@github.com:skyfielders/python-skyfield.git","clone_url":"https://github.com/skyfielders/python-skyfield.git","svn_url":"https://github.com/skyfielders/python-skyfield","homepage":null,"size":1501,"stargazers_count":218,"watchers_count":218,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":44,"open_issues":42,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skyfielders/python-skyfield/pulls/141"},"html":{"href":"https://github.com/skyfielders/python-skyfield/pull/141"},"issue":{"href":"https://api.github.com/repos/skyfielders/python-skyfield/issues/141"},"comments":{"href":"https://api.github.com/repos/skyfielders/python-skyfield/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/skyfielders/python-skyfield/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/skyfielders/python-skyfield/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skyfielders/python-skyfield/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/skyfielders/python-skyfield/statuses/44e2ea1796cd3f643b128b01fdce5b3ac28db867"}},"author_association":"NONE"}}
{"actor":{"display_login":"GammaSagittarii"}}