{"action":"created","issue":{"url":"https://api.github.com/repos/justinrainbow/json-schema/issues/517","repository_url":"https://api.github.com/repos/justinrainbow/json-schema","labels_url":"https://api.github.com/repos/justinrainbow/json-schema/issues/517/labels{/name}","comments_url":"https://api.github.com/repos/justinrainbow/json-schema/issues/517/comments","events_url":"https://api.github.com/repos/justinrainbow/json-schema/issues/517/events","html_url":"https://github.com/justinrainbow/json-schema/issues/517","id":325908220,"number":517,"title":"Const & enum deep comparison is not strictly typed","user":{"login":"erayd","id":121486,"avatar_url":"https://avatars3.githubusercontent.com/u/121486?v=4","gravatar_id":"","url":"https://api.github.com/users/erayd","html_url":"https://github.com/erayd","followers_url":"https://api.github.com/users/erayd/followers","following_url":"https://api.github.com/users/erayd/following{/other_user}","gists_url":"https://api.github.com/users/erayd/gists{/gist_id}","starred_url":"https://api.github.com/users/erayd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erayd/subscriptions","organizations_url":"https://api.github.com/users/erayd/orgs","repos_url":"https://api.github.com/users/erayd/repos","events_url":"https://api.github.com/users/erayd/events{/privacy}","received_events_url":"https://api.github.com/users/erayd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-23T23:19:36Z","updated_at":"2018-05-24T01:01:01Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The `const` implementation from #507, and the existing `enum` implementation, [does not properly compare objects](https://github.com/justinrainbow/json-schema/pull/507#discussion_r182204595). Objects are compared in a loosely-typed manner (`==`), which also results in a loosely-typed comparison of all members.\r\n\r\nThis behavior is incorrect, and results in spec violations. For example, `\"string\" == true` returns true, despite being clearly invalid - both the type and content are completely different."},"comment":{"url":"https://api.github.com/repos/justinrainbow/json-schema/issues/comments/391554152","html_url":"https://github.com/justinrainbow/json-schema/issues/517#issuecomment-391554152","issue_url":"https://api.github.com/repos/justinrainbow/json-schema/issues/517","id":391554152,"user":{"login":"erayd","id":121486,"avatar_url":"https://avatars3.githubusercontent.com/u/121486?v=4","gravatar_id":"","url":"https://api.github.com/users/erayd","html_url":"https://github.com/erayd","followers_url":"https://api.github.com/users/erayd/followers","following_url":"https://api.github.com/users/erayd/following{/other_user}","gists_url":"https://api.github.com/users/erayd/gists{/gist_id}","starred_url":"https://api.github.com/users/erayd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erayd/subscriptions","organizations_url":"https://api.github.com/users/erayd/orgs","repos_url":"https://api.github.com/users/erayd/repos","events_url":"https://api.github.com/users/erayd/events{/privacy}","received_events_url":"https://api.github.com/users/erayd/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T01:01:01Z","updated_at":"2018-05-24T01:01:01Z","author_association":"CONTRIBUTOR","body":"Please! I'm flat out right now..."}}
{"actor":{"display_login":"erayd"}}