{"action":"created","comment":{"url":"https://api.github.com/repos/signalapp/Signal-Desktop/pulls/comments/169793455","pull_request_review_id":98346038,"id":169793455,"diff_hunk":"@@ -609,6 +612,281 @@ input[type=text], input[type=search], textarea {\n   }\n }\n \n+.full-screen-flow {\n+  z-index: 1000;\n+  position: absolute;\n+  left: 0;\n+  right: 0;\n+  top: 0;\n+  bottom: 0;\n+  font-family: roboto-light;\n+\n+  color: black;\n+  a {\n+    color: $signal-blue;\n+  }\n+  background: linear-gradient(\n+    to bottom,\n+    rgb(238,238,238) 0%, // (1 - 0.41) * 255 + 0.41 * 213\n+    rgb(243,243,243) 12%, // (1 - 0.19) * 255 + 0.19 * 191\n+    rgb(255,255,255) 27%,\n+    rgb(255,255,255) 60%,\n+    rgb(249,249,249) 85%, // (1 - 0.19) * 255 + 0.19 * 222\n+    rgb(213,213,213) 100% // (1 - 0.27) * 255 + 0.27 * 98\n+  );\n+  display: flex;\n+  align-items: center;\n+  text-align: center;\n+\n+  font-size: 10pt;","path":"stylesheets/_global.scss","position":46,"original_position":46,"commit_id":"5f49dd1fe317aaa599ea19d92f50db671d6d6864","original_commit_id":"3a203052336f30d507618f1b45be8a9ffaee974d","user":{"login":"gasi","id":49583,"avatar_url":"https://avatars3.githubusercontent.com/u/49583?v=4","gravatar_id":"","url":"https://api.github.com/users/gasi","html_url":"https://github.com/gasi","followers_url":"https://api.github.com/users/gasi/followers","following_url":"https://api.github.com/users/gasi/following{/other_user}","gists_url":"https://api.github.com/users/gasi/gists{/gist_id}","starred_url":"https://api.github.com/users/gasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasi/subscriptions","organizations_url":"https://api.github.com/users/gasi/orgs","repos_url":"https://api.github.com/users/gasi/repos","events_url":"https://api.github.com/users/gasi/events{/privacy}","received_events_url":"https://api.github.com/users/gasi/received_events","type":"User","site_admin":false},"body":"When do use `em` vs `px` vs `pt`?","created_at":"2018-02-21T22:06:30Z","updated_at":"2018-02-21T22:23:47Z","html_url":"https://github.com/signalapp/Signal-Desktop/pull/2053#discussion_r169793455","pull_request_url":"https://api.github.com/repos/signalapp/Signal-Desktop/pulls/2053","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/signalapp/Signal-Desktop/pulls/comments/169793455"},"html":{"href":"https://github.com/signalapp/Signal-Desktop/pull/2053#discussion_r169793455"},"pull_request":{"href":"https://api.github.com/repos/signalapp/Signal-Desktop/pulls/2053"}}},"pull_request":{"url":"https://api.github.com/repos/signalapp/Signal-Desktop/pulls/2053","id":169762866,"html_url":"https://github.com/signalapp/Signal-Desktop/pull/2053","diff_url":"https://github.com/signalapp/Signal-Desktop/pull/2053.diff","patch_url":"https://github.com/signalapp/Signal-Desktop/pull/2053.patch","issue_url":"https://api.github.com/repos/signalapp/Signal-Desktop/issues/2053","number":2053,"state":"open","locked":false,"title":"WIP: Streamlined import: new visual design, 'light' import","user":{"login":"scottnonnenberg","id":443005,"avatar_url":"https://avatars2.githubusercontent.com/u/443005?v=4","gravatar_id":"","url":"https://api.github.com/users/scottnonnenberg","html_url":"https://github.com/scottnonnenberg","followers_url":"https://api.github.com/users/scottnonnenberg/followers","following_url":"https://api.github.com/users/scottnonnenberg/following{/other_user}","gists_url":"https://api.github.com/users/scottnonnenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/scottnonnenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottnonnenberg/subscriptions","organizations_url":"https://api.github.com/users/scottnonnenberg/orgs","repos_url":"https://api.github.com/users/scottnonnenberg/repos","events_url":"https://api.github.com/users/scottnonnenberg/events{/privacy}","received_events_url":"https://api.github.com/users/scottnonnenberg/received_events","type":"User","site_admin":false},"body":"Changes:\r\n- When not set up, the app opens directly into the install screen, which has been streamlined. The `--import` command-line argument will cause the app to open directly into the import flow.\r\n- A new design for the install flow. It features:\r\n  - Immediate entry into the QR code screen\r\n  - Animated dots to show that we're loading the QR code from the server\r\n  - Fewer screens: 1) QR 2) device name 3) sync-in-progress\r\n- A new design for the (dev-only) standalone registration view\r\n- A new design for the import flow. It features:\r\n  - Icons at the top of every screen\r\n  - Gray background, blue buttons, thinner text\r\n  - Simpler copy\r\n- At the end of a light import, we hand off to the normal device link screen, starting at the QR code.\r\n- `Whisper.Backup.backupToDirectory()` takes an options object so you can tell it to do a light export.\r\n- `Whisper.Backup.importFromDirectory()` takes an options object so you can force it to load only the light components found on disk. It also returns an object so you can tell whether a given import was a full import or light import.\r\n- On start of import, we build a list of all the ids present in the messages, conversations, and groups stores in IndexedDB. This can take some time if a lot of data is in the database already, but it makes the subsequent import very fast\r\n- Disappearing messages are now excluded when exporting\r\n- Remove some TODOs in the tests\r\n\r\nStill to do:\r\n- [ ] Escape valves in OS menu: import, link, and standalone (in dev mode)","created_at":"2018-02-17T02:07:01Z","updated_at":"2018-02-21T22:23:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef524bc35974d336a143e9d5726685dd32defdc8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/signalapp/Signal-Desktop/pulls/2053/commits","review_comments_url":"https://api.github.com/repos/signalapp/Signal-Desktop/pulls/2053/comments","review_comment_url":"https://api.github.com/repos/signalapp/Signal-Desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/signalapp/Signal-Desktop/issues/2053/comments","statuses_url":"https://api.github.com/repos/signalapp/Signal-Desktop/statuses/5f49dd1fe317aaa599ea19d92f50db671d6d6864","head":{"label":"signalapp:streamlined-import","ref":"streamlined-import","sha":"5f49dd1fe317aaa599ea19d92f50db671d6d6864","user":{"login":"signalapp","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"repo":{"id":17148588,"name":"Signal-Desktop","full_name":"signalapp/Signal-Desktop","owner":{"login":"signalapp","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalapp/Signal-Desktop","description":"Signal Private Messenger for Windows, Mac, and Linux","fork":false,"url":"https://api.github.com/repos/signalapp/Signal-Desktop","forks_url":"https://api.github.com/repos/signalapp/Signal-Desktop/forks","keys_url":"https://api.github.com/repos/signalapp/Signal-Desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalapp/Signal-Desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalapp/Signal-Desktop/teams","hooks_url":"https://api.github.com/repos/signalapp/Signal-Desktop/hooks","issue_events_url":"https://api.github.com/repos/signalapp/Signal-Desktop/issues/events{/number}","events_url":"https://api.github.com/repos/signalapp/Signal-Desktop/events","assignees_url":"https://api.github.com/repos/signalapp/Signal-Desktop/assignees{/user}","branches_url":"https://api.github.com/repos/signalapp/Signal-Desktop/branches{/branch}","tags_url":"https://api.github.com/repos/signalapp/Signal-Desktop/tags","blobs_url":"https://api.github.com/repos/signalapp/Signal-Desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalapp/Signal-Desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalapp/Signal-Desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalapp/Signal-Desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalapp/Signal-Desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/signalapp/Signal-Desktop/languages","stargazers_url":"https://api.github.com/repos/signalapp/Signal-Desktop/stargazers","contributors_url":"https://api.github.com/repos/signalapp/Signal-Desktop/contributors","subscribers_url":"https://api.github.com/repos/signalapp/Signal-Desktop/subscribers","subscription_url":"https://api.github.com/repos/signalapp/Signal-Desktop/subscription","commits_url":"https://api.github.com/repos/signalapp/Signal-Desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalapp/Signal-Desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalapp/Signal-Desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalapp/Signal-Desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalapp/Signal-Desktop/contents/{+path}","compare_url":"https://api.github.com/repos/signalapp/Signal-Desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalapp/Signal-Desktop/merges","archive_url":"https://api.github.com/repos/signalapp/Signal-Desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalapp/Signal-Desktop/downloads","issues_url":"https://api.github.com/repos/signalapp/Signal-Desktop/issues{/number}","pulls_url":"https://api.github.com/repos/signalapp/Signal-Desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/signalapp/Signal-Desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/signalapp/Signal-Desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalapp/Signal-Desktop/labels{/name}","releases_url":"https://api.github.com/repos/signalapp/Signal-Desktop/releases{/id}","deployments_url":"https://api.github.com/repos/signalapp/Signal-Desktop/deployments","created_at":"2014-02-24T19:53:36Z","updated_at":"2018-02-21T21:25:56Z","pushed_at":"2018-02-21T22:18:09Z","git_url":"git://github.com/signalapp/Signal-Desktop.git","ssh_url":"git@github.com:signalapp/Signal-Desktop.git","clone_url":"https://github.com/signalapp/Signal-Desktop.git","svn_url":"https://github.com/signalapp/Signal-Desktop","homepage":"https://signal.org/download","size":54039,"stargazers_count":3067,"watchers_count":3067,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":543,"mirror_url":null,"archived":false,"open_issues_count":330,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":543,"open_issues":330,"watchers":3067,"default_branch":"development"}},"base":{"label":"signalapp:development","ref":"development","sha":"be5cbc9d2b22f66d89c311958d9c61abbf847cbc","user":{"login":"signalapp","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"repo":{"id":17148588,"name":"Signal-Desktop","full_name":"signalapp/Signal-Desktop","owner":{"login":"signalapp","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/signalapp","html_url":"https://github.com/signalapp","followers_url":"https://api.github.com/users/signalapp/followers","following_url":"https://api.github.com/users/signalapp/following{/other_user}","gists_url":"https://api.github.com/users/signalapp/gists{/gist_id}","starred_url":"https://api.github.com/users/signalapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/signalapp/subscriptions","organizations_url":"https://api.github.com/users/signalapp/orgs","repos_url":"https://api.github.com/users/signalapp/repos","events_url":"https://api.github.com/users/signalapp/events{/privacy}","received_events_url":"https://api.github.com/users/signalapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/signalapp/Signal-Desktop","description":"Signal Private Messenger for Windows, Mac, and Linux","fork":false,"url":"https://api.github.com/repos/signalapp/Signal-Desktop","forks_url":"https://api.github.com/repos/signalapp/Signal-Desktop/forks","keys_url":"https://api.github.com/repos/signalapp/Signal-Desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/signalapp/Signal-Desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/signalapp/Signal-Desktop/teams","hooks_url":"https://api.github.com/repos/signalapp/Signal-Desktop/hooks","issue_events_url":"https://api.github.com/repos/signalapp/Signal-Desktop/issues/events{/number}","events_url":"https://api.github.com/repos/signalapp/Signal-Desktop/events","assignees_url":"https://api.github.com/repos/signalapp/Signal-Desktop/assignees{/user}","branches_url":"https://api.github.com/repos/signalapp/Signal-Desktop/branches{/branch}","tags_url":"https://api.github.com/repos/signalapp/Signal-Desktop/tags","blobs_url":"https://api.github.com/repos/signalapp/Signal-Desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/signalapp/Signal-Desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/signalapp/Signal-Desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/signalapp/Signal-Desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/signalapp/Signal-Desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/signalapp/Signal-Desktop/languages","stargazers_url":"https://api.github.com/repos/signalapp/Signal-Desktop/stargazers","contributors_url":"https://api.github.com/repos/signalapp/Signal-Desktop/contributors","subscribers_url":"https://api.github.com/repos/signalapp/Signal-Desktop/subscribers","subscription_url":"https://api.github.com/repos/signalapp/Signal-Desktop/subscription","commits_url":"https://api.github.com/repos/signalapp/Signal-Desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/signalapp/Signal-Desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/signalapp/Signal-Desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/signalapp/Signal-Desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/signalapp/Signal-Desktop/contents/{+path}","compare_url":"https://api.github.com/repos/signalapp/Signal-Desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/signalapp/Signal-Desktop/merges","archive_url":"https://api.github.com/repos/signalapp/Signal-Desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/signalapp/Signal-Desktop/downloads","issues_url":"https://api.github.com/repos/signalapp/Signal-Desktop/issues{/number}","pulls_url":"https://api.github.com/repos/signalapp/Signal-Desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/signalapp/Signal-Desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/signalapp/Signal-Desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/signalapp/Signal-Desktop/labels{/name}","releases_url":"https://api.github.com/repos/signalapp/Signal-Desktop/releases{/id}","deployments_url":"https://api.github.com/repos/signalapp/Signal-Desktop/deployments","created_at":"2014-02-24T19:53:36Z","updated_at":"2018-02-21T21:25:56Z","pushed_at":"2018-02-21T22:18:09Z","git_url":"git://github.com/signalapp/Signal-Desktop.git","ssh_url":"git@github.com:signalapp/Signal-Desktop.git","clone_url":"https://github.com/signalapp/Signal-Desktop.git","svn_url":"https://github.com/signalapp/Signal-Desktop","homepage":"https://signal.org/download","size":54039,"stargazers_count":3067,"watchers_count":3067,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":543,"mirror_url":null,"archived":false,"open_issues_count":330,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":543,"open_issues":330,"watchers":3067,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/signalapp/Signal-Desktop/pulls/2053"},"html":{"href":"https://github.com/signalapp/Signal-Desktop/pull/2053"},"issue":{"href":"https://api.github.com/repos/signalapp/Signal-Desktop/issues/2053"},"comments":{"href":"https://api.github.com/repos/signalapp/Signal-Desktop/issues/2053/comments"},"review_comments":{"href":"https://api.github.com/repos/signalapp/Signal-Desktop/pulls/2053/comments"},"review_comment":{"href":"https://api.github.com/repos/signalapp/Signal-Desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/signalapp/Signal-Desktop/pulls/2053/commits"},"statuses":{"href":"https://api.github.com/repos/signalapp/Signal-Desktop/statuses/5f49dd1fe317aaa599ea19d92f50db671d6d6864"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gasi"}}