{"action":"created","issue":{"url":"https://api.github.com/repos/webextension-toolbox/webextension-toolbox/issues/57","repository_url":"https://api.github.com/repos/webextension-toolbox/webextension-toolbox","labels_url":"https://api.github.com/repos/webextension-toolbox/webextension-toolbox/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/webextension-toolbox/webextension-toolbox/issues/57/comments","events_url":"https://api.github.com/repos/webextension-toolbox/webextension-toolbox/issues/57/events","html_url":"https://github.com/webextension-toolbox/webextension-toolbox/issues/57","id":336000361,"node_id":"MDU6SXNzdWUzMzYwMDAzNjE=","number":57,"title":"Should we disable minification?","user":{"login":"HaNdTriX","id":1265681,"node_id":"MDQ6VXNlcjEyNjU2ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1265681?v=4","gravatar_id":"","url":"https://api.github.com/users/HaNdTriX","html_url":"https://github.com/HaNdTriX","followers_url":"https://api.github.com/users/HaNdTriX/followers","following_url":"https://api.github.com/users/HaNdTriX/following{/other_user}","gists_url":"https://api.github.com/users/HaNdTriX/gists{/gist_id}","starred_url":"https://api.github.com/users/HaNdTriX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaNdTriX/subscriptions","organizations_url":"https://api.github.com/users/HaNdTriX/orgs","repos_url":"https://api.github.com/users/HaNdTriX/repos","events_url":"https://api.github.com/users/HaNdTriX/events{/privacy}","received_events_url":"https://api.github.com/users/HaNdTriX/received_events","type":"User","site_admin":false},"labels":[{"id":795185642,"node_id":"MDU6TGFiZWw3OTUxODU2NDI=","url":"https://api.github.com/repos/webextension-toolbox/webextension-toolbox/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-06-26T21:38:06Z","updated_at":"2018-08-17T15:42:31Z","closed_at":null,"author_association":"COLLABORATOR","body":"### Problem\r\n\r\nSome webstores doesn't like it, when extension code is minified.\r\nThis makes their review more complex.\r\n\r\n### Possible solutions\r\n\r\nA. Disable minification\r\nC. Enable minification (everything stays the same)\r\nB. Add an cli flag to leave it up to the user (default will be disabled)\r\nD. Add an cli flag to leave it up to the user (default will be enabled)\r\n\r\n### Related docs\r\n\r\nhttps://webpack.js.org/configuration/optimization/\r\n\r\n### Open questions\r\n\r\nDoes tree shaking and dead code elimination still work if minification is disabled? If not can we enable it somehow?\r\n\r\nWhat do you think?\r\n"},"comment":{"url":"https://api.github.com/repos/webextension-toolbox/webextension-toolbox/issues/comments/413905964","html_url":"https://github.com/webextension-toolbox/webextension-toolbox/issues/57#issuecomment-413905964","issue_url":"https://api.github.com/repos/webextension-toolbox/webextension-toolbox/issues/57","id":413905964,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzkwNTk2NA==","user":{"login":"JimMorrison723","id":506946,"node_id":"MDQ6VXNlcjUwNjk0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/506946?v=4","gravatar_id":"","url":"https://api.github.com/users/JimMorrison723","html_url":"https://github.com/JimMorrison723","followers_url":"https://api.github.com/users/JimMorrison723/followers","following_url":"https://api.github.com/users/JimMorrison723/following{/other_user}","gists_url":"https://api.github.com/users/JimMorrison723/gists{/gist_id}","starred_url":"https://api.github.com/users/JimMorrison723/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimMorrison723/subscriptions","organizations_url":"https://api.github.com/users/JimMorrison723/orgs","repos_url":"https://api.github.com/users/JimMorrison723/repos","events_url":"https://api.github.com/users/JimMorrison723/events{/privacy}","received_events_url":"https://api.github.com/users/JimMorrison723/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T15:42:31Z","updated_at":"2018-08-17T15:42:31Z","author_association":"CONTRIBUTOR","body":"I'd say go with option D.\r\nNo need to complicate things (and build a not minified version with cli flag is fine)"}}
{"actor":{"display_login":"JimMorrison723"}}