{"action":"created","issue":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/3107","repository_url":"https://api.github.com/repos/triplea-game/triplea","labels_url":"https://api.github.com/repos/triplea-game/triplea/issues/3107/labels{/name}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/3107/comments","events_url":"https://api.github.com/repos/triplea-game/triplea/issues/3107/events","html_url":"https://github.com/triplea-game/triplea/pull/3107","id":299399162,"number":3107,"title":"Remove reflection, correctly this time","user":{"login":"RoiEXLab","id":8350879,"avatar_url":"https://avatars0.githubusercontent.com/u/8350879?v=4","gravatar_id":"","url":"https://api.github.com/users/RoiEXLab","html_url":"https://github.com/RoiEXLab","followers_url":"https://api.github.com/users/RoiEXLab/followers","following_url":"https://api.github.com/users/RoiEXLab/following{/other_user}","gists_url":"https://api.github.com/users/RoiEXLab/gists{/gist_id}","starred_url":"https://api.github.com/users/RoiEXLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoiEXLab/subscriptions","organizations_url":"https://api.github.com/users/RoiEXLab/orgs","repos_url":"https://api.github.com/users/RoiEXLab/repos","events_url":"https://api.github.com/users/RoiEXLab/events{/privacy}","received_events_url":"https://api.github.com/users/RoiEXLab/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-22T15:35:33Z","updated_at":"2018-02-22T16:30:05Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/3107","html_url":"https://github.com/triplea-game/triplea/pull/3107","diff_url":"https://github.com/triplea-game/triplea/pull/3107.diff","patch_url":"https://github.com/triplea-game/triplea/pull/3107.patch"},"body":"Follow up of #3042\r\nTested a game of TWW played by AI, no errors were observed, testing is welcome and well needed probably (although it shoul really just work ^^)\r\nI recommend viewing the first couple commits and the general refactoring commits independently, I renamed the AttachmentProperty interface to ModifiableProperty, which is probably 90% of the diff.\r\n\r\nDisclaimer: I know I'm bad at naming things, so feel free to suggest better names"},"comment":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/comments/367737883","html_url":"https://github.com/triplea-game/triplea/pull/3107#issuecomment-367737883","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/3107","id":367737883,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-02-22T16:30:05Z","updated_at":"2018-02-22T16:30:05Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/triplea-game/triplea/pull/3107?src=pr&el=h1) Report\n> Merging [#3107](https://codecov.io/gh/triplea-game/triplea/pull/3107?src=pr&el=desc) into [master](https://codecov.io/gh/triplea-game/triplea/commit/a018209122974a35c373afc1dbd76bdd1e7366ba?src=pr&el=desc) will **decrease** coverage by `0.41%`.\n> The diff coverage is `91.01%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/triplea-game/triplea/pull/3107/graphs/tree.svg?width=650&src=pr&token=QPS14q4xnG&height=150)](https://codecov.io/gh/triplea-game/triplea/pull/3107?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff             @@\n##             master   #3107      +/-   ##\n===========================================\n- Coverage     21.31%   20.9%   -0.42%     \n+ Complexity     5860    5660     -200     \n===========================================\n  Files           822     822              \n  Lines         73297   73324      +27     \n  Branches      11973   11970       -3     \n===========================================\n- Hits          15623   15325     -298     \n- Misses        55583   55912     +329     \n+ Partials       2091    2087       -4\n```\n\n\n| [Impacted Files](https://codecov.io/gh/triplea-game/triplea/pull/3107?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [...n/java/games/strategy/engine/data/IAttachment.java](https://codecov.io/gh/triplea-game/triplea/pull/3107/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvZW5naW5lL2RhdGEvSUF0dGFjaG1lbnQuamF2YQ==) | `0% <ø> (-100%)` | `0 <0> (-1)` | |\n| [...tegy/triplea/attachments/UserActionAttachment.java](https://codecov.io/gh/triplea-game/triplea/pull/3107/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvdHJpcGxlYS9hdHRhY2htZW50cy9Vc2VyQWN0aW9uQXR0YWNobWVudC5qYXZh) | `3.33% <0%> (ø)` | `1 <0> (ø)` | :arrow_down: |\n| [...main/java/tools/map/making/MapPropertyWrapper.java](https://codecov.io/gh/triplea-game/triplea/pull/3107/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvdG9vbHMvbWFwL21ha2luZy9NYXBQcm9wZXJ0eVdyYXBwZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...ne/data/changefactory/AttachmentPropertyReset.java](https://codecov.io/gh/triplea-game/triplea/pull/3107/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvZW5naW5lL2RhdGEvY2hhbmdlZmFjdG9yeS9BdHRhY2htZW50UHJvcGVydHlSZXNldC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...ata/changefactory/AttachmentPropertyResetUndo.java](https://codecov.io/gh/triplea-game/triplea/pull/3107/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvZW5naW5lL2RhdGEvY2hhbmdlZmFjdG9yeS9BdHRhY2htZW50UHJvcGVydHlSZXNldFVuZG8uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [.../strategy/triplea/attachments/CanalAttachment.java](https://codecov.io/gh/triplea-game/triplea/pull/3107/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvdHJpcGxlYS9hdHRhY2htZW50cy9DYW5hbEF0dGFjaG1lbnQuamF2YQ==) | `53.48% <100%> (ø)` | `19 <1> (ø)` | :arrow_down: |\n| [...ngine/data/changefactory/ObjectPropertyChange.java](https://codecov.io/gh/triplea-game/triplea/pull/3107/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvZW5naW5lL2RhdGEvY2hhbmdlZmFjdG9yeS9PYmplY3RQcm9wZXJ0eUNoYW5nZS5qYXZh) | `78.94% <100%> (ø)` | `4 <2> (ø)` | :arrow_down: |\n| [...s/strategy/triplea/attachments/UnitAttachment.java](https://codecov.io/gh/triplea-game/triplea/pull/3107/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvdHJpcGxlYS9hdHRhY2htZW50cy9Vbml0QXR0YWNobWVudC5qYXZh) | `39.58% <100%> (-8.78%)` | `233 <1> (-96)` | |\n| [...triplea/attachments/AbstractTriggerAttachment.java](https://codecov.io/gh/triplea-game/triplea/pull/3107/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvdHJpcGxlYS9hdHRhY2htZW50cy9BYnN0cmFjdFRyaWdnZXJBdHRhY2htZW50LmphdmE=) | `39.55% <100%> (-7.47%)` | `30 <1> (-5)` | |\n| [...y/triplea/attachments/AbstractRulesAttachment.java](https://codecov.io/gh/triplea-game/triplea/pull/3107/diff?src=pr&el=tree#diff-Z2FtZS1jb3JlL3NyYy9tYWluL2phdmEvZ2FtZXMvc3RyYXRlZ3kvdHJpcGxlYS9hdHRhY2htZW50cy9BYnN0cmFjdFJ1bGVzQXR0YWNobWVudC5qYXZh) | `40.47% <100%> (-6.2%)` | `30 <1> (-8)` | |\n| ... and [42 more](https://codecov.io/gh/triplea-game/triplea/pull/3107/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/triplea-game/triplea/pull/3107?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/triplea-game/triplea/pull/3107?src=pr&el=footer). Last update [a018209...2b7c59c](https://codecov.io/gh/triplea-game/triplea/pull/3107?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}