{"action":"opened","number":136,"pull_request":{"url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/pulls/136","id":224101646,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MTAxNjQ2","html_url":"https://github.com/dart-lang/dart-protoc-plugin/pull/136","diff_url":"https://github.com/dart-lang/dart-protoc-plugin/pull/136.diff","patch_url":"https://github.com/dart-lang/dart-protoc-plugin/pull/136.patch","issue_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/issues/136","number":136,"state":"open","locked":false,"title":"Use Future and Stream over ResponseFuture and ReponseStream in clients.","user":{"login":"fuzzybinary","id":249982,"node_id":"MDQ6VXNlcjI0OTk4Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/249982?v=4","gravatar_id":"","url":"https://api.github.com/users/fuzzybinary","html_url":"https://github.com/fuzzybinary","followers_url":"https://api.github.com/users/fuzzybinary/followers","following_url":"https://api.github.com/users/fuzzybinary/following{/other_user}","gists_url":"https://api.github.com/users/fuzzybinary/gists{/gist_id}","starred_url":"https://api.github.com/users/fuzzybinary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuzzybinary/subscriptions","organizations_url":"https://api.github.com/users/fuzzybinary/orgs","repos_url":"https://api.github.com/users/fuzzybinary/repos","events_url":"https://api.github.com/users/fuzzybinary/events{/privacy}","received_events_url":"https://api.github.com/users/fuzzybinary/received_events","type":"User","site_admin":false},"body":"It appears ResponseFuture and ResponseStream are private implementaiton details of the grpc-dart library, and shouldn't be exposed as part of the interface to external users.  One of the main reasons for this is that using ResponseFuture / ResponseStream makes the gRPC Client extreamly difficult to mock for unit tests.\r\n\r\nThis fixes #135 ","created_at":"2018-10-18T21:15:24Z","updated_at":"2018-10-18T21:15:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/pulls/136/commits","review_comments_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/pulls/136/comments","review_comment_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/issues/136/comments","statuses_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/statuses/9cc95397b9dc9a4248d8b90652792bbfde830833","head":{"label":"fuzzybinary:feature/future-change","ref":"feature/future-change","sha":"9cc95397b9dc9a4248d8b90652792bbfde830833","user":{"login":"fuzzybinary","id":249982,"node_id":"MDQ6VXNlcjI0OTk4Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/249982?v=4","gravatar_id":"","url":"https://api.github.com/users/fuzzybinary","html_url":"https://github.com/fuzzybinary","followers_url":"https://api.github.com/users/fuzzybinary/followers","following_url":"https://api.github.com/users/fuzzybinary/following{/other_user}","gists_url":"https://api.github.com/users/fuzzybinary/gists{/gist_id}","starred_url":"https://api.github.com/users/fuzzybinary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuzzybinary/subscriptions","organizations_url":"https://api.github.com/users/fuzzybinary/orgs","repos_url":"https://api.github.com/users/fuzzybinary/repos","events_url":"https://api.github.com/users/fuzzybinary/events{/privacy}","received_events_url":"https://api.github.com/users/fuzzybinary/received_events","type":"User","site_admin":false},"repo":{"id":153686875,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2ODY4NzU=","name":"dart-protoc-plugin","full_name":"fuzzybinary/dart-protoc-plugin","private":false,"owner":{"login":"fuzzybinary","id":249982,"node_id":"MDQ6VXNlcjI0OTk4Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/249982?v=4","gravatar_id":"","url":"https://api.github.com/users/fuzzybinary","html_url":"https://github.com/fuzzybinary","followers_url":"https://api.github.com/users/fuzzybinary/followers","following_url":"https://api.github.com/users/fuzzybinary/following{/other_user}","gists_url":"https://api.github.com/users/fuzzybinary/gists{/gist_id}","starred_url":"https://api.github.com/users/fuzzybinary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuzzybinary/subscriptions","organizations_url":"https://api.github.com/users/fuzzybinary/orgs","repos_url":"https://api.github.com/users/fuzzybinary/repos","events_url":"https://api.github.com/users/fuzzybinary/events{/privacy}","received_events_url":"https://api.github.com/users/fuzzybinary/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fuzzybinary/dart-protoc-plugin","description":"Dart plugin for protobuf compiler (protoc)","fork":true,"url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin","forks_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/forks","keys_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/teams","hooks_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/hooks","issue_events_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/events","assignees_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/tags","blobs_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/languages","stargazers_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/stargazers","contributors_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/contributors","subscribers_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/subscribers","subscription_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/subscription","commits_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/merges","archive_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/downloads","issues_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/labels{/name}","releases_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/fuzzybinary/dart-protoc-plugin/deployments","created_at":"2018-10-18T20:59:58Z","updated_at":"2018-10-18T21:00:01Z","pushed_at":"2018-10-18T21:12:57Z","git_url":"git://github.com/fuzzybinary/dart-protoc-plugin.git","ssh_url":"git@github.com:fuzzybinary/dart-protoc-plugin.git","clone_url":"https://github.com/fuzzybinary/dart-protoc-plugin.git","svn_url":"https://github.com/fuzzybinary/dart-protoc-plugin","homepage":"https://pub.dartlang.org/packages/protoc_plugin","size":706,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"d29fec251afab11eab25a6b316985c18a5f272a8","user":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":11339346,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMzOTM0Ng==","name":"dart-protoc-plugin","full_name":"dart-lang/dart-protoc-plugin","private":false,"owner":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dart-lang/dart-protoc-plugin","description":"Dart plugin for protobuf compiler (protoc)","fork":false,"url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin","forks_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/forks","keys_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/teams","hooks_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/events","assignees_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/tags","blobs_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/languages","stargazers_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/subscription","commits_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/merges","archive_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/downloads","issues_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/deployments","created_at":"2013-07-11T10:34:07Z","updated_at":"2018-10-13T01:23:05Z","pushed_at":"2018-10-11T10:12:23Z","git_url":"git://github.com/dart-lang/dart-protoc-plugin.git","ssh_url":"git@github.com:dart-lang/dart-protoc-plugin.git","clone_url":"https://github.com/dart-lang/dart-protoc-plugin.git","svn_url":"https://github.com/dart-lang/dart-protoc-plugin","homepage":"https://pub.dartlang.org/packages/protoc_plugin","size":706,"stargazers_count":67,"watchers_count":67,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":38,"open_issues":18,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/pulls/136"},"html":{"href":"https://github.com/dart-lang/dart-protoc-plugin/pull/136"},"issue":{"href":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/issues/136"},"comments":{"href":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/dart-protoc-plugin/statuses/9cc95397b9dc9a4248d8b90652792bbfde830833"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":11,"deletions":17,"changed_files":2}}
{"actor":{"display_login":"fuzzybinary"}}