{"action":"created","comment":{"url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/comments/180799820","pull_request_review_id":111285416,"id":180799820,"diff_hunk":"@@ -1,7 +1,12 @@\n {\n   \"lerna\": \"2.4.0\",\n   \"version\": \"independent\",\n-  \"npmClient\": \"jlpm\",\n+  \"npmClient\": \"yarn\",","path":"lerna.json","position":5,"original_position":5,"commit_id":"6eb4fb03febceda4cb059eda3aff98c5f59bd9f2","original_commit_id":"6eb4fb03febceda4cb059eda3aff98c5f59bd9f2","user":{"login":"jasongrout","id":192614,"avatar_url":"https://avatars0.githubusercontent.com/u/192614?v=4","gravatar_id":"","url":"https://api.github.com/users/jasongrout","html_url":"https://github.com/jasongrout","followers_url":"https://api.github.com/users/jasongrout/followers","following_url":"https://api.github.com/users/jasongrout/following{/other_user}","gists_url":"https://api.github.com/users/jasongrout/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongrout/subscriptions","organizations_url":"https://api.github.com/users/jasongrout/orgs","repos_url":"https://api.github.com/users/jasongrout/repos","events_url":"https://api.github.com/users/jasongrout/events{/privacy}","received_events_url":"https://api.github.com/users/jasongrout/received_events","type":"User","site_admin":false},"body":"but I'd still rather use yarn because we have a specific version of yarn shipped, so it's more uniform than calling out to whatever npm people have.","created_at":"2018-04-11T15:34:45Z","updated_at":"2018-04-11T15:34:46Z","html_url":"https://github.com/jupyterlab/jupyterlab/pull/4353#discussion_r180799820","pull_request_url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/4353","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/comments/180799820"},"html":{"href":"https://github.com/jupyterlab/jupyterlab/pull/4353#discussion_r180799820"},"pull_request":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/4353"}},"in_reply_to_id":180791418},"pull_request":{"url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/4353","id":180805272,"html_url":"https://github.com/jupyterlab/jupyterlab/pull/4353","diff_url":"https://github.com/jupyterlab/jupyterlab/pull/4353.diff","patch_url":"https://github.com/jupyterlab/jupyterlab/pull/4353.patch","issue_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/4353","number":4353,"state":"open","locked":false,"title":"Make lerna use \"yarn\" since it has hardcoded checks","user":{"login":"jasongrout","id":192614,"avatar_url":"https://avatars0.githubusercontent.com/u/192614?v=4","gravatar_id":"","url":"https://api.github.com/users/jasongrout","html_url":"https://github.com/jasongrout","followers_url":"https://api.github.com/users/jasongrout/followers","following_url":"https://api.github.com/users/jasongrout/following{/other_user}","gists_url":"https://api.github.com/users/jasongrout/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongrout/subscriptions","organizations_url":"https://api.github.com/users/jasongrout/orgs","repos_url":"https://api.github.com/users/jasongrout/repos","events_url":"https://api.github.com/users/jasongrout/events{/privacy}","received_events_url":"https://api.github.com/users/jasongrout/received_events","type":"User","site_admin":false},"body":"We switch away from lerna thinking the package manager is jlpm since lerna has some hardcoded logic to deal with “yarn”. Yarn should be in the path by the time it runs.\r\n\r\nThis also attempts to do the same as https://github.com/lerna/lerna/commit/07d080db6cb77f3d1b28abce5bde7c732523a091","created_at":"2018-04-11T06:51:32Z","updated_at":"2018-04-11T15:34:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8e100efb8c8638333531d70bb8fc72d8ef012ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/jupyterlab/jupyterlab/milestones/11","html_url":"https://github.com/jupyterlab/jupyterlab/milestone/11","labels_url":"https://api.github.com/repos/jupyterlab/jupyterlab/milestones/11/labels","id":3016867,"number":11,"title":"Beta 2","description":"The second release in the beta series of JupyterLab releases.","creator":{"login":"ellisonbg","id":27600,"avatar_url":"https://avatars3.githubusercontent.com/u/27600?v=4","gravatar_id":"","url":"https://api.github.com/users/ellisonbg","html_url":"https://github.com/ellisonbg","followers_url":"https://api.github.com/users/ellisonbg/followers","following_url":"https://api.github.com/users/ellisonbg/following{/other_user}","gists_url":"https://api.github.com/users/ellisonbg/gists{/gist_id}","starred_url":"https://api.github.com/users/ellisonbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellisonbg/subscriptions","organizations_url":"https://api.github.com/users/ellisonbg/orgs","repos_url":"https://api.github.com/users/ellisonbg/repos","events_url":"https://api.github.com/users/ellisonbg/events{/privacy}","received_events_url":"https://api.github.com/users/ellisonbg/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":121,"state":"open","created_at":"2018-01-06T20:39:53Z","updated_at":"2018-04-11T09:02:01Z","due_on":"2018-04-09T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/4353/commits","review_comments_url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/4353/comments","review_comment_url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/4353/comments","statuses_url":"https://api.github.com/repos/jupyterlab/jupyterlab/statuses/6eb4fb03febceda4cb059eda3aff98c5f59bd9f2","head":{"label":"jasongrout:lernayarn","ref":"lernayarn","sha":"6eb4fb03febceda4cb059eda3aff98c5f59bd9f2","user":{"login":"jasongrout","id":192614,"avatar_url":"https://avatars0.githubusercontent.com/u/192614?v=4","gravatar_id":"","url":"https://api.github.com/users/jasongrout","html_url":"https://github.com/jasongrout","followers_url":"https://api.github.com/users/jasongrout/followers","following_url":"https://api.github.com/users/jasongrout/following{/other_user}","gists_url":"https://api.github.com/users/jasongrout/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongrout/subscriptions","organizations_url":"https://api.github.com/users/jasongrout/orgs","repos_url":"https://api.github.com/users/jasongrout/repos","events_url":"https://api.github.com/users/jasongrout/events{/privacy}","received_events_url":"https://api.github.com/users/jasongrout/received_events","type":"User","site_admin":false},"repo":{"id":60541761,"name":"jupyterlab","full_name":"jasongrout/jupyterlab","owner":{"login":"jasongrout","id":192614,"avatar_url":"https://avatars0.githubusercontent.com/u/192614?v=4","gravatar_id":"","url":"https://api.github.com/users/jasongrout","html_url":"https://github.com/jasongrout","followers_url":"https://api.github.com/users/jasongrout/followers","following_url":"https://api.github.com/users/jasongrout/following{/other_user}","gists_url":"https://api.github.com/users/jasongrout/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongrout/subscriptions","organizations_url":"https://api.github.com/users/jasongrout/orgs","repos_url":"https://api.github.com/users/jasongrout/repos","events_url":"https://api.github.com/users/jasongrout/events{/privacy}","received_events_url":"https://api.github.com/users/jasongrout/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasongrout/jupyterlab","description":"JupyterLab computational environment","fork":true,"url":"https://api.github.com/repos/jasongrout/jupyterlab","forks_url":"https://api.github.com/repos/jasongrout/jupyterlab/forks","keys_url":"https://api.github.com/repos/jasongrout/jupyterlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasongrout/jupyterlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasongrout/jupyterlab/teams","hooks_url":"https://api.github.com/repos/jasongrout/jupyterlab/hooks","issue_events_url":"https://api.github.com/repos/jasongrout/jupyterlab/issues/events{/number}","events_url":"https://api.github.com/repos/jasongrout/jupyterlab/events","assignees_url":"https://api.github.com/repos/jasongrout/jupyterlab/assignees{/user}","branches_url":"https://api.github.com/repos/jasongrout/jupyterlab/branches{/branch}","tags_url":"https://api.github.com/repos/jasongrout/jupyterlab/tags","blobs_url":"https://api.github.com/repos/jasongrout/jupyterlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasongrout/jupyterlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasongrout/jupyterlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasongrout/jupyterlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasongrout/jupyterlab/statuses/{sha}","languages_url":"https://api.github.com/repos/jasongrout/jupyterlab/languages","stargazers_url":"https://api.github.com/repos/jasongrout/jupyterlab/stargazers","contributors_url":"https://api.github.com/repos/jasongrout/jupyterlab/contributors","subscribers_url":"https://api.github.com/repos/jasongrout/jupyterlab/subscribers","subscription_url":"https://api.github.com/repos/jasongrout/jupyterlab/subscription","commits_url":"https://api.github.com/repos/jasongrout/jupyterlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasongrout/jupyterlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasongrout/jupyterlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasongrout/jupyterlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasongrout/jupyterlab/contents/{+path}","compare_url":"https://api.github.com/repos/jasongrout/jupyterlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasongrout/jupyterlab/merges","archive_url":"https://api.github.com/repos/jasongrout/jupyterlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasongrout/jupyterlab/downloads","issues_url":"https://api.github.com/repos/jasongrout/jupyterlab/issues{/number}","pulls_url":"https://api.github.com/repos/jasongrout/jupyterlab/pulls{/number}","milestones_url":"https://api.github.com/repos/jasongrout/jupyterlab/milestones{/number}","notifications_url":"https://api.github.com/repos/jasongrout/jupyterlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasongrout/jupyterlab/labels{/name}","releases_url":"https://api.github.com/repos/jasongrout/jupyterlab/releases{/id}","deployments_url":"https://api.github.com/repos/jasongrout/jupyterlab/deployments","created_at":"2016-06-06T16:06:40Z","updated_at":"2016-06-06T16:06:41Z","pushed_at":"2018-04-11T06:49:40Z","git_url":"git://github.com/jasongrout/jupyterlab.git","ssh_url":"git@github.com:jasongrout/jupyterlab.git","clone_url":"https://github.com/jasongrout/jupyterlab.git","svn_url":"https://github.com/jasongrout/jupyterlab","homepage":null,"size":61189,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyterlab:master","ref":"master","sha":"60ea7958d94a120042a71d353dd7e5666cf63b4c","user":{"login":"jupyterlab","id":22800682,"avatar_url":"https://avatars1.githubusercontent.com/u/22800682?v=4","gravatar_id":"","url":"https://api.github.com/users/jupyterlab","html_url":"https://github.com/jupyterlab","followers_url":"https://api.github.com/users/jupyterlab/followers","following_url":"https://api.github.com/users/jupyterlab/following{/other_user}","gists_url":"https://api.github.com/users/jupyterlab/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyterlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyterlab/subscriptions","organizations_url":"https://api.github.com/users/jupyterlab/orgs","repos_url":"https://api.github.com/users/jupyterlab/repos","events_url":"https://api.github.com/users/jupyterlab/events{/privacy}","received_events_url":"https://api.github.com/users/jupyterlab/received_events","type":"Organization","site_admin":false},"repo":{"id":60374819,"name":"jupyterlab","full_name":"jupyterlab/jupyterlab","owner":{"login":"jupyterlab","id":22800682,"avatar_url":"https://avatars1.githubusercontent.com/u/22800682?v=4","gravatar_id":"","url":"https://api.github.com/users/jupyterlab","html_url":"https://github.com/jupyterlab","followers_url":"https://api.github.com/users/jupyterlab/followers","following_url":"https://api.github.com/users/jupyterlab/following{/other_user}","gists_url":"https://api.github.com/users/jupyterlab/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyterlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyterlab/subscriptions","organizations_url":"https://api.github.com/users/jupyterlab/orgs","repos_url":"https://api.github.com/users/jupyterlab/repos","events_url":"https://api.github.com/users/jupyterlab/events{/privacy}","received_events_url":"https://api.github.com/users/jupyterlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyterlab/jupyterlab","description":"JupyterLab computational environment.","fork":false,"url":"https://api.github.com/repos/jupyterlab/jupyterlab","forks_url":"https://api.github.com/repos/jupyterlab/jupyterlab/forks","keys_url":"https://api.github.com/repos/jupyterlab/jupyterlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyterlab/jupyterlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyterlab/jupyterlab/teams","hooks_url":"https://api.github.com/repos/jupyterlab/jupyterlab/hooks","issue_events_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/events{/number}","events_url":"https://api.github.com/repos/jupyterlab/jupyterlab/events","assignees_url":"https://api.github.com/repos/jupyterlab/jupyterlab/assignees{/user}","branches_url":"https://api.github.com/repos/jupyterlab/jupyterlab/branches{/branch}","tags_url":"https://api.github.com/repos/jupyterlab/jupyterlab/tags","blobs_url":"https://api.github.com/repos/jupyterlab/jupyterlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyterlab/jupyterlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyterlab/jupyterlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyterlab/jupyterlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyterlab/jupyterlab/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyterlab/jupyterlab/languages","stargazers_url":"https://api.github.com/repos/jupyterlab/jupyterlab/stargazers","contributors_url":"https://api.github.com/repos/jupyterlab/jupyterlab/contributors","subscribers_url":"https://api.github.com/repos/jupyterlab/jupyterlab/subscribers","subscription_url":"https://api.github.com/repos/jupyterlab/jupyterlab/subscription","commits_url":"https://api.github.com/repos/jupyterlab/jupyterlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyterlab/jupyterlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyterlab/jupyterlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyterlab/jupyterlab/contents/{+path}","compare_url":"https://api.github.com/repos/jupyterlab/jupyterlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyterlab/jupyterlab/merges","archive_url":"https://api.github.com/repos/jupyterlab/jupyterlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyterlab/jupyterlab/downloads","issues_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues{/number}","pulls_url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyterlab/jupyterlab/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyterlab/jupyterlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyterlab/jupyterlab/labels{/name}","releases_url":"https://api.github.com/repos/jupyterlab/jupyterlab/releases{/id}","deployments_url":"https://api.github.com/repos/jupyterlab/jupyterlab/deployments","created_at":"2016-06-03T20:09:17Z","updated_at":"2018-04-11T15:22:50Z","pushed_at":"2018-04-11T13:54:55Z","git_url":"git://github.com/jupyterlab/jupyterlab.git","ssh_url":"git@github.com:jupyterlab/jupyterlab.git","clone_url":"https://github.com/jupyterlab/jupyterlab.git","svn_url":"https://github.com/jupyterlab/jupyterlab","homepage":"","size":56495,"stargazers_count":5084,"watchers_count":5084,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":578,"mirror_url":null,"archived":false,"open_issues_count":721,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":578,"open_issues":721,"watchers":5084,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/4353"},"html":{"href":"https://github.com/jupyterlab/jupyterlab/pull/4353"},"issue":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/4353"},"comments":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/4353/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/4353/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/4353/commits"},"statuses":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/statuses/6eb4fb03febceda4cb059eda3aff98c5f59bd9f2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jasongrout"}}