{"action":"closed","number":107,"pull_request":{"url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/pulls/107","id":175378279,"html_url":"https://github.com/ember-learn/ember-cli-addon-docs/pull/107","diff_url":"https://github.com/ember-learn/ember-cli-addon-docs/pull/107.diff","patch_url":"https://github.com/ember-learn/ember-cli-addon-docs/pull/107.patch","issue_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/issues/107","number":107,"state":"closed","locked":false,"title":"Remove application adapter and serializer","user":{"login":"ef4","id":319282,"avatar_url":"https://avatars0.githubusercontent.com/u/319282?v=4","gravatar_id":"","url":"https://api.github.com/users/ef4","html_url":"https://github.com/ef4","followers_url":"https://api.github.com/users/ef4/followers","following_url":"https://api.github.com/users/ef4/following{/other_user}","gists_url":"https://api.github.com/users/ef4/gists{/gist_id}","starred_url":"https://api.github.com/users/ef4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ef4/subscriptions","organizations_url":"https://api.github.com/users/ef4/orgs","repos_url":"https://api.github.com/users/ef4/repos","events_url":"https://api.github.com/users/ef4/events{/privacy}","received_events_url":"https://api.github.com/users/ef4/received_events","type":"User","site_admin":false},"body":"The presence of the application adapter and serializer broke ember-animated's test suite (because I was already using ember-data for another purpose).\r\n\r\nIn general I think it's risky for an addon to customize the global default application adapter & serializer, even when the consuming app is \"just\" an addon dummy app.\r\n\r\nThis PR limits the scope of the adapter and serializer customizations to only the models that are part of ember-cli-addon-docs.","created_at":"2018-03-15T21:03:38Z","updated_at":"2018-03-15T21:19:36Z","closed_at":"2018-03-15T21:19:36Z","merged_at":"2018-03-15T21:19:36Z","merge_commit_sha":"560bb02a7001e023bda7116e85f8368bb5ebf8de","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/pulls/107/commits","review_comments_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/pulls/107/comments","review_comment_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/issues/107/comments","statuses_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/statuses/7fade534defa1cb59e0d6e4e089146aa971cc098","head":{"label":"ef4:no-application-adapter","ref":"no-application-adapter","sha":"7fade534defa1cb59e0d6e4e089146aa971cc098","user":{"login":"ef4","id":319282,"avatar_url":"https://avatars0.githubusercontent.com/u/319282?v=4","gravatar_id":"","url":"https://api.github.com/users/ef4","html_url":"https://github.com/ef4","followers_url":"https://api.github.com/users/ef4/followers","following_url":"https://api.github.com/users/ef4/following{/other_user}","gists_url":"https://api.github.com/users/ef4/gists{/gist_id}","starred_url":"https://api.github.com/users/ef4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ef4/subscriptions","organizations_url":"https://api.github.com/users/ef4/orgs","repos_url":"https://api.github.com/users/ef4/repos","events_url":"https://api.github.com/users/ef4/events{/privacy}","received_events_url":"https://api.github.com/users/ef4/received_events","type":"User","site_admin":false},"repo":{"id":125425544,"name":"ember-cli-addon-docs","full_name":"ef4/ember-cli-addon-docs","owner":{"login":"ef4","id":319282,"avatar_url":"https://avatars0.githubusercontent.com/u/319282?v=4","gravatar_id":"","url":"https://api.github.com/users/ef4","html_url":"https://github.com/ef4","followers_url":"https://api.github.com/users/ef4/followers","following_url":"https://api.github.com/users/ef4/following{/other_user}","gists_url":"https://api.github.com/users/ef4/gists{/gist_id}","starred_url":"https://api.github.com/users/ef4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ef4/subscriptions","organizations_url":"https://api.github.com/users/ef4/orgs","repos_url":"https://api.github.com/users/ef4/repos","events_url":"https://api.github.com/users/ef4/events{/privacy}","received_events_url":"https://api.github.com/users/ef4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ef4/ember-cli-addon-docs","description":"Easy documentation for Ember addons","fork":true,"url":"https://api.github.com/repos/ef4/ember-cli-addon-docs","forks_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/forks","keys_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/teams","hooks_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/hooks","issue_events_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/issues/events{/number}","events_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/events","assignees_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/assignees{/user}","branches_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/branches{/branch}","tags_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/tags","blobs_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/languages","stargazers_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/stargazers","contributors_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/contributors","subscribers_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/subscribers","subscription_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/subscription","commits_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/contents/{+path}","compare_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/merges","archive_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/downloads","issues_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/issues{/number}","pulls_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/labels{/name}","releases_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/releases{/id}","deployments_url":"https://api.github.com/repos/ef4/ember-cli-addon-docs/deployments","created_at":"2018-03-15T20:59:50Z","updated_at":"2018-03-15T20:59:52Z","pushed_at":"2018-03-15T21:03:07Z","git_url":"git://github.com/ef4/ember-cli-addon-docs.git","ssh_url":"git@github.com:ef4/ember-cli-addon-docs.git","clone_url":"https://github.com/ef4/ember-cli-addon-docs.git","svn_url":"https://github.com/ef4/ember-cli-addon-docs","homepage":"https://ember-learn.github.io/ember-cli-addon-docs","size":7707,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-learn:master","ref":"master","sha":"4f905fe6ff2f268ab55d4662fcee105217fd7bc5","user":{"login":"ember-learn","id":18540472,"avatar_url":"https://avatars1.githubusercontent.com/u/18540472?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-learn","html_url":"https://github.com/ember-learn","followers_url":"https://api.github.com/users/ember-learn/followers","following_url":"https://api.github.com/users/ember-learn/following{/other_user}","gists_url":"https://api.github.com/users/ember-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-learn/subscriptions","organizations_url":"https://api.github.com/users/ember-learn/orgs","repos_url":"https://api.github.com/users/ember-learn/repos","events_url":"https://api.github.com/users/ember-learn/events{/privacy}","received_events_url":"https://api.github.com/users/ember-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":84850518,"name":"ember-cli-addon-docs","full_name":"ember-learn/ember-cli-addon-docs","owner":{"login":"ember-learn","id":18540472,"avatar_url":"https://avatars1.githubusercontent.com/u/18540472?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-learn","html_url":"https://github.com/ember-learn","followers_url":"https://api.github.com/users/ember-learn/followers","following_url":"https://api.github.com/users/ember-learn/following{/other_user}","gists_url":"https://api.github.com/users/ember-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-learn/subscriptions","organizations_url":"https://api.github.com/users/ember-learn/orgs","repos_url":"https://api.github.com/users/ember-learn/repos","events_url":"https://api.github.com/users/ember-learn/events{/privacy}","received_events_url":"https://api.github.com/users/ember-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-learn/ember-cli-addon-docs","description":"Easy documentation for Ember addons","fork":false,"url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs","forks_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/forks","keys_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/teams","hooks_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/hooks","issue_events_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/issues/events{/number}","events_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/events","assignees_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/assignees{/user}","branches_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/branches{/branch}","tags_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/tags","blobs_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/languages","stargazers_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/stargazers","contributors_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/contributors","subscribers_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/subscribers","subscription_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/subscription","commits_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/contents/{+path}","compare_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/merges","archive_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/downloads","issues_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/issues{/number}","pulls_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/labels{/name}","releases_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/releases{/id}","deployments_url":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/deployments","created_at":"2017-03-13T16:39:01Z","updated_at":"2018-03-15T19:58:43Z","pushed_at":"2018-03-15T21:19:36Z","git_url":"git://github.com/ember-learn/ember-cli-addon-docs.git","ssh_url":"git@github.com:ember-learn/ember-cli-addon-docs.git","clone_url":"https://github.com/ember-learn/ember-cli-addon-docs.git","svn_url":"https://github.com/ember-learn/ember-cli-addon-docs","homepage":"https://ember-learn.github.io/ember-cli-addon-docs","size":7707,"stargazers_count":58,"watchers_count":58,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":27,"open_issues":26,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/pulls/107"},"html":{"href":"https://github.com/ember-learn/ember-cli-addon-docs/pull/107"},"issue":{"href":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/issues/107"},"comments":{"href":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/ember-learn/ember-cli-addon-docs/statuses/7fade534defa1cb59e0d6e4e089146aa971cc098"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"pzuraq","id":685518,"avatar_url":"https://avatars3.githubusercontent.com/u/685518?v=4","gravatar_id":"","url":"https://api.github.com/users/pzuraq","html_url":"https://github.com/pzuraq","followers_url":"https://api.github.com/users/pzuraq/followers","following_url":"https://api.github.com/users/pzuraq/following{/other_user}","gists_url":"https://api.github.com/users/pzuraq/gists{/gist_id}","starred_url":"https://api.github.com/users/pzuraq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pzuraq/subscriptions","organizations_url":"https://api.github.com/users/pzuraq/orgs","repos_url":"https://api.github.com/users/pzuraq/repos","events_url":"https://api.github.com/users/pzuraq/events{/privacy}","received_events_url":"https://api.github.com/users/pzuraq/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":1,"changed_files":6}}
{"actor":{"display_login":"pzuraq"}}