{"action":"created","comment":{"url":"https://api.github.com/repos/mollie/mollie-api-php/pulls/comments/203297423","pull_request_review_id":138156105,"id":203297423,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzI5NzQyMw==","diff_hunk":"@@ -162,8 +163,13 @@ class MollieApiClient\n      */\n     public function __construct(HttpClient $httpClient = null, RequestFactory $requestFactory = null)\n     {\n-        $this->httpClient = $httpClient ? $httpClient : HttpClientDiscovery::find();\n-        $this->requestFactory = $requestFactory ? $requestFactory : MessageFactoryDiscovery::find();\n+\n+        try {\n+            $this->httpClient = $httpClient ? $httpClient : HttpClientDiscovery::find();\n+            $this->requestFactory = $requestFactory ? $requestFactory : MessageFactoryDiscovery::find();\n+        } catch (Exception $e) {\n+            throw new IncompatiblePlatform('We could not find any http-client-implementation. Install a package providing \"php-http/client-implementation\". Example: \"php-http/guzzle6-adapter\".');","path":"src/MollieApiClient.php","position":53,"original_position":19,"commit_id":"67f648f7e27e5b416c6eb579cf1aa715ffc321c9","original_commit_id":"67f648f7e27e5b416c6eb579cf1aa715ffc321c9","user":{"login":"willemstuursma","id":701299,"node_id":"MDQ6VXNlcjcwMTI5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/701299?v=4","gravatar_id":"","url":"https://api.github.com/users/willemstuursma","html_url":"https://github.com/willemstuursma","followers_url":"https://api.github.com/users/willemstuursma/followers","following_url":"https://api.github.com/users/willemstuursma/following{/other_user}","gists_url":"https://api.github.com/users/willemstuursma/gists{/gist_id}","starred_url":"https://api.github.com/users/willemstuursma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willemstuursma/subscriptions","organizations_url":"https://api.github.com/users/willemstuursma/orgs","repos_url":"https://api.github.com/users/willemstuursma/repos","events_url":"https://api.github.com/users/willemstuursma/events{/privacy}","received_events_url":"https://api.github.com/users/willemstuursma/received_events","type":"User","site_admin":false},"body":"`Example: \"composer install php-http/guzzle6-adapter\".`","created_at":"2018-07-18T08:45:24Z","updated_at":"2018-07-18T08:46:18Z","html_url":"https://github.com/mollie/mollie-api-php/pull/230#discussion_r203297423","pull_request_url":"https://api.github.com/repos/mollie/mollie-api-php/pulls/230","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mollie/mollie-api-php/pulls/comments/203297423"},"html":{"href":"https://github.com/mollie/mollie-api-php/pull/230#discussion_r203297423"},"pull_request":{"href":"https://api.github.com/repos/mollie/mollie-api-php/pulls/230"}}},"pull_request":{"url":"https://api.github.com/repos/mollie/mollie-api-php/pulls/230","id":202162008,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMTYyMDA4","html_url":"https://github.com/mollie/mollie-api-php/pull/230","diff_url":"https://github.com/mollie/mollie-api-php/pull/230.diff","patch_url":"https://github.com/mollie/mollie-api-php/pull/230.patch","issue_url":"https://api.github.com/repos/mollie/mollie-api-php/issues/230","number":230,"state":"open","locked":false,"title":"Abstract the Guzzle dependency to a HttpClient implementation","user":{"login":"Smitsel","id":9112118,"node_id":"MDQ6VXNlcjkxMTIxMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9112118?v=4","gravatar_id":"","url":"https://api.github.com/users/Smitsel","html_url":"https://github.com/Smitsel","followers_url":"https://api.github.com/users/Smitsel/followers","following_url":"https://api.github.com/users/Smitsel/following{/other_user}","gists_url":"https://api.github.com/users/Smitsel/gists{/gist_id}","starred_url":"https://api.github.com/users/Smitsel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smitsel/subscriptions","organizations_url":"https://api.github.com/users/Smitsel/orgs","repos_url":"https://api.github.com/users/Smitsel/repos","events_url":"https://api.github.com/users/Smitsel/events{/privacy}","received_events_url":"https://api.github.com/users/Smitsel/received_events","type":"User","site_admin":false},"body":"This will be a BC breaking change. Since the install will now require 2 steps.\r\nInstalling the SDK and also installing a HTTP client implementation.\r\n\r\nThis will not matter for our ZIP file as we can require the Guzzle 6 adapter in the steps.","created_at":"2018-07-18T07:31:40Z","updated_at":"2018-07-18T08:46:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4c362aba60090a239570c264b4709ff8a04005e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mollie/mollie-api-php/pulls/230/commits","review_comments_url":"https://api.github.com/repos/mollie/mollie-api-php/pulls/230/comments","review_comment_url":"https://api.github.com/repos/mollie/mollie-api-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mollie/mollie-api-php/issues/230/comments","statuses_url":"https://api.github.com/repos/mollie/mollie-api-php/statuses/67f648f7e27e5b416c6eb579cf1aa715ffc321c9","head":{"label":"mollie:abstract-http-client","ref":"abstract-http-client","sha":"67f648f7e27e5b416c6eb579cf1aa715ffc321c9","user":{"login":"mollie","id":1327170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1327170?v=4","gravatar_id":"","url":"https://api.github.com/users/mollie","html_url":"https://github.com/mollie","followers_url":"https://api.github.com/users/mollie/followers","following_url":"https://api.github.com/users/mollie/following{/other_user}","gists_url":"https://api.github.com/users/mollie/gists{/gist_id}","starred_url":"https://api.github.com/users/mollie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mollie/subscriptions","organizations_url":"https://api.github.com/users/mollie/orgs","repos_url":"https://api.github.com/users/mollie/repos","events_url":"https://api.github.com/users/mollie/events{/privacy}","received_events_url":"https://api.github.com/users/mollie/received_events","type":"Organization","site_admin":false},"repo":{"id":14861133,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg2MTEzMw==","name":"mollie-api-php","full_name":"mollie/mollie-api-php","owner":{"login":"mollie","id":1327170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1327170?v=4","gravatar_id":"","url":"https://api.github.com/users/mollie","html_url":"https://github.com/mollie","followers_url":"https://api.github.com/users/mollie/followers","following_url":"https://api.github.com/users/mollie/following{/other_user}","gists_url":"https://api.github.com/users/mollie/gists{/gist_id}","starred_url":"https://api.github.com/users/mollie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mollie/subscriptions","organizations_url":"https://api.github.com/users/mollie/orgs","repos_url":"https://api.github.com/users/mollie/repos","events_url":"https://api.github.com/users/mollie/events{/privacy}","received_events_url":"https://api.github.com/users/mollie/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mollie/mollie-api-php","description":"Mollie API client for PHP","fork":false,"url":"https://api.github.com/repos/mollie/mollie-api-php","forks_url":"https://api.github.com/repos/mollie/mollie-api-php/forks","keys_url":"https://api.github.com/repos/mollie/mollie-api-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mollie/mollie-api-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mollie/mollie-api-php/teams","hooks_url":"https://api.github.com/repos/mollie/mollie-api-php/hooks","issue_events_url":"https://api.github.com/repos/mollie/mollie-api-php/issues/events{/number}","events_url":"https://api.github.com/repos/mollie/mollie-api-php/events","assignees_url":"https://api.github.com/repos/mollie/mollie-api-php/assignees{/user}","branches_url":"https://api.github.com/repos/mollie/mollie-api-php/branches{/branch}","tags_url":"https://api.github.com/repos/mollie/mollie-api-php/tags","blobs_url":"https://api.github.com/repos/mollie/mollie-api-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mollie/mollie-api-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mollie/mollie-api-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/mollie/mollie-api-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mollie/mollie-api-php/statuses/{sha}","languages_url":"https://api.github.com/repos/mollie/mollie-api-php/languages","stargazers_url":"https://api.github.com/repos/mollie/mollie-api-php/stargazers","contributors_url":"https://api.github.com/repos/mollie/mollie-api-php/contributors","subscribers_url":"https://api.github.com/repos/mollie/mollie-api-php/subscribers","subscription_url":"https://api.github.com/repos/mollie/mollie-api-php/subscription","commits_url":"https://api.github.com/repos/mollie/mollie-api-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/mollie/mollie-api-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/mollie/mollie-api-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/mollie/mollie-api-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/mollie/mollie-api-php/contents/{+path}","compare_url":"https://api.github.com/repos/mollie/mollie-api-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mollie/mollie-api-php/merges","archive_url":"https://api.github.com/repos/mollie/mollie-api-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mollie/mollie-api-php/downloads","issues_url":"https://api.github.com/repos/mollie/mollie-api-php/issues{/number}","pulls_url":"https://api.github.com/repos/mollie/mollie-api-php/pulls{/number}","milestones_url":"https://api.github.com/repos/mollie/mollie-api-php/milestones{/number}","notifications_url":"https://api.github.com/repos/mollie/mollie-api-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mollie/mollie-api-php/labels{/name}","releases_url":"https://api.github.com/repos/mollie/mollie-api-php/releases{/id}","deployments_url":"https://api.github.com/repos/mollie/mollie-api-php/deployments","created_at":"2013-12-02T11:58:56Z","updated_at":"2018-07-17T15:57:38Z","pushed_at":"2018-07-18T08:42:13Z","git_url":"git://github.com/mollie/mollie-api-php.git","ssh_url":"git@github.com:mollie/mollie-api-php.git","clone_url":"https://github.com/mollie/mollie-api-php.git","svn_url":"https://github.com/mollie/mollie-api-php","homepage":"http://www.mollie.com","size":1168,"stargazers_count":210,"watchers_count":210,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":93,"open_issues":12,"watchers":210,"default_branch":"master"}},"base":{"label":"mollie:master","ref":"master","sha":"96353be4fd409a31997200136494812af5014a6e","user":{"login":"mollie","id":1327170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1327170?v=4","gravatar_id":"","url":"https://api.github.com/users/mollie","html_url":"https://github.com/mollie","followers_url":"https://api.github.com/users/mollie/followers","following_url":"https://api.github.com/users/mollie/following{/other_user}","gists_url":"https://api.github.com/users/mollie/gists{/gist_id}","starred_url":"https://api.github.com/users/mollie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mollie/subscriptions","organizations_url":"https://api.github.com/users/mollie/orgs","repos_url":"https://api.github.com/users/mollie/repos","events_url":"https://api.github.com/users/mollie/events{/privacy}","received_events_url":"https://api.github.com/users/mollie/received_events","type":"Organization","site_admin":false},"repo":{"id":14861133,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg2MTEzMw==","name":"mollie-api-php","full_name":"mollie/mollie-api-php","owner":{"login":"mollie","id":1327170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1327170?v=4","gravatar_id":"","url":"https://api.github.com/users/mollie","html_url":"https://github.com/mollie","followers_url":"https://api.github.com/users/mollie/followers","following_url":"https://api.github.com/users/mollie/following{/other_user}","gists_url":"https://api.github.com/users/mollie/gists{/gist_id}","starred_url":"https://api.github.com/users/mollie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mollie/subscriptions","organizations_url":"https://api.github.com/users/mollie/orgs","repos_url":"https://api.github.com/users/mollie/repos","events_url":"https://api.github.com/users/mollie/events{/privacy}","received_events_url":"https://api.github.com/users/mollie/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mollie/mollie-api-php","description":"Mollie API client for PHP","fork":false,"url":"https://api.github.com/repos/mollie/mollie-api-php","forks_url":"https://api.github.com/repos/mollie/mollie-api-php/forks","keys_url":"https://api.github.com/repos/mollie/mollie-api-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mollie/mollie-api-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mollie/mollie-api-php/teams","hooks_url":"https://api.github.com/repos/mollie/mollie-api-php/hooks","issue_events_url":"https://api.github.com/repos/mollie/mollie-api-php/issues/events{/number}","events_url":"https://api.github.com/repos/mollie/mollie-api-php/events","assignees_url":"https://api.github.com/repos/mollie/mollie-api-php/assignees{/user}","branches_url":"https://api.github.com/repos/mollie/mollie-api-php/branches{/branch}","tags_url":"https://api.github.com/repos/mollie/mollie-api-php/tags","blobs_url":"https://api.github.com/repos/mollie/mollie-api-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mollie/mollie-api-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mollie/mollie-api-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/mollie/mollie-api-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mollie/mollie-api-php/statuses/{sha}","languages_url":"https://api.github.com/repos/mollie/mollie-api-php/languages","stargazers_url":"https://api.github.com/repos/mollie/mollie-api-php/stargazers","contributors_url":"https://api.github.com/repos/mollie/mollie-api-php/contributors","subscribers_url":"https://api.github.com/repos/mollie/mollie-api-php/subscribers","subscription_url":"https://api.github.com/repos/mollie/mollie-api-php/subscription","commits_url":"https://api.github.com/repos/mollie/mollie-api-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/mollie/mollie-api-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/mollie/mollie-api-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/mollie/mollie-api-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/mollie/mollie-api-php/contents/{+path}","compare_url":"https://api.github.com/repos/mollie/mollie-api-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mollie/mollie-api-php/merges","archive_url":"https://api.github.com/repos/mollie/mollie-api-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mollie/mollie-api-php/downloads","issues_url":"https://api.github.com/repos/mollie/mollie-api-php/issues{/number}","pulls_url":"https://api.github.com/repos/mollie/mollie-api-php/pulls{/number}","milestones_url":"https://api.github.com/repos/mollie/mollie-api-php/milestones{/number}","notifications_url":"https://api.github.com/repos/mollie/mollie-api-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mollie/mollie-api-php/labels{/name}","releases_url":"https://api.github.com/repos/mollie/mollie-api-php/releases{/id}","deployments_url":"https://api.github.com/repos/mollie/mollie-api-php/deployments","created_at":"2013-12-02T11:58:56Z","updated_at":"2018-07-17T15:57:38Z","pushed_at":"2018-07-18T08:42:13Z","git_url":"git://github.com/mollie/mollie-api-php.git","ssh_url":"git@github.com:mollie/mollie-api-php.git","clone_url":"https://github.com/mollie/mollie-api-php.git","svn_url":"https://github.com/mollie/mollie-api-php","homepage":"http://www.mollie.com","size":1168,"stargazers_count":210,"watchers_count":210,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":93,"open_issues":12,"watchers":210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mollie/mollie-api-php/pulls/230"},"html":{"href":"https://github.com/mollie/mollie-api-php/pull/230"},"issue":{"href":"https://api.github.com/repos/mollie/mollie-api-php/issues/230"},"comments":{"href":"https://api.github.com/repos/mollie/mollie-api-php/issues/230/comments"},"review_comments":{"href":"https://api.github.com/repos/mollie/mollie-api-php/pulls/230/comments"},"review_comment":{"href":"https://api.github.com/repos/mollie/mollie-api-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mollie/mollie-api-php/pulls/230/commits"},"statuses":{"href":"https://api.github.com/repos/mollie/mollie-api-php/statuses/67f648f7e27e5b416c6eb579cf1aa715ffc321c9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"willemstuursma"}}