{"action":"created","issue":{"url":"https://api.github.com/repos/nest/nest-simulator/issues/1059","repository_url":"https://api.github.com/repos/nest/nest-simulator","labels_url":"https://api.github.com/repos/nest/nest-simulator/issues/1059/labels{/name}","comments_url":"https://api.github.com/repos/nest/nest-simulator/issues/1059/comments","events_url":"https://api.github.com/repos/nest/nest-simulator/issues/1059/events","html_url":"https://github.com/nest/nest-simulator/pull/1059","id":373527832,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NDM4MzQ3","number":1059,"title":"Fix issues in siegert_neuron","user":{"login":"AlexVanMeegen","id":32771370,"node_id":"MDQ6VXNlcjMyNzcxMzcw","avatar_url":"https://avatars2.githubusercontent.com/u/32771370?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexVanMeegen","html_url":"https://github.com/AlexVanMeegen","followers_url":"https://api.github.com/users/AlexVanMeegen/followers","following_url":"https://api.github.com/users/AlexVanMeegen/following{/other_user}","gists_url":"https://api.github.com/users/AlexVanMeegen/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexVanMeegen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexVanMeegen/subscriptions","organizations_url":"https://api.github.com/users/AlexVanMeegen/orgs","repos_url":"https://api.github.com/users/AlexVanMeegen/repos","events_url":"https://api.github.com/users/AlexVanMeegen/events{/privacy}","received_events_url":"https://api.github.com/users/AlexVanMeegen/received_events","type":"User","site_admin":false},"labels":[{"id":481181986,"node_id":"MDU6TGFiZWw0ODExODE5ODY=","url":"https://api.github.com/repos/nest/nest-simulator/labels/C:%20Model","name":"C: Model","color":"58ff4d","default":false},{"id":481274440,"node_id":"MDU6TGFiZWw0ODEyNzQ0NDA=","url":"https://api.github.com/repos/nest/nest-simulator/labels/I:%20No%20breaking%20change","name":"I: No breaking change","color":"cbd5ff","default":false},{"id":481271679,"node_id":"MDU6TGFiZWw0ODEyNzE2Nzk=","url":"https://api.github.com/repos/nest/nest-simulator/labels/P:%20PR%20Created","name":"P: PR Created","color":"ba65ff","default":false},{"id":481273188,"node_id":"MDU6TGFiZWw0ODEyNzMxODg=","url":"https://api.github.com/repos/nest/nest-simulator/labels/S:%20Low","name":"S: Low","color":"ffbfbf","default":false},{"id":481273470,"node_id":"MDU6TGFiZWw0ODEyNzM0NzA=","url":"https://api.github.com/repos/nest/nest-simulator/labels/T:%20Maintenance","name":"T: Maintenance","color":"ffd7a6","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-24T14:58:15Z","updated_at":"2018-10-31T14:05:18Z","closed_at":"2018-10-30T21:59:26Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nest/nest-simulator/pulls/1059","html_url":"https://github.com/nest/nest-simulator/pull/1059","diff_url":"https://github.com/nest/nest-simulator/pull/1059.diff","patch_url":"https://github.com/nest/nest-simulator/pull/1059.patch"},"body":"This is the PR for some issues detected and fixed by @mhelias in the `siegert_neuron`:\r\n1. The absence of input was caught with `std::abs( mu - 0. ) < 1e-12`, which is only true for no / low noise levels. Fix: Use `( theta_shift - mu ) > 6. * sigma` based on Brunel 2000, eq. (22).\r\n2. The relative and absolute errors for the numerical GSL integration routine were fixed to `0.1` for both `siegert1` and `siegert2`. However, their absolute errors differ considerably. Fix: Use zero absolute error and relative error of `1.49e-8` for both.\r\n3. The GSL workspace was allocated on every call. Fix: Only allocate the workspace on creation of the `siegert_neuron`.\r\n\r\nA test relied on the first issue to create a `siegert_neuron` modelling the external drive. This is also fixed by adjusting `theta` for this neuron."},"comment":{"url":"https://api.github.com/repos/nest/nest-simulator/issues/comments/434699763","html_url":"https://github.com/nest/nest-simulator/pull/1059#issuecomment-434699763","issue_url":"https://api.github.com/repos/nest/nest-simulator/issues/1059","id":434699763,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDY5OTc2Mw==","user":{"login":"AlexVanMeegen","id":32771370,"node_id":"MDQ6VXNlcjMyNzcxMzcw","avatar_url":"https://avatars2.githubusercontent.com/u/32771370?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexVanMeegen","html_url":"https://github.com/AlexVanMeegen","followers_url":"https://api.github.com/users/AlexVanMeegen/followers","following_url":"https://api.github.com/users/AlexVanMeegen/following{/other_user}","gists_url":"https://api.github.com/users/AlexVanMeegen/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexVanMeegen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexVanMeegen/subscriptions","organizations_url":"https://api.github.com/users/AlexVanMeegen/orgs","repos_url":"https://api.github.com/users/AlexVanMeegen/repos","events_url":"https://api.github.com/users/AlexVanMeegen/events{/privacy}","received_events_url":"https://api.github.com/users/AlexVanMeegen/received_events","type":"User","site_admin":false},"created_at":"2018-10-31T14:05:18Z","updated_at":"2018-10-31T14:05:18Z","author_association":"CONTRIBUTOR","body":"Thanks for the reviews!"}}
{"actor":{"display_login":"AlexVanMeegen"}}