{"action":"created","issue":{"url":"https://api.github.com/repos/Homebrew/brew/issues/4378","repository_url":"https://api.github.com/repos/Homebrew/brew","labels_url":"https://api.github.com/repos/Homebrew/brew/issues/4378/labels{/name}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/4378/comments","events_url":"https://api.github.com/repos/Homebrew/brew/issues/4378/events","html_url":"https://github.com/Homebrew/brew/pull/4378","id":336092123,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NjI3NTU2","number":4378,"title":"curl: enable session cookies","user":{"login":"yan12125","id":1937689,"node_id":"MDQ6VXNlcjE5Mzc2ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/1937689?v=4","gravatar_id":"","url":"https://api.github.com/users/yan12125","html_url":"https://github.com/yan12125","followers_url":"https://api.github.com/users/yan12125/followers","following_url":"https://api.github.com/users/yan12125/following{/other_user}","gists_url":"https://api.github.com/users/yan12125/gists{/gist_id}","starred_url":"https://api.github.com/users/yan12125/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yan12125/subscriptions","organizations_url":"https://api.github.com/users/yan12125/orgs","repos_url":"https://api.github.com/users/yan12125/repos","events_url":"https://api.github.com/users/yan12125/events{/privacy}","received_events_url":"https://api.github.com/users/yan12125/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-06-27T06:24:42Z","updated_at":"2018-07-12T12:18:56Z","closed_at":"2018-07-12T12:18:56Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/4378","html_url":"https://github.com/Homebrew/brew/pull/4378","diff_url":"https://github.com/Homebrew/brew/pull/4378.diff","patch_url":"https://github.com/Homebrew/brew/pull/4378.patch"},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).\r\n       Not sure just fixing parameters in the test is enough or not.\r\n- [x] Have you successfully run `brew style` with your changes locally?\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n\r\n-----\r\n\r\nFor some URLs like the dmg URL in https://gitlab.com/yan12125/homebrew-staging/blob/master/Casks/pulse-secure.rb, cookies from `Set-Cookie` of the first request should be passed down to the following requests, or the file can't be correctly downloaded. For example:\r\n```\r\n$ brew -v cask install pulse-secure\r\n==> Satisfying dependencies\r\n==> Downloading https://wiki.univ-nantes.fr/_media/nomade:pulse_clients:ps-pulse-mac-9.0r1.0-b571-installer.dmg\r\n/usr/bin/curl -q --show-error --user-agent Homebrew/1.6.9-33-g0d33aba (Macintosh; Intel Mac OS X 10.13.5) curl/7.54.0 --fail --location --remote-time --continue-at - --output /Users/yen/Library/Caches/Homebrew/Cask/pulse-secure--9.0r1.0-b571.dmg.incomplete https://wiki.univ-nantes.fr/_media/nomade:pulse_clients:ps-pulse-mac-9.0r1.0-b571-installer.dmg\r\n  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current\r\n                                 Dload  Upload   Total   Spent    Left  Speed\r\n  0   571    0     0    0     0      0      0 --:--:--  0:00:04 --:--:--     0\r\n  0     0    0     0    0     0      0      0 --:--:--  0:00:06 --:--:--     0\r\n  0   571    0     0    0     0      0      0 --:--:--  0:00:10 --:--:--     0\r\n  0     0    0     0    0     0      0      0 --:--:--  0:00:11 --:--:--     0\r\n  0     0    0     0    0     0      0      0 --:--:--  0:00:13 --:--:--     0^C\r\n```\r\nAdding two parameters to `curl` does the trick:\r\n```\r\n$ brew -v cask install pulse-secure\r\nUpdating Homebrew...\r\n==> Satisfying dependencies\r\n==> Downloading https://wiki.univ-nantes.fr/_media/nomade:pulse_clients:ps-pulse-mac-9.0r1.0-b571-installer.dmg\r\n/usr/bin/curl -q --show-error --user-agent Homebrew/1.6.9-34-gd47f485 (Macintosh; Intel Mac OS X 10.13.5) curl/7.54.0 --fail --location --remote-time --continue-at - --cookie-jar /dev/null --output /Users/yen/Library/Caches/Homebrew/Cask/pulse-secure--9.0r1.0-b571.dmg.incomplete https://wiki.univ-nantes.fr/_media/nomade:pulse_clients:ps-pulse-mac-9.0r1.0-b571-installer.dmg\r\n  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current\r\n                                 Dload  Upload   Total   Spent    Left  Speed\r\n  0   571    0     0    0     0      0      0 --:--:--  0:00:02 --:--:--     0\r\n  0     0    0     0    0     0      0      0 --:--:--  0:00:03 --:--:--     0\r\n100 15.6M  100 15.6M    0     0   219k      0  0:01:13  0:01:13 --:--:--  418k\r\n==> Verifying checksum for Cask pulse-secure\r\n```"},"comment":{"url":"https://api.github.com/repos/Homebrew/brew/issues/comments/404492790","html_url":"https://github.com/Homebrew/brew/pull/4378#issuecomment-404492790","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/4378","id":404492790,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDQ5Mjc5MA==","user":{"login":"yan12125","id":1937689,"node_id":"MDQ6VXNlcjE5Mzc2ODk=","avatar_url":"https://avatars3.githubusercontent.com/u/1937689?v=4","gravatar_id":"","url":"https://api.github.com/users/yan12125","html_url":"https://github.com/yan12125","followers_url":"https://api.github.com/users/yan12125/followers","following_url":"https://api.github.com/users/yan12125/following{/other_user}","gists_url":"https://api.github.com/users/yan12125/gists{/gist_id}","starred_url":"https://api.github.com/users/yan12125/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yan12125/subscriptions","organizations_url":"https://api.github.com/users/yan12125/orgs","repos_url":"https://api.github.com/users/yan12125/repos","events_url":"https://api.github.com/users/yan12125/events{/privacy}","received_events_url":"https://api.github.com/users/yan12125/received_events","type":"User","site_admin":false},"created_at":"2018-07-12T12:18:56Z","updated_at":"2018-07-12T12:18:56Z","author_association":"NONE","body":"> The url on casks supports setting cookies with cookies: {}. Have you tried that, @yan12125?\r\n\r\nNope. And my Mac gets broken a few days ago. I'm afraid I can't test it recently.\r\n\r\n> It should add -b '' when given an empty hash, which seems to work with your pulse-secure example.\r\n\r\nConfirmed add -b '' to the curl command works. I think this pull request is no longer necessary. Thanks!"}}
{"actor":{"display_login":"yan12125"}}