{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/174411732","pull_request_review_id":103758683,"id":174411732,"diff_hunk":"@@ -293,21 +297,26 @@ public boolean isDefined()\n             String groupName = null;\n \n             int typeIndex;\n-            if ( rawHeaderField != null && (typeIndex = rawHeaderField.lastIndexOf( ':' )) != -1 )\n-            {   // Specific type given\n-                name = typeIndex > 0 ? rawHeaderField.substring( 0, typeIndex ) : null;\n-                type = rawHeaderField.substring( typeIndex + 1 );\n-                int groupNameStartIndex = type.indexOf( '(' );\n-                if ( groupNameStartIndex != -1 )\n-                {   // Specific group given also\n-                    if ( !type.endsWith( \")\" ) )\n-                    {\n-                        throw new IllegalArgumentException( \"Group specification in '\" + rawHeaderField +\n-                                \"' is invalid, format expected to be 'name:TYPE(group)' \" +\n-                                \"where TYPE and (group) are optional\" );\n+\n+            if ( rawHeaderField != null )\n+            {\n+                String rawHeaderUntilOptions = rawHeaderField.split( \"\\\\{\" )[0];","path":"community/kernel/src/main/java/org/neo4j/unsafe/impl/batchimport/input/csv/DataFactories.java","position":46,"original_position":46,"commit_id":"308233e6cc3df5b06ede103a6049c5603470a4fc","original_commit_id":"308233e6cc3df5b06ede103a6049c5603470a4fc","user":{"login":"sherfert","id":22634484,"avatar_url":"https://avatars0.githubusercontent.com/u/22634484?v=4","gravatar_id":"","url":"https://api.github.com/users/sherfert","html_url":"https://github.com/sherfert","followers_url":"https://api.github.com/users/sherfert/followers","following_url":"https://api.github.com/users/sherfert/following{/other_user}","gists_url":"https://api.github.com/users/sherfert/gists{/gist_id}","starred_url":"https://api.github.com/users/sherfert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherfert/subscriptions","organizations_url":"https://api.github.com/users/sherfert/orgs","repos_url":"https://api.github.com/users/sherfert/repos","events_url":"https://api.github.com/users/sherfert/events{/privacy}","received_events_url":"https://api.github.com/users/sherfert/received_events","type":"User","site_admin":false},"body":"Does that mean the header must not contain `{` anywhere before the new options? Can we always guarantee that?","created_at":"2018-03-14T10:23:15Z","updated_at":"2018-03-14T10:58:22Z","html_url":"https://github.com/neo4j/neo4j/pull/11203#discussion_r174411732","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11203","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/174411732"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11203#discussion_r174411732"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11203"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/11203","id":173756276,"html_url":"https://github.com/neo4j/neo4j/pull/11203","diff_url":"https://github.com/neo4j/neo4j/pull/11203.diff","patch_url":"https://github.com/neo4j/neo4j/pull/11203.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/11203","number":11203,"state":"open","locked":false,"title":"Improve csv header parsing for batch importer 1","user":{"login":"SaschaPeukert","id":6998439,"avatar_url":"https://avatars0.githubusercontent.com/u/6998439?v=4","gravatar_id":"","url":"https://api.github.com/users/SaschaPeukert","html_url":"https://github.com/SaschaPeukert","followers_url":"https://api.github.com/users/SaschaPeukert/followers","following_url":"https://api.github.com/users/SaschaPeukert/following{/other_user}","gists_url":"https://api.github.com/users/SaschaPeukert/gists{/gist_id}","starred_url":"https://api.github.com/users/SaschaPeukert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaschaPeukert/subscriptions","organizations_url":"https://api.github.com/users/SaschaPeukert/orgs","repos_url":"https://api.github.com/users/SaschaPeukert/repos","events_url":"https://api.github.com/users/SaschaPeukert/events{/privacy}","received_events_url":"https://api.github.com/users/SaschaPeukert/received_events","type":"User","site_admin":false},"body":"This one covers point","created_at":"2018-03-08T14:52:08Z","updated_at":"2018-03-14T10:58:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b7e9db1e8e185c03ba271e3b18c5a80db4b9b4c","assignee":{"login":"sherfert","id":22634484,"avatar_url":"https://avatars0.githubusercontent.com/u/22634484?v=4","gravatar_id":"","url":"https://api.github.com/users/sherfert","html_url":"https://github.com/sherfert","followers_url":"https://api.github.com/users/sherfert/followers","following_url":"https://api.github.com/users/sherfert/following{/other_user}","gists_url":"https://api.github.com/users/sherfert/gists{/gist_id}","starred_url":"https://api.github.com/users/sherfert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherfert/subscriptions","organizations_url":"https://api.github.com/users/sherfert/orgs","repos_url":"https://api.github.com/users/sherfert/repos","events_url":"https://api.github.com/users/sherfert/events{/privacy}","received_events_url":"https://api.github.com/users/sherfert/received_events","type":"User","site_admin":false},"assignees":[{"login":"sherfert","id":22634484,"avatar_url":"https://avatars0.githubusercontent.com/u/22634484?v=4","gravatar_id":"","url":"https://api.github.com/users/sherfert","html_url":"https://github.com/sherfert","followers_url":"https://api.github.com/users/sherfert/followers","following_url":"https://api.github.com/users/sherfert/following{/other_user}","gists_url":"https://api.github.com/users/sherfert/gists{/gist_id}","starred_url":"https://api.github.com/users/sherfert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherfert/subscriptions","organizations_url":"https://api.github.com/users/sherfert/orgs","repos_url":"https://api.github.com/users/sherfert/repos","events_url":"https://api.github.com/users/sherfert/events{/privacy}","received_events_url":"https://api.github.com/users/sherfert/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":695463446,"url":"https://api.github.com/repos/neo4j/neo4j/labels/3.4","name":"3.4","color":"f9d0c4","default":false},{"id":19073042,"url":"https://api.github.com/repos/neo4j/neo4j/labels/cypher","name":"cypher","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11203/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11203/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/11203/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/308233e6cc3df5b06ede103a6049c5603470a4fc","head":{"label":"SaschaPeukert:3.4-improve-csv-header-parsing","ref":"3.4-improve-csv-header-parsing","sha":"308233e6cc3df5b06ede103a6049c5603470a4fc","user":{"login":"SaschaPeukert","id":6998439,"avatar_url":"https://avatars0.githubusercontent.com/u/6998439?v=4","gravatar_id":"","url":"https://api.github.com/users/SaschaPeukert","html_url":"https://github.com/SaschaPeukert","followers_url":"https://api.github.com/users/SaschaPeukert/followers","following_url":"https://api.github.com/users/SaschaPeukert/following{/other_user}","gists_url":"https://api.github.com/users/SaschaPeukert/gists{/gist_id}","starred_url":"https://api.github.com/users/SaschaPeukert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaschaPeukert/subscriptions","organizations_url":"https://api.github.com/users/SaschaPeukert/orgs","repos_url":"https://api.github.com/users/SaschaPeukert/repos","events_url":"https://api.github.com/users/SaschaPeukert/events{/privacy}","received_events_url":"https://api.github.com/users/SaschaPeukert/received_events","type":"User","site_admin":false},"repo":{"id":63535083,"name":"neo4j","full_name":"SaschaPeukert/neo4j","owner":{"login":"SaschaPeukert","id":6998439,"avatar_url":"https://avatars0.githubusercontent.com/u/6998439?v=4","gravatar_id":"","url":"https://api.github.com/users/SaschaPeukert","html_url":"https://github.com/SaschaPeukert","followers_url":"https://api.github.com/users/SaschaPeukert/followers","following_url":"https://api.github.com/users/SaschaPeukert/following{/other_user}","gists_url":"https://api.github.com/users/SaschaPeukert/gists{/gist_id}","starred_url":"https://api.github.com/users/SaschaPeukert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaschaPeukert/subscriptions","organizations_url":"https://api.github.com/users/SaschaPeukert/orgs","repos_url":"https://api.github.com/users/SaschaPeukert/repos","events_url":"https://api.github.com/users/SaschaPeukert/events{/privacy}","received_events_url":"https://api.github.com/users/SaschaPeukert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SaschaPeukert/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/SaschaPeukert/neo4j","forks_url":"https://api.github.com/repos/SaschaPeukert/neo4j/forks","keys_url":"https://api.github.com/repos/SaschaPeukert/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SaschaPeukert/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SaschaPeukert/neo4j/teams","hooks_url":"https://api.github.com/repos/SaschaPeukert/neo4j/hooks","issue_events_url":"https://api.github.com/repos/SaschaPeukert/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/SaschaPeukert/neo4j/events","assignees_url":"https://api.github.com/repos/SaschaPeukert/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/SaschaPeukert/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/SaschaPeukert/neo4j/tags","blobs_url":"https://api.github.com/repos/SaschaPeukert/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SaschaPeukert/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SaschaPeukert/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/SaschaPeukert/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SaschaPeukert/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/SaschaPeukert/neo4j/languages","stargazers_url":"https://api.github.com/repos/SaschaPeukert/neo4j/stargazers","contributors_url":"https://api.github.com/repos/SaschaPeukert/neo4j/contributors","subscribers_url":"https://api.github.com/repos/SaschaPeukert/neo4j/subscribers","subscription_url":"https://api.github.com/repos/SaschaPeukert/neo4j/subscription","commits_url":"https://api.github.com/repos/SaschaPeukert/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/SaschaPeukert/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/SaschaPeukert/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/SaschaPeukert/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/SaschaPeukert/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/SaschaPeukert/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SaschaPeukert/neo4j/merges","archive_url":"https://api.github.com/repos/SaschaPeukert/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SaschaPeukert/neo4j/downloads","issues_url":"https://api.github.com/repos/SaschaPeukert/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/SaschaPeukert/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/SaschaPeukert/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/SaschaPeukert/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SaschaPeukert/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/SaschaPeukert/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/SaschaPeukert/neo4j/deployments","created_at":"2016-07-17T14:09:33Z","updated_at":"2016-07-17T14:09:56Z","pushed_at":"2018-03-14T09:38:55Z","git_url":"git://github.com/SaschaPeukert/neo4j.git","ssh_url":"git@github.com:SaschaPeukert/neo4j.git","clone_url":"https://github.com/SaschaPeukert/neo4j.git","svn_url":"https://github.com/SaschaPeukert/neo4j","homepage":"http://neo4j.com","size":394361,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"3.1"}},"base":{"label":"neo4j:3.4","ref":"3.4","sha":"251e9a8d4c3303a8f776c4ee24827e36c3519d38","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2018-03-14T10:44:03Z","pushed_at":"2018-03-14T10:47:55Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":393848,"stargazers_count":4817,"watchers_count":4817,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1301,"mirror_url":null,"archived":false,"open_issues_count":337,"license":null,"forks":1301,"open_issues":337,"watchers":4817,"default_branch":"3.4"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11203"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11203"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11203"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11203/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11203/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11203/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/308233e6cc3df5b06ede103a6049c5603470a4fc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sherfert"}}