{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments/173939868","pull_request_review_id":103211461,"id":173939868,"diff_hunk":"@@ -157,15 +156,23 @@\n       this._clearTable();\n       // TODO(cais): Support sorting.\n       this._renderHeader();\n+      let activeRow;\n       for (const runKey in this._runKey2Count) {\n         if (this._runKey2Count.hasOwnProperty(runKey)) {\n           const sessionRun = JSON.parse(runKey);\n           const count = this._runKey2Count[runKey];\n           const isActive = this._activeRunKey === runKey;\n           const numDevices = this._runKey2NumDevices[runKey];\n-          this._renderRow(sessionRun, numDevices, count, isActive, this.soleActive);\n+          const row = this._renderRow(sessionRun, numDevices, count, isActive, this.soleActive);\n+          if (row) {\n+            activeRow = row;\n+          }\n         }\n       }\n+\n+      if (activeRow) {\n+        activeRow.parentNode.parentNode.parentNode.scrollTop = activeRow.offsetTop;","path":"tensorboard/plugins/debugger/tf_debugger_dashboard/tf-session-runs-view.html","position":28,"original_position":28,"commit_id":"8642e48d3b3e64f750dc23d6a8f1edbe9135ff27","original_commit_id":"8642e48d3b3e64f750dc23d6a8f1edbe9135ff27","user":{"login":"chihuahua","id":4221553,"avatar_url":"https://avatars0.githubusercontent.com/u/4221553?v=4","gravatar_id":"","url":"https://api.github.com/users/chihuahua","html_url":"https://github.com/chihuahua","followers_url":"https://api.github.com/users/chihuahua/followers","following_url":"https://api.github.com/users/chihuahua/following{/other_user}","gists_url":"https://api.github.com/users/chihuahua/gists{/gist_id}","starred_url":"https://api.github.com/users/chihuahua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chihuahua/subscriptions","organizations_url":"https://api.github.com/users/chihuahua/orgs","repos_url":"https://api.github.com/users/chihuahua/repos","events_url":"https://api.github.com/users/chihuahua/events{/privacy}","received_events_url":"https://api.github.com/users/chihuahua/received_events","type":"User","site_admin":false},"body":"Could we use a more specific selector? In case one day, a future dev adds a container in between the layers?","created_at":"2018-03-12T20:42:26Z","updated_at":"2018-03-12T20:42:50Z","html_url":"https://github.com/tensorflow/tensorboard/pull/1038#discussion_r173939868","pull_request_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1038","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments/173939868"},"html":{"href":"https://github.com/tensorflow/tensorboard/pull/1038#discussion_r173939868"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1038"}}},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1038","id":174476960,"html_url":"https://github.com/tensorflow/tensorboard/pull/1038","diff_url":"https://github.com/tensorflow/tensorboard/pull/1038.diff","patch_url":"https://github.com/tensorflow/tensorboard/pull/1038.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/1038","number":1038,"state":"open","locked":false,"title":"[Debugger Plugin] Fix session run list UI","user":{"login":"caisq","id":16824702,"avatar_url":"https://avatars2.githubusercontent.com/u/16824702?v=4","gravatar_id":"","url":"https://api.github.com/users/caisq","html_url":"https://github.com/caisq","followers_url":"https://api.github.com/users/caisq/followers","following_url":"https://api.github.com/users/caisq/following{/other_user}","gists_url":"https://api.github.com/users/caisq/gists{/gist_id}","starred_url":"https://api.github.com/users/caisq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caisq/subscriptions","organizations_url":"https://api.github.com/users/caisq/orgs","repos_url":"https://api.github.com/users/caisq/repos","events_url":"https://api.github.com/users/caisq/events{/privacy}","received_events_url":"https://api.github.com/users/caisq/received_events","type":"User","site_admin":false},"body":"* Let the table occupy 100% of the parent's width\r\n* Let the table not expand to unreasonably large sizes if there are\r\n  many session.run() types and/or a session.run() with many fetches\r\n  or feeds\r\n* When the table is scrolled, auto-scroll to the row that corresponds\r\n  to the active session.run().","created_at":"2018-03-12T19:53:09Z","updated_at":"2018-03-12T20:42:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"443b1f9db6ce042ebc31e46ddcec69972574d464","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":685702960,"url":"https://api.github.com/repos/tensorflow/tensorboard/labels/plugin:debugger","name":"plugin:debugger","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1038/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1038/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/1038/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorboard/statuses/8642e48d3b3e64f750dc23d6a8f1edbe9135ff27","head":{"label":"caisq:fix-session-run-list","ref":"fix-session-run-list","sha":"8642e48d3b3e64f750dc23d6a8f1edbe9135ff27","user":{"login":"caisq","id":16824702,"avatar_url":"https://avatars2.githubusercontent.com/u/16824702?v=4","gravatar_id":"","url":"https://api.github.com/users/caisq","html_url":"https://github.com/caisq","followers_url":"https://api.github.com/users/caisq/followers","following_url":"https://api.github.com/users/caisq/following{/other_user}","gists_url":"https://api.github.com/users/caisq/gists{/gist_id}","starred_url":"https://api.github.com/users/caisq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caisq/subscriptions","organizations_url":"https://api.github.com/users/caisq/orgs","repos_url":"https://api.github.com/users/caisq/repos","events_url":"https://api.github.com/users/caisq/events{/privacy}","received_events_url":"https://api.github.com/users/caisq/received_events","type":"User","site_admin":false},"repo":{"id":98921142,"name":"tensorboard","full_name":"caisq/tensorboard","owner":{"login":"caisq","id":16824702,"avatar_url":"https://avatars2.githubusercontent.com/u/16824702?v=4","gravatar_id":"","url":"https://api.github.com/users/caisq","html_url":"https://github.com/caisq","followers_url":"https://api.github.com/users/caisq/followers","following_url":"https://api.github.com/users/caisq/following{/other_user}","gists_url":"https://api.github.com/users/caisq/gists{/gist_id}","starred_url":"https://api.github.com/users/caisq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caisq/subscriptions","organizations_url":"https://api.github.com/users/caisq/orgs","repos_url":"https://api.github.com/users/caisq/repos","events_url":"https://api.github.com/users/caisq/events{/privacy}","received_events_url":"https://api.github.com/users/caisq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caisq/tensorboard","description":"TensorFlow's Visualization Toolkit","fork":true,"url":"https://api.github.com/repos/caisq/tensorboard","forks_url":"https://api.github.com/repos/caisq/tensorboard/forks","keys_url":"https://api.github.com/repos/caisq/tensorboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caisq/tensorboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caisq/tensorboard/teams","hooks_url":"https://api.github.com/repos/caisq/tensorboard/hooks","issue_events_url":"https://api.github.com/repos/caisq/tensorboard/issues/events{/number}","events_url":"https://api.github.com/repos/caisq/tensorboard/events","assignees_url":"https://api.github.com/repos/caisq/tensorboard/assignees{/user}","branches_url":"https://api.github.com/repos/caisq/tensorboard/branches{/branch}","tags_url":"https://api.github.com/repos/caisq/tensorboard/tags","blobs_url":"https://api.github.com/repos/caisq/tensorboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caisq/tensorboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caisq/tensorboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/caisq/tensorboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caisq/tensorboard/statuses/{sha}","languages_url":"https://api.github.com/repos/caisq/tensorboard/languages","stargazers_url":"https://api.github.com/repos/caisq/tensorboard/stargazers","contributors_url":"https://api.github.com/repos/caisq/tensorboard/contributors","subscribers_url":"https://api.github.com/repos/caisq/tensorboard/subscribers","subscription_url":"https://api.github.com/repos/caisq/tensorboard/subscription","commits_url":"https://api.github.com/repos/caisq/tensorboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/caisq/tensorboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/caisq/tensorboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/caisq/tensorboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/caisq/tensorboard/contents/{+path}","compare_url":"https://api.github.com/repos/caisq/tensorboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caisq/tensorboard/merges","archive_url":"https://api.github.com/repos/caisq/tensorboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caisq/tensorboard/downloads","issues_url":"https://api.github.com/repos/caisq/tensorboard/issues{/number}","pulls_url":"https://api.github.com/repos/caisq/tensorboard/pulls{/number}","milestones_url":"https://api.github.com/repos/caisq/tensorboard/milestones{/number}","notifications_url":"https://api.github.com/repos/caisq/tensorboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caisq/tensorboard/labels{/name}","releases_url":"https://api.github.com/repos/caisq/tensorboard/releases{/id}","deployments_url":"https://api.github.com/repos/caisq/tensorboard/deployments","created_at":"2017-07-31T19:12:11Z","updated_at":"2017-10-02T18:22:07Z","pushed_at":"2018-03-12T19:52:54Z","git_url":"git://github.com/caisq/tensorboard.git","ssh_url":"git@github.com:caisq/tensorboard.git","clone_url":"https://github.com/caisq/tensorboard.git","svn_url":"https://github.com/caisq/tensorboard","homepage":null,"size":10893,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"57daa455af743075afd39c5d4aef5033e1279ff4","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":91379993,"name":"tensorboard","full_name":"tensorflow/tensorboard","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorboard","description":"TensorFlow's Visualization Toolkit","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorboard","forks_url":"https://api.github.com/repos/tensorflow/tensorboard/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorboard/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorboard/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorboard/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorboard/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorboard/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorboard/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorboard/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorboard/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorboard/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorboard/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorboard/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorboard/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorboard/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorboard/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorboard/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorboard/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorboard/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorboard/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorboard/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorboard/deployments","created_at":"2017-05-15T20:08:07Z","updated_at":"2018-03-12T20:12:22Z","pushed_at":"2018-03-12T19:53:10Z","git_url":"git://github.com/tensorflow/tensorboard.git","ssh_url":"git@github.com:tensorflow/tensorboard.git","clone_url":"https://github.com/tensorflow/tensorboard.git","svn_url":"https://github.com/tensorflow/tensorboard","homepage":null,"size":10983,"stargazers_count":1344,"watchers_count":1344,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":329,"mirror_url":null,"archived":false,"open_issues_count":197,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":329,"open_issues":197,"watchers":1344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1038"},"html":{"href":"https://github.com/tensorflow/tensorboard/pull/1038"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorboard/issues/1038"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorboard/issues/1038/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1038/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1038/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorboard/statuses/8642e48d3b3e64f750dc23d6a8f1edbe9135ff27"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chihuahua"}}