{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/169366175","pull_request_review_id":97880547,"id":169366175,"diff_hunk":"@@ -111,3 +111,8 @@ def state(self):\n     def unit_of_measurement(self):\n         \"\"\"Return the unit of measurement of this entity, if any.\"\"\"\n         return self._sensor.unit_of_measurement\n+\n+    def update(self):\n+        \"\"\"Check and restart pykwb.\"\"\"\n+        if not self._easyfire.is_alive():\n+            self._easyfire.run_thread()","path":"homeassistant/components/sensor/kwb.py","position":17,"original_position":17,"commit_id":"5d754c7414a186f529b9219ec8f58d0be988a800","original_commit_id":"5d754c7414a186f529b9219ec8f58d0be988a800","user":{"login":"pvizeli","id":15338540,"avatar_url":"https://avatars3.githubusercontent.com/u/15338540?v=4","gravatar_id":"","url":"https://api.github.com/users/pvizeli","html_url":"https://github.com/pvizeli","followers_url":"https://api.github.com/users/pvizeli/followers","following_url":"https://api.github.com/users/pvizeli/following{/other_user}","gists_url":"https://api.github.com/users/pvizeli/gists{/gist_id}","starred_url":"https://api.github.com/users/pvizeli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvizeli/subscriptions","organizations_url":"https://api.github.com/users/pvizeli/orgs","repos_url":"https://api.github.com/users/pvizeli/repos","events_url":"https://api.github.com/users/pvizeli/events{/privacy}","received_events_url":"https://api.github.com/users/pvizeli/received_events","type":"User","site_admin":false},"body":"You should make pykwb robust inside main loop and not make a hack in home-assistant.","created_at":"2018-02-20T15:58:16Z","updated_at":"2018-02-20T15:58:53Z","html_url":"https://github.com/home-assistant/home-assistant/pull/12544#discussion_r169366175","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12544","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/169366175"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/12544#discussion_r169366175"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12544"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12544","id":170166675,"html_url":"https://github.com/home-assistant/home-assistant/pull/12544","diff_url":"https://github.com/home-assistant/home-assistant/pull/12544.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/12544.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/12544","number":12544,"state":"open","locked":false,"title":"KWB Easyfire component stability fixes","user":{"login":"bimbar","id":7500195,"avatar_url":"https://avatars0.githubusercontent.com/u/7500195?v=4","gravatar_id":"","url":"https://api.github.com/users/bimbar","html_url":"https://github.com/bimbar","followers_url":"https://api.github.com/users/bimbar/followers","following_url":"https://api.github.com/users/bimbar/following{/other_user}","gists_url":"https://api.github.com/users/bimbar/gists{/gist_id}","starred_url":"https://api.github.com/users/bimbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bimbar/subscriptions","organizations_url":"https://api.github.com/users/bimbar/orgs","repos_url":"https://api.github.com/users/bimbar/repos","events_url":"https://api.github.com/users/bimbar/events{/privacy}","received_events_url":"https://api.github.com/users/bimbar/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\nThis is a fix of an issue where the pykwb thread would stop running if network connectivity is flaky or something similar. The PR addresses this by checking on update() if the thread is running and restarting it if necessary.\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [x] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [x] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [x] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [x] New files were added to `.coveragerc`.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2018-02-20T11:31:57Z","updated_at":"2018-02-20T15:58:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c262a478bf01a3e236280f89645979ca34f9cbf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andrey-git","id":5478779,"avatar_url":"https://avatars0.githubusercontent.com/u/5478779?v=4","gravatar_id":"","url":"https://api.github.com/users/andrey-git","html_url":"https://github.com/andrey-git","followers_url":"https://api.github.com/users/andrey-git/followers","following_url":"https://api.github.com/users/andrey-git/following{/other_user}","gists_url":"https://api.github.com/users/andrey-git/gists{/gist_id}","starred_url":"https://api.github.com/users/andrey-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrey-git/subscriptions","organizations_url":"https://api.github.com/users/andrey-git/orgs","repos_url":"https://api.github.com/users/andrey-git/repos","events_url":"https://api.github.com/users/andrey-git/events{/privacy}","received_events_url":"https://api.github.com/users/andrey-git/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":532550479,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20sensor.kwb","name":"platform: sensor.kwb","color":"ededed","default":false},{"id":832964196,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/small-pr","name":"small-pr","color":"e5bd7e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12544/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12544/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/12544/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/5d754c7414a186f529b9219ec8f58d0be988a800","head":{"label":"bimbar:kwb_easyfire_stability_fix","ref":"kwb_easyfire_stability_fix","sha":"5d754c7414a186f529b9219ec8f58d0be988a800","user":{"login":"bimbar","id":7500195,"avatar_url":"https://avatars0.githubusercontent.com/u/7500195?v=4","gravatar_id":"","url":"https://api.github.com/users/bimbar","html_url":"https://github.com/bimbar","followers_url":"https://api.github.com/users/bimbar/followers","following_url":"https://api.github.com/users/bimbar/following{/other_user}","gists_url":"https://api.github.com/users/bimbar/gists{/gist_id}","starred_url":"https://api.github.com/users/bimbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bimbar/subscriptions","organizations_url":"https://api.github.com/users/bimbar/orgs","repos_url":"https://api.github.com/users/bimbar/repos","events_url":"https://api.github.com/users/bimbar/events{/privacy}","received_events_url":"https://api.github.com/users/bimbar/received_events","type":"User","site_admin":false},"repo":{"id":122184465,"name":"home-assistant","full_name":"bimbar/home-assistant","owner":{"login":"bimbar","id":7500195,"avatar_url":"https://avatars0.githubusercontent.com/u/7500195?v=4","gravatar_id":"","url":"https://api.github.com/users/bimbar","html_url":"https://github.com/bimbar","followers_url":"https://api.github.com/users/bimbar/followers","following_url":"https://api.github.com/users/bimbar/following{/other_user}","gists_url":"https://api.github.com/users/bimbar/gists{/gist_id}","starred_url":"https://api.github.com/users/bimbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bimbar/subscriptions","organizations_url":"https://api.github.com/users/bimbar/orgs","repos_url":"https://api.github.com/users/bimbar/repos","events_url":"https://api.github.com/users/bimbar/events{/privacy}","received_events_url":"https://api.github.com/users/bimbar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bimbar/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/bimbar/home-assistant","forks_url":"https://api.github.com/repos/bimbar/home-assistant/forks","keys_url":"https://api.github.com/repos/bimbar/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bimbar/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bimbar/home-assistant/teams","hooks_url":"https://api.github.com/repos/bimbar/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/bimbar/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/bimbar/home-assistant/events","assignees_url":"https://api.github.com/repos/bimbar/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/bimbar/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/bimbar/home-assistant/tags","blobs_url":"https://api.github.com/repos/bimbar/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bimbar/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bimbar/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/bimbar/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bimbar/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/bimbar/home-assistant/languages","stargazers_url":"https://api.github.com/repos/bimbar/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/bimbar/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/bimbar/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/bimbar/home-assistant/subscription","commits_url":"https://api.github.com/repos/bimbar/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/bimbar/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/bimbar/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/bimbar/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/bimbar/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/bimbar/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bimbar/home-assistant/merges","archive_url":"https://api.github.com/repos/bimbar/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bimbar/home-assistant/downloads","issues_url":"https://api.github.com/repos/bimbar/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/bimbar/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/bimbar/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/bimbar/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bimbar/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/bimbar/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/bimbar/home-assistant/deployments","created_at":"2018-02-20T10:33:15Z","updated_at":"2018-02-20T10:33:24Z","pushed_at":"2018-02-20T12:06:02Z","git_url":"git://github.com/bimbar/home-assistant.git","ssh_url":"git@github.com:bimbar/home-assistant.git","clone_url":"https://github.com/bimbar/home-assistant.git","svn_url":"https://github.com/bimbar/home-assistant","homepage":"https://home-assistant.io","size":78725,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"39847ea651c438a819f52d6abaf6bbc63da4e67e","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-02-20T15:34:51Z","pushed_at":"2018-02-20T15:46:21Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":78724,"stargazers_count":12653,"watchers_count":12653,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3658,"mirror_url":null,"archived":false,"open_issues_count":839,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3658,"open_issues":839,"watchers":12653,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12544"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/12544"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/12544"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/12544/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12544/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12544/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/5d754c7414a186f529b9219ec8f58d0be988a800"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pvizeli"}}