{"action":"opened","number":9,"pull_request":{"url":"https://api.github.com/repos/porty/httprecorder/pulls/9","id":203939472,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzOTM5NDcy","html_url":"https://github.com/porty/httprecorder/pull/9","diff_url":"https://github.com/porty/httprecorder/pull/9.diff","patch_url":"https://github.com/porty/httprecorder/pull/9.patch","issue_url":"https://api.github.com/repos/porty/httprecorder/issues/9","number":9,"state":"open","locked":false,"title":"Fix reading of request bodies","user":{"login":"porty","id":1373315,"node_id":"MDQ6VXNlcjEzNzMzMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1373315?v=4","gravatar_id":"","url":"https://api.github.com/users/porty","html_url":"https://github.com/porty","followers_url":"https://api.github.com/users/porty/followers","following_url":"https://api.github.com/users/porty/following{/other_user}","gists_url":"https://api.github.com/users/porty/gists{/gist_id}","starred_url":"https://api.github.com/users/porty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/porty/subscriptions","organizations_url":"https://api.github.com/users/porty/orgs","repos_url":"https://api.github.com/users/porty/repos","events_url":"https://api.github.com/users/porty/events{/privacy}","received_events_url":"https://api.github.com/users/porty/received_events","type":"User","site_admin":false},"body":"We're currently attempting to read a request body _after_ it has been sent off upstream and therefore has been already read and closed. This causes panics with attempts to read a closed body.\r\n\r\nThis fixes the middleware to read and replace the body before sending it to the next handler.\r\n\r\n# WIP\r\n\r\nThis code is a little gross and rushed","created_at":"2018-07-25T19:30:09Z","updated_at":"2018-07-25T19:30:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/porty/httprecorder/pulls/9/commits","review_comments_url":"https://api.github.com/repos/porty/httprecorder/pulls/9/comments","review_comment_url":"https://api.github.com/repos/porty/httprecorder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/porty/httprecorder/issues/9/comments","statuses_url":"https://api.github.com/repos/porty/httprecorder/statuses/678b40d3d66436760c86e30ab8783fe59e709a75","head":{"label":"porty:fix-post-body-reading","ref":"fix-post-body-reading","sha":"678b40d3d66436760c86e30ab8783fe59e709a75","user":{"login":"porty","id":1373315,"node_id":"MDQ6VXNlcjEzNzMzMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1373315?v=4","gravatar_id":"","url":"https://api.github.com/users/porty","html_url":"https://github.com/porty","followers_url":"https://api.github.com/users/porty/followers","following_url":"https://api.github.com/users/porty/following{/other_user}","gists_url":"https://api.github.com/users/porty/gists{/gist_id}","starred_url":"https://api.github.com/users/porty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/porty/subscriptions","organizations_url":"https://api.github.com/users/porty/orgs","repos_url":"https://api.github.com/users/porty/repos","events_url":"https://api.github.com/users/porty/events{/privacy}","received_events_url":"https://api.github.com/users/porty/received_events","type":"User","site_admin":false},"repo":{"id":141966380,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE5NjYzODA=","name":"httprecorder","full_name":"porty/httprecorder","owner":{"login":"porty","id":1373315,"node_id":"MDQ6VXNlcjEzNzMzMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1373315?v=4","gravatar_id":"","url":"https://api.github.com/users/porty","html_url":"https://github.com/porty","followers_url":"https://api.github.com/users/porty/followers","following_url":"https://api.github.com/users/porty/following{/other_user}","gists_url":"https://api.github.com/users/porty/gists{/gist_id}","starred_url":"https://api.github.com/users/porty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/porty/subscriptions","organizations_url":"https://api.github.com/users/porty/orgs","repos_url":"https://api.github.com/users/porty/repos","events_url":"https://api.github.com/users/porty/events{/privacy}","received_events_url":"https://api.github.com/users/porty/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/porty/httprecorder","description":"Records HTTP sessions via HTTP middlware","fork":false,"url":"https://api.github.com/repos/porty/httprecorder","forks_url":"https://api.github.com/repos/porty/httprecorder/forks","keys_url":"https://api.github.com/repos/porty/httprecorder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/porty/httprecorder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/porty/httprecorder/teams","hooks_url":"https://api.github.com/repos/porty/httprecorder/hooks","issue_events_url":"https://api.github.com/repos/porty/httprecorder/issues/events{/number}","events_url":"https://api.github.com/repos/porty/httprecorder/events","assignees_url":"https://api.github.com/repos/porty/httprecorder/assignees{/user}","branches_url":"https://api.github.com/repos/porty/httprecorder/branches{/branch}","tags_url":"https://api.github.com/repos/porty/httprecorder/tags","blobs_url":"https://api.github.com/repos/porty/httprecorder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/porty/httprecorder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/porty/httprecorder/git/refs{/sha}","trees_url":"https://api.github.com/repos/porty/httprecorder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/porty/httprecorder/statuses/{sha}","languages_url":"https://api.github.com/repos/porty/httprecorder/languages","stargazers_url":"https://api.github.com/repos/porty/httprecorder/stargazers","contributors_url":"https://api.github.com/repos/porty/httprecorder/contributors","subscribers_url":"https://api.github.com/repos/porty/httprecorder/subscribers","subscription_url":"https://api.github.com/repos/porty/httprecorder/subscription","commits_url":"https://api.github.com/repos/porty/httprecorder/commits{/sha}","git_commits_url":"https://api.github.com/repos/porty/httprecorder/git/commits{/sha}","comments_url":"https://api.github.com/repos/porty/httprecorder/comments{/number}","issue_comment_url":"https://api.github.com/repos/porty/httprecorder/issues/comments{/number}","contents_url":"https://api.github.com/repos/porty/httprecorder/contents/{+path}","compare_url":"https://api.github.com/repos/porty/httprecorder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/porty/httprecorder/merges","archive_url":"https://api.github.com/repos/porty/httprecorder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/porty/httprecorder/downloads","issues_url":"https://api.github.com/repos/porty/httprecorder/issues{/number}","pulls_url":"https://api.github.com/repos/porty/httprecorder/pulls{/number}","milestones_url":"https://api.github.com/repos/porty/httprecorder/milestones{/number}","notifications_url":"https://api.github.com/repos/porty/httprecorder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/porty/httprecorder/labels{/name}","releases_url":"https://api.github.com/repos/porty/httprecorder/releases{/id}","deployments_url":"https://api.github.com/repos/porty/httprecorder/deployments","created_at":"2018-07-23T05:40:25Z","updated_at":"2018-07-25T06:50:45Z","pushed_at":"2018-07-25T19:23:53Z","git_url":"git://github.com/porty/httprecorder.git","ssh_url":"git@github.com:porty/httprecorder.git","clone_url":"https://github.com/porty/httprecorder.git","svn_url":"https://github.com/porty/httprecorder","homepage":null,"size":11,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"porty:master","ref":"master","sha":"5542b2ac0d14ecc09b13303d4de64543de05a41d","user":{"login":"porty","id":1373315,"node_id":"MDQ6VXNlcjEzNzMzMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1373315?v=4","gravatar_id":"","url":"https://api.github.com/users/porty","html_url":"https://github.com/porty","followers_url":"https://api.github.com/users/porty/followers","following_url":"https://api.github.com/users/porty/following{/other_user}","gists_url":"https://api.github.com/users/porty/gists{/gist_id}","starred_url":"https://api.github.com/users/porty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/porty/subscriptions","organizations_url":"https://api.github.com/users/porty/orgs","repos_url":"https://api.github.com/users/porty/repos","events_url":"https://api.github.com/users/porty/events{/privacy}","received_events_url":"https://api.github.com/users/porty/received_events","type":"User","site_admin":false},"repo":{"id":141966380,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE5NjYzODA=","name":"httprecorder","full_name":"porty/httprecorder","owner":{"login":"porty","id":1373315,"node_id":"MDQ6VXNlcjEzNzMzMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1373315?v=4","gravatar_id":"","url":"https://api.github.com/users/porty","html_url":"https://github.com/porty","followers_url":"https://api.github.com/users/porty/followers","following_url":"https://api.github.com/users/porty/following{/other_user}","gists_url":"https://api.github.com/users/porty/gists{/gist_id}","starred_url":"https://api.github.com/users/porty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/porty/subscriptions","organizations_url":"https://api.github.com/users/porty/orgs","repos_url":"https://api.github.com/users/porty/repos","events_url":"https://api.github.com/users/porty/events{/privacy}","received_events_url":"https://api.github.com/users/porty/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/porty/httprecorder","description":"Records HTTP sessions via HTTP middlware","fork":false,"url":"https://api.github.com/repos/porty/httprecorder","forks_url":"https://api.github.com/repos/porty/httprecorder/forks","keys_url":"https://api.github.com/repos/porty/httprecorder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/porty/httprecorder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/porty/httprecorder/teams","hooks_url":"https://api.github.com/repos/porty/httprecorder/hooks","issue_events_url":"https://api.github.com/repos/porty/httprecorder/issues/events{/number}","events_url":"https://api.github.com/repos/porty/httprecorder/events","assignees_url":"https://api.github.com/repos/porty/httprecorder/assignees{/user}","branches_url":"https://api.github.com/repos/porty/httprecorder/branches{/branch}","tags_url":"https://api.github.com/repos/porty/httprecorder/tags","blobs_url":"https://api.github.com/repos/porty/httprecorder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/porty/httprecorder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/porty/httprecorder/git/refs{/sha}","trees_url":"https://api.github.com/repos/porty/httprecorder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/porty/httprecorder/statuses/{sha}","languages_url":"https://api.github.com/repos/porty/httprecorder/languages","stargazers_url":"https://api.github.com/repos/porty/httprecorder/stargazers","contributors_url":"https://api.github.com/repos/porty/httprecorder/contributors","subscribers_url":"https://api.github.com/repos/porty/httprecorder/subscribers","subscription_url":"https://api.github.com/repos/porty/httprecorder/subscription","commits_url":"https://api.github.com/repos/porty/httprecorder/commits{/sha}","git_commits_url":"https://api.github.com/repos/porty/httprecorder/git/commits{/sha}","comments_url":"https://api.github.com/repos/porty/httprecorder/comments{/number}","issue_comment_url":"https://api.github.com/repos/porty/httprecorder/issues/comments{/number}","contents_url":"https://api.github.com/repos/porty/httprecorder/contents/{+path}","compare_url":"https://api.github.com/repos/porty/httprecorder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/porty/httprecorder/merges","archive_url":"https://api.github.com/repos/porty/httprecorder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/porty/httprecorder/downloads","issues_url":"https://api.github.com/repos/porty/httprecorder/issues{/number}","pulls_url":"https://api.github.com/repos/porty/httprecorder/pulls{/number}","milestones_url":"https://api.github.com/repos/porty/httprecorder/milestones{/number}","notifications_url":"https://api.github.com/repos/porty/httprecorder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/porty/httprecorder/labels{/name}","releases_url":"https://api.github.com/repos/porty/httprecorder/releases{/id}","deployments_url":"https://api.github.com/repos/porty/httprecorder/deployments","created_at":"2018-07-23T05:40:25Z","updated_at":"2018-07-25T06:50:45Z","pushed_at":"2018-07-25T19:23:53Z","git_url":"git://github.com/porty/httprecorder.git","ssh_url":"git@github.com:porty/httprecorder.git","clone_url":"https://github.com/porty/httprecorder.git","svn_url":"https://github.com/porty/httprecorder","homepage":null,"size":11,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/porty/httprecorder/pulls/9"},"html":{"href":"https://github.com/porty/httprecorder/pull/9"},"issue":{"href":"https://api.github.com/repos/porty/httprecorder/issues/9"},"comments":{"href":"https://api.github.com/repos/porty/httprecorder/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/porty/httprecorder/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/porty/httprecorder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/porty/httprecorder/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/porty/httprecorder/statuses/678b40d3d66436760c86e30ab8783fe59e709a75"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":66,"deletions":17,"changed_files":4}}
{"actor":{"display_login":"porty"}}