{"action":"created","issue":{"url":"https://api.github.com/repos/batfish/batfish/issues/1314","repository_url":"https://api.github.com/repos/batfish/batfish","labels_url":"https://api.github.com/repos/batfish/batfish/issues/1314/labels{/name}","comments_url":"https://api.github.com/repos/batfish/batfish/issues/1314/comments","events_url":"https://api.github.com/repos/batfish/batfish/issues/1314/events","html_url":"https://github.com/batfish/batfish/pull/1314","id":320469041,"number":1314,"title":"ibdp readability improvements, part 1","user":{"login":"progwriter","id":4763675,"avatar_url":"https://avatars3.githubusercontent.com/u/4763675?v=4","gravatar_id":"","url":"https://api.github.com/users/progwriter","html_url":"https://github.com/progwriter","followers_url":"https://api.github.com/users/progwriter/followers","following_url":"https://api.github.com/users/progwriter/following{/other_user}","gists_url":"https://api.github.com/users/progwriter/gists{/gist_id}","starred_url":"https://api.github.com/users/progwriter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/progwriter/subscriptions","organizations_url":"https://api.github.com/users/progwriter/orgs","repos_url":"https://api.github.com/users/progwriter/repos","events_url":"https://api.github.com/users/progwriter/events{/privacy}","received_events_url":"https://api.github.com/users/progwriter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-05-05T01:30:41Z","updated_at":"2018-05-08T22:56:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/batfish/batfish/pulls/1314","html_url":"https://github.com/batfish/batfish/pull/1314","diff_url":"https://github.com/batfish/batfish/pull/1314.diff","patch_url":"https://github.com/batfish/batfish/pull/1314.patch"},"body":"- No functionality changes\r\n- Pull out the RIBs into a separate package\r\n- Cleanup the `Node` class\r\n   - Create getters for configuration/hostname/virtual routers\r\n   - Make _virtualRouters immutable"},"comment":{"url":"https://api.github.com/repos/batfish/batfish/issues/comments/387568177","html_url":"https://github.com/batfish/batfish/pull/1314#issuecomment-387568177","issue_url":"https://api.github.com/repos/batfish/batfish/issues/1314","id":387568177,"user":{"login":"dhalperi","id":526415,"avatar_url":"https://avatars0.githubusercontent.com/u/526415?v=4","gravatar_id":"","url":"https://api.github.com/users/dhalperi","html_url":"https://github.com/dhalperi","followers_url":"https://api.github.com/users/dhalperi/followers","following_url":"https://api.github.com/users/dhalperi/following{/other_user}","gists_url":"https://api.github.com/users/dhalperi/gists{/gist_id}","starred_url":"https://api.github.com/users/dhalperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhalperi/subscriptions","organizations_url":"https://api.github.com/users/dhalperi/orgs","repos_url":"https://api.github.com/users/dhalperi/repos","events_url":"https://api.github.com/users/dhalperi/events{/privacy}","received_events_url":"https://api.github.com/users/dhalperi/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T22:56:02Z","updated_at":"2018-05-08T22:56:02Z","author_association":"OWNER","body":"\n\n\n\nReviewed 2 of 4 files at r4.\nReview status: all files reviewed at latest revision, all discussions resolved.\n\n---\n\n*[projects/batfish/src/main/java/org/batfish/dataplane/rib/RibTreeNode.java, line 296 at r4](https://reviewable.io/reviews/batfish/batfish/1314#-LC0lKFh-v0Yr1ejksIA:-LC0lKFh-v0Yr1ejksIB:bcekopb) ([raw file](https://github.com/batfish/batfish/blob/a234ad1a3b64610d08a33667b37f8874b5917e6c/projects/batfish/src/main/java/org/batfish/dataplane/rib/RibTreeNode.java#L296)):*\n> ```Java\n>        */\n>       R oldRoute = _routes.iterator().next();\n>       int preferenceComparison = _owner.comparePreference(route, oldRoute);\n> ```\n\nnewRoute? since its rhs?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/batfish/batfish/1314)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"dhalperi"}}