{"action":"created","comment":{"url":"https://api.github.com/repos/exonum/exonum/pulls/comments/218696241","pull_request_review_id":156688555,"id":218696241,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODY5NjI0MQ==","diff_hunk":"@@ -87,67 +86,219 @@ pub struct NetworkPart {\n     pub network_tx: mpsc::Sender<NetworkEvent>,\n }\n \n-#[derive(Debug, Default, Clone)]\n-struct ConnectionsPool {\n-    inner: Rc<RefCell<HashMap<SocketAddr, mpsc::Sender<RawMessage>>>>,\n+#[derive(Clone, Debug)]\n+struct ConnectionPool {\n+    peers: Arc<RwLock<HashMap<SocketAddr, mpsc::Sender<RawMessage>>>>,","path":"exonum/src/events/network.rs","position":45,"original_position":45,"commit_id":"c8c44f4976bb562fa1b89dc73c81cfe5c331f72c","original_commit_id":"433c0d52d8528529a8bc167ea151510877a7aa14","user":{"login":"pavel-mukhanov","id":5321730,"node_id":"MDQ6VXNlcjUzMjE3MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5321730?v=4","gravatar_id":"","url":"https://api.github.com/users/pavel-mukhanov","html_url":"https://github.com/pavel-mukhanov","followers_url":"https://api.github.com/users/pavel-mukhanov/followers","following_url":"https://api.github.com/users/pavel-mukhanov/following{/other_user}","gists_url":"https://api.github.com/users/pavel-mukhanov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-mukhanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-mukhanov/subscriptions","organizations_url":"https://api.github.com/users/pavel-mukhanov/orgs","repos_url":"https://api.github.com/users/pavel-mukhanov/repos","events_url":"https://api.github.com/users/pavel-mukhanov/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-mukhanov/received_events","type":"User","site_admin":false},"body":"Thanks for pointing out, we can safely use `Rc<RefCell<_>>`.","created_at":"2018-09-19T07:35:26Z","updated_at":"2018-09-19T07:35:26Z","html_url":"https://github.com/exonum/exonum/pull/945#discussion_r218696241","pull_request_url":"https://api.github.com/repos/exonum/exonum/pulls/945","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum/pulls/comments/218696241"},"html":{"href":"https://github.com/exonum/exonum/pull/945#discussion_r218696241"},"pull_request":{"href":"https://api.github.com/repos/exonum/exonum/pulls/945"}},"in_reply_to_id":218385045},"pull_request":{"url":"https://api.github.com/repos/exonum/exonum/pulls/945","id":215980154,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTgwMTU0","html_url":"https://github.com/exonum/exonum/pull/945","diff_url":"https://github.com/exonum/exonum/pull/945.diff","patch_url":"https://github.com/exonum/exonum/pull/945.patch","issue_url":"https://api.github.com/repos/exonum/exonum/issues/945","number":945,"state":"open","locked":false,"title":"One connection between peers [ECR-2129]","user":{"login":"pavel-mukhanov","id":5321730,"node_id":"MDQ6VXNlcjUzMjE3MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5321730?v=4","gravatar_id":"","url":"https://api.github.com/users/pavel-mukhanov","html_url":"https://github.com/pavel-mukhanov","followers_url":"https://api.github.com/users/pavel-mukhanov/followers","following_url":"https://api.github.com/users/pavel-mukhanov/following{/other_user}","gists_url":"https://api.github.com/users/pavel-mukhanov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-mukhanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-mukhanov/subscriptions","organizations_url":"https://api.github.com/users/pavel-mukhanov/orgs","repos_url":"https://api.github.com/users/pavel-mukhanov/repos","events_url":"https://api.github.com/users/pavel-mukhanov/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-mukhanov/received_events","type":"User","site_admin":false},"body":"Rework network to provide one connection between peers.\r\n\r\n**Note:** as far as we don't have full requirments for the network protocol yet, this PR aims only resolve some bugs caused by single direction channels.","created_at":"2018-09-17T13:23:53Z","updated_at":"2018-09-19T07:35:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20fee4c4db43ce4881164ef7c90ab6a287678b37","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alekseysidorov","id":83360,"node_id":"MDQ6VXNlcjgzMzYw","avatar_url":"https://avatars1.githubusercontent.com/u/83360?v=4","gravatar_id":"","url":"https://api.github.com/users/alekseysidorov","html_url":"https://github.com/alekseysidorov","followers_url":"https://api.github.com/users/alekseysidorov/followers","following_url":"https://api.github.com/users/alekseysidorov/following{/other_user}","gists_url":"https://api.github.com/users/alekseysidorov/gists{/gist_id}","starred_url":"https://api.github.com/users/alekseysidorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alekseysidorov/subscriptions","organizations_url":"https://api.github.com/users/alekseysidorov/orgs","repos_url":"https://api.github.com/users/alekseysidorov/repos","events_url":"https://api.github.com/users/alekseysidorov/events{/privacy}","received_events_url":"https://api.github.com/users/alekseysidorov/received_events","type":"User","site_admin":false},{"login":"DarkEld3r","id":2997902,"node_id":"MDQ6VXNlcjI5OTc5MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/2997902?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkEld3r","html_url":"https://github.com/DarkEld3r","followers_url":"https://api.github.com/users/DarkEld3r/followers","following_url":"https://api.github.com/users/DarkEld3r/following{/other_user}","gists_url":"https://api.github.com/users/DarkEld3r/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkEld3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkEld3r/subscriptions","organizations_url":"https://api.github.com/users/DarkEld3r/orgs","repos_url":"https://api.github.com/users/DarkEld3r/repos","events_url":"https://api.github.com/users/DarkEld3r/events{/privacy}","received_events_url":"https://api.github.com/users/DarkEld3r/received_events","type":"User","site_admin":false},{"login":"andreyluchin","id":9142036,"node_id":"MDQ6VXNlcjkxNDIwMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/9142036?v=4","gravatar_id":"","url":"https://api.github.com/users/andreyluchin","html_url":"https://github.com/andreyluchin","followers_url":"https://api.github.com/users/andreyluchin/followers","following_url":"https://api.github.com/users/andreyluchin/following{/other_user}","gists_url":"https://api.github.com/users/andreyluchin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreyluchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreyluchin/subscriptions","organizations_url":"https://api.github.com/users/andreyluchin/orgs","repos_url":"https://api.github.com/users/andreyluchin/repos","events_url":"https://api.github.com/users/andreyluchin/events{/privacy}","received_events_url":"https://api.github.com/users/andreyluchin/received_events","type":"User","site_admin":false},{"login":"slowli","id":9612896,"node_id":"MDQ6VXNlcjk2MTI4OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/9612896?v=4","gravatar_id":"","url":"https://api.github.com/users/slowli","html_url":"https://github.com/slowli","followers_url":"https://api.github.com/users/slowli/followers","following_url":"https://api.github.com/users/slowli/following{/other_user}","gists_url":"https://api.github.com/users/slowli/gists{/gist_id}","starred_url":"https://api.github.com/users/slowli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slowli/subscriptions","organizations_url":"https://api.github.com/users/slowli/orgs","repos_url":"https://api.github.com/users/slowli/repos","events_url":"https://api.github.com/users/slowli/events{/privacy}","received_events_url":"https://api.github.com/users/slowli/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exonum/exonum/pulls/945/commits","review_comments_url":"https://api.github.com/repos/exonum/exonum/pulls/945/comments","review_comment_url":"https://api.github.com/repos/exonum/exonum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exonum/exonum/issues/945/comments","statuses_url":"https://api.github.com/repos/exonum/exonum/statuses/c8c44f4976bb562fa1b89dc73c81cfe5c331f72c","head":{"label":"pavel-mukhanov:ECR-2129-one-connect","ref":"ECR-2129-one-connect","sha":"c8c44f4976bb562fa1b89dc73c81cfe5c331f72c","user":{"login":"pavel-mukhanov","id":5321730,"node_id":"MDQ6VXNlcjUzMjE3MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5321730?v=4","gravatar_id":"","url":"https://api.github.com/users/pavel-mukhanov","html_url":"https://github.com/pavel-mukhanov","followers_url":"https://api.github.com/users/pavel-mukhanov/followers","following_url":"https://api.github.com/users/pavel-mukhanov/following{/other_user}","gists_url":"https://api.github.com/users/pavel-mukhanov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-mukhanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-mukhanov/subscriptions","organizations_url":"https://api.github.com/users/pavel-mukhanov/orgs","repos_url":"https://api.github.com/users/pavel-mukhanov/repos","events_url":"https://api.github.com/users/pavel-mukhanov/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-mukhanov/received_events","type":"User","site_admin":false},"repo":{"id":125359112,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUzNTkxMTI=","name":"exonum","full_name":"pavel-mukhanov/exonum","private":false,"owner":{"login":"pavel-mukhanov","id":5321730,"node_id":"MDQ6VXNlcjUzMjE3MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/5321730?v=4","gravatar_id":"","url":"https://api.github.com/users/pavel-mukhanov","html_url":"https://github.com/pavel-mukhanov","followers_url":"https://api.github.com/users/pavel-mukhanov/followers","following_url":"https://api.github.com/users/pavel-mukhanov/following{/other_user}","gists_url":"https://api.github.com/users/pavel-mukhanov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavel-mukhanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavel-mukhanov/subscriptions","organizations_url":"https://api.github.com/users/pavel-mukhanov/orgs","repos_url":"https://api.github.com/users/pavel-mukhanov/repos","events_url":"https://api.github.com/users/pavel-mukhanov/events{/privacy}","received_events_url":"https://api.github.com/users/pavel-mukhanov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pavel-mukhanov/exonum","description":"Exonum core repository","fork":true,"url":"https://api.github.com/repos/pavel-mukhanov/exonum","forks_url":"https://api.github.com/repos/pavel-mukhanov/exonum/forks","keys_url":"https://api.github.com/repos/pavel-mukhanov/exonum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pavel-mukhanov/exonum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pavel-mukhanov/exonum/teams","hooks_url":"https://api.github.com/repos/pavel-mukhanov/exonum/hooks","issue_events_url":"https://api.github.com/repos/pavel-mukhanov/exonum/issues/events{/number}","events_url":"https://api.github.com/repos/pavel-mukhanov/exonum/events","assignees_url":"https://api.github.com/repos/pavel-mukhanov/exonum/assignees{/user}","branches_url":"https://api.github.com/repos/pavel-mukhanov/exonum/branches{/branch}","tags_url":"https://api.github.com/repos/pavel-mukhanov/exonum/tags","blobs_url":"https://api.github.com/repos/pavel-mukhanov/exonum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pavel-mukhanov/exonum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pavel-mukhanov/exonum/git/refs{/sha}","trees_url":"https://api.github.com/repos/pavel-mukhanov/exonum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pavel-mukhanov/exonum/statuses/{sha}","languages_url":"https://api.github.com/repos/pavel-mukhanov/exonum/languages","stargazers_url":"https://api.github.com/repos/pavel-mukhanov/exonum/stargazers","contributors_url":"https://api.github.com/repos/pavel-mukhanov/exonum/contributors","subscribers_url":"https://api.github.com/repos/pavel-mukhanov/exonum/subscribers","subscription_url":"https://api.github.com/repos/pavel-mukhanov/exonum/subscription","commits_url":"https://api.github.com/repos/pavel-mukhanov/exonum/commits{/sha}","git_commits_url":"https://api.github.com/repos/pavel-mukhanov/exonum/git/commits{/sha}","comments_url":"https://api.github.com/repos/pavel-mukhanov/exonum/comments{/number}","issue_comment_url":"https://api.github.com/repos/pavel-mukhanov/exonum/issues/comments{/number}","contents_url":"https://api.github.com/repos/pavel-mukhanov/exonum/contents/{+path}","compare_url":"https://api.github.com/repos/pavel-mukhanov/exonum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pavel-mukhanov/exonum/merges","archive_url":"https://api.github.com/repos/pavel-mukhanov/exonum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pavel-mukhanov/exonum/downloads","issues_url":"https://api.github.com/repos/pavel-mukhanov/exonum/issues{/number}","pulls_url":"https://api.github.com/repos/pavel-mukhanov/exonum/pulls{/number}","milestones_url":"https://api.github.com/repos/pavel-mukhanov/exonum/milestones{/number}","notifications_url":"https://api.github.com/repos/pavel-mukhanov/exonum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pavel-mukhanov/exonum/labels{/name}","releases_url":"https://api.github.com/repos/pavel-mukhanov/exonum/releases{/id}","deployments_url":"https://api.github.com/repos/pavel-mukhanov/exonum/deployments","created_at":"2018-03-15T11:45:31Z","updated_at":"2018-03-15T11:45:34Z","pushed_at":"2018-09-18T16:08:25Z","git_url":"git://github.com/pavel-mukhanov/exonum.git","ssh_url":"git@github.com:pavel-mukhanov/exonum.git","clone_url":"https://github.com/pavel-mukhanov/exonum.git","svn_url":"https://github.com/pavel-mukhanov/exonum","homepage":"http://exonum.com","size":26019,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exonum:master","ref":"master","sha":"cd64ce984ad6d6f36bda0252063feee0f3eb0b5b","user":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"repo":{"id":80729805,"node_id":"MDEwOlJlcG9zaXRvcnk4MDcyOTgwNQ==","name":"exonum","full_name":"exonum/exonum","private":false,"owner":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/exonum/exonum","description":"An extensible open-source framework for creating private/permissioned blockchain applications","fork":false,"url":"https://api.github.com/repos/exonum/exonum","forks_url":"https://api.github.com/repos/exonum/exonum/forks","keys_url":"https://api.github.com/repos/exonum/exonum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exonum/exonum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exonum/exonum/teams","hooks_url":"https://api.github.com/repos/exonum/exonum/hooks","issue_events_url":"https://api.github.com/repos/exonum/exonum/issues/events{/number}","events_url":"https://api.github.com/repos/exonum/exonum/events","assignees_url":"https://api.github.com/repos/exonum/exonum/assignees{/user}","branches_url":"https://api.github.com/repos/exonum/exonum/branches{/branch}","tags_url":"https://api.github.com/repos/exonum/exonum/tags","blobs_url":"https://api.github.com/repos/exonum/exonum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exonum/exonum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exonum/exonum/git/refs{/sha}","trees_url":"https://api.github.com/repos/exonum/exonum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exonum/exonum/statuses/{sha}","languages_url":"https://api.github.com/repos/exonum/exonum/languages","stargazers_url":"https://api.github.com/repos/exonum/exonum/stargazers","contributors_url":"https://api.github.com/repos/exonum/exonum/contributors","subscribers_url":"https://api.github.com/repos/exonum/exonum/subscribers","subscription_url":"https://api.github.com/repos/exonum/exonum/subscription","commits_url":"https://api.github.com/repos/exonum/exonum/commits{/sha}","git_commits_url":"https://api.github.com/repos/exonum/exonum/git/commits{/sha}","comments_url":"https://api.github.com/repos/exonum/exonum/comments{/number}","issue_comment_url":"https://api.github.com/repos/exonum/exonum/issues/comments{/number}","contents_url":"https://api.github.com/repos/exonum/exonum/contents/{+path}","compare_url":"https://api.github.com/repos/exonum/exonum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exonum/exonum/merges","archive_url":"https://api.github.com/repos/exonum/exonum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exonum/exonum/downloads","issues_url":"https://api.github.com/repos/exonum/exonum/issues{/number}","pulls_url":"https://api.github.com/repos/exonum/exonum/pulls{/number}","milestones_url":"https://api.github.com/repos/exonum/exonum/milestones{/number}","notifications_url":"https://api.github.com/repos/exonum/exonum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exonum/exonum/labels{/name}","releases_url":"https://api.github.com/repos/exonum/exonum/releases{/id}","deployments_url":"https://api.github.com/repos/exonum/exonum/deployments","created_at":"2017-02-02T13:56:57Z","updated_at":"2018-09-18T08:10:09Z","pushed_at":"2018-09-18T21:43:59Z","git_url":"git://github.com/exonum/exonum.git","ssh_url":"git@github.com:exonum/exonum.git","clone_url":"https://github.com/exonum/exonum.git","svn_url":"https://github.com/exonum/exonum","homepage":"https://exonum.com","size":25486,"stargazers_count":707,"watchers_count":707,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":145,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":145,"open_issues":57,"watchers":707,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum/pulls/945"},"html":{"href":"https://github.com/exonum/exonum/pull/945"},"issue":{"href":"https://api.github.com/repos/exonum/exonum/issues/945"},"comments":{"href":"https://api.github.com/repos/exonum/exonum/issues/945/comments"},"review_comments":{"href":"https://api.github.com/repos/exonum/exonum/pulls/945/comments"},"review_comment":{"href":"https://api.github.com/repos/exonum/exonum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exonum/exonum/pulls/945/commits"},"statuses":{"href":"https://api.github.com/repos/exonum/exonum/statuses/c8c44f4976bb562fa1b89dc73c81cfe5c331f72c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pavel-mukhanov"}}