{"action":"created","issue":{"url":"https://api.github.com/repos/hpatches/hpatches-benchmark/issues/24","repository_url":"https://api.github.com/repos/hpatches/hpatches-benchmark","labels_url":"https://api.github.com/repos/hpatches/hpatches-benchmark/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/hpatches/hpatches-benchmark/issues/24/comments","events_url":"https://api.github.com/repos/hpatches/hpatches-benchmark/issues/24/events","html_url":"https://github.com/hpatches/hpatches-benchmark/pull/24","id":311600312,"number":24,"title":"Fix file paths on Windows, find \"tasks\" and \"data\" relative to .py files","user":{"login":"schuhschuh","id":975451,"avatar_url":"https://avatars0.githubusercontent.com/u/975451?v=4","gravatar_id":"","url":"https://api.github.com/users/schuhschuh","html_url":"https://github.com/schuhschuh","followers_url":"https://api.github.com/users/schuhschuh/followers","following_url":"https://api.github.com/users/schuhschuh/following{/other_user}","gists_url":"https://api.github.com/users/schuhschuh/gists{/gist_id}","starred_url":"https://api.github.com/users/schuhschuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schuhschuh/subscriptions","organizations_url":"https://api.github.com/users/schuhschuh/orgs","repos_url":"https://api.github.com/users/schuhschuh/repos","events_url":"https://api.github.com/users/schuhschuh/events{/privacy}","received_events_url":"https://api.github.com/users/schuhschuh/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-05T13:00:55Z","updated_at":"2018-04-10T16:12:03Z","closed_at":"2018-04-10T16:12:03Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/hpatches/hpatches-benchmark/pulls/24","html_url":"https://github.com/hpatches/hpatches-benchmark/pull/24","diff_url":"https://github.com/hpatches/hpatches-benchmark/pull/24.diff","patch_url":"https://github.com/hpatches/hpatches-benchmark/pull/24.patch"},"body":"Greetings from Scape, @vbalnt! Very neat benchmarking tools.\r\n\r\nHere are some minor fixes of the Python code:\r\n- Use `os.path.join` throughout to ensure valid file paths also on Windows.\r\n- Set paths to \"tasks\" and \"data\" folders based on `__file__` path of `.py` module.\r\n- Add `--results-dir` option also to `hpatches_eval` and use same default for both `hpatches_eval` and `hpatches_results` scripts."},"comment":{"url":"https://api.github.com/repos/hpatches/hpatches-benchmark/issues/comments/380158700","html_url":"https://github.com/hpatches/hpatches-benchmark/pull/24#issuecomment-380158700","issue_url":"https://api.github.com/repos/hpatches/hpatches-benchmark/issues/24","id":380158700,"user":{"login":"vbalnt","id":3127970,"avatar_url":"https://avatars0.githubusercontent.com/u/3127970?v=4","gravatar_id":"","url":"https://api.github.com/users/vbalnt","html_url":"https://github.com/vbalnt","followers_url":"https://api.github.com/users/vbalnt/followers","following_url":"https://api.github.com/users/vbalnt/following{/other_user}","gists_url":"https://api.github.com/users/vbalnt/gists{/gist_id}","starred_url":"https://api.github.com/users/vbalnt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbalnt/subscriptions","organizations_url":"https://api.github.com/users/vbalnt/orgs","repos_url":"https://api.github.com/users/vbalnt/repos","events_url":"https://api.github.com/users/vbalnt/events{/privacy}","received_events_url":"https://api.github.com/users/vbalnt/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T16:12:02Z","updated_at":"2018-04-10T16:12:02Z","author_association":"CONTRIBUTOR","body":"Hi @schuhschuh \r\n\r\nthanks for the contributions, they are much needed now due to limited time.\r\nAny more you might have are welcome :+1: \r\n"}}
{"actor":{"display_login":"vbalnt"}}