{"action":"closed","number":8898,"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/8898","id":169712998,"html_url":"https://github.com/PX4/Firmware/pull/8898","diff_url":"https://github.com/PX4/Firmware/pull/8898.diff","patch_url":"https://github.com/PX4/Firmware/pull/8898.patch","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/8898","number":8898,"state":"closed","locked":false,"title":"fw_att_control: fix airspeed subscription and validity check","user":{"login":"tstastny","id":8026163,"avatar_url":"https://avatars2.githubusercontent.com/u/8026163?v=4","gravatar_id":"","url":"https://api.github.com/users/tstastny","html_url":"https://github.com/tstastny","followers_url":"https://api.github.com/users/tstastny/followers","following_url":"https://api.github.com/users/tstastny/following{/other_user}","gists_url":"https://api.github.com/users/tstastny/gists{/gist_id}","starred_url":"https://api.github.com/users/tstastny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstastny/subscriptions","organizations_url":"https://api.github.com/users/tstastny/orgs","repos_url":"https://api.github.com/users/tstastny/repos","events_url":"https://api.github.com/users/tstastny/events{/privacy}","received_events_url":"https://api.github.com/users/tstastny/received_events","type":"User","site_admin":false},"body":"- fixed airspeed subscription that was not polling new updates properly resulting in the timestamp constantly =0 (as well as all other members of the airspeed struct)\r\n- replaced unsigned integer subtraction with doubles on airspeed last update check\r\n\r\nWithout these fixes, the airspeed scaling would not be active (assumes the trim value when the airspeed update was \"invalid\"). Also, this keeps the subscriptions all defined in a consistent manner.","created_at":"2018-02-16T20:01:05Z","updated_at":"2018-02-22T08:27:10Z","closed_at":"2018-02-22T08:27:10Z","merged_at":null,"merge_commit_sha":"31a0a194a9bff0ac328a2cd879d3a3914e58e78a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dagar","id":84712,"avatar_url":"https://avatars3.githubusercontent.com/u/84712?v=4","gravatar_id":"","url":"https://api.github.com/users/dagar","html_url":"https://github.com/dagar","followers_url":"https://api.github.com/users/dagar/followers","following_url":"https://api.github.com/users/dagar/following{/other_user}","gists_url":"https://api.github.com/users/dagar/gists{/gist_id}","starred_url":"https://api.github.com/users/dagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagar/subscriptions","organizations_url":"https://api.github.com/users/dagar/orgs","repos_url":"https://api.github.com/users/dagar/repos","events_url":"https://api.github.com/users/dagar/events{/privacy}","received_events_url":"https://api.github.com/users/dagar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":10884838,"url":"https://api.github.com/repos/PX4/Firmware/labels/bug","name":"bug","color":"fc2929","default":true},{"id":78699916,"url":"https://api.github.com/repos/PX4/Firmware/labels/fixedwing","name":"fixedwing","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PX4/Firmware/pulls/8898/commits","review_comments_url":"https://api.github.com/repos/PX4/Firmware/pulls/8898/comments","review_comment_url":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/8898/comments","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/9edf726aab17afd21868633a50baca557256d317","head":{"label":"tstastny:fix_airspeed_sub_in_fw_att_ctrl","ref":"fix_airspeed_sub_in_fw_att_ctrl","sha":"9edf726aab17afd21868633a50baca557256d317","user":{"login":"tstastny","id":8026163,"avatar_url":"https://avatars2.githubusercontent.com/u/8026163?v=4","gravatar_id":"","url":"https://api.github.com/users/tstastny","html_url":"https://github.com/tstastny","followers_url":"https://api.github.com/users/tstastny/followers","following_url":"https://api.github.com/users/tstastny/following{/other_user}","gists_url":"https://api.github.com/users/tstastny/gists{/gist_id}","starred_url":"https://api.github.com/users/tstastny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstastny/subscriptions","organizations_url":"https://api.github.com/users/tstastny/orgs","repos_url":"https://api.github.com/users/tstastny/repos","events_url":"https://api.github.com/users/tstastny/events{/privacy}","received_events_url":"https://api.github.com/users/tstastny/received_events","type":"User","site_admin":false},"repo":{"id":119966844,"name":"Firmware","full_name":"tstastny/Firmware","owner":{"login":"tstastny","id":8026163,"avatar_url":"https://avatars2.githubusercontent.com/u/8026163?v=4","gravatar_id":"","url":"https://api.github.com/users/tstastny","html_url":"https://github.com/tstastny","followers_url":"https://api.github.com/users/tstastny/followers","following_url":"https://api.github.com/users/tstastny/following{/other_user}","gists_url":"https://api.github.com/users/tstastny/gists{/gist_id}","starred_url":"https://api.github.com/users/tstastny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstastny/subscriptions","organizations_url":"https://api.github.com/users/tstastny/orgs","repos_url":"https://api.github.com/users/tstastny/repos","events_url":"https://api.github.com/users/tstastny/events{/privacy}","received_events_url":"https://api.github.com/users/tstastny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tstastny/Firmware","description":"PX4 Pro Autopilot Software","fork":true,"url":"https://api.github.com/repos/tstastny/Firmware","forks_url":"https://api.github.com/repos/tstastny/Firmware/forks","keys_url":"https://api.github.com/repos/tstastny/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tstastny/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tstastny/Firmware/teams","hooks_url":"https://api.github.com/repos/tstastny/Firmware/hooks","issue_events_url":"https://api.github.com/repos/tstastny/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/tstastny/Firmware/events","assignees_url":"https://api.github.com/repos/tstastny/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/tstastny/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/tstastny/Firmware/tags","blobs_url":"https://api.github.com/repos/tstastny/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tstastny/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tstastny/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/tstastny/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tstastny/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/tstastny/Firmware/languages","stargazers_url":"https://api.github.com/repos/tstastny/Firmware/stargazers","contributors_url":"https://api.github.com/repos/tstastny/Firmware/contributors","subscribers_url":"https://api.github.com/repos/tstastny/Firmware/subscribers","subscription_url":"https://api.github.com/repos/tstastny/Firmware/subscription","commits_url":"https://api.github.com/repos/tstastny/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/tstastny/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/tstastny/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/tstastny/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/tstastny/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/tstastny/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tstastny/Firmware/merges","archive_url":"https://api.github.com/repos/tstastny/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tstastny/Firmware/downloads","issues_url":"https://api.github.com/repos/tstastny/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/tstastny/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/tstastny/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/tstastny/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tstastny/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/tstastny/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/tstastny/Firmware/deployments","created_at":"2018-02-02T10:17:32Z","updated_at":"2018-02-02T10:17:43Z","pushed_at":"2018-02-20T09:48:19Z","git_url":"git://github.com/tstastny/Firmware.git","ssh_url":"git@github.com:tstastny/Firmware.git","clone_url":"https://github.com/tstastny/Firmware.git","svn_url":"https://github.com/tstastny/Firmware","homepage":"http://px4.io","size":94411,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PX4:master","ref":"master","sha":"f932217fdc706e5ac02769b41444e4e9a7e3e4a4","user":{"login":"PX4","id":2096014,"avatar_url":"https://avatars3.githubusercontent.com/u/2096014?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":5298790,"name":"Firmware","full_name":"PX4/Firmware","owner":{"login":"PX4","id":2096014,"avatar_url":"https://avatars3.githubusercontent.com/u/2096014?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/Firmware","description":"PX4 Pro Autopilot Software","fork":false,"url":"https://api.github.com/repos/PX4/Firmware","forks_url":"https://api.github.com/repos/PX4/Firmware/forks","keys_url":"https://api.github.com/repos/PX4/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/Firmware/teams","hooks_url":"https://api.github.com/repos/PX4/Firmware/hooks","issue_events_url":"https://api.github.com/repos/PX4/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/Firmware/events","assignees_url":"https://api.github.com/repos/PX4/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/Firmware/tags","blobs_url":"https://api.github.com/repos/PX4/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/Firmware/languages","stargazers_url":"https://api.github.com/repos/PX4/Firmware/stargazers","contributors_url":"https://api.github.com/repos/PX4/Firmware/contributors","subscribers_url":"https://api.github.com/repos/PX4/Firmware/subscribers","subscription_url":"https://api.github.com/repos/PX4/Firmware/subscription","commits_url":"https://api.github.com/repos/PX4/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/PX4/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/Firmware/merges","archive_url":"https://api.github.com/repos/PX4/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/Firmware/downloads","issues_url":"https://api.github.com/repos/PX4/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/PX4/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/PX4/Firmware/deployments","created_at":"2012-08-04T21:19:36Z","updated_at":"2018-02-22T05:55:51Z","pushed_at":"2018-02-22T08:13:34Z","git_url":"git://github.com/PX4/Firmware.git","ssh_url":"git@github.com:PX4/Firmware.git","clone_url":"https://github.com/PX4/Firmware.git","svn_url":"https://github.com/PX4/Firmware","homepage":"http://px4.io","size":96777,"stargazers_count":1574,"watchers_count":1574,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4417,"mirror_url":null,"archived":false,"open_issues_count":316,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":4417,"open_issues":316,"watchers":1574,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/8898"},"html":{"href":"https://github.com/PX4/Firmware/pull/8898"},"issue":{"href":"https://api.github.com/repos/PX4/Firmware/issues/8898"},"comments":{"href":"https://api.github.com/repos/PX4/Firmware/issues/8898/comments"},"review_comments":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/8898/comments"},"review_comment":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/8898/commits"},"statuses":{"href":"https://api.github.com/repos/PX4/Firmware/statuses/9edf726aab17afd21868633a50baca557256d317"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":26,"deletions":9,"changed_files":1}}
{"actor":{"display_login":"tstastny"}}