{"action":"closed","number":6534,"pull_request":{"url":"https://api.github.com/repos/NodeBB/NodeBB/pulls/6534","id":191781794,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNzgxNzk0","html_url":"https://github.com/NodeBB/NodeBB/pull/6534","diff_url":"https://github.com/NodeBB/NodeBB/pull/6534.diff","patch_url":"https://github.com/NodeBB/NodeBB/pull/6534.patch","issue_url":"https://api.github.com/repos/NodeBB/NodeBB/issues/6534","number":6534,"state":"closed","locked":false,"title":"Use setImmediate instead of process.nextTick.","user":{"login":"BenLubar","id":4257305,"node_id":"MDQ6VXNlcjQyNTczMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/4257305?v=4","gravatar_id":"","url":"https://api.github.com/users/BenLubar","html_url":"https://github.com/BenLubar","followers_url":"https://api.github.com/users/BenLubar/followers","following_url":"https://api.github.com/users/BenLubar/following{/other_user}","gists_url":"https://api.github.com/users/BenLubar/gists{/gist_id}","starred_url":"https://api.github.com/users/BenLubar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenLubar/subscriptions","organizations_url":"https://api.github.com/users/BenLubar/orgs","repos_url":"https://api.github.com/users/BenLubar/repos","events_url":"https://api.github.com/users/BenLubar/events{/privacy}","received_events_url":"https://api.github.com/users/BenLubar/received_events","type":"User","site_admin":false},"body":"setImmediate runs after IO handlers, but process.nextTick supercedes them. This can cause the nodejs process to be killed by the kernel.","created_at":"2018-05-31T14:58:31Z","updated_at":"2018-06-18T18:48:06Z","closed_at":"2018-06-18T18:48:05Z","merged_at":null,"merge_commit_sha":"330a8e5ae25df0698ea34352a0ee6c7e34ac1187","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NodeBB/NodeBB/pulls/6534/commits","review_comments_url":"https://api.github.com/repos/NodeBB/NodeBB/pulls/6534/comments","review_comment_url":"https://api.github.com/repos/NodeBB/NodeBB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NodeBB/NodeBB/issues/6534/comments","statuses_url":"https://api.github.com/repos/NodeBB/NodeBB/statuses/be1ba65051e23cba84ebee6139e67a17864ac12a","head":{"label":"BenLubar:setimmediate","ref":"setimmediate","sha":"be1ba65051e23cba84ebee6139e67a17864ac12a","user":{"login":"BenLubar","id":4257305,"node_id":"MDQ6VXNlcjQyNTczMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/4257305?v=4","gravatar_id":"","url":"https://api.github.com/users/BenLubar","html_url":"https://github.com/BenLubar","followers_url":"https://api.github.com/users/BenLubar/followers","following_url":"https://api.github.com/users/BenLubar/following{/other_user}","gists_url":"https://api.github.com/users/BenLubar/gists{/gist_id}","starred_url":"https://api.github.com/users/BenLubar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenLubar/subscriptions","organizations_url":"https://api.github.com/users/BenLubar/orgs","repos_url":"https://api.github.com/users/BenLubar/repos","events_url":"https://api.github.com/users/BenLubar/events{/privacy}","received_events_url":"https://api.github.com/users/BenLubar/received_events","type":"User","site_admin":false},"repo":{"id":52583200,"node_id":"MDEwOlJlcG9zaXRvcnk1MjU4MzIwMA==","name":"NodeBB","full_name":"BenLubar/NodeBB","owner":{"login":"BenLubar","id":4257305,"node_id":"MDQ6VXNlcjQyNTczMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/4257305?v=4","gravatar_id":"","url":"https://api.github.com/users/BenLubar","html_url":"https://github.com/BenLubar","followers_url":"https://api.github.com/users/BenLubar/followers","following_url":"https://api.github.com/users/BenLubar/following{/other_user}","gists_url":"https://api.github.com/users/BenLubar/gists{/gist_id}","starred_url":"https://api.github.com/users/BenLubar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenLubar/subscriptions","organizations_url":"https://api.github.com/users/BenLubar/orgs","repos_url":"https://api.github.com/users/BenLubar/repos","events_url":"https://api.github.com/users/BenLubar/events{/privacy}","received_events_url":"https://api.github.com/users/BenLubar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BenLubar/NodeBB","description":"NodeBB mirror repository for Docker Hub","fork":true,"url":"https://api.github.com/repos/BenLubar/NodeBB","forks_url":"https://api.github.com/repos/BenLubar/NodeBB/forks","keys_url":"https://api.github.com/repos/BenLubar/NodeBB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BenLubar/NodeBB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BenLubar/NodeBB/teams","hooks_url":"https://api.github.com/repos/BenLubar/NodeBB/hooks","issue_events_url":"https://api.github.com/repos/BenLubar/NodeBB/issues/events{/number}","events_url":"https://api.github.com/repos/BenLubar/NodeBB/events","assignees_url":"https://api.github.com/repos/BenLubar/NodeBB/assignees{/user}","branches_url":"https://api.github.com/repos/BenLubar/NodeBB/branches{/branch}","tags_url":"https://api.github.com/repos/BenLubar/NodeBB/tags","blobs_url":"https://api.github.com/repos/BenLubar/NodeBB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BenLubar/NodeBB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BenLubar/NodeBB/git/refs{/sha}","trees_url":"https://api.github.com/repos/BenLubar/NodeBB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BenLubar/NodeBB/statuses/{sha}","languages_url":"https://api.github.com/repos/BenLubar/NodeBB/languages","stargazers_url":"https://api.github.com/repos/BenLubar/NodeBB/stargazers","contributors_url":"https://api.github.com/repos/BenLubar/NodeBB/contributors","subscribers_url":"https://api.github.com/repos/BenLubar/NodeBB/subscribers","subscription_url":"https://api.github.com/repos/BenLubar/NodeBB/subscription","commits_url":"https://api.github.com/repos/BenLubar/NodeBB/commits{/sha}","git_commits_url":"https://api.github.com/repos/BenLubar/NodeBB/git/commits{/sha}","comments_url":"https://api.github.com/repos/BenLubar/NodeBB/comments{/number}","issue_comment_url":"https://api.github.com/repos/BenLubar/NodeBB/issues/comments{/number}","contents_url":"https://api.github.com/repos/BenLubar/NodeBB/contents/{+path}","compare_url":"https://api.github.com/repos/BenLubar/NodeBB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BenLubar/NodeBB/merges","archive_url":"https://api.github.com/repos/BenLubar/NodeBB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BenLubar/NodeBB/downloads","issues_url":"https://api.github.com/repos/BenLubar/NodeBB/issues{/number}","pulls_url":"https://api.github.com/repos/BenLubar/NodeBB/pulls{/number}","milestones_url":"https://api.github.com/repos/BenLubar/NodeBB/milestones{/number}","notifications_url":"https://api.github.com/repos/BenLubar/NodeBB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BenLubar/NodeBB/labels{/name}","releases_url":"https://api.github.com/repos/BenLubar/NodeBB/releases{/id}","deployments_url":"https://api.github.com/repos/BenLubar/NodeBB/deployments","created_at":"2016-02-26T06:18:46Z","updated_at":"2018-06-18T18:42:13Z","pushed_at":"2018-06-18T18:42:11Z","git_url":"git://github.com/BenLubar/NodeBB.git","ssh_url":"git@github.com:BenLubar/NodeBB.git","clone_url":"https://github.com/BenLubar/NodeBB.git","svn_url":"https://github.com/BenLubar/NodeBB","homepage":"https://hub.docker.com/r/benlubar/nodebb","size":47378,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"NodeBB:master","ref":"master","sha":"4f4290b15daf26d8568998899468346f76935de1","user":{"login":"NodeBB","id":4449608,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NDk2MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/4449608?v=4","gravatar_id":"","url":"https://api.github.com/users/NodeBB","html_url":"https://github.com/NodeBB","followers_url":"https://api.github.com/users/NodeBB/followers","following_url":"https://api.github.com/users/NodeBB/following{/other_user}","gists_url":"https://api.github.com/users/NodeBB/gists{/gist_id}","starred_url":"https://api.github.com/users/NodeBB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NodeBB/subscriptions","organizations_url":"https://api.github.com/users/NodeBB/orgs","repos_url":"https://api.github.com/users/NodeBB/repos","events_url":"https://api.github.com/users/NodeBB/events{/privacy}","received_events_url":"https://api.github.com/users/NodeBB/received_events","type":"Organization","site_admin":false},"repo":{"id":9603889,"node_id":"MDEwOlJlcG9zaXRvcnk5NjAzODg5","name":"NodeBB","full_name":"NodeBB/NodeBB","owner":{"login":"NodeBB","id":4449608,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NDk2MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/4449608?v=4","gravatar_id":"","url":"https://api.github.com/users/NodeBB","html_url":"https://github.com/NodeBB","followers_url":"https://api.github.com/users/NodeBB/followers","following_url":"https://api.github.com/users/NodeBB/following{/other_user}","gists_url":"https://api.github.com/users/NodeBB/gists{/gist_id}","starred_url":"https://api.github.com/users/NodeBB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NodeBB/subscriptions","organizations_url":"https://api.github.com/users/NodeBB/orgs","repos_url":"https://api.github.com/users/NodeBB/repos","events_url":"https://api.github.com/users/NodeBB/events{/privacy}","received_events_url":"https://api.github.com/users/NodeBB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NodeBB/NodeBB","description":"Node.js based forum software built for the modern web","fork":false,"url":"https://api.github.com/repos/NodeBB/NodeBB","forks_url":"https://api.github.com/repos/NodeBB/NodeBB/forks","keys_url":"https://api.github.com/repos/NodeBB/NodeBB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NodeBB/NodeBB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NodeBB/NodeBB/teams","hooks_url":"https://api.github.com/repos/NodeBB/NodeBB/hooks","issue_events_url":"https://api.github.com/repos/NodeBB/NodeBB/issues/events{/number}","events_url":"https://api.github.com/repos/NodeBB/NodeBB/events","assignees_url":"https://api.github.com/repos/NodeBB/NodeBB/assignees{/user}","branches_url":"https://api.github.com/repos/NodeBB/NodeBB/branches{/branch}","tags_url":"https://api.github.com/repos/NodeBB/NodeBB/tags","blobs_url":"https://api.github.com/repos/NodeBB/NodeBB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NodeBB/NodeBB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NodeBB/NodeBB/git/refs{/sha}","trees_url":"https://api.github.com/repos/NodeBB/NodeBB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NodeBB/NodeBB/statuses/{sha}","languages_url":"https://api.github.com/repos/NodeBB/NodeBB/languages","stargazers_url":"https://api.github.com/repos/NodeBB/NodeBB/stargazers","contributors_url":"https://api.github.com/repos/NodeBB/NodeBB/contributors","subscribers_url":"https://api.github.com/repos/NodeBB/NodeBB/subscribers","subscription_url":"https://api.github.com/repos/NodeBB/NodeBB/subscription","commits_url":"https://api.github.com/repos/NodeBB/NodeBB/commits{/sha}","git_commits_url":"https://api.github.com/repos/NodeBB/NodeBB/git/commits{/sha}","comments_url":"https://api.github.com/repos/NodeBB/NodeBB/comments{/number}","issue_comment_url":"https://api.github.com/repos/NodeBB/NodeBB/issues/comments{/number}","contents_url":"https://api.github.com/repos/NodeBB/NodeBB/contents/{+path}","compare_url":"https://api.github.com/repos/NodeBB/NodeBB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NodeBB/NodeBB/merges","archive_url":"https://api.github.com/repos/NodeBB/NodeBB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NodeBB/NodeBB/downloads","issues_url":"https://api.github.com/repos/NodeBB/NodeBB/issues{/number}","pulls_url":"https://api.github.com/repos/NodeBB/NodeBB/pulls{/number}","milestones_url":"https://api.github.com/repos/NodeBB/NodeBB/milestones{/number}","notifications_url":"https://api.github.com/repos/NodeBB/NodeBB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NodeBB/NodeBB/labels{/name}","releases_url":"https://api.github.com/repos/NodeBB/NodeBB/releases{/id}","deployments_url":"https://api.github.com/repos/NodeBB/NodeBB/deployments","created_at":"2013-04-22T16:49:40Z","updated_at":"2018-06-18T18:47:00Z","pushed_at":"2018-06-18T18:47:20Z","git_url":"git://github.com/NodeBB/NodeBB.git","ssh_url":"git@github.com:NodeBB/NodeBB.git","clone_url":"https://github.com/NodeBB/NodeBB.git","svn_url":"https://github.com/NodeBB/NodeBB","homepage":"https://nodebb.org","size":47014,"stargazers_count":8819,"watchers_count":8819,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1860,"mirror_url":null,"archived":false,"open_issues_count":121,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1860,"open_issues":121,"watchers":8819,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NodeBB/NodeBB/pulls/6534"},"html":{"href":"https://github.com/NodeBB/NodeBB/pull/6534"},"issue":{"href":"https://api.github.com/repos/NodeBB/NodeBB/issues/6534"},"comments":{"href":"https://api.github.com/repos/NodeBB/NodeBB/issues/6534/comments"},"review_comments":{"href":"https://api.github.com/repos/NodeBB/NodeBB/pulls/6534/comments"},"review_comment":{"href":"https://api.github.com/repos/NodeBB/NodeBB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NodeBB/NodeBB/pulls/6534/commits"},"statuses":{"href":"https://api.github.com/repos/NodeBB/NodeBB/statuses/be1ba65051e23cba84ebee6139e67a17864ac12a"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":9,"changed_files":6}}
{"actor":{"display_login":"julianlam"}}