{"action":"created","issue":{"url":"https://api.github.com/repos/vvanholl/elasticsearch-prometheus-exporter/issues/131","repository_url":"https://api.github.com/repos/vvanholl/elasticsearch-prometheus-exporter","labels_url":"https://api.github.com/repos/vvanholl/elasticsearch-prometheus-exporter/issues/131/labels{/name}","comments_url":"https://api.github.com/repos/vvanholl/elasticsearch-prometheus-exporter/issues/131/comments","events_url":"https://api.github.com/repos/vvanholl/elasticsearch-prometheus-exporter/issues/131/events","html_url":"https://github.com/vvanholl/elasticsearch-prometheus-exporter/pull/131","id":376420539,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NjQwOTUz","number":131,"title":"Index level metrics","user":{"login":"lukas-vlcek","id":205174,"node_id":"MDQ6VXNlcjIwNTE3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/205174?v=4","gravatar_id":"","url":"https://api.github.com/users/lukas-vlcek","html_url":"https://github.com/lukas-vlcek","followers_url":"https://api.github.com/users/lukas-vlcek/followers","following_url":"https://api.github.com/users/lukas-vlcek/following{/other_user}","gists_url":"https://api.github.com/users/lukas-vlcek/gists{/gist_id}","starred_url":"https://api.github.com/users/lukas-vlcek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukas-vlcek/subscriptions","organizations_url":"https://api.github.com/users/lukas-vlcek/orgs","repos_url":"https://api.github.com/users/lukas-vlcek/repos","events_url":"https://api.github.com/users/lukas-vlcek/events{/privacy}","received_events_url":"https://api.github.com/users/lukas-vlcek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-01T14:39:40Z","updated_at":"2018-11-01T15:04:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vvanholl/elasticsearch-prometheus-exporter/pulls/131","html_url":"https://github.com/vvanholl/elasticsearch-prometheus-exporter/pull/131","diff_url":"https://github.com/vvanholl/elasticsearch-prometheus-exporter/pull/131.diff","patch_url":"https://github.com/vvanholl/elasticsearch-prometheus-exporter/pull/131.patch"},"body":"Adding esplugin integaration tests.\r\nBring indices level metrics back."},"comment":{"url":"https://api.github.com/repos/vvanholl/elasticsearch-prometheus-exporter/issues/comments/435069770","html_url":"https://github.com/vvanholl/elasticsearch-prometheus-exporter/pull/131#issuecomment-435069770","issue_url":"https://api.github.com/repos/vvanholl/elasticsearch-prometheus-exporter/issues/131","id":435069770,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTA2OTc3MA==","user":{"login":"lukas-vlcek","id":205174,"node_id":"MDQ6VXNlcjIwNTE3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/205174?v=4","gravatar_id":"","url":"https://api.github.com/users/lukas-vlcek","html_url":"https://github.com/lukas-vlcek","followers_url":"https://api.github.com/users/lukas-vlcek/followers","following_url":"https://api.github.com/users/lukas-vlcek/following{/other_user}","gists_url":"https://api.github.com/users/lukas-vlcek/gists{/gist_id}","starred_url":"https://api.github.com/users/lukas-vlcek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukas-vlcek/subscriptions","organizations_url":"https://api.github.com/users/lukas-vlcek/orgs","repos_url":"https://api.github.com/users/lukas-vlcek/repos","events_url":"https://api.github.com/users/lukas-vlcek/events{/privacy}","received_events_url":"https://api.github.com/users/lukas-vlcek/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T15:04:42Z","updated_at":"2018-11-01T15:04:42Z","author_association":"CONTRIBUTOR","body":"@vvanholl PTAL\r\n\r\nI need your review. I do not like creating massive PRs. The next feature I will contribute is #124 and it would be really great if this PR is already merged before I submit next one. We also need back-port these changes into older releases. So there is a lot of work to do...\r\n\r\nLet me sum up what this PR brings:\r\n\r\n1) Adoption of gradle `esplugin`. This simplifies ES plugin build automation, streamlines gradle build script (i.e plugin descriptor and Java security manager configuration) and enables implementation of REST API tests using Elasticsearch tools.\r\n\r\n2) Added couple of basic REST API tests.\r\n\r\n3) (Re-)Introducing index level metrics. I was also able to clean up the original code and drop some of the unnecessary ES plugin boilerplate code. I added complete coverage of all index level metrics into REST API tests. Although this sounds unnecessary I was able to spot and fix at least two minor issues in the metrics (one was typo in metric name, second was registration of metrics that were no longer available and reported).\r\n\r\nIn general I think it will be useful to add REST tests for every exposed metric. In the future I want to make sure that there is also Grafana dashboard available for each release version of this plugin. For this I want to be sure all the used metric names match."}}
{"actor":{"display_login":"lukas-vlcek"}}