{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/installer/pulls/comments/201809259","pull_request_review_id":136384054,"id":201809259,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTgwOTI1OQ==","diff_hunk":"@@ -0,0 +1,44 @@\n+# Init Phase\n+\n+## Goals\n+\n+1. Generates `InstallConfig` by prompting user for required parameters, and populating the rest of configuration with default values.\n+2. Make useful decisions on default values for most options.\n+3. Init phase should never prompt the user for more than 10 options unless there is a very strong reason.\n+\n+## Non Goals\n+\n+1. Supporting all the configuration option through init is not a goal. Init is just a helper for humans.\n+\n+## Overview\n+\n+The output of the `init` command is a config file that describes a default cluster for the given provider, and is valid/immediately usable.\n+\n+The `init` step is not required, this is merely a helper to generate a valid `InstallConfig`. A user could use examples from documentation, roll their own by hand, or re-use existing configs from source control.\n+\n+## Detailed Design\n+\n+### Prompts on CLI vs flags vs Environment variables\n+\n+1. Flags don’t work well here because we want the fast-path to be single command.\n+2. Init is only valuable for humans and environment variables are similarly tedious.\n+\n+Init phase should use prompts on CLI for top-level configurations that are required to generate InstallConfig.\n+\n+### Remember user's answers\n+\n+In case where users runs `installer init` and stops after platform prompt for some reason. Should the init command ask for platform again when it is rerun.\n+\n+The number of prompts from users need to be very few and remembering usrs's answer is unnecessary optimization.","path":"Documentation/design/initphase.md","position":32,"original_position":32,"commit_id":"63f8ace5bc37ff7065aa6bc20d1b0e63cf4f79ec","original_commit_id":"63f8ace5bc37ff7065aa6bc20d1b0e63cf4f79ec","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"body":"s/usrs's/user's/","created_at":"2018-07-11T19:13:35Z","updated_at":"2018-07-11T19:15:00Z","html_url":"https://github.com/openshift/installer/pull/47#discussion_r201809259","pull_request_url":"https://api.github.com/repos/openshift/installer/pulls/47","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments/201809259"},"html":{"href":"https://github.com/openshift/installer/pull/47#discussion_r201809259"},"pull_request":{"href":"https://api.github.com/repos/openshift/installer/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/47","id":200500916,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNTAwOTE2","html_url":"https://github.com/openshift/installer/pull/47","diff_url":"https://github.com/openshift/installer/pull/47.diff","patch_url":"https://github.com/openshift/installer/pull/47.patch","issue_url":"https://api.github.com/repos/openshift/installer/issues/47","number":47,"state":"open","locked":false,"title":"Documentation/design: add init phase design","user":{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false},"body":"Add `init` step design doc\r\n","created_at":"2018-07-10T19:32:44Z","updated_at":"2018-07-11T19:15:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e99d5d51c1c88971b604c277bd5c21f46ef85fe7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"crawford","id":368848,"node_id":"MDQ6VXNlcjM2ODg0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/368848?v=4","gravatar_id":"","url":"https://api.github.com/users/crawford","html_url":"https://github.com/crawford","followers_url":"https://api.github.com/users/crawford/followers","following_url":"https://api.github.com/users/crawford/following{/other_user}","gists_url":"https://api.github.com/users/crawford/gists{/gist_id}","starred_url":"https://api.github.com/users/crawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawford/subscriptions","organizations_url":"https://api.github.com/users/crawford/orgs","repos_url":"https://api.github.com/users/crawford/repos","events_url":"https://api.github.com/users/crawford/events{/privacy}","received_events_url":"https://api.github.com/users/crawford/received_events","type":"User","site_admin":false},{"login":"aaronlevy","id":374924,"node_id":"MDQ6VXNlcjM3NDkyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/374924?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronlevy","html_url":"https://github.com/aaronlevy","followers_url":"https://api.github.com/users/aaronlevy/followers","following_url":"https://api.github.com/users/aaronlevy/following{/other_user}","gists_url":"https://api.github.com/users/aaronlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlevy/subscriptions","organizations_url":"https://api.github.com/users/aaronlevy/orgs","repos_url":"https://api.github.com/users/aaronlevy/repos","events_url":"https://api.github.com/users/aaronlevy/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlevy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":959729794,"node_id":"MDU6TGFiZWw5NTk3Mjk3OTQ=","url":"https://api.github.com/repos/openshift/installer/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/installer/pulls/47/commits","review_comments_url":"https://api.github.com/repos/openshift/installer/pulls/47/comments","review_comment_url":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/installer/issues/47/comments","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/63f8ace5bc37ff7065aa6bc20d1b0e63cf4f79ec","head":{"label":"abhinavdahiya:design_init","ref":"design_init","sha":"63f8ace5bc37ff7065aa6bc20d1b0e63cf4f79ec","user":{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false},"repo":{"id":140032335,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwMzIzMzU=","name":"installer","full_name":"abhinavdahiya/installer","owner":{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abhinavdahiya/installer","description":"Install an OpenShift cluster","fork":true,"url":"https://api.github.com/repos/abhinavdahiya/installer","forks_url":"https://api.github.com/repos/abhinavdahiya/installer/forks","keys_url":"https://api.github.com/repos/abhinavdahiya/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abhinavdahiya/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abhinavdahiya/installer/teams","hooks_url":"https://api.github.com/repos/abhinavdahiya/installer/hooks","issue_events_url":"https://api.github.com/repos/abhinavdahiya/installer/issues/events{/number}","events_url":"https://api.github.com/repos/abhinavdahiya/installer/events","assignees_url":"https://api.github.com/repos/abhinavdahiya/installer/assignees{/user}","branches_url":"https://api.github.com/repos/abhinavdahiya/installer/branches{/branch}","tags_url":"https://api.github.com/repos/abhinavdahiya/installer/tags","blobs_url":"https://api.github.com/repos/abhinavdahiya/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abhinavdahiya/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abhinavdahiya/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/abhinavdahiya/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abhinavdahiya/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/abhinavdahiya/installer/languages","stargazers_url":"https://api.github.com/repos/abhinavdahiya/installer/stargazers","contributors_url":"https://api.github.com/repos/abhinavdahiya/installer/contributors","subscribers_url":"https://api.github.com/repos/abhinavdahiya/installer/subscribers","subscription_url":"https://api.github.com/repos/abhinavdahiya/installer/subscription","commits_url":"https://api.github.com/repos/abhinavdahiya/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/abhinavdahiya/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/abhinavdahiya/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/abhinavdahiya/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/abhinavdahiya/installer/contents/{+path}","compare_url":"https://api.github.com/repos/abhinavdahiya/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abhinavdahiya/installer/merges","archive_url":"https://api.github.com/repos/abhinavdahiya/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abhinavdahiya/installer/downloads","issues_url":"https://api.github.com/repos/abhinavdahiya/installer/issues{/number}","pulls_url":"https://api.github.com/repos/abhinavdahiya/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/abhinavdahiya/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/abhinavdahiya/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abhinavdahiya/installer/labels{/name}","releases_url":"https://api.github.com/repos/abhinavdahiya/installer/releases{/id}","deployments_url":"https://api.github.com/repos/abhinavdahiya/installer/deployments","created_at":"2018-07-06T21:44:39Z","updated_at":"2018-07-09T20:08:11Z","pushed_at":"2018-07-11T19:12:49Z","git_url":"git://github.com/abhinavdahiya/installer.git","ssh_url":"git@github.com:abhinavdahiya/installer.git","clone_url":"https://github.com/abhinavdahiya/installer.git","svn_url":"https://github.com/abhinavdahiya/installer","homepage":"","size":35780,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"ae41b0a3fa6f3c074bb1e0fd726a9aec406c4301","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":136633680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MzM2ODA=","name":"installer","full_name":"openshift/installer","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/installer","description":"Install an OpenShift cluster","fork":false,"url":"https://api.github.com/repos/openshift/installer","forks_url":"https://api.github.com/repos/openshift/installer/forks","keys_url":"https://api.github.com/repos/openshift/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/installer/teams","hooks_url":"https://api.github.com/repos/openshift/installer/hooks","issue_events_url":"https://api.github.com/repos/openshift/installer/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/installer/events","assignees_url":"https://api.github.com/repos/openshift/installer/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/installer/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/installer/tags","blobs_url":"https://api.github.com/repos/openshift/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/installer/languages","stargazers_url":"https://api.github.com/repos/openshift/installer/stargazers","contributors_url":"https://api.github.com/repos/openshift/installer/contributors","subscribers_url":"https://api.github.com/repos/openshift/installer/subscribers","subscription_url":"https://api.github.com/repos/openshift/installer/subscription","commits_url":"https://api.github.com/repos/openshift/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/installer/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/installer/merges","archive_url":"https://api.github.com/repos/openshift/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/installer/downloads","issues_url":"https://api.github.com/repos/openshift/installer/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/installer/labels{/name}","releases_url":"https://api.github.com/repos/openshift/installer/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/installer/deployments","created_at":"2018-06-08T15:04:41Z","updated_at":"2018-07-09T23:52:08Z","pushed_at":"2018-07-11T19:12:51Z","git_url":"git://github.com/openshift/installer.git","ssh_url":"git@github.com:openshift/installer.git","clone_url":"https://github.com/openshift/installer.git","svn_url":"https://github.com/openshift/installer","homepage":"","size":35762,"stargazers_count":8,"watchers_count":8,"language":"HCL","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":19,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/47"},"html":{"href":"https://github.com/openshift/installer/pull/47"},"issue":{"href":"https://api.github.com/repos/openshift/installer/issues/47"},"comments":{"href":"https://api.github.com/repos/openshift/installer/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/installer/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/installer/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/installer/statuses/63f8ace5bc37ff7065aa6bc20d1b0e63cf4f79ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wking"}}