{"action":"created","comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments/174097725","pull_request_review_id":103391395,"id":174097725,"diff_hunk":"@@ -0,0 +1,54 @@\n+<textarea id=\"editor\" cols=\"30\" rows=\"10\">\n+<p>Lorem <strong>ipsum</strong> dolor sit amet, <em>consectetur</em> adipiscing elit, <u>sed</u> do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo <u><strong>consequat</strong></u>. Duis aute irure dolor in <strong>reprehenderit</strong> in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum. Lorem ipsum dolor sit <sub>amet</sub>, consectetur adipiscing elit, sed do eiusmod tempor <sub><s>incididunt</s></sub> ut labore et dolore <strong>magna</strong> aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>\n+</textarea>\n+<script>\n+\tCKEDITOR.plugins.add( 'teststylesplit', {\n+\t\tinit: function( editor ) {\n+\n+\t\t\tvar lang = editor.lang.basicstyles;\n+\t\t\teditor.ui.add( 'teststylesplit', CKEDITOR.UI_SPLITBUTTON, {\n+\t\t\t\tlabel: 'Basic Styles',\n+\t\t\t\titems: [ {\n+\t\t\t\t\tlabel: lang.bold,\n+\t\t\t\t\tcommand: 'bold',\n+\t\t\t\t\ticon: 'bold',\n+\t\t\t\t\t'default': true\n+\t\t\t\t}, {\n+\t\t\t\t\tlabel: lang.italic,\n+\t\t\t\t\tcommand: 'italic',\n+\t\t\t\t\ticon: 'italic'\n+\t\t\t\t}, {\n+\t\t\t\t\tlabel: lang.underline,\n+\t\t\t\t\tcommand: 'underline',\n+\t\t\t\t\ticon: 'underline'\n+\t\t\t\t}, {\n+\t\t\t\t\tlabel: lang.strike,\n+\t\t\t\t\tcommand: 'strike',\n+\t\t\t\t\ticon: 'strike'\n+\t\t\t\t}, {\n+\t\t\t\t\tlabel: lang.subscript,\n+\t\t\t\t\tcommand: 'subscript',\n+\t\t\t\t\ticon: 'subscript'\n+\t\t\t\t}, {\n+\t\t\t\t\tlabel: lang.superscript,\n+\t\t\t\t\tcommand: 'superscript',\n+\t\t\t\t\ticon: 'superscript'\n+\t\t\t\t} ]\n+\t\t\t} );\n+\t\t}\n+\t} );\n+\n+\tCKEDITOR.replace( 'editor', {\n+\t\textraPlugins: 'teststylesplit'\n+\t} );\n+\n+\t// Just hiding buttons that are irrelevant to test.\n+\tCKEDITOR.instances.editor.on( 'contentDom', function() {","path":"tests/plugins/splitbutton/manual/splitbutton.html","position":46,"original_position":46,"commit_id":"66b9364ab1f70333d367e04f36a1c31288b32f3d","original_commit_id":"66b9364ab1f70333d367e04f36a1c31288b32f3d","user":{"login":"engineering-this","id":23366849,"avatar_url":"https://avatars0.githubusercontent.com/u/23366849?v=4","gravatar_id":"","url":"https://api.github.com/users/engineering-this","html_url":"https://github.com/engineering-this","followers_url":"https://api.github.com/users/engineering-this/followers","following_url":"https://api.github.com/users/engineering-this/following{/other_user}","gists_url":"https://api.github.com/users/engineering-this/gists{/gist_id}","starred_url":"https://api.github.com/users/engineering-this/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engineering-this/subscriptions","organizations_url":"https://api.github.com/users/engineering-this/orgs","repos_url":"https://api.github.com/users/engineering-this/repos","events_url":"https://api.github.com/users/engineering-this/events{/privacy}","received_events_url":"https://api.github.com/users/engineering-this/received_events","type":"User","site_admin":false},"body":"Hej, @mlewand what is your view on this?","created_at":"2018-03-13T11:36:57Z","updated_at":"2018-03-13T11:36:58Z","html_url":"https://github.com/ckeditor/ckeditor-dev/pull/1766#discussion_r174097725","pull_request_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/1766","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments/174097725"},"html":{"href":"https://github.com/ckeditor/ckeditor-dev/pull/1766#discussion_r174097725"},"pull_request":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/1766"}},"in_reply_to_id":173467982},"pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/1766","id":173786456,"html_url":"https://github.com/ckeditor/ckeditor-dev/pull/1766","diff_url":"https://github.com/ckeditor/ckeditor-dev/pull/1766.diff","patch_url":"https://github.com/ckeditor/ckeditor-dev/pull/1766.patch","issue_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/1766","number":1766,"state":"open","locked":false,"title":"New plugin: splitbutton","user":{"login":"engineering-this","id":23366849,"avatar_url":"https://avatars0.githubusercontent.com/u/23366849?v=4","gravatar_id":"","url":"https://api.github.com/users/engineering-this","html_url":"https://github.com/engineering-this","followers_url":"https://api.github.com/users/engineering-this/followers","following_url":"https://api.github.com/users/engineering-this/following{/other_user}","gists_url":"https://api.github.com/users/engineering-this/gists{/gist_id}","starred_url":"https://api.github.com/users/engineering-this/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engineering-this/subscriptions","organizations_url":"https://api.github.com/users/engineering-this/orgs","repos_url":"https://api.github.com/users/engineering-this/repos","events_url":"https://api.github.com/users/engineering-this/events{/privacy}","received_events_url":"https://api.github.com/users/engineering-this/received_events","type":"User","site_admin":false},"body":"## What is the purpose of this pull request?\r\n\r\nNew feature\r\n\r\n## Does your PR contain necessary tests?\r\n\r\nAll patches which change the editor code must include tests. You can always read more\r\non [PR testing](https://docs.ckeditor.com/ckeditor4/docs/#!/guide/dev_contributing_code-section-tests),\r\n[how to set the testing environment](https://docs.ckeditor.com/ckeditor4/docs/#!/guide/dev_tests) and\r\n[how to create tests](https://docs.ckeditor.com/ckeditor4/docs/#!/guide/dev_tests-section-creating-your-own-test)\r\nin the official CKEditor documentation.\r\n\r\n### This PR contains\r\n\r\n- [x] Unit tests\r\n- [x] Manual tests\r\n\r\n## What changes did you make?\r\n\r\nI've added the `splitbutton` plugin which is extending the `menubutton` class. Also I've slightly updated the `button`\r\n\r\n\r\nCloses #1679.","created_at":"2018-03-08T16:38:53Z","updated_at":"2018-03-13T11:36:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29179ab2c4a90dc6c95a680d64316dd951588886","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/1766/commits","review_comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/1766/comments","review_comment_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/1766/comments","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/66b9364ab1f70333d367e04f36a1c31288b32f3d","head":{"label":"ckeditor:t/1679","ref":"t/1679","sha":"66b9364ab1f70333d367e04f36a1c31288b32f3d","user":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":5482172,"name":"ckeditor-dev","full_name":"ckeditor/ckeditor-dev","owner":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor-dev","description":"The development repository of CKEditor 4.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor-dev","forks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/deployments","created_at":"2012-08-20T14:21:13Z","updated_at":"2018-03-13T09:00:27Z","pushed_at":"2018-03-13T11:13:16Z","git_url":"git://github.com/ckeditor/ckeditor-dev.git","ssh_url":"git@github.com:ckeditor/ckeditor-dev.git","clone_url":"https://github.com/ckeditor/ckeditor-dev.git","svn_url":"https://github.com/ckeditor/ckeditor-dev","homepage":"https://ckeditor.com/ckeditor-4","size":59419,"stargazers_count":3877,"watchers_count":3877,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1743,"mirror_url":null,"archived":false,"open_issues_count":564,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1743,"open_issues":564,"watchers":3877,"default_branch":"major"}},"base":{"label":"ckeditor:major","ref":"major","sha":"a649b6c3672da62c71df5ba3615baa1c2aabb297","user":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":5482172,"name":"ckeditor-dev","full_name":"ckeditor/ckeditor-dev","owner":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor-dev","description":"The development repository of CKEditor 4.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor-dev","forks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor-dev/deployments","created_at":"2012-08-20T14:21:13Z","updated_at":"2018-03-13T09:00:27Z","pushed_at":"2018-03-13T11:13:16Z","git_url":"git://github.com/ckeditor/ckeditor-dev.git","ssh_url":"git@github.com:ckeditor/ckeditor-dev.git","clone_url":"https://github.com/ckeditor/ckeditor-dev.git","svn_url":"https://github.com/ckeditor/ckeditor-dev","homepage":"https://ckeditor.com/ckeditor-4","size":59419,"stargazers_count":3877,"watchers_count":3877,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1743,"mirror_url":null,"archived":false,"open_issues_count":564,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1743,"open_issues":564,"watchers":3877,"default_branch":"major"}},"_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/1766"},"html":{"href":"https://github.com/ckeditor/ckeditor-dev/pull/1766"},"issue":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/1766"},"comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/issues/1766/comments"},"review_comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/1766/comments"},"review_comment":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/pulls/1766/commits"},"statuses":{"href":"https://api.github.com/repos/ckeditor/ckeditor-dev/statuses/66b9364ab1f70333d367e04f36a1c31288b32f3d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"engineering-this"}}