{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/220807722","pull_request_review_id":159300430,"id":220807722,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDgwNzcyMg==","diff_hunk":"@@ -421,7 +421,10 @@ def _legacy_fit_transform(self, X):\n         dtype = getattr(X, 'dtype', None)\n         X = check_array(X, dtype=np.int)\n         if np.any(X < 0):\n-            raise ValueError(\"X needs to contain only non-negative integers.\")\n+            raise ValueError(\"X needs to contain only non-negative integers,\"","path":"sklearn/preprocessing/_encoders.py","position":null,"original_position":5,"commit_id":"224ec676b4ca5c5065599c7cf2df661644d60c73","original_commit_id":"11d3a85a13ce0236087ac0e68de07c3b190489ab","user":{"login":"ramanujam","id":31292443,"node_id":"MDQ6VXNlcjMxMjkyNDQz","avatar_url":"https://avatars2.githubusercontent.com/u/31292443?v=4","gravatar_id":"","url":"https://api.github.com/users/ramanujam","html_url":"https://github.com/ramanujam","followers_url":"https://api.github.com/users/ramanujam/followers","following_url":"https://api.github.com/users/ramanujam/following{/other_user}","gists_url":"https://api.github.com/users/ramanujam/gists{/gist_id}","starred_url":"https://api.github.com/users/ramanujam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramanujam/subscriptions","organizations_url":"https://api.github.com/users/ramanujam/orgs","repos_url":"https://api.github.com/users/ramanujam/repos","events_url":"https://api.github.com/users/ramanujam/events{/privacy}","received_events_url":"https://api.github.com/users/ramanujam/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2018-09-27T06:36:33Z","updated_at":"2018-09-27T06:36:33Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/12180#discussion_r220807722","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12180","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/220807722"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/12180#discussion_r220807722"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12180"}},"in_reply_to_id":220805125},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12180","id":218528832,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NTI4ODMy","html_url":"https://github.com/scikit-learn/scikit-learn/pull/12180","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/12180.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/12180.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12180","number":12180,"state":"open","locked":false,"title":"Issue#12179","user":{"login":"ramanujam","id":31292443,"node_id":"MDQ6VXNlcjMxMjkyNDQz","avatar_url":"https://avatars2.githubusercontent.com/u/31292443?v=4","gravatar_id":"","url":"https://api.github.com/users/ramanujam","html_url":"https://github.com/ramanujam","followers_url":"https://api.github.com/users/ramanujam/followers","following_url":"https://api.github.com/users/ramanujam/following{/other_user}","gists_url":"https://api.github.com/users/ramanujam/gists{/gist_id}","starred_url":"https://api.github.com/users/ramanujam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramanujam/subscriptions","organizations_url":"https://api.github.com/users/ramanujam/orgs","repos_url":"https://api.github.com/users/ramanujam/repos","events_url":"https://api.github.com/users/ramanujam/events{/privacy}","received_events_url":"https://api.github.com/users/ramanujam/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist\r\n-->\r\n\r\n#### Reference Issues/PRs\r\nFixes #12179 - Update the error message when negative inputs are provided to OneHotEncoder to show how to negative inputs can be supported by instantiating OneHotEncoder with categories='auto'\r\n<!--\r\nExample: Fixes #1234. See also #3456.\r\nPlease use keywords (e.g., Fixes) to create link to the issues or pull requests\r\nyou resolved, so that they will automatically be closed when your pull request\r\nis merged. See https://github.com/blog/1506-closing-issues-via-pull-requests\r\n-->\r\n\r\n\r\n#### What does this implement/fix? Explain your changes.\r\nOneHotEncoder didn't support negative integer inputs. This behavior is \r\ndeprecated. The legacy behaviour currently raises ValueError(\"X needs \r\nto contain only non-negative integers.\"). This error message is now \r\nextended to show how to activate the new behavior by instantiating the \r\nOneHotEncoder with categories='auto'.\r\n\r\n#### Any other comments?\r\n\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n","created_at":"2018-09-27T05:33:51Z","updated_at":"2018-09-27T06:36:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5edd13f130df13e9028ba78481c0c6fb32465f57","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12180/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12180/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12180/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/224ec676b4ca5c5065599c7cf2df661644d60c73","head":{"label":"ramanujam:Issue#12179","ref":"Issue#12179","sha":"224ec676b4ca5c5065599c7cf2df661644d60c73","user":{"login":"ramanujam","id":31292443,"node_id":"MDQ6VXNlcjMxMjkyNDQz","avatar_url":"https://avatars2.githubusercontent.com/u/31292443?v=4","gravatar_id":"","url":"https://api.github.com/users/ramanujam","html_url":"https://github.com/ramanujam","followers_url":"https://api.github.com/users/ramanujam/followers","following_url":"https://api.github.com/users/ramanujam/following{/other_user}","gists_url":"https://api.github.com/users/ramanujam/gists{/gist_id}","starred_url":"https://api.github.com/users/ramanujam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramanujam/subscriptions","organizations_url":"https://api.github.com/users/ramanujam/orgs","repos_url":"https://api.github.com/users/ramanujam/repos","events_url":"https://api.github.com/users/ramanujam/events{/privacy}","received_events_url":"https://api.github.com/users/ramanujam/received_events","type":"User","site_admin":false},"repo":{"id":150504178,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA1MDQxNzg=","name":"scikit-learn","full_name":"ramanujam/scikit-learn","private":false,"owner":{"login":"ramanujam","id":31292443,"node_id":"MDQ6VXNlcjMxMjkyNDQz","avatar_url":"https://avatars2.githubusercontent.com/u/31292443?v=4","gravatar_id":"","url":"https://api.github.com/users/ramanujam","html_url":"https://github.com/ramanujam","followers_url":"https://api.github.com/users/ramanujam/followers","following_url":"https://api.github.com/users/ramanujam/following{/other_user}","gists_url":"https://api.github.com/users/ramanujam/gists{/gist_id}","starred_url":"https://api.github.com/users/ramanujam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramanujam/subscriptions","organizations_url":"https://api.github.com/users/ramanujam/orgs","repos_url":"https://api.github.com/users/ramanujam/repos","events_url":"https://api.github.com/users/ramanujam/events{/privacy}","received_events_url":"https://api.github.com/users/ramanujam/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ramanujam/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/ramanujam/scikit-learn","forks_url":"https://api.github.com/repos/ramanujam/scikit-learn/forks","keys_url":"https://api.github.com/repos/ramanujam/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramanujam/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramanujam/scikit-learn/teams","hooks_url":"https://api.github.com/repos/ramanujam/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/ramanujam/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/ramanujam/scikit-learn/events","assignees_url":"https://api.github.com/repos/ramanujam/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/ramanujam/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/ramanujam/scikit-learn/tags","blobs_url":"https://api.github.com/repos/ramanujam/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramanujam/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramanujam/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramanujam/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramanujam/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/ramanujam/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/ramanujam/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/ramanujam/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/ramanujam/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/ramanujam/scikit-learn/subscription","commits_url":"https://api.github.com/repos/ramanujam/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramanujam/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramanujam/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramanujam/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramanujam/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/ramanujam/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramanujam/scikit-learn/merges","archive_url":"https://api.github.com/repos/ramanujam/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramanujam/scikit-learn/downloads","issues_url":"https://api.github.com/repos/ramanujam/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/ramanujam/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/ramanujam/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/ramanujam/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramanujam/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/ramanujam/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/ramanujam/scikit-learn/deployments","created_at":"2018-09-27T00:04:32Z","updated_at":"2018-09-27T00:04:40Z","pushed_at":"2018-09-27T06:35:21Z","git_url":"git://github.com/ramanujam/scikit-learn.git","ssh_url":"git@github.com:ramanujam/scikit-learn.git","clone_url":"https://github.com/ramanujam/scikit-learn.git","svn_url":"https://github.com/ramanujam/scikit-learn","homepage":"http://scikit-learn.org","size":94230,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"dbfd872be4d68a6d824bd81ace09420383bf2d7b","user":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"node_id":"MDEwOlJlcG9zaXRvcnk4NDMyMjI=","name":"scikit-learn","full_name":"scikit-learn/scikit-learn","private":false,"owner":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2018-09-27T05:29:47Z","pushed_at":"2018-09-27T06:35:28Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":94877,"stargazers_count":30740,"watchers_count":30740,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15160,"mirror_url":null,"archived":false,"open_issues_count":1724,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15160,"open_issues":1724,"watchers":30740,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12180"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/12180"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12180"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12180/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12180/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12180/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/224ec676b4ca5c5065599c7cf2df661644d60c73"}},"author_association":"NONE"}}
{"actor":{"display_login":"ramanujam"}}