{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/13515","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/13515/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/13515/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/13515/events","html_url":"https://github.com/highfidelity/hifi/pull/13515","id":337438274,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NjIwODQ5","number":13515,"title":"Shadow on Mac bug fix","user":{"login":"Zvork","id":14199381,"node_id":"MDQ6VXNlcjE0MTk5Mzgx","avatar_url":"https://avatars3.githubusercontent.com/u/14199381?v=4","gravatar_id":"","url":"https://api.github.com/users/Zvork","html_url":"https://github.com/Zvork","followers_url":"https://api.github.com/users/Zvork/followers","following_url":"https://api.github.com/users/Zvork/following{/other_user}","gists_url":"https://api.github.com/users/Zvork/gists{/gist_id}","starred_url":"https://api.github.com/users/Zvork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zvork/subscriptions","organizations_url":"https://api.github.com/users/Zvork/orgs","repos_url":"https://api.github.com/users/Zvork/repos","events_url":"https://api.github.com/users/Zvork/events{/privacy}","received_events_url":"https://api.github.com/users/Zvork/received_events","type":"User","site_admin":false},"labels":[{"id":314155368,"node_id":"MDU6TGFiZWwzMTQxNTUzNjg=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Development%20Approved","name":"Development Approved","color":"009800","default":false},{"id":675876856,"node_id":"MDU6TGFiZWw2NzU4NzY4NTY=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Engine","name":"Engine","color":"A2277C","default":false},{"id":799714245,"node_id":"MDU6TGFiZWw3OTk3MTQyNDU=","url":"https://api.github.com/repos/highfidelity/hifi/labels/outsource","name":"outsource","color":"7aced6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/30","html_url":"https://github.com/highfidelity/hifi/milestone/30","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/30/labels","id":3290828,"node_id":"MDk6TWlsZXN0b25lMzI5MDgyOA==","number":30,"title":"RC70","description":"","creator":{"login":"conklin94122","id":12115653,"node_id":"MDQ6VXNlcjEyMTE1NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":89,"state":"open","created_at":"2018-04-23T19:27:01Z","updated_at":"2018-07-02T16:32:04Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2018-07-02T09:28:49Z","updated_at":"2018-07-02T16:53:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/13515","html_url":"https://github.com/highfidelity/hifi/pull/13515","diff_url":"https://github.com/highfidelity/hifi/pull/13515.diff","patch_url":"https://github.com/highfidelity/hifi/pull/13515.patch"},"body":"Fixes the shadows on Mac with AMD GPU. See [Manuscript bug #13762](https://highfidelity.fogbugz.com/f/cases/13762/Mac-AMD-Shadows-do-not-correctly-render). It could possibly also fix another [shadow bug on Windows on AMD GPU #13081](https://highfidelity.fogbugz.com/f/cases/13081/Shadow-is-showing-grid-of-dots-on-AMD-GPU-systems).\r\n\r\n# Test Plan\r\nThe PR should be tested on Mac (ideally with NVidia and AMD GPU), on Window (to check second bug) with AMD and NVidia as well as on Android.\r\nRun the [tests/engine/render/shadows test](https://github.com/highfidelity/hifi_tests/tree/master/tests/engine/render/shadows)."},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/401867493","html_url":"https://github.com/highfidelity/hifi/pull/13515#issuecomment-401867493","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/13515","id":401867493,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTg2NzQ5Mw==","user":{"login":"vegaslon","id":2307946,"node_id":"MDQ6VXNlcjIzMDc5NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/2307946?v=4","gravatar_id":"","url":"https://api.github.com/users/vegaslon","html_url":"https://github.com/vegaslon","followers_url":"https://api.github.com/users/vegaslon/followers","following_url":"https://api.github.com/users/vegaslon/following{/other_user}","gists_url":"https://api.github.com/users/vegaslon/gists{/gist_id}","starred_url":"https://api.github.com/users/vegaslon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vegaslon/subscriptions","organizations_url":"https://api.github.com/users/vegaslon/orgs","repos_url":"https://api.github.com/users/vegaslon/repos","events_url":"https://api.github.com/users/vegaslon/events{/privacy}","received_events_url":"https://api.github.com/users/vegaslon/received_events","type":"User","site_admin":false},"created_at":"2018-07-02T16:53:39Z","updated_at":"2018-07-02T16:53:39Z","author_association":"NONE","body":"Perhaps you have misread what I have stated, in my experience with this PR the so called holes, translucent triangles, seams. When shadows are on, have disappeared with my hardware. "}}
{"actor":{"display_login":"vegaslon"}}