{"action":"created","issue":{"url":"https://api.github.com/repos/textpattern/textpattern/issues/1144","repository_url":"https://api.github.com/repos/textpattern/textpattern","labels_url":"https://api.github.com/repos/textpattern/textpattern/issues/1144/labels{/name}","comments_url":"https://api.github.com/repos/textpattern/textpattern/issues/1144/comments","events_url":"https://api.github.com/repos/textpattern/textpattern/issues/1144/events","html_url":"https://github.com/textpattern/textpattern/issues/1144","id":296309656,"number":1144,"title":"Skin related textpack changes","user":{"login":"NicolasGraph","id":5238487,"avatar_url":"https://avatars2.githubusercontent.com/u/5238487?v=4","gravatar_id":"","url":"https://api.github.com/users/NicolasGraph","html_url":"https://github.com/NicolasGraph","followers_url":"https://api.github.com/users/NicolasGraph/followers","following_url":"https://api.github.com/users/NicolasGraph/following{/other_user}","gists_url":"https://api.github.com/users/NicolasGraph/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolasGraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolasGraph/subscriptions","organizations_url":"https://api.github.com/users/NicolasGraph/orgs","repos_url":"https://api.github.com/users/NicolasGraph/repos","events_url":"https://api.github.com/users/NicolasGraph/events{/privacy}","received_events_url":"https://api.github.com/users/NicolasGraph/received_events","type":"User","site_admin":false},"labels":[{"id":836042505,"url":"https://api.github.com/repos/textpattern/textpattern/labels/Localization","name":"Localization","color":"e99695","default":false}],"state":"closed","locked":false,"assignee":{"login":"philwareham","id":413665,"avatar_url":"https://avatars2.githubusercontent.com/u/413665?v=4","gravatar_id":"","url":"https://api.github.com/users/philwareham","html_url":"https://github.com/philwareham","followers_url":"https://api.github.com/users/philwareham/followers","following_url":"https://api.github.com/users/philwareham/following{/other_user}","gists_url":"https://api.github.com/users/philwareham/gists{/gist_id}","starred_url":"https://api.github.com/users/philwareham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwareham/subscriptions","organizations_url":"https://api.github.com/users/philwareham/orgs","repos_url":"https://api.github.com/users/philwareham/repos","events_url":"https://api.github.com/users/philwareham/events{/privacy}","received_events_url":"https://api.github.com/users/philwareham/received_events","type":"User","site_admin":false},"assignees":[{"login":"philwareham","id":413665,"avatar_url":"https://avatars2.githubusercontent.com/u/413665?v=4","gravatar_id":"","url":"https://api.github.com/users/philwareham","html_url":"https://github.com/philwareham","followers_url":"https://api.github.com/users/philwareham/followers","following_url":"https://api.github.com/users/philwareham/following{/other_user}","gists_url":"https://api.github.com/users/philwareham/gists{/gist_id}","starred_url":"https://api.github.com/users/philwareham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwareham/subscriptions","organizations_url":"https://api.github.com/users/philwareham/orgs","repos_url":"https://api.github.com/users/philwareham/repos","events_url":"https://api.github.com/users/philwareham/events{/privacy}","received_events_url":"https://api.github.com/users/philwareham/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/textpattern/textpattern/milestones/2","html_url":"https://github.com/textpattern/textpattern/milestone/2","labels_url":"https://api.github.com/repos/textpattern/textpattern/milestones/2/labels","id":813574,"number":2,"title":"v4.7","description":"","creator":{"login":"philwareham","id":413665,"avatar_url":"https://avatars2.githubusercontent.com/u/413665?v=4","gravatar_id":"","url":"https://api.github.com/users/philwareham","html_url":"https://github.com/philwareham","followers_url":"https://api.github.com/users/philwareham/followers","following_url":"https://api.github.com/users/philwareham/following{/other_user}","gists_url":"https://api.github.com/users/philwareham/gists{/gist_id}","starred_url":"https://api.github.com/users/philwareham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwareham/subscriptions","organizations_url":"https://api.github.com/users/philwareham/orgs","repos_url":"https://api.github.com/users/philwareham/repos","events_url":"https://api.github.com/users/philwareham/events{/privacy}","received_events_url":"https://api.github.com/users/philwareham/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":88,"state":"open","created_at":"2014-10-04T13:55:37Z","updated_at":"2018-02-14T09:10:43Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2018-02-12T09:29:02Z","updated_at":"2018-02-14T09:10:43Z","closed_at":"2018-02-14T09:10:43Z","author_association":"CONTRIBUTOR","body":"From https://github.com/textpattern/textpattern/pull/1143, with some enhancements.\r\nShould currently be applied to the _themes_ branch.\r\n\r\n## Textpack related changes\r\n\r\n### To delete\r\n- [x] `skin_locking_failed`;\r\n- [x] `skin_unlocking_failed`;\r\n- [x] `remove_extra_templates`.\r\n\r\n### To change\r\n\r\n- [x] `tab_skins` to `tab_skin` to work with the [`Table` class](https://github.com/textpattern/textpattern/blob/dev/textpattern/vendors/Textpattern/Admin/Table.php#L72);\r\n\r\n### To add\r\n- [x] `override=\"Override\"` or `\"Re-import\"`[Edit: or \"Update\"]? This would replace the _import_ multi-edit option.\r\n- [x] `skin_synchronize=\"Synchronize template/file lists.\"` or `\"Delete unused templates/files\"`.\r\nThis string replaces `remove_extra_templates`. However, the `remove_extra_templates` value shouldn't be used because it is wrong. The pophelp contents should also be corrected and renamed.\r\n\r\n- [x] I suggest something like so for the pophelp: \r\n\r\n> If checked, this option allows to synchronize template related database rows and files.\r\n>\r\n> In practice, on override/re-import, each template which is not part of the processed import will be deleted from the database, while on export, template files will be deleted if they are not part of the processed export.\r\n>\r\n> If, for any reason, import or export fails for a defined template it would not be considered as part of the current process and will be deleted from the database or the theme directory.\r\n>\r\n> Finally, on deletion _all_ themes related files will be deleted, including files which would not be part of the theme core structure and would not appears in the database."},"comment":{"url":"https://api.github.com/repos/textpattern/textpattern/issues/comments/365540864","html_url":"https://github.com/textpattern/textpattern/issues/1144#issuecomment-365540864","issue_url":"https://api.github.com/repos/textpattern/textpattern/issues/1144","id":365540864,"user":{"login":"philwareham","id":413665,"avatar_url":"https://avatars2.githubusercontent.com/u/413665?v=4","gravatar_id":"","url":"https://api.github.com/users/philwareham","html_url":"https://github.com/philwareham","followers_url":"https://api.github.com/users/philwareham/followers","following_url":"https://api.github.com/users/philwareham/following{/other_user}","gists_url":"https://api.github.com/users/philwareham/gists{/gist_id}","starred_url":"https://api.github.com/users/philwareham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwareham/subscriptions","organizations_url":"https://api.github.com/users/philwareham/orgs","repos_url":"https://api.github.com/users/philwareham/repos","events_url":"https://api.github.com/users/philwareham/events{/privacy}","received_events_url":"https://api.github.com/users/philwareham/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T09:10:43Z","updated_at":"2018-02-14T09:10:43Z","author_association":"OWNER","body":"Done. Please test."}}
{"actor":{"display_login":"philwareham"}}