{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/comments/194167448","pull_request_review_id":127297861,"id":194167448,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDE2NzQ0OA==","diff_hunk":"@@ -0,0 +1,119 @@\n+// Copyright 2018 Google LLC","path":"google/cloud/storage/well_known_parameters.h","position":1,"original_position":1,"commit_id":"ffd9714f1dbeaaee3bf44758c28aad7bf1d39568","original_commit_id":"c9b3e3503200a3a47a0ff282646b6d91f013643f","user":{"login":"coryan","id":6241635,"node_id":"MDQ6VXNlcjYyNDE2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6241635?v=4","gravatar_id":"","url":"https://api.github.com/users/coryan","html_url":"https://github.com/coryan","followers_url":"https://api.github.com/users/coryan/followers","following_url":"https://api.github.com/users/coryan/following{/other_user}","gists_url":"https://api.github.com/users/coryan/gists{/gist_id}","starred_url":"https://api.github.com/users/coryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryan/subscriptions","organizations_url":"https://api.github.com/users/coryan/orgs","repos_url":"https://api.github.com/users/coryan/repos","events_url":"https://api.github.com/users/coryan/events{/privacy}","received_events_url":"https://api.github.com/users/coryan/received_events","type":"User","site_admin":false},"body":"> If we're going to make them public, I'd suggest renaming the single Apply methods to\r\n> ApplyModifier -- it's then more obvious that ApplyModifiers is basically shorthand for several\r\n> ApplyModifier calls.\r\n\r\nDone.\r\n\r\n> To that effect, the docs for ApplyModifiers could be simplified, saying something along the lines\r\n> of \"this is shorthand for request.ApplyModifier(m1); request.ApplyModifier(m2); ...\r\n\r\nDone.","created_at":"2018-06-08T20:04:23Z","updated_at":"2018-06-08T20:04:23Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/685#discussion_r194167448","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/685","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/comments/194167448"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/685#discussion_r194167448"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/685"}},"in_reply_to_id":193932801},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/685","id":193428791,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDI4Nzkx","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/685","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/685.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/685.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/685","number":685,"state":"open","locked":false,"title":"Support query modifiers in Bucket::GetMetadata.","user":{"login":"coryan","id":6241635,"node_id":"MDQ6VXNlcjYyNDE2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6241635?v=4","gravatar_id":"","url":"https://api.github.com/users/coryan","html_url":"https://github.com/coryan","followers_url":"https://api.github.com/users/coryan/followers","following_url":"https://api.github.com/users/coryan/following{/other_user}","gists_url":"https://api.github.com/users/coryan/gists{/gist_id}","starred_url":"https://api.github.com/users/coryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryan/subscriptions","organizations_url":"https://api.github.com/users/coryan/orgs","repos_url":"https://api.github.com/users/coryan/repos","events_url":"https://api.github.com/users/coryan/events{/privacy}","received_events_url":"https://api.github.com/users/coryan/received_events","type":"User","site_admin":false},"body":"This implements per-request query modifiers such as\r\nifGenerationMatch, or userProject (#566).\r\n\r\nLet me know if you would like me to break this down into smaller PRs.  It kind of makes sense as a single one, but it is a lot of go through.\r\n","created_at":"2018-06-07T19:48:57Z","updated_at":"2018-06-08T20:04:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcb3a1a370d7ca25f09a225c483bfc7f4e92b415","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mbrukman","id":4074659,"node_id":"MDQ6VXNlcjQwNzQ2NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/4074659?v=4","gravatar_id":"","url":"https://api.github.com/users/mbrukman","html_url":"https://github.com/mbrukman","followers_url":"https://api.github.com/users/mbrukman/followers","following_url":"https://api.github.com/users/mbrukman/following{/other_user}","gists_url":"https://api.github.com/users/mbrukman/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrukman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrukman/subscriptions","organizations_url":"https://api.github.com/users/mbrukman/orgs","repos_url":"https://api.github.com/users/mbrukman/repos","events_url":"https://api.github.com/users/mbrukman/events{/privacy}","received_events_url":"https://api.github.com/users/mbrukman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":760104389,"node_id":"MDU6TGFiZWw3NjAxMDQzODk=","url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false},{"id":921026962,"node_id":"MDU6TGFiZWw5MjEwMjY5NjI=","url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/labels/storage","name":"storage","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/685/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/685/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/685/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/statuses/ffd9714f1dbeaaee3bf44758c28aad7bf1d39568","head":{"label":"coryan:prototype-request-modifiers","ref":"prototype-request-modifiers","sha":"ffd9714f1dbeaaee3bf44758c28aad7bf1d39568","user":{"login":"coryan","id":6241635,"node_id":"MDQ6VXNlcjYyNDE2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6241635?v=4","gravatar_id":"","url":"https://api.github.com/users/coryan","html_url":"https://github.com/coryan","followers_url":"https://api.github.com/users/coryan/followers","following_url":"https://api.github.com/users/coryan/following{/other_user}","gists_url":"https://api.github.com/users/coryan/gists{/gist_id}","starred_url":"https://api.github.com/users/coryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryan/subscriptions","organizations_url":"https://api.github.com/users/coryan/orgs","repos_url":"https://api.github.com/users/coryan/repos","events_url":"https://api.github.com/users/coryan/events{/privacy}","received_events_url":"https://api.github.com/users/coryan/received_events","type":"User","site_admin":false},"repo":{"id":111937615,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE5Mzc2MTU=","name":"google-cloud-cpp","full_name":"coryan/google-cloud-cpp","owner":{"login":"coryan","id":6241635,"node_id":"MDQ6VXNlcjYyNDE2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6241635?v=4","gravatar_id":"","url":"https://api.github.com/users/coryan","html_url":"https://github.com/coryan","followers_url":"https://api.github.com/users/coryan/followers","following_url":"https://api.github.com/users/coryan/following{/other_user}","gists_url":"https://api.github.com/users/coryan/gists{/gist_id}","starred_url":"https://api.github.com/users/coryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryan/subscriptions","organizations_url":"https://api.github.com/users/coryan/orgs","repos_url":"https://api.github.com/users/coryan/repos","events_url":"https://api.github.com/users/coryan/events{/privacy}","received_events_url":"https://api.github.com/users/coryan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/coryan/google-cloud-cpp","description":"Google Cloud Platform C++ client libraries","fork":true,"url":"https://api.github.com/repos/coryan/google-cloud-cpp","forks_url":"https://api.github.com/repos/coryan/google-cloud-cpp/forks","keys_url":"https://api.github.com/repos/coryan/google-cloud-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coryan/google-cloud-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coryan/google-cloud-cpp/teams","hooks_url":"https://api.github.com/repos/coryan/google-cloud-cpp/hooks","issue_events_url":"https://api.github.com/repos/coryan/google-cloud-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/coryan/google-cloud-cpp/events","assignees_url":"https://api.github.com/repos/coryan/google-cloud-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/coryan/google-cloud-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/coryan/google-cloud-cpp/tags","blobs_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coryan/google-cloud-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/coryan/google-cloud-cpp/languages","stargazers_url":"https://api.github.com/repos/coryan/google-cloud-cpp/stargazers","contributors_url":"https://api.github.com/repos/coryan/google-cloud-cpp/contributors","subscribers_url":"https://api.github.com/repos/coryan/google-cloud-cpp/subscribers","subscription_url":"https://api.github.com/repos/coryan/google-cloud-cpp/subscription","commits_url":"https://api.github.com/repos/coryan/google-cloud-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/coryan/google-cloud-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/coryan/google-cloud-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/coryan/google-cloud-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/coryan/google-cloud-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/coryan/google-cloud-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coryan/google-cloud-cpp/merges","archive_url":"https://api.github.com/repos/coryan/google-cloud-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coryan/google-cloud-cpp/downloads","issues_url":"https://api.github.com/repos/coryan/google-cloud-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/coryan/google-cloud-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/coryan/google-cloud-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/coryan/google-cloud-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coryan/google-cloud-cpp/labels{/name}","releases_url":"https://api.github.com/repos/coryan/google-cloud-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/coryan/google-cloud-cpp/deployments","created_at":"2017-11-24T16:28:07Z","updated_at":"2018-06-08T04:01:48Z","pushed_at":"2018-06-08T19:59:30Z","git_url":"git://github.com/coryan/google-cloud-cpp.git","ssh_url":"git@github.com:coryan/google-cloud-cpp.git","clone_url":"https://github.com/coryan/google-cloud-cpp.git","svn_url":"https://github.com/coryan/google-cloud-cpp","homepage":"https://cloud.google.com/","size":93870,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"bda924edf30b3d6d222989ee2503504d170dd1e4","user":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":111860063,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE4NjAwNjM=","name":"google-cloud-cpp","full_name":"GoogleCloudPlatform/google-cloud-cpp","owner":{"login":"GoogleCloudPlatform","id":2810941,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTA5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp","description":"Google Cloud Client Library for C++","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/deployments","created_at":"2017-11-24T00:19:31Z","updated_at":"2018-06-08T19:18:52Z","pushed_at":"2018-06-08T19:59:32Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-cpp.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-cpp.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-cpp","homepage":"https://cloud.google.com/","size":86394,"stargazers_count":30,"watchers_count":30,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":140,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/685"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-cpp/pull/685"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/685"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/issues/685/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/685/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/pulls/685/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-cpp/statuses/ffd9714f1dbeaaee3bf44758c28aad7bf1d39568"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"coryan"}}