{"action":"created","issue":{"url":"https://api.github.com/repos/django-oscar/django-oscar/issues/2679","repository_url":"https://api.github.com/repos/django-oscar/django-oscar","labels_url":"https://api.github.com/repos/django-oscar/django-oscar/issues/2679/labels{/name}","comments_url":"https://api.github.com/repos/django-oscar/django-oscar/issues/2679/comments","events_url":"https://api.github.com/repos/django-oscar/django-oscar/issues/2679/events","html_url":"https://github.com/django-oscar/django-oscar/pull/2679","id":314302227,"number":2679,"title":"Decouple price and availability in base strategies.","user":{"login":"solarissmoke","id":160227,"avatar_url":"https://avatars1.githubusercontent.com/u/160227?v=4","gravatar_id":"","url":"https://api.github.com/users/solarissmoke","html_url":"https://github.com/solarissmoke","followers_url":"https://api.github.com/users/solarissmoke/followers","following_url":"https://api.github.com/users/solarissmoke/following{/other_user}","gists_url":"https://api.github.com/users/solarissmoke/gists{/gist_id}","starred_url":"https://api.github.com/users/solarissmoke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarissmoke/subscriptions","organizations_url":"https://api.github.com/users/solarissmoke/orgs","repos_url":"https://api.github.com/users/solarissmoke/repos","events_url":"https://api.github.com/users/solarissmoke/events{/privacy}","received_events_url":"https://api.github.com/users/solarissmoke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-14T05:52:16Z","updated_at":"2018-04-18T03:02:30Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/django-oscar/django-oscar/pulls/2679","html_url":"https://github.com/django-oscar/django-oscar/pull/2679","diff_url":"https://github.com/django-oscar/django-oscar/pull/2679.diff","patch_url":"https://github.com/django-oscar/django-oscar/pull/2679.patch"},"body":"Revert the changes in #1913 that required a stock record to have `price_excl_tax` set in order to report the product as available, on the basis that price and availability should be kept separate.\r\n\r\nAdd separate checks to the basket form/add logic that checks at the time of\r\nadding a product to the basket whether a price exists, and report an error if it doesn't. If a price is not found, then the add to basket form will raise a `ValidationError` - projects are responsible for ensuring that they supply a valid pricing strategy in such cases.\r\n\r\nFixes #2664."},"comment":{"url":"https://api.github.com/repos/django-oscar/django-oscar/issues/comments/382237233","html_url":"https://github.com/django-oscar/django-oscar/pull/2679#issuecomment-382237233","issue_url":"https://api.github.com/repos/django-oscar/django-oscar/issues/2679","id":382237233,"user":{"login":"solarissmoke","id":160227,"avatar_url":"https://avatars1.githubusercontent.com/u/160227?v=4","gravatar_id":"","url":"https://api.github.com/users/solarissmoke","html_url":"https://github.com/solarissmoke","followers_url":"https://api.github.com/users/solarissmoke/followers","following_url":"https://api.github.com/users/solarissmoke/following{/other_user}","gists_url":"https://api.github.com/users/solarissmoke/gists{/gist_id}","starred_url":"https://api.github.com/users/solarissmoke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarissmoke/subscriptions","organizations_url":"https://api.github.com/users/solarissmoke/orgs","repos_url":"https://api.github.com/users/solarissmoke/repos","events_url":"https://api.github.com/users/solarissmoke/events{/privacy}","received_events_url":"https://api.github.com/users/solarissmoke/received_events","type":"User","site_admin":false},"created_at":"2018-04-18T03:02:30Z","updated_at":"2018-04-18T03:02:30Z","author_association":"MEMBER","body":"Thanks for the review all. I have added a note to the release notes and merged - this will ship in the final 1.6 release."}}
{"actor":{"display_login":"solarissmoke"}}