{"action":"created","comment":{"url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/pulls/comments/203533128","pull_request_review_id":138443490,"id":203533128,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzUzMzEyOA==","diff_hunk":"@@ -1,4 +1,11 @@\n if [ `uname` = 'Darwin' ]; then export SD_CURL_CMD_WRAPPER=\"eval\"; else export SD_CURL_CMD_WRAPPER=\"$(echo 'sd-step exec --pkg-version 7.54.1 core/curl')\"; fi\n cd $SD_ARTIFACTS_DIR\n find . -type f -print > manifest.txt\n-find . -type f -exec sh -c 'f=`echo $1 | sed \"s/^\\.\\///\"`; encoded=$($SD_CURL_CMD_WRAPPER \"curl -s -w \\\"%{url_effective}\\\" --data-urlencode \\\"$f\\\" -G \\\"\\\" | sed -e \\\"s/^\\/?//\\\"\"); $SD_CURL_CMD_WRAPPER \"curl -H \\\"Authorization: Bearer $SD_TOKEN\\\" -H \\\"Content-Type: text/plain\\\" -X PUT $STORE_URL/v1/builds/$SD_BUILD_ID/$ARTIFACTS_DIR_SUFFIX/$encoded -T ./\\\"$f\\\"\"' -- {} \\;\n+\n+if [ \"$SD_ZIP_ARTIFACTS\" = \"yes\" ]; then","path":"commands.txt","position":6,"original_position":6,"commit_id":"00c48020aca81dc4fb303c686b7e3cef190b3506","original_commit_id":"00c48020aca81dc4fb303c686b7e3cef190b3506","user":{"login":"tkyi","id":3230529,"node_id":"MDQ6VXNlcjMyMzA1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/3230529?v=4","gravatar_id":"","url":"https://api.github.com/users/tkyi","html_url":"https://github.com/tkyi","followers_url":"https://api.github.com/users/tkyi/followers","following_url":"https://api.github.com/users/tkyi/following{/other_user}","gists_url":"https://api.github.com/users/tkyi/gists{/gist_id}","starred_url":"https://api.github.com/users/tkyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkyi/subscriptions","organizations_url":"https://api.github.com/users/tkyi/orgs","repos_url":"https://api.github.com/users/tkyi/repos","events_url":"https://api.github.com/users/tkyi/events{/privacy}","received_events_url":"https://api.github.com/users/tkyi/received_events","type":"User","site_admin":false},"body":"`\"yes\"`? should we just use `true`?","created_at":"2018-07-18T21:18:56Z","updated_at":"2018-07-18T21:18:56Z","html_url":"https://github.com/screwdriver-cd/artifact-bookend/pull/23#discussion_r203533128","pull_request_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/pulls/23","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/pulls/comments/203533128"},"html":{"href":"https://github.com/screwdriver-cd/artifact-bookend/pull/23#discussion_r203533128"},"pull_request":{"href":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/pulls/23","id":202374208,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzc0MjA4","html_url":"https://github.com/screwdriver-cd/artifact-bookend/pull/23","diff_url":"https://github.com/screwdriver-cd/artifact-bookend/pull/23.diff","patch_url":"https://github.com/screwdriver-cd/artifact-bookend/pull/23.patch","issue_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/issues/23","number":23,"state":"open","locked":false,"title":"Zip artifacts before uploading","user":{"login":"pranavrc","id":691950,"node_id":"MDQ6VXNlcjY5MTk1MA==","avatar_url":"https://avatars1.githubusercontent.com/u/691950?v=4","gravatar_id":"","url":"https://api.github.com/users/pranavrc","html_url":"https://github.com/pranavrc","followers_url":"https://api.github.com/users/pranavrc/followers","following_url":"https://api.github.com/users/pranavrc/following{/other_user}","gists_url":"https://api.github.com/users/pranavrc/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavrc/subscriptions","organizations_url":"https://api.github.com/users/pranavrc/orgs","repos_url":"https://api.github.com/users/pranavrc/repos","events_url":"https://api.github.com/users/pranavrc/events{/privacy}","received_events_url":"https://api.github.com/users/pranavrc/received_events","type":"User","site_admin":false},"body":"# Context\r\n\r\nCurrently we're uploading each artifact in a separate network call, so a build with a lot of artifacts creates a lot of network calls. The PR is to zip all the artifacts into one file and upload it so that aws lambda can take care of unzipping it.\r\n\r\n# Objective\r\n\r\n- [ ] Check if `SD_ZIP_ARTIFACTS` is set\r\n- [ ] If it is, zip all the artifacts and uploading it to the store\r\n\r\n# Related links\r\n\r\nIssue - https://github.com/screwdriver-cd/screwdriver/issues/1196","created_at":"2018-07-18T20:43:10Z","updated_at":"2018-07-18T21:18:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1502539b4b09801baac4d151984b922d26ea482c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/pulls/23/commits","review_comments_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/pulls/23/comments","review_comment_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/issues/23/comments","statuses_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/statuses/00c48020aca81dc4fb303c686b7e3cef190b3506","head":{"label":"screwdriver-cd:zipartifact","ref":"zipartifact","sha":"00c48020aca81dc4fb303c686b7e3cef190b3506","user":{"login":"screwdriver-cd","id":19417863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDE3ODYz","avatar_url":"https://avatars0.githubusercontent.com/u/19417863?v=4","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"repo":{"id":82125107,"node_id":"MDEwOlJlcG9zaXRvcnk4MjEyNTEwNw==","name":"artifact-bookend","full_name":"screwdriver-cd/artifact-bookend","owner":{"login":"screwdriver-cd","id":19417863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDE3ODYz","avatar_url":"https://avatars0.githubusercontent.com/u/19417863?v=4","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/screwdriver-cd/artifact-bookend","description":"sd.cd bookend for uploading artifacts","fork":false,"url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend","forks_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/forks","keys_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/teams","hooks_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/hooks","issue_events_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/issues/events{/number}","events_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/events","assignees_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/assignees{/user}","branches_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/branches{/branch}","tags_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/tags","blobs_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/git/refs{/sha}","trees_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/statuses/{sha}","languages_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/languages","stargazers_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/stargazers","contributors_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/contributors","subscribers_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/subscribers","subscription_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/subscription","commits_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/commits{/sha}","git_commits_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/git/commits{/sha}","comments_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/comments{/number}","issue_comment_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/issues/comments{/number}","contents_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/contents/{+path}","compare_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/merges","archive_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/downloads","issues_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/issues{/number}","pulls_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/pulls{/number}","milestones_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/milestones{/number}","notifications_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/labels{/name}","releases_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/releases{/id}","deployments_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/deployments","created_at":"2017-02-16T01:27:59Z","updated_at":"2018-05-07T21:47:09Z","pushed_at":"2018-07-18T20:46:17Z","git_url":"git://github.com/screwdriver-cd/artifact-bookend.git","ssh_url":"git@github.com:screwdriver-cd/artifact-bookend.git","clone_url":"https://github.com/screwdriver-cd/artifact-bookend.git","svn_url":"https://github.com/screwdriver-cd/artifact-bookend","homepage":null,"size":36,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"screwdriver-cd:master","ref":"master","sha":"792de3a230c9b98e01963932546f679cacc06444","user":{"login":"screwdriver-cd","id":19417863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDE3ODYz","avatar_url":"https://avatars0.githubusercontent.com/u/19417863?v=4","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"repo":{"id":82125107,"node_id":"MDEwOlJlcG9zaXRvcnk4MjEyNTEwNw==","name":"artifact-bookend","full_name":"screwdriver-cd/artifact-bookend","owner":{"login":"screwdriver-cd","id":19417863,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDE3ODYz","avatar_url":"https://avatars0.githubusercontent.com/u/19417863?v=4","gravatar_id":"","url":"https://api.github.com/users/screwdriver-cd","html_url":"https://github.com/screwdriver-cd","followers_url":"https://api.github.com/users/screwdriver-cd/followers","following_url":"https://api.github.com/users/screwdriver-cd/following{/other_user}","gists_url":"https://api.github.com/users/screwdriver-cd/gists{/gist_id}","starred_url":"https://api.github.com/users/screwdriver-cd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screwdriver-cd/subscriptions","organizations_url":"https://api.github.com/users/screwdriver-cd/orgs","repos_url":"https://api.github.com/users/screwdriver-cd/repos","events_url":"https://api.github.com/users/screwdriver-cd/events{/privacy}","received_events_url":"https://api.github.com/users/screwdriver-cd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/screwdriver-cd/artifact-bookend","description":"sd.cd bookend for uploading artifacts","fork":false,"url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend","forks_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/forks","keys_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/teams","hooks_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/hooks","issue_events_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/issues/events{/number}","events_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/events","assignees_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/assignees{/user}","branches_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/branches{/branch}","tags_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/tags","blobs_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/git/refs{/sha}","trees_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/statuses/{sha}","languages_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/languages","stargazers_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/stargazers","contributors_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/contributors","subscribers_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/subscribers","subscription_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/subscription","commits_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/commits{/sha}","git_commits_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/git/commits{/sha}","comments_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/comments{/number}","issue_comment_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/issues/comments{/number}","contents_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/contents/{+path}","compare_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/merges","archive_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/downloads","issues_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/issues{/number}","pulls_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/pulls{/number}","milestones_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/milestones{/number}","notifications_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/labels{/name}","releases_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/releases{/id}","deployments_url":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/deployments","created_at":"2017-02-16T01:27:59Z","updated_at":"2018-05-07T21:47:09Z","pushed_at":"2018-07-18T20:46:17Z","git_url":"git://github.com/screwdriver-cd/artifact-bookend.git","ssh_url":"git@github.com:screwdriver-cd/artifact-bookend.git","clone_url":"https://github.com/screwdriver-cd/artifact-bookend.git","svn_url":"https://github.com/screwdriver-cd/artifact-bookend","homepage":null,"size":36,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/pulls/23"},"html":{"href":"https://github.com/screwdriver-cd/artifact-bookend/pull/23"},"issue":{"href":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/issues/23"},"comments":{"href":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/screwdriver-cd/artifact-bookend/statuses/00c48020aca81dc4fb303c686b7e3cef190b3506"}},"author_association":"NONE"}}
{"actor":{"display_login":"tkyi"}}