{"action":"created","comment":{"url":"https://api.github.com/repos/Morgan-Stanley/testplan/pulls/comments/236703084","pull_request_review_id":178819518,"id":236703084,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjcwMzA4NA==","diff_hunk":"@@ -460,10 +467,16 @@ def status(self):\n \n     def merge(self, report, strict=True):\n         \"\"\"\n-          TestCaseReport merge overwrites everything in place,\n-          as assertions of a test case won't be split among different runners.\n+        TestCaseReport merge overwrites everything in place, as assertions\n+        of a test case won't be split among different runners. For some special\n+        test cases, choose the one whose status is of higher precedence.\n         \"\"\"\n         self._check_report(report)\n+        if not self.replace_instead_of_merge and \\","path":"testplan/report/testing/base.py","position":60,"original_position":60,"commit_id":"ee05e4f4acd0b34e4ab0c108763dce47e05e2c35","original_commit_id":"ee05e4f4acd0b34e4ab0c108763dce47e05e2c35","user":{"login":"ryan-collingham","id":43373633,"node_id":"MDQ6VXNlcjQzMzczNjMz","avatar_url":"https://avatars3.githubusercontent.com/u/43373633?v=4","gravatar_id":"","url":"https://api.github.com/users/ryan-collingham","html_url":"https://github.com/ryan-collingham","followers_url":"https://api.github.com/users/ryan-collingham/followers","following_url":"https://api.github.com/users/ryan-collingham/following{/other_user}","gists_url":"https://api.github.com/users/ryan-collingham/gists{/gist_id}","starred_url":"https://api.github.com/users/ryan-collingham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryan-collingham/subscriptions","organizations_url":"https://api.github.com/users/ryan-collingham/orgs","repos_url":"https://api.github.com/users/ryan-collingham/repos","events_url":"https://api.github.com/users/ryan-collingham/events{/privacy}","received_events_url":"https://api.github.com/users/ryan-collingham/received_events","type":"User","site_admin":false},"body":"Personally I find `\\` very ugly - can be avoided with parentheses:\r\n\r\n```suggestion\r\n        if (not self.replace_instead_of_merge) and (\r\n                Status.precedent([self.status]) <\r\n                Status.precedent([report.status])):\r\n```\r\n\r\nas recommended by PEP 8 https://www.python.org/dev/peps/pep-0008/#maximum-line-length","created_at":"2018-11-27T15:05:08Z","updated_at":"2018-11-27T15:39:07Z","html_url":"https://github.com/Morgan-Stanley/testplan/pull/82#discussion_r236703084","pull_request_url":"https://api.github.com/repos/Morgan-Stanley/testplan/pulls/82","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Morgan-Stanley/testplan/pulls/comments/236703084"},"html":{"href":"https://github.com/Morgan-Stanley/testplan/pull/82#discussion_r236703084"},"pull_request":{"href":"https://api.github.com/repos/Morgan-Stanley/testplan/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/Morgan-Stanley/testplan/pulls/82","id":233602270,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjAyMjcw","html_url":"https://github.com/Morgan-Stanley/testplan/pull/82","diff_url":"https://github.com/Morgan-Stanley/testplan/pull/82.diff","patch_url":"https://github.com/Morgan-Stanley/testplan/pull/82.patch","issue_url":"https://api.github.com/repos/Morgan-Stanley/testplan/issues/82","number":82,"state":"open","locked":false,"title":"MultiTest parts scheduling","user":{"login":"raoyitao","id":8922993,"node_id":"MDQ6VXNlcjg5MjI5OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/8922993?v=4","gravatar_id":"","url":"https://api.github.com/users/raoyitao","html_url":"https://github.com/raoyitao","followers_url":"https://api.github.com/users/raoyitao/followers","following_url":"https://api.github.com/users/raoyitao/following{/other_user}","gists_url":"https://api.github.com/users/raoyitao/gists{/gist_id}","starred_url":"https://api.github.com/users/raoyitao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raoyitao/subscriptions","organizations_url":"https://api.github.com/users/raoyitao/orgs","repos_url":"https://api.github.com/users/raoyitao/repos","events_url":"https://api.github.com/users/raoyitao/events{/privacy}","received_events_url":"https://api.github.com/users/raoyitao/received_events","type":"User","site_admin":false},"body":"* A Task that returns a MultiTest can be scheduled in parts in one or\r\n  more pools. Each MultiTest will have its own environment and will run\r\n  a subtotal of testcases based on which part of the total number of\r\n  parts it is. Each MultiTest part will produce its own report entry.\r\n  ISSUE: should the testcase reports be re-ordered after merging?","created_at":"2018-11-26T15:41:49Z","updated_at":"2018-11-27T15:39:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb0cebbdd77995f5c40760755afdc608970c0429","assignee":null,"assignees":[],"requested_reviewers":[{"login":"JohnChiotis","id":26144354,"node_id":"MDQ6VXNlcjI2MTQ0MzU0","avatar_url":"https://avatars2.githubusercontent.com/u/26144354?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnChiotis","html_url":"https://github.com/JohnChiotis","followers_url":"https://api.github.com/users/JohnChiotis/followers","following_url":"https://api.github.com/users/JohnChiotis/following{/other_user}","gists_url":"https://api.github.com/users/JohnChiotis/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnChiotis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnChiotis/subscriptions","organizations_url":"https://api.github.com/users/JohnChiotis/orgs","repos_url":"https://api.github.com/users/JohnChiotis/repos","events_url":"https://api.github.com/users/JohnChiotis/events{/privacy}","received_events_url":"https://api.github.com/users/JohnChiotis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Morgan-Stanley/testplan/pulls/82/commits","review_comments_url":"https://api.github.com/repos/Morgan-Stanley/testplan/pulls/82/comments","review_comment_url":"https://api.github.com/repos/Morgan-Stanley/testplan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Morgan-Stanley/testplan/issues/82/comments","statuses_url":"https://api.github.com/repos/Morgan-Stanley/testplan/statuses/ee05e4f4acd0b34e4ab0c108763dce47e05e2c35","head":{"label":"raoyitao:multitest_parts","ref":"multitest_parts","sha":"ee05e4f4acd0b34e4ab0c108763dce47e05e2c35","user":{"login":"raoyitao","id":8922993,"node_id":"MDQ6VXNlcjg5MjI5OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/8922993?v=4","gravatar_id":"","url":"https://api.github.com/users/raoyitao","html_url":"https://github.com/raoyitao","followers_url":"https://api.github.com/users/raoyitao/followers","following_url":"https://api.github.com/users/raoyitao/following{/other_user}","gists_url":"https://api.github.com/users/raoyitao/gists{/gist_id}","starred_url":"https://api.github.com/users/raoyitao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raoyitao/subscriptions","organizations_url":"https://api.github.com/users/raoyitao/orgs","repos_url":"https://api.github.com/users/raoyitao/repos","events_url":"https://api.github.com/users/raoyitao/events{/privacy}","received_events_url":"https://api.github.com/users/raoyitao/received_events","type":"User","site_admin":false},"repo":{"id":135962799,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU5NjI3OTk=","name":"testplan","full_name":"raoyitao/testplan","private":false,"owner":{"login":"raoyitao","id":8922993,"node_id":"MDQ6VXNlcjg5MjI5OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/8922993?v=4","gravatar_id":"","url":"https://api.github.com/users/raoyitao","html_url":"https://github.com/raoyitao","followers_url":"https://api.github.com/users/raoyitao/followers","following_url":"https://api.github.com/users/raoyitao/following{/other_user}","gists_url":"https://api.github.com/users/raoyitao/gists{/gist_id}","starred_url":"https://api.github.com/users/raoyitao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raoyitao/subscriptions","organizations_url":"https://api.github.com/users/raoyitao/orgs","repos_url":"https://api.github.com/users/raoyitao/repos","events_url":"https://api.github.com/users/raoyitao/events{/privacy}","received_events_url":"https://api.github.com/users/raoyitao/received_events","type":"User","site_admin":false},"html_url":"https://github.com/raoyitao/testplan","description":"Testplan, a multi-testing framework, because unit tests can only go so far..","fork":true,"url":"https://api.github.com/repos/raoyitao/testplan","forks_url":"https://api.github.com/repos/raoyitao/testplan/forks","keys_url":"https://api.github.com/repos/raoyitao/testplan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raoyitao/testplan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raoyitao/testplan/teams","hooks_url":"https://api.github.com/repos/raoyitao/testplan/hooks","issue_events_url":"https://api.github.com/repos/raoyitao/testplan/issues/events{/number}","events_url":"https://api.github.com/repos/raoyitao/testplan/events","assignees_url":"https://api.github.com/repos/raoyitao/testplan/assignees{/user}","branches_url":"https://api.github.com/repos/raoyitao/testplan/branches{/branch}","tags_url":"https://api.github.com/repos/raoyitao/testplan/tags","blobs_url":"https://api.github.com/repos/raoyitao/testplan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raoyitao/testplan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raoyitao/testplan/git/refs{/sha}","trees_url":"https://api.github.com/repos/raoyitao/testplan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raoyitao/testplan/statuses/{sha}","languages_url":"https://api.github.com/repos/raoyitao/testplan/languages","stargazers_url":"https://api.github.com/repos/raoyitao/testplan/stargazers","contributors_url":"https://api.github.com/repos/raoyitao/testplan/contributors","subscribers_url":"https://api.github.com/repos/raoyitao/testplan/subscribers","subscription_url":"https://api.github.com/repos/raoyitao/testplan/subscription","commits_url":"https://api.github.com/repos/raoyitao/testplan/commits{/sha}","git_commits_url":"https://api.github.com/repos/raoyitao/testplan/git/commits{/sha}","comments_url":"https://api.github.com/repos/raoyitao/testplan/comments{/number}","issue_comment_url":"https://api.github.com/repos/raoyitao/testplan/issues/comments{/number}","contents_url":"https://api.github.com/repos/raoyitao/testplan/contents/{+path}","compare_url":"https://api.github.com/repos/raoyitao/testplan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raoyitao/testplan/merges","archive_url":"https://api.github.com/repos/raoyitao/testplan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raoyitao/testplan/downloads","issues_url":"https://api.github.com/repos/raoyitao/testplan/issues{/number}","pulls_url":"https://api.github.com/repos/raoyitao/testplan/pulls{/number}","milestones_url":"https://api.github.com/repos/raoyitao/testplan/milestones{/number}","notifications_url":"https://api.github.com/repos/raoyitao/testplan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raoyitao/testplan/labels{/name}","releases_url":"https://api.github.com/repos/raoyitao/testplan/releases{/id}","deployments_url":"https://api.github.com/repos/raoyitao/testplan/deployments","created_at":"2018-06-04T02:52:57Z","updated_at":"2018-11-14T02:36:28Z","pushed_at":"2018-11-26T15:40:59Z","git_url":"git://github.com/raoyitao/testplan.git","ssh_url":"git@github.com:raoyitao/testplan.git","clone_url":"https://github.com/raoyitao/testplan.git","svn_url":"https://github.com/raoyitao/testplan","homepage":"http://testplan.readthedocs.io","size":2410,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Morgan-Stanley:master","ref":"master","sha":"1a95934954c73814483bf23694865569dc156041","user":{"login":"Morgan-Stanley","id":5435928,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzU5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/5435928?v=4","gravatar_id":"","url":"https://api.github.com/users/Morgan-Stanley","html_url":"https://github.com/Morgan-Stanley","followers_url":"https://api.github.com/users/Morgan-Stanley/followers","following_url":"https://api.github.com/users/Morgan-Stanley/following{/other_user}","gists_url":"https://api.github.com/users/Morgan-Stanley/gists{/gist_id}","starred_url":"https://api.github.com/users/Morgan-Stanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morgan-Stanley/subscriptions","organizations_url":"https://api.github.com/users/Morgan-Stanley/orgs","repos_url":"https://api.github.com/users/Morgan-Stanley/repos","events_url":"https://api.github.com/users/Morgan-Stanley/events{/privacy}","received_events_url":"https://api.github.com/users/Morgan-Stanley/received_events","type":"Organization","site_admin":false},"repo":{"id":125212755,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUyMTI3NTU=","name":"testplan","full_name":"Morgan-Stanley/testplan","private":false,"owner":{"login":"Morgan-Stanley","id":5435928,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzU5Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/5435928?v=4","gravatar_id":"","url":"https://api.github.com/users/Morgan-Stanley","html_url":"https://github.com/Morgan-Stanley","followers_url":"https://api.github.com/users/Morgan-Stanley/followers","following_url":"https://api.github.com/users/Morgan-Stanley/following{/other_user}","gists_url":"https://api.github.com/users/Morgan-Stanley/gists{/gist_id}","starred_url":"https://api.github.com/users/Morgan-Stanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morgan-Stanley/subscriptions","organizations_url":"https://api.github.com/users/Morgan-Stanley/orgs","repos_url":"https://api.github.com/users/Morgan-Stanley/repos","events_url":"https://api.github.com/users/Morgan-Stanley/events{/privacy}","received_events_url":"https://api.github.com/users/Morgan-Stanley/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Morgan-Stanley/testplan","description":"Testplan, a multi-testing framework, because unit tests can only go so far..","fork":false,"url":"https://api.github.com/repos/Morgan-Stanley/testplan","forks_url":"https://api.github.com/repos/Morgan-Stanley/testplan/forks","keys_url":"https://api.github.com/repos/Morgan-Stanley/testplan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Morgan-Stanley/testplan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Morgan-Stanley/testplan/teams","hooks_url":"https://api.github.com/repos/Morgan-Stanley/testplan/hooks","issue_events_url":"https://api.github.com/repos/Morgan-Stanley/testplan/issues/events{/number}","events_url":"https://api.github.com/repos/Morgan-Stanley/testplan/events","assignees_url":"https://api.github.com/repos/Morgan-Stanley/testplan/assignees{/user}","branches_url":"https://api.github.com/repos/Morgan-Stanley/testplan/branches{/branch}","tags_url":"https://api.github.com/repos/Morgan-Stanley/testplan/tags","blobs_url":"https://api.github.com/repos/Morgan-Stanley/testplan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Morgan-Stanley/testplan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Morgan-Stanley/testplan/git/refs{/sha}","trees_url":"https://api.github.com/repos/Morgan-Stanley/testplan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Morgan-Stanley/testplan/statuses/{sha}","languages_url":"https://api.github.com/repos/Morgan-Stanley/testplan/languages","stargazers_url":"https://api.github.com/repos/Morgan-Stanley/testplan/stargazers","contributors_url":"https://api.github.com/repos/Morgan-Stanley/testplan/contributors","subscribers_url":"https://api.github.com/repos/Morgan-Stanley/testplan/subscribers","subscription_url":"https://api.github.com/repos/Morgan-Stanley/testplan/subscription","commits_url":"https://api.github.com/repos/Morgan-Stanley/testplan/commits{/sha}","git_commits_url":"https://api.github.com/repos/Morgan-Stanley/testplan/git/commits{/sha}","comments_url":"https://api.github.com/repos/Morgan-Stanley/testplan/comments{/number}","issue_comment_url":"https://api.github.com/repos/Morgan-Stanley/testplan/issues/comments{/number}","contents_url":"https://api.github.com/repos/Morgan-Stanley/testplan/contents/{+path}","compare_url":"https://api.github.com/repos/Morgan-Stanley/testplan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Morgan-Stanley/testplan/merges","archive_url":"https://api.github.com/repos/Morgan-Stanley/testplan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Morgan-Stanley/testplan/downloads","issues_url":"https://api.github.com/repos/Morgan-Stanley/testplan/issues{/number}","pulls_url":"https://api.github.com/repos/Morgan-Stanley/testplan/pulls{/number}","milestones_url":"https://api.github.com/repos/Morgan-Stanley/testplan/milestones{/number}","notifications_url":"https://api.github.com/repos/Morgan-Stanley/testplan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Morgan-Stanley/testplan/labels{/name}","releases_url":"https://api.github.com/repos/Morgan-Stanley/testplan/releases{/id}","deployments_url":"https://api.github.com/repos/Morgan-Stanley/testplan/deployments","created_at":"2018-03-14T12:58:19Z","updated_at":"2018-11-27T14:04:24Z","pushed_at":"2018-11-27T14:04:22Z","git_url":"git://github.com/Morgan-Stanley/testplan.git","ssh_url":"git@github.com:Morgan-Stanley/testplan.git","clone_url":"https://github.com/Morgan-Stanley/testplan.git","svn_url":"https://github.com/Morgan-Stanley/testplan","homepage":"http://testplan.readthedocs.io","size":2414,"stargazers_count":44,"watchers_count":44,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":2,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Morgan-Stanley/testplan/pulls/82"},"html":{"href":"https://github.com/Morgan-Stanley/testplan/pull/82"},"issue":{"href":"https://api.github.com/repos/Morgan-Stanley/testplan/issues/82"},"comments":{"href":"https://api.github.com/repos/Morgan-Stanley/testplan/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/Morgan-Stanley/testplan/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/Morgan-Stanley/testplan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Morgan-Stanley/testplan/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/Morgan-Stanley/testplan/statuses/ee05e4f4acd0b34e4ab0c108763dce47e05e2c35"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ryan-collingham"}}