{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/189287018","pull_request_review_id":121442159,"id":189287018,"diff_hunk":"@@ -402,6 +402,31 @@ int RSA_get0_multi_prime_crt_params(const RSA *r, const BIGNUM *exps[],\n     return 1;\n }\n \n+const BIGNUM *RSA_get0_n(const RSA *r)\n+{\n+    return r->n;\n+}\n+\n+const BIGNUM *RSA_get0_e(const RSA *r)\n+{\n+    return r->e;\n+}\n+\n+const BIGNUM *RSA_get0_d(const RSA *r)\n+{\n+    return r->d;\n+}\n+\n+const BIGNUM *RSA_get0_p(const RSA *r)\n+{\n+    return r->p;\n+}\n+\n+const BIGNUM *RSA_get0_q(const RSA *r)\n+{\n+    return r->q;\n+}\n+","path":"crypto/rsa/rsa_lib.c","position":28,"original_position":28,"commit_id":"4270c0c8d666a520a4598e2cb04fc1a856b7f3c4","original_commit_id":"4270c0c8d666a520a4598e2cb04fc1a856b7f3c4","user":{"login":"stevelinsell","id":15036083,"avatar_url":"https://avatars2.githubusercontent.com/u/15036083?v=4","gravatar_id":"","url":"https://api.github.com/users/stevelinsell","html_url":"https://github.com/stevelinsell","followers_url":"https://api.github.com/users/stevelinsell/followers","following_url":"https://api.github.com/users/stevelinsell/following{/other_user}","gists_url":"https://api.github.com/users/stevelinsell/gists{/gist_id}","starred_url":"https://api.github.com/users/stevelinsell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevelinsell/subscriptions","organizations_url":"https://api.github.com/users/stevelinsell/orgs","repos_url":"https://api.github.com/users/stevelinsell/repos","events_url":"https://api.github.com/users/stevelinsell/events{/privacy}","received_events_url":"https://api.github.com/users/stevelinsell/received_events","type":"User","site_admin":false},"body":"I concur that without a use case where you want the individual CRT parts it shouldn't be added.\r\nI guess the same is true for:\r\nECDSA_SIG_get0()\r\nwhich hasn't been considered in this pull request.\r\nI don't think you would want to retrieve r or s on their own so there is no point in adding simplified getters.","created_at":"2018-05-18T14:29:06Z","updated_at":"2018-05-18T14:29:06Z","html_url":"https://github.com/openssl/openssl/pull/6290#discussion_r189287018","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/6290","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/189287018"},"html":{"href":"https://github.com/openssl/openssl/pull/6290#discussion_r189287018"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6290"}},"in_reply_to_id":189197544},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/6290","id":188943772,"html_url":"https://github.com/openssl/openssl/pull/6290","diff_url":"https://github.com/openssl/openssl/pull/6290.diff","patch_url":"https://github.com/openssl/openssl/pull/6290.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/6290","number":6290,"state":"open","locked":false,"title":"WIP: DSA,RSA: add simple getters for commonly used struct members","user":{"login":"mspncp","id":11467854,"avatar_url":"https://avatars2.githubusercontent.com/u/11467854?v=4","gravatar_id":"","url":"https://api.github.com/users/mspncp","html_url":"https://github.com/mspncp","followers_url":"https://api.github.com/users/mspncp/followers","following_url":"https://api.github.com/users/mspncp/following{/other_user}","gists_url":"https://api.github.com/users/mspncp/gists{/gist_id}","starred_url":"https://api.github.com/users/mspncp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspncp/subscriptions","organizations_url":"https://api.github.com/users/mspncp/orgs","repos_url":"https://api.github.com/users/mspncp/repos","events_url":"https://api.github.com/users/mspncp/events{/privacy}","received_events_url":"https://api.github.com/users/mspncp/received_events","type":"User","site_admin":false},"body":"This continues #6273 which added simple accessors for DH, amending the accessors\r\n\r\n```\r\nvoid DH_get0_pqg(const DH *dh,\r\n                 const BIGNUM **p, const BIGNUM **q, const BIGNUM **g);\r\n\r\nvoid DH_get0_key(const DH *dh,\r\n                 const BIGNUM **pub_key, const BIGNUM **priv_key);\r\n```\r\n\r\nFor DSA, we add simple accessors amending\r\n\r\n```\r\nvoid DSA_get0_pqg(const DSA *d,\r\n                  const BIGNUM **p, const BIGNUM **q, const BIGNUM **g);\r\n\r\nvoid DSA_get0_key(const DSA *d,\r\n                  const BIGNUM **pub_key, const BIGNUM **priv_key);\r\n```\r\n\r\nand for RSA:\r\n\r\n```\r\nvoid RSA_get0_key(const RSA *r,\r\n                  const BIGNUM **n, const BIGNUM **e, const BIGNUM **d);\r\n\r\nvoid RSA_get0_factors(const RSA *r, const BIGNUM **p, const BIGNUM **q);\r\n\r\n```\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n- [ ] documentation is added or updated\r\n- [ ] tests are added or updated\r\n","created_at":"2018-05-18T07:35:01Z","updated_at":"2018-05-18T14:29:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a49c9ba5af732408f5e2ce532e7adca471c4959","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/6290/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/6290/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/6290/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/4270c0c8d666a520a4598e2cb04fc1a856b7f3c4","head":{"label":"mspncp:pr-dsa-rsa-add-simple-getters","ref":"pr-dsa-rsa-add-simple-getters","sha":"4270c0c8d666a520a4598e2cb04fc1a856b7f3c4","user":{"login":"mspncp","id":11467854,"avatar_url":"https://avatars2.githubusercontent.com/u/11467854?v=4","gravatar_id":"","url":"https://api.github.com/users/mspncp","html_url":"https://github.com/mspncp","followers_url":"https://api.github.com/users/mspncp/followers","following_url":"https://api.github.com/users/mspncp/following{/other_user}","gists_url":"https://api.github.com/users/mspncp/gists{/gist_id}","starred_url":"https://api.github.com/users/mspncp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspncp/subscriptions","organizations_url":"https://api.github.com/users/mspncp/orgs","repos_url":"https://api.github.com/users/mspncp/repos","events_url":"https://api.github.com/users/mspncp/events{/privacy}","received_events_url":"https://api.github.com/users/mspncp/received_events","type":"User","site_admin":false},"repo":{"id":54672642,"name":"openssl","full_name":"mspncp/openssl","owner":{"login":"mspncp","id":11467854,"avatar_url":"https://avatars2.githubusercontent.com/u/11467854?v=4","gravatar_id":"","url":"https://api.github.com/users/mspncp","html_url":"https://github.com/mspncp","followers_url":"https://api.github.com/users/mspncp/followers","following_url":"https://api.github.com/users/mspncp/following{/other_user}","gists_url":"https://api.github.com/users/mspncp/gists{/gist_id}","starred_url":"https://api.github.com/users/mspncp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspncp/subscriptions","organizations_url":"https://api.github.com/users/mspncp/orgs","repos_url":"https://api.github.com/users/mspncp/repos","events_url":"https://api.github.com/users/mspncp/events{/privacy}","received_events_url":"https://api.github.com/users/mspncp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mspncp/openssl","description":"TLS/SSL and crypto library","fork":true,"url":"https://api.github.com/repos/mspncp/openssl","forks_url":"https://api.github.com/repos/mspncp/openssl/forks","keys_url":"https://api.github.com/repos/mspncp/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mspncp/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mspncp/openssl/teams","hooks_url":"https://api.github.com/repos/mspncp/openssl/hooks","issue_events_url":"https://api.github.com/repos/mspncp/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/mspncp/openssl/events","assignees_url":"https://api.github.com/repos/mspncp/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/mspncp/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/mspncp/openssl/tags","blobs_url":"https://api.github.com/repos/mspncp/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mspncp/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mspncp/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/mspncp/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mspncp/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/mspncp/openssl/languages","stargazers_url":"https://api.github.com/repos/mspncp/openssl/stargazers","contributors_url":"https://api.github.com/repos/mspncp/openssl/contributors","subscribers_url":"https://api.github.com/repos/mspncp/openssl/subscribers","subscription_url":"https://api.github.com/repos/mspncp/openssl/subscription","commits_url":"https://api.github.com/repos/mspncp/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/mspncp/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/mspncp/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/mspncp/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/mspncp/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/mspncp/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mspncp/openssl/merges","archive_url":"https://api.github.com/repos/mspncp/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mspncp/openssl/downloads","issues_url":"https://api.github.com/repos/mspncp/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/mspncp/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/mspncp/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/mspncp/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mspncp/openssl/labels{/name}","releases_url":"https://api.github.com/repos/mspncp/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/mspncp/openssl/deployments","created_at":"2016-03-24T20:38:04Z","updated_at":"2018-05-11T16:22:05Z","pushed_at":"2018-05-18T07:26:39Z","git_url":"git://github.com/mspncp/openssl.git","ssh_url":"git@github.com:mspncp/openssl.git","clone_url":"https://github.com/mspncp/openssl.git","svn_url":"https://github.com/mspncp/openssl","homepage":"https://www.openssl.org","size":147259,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"8a59c08583424d59ac30c1261eedff40d653f8b0","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2018-05-18T14:23:47Z","pushed_at":"2018-05-18T13:52:22Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":147541,"stargazers_count":7129,"watchers_count":7129,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3451,"mirror_url":null,"archived":false,"open_issues_count":373,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3451,"open_issues":373,"watchers":7129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6290"},"html":{"href":"https://github.com/openssl/openssl/pull/6290"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/6290"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/6290/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6290/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6290/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/4270c0c8d666a520a4598e2cb04fc1a856b7f3c4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stevelinsell"}}