{"action":"created","comment":{"url":"https://api.github.com/repos/Adslot/adslot-ui/pulls/comments/186589847","pull_request_review_id":118197774,"id":186589847,"diff_hunk":"@@ -0,0 +1,64 @@\n+import React from 'react';\n+import PropTypes from 'prop-types';\n+\n+import './styles.scss';\n+\n+const Konsole = window.console;\n+\n+class CheckboxGroup extends React.Component {\n+\n+  constructor(props) {\n+    super(props);\n+    this.state = {\n+      value: this.props.value || [],\n+    };\n+    this.renderChildren = this.renderChildren.bind(this);\n+    this.onChangeCallback = this.onChangeCallback.bind(this);\n+  }\n+\n+  onChangeCallback(checkboxParams, event) {\n+    let newValue;\n+    if(checkboxParams.checked){\n+      newValue = this.state.value.concat([checkboxParams.value]);","path":"src/components/adslot-ui/CheckboxGroup/index.jsx","position":22,"original_position":22,"commit_id":"c2f072d4432299a66648307ec1ee51ea228b90b9","original_commit_id":"c2f072d4432299a66648307ec1ee51ea228b90b9","user":{"login":"mdotwills","id":5505611,"avatar_url":"https://avatars2.githubusercontent.com/u/5505611?v=4","gravatar_id":"","url":"https://api.github.com/users/mdotwills","html_url":"https://github.com/mdotwills","followers_url":"https://api.github.com/users/mdotwills/followers","following_url":"https://api.github.com/users/mdotwills/following{/other_user}","gists_url":"https://api.github.com/users/mdotwills/gists{/gist_id}","starred_url":"https://api.github.com/users/mdotwills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdotwills/subscriptions","organizations_url":"https://api.github.com/users/mdotwills/orgs","repos_url":"https://api.github.com/users/mdotwills/repos","events_url":"https://api.github.com/users/mdotwills/events{/privacy}","received_events_url":"https://api.github.com/users/mdotwills/received_events","type":"User","site_admin":false},"body":"good point about `concat` not mutating state. But the latter point still remains, you need to call `setState` with a function and not an object.","created_at":"2018-05-08T00:37:34Z","updated_at":"2018-05-08T00:37:34Z","html_url":"https://github.com/Adslot/adslot-ui/pull/716#discussion_r186589847","pull_request_url":"https://api.github.com/repos/Adslot/adslot-ui/pulls/716","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Adslot/adslot-ui/pulls/comments/186589847"},"html":{"href":"https://github.com/Adslot/adslot-ui/pull/716#discussion_r186589847"},"pull_request":{"href":"https://api.github.com/repos/Adslot/adslot-ui/pulls/716"}},"in_reply_to_id":186585890},"pull_request":{"url":"https://api.github.com/repos/Adslot/adslot-ui/pulls/716","id":185589430,"html_url":"https://github.com/Adslot/adslot-ui/pull/716","diff_url":"https://github.com/Adslot/adslot-ui/pull/716.diff","patch_url":"https://github.com/Adslot/adslot-ui/pull/716.patch","issue_url":"https://api.github.com/repos/Adslot/adslot-ui/issues/716","number":716,"state":"open","locked":false,"title":"[WIP] [ADS-1046] Checkbox/CheckboxGroup components","user":{"login":"nimishjha","id":3327105,"avatar_url":"https://avatars2.githubusercontent.com/u/3327105?v=4","gravatar_id":"","url":"https://api.github.com/users/nimishjha","html_url":"https://github.com/nimishjha","followers_url":"https://api.github.com/users/nimishjha/followers","following_url":"https://api.github.com/users/nimishjha/following{/other_user}","gists_url":"https://api.github.com/users/nimishjha/gists{/gist_id}","starred_url":"https://api.github.com/users/nimishjha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimishjha/subscriptions","organizations_url":"https://api.github.com/users/nimishjha/orgs","repos_url":"https://api.github.com/users/nimishjha/repos","events_url":"https://api.github.com/users/nimishjha/events{/privacy}","received_events_url":"https://api.github.com/users/nimishjha/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- A few sentences describing the overall goals of the pull request's commit. -->\r\n\r\n## Motivation and Background Context\r\n\r\nhttps://github.com/Adslot/adslot-ui/issues/700\r\nhttps://adslot.atlassian.net/browse/ADS-1046\r\n\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## Does this PR introduce a breaking change?\r\n<!--- If this PR contains a breaking change, please describe the impact and migration path for existing applications. -->\r\n\r\n- [ ] Yes\r\n- [ ] No\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Check-list:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] I have read the [Contributing](CONTRIBUTING.md) document.\r\n- [ ] I've thought about and labelled my PR/commit message appropriately.\r\n- [ ] If this PR introduces breaking changes I've described the impact and migration path for existing applications.\r\n- [ ] CI is green (coverage, linting, tests).\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I've two LGTMs/Approvals.\r\n- [ ] I've fixed or replied to all my code-review comments.\r\n- [ ] I've manually tested with a buddy.\r\n- [ ] I've squashed my commits into one.\r\n","created_at":"2018-05-02T23:50:56Z","updated_at":"2018-05-08T00:37:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b4852c6731ef615b9587425628f69a7ae0e0652","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Adslot/adslot-ui/pulls/716/commits","review_comments_url":"https://api.github.com/repos/Adslot/adslot-ui/pulls/716/comments","review_comment_url":"https://api.github.com/repos/Adslot/adslot-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Adslot/adslot-ui/issues/716/comments","statuses_url":"https://api.github.com/repos/Adslot/adslot-ui/statuses/c2f072d4432299a66648307ec1ee51ea228b90b9","head":{"label":"Adslot:nj-icheck-replacement","ref":"nj-icheck-replacement","sha":"c2f072d4432299a66648307ec1ee51ea228b90b9","user":{"login":"Adslot","id":767098,"avatar_url":"https://avatars0.githubusercontent.com/u/767098?v=4","gravatar_id":"","url":"https://api.github.com/users/Adslot","html_url":"https://github.com/Adslot","followers_url":"https://api.github.com/users/Adslot/followers","following_url":"https://api.github.com/users/Adslot/following{/other_user}","gists_url":"https://api.github.com/users/Adslot/gists{/gist_id}","starred_url":"https://api.github.com/users/Adslot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adslot/subscriptions","organizations_url":"https://api.github.com/users/Adslot/orgs","repos_url":"https://api.github.com/users/Adslot/repos","events_url":"https://api.github.com/users/Adslot/events{/privacy}","received_events_url":"https://api.github.com/users/Adslot/received_events","type":"Organization","site_admin":false},"repo":{"id":45156258,"name":"adslot-ui","full_name":"Adslot/adslot-ui","owner":{"login":"Adslot","id":767098,"avatar_url":"https://avatars0.githubusercontent.com/u/767098?v=4","gravatar_id":"","url":"https://api.github.com/users/Adslot","html_url":"https://github.com/Adslot","followers_url":"https://api.github.com/users/Adslot/followers","following_url":"https://api.github.com/users/Adslot/following{/other_user}","gists_url":"https://api.github.com/users/Adslot/gists{/gist_id}","starred_url":"https://api.github.com/users/Adslot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adslot/subscriptions","organizations_url":"https://api.github.com/users/Adslot/orgs","repos_url":"https://api.github.com/users/Adslot/repos","events_url":"https://api.github.com/users/Adslot/events{/privacy}","received_events_url":"https://api.github.com/users/Adslot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Adslot/adslot-ui","description":"Core component library. By Adslot","fork":false,"url":"https://api.github.com/repos/Adslot/adslot-ui","forks_url":"https://api.github.com/repos/Adslot/adslot-ui/forks","keys_url":"https://api.github.com/repos/Adslot/adslot-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Adslot/adslot-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Adslot/adslot-ui/teams","hooks_url":"https://api.github.com/repos/Adslot/adslot-ui/hooks","issue_events_url":"https://api.github.com/repos/Adslot/adslot-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Adslot/adslot-ui/events","assignees_url":"https://api.github.com/repos/Adslot/adslot-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Adslot/adslot-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Adslot/adslot-ui/tags","blobs_url":"https://api.github.com/repos/Adslot/adslot-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Adslot/adslot-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Adslot/adslot-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Adslot/adslot-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Adslot/adslot-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Adslot/adslot-ui/languages","stargazers_url":"https://api.github.com/repos/Adslot/adslot-ui/stargazers","contributors_url":"https://api.github.com/repos/Adslot/adslot-ui/contributors","subscribers_url":"https://api.github.com/repos/Adslot/adslot-ui/subscribers","subscription_url":"https://api.github.com/repos/Adslot/adslot-ui/subscription","commits_url":"https://api.github.com/repos/Adslot/adslot-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Adslot/adslot-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Adslot/adslot-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Adslot/adslot-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Adslot/adslot-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Adslot/adslot-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Adslot/adslot-ui/merges","archive_url":"https://api.github.com/repos/Adslot/adslot-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Adslot/adslot-ui/downloads","issues_url":"https://api.github.com/repos/Adslot/adslot-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Adslot/adslot-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Adslot/adslot-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Adslot/adslot-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Adslot/adslot-ui/labels{/name}","releases_url":"https://api.github.com/repos/Adslot/adslot-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Adslot/adslot-ui/deployments","created_at":"2015-10-29T02:51:12Z","updated_at":"2018-05-07T05:32:24Z","pushed_at":"2018-05-07T23:52:22Z","git_url":"git://github.com/Adslot/adslot-ui.git","ssh_url":"git@github.com:Adslot/adslot-ui.git","clone_url":"https://github.com/Adslot/adslot-ui.git","svn_url":"https://github.com/Adslot/adslot-ui","homepage":"https://adslot.github.io/adslot-ui/","size":14282,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":17,"license":null,"forks":4,"open_issues":17,"watchers":14,"default_branch":"master"}},"base":{"label":"Adslot:master","ref":"master","sha":"b3149067d56a6d06e44276d267adc1175bcf55da","user":{"login":"Adslot","id":767098,"avatar_url":"https://avatars0.githubusercontent.com/u/767098?v=4","gravatar_id":"","url":"https://api.github.com/users/Adslot","html_url":"https://github.com/Adslot","followers_url":"https://api.github.com/users/Adslot/followers","following_url":"https://api.github.com/users/Adslot/following{/other_user}","gists_url":"https://api.github.com/users/Adslot/gists{/gist_id}","starred_url":"https://api.github.com/users/Adslot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adslot/subscriptions","organizations_url":"https://api.github.com/users/Adslot/orgs","repos_url":"https://api.github.com/users/Adslot/repos","events_url":"https://api.github.com/users/Adslot/events{/privacy}","received_events_url":"https://api.github.com/users/Adslot/received_events","type":"Organization","site_admin":false},"repo":{"id":45156258,"name":"adslot-ui","full_name":"Adslot/adslot-ui","owner":{"login":"Adslot","id":767098,"avatar_url":"https://avatars0.githubusercontent.com/u/767098?v=4","gravatar_id":"","url":"https://api.github.com/users/Adslot","html_url":"https://github.com/Adslot","followers_url":"https://api.github.com/users/Adslot/followers","following_url":"https://api.github.com/users/Adslot/following{/other_user}","gists_url":"https://api.github.com/users/Adslot/gists{/gist_id}","starred_url":"https://api.github.com/users/Adslot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adslot/subscriptions","organizations_url":"https://api.github.com/users/Adslot/orgs","repos_url":"https://api.github.com/users/Adslot/repos","events_url":"https://api.github.com/users/Adslot/events{/privacy}","received_events_url":"https://api.github.com/users/Adslot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Adslot/adslot-ui","description":"Core component library. By Adslot","fork":false,"url":"https://api.github.com/repos/Adslot/adslot-ui","forks_url":"https://api.github.com/repos/Adslot/adslot-ui/forks","keys_url":"https://api.github.com/repos/Adslot/adslot-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Adslot/adslot-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Adslot/adslot-ui/teams","hooks_url":"https://api.github.com/repos/Adslot/adslot-ui/hooks","issue_events_url":"https://api.github.com/repos/Adslot/adslot-ui/issues/events{/number}","events_url":"https://api.github.com/repos/Adslot/adslot-ui/events","assignees_url":"https://api.github.com/repos/Adslot/adslot-ui/assignees{/user}","branches_url":"https://api.github.com/repos/Adslot/adslot-ui/branches{/branch}","tags_url":"https://api.github.com/repos/Adslot/adslot-ui/tags","blobs_url":"https://api.github.com/repos/Adslot/adslot-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Adslot/adslot-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Adslot/adslot-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Adslot/adslot-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Adslot/adslot-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Adslot/adslot-ui/languages","stargazers_url":"https://api.github.com/repos/Adslot/adslot-ui/stargazers","contributors_url":"https://api.github.com/repos/Adslot/adslot-ui/contributors","subscribers_url":"https://api.github.com/repos/Adslot/adslot-ui/subscribers","subscription_url":"https://api.github.com/repos/Adslot/adslot-ui/subscription","commits_url":"https://api.github.com/repos/Adslot/adslot-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Adslot/adslot-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Adslot/adslot-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Adslot/adslot-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Adslot/adslot-ui/contents/{+path}","compare_url":"https://api.github.com/repos/Adslot/adslot-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Adslot/adslot-ui/merges","archive_url":"https://api.github.com/repos/Adslot/adslot-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Adslot/adslot-ui/downloads","issues_url":"https://api.github.com/repos/Adslot/adslot-ui/issues{/number}","pulls_url":"https://api.github.com/repos/Adslot/adslot-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Adslot/adslot-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Adslot/adslot-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Adslot/adslot-ui/labels{/name}","releases_url":"https://api.github.com/repos/Adslot/adslot-ui/releases{/id}","deployments_url":"https://api.github.com/repos/Adslot/adslot-ui/deployments","created_at":"2015-10-29T02:51:12Z","updated_at":"2018-05-07T05:32:24Z","pushed_at":"2018-05-07T23:52:22Z","git_url":"git://github.com/Adslot/adslot-ui.git","ssh_url":"git@github.com:Adslot/adslot-ui.git","clone_url":"https://github.com/Adslot/adslot-ui.git","svn_url":"https://github.com/Adslot/adslot-ui","homepage":"https://adslot.github.io/adslot-ui/","size":14282,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":17,"license":null,"forks":4,"open_issues":17,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Adslot/adslot-ui/pulls/716"},"html":{"href":"https://github.com/Adslot/adslot-ui/pull/716"},"issue":{"href":"https://api.github.com/repos/Adslot/adslot-ui/issues/716"},"comments":{"href":"https://api.github.com/repos/Adslot/adslot-ui/issues/716/comments"},"review_comments":{"href":"https://api.github.com/repos/Adslot/adslot-ui/pulls/716/comments"},"review_comment":{"href":"https://api.github.com/repos/Adslot/adslot-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Adslot/adslot-ui/pulls/716/commits"},"statuses":{"href":"https://api.github.com/repos/Adslot/adslot-ui/statuses/c2f072d4432299a66648307ec1ee51ea228b90b9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mdotwills"}}