{"action":"created","comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/pulls/comments/169183210","pull_request_review_id":97669112,"id":169183210,"diff_hunk":"@@ -189,3 +189,14 @@ TRIBITS_ADD_EXECUTABLE_AND_TEST(\n   NUM_MPI_PROCS 2-10\n   STANDARD_PASS_OUTPUT\n   )\n+\n+\n+TRIBITS_ADD_EXECUTABLE_AND_TEST(\n+  Map_getMinGlobalIndex\n+  SOURCES\n+    Map_getMinGlobalIndex\n+    ${TEUCHOS_STD_UNIT_TEST_MAIN}\n+  COMM mpi\n+  NUM_MPI_PROCS 4","path":"packages/tpetra/core/test/Map/CMakeLists.txt","position":null,"original_position":12,"commit_id":"4fb6a8afcfccf6cf543d4a8bfca0df7797803426","original_commit_id":"892a13abf61a643c8080475b7d3bfc019b2e2381","user":{"login":"lucbv","id":22935531,"avatar_url":"https://avatars0.githubusercontent.com/u/22935531?v=4","gravatar_id":"","url":"https://api.github.com/users/lucbv","html_url":"https://github.com/lucbv","followers_url":"https://api.github.com/users/lucbv/followers","following_url":"https://api.github.com/users/lucbv/following{/other_user}","gists_url":"https://api.github.com/users/lucbv/gists{/gist_id}","starred_url":"https://api.github.com/users/lucbv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucbv/subscriptions","organizations_url":"https://api.github.com/users/lucbv/orgs","repos_url":"https://api.github.com/users/lucbv/repos","events_url":"https://api.github.com/users/lucbv/events{/privacy}","received_events_url":"https://api.github.com/users/lucbv/received_events","type":"User","site_admin":false},"body":"I made the change and I tested going from 1 to 4 mpi ranks. It works fine now.","created_at":"2018-02-19T22:31:57Z","updated_at":"2018-02-19T22:31:57Z","html_url":"https://github.com/trilinos/Trilinos/pull/2251#discussion_r169183210","pull_request_url":"https://api.github.com/repos/trilinos/Trilinos/pulls/2251","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/comments/169183210"},"html":{"href":"https://github.com/trilinos/Trilinos/pull/2251#discussion_r169183210"},"pull_request":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/2251"}},"in_reply_to_id":169171424},"pull_request":{"url":"https://api.github.com/repos/trilinos/Trilinos/pulls/2251","id":169867406,"html_url":"https://github.com/trilinos/Trilinos/pull/2251","diff_url":"https://github.com/trilinos/Trilinos/pull/2251.diff","patch_url":"https://github.com/trilinos/Trilinos/pull/2251.patch","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/2251","number":2251,"state":"open","locked":false,"title":"[WIP] Tpetra map get min global index","user":{"login":"lucbv","id":22935531,"avatar_url":"https://avatars0.githubusercontent.com/u/22935531?v=4","gravatar_id":"","url":"https://api.github.com/users/lucbv","html_url":"https://github.com/lucbv","followers_url":"https://api.github.com/users/lucbv/followers","following_url":"https://api.github.com/users/lucbv/following{/other_user}","gists_url":"https://api.github.com/users/lucbv/gists{/gist_id}","starred_url":"https://api.github.com/users/lucbv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucbv/subscriptions","organizations_url":"https://api.github.com/users/lucbv/orgs","repos_url":"https://api.github.com/users/lucbv/repos","events_url":"https://api.github.com/users/lucbv/events{/privacy}","received_events_url":"https://api.github.com/users/lucbv/received_events","type":"User","site_admin":false},"body":"Change in the behavior of Tpetra map when a process holds no GID. The goal is to provide more logical returns from `getMinAllGlobalIndex()`\r\n\r\n\r\n@trilinos/tpetra \r\n\r\n<!---\r\nLables:  Choose any applicable package names from the Labels drop-down on the\r\nright.  Additionally, choose a label to indicate the type of issue, for\r\ninstance, bug, build, documentation, enhancement, etc.\r\n-->\r\n\r\n## Description\r\nChange `minMyGID_` value to `Teuchos::OrdinalTraits<GlobalOrdinal>::max()` when a rank holds no GIDs.\r\n\r\n## Motivation and Context\r\nThe current behavior is not logical and block repartitioning algorithm for `Xpetra::BlockedMatrix`\r\n\r\n## Related Issues\r\n* Closes  #2250 \r\n\r\n\r\n## Checklist\r\n- [ ] My commit messages mention the appropriate GitHub issue numbers.\r\n- [ ] My code follows the code style of the affected package(s).\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n- [ ] No new compiler warnings were introduced.\r\n- [ ] These changes break backwards compatibility.","created_at":"2018-02-19T02:22:58Z","updated_at":"2018-02-19T22:31:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dcc33e3ad87a03bbdd2a5643e340e8df59ef549","assignee":{"login":"lucbv","id":22935531,"avatar_url":"https://avatars0.githubusercontent.com/u/22935531?v=4","gravatar_id":"","url":"https://api.github.com/users/lucbv","html_url":"https://github.com/lucbv","followers_url":"https://api.github.com/users/lucbv/followers","following_url":"https://api.github.com/users/lucbv/following{/other_user}","gists_url":"https://api.github.com/users/lucbv/gists{/gist_id}","starred_url":"https://api.github.com/users/lucbv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucbv/subscriptions","organizations_url":"https://api.github.com/users/lucbv/orgs","repos_url":"https://api.github.com/users/lucbv/repos","events_url":"https://api.github.com/users/lucbv/events{/privacy}","received_events_url":"https://api.github.com/users/lucbv/received_events","type":"User","site_admin":false},"assignees":[{"login":"lucbv","id":22935531,"avatar_url":"https://avatars0.githubusercontent.com/u/22935531?v=4","gravatar_id":"","url":"https://api.github.com/users/lucbv","html_url":"https://github.com/lucbv","followers_url":"https://api.github.com/users/lucbv/followers","following_url":"https://api.github.com/users/lucbv/following{/other_user}","gists_url":"https://api.github.com/users/lucbv/gists{/gist_id}","starred_url":"https://api.github.com/users/lucbv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucbv/subscriptions","organizations_url":"https://api.github.com/users/lucbv/orgs","repos_url":"https://api.github.com/users/lucbv/repos","events_url":"https://api.github.com/users/lucbv/events{/privacy}","received_events_url":"https://api.github.com/users/lucbv/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"csiefer2","id":8304471,"avatar_url":"https://avatars0.githubusercontent.com/u/8304471?v=4","gravatar_id":"","url":"https://api.github.com/users/csiefer2","html_url":"https://github.com/csiefer2","followers_url":"https://api.github.com/users/csiefer2/followers","following_url":"https://api.github.com/users/csiefer2/following{/other_user}","gists_url":"https://api.github.com/users/csiefer2/gists{/gist_id}","starred_url":"https://api.github.com/users/csiefer2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csiefer2/subscriptions","organizations_url":"https://api.github.com/users/csiefer2/orgs","repos_url":"https://api.github.com/users/csiefer2/repos","events_url":"https://api.github.com/users/csiefer2/events{/privacy}","received_events_url":"https://api.github.com/users/csiefer2/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":289606028,"url":"https://api.github.com/repos/trilinos/Trilinos/labels/Tpetra","name":"Tpetra","color":"5319e7","default":false},{"id":732061788,"url":"https://api.github.com/repos/trilinos/Trilinos/labels/TpetraRF","name":"TpetraRF","color":"f9d0c4","default":false},{"id":287520103,"url":"https://api.github.com/repos/trilinos/Trilinos/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/trilinos/Trilinos/pulls/2251/commits","review_comments_url":"https://api.github.com/repos/trilinos/Trilinos/pulls/2251/comments","review_comment_url":"https://api.github.com/repos/trilinos/Trilinos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/2251/comments","statuses_url":"https://api.github.com/repos/trilinos/Trilinos/statuses/4fb6a8afcfccf6cf543d4a8bfca0df7797803426","head":{"label":"trilinos:Tpetra_map_getMinGlobalIndex","ref":"Tpetra_map_getMinGlobalIndex","sha":"4fb6a8afcfccf6cf543d4a8bfca0df7797803426","user":{"login":"trilinos","id":8566498,"avatar_url":"https://avatars1.githubusercontent.com/u/8566498?v=4","gravatar_id":"","url":"https://api.github.com/users/trilinos","html_url":"https://github.com/trilinos","followers_url":"https://api.github.com/users/trilinos/followers","following_url":"https://api.github.com/users/trilinos/following{/other_user}","gists_url":"https://api.github.com/users/trilinos/gists{/gist_id}","starred_url":"https://api.github.com/users/trilinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trilinos/subscriptions","organizations_url":"https://api.github.com/users/trilinos/orgs","repos_url":"https://api.github.com/users/trilinos/repos","events_url":"https://api.github.com/users/trilinos/events{/privacy}","received_events_url":"https://api.github.com/users/trilinos/received_events","type":"Organization","site_admin":false},"repo":{"id":46297649,"name":"Trilinos","full_name":"trilinos/Trilinos","owner":{"login":"trilinos","id":8566498,"avatar_url":"https://avatars1.githubusercontent.com/u/8566498?v=4","gravatar_id":"","url":"https://api.github.com/users/trilinos","html_url":"https://github.com/trilinos","followers_url":"https://api.github.com/users/trilinos/followers","following_url":"https://api.github.com/users/trilinos/following{/other_user}","gists_url":"https://api.github.com/users/trilinos/gists{/gist_id}","starred_url":"https://api.github.com/users/trilinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trilinos/subscriptions","organizations_url":"https://api.github.com/users/trilinos/orgs","repos_url":"https://api.github.com/users/trilinos/repos","events_url":"https://api.github.com/users/trilinos/events{/privacy}","received_events_url":"https://api.github.com/users/trilinos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trilinos/Trilinos","description":"Primary repository for the Trilinos Project","fork":false,"url":"https://api.github.com/repos/trilinos/Trilinos","forks_url":"https://api.github.com/repos/trilinos/Trilinos/forks","keys_url":"https://api.github.com/repos/trilinos/Trilinos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trilinos/Trilinos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trilinos/Trilinos/teams","hooks_url":"https://api.github.com/repos/trilinos/Trilinos/hooks","issue_events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/events{/number}","events_url":"https://api.github.com/repos/trilinos/Trilinos/events","assignees_url":"https://api.github.com/repos/trilinos/Trilinos/assignees{/user}","branches_url":"https://api.github.com/repos/trilinos/Trilinos/branches{/branch}","tags_url":"https://api.github.com/repos/trilinos/Trilinos/tags","blobs_url":"https://api.github.com/repos/trilinos/Trilinos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trilinos/Trilinos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trilinos/Trilinos/git/refs{/sha}","trees_url":"https://api.github.com/repos/trilinos/Trilinos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trilinos/Trilinos/statuses/{sha}","languages_url":"https://api.github.com/repos/trilinos/Trilinos/languages","stargazers_url":"https://api.github.com/repos/trilinos/Trilinos/stargazers","contributors_url":"https://api.github.com/repos/trilinos/Trilinos/contributors","subscribers_url":"https://api.github.com/repos/trilinos/Trilinos/subscribers","subscription_url":"https://api.github.com/repos/trilinos/Trilinos/subscription","commits_url":"https://api.github.com/repos/trilinos/Trilinos/commits{/sha}","git_commits_url":"https://api.github.com/repos/trilinos/Trilinos/git/commits{/sha}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/comments{/number}","issue_comment_url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments{/number}","contents_url":"https://api.github.com/repos/trilinos/Trilinos/contents/{+path}","compare_url":"https://api.github.com/repos/trilinos/Trilinos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trilinos/Trilinos/merges","archive_url":"https://api.github.com/repos/trilinos/Trilinos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trilinos/Trilinos/downloads","issues_url":"https://api.github.com/repos/trilinos/Trilinos/issues{/number}","pulls_url":"https://api.github.com/repos/trilinos/Trilinos/pulls{/number}","milestones_url":"https://api.github.com/repos/trilinos/Trilinos/milestones{/number}","notifications_url":"https://api.github.com/repos/trilinos/Trilinos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trilinos/Trilinos/labels{/name}","releases_url":"https://api.github.com/repos/trilinos/Trilinos/releases{/id}","deployments_url":"https://api.github.com/repos/trilinos/Trilinos/deployments","created_at":"2015-11-16T19:39:16Z","updated_at":"2018-02-12T13:38:30Z","pushed_at":"2018-02-19T22:08:30Z","git_url":"git://github.com/trilinos/Trilinos.git","ssh_url":"git@github.com:trilinos/Trilinos.git","clone_url":"https://github.com/trilinos/Trilinos.git","svn_url":"https://github.com/trilinos/Trilinos","homepage":"https://trilinos.org/","size":441760,"stargazers_count":225,"watchers_count":225,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":167,"mirror_url":null,"archived":false,"open_issues_count":671,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":167,"open_issues":671,"watchers":225,"default_branch":"master"}},"base":{"label":"trilinos:develop","ref":"develop","sha":"d9b5059d34b007158cce8a03b064698546aeefa1","user":{"login":"trilinos","id":8566498,"avatar_url":"https://avatars1.githubusercontent.com/u/8566498?v=4","gravatar_id":"","url":"https://api.github.com/users/trilinos","html_url":"https://github.com/trilinos","followers_url":"https://api.github.com/users/trilinos/followers","following_url":"https://api.github.com/users/trilinos/following{/other_user}","gists_url":"https://api.github.com/users/trilinos/gists{/gist_id}","starred_url":"https://api.github.com/users/trilinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trilinos/subscriptions","organizations_url":"https://api.github.com/users/trilinos/orgs","repos_url":"https://api.github.com/users/trilinos/repos","events_url":"https://api.github.com/users/trilinos/events{/privacy}","received_events_url":"https://api.github.com/users/trilinos/received_events","type":"Organization","site_admin":false},"repo":{"id":46297649,"name":"Trilinos","full_name":"trilinos/Trilinos","owner":{"login":"trilinos","id":8566498,"avatar_url":"https://avatars1.githubusercontent.com/u/8566498?v=4","gravatar_id":"","url":"https://api.github.com/users/trilinos","html_url":"https://github.com/trilinos","followers_url":"https://api.github.com/users/trilinos/followers","following_url":"https://api.github.com/users/trilinos/following{/other_user}","gists_url":"https://api.github.com/users/trilinos/gists{/gist_id}","starred_url":"https://api.github.com/users/trilinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trilinos/subscriptions","organizations_url":"https://api.github.com/users/trilinos/orgs","repos_url":"https://api.github.com/users/trilinos/repos","events_url":"https://api.github.com/users/trilinos/events{/privacy}","received_events_url":"https://api.github.com/users/trilinos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trilinos/Trilinos","description":"Primary repository for the Trilinos Project","fork":false,"url":"https://api.github.com/repos/trilinos/Trilinos","forks_url":"https://api.github.com/repos/trilinos/Trilinos/forks","keys_url":"https://api.github.com/repos/trilinos/Trilinos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trilinos/Trilinos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trilinos/Trilinos/teams","hooks_url":"https://api.github.com/repos/trilinos/Trilinos/hooks","issue_events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/events{/number}","events_url":"https://api.github.com/repos/trilinos/Trilinos/events","assignees_url":"https://api.github.com/repos/trilinos/Trilinos/assignees{/user}","branches_url":"https://api.github.com/repos/trilinos/Trilinos/branches{/branch}","tags_url":"https://api.github.com/repos/trilinos/Trilinos/tags","blobs_url":"https://api.github.com/repos/trilinos/Trilinos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trilinos/Trilinos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trilinos/Trilinos/git/refs{/sha}","trees_url":"https://api.github.com/repos/trilinos/Trilinos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trilinos/Trilinos/statuses/{sha}","languages_url":"https://api.github.com/repos/trilinos/Trilinos/languages","stargazers_url":"https://api.github.com/repos/trilinos/Trilinos/stargazers","contributors_url":"https://api.github.com/repos/trilinos/Trilinos/contributors","subscribers_url":"https://api.github.com/repos/trilinos/Trilinos/subscribers","subscription_url":"https://api.github.com/repos/trilinos/Trilinos/subscription","commits_url":"https://api.github.com/repos/trilinos/Trilinos/commits{/sha}","git_commits_url":"https://api.github.com/repos/trilinos/Trilinos/git/commits{/sha}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/comments{/number}","issue_comment_url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments{/number}","contents_url":"https://api.github.com/repos/trilinos/Trilinos/contents/{+path}","compare_url":"https://api.github.com/repos/trilinos/Trilinos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trilinos/Trilinos/merges","archive_url":"https://api.github.com/repos/trilinos/Trilinos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trilinos/Trilinos/downloads","issues_url":"https://api.github.com/repos/trilinos/Trilinos/issues{/number}","pulls_url":"https://api.github.com/repos/trilinos/Trilinos/pulls{/number}","milestones_url":"https://api.github.com/repos/trilinos/Trilinos/milestones{/number}","notifications_url":"https://api.github.com/repos/trilinos/Trilinos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trilinos/Trilinos/labels{/name}","releases_url":"https://api.github.com/repos/trilinos/Trilinos/releases{/id}","deployments_url":"https://api.github.com/repos/trilinos/Trilinos/deployments","created_at":"2015-11-16T19:39:16Z","updated_at":"2018-02-12T13:38:30Z","pushed_at":"2018-02-19T22:08:30Z","git_url":"git://github.com/trilinos/Trilinos.git","ssh_url":"git@github.com:trilinos/Trilinos.git","clone_url":"https://github.com/trilinos/Trilinos.git","svn_url":"https://github.com/trilinos/Trilinos","homepage":"https://trilinos.org/","size":441760,"stargazers_count":225,"watchers_count":225,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":167,"mirror_url":null,"archived":false,"open_issues_count":671,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":167,"open_issues":671,"watchers":225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/2251"},"html":{"href":"https://github.com/trilinos/Trilinos/pull/2251"},"issue":{"href":"https://api.github.com/repos/trilinos/Trilinos/issues/2251"},"comments":{"href":"https://api.github.com/repos/trilinos/Trilinos/issues/2251/comments"},"review_comments":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/2251/comments"},"review_comment":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/2251/commits"},"statuses":{"href":"https://api.github.com/repos/trilinos/Trilinos/statuses/4fb6a8afcfccf6cf543d4a8bfca0df7797803426"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lucbv"}}