{"action":"created","comment":{"url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/pulls/comments/243375479","pull_request_review_id":187129636,"id":243375479,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzM3NTQ3OQ==","diff_hunk":"@@ -81,8 +83,8 @@ def sort_app(organize_by, app_list):\n             organized_app_list['All apps'].append(app)\n     else:\n         for app in app_list:    \n-            if app.get(organize_by) is not None:\n-                # check if it already exisits in the organized_app_list dictionary.\n+            if len(app.get(organize_by)) > 0:\n+                # list of categories/developers/modules associated with the app.\n                 items = app.get(organize_by)","path":"index.py","position":53,"original_position":53,"commit_id":"3034df5d459f6f1ad9feb84308863df336c79e7b","original_commit_id":"3034df5d459f6f1ad9feb84308863df336c79e7b","user":{"login":"briehl","id":2152243,"node_id":"MDQ6VXNlcjIxNTIyNDM=","avatar_url":"https://avatars1.githubusercontent.com/u/2152243?v=4","gravatar_id":"","url":"https://api.github.com/users/briehl","html_url":"https://github.com/briehl","followers_url":"https://api.github.com/users/briehl/followers","following_url":"https://api.github.com/users/briehl/following{/other_user}","gists_url":"https://api.github.com/users/briehl/gists{/gist_id}","starred_url":"https://api.github.com/users/briehl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briehl/subscriptions","organizations_url":"https://api.github.com/users/briehl/orgs","repos_url":"https://api.github.com/users/briehl/repos","events_url":"https://api.github.com/users/briehl/events{/privacy}","received_events_url":"https://api.github.com/users/briehl/received_events","type":"User","site_admin":false},"body":"Same as above - best to return a default empty list (or something that will fail as expected when doing a comparison on it)","created_at":"2018-12-20T18:36:24Z","updated_at":"2018-12-20T18:54:00Z","html_url":"https://github.com/kbase/KbaseAppCatalogStatic/pull/5#discussion_r243375479","pull_request_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/pulls/5","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/pulls/comments/243375479"},"html":{"href":"https://github.com/kbase/KbaseAppCatalogStatic/pull/5#discussion_r243375479"},"pull_request":{"href":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/pulls/5","id":240262993,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjYyOTkz","html_url":"https://github.com/kbase/KbaseAppCatalogStatic/pull/5","diff_url":"https://github.com/kbase/KbaseAppCatalogStatic/pull/5.diff","patch_url":"https://github.com/kbase/KbaseAppCatalogStatic/pull/5.patch","issue_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/issues/5","number":5,"state":"open","locked":false,"title":"App page","user":{"login":"FlyingUnicornSF","id":28878010,"node_id":"MDQ6VXNlcjI4ODc4MDEw","avatar_url":"https://avatars3.githubusercontent.com/u/28878010?v=4","gravatar_id":"","url":"https://api.github.com/users/FlyingUnicornSF","html_url":"https://github.com/FlyingUnicornSF","followers_url":"https://api.github.com/users/FlyingUnicornSF/followers","following_url":"https://api.github.com/users/FlyingUnicornSF/following{/other_user}","gists_url":"https://api.github.com/users/FlyingUnicornSF/gists{/gist_id}","starred_url":"https://api.github.com/users/FlyingUnicornSF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlyingUnicornSF/subscriptions","organizations_url":"https://api.github.com/users/FlyingUnicornSF/orgs","repos_url":"https://api.github.com/users/FlyingUnicornSF/repos","events_url":"https://api.github.com/users/FlyingUnicornSF/events{/privacy}","received_events_url":"https://api.github.com/users/FlyingUnicornSF/received_events","type":"User","site_admin":false},"body":"added app page.  It should look almost exactly like https://narrative.kbase.us/#catalog/apps/<app_id>\r\nusing base.html template to use the same header for both catalog template (index.html) and app page template (app_page.html). ","created_at":"2018-12-20T18:30:06Z","updated_at":"2018-12-20T18:54:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f64af688bcae4cdf888b057036d8af6059ba323d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/pulls/5/commits","review_comments_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/pulls/5/comments","review_comment_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/issues/5/comments","statuses_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/statuses/3034df5d459f6f1ad9feb84308863df336c79e7b","head":{"label":"kbase:appPage","ref":"appPage","sha":"3034df5d459f6f1ad9feb84308863df336c79e7b","user":{"login":"kbase","id":1263946,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjM5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1263946?v=4","gravatar_id":"","url":"https://api.github.com/users/kbase","html_url":"https://github.com/kbase","followers_url":"https://api.github.com/users/kbase/followers","following_url":"https://api.github.com/users/kbase/following{/other_user}","gists_url":"https://api.github.com/users/kbase/gists{/gist_id}","starred_url":"https://api.github.com/users/kbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbase/subscriptions","organizations_url":"https://api.github.com/users/kbase/orgs","repos_url":"https://api.github.com/users/kbase/repos","events_url":"https://api.github.com/users/kbase/events{/privacy}","received_events_url":"https://api.github.com/users/kbase/received_events","type":"Organization","site_admin":false},"repo":{"id":160894678,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA4OTQ2Nzg=","name":"KbaseAppCatalogStatic","full_name":"kbase/KbaseAppCatalogStatic","private":false,"owner":{"login":"kbase","id":1263946,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjM5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1263946?v=4","gravatar_id":"","url":"https://api.github.com/users/kbase","html_url":"https://github.com/kbase","followers_url":"https://api.github.com/users/kbase/followers","following_url":"https://api.github.com/users/kbase/following{/other_user}","gists_url":"https://api.github.com/users/kbase/gists{/gist_id}","starred_url":"https://api.github.com/users/kbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbase/subscriptions","organizations_url":"https://api.github.com/users/kbase/orgs","repos_url":"https://api.github.com/users/kbase/repos","events_url":"https://api.github.com/users/kbase/events{/privacy}","received_events_url":"https://api.github.com/users/kbase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kbase/KbaseAppCatalogStatic","description":null,"fork":false,"url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic","forks_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/forks","keys_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/teams","hooks_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/hooks","issue_events_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/issues/events{/number}","events_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/events","assignees_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/assignees{/user}","branches_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/branches{/branch}","tags_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/tags","blobs_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/statuses/{sha}","languages_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/languages","stargazers_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/stargazers","contributors_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/contributors","subscribers_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/subscribers","subscription_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/subscription","commits_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/contents/{+path}","compare_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/merges","archive_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/downloads","issues_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/issues{/number}","pulls_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/pulls{/number}","milestones_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/milestones{/number}","notifications_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/labels{/name}","releases_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/releases{/id}","deployments_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/deployments","created_at":"2018-12-08T02:02:52Z","updated_at":"2018-12-17T23:06:23Z","pushed_at":"2018-12-20T18:30:06Z","git_url":"git://github.com/kbase/KbaseAppCatalogStatic.git","ssh_url":"git@github.com:kbase/KbaseAppCatalogStatic.git","clone_url":"https://github.com/kbase/KbaseAppCatalogStatic.git","svn_url":"https://github.com/kbase/KbaseAppCatalogStatic","homepage":null,"size":34,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"kbase:master","ref":"master","sha":"33438c5d578a1f23e291233e15270fc65e56d40d","user":{"login":"kbase","id":1263946,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjM5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1263946?v=4","gravatar_id":"","url":"https://api.github.com/users/kbase","html_url":"https://github.com/kbase","followers_url":"https://api.github.com/users/kbase/followers","following_url":"https://api.github.com/users/kbase/following{/other_user}","gists_url":"https://api.github.com/users/kbase/gists{/gist_id}","starred_url":"https://api.github.com/users/kbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbase/subscriptions","organizations_url":"https://api.github.com/users/kbase/orgs","repos_url":"https://api.github.com/users/kbase/repos","events_url":"https://api.github.com/users/kbase/events{/privacy}","received_events_url":"https://api.github.com/users/kbase/received_events","type":"Organization","site_admin":false},"repo":{"id":160894678,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA4OTQ2Nzg=","name":"KbaseAppCatalogStatic","full_name":"kbase/KbaseAppCatalogStatic","private":false,"owner":{"login":"kbase","id":1263946,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjM5NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1263946?v=4","gravatar_id":"","url":"https://api.github.com/users/kbase","html_url":"https://github.com/kbase","followers_url":"https://api.github.com/users/kbase/followers","following_url":"https://api.github.com/users/kbase/following{/other_user}","gists_url":"https://api.github.com/users/kbase/gists{/gist_id}","starred_url":"https://api.github.com/users/kbase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbase/subscriptions","organizations_url":"https://api.github.com/users/kbase/orgs","repos_url":"https://api.github.com/users/kbase/repos","events_url":"https://api.github.com/users/kbase/events{/privacy}","received_events_url":"https://api.github.com/users/kbase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kbase/KbaseAppCatalogStatic","description":null,"fork":false,"url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic","forks_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/forks","keys_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/teams","hooks_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/hooks","issue_events_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/issues/events{/number}","events_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/events","assignees_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/assignees{/user}","branches_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/branches{/branch}","tags_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/tags","blobs_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/statuses/{sha}","languages_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/languages","stargazers_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/stargazers","contributors_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/contributors","subscribers_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/subscribers","subscription_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/subscription","commits_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/contents/{+path}","compare_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/merges","archive_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/downloads","issues_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/issues{/number}","pulls_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/pulls{/number}","milestones_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/milestones{/number}","notifications_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/labels{/name}","releases_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/releases{/id}","deployments_url":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/deployments","created_at":"2018-12-08T02:02:52Z","updated_at":"2018-12-17T23:06:23Z","pushed_at":"2018-12-20T18:30:06Z","git_url":"git://github.com/kbase/KbaseAppCatalogStatic.git","ssh_url":"git@github.com:kbase/KbaseAppCatalogStatic.git","clone_url":"https://github.com/kbase/KbaseAppCatalogStatic.git","svn_url":"https://github.com/kbase/KbaseAppCatalogStatic","homepage":null,"size":34,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/pulls/5"},"html":{"href":"https://github.com/kbase/KbaseAppCatalogStatic/pull/5"},"issue":{"href":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/issues/5"},"comments":{"href":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/kbase/KbaseAppCatalogStatic/statuses/3034df5d459f6f1ad9feb84308863df336c79e7b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"briehl"}}