{"action":"created","issue":{"url":"https://api.github.com/repos/hakasenyang/openssl-patch/issues/7","repository_url":"https://api.github.com/repos/hakasenyang/openssl-patch","labels_url":"https://api.github.com/repos/hakasenyang/openssl-patch/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/hakasenyang/openssl-patch/issues/7/comments","events_url":"https://api.github.com/repos/hakasenyang/openssl-patch/issues/7/events","html_url":"https://github.com/hakasenyang/openssl-patch/issues/7","id":367065577,"node_id":"MDU6SXNzdWUzNjcwNjU1Nzc=","number":7,"title":"about \"strict sni\".","user":{"login":"NewBugger","id":41441631,"node_id":"MDQ6VXNlcjQxNDQxNjMx","avatar_url":"https://avatars3.githubusercontent.com/u/41441631?v=4","gravatar_id":"","url":"https://api.github.com/users/NewBugger","html_url":"https://github.com/NewBugger","followers_url":"https://api.github.com/users/NewBugger/followers","following_url":"https://api.github.com/users/NewBugger/following{/other_user}","gists_url":"https://api.github.com/users/NewBugger/gists{/gist_id}","starred_url":"https://api.github.com/users/NewBugger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NewBugger/subscriptions","organizations_url":"https://api.github.com/users/NewBugger/orgs","repos_url":"https://api.github.com/users/NewBugger/repos","events_url":"https://api.github.com/users/NewBugger/events{/privacy}","received_events_url":"https://api.github.com/users/NewBugger/received_events","type":"User","site_admin":false},"labels":[{"id":932056064,"node_id":"MDU6TGFiZWw5MzIwNTYwNjQ=","url":"https://api.github.com/repos/hakasenyang/openssl-patch/labels/question","name":"question","color":"d876e3","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-10-05T05:31:38Z","updated_at":"2018-10-07T10:55:46Z","closed_at":null,"author_association":"NONE","body":"in the [patch](https://github.com/hakasenyang/openssl-patch/blob/master/nginx_strict-sni.patch) , it contains this:\r\n```c\r\ndiff --git a/src/event/ngx_event_openssl.c b/src/event/ngx_event_openssl.c\r\n--- a/src/event/ngx_event_openssl.c    2018-10-02 15:13:36.414143028 +0000\r\n+++ b/src/event/ngx_event_openssl.c    2018-10-04 13:58:28.756873433 +0000\r\n@@ -1456,6 +1456,13 @@ ngx_ssl_handshake(ngx_connection_t *c)\r\n\r\n     c->read->error = 1;\r\n\r\n+\r\n+    if (sslerr == SSL_ERROR_SSL) {\r\n+        ERR_peek_error();\r\n+        ERR_clear_error();\r\n+        return NGX_ERROR;\r\n+    }\r\n+\r\n     ngx_ssl_connection_error(c, sslerr, err, \"SSL_do_handshake() failed\");\r\n\r\nreturn NGX_ERROR;\r\n```\r\n\r\nbut in this [commit](https://github.com/hakasenyang/nginx-build/commit/e3932ebe24b3fc723d6cb041c52ae63876154df9) : \r\n>> Not compatible with ssl_early_data.\r\n\r\ni use BoringSSL and `ssl_early_data on;` directive."},"comment":{"url":"https://api.github.com/repos/hakasenyang/openssl-patch/issues/comments/427643975","html_url":"https://github.com/hakasenyang/openssl-patch/issues/7#issuecomment-427643975","issue_url":"https://api.github.com/repos/hakasenyang/openssl-patch/issues/7","id":427643975,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzY0Mzk3NQ==","user":{"login":"kn007","id":6196903,"node_id":"MDQ6VXNlcjYxOTY5MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/6196903?v=4","gravatar_id":"","url":"https://api.github.com/users/kn007","html_url":"https://github.com/kn007","followers_url":"https://api.github.com/users/kn007/followers","following_url":"https://api.github.com/users/kn007/following{/other_user}","gists_url":"https://api.github.com/users/kn007/gists{/gist_id}","starred_url":"https://api.github.com/users/kn007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kn007/subscriptions","organizations_url":"https://api.github.com/users/kn007/orgs","repos_url":"https://api.github.com/users/kn007/repos","events_url":"https://api.github.com/users/kn007/events{/privacy}","received_events_url":"https://api.github.com/users/kn007/received_events","type":"User","site_admin":false},"created_at":"2018-10-07T10:55:46Z","updated_at":"2018-10-07T10:55:46Z","author_association":"NONE","body":"@hakasenyang I know...\r\nBut don't you need to judge servername?"}}
{"actor":{"display_login":"kn007"}}