{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/18475","repository_url":"https://api.github.com/repos/edx/edx-platform","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/18475/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/18475/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/18475/events","html_url":"https://github.com/edx/edx-platform/pull/18475","id":336316924,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3Nzk4NDQ1","number":18475,"title":"(WIP) Convert instructor email messages to ACE","user":{"login":"OmarIthawi","id":645156,"node_id":"MDQ6VXNlcjY0NTE1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/645156?v=4","gravatar_id":"","url":"https://api.github.com/users/OmarIthawi","html_url":"https://github.com/OmarIthawi","followers_url":"https://api.github.com/users/OmarIthawi/followers","following_url":"https://api.github.com/users/OmarIthawi/following{/other_user}","gists_url":"https://api.github.com/users/OmarIthawi/gists{/gist_id}","starred_url":"https://api.github.com/users/OmarIthawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmarIthawi/subscriptions","organizations_url":"https://api.github.com/users/OmarIthawi/orgs","repos_url":"https://api.github.com/users/OmarIthawi/repos","events_url":"https://api.github.com/users/OmarIthawi/events{/privacy}","received_events_url":"https://api.github.com/users/OmarIthawi/received_events","type":"User","site_admin":false},"labels":[{"id":128413102,"node_id":"MDU6TGFiZWwxMjg0MTMxMDI=","url":"https://api.github.com/repos/edx/edx-platform/labels/awaiting%20prioritization","name":"awaiting prioritization","color":"fad8c7","default":false},{"id":78051711,"node_id":"MDU6TGFiZWw3ODA1MTcxMQ==","url":"https://api.github.com/repos/edx/edx-platform/labels/open-source-contribution","name":"open-source-contribution","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2018-06-27T17:14:23Z","updated_at":"2018-09-13T20:35:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/18475","html_url":"https://github.com/edx/edx-platform/pull/18475","diff_url":"https://github.com/edx/edx-platform/pull/18475.diff","patch_url":"https://github.com/edx/edx-platform/pull/18475.patch"},"body":"Convert instructor email messages to ACE:\r\n\r\n**Caveat:** Due to a shortcoming in ACE, when the username is missing (e.g. for messages that are for emails to unregistered users), the file will be hidden in the in your File Manager `openedx/src/ace_messages/.20180628-195623.html`. Use the command `$ ls -lah` to find it.\r\n\r\n### TODO\r\n\r\n - [x] Make Jenkins happy\r\n - [x] Add tests to the HTML message\r\n - [x] Support CCX messages as well\r\n - [x] Fix the ugly `course_name=display_name|default:course.display_name_with_default` and abstract it somewhere else\r\n - [ ] @nedbat (or anyone from edX) to check with the white-label team before merging this PR\r\n - [ ] Test all of the HTML messages manually:\r\n   * [ ] AccountCreationAndEnrollment\r\n   * [ ] AddBetaTester\r\n   * [x] AllowedEnroll\r\n   * [x] AllowedUnenroll\r\n   * [ ] EnrollEnrolled\r\n   * [ ] EnrolledUnenroll\r\n   * [ ] RemoveBetaTester\r\n - [ ] Move `EmailTemplateTagMixin` into the `mixins.py` file\r\n - [ ] **Question to Reviewer:** What about `test_site` and `stanford-style`?\r\n\r\n### Cheese!\r\n<img src=\"https://user-images.githubusercontent.com/645156/42067159-7be19ece-7b4d-11e8-8f5e-de254a713922.png\" alt=\"image\" style=\"max-width:100%;\" width=\"350\">\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/421144126","html_url":"https://github.com/edx/edx-platform/pull/18475#issuecomment-421144126","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/18475","id":421144126,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTE0NDEyNg==","user":{"login":"OmarIthawi","id":645156,"node_id":"MDQ6VXNlcjY0NTE1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/645156?v=4","gravatar_id":"","url":"https://api.github.com/users/OmarIthawi","html_url":"https://github.com/OmarIthawi","followers_url":"https://api.github.com/users/OmarIthawi/followers","following_url":"https://api.github.com/users/OmarIthawi/following{/other_user}","gists_url":"https://api.github.com/users/OmarIthawi/gists{/gist_id}","starred_url":"https://api.github.com/users/OmarIthawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmarIthawi/subscriptions","organizations_url":"https://api.github.com/users/OmarIthawi/orgs","repos_url":"https://api.github.com/users/OmarIthawi/repos","events_url":"https://api.github.com/users/OmarIthawi/events{/privacy}","received_events_url":"https://api.github.com/users/OmarIthawi/received_events","type":"User","site_admin":false},"created_at":"2018-09-13T20:35:12Z","updated_at":"2018-09-13T20:35:12Z","author_association":"CONTRIBUTOR","body":"### EnrolledUnenroll ACE Message\r\n\r\n<img src=\"https://user-images.githubusercontent.com/645156/45514253-8695f580-b7ad-11e8-8994-7c5c4545a65d.png\" width=\"350\" />\r\n\r\n```\r\n------- EMAIL -------\r\nTo: staff@example.com\r\nFrom: \r\nSubject: You have been unenrolled from edX Demonstration Course\r\nBody:\r\nDear Staff\r\n\r\nYou have been unenrolled from edX Demonstration Course at edx.devstack.lms:18000 by a member of the course staff. This course will no longer appear on your edx.devstack.lms:18000 dashboard.\r\n\r\nYour other courses have not been affected.\r\n\r\n----\r\nThis email was automatically sent from edx.devstack.lms:18000 to Staff\r\n-------  END  -------\r\n```"}}
{"actor":{"display_login":"OmarIthawi"}}