{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tispark/pulls/comments/167462940","pull_request_review_id":95683481,"id":167462940,"diff_hunk":"@@ -106,7 +85,7 @@ public ByteString get(ByteString key) {\n    * @return Row iterator to iterate over resulting rows\n    */\n   public Iterator<Row> tableRead(TiDAGRequest dagRequest, List<RegionTask> task) {\n-    if (dagRequest.isIndexScan()) {\n+    if (dagRequest.isDoubleRead()) {","path":"tikv-client/src/main/java/com/pingcap/tikv/Snapshot.java","position":67,"original_position":67,"commit_id":"df40132356c12bbd4694cd2808af98c4e5dd961a","original_commit_id":"df40132356c12bbd4694cd2808af98c4e5dd961a","user":{"login":"birdstorm","id":15857134,"avatar_url":"https://avatars1.githubusercontent.com/u/15857134?v=4","gravatar_id":"","url":"https://api.github.com/users/birdstorm","html_url":"https://github.com/birdstorm","followers_url":"https://api.github.com/users/birdstorm/followers","following_url":"https://api.github.com/users/birdstorm/following{/other_user}","gists_url":"https://api.github.com/users/birdstorm/gists{/gist_id}","starred_url":"https://api.github.com/users/birdstorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birdstorm/subscriptions","organizations_url":"https://api.github.com/users/birdstorm/orgs","repos_url":"https://api.github.com/users/birdstorm/repos","events_url":"https://api.github.com/users/birdstorm/events{/privacy}","received_events_url":"https://api.github.com/users/birdstorm/received_events","type":"User","site_admin":false},"body":"the condition is changed into `isDoubleRead` because we need `getHandleIterator` only when index double read.","created_at":"2018-02-12T02:53:39Z","updated_at":"2018-02-12T02:53:39Z","html_url":"https://github.com/pingcap/tispark/pull/148#discussion_r167462940","pull_request_url":"https://api.github.com/repos/pingcap/tispark/pulls/148","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tispark/pulls/comments/167462940"},"html":{"href":"https://github.com/pingcap/tispark/pull/148#discussion_r167462940"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tispark/pulls/148"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tispark/pulls/148","id":159631282,"html_url":"https://github.com/pingcap/tispark/pull/148","diff_url":"https://github.com/pingcap/tispark/pull/148.diff","patch_url":"https://github.com/pingcap/tispark/pull/148.patch","issue_url":"https://api.github.com/repos/pingcap/tispark/issues/148","number":148,"state":"open","locked":false,"title":"add support for covering index","user":{"login":"birdstorm","id":15857134,"avatar_url":"https://avatars1.githubusercontent.com/u/15857134?v=4","gravatar_id":"","url":"https://api.github.com/users/birdstorm","html_url":"https://github.com/birdstorm","followers_url":"https://api.github.com/users/birdstorm/followers","following_url":"https://api.github.com/users/birdstorm/following{/other_user}","gists_url":"https://api.github.com/users/birdstorm/gists{/gist_id}","starred_url":"https://api.github.com/users/birdstorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birdstorm/subscriptions","organizations_url":"https://api.github.com/users/birdstorm/orgs","repos_url":"https://api.github.com/users/birdstorm/repos","events_url":"https://api.github.com/users/birdstorm/events{/privacy}","received_events_url":"https://api.github.com/users/birdstorm/received_events","type":"User","site_admin":false},"body":"By using covering index, we can avoid double read and ineffective table scan.\r\n\r\nfor issue #19 ","created_at":"2017-12-21T11:08:09Z","updated_at":"2018-02-12T02:53:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"022f29cc01c9e1465ca0285c671d1772c2832bed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":772309409,"url":"https://api.github.com/repos/pingcap/tispark/labels/work%20in%20progress","name":"work in progress","color":"daf700","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tispark/pulls/148/commits","review_comments_url":"https://api.github.com/repos/pingcap/tispark/pulls/148/comments","review_comment_url":"https://api.github.com/repos/pingcap/tispark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tispark/issues/148/comments","statuses_url":"https://api.github.com/repos/pingcap/tispark/statuses/df40132356c12bbd4694cd2808af98c4e5dd961a","head":{"label":"pingcap:addCoveringIndex","ref":"addCoveringIndex","sha":"df40132356c12bbd4694cd2808af98c4e5dd961a","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":90061538,"name":"tispark","full_name":"pingcap/tispark","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tispark","description":"TiSpark is built for running Apache Spark on top of TiDB/TiKV","fork":false,"url":"https://api.github.com/repos/pingcap/tispark","forks_url":"https://api.github.com/repos/pingcap/tispark/forks","keys_url":"https://api.github.com/repos/pingcap/tispark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tispark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tispark/teams","hooks_url":"https://api.github.com/repos/pingcap/tispark/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tispark/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tispark/events","assignees_url":"https://api.github.com/repos/pingcap/tispark/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tispark/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tispark/tags","blobs_url":"https://api.github.com/repos/pingcap/tispark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tispark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tispark/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tispark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tispark/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tispark/languages","stargazers_url":"https://api.github.com/repos/pingcap/tispark/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tispark/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tispark/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tispark/subscription","commits_url":"https://api.github.com/repos/pingcap/tispark/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tispark/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tispark/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tispark/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tispark/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tispark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tispark/merges","archive_url":"https://api.github.com/repos/pingcap/tispark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tispark/downloads","issues_url":"https://api.github.com/repos/pingcap/tispark/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tispark/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tispark/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tispark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tispark/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tispark/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tispark/deployments","created_at":"2017-05-02T17:48:30Z","updated_at":"2018-02-11T09:26:19Z","pushed_at":"2018-02-12T02:45:47Z","git_url":"git://github.com/pingcap/tispark.git","ssh_url":"git@github.com:pingcap/tispark.git","clone_url":"https://github.com/pingcap/tispark.git","svn_url":"https://github.com/pingcap/tispark","homepage":"","size":22488,"stargazers_count":153,"watchers_count":153,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":30,"open_issues":40,"watchers":153,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"c8a40fa2995fbc3fea7acf327681d8ec22ab92a1","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":90061538,"name":"tispark","full_name":"pingcap/tispark","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tispark","description":"TiSpark is built for running Apache Spark on top of TiDB/TiKV","fork":false,"url":"https://api.github.com/repos/pingcap/tispark","forks_url":"https://api.github.com/repos/pingcap/tispark/forks","keys_url":"https://api.github.com/repos/pingcap/tispark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tispark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tispark/teams","hooks_url":"https://api.github.com/repos/pingcap/tispark/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tispark/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tispark/events","assignees_url":"https://api.github.com/repos/pingcap/tispark/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tispark/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tispark/tags","blobs_url":"https://api.github.com/repos/pingcap/tispark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tispark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tispark/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tispark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tispark/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tispark/languages","stargazers_url":"https://api.github.com/repos/pingcap/tispark/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tispark/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tispark/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tispark/subscription","commits_url":"https://api.github.com/repos/pingcap/tispark/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tispark/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tispark/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tispark/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tispark/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tispark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tispark/merges","archive_url":"https://api.github.com/repos/pingcap/tispark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tispark/downloads","issues_url":"https://api.github.com/repos/pingcap/tispark/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tispark/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tispark/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tispark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tispark/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tispark/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tispark/deployments","created_at":"2017-05-02T17:48:30Z","updated_at":"2018-02-11T09:26:19Z","pushed_at":"2018-02-12T02:45:47Z","git_url":"git://github.com/pingcap/tispark.git","ssh_url":"git@github.com:pingcap/tispark.git","clone_url":"https://github.com/pingcap/tispark.git","svn_url":"https://github.com/pingcap/tispark","homepage":"","size":22488,"stargazers_count":153,"watchers_count":153,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":30,"open_issues":40,"watchers":153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tispark/pulls/148"},"html":{"href":"https://github.com/pingcap/tispark/pull/148"},"issue":{"href":"https://api.github.com/repos/pingcap/tispark/issues/148"},"comments":{"href":"https://api.github.com/repos/pingcap/tispark/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tispark/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tispark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tispark/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tispark/statuses/df40132356c12bbd4694cd2808af98c4e5dd961a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"birdstorm"}}