{"action":"created","issue":{"url":"https://api.github.com/repos/shapenaji/cranium/issues/12","repository_url":"https://api.github.com/repos/shapenaji/cranium","labels_url":"https://api.github.com/repos/shapenaji/cranium/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/shapenaji/cranium/issues/12/comments","events_url":"https://api.github.com/repos/shapenaji/cranium/issues/12/events","html_url":"https://github.com/shapenaji/cranium/pull/12","id":388466779,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NzI2NDc5","number":12,"title":"expose host/port/local path as environment variables","user":{"login":"shapenaji","id":13593075,"node_id":"MDQ6VXNlcjEzNTkzMDc1","avatar_url":"https://avatars2.githubusercontent.com/u/13593075?v=4","gravatar_id":"","url":"https://api.github.com/users/shapenaji","html_url":"https://github.com/shapenaji","followers_url":"https://api.github.com/users/shapenaji/followers","following_url":"https://api.github.com/users/shapenaji/following{/other_user}","gists_url":"https://api.github.com/users/shapenaji/gists{/gist_id}","starred_url":"https://api.github.com/users/shapenaji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shapenaji/subscriptions","organizations_url":"https://api.github.com/users/shapenaji/orgs","repos_url":"https://api.github.com/users/shapenaji/repos","events_url":"https://api.github.com/users/shapenaji/events{/privacy}","received_events_url":"https://api.github.com/users/shapenaji/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-07T01:22:28Z","updated_at":"2018-12-07T03:00:14Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/shapenaji/cranium/pulls/12","html_url":"https://github.com/shapenaji/cranium/pull/12","diff_url":"https://github.com/shapenaji/cranium/pull/12.diff","patch_url":"https://github.com/shapenaji/cranium/pull/12.patch"},"body":"Adding some additional ENV variables with their defaults, if someone runs this outside of the container, it may be convenient for them to run it on alternate ports, or run off loopback"},"comment":{"url":"https://api.github.com/repos/shapenaji/cranium/issues/comments/445106695","html_url":"https://github.com/shapenaji/cranium/pull/12#issuecomment-445106695","issue_url":"https://api.github.com/repos/shapenaji/cranium/issues/12","id":445106695,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTEwNjY5NQ==","user":{"login":"shapenaji","id":13593075,"node_id":"MDQ6VXNlcjEzNTkzMDc1","avatar_url":"https://avatars2.githubusercontent.com/u/13593075?v=4","gravatar_id":"","url":"https://api.github.com/users/shapenaji","html_url":"https://github.com/shapenaji","followers_url":"https://api.github.com/users/shapenaji/followers","following_url":"https://api.github.com/users/shapenaji/following{/other_user}","gists_url":"https://api.github.com/users/shapenaji/gists{/gist_id}","starred_url":"https://api.github.com/users/shapenaji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shapenaji/subscriptions","organizations_url":"https://api.github.com/users/shapenaji/orgs","repos_url":"https://api.github.com/users/shapenaji/repos","events_url":"https://api.github.com/users/shapenaji/events{/privacy}","received_events_url":"https://api.github.com/users/shapenaji/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T03:00:14Z","updated_at":"2018-12-07T03:00:14Z","author_association":"OWNER","body":"> I'm not opposed to configuring some of the internal stuff with environment variables, but I'm not sure what advantage it gets us over passing in parameters to the function. Are you imagining that someone could just run `entrypoint.R`?\r\n\r\nRegarding the argument checking, The goal with the internal stuff is to be completely self-consistent. We respect the environment variables wherever they are passed, and have the same behavior. \r\n\r\nRegarding entrypoint.R I think WE might run it in order to get a better debugging environment.\r\n\r\n(This is actually what I'm doing now, I'm starting the server and sticking a browser inside it to observe behavior, much easier than doing it inside the container)"}}
{"actor":{"display_login":"shapenaji"}}