{"action":"created","comment":{"url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/pulls/comments/171601155","pull_request_review_id":100482476,"id":171601155,"diff_hunk":"@@ -178,7 +178,10 @@ public void detectBackupEnabled(Map<String, SecurityCheckResult> results) {\n      */\n     public void detectDeviceEncryptionStatus(Map<String, SecurityCheckResult> results) {\n         totalTests++;\n-        //TODO: add check\n+        SecurityCheckResult result = securityService.check(SecurityCheckType.HAS_ENCRYPTION_ENABLED);\n+        if (result.passed()){\n+            setDetected(deviceEncrypted, R.string.device_encrypted_positive);","path":"example/src/main/java/org/aerogear/mobile/example/ui/SecurityServiceFragment.java","position":7,"original_position":7,"commit_id":"739eda8cce6a399a642962e456fb30c1ac42e2d4","original_commit_id":"739eda8cce6a399a642962e456fb30c1ac42e2d4","user":{"login":"aidenkeating","id":8698527,"avatar_url":"https://avatars3.githubusercontent.com/u/8698527?v=4","gravatar_id":"","url":"https://api.github.com/users/aidenkeating","html_url":"https://github.com/aidenkeating","followers_url":"https://api.github.com/users/aidenkeating/followers","following_url":"https://api.github.com/users/aidenkeating/following{/other_user}","gists_url":"https://api.github.com/users/aidenkeating/gists{/gist_id}","starred_url":"https://api.github.com/users/aidenkeating/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidenkeating/subscriptions","organizations_url":"https://api.github.com/users/aidenkeating/orgs","repos_url":"https://api.github.com/users/aidenkeating/repos","events_url":"https://api.github.com/users/aidenkeating/events{/privacy}","received_events_url":"https://api.github.com/users/aidenkeating/received_events","type":"User","site_admin":false},"body":"Is this correct, isn't encryption enabled a good thing? At the moment I'm seeing that encryption is enabled but it's in red writing.\r\n\r\n```java\r\nif (!result.passed()) {\r\n    setDetected(deviceEncrypted, R.string.device_encrypted_negative);\r\n}\r\n```\r\n\r\nwould make more sense to me.","created_at":"2018-03-01T15:49:36Z","updated_at":"2018-03-01T15:49:36Z","html_url":"https://github.com/aerogear/aerogear-android-sdk/pull/121#discussion_r171601155","pull_request_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/pulls/121","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-android-sdk/pulls/comments/171601155"},"html":{"href":"https://github.com/aerogear/aerogear-android-sdk/pull/121#discussion_r171601155"},"pull_request":{"href":"https://api.github.com/repos/aerogear/aerogear-android-sdk/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/pulls/121","id":172267920,"html_url":"https://github.com/aerogear/aerogear-android-sdk/pull/121","diff_url":"https://github.com/aerogear/aerogear-android-sdk/pull/121.diff","patch_url":"https://github.com/aerogear/aerogear-android-sdk/pull/121.patch","issue_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/issues/121","number":121,"state":"open","locked":false,"title":"AEROGEAR-2209 Add Encryption Check","user":{"login":"ciaranRoche","id":14313111,"avatar_url":"https://avatars3.githubusercontent.com/u/14313111?v=4","gravatar_id":"","url":"https://api.github.com/users/ciaranRoche","html_url":"https://github.com/ciaranRoche","followers_url":"https://api.github.com/users/ciaranRoche/followers","following_url":"https://api.github.com/users/ciaranRoche/following{/other_user}","gists_url":"https://api.github.com/users/ciaranRoche/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaranRoche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaranRoche/subscriptions","organizations_url":"https://api.github.com/users/ciaranRoche/orgs","repos_url":"https://api.github.com/users/ciaranRoche/repos","events_url":"https://api.github.com/users/ciaranRoche/events{/privacy}","received_events_url":"https://api.github.com/users/ciaranRoche/received_events","type":"User","site_admin":false},"body":"## Motivation\r\n\r\nJIRA: https://issues.jboss.org/browse/AEROGEAR-2209\r\n\r\n## Description\r\n\r\nWe created a function that allows the end developer to check if the devices file system is encrypted\r\n\r\n## Progress\r\n\r\n- [x] Add Check\r\n- [x] Add Unit Tests\r\n- [x] Add Javadoc\r\n- [x] Add Check to Example App\r\n","created_at":"2018-03-01T15:25:56Z","updated_at":"2018-03-01T15:49:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d94355dbc9e0f6b8d880803be12127c429c3455","assignee":null,"assignees":[],"requested_reviewers":[{"login":"danielpassos","id":13337,"avatar_url":"https://avatars1.githubusercontent.com/u/13337?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpassos","html_url":"https://github.com/danielpassos","followers_url":"https://api.github.com/users/danielpassos/followers","following_url":"https://api.github.com/users/danielpassos/following{/other_user}","gists_url":"https://api.github.com/users/danielpassos/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpassos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpassos/subscriptions","organizations_url":"https://api.github.com/users/danielpassos/orgs","repos_url":"https://api.github.com/users/danielpassos/repos","events_url":"https://api.github.com/users/danielpassos/events{/privacy}","received_events_url":"https://api.github.com/users/danielpassos/received_events","type":"User","site_admin":false},{"login":"secondsun","id":2413816,"avatar_url":"https://avatars2.githubusercontent.com/u/2413816?v=4","gravatar_id":"","url":"https://api.github.com/users/secondsun","html_url":"https://github.com/secondsun","followers_url":"https://api.github.com/users/secondsun/followers","following_url":"https://api.github.com/users/secondsun/following{/other_user}","gists_url":"https://api.github.com/users/secondsun/gists{/gist_id}","starred_url":"https://api.github.com/users/secondsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/secondsun/subscriptions","organizations_url":"https://api.github.com/users/secondsun/orgs","repos_url":"https://api.github.com/users/secondsun/repos","events_url":"https://api.github.com/users/secondsun/events{/privacy}","received_events_url":"https://api.github.com/users/secondsun/received_events","type":"User","site_admin":false},{"login":"rachael-oregan","id":17702978,"avatar_url":"https://avatars2.githubusercontent.com/u/17702978?v=4","gravatar_id":"","url":"https://api.github.com/users/rachael-oregan","html_url":"https://github.com/rachael-oregan","followers_url":"https://api.github.com/users/rachael-oregan/followers","following_url":"https://api.github.com/users/rachael-oregan/following{/other_user}","gists_url":"https://api.github.com/users/rachael-oregan/gists{/gist_id}","starred_url":"https://api.github.com/users/rachael-oregan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rachael-oregan/subscriptions","organizations_url":"https://api.github.com/users/rachael-oregan/orgs","repos_url":"https://api.github.com/users/rachael-oregan/repos","events_url":"https://api.github.com/users/rachael-oregan/events{/privacy}","received_events_url":"https://api.github.com/users/rachael-oregan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/pulls/121/commits","review_comments_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/pulls/121/comments","review_comment_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/issues/121/comments","statuses_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/statuses/739eda8cce6a399a642962e456fb30c1ac42e2d4","head":{"label":"ciaranRoche:AEROGEAR-2209-encryption-check","ref":"AEROGEAR-2209-encryption-check","sha":"739eda8cce6a399a642962e456fb30c1ac42e2d4","user":{"login":"ciaranRoche","id":14313111,"avatar_url":"https://avatars3.githubusercontent.com/u/14313111?v=4","gravatar_id":"","url":"https://api.github.com/users/ciaranRoche","html_url":"https://github.com/ciaranRoche","followers_url":"https://api.github.com/users/ciaranRoche/followers","following_url":"https://api.github.com/users/ciaranRoche/following{/other_user}","gists_url":"https://api.github.com/users/ciaranRoche/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaranRoche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaranRoche/subscriptions","organizations_url":"https://api.github.com/users/ciaranRoche/orgs","repos_url":"https://api.github.com/users/ciaranRoche/repos","events_url":"https://api.github.com/users/ciaranRoche/events{/privacy}","received_events_url":"https://api.github.com/users/ciaranRoche/received_events","type":"User","site_admin":false},"repo":{"id":117975630,"name":"aerogear-android-sdk","full_name":"ciaranRoche/aerogear-android-sdk","owner":{"login":"ciaranRoche","id":14313111,"avatar_url":"https://avatars3.githubusercontent.com/u/14313111?v=4","gravatar_id":"","url":"https://api.github.com/users/ciaranRoche","html_url":"https://github.com/ciaranRoche","followers_url":"https://api.github.com/users/ciaranRoche/followers","following_url":"https://api.github.com/users/ciaranRoche/following{/other_user}","gists_url":"https://api.github.com/users/ciaranRoche/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaranRoche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaranRoche/subscriptions","organizations_url":"https://api.github.com/users/ciaranRoche/orgs","repos_url":"https://api.github.com/users/ciaranRoche/repos","events_url":"https://api.github.com/users/ciaranRoche/events{/privacy}","received_events_url":"https://api.github.com/users/ciaranRoche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ciaranRoche/aerogear-android-sdk","description":"Mobile.Next() SDK: Work in progress","fork":true,"url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk","forks_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/forks","keys_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/teams","hooks_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/events","assignees_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/tags","blobs_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/languages","stargazers_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/subscription","commits_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/merges","archive_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/downloads","issues_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/ciaranRoche/aerogear-android-sdk/deployments","created_at":"2018-01-18T11:43:53Z","updated_at":"2018-01-18T11:43:54Z","pushed_at":"2018-03-01T15:30:17Z","git_url":"git://github.com/ciaranRoche/aerogear-android-sdk.git","ssh_url":"git@github.com:ciaranRoche/aerogear-android-sdk.git","clone_url":"https://github.com/ciaranRoche/aerogear-android-sdk.git","svn_url":"https://github.com/ciaranRoche/aerogear-android-sdk","homepage":"","size":967,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aerogear:master","ref":"master","sha":"c6d99090c8005449640f3fda018991da649317d5","user":{"login":"aerogear","id":954205,"avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"repo":{"id":116160086,"name":"aerogear-android-sdk","full_name":"aerogear/aerogear-android-sdk","owner":{"login":"aerogear","id":954205,"avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerogear/aerogear-android-sdk","description":"AeroGear Services Android SDK","fork":false,"url":"https://api.github.com/repos/aerogear/aerogear-android-sdk","forks_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/forks","keys_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/teams","hooks_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/events","assignees_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/tags","blobs_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/languages","stargazers_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/subscription","commits_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/merges","archive_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/downloads","issues_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/aerogear/aerogear-android-sdk/deployments","created_at":"2018-01-03T16:45:59Z","updated_at":"2018-02-28T15:07:02Z","pushed_at":"2018-03-01T15:30:18Z","git_url":"git://github.com/aerogear/aerogear-android-sdk.git","ssh_url":"git@github.com:aerogear/aerogear-android-sdk.git","clone_url":"https://github.com/aerogear/aerogear-android-sdk.git","svn_url":"https://github.com/aerogear/aerogear-android-sdk","homepage":"","size":990,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":18,"open_issues":11,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-android-sdk/pulls/121"},"html":{"href":"https://github.com/aerogear/aerogear-android-sdk/pull/121"},"issue":{"href":"https://api.github.com/repos/aerogear/aerogear-android-sdk/issues/121"},"comments":{"href":"https://api.github.com/repos/aerogear/aerogear-android-sdk/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/aerogear/aerogear-android-sdk/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/aerogear/aerogear-android-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aerogear/aerogear-android-sdk/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/aerogear/aerogear-android-sdk/statuses/739eda8cce6a399a642962e456fb30c1ac42e2d4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aidenkeating"}}