{"action":"created","comment":{"url":"https://api.github.com/repos/chartjs/Chart.js/pulls/comments/243180591","pull_request_review_id":186879779,"id":243180591,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzE4MDU5MQ==","diff_hunk":"@@ -383,7 +383,7 @@ function computeOffsets(table, ticks, min, max, options) {\n \t\t}\n \t}\n \n-\treturn {left: left, right: right};\n+\treturn options.ticks.reverse ? {left: right, right: left} : {left: left, right: right};","path":"src/scales/scale.time.js","position":5,"original_position":5,"commit_id":"0fad2b62a6b7e4bb706d8a02c863de451ff8aa9a","original_commit_id":"0fad2b62a6b7e4bb706d8a02c863de451ff8aa9a","user":{"login":"simonbrunel","id":3874900,"node_id":"MDQ6VXNlcjM4NzQ5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3874900?v=4","gravatar_id":"","url":"https://api.github.com/users/simonbrunel","html_url":"https://github.com/simonbrunel","followers_url":"https://api.github.com/users/simonbrunel/followers","following_url":"https://api.github.com/users/simonbrunel/following{/other_user}","gists_url":"https://api.github.com/users/simonbrunel/gists{/gist_id}","starred_url":"https://api.github.com/users/simonbrunel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonbrunel/subscriptions","organizations_url":"https://api.github.com/users/simonbrunel/orgs","repos_url":"https://api.github.com/users/simonbrunel/repos","events_url":"https://api.github.com/users/simonbrunel/events{/privacy}","received_events_url":"https://api.github.com/users/simonbrunel/received_events","type":"User","site_admin":false},"body":"Not directly related to this PR but maybe the good timing to change it: since we use these values for vertical and now reversed scales, it may be easier to understand if we rename those properties for `start` and `end`:\r\n\r\n```javascript\r\nreturn options.ticks.reverse ? {start: start, end: end} : {start: end, end: start};\r\n```","created_at":"2018-12-20T07:54:53Z","updated_at":"2018-12-20T07:54:53Z","html_url":"https://github.com/chartjs/Chart.js/pull/5927#discussion_r243180591","pull_request_url":"https://api.github.com/repos/chartjs/Chart.js/pulls/5927","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/chartjs/Chart.js/pulls/comments/243180591"},"html":{"href":"https://github.com/chartjs/Chart.js/pull/5927#discussion_r243180591"},"pull_request":{"href":"https://api.github.com/repos/chartjs/Chart.js/pulls/5927"}}},"pull_request":{"url":"https://api.github.com/repos/chartjs/Chart.js/pulls/5927","id":239958465,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5OTU4NDY1","html_url":"https://github.com/chartjs/Chart.js/pull/5927","diff_url":"https://github.com/chartjs/Chart.js/pull/5927.diff","patch_url":"https://github.com/chartjs/Chart.js/pull/5927.patch","issue_url":"https://api.github.com/repos/chartjs/Chart.js/issues/5927","number":5927,"state":"open","locked":false,"title":"Add `reverse` support to time scale","user":{"login":"kurkle","id":27971921,"node_id":"MDQ6VXNlcjI3OTcxOTIx","avatar_url":"https://avatars1.githubusercontent.com/u/27971921?v=4","gravatar_id":"","url":"https://api.github.com/users/kurkle","html_url":"https://github.com/kurkle","followers_url":"https://api.github.com/users/kurkle/followers","following_url":"https://api.github.com/users/kurkle/following{/other_user}","gists_url":"https://api.github.com/users/kurkle/gists{/gist_id}","starred_url":"https://api.github.com/users/kurkle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurkle/subscriptions","organizations_url":"https://api.github.com/users/kurkle/orgs","repos_url":"https://api.github.com/users/kurkle/repos","events_url":"https://api.github.com/users/kurkle/events{/privacy}","received_events_url":"https://api.github.com/users/kurkle/received_events","type":"User","site_admin":false},"body":"Simpler approach for reversing time scale.\r\n<del>What I don't know is why those labels rotate, that needs to be investigated still.</del>\r\n\r\nTests adopted from PR: #5731 \r\nFixes: #3279\r\n\r\n![3279](https://user-images.githubusercontent.com/27971921/50244832-9ab74780-03d9-11e9-9cfe-e55113b24963.png)\r\n(tick rotation fixed in fiddle)\r\n\r\n2.7.3: https://jsfiddle.net/rr3ftzge/40/\r\nPR: https://jsfiddle.net/9cr418ty/1/\r\n\r\n","created_at":"2018-12-19T20:03:39Z","updated_at":"2018-12-20T07:54:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"382e6a2c35c26fbc8cf5e28b59d94448b26b3a3f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chartjs/Chart.js/pulls/5927/commits","review_comments_url":"https://api.github.com/repos/chartjs/Chart.js/pulls/5927/comments","review_comment_url":"https://api.github.com/repos/chartjs/Chart.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chartjs/Chart.js/issues/5927/comments","statuses_url":"https://api.github.com/repos/chartjs/Chart.js/statuses/0fad2b62a6b7e4bb706d8a02c863de451ff8aa9a","head":{"label":"kurkle:#3279","ref":"#3279","sha":"0fad2b62a6b7e4bb706d8a02c863de451ff8aa9a","user":{"login":"kurkle","id":27971921,"node_id":"MDQ6VXNlcjI3OTcxOTIx","avatar_url":"https://avatars1.githubusercontent.com/u/27971921?v=4","gravatar_id":"","url":"https://api.github.com/users/kurkle","html_url":"https://github.com/kurkle","followers_url":"https://api.github.com/users/kurkle/followers","following_url":"https://api.github.com/users/kurkle/following{/other_user}","gists_url":"https://api.github.com/users/kurkle/gists{/gist_id}","starred_url":"https://api.github.com/users/kurkle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurkle/subscriptions","organizations_url":"https://api.github.com/users/kurkle/orgs","repos_url":"https://api.github.com/users/kurkle/repos","events_url":"https://api.github.com/users/kurkle/events{/privacy}","received_events_url":"https://api.github.com/users/kurkle/received_events","type":"User","site_admin":false},"repo":{"id":158796559,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg3OTY1NTk=","name":"Chart.js","full_name":"kurkle/Chart.js","private":false,"owner":{"login":"kurkle","id":27971921,"node_id":"MDQ6VXNlcjI3OTcxOTIx","avatar_url":"https://avatars1.githubusercontent.com/u/27971921?v=4","gravatar_id":"","url":"https://api.github.com/users/kurkle","html_url":"https://github.com/kurkle","followers_url":"https://api.github.com/users/kurkle/followers","following_url":"https://api.github.com/users/kurkle/following{/other_user}","gists_url":"https://api.github.com/users/kurkle/gists{/gist_id}","starred_url":"https://api.github.com/users/kurkle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurkle/subscriptions","organizations_url":"https://api.github.com/users/kurkle/orgs","repos_url":"https://api.github.com/users/kurkle/repos","events_url":"https://api.github.com/users/kurkle/events{/privacy}","received_events_url":"https://api.github.com/users/kurkle/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kurkle/Chart.js","description":"Simple HTML5 Charts using the <canvas> tag","fork":true,"url":"https://api.github.com/repos/kurkle/Chart.js","forks_url":"https://api.github.com/repos/kurkle/Chart.js/forks","keys_url":"https://api.github.com/repos/kurkle/Chart.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kurkle/Chart.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kurkle/Chart.js/teams","hooks_url":"https://api.github.com/repos/kurkle/Chart.js/hooks","issue_events_url":"https://api.github.com/repos/kurkle/Chart.js/issues/events{/number}","events_url":"https://api.github.com/repos/kurkle/Chart.js/events","assignees_url":"https://api.github.com/repos/kurkle/Chart.js/assignees{/user}","branches_url":"https://api.github.com/repos/kurkle/Chart.js/branches{/branch}","tags_url":"https://api.github.com/repos/kurkle/Chart.js/tags","blobs_url":"https://api.github.com/repos/kurkle/Chart.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kurkle/Chart.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kurkle/Chart.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/kurkle/Chart.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kurkle/Chart.js/statuses/{sha}","languages_url":"https://api.github.com/repos/kurkle/Chart.js/languages","stargazers_url":"https://api.github.com/repos/kurkle/Chart.js/stargazers","contributors_url":"https://api.github.com/repos/kurkle/Chart.js/contributors","subscribers_url":"https://api.github.com/repos/kurkle/Chart.js/subscribers","subscription_url":"https://api.github.com/repos/kurkle/Chart.js/subscription","commits_url":"https://api.github.com/repos/kurkle/Chart.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/kurkle/Chart.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/kurkle/Chart.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/kurkle/Chart.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/kurkle/Chart.js/contents/{+path}","compare_url":"https://api.github.com/repos/kurkle/Chart.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kurkle/Chart.js/merges","archive_url":"https://api.github.com/repos/kurkle/Chart.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kurkle/Chart.js/downloads","issues_url":"https://api.github.com/repos/kurkle/Chart.js/issues{/number}","pulls_url":"https://api.github.com/repos/kurkle/Chart.js/pulls{/number}","milestones_url":"https://api.github.com/repos/kurkle/Chart.js/milestones{/number}","notifications_url":"https://api.github.com/repos/kurkle/Chart.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kurkle/Chart.js/labels{/name}","releases_url":"https://api.github.com/repos/kurkle/Chart.js/releases{/id}","deployments_url":"https://api.github.com/repos/kurkle/Chart.js/deployments","created_at":"2018-11-23T07:31:50Z","updated_at":"2018-12-15T08:39:58Z","pushed_at":"2018-12-19T21:20:31Z","git_url":"git://github.com/kurkle/Chart.js.git","ssh_url":"git@github.com:kurkle/Chart.js.git","clone_url":"https://github.com/kurkle/Chart.js.git","svn_url":"https://github.com/kurkle/Chart.js","homepage":"http://www.chartjs.org/","size":10964,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chartjs:master","ref":"master","sha":"c8ce3d2018244657f18f7bae2fd2fcf1fe825e8f","user":{"login":"chartjs","id":10342521,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMzQyNTIx","avatar_url":"https://avatars1.githubusercontent.com/u/10342521?v=4","gravatar_id":"","url":"https://api.github.com/users/chartjs","html_url":"https://github.com/chartjs","followers_url":"https://api.github.com/users/chartjs/followers","following_url":"https://api.github.com/users/chartjs/following{/other_user}","gists_url":"https://api.github.com/users/chartjs/gists{/gist_id}","starred_url":"https://api.github.com/users/chartjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chartjs/subscriptions","organizations_url":"https://api.github.com/users/chartjs/orgs","repos_url":"https://api.github.com/users/chartjs/repos","events_url":"https://api.github.com/users/chartjs/events{/privacy}","received_events_url":"https://api.github.com/users/chartjs/received_events","type":"Organization","site_admin":false},"repo":{"id":8843683,"node_id":"MDEwOlJlcG9zaXRvcnk4ODQzNjgz","name":"Chart.js","full_name":"chartjs/Chart.js","private":false,"owner":{"login":"chartjs","id":10342521,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMzQyNTIx","avatar_url":"https://avatars1.githubusercontent.com/u/10342521?v=4","gravatar_id":"","url":"https://api.github.com/users/chartjs","html_url":"https://github.com/chartjs","followers_url":"https://api.github.com/users/chartjs/followers","following_url":"https://api.github.com/users/chartjs/following{/other_user}","gists_url":"https://api.github.com/users/chartjs/gists{/gist_id}","starred_url":"https://api.github.com/users/chartjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chartjs/subscriptions","organizations_url":"https://api.github.com/users/chartjs/orgs","repos_url":"https://api.github.com/users/chartjs/repos","events_url":"https://api.github.com/users/chartjs/events{/privacy}","received_events_url":"https://api.github.com/users/chartjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chartjs/Chart.js","description":"Simple HTML5 Charts using the <canvas> tag","fork":false,"url":"https://api.github.com/repos/chartjs/Chart.js","forks_url":"https://api.github.com/repos/chartjs/Chart.js/forks","keys_url":"https://api.github.com/repos/chartjs/Chart.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chartjs/Chart.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chartjs/Chart.js/teams","hooks_url":"https://api.github.com/repos/chartjs/Chart.js/hooks","issue_events_url":"https://api.github.com/repos/chartjs/Chart.js/issues/events{/number}","events_url":"https://api.github.com/repos/chartjs/Chart.js/events","assignees_url":"https://api.github.com/repos/chartjs/Chart.js/assignees{/user}","branches_url":"https://api.github.com/repos/chartjs/Chart.js/branches{/branch}","tags_url":"https://api.github.com/repos/chartjs/Chart.js/tags","blobs_url":"https://api.github.com/repos/chartjs/Chart.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chartjs/Chart.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chartjs/Chart.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/chartjs/Chart.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chartjs/Chart.js/statuses/{sha}","languages_url":"https://api.github.com/repos/chartjs/Chart.js/languages","stargazers_url":"https://api.github.com/repos/chartjs/Chart.js/stargazers","contributors_url":"https://api.github.com/repos/chartjs/Chart.js/contributors","subscribers_url":"https://api.github.com/repos/chartjs/Chart.js/subscribers","subscription_url":"https://api.github.com/repos/chartjs/Chart.js/subscription","commits_url":"https://api.github.com/repos/chartjs/Chart.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/chartjs/Chart.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/chartjs/Chart.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/chartjs/Chart.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/chartjs/Chart.js/contents/{+path}","compare_url":"https://api.github.com/repos/chartjs/Chart.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chartjs/Chart.js/merges","archive_url":"https://api.github.com/repos/chartjs/Chart.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chartjs/Chart.js/downloads","issues_url":"https://api.github.com/repos/chartjs/Chart.js/issues{/number}","pulls_url":"https://api.github.com/repos/chartjs/Chart.js/pulls{/number}","milestones_url":"https://api.github.com/repos/chartjs/Chart.js/milestones{/number}","notifications_url":"https://api.github.com/repos/chartjs/Chart.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chartjs/Chart.js/labels{/name}","releases_url":"https://api.github.com/repos/chartjs/Chart.js/releases{/id}","deployments_url":"https://api.github.com/repos/chartjs/Chart.js/deployments","created_at":"2013-03-17T23:56:36Z","updated_at":"2018-12-20T07:45:49Z","pushed_at":"2018-12-20T01:31:23Z","git_url":"git://github.com/chartjs/Chart.js.git","ssh_url":"git@github.com:chartjs/Chart.js.git","clone_url":"https://github.com/chartjs/Chart.js.git","svn_url":"https://github.com/chartjs/Chart.js","homepage":"https://www.chartjs.org/","size":10934,"stargazers_count":40926,"watchers_count":40926,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9242,"mirror_url":null,"archived":false,"open_issues_count":475,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9242,"open_issues":475,"watchers":40926,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chartjs/Chart.js/pulls/5927"},"html":{"href":"https://github.com/chartjs/Chart.js/pull/5927"},"issue":{"href":"https://api.github.com/repos/chartjs/Chart.js/issues/5927"},"comments":{"href":"https://api.github.com/repos/chartjs/Chart.js/issues/5927/comments"},"review_comments":{"href":"https://api.github.com/repos/chartjs/Chart.js/pulls/5927/comments"},"review_comment":{"href":"https://api.github.com/repos/chartjs/Chart.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chartjs/Chart.js/pulls/5927/commits"},"statuses":{"href":"https://api.github.com/repos/chartjs/Chart.js/statuses/0fad2b62a6b7e4bb706d8a02c863de451ff8aa9a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"simonbrunel"}}