{"action":"created","comment":{"url":"https://api.github.com/repos/MTS-STM/MTSApp/pulls/comments/196460714","pull_request_review_id":130016822,"id":196460714,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjQ2MDcxNA==","diff_hunk":"@@ -13,6 +13,11 @@ import { Lang, User, LangCodes } from \"../providers\";\n     <ion-header>\n       <ion-toolbar color=\"navMenuBackground\">\n         <ion-title>Pages</ion-title>\n+        <ion-buttons end>\n+          <button ion-button clear menuClose>\n+            <ion-icon name=\"close\" aria-hidden=\"true\"></ion-icon>","path":"src/app/app.component.ts","position":6,"original_position":6,"commit_id":"420e6f8341d99452438013e82af167f75f82ec83","original_commit_id":"420e6f8341d99452438013e82af167f75f82ec83","user":{"login":"CalvinRodo","id":87738,"node_id":"MDQ6VXNlcjg3NzM4","avatar_url":"https://avatars2.githubusercontent.com/u/87738?v=4","gravatar_id":"","url":"https://api.github.com/users/CalvinRodo","html_url":"https://github.com/CalvinRodo","followers_url":"https://api.github.com/users/CalvinRodo/followers","following_url":"https://api.github.com/users/CalvinRodo/following{/other_user}","gists_url":"https://api.github.com/users/CalvinRodo/gists{/gist_id}","starred_url":"https://api.github.com/users/CalvinRodo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CalvinRodo/subscriptions","organizations_url":"https://api.github.com/users/CalvinRodo/orgs","repos_url":"https://api.github.com/users/CalvinRodo/repos","events_url":"https://api.github.com/users/CalvinRodo/events{/privacy}","received_events_url":"https://api.github.com/users/CalvinRodo/received_events","type":"User","site_admin":false},"body":"For testing purposes all buttons need IDs. \r\nFor a11y purposes the button needs to have text and not just rely purely on an icon. You can use invisible text but it must be visible to a screen reader. ","created_at":"2018-06-19T14:59:30Z","updated_at":"2018-06-19T14:59:46Z","html_url":"https://github.com/MTS-STM/MTSApp/pull/210#discussion_r196460714","pull_request_url":"https://api.github.com/repos/MTS-STM/MTSApp/pulls/210","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/MTS-STM/MTSApp/pulls/comments/196460714"},"html":{"href":"https://github.com/MTS-STM/MTSApp/pull/210#discussion_r196460714"},"pull_request":{"href":"https://api.github.com/repos/MTS-STM/MTSApp/pulls/210"}}},"pull_request":{"url":"https://api.github.com/repos/MTS-STM/MTSApp/pulls/210","id":195302088,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzAyMDg4","html_url":"https://github.com/MTS-STM/MTSApp/pull/210","diff_url":"https://github.com/MTS-STM/MTSApp/pull/210.diff","patch_url":"https://github.com/MTS-STM/MTSApp/pull/210.patch","issue_url":"https://api.github.com/repos/MTS-STM/MTSApp/issues/210","number":210,"state":"open","locked":false,"title":"Full width nav menu","user":{"login":"will0684","id":31868510,"node_id":"MDQ6VXNlcjMxODY4NTEw","avatar_url":"https://avatars1.githubusercontent.com/u/31868510?v=4","gravatar_id":"","url":"https://api.github.com/users/will0684","html_url":"https://github.com/will0684","followers_url":"https://api.github.com/users/will0684/followers","following_url":"https://api.github.com/users/will0684/following{/other_user}","gists_url":"https://api.github.com/users/will0684/gists{/gist_id}","starred_url":"https://api.github.com/users/will0684/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/will0684/subscriptions","organizations_url":"https://api.github.com/users/will0684/orgs","repos_url":"https://api.github.com/users/will0684/repos","events_url":"https://api.github.com/users/will0684/events{/privacy}","received_events_url":"https://api.github.com/users/will0684/received_events","type":"User","site_admin":false},"body":"- Matches design for larger devices\r\n- Using it on smaller devices allows for longer i.e. french strings","created_at":"2018-06-15T23:19:47Z","updated_at":"2018-06-19T14:59:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98049c655ff1fb1cafca8ee0f51d81ccfbb51f7d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sdkibb","id":8471209,"node_id":"MDQ6VXNlcjg0NzEyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/8471209?v=4","gravatar_id":"","url":"https://api.github.com/users/sdkibb","html_url":"https://github.com/sdkibb","followers_url":"https://api.github.com/users/sdkibb/followers","following_url":"https://api.github.com/users/sdkibb/following{/other_user}","gists_url":"https://api.github.com/users/sdkibb/gists{/gist_id}","starred_url":"https://api.github.com/users/sdkibb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdkibb/subscriptions","organizations_url":"https://api.github.com/users/sdkibb/orgs","repos_url":"https://api.github.com/users/sdkibb/repos","events_url":"https://api.github.com/users/sdkibb/events{/privacy}","received_events_url":"https://api.github.com/users/sdkibb/received_events","type":"User","site_admin":false},{"login":"blai0264","id":31868036,"node_id":"MDQ6VXNlcjMxODY4MDM2","avatar_url":"https://avatars1.githubusercontent.com/u/31868036?v=4","gravatar_id":"","url":"https://api.github.com/users/blai0264","html_url":"https://github.com/blai0264","followers_url":"https://api.github.com/users/blai0264/followers","following_url":"https://api.github.com/users/blai0264/following{/other_user}","gists_url":"https://api.github.com/users/blai0264/gists{/gist_id}","starred_url":"https://api.github.com/users/blai0264/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blai0264/subscriptions","organizations_url":"https://api.github.com/users/blai0264/orgs","repos_url":"https://api.github.com/users/blai0264/repos","events_url":"https://api.github.com/users/blai0264/events{/privacy}","received_events_url":"https://api.github.com/users/blai0264/received_events","type":"User","site_admin":false},{"login":"marjan-tropper","id":39193846,"node_id":"MDQ6VXNlcjM5MTkzODQ2","avatar_url":"https://avatars2.githubusercontent.com/u/39193846?v=4","gravatar_id":"","url":"https://api.github.com/users/marjan-tropper","html_url":"https://github.com/marjan-tropper","followers_url":"https://api.github.com/users/marjan-tropper/followers","following_url":"https://api.github.com/users/marjan-tropper/following{/other_user}","gists_url":"https://api.github.com/users/marjan-tropper/gists{/gist_id}","starred_url":"https://api.github.com/users/marjan-tropper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marjan-tropper/subscriptions","organizations_url":"https://api.github.com/users/marjan-tropper/orgs","repos_url":"https://api.github.com/users/marjan-tropper/repos","events_url":"https://api.github.com/users/marjan-tropper/events{/privacy}","received_events_url":"https://api.github.com/users/marjan-tropper/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MTS-STM/MTSApp/pulls/210/commits","review_comments_url":"https://api.github.com/repos/MTS-STM/MTSApp/pulls/210/comments","review_comment_url":"https://api.github.com/repos/MTS-STM/MTSApp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MTS-STM/MTSApp/issues/210/comments","statuses_url":"https://api.github.com/repos/MTS-STM/MTSApp/statuses/420e6f8341d99452438013e82af167f75f82ec83","head":{"label":"MTS-STM:full-width-nav-menu","ref":"full-width-nav-menu","sha":"420e6f8341d99452438013e82af167f75f82ec83","user":{"login":"MTS-STM","id":37446123,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NDQ2MTIz","avatar_url":"https://avatars1.githubusercontent.com/u/37446123?v=4","gravatar_id":"","url":"https://api.github.com/users/MTS-STM","html_url":"https://github.com/MTS-STM","followers_url":"https://api.github.com/users/MTS-STM/followers","following_url":"https://api.github.com/users/MTS-STM/following{/other_user}","gists_url":"https://api.github.com/users/MTS-STM/gists{/gist_id}","starred_url":"https://api.github.com/users/MTS-STM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MTS-STM/subscriptions","organizations_url":"https://api.github.com/users/MTS-STM/orgs","repos_url":"https://api.github.com/users/MTS-STM/repos","events_url":"https://api.github.com/users/MTS-STM/events{/privacy}","received_events_url":"https://api.github.com/users/MTS-STM/received_events","type":"Organization","site_admin":false},"repo":{"id":132934802,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI5MzQ4MDI=","name":"MTSApp","full_name":"MTS-STM/MTSApp","owner":{"login":"MTS-STM","id":37446123,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NDQ2MTIz","avatar_url":"https://avatars1.githubusercontent.com/u/37446123?v=4","gravatar_id":"","url":"https://api.github.com/users/MTS-STM","html_url":"https://github.com/MTS-STM","followers_url":"https://api.github.com/users/MTS-STM/followers","following_url":"https://api.github.com/users/MTS-STM/following{/other_user}","gists_url":"https://api.github.com/users/MTS-STM/gists{/gist_id}","starred_url":"https://api.github.com/users/MTS-STM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MTS-STM/subscriptions","organizations_url":"https://api.github.com/users/MTS-STM/orgs","repos_url":"https://api.github.com/users/MTS-STM/repos","events_url":"https://api.github.com/users/MTS-STM/events{/privacy}","received_events_url":"https://api.github.com/users/MTS-STM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MTS-STM/MTSApp","description":null,"fork":false,"url":"https://api.github.com/repos/MTS-STM/MTSApp","forks_url":"https://api.github.com/repos/MTS-STM/MTSApp/forks","keys_url":"https://api.github.com/repos/MTS-STM/MTSApp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MTS-STM/MTSApp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MTS-STM/MTSApp/teams","hooks_url":"https://api.github.com/repos/MTS-STM/MTSApp/hooks","issue_events_url":"https://api.github.com/repos/MTS-STM/MTSApp/issues/events{/number}","events_url":"https://api.github.com/repos/MTS-STM/MTSApp/events","assignees_url":"https://api.github.com/repos/MTS-STM/MTSApp/assignees{/user}","branches_url":"https://api.github.com/repos/MTS-STM/MTSApp/branches{/branch}","tags_url":"https://api.github.com/repos/MTS-STM/MTSApp/tags","blobs_url":"https://api.github.com/repos/MTS-STM/MTSApp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MTS-STM/MTSApp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MTS-STM/MTSApp/git/refs{/sha}","trees_url":"https://api.github.com/repos/MTS-STM/MTSApp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MTS-STM/MTSApp/statuses/{sha}","languages_url":"https://api.github.com/repos/MTS-STM/MTSApp/languages","stargazers_url":"https://api.github.com/repos/MTS-STM/MTSApp/stargazers","contributors_url":"https://api.github.com/repos/MTS-STM/MTSApp/contributors","subscribers_url":"https://api.github.com/repos/MTS-STM/MTSApp/subscribers","subscription_url":"https://api.github.com/repos/MTS-STM/MTSApp/subscription","commits_url":"https://api.github.com/repos/MTS-STM/MTSApp/commits{/sha}","git_commits_url":"https://api.github.com/repos/MTS-STM/MTSApp/git/commits{/sha}","comments_url":"https://api.github.com/repos/MTS-STM/MTSApp/comments{/number}","issue_comment_url":"https://api.github.com/repos/MTS-STM/MTSApp/issues/comments{/number}","contents_url":"https://api.github.com/repos/MTS-STM/MTSApp/contents/{+path}","compare_url":"https://api.github.com/repos/MTS-STM/MTSApp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MTS-STM/MTSApp/merges","archive_url":"https://api.github.com/repos/MTS-STM/MTSApp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MTS-STM/MTSApp/downloads","issues_url":"https://api.github.com/repos/MTS-STM/MTSApp/issues{/number}","pulls_url":"https://api.github.com/repos/MTS-STM/MTSApp/pulls{/number}","milestones_url":"https://api.github.com/repos/MTS-STM/MTSApp/milestones{/number}","notifications_url":"https://api.github.com/repos/MTS-STM/MTSApp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MTS-STM/MTSApp/labels{/name}","releases_url":"https://api.github.com/repos/MTS-STM/MTSApp/releases{/id}","deployments_url":"https://api.github.com/repos/MTS-STM/MTSApp/deployments","created_at":"2018-05-10T17:43:37Z","updated_at":"2018-06-19T14:53:37Z","pushed_at":"2018-06-19T14:58:12Z","git_url":"git://github.com/MTS-STM/MTSApp.git","ssh_url":"git@github.com:MTS-STM/MTSApp.git","clone_url":"https://github.com/MTS-STM/MTSApp.git","svn_url":"https://github.com/MTS-STM/MTSApp","homepage":null,"size":14272,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"MTS-STM:master","ref":"master","sha":"8fc6d913318e2a6374446590fcdb232e37b318f2","user":{"login":"MTS-STM","id":37446123,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NDQ2MTIz","avatar_url":"https://avatars1.githubusercontent.com/u/37446123?v=4","gravatar_id":"","url":"https://api.github.com/users/MTS-STM","html_url":"https://github.com/MTS-STM","followers_url":"https://api.github.com/users/MTS-STM/followers","following_url":"https://api.github.com/users/MTS-STM/following{/other_user}","gists_url":"https://api.github.com/users/MTS-STM/gists{/gist_id}","starred_url":"https://api.github.com/users/MTS-STM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MTS-STM/subscriptions","organizations_url":"https://api.github.com/users/MTS-STM/orgs","repos_url":"https://api.github.com/users/MTS-STM/repos","events_url":"https://api.github.com/users/MTS-STM/events{/privacy}","received_events_url":"https://api.github.com/users/MTS-STM/received_events","type":"Organization","site_admin":false},"repo":{"id":132934802,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI5MzQ4MDI=","name":"MTSApp","full_name":"MTS-STM/MTSApp","owner":{"login":"MTS-STM","id":37446123,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NDQ2MTIz","avatar_url":"https://avatars1.githubusercontent.com/u/37446123?v=4","gravatar_id":"","url":"https://api.github.com/users/MTS-STM","html_url":"https://github.com/MTS-STM","followers_url":"https://api.github.com/users/MTS-STM/followers","following_url":"https://api.github.com/users/MTS-STM/following{/other_user}","gists_url":"https://api.github.com/users/MTS-STM/gists{/gist_id}","starred_url":"https://api.github.com/users/MTS-STM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MTS-STM/subscriptions","organizations_url":"https://api.github.com/users/MTS-STM/orgs","repos_url":"https://api.github.com/users/MTS-STM/repos","events_url":"https://api.github.com/users/MTS-STM/events{/privacy}","received_events_url":"https://api.github.com/users/MTS-STM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MTS-STM/MTSApp","description":null,"fork":false,"url":"https://api.github.com/repos/MTS-STM/MTSApp","forks_url":"https://api.github.com/repos/MTS-STM/MTSApp/forks","keys_url":"https://api.github.com/repos/MTS-STM/MTSApp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MTS-STM/MTSApp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MTS-STM/MTSApp/teams","hooks_url":"https://api.github.com/repos/MTS-STM/MTSApp/hooks","issue_events_url":"https://api.github.com/repos/MTS-STM/MTSApp/issues/events{/number}","events_url":"https://api.github.com/repos/MTS-STM/MTSApp/events","assignees_url":"https://api.github.com/repos/MTS-STM/MTSApp/assignees{/user}","branches_url":"https://api.github.com/repos/MTS-STM/MTSApp/branches{/branch}","tags_url":"https://api.github.com/repos/MTS-STM/MTSApp/tags","blobs_url":"https://api.github.com/repos/MTS-STM/MTSApp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MTS-STM/MTSApp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MTS-STM/MTSApp/git/refs{/sha}","trees_url":"https://api.github.com/repos/MTS-STM/MTSApp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MTS-STM/MTSApp/statuses/{sha}","languages_url":"https://api.github.com/repos/MTS-STM/MTSApp/languages","stargazers_url":"https://api.github.com/repos/MTS-STM/MTSApp/stargazers","contributors_url":"https://api.github.com/repos/MTS-STM/MTSApp/contributors","subscribers_url":"https://api.github.com/repos/MTS-STM/MTSApp/subscribers","subscription_url":"https://api.github.com/repos/MTS-STM/MTSApp/subscription","commits_url":"https://api.github.com/repos/MTS-STM/MTSApp/commits{/sha}","git_commits_url":"https://api.github.com/repos/MTS-STM/MTSApp/git/commits{/sha}","comments_url":"https://api.github.com/repos/MTS-STM/MTSApp/comments{/number}","issue_comment_url":"https://api.github.com/repos/MTS-STM/MTSApp/issues/comments{/number}","contents_url":"https://api.github.com/repos/MTS-STM/MTSApp/contents/{+path}","compare_url":"https://api.github.com/repos/MTS-STM/MTSApp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MTS-STM/MTSApp/merges","archive_url":"https://api.github.com/repos/MTS-STM/MTSApp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MTS-STM/MTSApp/downloads","issues_url":"https://api.github.com/repos/MTS-STM/MTSApp/issues{/number}","pulls_url":"https://api.github.com/repos/MTS-STM/MTSApp/pulls{/number}","milestones_url":"https://api.github.com/repos/MTS-STM/MTSApp/milestones{/number}","notifications_url":"https://api.github.com/repos/MTS-STM/MTSApp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MTS-STM/MTSApp/labels{/name}","releases_url":"https://api.github.com/repos/MTS-STM/MTSApp/releases{/id}","deployments_url":"https://api.github.com/repos/MTS-STM/MTSApp/deployments","created_at":"2018-05-10T17:43:37Z","updated_at":"2018-06-19T14:53:37Z","pushed_at":"2018-06-19T14:58:12Z","git_url":"git://github.com/MTS-STM/MTSApp.git","ssh_url":"git@github.com:MTS-STM/MTSApp.git","clone_url":"https://github.com/MTS-STM/MTSApp.git","svn_url":"https://github.com/MTS-STM/MTSApp","homepage":null,"size":14272,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MTS-STM/MTSApp/pulls/210"},"html":{"href":"https://github.com/MTS-STM/MTSApp/pull/210"},"issue":{"href":"https://api.github.com/repos/MTS-STM/MTSApp/issues/210"},"comments":{"href":"https://api.github.com/repos/MTS-STM/MTSApp/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/MTS-STM/MTSApp/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/MTS-STM/MTSApp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MTS-STM/MTSApp/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/MTS-STM/MTSApp/statuses/420e6f8341d99452438013e82af167f75f82ec83"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"CalvinRodo"}}