{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69454","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69454/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69454/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69454/events","html_url":"https://github.com/kubernetes/kubernetes/pull/69454","id":367083220,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNjAzMTE3","number":69454,"title":"delete node from aws if it is terminated","user":{"login":"zetaab","id":22482503,"node_id":"MDQ6VXNlcjIyNDgyNTAz","avatar_url":"https://avatars2.githubusercontent.com/u/22482503?v=4","gravatar_id":"","url":"https://api.github.com/users/zetaab","html_url":"https://github.com/zetaab","followers_url":"https://api.github.com/users/zetaab/followers","following_url":"https://api.github.com/users/zetaab/following{/other_user}","gists_url":"https://api.github.com/users/zetaab/gists{/gist_id}","starred_url":"https://api.github.com/users/zetaab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetaab/subscriptions","organizations_url":"https://api.github.com/users/zetaab/orgs","repos_url":"https://api.github.com/users/zetaab/repos","events_url":"https://api.github.com/users/zetaab/events{/privacy}","received_events_url":"https://api.github.com/users/zetaab/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"node_id":"MDU6TGFiZWw0MTQ4ODM5ODI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":148225179,"node_id":"MDU6TGFiZWwxNDgyMjUxNzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":328487998,"node_id":"MDU6TGFiZWwzMjg0ODc5OTg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/aws","name":"sig/aws","color":"d2b48c","default":false},{"id":958178286,"node_id":"MDU6TGFiZWw5NTgxNzgyODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cloud-provider","name":"sig/cloud-provider","color":"d2b48c","default":false},{"id":253450793,"node_id":"MDU6TGFiZWwyNTM0NTA3OTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"gnufied","id":278,"node_id":"MDQ6VXNlcjI3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/278?v=4","gravatar_id":"","url":"https://api.github.com/users/gnufied","html_url":"https://github.com/gnufied","followers_url":"https://api.github.com/users/gnufied/followers","following_url":"https://api.github.com/users/gnufied/following{/other_user}","gists_url":"https://api.github.com/users/gnufied/gists{/gist_id}","starred_url":"https://api.github.com/users/gnufied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnufied/subscriptions","organizations_url":"https://api.github.com/users/gnufied/orgs","repos_url":"https://api.github.com/users/gnufied/repos","events_url":"https://api.github.com/users/gnufied/events{/privacy}","received_events_url":"https://api.github.com/users/gnufied/received_events","type":"User","site_admin":false},"assignees":[{"login":"gnufied","id":278,"node_id":"MDQ6VXNlcjI3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/278?v=4","gravatar_id":"","url":"https://api.github.com/users/gnufied","html_url":"https://github.com/gnufied","followers_url":"https://api.github.com/users/gnufied/followers","following_url":"https://api.github.com/users/gnufied/following{/other_user}","gists_url":"https://api.github.com/users/gnufied/gists{/gist_id}","starred_url":"https://api.github.com/users/gnufied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnufied/subscriptions","organizations_url":"https://api.github.com/users/gnufied/orgs","repos_url":"https://api.github.com/users/gnufied/repos","events_url":"https://api.github.com/users/gnufied/events{/privacy}","received_events_url":"https://api.github.com/users/gnufied/received_events","type":"User","site_admin":false},{"login":"sjenning","id":493891,"node_id":"MDQ6VXNlcjQ5Mzg5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/493891?v=4","gravatar_id":"","url":"https://api.github.com/users/sjenning","html_url":"https://github.com/sjenning","followers_url":"https://api.github.com/users/sjenning/followers","following_url":"https://api.github.com/users/sjenning/following{/other_user}","gists_url":"https://api.github.com/users/sjenning/gists{/gist_id}","starred_url":"https://api.github.com/users/sjenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjenning/subscriptions","organizations_url":"https://api.github.com/users/sjenning/orgs","repos_url":"https://api.github.com/users/sjenning/repos","events_url":"https://api.github.com/users/sjenning/events{/privacy}","received_events_url":"https://api.github.com/users/sjenning/received_events","type":"User","site_admin":false},{"login":"yastij","id":7813699,"node_id":"MDQ6VXNlcjc4MTM2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7813699?v=4","gravatar_id":"","url":"https://api.github.com/users/yastij","html_url":"https://github.com/yastij","followers_url":"https://api.github.com/users/yastij/followers","following_url":"https://api.github.com/users/yastij/following{/other_user}","gists_url":"https://api.github.com/users/yastij/gists{/gist_id}","starred_url":"https://api.github.com/users/yastij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yastij/subscriptions","organizations_url":"https://api.github.com/users/yastij/orgs","repos_url":"https://api.github.com/users/yastij/repos","events_url":"https://api.github.com/users/yastij/events{/privacy}","received_events_url":"https://api.github.com/users/yastij/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2018-10-05T06:57:25Z","updated_at":"2018-10-19T00:04:03Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/69454","html_url":"https://github.com/kubernetes/kubernetes/pull/69454","diff_url":"https://github.com/kubernetes/kubernetes/pull/69454.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/69454.patch"},"body":"**What this PR does / why we need it**: currently (1.12 ->) nodes are not deleted from cluster if those are terminated\r\n\r\n**Which issue(s) this PR fixes**: \r\nFixes #69409\r\n\r\n**Special notes for your reviewer**: When we remove terminated state from shutdown function. Then it does not add shutdown taint if node is terminated - instead it will delete node. \r\n\r\nAlso if we see that instance does not exist already in shutdown function, we should continue forward. Otherwise the node is not deleted either. It is little bit stupid to retrieve same instance status twice but thats not easy to modify because all cloudproviders are using it.\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n/sig aws\r\n/kind bug\r\n/cc @sjenning @gnufied "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/431202993","html_url":"https://github.com/kubernetes/kubernetes/pull/69454#issuecomment-431202993","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69454","id":431202993,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTIwMjk5Mw==","user":{"login":"fejta-bot","id":30488982,"node_id":"MDQ6VXNlcjMwNDg4OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/30488982?v=4","gravatar_id":"","url":"https://api.github.com/users/fejta-bot","html_url":"https://github.com/fejta-bot","followers_url":"https://api.github.com/users/fejta-bot/followers","following_url":"https://api.github.com/users/fejta-bot/following{/other_user}","gists_url":"https://api.github.com/users/fejta-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta-bot/subscriptions","organizations_url":"https://api.github.com/users/fejta-bot/orgs","repos_url":"https://api.github.com/users/fejta-bot/repos","events_url":"https://api.github.com/users/fejta-bot/events{/privacy}","received_events_url":"https://api.github.com/users/fejta-bot/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T00:04:03Z","updated_at":"2018-10-19T00:04:03Z","author_association":"NONE","body":"/retest\nThis bot automatically retries jobs that failed/flaked on approved PRs (send feedback to [fejta](https://github.com/fejta)).\n\nReview the [full test history](https://k8s-gubernator.appspot.com/pr/69454) for this PR.\n\nSilence the bot with an `/lgtm cancel` comment for consistent failures."}}
{"actor":{"display_login":"fejta-bot"}}