{"action":"opened","issue":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/14813","repository_url":"https://api.github.com/repos/spring-projects/spring-boot","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/14813/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/14813/comments","events_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/14813/events","html_url":"https://github.com/spring-projects/spring-boot/issues/14813","id":369835490,"node_id":"MDU6SXNzdWUzNjk4MzU0OTA=","number":14813,"title":"Configuration metadata for Map properties does not include their default value","user":{"login":"wilkinsona","id":914682,"node_id":"MDQ6VXNlcjkxNDY4Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/914682?v=4","gravatar_id":"","url":"https://api.github.com/users/wilkinsona","html_url":"https://github.com/wilkinsona","followers_url":"https://api.github.com/users/wilkinsona/followers","following_url":"https://api.github.com/users/wilkinsona/following{/other_user}","gists_url":"https://api.github.com/users/wilkinsona/gists{/gist_id}","starred_url":"https://api.github.com/users/wilkinsona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilkinsona/subscriptions","organizations_url":"https://api.github.com/users/wilkinsona/orgs","repos_url":"https://api.github.com/users/wilkinsona/repos","events_url":"https://api.github.com/users/wilkinsona/events{/privacy}","received_events_url":"https://api.github.com/users/wilkinsona/received_events","type":"User","site_admin":false},"labels":[{"id":272169180,"node_id":"MDU6TGFiZWwyNzIxNjkxODA=","url":"https://api.github.com/repos/spring-projects/spring-boot/labels/for:%20team-attention","name":"for: team-attention","color":"c5def5","default":false},{"id":293438798,"node_id":"MDU6TGFiZWwyOTM0Mzg3OTg=","url":"https://api.github.com/repos/spring-projects/spring-boot/labels/status:%20waiting-for-triage","name":"status: waiting-for-triage","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-13T19:53:55Z","updated_at":"2018-10-13T19:53:55Z","closed_at":null,"author_association":"MEMBER","body":"The properties for Humio metrics export include a `Map<String, String>` property with a default value:\r\n\r\n```\r\n/**\r\n * Humio tags describing the datasource in which metrics will be stored. Humio tags\r\n * are a distinct concept from Micrometer's tags. Micrometer's tags are used to divide\r\n * metrics along dimensional boundaries.\r\n */\r\nprivate Map<String, String> tags = new HashMap<>(\r\n\t\tCollections.singletonMap(\"name\", \"micrometer\"));\r\n```\r\n\r\nThis default is required to match the default in Micrometer's `HumioConfig`. The resulting configuration property metadata does to include the default value:\r\n\r\n```\r\n{\r\n      \"name\": \"management.metrics.export.humio.tags\",\r\n      \"type\": \"java.util.Map<java.lang.String,java.lang.String>\",\r\n      \"description\": \"Humio tags describing the datasource in which metrics will be stored. Humio tags are a distinct concept from Micrometer's tags. Micrometer's tags are used to divide metrics along dimensional boundaries.\",\r\n      \"sourceType\": \"org.springframework.boot.actuate.autoconfigure.metrics.export.humio.HumioProperties\"\r\n},\r\n```\r\n\r\nI'm not sure if it's possible for the annotation processor to capture the default in the case and, even if it could, what form the default should then take in the JSON. However, it would be good to be able to offer something so that users are aware of the default.\r\n\r\nThe work in progress to add support for Humio is in [this branch](https://github.com/wilkinsona/spring-boot/tree/gh-14804)."}}
{"actor":{"display_login":"wilkinsona"}}