{"push_id":2581260950,"size":21,"distinct_size":16,"ref":"refs/heads/master","head":"cc4511e1be866da968b94432d7537cf2bba5af3b","before":"95ee77fcad61cec8ca8f3a4a1f7155afc37cb9a7","commits":[{"sha":"5390b0f1e8566d2a361ebea5b9cb82c6febb3b68","author":{"name":"Ben Darnell","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@cockroachlabs.com"},"message":"storage: Remove COCKROACH_ENABLE_TICK_QUIESCED\n\nThis is no longer used\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/5390b0f1e8566d2a361ebea5b9cb82c6febb3b68"},{"sha":"65139caa0069c0bfa7e72cf8ef332661a4f313c5","author":{"name":"Ben Darnell","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@cockroachlabs.com"},"message":"syncutil: Document that nil values are not supported.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/65139caa0069c0bfa7e72cf8ef332661a4f313c5"},{"sha":"f4c5e3cd9448e82ec2025d944764d87b94a09edd","author":{"name":"Ben Darnell","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@cockroachlabs.com"},"message":"storage: Maintain a separate set of unquiesced replicas\n\nThis means that idle replicas no longer have a per-tick CPU cost,\nwhich is one of the bottlenecks limiting the amount of data we can\nhandle per store.\n\nFixes #17609\n\nRelease note (performance improvement): Reduced CPU overhead of idle\nranges","distinct":false,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/f4c5e3cd9448e82ec2025d944764d87b94a09edd"},{"sha":"52f22d7f2a0c27c036fb8176d7058b15d1ab4420","author":{"name":"Victor Chen","email":"88fa846e5f8aa198848be76e1abdcb7d7a42d292@cockroachlabs.com"},"message":"encryption: encrypt data written to disk by Distsql's temp engine.\n\nNow whenever distsql's temp engine writes to disk, the data written will be\nencrypted. This commit is part of the `use encryption for all local disk usage\n(non-logs)`.\n\nIssue: #19783.\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/52f22d7f2a0c27c036fb8176d7058b15d1ab4420"},{"sha":"8d2c9e9238c01980be73df3eee0e544a8fc9f5d7","author":{"name":"Ben Darnell","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@cockroachlabs.com"},"message":"roachtest: Manually install the jepsen package\n\nThis is necessary to depend on the head revision of a package in the\nsame repo.\n\nAlso move the cloning/updating of the jepsen repo above the \"already\ninitialized\" check for ease of iteration (it's fast when the repo is\nalready there).\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/8d2c9e9238c01980be73df3eee0e544a8fc9f5d7"},{"sha":"e923830d50f82f944b2c28976a8e64678294c46b","author":{"name":"Jordan Lewis","email":"d6a9c9ceebab0a60eea8692fb0aa04be2d19ee67@gmail.com"},"message":"sql: add the array_to_string builtin\n\nThis is used to join values in an array with a delimiter into a string,\nwith an optional null replacement string.\n\nRelease note (sql change): add the array_to_string builtin function.","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/e923830d50f82f944b2c28976a8e64678294c46b"},{"sha":"06a4201eae66a20b6ac8b5769bf0a876396bc1cd","author":{"name":"Andrew Kimball","email":"47fb46b442a7228b0951bd0a39a9bd256934d92d@cockroachlabs.com"},"message":"sql: Split SqlLite tests from main TestLogic tests\n\nDuring our nightly runs, we pass the -bigtest flag to the main\nLogicTest. This causes it to run a completely different set of\ntests, pulled from a fork of:\n\n  https://github.com/cockroachdb/sqllogictest\n\nThis commit segregates those tests into a new top level go test,\ncalled TestSqlLiteLogic. The -bigtest flag is still required in\norder to run the test, since it takes too long to run by default.\n\nThis commit prepares the way for separating out other aspects of\nthe monolithic TestLogic test, such as variations that are intended\nto test the 2.0 heuristic planner. Eventually, we will get to a\npoint where TestLogic only tests the correctness of relational\noutput, rather than the specifics of how that output was derived.\nThis will allow the 2.0 heuristic planner and the 2.1 cost-based\noptimizer to share these tests.\n\nOther aspects of our testing that cannot be easily shared can go\ninto other top-level tests.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/06a4201eae66a20b6ac8b5769bf0a876396bc1cd"},{"sha":"9ba2fd738834e9047bcee5346457d9f61a23a4ad","author":{"name":"Radu Berinde","email":"8cd32adbfdfb986a6f0d684f7a16030a20d97029@cockroachlabs.com"},"message":"sql: fix null normalization\n\nThe normalization rules are happy to convert `NULL::TEXT` to `NULL`.\nWhile both expressions evaluate to `DNull`, the `ResolvedType()` is\ndifferent. It seems unsound for normalization to change the type.\n\nThis issue is shown by trying to run a query containing\n`ARRAY_AGG(NULL::TEXT)` through distsql planning: by the time the\ndistsql planner looks at it, the `NULL::TEXT` is just `DNull` (with\nthe `Unknown` type) and the distsql planner cannot find the builtin.\n\nThis change fixes the normalization rules by retaining the cast in\nthis case. In general, any expression that statically evaluates to\nNULL gets a cast to the original expression type. The same is done in\nthe opt execbuilder.\n\nFixes #25724.\n\nRelease note (bug fix): Fixed query errors in some cases involving a\nNULL constant that is cast to a specific type.","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/9ba2fd738834e9047bcee5346457d9f61a23a4ad"},{"sha":"e1f8e98e44930ad257ac6cb9e8d663919796faca","author":{"name":"Peter Mattis","email":"b25b72a65195e46aa49449589ffbea257ff840a3@gmail.com"},"message":"roachtest: include build branch in github issue title\n\nChange the github issue title to have the suffix \"failed on <branch>\".\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/e1f8e98e44930ad257ac6cb9e8d663919796faca"},{"sha":"bc426fdf2cf2742aafce4f016774d4163f810833","author":{"name":"Jordan Lewis","email":"d6a9c9ceebab0a60eea8692fb0aa04be2d19ee67@gmail.com"},"message":"sql: fix union of cols w/ mismatched type aliases\n\nPreviously, the ColumnType.Equals method provided by protobuf generated\ncode was used to compare column types for equality when determining\nwhether two DistSQL streams were mergeable. This was incorrect because\ncolumn types can have type aliases known as VisibleTypes, which might\nnot match despite the underlying column types being equal. An example is\nthe column types INT and INTEGER. We preserve the difference between\nthose two, so that SHOW CREATE TABLE produces the same output as the\noriginal CREATE TABLE.\n\nTo fix this, a new ColumnType.Equivalent method is introduced that\nignores the VisibleType field on ColumnTypes.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/bc426fdf2cf2742aafce4f016774d4163f810833"},{"sha":"7e80c8b5db10fa64cf26789b5204f96b873fb496","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #25720\n\n25720: sql: fix union of cols w/ mismatched type aliases r=jordanlewis a=jordanlewis\n\nPreviously, the ColumnType.Equals method provided by protobuf generated\r\ncode was used to compare column types for equality when determining\r\nwhether two DistSQL streams were mergeable. This was incorrect because\r\ncolumn types can have type aliases known as VisibleTypes, which might\r\nnot match despite the underlying column types being equal. An example is\r\nthe column types INT and INTEGER. We preserve the difference between\r\nthose two, so that SHOW CREATE TABLE produces the same output as the\r\noriginal CREATE TABLE.\r\n\r\nTo fix this, a new ColumnType.Equivalent method is introduced that\r\nignores the VisibleType field on ColumnTypes.\r\n\r\nFixes #25674.\r\n\r\nRelease note: None\n\nCo-authored-by: Jordan Lewis <jordanthelewis@gmail.com>","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/7e80c8b5db10fa64cf26789b5204f96b873fb496"},{"sha":"a77ec802d5671f56f3ed6930bb7b71d21a95f095","author":{"name":"Ben Darnell","email":"73675debcd8a436be48ec22211dcf44fe0df0a64@cockroachlabs.com"},"message":"storage: Refactor maybeCampaignOnWakeLocked for testability\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/a77ec802d5671f56f3ed6930bb7b71d21a95f095"},{"sha":"7bf4aa451d2e7b2da13eb1f31af2f98bcd4646ea","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #25739\n\n25739: roachtest: include build branch in github issue title r=tschottdorf a=petermattis\n\nChange the github issue title to have the suffix \"failed on <branch>\".\n\nRelease note: None\n\nCo-authored-by: Peter Mattis <petermattis@gmail.com>","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/7bf4aa451d2e7b2da13eb1f31af2f98bcd4646ea"},{"sha":"7527b0ee641ce094441a255ac31a30db658d2439","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #25681\n\n25681: sql: add the array_to_string builtin r=jordanlewis a=jordanlewis\n\nThis is used to join values in an array with a delimiter into a string,\r\nwith an optional null replacement string.\r\n\r\nFixes #23774.\r\n\r\nRelease note (sql change): add the array_to_string builtin function.\n\nCo-authored-by: Jordan Lewis <jordanthelewis@gmail.com>","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/7527b0ee641ce094441a255ac31a30db658d2439"},{"sha":"14236e0225a7ac420c563a6e794b022a619adc15","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #25639\n\n25639: roachtest: Manually install the jepsen package r=bdarnell a=bdarnell\n\nThis is necessary to depend on the head revision of a package in the\r\nsame repo.\r\n\r\nAlso move the cloning/updating of the jepsen repo above the \"already\r\ninitialized\" check for ease of iteration (it's fast when the repo is\r\nalready there).\r\n\r\nRelease note: None\n\nCo-authored-by: Ben Darnell <ben@cockroachlabs.com>","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/14236e0225a7ac420c563a6e794b022a619adc15"},{"sha":"e742b092aa189cfcdf55c94da7f38031b625bb25","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #25591\n\n25591: encryption: encrypt data written to disk by Distsql's temp engine. r=windchan7 a=windchan7\n\nNow whenever distsql's temp engine writes to disk, the data written will be\r\nencrypted. This commit is part of the `use encryption for all local disk usage\r\n(non-logs)`.\r\n\r\nIssue: #19783.\r\nRelease note: None\n\nCo-authored-by: Victor Chen <victor@cockroachlabs.com>","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/e742b092aa189cfcdf55c94da7f38031b625bb25"},{"sha":"377ad18f4545fcdc3d04cd7e9bfbc7c9b0084892","author":{"name":"Daniel Harrison","email":"3a2f0da2a0c450062f2df795b8346ad513a9734a@gmail.com"},"message":"sqlbase: add \"sideband\" data to RowFetcher\n\nImmediatly after NextRow returns a non-nil row, then RowLastModified can\nbe called to get the timestamp of the last modification to that row.\n\nSimilarly, RowIsDeleted can be called to find out whether the just\nreturned row was deleted (which can only happen with alternate kvFetcher\nimplementations that return kv tombstones).\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/377ad18f4545fcdc3d04cd7e9bfbc7c9b0084892"},{"sha":"908de5da21fc7864dea319c459e376623ac40bd2","author":{"name":"Daniel Harrison","email":"3a2f0da2a0c450062f2df795b8346ad513a9734a@gmail.com"},"message":"changefeedccl: support DELETEs in changefeeds\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/908de5da21fc7864dea319c459e376623ac40bd2"},{"sha":"d865309fc53eb86afdf90b12363acab641ea98c4","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #24956 #25735\n\n24956: storage: Maintain a separate set of unquiesced replicas r=petermattis a=bdarnell\n\nThis means that idle replicas no longer have a per-tick CPU cost,\r\nwhich is one of the bottlenecks limiting the amount of data we can\r\nhandle per store.\r\n\r\nFixes #17609\r\n\r\nRelease note (performance improvement): Reduced CPU overhead of idle\r\nranges\r\n\r\n\r\nThe first five commits are from #24920; that PR should be merged and tested in isolation first. \n\n25735: sql: fix null normalization r=RaduBerinde a=RaduBerinde\n\nThe normalization rules are happy to convert `NULL::TEXT` to `NULL`.\r\nWhile both expressions evaluate to `DNull`, the `ResolvedType()` is\r\ndifferent. It seems unsound for normalization to change the type.\r\n\r\nThis issue is shown by trying to run a query containing\r\n`ARRAY_AGG(NULL::TEXT)` through distsql planning: by the time the\r\ndistsql planner looks at it, the `NULL::TEXT` is just `DNull` (with\r\nthe `Unknown` type) and the distsql planner cannot find the builtin.\r\n\r\nThis change fixes the normalization rules by retaining the cast in\r\nthis case. In general, any expression that statically evaluates to\r\nNULL gets a cast to the original expression type. The same is done in\r\nthe opt execbuilder.\r\n\r\nFixes #25724.\r\n\r\nRelease note (bug fix): Fixed query errors in some cases involving a\r\nNULL constant that is cast to a specific type.\n\nCo-authored-by: Ben Darnell <ben@cockroachlabs.com>\nCo-authored-by: Radu Berinde <radu@cockroachlabs.com>","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/d865309fc53eb86afdf90b12363acab641ea98c4"},{"sha":"d63c890209258405da614e70dbf2cd191a2b3073","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #25727\n\n25727: changefeedccl: support DELETEs r=jordanlewis a=danhhz\n\n@jordanlewis This is almost entirely RowFetcher changes; mind taking a look? I also need to figure out how we're going to do the continuous table leasing that changefeeds will need, which is much larger surgery. Happy to step back and discuss the approach if you're not feeling it.\n\nCo-authored-by: Daniel Harrison <daniel.harrison@gmail.com>","distinct":true,"url":"https://api.github.com/repos/bdarnell/cockroach/commits/d63c890209258405da614e70dbf2cd191a2b3073"}]}
{"actor":{"display_login":"bdarnell"}}