{"action":"created","comment":{"url":"https://api.github.com/repos/resin-io/etcher/pulls/comments/189858833","pull_request_review_id":122116353,"id":189858833,"diff_hunk":"@@ -41,8 +45,27 @@ module.exports = function (\n    * @example\n    * FileSelectorController.getFolderConstraint()\n    */\n-  this.getFolderConstraint = () => {\n+  this.getFolderConstraints = utils.memoize(() => {\n     // TODO(Shou): get this dynamically from the mountpoint of a specific port in Etcher Pro\n+    // FIXME(Shou): splitting on ',' is unsafe","path":"lib/gui/app/components/file-selector/controllers/file-selector.js","position":18,"original_position":18,"commit_id":"ce0898dc0305be6ec978b2de8dca16529d8e9143","original_commit_id":"ce0898dc0305be6ec978b2de8dca16529d8e9143","user":{"login":"lurch","id":476186,"avatar_url":"https://avatars2.githubusercontent.com/u/476186?v=4","gravatar_id":"","url":"https://api.github.com/users/lurch","html_url":"https://github.com/lurch","followers_url":"https://api.github.com/users/lurch/followers","following_url":"https://api.github.com/users/lurch/following{/other_user}","gists_url":"https://api.github.com/users/lurch/gists{/gist_id}","starred_url":"https://api.github.com/users/lurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lurch/subscriptions","organizations_url":"https://api.github.com/users/lurch/orgs","repos_url":"https://api.github.com/users/lurch/repos","events_url":"https://api.github.com/users/lurch/events{/privacy}","received_events_url":"https://api.github.com/users/lurch/received_events","type":"User","site_admin":false},"body":"On Unix, the `$PATH` variable is separated by `:` characters, on Windows the `%PATH%` variable is separated by `;` characters. Might make sense to re-use those semantics in Etcher?","created_at":"2018-05-22T10:57:32Z","updated_at":"2018-05-22T10:57:32Z","html_url":"https://github.com/resin-io/etcher/pull/2362#discussion_r189858833","pull_request_url":"https://api.github.com/repos/resin-io/etcher/pulls/2362","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/resin-io/etcher/pulls/comments/189858833"},"html":{"href":"https://github.com/resin-io/etcher/pull/2362#discussion_r189858833"},"pull_request":{"href":"https://api.github.com/repos/resin-io/etcher/pulls/2362"}}},"pull_request":{"url":"https://api.github.com/repos/resin-io/etcher/pulls/2362","id":189621532,"html_url":"https://github.com/resin-io/etcher/pull/2362","diff_url":"https://github.com/resin-io/etcher/pull/2362.diff","patch_url":"https://github.com/resin-io/etcher/pull/2362.patch","issue_url":"https://api.github.com/repos/resin-io/etcher/issues/2362","number":2362,"state":"open","locked":false,"title":"fix(GUI): file-picker performance and design improvements","user":{"login":"Shou","id":819413,"avatar_url":"https://avatars1.githubusercontent.com/u/819413?v=4","gravatar_id":"","url":"https://api.github.com/users/Shou","html_url":"https://github.com/Shou","followers_url":"https://api.github.com/users/Shou/followers","following_url":"https://api.github.com/users/Shou/following{/other_user}","gists_url":"https://api.github.com/users/Shou/gists{/gist_id}","starred_url":"https://api.github.com/users/Shou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shou/subscriptions","organizations_url":"https://api.github.com/users/Shou/orgs","repos_url":"https://api.github.com/users/Shou/repos","events_url":"https://api.github.com/users/Shou/events{/privacy}","received_events_url":"https://api.github.com/users/Shou/received_events","type":"User","site_admin":false},"body":"- Replace onClick arrow functions in all components that use them for\r\n  efficiency reasons: 5-3x speed-up\r\n- Sort by folders and ignore case for better UX\r\n- Remove use of `rendition.Button` in files\r\n- Proper sidebar width and spacing\r\n- Recents and favorites are now filtered by existence async for a tiny\r\n  performance improvement\r\n- Make Breadcrumbs a pure component to stop frequent re-rendering\r\n- Initial support for array constraints\r\n- Use first constraint as initial path instead of homedir if a\r\n  constraint is set\r\n- Use correct design height on modal, `calc(100vh - 20px)`\r\n- Reset scroll position when browsing a new folder\r\n\r\nChange-Type: patch","created_at":"2018-05-22T10:51:39Z","updated_at":"2018-05-22T10:57:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"799397d5193a00167d90e61056d2714c7dbaf987","assignee":{"login":"Shou","id":819413,"avatar_url":"https://avatars1.githubusercontent.com/u/819413?v=4","gravatar_id":"","url":"https://api.github.com/users/Shou","html_url":"https://github.com/Shou","followers_url":"https://api.github.com/users/Shou/followers","following_url":"https://api.github.com/users/Shou/following{/other_user}","gists_url":"https://api.github.com/users/Shou/gists{/gist_id}","starred_url":"https://api.github.com/users/Shou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shou/subscriptions","organizations_url":"https://api.github.com/users/Shou/orgs","repos_url":"https://api.github.com/users/Shou/repos","events_url":"https://api.github.com/users/Shou/events{/privacy}","received_events_url":"https://api.github.com/users/Shou/received_events","type":"User","site_admin":false},"assignees":[{"login":"Shou","id":819413,"avatar_url":"https://avatars1.githubusercontent.com/u/819413?v=4","gravatar_id":"","url":"https://api.github.com/users/Shou","html_url":"https://github.com/Shou","followers_url":"https://api.github.com/users/Shou/followers","following_url":"https://api.github.com/users/Shou/following{/other_user}","gists_url":"https://api.github.com/users/Shou/gists{/gist_id}","starred_url":"https://api.github.com/users/Shou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shou/subscriptions","organizations_url":"https://api.github.com/users/Shou/orgs","repos_url":"https://api.github.com/users/Shou/repos","events_url":"https://api.github.com/users/Shou/events{/privacy}","received_events_url":"https://api.github.com/users/Shou/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"zvin","id":180331,"avatar_url":"https://avatars2.githubusercontent.com/u/180331?v=4","gravatar_id":"","url":"https://api.github.com/users/zvin","html_url":"https://github.com/zvin","followers_url":"https://api.github.com/users/zvin/followers","following_url":"https://api.github.com/users/zvin/following{/other_user}","gists_url":"https://api.github.com/users/zvin/gists{/gist_id}","starred_url":"https://api.github.com/users/zvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zvin/subscriptions","organizations_url":"https://api.github.com/users/zvin/orgs","repos_url":"https://api.github.com/users/zvin/repos","events_url":"https://api.github.com/users/zvin/events{/privacy}","received_events_url":"https://api.github.com/users/zvin/received_events","type":"User","site_admin":false},{"login":"jhermsmeier","id":244907,"avatar_url":"https://avatars3.githubusercontent.com/u/244907?v=4","gravatar_id":"","url":"https://api.github.com/users/jhermsmeier","html_url":"https://github.com/jhermsmeier","followers_url":"https://api.github.com/users/jhermsmeier/followers","following_url":"https://api.github.com/users/jhermsmeier/following{/other_user}","gists_url":"https://api.github.com/users/jhermsmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/jhermsmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhermsmeier/subscriptions","organizations_url":"https://api.github.com/users/jhermsmeier/orgs","repos_url":"https://api.github.com/users/jhermsmeier/repos","events_url":"https://api.github.com/users/jhermsmeier/events{/privacy}","received_events_url":"https://api.github.com/users/jhermsmeier/received_events","type":"User","site_admin":false},{"login":"curcuz","id":2338223,"avatar_url":"https://avatars3.githubusercontent.com/u/2338223?v=4","gravatar_id":"","url":"https://api.github.com/users/curcuz","html_url":"https://github.com/curcuz","followers_url":"https://api.github.com/users/curcuz/followers","following_url":"https://api.github.com/users/curcuz/following{/other_user}","gists_url":"https://api.github.com/users/curcuz/gists{/gist_id}","starred_url":"https://api.github.com/users/curcuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curcuz/subscriptions","organizations_url":"https://api.github.com/users/curcuz/orgs","repos_url":"https://api.github.com/users/curcuz/repos","events_url":"https://api.github.com/users/curcuz/events{/privacy}","received_events_url":"https://api.github.com/users/curcuz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":310247012,"url":"https://api.github.com/repos/resin-io/etcher/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/resin-io/etcher/pulls/2362/commits","review_comments_url":"https://api.github.com/repos/resin-io/etcher/pulls/2362/comments","review_comment_url":"https://api.github.com/repos/resin-io/etcher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/resin-io/etcher/issues/2362/comments","statuses_url":"https://api.github.com/repos/resin-io/etcher/statuses/ce0898dc0305be6ec978b2de8dca16529d8e9143","head":{"label":"resin-io:file-picker-performance","ref":"file-picker-performance","sha":"ce0898dc0305be6ec978b2de8dca16529d8e9143","user":{"login":"resin-io","id":6157842,"avatar_url":"https://avatars1.githubusercontent.com/u/6157842?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io","html_url":"https://github.com/resin-io","followers_url":"https://api.github.com/users/resin-io/followers","following_url":"https://api.github.com/users/resin-io/following{/other_user}","gists_url":"https://api.github.com/users/resin-io/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io/subscriptions","organizations_url":"https://api.github.com/users/resin-io/orgs","repos_url":"https://api.github.com/users/resin-io/repos","events_url":"https://api.github.com/users/resin-io/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io/received_events","type":"Organization","site_admin":false},"repo":{"id":45055693,"name":"etcher","full_name":"resin-io/etcher","owner":{"login":"resin-io","id":6157842,"avatar_url":"https://avatars1.githubusercontent.com/u/6157842?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io","html_url":"https://github.com/resin-io","followers_url":"https://api.github.com/users/resin-io/followers","following_url":"https://api.github.com/users/resin-io/following{/other_user}","gists_url":"https://api.github.com/users/resin-io/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io/subscriptions","organizations_url":"https://api.github.com/users/resin-io/orgs","repos_url":"https://api.github.com/users/resin-io/repos","events_url":"https://api.github.com/users/resin-io/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resin-io/etcher","description":"Flash OS images to SD cards & USB drives, safely and easily.","fork":false,"url":"https://api.github.com/repos/resin-io/etcher","forks_url":"https://api.github.com/repos/resin-io/etcher/forks","keys_url":"https://api.github.com/repos/resin-io/etcher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io/etcher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io/etcher/teams","hooks_url":"https://api.github.com/repos/resin-io/etcher/hooks","issue_events_url":"https://api.github.com/repos/resin-io/etcher/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io/etcher/events","assignees_url":"https://api.github.com/repos/resin-io/etcher/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io/etcher/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io/etcher/tags","blobs_url":"https://api.github.com/repos/resin-io/etcher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io/etcher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io/etcher/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io/etcher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io/etcher/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io/etcher/languages","stargazers_url":"https://api.github.com/repos/resin-io/etcher/stargazers","contributors_url":"https://api.github.com/repos/resin-io/etcher/contributors","subscribers_url":"https://api.github.com/repos/resin-io/etcher/subscribers","subscription_url":"https://api.github.com/repos/resin-io/etcher/subscription","commits_url":"https://api.github.com/repos/resin-io/etcher/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io/etcher/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io/etcher/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io/etcher/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io/etcher/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io/etcher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io/etcher/merges","archive_url":"https://api.github.com/repos/resin-io/etcher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io/etcher/downloads","issues_url":"https://api.github.com/repos/resin-io/etcher/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io/etcher/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io/etcher/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io/etcher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io/etcher/labels{/name}","releases_url":"https://api.github.com/repos/resin-io/etcher/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io/etcher/deployments","created_at":"2015-10-27T16:53:23Z","updated_at":"2018-05-22T09:59:19Z","pushed_at":"2018-05-22T10:56:48Z","git_url":"git://github.com/resin-io/etcher.git","ssh_url":"git@github.com:resin-io/etcher.git","clone_url":"https://github.com/resin-io/etcher.git","svn_url":"https://github.com/resin-io/etcher","homepage":"https://etcher.io","size":88062,"stargazers_count":10942,"watchers_count":10942,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":533,"mirror_url":null,"archived":false,"open_issues_count":246,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":533,"open_issues":246,"watchers":10942,"default_branch":"master"}},"base":{"label":"resin-io:master","ref":"master","sha":"d9a773051149dfcc06280a92269597c3ee776eab","user":{"login":"resin-io","id":6157842,"avatar_url":"https://avatars1.githubusercontent.com/u/6157842?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io","html_url":"https://github.com/resin-io","followers_url":"https://api.github.com/users/resin-io/followers","following_url":"https://api.github.com/users/resin-io/following{/other_user}","gists_url":"https://api.github.com/users/resin-io/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io/subscriptions","organizations_url":"https://api.github.com/users/resin-io/orgs","repos_url":"https://api.github.com/users/resin-io/repos","events_url":"https://api.github.com/users/resin-io/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io/received_events","type":"Organization","site_admin":false},"repo":{"id":45055693,"name":"etcher","full_name":"resin-io/etcher","owner":{"login":"resin-io","id":6157842,"avatar_url":"https://avatars1.githubusercontent.com/u/6157842?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io","html_url":"https://github.com/resin-io","followers_url":"https://api.github.com/users/resin-io/followers","following_url":"https://api.github.com/users/resin-io/following{/other_user}","gists_url":"https://api.github.com/users/resin-io/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io/subscriptions","organizations_url":"https://api.github.com/users/resin-io/orgs","repos_url":"https://api.github.com/users/resin-io/repos","events_url":"https://api.github.com/users/resin-io/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resin-io/etcher","description":"Flash OS images to SD cards & USB drives, safely and easily.","fork":false,"url":"https://api.github.com/repos/resin-io/etcher","forks_url":"https://api.github.com/repos/resin-io/etcher/forks","keys_url":"https://api.github.com/repos/resin-io/etcher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io/etcher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io/etcher/teams","hooks_url":"https://api.github.com/repos/resin-io/etcher/hooks","issue_events_url":"https://api.github.com/repos/resin-io/etcher/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io/etcher/events","assignees_url":"https://api.github.com/repos/resin-io/etcher/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io/etcher/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io/etcher/tags","blobs_url":"https://api.github.com/repos/resin-io/etcher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io/etcher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io/etcher/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io/etcher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io/etcher/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io/etcher/languages","stargazers_url":"https://api.github.com/repos/resin-io/etcher/stargazers","contributors_url":"https://api.github.com/repos/resin-io/etcher/contributors","subscribers_url":"https://api.github.com/repos/resin-io/etcher/subscribers","subscription_url":"https://api.github.com/repos/resin-io/etcher/subscription","commits_url":"https://api.github.com/repos/resin-io/etcher/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io/etcher/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io/etcher/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io/etcher/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io/etcher/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io/etcher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io/etcher/merges","archive_url":"https://api.github.com/repos/resin-io/etcher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io/etcher/downloads","issues_url":"https://api.github.com/repos/resin-io/etcher/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io/etcher/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io/etcher/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io/etcher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io/etcher/labels{/name}","releases_url":"https://api.github.com/repos/resin-io/etcher/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io/etcher/deployments","created_at":"2015-10-27T16:53:23Z","updated_at":"2018-05-22T09:59:19Z","pushed_at":"2018-05-22T10:56:48Z","git_url":"git://github.com/resin-io/etcher.git","ssh_url":"git@github.com:resin-io/etcher.git","clone_url":"https://github.com/resin-io/etcher.git","svn_url":"https://github.com/resin-io/etcher","homepage":"https://etcher.io","size":88062,"stargazers_count":10942,"watchers_count":10942,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":533,"mirror_url":null,"archived":false,"open_issues_count":246,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":533,"open_issues":246,"watchers":10942,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/resin-io/etcher/pulls/2362"},"html":{"href":"https://github.com/resin-io/etcher/pull/2362"},"issue":{"href":"https://api.github.com/repos/resin-io/etcher/issues/2362"},"comments":{"href":"https://api.github.com/repos/resin-io/etcher/issues/2362/comments"},"review_comments":{"href":"https://api.github.com/repos/resin-io/etcher/pulls/2362/comments"},"review_comment":{"href":"https://api.github.com/repos/resin-io/etcher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/resin-io/etcher/pulls/2362/commits"},"statuses":{"href":"https://api.github.com/repos/resin-io/etcher/statuses/ce0898dc0305be6ec978b2de8dca16529d8e9143"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lurch"}}