{"action":"created","issue":{"url":"https://api.github.com/repos/xamarin/xamarin-android-api-compatibility/issues/14","repository_url":"https://api.github.com/repos/xamarin/xamarin-android-api-compatibility","labels_url":"https://api.github.com/repos/xamarin/xamarin-android-api-compatibility/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/xamarin/xamarin-android-api-compatibility/issues/14/comments","events_url":"https://api.github.com/repos/xamarin/xamarin-android-api-compatibility/issues/14/events","html_url":"https://github.com/xamarin/xamarin-android-api-compatibility/pull/14","id":297174750,"number":14,"title":"Abstractify old webkit api","user":{"login":"atsushieno","id":53929,"avatar_url":"https://avatars3.githubusercontent.com/u/53929?v=4","gravatar_id":"","url":"https://api.github.com/users/atsushieno","html_url":"https://github.com/atsushieno","followers_url":"https://api.github.com/users/atsushieno/followers","following_url":"https://api.github.com/users/atsushieno/following{/other_user}","gists_url":"https://api.github.com/users/atsushieno/gists{/gist_id}","starred_url":"https://api.github.com/users/atsushieno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atsushieno/subscriptions","organizations_url":"https://api.github.com/users/atsushieno/orgs","repos_url":"https://api.github.com/users/atsushieno/repos","events_url":"https://api.github.com/users/atsushieno/events{/privacy}","received_events_url":"https://api.github.com/users/atsushieno/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-14T17:09:01Z","updated_at":"2018-02-23T07:02:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/xamarin/xamarin-android-api-compatibility/pulls/14","html_url":"https://github.com/xamarin/xamarin-android-api-compatibility/pull/14","diff_url":"https://github.com/xamarin/xamarin-android-api-compatibility/pull/14.diff","patch_url":"https://github.com/xamarin/xamarin-android-api-compatibility/pull/14.patch"},"body":"As part of discussion at https://github.com/xamarin/xamarin-android/pull/1078#issuecomment-365187452 ,\r\nwe decided to make changes to those inconsistent methods that used to be\r\nvirtual and then became abstract, to become abstract even in old API level.\r\n\r\nIt is done at metadata fixup level.\r\n\r\n(copying the commitmsg from https://github.com/xamarin/xamarin-android/pull/1304)"},"comment":{"url":"https://api.github.com/repos/xamarin/xamarin-android-api-compatibility/issues/comments/367927553","html_url":"https://github.com/xamarin/xamarin-android-api-compatibility/pull/14#issuecomment-367927553","issue_url":"https://api.github.com/repos/xamarin/xamarin-android-api-compatibility/issues/14","id":367927553,"user":{"login":"atsushieno","id":53929,"avatar_url":"https://avatars3.githubusercontent.com/u/53929?v=4","gravatar_id":"","url":"https://api.github.com/users/atsushieno","html_url":"https://github.com/atsushieno","followers_url":"https://api.github.com/users/atsushieno/followers","following_url":"https://api.github.com/users/atsushieno/following{/other_user}","gists_url":"https://api.github.com/users/atsushieno/gists{/gist_id}","starred_url":"https://api.github.com/users/atsushieno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atsushieno/subscriptions","organizations_url":"https://api.github.com/users/atsushieno/orgs","repos_url":"https://api.github.com/users/atsushieno/repos","events_url":"https://api.github.com/users/atsushieno/events{/privacy}","received_events_url":"https://api.github.com/users/atsushieno/received_events","type":"User","site_admin":false},"created_at":"2018-02-23T07:02:46Z","updated_at":"2018-02-23T07:02:46Z","author_association":"CONTRIBUTOR","body":"Not an exact output, but it is on what my changes are based (reported as inter-api diff between 8.0 and 8.1 as I didn't waste time on building everything on master):\r\n\r\n\t<h1>### API BREAK BETWEEN v8.0 and v8.1</h1>\r\n\t<!-- start namespace Android.Webkit --> <div> \r\n\t<h2>Namespace Android.Webkit</h2>\r\n\t<!-- start type WebHistoryItem --> <div>\r\n\t<h3>Type Changed: Android.Webkit.WebHistoryItem</h3>\r\n\t<p>Modified properties:</p>\r\n\t<pre>\r\n\t<div data-is-breaking>\tpublic <span class='added added-breaking-inline'>abstract</span> int Id { get; }\r\n\t</div></pre>\r\n\r\n\t</div> <!-- end type WebHistoryItem -->\r\n\t<!-- start type WebSettings --> <div>\r\n\t<h3>Type Changed: Android.Webkit.WebSettings</h3>\r\n\t<p>Modified properties:</p>\r\n\t<pre>\r\n\t<div data-is-breaking>\tpublic <span class='added added-breaking-inline'>abstract</span> bool NavDump { get; set; }\r\n\t</div><div data-is-breaking>\tpublic <span class='added added-breaking-inline'>abstract</span> bool PluginsEnabled { get; set; }\r\n\t</div><div data-is-breaking>\tpublic <span class='added added-breaking-inline'>abstract</span> string PluginsPath { get; set; }\r\n\t</div><div data-is-breaking>\tpublic <span class='added added-breaking-inline'>abstract</span> bool UseDoubleTree { get; set; }\r\n\t</div><div data-is-breaking>\tpublic <span class='added added-breaking-inline'>abstract</span> bool UseWebViewBackgroundForOverscrollBackground { get; set; }\r\n\t</div><div data-is-breaking>\tpublic <span class='added added-breaking-inline'>abstract</span> int UserAgent { get; set; }\r\n\t</div></pre>\r\n\t<p>Modified methods:</p>\r\n\t<pre>\r\n\t<div data-is-breaking>\tpublic <span class='added added-breaking-inline'>abstract</span> WebSettings.TextSize GetTextSize ()\r\n\t</div></pre>\r\n\r\n\t</div> <!-- end type WebSettings -->\r\n\r\n\t</div> <!-- end namespace Android.Webkit -->\r\n\tMakefile:122: recipe for target 'check-inter-api-level' failed\r\n"}}
{"actor":{"display_login":"atsushieno"}}