{"action":"created","comment":{"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/comments/212846738","pull_request_review_id":149558877,"id":212846738,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjg0NjczOA==","diff_hunk":"@@ -225,14 +225,14 @@ cpu_primary32_gdt_ptr:\n     .align  0x1000\n     .global cpu_boot32_page_tables_start\n cpu_boot32_page_tables_start:\n-    /* 0x3 = (IA32E_COMM_P_BIT | IA32E_COMM_RW_BIT) */\n+    /* 0x3 = (PAGE_PRESENT | PAGE_RW) */","path":"hypervisor/arch/x86/cpu_primary.S","position":5,"original_position":5,"commit_id":"527c570854dc092482014be6b270da26ec4eaba9","original_commit_id":"ed36c267e2d9dd54fec293f7facd8297854666e6","user":{"login":"lifeix","id":36348136,"node_id":"MDQ6VXNlcjM2MzQ4MTM2","avatar_url":"https://avatars3.githubusercontent.com/u/36348136?v=4","gravatar_id":"","url":"https://api.github.com/users/lifeix","html_url":"https://github.com/lifeix","followers_url":"https://api.github.com/users/lifeix/followers","following_url":"https://api.github.com/users/lifeix/following{/other_user}","gists_url":"https://api.github.com/users/lifeix/gists{/gist_id}","starred_url":"https://api.github.com/users/lifeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifeix/subscriptions","organizations_url":"https://api.github.com/users/lifeix/orgs","repos_url":"https://api.github.com/users/lifeix/repos","events_url":"https://api.github.com/users/lifeix/events{/privacy}","received_events_url":"https://api.github.com/users/lifeix/received_events","type":"User","site_admin":false},"body":"This is wants to set the hypervisor MMU page table attributes not guest EPT page table attributes.\r\nIt should use the Macro definition for hypervisor MMU page table attributes.\r\n","created_at":"2018-08-27T01:04:33Z","updated_at":"2018-08-27T01:04:33Z","html_url":"https://github.com/projectacrn/acrn-hypervisor/pull/1096#discussion_r212846738","pull_request_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/1096","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/comments/212846738"},"html":{"href":"https://github.com/projectacrn/acrn-hypervisor/pull/1096#discussion_r212846738"},"pull_request":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/1096"}},"in_reply_to_id":212659460},"pull_request":{"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/1096","id":210628243,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNjI4MjQz","html_url":"https://github.com/projectacrn/acrn-hypervisor/pull/1096","diff_url":"https://github.com/projectacrn/acrn-hypervisor/pull/1096.diff","patch_url":"https://github.com/projectacrn/acrn-hypervisor/pull/1096.patch","issue_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/1096","number":1096,"state":"open","locked":false,"title":"Mmu: cleanup mmu.h","user":{"login":"lifeix","id":36348136,"node_id":"MDQ6VXNlcjM2MzQ4MTM2","avatar_url":"https://avatars3.githubusercontent.com/u/36348136?v=4","gravatar_id":"","url":"https://api.github.com/users/lifeix","html_url":"https://github.com/lifeix","followers_url":"https://api.github.com/users/lifeix/followers","following_url":"https://api.github.com/users/lifeix/following{/other_user}","gists_url":"https://api.github.com/users/lifeix/gists{/gist_id}","starred_url":"https://api.github.com/users/lifeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifeix/subscriptions","organizations_url":"https://api.github.com/users/lifeix/orgs","repos_url":"https://api.github.com/users/lifeix/repos","events_url":"https://api.github.com/users/lifeix/events{/privacy}","received_events_url":"https://api.github.com/users/lifeix/received_events","type":"User","site_admin":false},"body":"Since we reshuffle mmu code, there're many MACRO or structure we don't use \r\nany more in mmu.h. This serial try to remove them and replace the outdated\r\nwith the new one.","created_at":"2018-08-24T03:12:16Z","updated_at":"2018-08-27T01:04:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e71e613a6931d36ade5b1afde3350fd9dc758385","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anthonyzxu","id":17092385,"node_id":"MDQ6VXNlcjE3MDkyMzg1","avatar_url":"https://avatars2.githubusercontent.com/u/17092385?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonyzxu","html_url":"https://github.com/anthonyzxu","followers_url":"https://api.github.com/users/anthonyzxu/followers","following_url":"https://api.github.com/users/anthonyzxu/following{/other_user}","gists_url":"https://api.github.com/users/anthonyzxu/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonyzxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonyzxu/subscriptions","organizations_url":"https://api.github.com/users/anthonyzxu/orgs","repos_url":"https://api.github.com/users/anthonyzxu/repos","events_url":"https://api.github.com/users/anthonyzxu/events{/privacy}","received_events_url":"https://api.github.com/users/anthonyzxu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/1096/commits","review_comments_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/1096/comments","review_comment_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/1096/comments","statuses_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/statuses/527c570854dc092482014be6b270da26ec4eaba9","head":{"label":"lifeix:mmu","ref":"mmu","sha":"527c570854dc092482014be6b270da26ec4eaba9","user":{"login":"lifeix","id":36348136,"node_id":"MDQ6VXNlcjM2MzQ4MTM2","avatar_url":"https://avatars3.githubusercontent.com/u/36348136?v=4","gravatar_id":"","url":"https://api.github.com/users/lifeix","html_url":"https://github.com/lifeix","followers_url":"https://api.github.com/users/lifeix/followers","following_url":"https://api.github.com/users/lifeix/following{/other_user}","gists_url":"https://api.github.com/users/lifeix/gists{/gist_id}","starred_url":"https://api.github.com/users/lifeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifeix/subscriptions","organizations_url":"https://api.github.com/users/lifeix/orgs","repos_url":"https://api.github.com/users/lifeix/repos","events_url":"https://api.github.com/users/lifeix/events{/privacy}","received_events_url":"https://api.github.com/users/lifeix/received_events","type":"User","site_admin":false},"repo":{"id":125153397,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUxNTMzOTc=","name":"acrn-hypervisor","full_name":"lifeix/acrn-hypervisor","owner":{"login":"lifeix","id":36348136,"node_id":"MDQ6VXNlcjM2MzQ4MTM2","avatar_url":"https://avatars3.githubusercontent.com/u/36348136?v=4","gravatar_id":"","url":"https://api.github.com/users/lifeix","html_url":"https://github.com/lifeix","followers_url":"https://api.github.com/users/lifeix/followers","following_url":"https://api.github.com/users/lifeix/following{/other_user}","gists_url":"https://api.github.com/users/lifeix/gists{/gist_id}","starred_url":"https://api.github.com/users/lifeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifeix/subscriptions","organizations_url":"https://api.github.com/users/lifeix/orgs","repos_url":"https://api.github.com/users/lifeix/repos","events_url":"https://api.github.com/users/lifeix/events{/privacy}","received_events_url":"https://api.github.com/users/lifeix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lifeix/acrn-hypervisor","description":"Project ACRN hypervisor ","fork":true,"url":"https://api.github.com/repos/lifeix/acrn-hypervisor","forks_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/forks","keys_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/teams","hooks_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/hooks","issue_events_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/issues/events{/number}","events_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/events","assignees_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/assignees{/user}","branches_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/branches{/branch}","tags_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/tags","blobs_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/statuses/{sha}","languages_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/languages","stargazers_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/stargazers","contributors_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/contributors","subscribers_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/subscribers","subscription_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/subscription","commits_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/contents/{+path}","compare_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/merges","archive_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/downloads","issues_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/issues{/number}","pulls_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/pulls{/number}","milestones_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/milestones{/number}","notifications_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/labels{/name}","releases_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/releases{/id}","deployments_url":"https://api.github.com/repos/lifeix/acrn-hypervisor/deployments","created_at":"2018-03-14T04:06:04Z","updated_at":"2018-05-16T05:36:24Z","pushed_at":"2018-08-24T03:10:09Z","git_url":"git://github.com/lifeix/acrn-hypervisor.git","ssh_url":"git@github.com:lifeix/acrn-hypervisor.git","clone_url":"https://github.com/lifeix/acrn-hypervisor.git","svn_url":"https://github.com/lifeix/acrn-hypervisor","homepage":"","size":15099,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectacrn:master","ref":"master","sha":"7bc1a3f925c346dabeb165d9caf933f0bd1c7ed5","user":{"login":"projectacrn","id":36865262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2ODY1MjYy","avatar_url":"https://avatars1.githubusercontent.com/u/36865262?v=4","gravatar_id":"","url":"https://api.github.com/users/projectacrn","html_url":"https://github.com/projectacrn","followers_url":"https://api.github.com/users/projectacrn/followers","following_url":"https://api.github.com/users/projectacrn/following{/other_user}","gists_url":"https://api.github.com/users/projectacrn/gists{/gist_id}","starred_url":"https://api.github.com/users/projectacrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectacrn/subscriptions","organizations_url":"https://api.github.com/users/projectacrn/orgs","repos_url":"https://api.github.com/users/projectacrn/repos","events_url":"https://api.github.com/users/projectacrn/events{/privacy}","received_events_url":"https://api.github.com/users/projectacrn/received_events","type":"Organization","site_admin":false},"repo":{"id":123983554,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5ODM1NTQ=","name":"acrn-hypervisor","full_name":"projectacrn/acrn-hypervisor","owner":{"login":"projectacrn","id":36865262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2ODY1MjYy","avatar_url":"https://avatars1.githubusercontent.com/u/36865262?v=4","gravatar_id":"","url":"https://api.github.com/users/projectacrn","html_url":"https://github.com/projectacrn","followers_url":"https://api.github.com/users/projectacrn/followers","following_url":"https://api.github.com/users/projectacrn/following{/other_user}","gists_url":"https://api.github.com/users/projectacrn/gists{/gist_id}","starred_url":"https://api.github.com/users/projectacrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectacrn/subscriptions","organizations_url":"https://api.github.com/users/projectacrn/orgs","repos_url":"https://api.github.com/users/projectacrn/repos","events_url":"https://api.github.com/users/projectacrn/events{/privacy}","received_events_url":"https://api.github.com/users/projectacrn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectacrn/acrn-hypervisor","description":"Project ACRN hypervisor ","fork":false,"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor","forks_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/forks","keys_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/teams","hooks_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/hooks","issue_events_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/events{/number}","events_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/events","assignees_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/assignees{/user}","branches_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/branches{/branch}","tags_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/tags","blobs_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/statuses/{sha}","languages_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/languages","stargazers_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/stargazers","contributors_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/contributors","subscribers_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/subscribers","subscription_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/subscription","commits_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/contents/{+path}","compare_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/merges","archive_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/downloads","issues_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues{/number}","pulls_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls{/number}","milestones_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/milestones{/number}","notifications_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/labels{/name}","releases_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/releases{/id}","deployments_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/deployments","created_at":"2018-03-05T21:52:25Z","updated_at":"2018-08-26T00:06:57Z","pushed_at":"2018-08-25T02:16:46Z","git_url":"git://github.com/projectacrn/acrn-hypervisor.git","ssh_url":"git@github.com:projectacrn/acrn-hypervisor.git","clone_url":"https://github.com/projectacrn/acrn-hypervisor.git","svn_url":"https://github.com/projectacrn/acrn-hypervisor","homepage":"","size":15331,"stargazers_count":236,"watchers_count":236,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"archived":false,"open_issues_count":141,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":160,"open_issues":141,"watchers":236,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/1096"},"html":{"href":"https://github.com/projectacrn/acrn-hypervisor/pull/1096"},"issue":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/1096"},"comments":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/1096/comments"},"review_comments":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/1096/comments"},"review_comment":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/1096/commits"},"statuses":{"href":"https://api.github.com/repos/projectacrn/acrn-hypervisor/statuses/527c570854dc092482014be6b270da26ec4eaba9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lifeix"}}