{"action":"created","comment":{"url":"https://api.github.com/repos/root-project/root/pulls/comments/220454136","pull_request_review_id":158863631,"id":220454136,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDQ1NDEzNg==","diff_hunk":"@@ -4974,6 +4994,7 @@ int TCling::ReadRootmapFile(const char *rootmapfile, TUniqueString *uniqueString\n {\n    // For \"class \", \"namespace \", \"typedef \", \"header \", \"enum \", \"var \" respectively\n    const std::map<char, unsigned int> keyLenMap = {{'c',6},{'n',10},{'t',8},{'h',7},{'e',5},{'v',4}};\n+   bool hasPCM = rMapHasPCM(rootmapfile, fInterpreter);","path":"core/metacling/src/TCling.cxx","position":81,"original_position":40,"commit_id":"a907257cb6eec5b841f42253840b0d9bdc817968","original_commit_id":"a907257cb6eec5b841f42253840b0d9bdc817968","user":{"login":"vgvassilev","id":6516307,"node_id":"MDQ6VXNlcjY1MTYzMDc=","avatar_url":"https://avatars1.githubusercontent.com/u/6516307?v=4","gravatar_id":"","url":"https://api.github.com/users/vgvassilev","html_url":"https://github.com/vgvassilev","followers_url":"https://api.github.com/users/vgvassilev/followers","following_url":"https://api.github.com/users/vgvassilev/following{/other_user}","gists_url":"https://api.github.com/users/vgvassilev/gists{/gist_id}","starred_url":"https://api.github.com/users/vgvassilev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgvassilev/subscriptions","organizations_url":"https://api.github.com/users/vgvassilev/orgs","repos_url":"https://api.github.com/users/vgvassilev/repos","events_url":"https://api.github.com/users/vgvassilev/events{/privacy}","received_events_url":"https://api.github.com/users/vgvassilev/received_events","type":"User","site_admin":false},"body":"Remove, we only use it once.","created_at":"2018-09-26T07:37:32Z","updated_at":"2018-09-26T07:40:28Z","html_url":"https://github.com/root-project/root/pull/2592#discussion_r220454136","pull_request_url":"https://api.github.com/repos/root-project/root/pulls/2592","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/comments/220454136"},"html":{"href":"https://github.com/root-project/root/pull/2592#discussion_r220454136"},"pull_request":{"href":"https://api.github.com/repos/root-project/root/pulls/2592"}}},"pull_request":{"url":"https://api.github.com/repos/root-project/root/pulls/2592","id":213092944,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMDkyOTQ0","html_url":"https://github.com/root-project/root/pull/2592","diff_url":"https://github.com/root-project/root/pull/2592.diff","patch_url":"https://github.com/root-project/root/pull/2592.patch","issue_url":"https://api.github.com/repos/root-project/root/issues/2592","number":2592,"state":"open","locked":false,"title":"[cxxmodule] Don't declare fwd decls from rootmaps with modules","user":{"login":"yamaguchi1024","id":12247908,"node_id":"MDQ6VXNlcjEyMjQ3OTA4","avatar_url":"https://avatars0.githubusercontent.com/u/12247908?v=4","gravatar_id":"","url":"https://api.github.com/users/yamaguchi1024","html_url":"https://github.com/yamaguchi1024","followers_url":"https://api.github.com/users/yamaguchi1024/followers","following_url":"https://api.github.com/users/yamaguchi1024/following{/other_user}","gists_url":"https://api.github.com/users/yamaguchi1024/gists{/gist_id}","starred_url":"https://api.github.com/users/yamaguchi1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamaguchi1024/subscriptions","organizations_url":"https://api.github.com/users/yamaguchi1024/orgs","repos_url":"https://api.github.com/users/yamaguchi1024/repos","events_url":"https://api.github.com/users/yamaguchi1024/events{/privacy}","received_events_url":"https://api.github.com/users/yamaguchi1024/received_events","type":"User","site_admin":false},"body":"Fwd decls from rootmap files were injected to ROOT at the startup time.\r\nHowever with modules we don't need any foward decls as we're preloading\r\nall modules.\r\n\r\nOur future plan is to remove rootmap files as a whole, but we still need\r\nto support more features (see 2380). So for now we can remove what we\r\nare not using.\r\n\r\n*edit This patch also contains adding fHasCxxModule as a private member\r\n\r\nThis improves startup memory by 10 mbytes.","created_at":"2018-09-04T20:23:47Z","updated_at":"2018-09-26T07:40:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52d2bfb6278404897baea7be86cdd51eb5661d41","assignee":{"login":"vgvassilev","id":6516307,"node_id":"MDQ6VXNlcjY1MTYzMDc=","avatar_url":"https://avatars1.githubusercontent.com/u/6516307?v=4","gravatar_id":"","url":"https://api.github.com/users/vgvassilev","html_url":"https://github.com/vgvassilev","followers_url":"https://api.github.com/users/vgvassilev/followers","following_url":"https://api.github.com/users/vgvassilev/following{/other_user}","gists_url":"https://api.github.com/users/vgvassilev/gists{/gist_id}","starred_url":"https://api.github.com/users/vgvassilev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgvassilev/subscriptions","organizations_url":"https://api.github.com/users/vgvassilev/orgs","repos_url":"https://api.github.com/users/vgvassilev/repos","events_url":"https://api.github.com/users/vgvassilev/events{/privacy}","received_events_url":"https://api.github.com/users/vgvassilev/received_events","type":"User","site_admin":false},"assignees":[{"login":"vgvassilev","id":6516307,"node_id":"MDQ6VXNlcjY1MTYzMDc=","avatar_url":"https://avatars1.githubusercontent.com/u/6516307?v=4","gravatar_id":"","url":"https://api.github.com/users/vgvassilev","html_url":"https://github.com/vgvassilev","followers_url":"https://api.github.com/users/vgvassilev/followers","following_url":"https://api.github.com/users/vgvassilev/following{/other_user}","gists_url":"https://api.github.com/users/vgvassilev/gists{/gist_id}","starred_url":"https://api.github.com/users/vgvassilev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgvassilev/subscriptions","organizations_url":"https://api.github.com/users/vgvassilev/orgs","repos_url":"https://api.github.com/users/vgvassilev/repos","events_url":"https://api.github.com/users/vgvassilev/events{/privacy}","received_events_url":"https://api.github.com/users/vgvassilev/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Axel-Naumann","id":144675,"node_id":"MDQ6VXNlcjE0NDY3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/144675?v=4","gravatar_id":"","url":"https://api.github.com/users/Axel-Naumann","html_url":"https://github.com/Axel-Naumann","followers_url":"https://api.github.com/users/Axel-Naumann/followers","following_url":"https://api.github.com/users/Axel-Naumann/following{/other_user}","gists_url":"https://api.github.com/users/Axel-Naumann/gists{/gist_id}","starred_url":"https://api.github.com/users/Axel-Naumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Axel-Naumann/subscriptions","organizations_url":"https://api.github.com/users/Axel-Naumann/orgs","repos_url":"https://api.github.com/users/Axel-Naumann/repos","events_url":"https://api.github.com/users/Axel-Naumann/events{/privacy}","received_events_url":"https://api.github.com/users/Axel-Naumann/received_events","type":"User","site_admin":false},{"login":"pcanal","id":5175087,"node_id":"MDQ6VXNlcjUxNzUwODc=","avatar_url":"https://avatars3.githubusercontent.com/u/5175087?v=4","gravatar_id":"","url":"https://api.github.com/users/pcanal","html_url":"https://github.com/pcanal","followers_url":"https://api.github.com/users/pcanal/followers","following_url":"https://api.github.com/users/pcanal/following{/other_user}","gists_url":"https://api.github.com/users/pcanal/gists{/gist_id}","starred_url":"https://api.github.com/users/pcanal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcanal/subscriptions","organizations_url":"https://api.github.com/users/pcanal/orgs","repos_url":"https://api.github.com/users/pcanal/repos","events_url":"https://api.github.com/users/pcanal/events{/privacy}","received_events_url":"https://api.github.com/users/pcanal/received_events","type":"User","site_admin":false},{"login":"oshadura","id":7012420,"node_id":"MDQ6VXNlcjcwMTI0MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/7012420?v=4","gravatar_id":"","url":"https://api.github.com/users/oshadura","html_url":"https://github.com/oshadura","followers_url":"https://api.github.com/users/oshadura/followers","following_url":"https://api.github.com/users/oshadura/following{/other_user}","gists_url":"https://api.github.com/users/oshadura/gists{/gist_id}","starred_url":"https://api.github.com/users/oshadura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshadura/subscriptions","organizations_url":"https://api.github.com/users/oshadura/orgs","repos_url":"https://api.github.com/users/oshadura/repos","events_url":"https://api.github.com/users/oshadura/events{/privacy}","received_events_url":"https://api.github.com/users/oshadura/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/root-project/root/pulls/2592/commits","review_comments_url":"https://api.github.com/repos/root-project/root/pulls/2592/comments","review_comment_url":"https://api.github.com/repos/root-project/root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/root-project/root/issues/2592/comments","statuses_url":"https://api.github.com/repos/root-project/root/statuses/a907257cb6eec5b841f42253840b0d9bdc817968","head":{"label":"yamaguchi1024:nodeclare","ref":"nodeclare","sha":"a907257cb6eec5b841f42253840b0d9bdc817968","user":{"login":"yamaguchi1024","id":12247908,"node_id":"MDQ6VXNlcjEyMjQ3OTA4","avatar_url":"https://avatars0.githubusercontent.com/u/12247908?v=4","gravatar_id":"","url":"https://api.github.com/users/yamaguchi1024","html_url":"https://github.com/yamaguchi1024","followers_url":"https://api.github.com/users/yamaguchi1024/followers","following_url":"https://api.github.com/users/yamaguchi1024/following{/other_user}","gists_url":"https://api.github.com/users/yamaguchi1024/gists{/gist_id}","starred_url":"https://api.github.com/users/yamaguchi1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamaguchi1024/subscriptions","organizations_url":"https://api.github.com/users/yamaguchi1024/orgs","repos_url":"https://api.github.com/users/yamaguchi1024/repos","events_url":"https://api.github.com/users/yamaguchi1024/events{/privacy}","received_events_url":"https://api.github.com/users/yamaguchi1024/received_events","type":"User","site_admin":false},"repo":{"id":123582891,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1ODI4OTE=","name":"root","full_name":"yamaguchi1024/root","private":false,"owner":{"login":"yamaguchi1024","id":12247908,"node_id":"MDQ6VXNlcjEyMjQ3OTA4","avatar_url":"https://avatars0.githubusercontent.com/u/12247908?v=4","gravatar_id":"","url":"https://api.github.com/users/yamaguchi1024","html_url":"https://github.com/yamaguchi1024","followers_url":"https://api.github.com/users/yamaguchi1024/followers","following_url":"https://api.github.com/users/yamaguchi1024/following{/other_user}","gists_url":"https://api.github.com/users/yamaguchi1024/gists{/gist_id}","starred_url":"https://api.github.com/users/yamaguchi1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamaguchi1024/subscriptions","organizations_url":"https://api.github.com/users/yamaguchi1024/orgs","repos_url":"https://api.github.com/users/yamaguchi1024/repos","events_url":"https://api.github.com/users/yamaguchi1024/events{/privacy}","received_events_url":"https://api.github.com/users/yamaguchi1024/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yamaguchi1024/root","description":"The official ROOT repository","fork":true,"url":"https://api.github.com/repos/yamaguchi1024/root","forks_url":"https://api.github.com/repos/yamaguchi1024/root/forks","keys_url":"https://api.github.com/repos/yamaguchi1024/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yamaguchi1024/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yamaguchi1024/root/teams","hooks_url":"https://api.github.com/repos/yamaguchi1024/root/hooks","issue_events_url":"https://api.github.com/repos/yamaguchi1024/root/issues/events{/number}","events_url":"https://api.github.com/repos/yamaguchi1024/root/events","assignees_url":"https://api.github.com/repos/yamaguchi1024/root/assignees{/user}","branches_url":"https://api.github.com/repos/yamaguchi1024/root/branches{/branch}","tags_url":"https://api.github.com/repos/yamaguchi1024/root/tags","blobs_url":"https://api.github.com/repos/yamaguchi1024/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yamaguchi1024/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yamaguchi1024/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/yamaguchi1024/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yamaguchi1024/root/statuses/{sha}","languages_url":"https://api.github.com/repos/yamaguchi1024/root/languages","stargazers_url":"https://api.github.com/repos/yamaguchi1024/root/stargazers","contributors_url":"https://api.github.com/repos/yamaguchi1024/root/contributors","subscribers_url":"https://api.github.com/repos/yamaguchi1024/root/subscribers","subscription_url":"https://api.github.com/repos/yamaguchi1024/root/subscription","commits_url":"https://api.github.com/repos/yamaguchi1024/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/yamaguchi1024/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/yamaguchi1024/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/yamaguchi1024/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/yamaguchi1024/root/contents/{+path}","compare_url":"https://api.github.com/repos/yamaguchi1024/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yamaguchi1024/root/merges","archive_url":"https://api.github.com/repos/yamaguchi1024/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yamaguchi1024/root/downloads","issues_url":"https://api.github.com/repos/yamaguchi1024/root/issues{/number}","pulls_url":"https://api.github.com/repos/yamaguchi1024/root/pulls{/number}","milestones_url":"https://api.github.com/repos/yamaguchi1024/root/milestones{/number}","notifications_url":"https://api.github.com/repos/yamaguchi1024/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yamaguchi1024/root/labels{/name}","releases_url":"https://api.github.com/repos/yamaguchi1024/root/releases{/id}","deployments_url":"https://api.github.com/repos/yamaguchi1024/root/deployments","created_at":"2018-03-02T13:33:28Z","updated_at":"2018-09-25T13:18:31Z","pushed_at":"2018-09-25T16:38:38Z","git_url":"git://github.com/yamaguchi1024/root.git","ssh_url":"git@github.com:yamaguchi1024/root.git","clone_url":"https://github.com/yamaguchi1024/root.git","svn_url":"https://github.com/yamaguchi1024/root","homepage":"https://root.cern","size":708058,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"root-project:master","ref":"master","sha":"acc3fcb98563b56adc505f799791da091d72c8a4","user":{"login":"root-project","id":6450093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NTAwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"repo":{"id":10994345,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk5NDM0NQ==","name":"root","full_name":"root-project/root","private":false,"owner":{"login":"root-project","id":6450093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NTAwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/root-project/root","description":"The official repository for ROOT: analyzing, storing and visualizing big data","fork":false,"url":"https://api.github.com/repos/root-project/root","forks_url":"https://api.github.com/repos/root-project/root/forks","keys_url":"https://api.github.com/repos/root-project/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root-project/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root-project/root/teams","hooks_url":"https://api.github.com/repos/root-project/root/hooks","issue_events_url":"https://api.github.com/repos/root-project/root/issues/events{/number}","events_url":"https://api.github.com/repos/root-project/root/events","assignees_url":"https://api.github.com/repos/root-project/root/assignees{/user}","branches_url":"https://api.github.com/repos/root-project/root/branches{/branch}","tags_url":"https://api.github.com/repos/root-project/root/tags","blobs_url":"https://api.github.com/repos/root-project/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root-project/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root-project/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/root-project/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root-project/root/statuses/{sha}","languages_url":"https://api.github.com/repos/root-project/root/languages","stargazers_url":"https://api.github.com/repos/root-project/root/stargazers","contributors_url":"https://api.github.com/repos/root-project/root/contributors","subscribers_url":"https://api.github.com/repos/root-project/root/subscribers","subscription_url":"https://api.github.com/repos/root-project/root/subscription","commits_url":"https://api.github.com/repos/root-project/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/root-project/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/root-project/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/root-project/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/root-project/root/contents/{+path}","compare_url":"https://api.github.com/repos/root-project/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root-project/root/merges","archive_url":"https://api.github.com/repos/root-project/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root-project/root/downloads","issues_url":"https://api.github.com/repos/root-project/root/issues{/number}","pulls_url":"https://api.github.com/repos/root-project/root/pulls{/number}","milestones_url":"https://api.github.com/repos/root-project/root/milestones{/number}","notifications_url":"https://api.github.com/repos/root-project/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root-project/root/labels{/name}","releases_url":"https://api.github.com/repos/root-project/root/releases{/id}","deployments_url":"https://api.github.com/repos/root-project/root/deployments","created_at":"2013-06-27T10:46:59Z","updated_at":"2018-09-26T06:56:53Z","pushed_at":"2018-09-26T06:56:37Z","git_url":"git://github.com/root-project/root.git","ssh_url":"git@github.com:root-project/root.git","clone_url":"https://github.com/root-project/root.git","svn_url":"https://github.com/root-project/root","homepage":"https://root.cern","size":708851,"stargazers_count":646,"watchers_count":646,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":458,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":458,"open_issues":92,"watchers":646,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/2592"},"html":{"href":"https://github.com/root-project/root/pull/2592"},"issue":{"href":"https://api.github.com/repos/root-project/root/issues/2592"},"comments":{"href":"https://api.github.com/repos/root-project/root/issues/2592/comments"},"review_comments":{"href":"https://api.github.com/repos/root-project/root/pulls/2592/comments"},"review_comment":{"href":"https://api.github.com/repos/root-project/root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/root-project/root/pulls/2592/commits"},"statuses":{"href":"https://api.github.com/repos/root-project/root/statuses/a907257cb6eec5b841f42253840b0d9bdc817968"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vgvassilev"}}