{"action":"closed","number":850,"pull_request":{"url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/850","id":134315294,"html_url":"https://github.com/keepassxreboot/keepassxc/pull/850","diff_url":"https://github.com/keepassxreboot/keepassxc/pull/850.diff","patch_url":"https://github.com/keepassxreboot/keepassxc/pull/850.patch","issue_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/850","number":850,"state":"closed","locked":false,"title":"[WIP] Create new KeepassHTTP KeyAcceptDialog","user":{"login":"duk3luk3","id":611471,"avatar_url":"https://avatars2.githubusercontent.com/u/611471?v=4","gravatar_id":"","url":"https://api.github.com/users/duk3luk3","html_url":"https://github.com/duk3luk3","followers_url":"https://api.github.com/users/duk3luk3/followers","following_url":"https://api.github.com/users/duk3luk3/following{/other_user}","gists_url":"https://api.github.com/users/duk3luk3/gists{/gist_id}","starred_url":"https://api.github.com/users/duk3luk3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duk3luk3/subscriptions","organizations_url":"https://api.github.com/users/duk3luk3/orgs","repos_url":"https://api.github.com/users/duk3luk3/repos","events_url":"https://api.github.com/users/duk3luk3/events{/privacy}","received_events_url":"https://api.github.com/users/duk3luk3/received_events","type":"User","site_admin":false},"body":"WIP - Creates a new dialog widget for accepting keys - needed for #838\r\n\r\nFor #838, #530\r\n\r\nThis is a proof-of-concept for myself that I can make changes to KeePassXC and a first step towards making some big changes to the KeepassHTTP authorization key management in order to address #838 and #530 and my own usability / workflow itches as someone who generally works with multiple databases open at the same time.\r\n\r\nPlease give this change a quick look and tell me if this is a good direction to go in, as well as anything problematic in the code I've changed (as far as it isn't a temporary mock-up / stub)\r\n\r\n## Description\r\n\r\nPlanned changes:\r\n* Fix #530 \r\n* Allow to select which database(s) to add a KeepassHTTP authorization key to. (#838)\r\n* Figure out if more information about the source of the authorization request can be taken from the KeepassHTTP connection and display it\r\n\r\n## Motivation and context\r\nSee #530, #838 \r\n\r\n## How has this been tested?\r\n\r\n* Not yet, WIP changes\r\n\r\n## Screenshots (if appropriate):\r\n\r\n![keepassnewkey](https://user-images.githubusercontent.com/611471/29000914-26f26c12-7abe-11e7-948b-da275d8a30d7.png)\r\n\r\n\r\n## Types of changes\r\n- ✅ Bug fix (non-breaking change which fixes an issue)\r\n- ✅ New feature (non-breaking change which adds functionality)\r\n- ✅ Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n- ✅ I have read the **CONTRIBUTING** document. **[REQUIRED]**\r\n- ? My code follows the code style of this project. **[REQUIRED]**\r\n- X All new and existing tests passed. **[REQUIRED]**\r\n- X I have compiled and verified my code with `-DWITH_ASAN=ON`. **[REQUIRED]**\r\n- ? My change requires a change to the documentation and I have updated it accordingly.\r\n- X I have added tests to cover my changes.\r\n","created_at":"2017-08-06T05:47:35Z","updated_at":"2018-02-24T18:47:38Z","closed_at":"2018-02-24T18:47:38Z","merged_at":null,"merge_commit_sha":"4bb66a701d217471f630d75007c5aba50740fd5c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":649762822,"url":"https://api.github.com/repos/keepassxreboot/keepassxc/labels/browser%20integration","name":"browser integration","color":"fbca04","default":false},{"id":525279942,"url":"https://api.github.com/repos/keepassxreboot/keepassxc/labels/needs%20work","name":"needs work","color":"e99695","default":false},{"id":454631186,"url":"https://api.github.com/repos/keepassxreboot/keepassxc/labels/user%20interface","name":"user interface","color":"bfd4f2","default":false}],"milestone":{"url":"https://api.github.com/repos/keepassxreboot/keepassxc/milestones/7","html_url":"https://github.com/keepassxreboot/keepassxc/milestone/7","labels_url":"https://api.github.com/repos/keepassxreboot/keepassxc/milestones/7/labels","id":2426888,"number":7,"title":"Future","description":"Wishlist items and good ideas not specifically planned for yet.","creator":{"login":"droidmonkey","id":2809491,"avatar_url":"https://avatars2.githubusercontent.com/u/2809491?v=4","gravatar_id":"","url":"https://api.github.com/users/droidmonkey","html_url":"https://github.com/droidmonkey","followers_url":"https://api.github.com/users/droidmonkey/followers","following_url":"https://api.github.com/users/droidmonkey/following{/other_user}","gists_url":"https://api.github.com/users/droidmonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/droidmonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droidmonkey/subscriptions","organizations_url":"https://api.github.com/users/droidmonkey/orgs","repos_url":"https://api.github.com/users/droidmonkey/repos","events_url":"https://api.github.com/users/droidmonkey/events{/privacy}","received_events_url":"https://api.github.com/users/droidmonkey/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":1,"state":"open","created_at":"2017-04-01T02:14:52Z","updated_at":"2018-02-24T18:47:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/850/commits","review_comments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/850/comments","review_comment_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/850/comments","statuses_url":"https://api.github.com/repos/keepassxreboot/keepassxc/statuses/64689aea23da619db449a585989f86784107a9b5","head":{"label":"duk3luk3:feature/838-keepasshttp-keys","ref":"feature/838-keepasshttp-keys","sha":"64689aea23da619db449a585989f86784107a9b5","user":{"login":"duk3luk3","id":611471,"avatar_url":"https://avatars2.githubusercontent.com/u/611471?v=4","gravatar_id":"","url":"https://api.github.com/users/duk3luk3","html_url":"https://github.com/duk3luk3","followers_url":"https://api.github.com/users/duk3luk3/followers","following_url":"https://api.github.com/users/duk3luk3/following{/other_user}","gists_url":"https://api.github.com/users/duk3luk3/gists{/gist_id}","starred_url":"https://api.github.com/users/duk3luk3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duk3luk3/subscriptions","organizations_url":"https://api.github.com/users/duk3luk3/orgs","repos_url":"https://api.github.com/users/duk3luk3/repos","events_url":"https://api.github.com/users/duk3luk3/events{/privacy}","received_events_url":"https://api.github.com/users/duk3luk3/received_events","type":"User","site_admin":false},"repo":{"id":99460027,"name":"keepassxc","full_name":"duk3luk3/keepassxc","owner":{"login":"duk3luk3","id":611471,"avatar_url":"https://avatars2.githubusercontent.com/u/611471?v=4","gravatar_id":"","url":"https://api.github.com/users/duk3luk3","html_url":"https://github.com/duk3luk3","followers_url":"https://api.github.com/users/duk3luk3/followers","following_url":"https://api.github.com/users/duk3luk3/following{/other_user}","gists_url":"https://api.github.com/users/duk3luk3/gists{/gist_id}","starred_url":"https://api.github.com/users/duk3luk3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duk3luk3/subscriptions","organizations_url":"https://api.github.com/users/duk3luk3/orgs","repos_url":"https://api.github.com/users/duk3luk3/repos","events_url":"https://api.github.com/users/duk3luk3/events{/privacy}","received_events_url":"https://api.github.com/users/duk3luk3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/duk3luk3/keepassxc","description":"KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.","fork":true,"url":"https://api.github.com/repos/duk3luk3/keepassxc","forks_url":"https://api.github.com/repos/duk3luk3/keepassxc/forks","keys_url":"https://api.github.com/repos/duk3luk3/keepassxc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duk3luk3/keepassxc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duk3luk3/keepassxc/teams","hooks_url":"https://api.github.com/repos/duk3luk3/keepassxc/hooks","issue_events_url":"https://api.github.com/repos/duk3luk3/keepassxc/issues/events{/number}","events_url":"https://api.github.com/repos/duk3luk3/keepassxc/events","assignees_url":"https://api.github.com/repos/duk3luk3/keepassxc/assignees{/user}","branches_url":"https://api.github.com/repos/duk3luk3/keepassxc/branches{/branch}","tags_url":"https://api.github.com/repos/duk3luk3/keepassxc/tags","blobs_url":"https://api.github.com/repos/duk3luk3/keepassxc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duk3luk3/keepassxc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duk3luk3/keepassxc/git/refs{/sha}","trees_url":"https://api.github.com/repos/duk3luk3/keepassxc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duk3luk3/keepassxc/statuses/{sha}","languages_url":"https://api.github.com/repos/duk3luk3/keepassxc/languages","stargazers_url":"https://api.github.com/repos/duk3luk3/keepassxc/stargazers","contributors_url":"https://api.github.com/repos/duk3luk3/keepassxc/contributors","subscribers_url":"https://api.github.com/repos/duk3luk3/keepassxc/subscribers","subscription_url":"https://api.github.com/repos/duk3luk3/keepassxc/subscription","commits_url":"https://api.github.com/repos/duk3luk3/keepassxc/commits{/sha}","git_commits_url":"https://api.github.com/repos/duk3luk3/keepassxc/git/commits{/sha}","comments_url":"https://api.github.com/repos/duk3luk3/keepassxc/comments{/number}","issue_comment_url":"https://api.github.com/repos/duk3luk3/keepassxc/issues/comments{/number}","contents_url":"https://api.github.com/repos/duk3luk3/keepassxc/contents/{+path}","compare_url":"https://api.github.com/repos/duk3luk3/keepassxc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duk3luk3/keepassxc/merges","archive_url":"https://api.github.com/repos/duk3luk3/keepassxc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duk3luk3/keepassxc/downloads","issues_url":"https://api.github.com/repos/duk3luk3/keepassxc/issues{/number}","pulls_url":"https://api.github.com/repos/duk3luk3/keepassxc/pulls{/number}","milestones_url":"https://api.github.com/repos/duk3luk3/keepassxc/milestones{/number}","notifications_url":"https://api.github.com/repos/duk3luk3/keepassxc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duk3luk3/keepassxc/labels{/name}","releases_url":"https://api.github.com/repos/duk3luk3/keepassxc/releases{/id}","deployments_url":"https://api.github.com/repos/duk3luk3/keepassxc/deployments","created_at":"2017-08-06T02:41:29Z","updated_at":"2017-08-06T02:41:32Z","pushed_at":"2018-01-20T11:29:57Z","git_url":"git://github.com/duk3luk3/keepassxc.git","ssh_url":"git@github.com:duk3luk3/keepassxc.git","clone_url":"https://github.com/duk3luk3/keepassxc.git","svn_url":"https://github.com/duk3luk3/keepassxc","homepage":"https://keepassxc.org/","size":10357,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"keepassxreboot:develop","ref":"develop","sha":"28ad6ed552fb5b44716b0275d946dbb7d544f432","user":{"login":"keepassxreboot","id":22534815,"avatar_url":"https://avatars3.githubusercontent.com/u/22534815?v=4","gravatar_id":"","url":"https://api.github.com/users/keepassxreboot","html_url":"https://github.com/keepassxreboot","followers_url":"https://api.github.com/users/keepassxreboot/followers","following_url":"https://api.github.com/users/keepassxreboot/following{/other_user}","gists_url":"https://api.github.com/users/keepassxreboot/gists{/gist_id}","starred_url":"https://api.github.com/users/keepassxreboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepassxreboot/subscriptions","organizations_url":"https://api.github.com/users/keepassxreboot/orgs","repos_url":"https://api.github.com/users/keepassxreboot/repos","events_url":"https://api.github.com/users/keepassxreboot/events{/privacy}","received_events_url":"https://api.github.com/users/keepassxreboot/received_events","type":"Organization","site_admin":false},"repo":{"id":52729242,"name":"keepassxc","full_name":"keepassxreboot/keepassxc","owner":{"login":"keepassxreboot","id":22534815,"avatar_url":"https://avatars3.githubusercontent.com/u/22534815?v=4","gravatar_id":"","url":"https://api.github.com/users/keepassxreboot","html_url":"https://github.com/keepassxreboot","followers_url":"https://api.github.com/users/keepassxreboot/followers","following_url":"https://api.github.com/users/keepassxreboot/following{/other_user}","gists_url":"https://api.github.com/users/keepassxreboot/gists{/gist_id}","starred_url":"https://api.github.com/users/keepassxreboot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keepassxreboot/subscriptions","organizations_url":"https://api.github.com/users/keepassxreboot/orgs","repos_url":"https://api.github.com/users/keepassxreboot/repos","events_url":"https://api.github.com/users/keepassxreboot/events{/privacy}","received_events_url":"https://api.github.com/users/keepassxreboot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keepassxreboot/keepassxc","description":"KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.","fork":false,"url":"https://api.github.com/repos/keepassxreboot/keepassxc","forks_url":"https://api.github.com/repos/keepassxreboot/keepassxc/forks","keys_url":"https://api.github.com/repos/keepassxreboot/keepassxc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keepassxreboot/keepassxc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keepassxreboot/keepassxc/teams","hooks_url":"https://api.github.com/repos/keepassxreboot/keepassxc/hooks","issue_events_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/events{/number}","events_url":"https://api.github.com/repos/keepassxreboot/keepassxc/events","assignees_url":"https://api.github.com/repos/keepassxreboot/keepassxc/assignees{/user}","branches_url":"https://api.github.com/repos/keepassxreboot/keepassxc/branches{/branch}","tags_url":"https://api.github.com/repos/keepassxreboot/keepassxc/tags","blobs_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/refs{/sha}","trees_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keepassxreboot/keepassxc/statuses/{sha}","languages_url":"https://api.github.com/repos/keepassxreboot/keepassxc/languages","stargazers_url":"https://api.github.com/repos/keepassxreboot/keepassxc/stargazers","contributors_url":"https://api.github.com/repos/keepassxreboot/keepassxc/contributors","subscribers_url":"https://api.github.com/repos/keepassxreboot/keepassxc/subscribers","subscription_url":"https://api.github.com/repos/keepassxreboot/keepassxc/subscription","commits_url":"https://api.github.com/repos/keepassxreboot/keepassxc/commits{/sha}","git_commits_url":"https://api.github.com/repos/keepassxreboot/keepassxc/git/commits{/sha}","comments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/comments{/number}","issue_comment_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/comments{/number}","contents_url":"https://api.github.com/repos/keepassxreboot/keepassxc/contents/{+path}","compare_url":"https://api.github.com/repos/keepassxreboot/keepassxc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keepassxreboot/keepassxc/merges","archive_url":"https://api.github.com/repos/keepassxreboot/keepassxc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keepassxreboot/keepassxc/downloads","issues_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues{/number}","pulls_url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls{/number}","milestones_url":"https://api.github.com/repos/keepassxreboot/keepassxc/milestones{/number}","notifications_url":"https://api.github.com/repos/keepassxreboot/keepassxc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keepassxreboot/keepassxc/labels{/name}","releases_url":"https://api.github.com/repos/keepassxreboot/keepassxc/releases{/id}","deployments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/deployments","created_at":"2016-02-28T15:52:40Z","updated_at":"2018-02-24T17:52:17Z","pushed_at":"2018-02-24T17:36:53Z","git_url":"git://github.com/keepassxreboot/keepassxc.git","ssh_url":"git@github.com:keepassxreboot/keepassxc.git","clone_url":"https://github.com/keepassxreboot/keepassxc.git","svn_url":"https://github.com/keepassxreboot/keepassxc","homepage":"https://keepassxc.org/","size":11230,"stargazers_count":3138,"watchers_count":3138,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":223,"mirror_url":null,"archived":false,"open_issues_count":299,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":223,"open_issues":299,"watchers":3138,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/850"},"html":{"href":"https://github.com/keepassxreboot/keepassxc/pull/850"},"issue":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/850"},"comments":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/850/comments"},"review_comments":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/850/comments"},"review_comment":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/850/commits"},"statuses":{"href":"https://api.github.com/repos/keepassxreboot/keepassxc/statuses/64689aea23da619db449a585989f86784107a9b5"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":26,"review_comments":20,"maintainer_can_modify":false,"commits":8,"additions":755,"deletions":307,"changed_files":8}}
{"actor":{"display_login":"droidmonkey"}}