{"action":"created","comment":{"url":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/comments/186696344","pull_request_review_id":118324093,"id":186696344,"diff_hunk":"@@ -52,4 +52,4 @@ FILES_${PN}_append_raspberrypi0-wifi = \" ${BCM_BT_FIRMWARE}\"\n \n SYSTEMD_SERVICE_${PN}_append_raspberrypi0-wifi = \" ${BCM_BT_SERVICE}\"\n \n-RDEPENDS_${PN}_append_raspebrrypi0-wifi = \" udev-rules-rpi\"\n+RDEPENDS_${PN}_append_raspberrypi0-wifi = \" udev-rules-rpi\"","path":"recipes-connectivity/bluez5/bluez5_%.bbappend","position":null,"original_position":5,"commit_id":"c665643398313268d7b9bfca8597c0effb7b64f7","original_commit_id":"ded8c8dbf517dd3bbf17eb834880fa1a4f0e2698","user":{"login":"agherzan","id":1746941,"avatar_url":"https://avatars0.githubusercontent.com/u/1746941?v=4","gravatar_id":"","url":"https://api.github.com/users/agherzan","html_url":"https://github.com/agherzan","followers_url":"https://api.github.com/users/agherzan/followers","following_url":"https://api.github.com/users/agherzan/following{/other_user}","gists_url":"https://api.github.com/users/agherzan/gists{/gist_id}","starred_url":"https://api.github.com/users/agherzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agherzan/subscriptions","organizations_url":"https://api.github.com/users/agherzan/orgs","repos_url":"https://api.github.com/users/agherzan/repos","events_url":"https://api.github.com/users/agherzan/events{/privacy}","received_events_url":"https://api.github.com/users/agherzan/received_events","type":"User","site_admin":false},"body":"@kraj you have a point there but the issue is the fact that bluez brings the systemd service which depends on the udev rules. So this makes bluez package dependent on the udev rules. That's why we have that RDEPENDS, at runtime, the systemd service needs the udev rules. Probably the clean way forward would be to get the service out in another recipe and make that depend on udev rules but I wonder if that would not confuse people more.","created_at":"2018-05-08T11:31:16Z","updated_at":"2018-05-08T11:31:16Z","html_url":"https://github.com/agherzan/meta-raspberrypi/pull/238#discussion_r186696344","pull_request_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/238","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/comments/186696344"},"html":{"href":"https://github.com/agherzan/meta-raspberrypi/pull/238#discussion_r186696344"},"pull_request":{"href":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/238"}},"in_reply_to_id":186469459},"pull_request":{"url":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/238","id":186364190,"html_url":"https://github.com/agherzan/meta-raspberrypi/pull/238","diff_url":"https://github.com/agherzan/meta-raspberrypi/pull/238.diff","patch_url":"https://github.com/agherzan/meta-raspberrypi/pull/238.patch","issue_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/issues/238","number":238,"state":"open","locked":false,"title":"Firmware/Kernel updates then rework bluetooth to fix licensing and address issues","user":{"login":"pabigot","id":964298,"avatar_url":"https://avatars1.githubusercontent.com/u/964298?v=4","gravatar_id":"","url":"https://api.github.com/users/pabigot","html_url":"https://github.com/pabigot","followers_url":"https://api.github.com/users/pabigot/followers","following_url":"https://api.github.com/users/pabigot/following{/other_user}","gists_url":"https://api.github.com/users/pabigot/gists{/gist_id}","starred_url":"https://api.github.com/users/pabigot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabigot/subscriptions","organizations_url":"https://api.github.com/users/pabigot/orgs","repos_url":"https://api.github.com/users/pabigot/repos","events_url":"https://api.github.com/users/pabigot/events{/privacy}","received_events_url":"https://api.github.com/users/pabigot/received_events","type":"User","site_admin":false},"body":"Tested on 3B+ and 0-wifi.\r\n\r\nfirmware updated because there's a 3B+ patch in there that might affect identifying the pins for hardware flow control in the bluetooth uart (which is now supported).  Kernel updated to match the firmware, plus one more release to reduce the amount of lan78xx noise.  These may not be necessary, but that's how I tested everything.\r\n\r\nA couple patches to the existing bluez recipe and systemd script, then the patches that break out the material that needs its own license and supports using the standard Raspbian approach to configuring the bluetooth device.","created_at":"2018-05-07T14:15:44Z","updated_at":"2018-05-08T11:31:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4313d0bb1ba1427a68581c3f0e5da9723d8e10fd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/238/commits","review_comments_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/238/comments","review_comment_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/issues/238/comments","statuses_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/statuses/c665643398313268d7b9bfca8597c0effb7b64f7","head":{"label":"pabigot:pr/bt","ref":"pr/bt","sha":"c665643398313268d7b9bfca8597c0effb7b64f7","user":{"login":"pabigot","id":964298,"avatar_url":"https://avatars1.githubusercontent.com/u/964298?v=4","gravatar_id":"","url":"https://api.github.com/users/pabigot","html_url":"https://github.com/pabigot","followers_url":"https://api.github.com/users/pabigot/followers","following_url":"https://api.github.com/users/pabigot/following{/other_user}","gists_url":"https://api.github.com/users/pabigot/gists{/gist_id}","starred_url":"https://api.github.com/users/pabigot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabigot/subscriptions","organizations_url":"https://api.github.com/users/pabigot/orgs","repos_url":"https://api.github.com/users/pabigot/repos","events_url":"https://api.github.com/users/pabigot/events{/privacy}","received_events_url":"https://api.github.com/users/pabigot/received_events","type":"User","site_admin":false},"repo":{"id":124258125,"name":"meta-raspberrypi","full_name":"pabigot/meta-raspberrypi","owner":{"login":"pabigot","id":964298,"avatar_url":"https://avatars1.githubusercontent.com/u/964298?v=4","gravatar_id":"","url":"https://api.github.com/users/pabigot","html_url":"https://github.com/pabigot","followers_url":"https://api.github.com/users/pabigot/followers","following_url":"https://api.github.com/users/pabigot/following{/other_user}","gists_url":"https://api.github.com/users/pabigot/gists{/gist_id}","starred_url":"https://api.github.com/users/pabigot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pabigot/subscriptions","organizations_url":"https://api.github.com/users/pabigot/orgs","repos_url":"https://api.github.com/users/pabigot/repos","events_url":"https://api.github.com/users/pabigot/events{/privacy}","received_events_url":"https://api.github.com/users/pabigot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pabigot/meta-raspberrypi","description":"Yocto BSP layer for the Raspberry Pi boards","fork":true,"url":"https://api.github.com/repos/pabigot/meta-raspberrypi","forks_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/forks","keys_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/teams","hooks_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/hooks","issue_events_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/issues/events{/number}","events_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/events","assignees_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/assignees{/user}","branches_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/branches{/branch}","tags_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/tags","blobs_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/git/refs{/sha}","trees_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/statuses/{sha}","languages_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/languages","stargazers_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/stargazers","contributors_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/contributors","subscribers_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/subscribers","subscription_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/subscription","commits_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/commits{/sha}","git_commits_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/git/commits{/sha}","comments_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/comments{/number}","issue_comment_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/issues/comments{/number}","contents_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/contents/{+path}","compare_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/merges","archive_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/downloads","issues_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/issues{/number}","pulls_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/pulls{/number}","milestones_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/milestones{/number}","notifications_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/labels{/name}","releases_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/releases{/id}","deployments_url":"https://api.github.com/repos/pabigot/meta-raspberrypi/deployments","created_at":"2018-03-07T15:46:09Z","updated_at":"2018-03-07T15:46:11Z","pushed_at":"2018-05-07T16:52:38Z","git_url":"git://github.com/pabigot/meta-raspberrypi.git","ssh_url":"git@github.com:pabigot/meta-raspberrypi.git","clone_url":"https://github.com/pabigot/meta-raspberrypi.git","svn_url":"https://github.com/pabigot/meta-raspberrypi","homepage":"http://www.raspberrypi.org/","size":1447,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"agherzan:master","ref":"master","sha":"a93a373c3eb806636602efe94fc45e8d4485f05a","user":{"login":"agherzan","id":1746941,"avatar_url":"https://avatars0.githubusercontent.com/u/1746941?v=4","gravatar_id":"","url":"https://api.github.com/users/agherzan","html_url":"https://github.com/agherzan","followers_url":"https://api.github.com/users/agherzan/followers","following_url":"https://api.github.com/users/agherzan/following{/other_user}","gists_url":"https://api.github.com/users/agherzan/gists{/gist_id}","starred_url":"https://api.github.com/users/agherzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agherzan/subscriptions","organizations_url":"https://api.github.com/users/agherzan/orgs","repos_url":"https://api.github.com/users/agherzan/repos","events_url":"https://api.github.com/users/agherzan/events{/privacy}","received_events_url":"https://api.github.com/users/agherzan/received_events","type":"User","site_admin":false},"repo":{"id":30782639,"name":"meta-raspberrypi","full_name":"agherzan/meta-raspberrypi","owner":{"login":"agherzan","id":1746941,"avatar_url":"https://avatars0.githubusercontent.com/u/1746941?v=4","gravatar_id":"","url":"https://api.github.com/users/agherzan","html_url":"https://github.com/agherzan","followers_url":"https://api.github.com/users/agherzan/followers","following_url":"https://api.github.com/users/agherzan/following{/other_user}","gists_url":"https://api.github.com/users/agherzan/gists{/gist_id}","starred_url":"https://api.github.com/users/agherzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agherzan/subscriptions","organizations_url":"https://api.github.com/users/agherzan/orgs","repos_url":"https://api.github.com/users/agherzan/repos","events_url":"https://api.github.com/users/agherzan/events{/privacy}","received_events_url":"https://api.github.com/users/agherzan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agherzan/meta-raspberrypi","description":"Yocto BSP layer for the Raspberry Pi boards","fork":false,"url":"https://api.github.com/repos/agherzan/meta-raspberrypi","forks_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/forks","keys_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/teams","hooks_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/hooks","issue_events_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/issues/events{/number}","events_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/events","assignees_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/assignees{/user}","branches_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/branches{/branch}","tags_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/tags","blobs_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/git/refs{/sha}","trees_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/statuses/{sha}","languages_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/languages","stargazers_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/stargazers","contributors_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/contributors","subscribers_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/subscribers","subscription_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/subscription","commits_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/commits{/sha}","git_commits_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/git/commits{/sha}","comments_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/comments{/number}","issue_comment_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/issues/comments{/number}","contents_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/contents/{+path}","compare_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/merges","archive_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/downloads","issues_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/issues{/number}","pulls_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls{/number}","milestones_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/milestones{/number}","notifications_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/labels{/name}","releases_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/releases{/id}","deployments_url":"https://api.github.com/repos/agherzan/meta-raspberrypi/deployments","created_at":"2015-02-14T00:47:35Z","updated_at":"2018-05-07T21:16:24Z","pushed_at":"2018-05-07T16:52:40Z","git_url":"git://github.com/agherzan/meta-raspberrypi.git","ssh_url":"git@github.com:agherzan/meta-raspberrypi.git","clone_url":"https://github.com/agherzan/meta-raspberrypi.git","svn_url":"https://github.com/agherzan/meta-raspberrypi","homepage":"http://www.raspberrypi.org/","size":1443,"stargazers_count":91,"watchers_count":91,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":114,"open_issues":10,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/238"},"html":{"href":"https://github.com/agherzan/meta-raspberrypi/pull/238"},"issue":{"href":"https://api.github.com/repos/agherzan/meta-raspberrypi/issues/238"},"comments":{"href":"https://api.github.com/repos/agherzan/meta-raspberrypi/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/agherzan/meta-raspberrypi/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/agherzan/meta-raspberrypi/statuses/c665643398313268d7b9bfca8597c0effb7b64f7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"agherzan"}}