{"action":"created","issue":{"url":"https://api.github.com/repos/yast/yast-ruby-bindings/issues/216","repository_url":"https://api.github.com/repos/yast/yast-ruby-bindings","labels_url":"https://api.github.com/repos/yast/yast-ruby-bindings/issues/216/labels{/name}","comments_url":"https://api.github.com/repos/yast/yast-ruby-bindings/issues/216/comments","events_url":"https://api.github.com/repos/yast/yast-ruby-bindings/issues/216/events","html_url":"https://github.com/yast/yast-ruby-bindings/pull/216","id":326996165,"number":216,"title":"log method name","user":{"login":"jreidinger","id":478871,"avatar_url":"https://avatars2.githubusercontent.com/u/478871?v=4","gravatar_id":"","url":"https://api.github.com/users/jreidinger","html_url":"https://github.com/jreidinger","followers_url":"https://api.github.com/users/jreidinger/followers","following_url":"https://api.github.com/users/jreidinger/following{/other_user}","gists_url":"https://api.github.com/users/jreidinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jreidinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreidinger/subscriptions","organizations_url":"https://api.github.com/users/jreidinger/orgs","repos_url":"https://api.github.com/users/jreidinger/repos","events_url":"https://api.github.com/users/jreidinger/events{/privacy}","received_events_url":"https://api.github.com/users/jreidinger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-28T11:35:42Z","updated_at":"2018-05-28T11:45:18Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/yast/yast-ruby-bindings/pulls/216","html_url":"https://github.com/yast/yast-ruby-bindings/pull/216","diff_url":"https://github.com/yast/yast-ruby-bindings/pull/216.diff","patch_url":"https://github.com/yast/yast-ruby-bindings/pull/216.patch"},"body":"how it looks before change:\r\n```\r\n2018-05-28 13:10:29 <1> linux-vvcf.privatesite(12728) [Ruby] y2storage/dump_manager.rb:230 Devicegraph dump directory: /var/log/YaST2/storage\r\n2018-05-28 13:10:29 <1> linux-vvcf.privatesite(12728) [Ruby] y2storage/dump_manager.rb:264 Dumping Devicegraph to 01-probed\r\n```\r\n\r\nand after:\r\n```\r\n2018-05-28 13:25:35 <1> linux-vvcf.privatesite(20263) [Ruby] y2storage/dump_manager.rb(lazy_init):230 Devicegraph dump directory: /var/log/YaST2/storage\r\n2018-05-28 13:25:35 <1> linux-vvcf.privatesite(20263) [Ruby] y2storage/dump_manager.rb(dump_internal):264 Dumping Devicegraph to 01-probed\r\n```\r\n\r\n\r\nI tested if it breaks old testsuite and result is that it is broken. Example failed test:\r\n```\r\n[   10s] --- tests/Map.out\t2018-05-11 06:32:41.000000000 +0000\r\n[   10s] +++ tmp.out.Map\t2018-05-28 11:35:08.562451210 +0000\r\n[   10s] @@ -26,32 +26,32 @@\r\n[   10s]  Return\t$[\"A\":1, \"B\":1]\r\n[   10s]  Dump\tMap::CheckKeys\r\n[   10s]  Return\tfalse\r\n[   10s] -Log\tMissing key: 1\r\n[   10s] +Log\tin CheckKeys):97 Missing key: 1\r\n[   10s]  Return\tfalse\r\n[   10s] -Log\tMissing key: nil\r\n[   10s] +Log\tin CheckKeys):97 Missing key: nil\r\n[   10s]  Return\tfalse\r\n[   10s]  Return\ttrue\r\n[   10s] -Log\tMissing key: 2\r\n[   10s] +Log\tin CheckKeys):97 Missing key: 2\r\n[   10s]  Return\tfalse\r\n[   10s] -Log\tMissing key: 1\r\n[   10s] +Log\tin CheckKeys):97 Missing key: 1\r\n[   10s]  Return\tfalse\r\n[   10s]  Return\ttrue\r\n[   10s]  Return\ttrue\r\n[   10s] -Log\tMissing key: `y\r\n[   10s] +Log\tin CheckKeys):97 Missing key: `y\r\n[   10s]  Return\tfalse\r\n[   10s] -Log\tMissing key: 1\r\n[   10s] +Log\tin CheckKeys):97 Missing key: 1\r\n[   10s]  Return\tfalse\r\n[   10s]  Return\ttrue\r\n[   10s]  Return\ttrue\r\n[   10s]  Return\ttrue\r\n[   10s] -Log\tMissing key: 2\r\n[   10s] +Log\tin CheckKeys):97 Missing key: 2\r\n[   10s]  Return\tfalse\r\n[   10s] -Log\tMissing key: 4\r\n[   10s] -Log\tMissing key: 5\r\n[   10s] +Log\tin CheckKeys):97 Missing key: 4\r\n[   10s] +Log\tin CheckKeys):97 Missing key: 5\r\n[   10s]  Return\tfalse\r\n[   10s] -Log\tMissing key: 2\r\n[   10s] +Log\tin CheckKeys):97 Missing key: 2\r\n[   10s]  Return\tfalse\r\n[   10s] -Log\tMissing key: `x\r\n[   10s] +Log\tin CheckKeys):97 Missing key: `x\r\n```"},"comment":{"url":"https://api.github.com/repos/yast/yast-ruby-bindings/issues/comments/392505166","html_url":"https://github.com/yast/yast-ruby-bindings/pull/216#issuecomment-392505166","issue_url":"https://api.github.com/repos/yast/yast-ruby-bindings/issues/216","id":392505166,"user":{"login":"mvidner","id":102056,"avatar_url":"https://avatars3.githubusercontent.com/u/102056?v=4","gravatar_id":"","url":"https://api.github.com/users/mvidner","html_url":"https://github.com/mvidner","followers_url":"https://api.github.com/users/mvidner/followers","following_url":"https://api.github.com/users/mvidner/following{/other_user}","gists_url":"https://api.github.com/users/mvidner/gists{/gist_id}","starred_url":"https://api.github.com/users/mvidner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvidner/subscriptions","organizations_url":"https://api.github.com/users/mvidner/orgs","repos_url":"https://api.github.com/users/mvidner/repos","events_url":"https://api.github.com/users/mvidner/events{/privacy}","received_events_url":"https://api.github.com/users/mvidner/received_events","type":"User","site_admin":false},"created_at":"2018-05-28T11:45:18Z","updated_at":"2018-05-28T11:45:18Z","author_association":"MEMBER","body":"FYI, I did a quick count of the old test cases (`tests/*.out` files) and grouped them by repositories.\r\nTotal:  945\r\n\r\n```\r\ngithub-checkout$ find -path \\*/tests/\\*.out | sort | cut -f3 -d/ | uniq -c | sort -n\r\n      1 yast-audit-laf\r\n      1 yast-fcoe-client\r\n      1 yast-iplb\r\n      1 yast-nis-client\r\n      1 yast-printer\r\n      2 yast-hardware-detection\r\n      2 yast-multipath\r\n      2 yast-slp-server\r\n      3 yast-nis-server\r\n      4 yast-mail\r\n      4 yast-nfs-server\r\n      4 yast-squid\r\n      6 yast-http-server\r\n      6 yast-sound\r\n      7 yast-perl-bindings\r\n      8 yast-samba-client\r\n      9 yast-dns-server\r\n      9 yast-nfs-client\r\n      9 yast-sysconfig\r\n     11 yast-dhcp-server\r\n     19 yast-country\r\n     35 yast-users\r\n     37 yast-samba-server\r\n     37 yast-storage\r\n     71 yast-yast2\r\n    655 yast-core\r\n```"}}
{"actor":{"display_login":"mvidner"}}