{"action":"created","issue":{"url":"https://api.github.com/repos/thelounge/thelounge/issues/2246","repository_url":"https://api.github.com/repos/thelounge/thelounge","labels_url":"https://api.github.com/repos/thelounge/thelounge/issues/2246/labels{/name}","comments_url":"https://api.github.com/repos/thelounge/thelounge/issues/2246/comments","events_url":"https://api.github.com/repos/thelounge/thelounge/issues/2246/events","html_url":"https://github.com/thelounge/thelounge/pull/2246","id":306135406,"number":2246,"title":"Add a semi-opaque overlay when channel list is open on mobile","user":{"login":"astorije","id":113730,"avatar_url":"https://avatars1.githubusercontent.com/u/113730?v=4","gravatar_id":"","url":"https://api.github.com/users/astorije","html_url":"https://github.com/astorije","followers_url":"https://api.github.com/users/astorije/followers","following_url":"https://api.github.com/users/astorije/following{/other_user}","gists_url":"https://api.github.com/users/astorije/gists{/gist_id}","starred_url":"https://api.github.com/users/astorije/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astorije/subscriptions","organizations_url":"https://api.github.com/users/astorije/orgs","repos_url":"https://api.github.com/users/astorije/repos","events_url":"https://api.github.com/users/astorije/events{/privacy}","received_events_url":"https://api.github.com/users/astorije/received_events","type":"User","site_admin":false},"labels":[{"id":323424562,"url":"https://api.github.com/repos/thelounge/thelounge/labels/Type:%20Feature","name":"Type: Feature","color":"86c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/thelounge/thelounge/milestones/28","html_url":"https://github.com/thelounge/thelounge/milestone/28","labels_url":"https://api.github.com/repos/thelounge/thelounge/milestones/28/labels","id":2803396,"number":28,"title":"3.0.0","description":"","creator":{"login":"astorije","id":113730,"avatar_url":"https://avatars1.githubusercontent.com/u/113730?v=4","gravatar_id":"","url":"https://api.github.com/users/astorije","html_url":"https://github.com/astorije","followers_url":"https://api.github.com/users/astorije/followers","following_url":"https://api.github.com/users/astorije/following{/other_user}","gists_url":"https://api.github.com/users/astorije/gists{/gist_id}","starred_url":"https://api.github.com/users/astorije/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astorije/subscriptions","organizations_url":"https://api.github.com/users/astorije/orgs","repos_url":"https://api.github.com/users/astorije/repos","events_url":"https://api.github.com/users/astorije/events{/privacy}","received_events_url":"https://api.github.com/users/astorije/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":202,"state":"open","created_at":"2017-09-29T17:49:11Z","updated_at":"2018-03-18T15:16:05Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-03-17T07:18:19Z","updated_at":"2018-03-18T15:39:42Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/thelounge/thelounge/pulls/2246","html_url":"https://github.com/thelounge/thelounge/pull/2246","diff_url":"https://github.com/thelounge/thelounge/pull/2246.diff","patch_url":"https://github.com/thelounge/thelounge/pull/2246.patch"},"body":"This also fixes a bug that would let user accidentally open a link when trying to close the channel list, [this](https://github.com/thelounge/thelounge/pull/2185/files#diff-97db1f70168fb5f12457b238ff6052b5L2326).\r\n\r\n![sidebar-overlay](https://user-images.githubusercontent.com/113730/37552771-c97e6684-2991-11e8-8f11-643d55236eb0.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/thelounge/thelounge/issues/comments/374009025","html_url":"https://github.com/thelounge/thelounge/pull/2246#issuecomment-374009025","issue_url":"https://api.github.com/repos/thelounge/thelounge/issues/2246","id":374009025,"user":{"login":"McInkay","id":2162657,"avatar_url":"https://avatars2.githubusercontent.com/u/2162657?v=4","gravatar_id":"","url":"https://api.github.com/users/McInkay","html_url":"https://github.com/McInkay","followers_url":"https://api.github.com/users/McInkay/followers","following_url":"https://api.github.com/users/McInkay/following{/other_user}","gists_url":"https://api.github.com/users/McInkay/gists{/gist_id}","starred_url":"https://api.github.com/users/McInkay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McInkay/subscriptions","organizations_url":"https://api.github.com/users/McInkay/orgs","repos_url":"https://api.github.com/users/McInkay/repos","events_url":"https://api.github.com/users/McInkay/events{/privacy}","received_events_url":"https://api.github.com/users/McInkay/received_events","type":"User","site_admin":false},"created_at":"2018-03-18T15:39:42Z","updated_at":"2018-03-18T15:39:42Z","author_association":"MEMBER","body":"Looks pretty good. Found just 1 issue. It might be a bit complicated to explain. Repro steps\r\n\r\n1. Open lounge on mobile device\r\n2. Open sidebar\r\n3. Go into a server lobby\r\n4. Open sidebar again\r\n5. Collapse or expand network\r\n\r\nWhat should happen: network is collapsed or expanded and nothing else\r\n\r\nWhat does happen: network is collapsed or expanded and the sidebar is closed.\r\n\r\nI think this is probably because it's selecting the lobby when clicking the caret of a lobby that is already selected. Or ... something ... "}}
{"actor":{"display_login":"McInkay"}}