{"action":"created","comment":{"url":"https://api.github.com/repos/khaledhosny/ots/pulls/comments/169033315","pull_request_review_id":97493652,"id":169033315,"diff_hunk":"@@ -702,8 +702,9 @@ bool ProcessGeneric(ots::FontFile *header,\n       // We don't sanitize bitmap tables, but don’t reject bitmap-only fonts if\n       // we are asked to pass them thru.\n       // Also don’t reject if we are asked to pass glyf/loca thru.\n-      if (!font->GetTable(OTS_TAG('C','B','D','T')) &&\n-          !font->GetTable(OTS_TAG('C','B','L','C'))) {\n+      if (!font->GetTable(OTS_TAG('C', 'B', 'D', 'T')) &&\n+          !font->GetTable(OTS_TAG('C', 'B', 'L', 'C')) &&\n+          !font->GetTable(OTS_TAG('C', 'F', 'F', '2'))) {","path":"src/ots.cc","position":null,"original_position":8,"commit_id":"3a4dd3c631e7eb6d10900f83a51940c996567788","original_commit_id":"d2ec2ef87d78b0e509660a784e627a9ea08a3c27","user":{"login":"drott","id":1021784,"avatar_url":"https://avatars0.githubusercontent.com/u/1021784?v=4","gravatar_id":"","url":"https://api.github.com/users/drott","html_url":"https://github.com/drott","followers_url":"https://api.github.com/users/drott/followers","following_url":"https://api.github.com/users/drott/following{/other_user}","gists_url":"https://api.github.com/users/drott/gists{/gist_id}","starred_url":"https://api.github.com/users/drott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drott/subscriptions","organizations_url":"https://api.github.com/users/drott/orgs","repos_url":"https://api.github.com/users/drott/repos","events_url":"https://api.github.com/users/drott/events{/privacy}","received_events_url":"https://api.github.com/users/drott/received_events","type":"User","site_admin":false},"body":"Thanks for the review, sounds reasonable. Updated the patch accordingly.\r\n","created_at":"2018-02-19T10:20:23Z","updated_at":"2018-02-19T10:20:23Z","html_url":"https://github.com/khaledhosny/ots/pull/161#discussion_r169033315","pull_request_url":"https://api.github.com/repos/khaledhosny/ots/pulls/161","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/khaledhosny/ots/pulls/comments/169033315"},"html":{"href":"https://github.com/khaledhosny/ots/pull/161#discussion_r169033315"},"pull_request":{"href":"https://api.github.com/repos/khaledhosny/ots/pulls/161"}},"in_reply_to_id":168837601},"pull_request":{"url":"https://api.github.com/repos/khaledhosny/ots/pulls/161","id":169694166,"html_url":"https://github.com/khaledhosny/ots/pull/161","diff_url":"https://github.com/khaledhosny/ots/pull/161.diff","patch_url":"https://github.com/khaledhosny/ots/pull/161.patch","issue_url":"https://api.github.com/repos/khaledhosny/ots/issues/161","number":161,"state":"open","locked":false,"title":"Don't bail if CFF2 glyph table is present","user":{"login":"drott","id":1021784,"avatar_url":"https://avatars0.githubusercontent.com/u/1021784?v=4","gravatar_id":"","url":"https://api.github.com/users/drott","html_url":"https://github.com/drott","followers_url":"https://api.github.com/users/drott/followers","following_url":"https://api.github.com/users/drott/following{/other_user}","gists_url":"https://api.github.com/users/drott/gists{/gist_id}","starred_url":"https://api.github.com/users/drott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drott/subscriptions","organizations_url":"https://api.github.com/users/drott/orgs","repos_url":"https://api.github.com/users/drott/repos","events_url":"https://api.github.com/users/drott/events{/privacy}","received_events_url":"https://api.github.com/users/drott/received_events","type":"User","site_admin":false},"body":"Fixes #160.","created_at":"2018-02-16T18:28:23Z","updated_at":"2018-02-19T10:20:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8efcb773366e1fab5a7c1b5d2cdac3ef922fa3ed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/khaledhosny/ots/pulls/161/commits","review_comments_url":"https://api.github.com/repos/khaledhosny/ots/pulls/161/comments","review_comment_url":"https://api.github.com/repos/khaledhosny/ots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/khaledhosny/ots/issues/161/comments","statuses_url":"https://api.github.com/repos/khaledhosny/ots/statuses/3a4dd3c631e7eb6d10900f83a51940c996567788","head":{"label":"drott:allowCff2","ref":"allowCff2","sha":"3a4dd3c631e7eb6d10900f83a51940c996567788","user":{"login":"drott","id":1021784,"avatar_url":"https://avatars0.githubusercontent.com/u/1021784?v=4","gravatar_id":"","url":"https://api.github.com/users/drott","html_url":"https://github.com/drott","followers_url":"https://api.github.com/users/drott/followers","following_url":"https://api.github.com/users/drott/following{/other_user}","gists_url":"https://api.github.com/users/drott/gists{/gist_id}","starred_url":"https://api.github.com/users/drott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drott/subscriptions","organizations_url":"https://api.github.com/users/drott/orgs","repos_url":"https://api.github.com/users/drott/repos","events_url":"https://api.github.com/users/drott/events{/privacy}","received_events_url":"https://api.github.com/users/drott/received_events","type":"User","site_admin":false},"repo":{"id":121761940,"name":"ots","full_name":"drott/ots","owner":{"login":"drott","id":1021784,"avatar_url":"https://avatars0.githubusercontent.com/u/1021784?v=4","gravatar_id":"","url":"https://api.github.com/users/drott","html_url":"https://github.com/drott","followers_url":"https://api.github.com/users/drott/followers","following_url":"https://api.github.com/users/drott/following{/other_user}","gists_url":"https://api.github.com/users/drott/gists{/gist_id}","starred_url":"https://api.github.com/users/drott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drott/subscriptions","organizations_url":"https://api.github.com/users/drott/orgs","repos_url":"https://api.github.com/users/drott/repos","events_url":"https://api.github.com/users/drott/events{/privacy}","received_events_url":"https://api.github.com/users/drott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drott/ots","description":"Sanitizer for OpenType","fork":true,"url":"https://api.github.com/repos/drott/ots","forks_url":"https://api.github.com/repos/drott/ots/forks","keys_url":"https://api.github.com/repos/drott/ots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drott/ots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drott/ots/teams","hooks_url":"https://api.github.com/repos/drott/ots/hooks","issue_events_url":"https://api.github.com/repos/drott/ots/issues/events{/number}","events_url":"https://api.github.com/repos/drott/ots/events","assignees_url":"https://api.github.com/repos/drott/ots/assignees{/user}","branches_url":"https://api.github.com/repos/drott/ots/branches{/branch}","tags_url":"https://api.github.com/repos/drott/ots/tags","blobs_url":"https://api.github.com/repos/drott/ots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drott/ots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drott/ots/git/refs{/sha}","trees_url":"https://api.github.com/repos/drott/ots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drott/ots/statuses/{sha}","languages_url":"https://api.github.com/repos/drott/ots/languages","stargazers_url":"https://api.github.com/repos/drott/ots/stargazers","contributors_url":"https://api.github.com/repos/drott/ots/contributors","subscribers_url":"https://api.github.com/repos/drott/ots/subscribers","subscription_url":"https://api.github.com/repos/drott/ots/subscription","commits_url":"https://api.github.com/repos/drott/ots/commits{/sha}","git_commits_url":"https://api.github.com/repos/drott/ots/git/commits{/sha}","comments_url":"https://api.github.com/repos/drott/ots/comments{/number}","issue_comment_url":"https://api.github.com/repos/drott/ots/issues/comments{/number}","contents_url":"https://api.github.com/repos/drott/ots/contents/{+path}","compare_url":"https://api.github.com/repos/drott/ots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drott/ots/merges","archive_url":"https://api.github.com/repos/drott/ots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drott/ots/downloads","issues_url":"https://api.github.com/repos/drott/ots/issues{/number}","pulls_url":"https://api.github.com/repos/drott/ots/pulls{/number}","milestones_url":"https://api.github.com/repos/drott/ots/milestones{/number}","notifications_url":"https://api.github.com/repos/drott/ots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drott/ots/labels{/name}","releases_url":"https://api.github.com/repos/drott/ots/releases{/id}","deployments_url":"https://api.github.com/repos/drott/ots/deployments","created_at":"2018-02-16T14:47:26Z","updated_at":"2018-02-16T14:47:28Z","pushed_at":"2018-02-19T10:19:45Z","git_url":"git://github.com/drott/ots.git","ssh_url":"git@github.com:drott/ots.git","clone_url":"https://github.com/drott/ots.git","svn_url":"https://github.com/drott/ots","homepage":"","size":26758,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"khaledhosny:master","ref":"master","sha":"50b539d9b0d1fc3a09cfcd22c93ca675904e07d2","user":{"login":"khaledhosny","id":93914,"avatar_url":"https://avatars0.githubusercontent.com/u/93914?v=4","gravatar_id":"","url":"https://api.github.com/users/khaledhosny","html_url":"https://github.com/khaledhosny","followers_url":"https://api.github.com/users/khaledhosny/followers","following_url":"https://api.github.com/users/khaledhosny/following{/other_user}","gists_url":"https://api.github.com/users/khaledhosny/gists{/gist_id}","starred_url":"https://api.github.com/users/khaledhosny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khaledhosny/subscriptions","organizations_url":"https://api.github.com/users/khaledhosny/orgs","repos_url":"https://api.github.com/users/khaledhosny/repos","events_url":"https://api.github.com/users/khaledhosny/events{/privacy}","received_events_url":"https://api.github.com/users/khaledhosny/received_events","type":"User","site_admin":false},"repo":{"id":15947557,"name":"ots","full_name":"khaledhosny/ots","owner":{"login":"khaledhosny","id":93914,"avatar_url":"https://avatars0.githubusercontent.com/u/93914?v=4","gravatar_id":"","url":"https://api.github.com/users/khaledhosny","html_url":"https://github.com/khaledhosny","followers_url":"https://api.github.com/users/khaledhosny/followers","following_url":"https://api.github.com/users/khaledhosny/following{/other_user}","gists_url":"https://api.github.com/users/khaledhosny/gists{/gist_id}","starred_url":"https://api.github.com/users/khaledhosny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khaledhosny/subscriptions","organizations_url":"https://api.github.com/users/khaledhosny/orgs","repos_url":"https://api.github.com/users/khaledhosny/repos","events_url":"https://api.github.com/users/khaledhosny/events{/privacy}","received_events_url":"https://api.github.com/users/khaledhosny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khaledhosny/ots","description":"Sanitizer for OpenType","fork":false,"url":"https://api.github.com/repos/khaledhosny/ots","forks_url":"https://api.github.com/repos/khaledhosny/ots/forks","keys_url":"https://api.github.com/repos/khaledhosny/ots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khaledhosny/ots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khaledhosny/ots/teams","hooks_url":"https://api.github.com/repos/khaledhosny/ots/hooks","issue_events_url":"https://api.github.com/repos/khaledhosny/ots/issues/events{/number}","events_url":"https://api.github.com/repos/khaledhosny/ots/events","assignees_url":"https://api.github.com/repos/khaledhosny/ots/assignees{/user}","branches_url":"https://api.github.com/repos/khaledhosny/ots/branches{/branch}","tags_url":"https://api.github.com/repos/khaledhosny/ots/tags","blobs_url":"https://api.github.com/repos/khaledhosny/ots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khaledhosny/ots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khaledhosny/ots/git/refs{/sha}","trees_url":"https://api.github.com/repos/khaledhosny/ots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khaledhosny/ots/statuses/{sha}","languages_url":"https://api.github.com/repos/khaledhosny/ots/languages","stargazers_url":"https://api.github.com/repos/khaledhosny/ots/stargazers","contributors_url":"https://api.github.com/repos/khaledhosny/ots/contributors","subscribers_url":"https://api.github.com/repos/khaledhosny/ots/subscribers","subscription_url":"https://api.github.com/repos/khaledhosny/ots/subscription","commits_url":"https://api.github.com/repos/khaledhosny/ots/commits{/sha}","git_commits_url":"https://api.github.com/repos/khaledhosny/ots/git/commits{/sha}","comments_url":"https://api.github.com/repos/khaledhosny/ots/comments{/number}","issue_comment_url":"https://api.github.com/repos/khaledhosny/ots/issues/comments{/number}","contents_url":"https://api.github.com/repos/khaledhosny/ots/contents/{+path}","compare_url":"https://api.github.com/repos/khaledhosny/ots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khaledhosny/ots/merges","archive_url":"https://api.github.com/repos/khaledhosny/ots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khaledhosny/ots/downloads","issues_url":"https://api.github.com/repos/khaledhosny/ots/issues{/number}","pulls_url":"https://api.github.com/repos/khaledhosny/ots/pulls{/number}","milestones_url":"https://api.github.com/repos/khaledhosny/ots/milestones{/number}","notifications_url":"https://api.github.com/repos/khaledhosny/ots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khaledhosny/ots/labels{/name}","releases_url":"https://api.github.com/repos/khaledhosny/ots/releases{/id}","deployments_url":"https://api.github.com/repos/khaledhosny/ots/deployments","created_at":"2014-01-15T20:36:53Z","updated_at":"2017-12-19T04:33:10Z","pushed_at":"2018-02-19T10:19:46Z","git_url":"git://github.com/khaledhosny/ots.git","ssh_url":"git@github.com:khaledhosny/ots.git","clone_url":"https://github.com/khaledhosny/ots.git","svn_url":"https://github.com/khaledhosny/ots","homepage":"","size":26758,"stargazers_count":74,"watchers_count":74,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":27,"open_issues":18,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/khaledhosny/ots/pulls/161"},"html":{"href":"https://github.com/khaledhosny/ots/pull/161"},"issue":{"href":"https://api.github.com/repos/khaledhosny/ots/issues/161"},"comments":{"href":"https://api.github.com/repos/khaledhosny/ots/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/khaledhosny/ots/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/khaledhosny/ots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/khaledhosny/ots/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/khaledhosny/ots/statuses/3a4dd3c631e7eb6d10900f83a51940c996567788"}},"author_association":"NONE"}}
{"actor":{"display_login":"drott"}}