{"action":"created","comment":{"url":"https://api.github.com/repos/nilearn/nilearn/pulls/comments/222682044","pull_request_review_id":161627435,"id":222682044,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjY4MjA0NA==","diff_hunk":"@@ -775,6 +776,7 @@ def _show_colorbar(self, cmap, norm, threshold=None):\n             self._colorbar_ax, ticks=ticks, norm=norm,\n             orientation='vertical', cmap=our_cmap, boundaries=bounds,\n             spacing='proportional', format='%.2g')\n+        self._cbar.patch.set_facecolor(mid_gray)","path":"nilearn/plotting/displays.py","position":15,"original_position":15,"commit_id":"83e89315ec5ede5ffc3f54d9840d78a6b29e27ca","original_commit_id":"83e89315ec5ede5ffc3f54d9840d78a6b29e27ca","user":{"login":"KamalakerDadi","id":11410385,"node_id":"MDQ6VXNlcjExNDEwMzg1","avatar_url":"https://avatars2.githubusercontent.com/u/11410385?v=4","gravatar_id":"","url":"https://api.github.com/users/KamalakerDadi","html_url":"https://github.com/KamalakerDadi","followers_url":"https://api.github.com/users/KamalakerDadi/followers","following_url":"https://api.github.com/users/KamalakerDadi/following{/other_user}","gists_url":"https://api.github.com/users/KamalakerDadi/gists{/gist_id}","starred_url":"https://api.github.com/users/KamalakerDadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KamalakerDadi/subscriptions","organizations_url":"https://api.github.com/users/KamalakerDadi/orgs","repos_url":"https://api.github.com/users/KamalakerDadi/repos","events_url":"https://api.github.com/users/KamalakerDadi/events{/privacy}","received_events_url":"https://api.github.com/users/KamalakerDadi/received_events","type":"User","site_admin":false},"body":"Is it this enough ? Do you also need adding (0.) ?\r\n\r\nFor me it looks like using only this ```self._cbar.patch.set_facecolor(mid_gray)``` is sufficient. Correct me if I am wrong.","created_at":"2018-10-04T14:04:15Z","updated_at":"2018-10-04T14:04:16Z","html_url":"https://github.com/nilearn/nilearn/pull/1758#discussion_r222682044","pull_request_url":"https://api.github.com/repos/nilearn/nilearn/pulls/1758","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nilearn/nilearn/pulls/comments/222682044"},"html":{"href":"https://github.com/nilearn/nilearn/pull/1758#discussion_r222682044"},"pull_request":{"href":"https://api.github.com/repos/nilearn/nilearn/pulls/1758"}}},"pull_request":{"url":"https://api.github.com/repos/nilearn/nilearn/pulls/1758","id":215289043,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1Mjg5MDQz","html_url":"https://github.com/nilearn/nilearn/pull/1758","diff_url":"https://github.com/nilearn/nilearn/pull/1758.diff","patch_url":"https://github.com/nilearn/nilearn/pull/1758.patch","issue_url":"https://api.github.com/repos/nilearn/nilearn/issues/1758","number":1758,"state":"open","locked":false,"title":"BUG: Fix alpha for transparent colormaps","user":{"login":"larsoner","id":2365790,"node_id":"MDQ6VXNlcjIzNjU3OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/2365790?v=4","gravatar_id":"","url":"https://api.github.com/users/larsoner","html_url":"https://github.com/larsoner","followers_url":"https://api.github.com/users/larsoner/followers","following_url":"https://api.github.com/users/larsoner/following{/other_user}","gists_url":"https://api.github.com/users/larsoner/gists{/gist_id}","starred_url":"https://api.github.com/users/larsoner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsoner/subscriptions","organizations_url":"https://api.github.com/users/larsoner/orgs","repos_url":"https://api.github.com/users/larsoner/repos","events_url":"https://api.github.com/users/larsoner/events{/privacy}","received_events_url":"https://api.github.com/users/larsoner/received_events","type":"User","site_admin":false},"body":"For plotting functions, the colorbar has a white background. This is problematic because colormaps with an alpha channel are displayed incorrectly. This sets the background color to mid gray, and thus also sets the `cmaplist` entries that are below `threshold` just to be fully transparent. This should have the same effect as using `(0.5, 0.5, 0.5, 1.0)` directly but is more consistent with what the plotting is actually doing.","created_at":"2018-09-13T13:48:27Z","updated_at":"2018-10-04T14:04:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"406028dc54b3092f4d85fb8c1a7587891dc841ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nilearn/nilearn/pulls/1758/commits","review_comments_url":"https://api.github.com/repos/nilearn/nilearn/pulls/1758/comments","review_comment_url":"https://api.github.com/repos/nilearn/nilearn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nilearn/nilearn/issues/1758/comments","statuses_url":"https://api.github.com/repos/nilearn/nilearn/statuses/83e89315ec5ede5ffc3f54d9840d78a6b29e27ca","head":{"label":"larsoner:alpha","ref":"alpha","sha":"83e89315ec5ede5ffc3f54d9840d78a6b29e27ca","user":{"login":"larsoner","id":2365790,"node_id":"MDQ6VXNlcjIzNjU3OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/2365790?v=4","gravatar_id":"","url":"https://api.github.com/users/larsoner","html_url":"https://github.com/larsoner","followers_url":"https://api.github.com/users/larsoner/followers","following_url":"https://api.github.com/users/larsoner/following{/other_user}","gists_url":"https://api.github.com/users/larsoner/gists{/gist_id}","starred_url":"https://api.github.com/users/larsoner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsoner/subscriptions","organizations_url":"https://api.github.com/users/larsoner/orgs","repos_url":"https://api.github.com/users/larsoner/repos","events_url":"https://api.github.com/users/larsoner/events{/privacy}","received_events_url":"https://api.github.com/users/larsoner/received_events","type":"User","site_admin":false},"repo":{"id":100545537,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA1NDU1Mzc=","name":"nilearn","full_name":"larsoner/nilearn","private":false,"owner":{"login":"larsoner","id":2365790,"node_id":"MDQ6VXNlcjIzNjU3OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/2365790?v=4","gravatar_id":"","url":"https://api.github.com/users/larsoner","html_url":"https://github.com/larsoner","followers_url":"https://api.github.com/users/larsoner/followers","following_url":"https://api.github.com/users/larsoner/following{/other_user}","gists_url":"https://api.github.com/users/larsoner/gists{/gist_id}","starred_url":"https://api.github.com/users/larsoner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsoner/subscriptions","organizations_url":"https://api.github.com/users/larsoner/orgs","repos_url":"https://api.github.com/users/larsoner/repos","events_url":"https://api.github.com/users/larsoner/events{/privacy}","received_events_url":"https://api.github.com/users/larsoner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/larsoner/nilearn","description":"Machine learning for NeuroImaging in Python","fork":true,"url":"https://api.github.com/repos/larsoner/nilearn","forks_url":"https://api.github.com/repos/larsoner/nilearn/forks","keys_url":"https://api.github.com/repos/larsoner/nilearn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/larsoner/nilearn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/larsoner/nilearn/teams","hooks_url":"https://api.github.com/repos/larsoner/nilearn/hooks","issue_events_url":"https://api.github.com/repos/larsoner/nilearn/issues/events{/number}","events_url":"https://api.github.com/repos/larsoner/nilearn/events","assignees_url":"https://api.github.com/repos/larsoner/nilearn/assignees{/user}","branches_url":"https://api.github.com/repos/larsoner/nilearn/branches{/branch}","tags_url":"https://api.github.com/repos/larsoner/nilearn/tags","blobs_url":"https://api.github.com/repos/larsoner/nilearn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/larsoner/nilearn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/larsoner/nilearn/git/refs{/sha}","trees_url":"https://api.github.com/repos/larsoner/nilearn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/larsoner/nilearn/statuses/{sha}","languages_url":"https://api.github.com/repos/larsoner/nilearn/languages","stargazers_url":"https://api.github.com/repos/larsoner/nilearn/stargazers","contributors_url":"https://api.github.com/repos/larsoner/nilearn/contributors","subscribers_url":"https://api.github.com/repos/larsoner/nilearn/subscribers","subscription_url":"https://api.github.com/repos/larsoner/nilearn/subscription","commits_url":"https://api.github.com/repos/larsoner/nilearn/commits{/sha}","git_commits_url":"https://api.github.com/repos/larsoner/nilearn/git/commits{/sha}","comments_url":"https://api.github.com/repos/larsoner/nilearn/comments{/number}","issue_comment_url":"https://api.github.com/repos/larsoner/nilearn/issues/comments{/number}","contents_url":"https://api.github.com/repos/larsoner/nilearn/contents/{+path}","compare_url":"https://api.github.com/repos/larsoner/nilearn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/larsoner/nilearn/merges","archive_url":"https://api.github.com/repos/larsoner/nilearn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/larsoner/nilearn/downloads","issues_url":"https://api.github.com/repos/larsoner/nilearn/issues{/number}","pulls_url":"https://api.github.com/repos/larsoner/nilearn/pulls{/number}","milestones_url":"https://api.github.com/repos/larsoner/nilearn/milestones{/number}","notifications_url":"https://api.github.com/repos/larsoner/nilearn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/larsoner/nilearn/labels{/name}","releases_url":"https://api.github.com/repos/larsoner/nilearn/releases{/id}","deployments_url":"https://api.github.com/repos/larsoner/nilearn/deployments","created_at":"2017-08-17T00:51:57Z","updated_at":"2018-07-30T16:35:29Z","pushed_at":"2018-09-19T11:49:19Z","git_url":"git://github.com/larsoner/nilearn.git","ssh_url":"git@github.com:larsoner/nilearn.git","clone_url":"https://github.com/larsoner/nilearn.git","svn_url":"https://github.com/larsoner/nilearn","homepage":"http://nilearn.github.io","size":18084,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nilearn:master","ref":"master","sha":"5911eb6b2bef897b7a3fea4ab17954ae94da2b88","user":{"login":"nilearn","id":4646912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDY5MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/4646912?v=4","gravatar_id":"","url":"https://api.github.com/users/nilearn","html_url":"https://github.com/nilearn","followers_url":"https://api.github.com/users/nilearn/followers","following_url":"https://api.github.com/users/nilearn/following{/other_user}","gists_url":"https://api.github.com/users/nilearn/gists{/gist_id}","starred_url":"https://api.github.com/users/nilearn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilearn/subscriptions","organizations_url":"https://api.github.com/users/nilearn/orgs","repos_url":"https://api.github.com/users/nilearn/repos","events_url":"https://api.github.com/users/nilearn/events{/privacy}","received_events_url":"https://api.github.com/users/nilearn/received_events","type":"Organization","site_admin":false},"repo":{"id":1235740,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1NzQw","name":"nilearn","full_name":"nilearn/nilearn","private":false,"owner":{"login":"nilearn","id":4646912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDY5MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/4646912?v=4","gravatar_id":"","url":"https://api.github.com/users/nilearn","html_url":"https://github.com/nilearn","followers_url":"https://api.github.com/users/nilearn/followers","following_url":"https://api.github.com/users/nilearn/following{/other_user}","gists_url":"https://api.github.com/users/nilearn/gists{/gist_id}","starred_url":"https://api.github.com/users/nilearn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilearn/subscriptions","organizations_url":"https://api.github.com/users/nilearn/orgs","repos_url":"https://api.github.com/users/nilearn/repos","events_url":"https://api.github.com/users/nilearn/events{/privacy}","received_events_url":"https://api.github.com/users/nilearn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nilearn/nilearn","description":"Machine learning for NeuroImaging in Python","fork":false,"url":"https://api.github.com/repos/nilearn/nilearn","forks_url":"https://api.github.com/repos/nilearn/nilearn/forks","keys_url":"https://api.github.com/repos/nilearn/nilearn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nilearn/nilearn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nilearn/nilearn/teams","hooks_url":"https://api.github.com/repos/nilearn/nilearn/hooks","issue_events_url":"https://api.github.com/repos/nilearn/nilearn/issues/events{/number}","events_url":"https://api.github.com/repos/nilearn/nilearn/events","assignees_url":"https://api.github.com/repos/nilearn/nilearn/assignees{/user}","branches_url":"https://api.github.com/repos/nilearn/nilearn/branches{/branch}","tags_url":"https://api.github.com/repos/nilearn/nilearn/tags","blobs_url":"https://api.github.com/repos/nilearn/nilearn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nilearn/nilearn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nilearn/nilearn/git/refs{/sha}","trees_url":"https://api.github.com/repos/nilearn/nilearn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nilearn/nilearn/statuses/{sha}","languages_url":"https://api.github.com/repos/nilearn/nilearn/languages","stargazers_url":"https://api.github.com/repos/nilearn/nilearn/stargazers","contributors_url":"https://api.github.com/repos/nilearn/nilearn/contributors","subscribers_url":"https://api.github.com/repos/nilearn/nilearn/subscribers","subscription_url":"https://api.github.com/repos/nilearn/nilearn/subscription","commits_url":"https://api.github.com/repos/nilearn/nilearn/commits{/sha}","git_commits_url":"https://api.github.com/repos/nilearn/nilearn/git/commits{/sha}","comments_url":"https://api.github.com/repos/nilearn/nilearn/comments{/number}","issue_comment_url":"https://api.github.com/repos/nilearn/nilearn/issues/comments{/number}","contents_url":"https://api.github.com/repos/nilearn/nilearn/contents/{+path}","compare_url":"https://api.github.com/repos/nilearn/nilearn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nilearn/nilearn/merges","archive_url":"https://api.github.com/repos/nilearn/nilearn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nilearn/nilearn/downloads","issues_url":"https://api.github.com/repos/nilearn/nilearn/issues{/number}","pulls_url":"https://api.github.com/repos/nilearn/nilearn/pulls{/number}","milestones_url":"https://api.github.com/repos/nilearn/nilearn/milestones{/number}","notifications_url":"https://api.github.com/repos/nilearn/nilearn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nilearn/nilearn/labels{/name}","releases_url":"https://api.github.com/repos/nilearn/nilearn/releases{/id}","deployments_url":"https://api.github.com/repos/nilearn/nilearn/deployments","created_at":"2011-01-09T19:02:23Z","updated_at":"2018-10-03T22:00:42Z","pushed_at":"2018-10-03T11:52:02Z","git_url":"git://github.com/nilearn/nilearn.git","ssh_url":"git@github.com:nilearn/nilearn.git","clone_url":"https://github.com/nilearn/nilearn.git","svn_url":"https://github.com/nilearn/nilearn","homepage":"http://nilearn.github.io","size":18092,"stargazers_count":446,"watchers_count":446,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":277,"mirror_url":null,"archived":false,"open_issues_count":273,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":277,"open_issues":273,"watchers":446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nilearn/nilearn/pulls/1758"},"html":{"href":"https://github.com/nilearn/nilearn/pull/1758"},"issue":{"href":"https://api.github.com/repos/nilearn/nilearn/issues/1758"},"comments":{"href":"https://api.github.com/repos/nilearn/nilearn/issues/1758/comments"},"review_comments":{"href":"https://api.github.com/repos/nilearn/nilearn/pulls/1758/comments"},"review_comment":{"href":"https://api.github.com/repos/nilearn/nilearn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nilearn/nilearn/pulls/1758/commits"},"statuses":{"href":"https://api.github.com/repos/nilearn/nilearn/statuses/83e89315ec5ede5ffc3f54d9840d78a6b29e27ca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KamalakerDadi"}}