{"action":"created","issue":{"url":"https://api.github.com/repos/xapi-project/xen-api/issues/3431","repository_url":"https://api.github.com/repos/xapi-project/xen-api","labels_url":"https://api.github.com/repos/xapi-project/xen-api/issues/3431/labels{/name}","comments_url":"https://api.github.com/repos/xapi-project/xen-api/issues/3431/comments","events_url":"https://api.github.com/repos/xapi-project/xen-api/issues/3431/events","html_url":"https://github.com/xapi-project/xen-api/pull/3431","id":294338649,"number":3431,"title":"CP-25699 Refine PIF type check related stuff","user":{"login":"krizex","id":3365993,"avatar_url":"https://avatars0.githubusercontent.com/u/3365993?v=4","gravatar_id":"","url":"https://api.github.com/users/krizex","html_url":"https://github.com/krizex","followers_url":"https://api.github.com/users/krizex/followers","following_url":"https://api.github.com/users/krizex/following{/other_user}","gists_url":"https://api.github.com/users/krizex/gists{/gist_id}","starred_url":"https://api.github.com/users/krizex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krizex/subscriptions","organizations_url":"https://api.github.com/users/krizex/orgs","repos_url":"https://api.github.com/users/krizex/repos","events_url":"https://api.github.com/users/krizex/events{/privacy}","received_events_url":"https://api.github.com/users/krizex/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-02-05T10:15:42Z","updated_at":"2018-02-05T14:57:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/xapi-project/xen-api/pulls/3431","html_url":"https://github.com/xapi-project/xen-api/pull/3431","diff_url":"https://github.com/xapi-project/xen-api/pull/3431.diff","patch_url":"https://github.com/xapi-project/xen-api/pull/3431.patch"},"body":"1. Add Xapi_pif_helpers.ml contains:\r\n  + Add get_pif_type to get PIF type\r\n  + Add X_is_allowed_on_pif serial functions to exectue check before creating\r\n  VLAN, bond and tunnel\r\n2. Add support of sriov PIF in nm.bring_pif_up and nm.bring_pif_down\r\n3. Apply Xapi_pif_helpers.get_pif_type in nm.ml\r\n4. Refine VLAN UT\r\n\r\nSigned-off-by: Yang Qian <yang.qian@citrix.com>\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/xapi-project/xen-api/3431)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/xapi-project/xen-api/issues/comments/363108759","html_url":"https://github.com/xapi-project/xen-api/pull/3431#issuecomment-363108759","issue_url":"https://api.github.com/repos/xapi-project/xen-api/issues/3431","id":363108759,"user":{"login":"mseri","id":4040623,"avatar_url":"https://avatars0.githubusercontent.com/u/4040623?v=4","gravatar_id":"","url":"https://api.github.com/users/mseri","html_url":"https://github.com/mseri","followers_url":"https://api.github.com/users/mseri/followers","following_url":"https://api.github.com/users/mseri/following{/other_user}","gists_url":"https://api.github.com/users/mseri/gists{/gist_id}","starred_url":"https://api.github.com/users/mseri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseri/subscriptions","organizations_url":"https://api.github.com/users/mseri/orgs","repos_url":"https://api.github.com/users/mseri/repos","events_url":"https://api.github.com/users/mseri/events{/privacy}","received_events_url":"https://api.github.com/users/mseri/received_events","type":"User","site_admin":false},"created_at":"2018-02-05T14:57:11Z","updated_at":"2018-02-05T14:57:11Z","author_association":"CONTRIBUTOR","body":"\n\n\n\n\n\n\n\n*[ocaml/xapi/xapi_pif_helpers.ml, line 124 at r1](https://reviewable.io:443/reviews/xapi-project/xen-api/3431#-L4_impaDgWw47igSWEW:-L4aSvjcz5FInYUrNRvo:bk4l2vs) ([raw file](https://github.com/xapi-project/xen-api/blob/fcf85fde6b86799ba02ad2c3b256fce7f66efaff/ocaml/xapi/xapi_pif_helpers.ml#L124)):*\n<details><summary><i>Previously, krizex (Yang Qian) wrote…</i></summary><blockquote>\n\nThen I'd rather match the pattern as \n```\n| Physical pif_rec :: _\n```\nbecause for now we don't care what tail is and actually as `Physical` is a terminate symbol, tail should always be `[]`.\n</blockquote></details>\n\nFine with me but please add a comment saying `(* Here we rely on the implementation to guarantee that `Phisycal` is a terminating case *)` even if it is redundant\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/xapi-project/xen-api/3431)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"mseri"}}