{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/EIPs/issues/1151","repository_url":"https://api.github.com/repos/ethereum/EIPs","labels_url":"https://api.github.com/repos/ethereum/EIPs/issues/1151/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/EIPs/issues/1151/comments","events_url":"https://api.github.com/repos/ethereum/EIPs/issues/1151/events","html_url":"https://github.com/ethereum/EIPs/pull/1151","id":331748936,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NDA0Mjc1","number":1151,"title":"mild approve()/Approval() clarifications","user":{"login":"shrugs","id":1535001,"node_id":"MDQ6VXNlcjE1MzUwMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1535001?v=4","gravatar_id":"","url":"https://api.github.com/users/shrugs","html_url":"https://github.com/shrugs","followers_url":"https://api.github.com/users/shrugs/followers","following_url":"https://api.github.com/users/shrugs/following{/other_user}","gists_url":"https://api.github.com/users/shrugs/gists{/gist_id}","starred_url":"https://api.github.com/users/shrugs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrugs/subscriptions","organizations_url":"https://api.github.com/users/shrugs/orgs","repos_url":"https://api.github.com/users/shrugs/repos","events_url":"https://api.github.com/users/shrugs/events{/privacy}","received_events_url":"https://api.github.com/users/shrugs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-06-12T20:51:41Z","updated_at":"2018-06-19T09:38:49Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ethereum/EIPs/pulls/1151","html_url":"https://github.com/ethereum/EIPs/pull/1151","diff_url":"https://github.com/ethereum/EIPs/pull/1151.diff","patch_url":"https://github.com/ethereum/EIPs/pull/1151.patch"},"body":"In ERC721, specify that `Approval` should be emitted in a \"set or reaffirmation\" and not just on a \"change or reaffirmation\"."},"comment":{"url":"https://api.github.com/repos/ethereum/EIPs/issues/comments/398338859","html_url":"https://github.com/ethereum/EIPs/pull/1151#issuecomment-398338859","issue_url":"https://api.github.com/repos/ethereum/EIPs/issues/1151","id":398338859,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODMzODg1OQ==","user":{"login":"mg6maciej","id":1316369,"node_id":"MDQ6VXNlcjEzMTYzNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1316369?v=4","gravatar_id":"","url":"https://api.github.com/users/mg6maciej","html_url":"https://github.com/mg6maciej","followers_url":"https://api.github.com/users/mg6maciej/followers","following_url":"https://api.github.com/users/mg6maciej/following{/other_user}","gists_url":"https://api.github.com/users/mg6maciej/gists{/gist_id}","starred_url":"https://api.github.com/users/mg6maciej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mg6maciej/subscriptions","organizations_url":"https://api.github.com/users/mg6maciej/orgs","repos_url":"https://api.github.com/users/mg6maciej/repos","events_url":"https://api.github.com/users/mg6maciej/events{/privacy}","received_events_url":"https://api.github.com/users/mg6maciej/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T09:38:49Z","updated_at":"2018-06-19T09:38:49Z","author_association":"CONTRIBUTOR","body":"Looking at it again and at 0xcert and openzeppelin implementations, the `Approval` event seems to be emitted in call cases:\r\n* set (none -> address)\r\n* unset (address -> none)\r\n* changed (address -> another address)\r\n* reaffirmed (none -> none or address -> same address)\r\n\r\n\"Changed\" can also be understood as a set of {set, unset, changed}, so I think it might be better to leave it as \"changed or reaffirmed\" instead of listing all cases or maybe just write something along the lines of \"In all cases Approval event is emitted\"."}}
{"actor":{"display_login":"mg6maciej"}}