{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/205994788","pull_request_review_id":141368418,"id":205994788,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTk5NDc4OA==","diff_hunk":"@@ -248,8 +248,13 @@ func (b *BundleAPI) fillBundleData(model description.Model) (*charm.BundleData,\n \t\t\tAnnotations: machine.Annotations(),\n \t\t\tSeries:      machine.Series(),\n \t\t}\n-\t\tif result := b.constraints(machine.Constraints()); len(result) != 0 {\n+\n+\t\tif result := b.hardwareConstraints(machine.Instance()); len(result) != 0 {\n \t\t\tnewMachine.Constraints = strings.Join(result, \" \")\n+\t\t} else {\n+\t\t\tif result = b.machineConstraints(machine.Constraints()); len(result) != 0 {","path":"apiserver/facades/client/bundle/bundle.go","position":27,"original_position":27,"commit_id":"7d0766ee85dc0c590f3fe3d7bf893468cc8b18fc","original_commit_id":"7d0766ee85dc0c590f3fe3d7bf893468cc8b18fc","user":{"login":"wallyworld","id":5808968,"node_id":"MDQ6VXNlcjU4MDg5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/5808968?v=4","gravatar_id":"","url":"https://api.github.com/users/wallyworld","html_url":"https://github.com/wallyworld","followers_url":"https://api.github.com/users/wallyworld/followers","following_url":"https://api.github.com/users/wallyworld/following{/other_user}","gists_url":"https://api.github.com/users/wallyworld/gists{/gist_id}","starred_url":"https://api.github.com/users/wallyworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallyworld/subscriptions","organizations_url":"https://api.github.com/users/wallyworld/orgs","repos_url":"https://api.github.com/users/wallyworld/repos","events_url":"https://api.github.com/users/wallyworld/events{/privacy}","received_events_url":"https://api.github.com/users/wallyworld/received_events","type":"User","site_admin":false},"body":"We don't need this here right?\r\nSince we set machine constraints earlier up above?","created_at":"2018-07-30T00:57:04Z","updated_at":"2018-07-30T00:57:04Z","html_url":"https://github.com/juju/juju/pull/8985#discussion_r205994788","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/8985","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/205994788"},"html":{"href":"https://github.com/juju/juju/pull/8985#discussion_r205994788"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/8985"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/8985","id":204334427,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MzM0NDI3","html_url":"https://github.com/juju/juju/pull/8985","diff_url":"https://github.com/juju/juju/pull/8985.diff","patch_url":"https://github.com/juju/juju/pull/8985.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/8985","number":8985,"state":"open","locked":false,"title":"Added logic to consider provisioned H/W for mac","user":{"login":"vinu2003","id":31263558,"node_id":"MDQ6VXNlcjMxMjYzNTU4","avatar_url":"https://avatars1.githubusercontent.com/u/31263558?v=4","gravatar_id":"","url":"https://api.github.com/users/vinu2003","html_url":"https://github.com/vinu2003","followers_url":"https://api.github.com/users/vinu2003/followers","following_url":"https://api.github.com/users/vinu2003/following{/other_user}","gists_url":"https://api.github.com/users/vinu2003/gists{/gist_id}","starred_url":"https://api.github.com/users/vinu2003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinu2003/subscriptions","organizations_url":"https://api.github.com/users/vinu2003/orgs","repos_url":"https://api.github.com/users/vinu2003/repos","events_url":"https://api.github.com/users/vinu2003/events{/privacy}","received_events_url":"https://api.github.com/users/vinu2003/received_events","type":"User","site_admin":false},"body":"## Please provide the following details to expedite Pull Request review:\r\n## Description of change\r\nThis PR addresses the changes to consider provisioned hardware characteristics for machines constraints.\r\n\r\n*Please replace with a description about why this change is needed?*\r\n*Please replace with how we can verify that the change works?*\r\nexecute export-bundle command in developer-mode\r\n\r\n## Documentation changes\r\nN/A\r\n## Bug reference\r\nN/A\r\n","created_at":"2018-07-27T05:41:16Z","updated_at":"2018-07-30T00:57:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1facbfb6c87cf86fdac364a57c9c8d7ab061a506","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/8985/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/8985/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/8985/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/7d0766ee85dc0c590f3fe3d7bf893468cc8b18fc","head":{"label":"vinu2003:juju_provisionHWMac_exportBundle","ref":"juju_provisionHWMac_exportBundle","sha":"7d0766ee85dc0c590f3fe3d7bf893468cc8b18fc","user":{"login":"vinu2003","id":31263558,"node_id":"MDQ6VXNlcjMxMjYzNTU4","avatar_url":"https://avatars1.githubusercontent.com/u/31263558?v=4","gravatar_id":"","url":"https://api.github.com/users/vinu2003","html_url":"https://github.com/vinu2003","followers_url":"https://api.github.com/users/vinu2003/followers","following_url":"https://api.github.com/users/vinu2003/following{/other_user}","gists_url":"https://api.github.com/users/vinu2003/gists{/gist_id}","starred_url":"https://api.github.com/users/vinu2003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinu2003/subscriptions","organizations_url":"https://api.github.com/users/vinu2003/orgs","repos_url":"https://api.github.com/users/vinu2003/repos","events_url":"https://api.github.com/users/vinu2003/events{/privacy}","received_events_url":"https://api.github.com/users/vinu2003/received_events","type":"User","site_admin":false},"repo":{"id":129232886,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkyMzI4ODY=","name":"juju","full_name":"vinu2003/juju","owner":{"login":"vinu2003","id":31263558,"node_id":"MDQ6VXNlcjMxMjYzNTU4","avatar_url":"https://avatars1.githubusercontent.com/u/31263558?v=4","gravatar_id":"","url":"https://api.github.com/users/vinu2003","html_url":"https://github.com/vinu2003","followers_url":"https://api.github.com/users/vinu2003/followers","following_url":"https://api.github.com/users/vinu2003/following{/other_user}","gists_url":"https://api.github.com/users/vinu2003/gists{/gist_id}","starred_url":"https://api.github.com/users/vinu2003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinu2003/subscriptions","organizations_url":"https://api.github.com/users/vinu2003/orgs","repos_url":"https://api.github.com/users/vinu2003/repos","events_url":"https://api.github.com/users/vinu2003/events{/privacy}","received_events_url":"https://api.github.com/users/vinu2003/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vinu2003/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/vinu2003/juju","forks_url":"https://api.github.com/repos/vinu2003/juju/forks","keys_url":"https://api.github.com/repos/vinu2003/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vinu2003/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vinu2003/juju/teams","hooks_url":"https://api.github.com/repos/vinu2003/juju/hooks","issue_events_url":"https://api.github.com/repos/vinu2003/juju/issues/events{/number}","events_url":"https://api.github.com/repos/vinu2003/juju/events","assignees_url":"https://api.github.com/repos/vinu2003/juju/assignees{/user}","branches_url":"https://api.github.com/repos/vinu2003/juju/branches{/branch}","tags_url":"https://api.github.com/repos/vinu2003/juju/tags","blobs_url":"https://api.github.com/repos/vinu2003/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vinu2003/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vinu2003/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/vinu2003/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vinu2003/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/vinu2003/juju/languages","stargazers_url":"https://api.github.com/repos/vinu2003/juju/stargazers","contributors_url":"https://api.github.com/repos/vinu2003/juju/contributors","subscribers_url":"https://api.github.com/repos/vinu2003/juju/subscribers","subscription_url":"https://api.github.com/repos/vinu2003/juju/subscription","commits_url":"https://api.github.com/repos/vinu2003/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/vinu2003/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/vinu2003/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/vinu2003/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/vinu2003/juju/contents/{+path}","compare_url":"https://api.github.com/repos/vinu2003/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vinu2003/juju/merges","archive_url":"https://api.github.com/repos/vinu2003/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vinu2003/juju/downloads","issues_url":"https://api.github.com/repos/vinu2003/juju/issues{/number}","pulls_url":"https://api.github.com/repos/vinu2003/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/vinu2003/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/vinu2003/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vinu2003/juju/labels{/name}","releases_url":"https://api.github.com/repos/vinu2003/juju/releases{/id}","deployments_url":"https://api.github.com/repos/vinu2003/juju/deployments","created_at":"2018-04-12T10:15:55Z","updated_at":"2018-07-24T23:10:58Z","pushed_at":"2018-07-27T09:47:00Z","git_url":"git://github.com/vinu2003/juju.git","ssh_url":"git@github.com:vinu2003/juju.git","clone_url":"https://github.com/vinu2003/juju.git","svn_url":"https://github.com/vinu2003/juju","homepage":"juju.ubuntu.com","size":214772,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"juju:2.4","ref":"2.4","sha":"2795dc0b15dcc285d842201bf78a8203a46bb4d3","user":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ0NTk0Nw==","name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2018-07-27T19:19:39Z","pushed_at":"2018-07-28T17:25:15Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":214923,"stargazers_count":1190,"watchers_count":1190,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":273,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":273,"open_issues":15,"watchers":1190,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/8985"},"html":{"href":"https://github.com/juju/juju/pull/8985"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/8985"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/8985/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/8985/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/8985/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/7d0766ee85dc0c590f3fe3d7bf893468cc8b18fc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wallyworld"}}