{"action":"created","comment":{"url":"https://api.github.com/repos/Starcounter/Blending/pulls/comments/182376326","pull_request_review_id":113156850,"id":182376326,"diff_hunk":"@@ -85,13 +85,13 @@ public void Register()\n                     {\n                         var master = SessionHelper.GetMasterPage();\n \n-                        var page = master?.CurrentPage as SettingsPage;\n-\n-                        if (page == null)\n+                        if (!(master?.CurrentPage is SettingsPage))","path":"src/BlendingEditor/Website/Api/MainHandlers.cs","position":7,"original_position":7,"commit_id":"33635c0e0877db69c8327cba3cbe298c68b4b9b9","original_commit_id":"33635c0e0877db69c8327cba3cbe298c68b4b9b9","user":{"login":"PatrykSzwer","id":25042256,"avatar_url":"https://avatars2.githubusercontent.com/u/25042256?v=4","gravatar_id":"","url":"https://api.github.com/users/PatrykSzwer","html_url":"https://github.com/PatrykSzwer","followers_url":"https://api.github.com/users/PatrykSzwer/followers","following_url":"https://api.github.com/users/PatrykSzwer/following{/other_user}","gists_url":"https://api.github.com/users/PatrykSzwer/gists{/gist_id}","starred_url":"https://api.github.com/users/PatrykSzwer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatrykSzwer/subscriptions","organizations_url":"https://api.github.com/users/PatrykSzwer/orgs","repos_url":"https://api.github.com/users/PatrykSzwer/repos","events_url":"https://api.github.com/users/PatrykSzwer/events{/privacy}","received_events_url":"https://api.github.com/users/PatrykSzwer/received_events","type":"User","site_admin":false},"body":"Why did you added these changes here? Was there any case that this could throw an exception or something?","created_at":"2018-04-18T10:10:58Z","updated_at":"2018-04-18T10:15:10Z","html_url":"https://github.com/Starcounter/Blending/pull/176#discussion_r182376326","pull_request_url":"https://api.github.com/repos/Starcounter/Blending/pulls/176","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Starcounter/Blending/pulls/comments/182376326"},"html":{"href":"https://github.com/Starcounter/Blending/pull/176#discussion_r182376326"},"pull_request":{"href":"https://api.github.com/repos/Starcounter/Blending/pulls/176"}}},"pull_request":{"url":"https://api.github.com/repos/Starcounter/Blending/pulls/176","id":182255268,"html_url":"https://github.com/Starcounter/Blending/pull/176","diff_url":"https://github.com/Starcounter/Blending/pull/176.diff","patch_url":"https://github.com/Starcounter/Blending/pull/176.patch","issue_url":"https://api.github.com/repos/Starcounter/Blending/issues/176","number":176,"state":"open","locked":false,"title":"Problem #140: export viewkeeper setting.","user":{"login":"kegor","id":17431807,"avatar_url":"https://avatars2.githubusercontent.com/u/17431807?v=4","gravatar_id":"","url":"https://api.github.com/users/kegor","html_url":"https://github.com/kegor","followers_url":"https://api.github.com/users/kegor/followers","following_url":"https://api.github.com/users/kegor/following{/other_user}","gists_url":"https://api.github.com/users/kegor/gists{/gist_id}","starred_url":"https://api.github.com/users/kegor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kegor/subscriptions","organizations_url":"https://api.github.com/users/kegor/orgs","repos_url":"https://api.github.com/users/kegor/repos","events_url":"https://api.github.com/users/kegor/events{/privacy}","received_events_url":"https://api.github.com/users/kegor/received_events","type":"User","site_admin":false},"body":"**Problem #140:**\r\nSettings is not exporting by the StarDump.\r\n\r\n**Solution**:\r\nWebSettings table was added into StarDump command.\r\n\r\n**Tests:**\r\n⚠️ Manual check is successful if we are talking about importing the dump on the empty DB.\r\nBut if we importing the dump on the same DB with default data using test-case from #140 description then we are getting duplicated rows for each entity in the dump, and for `Settings` as well.\r\nI think this is the question, should we considering this test-case or should we stop on a general use-case with applying the dump only on empty DB.","created_at":"2018-04-17T18:28:27Z","updated_at":"2018-04-18T10:15:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e17d55e705d1e97ebf6464574bb499fed49a4293","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Starcounter/Blending/pulls/176/commits","review_comments_url":"https://api.github.com/repos/Starcounter/Blending/pulls/176/comments","review_comment_url":"https://api.github.com/repos/Starcounter/Blending/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Starcounter/Blending/issues/176/comments","statuses_url":"https://api.github.com/repos/Starcounter/Blending/statuses/33635c0e0877db69c8327cba3cbe298c68b4b9b9","head":{"label":"Starcounter:140-export-viewkeeper-setting","ref":"140-export-viewkeeper-setting","sha":"33635c0e0877db69c8327cba3cbe298c68b4b9b9","user":{"login":"Starcounter","id":1219066,"avatar_url":"https://avatars3.githubusercontent.com/u/1219066?v=4","gravatar_id":"","url":"https://api.github.com/users/Starcounter","html_url":"https://github.com/Starcounter","followers_url":"https://api.github.com/users/Starcounter/followers","following_url":"https://api.github.com/users/Starcounter/following{/other_user}","gists_url":"https://api.github.com/users/Starcounter/gists{/gist_id}","starred_url":"https://api.github.com/users/Starcounter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starcounter/subscriptions","organizations_url":"https://api.github.com/users/Starcounter/orgs","repos_url":"https://api.github.com/users/Starcounter/repos","events_url":"https://api.github.com/users/Starcounter/events{/privacy}","received_events_url":"https://api.github.com/users/Starcounter/received_events","type":"Organization","site_admin":false},"repo":{"id":116174622,"name":"Blending","full_name":"Starcounter/Blending","owner":{"login":"Starcounter","id":1219066,"avatar_url":"https://avatars3.githubusercontent.com/u/1219066?v=4","gravatar_id":"","url":"https://api.github.com/users/Starcounter","html_url":"https://github.com/Starcounter","followers_url":"https://api.github.com/users/Starcounter/followers","following_url":"https://api.github.com/users/Starcounter/following{/other_user}","gists_url":"https://api.github.com/users/Starcounter/gists{/gist_id}","starred_url":"https://api.github.com/users/Starcounter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starcounter/subscriptions","organizations_url":"https://api.github.com/users/Starcounter/orgs","repos_url":"https://api.github.com/users/Starcounter/repos","events_url":"https://api.github.com/users/Starcounter/events{/privacy}","received_events_url":"https://api.github.com/users/Starcounter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Starcounter/Blending","description":"New suite of apps that enables blending in Starcounter 2.4","fork":false,"url":"https://api.github.com/repos/Starcounter/Blending","forks_url":"https://api.github.com/repos/Starcounter/Blending/forks","keys_url":"https://api.github.com/repos/Starcounter/Blending/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Starcounter/Blending/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Starcounter/Blending/teams","hooks_url":"https://api.github.com/repos/Starcounter/Blending/hooks","issue_events_url":"https://api.github.com/repos/Starcounter/Blending/issues/events{/number}","events_url":"https://api.github.com/repos/Starcounter/Blending/events","assignees_url":"https://api.github.com/repos/Starcounter/Blending/assignees{/user}","branches_url":"https://api.github.com/repos/Starcounter/Blending/branches{/branch}","tags_url":"https://api.github.com/repos/Starcounter/Blending/tags","blobs_url":"https://api.github.com/repos/Starcounter/Blending/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Starcounter/Blending/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Starcounter/Blending/git/refs{/sha}","trees_url":"https://api.github.com/repos/Starcounter/Blending/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Starcounter/Blending/statuses/{sha}","languages_url":"https://api.github.com/repos/Starcounter/Blending/languages","stargazers_url":"https://api.github.com/repos/Starcounter/Blending/stargazers","contributors_url":"https://api.github.com/repos/Starcounter/Blending/contributors","subscribers_url":"https://api.github.com/repos/Starcounter/Blending/subscribers","subscription_url":"https://api.github.com/repos/Starcounter/Blending/subscription","commits_url":"https://api.github.com/repos/Starcounter/Blending/commits{/sha}","git_commits_url":"https://api.github.com/repos/Starcounter/Blending/git/commits{/sha}","comments_url":"https://api.github.com/repos/Starcounter/Blending/comments{/number}","issue_comment_url":"https://api.github.com/repos/Starcounter/Blending/issues/comments{/number}","contents_url":"https://api.github.com/repos/Starcounter/Blending/contents/{+path}","compare_url":"https://api.github.com/repos/Starcounter/Blending/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Starcounter/Blending/merges","archive_url":"https://api.github.com/repos/Starcounter/Blending/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Starcounter/Blending/downloads","issues_url":"https://api.github.com/repos/Starcounter/Blending/issues{/number}","pulls_url":"https://api.github.com/repos/Starcounter/Blending/pulls{/number}","milestones_url":"https://api.github.com/repos/Starcounter/Blending/milestones{/number}","notifications_url":"https://api.github.com/repos/Starcounter/Blending/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Starcounter/Blending/labels{/name}","releases_url":"https://api.github.com/repos/Starcounter/Blending/releases{/id}","deployments_url":"https://api.github.com/repos/Starcounter/Blending/deployments","created_at":"2018-01-03T19:37:59Z","updated_at":"2018-04-17T14:18:39Z","pushed_at":"2018-04-17T18:28:29Z","git_url":"git://github.com/Starcounter/Blending.git","ssh_url":"git@github.com:Starcounter/Blending.git","clone_url":"https://github.com/Starcounter/Blending.git","svn_url":"https://github.com/Starcounter/Blending","homepage":null,"size":13773,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":35,"watchers":0,"default_branch":"master"}},"base":{"label":"Starcounter:master","ref":"master","sha":"7632a9e70c691ba8661b86f322762c01f0652b4e","user":{"login":"Starcounter","id":1219066,"avatar_url":"https://avatars3.githubusercontent.com/u/1219066?v=4","gravatar_id":"","url":"https://api.github.com/users/Starcounter","html_url":"https://github.com/Starcounter","followers_url":"https://api.github.com/users/Starcounter/followers","following_url":"https://api.github.com/users/Starcounter/following{/other_user}","gists_url":"https://api.github.com/users/Starcounter/gists{/gist_id}","starred_url":"https://api.github.com/users/Starcounter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starcounter/subscriptions","organizations_url":"https://api.github.com/users/Starcounter/orgs","repos_url":"https://api.github.com/users/Starcounter/repos","events_url":"https://api.github.com/users/Starcounter/events{/privacy}","received_events_url":"https://api.github.com/users/Starcounter/received_events","type":"Organization","site_admin":false},"repo":{"id":116174622,"name":"Blending","full_name":"Starcounter/Blending","owner":{"login":"Starcounter","id":1219066,"avatar_url":"https://avatars3.githubusercontent.com/u/1219066?v=4","gravatar_id":"","url":"https://api.github.com/users/Starcounter","html_url":"https://github.com/Starcounter","followers_url":"https://api.github.com/users/Starcounter/followers","following_url":"https://api.github.com/users/Starcounter/following{/other_user}","gists_url":"https://api.github.com/users/Starcounter/gists{/gist_id}","starred_url":"https://api.github.com/users/Starcounter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starcounter/subscriptions","organizations_url":"https://api.github.com/users/Starcounter/orgs","repos_url":"https://api.github.com/users/Starcounter/repos","events_url":"https://api.github.com/users/Starcounter/events{/privacy}","received_events_url":"https://api.github.com/users/Starcounter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Starcounter/Blending","description":"New suite of apps that enables blending in Starcounter 2.4","fork":false,"url":"https://api.github.com/repos/Starcounter/Blending","forks_url":"https://api.github.com/repos/Starcounter/Blending/forks","keys_url":"https://api.github.com/repos/Starcounter/Blending/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Starcounter/Blending/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Starcounter/Blending/teams","hooks_url":"https://api.github.com/repos/Starcounter/Blending/hooks","issue_events_url":"https://api.github.com/repos/Starcounter/Blending/issues/events{/number}","events_url":"https://api.github.com/repos/Starcounter/Blending/events","assignees_url":"https://api.github.com/repos/Starcounter/Blending/assignees{/user}","branches_url":"https://api.github.com/repos/Starcounter/Blending/branches{/branch}","tags_url":"https://api.github.com/repos/Starcounter/Blending/tags","blobs_url":"https://api.github.com/repos/Starcounter/Blending/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Starcounter/Blending/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Starcounter/Blending/git/refs{/sha}","trees_url":"https://api.github.com/repos/Starcounter/Blending/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Starcounter/Blending/statuses/{sha}","languages_url":"https://api.github.com/repos/Starcounter/Blending/languages","stargazers_url":"https://api.github.com/repos/Starcounter/Blending/stargazers","contributors_url":"https://api.github.com/repos/Starcounter/Blending/contributors","subscribers_url":"https://api.github.com/repos/Starcounter/Blending/subscribers","subscription_url":"https://api.github.com/repos/Starcounter/Blending/subscription","commits_url":"https://api.github.com/repos/Starcounter/Blending/commits{/sha}","git_commits_url":"https://api.github.com/repos/Starcounter/Blending/git/commits{/sha}","comments_url":"https://api.github.com/repos/Starcounter/Blending/comments{/number}","issue_comment_url":"https://api.github.com/repos/Starcounter/Blending/issues/comments{/number}","contents_url":"https://api.github.com/repos/Starcounter/Blending/contents/{+path}","compare_url":"https://api.github.com/repos/Starcounter/Blending/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Starcounter/Blending/merges","archive_url":"https://api.github.com/repos/Starcounter/Blending/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Starcounter/Blending/downloads","issues_url":"https://api.github.com/repos/Starcounter/Blending/issues{/number}","pulls_url":"https://api.github.com/repos/Starcounter/Blending/pulls{/number}","milestones_url":"https://api.github.com/repos/Starcounter/Blending/milestones{/number}","notifications_url":"https://api.github.com/repos/Starcounter/Blending/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Starcounter/Blending/labels{/name}","releases_url":"https://api.github.com/repos/Starcounter/Blending/releases{/id}","deployments_url":"https://api.github.com/repos/Starcounter/Blending/deployments","created_at":"2018-01-03T19:37:59Z","updated_at":"2018-04-17T14:18:39Z","pushed_at":"2018-04-17T18:28:29Z","git_url":"git://github.com/Starcounter/Blending.git","ssh_url":"git@github.com:Starcounter/Blending.git","clone_url":"https://github.com/Starcounter/Blending.git","svn_url":"https://github.com/Starcounter/Blending","homepage":null,"size":13773,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":35,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Starcounter/Blending/pulls/176"},"html":{"href":"https://github.com/Starcounter/Blending/pull/176"},"issue":{"href":"https://api.github.com/repos/Starcounter/Blending/issues/176"},"comments":{"href":"https://api.github.com/repos/Starcounter/Blending/issues/176/comments"},"review_comments":{"href":"https://api.github.com/repos/Starcounter/Blending/pulls/176/comments"},"review_comment":{"href":"https://api.github.com/repos/Starcounter/Blending/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Starcounter/Blending/pulls/176/commits"},"statuses":{"href":"https://api.github.com/repos/Starcounter/Blending/statuses/33635c0e0877db69c8327cba3cbe298c68b4b9b9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"PatrykSzwer"}}