{"action":"created","issue":{"url":"https://api.github.com/repos/learningequality/kolibri/issues/4318","repository_url":"https://api.github.com/repos/learningequality/kolibri","labels_url":"https://api.github.com/repos/learningequality/kolibri/issues/4318/labels{/name}","comments_url":"https://api.github.com/repos/learningequality/kolibri/issues/4318/comments","events_url":"https://api.github.com/repos/learningequality/kolibri/issues/4318/events","html_url":"https://github.com/learningequality/kolibri/pull/4318","id":363357802,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3ODE3NDE1","number":4318,"title":"correct url reversal for csv endpoints","user":{"login":"ralphiee22","id":6361732,"node_id":"MDQ6VXNlcjYzNjE3MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/6361732?v=4","gravatar_id":"","url":"https://api.github.com/users/ralphiee22","html_url":"https://github.com/ralphiee22","followers_url":"https://api.github.com/users/ralphiee22/followers","following_url":"https://api.github.com/users/ralphiee22/following{/other_user}","gists_url":"https://api.github.com/users/ralphiee22/gists{/gist_id}","starred_url":"https://api.github.com/users/ralphiee22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralphiee22/subscriptions","organizations_url":"https://api.github.com/users/ralphiee22/orgs","repos_url":"https://api.github.com/users/ralphiee22/repos","events_url":"https://api.github.com/users/ralphiee22/events{/privacy}","received_events_url":"https://api.github.com/users/ralphiee22/received_events","type":"User","site_admin":false},"labels":[{"id":410338552,"node_id":"MDU6TGFiZWw0MTAzMzg1NTI=","url":"https://api.github.com/repos/learningequality/kolibri/labels/PR:%20needs%20review","name":"PR: needs review","color":"1f6ad6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/learningequality/kolibri/milestones/22","html_url":"https://github.com/learningequality/kolibri/milestone/22","labels_url":"https://api.github.com/repos/learningequality/kolibri/milestones/22/labels","id":3254318,"node_id":"MDk6TWlsZXN0b25lMzI1NDMxOA==","number":22,"title":"0.11.0","description":"","creator":{"login":"indirectlylit","id":2367265,"node_id":"MDQ6VXNlcjIzNjcyNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/2367265?v=4","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":127,"state":"open","created_at":"2018-04-09T23:34:55Z","updated_at":"2018-09-24T23:34:43Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-09-24T23:34:43Z","updated_at":"2018-09-25T00:00:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/4318","html_url":"https://github.com/learningequality/kolibri/pull/4318","diff_url":"https://github.com/learningequality/kolibri/pull/4318.diff","patch_url":"https://github.com/learningequality/kolibri/pull/4318.patch"},"body":"<!--\r\n 1. Following guidance below, replace …'s with your own words\r\n 2. After saving the PR, tick of completed checklist items\r\n 3. Skip checklist items that are not applicable or not necessary\r\n 4. Delete instruction/comment blocks\r\n-->\r\n\r\n### Summary\r\n<!--\r\n * description of the change\r\n * manual verification steps performed\r\n * screenshots if the PR affects the UI\r\n-->\r\n\r\nFix the url reversals for csv endpoints, after core refactor.\r\n\r\n### Reviewer guidance\r\n<!--\r\n * how can a reviewer test these changes?\r\n * are there any risky areas that deserve extra testing\r\n-->\r\n\r\nOn the data page under facility management, can you download logs? \r\nbefore change? after change?\r\n\r\n----\r\n\r\n### Contributor Checklist\r\n\r\n- [x] Contributor has fully tested the PR manually\r\n- [x] PR has the correct target branch and milestone\r\n- [x] PR has 'needs review' or 'work-in-progress' label\r\n- [x] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')\r\n- [ ] If there are any front-end changes, before/after screenshots are included\r\n- [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label\r\n\r\n### Reviewer Checklist\r\n\r\n- [ ] Automated test coverage is satisfactory\r\n- [ ] Reviewer has fully tested the PR manually\r\n- [ ] PR has been tested for [accessibility regressions](http://kolibri-dev.readthedocs.io/en/develop/manual_testing.html#accessibility-a11y-testing)\r\n- [ ] External dependencies files were updated (`yarn` and `pip`)\r\n- [ ] Documentation is updated\r\n- [ ] Link to diff of internal dependency change is included\r\n- [ ] CHANGELOG.rst is updated for high-level changes\r\n- [ ] Contributor is in AUTHORS.rst\r\n"},"comment":{"url":"https://api.github.com/repos/learningequality/kolibri/issues/comments/424163758","html_url":"https://github.com/learningequality/kolibri/pull/4318#issuecomment-424163758","issue_url":"https://api.github.com/repos/learningequality/kolibri/issues/4318","id":424163758,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDE2Mzc1OA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/marketplace/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-09-25T00:00:39Z","updated_at":"2018-09-25T00:00:39Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/learningequality/kolibri/pull/4318?src=pr&el=h1) Report\n> Merging [#4318](https://codecov.io/gh/learningequality/kolibri/pull/4318?src=pr&el=desc) into [develop](https://codecov.io/gh/learningequality/kolibri/commit/2ae89b7998e9a4a0479254a9c306fdd40de8fe01?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `0%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/learningequality/kolibri/pull/4318/graphs/tree.svg?width=650&token=l3yT7YuBEg&height=150&src=pr)](https://codecov.io/gh/learningequality/kolibri/pull/4318?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff            @@\n##           develop    #4318   +/-   ##\n========================================\n  Coverage    52.92%   52.92%           \n========================================\n  Files          718      718           \n  Lines        22813    22813           \n  Branches      3096     3096           \n========================================\n  Hits         12073    12073           \n  Misses       10017    10017           \n  Partials       723      723\n```\n\n\n| [Impacted Files](https://codecov.io/gh/learningequality/kolibri/pull/4318?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [.../facility\\_management/assets/src/views/DataPage.vue](https://codecov.io/gh/learningequality/kolibri/pull/4318/diff?src=pr&el=tree#diff-a29saWJyaS9wbHVnaW5zL2ZhY2lsaXR5X21hbmFnZW1lbnQvYXNzZXRzL3NyYy92aWV3cy9EYXRhUGFnZS52dWU=) | `0% <0%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/learningequality/kolibri/pull/4318?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/learningequality/kolibri/pull/4318?src=pr&el=footer). Last update [2ae89b7...1273a28](https://codecov.io/gh/learningequality/kolibri/pull/4318?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}