{"action":"created","comment":{"url":"https://api.github.com/repos/ros-visualization/qt_gui_core/pulls/comments/229824783","pull_request_review_id":170417352,"id":229824783,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTgyNDc4Mw==","diff_hunk":"@@ -2,14 +2,15 @@ cmake_minimum_required(VERSION 3.5)\n project(qt_gui_cpp)\n \n find_package(ament_cmake REQUIRED)\n+find_package(ament_cmake_python REQUIRED)\n+#find_package(Boost REQUIRED COMPONENTS filesystem system)","path":"qt_gui_cpp/CMakeLists.txt","position":5,"original_position":5,"commit_id":"a01c3ef5e01e0bf527b30dcb9b1d5f3734add00d","original_commit_id":"a01c3ef5e01e0bf527b30dcb9b1d5f3734add00d","user":{"login":"brawner","id":1044986,"node_id":"MDQ6VXNlcjEwNDQ5ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/1044986?v=4","gravatar_id":"","url":"https://api.github.com/users/brawner","html_url":"https://github.com/brawner","followers_url":"https://api.github.com/users/brawner/followers","following_url":"https://api.github.com/users/brawner/following{/other_user}","gists_url":"https://api.github.com/users/brawner/gists{/gist_id}","starred_url":"https://api.github.com/users/brawner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brawner/subscriptions","organizations_url":"https://api.github.com/users/brawner/orgs","repos_url":"https://api.github.com/users/brawner/repos","events_url":"https://api.github.com/users/brawner/events{/privacy}","received_events_url":"https://api.github.com/users/brawner/received_events","type":"User","site_admin":false},"body":"This should be deleted","created_at":"2018-10-31T18:50:02Z","updated_at":"2018-10-31T18:50:14Z","html_url":"https://github.com/ros-visualization/qt_gui_core/pull/133#discussion_r229824783","pull_request_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/pulls/133","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ros-visualization/qt_gui_core/pulls/comments/229824783"},"html":{"href":"https://github.com/ros-visualization/qt_gui_core/pull/133#discussion_r229824783"},"pull_request":{"href":"https://api.github.com/repos/ros-visualization/qt_gui_core/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/ros-visualization/qt_gui_core/pulls/133","id":226754147,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NzU0MTQ3","html_url":"https://github.com/ros-visualization/qt_gui_core/pull/133","diff_url":"https://github.com/ros-visualization/qt_gui_core/pull/133.diff","patch_url":"https://github.com/ros-visualization/qt_gui_core/pull/133.patch","issue_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/issues/133","number":133,"state":"open","locked":false,"title":"Ros2 port w tests","user":{"login":"brawner","id":1044986,"node_id":"MDQ6VXNlcjEwNDQ5ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/1044986?v=4","gravatar_id":"","url":"https://api.github.com/users/brawner","html_url":"https://github.com/brawner","followers_url":"https://api.github.com/users/brawner/followers","following_url":"https://api.github.com/users/brawner/following{/other_user}","gists_url":"https://api.github.com/users/brawner/gists{/gist_id}","starred_url":"https://api.github.com/users/brawner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brawner/subscriptions","organizations_url":"https://api.github.com/users/brawner/orgs","repos_url":"https://api.github.com/users/brawner/repos","events_url":"https://api.github.com/users/brawner/events{/privacy}","received_events_url":"https://api.github.com/users/brawner/received_events","type":"User","site_admin":false},"body":"This adds style tests and updates the existing qt_dotgraph tests to pass. It does rely on python_qt_binding pull request (https://github.com/ros-visualization/python_qt_binding/pull/53)","created_at":"2018-10-30T00:17:03Z","updated_at":"2018-10-31T18:50:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"471dda5f35b20dd0574aef086e1f82d347d9531b","assignee":{"login":"brawner","id":1044986,"node_id":"MDQ6VXNlcjEwNDQ5ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/1044986?v=4","gravatar_id":"","url":"https://api.github.com/users/brawner","html_url":"https://github.com/brawner","followers_url":"https://api.github.com/users/brawner/followers","following_url":"https://api.github.com/users/brawner/following{/other_user}","gists_url":"https://api.github.com/users/brawner/gists{/gist_id}","starred_url":"https://api.github.com/users/brawner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brawner/subscriptions","organizations_url":"https://api.github.com/users/brawner/orgs","repos_url":"https://api.github.com/users/brawner/repos","events_url":"https://api.github.com/users/brawner/events{/privacy}","received_events_url":"https://api.github.com/users/brawner/received_events","type":"User","site_admin":false},"assignees":[{"login":"brawner","id":1044986,"node_id":"MDQ6VXNlcjEwNDQ5ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/1044986?v=4","gravatar_id":"","url":"https://api.github.com/users/brawner","html_url":"https://github.com/brawner","followers_url":"https://api.github.com/users/brawner/followers","following_url":"https://api.github.com/users/brawner/following{/other_user}","gists_url":"https://api.github.com/users/brawner/gists{/gist_id}","starred_url":"https://api.github.com/users/brawner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brawner/subscriptions","organizations_url":"https://api.github.com/users/brawner/orgs","repos_url":"https://api.github.com/users/brawner/repos","events_url":"https://api.github.com/users/brawner/events{/privacy}","received_events_url":"https://api.github.com/users/brawner/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dirk-thomas","id":1335366,"node_id":"MDQ6VXNlcjEzMzUzNjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1335366?v=4","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},{"login":"mlautman","id":3253549,"node_id":"MDQ6VXNlcjMyNTM1NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/3253549?v=4","gravatar_id":"","url":"https://api.github.com/users/mlautman","html_url":"https://github.com/mlautman","followers_url":"https://api.github.com/users/mlautman/followers","following_url":"https://api.github.com/users/mlautman/following{/other_user}","gists_url":"https://api.github.com/users/mlautman/gists{/gist_id}","starred_url":"https://api.github.com/users/mlautman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlautman/subscriptions","organizations_url":"https://api.github.com/users/mlautman/orgs","repos_url":"https://api.github.com/users/mlautman/repos","events_url":"https://api.github.com/users/mlautman/events{/privacy}","received_events_url":"https://api.github.com/users/mlautman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":875285448,"node_id":"MDU6TGFiZWw4NzUyODU0NDg=","url":"https://api.github.com/repos/ros-visualization/qt_gui_core/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/pulls/133/commits","review_comments_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/pulls/133/comments","review_comment_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/issues/133/comments","statuses_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/statuses/a01c3ef5e01e0bf527b30dcb9b1d5f3734add00d","head":{"label":"ros-visualization:ros2_port_w_tests","ref":"ros2_port_w_tests","sha":"a01c3ef5e01e0bf527b30dcb9b1d5f3734add00d","user":{"login":"ros-visualization","id":2328629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjg2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/2328629?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-visualization","html_url":"https://github.com/ros-visualization","followers_url":"https://api.github.com/users/ros-visualization/followers","following_url":"https://api.github.com/users/ros-visualization/following{/other_user}","gists_url":"https://api.github.com/users/ros-visualization/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-visualization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-visualization/subscriptions","organizations_url":"https://api.github.com/users/ros-visualization/orgs","repos_url":"https://api.github.com/users/ros-visualization/repos","events_url":"https://api.github.com/users/ros-visualization/events{/privacy}","received_events_url":"https://api.github.com/users/ros-visualization/received_events","type":"Organization","site_admin":false},"repo":{"id":5864709,"node_id":"MDEwOlJlcG9zaXRvcnk1ODY0NzA5","name":"qt_gui_core","full_name":"ros-visualization/qt_gui_core","private":false,"owner":{"login":"ros-visualization","id":2328629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjg2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/2328629?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-visualization","html_url":"https://github.com/ros-visualization","followers_url":"https://api.github.com/users/ros-visualization/followers","following_url":"https://api.github.com/users/ros-visualization/following{/other_user}","gists_url":"https://api.github.com/users/ros-visualization/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-visualization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-visualization/subscriptions","organizations_url":"https://api.github.com/users/ros-visualization/orgs","repos_url":"https://api.github.com/users/ros-visualization/repos","events_url":"https://api.github.com/users/ros-visualization/events{/privacy}","received_events_url":"https://api.github.com/users/ros-visualization/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ros-visualization/qt_gui_core","description":null,"fork":false,"url":"https://api.github.com/repos/ros-visualization/qt_gui_core","forks_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/forks","keys_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/teams","hooks_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/hooks","issue_events_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/issues/events{/number}","events_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/events","assignees_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/assignees{/user}","branches_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/branches{/branch}","tags_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/tags","blobs_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/languages","stargazers_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/stargazers","contributors_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/contributors","subscribers_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/subscribers","subscription_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/subscription","commits_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/contents/{+path}","compare_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/merges","archive_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/downloads","issues_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/issues{/number}","pulls_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/labels{/name}","releases_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/releases{/id}","deployments_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/deployments","created_at":"2012-09-19T00:01:42Z","updated_at":"2018-10-23T16:27:26Z","pushed_at":"2018-10-31T06:38:26Z","git_url":"git://github.com/ros-visualization/qt_gui_core.git","ssh_url":"git@github.com:ros-visualization/qt_gui_core.git","clone_url":"https://github.com/ros-visualization/qt_gui_core.git","svn_url":"https://github.com/ros-visualization/qt_gui_core","homepage":null,"size":2268,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":43,"open_issues":13,"watchers":14,"default_branch":"kinetic-devel"}},"base":{"label":"ros-visualization:ros2_port_minimal","ref":"ros2_port_minimal","sha":"62e5b6730b7c754b2b972d76953e5a7d6b873038","user":{"login":"ros-visualization","id":2328629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjg2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/2328629?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-visualization","html_url":"https://github.com/ros-visualization","followers_url":"https://api.github.com/users/ros-visualization/followers","following_url":"https://api.github.com/users/ros-visualization/following{/other_user}","gists_url":"https://api.github.com/users/ros-visualization/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-visualization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-visualization/subscriptions","organizations_url":"https://api.github.com/users/ros-visualization/orgs","repos_url":"https://api.github.com/users/ros-visualization/repos","events_url":"https://api.github.com/users/ros-visualization/events{/privacy}","received_events_url":"https://api.github.com/users/ros-visualization/received_events","type":"Organization","site_admin":false},"repo":{"id":5864709,"node_id":"MDEwOlJlcG9zaXRvcnk1ODY0NzA5","name":"qt_gui_core","full_name":"ros-visualization/qt_gui_core","private":false,"owner":{"login":"ros-visualization","id":2328629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjg2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/2328629?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-visualization","html_url":"https://github.com/ros-visualization","followers_url":"https://api.github.com/users/ros-visualization/followers","following_url":"https://api.github.com/users/ros-visualization/following{/other_user}","gists_url":"https://api.github.com/users/ros-visualization/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-visualization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-visualization/subscriptions","organizations_url":"https://api.github.com/users/ros-visualization/orgs","repos_url":"https://api.github.com/users/ros-visualization/repos","events_url":"https://api.github.com/users/ros-visualization/events{/privacy}","received_events_url":"https://api.github.com/users/ros-visualization/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ros-visualization/qt_gui_core","description":null,"fork":false,"url":"https://api.github.com/repos/ros-visualization/qt_gui_core","forks_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/forks","keys_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/teams","hooks_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/hooks","issue_events_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/issues/events{/number}","events_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/events","assignees_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/assignees{/user}","branches_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/branches{/branch}","tags_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/tags","blobs_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/languages","stargazers_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/stargazers","contributors_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/contributors","subscribers_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/subscribers","subscription_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/subscription","commits_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/contents/{+path}","compare_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/merges","archive_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/downloads","issues_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/issues{/number}","pulls_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/labels{/name}","releases_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/releases{/id}","deployments_url":"https://api.github.com/repos/ros-visualization/qt_gui_core/deployments","created_at":"2012-09-19T00:01:42Z","updated_at":"2018-10-23T16:27:26Z","pushed_at":"2018-10-31T06:38:26Z","git_url":"git://github.com/ros-visualization/qt_gui_core.git","ssh_url":"git@github.com:ros-visualization/qt_gui_core.git","clone_url":"https://github.com/ros-visualization/qt_gui_core.git","svn_url":"https://github.com/ros-visualization/qt_gui_core","homepage":null,"size":2268,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":43,"open_issues":13,"watchers":14,"default_branch":"kinetic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-visualization/qt_gui_core/pulls/133"},"html":{"href":"https://github.com/ros-visualization/qt_gui_core/pull/133"},"issue":{"href":"https://api.github.com/repos/ros-visualization/qt_gui_core/issues/133"},"comments":{"href":"https://api.github.com/repos/ros-visualization/qt_gui_core/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-visualization/qt_gui_core/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-visualization/qt_gui_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-visualization/qt_gui_core/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/ros-visualization/qt_gui_core/statuses/a01c3ef5e01e0bf527b30dcb9b1d5f3734add00d"}},"author_association":"NONE"}}
{"actor":{"display_login":"brawner"}}