{"action":"created","issue":{"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/2104","repository_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor","labels_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/2104/labels{/name}","comments_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/2104/comments","events_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/2104/events","html_url":"https://github.com/projectacrn/acrn-hypervisor/pull/2104","id":392394480,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5Njc3OTQ2","number":2104,"title":"[v3]Patch for modularising ioapic.[c/h] and related files.","user":{"login":"rarindam","id":29132611,"node_id":"MDQ6VXNlcjI5MTMyNjEx","avatar_url":"https://avatars3.githubusercontent.com/u/29132611?v=4","gravatar_id":"","url":"https://api.github.com/users/rarindam","html_url":"https://github.com/rarindam","followers_url":"https://api.github.com/users/rarindam/followers","following_url":"https://api.github.com/users/rarindam/following{/other_user}","gists_url":"https://api.github.com/users/rarindam/gists{/gist_id}","starred_url":"https://api.github.com/users/rarindam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rarindam/subscriptions","organizations_url":"https://api.github.com/users/rarindam/orgs","repos_url":"https://api.github.com/users/rarindam/repos","events_url":"https://api.github.com/users/rarindam/events{/privacy}","received_events_url":"https://api.github.com/users/rarindam/received_events","type":"User","site_admin":false},"labels":[{"id":1145223102,"node_id":"MDU6TGFiZWwxMTQ1MjIzMTAy","url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/labels/CI:%20Tracked%20On%20Pass","name":"CI: Tracked On Pass","color":"bae26a","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-19T00:40:45Z","updated_at":"2018-12-19T02:18:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/pulls/2104","html_url":"https://github.com/projectacrn/acrn-hypervisor/pull/2104","diff_url":"https://github.com/projectacrn/acrn-hypervisor/pull/2104.diff","patch_url":"https://github.com/projectacrn/acrn-hypervisor/pull/2104.patch"},"body":"This adds few functions to access the daata structures\r\ndefined inside ioapic.c. Removes the same data structures\r\nfrom ioapic.h\r\nAlso this modifies some of the names of existing APIs to\r\nconform to the ioapic module name.\r\nMade some changes to conform to MISRA C standards.\r\n\r\nTracked-On: #1842\r\nSigned-off-by: Arindam Roy <arindam.roy@intel.com>"},"comment":{"url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/comments/448445182","html_url":"https://github.com/projectacrn/acrn-hypervisor/pull/2104#issuecomment-448445182","issue_url":"https://api.github.com/repos/projectacrn/acrn-hypervisor/issues/2104","id":448445182,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODQ0NTE4Mg==","user":{"login":"shiqingg","id":25377381,"node_id":"MDQ6VXNlcjI1Mzc3Mzgx","avatar_url":"https://avatars2.githubusercontent.com/u/25377381?v=4","gravatar_id":"","url":"https://api.github.com/users/shiqingg","html_url":"https://github.com/shiqingg","followers_url":"https://api.github.com/users/shiqingg/followers","following_url":"https://api.github.com/users/shiqingg/following{/other_user}","gists_url":"https://api.github.com/users/shiqingg/gists{/gist_id}","starred_url":"https://api.github.com/users/shiqingg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiqingg/subscriptions","organizations_url":"https://api.github.com/users/shiqingg/orgs","repos_url":"https://api.github.com/users/shiqingg/repos","events_url":"https://api.github.com/users/shiqingg/events{/privacy}","received_events_url":"https://api.github.com/users/shiqingg/received_events","type":"User","site_admin":false},"created_at":"2018-12-19T02:18:55Z","updated_at":"2018-12-19T02:18:55Z","author_association":"CONTRIBUTOR","body":"> Violation 1: The definition was already there. I can resubmit the parch but would need changing all the places the array is bring used. Arindam On Dec 18, 2018, at 6:08 PM, Shiqing Gao <notifications@github.com<mailto:notifications@github.com>> wrote: violation 2, 3, 4, 5, 6, 7 could be ignored. violation 1 needs to be fixed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<[#2104 (comment)](https://github.com/projectacrn/acrn-hypervisor/pull/2104#issuecomment-448443343)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AbyHQ0wpI-i7ihUbrwt6O0cGnssEn5BHks5u6Z-QgaJpZM4ZZVXr>.\r\n\r\nSure. A separate patch to fix this violation in the same PR is working fine."}}
{"actor":{"display_login":"shiqingg"}}