{"action":"opened","number":25,"pull_request":{"url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/25","id":187255687,"html_url":"https://github.com/lsst/sims_coordUtils/pull/25","diff_url":"https://github.com/lsst/sims_coordUtils/pull/25.diff","patch_url":"https://github.com/lsst/sims_coordUtils/pull/25.patch","issue_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/25","number":25,"state":"open","locked":false,"title":"U/danielsf/outside/radius","user":{"login":"danielsf","id":1682854,"avatar_url":"https://avatars1.githubusercontent.com/u/1682854?v=4","gravatar_id":"","url":"https://api.github.com/users/danielsf","html_url":"https://github.com/danielsf","followers_url":"https://api.github.com/users/danielsf/followers","following_url":"https://api.github.com/users/danielsf/following{/other_user}","gists_url":"https://api.github.com/users/danielsf/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsf/subscriptions","organizations_url":"https://api.github.com/users/danielsf/orgs","repos_url":"https://api.github.com/users/danielsf/repos","events_url":"https://api.github.com/users/danielsf/events{/privacy}","received_events_url":"https://api.github.com/users/danielsf/received_events","type":"User","site_admin":false},"body":"In responding to the PR for `u/danielsf/fix/focal/plane`, I set up a system where, if you asked for the focal plane coordinates of something well outside of the LSST focal plane, you got a `ZernikeRadialError`.  This would have caused a problem for us in image simulation, where we routinely ask for catalogs that are larger than the focal plane and let the image simulator figure out which objects are in and out of the focal plane.\r\n\r\nThis PR changes the behavior of `ZernikePolynomialGenerator` so that it will return `np.NaN` for any point that is outside of the LSST focal plane.  The routines in sims_coordUtils that find pixel positions and chip names will no how to deal with this.","created_at":"2018-05-10T17:31:10Z","updated_at":"2018-05-10T17:31:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/25/commits","review_comments_url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/25/comments","review_comment_url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/25/comments","statuses_url":"https://api.github.com/repos/lsst/sims_coordUtils/statuses/5998cf00e439dcc6b0bb927c0d4e7ca2b2cdd5de","head":{"label":"lsst:u/danielsf/outside/radius","ref":"u/danielsf/outside/radius","sha":"5998cf00e439dcc6b0bb927c0d4e7ca2b2cdd5de","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":34668295,"name":"sims_coordUtils","full_name":"lsst/sims_coordUtils","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/sims_coordUtils","description":"LSST Simulations package for coordinate utility functions","fork":false,"url":"https://api.github.com/repos/lsst/sims_coordUtils","forks_url":"https://api.github.com/repos/lsst/sims_coordUtils/forks","keys_url":"https://api.github.com/repos/lsst/sims_coordUtils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/sims_coordUtils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/sims_coordUtils/teams","hooks_url":"https://api.github.com/repos/lsst/sims_coordUtils/hooks","issue_events_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/sims_coordUtils/events","assignees_url":"https://api.github.com/repos/lsst/sims_coordUtils/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/sims_coordUtils/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/sims_coordUtils/tags","blobs_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/sims_coordUtils/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/sims_coordUtils/languages","stargazers_url":"https://api.github.com/repos/lsst/sims_coordUtils/stargazers","contributors_url":"https://api.github.com/repos/lsst/sims_coordUtils/contributors","subscribers_url":"https://api.github.com/repos/lsst/sims_coordUtils/subscribers","subscription_url":"https://api.github.com/repos/lsst/sims_coordUtils/subscription","commits_url":"https://api.github.com/repos/lsst/sims_coordUtils/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/sims_coordUtils/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/sims_coordUtils/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/sims_coordUtils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/sims_coordUtils/merges","archive_url":"https://api.github.com/repos/lsst/sims_coordUtils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/sims_coordUtils/downloads","issues_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/sims_coordUtils/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/sims_coordUtils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/sims_coordUtils/labels{/name}","releases_url":"https://api.github.com/repos/lsst/sims_coordUtils/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/sims_coordUtils/deployments","created_at":"2015-04-27T13:28:33Z","updated_at":"2018-05-08T22:50:36Z","pushed_at":"2018-05-10T17:28:11Z","git_url":"git://github.com/lsst/sims_coordUtils.git","ssh_url":"git@github.com:lsst/sims_coordUtils.git","clone_url":"https://github.com/lsst/sims_coordUtils.git","svn_url":"https://github.com/lsst/sims_coordUtils","homepage":null,"size":946,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"bc1a2fe5cc35248912b2d4c790a57b52923d6a64","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":34668295,"name":"sims_coordUtils","full_name":"lsst/sims_coordUtils","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/sims_coordUtils","description":"LSST Simulations package for coordinate utility functions","fork":false,"url":"https://api.github.com/repos/lsst/sims_coordUtils","forks_url":"https://api.github.com/repos/lsst/sims_coordUtils/forks","keys_url":"https://api.github.com/repos/lsst/sims_coordUtils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/sims_coordUtils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/sims_coordUtils/teams","hooks_url":"https://api.github.com/repos/lsst/sims_coordUtils/hooks","issue_events_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/sims_coordUtils/events","assignees_url":"https://api.github.com/repos/lsst/sims_coordUtils/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/sims_coordUtils/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/sims_coordUtils/tags","blobs_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/sims_coordUtils/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/sims_coordUtils/languages","stargazers_url":"https://api.github.com/repos/lsst/sims_coordUtils/stargazers","contributors_url":"https://api.github.com/repos/lsst/sims_coordUtils/contributors","subscribers_url":"https://api.github.com/repos/lsst/sims_coordUtils/subscribers","subscription_url":"https://api.github.com/repos/lsst/sims_coordUtils/subscription","commits_url":"https://api.github.com/repos/lsst/sims_coordUtils/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/sims_coordUtils/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/sims_coordUtils/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/sims_coordUtils/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/sims_coordUtils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/sims_coordUtils/merges","archive_url":"https://api.github.com/repos/lsst/sims_coordUtils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/sims_coordUtils/downloads","issues_url":"https://api.github.com/repos/lsst/sims_coordUtils/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/sims_coordUtils/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/sims_coordUtils/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/sims_coordUtils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/sims_coordUtils/labels{/name}","releases_url":"https://api.github.com/repos/lsst/sims_coordUtils/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/sims_coordUtils/deployments","created_at":"2015-04-27T13:28:33Z","updated_at":"2018-05-08T22:50:36Z","pushed_at":"2018-05-10T17:28:11Z","git_url":"git://github.com/lsst/sims_coordUtils.git","ssh_url":"git@github.com:lsst/sims_coordUtils.git","clone_url":"https://github.com/lsst/sims_coordUtils.git","svn_url":"https://github.com/lsst/sims_coordUtils","homepage":null,"size":946,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/25"},"html":{"href":"https://github.com/lsst/sims_coordUtils/pull/25"},"issue":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/issues/25"},"comments":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/sims_coordUtils/statuses/5998cf00e439dcc6b0bb927c0d4e7ca2b2cdd5de"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":11,"additions":207,"deletions":21,"changed_files":4}}
{"actor":{"display_login":"danielsf"}}