{"action":"created","issue":{"url":"https://api.github.com/repos/IBM/carbon-components/issues/1537","repository_url":"https://api.github.com/repos/IBM/carbon-components","labels_url":"https://api.github.com/repos/IBM/carbon-components/issues/1537/labels{/name}","comments_url":"https://api.github.com/repos/IBM/carbon-components/issues/1537/comments","events_url":"https://api.github.com/repos/IBM/carbon-components/issues/1537/events","html_url":"https://github.com/IBM/carbon-components/pull/1537","id":387888706,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2Mjc4NjQ3","number":1537,"title":"fix(select): remove unecessary and incorrect CSS","user":{"login":"lovemecomputer","id":3846271,"node_id":"MDQ6VXNlcjM4NDYyNzE=","avatar_url":"https://avatars0.githubusercontent.com/u/3846271?v=4","gravatar_id":"","url":"https://api.github.com/users/lovemecomputer","html_url":"https://github.com/lovemecomputer","followers_url":"https://api.github.com/users/lovemecomputer/followers","following_url":"https://api.github.com/users/lovemecomputer/following{/other_user}","gists_url":"https://api.github.com/users/lovemecomputer/gists{/gist_id}","starred_url":"https://api.github.com/users/lovemecomputer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lovemecomputer/subscriptions","organizations_url":"https://api.github.com/users/lovemecomputer/orgs","repos_url":"https://api.github.com/users/lovemecomputer/repos","events_url":"https://api.github.com/users/lovemecomputer/events{/privacy}","received_events_url":"https://api.github.com/users/lovemecomputer/received_events","type":"User","site_admin":false},"labels":[{"id":1056028604,"node_id":"MDU6TGFiZWwxMDU2MDI4NjA0","url":"https://api.github.com/repos/IBM/carbon-components/labels/priority:%20high","name":"priority: high","color":"EB101A","default":false},{"id":1056028618,"node_id":"MDU6TGFiZWwxMDU2MDI4NjE4","url":"https://api.github.com/repos/IBM/carbon-components/labels/project:%20components","name":"project: components","color":"ff69b4","default":false},{"id":1056028590,"node_id":"MDU6TGFiZWwxMDU2MDI4NTkw","url":"https://api.github.com/repos/IBM/carbon-components/labels/status:%20ready%20for%20review%20%20:eyes:","name":"status: ready for review  :eyes:","color":"fbca04","default":false},{"id":1056028595,"node_id":"MDU6TGFiZWwxMDU2MDI4NTk1","url":"https://api.github.com/repos/IBM/carbon-components/labels/type:%20bug%20%F0%9F%90%9B","name":"type: bug 🐛","color":"f8673a","default":false},{"id":1056155838,"node_id":"MDU6TGFiZWwxMDU2MTU1ODM4","url":"https://api.github.com/repos/IBM/carbon-components/labels/type:%20dev%20:robot:","name":"type: dev :robot:","color":"c8a2e8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-12-05T18:32:22Z","updated_at":"2018-12-14T16:42:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/IBM/carbon-components/pulls/1537","html_url":"https://github.com/IBM/carbon-components/pull/1537","diff_url":"https://github.com/IBM/carbon-components/pull/1537.diff","patch_url":"https://github.com/IBM/carbon-components/pull/1537.patch"},"body":"this issue came up while updating https://github.com/IBM/carbon-components/pull/1518\r\n\r\nthe new icon pack has proper sizing built in, so @aledavila and i removed the unnecessary width & height rules! this looks correct, and the correct appearance should be inherited by the pagination select components once they're both merged :)"},"comment":{"url":"https://api.github.com/repos/IBM/carbon-components/issues/comments/447381398","html_url":"https://github.com/IBM/carbon-components/pull/1537#issuecomment-447381398","issue_url":"https://api.github.com/repos/IBM/carbon-components/issues/1537","id":447381398,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzM4MTM5OA==","user":{"login":"aledavila","id":12533409,"node_id":"MDQ6VXNlcjEyNTMzNDA5","avatar_url":"https://avatars2.githubusercontent.com/u/12533409?v=4","gravatar_id":"","url":"https://api.github.com/users/aledavila","html_url":"https://github.com/aledavila","followers_url":"https://api.github.com/users/aledavila/followers","following_url":"https://api.github.com/users/aledavila/following{/other_user}","gists_url":"https://api.github.com/users/aledavila/gists{/gist_id}","starred_url":"https://api.github.com/users/aledavila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledavila/subscriptions","organizations_url":"https://api.github.com/users/aledavila/orgs","repos_url":"https://api.github.com/users/aledavila/repos","events_url":"https://api.github.com/users/aledavila/events{/privacy}","received_events_url":"https://api.github.com/users/aledavila/received_events","type":"User","site_admin":false},"created_at":"2018-12-14T16:42:19Z","updated_at":"2018-12-14T16:42:19Z","author_association":"CONTRIBUTOR","body":"@asudoh  Correct which is why this is only removing the width and height from the experimental select css. \r\n\r\nThe issue here was the experimental select component svg was being overriden by the width and height that this pr fixes by removing the width and height. Those sizes are brought in by bringing in the correct  svg. If the correct svg is brought in (which it is now for experimental select) then there is no need to define the width and height in the css. "}}
{"actor":{"display_login":"aledavila"}}