{"action":"created","comment":{"url":"https://api.github.com/repos/ably/ably-go/pulls/comments/213630777","pull_request_review_id":150505062,"id":213630777,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzYzMDc3Nw==","diff_hunk":"@@ -195,3 +197,25 @@ var _ = Describe(\"RestClient\", func() {\n \t\t})\n \t})\n })\n+\n+func TestRSC7(t *testing.T) {\n+\tapp, err := ablytest.NewSandbox(nil)\n+\tif err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\tc, err := ably.NewRestClient(app.Options())\n+\tif err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\tt.Run(\"must set version header\", func(ts *testing.T) {\n+\t\treq, err := c.NewHTTPRequest(&ably.Request{})\n+\t\tif err != nil {\n+\t\t\tts.Fatal(err)\n+\t\t}\n+\t\th := req.Header.Get(\"X-Ably-Version\")","path":"ably/rest_client_test.go","position":31,"original_position":31,"commit_id":"92a4e8c40d287dcb767177e0fa7fa93df3382884","original_commit_id":"92a4e8c40d287dcb767177e0fa7fa93df3382884","user":{"login":"gernest","id":6039952,"node_id":"MDQ6VXNlcjYwMzk5NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/6039952?v=4","gravatar_id":"","url":"https://api.github.com/users/gernest","html_url":"https://github.com/gernest","followers_url":"https://api.github.com/users/gernest/followers","following_url":"https://api.github.com/users/gernest/following{/other_user}","gists_url":"https://api.github.com/users/gernest/gists{/gist_id}","starred_url":"https://api.github.com/users/gernest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gernest/subscriptions","organizations_url":"https://api.github.com/users/gernest/orgs","repos_url":"https://api.github.com/users/gernest/repos","events_url":"https://api.github.com/users/gernest/events{/privacy}","received_events_url":"https://api.github.com/users/gernest/received_events","type":"User","site_admin":false},"body":"@paddybyers that is not really necessary. Because this is the only place throughout the library where the request is composed.\r\n\r\nSo, what you see is a stated fact. We are only checking that our facts are correct.","created_at":"2018-08-29T10:52:46Z","updated_at":"2018-08-29T10:52:46Z","html_url":"https://github.com/ably/ably-go/pull/67#discussion_r213630777","pull_request_url":"https://api.github.com/repos/ably/ably-go/pulls/67","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ably/ably-go/pulls/comments/213630777"},"html":{"href":"https://github.com/ably/ably-go/pull/67#discussion_r213630777"},"pull_request":{"href":"https://api.github.com/repos/ably/ably-go/pulls/67"}},"in_reply_to_id":213628665},"pull_request":{"url":"https://api.github.com/repos/ably/ably-go/pulls/67","id":211703830,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNzAzODMw","html_url":"https://github.com/ably/ably-go/pull/67","diff_url":"https://github.com/ably/ably-go/pull/67.diff","patch_url":"https://github.com/ably/ably-go/pull/67.patch","issue_url":"https://api.github.com/repos/ably/ably-go/issues/67","number":67,"state":"open","locked":false,"title":"RSC7a add version header","user":{"login":"gernest","id":6039952,"node_id":"MDQ6VXNlcjYwMzk5NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/6039952?v=4","gravatar_id":"","url":"https://api.github.com/users/gernest","html_url":"https://github.com/gernest","followers_url":"https://api.github.com/users/gernest/followers","following_url":"https://api.github.com/users/gernest/following{/other_user}","gists_url":"https://api.github.com/users/gernest/gists{/gist_id}","starred_url":"https://api.github.com/users/gernest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gernest/subscriptions","organizations_url":"https://api.github.com/users/gernest/orgs","repos_url":"https://api.github.com/users/gernest/repos","events_url":"https://api.github.com/users/gernest/events{/privacy}","received_events_url":"https://api.github.com/users/gernest/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-29T10:27:35Z","updated_at":"2018-08-29T10:52:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5bd04567d60c6c71d37535706ea931efa93a50b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ably/ably-go/pulls/67/commits","review_comments_url":"https://api.github.com/repos/ably/ably-go/pulls/67/comments","review_comment_url":"https://api.github.com/repos/ably/ably-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ably/ably-go/issues/67/comments","statuses_url":"https://api.github.com/repos/ably/ably-go/statuses/92a4e8c40d287dcb767177e0fa7fa93df3382884","head":{"label":"gernest:rsc7a-add-version-header","ref":"rsc7a-add-version-header","sha":"92a4e8c40d287dcb767177e0fa7fa93df3382884","user":{"login":"gernest","id":6039952,"node_id":"MDQ6VXNlcjYwMzk5NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/6039952?v=4","gravatar_id":"","url":"https://api.github.com/users/gernest","html_url":"https://github.com/gernest","followers_url":"https://api.github.com/users/gernest/followers","following_url":"https://api.github.com/users/gernest/following{/other_user}","gists_url":"https://api.github.com/users/gernest/gists{/gist_id}","starred_url":"https://api.github.com/users/gernest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gernest/subscriptions","organizations_url":"https://api.github.com/users/gernest/orgs","repos_url":"https://api.github.com/users/gernest/repos","events_url":"https://api.github.com/users/gernest/events{/privacy}","received_events_url":"https://api.github.com/users/gernest/received_events","type":"User","site_admin":false},"repo":{"id":146273138,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYyNzMxMzg=","name":"ably-go","full_name":"gernest/ably-go","owner":{"login":"gernest","id":6039952,"node_id":"MDQ6VXNlcjYwMzk5NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/6039952?v=4","gravatar_id":"","url":"https://api.github.com/users/gernest","html_url":"https://github.com/gernest","followers_url":"https://api.github.com/users/gernest/followers","following_url":"https://api.github.com/users/gernest/following{/other_user}","gists_url":"https://api.github.com/users/gernest/gists{/gist_id}","starred_url":"https://api.github.com/users/gernest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gernest/subscriptions","organizations_url":"https://api.github.com/users/gernest/orgs","repos_url":"https://api.github.com/users/gernest/repos","events_url":"https://api.github.com/users/gernest/events{/privacy}","received_events_url":"https://api.github.com/users/gernest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gernest/ably-go","description":"Go client library SDK for Ably realtime messaging service","fork":true,"url":"https://api.github.com/repos/gernest/ably-go","forks_url":"https://api.github.com/repos/gernest/ably-go/forks","keys_url":"https://api.github.com/repos/gernest/ably-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gernest/ably-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gernest/ably-go/teams","hooks_url":"https://api.github.com/repos/gernest/ably-go/hooks","issue_events_url":"https://api.github.com/repos/gernest/ably-go/issues/events{/number}","events_url":"https://api.github.com/repos/gernest/ably-go/events","assignees_url":"https://api.github.com/repos/gernest/ably-go/assignees{/user}","branches_url":"https://api.github.com/repos/gernest/ably-go/branches{/branch}","tags_url":"https://api.github.com/repos/gernest/ably-go/tags","blobs_url":"https://api.github.com/repos/gernest/ably-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gernest/ably-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gernest/ably-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/gernest/ably-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gernest/ably-go/statuses/{sha}","languages_url":"https://api.github.com/repos/gernest/ably-go/languages","stargazers_url":"https://api.github.com/repos/gernest/ably-go/stargazers","contributors_url":"https://api.github.com/repos/gernest/ably-go/contributors","subscribers_url":"https://api.github.com/repos/gernest/ably-go/subscribers","subscription_url":"https://api.github.com/repos/gernest/ably-go/subscription","commits_url":"https://api.github.com/repos/gernest/ably-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/gernest/ably-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/gernest/ably-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/gernest/ably-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/gernest/ably-go/contents/{+path}","compare_url":"https://api.github.com/repos/gernest/ably-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gernest/ably-go/merges","archive_url":"https://api.github.com/repos/gernest/ably-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gernest/ably-go/downloads","issues_url":"https://api.github.com/repos/gernest/ably-go/issues{/number}","pulls_url":"https://api.github.com/repos/gernest/ably-go/pulls{/number}","milestones_url":"https://api.github.com/repos/gernest/ably-go/milestones{/number}","notifications_url":"https://api.github.com/repos/gernest/ably-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gernest/ably-go/labels{/name}","releases_url":"https://api.github.com/repos/gernest/ably-go/releases{/id}","deployments_url":"https://api.github.com/repos/gernest/ably-go/deployments","created_at":"2018-08-27T09:01:50Z","updated_at":"2018-08-27T09:01:52Z","pushed_at":"2018-08-29T10:25:20Z","git_url":"git://github.com/gernest/ably-go.git","ssh_url":"git@github.com:gernest/ably-go.git","clone_url":"https://github.com/gernest/ably-go.git","svn_url":"https://github.com/gernest/ably-go","homepage":"https://www.ably.io/download","size":636,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ably:intergation-spec-1.1","ref":"intergation-spec-1.1","sha":"eb8840655f32c8af1422b5ada6a9a43d53f1e784","user":{"login":"ably","id":1859245,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTkyNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1859245?v=4","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"repo":{"id":27377399,"node_id":"MDEwOlJlcG9zaXRvcnkyNzM3NzM5OQ==","name":"ably-go","full_name":"ably/ably-go","owner":{"login":"ably","id":1859245,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTkyNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1859245?v=4","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ably/ably-go","description":"Go client library SDK for Ably realtime messaging service","fork":false,"url":"https://api.github.com/repos/ably/ably-go","forks_url":"https://api.github.com/repos/ably/ably-go/forks","keys_url":"https://api.github.com/repos/ably/ably-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ably/ably-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ably/ably-go/teams","hooks_url":"https://api.github.com/repos/ably/ably-go/hooks","issue_events_url":"https://api.github.com/repos/ably/ably-go/issues/events{/number}","events_url":"https://api.github.com/repos/ably/ably-go/events","assignees_url":"https://api.github.com/repos/ably/ably-go/assignees{/user}","branches_url":"https://api.github.com/repos/ably/ably-go/branches{/branch}","tags_url":"https://api.github.com/repos/ably/ably-go/tags","blobs_url":"https://api.github.com/repos/ably/ably-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ably/ably-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ably/ably-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/ably/ably-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ably/ably-go/statuses/{sha}","languages_url":"https://api.github.com/repos/ably/ably-go/languages","stargazers_url":"https://api.github.com/repos/ably/ably-go/stargazers","contributors_url":"https://api.github.com/repos/ably/ably-go/contributors","subscribers_url":"https://api.github.com/repos/ably/ably-go/subscribers","subscription_url":"https://api.github.com/repos/ably/ably-go/subscription","commits_url":"https://api.github.com/repos/ably/ably-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/ably/ably-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/ably/ably-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/ably/ably-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/ably/ably-go/contents/{+path}","compare_url":"https://api.github.com/repos/ably/ably-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ably/ably-go/merges","archive_url":"https://api.github.com/repos/ably/ably-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ably/ably-go/downloads","issues_url":"https://api.github.com/repos/ably/ably-go/issues{/number}","pulls_url":"https://api.github.com/repos/ably/ably-go/pulls{/number}","milestones_url":"https://api.github.com/repos/ably/ably-go/milestones{/number}","notifications_url":"https://api.github.com/repos/ably/ably-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ably/ably-go/labels{/name}","releases_url":"https://api.github.com/repos/ably/ably-go/releases{/id}","deployments_url":"https://api.github.com/repos/ably/ably-go/deployments","created_at":"2014-12-01T11:57:59Z","updated_at":"2018-08-27T17:26:22Z","pushed_at":"2018-08-29T10:27:35Z","git_url":"git://github.com/ably/ably-go.git","ssh_url":"git@github.com:ably/ably-go.git","clone_url":"https://github.com/ably/ably-go.git","svn_url":"https://github.com/ably/ably-go","homepage":"https://www.ably.io/download","size":634,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10,"open_issues":17,"watchers":14,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ably/ably-go/pulls/67"},"html":{"href":"https://github.com/ably/ably-go/pull/67"},"issue":{"href":"https://api.github.com/repos/ably/ably-go/issues/67"},"comments":{"href":"https://api.github.com/repos/ably/ably-go/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/ably/ably-go/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/ably/ably-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ably/ably-go/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/ably/ably-go/statuses/92a4e8c40d287dcb767177e0fa7fa93df3382884"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gernest"}}