{"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/212331042","pull_request_review_id":148938595,"id":212331042,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjMzMTA0Mg==","diff_hunk":"@@ -956,27 +958,33 @@ private void BlockDownloaded(uint256 blockHash, Block block)\n                 {\n                     try\n                     {\n-                        chainedHeader = this.chainedHeaderTree.FindHeaderAndVerifyBlockIntegrity(block);\n+                        chainedHeader = this.chainedHeaderTree.FindHeader(block);\n                     }\n                     catch (BlockDownloadedForMissingChainedHeaderException)\n                     {\n                         this.logger.LogTrace(\"(-)[CHAINED_HEADER_NOT_FOUND]\");\n                         return;\n                     }\n-                    catch (IntegrityValidationFailedException integrityException)\n-                    {\n-                        this.peerBanning.BanAndDisconnectPeer(integrityException.PeerEndPoint, integrityException.BanDurationSeconds, $\"Integrity validation failed: {integrityException.Error.Message}\");\n-\n-                        this.logger.LogTrace(\"(-)[INTEGRITY_VERIFICATION_FAILED]\");\n-                        return;\n-                    }\n                 }\n                 else\n                 {\n                     this.logger.LogDebug(\"Block '{0}' failed to be delivered.\", blockHash);\n                 }\n             }\n \n+            if (block != null)\n+            {","path":"src/Stratis.Bitcoin/Consensus/ConsensusManager.cs","position":56,"original_position":52,"commit_id":"a87473b22c1d6165d0cb9c0671c332637ac09724","original_commit_id":"fec7d6b6dba3d0a509d71b6985e5d55903daaf65","user":{"login":"noescape00","id":10259355,"node_id":"MDQ6VXNlcjEwMjU5MzU1","avatar_url":"https://avatars0.githubusercontent.com/u/10259355?v=4","gravatar_id":"","url":"https://api.github.com/users/noescape00","html_url":"https://github.com/noescape00","followers_url":"https://api.github.com/users/noescape00/followers","following_url":"https://api.github.com/users/noescape00/following{/other_user}","gists_url":"https://api.github.com/users/noescape00/gists{/gist_id}","starred_url":"https://api.github.com/users/noescape00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noescape00/subscriptions","organizations_url":"https://api.github.com/users/noescape00/orgs","repos_url":"https://api.github.com/users/noescape00/repos","events_url":"https://api.github.com/users/noescape00/events{/privacy}","received_events_url":"https://api.github.com/users/noescape00/received_events","type":"User","site_admin":false},"body":"Ah, yes you are right, we do need to check, sorry. \r\n\r\nForgot about cases where we want to process block being null (when puller failed to deliver)","created_at":"2018-08-23T14:28:49Z","updated_at":"2018-08-23T14:28:49Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1999#discussion_r212331042","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1999","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/212331042"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1999#discussion_r212331042"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1999"}},"in_reply_to_id":212293693},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1999","id":210256291,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMjU2Mjkx","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1999","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1999.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1999.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1999","number":1999,"state":"open","locked":false,"title":"[Activation] Do BlockIntegrity check outside of lock","user":{"login":"zeptin","id":25860,"node_id":"MDQ6VXNlcjI1ODYw","avatar_url":"https://avatars2.githubusercontent.com/u/25860?v=4","gravatar_id":"","url":"https://api.github.com/users/zeptin","html_url":"https://github.com/zeptin","followers_url":"https://api.github.com/users/zeptin/followers","following_url":"https://api.github.com/users/zeptin/following{/other_user}","gists_url":"https://api.github.com/users/zeptin/gists{/gist_id}","starred_url":"https://api.github.com/users/zeptin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeptin/subscriptions","organizations_url":"https://api.github.com/users/zeptin/orgs","repos_url":"https://api.github.com/users/zeptin/repos","events_url":"https://api.github.com/users/zeptin/events{/privacy}","received_events_url":"https://api.github.com/users/zeptin/received_events","type":"User","site_admin":false},"body":"For #1938","created_at":"2018-08-22T20:34:24Z","updated_at":"2018-08-23T14:28:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fbfe8a7ed966892ca6a5a31de303652b4ae46e5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Aprogiena","id":30052221,"node_id":"MDQ6VXNlcjMwMDUyMjIx","avatar_url":"https://avatars0.githubusercontent.com/u/30052221?v=4","gravatar_id":"","url":"https://api.github.com/users/Aprogiena","html_url":"https://github.com/Aprogiena","followers_url":"https://api.github.com/users/Aprogiena/followers","following_url":"https://api.github.com/users/Aprogiena/following{/other_user}","gists_url":"https://api.github.com/users/Aprogiena/gists{/gist_id}","starred_url":"https://api.github.com/users/Aprogiena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aprogiena/subscriptions","organizations_url":"https://api.github.com/users/Aprogiena/orgs","repos_url":"https://api.github.com/users/Aprogiena/repos","events_url":"https://api.github.com/users/Aprogiena/events{/privacy}","received_events_url":"https://api.github.com/users/Aprogiena/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1999/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1999/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1999/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/a87473b22c1d6165d0cb9c0671c332637ac09724","head":{"label":"zeptin:blockintegrity-1938","ref":"blockintegrity-1938","sha":"a87473b22c1d6165d0cb9c0671c332637ac09724","user":{"login":"zeptin","id":25860,"node_id":"MDQ6VXNlcjI1ODYw","avatar_url":"https://avatars2.githubusercontent.com/u/25860?v=4","gravatar_id":"","url":"https://api.github.com/users/zeptin","html_url":"https://github.com/zeptin","followers_url":"https://api.github.com/users/zeptin/followers","following_url":"https://api.github.com/users/zeptin/following{/other_user}","gists_url":"https://api.github.com/users/zeptin/gists{/gist_id}","starred_url":"https://api.github.com/users/zeptin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeptin/subscriptions","organizations_url":"https://api.github.com/users/zeptin/orgs","repos_url":"https://api.github.com/users/zeptin/repos","events_url":"https://api.github.com/users/zeptin/events{/privacy}","received_events_url":"https://api.github.com/users/zeptin/received_events","type":"User","site_admin":false},"repo":{"id":141340460,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzNDA0NjA=","name":"StratisBitcoinFullNode","full_name":"zeptin/StratisBitcoinFullNode","owner":{"login":"zeptin","id":25860,"node_id":"MDQ6VXNlcjI1ODYw","avatar_url":"https://avatars2.githubusercontent.com/u/25860?v=4","gravatar_id":"","url":"https://api.github.com/users/zeptin","html_url":"https://github.com/zeptin","followers_url":"https://api.github.com/users/zeptin/followers","following_url":"https://api.github.com/users/zeptin/following{/other_user}","gists_url":"https://api.github.com/users/zeptin/gists{/gist_id}","starred_url":"https://api.github.com/users/zeptin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeptin/subscriptions","organizations_url":"https://api.github.com/users/zeptin/orgs","repos_url":"https://api.github.com/users/zeptin/repos","events_url":"https://api.github.com/users/zeptin/events{/privacy}","received_events_url":"https://api.github.com/users/zeptin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zeptin/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":true,"url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/zeptin/StratisBitcoinFullNode/deployments","created_at":"2018-07-17T20:32:06Z","updated_at":"2018-07-17T20:32:12Z","pushed_at":"2018-08-23T13:18:14Z","git_url":"git://github.com/zeptin/StratisBitcoinFullNode.git","ssh_url":"git@github.com:zeptin/StratisBitcoinFullNode.git","clone_url":"https://github.com/zeptin/StratisBitcoinFullNode.git","svn_url":"https://github.com/zeptin/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":33647,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratisproject:core-way-activation","ref":"core-way-activation","sha":"5408dd5fc18318a9cc8a923ee1650e0fd4f09e59","user":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI3MTI5MA==","name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","owner":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-08-23T10:49:47Z","pushed_at":"2018-08-23T13:46:28Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":32951,"stargazers_count":535,"watchers_count":535,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":243,"mirror_url":null,"archived":false,"open_issues_count":156,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":243,"open_issues":156,"watchers":535,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1999"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1999"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1999"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1999/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1999/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1999/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/a87473b22c1d6165d0cb9c0671c332637ac09724"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"noescape00"}}