{"action":"closed","number":99,"pull_request":{"url":"https://api.github.com/repos/pcdshub/typhon/pulls/99","id":216407997,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDA3OTk3","html_url":"https://github.com/pcdshub/typhon/pull/99","diff_url":"https://github.com/pcdshub/typhon/pull/99.diff","patch_url":"https://github.com/pcdshub/typhon/pull/99.patch","issue_url":"https://api.github.com/repos/pcdshub/typhon/issues/99","number":99,"state":"closed","locked":false,"title":"FIX: Send signal metadata before value","user":{"login":"teddyrendahl","id":25753048,"node_id":"MDQ6VXNlcjI1NzUzMDQ4","avatar_url":"https://avatars3.githubusercontent.com/u/25753048?v=4","gravatar_id":"","url":"https://api.github.com/users/teddyrendahl","html_url":"https://github.com/teddyrendahl","followers_url":"https://api.github.com/users/teddyrendahl/followers","following_url":"https://api.github.com/users/teddyrendahl/following{/other_user}","gists_url":"https://api.github.com/users/teddyrendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyrendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyrendahl/subscriptions","organizations_url":"https://api.github.com/users/teddyrendahl/orgs","repos_url":"https://api.github.com/users/teddyrendahl/repos","events_url":"https://api.github.com/users/teddyrendahl/events{/privacy}","received_events_url":"https://api.github.com/users/teddyrendahl/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nThought I was having an issue with `PyDMEnumComboBox` for days but just realized that the `SignalPlugin` sends the new value before ever sending the `metadata`. We then try to set the value of the `QComboBox` before we have filled it with any information.\r\n\r\nThis is a good thing to keep in mind for general `Plugin` logic. We can't assume that we are sending this information to `state-less` widget and it would be nice to ensure that all the widgets depend on the same order of information.\r\n","created_at":"2018-09-18T18:51:15Z","updated_at":"2018-09-18T21:19:17Z","closed_at":"2018-09-18T21:19:17Z","merged_at":"2018-09-18T21:19:17Z","merge_commit_sha":"12096ba80719de6f6eef9694e259117b861671c2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hhslepicka","id":8185425,"node_id":"MDQ6VXNlcjgxODU0MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/8185425?v=4","gravatar_id":"","url":"https://api.github.com/users/hhslepicka","html_url":"https://github.com/hhslepicka","followers_url":"https://api.github.com/users/hhslepicka/followers","following_url":"https://api.github.com/users/hhslepicka/following{/other_user}","gists_url":"https://api.github.com/users/hhslepicka/gists{/gist_id}","starred_url":"https://api.github.com/users/hhslepicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhslepicka/subscriptions","organizations_url":"https://api.github.com/users/hhslepicka/orgs","repos_url":"https://api.github.com/users/hhslepicka/repos","events_url":"https://api.github.com/users/hhslepicka/events{/privacy}","received_events_url":"https://api.github.com/users/hhslepicka/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pcdshub/typhon/pulls/99/commits","review_comments_url":"https://api.github.com/repos/pcdshub/typhon/pulls/99/comments","review_comment_url":"https://api.github.com/repos/pcdshub/typhon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pcdshub/typhon/issues/99/comments","statuses_url":"https://api.github.com/repos/pcdshub/typhon/statuses/3b60e9fc701d991a21e4ef419e5552b94f8e1f00","head":{"label":"teddyrendahl:md_order","ref":"md_order","sha":"3b60e9fc701d991a21e4ef419e5552b94f8e1f00","user":{"login":"teddyrendahl","id":25753048,"node_id":"MDQ6VXNlcjI1NzUzMDQ4","avatar_url":"https://avatars3.githubusercontent.com/u/25753048?v=4","gravatar_id":"","url":"https://api.github.com/users/teddyrendahl","html_url":"https://github.com/teddyrendahl","followers_url":"https://api.github.com/users/teddyrendahl/followers","following_url":"https://api.github.com/users/teddyrendahl/following{/other_user}","gists_url":"https://api.github.com/users/teddyrendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyrendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyrendahl/subscriptions","organizations_url":"https://api.github.com/users/teddyrendahl/orgs","repos_url":"https://api.github.com/users/teddyrendahl/repos","events_url":"https://api.github.com/users/teddyrendahl/events{/privacy}","received_events_url":"https://api.github.com/users/teddyrendahl/received_events","type":"User","site_admin":false},"repo":{"id":109220100,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkyMjAxMDA=","name":"typhon","full_name":"teddyrendahl/typhon","private":false,"owner":{"login":"teddyrendahl","id":25753048,"node_id":"MDQ6VXNlcjI1NzUzMDQ4","avatar_url":"https://avatars3.githubusercontent.com/u/25753048?v=4","gravatar_id":"","url":"https://api.github.com/users/teddyrendahl","html_url":"https://github.com/teddyrendahl","followers_url":"https://api.github.com/users/teddyrendahl/followers","following_url":"https://api.github.com/users/teddyrendahl/following{/other_user}","gists_url":"https://api.github.com/users/teddyrendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyrendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyrendahl/subscriptions","organizations_url":"https://api.github.com/users/teddyrendahl/orgs","repos_url":"https://api.github.com/users/teddyrendahl/repos","events_url":"https://api.github.com/users/teddyrendahl/events{/privacy}","received_events_url":"https://api.github.com/users/teddyrendahl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/teddyrendahl/typhon","description":"Interface Generation for Ophyd Devices","fork":true,"url":"https://api.github.com/repos/teddyrendahl/typhon","forks_url":"https://api.github.com/repos/teddyrendahl/typhon/forks","keys_url":"https://api.github.com/repos/teddyrendahl/typhon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teddyrendahl/typhon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teddyrendahl/typhon/teams","hooks_url":"https://api.github.com/repos/teddyrendahl/typhon/hooks","issue_events_url":"https://api.github.com/repos/teddyrendahl/typhon/issues/events{/number}","events_url":"https://api.github.com/repos/teddyrendahl/typhon/events","assignees_url":"https://api.github.com/repos/teddyrendahl/typhon/assignees{/user}","branches_url":"https://api.github.com/repos/teddyrendahl/typhon/branches{/branch}","tags_url":"https://api.github.com/repos/teddyrendahl/typhon/tags","blobs_url":"https://api.github.com/repos/teddyrendahl/typhon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teddyrendahl/typhon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teddyrendahl/typhon/git/refs{/sha}","trees_url":"https://api.github.com/repos/teddyrendahl/typhon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teddyrendahl/typhon/statuses/{sha}","languages_url":"https://api.github.com/repos/teddyrendahl/typhon/languages","stargazers_url":"https://api.github.com/repos/teddyrendahl/typhon/stargazers","contributors_url":"https://api.github.com/repos/teddyrendahl/typhon/contributors","subscribers_url":"https://api.github.com/repos/teddyrendahl/typhon/subscribers","subscription_url":"https://api.github.com/repos/teddyrendahl/typhon/subscription","commits_url":"https://api.github.com/repos/teddyrendahl/typhon/commits{/sha}","git_commits_url":"https://api.github.com/repos/teddyrendahl/typhon/git/commits{/sha}","comments_url":"https://api.github.com/repos/teddyrendahl/typhon/comments{/number}","issue_comment_url":"https://api.github.com/repos/teddyrendahl/typhon/issues/comments{/number}","contents_url":"https://api.github.com/repos/teddyrendahl/typhon/contents/{+path}","compare_url":"https://api.github.com/repos/teddyrendahl/typhon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teddyrendahl/typhon/merges","archive_url":"https://api.github.com/repos/teddyrendahl/typhon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teddyrendahl/typhon/downloads","issues_url":"https://api.github.com/repos/teddyrendahl/typhon/issues{/number}","pulls_url":"https://api.github.com/repos/teddyrendahl/typhon/pulls{/number}","milestones_url":"https://api.github.com/repos/teddyrendahl/typhon/milestones{/number}","notifications_url":"https://api.github.com/repos/teddyrendahl/typhon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teddyrendahl/typhon/labels{/name}","releases_url":"https://api.github.com/repos/teddyrendahl/typhon/releases{/id}","deployments_url":"https://api.github.com/repos/teddyrendahl/typhon/deployments","created_at":"2017-11-02T05:07:19Z","updated_at":"2018-09-18T16:21:32Z","pushed_at":"2018-09-18T21:04:20Z","git_url":"git://github.com/teddyrendahl/typhon.git","ssh_url":"git@github.com:teddyrendahl/typhon.git","clone_url":"https://github.com/teddyrendahl/typhon.git","svn_url":"https://github.com/teddyrendahl/typhon","homepage":null,"size":822,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pcdshub:master","ref":"master","sha":"dac613351b95aff906dfa36796053b6b7215e258","user":{"login":"pcdshub","id":31903189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTAzMTg5","avatar_url":"https://avatars1.githubusercontent.com/u/31903189?v=4","gravatar_id":"","url":"https://api.github.com/users/pcdshub","html_url":"https://github.com/pcdshub","followers_url":"https://api.github.com/users/pcdshub/followers","following_url":"https://api.github.com/users/pcdshub/following{/other_user}","gists_url":"https://api.github.com/users/pcdshub/gists{/gist_id}","starred_url":"https://api.github.com/users/pcdshub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcdshub/subscriptions","organizations_url":"https://api.github.com/users/pcdshub/orgs","repos_url":"https://api.github.com/users/pcdshub/repos","events_url":"https://api.github.com/users/pcdshub/events{/privacy}","received_events_url":"https://api.github.com/users/pcdshub/received_events","type":"Organization","site_admin":false},"repo":{"id":107621437,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc2MjE0Mzc=","name":"typhon","full_name":"pcdshub/typhon","private":false,"owner":{"login":"pcdshub","id":31903189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTAzMTg5","avatar_url":"https://avatars1.githubusercontent.com/u/31903189?v=4","gravatar_id":"","url":"https://api.github.com/users/pcdshub","html_url":"https://github.com/pcdshub","followers_url":"https://api.github.com/users/pcdshub/followers","following_url":"https://api.github.com/users/pcdshub/following{/other_user}","gists_url":"https://api.github.com/users/pcdshub/gists{/gist_id}","starred_url":"https://api.github.com/users/pcdshub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcdshub/subscriptions","organizations_url":"https://api.github.com/users/pcdshub/orgs","repos_url":"https://api.github.com/users/pcdshub/repos","events_url":"https://api.github.com/users/pcdshub/events{/privacy}","received_events_url":"https://api.github.com/users/pcdshub/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pcdshub/typhon","description":"Interface Generation for Ophyd Devices","fork":false,"url":"https://api.github.com/repos/pcdshub/typhon","forks_url":"https://api.github.com/repos/pcdshub/typhon/forks","keys_url":"https://api.github.com/repos/pcdshub/typhon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcdshub/typhon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcdshub/typhon/teams","hooks_url":"https://api.github.com/repos/pcdshub/typhon/hooks","issue_events_url":"https://api.github.com/repos/pcdshub/typhon/issues/events{/number}","events_url":"https://api.github.com/repos/pcdshub/typhon/events","assignees_url":"https://api.github.com/repos/pcdshub/typhon/assignees{/user}","branches_url":"https://api.github.com/repos/pcdshub/typhon/branches{/branch}","tags_url":"https://api.github.com/repos/pcdshub/typhon/tags","blobs_url":"https://api.github.com/repos/pcdshub/typhon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcdshub/typhon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcdshub/typhon/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcdshub/typhon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcdshub/typhon/statuses/{sha}","languages_url":"https://api.github.com/repos/pcdshub/typhon/languages","stargazers_url":"https://api.github.com/repos/pcdshub/typhon/stargazers","contributors_url":"https://api.github.com/repos/pcdshub/typhon/contributors","subscribers_url":"https://api.github.com/repos/pcdshub/typhon/subscribers","subscription_url":"https://api.github.com/repos/pcdshub/typhon/subscription","commits_url":"https://api.github.com/repos/pcdshub/typhon/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcdshub/typhon/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcdshub/typhon/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcdshub/typhon/issues/comments{/number}","contents_url":"https://api.github.com/repos/pcdshub/typhon/contents/{+path}","compare_url":"https://api.github.com/repos/pcdshub/typhon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcdshub/typhon/merges","archive_url":"https://api.github.com/repos/pcdshub/typhon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcdshub/typhon/downloads","issues_url":"https://api.github.com/repos/pcdshub/typhon/issues{/number}","pulls_url":"https://api.github.com/repos/pcdshub/typhon/pulls{/number}","milestones_url":"https://api.github.com/repos/pcdshub/typhon/milestones{/number}","notifications_url":"https://api.github.com/repos/pcdshub/typhon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcdshub/typhon/labels{/name}","releases_url":"https://api.github.com/repos/pcdshub/typhon/releases{/id}","deployments_url":"https://api.github.com/repos/pcdshub/typhon/deployments","created_at":"2017-10-20T02:18:01Z","updated_at":"2018-09-18T21:04:19Z","pushed_at":"2018-09-18T21:19:17Z","git_url":"git://github.com/pcdshub/typhon.git","ssh_url":"git@github.com:pcdshub/typhon.git","clone_url":"https://github.com/pcdshub/typhon.git","svn_url":"https://github.com/pcdshub/typhon","homepage":"http://pcdshub.github.io/typhon","size":7775,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":21,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pcdshub/typhon/pulls/99"},"html":{"href":"https://github.com/pcdshub/typhon/pull/99"},"issue":{"href":"https://api.github.com/repos/pcdshub/typhon/issues/99"},"comments":{"href":"https://api.github.com/repos/pcdshub/typhon/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/pcdshub/typhon/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/pcdshub/typhon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pcdshub/typhon/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/pcdshub/typhon/statuses/3b60e9fc701d991a21e4ef419e5552b94f8e1f00"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"teddyrendahl","id":25753048,"node_id":"MDQ6VXNlcjI1NzUzMDQ4","avatar_url":"https://avatars3.githubusercontent.com/u/25753048?v=4","gravatar_id":"","url":"https://api.github.com/users/teddyrendahl","html_url":"https://github.com/teddyrendahl","followers_url":"https://api.github.com/users/teddyrendahl/followers","following_url":"https://api.github.com/users/teddyrendahl/following{/other_user}","gists_url":"https://api.github.com/users/teddyrendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyrendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyrendahl/subscriptions","organizations_url":"https://api.github.com/users/teddyrendahl/orgs","repos_url":"https://api.github.com/users/teddyrendahl/repos","events_url":"https://api.github.com/users/teddyrendahl/events{/privacy}","received_events_url":"https://api.github.com/users/teddyrendahl/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"teddyrendahl"}}