{"action":"created","comment":{"url":"https://api.github.com/repos/Uninett/nav/pulls/comments/212233593","pull_request_review_id":148818784,"id":212233593,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjIzMzU5Mw==","diff_hunk":"@@ -27,14 +27,15 @@\n from django.core import exceptions\n from django.db.models import Q\n from django.utils import six\n+\n try:\n-    # Django < 1.9\n-    from django.db.models import get_models\n-except ImportError:\n     # Django >= 1.8\n     from django.apps import apps\n     get_models = apps.get_models\n     del apps\n+except ImportError:\n+    # Django < 1.9","path":"python/nav/models/fields.py","position":14,"original_position":14,"commit_id":"309019abcf100f0e03b328763153a21470794cd0","original_commit_id":"a2102e8d790495c006414dae89287b095a801f25","user":{"login":"hmpf","id":11956096,"node_id":"MDQ6VXNlcjExOTU2MDk2","avatar_url":"https://avatars1.githubusercontent.com/u/11956096?v=4","gravatar_id":"","url":"https://api.github.com/users/hmpf","html_url":"https://github.com/hmpf","followers_url":"https://api.github.com/users/hmpf/followers","following_url":"https://api.github.com/users/hmpf/following{/other_user}","gists_url":"https://api.github.com/users/hmpf/gists{/gist_id}","starred_url":"https://api.github.com/users/hmpf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmpf/subscriptions","organizations_url":"https://api.github.com/users/hmpf/orgs","repos_url":"https://api.github.com/users/hmpf/repos","events_url":"https://api.github.com/users/hmpf/events{/privacy}","received_events_url":"https://api.github.com/users/hmpf/received_events","type":"User","site_admin":false},"body":"1.8 is the first version where the new method works, and the last method where the old method works :)","created_at":"2018-08-23T09:03:16Z","updated_at":"2018-08-23T09:03:16Z","html_url":"https://github.com/Uninett/nav/pull/1752#discussion_r212233593","pull_request_url":"https://api.github.com/repos/Uninett/nav/pulls/1752","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Uninett/nav/pulls/comments/212233593"},"html":{"href":"https://github.com/Uninett/nav/pull/1752#discussion_r212233593"},"pull_request":{"href":"https://api.github.com/repos/Uninett/nav/pulls/1752"}},"in_reply_to_id":212216875},"pull_request":{"url":"https://api.github.com/repos/Uninett/nav/pulls/1752","id":206617726,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NjE3NzI2","html_url":"https://github.com/Uninett/nav/pull/1752","diff_url":"https://github.com/Uninett/nav/pull/1752.diff","patch_url":"https://github.com/Uninett/nav/pull/1752.patch","issue_url":"https://api.github.com/repos/Uninett/nav/issues/1752","number":1752,"state":"open","locked":false,"title":"No warnings for Django 1.8","user":{"login":"hmpf","id":11956096,"node_id":"MDQ6VXNlcjExOTU2MDk2","avatar_url":"https://avatars1.githubusercontent.com/u/11956096?v=4","gravatar_id":"","url":"https://api.github.com/users/hmpf","html_url":"https://github.com/hmpf","followers_url":"https://api.github.com/users/hmpf/followers","following_url":"https://api.github.com/users/hmpf/following{/other_user}","gists_url":"https://api.github.com/users/hmpf/gists{/gist_id}","starred_url":"https://api.github.com/users/hmpf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmpf/subscriptions","organizations_url":"https://api.github.com/users/hmpf/orgs","repos_url":"https://api.github.com/users/hmpf/repos","events_url":"https://api.github.com/users/hmpf/events{/privacy}","received_events_url":"https://api.github.com/users/hmpf/received_events","type":"User","site_admin":false},"body":"This PR gets rid of the remaining warnings for running NAV on Django 1.8, in code that we control.","created_at":"2018-08-07T08:25:47Z","updated_at":"2018-08-23T09:03:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d9807d5e0368e23706fa0c5696f12893e518047","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Uninett/nav/pulls/1752/commits","review_comments_url":"https://api.github.com/repos/Uninett/nav/pulls/1752/comments","review_comment_url":"https://api.github.com/repos/Uninett/nav/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Uninett/nav/issues/1752/comments","statuses_url":"https://api.github.com/repos/Uninett/nav/statuses/309019abcf100f0e03b328763153a21470794cd0","head":{"label":"hmpf:no-warnings-django18","ref":"no-warnings-django18","sha":"309019abcf100f0e03b328763153a21470794cd0","user":{"login":"hmpf","id":11956096,"node_id":"MDQ6VXNlcjExOTU2MDk2","avatar_url":"https://avatars1.githubusercontent.com/u/11956096?v=4","gravatar_id":"","url":"https://api.github.com/users/hmpf","html_url":"https://github.com/hmpf","followers_url":"https://api.github.com/users/hmpf/followers","following_url":"https://api.github.com/users/hmpf/following{/other_user}","gists_url":"https://api.github.com/users/hmpf/gists{/gist_id}","starred_url":"https://api.github.com/users/hmpf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmpf/subscriptions","organizations_url":"https://api.github.com/users/hmpf/orgs","repos_url":"https://api.github.com/users/hmpf/repos","events_url":"https://api.github.com/users/hmpf/events{/privacy}","received_events_url":"https://api.github.com/users/hmpf/received_events","type":"User","site_admin":false},"repo":{"id":79339015,"node_id":"MDEwOlJlcG9zaXRvcnk3OTMzOTAxNQ==","name":"nav","full_name":"hmpf/nav","owner":{"login":"hmpf","id":11956096,"node_id":"MDQ6VXNlcjExOTU2MDk2","avatar_url":"https://avatars1.githubusercontent.com/u/11956096?v=4","gravatar_id":"","url":"https://api.github.com/users/hmpf","html_url":"https://github.com/hmpf","followers_url":"https://api.github.com/users/hmpf/followers","following_url":"https://api.github.com/users/hmpf/following{/other_user}","gists_url":"https://api.github.com/users/hmpf/gists{/gist_id}","starred_url":"https://api.github.com/users/hmpf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmpf/subscriptions","organizations_url":"https://api.github.com/users/hmpf/orgs","repos_url":"https://api.github.com/users/hmpf/repos","events_url":"https://api.github.com/users/hmpf/events{/privacy}","received_events_url":"https://api.github.com/users/hmpf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hmpf/nav","description":"Network Administration Visualized","fork":true,"url":"https://api.github.com/repos/hmpf/nav","forks_url":"https://api.github.com/repos/hmpf/nav/forks","keys_url":"https://api.github.com/repos/hmpf/nav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmpf/nav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmpf/nav/teams","hooks_url":"https://api.github.com/repos/hmpf/nav/hooks","issue_events_url":"https://api.github.com/repos/hmpf/nav/issues/events{/number}","events_url":"https://api.github.com/repos/hmpf/nav/events","assignees_url":"https://api.github.com/repos/hmpf/nav/assignees{/user}","branches_url":"https://api.github.com/repos/hmpf/nav/branches{/branch}","tags_url":"https://api.github.com/repos/hmpf/nav/tags","blobs_url":"https://api.github.com/repos/hmpf/nav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmpf/nav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmpf/nav/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmpf/nav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmpf/nav/statuses/{sha}","languages_url":"https://api.github.com/repos/hmpf/nav/languages","stargazers_url":"https://api.github.com/repos/hmpf/nav/stargazers","contributors_url":"https://api.github.com/repos/hmpf/nav/contributors","subscribers_url":"https://api.github.com/repos/hmpf/nav/subscribers","subscription_url":"https://api.github.com/repos/hmpf/nav/subscription","commits_url":"https://api.github.com/repos/hmpf/nav/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmpf/nav/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmpf/nav/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmpf/nav/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmpf/nav/contents/{+path}","compare_url":"https://api.github.com/repos/hmpf/nav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmpf/nav/merges","archive_url":"https://api.github.com/repos/hmpf/nav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmpf/nav/downloads","issues_url":"https://api.github.com/repos/hmpf/nav/issues{/number}","pulls_url":"https://api.github.com/repos/hmpf/nav/pulls{/number}","milestones_url":"https://api.github.com/repos/hmpf/nav/milestones{/number}","notifications_url":"https://api.github.com/repos/hmpf/nav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmpf/nav/labels{/name}","releases_url":"https://api.github.com/repos/hmpf/nav/releases{/id}","deployments_url":"https://api.github.com/repos/hmpf/nav/deployments","created_at":"2017-01-18T12:43:13Z","updated_at":"2018-08-06T10:06:15Z","pushed_at":"2018-08-20T09:07:57Z","git_url":"git://github.com/hmpf/nav.git","ssh_url":"git@github.com:hmpf/nav.git","clone_url":"https://github.com/hmpf/nav.git","svn_url":"https://github.com/hmpf/nav","homepage":null,"size":104076,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Uninett:master","ref":"master","sha":"d13091460003ec29a6cf115c3e1193ea6f72a2bd","user":{"login":"Uninett","id":778970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODk3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/778970?v=4","gravatar_id":"","url":"https://api.github.com/users/Uninett","html_url":"https://github.com/Uninett","followers_url":"https://api.github.com/users/Uninett/followers","following_url":"https://api.github.com/users/Uninett/following{/other_user}","gists_url":"https://api.github.com/users/Uninett/gists{/gist_id}","starred_url":"https://api.github.com/users/Uninett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Uninett/subscriptions","organizations_url":"https://api.github.com/users/Uninett/orgs","repos_url":"https://api.github.com/users/Uninett/repos","events_url":"https://api.github.com/users/Uninett/events{/privacy}","received_events_url":"https://api.github.com/users/Uninett/received_events","type":"Organization","site_admin":false},"repo":{"id":79214421,"node_id":"MDEwOlJlcG9zaXRvcnk3OTIxNDQyMQ==","name":"nav","full_name":"Uninett/nav","owner":{"login":"Uninett","id":778970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3ODk3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/778970?v=4","gravatar_id":"","url":"https://api.github.com/users/Uninett","html_url":"https://github.com/Uninett","followers_url":"https://api.github.com/users/Uninett/followers","following_url":"https://api.github.com/users/Uninett/following{/other_user}","gists_url":"https://api.github.com/users/Uninett/gists{/gist_id}","starred_url":"https://api.github.com/users/Uninett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Uninett/subscriptions","organizations_url":"https://api.github.com/users/Uninett/orgs","repos_url":"https://api.github.com/users/Uninett/repos","events_url":"https://api.github.com/users/Uninett/events{/privacy}","received_events_url":"https://api.github.com/users/Uninett/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Uninett/nav","description":"Network Administration Visualized","fork":false,"url":"https://api.github.com/repos/Uninett/nav","forks_url":"https://api.github.com/repos/Uninett/nav/forks","keys_url":"https://api.github.com/repos/Uninett/nav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Uninett/nav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Uninett/nav/teams","hooks_url":"https://api.github.com/repos/Uninett/nav/hooks","issue_events_url":"https://api.github.com/repos/Uninett/nav/issues/events{/number}","events_url":"https://api.github.com/repos/Uninett/nav/events","assignees_url":"https://api.github.com/repos/Uninett/nav/assignees{/user}","branches_url":"https://api.github.com/repos/Uninett/nav/branches{/branch}","tags_url":"https://api.github.com/repos/Uninett/nav/tags","blobs_url":"https://api.github.com/repos/Uninett/nav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Uninett/nav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Uninett/nav/git/refs{/sha}","trees_url":"https://api.github.com/repos/Uninett/nav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Uninett/nav/statuses/{sha}","languages_url":"https://api.github.com/repos/Uninett/nav/languages","stargazers_url":"https://api.github.com/repos/Uninett/nav/stargazers","contributors_url":"https://api.github.com/repos/Uninett/nav/contributors","subscribers_url":"https://api.github.com/repos/Uninett/nav/subscribers","subscription_url":"https://api.github.com/repos/Uninett/nav/subscription","commits_url":"https://api.github.com/repos/Uninett/nav/commits{/sha}","git_commits_url":"https://api.github.com/repos/Uninett/nav/git/commits{/sha}","comments_url":"https://api.github.com/repos/Uninett/nav/comments{/number}","issue_comment_url":"https://api.github.com/repos/Uninett/nav/issues/comments{/number}","contents_url":"https://api.github.com/repos/Uninett/nav/contents/{+path}","compare_url":"https://api.github.com/repos/Uninett/nav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Uninett/nav/merges","archive_url":"https://api.github.com/repos/Uninett/nav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Uninett/nav/downloads","issues_url":"https://api.github.com/repos/Uninett/nav/issues{/number}","pulls_url":"https://api.github.com/repos/Uninett/nav/pulls{/number}","milestones_url":"https://api.github.com/repos/Uninett/nav/milestones{/number}","notifications_url":"https://api.github.com/repos/Uninett/nav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Uninett/nav/labels{/name}","releases_url":"https://api.github.com/repos/Uninett/nav/releases{/id}","deployments_url":"https://api.github.com/repos/Uninett/nav/deployments","created_at":"2017-01-17T10:05:09Z","updated_at":"2018-08-10T11:20:47Z","pushed_at":"2018-08-20T09:09:54Z","git_url":"git://github.com/Uninett/nav.git","ssh_url":"git@github.com:Uninett/nav.git","clone_url":"https://github.com/Uninett/nav.git","svn_url":"https://github.com/Uninett/nav","homepage":null,"size":103987,"stargazers_count":34,"watchers_count":34,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":107,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":16,"open_issues":107,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Uninett/nav/pulls/1752"},"html":{"href":"https://github.com/Uninett/nav/pull/1752"},"issue":{"href":"https://api.github.com/repos/Uninett/nav/issues/1752"},"comments":{"href":"https://api.github.com/repos/Uninett/nav/issues/1752/comments"},"review_comments":{"href":"https://api.github.com/repos/Uninett/nav/pulls/1752/comments"},"review_comment":{"href":"https://api.github.com/repos/Uninett/nav/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Uninett/nav/pulls/1752/commits"},"statuses":{"href":"https://api.github.com/repos/Uninett/nav/statuses/309019abcf100f0e03b328763153a21470794cd0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hmpf"}}