{"action":"created","issue":{"url":"https://api.github.com/repos/bazelbuild/rules_docker/issues/403","repository_url":"https://api.github.com/repos/bazelbuild/rules_docker","labels_url":"https://api.github.com/repos/bazelbuild/rules_docker/issues/403/labels{/name}","comments_url":"https://api.github.com/repos/bazelbuild/rules_docker/issues/403/comments","events_url":"https://api.github.com/repos/bazelbuild/rules_docker/issues/403/events","html_url":"https://github.com/bazelbuild/rules_docker/pull/403","id":323223181,"number":403,"title":"Update rules_nodejs to 0.9.0 and fix node target","user":{"login":"nimerritt","id":2065955,"avatar_url":"https://avatars0.githubusercontent.com/u/2065955?v=4","gravatar_id":"","url":"https://api.github.com/users/nimerritt","html_url":"https://github.com/nimerritt","followers_url":"https://api.github.com/users/nimerritt/followers","following_url":"https://api.github.com/users/nimerritt/following{/other_user}","gists_url":"https://api.github.com/users/nimerritt/gists{/gist_id}","starred_url":"https://api.github.com/users/nimerritt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimerritt/subscriptions","organizations_url":"https://api.github.com/users/nimerritt/orgs","repos_url":"https://api.github.com/users/nimerritt/repos","events_url":"https://api.github.com/users/nimerritt/events{/privacy}","received_events_url":"https://api.github.com/users/nimerritt/received_events","type":"User","site_admin":false},"labels":[{"id":577265609,"url":"https://api.github.com/repos/bazelbuild/rules_docker/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-05-15T13:41:14Z","updated_at":"2018-05-17T06:51:50Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bazelbuild/rules_docker/pulls/403","html_url":"https://github.com/bazelbuild/rules_docker/pull/403","diff_url":"https://github.com/bazelbuild/rules_docker/pull/403.diff","patch_url":"https://github.com/bazelbuild/rules_docker/pull/403.patch"},"body":"This https://github.com/bazelbuild/rules_nodejs/pull/193/files#diff-09498dbadf45966909850dc8a47ebb13R30 will break this rule when it is released.\r\n\r\nThis isn't yet released with `rules_nodejs` but will be in the next release.\r\n@gregmagolan just aheads up."},"comment":{"url":"https://api.github.com/repos/bazelbuild/rules_docker/issues/comments/389763512","html_url":"https://github.com/bazelbuild/rules_docker/pull/403#issuecomment-389763512","issue_url":"https://api.github.com/repos/bazelbuild/rules_docker/issues/403","id":389763512,"user":{"login":"nimerritt","id":2065955,"avatar_url":"https://avatars0.githubusercontent.com/u/2065955?v=4","gravatar_id":"","url":"https://api.github.com/users/nimerritt","html_url":"https://github.com/nimerritt","followers_url":"https://api.github.com/users/nimerritt/followers","following_url":"https://api.github.com/users/nimerritt/following{/other_user}","gists_url":"https://api.github.com/users/nimerritt/gists{/gist_id}","starred_url":"https://api.github.com/users/nimerritt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimerritt/subscriptions","organizations_url":"https://api.github.com/users/nimerritt/orgs","repos_url":"https://api.github.com/users/nimerritt/repos","events_url":"https://api.github.com/users/nimerritt/events{/privacy}","received_events_url":"https://api.github.com/users/nimerritt/received_events","type":"User","site_admin":false},"created_at":"2018-05-17T06:51:50Z","updated_at":"2018-05-17T06:51:50Z","author_association":"NONE","body":"Inspecting the image built by the e2e test, `bazel build //testdata:nodejs_image` shows that the node binary isn't copied into the image any more. With the 0.9.0 changes the image looks like:\r\n```\r\n.\r\n└── app\r\n    └── testdata\r\n        ├── nodejs_image.binary -> /app/testdata/nodejs_image.binary.runfiles/io_bazel_rules_docker/testdata/nodejs_image.binary\r\n        └── nodejs_image.binary.runfiles\r\n            ├── io_bazel_rules_docker\r\n            │   ├── external -> /app/testdata/nodejs_image.binary.runfiles\r\n            │   └── testdata\r\n            │       ├── nodejs_image.binary\r\n            │       ├── nodejs_image.binary_bin\r\n            │       ├── nodejs_image.binary_bin.sh\r\n            │       ├── nodejs_image.binary_bin_loader.js\r\n            │       └── nodejs_image.js\r\n            ├── nodejs\r\n            │   ├── args.sh\r\n            │   └── bin\r\n            │       └── node\r\n            └── npm_deps\r\n                └── node_modules\r\n                    └── jsesc\r\n                        ├── LICENSE-MIT.txt\r\n                        ├── README.md\r\n                        ├── bin\r\n                        │   └── jsesc\r\n                        ├── jsesc.js\r\n                        ├── man\r\n                        │   └── jsesc.1\r\n                        └── package.json\r\n```\r\n\r\ncompared to the previously working image,\r\n\r\n```\r\n.\r\n└── app\r\n    └── testdata\r\n        ├── nodejs_image.binary -> /app/testdata/nodejs_image.binary.runfiles/io_bazel_rules_docker/testdata/nodejs_image.binary\r\n        └── nodejs_image.binary.runfiles\r\n            ├── io_bazel_rules_docker\r\n            │   ├── external -> /app/testdata/nodejs_image.binary.runfiles\r\n            │   └── testdata\r\n            │       ├── nodejs_image.binary\r\n            │       ├── nodejs_image.binary_bin\r\n            │       ├── nodejs_image.binary_bin.sh\r\n            │       ├── nodejs_image.binary_bin_loader.js\r\n            │       └── nodejs_image.js\r\n            ├── nodejs\r\n            │   └── repository_bin\r\n            │       ├── node\r\n            │       └── node_args.sh\r\n            └── npm_deps\r\n                └── node_modules\r\n                    └── jsesc\r\n                        ├── LICENSE-MIT.txt\r\n                        ├── README.md\r\n                        ├── bin\r\n                        │   └── jsesc\r\n                        ├── jsesc.js\r\n                        ├── man\r\n                        │   └── jsesc.1\r\n                        └── package.json\r\n```"}}
{"actor":{"display_login":"nimerritt"}}