{"action":"created","issue":{"url":"https://api.github.com/repos/mimblewimble/grin/issues/1944","repository_url":"https://api.github.com/repos/mimblewimble/grin","labels_url":"https://api.github.com/repos/mimblewimble/grin/issues/1944/labels{/name}","comments_url":"https://api.github.com/repos/mimblewimble/grin/issues/1944/comments","events_url":"https://api.github.com/repos/mimblewimble/grin/issues/1944/events","html_url":"https://github.com/mimblewimble/grin/pull/1944","id":378217445,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4OTczMzg3","number":1944,"title":"Fix capabilities","user":{"login":"antiochp","id":30642645,"node_id":"MDQ6VXNlcjMwNjQyNjQ1","avatar_url":"https://avatars2.githubusercontent.com/u/30642645?v=4","gravatar_id":"","url":"https://api.github.com/users/antiochp","html_url":"https://github.com/antiochp","followers_url":"https://api.github.com/users/antiochp/followers","following_url":"https://api.github.com/users/antiochp/following{/other_user}","gists_url":"https://api.github.com/users/antiochp/gists{/gist_id}","starred_url":"https://api.github.com/users/antiochp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiochp/subscriptions","organizations_url":"https://api.github.com/users/antiochp/orgs","repos_url":"https://api.github.com/users/antiochp/repos","events_url":"https://api.github.com/users/antiochp/events{/privacy}","received_events_url":"https://api.github.com/users/antiochp/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-07T10:00:06Z","updated_at":"2018-11-07T10:05:41Z","closed_at":"2018-11-07T10:00:43Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mimblewimble/grin/pulls/1944","html_url":"https://github.com/mimblewimble/grin/pull/1944","diff_url":"https://github.com/mimblewimble/grin/pull/1944.diff","patch_url":"https://github.com/mimblewimble/grin/pull/1944.patch"},"body":"So we cannot safely add a new `capability` (and enable it) as old nodes do not recognize this and will not successfully connect as peers.\r\n\r\nThis PR fixes this problem by not enabling the new capability by default.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mimblewimble/grin/issues/comments/436571459","html_url":"https://github.com/mimblewimble/grin/pull/1944#issuecomment-436571459","issue_url":"https://api.github.com/repos/mimblewimble/grin/issues/1944","id":436571459,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjU3MTQ1OQ==","user":{"login":"antiochp","id":30642645,"node_id":"MDQ6VXNlcjMwNjQyNjQ1","avatar_url":"https://avatars2.githubusercontent.com/u/30642645?v=4","gravatar_id":"","url":"https://api.github.com/users/antiochp","html_url":"https://github.com/antiochp","followers_url":"https://api.github.com/users/antiochp/followers","following_url":"https://api.github.com/users/antiochp/following{/other_user}","gists_url":"https://api.github.com/users/antiochp/gists{/gist_id}","starred_url":"https://api.github.com/users/antiochp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiochp/subscriptions","organizations_url":"https://api.github.com/users/antiochp/orgs","repos_url":"https://api.github.com/users/antiochp/repos","events_url":"https://api.github.com/users/antiochp/events{/privacy}","received_events_url":"https://api.github.com/users/antiochp/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T10:05:41Z","updated_at":"2018-11-07T10:05:41Z","author_association":"MEMBER","body":"I think there is an easy fix here to handle this.\r\n\r\nFrom the bitflags docs - \r\n\r\nhttps://docs.rs/bitflags/1.0.4/bitflags/index.html#methods-1\r\n\r\n> `from_bits`: convert from underlying bit representation, unless that representation contains bits that do not correspond to a flag\r\n> `from_bits_truncate`: convert from underlying bit representation, dropping any bits that do not correspond to flags"}}
{"actor":{"display_login":"antiochp"}}