{"action":"created","comment":{"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/pulls/comments/178376359","pull_request_review_id":108432147,"id":178376359,"diff_hunk":"@@ -1,7 +1,11 @@\n-<h1>Image Sharing Project</h1>\n+<h1 id='header'>Image Sharing Project</h1>\n <h2>by <%= @name %></h2>\n \n-<%= image_tag 'http://media.getty.edu/museum/images/web/enlarge/00103401.jpg' , size:'50%xauto' %> <br>\n+<% @image_list.each do | image | %>\n+    <div class=\"saved-image\">\n+      <%= image_tag image.url , height: '400' , width: '400' %>\n+    </div>\n+<% end unless Image.first.new_record? rescue nil %>","path":"app/views/application/home.html.erb","position":10,"original_position":10,"commit_id":"ec8b4802263052c0d39cd5f646ee0870516f7958","original_commit_id":"ec8b4802263052c0d39cd5f646ee0870516f7958","user":{"login":"pololee","id":3411834,"avatar_url":"https://avatars0.githubusercontent.com/u/3411834?v=4","gravatar_id":"","url":"https://api.github.com/users/pololee","html_url":"https://github.com/pololee","followers_url":"https://api.github.com/users/pololee/followers","following_url":"https://api.github.com/users/pololee/following{/other_user}","gists_url":"https://api.github.com/users/pololee/gists{/gist_id}","starred_url":"https://api.github.com/users/pololee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pololee/subscriptions","organizations_url":"https://api.github.com/users/pololee/orgs","repos_url":"https://api.github.com/users/pololee/repos","events_url":"https://api.github.com/users/pololee/events{/privacy}","received_events_url":"https://api.github.com/users/pololee/received_events","type":"User","site_admin":false},"body":"Why do we need `unless Image.first.new_record?` and `rescue nil`?\r\n\r\n1. The logic is unnecessary. I don't see anything could blow up here. If `@image_list` is empty.\r\n\r\n2. Even if there would be something that may blow up, handling exception inside view is not a good idea.","created_at":"2018-03-30T20:50:49Z","updated_at":"2018-03-30T20:58:26Z","html_url":"https://github.com/AppFolioOnboarding/image-sharer-AgentCyrusJr/pull/14#discussion_r178376359","pull_request_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/pulls/14","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/pulls/comments/178376359"},"html":{"href":"https://github.com/AppFolioOnboarding/image-sharer-AgentCyrusJr/pull/14#discussion_r178376359"},"pull_request":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/pulls/14","id":178614443,"html_url":"https://github.com/AppFolioOnboarding/image-sharer-AgentCyrusJr/pull/14","diff_url":"https://github.com/AppFolioOnboarding/image-sharer-AgentCyrusJr/pull/14.diff","patch_url":"https://github.com/AppFolioOnboarding/image-sharer-AgentCyrusJr/pull/14.patch","issue_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/issues/14","number":14,"state":"open","locked":false,"title":"cp - show saved images on index page","user":{"login":"AgentCyrusJr","id":17020264,"avatar_url":"https://avatars2.githubusercontent.com/u/17020264?v=4","gravatar_id":"","url":"https://api.github.com/users/AgentCyrusJr","html_url":"https://github.com/AgentCyrusJr","followers_url":"https://api.github.com/users/AgentCyrusJr/followers","following_url":"https://api.github.com/users/AgentCyrusJr/following{/other_user}","gists_url":"https://api.github.com/users/AgentCyrusJr/gists{/gist_id}","starred_url":"https://api.github.com/users/AgentCyrusJr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgentCyrusJr/subscriptions","organizations_url":"https://api.github.com/users/AgentCyrusJr/orgs","repos_url":"https://api.github.com/users/AgentCyrusJr/repos","events_url":"https://api.github.com/users/AgentCyrusJr/events{/privacy}","received_events_url":"https://api.github.com/users/AgentCyrusJr/received_events","type":"User","site_admin":false},"body":"Closes #2 \r\n\r\n---\r\n\r\nThe following is a checklist to remind you of the steps to take when opening a\r\nnew PR. The horizontal line above and everything below can be removed from the\r\npull request description.\r\n\r\n- [ ] I have replaced `X` above with the associated issue number.\r\n- [ ] I have changed the issue's label to \"pull request\".\r\n- [ ] I have assigned the designated reviewer to this PR.\r\n- [ ] I have set the appropriate label on this PR.\r\n- [ ] I have written clear commit messages ([ref](http://chris.beams.io/posts/git-commit/)).\r\n\r\nIf needed, please review the document on the\r\n[Image Sharing Project](https://sites.google.com/a/appfolio.com/eng/new-hire-resources/engineering-academy/ropes/image-sharing-project)\r\nfor information on how labels should be used.\r\n","created_at":"2018-03-30T18:50:45Z","updated_at":"2018-03-30T20:58:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5dc5296a72dc80ff9a7cd87e237f8209c943dfa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/pulls/14/commits","review_comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/pulls/14/comments","review_comment_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/issues/14/comments","statuses_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/statuses/ec8b4802263052c0d39cd5f646ee0870516f7958","head":{"label":"AppFolioOnboarding:image_index","ref":"image_index","sha":"ec8b4802263052c0d39cd5f646ee0870516f7958","user":{"login":"AppFolioOnboarding","id":16782391,"avatar_url":"https://avatars1.githubusercontent.com/u/16782391?v=4","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"repo":{"id":127020253,"name":"image-sharer-AgentCyrusJr","full_name":"AppFolioOnboarding/image-sharer-AgentCyrusJr","owner":{"login":"AppFolioOnboarding","id":16782391,"avatar_url":"https://avatars1.githubusercontent.com/u/16782391?v=4","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AppFolioOnboarding/image-sharer-AgentCyrusJr","description":"image-sharer-AgentCyrusJr created by GitHub Classroom","fork":false,"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr","forks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/forks","keys_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/teams","hooks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/hooks","issue_events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/issues/events{/number}","events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/events","assignees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/assignees{/user}","branches_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/branches{/branch}","tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/tags","blobs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/statuses/{sha}","languages_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/languages","stargazers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/stargazers","contributors_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/contributors","subscribers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/subscribers","subscription_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/subscription","commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/contents/{+path}","compare_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/merges","archive_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/downloads","issues_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/issues{/number}","pulls_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/pulls{/number}","milestones_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/milestones{/number}","notifications_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/labels{/name}","releases_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/releases{/id}","deployments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/deployments","created_at":"2018-03-27T17:08:03Z","updated_at":"2018-03-30T03:48:38Z","pushed_at":"2018-03-30T18:50:45Z","git_url":"git://github.com/AppFolioOnboarding/image-sharer-AgentCyrusJr.git","ssh_url":"git@github.com:AppFolioOnboarding/image-sharer-AgentCyrusJr.git","clone_url":"https://github.com/AppFolioOnboarding/image-sharer-AgentCyrusJr.git","svn_url":"https://github.com/AppFolioOnboarding/image-sharer-AgentCyrusJr","homepage":null,"size":234,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"AppFolioOnboarding:master","ref":"master","sha":"d77e697e9c635ccbea57587620b05b9a48402893","user":{"login":"AppFolioOnboarding","id":16782391,"avatar_url":"https://avatars1.githubusercontent.com/u/16782391?v=4","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"repo":{"id":127020253,"name":"image-sharer-AgentCyrusJr","full_name":"AppFolioOnboarding/image-sharer-AgentCyrusJr","owner":{"login":"AppFolioOnboarding","id":16782391,"avatar_url":"https://avatars1.githubusercontent.com/u/16782391?v=4","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AppFolioOnboarding/image-sharer-AgentCyrusJr","description":"image-sharer-AgentCyrusJr created by GitHub Classroom","fork":false,"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr","forks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/forks","keys_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/teams","hooks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/hooks","issue_events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/issues/events{/number}","events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/events","assignees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/assignees{/user}","branches_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/branches{/branch}","tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/tags","blobs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/statuses/{sha}","languages_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/languages","stargazers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/stargazers","contributors_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/contributors","subscribers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/subscribers","subscription_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/subscription","commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/contents/{+path}","compare_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/merges","archive_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/downloads","issues_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/issues{/number}","pulls_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/pulls{/number}","milestones_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/milestones{/number}","notifications_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/labels{/name}","releases_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/releases{/id}","deployments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/deployments","created_at":"2018-03-27T17:08:03Z","updated_at":"2018-03-30T03:48:38Z","pushed_at":"2018-03-30T18:50:45Z","git_url":"git://github.com/AppFolioOnboarding/image-sharer-AgentCyrusJr.git","ssh_url":"git@github.com:AppFolioOnboarding/image-sharer-AgentCyrusJr.git","clone_url":"https://github.com/AppFolioOnboarding/image-sharer-AgentCyrusJr.git","svn_url":"https://github.com/AppFolioOnboarding/image-sharer-AgentCyrusJr","homepage":null,"size":234,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/pulls/14"},"html":{"href":"https://github.com/AppFolioOnboarding/image-sharer-AgentCyrusJr/pull/14"},"issue":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/issues/14"},"comments":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-AgentCyrusJr/statuses/ec8b4802263052c0d39cd5f646ee0870516f7958"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pololee"}}