{"action":"created","comment":{"url":"https://api.github.com/repos/essentiaone/HDWallet/pulls/comments/202331228","pull_request_review_id":137012731,"id":202331228,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjMzMTIyOA==","diff_hunk":"@@ -24,21 +24,26 @@ public final class ECDSA {\n         var pKey = secp256k1_pubkey()\n         \n         var result = secp256k1_ec_pubkey_create(context, &pKey, prvKey)\n-        if (result != 1) {\n+        if result != 1 {","path":"HDWalletKit/Core/Crypto/Encryption/ECDSA.swift","position":5,"original_position":5,"commit_id":"345bd7f14ad3fd6dfc27cb80bef0f06e65e3b3a0","original_commit_id":"345bd7f14ad3fd6dfc27cb80bef0f06e65e3b3a0","user":{"login":"kozlov-oleksandr","id":18533903,"node_id":"MDQ6VXNlcjE4NTMzOTAz","avatar_url":"https://avatars3.githubusercontent.com/u/18533903?v=4","gravatar_id":"","url":"https://api.github.com/users/kozlov-oleksandr","html_url":"https://github.com/kozlov-oleksandr","followers_url":"https://api.github.com/users/kozlov-oleksandr/followers","following_url":"https://api.github.com/users/kozlov-oleksandr/following{/other_user}","gists_url":"https://api.github.com/users/kozlov-oleksandr/gists{/gist_id}","starred_url":"https://api.github.com/users/kozlov-oleksandr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kozlov-oleksandr/subscriptions","organizations_url":"https://api.github.com/users/kozlov-oleksandr/orgs","repos_url":"https://api.github.com/users/kozlov-oleksandr/repos","events_url":"https://api.github.com/users/kozlov-oleksandr/events{/privacy}","received_events_url":"https://api.github.com/users/kozlov-oleksandr/received_events","type":"User","site_admin":false},"body":"@impul 1? add name for this magic number","created_at":"2018-07-13T12:18:31Z","updated_at":"2018-07-13T12:37:20Z","html_url":"https://github.com/essentiaone/HDWallet/pull/5#discussion_r202331228","pull_request_url":"https://api.github.com/repos/essentiaone/HDWallet/pulls/5","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/essentiaone/HDWallet/pulls/comments/202331228"},"html":{"href":"https://github.com/essentiaone/HDWallet/pull/5#discussion_r202331228"},"pull_request":{"href":"https://api.github.com/repos/essentiaone/HDWallet/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/essentiaone/HDWallet/pulls/5","id":201258965,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMjU4OTY1","html_url":"https://github.com/essentiaone/HDWallet/pull/5","diff_url":"https://github.com/essentiaone/HDWallet/pull/5.diff","patch_url":"https://github.com/essentiaone/HDWallet/pull/5.patch","issue_url":"https://api.github.com/repos/essentiaone/HDWallet/issues/5","number":5,"state":"open","locked":false,"title":"MB-22: Sign ether transaction","user":{"login":"impul","id":15803807,"node_id":"MDQ6VXNlcjE1ODAzODA3","avatar_url":"https://avatars1.githubusercontent.com/u/15803807?v=4","gravatar_id":"","url":"https://api.github.com/users/impul","html_url":"https://github.com/impul","followers_url":"https://api.github.com/users/impul/followers","following_url":"https://api.github.com/users/impul/following{/other_user}","gists_url":"https://api.github.com/users/impul/gists{/gist_id}","starred_url":"https://api.github.com/users/impul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/impul/subscriptions","organizations_url":"https://api.github.com/users/impul/orgs","repos_url":"https://api.github.com/users/impul/repos","events_url":"https://api.github.com/users/impul/events{/privacy}","received_events_url":"https://api.github.com/users/impul/received_events","type":"User","site_admin":false},"body":"### Jira references\r\n- Ticket (issue) — https://essentiatechnologies.atlassian.net/browse/MB-22\r\n### Description\r\nAdd ability to sign `Ethereum` transaction to `Wallet`. \r\n### Implemented\r\nAdd raw transaction model:\r\n```Swift\r\npublic struct RawTransaction: Codable {\r\n    /// Amount value to send, unit is in Wei\r\n    public let value: Wei\r\n    /// Address to send ether to\r\n    public let to: Address\r\n    /// Gas price for this transaction, unit is in Wei\r\n    /// you need to convert it if it is specified in GWei\r\n    /// use Converter.toWei method to convert GWei value to Wei\r\n    public let gasPrice: Int\r\n    /// Gas limit for this transaction\r\n    /// Total amount of gas will be (gas price * gas limit)\r\n    public let gasLimit: Int\r\n    /// Nonce of your address\r\n    public let nonce: Int\r\n    /// Data to attach to this transaction\r\n    public let data: Data\r\n}\r\n```\r\nAdd method in sign raw transaction:\r\n```Swift\r\npublic func sign(rawTransaction: RawTransaction) throws -> String \r\n```\r\n### References\r\n- Sign transaction — https://github.com/D-Technologies/EthereumKit/blob/master/Documentation/GettingStarted.md","created_at":"2018-07-13T11:04:41Z","updated_at":"2018-07-13T12:37:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f819ca96b16e7cd3278e951d767fce5b1ade933","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/essentiaone/HDWallet/pulls/5/commits","review_comments_url":"https://api.github.com/repos/essentiaone/HDWallet/pulls/5/comments","review_comment_url":"https://api.github.com/repos/essentiaone/HDWallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/essentiaone/HDWallet/issues/5/comments","statuses_url":"https://api.github.com/repos/essentiaone/HDWallet/statuses/345bd7f14ad3fd6dfc27cb80bef0f06e65e3b3a0","head":{"label":"essentiaone:feature/sign-ether-transaction-MB-22","ref":"feature/sign-ether-transaction-MB-22","sha":"345bd7f14ad3fd6dfc27cb80bef0f06e65e3b3a0","user":{"login":"essentiaone","id":32127946,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTI3OTQ2","avatar_url":"https://avatars1.githubusercontent.com/u/32127946?v=4","gravatar_id":"","url":"https://api.github.com/users/essentiaone","html_url":"https://github.com/essentiaone","followers_url":"https://api.github.com/users/essentiaone/followers","following_url":"https://api.github.com/users/essentiaone/following{/other_user}","gists_url":"https://api.github.com/users/essentiaone/gists{/gist_id}","starred_url":"https://api.github.com/users/essentiaone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/essentiaone/subscriptions","organizations_url":"https://api.github.com/users/essentiaone/orgs","repos_url":"https://api.github.com/users/essentiaone/repos","events_url":"https://api.github.com/users/essentiaone/events{/privacy}","received_events_url":"https://api.github.com/users/essentiaone/received_events","type":"Organization","site_admin":false},"repo":{"id":138898540,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg4OTg1NDA=","name":"HDWallet","full_name":"essentiaone/HDWallet","owner":{"login":"essentiaone","id":32127946,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTI3OTQ2","avatar_url":"https://avatars1.githubusercontent.com/u/32127946?v=4","gravatar_id":"","url":"https://api.github.com/users/essentiaone","html_url":"https://github.com/essentiaone","followers_url":"https://api.github.com/users/essentiaone/followers","following_url":"https://api.github.com/users/essentiaone/following{/other_user}","gists_url":"https://api.github.com/users/essentiaone/gists{/gist_id}","starred_url":"https://api.github.com/users/essentiaone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/essentiaone/subscriptions","organizations_url":"https://api.github.com/users/essentiaone/orgs","repos_url":"https://api.github.com/users/essentiaone/repos","events_url":"https://api.github.com/users/essentiaone/events{/privacy}","received_events_url":"https://api.github.com/users/essentiaone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/essentiaone/HDWallet","description":null,"fork":false,"url":"https://api.github.com/repos/essentiaone/HDWallet","forks_url":"https://api.github.com/repos/essentiaone/HDWallet/forks","keys_url":"https://api.github.com/repos/essentiaone/HDWallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/essentiaone/HDWallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/essentiaone/HDWallet/teams","hooks_url":"https://api.github.com/repos/essentiaone/HDWallet/hooks","issue_events_url":"https://api.github.com/repos/essentiaone/HDWallet/issues/events{/number}","events_url":"https://api.github.com/repos/essentiaone/HDWallet/events","assignees_url":"https://api.github.com/repos/essentiaone/HDWallet/assignees{/user}","branches_url":"https://api.github.com/repos/essentiaone/HDWallet/branches{/branch}","tags_url":"https://api.github.com/repos/essentiaone/HDWallet/tags","blobs_url":"https://api.github.com/repos/essentiaone/HDWallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/essentiaone/HDWallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/essentiaone/HDWallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/essentiaone/HDWallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/essentiaone/HDWallet/statuses/{sha}","languages_url":"https://api.github.com/repos/essentiaone/HDWallet/languages","stargazers_url":"https://api.github.com/repos/essentiaone/HDWallet/stargazers","contributors_url":"https://api.github.com/repos/essentiaone/HDWallet/contributors","subscribers_url":"https://api.github.com/repos/essentiaone/HDWallet/subscribers","subscription_url":"https://api.github.com/repos/essentiaone/HDWallet/subscription","commits_url":"https://api.github.com/repos/essentiaone/HDWallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/essentiaone/HDWallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/essentiaone/HDWallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/essentiaone/HDWallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/essentiaone/HDWallet/contents/{+path}","compare_url":"https://api.github.com/repos/essentiaone/HDWallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/essentiaone/HDWallet/merges","archive_url":"https://api.github.com/repos/essentiaone/HDWallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/essentiaone/HDWallet/downloads","issues_url":"https://api.github.com/repos/essentiaone/HDWallet/issues{/number}","pulls_url":"https://api.github.com/repos/essentiaone/HDWallet/pulls{/number}","milestones_url":"https://api.github.com/repos/essentiaone/HDWallet/milestones{/number}","notifications_url":"https://api.github.com/repos/essentiaone/HDWallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/essentiaone/HDWallet/labels{/name}","releases_url":"https://api.github.com/repos/essentiaone/HDWallet/releases{/id}","deployments_url":"https://api.github.com/repos/essentiaone/HDWallet/deployments","created_at":"2018-06-27T15:13:05Z","updated_at":"2018-07-12T17:25:59Z","pushed_at":"2018-07-13T11:04:42Z","git_url":"git://github.com/essentiaone/HDWallet.git","ssh_url":"git@github.com:essentiaone/HDWallet.git","clone_url":"https://github.com/essentiaone/HDWallet.git","svn_url":"https://github.com/essentiaone/HDWallet","homepage":null,"size":11272,"stargazers_count":2,"watchers_count":2,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":2,"default_branch":"develop"}},"base":{"label":"essentiaone:develop","ref":"develop","sha":"64ea9f30233d0f218b40b2445e78373efb58191d","user":{"login":"essentiaone","id":32127946,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTI3OTQ2","avatar_url":"https://avatars1.githubusercontent.com/u/32127946?v=4","gravatar_id":"","url":"https://api.github.com/users/essentiaone","html_url":"https://github.com/essentiaone","followers_url":"https://api.github.com/users/essentiaone/followers","following_url":"https://api.github.com/users/essentiaone/following{/other_user}","gists_url":"https://api.github.com/users/essentiaone/gists{/gist_id}","starred_url":"https://api.github.com/users/essentiaone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/essentiaone/subscriptions","organizations_url":"https://api.github.com/users/essentiaone/orgs","repos_url":"https://api.github.com/users/essentiaone/repos","events_url":"https://api.github.com/users/essentiaone/events{/privacy}","received_events_url":"https://api.github.com/users/essentiaone/received_events","type":"Organization","site_admin":false},"repo":{"id":138898540,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg4OTg1NDA=","name":"HDWallet","full_name":"essentiaone/HDWallet","owner":{"login":"essentiaone","id":32127946,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTI3OTQ2","avatar_url":"https://avatars1.githubusercontent.com/u/32127946?v=4","gravatar_id":"","url":"https://api.github.com/users/essentiaone","html_url":"https://github.com/essentiaone","followers_url":"https://api.github.com/users/essentiaone/followers","following_url":"https://api.github.com/users/essentiaone/following{/other_user}","gists_url":"https://api.github.com/users/essentiaone/gists{/gist_id}","starred_url":"https://api.github.com/users/essentiaone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/essentiaone/subscriptions","organizations_url":"https://api.github.com/users/essentiaone/orgs","repos_url":"https://api.github.com/users/essentiaone/repos","events_url":"https://api.github.com/users/essentiaone/events{/privacy}","received_events_url":"https://api.github.com/users/essentiaone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/essentiaone/HDWallet","description":null,"fork":false,"url":"https://api.github.com/repos/essentiaone/HDWallet","forks_url":"https://api.github.com/repos/essentiaone/HDWallet/forks","keys_url":"https://api.github.com/repos/essentiaone/HDWallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/essentiaone/HDWallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/essentiaone/HDWallet/teams","hooks_url":"https://api.github.com/repos/essentiaone/HDWallet/hooks","issue_events_url":"https://api.github.com/repos/essentiaone/HDWallet/issues/events{/number}","events_url":"https://api.github.com/repos/essentiaone/HDWallet/events","assignees_url":"https://api.github.com/repos/essentiaone/HDWallet/assignees{/user}","branches_url":"https://api.github.com/repos/essentiaone/HDWallet/branches{/branch}","tags_url":"https://api.github.com/repos/essentiaone/HDWallet/tags","blobs_url":"https://api.github.com/repos/essentiaone/HDWallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/essentiaone/HDWallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/essentiaone/HDWallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/essentiaone/HDWallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/essentiaone/HDWallet/statuses/{sha}","languages_url":"https://api.github.com/repos/essentiaone/HDWallet/languages","stargazers_url":"https://api.github.com/repos/essentiaone/HDWallet/stargazers","contributors_url":"https://api.github.com/repos/essentiaone/HDWallet/contributors","subscribers_url":"https://api.github.com/repos/essentiaone/HDWallet/subscribers","subscription_url":"https://api.github.com/repos/essentiaone/HDWallet/subscription","commits_url":"https://api.github.com/repos/essentiaone/HDWallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/essentiaone/HDWallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/essentiaone/HDWallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/essentiaone/HDWallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/essentiaone/HDWallet/contents/{+path}","compare_url":"https://api.github.com/repos/essentiaone/HDWallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/essentiaone/HDWallet/merges","archive_url":"https://api.github.com/repos/essentiaone/HDWallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/essentiaone/HDWallet/downloads","issues_url":"https://api.github.com/repos/essentiaone/HDWallet/issues{/number}","pulls_url":"https://api.github.com/repos/essentiaone/HDWallet/pulls{/number}","milestones_url":"https://api.github.com/repos/essentiaone/HDWallet/milestones{/number}","notifications_url":"https://api.github.com/repos/essentiaone/HDWallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/essentiaone/HDWallet/labels{/name}","releases_url":"https://api.github.com/repos/essentiaone/HDWallet/releases{/id}","deployments_url":"https://api.github.com/repos/essentiaone/HDWallet/deployments","created_at":"2018-06-27T15:13:05Z","updated_at":"2018-07-12T17:25:59Z","pushed_at":"2018-07-13T11:04:42Z","git_url":"git://github.com/essentiaone/HDWallet.git","ssh_url":"git@github.com:essentiaone/HDWallet.git","clone_url":"https://github.com/essentiaone/HDWallet.git","svn_url":"https://github.com/essentiaone/HDWallet","homepage":null,"size":11272,"stargazers_count":2,"watchers_count":2,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/essentiaone/HDWallet/pulls/5"},"html":{"href":"https://github.com/essentiaone/HDWallet/pull/5"},"issue":{"href":"https://api.github.com/repos/essentiaone/HDWallet/issues/5"},"comments":{"href":"https://api.github.com/repos/essentiaone/HDWallet/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/essentiaone/HDWallet/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/essentiaone/HDWallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/essentiaone/HDWallet/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/essentiaone/HDWallet/statuses/345bd7f14ad3fd6dfc27cb80bef0f06e65e3b3a0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kozlov-oleksandr"}}