{"action":"opened","issue":{"url":"https://api.github.com/repos/espressif/arduino-esp32/issues/1577","repository_url":"https://api.github.com/repos/espressif/arduino-esp32","labels_url":"https://api.github.com/repos/espressif/arduino-esp32/issues/1577/labels{/name}","comments_url":"https://api.github.com/repos/espressif/arduino-esp32/issues/1577/comments","events_url":"https://api.github.com/repos/espressif/arduino-esp32/issues/1577/events","html_url":"https://github.com/espressif/arduino-esp32/issues/1577","id":337710452,"node_id":"MDU6SXNzdWUzMzc3MTA0NTI=","number":1577,"title":"Missing global instance of 'Serial1'; is one needed?","user":{"login":"mrwgx3","id":23343823,"node_id":"MDQ6VXNlcjIzMzQzODIz","avatar_url":"https://avatars2.githubusercontent.com/u/23343823?v=4","gravatar_id":"","url":"https://api.github.com/users/mrwgx3","html_url":"https://github.com/mrwgx3","followers_url":"https://api.github.com/users/mrwgx3/followers","following_url":"https://api.github.com/users/mrwgx3/following{/other_user}","gists_url":"https://api.github.com/users/mrwgx3/gists{/gist_id}","starred_url":"https://api.github.com/users/mrwgx3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrwgx3/subscriptions","organizations_url":"https://api.github.com/users/mrwgx3/orgs","repos_url":"https://api.github.com/users/mrwgx3/repos","events_url":"https://api.github.com/users/mrwgx3/events{/privacy}","received_events_url":"https://api.github.com/users/mrwgx3/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-03T01:02:58Z","updated_at":"2018-07-03T01:02:58Z","closed_at":null,"author_association":"NONE","body":"### Basic Infos\r\n\r\n#### Hardware\r\n\r\nAdafruit HUZZAH32 - ESP32 Feather Board  \r\nhttps://www.adafruit.com/product/3405\r\n\r\nAdalogger FeatherWing - RTC + SD Add-on For All Feather Boards  \r\nhttps://www.adafruit.com/product/2922\r\n\r\nAdafruit Ultimate GPS FeatherWing  \r\nhttps://www.adafruit.com/product/3133\r\n\r\nFeatherWing Tripler Mini Kit - Prototyping Add-on For Feathers  \r\nhttps://www.adafruit.com/product/3417\r\n\r\n#### OS, IDE, and Commit\r\n``` \r\nOS:       Windows 10 Professional\r\nIDE:      1.8.5\r\nCOMMIT?:  via 'git branch -v'\r\n          * master b855eb2 * arduino-esp32 release mgmt. update (#1557)\r\n```\r\n### Settings in IDE\r\n```\r\nModule:            Adafruit ESP32 Feather\r\nCPU Frequency:     80Mhz  \r\nCore Debug Level:  None\r\n```\r\n\r\n### Description\r\n\r\nWhile bringing up the forementioned hardware assembly, my colleague and I found that the [basic GPS Rx/Tx test sketch][rx_tx_test] would not compile for the ESP32. The cause of the problem is due to a missing global instance of 'HardwareSerial' named 'Serial1' (see adafruit/Adafruit_GPS#74).\r\n\r\nThe comments regarding the rx/tx test sketch implies that a global 'Serial1' should exist for multiple Arduino boards; they do exist within the Arduino/ESP8266 repository in core files ['HardwareSerial.cpp'][esp8266_hws_cpp] and ['HardwareSerial.h'][esp8266_hws_h].\r\n\r\nThe corresponding 'Serial1' definitions, however, cannot be found within the Arduino/ESP32 repository. [(a local instance can be found HERE)][serial1_instance].\r\n\r\nDoes a global instance of 'Serial1' need to be defined for the Arduino/ESP32 repository? Are there good reasons for not doing so?\r\n\r\n[rx_tx_test]:\r\nhttps://learn.adafruit.com/adafruit-ultimate-gps-featherwing/basic-rx-tx-test \"Basic Rx/Tx GPS test\"\r\n\r\n[esp8266_hws_cpp]:\r\nhttps://github.com/esp8266/Arduino/blob/3a110aa698dd17e0d80704db47c8e43c986b0f86/cores/esp8266/HardwareSerial.cpp#L111#L116 \"ESP8266 'HardwareSerial.cpp'\"\r\n\r\n[esp8266_hws_h]:\r\nhttps://github.com/esp8266/Arduino/blob/3a110aa698dd17e0d80704db47c8e43c986b0f86/cores/esp8266/HardwareSerial.h#L187#L196 \"ESP8266 'HardwareSerial.h'\"\r\n\r\n[serial1_instance]:\r\nhttps://github.com/espressif/arduino-esp32/blob/432bcf5a0aa0d234346c22598bea8e248c156c79/libraries/WiFi/examples/WiFiTelnetToSerial/WiFiTelnetToSerial.ino#L32#L36  \"Instance for'Serial1'\""}}
{"actor":{"display_login":"mrwgx3"}}