{"push_id":2385123683,"size":126,"distinct_size":0,"ref":"refs/heads/canary","head":"7a8be5f0e0acf1ea21405b29442539c51ce43d9a","before":"ca293a11ae98bd642339f38c5a5eae225d5f75c6","commits":[{"sha":"8ac299a7fe14cb9c53182d4c8ed7f22b38b34c34","author":{"name":"William Chou","email":"f7104039f15cbb0c3ebd55dacf81ba2ac6f2c807@google.com"},"message":"Avoid function names for IE11 (#13615)\n\n* avoid function names for ie11\r\n\r\n* add conformance config check\r\n\r\n* fix lint","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/8ac299a7fe14cb9c53182d4c8ed7f22b38b34c34"},{"sha":"6c50ccae36ac57055c9af53360626c62405ba9f8","author":{"name":"Cathy Zhu","email":"10609afed122eb28a2fdaac1ff8af6c334fce63d@gmail.com"},"message":"Add <amp-anim> to <amp-lightbox-gallery>  (#13614)\n\n* Add amp-anim\r\n\r\n* Change constants to upper casE","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/6c50ccae36ac57055c9af53360626c62405ba9f8"},{"sha":"0210f98d551a747b066f9c94e679095eac3f4f74","author":{"name":"Dima Voytenko","email":"25fbbb6929233b848e1fe3e32f489f86dc37c0dd@google.com"},"message":"Dialog renderer implementation for subscriptions (#13605)\n\n* Dialog renderer implementation for subscriptions\r\n\r\n* linters\r\n\r\n* review fixes","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/0210f98d551a747b066f9c94e679095eac3f4f74"},{"sha":"1eddb7cc242ee279a384bb7203b5fe5fbaa3f654","author":{"name":"Yuxuan Zhou","email":"609a0113f3eb2149eeca5ae90b83ffa7e8980c6a@users.noreply.github.com"},"message":"Improve custom ad to support different templateId (#13583)\n\n* templateId\r\n\r\n* remove old manual test\r\n\r\n* ini_load signal\r\n\r\n* ralways respect child template\r\n\r\n* address comment","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/1eddb7cc242ee279a384bb7203b5fe5fbaa3f654"},{"sha":"1fdf92ae9169557391be122cca70a5c1c02739b7","author":{"name":"nainar","email":"3c2e617a4d256dde1e096acea8700cc323e4f0cb@google.com"},"message":"<amp-facebook-page> Fix typo in propagating data-show-facepile (#13625)","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/1fdf92ae9169557391be122cca70a5c1c02739b7"},{"sha":"c56637b733d54f91d192702adc5a00a371c3c743","author":{"name":"Ali Ghassemi","email":"028792cf7948a792d475057fc884867e01167da2@google.com"},"message":"amp-carousel: First phase of cleaning up snap experiment (#13620)","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/c56637b733d54f91d192702adc5a00a371c3c743"},{"sha":"19e6e78e9d287ae019418575de4af03d420041f5","author":{"name":"Hamoon","email":"cf713b168717175166427e373f441008f1066126@users.noreply.github.com"},"message":"Whitelist actions on the special AMP target (#13192)\n\n* respect the whitelist of actions specified in meta tags\r\n\r\n* fixed the failing tests\r\n\r\n* lint fix\r\n\r\n* Fixed some of the concerns in the review\r\n\r\n* Faking the window\r\n\r\n* ran lint --fix\r\n\r\n* simplifying the functional tests\r\n\r\n* more code review fixes\r\n\r\n* using real window in test\r\n\r\n* a few suggestions by Su\r\n\r\n* fixing import orders\r\n\r\n* fixed lint errors\r\n\r\n* removing const identifier","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/19e6e78e9d287ae019418575de4af03d420041f5"},{"sha":"3a2d476193678a5f726b892176fe497cb4aafccc","author":{"name":"Caleb Cordry","email":"cf64d2b852d2cfa345f8cdceffb1feca45093958@google.com"},"message":"🚀 Make sure amp-story ad is loaded before display (#13618)\n\n* check if ad loaded\r\n\r\n* add created count","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/3a2d476193678a5f726b892176fe497cb4aafccc"},{"sha":"bce2653027d851f2df7d25dba417a4c5b8c8930d","author":{"name":"nainar","email":"3c2e617a4d256dde1e096acea8700cc323e4f0cb@google.com"},"message":"<amp-facebook-page> Propagate user specified `width` and `height` attributes (#13626)\n\n* Make sure to propagate user specified  and  attributes\r\n\r\n* Stop exposing data-adapt-container-width. Force it to be true always.","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/bce2653027d851f2df7d25dba417a4c5b8c8930d"},{"sha":"dfe14d5f89b9bb5144f1844189e906cbe715d2d2","author":{"name":"Prateek Bhatnagar","email":"d2f0a0d45ff042983facf4c91c63132148ce1d5a@gmail.com"},"message":"Amp subscriptions: Read service config from page (#13611)\n\n* fix animating circle fixed position\r\n\r\n* adding null resolve if no entitlements enables reader\r\n\r\n* adding tests\r\n\r\n* adding tests for entitlements store\r\n\r\n* lint fixes\r\n\r\n* sending page config to subscription platform\r\n\r\n* fixing comments\r\n\r\n* changing promise resolution of firstPositive\r\n\r\n* reading serviceConfig\r\n\r\n* fixing existing tests\r\n\r\n* adding test for service config\r\n\r\n* fixed nits\r\n\r\n* fixing conflicts\r\n\r\n* fixing comments\r\n\r\n* fixing cors and types\r\n\r\n* adding more test","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/dfe14d5f89b9bb5144f1844189e906cbe715d2d2"},{"sha":"2c26ad1780e3ff85dbd7bbffc47ddc4f3ae37886","author":{"name":"Cathy Zhu","email":"10609afed122eb28a2fdaac1ff8af6c334fce63d@gmail.com"},"message":"Change thumbnail src to thumbnail id for lightbox thumbnail api (#13624)\n\n* Change thumbnail src to thumbnail id\r\n\r\n* Add example and documentation\r\n\r\n* Fix lint\r\n\r\n* Address comments and fix lint","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/2c26ad1780e3ff85dbd7bbffc47ddc4f3ae37886"},{"sha":"4560c0716ee67180fd57b741bc02fa2e2d5f293e","author":{"name":"Cathy Zhu","email":"10609afed122eb28a2fdaac1ff8af6c334fce63d@gmail.com"},"message":"Add <amp-ad> to <amp-lightbox-gallery> support  (#13639)\n\n* Add <amp-ad> to supported attributes in lightbox\r\n\r\n* Add high res images and make launch tests look ok","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/4560c0716ee67180fd57b741bc02fa2e2d5f293e"},{"sha":"81e7607e45090e8bb0e1a9bb9abfbb802e4d1cdb","author":{"name":"Prateek Bhatnagar","email":"d2f0a0d45ff042983facf4c91c63132148ce1d5a@gmail.com"},"message":"Amp subs platform factory (#13636)\n\n* fix animating circle fixed position\r\n\r\n* adding null resolve if no entitlements enables reader\r\n\r\n* adding tests\r\n\r\n* adding tests for entitlements store\r\n\r\n* lint fixes\r\n\r\n* sending page config to subscription platform\r\n\r\n* fixing comments\r\n\r\n* changing promise resolution of firstPositive\r\n\r\n* reading serviceConfig\r\n\r\n* fixing existing tests\r\n\r\n* adding test for service config\r\n\r\n* fixed nits\r\n\r\n* fixing conflicts\r\n\r\n* fixing comments\r\n\r\n* fixing cors and types\r\n\r\n* shifting init login in start\r\n\r\n* WIP factory function\r\n\r\n* Adding serviceconfig definations\r\n\r\n* fix merge conflict\r\n\r\n* addiing tests\r\n\r\n* fixing comments\r\n\r\n* fixed types and service config bing passed","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/81e7607e45090e8bb0e1a9bb9abfbb802e4d1cdb"},{"sha":"52ea5a046e228955ce27637333834b56a61762ad","author":{"name":"Caleb Cordry","email":"cf64d2b852d2cfa345f8cdceffb1feca45093958@google.com"},"message":"✨Use template ads for `auto-story-ads` (#13640)\n\n* use template ads\r\n\r\n* address comments\r\n\r\n* fix json type","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/52ea5a046e228955ce27637333834b56a61762ad"},{"sha":"91ece2b5d6d84f1be52c4808ffdb440aa8419a00","author":{"name":"Caleb Cordry","email":"cf64d2b852d2cfa345f8cdceffb1feca45093958@google.com"},"message":"🐛 Fix progress-bar segments showing on ads in story (#13648)\n\n* wait for story load event\r\n\r\n* inline resolve","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/91ece2b5d6d84f1be52c4808ffdb440aa8419a00"},{"sha":"dfb6ea12b8e85f9d81aa570931ad2c02d318c00f","author":{"name":"Enrique Marroquin","email":"eb45d89b8cfbdee8ed00c18b209e3e140a14c4d9@users.noreply.github.com"},"message":"Adds new \"call to action\" layer (#13631)\n\n* Adds new \"call to action\" layer with corresponding styles, and an example of it interacting with the existing amp-story-grid-layer templates.\r\n\r\n* Removes unecessary tyling for child elements, fixes example to comply with validator, fixes formatting.\r\n\r\n* Fixes formatting.\r\n\r\n* fixup! Fixes formatting.","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/dfb6ea12b8e85f9d81aa570931ad2c02d318c00f"},{"sha":"5c17d9422886ce9ef3c08583907b37138794b199","author":{"name":"Noran Azmy","email":"88c48730a24c862aa398201a26fefcd8a85abbf8@gmail.com"},"message":"Reinforcing width check for full-width responsive ad units (#13607)","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/5c17d9422886ce9ef3c08583907b37138794b199"},{"sha":"a894b876cca15d44c724297c5d41da91d65a9280","author":{"name":"Lucas Silva","email":"7256d5c931c123d15c6c30dff5b00086ce83fdde@google.com"},"message":"✨ Add the \"sandbox\" iframe attribute to cross domain A4A rendering modes (#13622)\n\n* Add the \"sandbox\" iframe attribute to cross domain A4A rendering modes if the sandbox header is set in the ad response. Adding this attribute to ad iframes will prevent malicious ads from auto-redirecting users without their consent. This is a no-op if the header is not set in the ad response.\r\n\r\n* Add unit tests for sandboxing in A4A\r\n\r\n* Address reviewer comments, rename \"sandbox\" variable to \"sandboxAttribute\"\r\n\r\n* Address review comments","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/a894b876cca15d44c724297c5d41da91d65a9280"},{"sha":"ca43a58235a4c1942789a12ef8ea3531a891e598","author":{"name":"nainar","email":"3c2e617a4d256dde1e096acea8700cc323e4f0cb@google.com"},"message":"<amp-selector> element toggle the 'selected' attribute (#13553)\n\n* WIP\r\n\r\n* Finalize implementation and tests\r\n\r\n* Implementation and tests\r\n\r\n* Make cvializ@ suggestions - change input argument name and clean up code\r\n\r\n* Cater for large negative numbers and add tests to check for that too\r\n\r\n* Rewrite code and tests to be cleaner\r\n\r\n* Move mod functionality to helper and add tests too\r\n\r\n* Remove unnecessary  attribute logic\r\n\r\n* Add assert to ensure index is > 0\r\n\r\n* Add additional assert\r\n\r\n* Linter error","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/ca43a58235a4c1942789a12ef8ea3531a891e598"},{"sha":"b5af4ecb87161873b16bb4be8edb8953d09977c3","author":{"name":"Dima Voytenko","email":"25fbbb6929233b848e1fe3e32f489f86dc37c0dd@google.com"},"message":"Import SwG subscriptions library (#13627)\n\n* Import SwG subscriptions library\r\n\r\n* lints\r\n\r\n* tests\r\n\r\n* rebased to plartform factories\r\n\r\n* lints","distinct":false,"url":"https://api.github.com/repos/ampproject/amphtml/commits/b5af4ecb87161873b16bb4be8edb8953d09977c3"}]}
{"actor":{"display_login":"lannka"}}