{"action":"created","issue":{"url":"https://api.github.com/repos/angular/universal/issues/1091","repository_url":"https://api.github.com/repos/angular/universal","labels_url":"https://api.github.com/repos/angular/universal/issues/1091/labels{/name}","comments_url":"https://api.github.com/repos/angular/universal/issues/1091/comments","events_url":"https://api.github.com/repos/angular/universal/issues/1091/events","html_url":"https://github.com/angular/universal/pull/1091","id":378377907,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MDk3NzE3","number":1091,"title":"fix(common): Update transfer_http cache to not invalidate after mutating calls","user":{"login":"JediSange","id":832893,"node_id":"MDQ6VXNlcjgzMjg5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/832893?v=4","gravatar_id":"","url":"https://api.github.com/users/JediSange","html_url":"https://github.com/JediSange","followers_url":"https://api.github.com/users/JediSange/followers","following_url":"https://api.github.com/users/JediSange/following{/other_user}","gists_url":"https://api.github.com/users/JediSange/gists{/gist_id}","starred_url":"https://api.github.com/users/JediSange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JediSange/subscriptions","organizations_url":"https://api.github.com/users/JediSange/orgs","repos_url":"https://api.github.com/users/JediSange/repos","events_url":"https://api.github.com/users/JediSange/events{/privacy}","received_events_url":"https://api.github.com/users/JediSange/received_events","type":"User","site_admin":false},"labels":[{"id":836486616,"node_id":"MDU6TGFiZWw4MzY0ODY2MTY=","url":"https://api.github.com/repos/angular/universal/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-11-07T16:54:04Z","updated_at":"2018-11-08T22:43:59Z","closed_at":"2018-11-08T22:33:44Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/angular/universal/pulls/1091","html_url":"https://github.com/angular/universal/pull/1091","diff_url":"https://github.com/angular/universal/pull/1091.diff","patch_url":"https://github.com/angular/universal/pull/1091.patch"},"body":"Ran into this issue while working in Angular Universal 6.0. We noticed that the transfer state wasn't accurately returning and that our page, despite having the initial transfer state rendered on the page, was still making an HTTP call to fetch the data because it was producing a cache miss here.\r\n\r\nThis was happening because we were submitting PUT/POST requests for reporting at a an earlier point in time. In my opinion, there is not a good reason to invalidate this cache for any reason other than the application becoming stable. This code reflects that and it was a simple enough change for our usage so we are trying to commit it back."},"comment":{"url":"https://api.github.com/repos/angular/universal/issues/comments/437183415","html_url":"https://github.com/angular/universal/pull/1091#issuecomment-437183415","issue_url":"https://api.github.com/repos/angular/universal/issues/1091","id":437183415,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzE4MzQxNQ==","user":{"login":"JediSange","id":832893,"node_id":"MDQ6VXNlcjgzMjg5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/832893?v=4","gravatar_id":"","url":"https://api.github.com/users/JediSange","html_url":"https://github.com/JediSange","followers_url":"https://api.github.com/users/JediSange/followers","following_url":"https://api.github.com/users/JediSange/following{/other_user}","gists_url":"https://api.github.com/users/JediSange/gists{/gist_id}","starred_url":"https://api.github.com/users/JediSange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JediSange/subscriptions","organizations_url":"https://api.github.com/users/JediSange/orgs","repos_url":"https://api.github.com/users/JediSange/repos","events_url":"https://api.github.com/users/JediSange/events{/privacy}","received_events_url":"https://api.github.com/users/JediSange/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T22:43:59Z","updated_at":"2018-11-08T22:43:59Z","author_association":"NONE","body":"@vikerman In what ways would this be a breaking change? It wouldn't affect any GET or HEAD requests. You arbitrarily deem that an application should not want any of the cached data from the `transferState` after receiving a PUT/POST/etc. Perhaps that decision is not arbitrary and I'd love to hear more about why that is -- because that doesn't seem like a common paradigm. If I am showing some record, I still want to reference that pre-fetched data from the transferState even if I have also fired reporting calls.\r\n\r\n@Toxicable My change does not cache mutating http calls. This bypasses caching them, but also doesn't invalidate the existing GET/HEAD requests the server has already done for us."}}
{"actor":{"display_login":"JediSange"}}