{"action":"created","issue":{"url":"https://api.github.com/repos/bcye/whathaveiread/issues/27","repository_url":"https://api.github.com/repos/bcye/whathaveiread","labels_url":"https://api.github.com/repos/bcye/whathaveiread/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/bcye/whathaveiread/issues/27/comments","events_url":"https://api.github.com/repos/bcye/whathaveiread/issues/27/events","html_url":"https://github.com/bcye/whathaveiread/issues/27","id":374792146,"node_id":"MDU6SXNzdWUzNzQ3OTIxNDY=","number":27,"title":"Over-complete API data model","user":{"login":"raysarebest","id":7948008,"node_id":"MDQ6VXNlcjc5NDgwMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/7948008?v=4","gravatar_id":"","url":"https://api.github.com/users/raysarebest","html_url":"https://github.com/raysarebest","followers_url":"https://api.github.com/users/raysarebest/followers","following_url":"https://api.github.com/users/raysarebest/following{/other_user}","gists_url":"https://api.github.com/users/raysarebest/gists{/gist_id}","starred_url":"https://api.github.com/users/raysarebest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raysarebest/subscriptions","organizations_url":"https://api.github.com/users/raysarebest/orgs","repos_url":"https://api.github.com/users/raysarebest/repos","events_url":"https://api.github.com/users/raysarebest/events{/privacy}","received_events_url":"https://api.github.com/users/raysarebest/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-28T19:59:11Z","updated_at":"2018-10-28T20:02:07Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The model in `OpenLibraryBook.swift` contains *a lot* of data. However, much of it is non-optional, and the app itself doesn't use most of it. Worse yet, since most (if not, all) of it is non-optional, that means that decoding will fail for a book that has lots of valid data, but not for every key. I propose that we mark only the properties that the app uses as non-optional\r\n\r\nOf course, this means we'll need to figure out what to do about the other data. There are 3 paths I see with this:\r\n\r\n- Just delete all the references to it and only keep the data we need\r\n- Keep all the properties that exist, but mark all but the ones we use as optional and decode them only if present\r\n- Make properties for just the data we need, and put the rest into a dictionary property\r\n    - Maybe allow `@dynamicMemberLookup` for access to that dictionary?"},"comment":{"url":"https://api.github.com/repos/bcye/whathaveiread/issues/comments/433736551","html_url":"https://github.com/bcye/whathaveiread/issues/27#issuecomment-433736551","issue_url":"https://api.github.com/repos/bcye/whathaveiread/issues/27","id":433736551,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzczNjU1MQ==","user":{"login":"bcye","id":29666239,"node_id":"MDQ6VXNlcjI5NjY2MjM5","avatar_url":"https://avatars2.githubusercontent.com/u/29666239?v=4","gravatar_id":"","url":"https://api.github.com/users/bcye","html_url":"https://github.com/bcye","followers_url":"https://api.github.com/users/bcye/followers","following_url":"https://api.github.com/users/bcye/following{/other_user}","gists_url":"https://api.github.com/users/bcye/gists{/gist_id}","starred_url":"https://api.github.com/users/bcye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcye/subscriptions","organizations_url":"https://api.github.com/users/bcye/orgs","repos_url":"https://api.github.com/users/bcye/repos","events_url":"https://api.github.com/users/bcye/events{/privacy}","received_events_url":"https://api.github.com/users/bcye/received_events","type":"User","site_admin":false},"created_at":"2018-10-28T20:02:07Z","updated_at":"2018-10-28T20:02:07Z","author_association":"OWNER","body":"I would go for option 2, this makes it easier to access the properties in future versions, where we might want to access them"}}
{"actor":{"display_login":"bcye"}}