{"action":"created","comment":{"url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/comments/221061362","pull_request_review_id":159621318,"id":221061362,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTA2MTM2Mg==","diff_hunk":"@@ -117,6 +117,7 @@ class RecognizeStream extends Duplex {\n    * @param {string} [options.base_model_version] - The version of the specified base model that is to be used with recognition request or, for the **Create a session** method, with the new session.\n    * Multiple versions of a base model can exist when a model is updated for internal improvements. The parameter is intended primarily for use with custom models that have been upgraded for a new base model.\n    * The default value depends on whether the parameter is used with or without a custom model. For more information, see [Base model version](https://console.bluemix.net/docs/services/speech-to-text/input.html#version).\n+   * @param {Boolean} [options.rejectUnauthorized] - If true, disable SSL verification for the WebSocket connection","path":"lib/recognize-stream.ts","position":4,"original_position":4,"commit_id":"f8466c87f6f842072d4996e72fee3a8d61ca2ca6","original_commit_id":"f8466c87f6f842072d4996e72fee3a8d61ca2ca6","user":{"login":"germanattanasio","id":313157,"node_id":"MDQ6VXNlcjMxMzE1Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/313157?v=4","gravatar_id":"","url":"https://api.github.com/users/germanattanasio","html_url":"https://github.com/germanattanasio","followers_url":"https://api.github.com/users/germanattanasio/followers","following_url":"https://api.github.com/users/germanattanasio/following{/other_user}","gists_url":"https://api.github.com/users/germanattanasio/gists{/gist_id}","starred_url":"https://api.github.com/users/germanattanasio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/germanattanasio/subscriptions","organizations_url":"https://api.github.com/users/germanattanasio/orgs","repos_url":"https://api.github.com/users/germanattanasio/repos","events_url":"https://api.github.com/users/germanattanasio/events{/privacy}","received_events_url":"https://api.github.com/users/germanattanasio/received_events","type":"User","site_admin":false},"body":"is `rejectUnauthorized` the name we use in the other SDKs?","created_at":"2018-09-27T20:12:59Z","updated_at":"2018-09-27T20:13:01Z","html_url":"https://github.com/watson-developer-cloud/node-sdk/pull/782#discussion_r221061362","pull_request_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/782","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/comments/221061362"},"html":{"href":"https://github.com/watson-developer-cloud/node-sdk/pull/782#discussion_r221061362"},"pull_request":{"href":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/782"}}},"pull_request":{"url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/782","id":218774745,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4Nzc0NzQ1","html_url":"https://github.com/watson-developer-cloud/node-sdk/pull/782","diff_url":"https://github.com/watson-developer-cloud/node-sdk/pull/782.diff","patch_url":"https://github.com/watson-developer-cloud/node-sdk/pull/782.patch","issue_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues/782","number":782,"state":"open","locked":false,"title":"Disable ssl for websocket","user":{"login":"dpopp07","id":9168931,"node_id":"MDQ6VXNlcjkxNjg5MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/9168931?v=4","gravatar_id":"","url":"https://api.github.com/users/dpopp07","html_url":"https://github.com/dpopp07","followers_url":"https://api.github.com/users/dpopp07/followers","following_url":"https://api.github.com/users/dpopp07/following{/other_user}","gists_url":"https://api.github.com/users/dpopp07/gists{/gist_id}","starred_url":"https://api.github.com/users/dpopp07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpopp07/subscriptions","organizations_url":"https://api.github.com/users/dpopp07/orgs","repos_url":"https://api.github.com/users/dpopp07/repos","events_url":"https://api.github.com/users/dpopp07/events{/privacy}","received_events_url":"https://api.github.com/users/dpopp07/received_events","type":"User","site_admin":false},"body":"The SSL disabling option I added for the last release did not cover the WebSocket connection (thanks @lpatino10 for the catch).\r\n\r\nThis PR resolves this by taking the user option, passing it to the `RecognizeStream` class, and using it to configure the connection. It does this by creating a `tlsOptions` parameter, which gets passed into Node's native `http` library [according to the `websocket` docs](https://github.com/theturtle32/WebSocket-Node/blob/master/docs/WebSocketClient.md#client-config-options).\r\n\r\n@lpatino10 confirmed this fix works with ICP.\r\n\r\ncc @germanattanasio ","created_at":"2018-09-27T20:11:50Z","updated_at":"2018-09-27T20:13:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b034429b383b3b7f97ef01a0e17642218434381","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anweshan","id":7184512,"node_id":"MDQ6VXNlcjcxODQ1MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/7184512?v=4","gravatar_id":"","url":"https://api.github.com/users/anweshan","html_url":"https://github.com/anweshan","followers_url":"https://api.github.com/users/anweshan/followers","following_url":"https://api.github.com/users/anweshan/following{/other_user}","gists_url":"https://api.github.com/users/anweshan/gists{/gist_id}","starred_url":"https://api.github.com/users/anweshan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anweshan/subscriptions","organizations_url":"https://api.github.com/users/anweshan/orgs","repos_url":"https://api.github.com/users/anweshan/repos","events_url":"https://api.github.com/users/anweshan/events{/privacy}","received_events_url":"https://api.github.com/users/anweshan/received_events","type":"User","site_admin":false},{"login":"lpatino10","id":8710772,"node_id":"MDQ6VXNlcjg3MTA3NzI=","avatar_url":"https://avatars2.githubusercontent.com/u/8710772?v=4","gravatar_id":"","url":"https://api.github.com/users/lpatino10","html_url":"https://github.com/lpatino10","followers_url":"https://api.github.com/users/lpatino10/followers","following_url":"https://api.github.com/users/lpatino10/following{/other_user}","gists_url":"https://api.github.com/users/lpatino10/gists{/gist_id}","starred_url":"https://api.github.com/users/lpatino10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpatino10/subscriptions","organizations_url":"https://api.github.com/users/lpatino10/orgs","repos_url":"https://api.github.com/users/lpatino10/repos","events_url":"https://api.github.com/users/lpatino10/events{/privacy}","received_events_url":"https://api.github.com/users/lpatino10/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/782/commits","review_comments_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/782/comments","review_comment_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues/782/comments","statuses_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/statuses/f8466c87f6f842072d4996e72fee3a8d61ca2ca6","head":{"label":"watson-developer-cloud:disable-ssl-for-websocket","ref":"disable-ssl-for-websocket","sha":"f8466c87f6f842072d4996e72fee3a8d61ca2ca6","user":{"login":"watson-developer-cloud","id":10017763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDE3NzYz","avatar_url":"https://avatars2.githubusercontent.com/u/10017763?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-developer-cloud","html_url":"https://github.com/watson-developer-cloud","followers_url":"https://api.github.com/users/watson-developer-cloud/followers","following_url":"https://api.github.com/users/watson-developer-cloud/following{/other_user}","gists_url":"https://api.github.com/users/watson-developer-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-developer-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-developer-cloud/subscriptions","organizations_url":"https://api.github.com/users/watson-developer-cloud/orgs","repos_url":"https://api.github.com/users/watson-developer-cloud/repos","events_url":"https://api.github.com/users/watson-developer-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/watson-developer-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":27840307,"node_id":"MDEwOlJlcG9zaXRvcnkyNzg0MDMwNw==","name":"node-sdk","full_name":"watson-developer-cloud/node-sdk","private":false,"owner":{"login":"watson-developer-cloud","id":10017763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDE3NzYz","avatar_url":"https://avatars2.githubusercontent.com/u/10017763?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-developer-cloud","html_url":"https://github.com/watson-developer-cloud","followers_url":"https://api.github.com/users/watson-developer-cloud/followers","following_url":"https://api.github.com/users/watson-developer-cloud/following{/other_user}","gists_url":"https://api.github.com/users/watson-developer-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-developer-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-developer-cloud/subscriptions","organizations_url":"https://api.github.com/users/watson-developer-cloud/orgs","repos_url":"https://api.github.com/users/watson-developer-cloud/repos","events_url":"https://api.github.com/users/watson-developer-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/watson-developer-cloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/watson-developer-cloud/node-sdk","description":":comet: Node.js library to access IBM Watson services.","fork":false,"url":"https://api.github.com/repos/watson-developer-cloud/node-sdk","forks_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/forks","keys_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/teams","hooks_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/hooks","issue_events_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/events","assignees_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/tags","blobs_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/languages","stargazers_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/stargazers","contributors_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/contributors","subscribers_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/subscribers","subscription_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/subscription","commits_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/merges","archive_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/downloads","issues_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/labels{/name}","releases_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/deployments","created_at":"2014-12-10T21:20:48Z","updated_at":"2018-09-26T07:44:38Z","pushed_at":"2018-09-27T20:11:51Z","git_url":"git://github.com/watson-developer-cloud/node-sdk.git","ssh_url":"git@github.com:watson-developer-cloud/node-sdk.git","clone_url":"https://github.com/watson-developer-cloud/node-sdk.git","svn_url":"https://github.com/watson-developer-cloud/node-sdk","homepage":"https://www.npmjs.com/package/watson-developer-cloud","size":126469,"stargazers_count":1115,"watchers_count":1115,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":561,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":561,"open_issues":17,"watchers":1115,"default_branch":"master"}},"base":{"label":"watson-developer-cloud:master","ref":"master","sha":"724e6842030332057ff619a368113eb816fe0b86","user":{"login":"watson-developer-cloud","id":10017763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDE3NzYz","avatar_url":"https://avatars2.githubusercontent.com/u/10017763?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-developer-cloud","html_url":"https://github.com/watson-developer-cloud","followers_url":"https://api.github.com/users/watson-developer-cloud/followers","following_url":"https://api.github.com/users/watson-developer-cloud/following{/other_user}","gists_url":"https://api.github.com/users/watson-developer-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-developer-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-developer-cloud/subscriptions","organizations_url":"https://api.github.com/users/watson-developer-cloud/orgs","repos_url":"https://api.github.com/users/watson-developer-cloud/repos","events_url":"https://api.github.com/users/watson-developer-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/watson-developer-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":27840307,"node_id":"MDEwOlJlcG9zaXRvcnkyNzg0MDMwNw==","name":"node-sdk","full_name":"watson-developer-cloud/node-sdk","private":false,"owner":{"login":"watson-developer-cloud","id":10017763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDE3NzYz","avatar_url":"https://avatars2.githubusercontent.com/u/10017763?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-developer-cloud","html_url":"https://github.com/watson-developer-cloud","followers_url":"https://api.github.com/users/watson-developer-cloud/followers","following_url":"https://api.github.com/users/watson-developer-cloud/following{/other_user}","gists_url":"https://api.github.com/users/watson-developer-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-developer-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-developer-cloud/subscriptions","organizations_url":"https://api.github.com/users/watson-developer-cloud/orgs","repos_url":"https://api.github.com/users/watson-developer-cloud/repos","events_url":"https://api.github.com/users/watson-developer-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/watson-developer-cloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/watson-developer-cloud/node-sdk","description":":comet: Node.js library to access IBM Watson services.","fork":false,"url":"https://api.github.com/repos/watson-developer-cloud/node-sdk","forks_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/forks","keys_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/teams","hooks_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/hooks","issue_events_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/events","assignees_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/tags","blobs_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/languages","stargazers_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/stargazers","contributors_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/contributors","subscribers_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/subscribers","subscription_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/subscription","commits_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/merges","archive_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/downloads","issues_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/labels{/name}","releases_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/deployments","created_at":"2014-12-10T21:20:48Z","updated_at":"2018-09-26T07:44:38Z","pushed_at":"2018-09-27T20:11:51Z","git_url":"git://github.com/watson-developer-cloud/node-sdk.git","ssh_url":"git@github.com:watson-developer-cloud/node-sdk.git","clone_url":"https://github.com/watson-developer-cloud/node-sdk.git","svn_url":"https://github.com/watson-developer-cloud/node-sdk","homepage":"https://www.npmjs.com/package/watson-developer-cloud","size":126469,"stargazers_count":1115,"watchers_count":1115,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":561,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":561,"open_issues":17,"watchers":1115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/782"},"html":{"href":"https://github.com/watson-developer-cloud/node-sdk/pull/782"},"issue":{"href":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues/782"},"comments":{"href":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues/782/comments"},"review_comments":{"href":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/782/comments"},"review_comment":{"href":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/782/commits"},"statuses":{"href":"https://api.github.com/repos/watson-developer-cloud/node-sdk/statuses/f8466c87f6f842072d4996e72fee3a8d61ca2ca6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"germanattanasio"}}