{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/pulls/comments/216238508","pull_request_review_id":153672117,"id":216238508,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjIzODUwOA==","diff_hunk":"@@ -1,63 +0,0 @@\n-package uk.gov.ida.metadataaggregator;\n-\n-import org.junit.Before;\n-import org.junit.Test;\n-import org.opensaml.core.config.InitializationException;\n-import org.opensaml.core.config.InitializationService;\n-import uk.gov.ida.metadataaggregator.configuration.MetadataSourceConfiguration;\n-import uk.gov.ida.metadataaggregator.exceptions.ConfigSourceException;\n-import uk.gov.ida.metadataaggregator.configuration.MetadataSourceConfigurationLoader;\n-\n-import java.net.URL;\n-import java.util.Collection;\n-\n-import static org.assertj.core.api.Java6Assertions.assertThat;\n-\n-public class EnvironmentConfigTest {","path":"src/config-test/java/uk/gov/ida/metadataaggregator/EnvironmentConfigTest.java","position":16,"original_position":16,"commit_id":"06379c8b88746787d7bc88dab08006769acacb88","original_commit_id":"06379c8b88746787d7bc88dab08006769acacb88","user":{"login":"IreneLau-GDS","id":30260246,"node_id":"MDQ6VXNlcjMwMjYwMjQ2","avatar_url":"https://avatars0.githubusercontent.com/u/30260246?v=4","gravatar_id":"","url":"https://api.github.com/users/IreneLau-GDS","html_url":"https://github.com/IreneLau-GDS","followers_url":"https://api.github.com/users/IreneLau-GDS/followers","following_url":"https://api.github.com/users/IreneLau-GDS/following{/other_user}","gists_url":"https://api.github.com/users/IreneLau-GDS/gists{/gist_id}","starred_url":"https://api.github.com/users/IreneLau-GDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IreneLau-GDS/subscriptions","organizations_url":"https://api.github.com/users/IreneLau-GDS/orgs","repos_url":"https://api.github.com/users/IreneLau-GDS/repos","events_url":"https://api.github.com/users/IreneLau-GDS/events{/privacy}","received_events_url":"https://api.github.com/users/IreneLau-GDS/received_events","type":"User","site_admin":false},"body":"Now that we have deleted the tests, shouldn't we also delete the resources that the tests were testing? ","created_at":"2018-09-10T08:36:07Z","updated_at":"2018-09-10T08:36:11Z","html_url":"https://github.com/alphagov/verify-eidas-metadata-aggregator/pull/27#discussion_r216238508","pull_request_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/pulls/27","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/pulls/comments/216238508"},"html":{"href":"https://github.com/alphagov/verify-eidas-metadata-aggregator/pull/27#discussion_r216238508"},"pull_request":{"href":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/pulls/27","id":213665669,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNjY1NjY5","html_url":"https://github.com/alphagov/verify-eidas-metadata-aggregator/pull/27","diff_url":"https://github.com/alphagov/verify-eidas-metadata-aggregator/pull/27.diff","patch_url":"https://github.com/alphagov/verify-eidas-metadata-aggregator/pull/27.patch","issue_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/issues/27","number":27,"state":"open","locked":false,"title":"Eid 887: Schedule Metadata Aggregation on DW app","user":{"login":"FelixMarcusMillne","id":36890236,"node_id":"MDQ6VXNlcjM2ODkwMjM2","avatar_url":"https://avatars3.githubusercontent.com/u/36890236?v=4","gravatar_id":"","url":"https://api.github.com/users/FelixMarcusMillne","html_url":"https://github.com/FelixMarcusMillne","followers_url":"https://api.github.com/users/FelixMarcusMillne/followers","following_url":"https://api.github.com/users/FelixMarcusMillne/following{/other_user}","gists_url":"https://api.github.com/users/FelixMarcusMillne/gists{/gist_id}","starred_url":"https://api.github.com/users/FelixMarcusMillne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FelixMarcusMillne/subscriptions","organizations_url":"https://api.github.com/users/FelixMarcusMillne/orgs","repos_url":"https://api.github.com/users/FelixMarcusMillne/repos","events_url":"https://api.github.com/users/FelixMarcusMillne/events{/privacy}","received_events_url":"https://api.github.com/users/FelixMarcusMillne/received_events","type":"User","site_admin":false},"body":"Creating a managed dropwizard job that schedules the aggregation.\r\n\r\nThe schedule delay is defined in config, and there is an acceptance test for ensuring that the aggregation scheduler is managed by DW.\r\n\r\nNB A ScheduledExecutorService is used instead of Timer to allow future blocking when we wish to introduce a manual trigger. ","created_at":"2018-09-06T15:46:08Z","updated_at":"2018-09-10T08:36:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8bbc3105949ee11aff6e92bae0ca28b5b16f2f0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"minhngocd","id":568730,"node_id":"MDQ6VXNlcjU2ODczMA==","avatar_url":"https://avatars0.githubusercontent.com/u/568730?v=4","gravatar_id":"","url":"https://api.github.com/users/minhngocd","html_url":"https://github.com/minhngocd","followers_url":"https://api.github.com/users/minhngocd/followers","following_url":"https://api.github.com/users/minhngocd/following{/other_user}","gists_url":"https://api.github.com/users/minhngocd/gists{/gist_id}","starred_url":"https://api.github.com/users/minhngocd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minhngocd/subscriptions","organizations_url":"https://api.github.com/users/minhngocd/orgs","repos_url":"https://api.github.com/users/minhngocd/repos","events_url":"https://api.github.com/users/minhngocd/events{/privacy}","received_events_url":"https://api.github.com/users/minhngocd/received_events","type":"User","site_admin":false},{"login":"simonwo","id":4951176,"node_id":"MDQ6VXNlcjQ5NTExNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/4951176?v=4","gravatar_id":"","url":"https://api.github.com/users/simonwo","html_url":"https://github.com/simonwo","followers_url":"https://api.github.com/users/simonwo/followers","following_url":"https://api.github.com/users/simonwo/following{/other_user}","gists_url":"https://api.github.com/users/simonwo/gists{/gist_id}","starred_url":"https://api.github.com/users/simonwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonwo/subscriptions","organizations_url":"https://api.github.com/users/simonwo/orgs","repos_url":"https://api.github.com/users/simonwo/repos","events_url":"https://api.github.com/users/simonwo/events{/privacy}","received_events_url":"https://api.github.com/users/simonwo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/pulls/27/commits","review_comments_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/pulls/27/comments","review_comment_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/issues/27/comments","statuses_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/statuses/06379c8b88746787d7bc88dab08006769acacb88","head":{"label":"alphagov:EID-887-fm","ref":"EID-887-fm","sha":"06379c8b88746787d7bc88dab08006769acacb88","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":122230317,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIyMzAzMTc=","name":"verify-eidas-metadata-aggregator","full_name":"alphagov/verify-eidas-metadata-aggregator","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/verify-eidas-metadata-aggregator","description":"Script to aggregate SAML metadata from EU countries","fork":false,"url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator","forks_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/forks","keys_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/teams","hooks_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/hooks","issue_events_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/events","assignees_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/tags","blobs_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/languages","stargazers_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/stargazers","contributors_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/contributors","subscribers_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/subscribers","subscription_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/subscription","commits_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/merges","archive_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/downloads","issues_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/deployments","created_at":"2018-02-20T17:21:04Z","updated_at":"2018-09-06T13:52:03Z","pushed_at":"2018-09-07T15:48:36Z","git_url":"git://github.com/alphagov/verify-eidas-metadata-aggregator.git","ssh_url":"git@github.com:alphagov/verify-eidas-metadata-aggregator.git","clone_url":"https://github.com/alphagov/verify-eidas-metadata-aggregator.git","svn_url":"https://github.com/alphagov/verify-eidas-metadata-aggregator","homepage":"","size":229,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"a58f4425ce7ab384011cea96258afdbc4153712a","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":122230317,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIyMzAzMTc=","name":"verify-eidas-metadata-aggregator","full_name":"alphagov/verify-eidas-metadata-aggregator","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/verify-eidas-metadata-aggregator","description":"Script to aggregate SAML metadata from EU countries","fork":false,"url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator","forks_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/forks","keys_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/teams","hooks_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/hooks","issue_events_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/events","assignees_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/tags","blobs_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/languages","stargazers_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/stargazers","contributors_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/contributors","subscribers_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/subscribers","subscription_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/subscription","commits_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/merges","archive_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/downloads","issues_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/deployments","created_at":"2018-02-20T17:21:04Z","updated_at":"2018-09-06T13:52:03Z","pushed_at":"2018-09-07T15:48:36Z","git_url":"git://github.com/alphagov/verify-eidas-metadata-aggregator.git","ssh_url":"git@github.com:alphagov/verify-eidas-metadata-aggregator.git","clone_url":"https://github.com/alphagov/verify-eidas-metadata-aggregator.git","svn_url":"https://github.com/alphagov/verify-eidas-metadata-aggregator","homepage":"","size":229,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/pulls/27"},"html":{"href":"https://github.com/alphagov/verify-eidas-metadata-aggregator/pull/27"},"issue":{"href":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/issues/27"},"comments":{"href":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/verify-eidas-metadata-aggregator/statuses/06379c8b88746787d7bc88dab08006769acacb88"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"IreneLau-GDS"}}