{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/23871","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/23871/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/23871/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/23871/events","html_url":"https://github.com/Automattic/wp-calypso/pull/23871","id":310979251,"number":23871,"title":"Implement \"Load More\" buttons for domain registration step","user":{"login":"jsnmoon","id":4044428,"avatar_url":"https://avatars2.githubusercontent.com/u/4044428?v=4","gravatar_id":"","url":"https://api.github.com/users/jsnmoon","html_url":"https://github.com/jsnmoon","followers_url":"https://api.github.com/users/jsnmoon/followers","following_url":"https://api.github.com/users/jsnmoon/following{/other_user}","gists_url":"https://api.github.com/users/jsnmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnmoon/subscriptions","organizations_url":"https://api.github.com/users/jsnmoon/orgs","repos_url":"https://api.github.com/users/jsnmoon/repos","events_url":"https://api.github.com/users/jsnmoon/events{/privacy}","received_events_url":"https://api.github.com/users/jsnmoon/received_events","type":"User","site_admin":false},"labels":[{"id":289076660,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Domains","name":"Domains","color":"006b75","default":false},{"id":285010030,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Ready%20to%20Merge","name":"[Status] Ready to Merge","color":"d4fb79","default":false}],"state":"open","locked":false,"assignee":{"login":"jsnmoon","id":4044428,"avatar_url":"https://avatars2.githubusercontent.com/u/4044428?v=4","gravatar_id":"","url":"https://api.github.com/users/jsnmoon","html_url":"https://github.com/jsnmoon","followers_url":"https://api.github.com/users/jsnmoon/followers","following_url":"https://api.github.com/users/jsnmoon/following{/other_user}","gists_url":"https://api.github.com/users/jsnmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnmoon/subscriptions","organizations_url":"https://api.github.com/users/jsnmoon/orgs","repos_url":"https://api.github.com/users/jsnmoon/repos","events_url":"https://api.github.com/users/jsnmoon/events{/privacy}","received_events_url":"https://api.github.com/users/jsnmoon/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsnmoon","id":4044428,"avatar_url":"https://avatars2.githubusercontent.com/u/4044428?v=4","gravatar_id":"","url":"https://api.github.com/users/jsnmoon","html_url":"https://github.com/jsnmoon","followers_url":"https://api.github.com/users/jsnmoon/followers","following_url":"https://api.github.com/users/jsnmoon/following{/other_user}","gists_url":"https://api.github.com/users/jsnmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnmoon/subscriptions","organizations_url":"https://api.github.com/users/jsnmoon/orgs","repos_url":"https://api.github.com/users/jsnmoon/repos","events_url":"https://api.github.com/users/jsnmoon/events{/privacy}","received_events_url":"https://api.github.com/users/jsnmoon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-04-03T20:07:58Z","updated_at":"2018-04-05T20:30:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/23871","html_url":"https://github.com/Automattic/wp-calypso/pull/23871","diff_url":"https://github.com/Automattic/wp-calypso/pull/23871.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/23871.patch"},"body":"This adds a link button labeled `Show more results` at the bottom of the suggestions list, like so: \r\n\r\n<img width=\"986\" alt=\"Show more results\" src=\"https://user-images.githubusercontent.com/4044428/38272249-f1957916-3745-11e8-88de-b107f6275da7.png\">\r\n\r\nClicking this will append more results below the existing results (once this feature is supported in the API). Currently, no new suggestions are added.\r\n\r\nThis feature is implemented like so:\r\n\r\n- When the user initially loads suggestions, we assume that page to be `page 1`.\r\n- When the user clicks `Show more results`, we make a request for more suggestions with the `page_number` parameter set to `2`.\r\n- Upon receiving the domain suggestion response, we append it to the existing list of search results and show it to the user.\r\n\r\n\r\n# Testing Instructions\r\n1. Spin up your environment locally, which has `domains/kracken-ui` feature flag enabled.\r\n2. Navigate to [`/start/domains`](calypso.localhost:3000/start/domains).\r\n3. Set your localStorage debug like so: `localStorage.debug = 'calypso:domains:register-domain-step'`.\r\n4. Enter a query and ensure that you see a corresponding debug line in the console. (You can also double check with your network panel.)\r\n5. Click `Show more results` and ensure that you see a corresponding debug line containing `page_number: 2` in the request parameter. (Likewise, this will also show up in the network panel.)"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/379066685","html_url":"https://github.com/Automattic/wp-calypso/pull/23871#issuecomment-379066685","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/23871","id":379066685,"user":{"login":"jsnmoon","id":4044428,"avatar_url":"https://avatars2.githubusercontent.com/u/4044428?v=4","gravatar_id":"","url":"https://api.github.com/users/jsnmoon","html_url":"https://github.com/jsnmoon","followers_url":"https://api.github.com/users/jsnmoon/followers","following_url":"https://api.github.com/users/jsnmoon/following{/other_user}","gists_url":"https://api.github.com/users/jsnmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnmoon/subscriptions","organizations_url":"https://api.github.com/users/jsnmoon/orgs","repos_url":"https://api.github.com/users/jsnmoon/repos","events_url":"https://api.github.com/users/jsnmoon/events{/privacy}","received_events_url":"https://api.github.com/users/jsnmoon/received_events","type":"User","site_admin":false},"created_at":"2018-04-05T20:30:05Z","updated_at":"2018-04-05T20:30:05Z","author_association":"CONTRIBUTOR","body":"Thanks Igor! 🎉 "}}
{"actor":{"display_login":"jsnmoon"}}