{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/ghindle/rancher-backup/pulls/1","id":208519336,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NTE5MzM2","html_url":"https://github.com/ghindle/rancher-backup/pull/1","diff_url":"https://github.com/ghindle/rancher-backup/pull/1.diff","patch_url":"https://github.com/ghindle/rancher-backup/pull/1.patch","issue_url":"https://api.github.com/repos/ghindle/rancher-backup/issues/1","number":1,"state":"open","locked":false,"title":"Filter services fetched to \"active services\"","user":{"login":"ghindle","id":47464,"node_id":"MDQ6VXNlcjQ3NDY0","avatar_url":"https://avatars1.githubusercontent.com/u/47464?v=4","gravatar_id":"","url":"https://api.github.com/users/ghindle","html_url":"https://github.com/ghindle","followers_url":"https://api.github.com/users/ghindle/followers","following_url":"https://api.github.com/users/ghindle/following{/other_user}","gists_url":"https://api.github.com/users/ghindle/gists{/gist_id}","starred_url":"https://api.github.com/users/ghindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghindle/subscriptions","organizations_url":"https://api.github.com/users/ghindle/orgs","repos_url":"https://api.github.com/users/ghindle/repos","events_url":"https://api.github.com/users/ghindle/events{/privacy}","received_events_url":"https://api.github.com/users/ghindle/received_events","type":"User","site_admin":false},"body":"I have an environment where we have ~250 services. The Cattle API list services endpoint has a default pagination limit of 100 when no filters are provided therefore a number of our services aren't being \"found\" and therefore not backed up.\r\n\r\nBy moving the filtering from the for loop and into the API call we a reduce the number of entries we need to compare, plus it appears to negate the limit.","created_at":"2018-08-15T09:52:00Z","updated_at":"2018-08-15T09:52:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ghindle/rancher-backup/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ghindle/rancher-backup/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ghindle/rancher-backup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ghindle/rancher-backup/issues/1/comments","statuses_url":"https://api.github.com/repos/ghindle/rancher-backup/statuses/5dfd9fac3eb8e8020b9a056a137ca7e893eb27e5","head":{"label":"ghindle:activeServices","ref":"activeServices","sha":"5dfd9fac3eb8e8020b9a056a137ca7e893eb27e5","user":{"login":"ghindle","id":47464,"node_id":"MDQ6VXNlcjQ3NDY0","avatar_url":"https://avatars1.githubusercontent.com/u/47464?v=4","gravatar_id":"","url":"https://api.github.com/users/ghindle","html_url":"https://github.com/ghindle","followers_url":"https://api.github.com/users/ghindle/followers","following_url":"https://api.github.com/users/ghindle/following{/other_user}","gists_url":"https://api.github.com/users/ghindle/gists{/gist_id}","starred_url":"https://api.github.com/users/ghindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghindle/subscriptions","organizations_url":"https://api.github.com/users/ghindle/orgs","repos_url":"https://api.github.com/users/ghindle/repos","events_url":"https://api.github.com/users/ghindle/events{/privacy}","received_events_url":"https://api.github.com/users/ghindle/received_events","type":"User","site_admin":false},"repo":{"id":144834192,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4MzQxOTI=","name":"rancher-backup","full_name":"ghindle/rancher-backup","owner":{"login":"ghindle","id":47464,"node_id":"MDQ6VXNlcjQ3NDY0","avatar_url":"https://avatars1.githubusercontent.com/u/47464?v=4","gravatar_id":"","url":"https://api.github.com/users/ghindle","html_url":"https://github.com/ghindle","followers_url":"https://api.github.com/users/ghindle/followers","following_url":"https://api.github.com/users/ghindle/following{/other_user}","gists_url":"https://api.github.com/users/ghindle/gists{/gist_id}","starred_url":"https://api.github.com/users/ghindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghindle/subscriptions","organizations_url":"https://api.github.com/users/ghindle/orgs","repos_url":"https://api.github.com/users/ghindle/repos","events_url":"https://api.github.com/users/ghindle/events{/privacy}","received_events_url":"https://api.github.com/users/ghindle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghindle/rancher-backup","description":null,"fork":true,"url":"https://api.github.com/repos/ghindle/rancher-backup","forks_url":"https://api.github.com/repos/ghindle/rancher-backup/forks","keys_url":"https://api.github.com/repos/ghindle/rancher-backup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghindle/rancher-backup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghindle/rancher-backup/teams","hooks_url":"https://api.github.com/repos/ghindle/rancher-backup/hooks","issue_events_url":"https://api.github.com/repos/ghindle/rancher-backup/issues/events{/number}","events_url":"https://api.github.com/repos/ghindle/rancher-backup/events","assignees_url":"https://api.github.com/repos/ghindle/rancher-backup/assignees{/user}","branches_url":"https://api.github.com/repos/ghindle/rancher-backup/branches{/branch}","tags_url":"https://api.github.com/repos/ghindle/rancher-backup/tags","blobs_url":"https://api.github.com/repos/ghindle/rancher-backup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghindle/rancher-backup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghindle/rancher-backup/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghindle/rancher-backup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghindle/rancher-backup/statuses/{sha}","languages_url":"https://api.github.com/repos/ghindle/rancher-backup/languages","stargazers_url":"https://api.github.com/repos/ghindle/rancher-backup/stargazers","contributors_url":"https://api.github.com/repos/ghindle/rancher-backup/contributors","subscribers_url":"https://api.github.com/repos/ghindle/rancher-backup/subscribers","subscription_url":"https://api.github.com/repos/ghindle/rancher-backup/subscription","commits_url":"https://api.github.com/repos/ghindle/rancher-backup/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghindle/rancher-backup/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghindle/rancher-backup/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghindle/rancher-backup/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghindle/rancher-backup/contents/{+path}","compare_url":"https://api.github.com/repos/ghindle/rancher-backup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghindle/rancher-backup/merges","archive_url":"https://api.github.com/repos/ghindle/rancher-backup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghindle/rancher-backup/downloads","issues_url":"https://api.github.com/repos/ghindle/rancher-backup/issues{/number}","pulls_url":"https://api.github.com/repos/ghindle/rancher-backup/pulls{/number}","milestones_url":"https://api.github.com/repos/ghindle/rancher-backup/milestones{/number}","notifications_url":"https://api.github.com/repos/ghindle/rancher-backup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghindle/rancher-backup/labels{/name}","releases_url":"https://api.github.com/repos/ghindle/rancher-backup/releases{/id}","deployments_url":"https://api.github.com/repos/ghindle/rancher-backup/deployments","created_at":"2018-08-15T09:33:45Z","updated_at":"2018-08-15T09:33:47Z","pushed_at":"2018-08-15T09:38:37Z","git_url":"git://github.com/ghindle/rancher-backup.git","ssh_url":"git@github.com:ghindle/rancher-backup.git","clone_url":"https://github.com/ghindle/rancher-backup.git","svn_url":"https://github.com/ghindle/rancher-backup","homepage":null,"size":158,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ghindle:develop","ref":"develop","sha":"45f8ac26b5d263324ef1a66474207752b5164f50","user":{"login":"ghindle","id":47464,"node_id":"MDQ6VXNlcjQ3NDY0","avatar_url":"https://avatars1.githubusercontent.com/u/47464?v=4","gravatar_id":"","url":"https://api.github.com/users/ghindle","html_url":"https://github.com/ghindle","followers_url":"https://api.github.com/users/ghindle/followers","following_url":"https://api.github.com/users/ghindle/following{/other_user}","gists_url":"https://api.github.com/users/ghindle/gists{/gist_id}","starred_url":"https://api.github.com/users/ghindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghindle/subscriptions","organizations_url":"https://api.github.com/users/ghindle/orgs","repos_url":"https://api.github.com/users/ghindle/repos","events_url":"https://api.github.com/users/ghindle/events{/privacy}","received_events_url":"https://api.github.com/users/ghindle/received_events","type":"User","site_admin":false},"repo":{"id":144834192,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4MzQxOTI=","name":"rancher-backup","full_name":"ghindle/rancher-backup","owner":{"login":"ghindle","id":47464,"node_id":"MDQ6VXNlcjQ3NDY0","avatar_url":"https://avatars1.githubusercontent.com/u/47464?v=4","gravatar_id":"","url":"https://api.github.com/users/ghindle","html_url":"https://github.com/ghindle","followers_url":"https://api.github.com/users/ghindle/followers","following_url":"https://api.github.com/users/ghindle/following{/other_user}","gists_url":"https://api.github.com/users/ghindle/gists{/gist_id}","starred_url":"https://api.github.com/users/ghindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghindle/subscriptions","organizations_url":"https://api.github.com/users/ghindle/orgs","repos_url":"https://api.github.com/users/ghindle/repos","events_url":"https://api.github.com/users/ghindle/events{/privacy}","received_events_url":"https://api.github.com/users/ghindle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghindle/rancher-backup","description":null,"fork":true,"url":"https://api.github.com/repos/ghindle/rancher-backup","forks_url":"https://api.github.com/repos/ghindle/rancher-backup/forks","keys_url":"https://api.github.com/repos/ghindle/rancher-backup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghindle/rancher-backup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghindle/rancher-backup/teams","hooks_url":"https://api.github.com/repos/ghindle/rancher-backup/hooks","issue_events_url":"https://api.github.com/repos/ghindle/rancher-backup/issues/events{/number}","events_url":"https://api.github.com/repos/ghindle/rancher-backup/events","assignees_url":"https://api.github.com/repos/ghindle/rancher-backup/assignees{/user}","branches_url":"https://api.github.com/repos/ghindle/rancher-backup/branches{/branch}","tags_url":"https://api.github.com/repos/ghindle/rancher-backup/tags","blobs_url":"https://api.github.com/repos/ghindle/rancher-backup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghindle/rancher-backup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghindle/rancher-backup/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghindle/rancher-backup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghindle/rancher-backup/statuses/{sha}","languages_url":"https://api.github.com/repos/ghindle/rancher-backup/languages","stargazers_url":"https://api.github.com/repos/ghindle/rancher-backup/stargazers","contributors_url":"https://api.github.com/repos/ghindle/rancher-backup/contributors","subscribers_url":"https://api.github.com/repos/ghindle/rancher-backup/subscribers","subscription_url":"https://api.github.com/repos/ghindle/rancher-backup/subscription","commits_url":"https://api.github.com/repos/ghindle/rancher-backup/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghindle/rancher-backup/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghindle/rancher-backup/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghindle/rancher-backup/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghindle/rancher-backup/contents/{+path}","compare_url":"https://api.github.com/repos/ghindle/rancher-backup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghindle/rancher-backup/merges","archive_url":"https://api.github.com/repos/ghindle/rancher-backup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghindle/rancher-backup/downloads","issues_url":"https://api.github.com/repos/ghindle/rancher-backup/issues{/number}","pulls_url":"https://api.github.com/repos/ghindle/rancher-backup/pulls{/number}","milestones_url":"https://api.github.com/repos/ghindle/rancher-backup/milestones{/number}","notifications_url":"https://api.github.com/repos/ghindle/rancher-backup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghindle/rancher-backup/labels{/name}","releases_url":"https://api.github.com/repos/ghindle/rancher-backup/releases{/id}","deployments_url":"https://api.github.com/repos/ghindle/rancher-backup/deployments","created_at":"2018-08-15T09:33:45Z","updated_at":"2018-08-15T09:33:47Z","pushed_at":"2018-08-15T09:38:37Z","git_url":"git://github.com/ghindle/rancher-backup.git","ssh_url":"git@github.com:ghindle/rancher-backup.git","clone_url":"https://github.com/ghindle/rancher-backup.git","svn_url":"https://github.com/ghindle/rancher-backup","homepage":null,"size":158,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ghindle/rancher-backup/pulls/1"},"html":{"href":"https://github.com/ghindle/rancher-backup/pull/1"},"issue":{"href":"https://api.github.com/repos/ghindle/rancher-backup/issues/1"},"comments":{"href":"https://api.github.com/repos/ghindle/rancher-backup/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ghindle/rancher-backup/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ghindle/rancher-backup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ghindle/rancher-backup/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ghindle/rancher-backup/statuses/5dfd9fac3eb8e8020b9a056a137ca7e893eb27e5"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"ghindle"}}