{"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/mailgun/sandra/pulls/13","id":227049194,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MDQ5MTk0","html_url":"https://github.com/mailgun/sandra/pull/13","diff_url":"https://github.com/mailgun/sandra/pull/13.diff","patch_url":"https://github.com/mailgun/sandra/pull/13.patch","issue_url":"https://api.github.com/repos/mailgun/sandra/issues/13","number":13,"state":"closed","locked":false,"title":"CassandraConfig.DataCenter is now optional","user":{"login":"thrawn01","id":9817,"node_id":"MDQ6VXNlcjk4MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/9817?v=4","gravatar_id":"","url":"https://api.github.com/users/thrawn01","html_url":"https://github.com/thrawn01","followers_url":"https://api.github.com/users/thrawn01/followers","following_url":"https://api.github.com/users/thrawn01/following{/other_user}","gists_url":"https://api.github.com/users/thrawn01/gists{/gist_id}","starred_url":"https://api.github.com/users/thrawn01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thrawn01/subscriptions","organizations_url":"https://api.github.com/users/thrawn01/orgs","repos_url":"https://api.github.com/users/thrawn01/repos","events_url":"https://api.github.com/users/thrawn01/events{/privacy}","received_events_url":"https://api.github.com/users/thrawn01/received_events","type":"User","site_admin":false},"body":"## Purpose\r\nSince our production Cassandra environment has a multi datacenter configuration gocql will by default connect to all nodes found via node discovery. To ensure that a service only connects to data center local nodes in the cluster a `DataCenter` designation is used to filter out those nodes that are not in the local datacenter.  \r\n\r\nHowever when connecting to a local Cassandra node running in a docker container the datacenter is empty string `\"\"`. In order for gocql to connect to such a node the config must be allowed to specify a `DataCenter` as an empty string. This PR makes the `DataCenter` config optional, IE: allows `DataCenter` to be empty without resulting in an error if loaded with `mailgun/cfg`","created_at":"2018-10-30T19:17:51Z","updated_at":"2018-10-31T02:37:11Z","closed_at":"2018-10-31T02:37:11Z","merged_at":"2018-10-31T02:37:10Z","merge_commit_sha":"8532ca15c9e45abca2027936beef6798aae509d4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mailgun/sandra/pulls/13/commits","review_comments_url":"https://api.github.com/repos/mailgun/sandra/pulls/13/comments","review_comment_url":"https://api.github.com/repos/mailgun/sandra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mailgun/sandra/issues/13/comments","statuses_url":"https://api.github.com/repos/mailgun/sandra/statuses/e9c1362250b4e57a58f50df1a06f440df1cf847a","head":{"label":"mailgun:thrawn/develop","ref":"thrawn/develop","sha":"e9c1362250b4e57a58f50df1a06f440df1cf847a","user":{"login":"mailgun","id":447686,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NzY4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/447686?v=4","gravatar_id":"","url":"https://api.github.com/users/mailgun","html_url":"https://github.com/mailgun","followers_url":"https://api.github.com/users/mailgun/followers","following_url":"https://api.github.com/users/mailgun/following{/other_user}","gists_url":"https://api.github.com/users/mailgun/gists{/gist_id}","starred_url":"https://api.github.com/users/mailgun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mailgun/subscriptions","organizations_url":"https://api.github.com/users/mailgun/orgs","repos_url":"https://api.github.com/users/mailgun/repos","events_url":"https://api.github.com/users/mailgun/events{/privacy}","received_events_url":"https://api.github.com/users/mailgun/received_events","type":"Organization","site_admin":false},"repo":{"id":23930960,"node_id":"MDEwOlJlcG9zaXRvcnkyMzkzMDk2MA==","name":"sandra","full_name":"mailgun/sandra","private":false,"owner":{"login":"mailgun","id":447686,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NzY4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/447686?v=4","gravatar_id":"","url":"https://api.github.com/users/mailgun","html_url":"https://github.com/mailgun","followers_url":"https://api.github.com/users/mailgun/followers","following_url":"https://api.github.com/users/mailgun/following{/other_user}","gists_url":"https://api.github.com/users/mailgun/gists{/gist_id}","starred_url":"https://api.github.com/users/mailgun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mailgun/subscriptions","organizations_url":"https://api.github.com/users/mailgun/orgs","repos_url":"https://api.github.com/users/mailgun/repos","events_url":"https://api.github.com/users/mailgun/events{/privacy}","received_events_url":"https://api.github.com/users/mailgun/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mailgun/sandra","description":"Go library providing some convenience wrappers around gocql.","fork":false,"url":"https://api.github.com/repos/mailgun/sandra","forks_url":"https://api.github.com/repos/mailgun/sandra/forks","keys_url":"https://api.github.com/repos/mailgun/sandra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mailgun/sandra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mailgun/sandra/teams","hooks_url":"https://api.github.com/repos/mailgun/sandra/hooks","issue_events_url":"https://api.github.com/repos/mailgun/sandra/issues/events{/number}","events_url":"https://api.github.com/repos/mailgun/sandra/events","assignees_url":"https://api.github.com/repos/mailgun/sandra/assignees{/user}","branches_url":"https://api.github.com/repos/mailgun/sandra/branches{/branch}","tags_url":"https://api.github.com/repos/mailgun/sandra/tags","blobs_url":"https://api.github.com/repos/mailgun/sandra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mailgun/sandra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mailgun/sandra/git/refs{/sha}","trees_url":"https://api.github.com/repos/mailgun/sandra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mailgun/sandra/statuses/{sha}","languages_url":"https://api.github.com/repos/mailgun/sandra/languages","stargazers_url":"https://api.github.com/repos/mailgun/sandra/stargazers","contributors_url":"https://api.github.com/repos/mailgun/sandra/contributors","subscribers_url":"https://api.github.com/repos/mailgun/sandra/subscribers","subscription_url":"https://api.github.com/repos/mailgun/sandra/subscription","commits_url":"https://api.github.com/repos/mailgun/sandra/commits{/sha}","git_commits_url":"https://api.github.com/repos/mailgun/sandra/git/commits{/sha}","comments_url":"https://api.github.com/repos/mailgun/sandra/comments{/number}","issue_comment_url":"https://api.github.com/repos/mailgun/sandra/issues/comments{/number}","contents_url":"https://api.github.com/repos/mailgun/sandra/contents/{+path}","compare_url":"https://api.github.com/repos/mailgun/sandra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mailgun/sandra/merges","archive_url":"https://api.github.com/repos/mailgun/sandra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mailgun/sandra/downloads","issues_url":"https://api.github.com/repos/mailgun/sandra/issues{/number}","pulls_url":"https://api.github.com/repos/mailgun/sandra/pulls{/number}","milestones_url":"https://api.github.com/repos/mailgun/sandra/milestones{/number}","notifications_url":"https://api.github.com/repos/mailgun/sandra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mailgun/sandra/labels{/name}","releases_url":"https://api.github.com/repos/mailgun/sandra/releases{/id}","deployments_url":"https://api.github.com/repos/mailgun/sandra/deployments","created_at":"2014-09-11T18:42:44Z","updated_at":"2018-10-01T12:03:27Z","pushed_at":"2018-10-31T02:37:10Z","git_url":"git://github.com/mailgun/sandra.git","ssh_url":"git@github.com:mailgun/sandra.git","clone_url":"https://github.com/mailgun/sandra.git","svn_url":"https://github.com/mailgun/sandra","homepage":null,"size":26,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":0,"watchers":8,"default_branch":"master"}},"base":{"label":"mailgun:master","ref":"master","sha":"84a99d62f665474a77b81371e65d6b95061072e8","user":{"login":"mailgun","id":447686,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NzY4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/447686?v=4","gravatar_id":"","url":"https://api.github.com/users/mailgun","html_url":"https://github.com/mailgun","followers_url":"https://api.github.com/users/mailgun/followers","following_url":"https://api.github.com/users/mailgun/following{/other_user}","gists_url":"https://api.github.com/users/mailgun/gists{/gist_id}","starred_url":"https://api.github.com/users/mailgun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mailgun/subscriptions","organizations_url":"https://api.github.com/users/mailgun/orgs","repos_url":"https://api.github.com/users/mailgun/repos","events_url":"https://api.github.com/users/mailgun/events{/privacy}","received_events_url":"https://api.github.com/users/mailgun/received_events","type":"Organization","site_admin":false},"repo":{"id":23930960,"node_id":"MDEwOlJlcG9zaXRvcnkyMzkzMDk2MA==","name":"sandra","full_name":"mailgun/sandra","private":false,"owner":{"login":"mailgun","id":447686,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0NzY4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/447686?v=4","gravatar_id":"","url":"https://api.github.com/users/mailgun","html_url":"https://github.com/mailgun","followers_url":"https://api.github.com/users/mailgun/followers","following_url":"https://api.github.com/users/mailgun/following{/other_user}","gists_url":"https://api.github.com/users/mailgun/gists{/gist_id}","starred_url":"https://api.github.com/users/mailgun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mailgun/subscriptions","organizations_url":"https://api.github.com/users/mailgun/orgs","repos_url":"https://api.github.com/users/mailgun/repos","events_url":"https://api.github.com/users/mailgun/events{/privacy}","received_events_url":"https://api.github.com/users/mailgun/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mailgun/sandra","description":"Go library providing some convenience wrappers around gocql.","fork":false,"url":"https://api.github.com/repos/mailgun/sandra","forks_url":"https://api.github.com/repos/mailgun/sandra/forks","keys_url":"https://api.github.com/repos/mailgun/sandra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mailgun/sandra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mailgun/sandra/teams","hooks_url":"https://api.github.com/repos/mailgun/sandra/hooks","issue_events_url":"https://api.github.com/repos/mailgun/sandra/issues/events{/number}","events_url":"https://api.github.com/repos/mailgun/sandra/events","assignees_url":"https://api.github.com/repos/mailgun/sandra/assignees{/user}","branches_url":"https://api.github.com/repos/mailgun/sandra/branches{/branch}","tags_url":"https://api.github.com/repos/mailgun/sandra/tags","blobs_url":"https://api.github.com/repos/mailgun/sandra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mailgun/sandra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mailgun/sandra/git/refs{/sha}","trees_url":"https://api.github.com/repos/mailgun/sandra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mailgun/sandra/statuses/{sha}","languages_url":"https://api.github.com/repos/mailgun/sandra/languages","stargazers_url":"https://api.github.com/repos/mailgun/sandra/stargazers","contributors_url":"https://api.github.com/repos/mailgun/sandra/contributors","subscribers_url":"https://api.github.com/repos/mailgun/sandra/subscribers","subscription_url":"https://api.github.com/repos/mailgun/sandra/subscription","commits_url":"https://api.github.com/repos/mailgun/sandra/commits{/sha}","git_commits_url":"https://api.github.com/repos/mailgun/sandra/git/commits{/sha}","comments_url":"https://api.github.com/repos/mailgun/sandra/comments{/number}","issue_comment_url":"https://api.github.com/repos/mailgun/sandra/issues/comments{/number}","contents_url":"https://api.github.com/repos/mailgun/sandra/contents/{+path}","compare_url":"https://api.github.com/repos/mailgun/sandra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mailgun/sandra/merges","archive_url":"https://api.github.com/repos/mailgun/sandra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mailgun/sandra/downloads","issues_url":"https://api.github.com/repos/mailgun/sandra/issues{/number}","pulls_url":"https://api.github.com/repos/mailgun/sandra/pulls{/number}","milestones_url":"https://api.github.com/repos/mailgun/sandra/milestones{/number}","notifications_url":"https://api.github.com/repos/mailgun/sandra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mailgun/sandra/labels{/name}","releases_url":"https://api.github.com/repos/mailgun/sandra/releases{/id}","deployments_url":"https://api.github.com/repos/mailgun/sandra/deployments","created_at":"2014-09-11T18:42:44Z","updated_at":"2018-10-01T12:03:27Z","pushed_at":"2018-10-31T02:37:10Z","git_url":"git://github.com/mailgun/sandra.git","ssh_url":"git@github.com:mailgun/sandra.git","clone_url":"https://github.com/mailgun/sandra.git","svn_url":"https://github.com/mailgun/sandra","homepage":null,"size":26,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":0,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mailgun/sandra/pulls/13"},"html":{"href":"https://github.com/mailgun/sandra/pull/13"},"issue":{"href":"https://api.github.com/repos/mailgun/sandra/issues/13"},"comments":{"href":"https://api.github.com/repos/mailgun/sandra/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/mailgun/sandra/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/mailgun/sandra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mailgun/sandra/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/mailgun/sandra/statuses/e9c1362250b4e57a58f50df1a06f440df1cf847a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"thrawn01","id":9817,"node_id":"MDQ6VXNlcjk4MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/9817?v=4","gravatar_id":"","url":"https://api.github.com/users/thrawn01","html_url":"https://github.com/thrawn01","followers_url":"https://api.github.com/users/thrawn01/followers","following_url":"https://api.github.com/users/thrawn01/following{/other_user}","gists_url":"https://api.github.com/users/thrawn01/gists{/gist_id}","starred_url":"https://api.github.com/users/thrawn01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thrawn01/subscriptions","organizations_url":"https://api.github.com/users/thrawn01/orgs","repos_url":"https://api.github.com/users/thrawn01/repos","events_url":"https://api.github.com/users/thrawn01/events{/privacy}","received_events_url":"https://api.github.com/users/thrawn01/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":13,"changed_files":1}}
{"actor":{"display_login":"thrawn01"}}