{"action":"created","issue":{"url":"https://api.github.com/repos/kata-containers/agent/issues/380","repository_url":"https://api.github.com/repos/kata-containers/agent","labels_url":"https://api.github.com/repos/kata-containers/agent/issues/380/labels{/name}","comments_url":"https://api.github.com/repos/kata-containers/agent/issues/380/comments","events_url":"https://api.github.com/repos/kata-containers/agent/issues/380/events","html_url":"https://github.com/kata-containers/agent/pull/380","id":362009771,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2ODM4Mjg4","number":380,"title":"fix up remaining issues with pci hotplug and uevent listening","user":{"login":"bergwolf","id":88972,"node_id":"MDQ6VXNlcjg4OTcy","avatar_url":"https://avatars0.githubusercontent.com/u/88972?v=4","gravatar_id":"","url":"https://api.github.com/users/bergwolf","html_url":"https://github.com/bergwolf","followers_url":"https://api.github.com/users/bergwolf/followers","following_url":"https://api.github.com/users/bergwolf/following{/other_user}","gists_url":"https://api.github.com/users/bergwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/bergwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergwolf/subscriptions","organizations_url":"https://api.github.com/users/bergwolf/orgs","repos_url":"https://api.github.com/users/bergwolf/repos","events_url":"https://api.github.com/users/bergwolf/events{/privacy}","received_events_url":"https://api.github.com/users/bergwolf/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-09-20T03:59:08Z","updated_at":"2018-09-21T19:49:07Z","closed_at":"2018-09-21T04:06:23Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kata-containers/agent/pulls/380","html_url":"https://github.com/kata-containers/agent/pull/380","diff_url":"https://github.com/kata-containers/agent/pull/380.diff","patch_url":"https://github.com/kata-containers/agent/pull/380.patch"},"body":"1. rescan pci bus before waiting for a new device\r\n2. fix redefined notify channel when waiting for a new device\r\n\r\nFixes: #372\r\n\r\nI made this depends on #375 since they both modify the same function and would naturally conflict."},"comment":{"url":"https://api.github.com/repos/kata-containers/agent/issues/comments/423651880","html_url":"https://github.com/kata-containers/agent/pull/380#issuecomment-423651880","issue_url":"https://api.github.com/repos/kata-containers/agent/issues/380","id":423651880,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzY1MTg4MA==","user":{"login":"amshinde","id":7132811,"node_id":"MDQ6VXNlcjcxMzI4MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/7132811?v=4","gravatar_id":"","url":"https://api.github.com/users/amshinde","html_url":"https://github.com/amshinde","followers_url":"https://api.github.com/users/amshinde/followers","following_url":"https://api.github.com/users/amshinde/following{/other_user}","gists_url":"https://api.github.com/users/amshinde/gists{/gist_id}","starred_url":"https://api.github.com/users/amshinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amshinde/subscriptions","organizations_url":"https://api.github.com/users/amshinde/orgs","repos_url":"https://api.github.com/users/amshinde/repos","events_url":"https://api.github.com/users/amshinde/events{/privacy}","received_events_url":"https://api.github.com/users/amshinde/received_events","type":"User","site_admin":false},"created_at":"2018-09-21T19:49:07Z","updated_at":"2018-09-21T19:49:07Z","author_association":"CONTRIBUTOR","body":"@sboeuf Thanks for summarising our findings. In conclusion:\r\nIt always makes sense to leave SHPC on for a pci-bridge.\r\n\r\nWith the current hotplug implementation for `q35` in virtcontainers with pci-bridge, we need to rescan the pci bus because of the 5 second delay in the shpc controller. \r\nSince this is not required for `pc`, we can do better and pass an extra parameter to the agent telling it to scan the bus or not. I am not sure how expensive scanning the bus would get, when large number of devices are attached.\r\n\r\nAnother point to consider with q35 hotplug is that by  attaching pcie devices to a pci-bridge we lose out on the pcie capabilities of the device, since the device is exposed as a pci device. We lose out on all the advantages of pcie which we would get with `q35` platform. Hence, what we really need to do is to revisit q35 hotplug in virtcontainers and implement the hotplug using pcie root ports instead of a pci-bridge.\r\n\r\ncc @devimc \r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"amshinde"}}