{"action":"created","comment":{"url":"https://api.github.com/repos/square/misk/pulls/comments/168781633","pull_request_review_id":97207470,"id":168781633,"diff_hunk":"@@ -0,0 +1,24 @@\n+package misk.wire","path":"misk/src/main/kotlin/misk/wire/AbstractClientCommand.kt","position":1,"original_position":1,"commit_id":"d24100505c61b07002e6c8954d6aa7cd47bd7171","original_commit_id":"d24100505c61b07002e6c8954d6aa7cd47bd7171","user":{"login":"mmihic","id":392793,"avatar_url":"https://avatars0.githubusercontent.com/u/392793?v=4","gravatar_id":"","url":"https://api.github.com/users/mmihic","html_url":"https://github.com/mmihic","followers_url":"https://api.github.com/users/mmihic/followers","following_url":"https://api.github.com/users/mmihic/following{/other_user}","gists_url":"https://api.github.com/users/mmihic/gists{/gist_id}","starred_url":"https://api.github.com/users/mmihic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmihic/subscriptions","organizations_url":"https://api.github.com/users/mmihic/orgs","repos_url":"https://api.github.com/users/mmihic/repos","events_url":"https://api.github.com/users/mmihic/events{/privacy}","received_events_url":"https://api.github.com/users/mmihic/received_events","type":"User","site_admin":false},"body":"I'm not sure this is sufficient value-add to add at the misk-level - the only thing it's really doing is defining a parameter for passing in the URL. I think that should just be left to the applications.","created_at":"2018-02-16T15:09:42Z","updated_at":"2018-02-16T15:09:54Z","html_url":"https://github.com/square/misk/pull/98#discussion_r168781633","pull_request_url":"https://api.github.com/repos/square/misk/pulls/98","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/square/misk/pulls/comments/168781633"},"html":{"href":"https://github.com/square/misk/pull/98#discussion_r168781633"},"pull_request":{"href":"https://api.github.com/repos/square/misk/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/square/misk/pulls/98","id":169645671,"html_url":"https://github.com/square/misk/pull/98","diff_url":"https://github.com/square/misk/pull/98.diff","patch_url":"https://github.com/square/misk/pull/98.patch","issue_url":"https://api.github.com/repos/square/misk/issues/98","number":98,"state":"open","locked":false,"title":"Add utility classes for marshalling Wire Messages into HTTP requests","user":{"login":"eeSeeGee","id":4116883,"avatar_url":"https://avatars1.githubusercontent.com/u/4116883?v=4","gravatar_id":"","url":"https://api.github.com/users/eeSeeGee","html_url":"https://github.com/eeSeeGee","followers_url":"https://api.github.com/users/eeSeeGee/followers","following_url":"https://api.github.com/users/eeSeeGee/following{/other_user}","gists_url":"https://api.github.com/users/eeSeeGee/gists{/gist_id}","starred_url":"https://api.github.com/users/eeSeeGee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeSeeGee/subscriptions","organizations_url":"https://api.github.com/users/eeSeeGee/orgs","repos_url":"https://api.github.com/users/eeSeeGee/repos","events_url":"https://api.github.com/users/eeSeeGee/events{/privacy}","received_events_url":"https://api.github.com/users/eeSeeGee/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-16T15:02:23Z","updated_at":"2018-02-16T15:09:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb4e3ff2b8675ffcc739784f5576e4b5c3bbd8cd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/square/misk/pulls/98/commits","review_comments_url":"https://api.github.com/repos/square/misk/pulls/98/comments","review_comment_url":"https://api.github.com/repos/square/misk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/misk/issues/98/comments","statuses_url":"https://api.github.com/repos/square/misk/statuses/d24100505c61b07002e6c8954d6aa7cd47bd7171","head":{"label":"square:proto_http_utils","ref":"proto_http_utils","sha":"d24100505c61b07002e6c8954d6aa7cd47bd7171","user":{"login":"square","id":82592,"avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":113107217,"name":"misk","full_name":"square/misk","owner":{"login":"square","id":82592,"avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/misk","description":null,"fork":false,"url":"https://api.github.com/repos/square/misk","forks_url":"https://api.github.com/repos/square/misk/forks","keys_url":"https://api.github.com/repos/square/misk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/misk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/misk/teams","hooks_url":"https://api.github.com/repos/square/misk/hooks","issue_events_url":"https://api.github.com/repos/square/misk/issues/events{/number}","events_url":"https://api.github.com/repos/square/misk/events","assignees_url":"https://api.github.com/repos/square/misk/assignees{/user}","branches_url":"https://api.github.com/repos/square/misk/branches{/branch}","tags_url":"https://api.github.com/repos/square/misk/tags","blobs_url":"https://api.github.com/repos/square/misk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/misk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/misk/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/misk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/misk/statuses/{sha}","languages_url":"https://api.github.com/repos/square/misk/languages","stargazers_url":"https://api.github.com/repos/square/misk/stargazers","contributors_url":"https://api.github.com/repos/square/misk/contributors","subscribers_url":"https://api.github.com/repos/square/misk/subscribers","subscription_url":"https://api.github.com/repos/square/misk/subscription","commits_url":"https://api.github.com/repos/square/misk/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/misk/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/misk/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/misk/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/misk/contents/{+path}","compare_url":"https://api.github.com/repos/square/misk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/misk/merges","archive_url":"https://api.github.com/repos/square/misk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/misk/downloads","issues_url":"https://api.github.com/repos/square/misk/issues{/number}","pulls_url":"https://api.github.com/repos/square/misk/pulls{/number}","milestones_url":"https://api.github.com/repos/square/misk/milestones{/number}","notifications_url":"https://api.github.com/repos/square/misk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/misk/labels{/name}","releases_url":"https://api.github.com/repos/square/misk/releases{/id}","deployments_url":"https://api.github.com/repos/square/misk/deployments","created_at":"2017-12-04T23:31:52Z","updated_at":"2018-02-12T02:49:43Z","pushed_at":"2018-02-16T15:02:23Z","git_url":"git://github.com/square/misk.git","ssh_url":"git@github.com:square/misk.git","clone_url":"https://github.com/square/misk.git","svn_url":"https://github.com/square/misk","homepage":null,"size":353,"stargazers_count":28,"watchers_count":28,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":3,"open_issues":24,"watchers":28,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"f137d8856971445076f698d72bbc030eb332f9a8","user":{"login":"square","id":82592,"avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":113107217,"name":"misk","full_name":"square/misk","owner":{"login":"square","id":82592,"avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/misk","description":null,"fork":false,"url":"https://api.github.com/repos/square/misk","forks_url":"https://api.github.com/repos/square/misk/forks","keys_url":"https://api.github.com/repos/square/misk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/misk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/misk/teams","hooks_url":"https://api.github.com/repos/square/misk/hooks","issue_events_url":"https://api.github.com/repos/square/misk/issues/events{/number}","events_url":"https://api.github.com/repos/square/misk/events","assignees_url":"https://api.github.com/repos/square/misk/assignees{/user}","branches_url":"https://api.github.com/repos/square/misk/branches{/branch}","tags_url":"https://api.github.com/repos/square/misk/tags","blobs_url":"https://api.github.com/repos/square/misk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/misk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/misk/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/misk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/misk/statuses/{sha}","languages_url":"https://api.github.com/repos/square/misk/languages","stargazers_url":"https://api.github.com/repos/square/misk/stargazers","contributors_url":"https://api.github.com/repos/square/misk/contributors","subscribers_url":"https://api.github.com/repos/square/misk/subscribers","subscription_url":"https://api.github.com/repos/square/misk/subscription","commits_url":"https://api.github.com/repos/square/misk/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/misk/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/misk/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/misk/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/misk/contents/{+path}","compare_url":"https://api.github.com/repos/square/misk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/misk/merges","archive_url":"https://api.github.com/repos/square/misk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/misk/downloads","issues_url":"https://api.github.com/repos/square/misk/issues{/number}","pulls_url":"https://api.github.com/repos/square/misk/pulls{/number}","milestones_url":"https://api.github.com/repos/square/misk/milestones{/number}","notifications_url":"https://api.github.com/repos/square/misk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/misk/labels{/name}","releases_url":"https://api.github.com/repos/square/misk/releases{/id}","deployments_url":"https://api.github.com/repos/square/misk/deployments","created_at":"2017-12-04T23:31:52Z","updated_at":"2018-02-12T02:49:43Z","pushed_at":"2018-02-16T15:02:23Z","git_url":"git://github.com/square/misk.git","ssh_url":"git@github.com:square/misk.git","clone_url":"https://github.com/square/misk.git","svn_url":"https://github.com/square/misk","homepage":null,"size":353,"stargazers_count":28,"watchers_count":28,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":3,"open_issues":24,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/misk/pulls/98"},"html":{"href":"https://github.com/square/misk/pull/98"},"issue":{"href":"https://api.github.com/repos/square/misk/issues/98"},"comments":{"href":"https://api.github.com/repos/square/misk/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/square/misk/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/square/misk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/misk/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/square/misk/statuses/d24100505c61b07002e6c8954d6aa7cd47bd7171"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mmihic"}}