{"action":"closed","number":167,"pull_request":{"url":"https://api.github.com/repos/aviabird/snitch/pulls/167","id":212720508,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNzIwNTA4","html_url":"https://github.com/aviabird/snitch/pull/167","diff_url":"https://github.com/aviabird/snitch/pull/167.diff","patch_url":"https://github.com/aviabird/snitch/pull/167.patch","issue_url":"https://api.github.com/repos/aviabird/snitch/issues/167","number":167,"state":"closed","locked":false,"title":"Add images to Product Brands.","user":{"login":"arjun289","id":9413385,"node_id":"MDQ6VXNlcjk0MTMzODU=","avatar_url":"https://avatars0.githubusercontent.com/u/9413385?v=4","gravatar_id":"","url":"https://api.github.com/users/arjun289","html_url":"https://github.com/arjun289","followers_url":"https://api.github.com/users/arjun289/followers","following_url":"https://api.github.com/users/arjun289/following{/other_user}","gists_url":"https://api.github.com/users/arjun289/gists{/gist_id}","starred_url":"https://api.github.com/users/arjun289/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjun289/subscriptions","organizations_url":"https://api.github.com/users/arjun289/orgs","repos_url":"https://api.github.com/users/arjun289/repos","events_url":"https://api.github.com/users/arjun289/events{/privacy}","received_events_url":"https://api.github.com/users/arjun289/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n<!--- in NOT MORE THAN 50 characters. Keep it short, pls. -->\r\nAdd images to product brands.\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n<!--- If it delivers a story on the Pivotal tracker, please link to it here. -->\r\nProduct brands only had a name field earlier associated with it. Every product brand\r\nneeds to have a logo associated with it.\r\n## Describe your changes\r\n<!--- List and detail all changes made in this PR. -->\r\nThis change\r\n- Adds functionality to associate a logo with the brand. The admin can now upload an image while creating a new product brand.\r\n- At present, the image added is put in the local storage.\r\n## Any further comments?\r\nMigrations\r\nAdded a migration for product_brand_images.\r\n\r\n<!-- If this is a relatively large or complex change, kick off the discussion by -->\r\n<!-- explaining why you chose the solution you did and what alternatives you -->\r\n<!-- considered, etc... -->\r\n\r\n------\r\n\r\n## Checklist\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] I have read [CONTRIBUTING.md][contributing].\r\n- [ ] My code follows the [style guidelines][contributing] of this project.\r\n- [ ] I have commented my code, particularly in hard-to-understand areas.\r\n- [ ] My code does not generate any (new) [`credo`][credo] and compile-time warnings.\r\n- [ ] I have updated the documentation wherever necessary.\r\n- [ ] I have added tests to cover my changes.\r\n\r\n[contributing]: https://github.com/aviabird/snitch/CONTRIBUTING.md\r\n[credo]: https://github.com/rrrene/credo\r\n\r\n<!--- DO NOT REMOVE SECTION BELOW -->\r\n------\r\nDear Gatekeeper,\r\n\r\nPlease make sure that the commits that will be merged or rebased into the base\r\nbranch are [formatted according to our standards][commit-style].\r\n\r\n> The only additional requirement is that the the PR number must appear in the\r\n> commit title in brackets: `(#XXX)`\r\n\r\n[commit-style]: https://github.com/aviabird/snitch/blob/develop/CONTRIBUTING.md#styling\r\n","created_at":"2018-09-03T11:31:52Z","updated_at":"2018-09-03T12:19:05Z","closed_at":"2018-09-03T12:19:05Z","merged_at":"2018-09-03T12:19:05Z","merge_commit_sha":"a024e7fd2491539ea53035203a172ecfecbff096","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pkrawat1","id":3807725,"node_id":"MDQ6VXNlcjM4MDc3MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/3807725?v=4","gravatar_id":"","url":"https://api.github.com/users/pkrawat1","html_url":"https://github.com/pkrawat1","followers_url":"https://api.github.com/users/pkrawat1/followers","following_url":"https://api.github.com/users/pkrawat1/following{/other_user}","gists_url":"https://api.github.com/users/pkrawat1/gists{/gist_id}","starred_url":"https://api.github.com/users/pkrawat1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkrawat1/subscriptions","organizations_url":"https://api.github.com/users/pkrawat1/orgs","repos_url":"https://api.github.com/users/pkrawat1/repos","events_url":"https://api.github.com/users/pkrawat1/events{/privacy}","received_events_url":"https://api.github.com/users/pkrawat1/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aviabird/snitch/pulls/167/commits","review_comments_url":"https://api.github.com/repos/aviabird/snitch/pulls/167/comments","review_comment_url":"https://api.github.com/repos/aviabird/snitch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aviabird/snitch/issues/167/comments","statuses_url":"https://api.github.com/repos/aviabird/snitch/statuses/b5baaed4b575ee3092592b23b27715e770b8a078","head":{"label":"aviabird:brands-image","ref":"brands-image","sha":"b5baaed4b575ee3092592b23b27715e770b8a078","user":{"login":"aviabird","id":22424801,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDI0ODAx","avatar_url":"https://avatars3.githubusercontent.com/u/22424801?v=4","gravatar_id":"","url":"https://api.github.com/users/aviabird","html_url":"https://github.com/aviabird","followers_url":"https://api.github.com/users/aviabird/followers","following_url":"https://api.github.com/users/aviabird/following{/other_user}","gists_url":"https://api.github.com/users/aviabird/gists{/gist_id}","starred_url":"https://api.github.com/users/aviabird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aviabird/subscriptions","organizations_url":"https://api.github.com/users/aviabird/orgs","repos_url":"https://api.github.com/users/aviabird/repos","events_url":"https://api.github.com/users/aviabird/events{/privacy}","received_events_url":"https://api.github.com/users/aviabird/received_events","type":"Organization","site_admin":false},"repo":{"id":121001913,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEwMDE5MTM=","name":"snitch","full_name":"aviabird/snitch","owner":{"login":"aviabird","id":22424801,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDI0ODAx","avatar_url":"https://avatars3.githubusercontent.com/u/22424801?v=4","gravatar_id":"","url":"https://api.github.com/users/aviabird","html_url":"https://github.com/aviabird","followers_url":"https://api.github.com/users/aviabird/followers","following_url":"https://api.github.com/users/aviabird/following{/other_user}","gists_url":"https://api.github.com/users/aviabird/gists{/gist_id}","starred_url":"https://api.github.com/users/aviabird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aviabird/subscriptions","organizations_url":"https://api.github.com/users/aviabird/orgs","repos_url":"https://api.github.com/users/aviabird/repos","events_url":"https://api.github.com/users/aviabird/events{/privacy}","received_events_url":"https://api.github.com/users/aviabird/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aviabird/snitch","description":"E-Commerce re-invented in Elixir","fork":false,"url":"https://api.github.com/repos/aviabird/snitch","forks_url":"https://api.github.com/repos/aviabird/snitch/forks","keys_url":"https://api.github.com/repos/aviabird/snitch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aviabird/snitch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aviabird/snitch/teams","hooks_url":"https://api.github.com/repos/aviabird/snitch/hooks","issue_events_url":"https://api.github.com/repos/aviabird/snitch/issues/events{/number}","events_url":"https://api.github.com/repos/aviabird/snitch/events","assignees_url":"https://api.github.com/repos/aviabird/snitch/assignees{/user}","branches_url":"https://api.github.com/repos/aviabird/snitch/branches{/branch}","tags_url":"https://api.github.com/repos/aviabird/snitch/tags","blobs_url":"https://api.github.com/repos/aviabird/snitch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aviabird/snitch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aviabird/snitch/git/refs{/sha}","trees_url":"https://api.github.com/repos/aviabird/snitch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aviabird/snitch/statuses/{sha}","languages_url":"https://api.github.com/repos/aviabird/snitch/languages","stargazers_url":"https://api.github.com/repos/aviabird/snitch/stargazers","contributors_url":"https://api.github.com/repos/aviabird/snitch/contributors","subscribers_url":"https://api.github.com/repos/aviabird/snitch/subscribers","subscription_url":"https://api.github.com/repos/aviabird/snitch/subscription","commits_url":"https://api.github.com/repos/aviabird/snitch/commits{/sha}","git_commits_url":"https://api.github.com/repos/aviabird/snitch/git/commits{/sha}","comments_url":"https://api.github.com/repos/aviabird/snitch/comments{/number}","issue_comment_url":"https://api.github.com/repos/aviabird/snitch/issues/comments{/number}","contents_url":"https://api.github.com/repos/aviabird/snitch/contents/{+path}","compare_url":"https://api.github.com/repos/aviabird/snitch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aviabird/snitch/merges","archive_url":"https://api.github.com/repos/aviabird/snitch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aviabird/snitch/downloads","issues_url":"https://api.github.com/repos/aviabird/snitch/issues{/number}","pulls_url":"https://api.github.com/repos/aviabird/snitch/pulls{/number}","milestones_url":"https://api.github.com/repos/aviabird/snitch/milestones{/number}","notifications_url":"https://api.github.com/repos/aviabird/snitch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aviabird/snitch/labels{/name}","releases_url":"https://api.github.com/repos/aviabird/snitch/releases{/id}","deployments_url":"https://api.github.com/repos/aviabird/snitch/deployments","created_at":"2018-02-10T09:24:32Z","updated_at":"2018-09-03T10:12:32Z","pushed_at":"2018-09-03T12:19:05Z","git_url":"git://github.com/aviabird/snitch.git","ssh_url":"git@github.com:aviabird/snitch.git","clone_url":"https://github.com/aviabird/snitch.git","svn_url":"https://github.com/aviabird/snitch","homepage":"","size":1098,"stargazers_count":19,"watchers_count":19,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":23,"license":null,"forks":7,"open_issues":23,"watchers":19,"default_branch":"develop"}},"base":{"label":"aviabird:develop","ref":"develop","sha":"40505a3f3b06c87fec9c0d4c3b0c4f04196011f7","user":{"login":"aviabird","id":22424801,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDI0ODAx","avatar_url":"https://avatars3.githubusercontent.com/u/22424801?v=4","gravatar_id":"","url":"https://api.github.com/users/aviabird","html_url":"https://github.com/aviabird","followers_url":"https://api.github.com/users/aviabird/followers","following_url":"https://api.github.com/users/aviabird/following{/other_user}","gists_url":"https://api.github.com/users/aviabird/gists{/gist_id}","starred_url":"https://api.github.com/users/aviabird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aviabird/subscriptions","organizations_url":"https://api.github.com/users/aviabird/orgs","repos_url":"https://api.github.com/users/aviabird/repos","events_url":"https://api.github.com/users/aviabird/events{/privacy}","received_events_url":"https://api.github.com/users/aviabird/received_events","type":"Organization","site_admin":false},"repo":{"id":121001913,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEwMDE5MTM=","name":"snitch","full_name":"aviabird/snitch","owner":{"login":"aviabird","id":22424801,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDI0ODAx","avatar_url":"https://avatars3.githubusercontent.com/u/22424801?v=4","gravatar_id":"","url":"https://api.github.com/users/aviabird","html_url":"https://github.com/aviabird","followers_url":"https://api.github.com/users/aviabird/followers","following_url":"https://api.github.com/users/aviabird/following{/other_user}","gists_url":"https://api.github.com/users/aviabird/gists{/gist_id}","starred_url":"https://api.github.com/users/aviabird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aviabird/subscriptions","organizations_url":"https://api.github.com/users/aviabird/orgs","repos_url":"https://api.github.com/users/aviabird/repos","events_url":"https://api.github.com/users/aviabird/events{/privacy}","received_events_url":"https://api.github.com/users/aviabird/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aviabird/snitch","description":"E-Commerce re-invented in Elixir","fork":false,"url":"https://api.github.com/repos/aviabird/snitch","forks_url":"https://api.github.com/repos/aviabird/snitch/forks","keys_url":"https://api.github.com/repos/aviabird/snitch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aviabird/snitch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aviabird/snitch/teams","hooks_url":"https://api.github.com/repos/aviabird/snitch/hooks","issue_events_url":"https://api.github.com/repos/aviabird/snitch/issues/events{/number}","events_url":"https://api.github.com/repos/aviabird/snitch/events","assignees_url":"https://api.github.com/repos/aviabird/snitch/assignees{/user}","branches_url":"https://api.github.com/repos/aviabird/snitch/branches{/branch}","tags_url":"https://api.github.com/repos/aviabird/snitch/tags","blobs_url":"https://api.github.com/repos/aviabird/snitch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aviabird/snitch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aviabird/snitch/git/refs{/sha}","trees_url":"https://api.github.com/repos/aviabird/snitch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aviabird/snitch/statuses/{sha}","languages_url":"https://api.github.com/repos/aviabird/snitch/languages","stargazers_url":"https://api.github.com/repos/aviabird/snitch/stargazers","contributors_url":"https://api.github.com/repos/aviabird/snitch/contributors","subscribers_url":"https://api.github.com/repos/aviabird/snitch/subscribers","subscription_url":"https://api.github.com/repos/aviabird/snitch/subscription","commits_url":"https://api.github.com/repos/aviabird/snitch/commits{/sha}","git_commits_url":"https://api.github.com/repos/aviabird/snitch/git/commits{/sha}","comments_url":"https://api.github.com/repos/aviabird/snitch/comments{/number}","issue_comment_url":"https://api.github.com/repos/aviabird/snitch/issues/comments{/number}","contents_url":"https://api.github.com/repos/aviabird/snitch/contents/{+path}","compare_url":"https://api.github.com/repos/aviabird/snitch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aviabird/snitch/merges","archive_url":"https://api.github.com/repos/aviabird/snitch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aviabird/snitch/downloads","issues_url":"https://api.github.com/repos/aviabird/snitch/issues{/number}","pulls_url":"https://api.github.com/repos/aviabird/snitch/pulls{/number}","milestones_url":"https://api.github.com/repos/aviabird/snitch/milestones{/number}","notifications_url":"https://api.github.com/repos/aviabird/snitch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aviabird/snitch/labels{/name}","releases_url":"https://api.github.com/repos/aviabird/snitch/releases{/id}","deployments_url":"https://api.github.com/repos/aviabird/snitch/deployments","created_at":"2018-02-10T09:24:32Z","updated_at":"2018-09-03T10:12:32Z","pushed_at":"2018-09-03T12:19:05Z","git_url":"git://github.com/aviabird/snitch.git","ssh_url":"git@github.com:aviabird/snitch.git","clone_url":"https://github.com/aviabird/snitch.git","svn_url":"https://github.com/aviabird/snitch","homepage":"","size":1098,"stargazers_count":19,"watchers_count":19,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":23,"license":null,"forks":7,"open_issues":23,"watchers":19,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/aviabird/snitch/pulls/167"},"html":{"href":"https://github.com/aviabird/snitch/pull/167"},"issue":{"href":"https://api.github.com/repos/aviabird/snitch/issues/167"},"comments":{"href":"https://api.github.com/repos/aviabird/snitch/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/aviabird/snitch/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/aviabird/snitch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aviabird/snitch/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/aviabird/snitch/statuses/b5baaed4b575ee3092592b23b27715e770b8a078"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"SagarKarwande","id":12864766,"node_id":"MDQ6VXNlcjEyODY0NzY2","avatar_url":"https://avatars1.githubusercontent.com/u/12864766?v=4","gravatar_id":"","url":"https://api.github.com/users/SagarKarwande","html_url":"https://github.com/SagarKarwande","followers_url":"https://api.github.com/users/SagarKarwande/followers","following_url":"https://api.github.com/users/SagarKarwande/following{/other_user}","gists_url":"https://api.github.com/users/SagarKarwande/gists{/gist_id}","starred_url":"https://api.github.com/users/SagarKarwande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SagarKarwande/subscriptions","organizations_url":"https://api.github.com/users/SagarKarwande/orgs","repos_url":"https://api.github.com/users/SagarKarwande/repos","events_url":"https://api.github.com/users/SagarKarwande/events{/privacy}","received_events_url":"https://api.github.com/users/SagarKarwande/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":235,"deletions":22,"changed_files":10}}
{"actor":{"display_login":"SagarKarwande"}}