{"action":"created","comment":{"url":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/comments/215343808","pull_request_review_id":152556878,"id":215343808,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTM0MzgwOA==","diff_hunk":"@@ -25,11 +26,6 @@ def essays(info=None):\n @before_request\n def submit_essay(info=None):\n     formdata = request.form\n-    packet = Packet.query.filter_by(freshman_username=info['uid']).first()\n-\n-    packet.info_eboard = formdata['info_eboard']\n-    packet.info_events = formdata['info_events']\n-    packet.info_achieve = formdata['info_achieve']\n-    db.session.commit()\n-\n-    return redirect(\"/essays\", 302)\n+    if set_requirements(info['uid'], formdata['info_eboard'], formdata['info_events'], formdata['info_achieve']):\n+        return redirect(\"/essays\", 302)\n+    return redirect(\"/essays\", 500)","path":"packet/routes/freshmen.py","position":22,"original_position":22,"commit_id":"43bbe61052f31ad198477bd34d0002de5e2bdff4","original_commit_id":"43bbe61052f31ad198477bd34d0002de5e2bdff4","user":{"login":"JoelEager","id":14286106,"node_id":"MDQ6VXNlcjE0Mjg2MTA2","avatar_url":"https://avatars3.githubusercontent.com/u/14286106?v=4","gravatar_id":"","url":"https://api.github.com/users/JoelEager","html_url":"https://github.com/JoelEager","followers_url":"https://api.github.com/users/JoelEager/followers","following_url":"https://api.github.com/users/JoelEager/following{/other_user}","gists_url":"https://api.github.com/users/JoelEager/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelEager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelEager/subscriptions","organizations_url":"https://api.github.com/users/JoelEager/orgs","repos_url":"https://api.github.com/users/JoelEager/repos","events_url":"https://api.github.com/users/JoelEager/events{/privacy}","received_events_url":"https://api.github.com/users/JoelEager/received_events","type":"User","site_admin":false},"body":"If `set_requirements` fails you're going to get an exception, not a non-true return value. Could you refactor this to better handle those failure cases?","created_at":"2018-09-05T16:39:35Z","updated_at":"2018-09-05T16:42:43Z","html_url":"https://github.com/ComputerScienceHouse/packet/pull/51#discussion_r215343808","pull_request_url":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/51","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/comments/215343808"},"html":{"href":"https://github.com/ComputerScienceHouse/packet/pull/51#discussion_r215343808"},"pull_request":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/51","id":213029268,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMDI5MjY4","html_url":"https://github.com/ComputerScienceHouse/packet/pull/51","diff_url":"https://github.com/ComputerScienceHouse/packet/pull/51.diff","patch_url":"https://github.com/ComputerScienceHouse/packet/pull/51.patch","issue_url":"https://api.github.com/repos/ComputerScienceHouse/packet/issues/51","number":51,"state":"open","locked":false,"title":"SQL/Calculation Perfomance Enhancements","user":{"login":"zedoax","id":9372283,"node_id":"MDQ6VXNlcjkzNzIyODM=","avatar_url":"https://avatars1.githubusercontent.com/u/9372283?v=4","gravatar_id":"","url":"https://api.github.com/users/zedoax","html_url":"https://github.com/zedoax","followers_url":"https://api.github.com/users/zedoax/followers","following_url":"https://api.github.com/users/zedoax/following{/other_user}","gists_url":"https://api.github.com/users/zedoax/gists{/gist_id}","starred_url":"https://api.github.com/users/zedoax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zedoax/subscriptions","organizations_url":"https://api.github.com/users/zedoax/orgs","repos_url":"https://api.github.com/users/zedoax/repos","events_url":"https://api.github.com/users/zedoax/events{/privacy}","received_events_url":"https://api.github.com/users/zedoax/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-04T16:06:37Z","updated_at":"2018-09-05T16:42:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f4021fc2edf084d76d4411598b79e107553e266","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/51/commits","review_comments_url":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/51/comments","review_comment_url":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ComputerScienceHouse/packet/issues/51/comments","statuses_url":"https://api.github.com/repos/ComputerScienceHouse/packet/statuses/43bbe61052f31ad198477bd34d0002de5e2bdff4","head":{"label":"zedoax:develop","ref":"develop","sha":"43bbe61052f31ad198477bd34d0002de5e2bdff4","user":{"login":"zedoax","id":9372283,"node_id":"MDQ6VXNlcjkzNzIyODM=","avatar_url":"https://avatars1.githubusercontent.com/u/9372283?v=4","gravatar_id":"","url":"https://api.github.com/users/zedoax","html_url":"https://github.com/zedoax","followers_url":"https://api.github.com/users/zedoax/followers","following_url":"https://api.github.com/users/zedoax/following{/other_user}","gists_url":"https://api.github.com/users/zedoax/gists{/gist_id}","starred_url":"https://api.github.com/users/zedoax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zedoax/subscriptions","organizations_url":"https://api.github.com/users/zedoax/orgs","repos_url":"https://api.github.com/users/zedoax/repos","events_url":"https://api.github.com/users/zedoax/events{/privacy}","received_events_url":"https://api.github.com/users/zedoax/received_events","type":"User","site_admin":false},"repo":{"id":146299878,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYyOTk4Nzg=","name":"packet","full_name":"zedoax/packet","owner":{"login":"zedoax","id":9372283,"node_id":"MDQ6VXNlcjkzNzIyODM=","avatar_url":"https://avatars1.githubusercontent.com/u/9372283?v=4","gravatar_id":"","url":"https://api.github.com/users/zedoax","html_url":"https://github.com/zedoax","followers_url":"https://api.github.com/users/zedoax/followers","following_url":"https://api.github.com/users/zedoax/following{/other_user}","gists_url":"https://api.github.com/users/zedoax/gists{/gist_id}","starred_url":"https://api.github.com/users/zedoax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zedoax/subscriptions","organizations_url":"https://api.github.com/users/zedoax/orgs","repos_url":"https://api.github.com/users/zedoax/repos","events_url":"https://api.github.com/users/zedoax/events{/privacy}","received_events_url":"https://api.github.com/users/zedoax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zedoax/packet","description":"Web packet written in Python for Computer Science House","fork":true,"url":"https://api.github.com/repos/zedoax/packet","forks_url":"https://api.github.com/repos/zedoax/packet/forks","keys_url":"https://api.github.com/repos/zedoax/packet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zedoax/packet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zedoax/packet/teams","hooks_url":"https://api.github.com/repos/zedoax/packet/hooks","issue_events_url":"https://api.github.com/repos/zedoax/packet/issues/events{/number}","events_url":"https://api.github.com/repos/zedoax/packet/events","assignees_url":"https://api.github.com/repos/zedoax/packet/assignees{/user}","branches_url":"https://api.github.com/repos/zedoax/packet/branches{/branch}","tags_url":"https://api.github.com/repos/zedoax/packet/tags","blobs_url":"https://api.github.com/repos/zedoax/packet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zedoax/packet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zedoax/packet/git/refs{/sha}","trees_url":"https://api.github.com/repos/zedoax/packet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zedoax/packet/statuses/{sha}","languages_url":"https://api.github.com/repos/zedoax/packet/languages","stargazers_url":"https://api.github.com/repos/zedoax/packet/stargazers","contributors_url":"https://api.github.com/repos/zedoax/packet/contributors","subscribers_url":"https://api.github.com/repos/zedoax/packet/subscribers","subscription_url":"https://api.github.com/repos/zedoax/packet/subscription","commits_url":"https://api.github.com/repos/zedoax/packet/commits{/sha}","git_commits_url":"https://api.github.com/repos/zedoax/packet/git/commits{/sha}","comments_url":"https://api.github.com/repos/zedoax/packet/comments{/number}","issue_comment_url":"https://api.github.com/repos/zedoax/packet/issues/comments{/number}","contents_url":"https://api.github.com/repos/zedoax/packet/contents/{+path}","compare_url":"https://api.github.com/repos/zedoax/packet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zedoax/packet/merges","archive_url":"https://api.github.com/repos/zedoax/packet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zedoax/packet/downloads","issues_url":"https://api.github.com/repos/zedoax/packet/issues{/number}","pulls_url":"https://api.github.com/repos/zedoax/packet/pulls{/number}","milestones_url":"https://api.github.com/repos/zedoax/packet/milestones{/number}","notifications_url":"https://api.github.com/repos/zedoax/packet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zedoax/packet/labels{/name}","releases_url":"https://api.github.com/repos/zedoax/packet/releases{/id}","deployments_url":"https://api.github.com/repos/zedoax/packet/deployments","created_at":"2018-08-27T13:17:03Z","updated_at":"2018-09-03T07:48:37Z","pushed_at":"2018-09-04T22:40:37Z","git_url":"git://github.com/zedoax/packet.git","ssh_url":"git@github.com:zedoax/packet.git","clone_url":"https://github.com/zedoax/packet.git","svn_url":"https://github.com/zedoax/packet","homepage":null,"size":194,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ComputerScienceHouse:develop","ref":"develop","sha":"d0274042ad4df3b4b374a863b4d23e8bfa3a1c01","user":{"login":"ComputerScienceHouse","id":318130,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODEzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/318130?v=4","gravatar_id":"","url":"https://api.github.com/users/ComputerScienceHouse","html_url":"https://github.com/ComputerScienceHouse","followers_url":"https://api.github.com/users/ComputerScienceHouse/followers","following_url":"https://api.github.com/users/ComputerScienceHouse/following{/other_user}","gists_url":"https://api.github.com/users/ComputerScienceHouse/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputerScienceHouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputerScienceHouse/subscriptions","organizations_url":"https://api.github.com/users/ComputerScienceHouse/orgs","repos_url":"https://api.github.com/users/ComputerScienceHouse/repos","events_url":"https://api.github.com/users/ComputerScienceHouse/events{/privacy}","received_events_url":"https://api.github.com/users/ComputerScienceHouse/received_events","type":"Organization","site_admin":false},"repo":{"id":101905179,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE5MDUxNzk=","name":"packet","full_name":"ComputerScienceHouse/packet","owner":{"login":"ComputerScienceHouse","id":318130,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODEzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/318130?v=4","gravatar_id":"","url":"https://api.github.com/users/ComputerScienceHouse","html_url":"https://github.com/ComputerScienceHouse","followers_url":"https://api.github.com/users/ComputerScienceHouse/followers","following_url":"https://api.github.com/users/ComputerScienceHouse/following{/other_user}","gists_url":"https://api.github.com/users/ComputerScienceHouse/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputerScienceHouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputerScienceHouse/subscriptions","organizations_url":"https://api.github.com/users/ComputerScienceHouse/orgs","repos_url":"https://api.github.com/users/ComputerScienceHouse/repos","events_url":"https://api.github.com/users/ComputerScienceHouse/events{/privacy}","received_events_url":"https://api.github.com/users/ComputerScienceHouse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ComputerScienceHouse/packet","description":"Web packet written in Python for Computer Science House","fork":false,"url":"https://api.github.com/repos/ComputerScienceHouse/packet","forks_url":"https://api.github.com/repos/ComputerScienceHouse/packet/forks","keys_url":"https://api.github.com/repos/ComputerScienceHouse/packet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ComputerScienceHouse/packet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ComputerScienceHouse/packet/teams","hooks_url":"https://api.github.com/repos/ComputerScienceHouse/packet/hooks","issue_events_url":"https://api.github.com/repos/ComputerScienceHouse/packet/issues/events{/number}","events_url":"https://api.github.com/repos/ComputerScienceHouse/packet/events","assignees_url":"https://api.github.com/repos/ComputerScienceHouse/packet/assignees{/user}","branches_url":"https://api.github.com/repos/ComputerScienceHouse/packet/branches{/branch}","tags_url":"https://api.github.com/repos/ComputerScienceHouse/packet/tags","blobs_url":"https://api.github.com/repos/ComputerScienceHouse/packet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ComputerScienceHouse/packet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ComputerScienceHouse/packet/git/refs{/sha}","trees_url":"https://api.github.com/repos/ComputerScienceHouse/packet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ComputerScienceHouse/packet/statuses/{sha}","languages_url":"https://api.github.com/repos/ComputerScienceHouse/packet/languages","stargazers_url":"https://api.github.com/repos/ComputerScienceHouse/packet/stargazers","contributors_url":"https://api.github.com/repos/ComputerScienceHouse/packet/contributors","subscribers_url":"https://api.github.com/repos/ComputerScienceHouse/packet/subscribers","subscription_url":"https://api.github.com/repos/ComputerScienceHouse/packet/subscription","commits_url":"https://api.github.com/repos/ComputerScienceHouse/packet/commits{/sha}","git_commits_url":"https://api.github.com/repos/ComputerScienceHouse/packet/git/commits{/sha}","comments_url":"https://api.github.com/repos/ComputerScienceHouse/packet/comments{/number}","issue_comment_url":"https://api.github.com/repos/ComputerScienceHouse/packet/issues/comments{/number}","contents_url":"https://api.github.com/repos/ComputerScienceHouse/packet/contents/{+path}","compare_url":"https://api.github.com/repos/ComputerScienceHouse/packet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ComputerScienceHouse/packet/merges","archive_url":"https://api.github.com/repos/ComputerScienceHouse/packet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ComputerScienceHouse/packet/downloads","issues_url":"https://api.github.com/repos/ComputerScienceHouse/packet/issues{/number}","pulls_url":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls{/number}","milestones_url":"https://api.github.com/repos/ComputerScienceHouse/packet/milestones{/number}","notifications_url":"https://api.github.com/repos/ComputerScienceHouse/packet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ComputerScienceHouse/packet/labels{/name}","releases_url":"https://api.github.com/repos/ComputerScienceHouse/packet/releases{/id}","deployments_url":"https://api.github.com/repos/ComputerScienceHouse/packet/deployments","created_at":"2017-08-30T16:38:00Z","updated_at":"2018-09-05T14:14:04Z","pushed_at":"2018-09-05T16:10:38Z","git_url":"git://github.com/ComputerScienceHouse/packet.git","ssh_url":"git@github.com:ComputerScienceHouse/packet.git","clone_url":"https://github.com/ComputerScienceHouse/packet.git","svn_url":"https://github.com/ComputerScienceHouse/packet","homepage":null,"size":181,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":12,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/51"},"html":{"href":"https://github.com/ComputerScienceHouse/packet/pull/51"},"issue":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/issues/51"},"comments":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/ComputerScienceHouse/packet/statuses/43bbe61052f31ad198477bd34d0002de5e2bdff4"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"JoelEager"}}