{"action":"created","issue":{"url":"https://api.github.com/repos/github/linguist/issues/4054","repository_url":"https://api.github.com/repos/github/linguist","labels_url":"https://api.github.com/repos/github/linguist/issues/4054/labels{/name}","comments_url":"https://api.github.com/repos/github/linguist/issues/4054/comments","events_url":"https://api.github.com/repos/github/linguist/issues/4054/events","html_url":"https://github.com/github/linguist/pull/4054","id":301509821,"number":4054,"title":"Add script to alphabetise submodule list","user":{"login":"Alhadis","id":2346707,"avatar_url":"https://avatars0.githubusercontent.com/u/2346707?v=4","gravatar_id":"","url":"https://api.github.com/users/Alhadis","html_url":"https://github.com/Alhadis","followers_url":"https://api.github.com/users/Alhadis/followers","following_url":"https://api.github.com/users/Alhadis/following{/other_user}","gists_url":"https://api.github.com/users/Alhadis/gists{/gist_id}","starred_url":"https://api.github.com/users/Alhadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alhadis/subscriptions","organizations_url":"https://api.github.com/users/Alhadis/orgs","repos_url":"https://api.github.com/users/Alhadis/repos","events_url":"https://api.github.com/users/Alhadis/events{/privacy}","received_events_url":"https://api.github.com/users/Alhadis/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-01T18:25:29Z","updated_at":"2018-03-02T13:46:43Z","closed_at":"2018-03-02T09:33:10Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/github/linguist/pulls/4054","html_url":"https://github.com/github/linguist/pull/4054","diff_url":"https://github.com/github/linguist/pull/4054.diff","patch_url":"https://github.com/github/linguist/pull/4054.patch"},"body":"This PR adds a script to sort the contents of [`.gitmodules`](https://github.com/github/linguist/blob/master/.gitmodules) each time a new grammar is added.\r\n\r\n## Description\r\nWe see this all the time:\r\n\r\n<img src=\"https://user-images.githubusercontent.com/2346707/36861794-103c1acc-1dd9-11e8-908a-5b2bf59a6567.png\" width=\"706\" />\r\n\r\nThis happens because newly-registered submodules are always added at the very bottom of the `.gitmodules` file, meaning that merging one PR usually blocks the next one until the submitter has resolved conflicts manually. This slows everybody down: a user has to fix the conflicts themselves, then @lildude needs to approve the changes later.\r\n\r\nWe can remedy this simply by forcing the submodule list to be alphabetised (case-sensitively). A test has been added to ensure that manually-added modules still get ordered correctly.\r\n\r\nAs of this writing, there are currently nine PRs sitting open which have conflicting module-lists: [`#4030`](https://github.com/github/linguist/pull/4030#partial-timeline-marker), [`#4005`](https://github.com/github/linguist/pull/4005#partial-timeline-marker), [`#3983`](https://github.com/github/linguist/pull/3983#partial-timeline-marker), [`#3869`](https://github.com/github/linguist/pull/3869#partial-timeline-marker), [`#3802`](https://github.com/github/linguist/pull/3802#partial-timeline-marker), [`#3772`](https://github.com/github/linguist/pull/3772#partial-timeline-marker), [`#3764`](https://github.com/github/linguist/pull/3764#partial-timeline-marker), [`#3689`](https://github.com/github/linguist/pull/3689#partial-timeline-marker), [`#3720`](https://github.com/github/linguist/pull/3720#partial-timeline-marker).\r\n\r\nI haven't even bothered to count how many that are *closed* which have had similar conflicts. :wink: \r\n\r\n## Checklist:\r\n- [X] **I am adding new or changing current functionality**\r\n  - [X] I have added or updated the tests for the new or changed functionality.\r\n"},"comment":{"url":"https://api.github.com/repos/github/linguist/issues/comments/369924675","html_url":"https://github.com/github/linguist/pull/4054#issuecomment-369924675","issue_url":"https://api.github.com/repos/github/linguist/issues/4054","id":369924675,"user":{"login":"Alhadis","id":2346707,"avatar_url":"https://avatars0.githubusercontent.com/u/2346707?v=4","gravatar_id":"","url":"https://api.github.com/users/Alhadis","html_url":"https://github.com/Alhadis","followers_url":"https://api.github.com/users/Alhadis/followers","following_url":"https://api.github.com/users/Alhadis/following{/other_user}","gists_url":"https://api.github.com/users/Alhadis/gists{/gist_id}","starred_url":"https://api.github.com/users/Alhadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alhadis/subscriptions","organizations_url":"https://api.github.com/users/Alhadis/orgs","repos_url":"https://api.github.com/users/Alhadis/repos","events_url":"https://api.github.com/users/Alhadis/events{/privacy}","received_events_url":"https://api.github.com/users/Alhadis/received_events","type":"User","site_admin":false},"created_at":"2018-03-02T13:46:43Z","updated_at":"2018-03-02T13:46:43Z","author_association":"COLLABORATOR","body":"Done. :wink: See #4056."}}
{"actor":{"display_login":"Alhadis"}}