{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/234075074","pull_request_review_id":175639295,"id":234075074,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDA3NTA3NA==","diff_hunk":"@@ -14,7 +14,6 @@\n #include <util/system.h>\n #include <util/strencodings.h>\n \n-#include <boost/bind.hpp>","path":"src/rpc/server.cpp","position":4,"original_position":4,"commit_id":"77aab9dd27ccda6cac650713390065f32c464aef","original_commit_id":"77aab9dd27ccda6cac650713390065f32c464aef","user":{"login":"MarcoFalke","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"body":"Same","created_at":"2018-11-16T02:37:18Z","updated_at":"2018-11-16T02:38:28Z","html_url":"https://github.com/bitcoin/bitcoin/pull/14718#discussion_r234075074","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14718","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/234075074"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/14718#discussion_r234075074"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14718"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14718","id":230464839,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNDY0ODM5","html_url":"https://github.com/bitcoin/bitcoin/pull/14718","diff_url":"https://github.com/bitcoin/bitcoin/pull/14718.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/14718.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14718","number":14718,"state":"open","locked":false,"title":"Remove unreferenced boost headers","user":{"login":"murrayn","id":5404807,"node_id":"MDQ6VXNlcjU0MDQ4MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/5404807?v=4","gravatar_id":"","url":"https://api.github.com/users/murrayn","html_url":"https://github.com/murrayn","followers_url":"https://api.github.com/users/murrayn/followers","following_url":"https://api.github.com/users/murrayn/following{/other_user}","gists_url":"https://api.github.com/users/murrayn/gists{/gist_id}","starred_url":"https://api.github.com/users/murrayn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murrayn/subscriptions","organizations_url":"https://api.github.com/users/murrayn/orgs","repos_url":"https://api.github.com/users/murrayn/repos","events_url":"https://api.github.com/users/murrayn/events{/privacy}","received_events_url":"https://api.github.com/users/murrayn/received_events","type":"User","site_admin":false},"body":"Building with clang (e.g. on FreeBSD) is very noisy due to `-Wthread-safety-analysis` warnings regarding boost. This change removes a number of unnecessary boost includes, and silences the rest of the warnings when building with clang. This allows more potentially interesting warnings to surface from the noise.\r\n\r\nTested on FreeBSD 11.2\r\n","created_at":"2018-11-13T12:55:25Z","updated_at":"2018-11-16T02:38:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb413d75baad96424c70d3687675c964dcc7c573","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":135961,"node_id":"MDU6TGFiZWwxMzU5NjE=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Refactoring","name":"Refactoring","color":"E6F6D6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14718/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14718/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14718/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/77aab9dd27ccda6cac650713390065f32c464aef","head":{"label":"murrayn:clang_warnings","ref":"clang_warnings","sha":"77aab9dd27ccda6cac650713390065f32c464aef","user":{"login":"murrayn","id":5404807,"node_id":"MDQ6VXNlcjU0MDQ4MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/5404807?v=4","gravatar_id":"","url":"https://api.github.com/users/murrayn","html_url":"https://github.com/murrayn","followers_url":"https://api.github.com/users/murrayn/followers","following_url":"https://api.github.com/users/murrayn/following{/other_user}","gists_url":"https://api.github.com/users/murrayn/gists{/gist_id}","starred_url":"https://api.github.com/users/murrayn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murrayn/subscriptions","organizations_url":"https://api.github.com/users/murrayn/orgs","repos_url":"https://api.github.com/users/murrayn/repos","events_url":"https://api.github.com/users/murrayn/events{/privacy}","received_events_url":"https://api.github.com/users/murrayn/received_events","type":"User","site_admin":false},"repo":{"id":119793914,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk3OTM5MTQ=","name":"bitcoin","full_name":"murrayn/bitcoin","private":false,"owner":{"login":"murrayn","id":5404807,"node_id":"MDQ6VXNlcjU0MDQ4MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/5404807?v=4","gravatar_id":"","url":"https://api.github.com/users/murrayn","html_url":"https://github.com/murrayn","followers_url":"https://api.github.com/users/murrayn/followers","following_url":"https://api.github.com/users/murrayn/following{/other_user}","gists_url":"https://api.github.com/users/murrayn/gists{/gist_id}","starred_url":"https://api.github.com/users/murrayn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murrayn/subscriptions","organizations_url":"https://api.github.com/users/murrayn/orgs","repos_url":"https://api.github.com/users/murrayn/repos","events_url":"https://api.github.com/users/murrayn/events{/privacy}","received_events_url":"https://api.github.com/users/murrayn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/murrayn/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/murrayn/bitcoin","forks_url":"https://api.github.com/repos/murrayn/bitcoin/forks","keys_url":"https://api.github.com/repos/murrayn/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/murrayn/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/murrayn/bitcoin/teams","hooks_url":"https://api.github.com/repos/murrayn/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/murrayn/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/murrayn/bitcoin/events","assignees_url":"https://api.github.com/repos/murrayn/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/murrayn/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/murrayn/bitcoin/tags","blobs_url":"https://api.github.com/repos/murrayn/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/murrayn/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/murrayn/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/murrayn/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/murrayn/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/murrayn/bitcoin/languages","stargazers_url":"https://api.github.com/repos/murrayn/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/murrayn/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/murrayn/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/murrayn/bitcoin/subscription","commits_url":"https://api.github.com/repos/murrayn/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/murrayn/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/murrayn/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/murrayn/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/murrayn/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/murrayn/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/murrayn/bitcoin/merges","archive_url":"https://api.github.com/repos/murrayn/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/murrayn/bitcoin/downloads","issues_url":"https://api.github.com/repos/murrayn/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/murrayn/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/murrayn/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/murrayn/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/murrayn/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/murrayn/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/murrayn/bitcoin/deployments","created_at":"2018-02-01T06:32:56Z","updated_at":"2018-11-13T07:09:03Z","pushed_at":"2018-11-15T23:42:20Z","git_url":"git://github.com/murrayn/bitcoin.git","ssh_url":"git@github.com:murrayn/bitcoin.git","clone_url":"https://github.com/murrayn/bitcoin.git","svn_url":"https://github.com/murrayn/bitcoin","homepage":"https://bitcoin.org/en/download","size":113954,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"384967f311b4c6b1d6c797f7821d25feb26bafbf","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-11-16T02:36:46Z","pushed_at":"2018-11-16T01:47:50Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":116677,"stargazers_count":35901,"watchers_count":35901,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":21381,"mirror_url":null,"archived":false,"open_issues_count":858,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21381,"open_issues":858,"watchers":35901,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14718"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/14718"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/14718"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/14718/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14718/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14718/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/77aab9dd27ccda6cac650713390065f32c464aef"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MarcoFalke"}}