{"action":"created","issue":{"url":"https://api.github.com/repos/pysal/libpysal/issues/97","repository_url":"https://api.github.com/repos/pysal/libpysal","labels_url":"https://api.github.com/repos/pysal/libpysal/issues/97/labels{/name}","comments_url":"https://api.github.com/repos/pysal/libpysal/issues/97/comments","events_url":"https://api.github.com/repos/pysal/libpysal/issues/97/events","html_url":"https://github.com/pysal/libpysal/issues/97","id":350934935,"node_id":"MDU6SXNzdWUzNTA5MzQ5MzU=","number":97,"title":"[ENH] should `weights.util.get_ids()` also accept a geodataframe?","user":{"login":"jGaboardi","id":8590583,"node_id":"MDQ6VXNlcjg1OTA1ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/8590583?v=4","gravatar_id":"","url":"https://api.github.com/users/jGaboardi","html_url":"https://github.com/jGaboardi","followers_url":"https://api.github.com/users/jGaboardi/followers","following_url":"https://api.github.com/users/jGaboardi/following{/other_user}","gists_url":"https://api.github.com/users/jGaboardi/gists{/gist_id}","starred_url":"https://api.github.com/users/jGaboardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jGaboardi/subscriptions","organizations_url":"https://api.github.com/users/jGaboardi/orgs","repos_url":"https://api.github.com/users/jGaboardi/repos","events_url":"https://api.github.com/users/jGaboardi/events{/privacy}","received_events_url":"https://api.github.com/users/jGaboardi/received_events","type":"User","site_admin":false},"labels":[{"id":536186559,"node_id":"MDU6TGFiZWw1MzYxODY1NTk=","url":"https://api.github.com/repos/pysal/libpysal/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":1027252531,"node_id":"MDU6TGFiZWwxMDI3MjUyNTMx","url":"https://api.github.com/repos/pysal/libpysal/labels/needs%20testing","name":"needs testing","color":"f42c93","default":false}],"state":"open","locked":false,"assignee":{"login":"jGaboardi","id":8590583,"node_id":"MDQ6VXNlcjg1OTA1ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/8590583?v=4","gravatar_id":"","url":"https://api.github.com/users/jGaboardi","html_url":"https://github.com/jGaboardi","followers_url":"https://api.github.com/users/jGaboardi/followers","following_url":"https://api.github.com/users/jGaboardi/following{/other_user}","gists_url":"https://api.github.com/users/jGaboardi/gists{/gist_id}","starred_url":"https://api.github.com/users/jGaboardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jGaboardi/subscriptions","organizations_url":"https://api.github.com/users/jGaboardi/orgs","repos_url":"https://api.github.com/users/jGaboardi/repos","events_url":"https://api.github.com/users/jGaboardi/events{/privacy}","received_events_url":"https://api.github.com/users/jGaboardi/received_events","type":"User","site_admin":false},"assignees":[{"login":"jGaboardi","id":8590583,"node_id":"MDQ6VXNlcjg1OTA1ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/8590583?v=4","gravatar_id":"","url":"https://api.github.com/users/jGaboardi","html_url":"https://github.com/jGaboardi","followers_url":"https://api.github.com/users/jGaboardi/followers","following_url":"https://api.github.com/users/jGaboardi/following{/other_user}","gists_url":"https://api.github.com/users/jGaboardi/gists{/gist_id}","starred_url":"https://api.github.com/users/jGaboardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jGaboardi/subscriptions","organizations_url":"https://api.github.com/users/jGaboardi/orgs","repos_url":"https://api.github.com/users/jGaboardi/repos","events_url":"https://api.github.com/users/jGaboardi/events{/privacy}","received_events_url":"https://api.github.com/users/jGaboardi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-08-15T19:27:50Z","updated_at":"2018-08-17T13:29:22Z","closed_at":null,"author_association":"MEMBER","body":"Would we like to have `get_ids(shapefile, idVariable)` in `libpysal.weights.util` also accept a `geopandas.GeoDataFrame` as a valid `arg` for `shapefile`? If so, I am willing to put a PR together."},"comment":{"url":"https://api.github.com/repos/pysal/libpysal/issues/comments/413866260","html_url":"https://github.com/pysal/libpysal/issues/97#issuecomment-413866260","issue_url":"https://api.github.com/repos/pysal/libpysal/issues/97","id":413866260,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzg2NjI2MA==","user":{"login":"jGaboardi","id":8590583,"node_id":"MDQ6VXNlcjg1OTA1ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/8590583?v=4","gravatar_id":"","url":"https://api.github.com/users/jGaboardi","html_url":"https://github.com/jGaboardi","followers_url":"https://api.github.com/users/jGaboardi/followers","following_url":"https://api.github.com/users/jGaboardi/following{/other_user}","gists_url":"https://api.github.com/users/jGaboardi/gists{/gist_id}","starred_url":"https://api.github.com/users/jGaboardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jGaboardi/subscriptions","organizations_url":"https://api.github.com/users/jGaboardi/orgs","repos_url":"https://api.github.com/users/jGaboardi/repos","events_url":"https://api.github.com/users/jGaboardi/events{/privacy}","received_events_url":"https://api.github.com/users/jGaboardi/received_events","type":"User","site_admin":false},"created_at":"2018-08-17T13:29:22Z","updated_at":"2018-08-17T13:29:22Z","author_association":"MEMBER","body":"@ljwolf are there any other specific tests I can put together other than [the one I already included](https://github.com/pysal/libpysal/pull/101/files#diff-3378068a2f75204ca6ff319938554ae2)?"}}
{"actor":{"display_login":"jGaboardi"}}